Timeline


and

06/01/09:

23:40 Changeset [44348] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-06-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler. Landed by Adam Barth.

Remove a redundant checkEncodedString call when constructing a
KURL object from a string.

  • platform/KURL.cpp: (WebCore::KURL::KURL):
22:59 Changeset [44347] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-01 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY - speculative windows build fix (errm, for the other patch!).

  • jit/JITStubs.cpp: (JSC::):
22:54 Changeset [44346] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-01 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY - speculative windows build fix.

  • assembler/AbstractMacroAssembler.h: (JSC::::CodeLocationCall::CodeLocationCall): (JSC::::CodeLocationNearCall::CodeLocationNearCall):
22:46 Changeset [44345] by ggaren@apple.com
  • 5 edits in branches/nitro-extreme

JavaScriptCore:

2009-06-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed some of the regression in crypto-aes.js. (8.5% speedup in
crypto-aes.js.)


SunSpider reports no change overall.


Division was producing double results, which took the slow path through
array access code.


Strangely, all my attempts at versions of this patch that modified array
access code to accept ints encoded as doubles along the fast or slow paths
were regressions. So I did this instead.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_div): When dividing an int by an int, go ahead and try to turn the result into an int. Don't just do int division, though, because testing shows it to be slower than SSE double division, and the corner cases are pretty complicated / lengthy on top of that. Also, don't try to canonicalize division of known tiny numerators into ints, since that's a waste of time.

LayoutTests:

2009-06-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Added test cases for some division edge cases I broke.

  • fast/js/arithmetic-expected.txt:
  • fast/js/resources/arithmetic.js: Also modified this test to avoid constant folding.
22:36 Changeset [44344] by barraclough@apple.com
  • 8 edits in trunk/JavaScriptCore

2009-06-01 Gavin Barraclough <barraclough@apple.com>

Reviewed by Olliej Hunt.

Change JITStub functions from being static members on the JITStub class to be
global extern "C" functions, and switch their the function signature declaration
in the definition of the functions to be C-macro generated. This makes it easier
to work with the stub functions from assembler code (since the names no longer
require mangling), and by delaring the functions with a macro we can look at
also auto-generating asm thunks to wrap the JITStub functions to perform the
work currently in 'restoreArgumentReference' (as a memory saving).

Making this change also forces us to be a bit more realistic about what is private
on the Register and CallFrame objects. Presently most everything on these classes
is private, and the classes have plenty of friends. We could befriend all the
global functions to perpetuate the delusion of encapsulation, but using friends is
a bit of a sledgehammer solution here - since friends can poke around with all of
the class's privates, and since all the major classes taht operate on Regsiters are
currently friends, right there is currently in practice very little protection at
all. Better to start removing friend delclarations, and exposing just the parts
that need to be exposed.

  • interpreter/CallFrame.h: (JSC::ExecState::returnPC): (JSC::ExecState::setCallerFrame): (JSC::ExecState::returnValueRegister): (JSC::ExecState::setArgumentCount): (JSC::ExecState::setCallee): (JSC::ExecState::setCodeBlock):
  • interpreter/Interpreter.h:
  • interpreter/Register.h: (JSC::Register::Register): (JSC::Register::i):
  • jit/JITStubs.cpp: (JSC::): (JSC::JITThunks::JITThunks): (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h: (JSC::JITStubs::):
  • runtime/JSFunction.h: (JSC::JSFunction::nativeFunction): (JSC::JSFunction::classInfo):
  • runtime/JSGlobalData.h:
21:40 Changeset [44343] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Tidy up the literal parser.

Reviewed by Gavin Barraclogh.

Make the number lexing in the LiteralParser exactly match the JSON spec, which
makes us cover more cases, but also more strict. Also made string lexing only
allow double-quoted strings.

20:03 Changeset [44342] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

Reposition platform guard, improperly placed by http://trac.webkit.org/changeset/44340
Bad Dimitri.

  • platform/KeyboardCodes.h: Repositioned the guard to avoid nested

WebCore namespace declarations.

18:20 Changeset [44341] by barraclough@apple.com
  • 10 edits in trunk/JavaScriptCore

2009-06-01 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam "WX" Weinig.

Allow the JIT to operate without relying on use of RWX memory, on platforms where this is supported.

This patch adds a switch to Platform.h (ENABLE_ASSEMBLER_WX_EXCLUSIVE) which enables this mode of operation.
When this flag is set, all executable memory will be allocated RX, and switched to RW only whilst being
modified. Upon completion of code generation the protection is switched back to RX to allow execution.

Further optimization will be required before it is desirable to enable this mode of operation by default;
enabling this presently incurs a 5%-10% regression.

(Submitting disabled - no performance impact).

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::CodeLocationInstruction::repatchLoadToLEA): (JSC::AbstractMacroAssembler::CodeLocationLabel::fromFunctionPointer): (JSC::AbstractMacroAssembler::CodeLocationJump::relink): (JSC::AbstractMacroAssembler::CodeLocationCall::relink): (JSC::AbstractMacroAssembler::CodeLocationNearCall::relink): (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch): (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkNearCallerToTrampoline): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkNearCallerToFunction): (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::~PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::patch): (JSC::AbstractMacroAssembler::PatchBuffer::performFinalization): (JSC::::CodeLocationCommon::nearCallAtOffset): (JSC::::CodeLocationCall::CodeLocationCall): (JSC::::CodeLocationNearCall::CodeLocationNearCall):
  • assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::executableCopy):
  • assembler/X86Assembler.h: (JSC::CAN_SIGN_EXTEND_U32_64): (JSC::X86Assembler::linkJump): (JSC::X86Assembler::linkCall): (JSC::X86Assembler::patchPointer): (JSC::X86Assembler::relinkJump): (JSC::X86Assembler::relinkCall): (JSC::X86Assembler::repatchInt32): (JSC::X86Assembler::repatchPointer): (JSC::X86Assembler::repatchLoadToLEA): (JSC::X86Assembler::patchInt32): (JSC::X86Assembler::patchRel32):
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::): (JSC::ExecutableAllocator::makeWritable): (JSC::ExecutableAllocator::makeExecutable):
  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
  • jit/ExecutableAllocatorPosix.cpp: (JSC::ExecutablePool::systemAlloc): (JSC::ExecutablePool::systemRelease): (JSC::ExecutableAllocator::reprotectRegion):
  • jit/ExecutableAllocatorWin.cpp:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace):
  • wtf/Platform.h:
16:48 Changeset [44340] by dglazkov@chromium.org
  • 2 edits
    1 delete in trunk/WebCore

2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

  • platform/KeyboardCodes.h: Integrated contents of platform/chromium/KeyboardCodes.h

with a stern FIXME.

  • platform/chromium/KeyboardCodes.h: Removed.
16:38 Changeset [44339] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

svn-create-patch displays confusing "Broken pipe" errors from Subversion
when files have been renamed in local working copy. This was happening
because we invoke 'svn info' to determine the URL that the file was copied
from, but we were closing the pipe to the subprocess before SVN had finished
writing its output.

Reviewed by Sam Weinig.

  • Scripts/prepare-ChangeLog: Consume all 'svn info' output before closing the file handle.
  • Scripts/svn-create-patch: Ditto.
16:09 Changeset [44338] by zimmermann@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Eric Seidel.

Fix assertion error in --filters enabled debug builds.
Instead of using RefPtr<AtomicStringImpl> as keys for the hash maps in SVGFilterBuilder, just use AtomicString objects.

15:20 Changeset [44337] by zimmermann@webkit.org
  • 10 edits in trunk/WebCore

Reviewed by Eric Seidel.

Fix --filters enabled build on Mac.
Remove unnecessary 'boundingBox' parameter from finishRenderSVGContent() method.
Kill several warnings, to make build pass.

15:19 Changeset [44336] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-29 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Inherits Interpreter class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/JSGlobalData.cpp.

  • interpreter/Interpreter.h:
14:52 Changeset [44335] by dglazkov@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

ChangeLog spelling, meaning fixes.

14:50 Changeset [44334] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Dave Hyatt.

Fix Chromium build by adding an #ifdef.

  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint): Added an #ifdef.
14:37 Changeset [44333] by kov@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-06-01 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Rubber-stamped by Gustavo Noronha.

Before guessing the url trim the string to remove whitespace added to the start/end by the user.

  • Api/qwebview.cpp: (QWebView::guessUrlFromString):
  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::guessUrlFromString_data):
14:28 Changeset [44332] by krit@webkit.org
  • 5 edits
    8 deletes in trunk/WebCore

2009-06-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Remove last pieces of the old SVG filte system. They are not
usable with our current filter system. The new filter effects
will replace the functionality step by step.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/graphics/cairo: Removed.
  • svg/graphics/cairo/SVGResourceFilterCairo.cpp: Removed.
  • svg/graphics/cg: Removed.
  • svg/graphics/cg/SVGResourceFilterCg.cpp: Removed.
  • svg/graphics/cg/SVGResourceFilterCg.mm: Removed.
  • svg/graphics/filters/SVGFilterEffect.cpp: Removed.
  • svg/graphics/filters/SVGFilterEffect.h: Removed.
  • svg/graphics/filters/cg: Removed.
  • svg/graphics/filters/cg/SVGFEHelpersCg.h: Removed.
  • svg/graphics/filters/cg/SVGFEHelpersCg.mm: Removed.
  • svg/graphics/filters/cg/SVGFilterEffectCg.mm: Removed.
  • svg/graphics/filters/cg/WKArithmeticFilter.cikernel: Removed.
  • svg/graphics/filters/cg/WKArithmeticFilter.h: Removed.
  • svg/graphics/filters/cg/WKArithmeticFilter.m: Removed.
  • svg/graphics/filters/cg/WKComponentMergeFilter.cikernel: Removed.
  • svg/graphics/filters/cg/WKComponentMergeFilter.h: Removed.
  • svg/graphics/filters/cg/WKComponentMergeFilter.m: Removed.
  • svg/graphics/filters/cg/WKDiffuseLightingFilter.cikernel: Removed.
  • svg/graphics/filters/cg/WKDiffuseLightingFilter.h: Removed.
  • svg/graphics/filters/cg/WKDiffuseLightingFilter.m: Removed.
  • svg/graphics/filters/cg/WKDiscreteTransferFilter.cikernel: Removed.
  • svg/graphics/filters/cg/WKDiscreteTransferFilter.h: Removed.
  • svg/graphics/filters/cg/WKDiscreteTransferFilter.m: Removed.
  • svg/graphics/filters/cg/WKDisplacementMapFilter.cikernel: Removed.
  • svg/graphics/filters/cg/WKDisplacementMapFilter.h: Removed.
  • svg/graphics/filters/cg/WKDisplacementMapFilter.m: Removed.
  • svg/graphics/filters/cg/WKDistantLightFilter.cikernel: Removed.
  • svg/graphics/filters/cg/WKDistantLightFilter.h: Removed.
  • svg/graphics/filters/cg/WKDistantLightFilter.m: Removed.
  • svg/graphics/filters/cg/WKGammaTransferFilter.cikernel: Removed.
  • svg/graphics/filters/cg/WKGammaTransferFilter.h: Removed.
  • svg/graphics/filters/cg/WKGammaTransferFilter.m: Removed.
  • svg/graphics/filters/cg/WKIdentityTransferFilter.h: Removed.
  • svg/graphics/filters/cg/WKIdentityTransferFilter.m: Removed.
  • svg/graphics/filters/cg/WKLinearTransferFilter.cikernel: Removed.
  • svg/graphics/filters/cg/WKLinearTransferFilter.h: Removed.
  • svg/graphics/filters/cg/WKLinearTransferFilter.m: Removed.
  • svg/graphics/filters/cg/WKNormalMapFilter.cikernel: Removed.
  • svg/graphics/filters/cg/WKNormalMapFilter.h: Removed.
  • svg/graphics/filters/cg/WKNormalMapFilter.m: Removed.
  • svg/graphics/filters/cg/WKPointLightFilter.cikernel: Removed.
  • svg/graphics/filters/cg/WKPointLightFilter.h: Removed.
  • svg/graphics/filters/cg/WKPointLightFilter.m: Removed.
  • svg/graphics/filters/cg/WKSpecularLightingFilter.cikernel: Removed.
  • svg/graphics/filters/cg/WKSpecularLightingFilter.h: Removed.
  • svg/graphics/filters/cg/WKSpecularLightingFilter.m: Removed.
  • svg/graphics/filters/cg/WKSpotLightFilter.cikernel: Removed.
  • svg/graphics/filters/cg/WKSpotLightFilter.h: Removed.
  • svg/graphics/filters/cg/WKSpotLightFilter.m: Removed.
  • svg/graphics/filters/cg/WKTableTransferFilter.cikernel: Removed.
  • svg/graphics/filters/cg/WKTableTransferFilter.h: Removed.
  • svg/graphics/filters/cg/WKTableTransferFilter.m: Removed.
  • svg/graphics/mac: Removed.
  • svg/graphics/mac/SVGResourceFilterPlatformDataMac.h: Removed.
  • svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm: Removed.
  • svg/graphics/qt: Removed.
  • svg/graphics/qt/SVGResourceFilterQt.cpp: Removed.
  • svg/graphics/skia: Removed.
  • svg/graphics/skia/SVGResourceFilterSkia.cpp: Removed.
14:05 Changeset [44331] by kov@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-06-01 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Rubber-stamped by Gustavo Noronha.

Use QLatin1Char() to compile when QT_NO_CAST_FROM_ASCII and QT_NO_CAST_TO_ASCII is defined

  • Api/qwebview.cpp: (QWebView::guessUrlFromString):
13:06 Changeset [44330] by kov@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-06-01 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Rubber-stamped by Gustavo Noronha.

Cleanup autotest file

  • use proper includes
  • remove useless constructor and destructor
  • add missing newline at the end of the file
  • tests/qwebview/tst_qwebview.cpp:
13:01 Changeset [44329] by kov@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-06-01 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Rubber-stamped by Gustavo Noronha.

Add a missing space between two words in the documentation.

  • Api/qwebview.cpp:
12:56 Changeset [44328] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-06-01 Dmitry Titov <dimich@chromium.org>

Fix the previous checkin (ttp://trac.webkit.org/changeset/44327).
This adds a comment suggested during review.

  • platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::~ThreadGlobalData): Add comment clarifying the change.
12:44 Changeset [44327] by dimich@chromium.org
  • 3 edits in trunk/WebCore

2009-06-01 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25973
Avoid calling CurrentThread() in thread-specific destructors in OSX Chromium.
Pthreads invoke thread-specific destructors after WTF::detachThread() is called and ThreadIdentifier
for the thread removed from the WTF thread map. Calling CurrentThread() in such destructor causes
the ThreadIdentifier to be re-created and inserted into the map again. Since Pthreads on OSX reuse
the pthread_t between threads, the next created thread will have the same pthread_t and cause an assert
in establishIdentifierForPthreadHandle() since the id is already in the map.

The behavior is covered by existing test LayoutTests/fast/workers/worker-terminate.html, which currently fails
on OSX Chromium and will stop failing after this change.

  • platform/ThreadGlobalData.h:
  • platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::~ThreadGlobalData): Store the result of "isMainThread()" in a member variable during construction of thread-specific data to avoid calling IsMainThread() in destructor, since the latter calls CurrentThread() in OSX Chromium.
12:18 Changeset [44326] by levin@chromium.org
  • 3 edits in trunk/JavaScriptCore

2009-06-01 David Levin <levin@chromium.org>

Reviewed by NOBODY (windows build fix).

Add exports for windows (corresponding to the JavaScriptCore.exp modification
in the previous change).

11:41 Changeset [44325] by levin@chromium.org
  • 9 edits in trunk

JavaScriptCore:

2009-06-01 David Levin <levin@chromium.org>

Reviewed by Darin Alder and Maciej Stachowiak.

Bug 26057: StringImpl should share buffers with UString.
https://bugs.webkit.org/show_bug.cgi?id=26057

  • JavaScriptCore.exp:
  • runtime/UString.cpp: (JSC::UString::Rep::create): (JSC::UString::BaseString::sharedBuffer): Only do the sharing when the buffer exceeds a certain size. The size was tuned by running various dom benchmarks with numbers ranging from 20 to 800 and finding a place that seemed to do the best overall.
  • runtime/UString.h:

WebCore:

2009-06-01 David Levin <levin@chromium.org>

Reviewed by Darin Alder and Maciej Stachowiak.

Bug 26057: StringImpl should share buffers with UString.
https://bugs.webkit.org/show_bug.cgi?id=26057

This change results in the following performance improvements:
On http://www.hixie.ch/tests/adhoc/perf/dom/artificial/core/001.html
the time went from 78ms to 40ms for append (other times remained constant).

On http://www.hixie.ch/tests/adhoc/perf/dom/artificial/core/002.html,
the time went from 3900ms to 2600ms.

For http://dromaeo.com/?dom, the time for DomModification improved by ~6%.
Other tests in dom seemed to be faster across several runs but within the
margin of error (except DOM Attributes which was slightly ~1.5% worse).

Existing tests cover this code and there is no new functionality
that is exposed to test.

  • platform/text/AtomicString.cpp: (WebCore::AtomicString::add):
  • platform/text/String.cpp: (WebCore::String::String): (WebCore::String::operator UString):
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): (WebCore::StringImpl::~StringImpl): (WebCore::StringImpl::create): Consumes a shared buffer. (WebCore::StringImpl::ustring): Shares the StringImpl's buffer with the UString. (WebCore::StringImpl::sharedBuffer): Exposes the buffer that may be shared.
  • platform/text/StringImpl.h: (WebCore::StringImpl::hasTerminatingNullCharacter): (WebCore::StringImpl::inTable): (WebCore::StringImpl::setInTable): Converted the bools to be inside of PtrAndFlags to avoid growing StringImpl in size.
10:35 WebKit Team edited by kov@webkit.org
(diff)
10:16 Changeset [44324] by bfulgham@webkit.org
  • 3 edits in trunk/WebKit/win

2009-06-01 Brent Fulgham <bfulgham@webkit.org>

Build fix for Cairo Windows target. Windows link definition
files were out of sync with the Apple Windows link files.

  • WebKit.vcproj/WebKit_Cairo.def:
  • WebKit.vcproj/WebKit_Cairo_debug.def:
09:53 Changeset [44323] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

V8 bindings follow-up to to DOMWindow-related cleanup:
http://trac.webkit.org/changeset/44215

  • bindings/v8/ScriptController.cpp: Removed disconnectFrame(), relocated

its body to destructor.

  • bindings/v8/ScriptController.h: Removed disconnectFrame() decl.
09:16 Changeset [44322] by dglazkov@chromium.org
  • 14 edits
    1 add in trunk/WebCore

2009-05-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

  • Add panel enabler to the resources panel.
  • Add session / always options into the panel enabler.
  • Make enabled status for three panels sticky (globally).
  • Persist enabled status using InspectorController::Settings
  • Make InspectorController produce no network-related overhead when resources panel is not enabled.

https://bugs.webkit.org/show_bug.cgi?id=26046

  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::disableDebugger):
  • inspector/InspectorController.h: (WebCore::InspectorController::Setting::Setting): (WebCore::InspectorController::resourceTrackingEnabled):
  • inspector/InspectorController.idl:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::resourceTrackingWasEnabled): (WebCore::InspectorFrontend::resourceTrackingWasDisabled):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/PanelEnablerView.js: (WebInspector.PanelEnablerView.enableOption): (WebInspector.PanelEnablerView): (WebInspector.PanelEnablerView.prototype._windowResized): (WebInspector.PanelEnablerView.prototype.alwaysWasChosen):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._enableProfiling): (WebInspector.ProfilesPanel.prototype._toggleProfiling):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.get statusBarItems): (WebInspector.ResourcesPanel.prototype.resourceTrackingWasEnabled): (WebInspector.ResourcesPanel.prototype.resourceTrackingWasDisabled): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._updateSidebarWidth): (WebInspector.ResourcesPanel.prototype._enableResourceTracking): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._enableDebugging): (WebInspector.ScriptsPanel.prototype._toggleDebugging):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js: (WebInspector.resourceTrackingWasEnabled): (WebInspector.resourceTrackingWasDisabled):
03:14 Changeset [44321] by abarth@webkit.org
  • 1 edit
    4 deletes in trunk/LayoutTests

Revert 44320. The test didn't pass on Windows.

02:05 Changeset [44320] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2009-06-01 Jungshik Shin <jshin@chromium.org>

Reviewed by Maciej Stachowiak. Landed by Adam Barth.

Add an additional test for bug 23786 (mistreatment of CR/LF
as zero-width characters in Chromium port). Tests using Bidi text were
added when the fix was checked in. Without the patch, Chromium used
to fail the same way with LTR complex scripts as well. (that is,
CR and LF were treated as zero-width space). To prevent a potential
regression in the future, a new test with Hindi (a LTR complex script)
is added.

https://bugs.webkit.org/show_bug.cgi?id=25698

  • fast/text/international/hindi-whitespace.html: Added.
  • platform/mac/fast/text/international/hindi-whitespace-expected.checksum: Added.
  • platform/mac/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/mac/fast/text/international/hindi-whitespace-expected.txt: Added.
02:00 Changeset [44319] by abarth@webkit.org
  • 7 edits
    6 adds in trunk

WebCore:

2009-06-01 Drew Wilson <atwilson@google.com>

Reviewed by Darin Adler. Landed (and tweaked) by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=25902

Added WorkerContext.close()

Test: fast/workers/worker-close.html

  • workers/WorkerContext.cpp: (WebCore::WorkerContext::close):
  • workers/WorkerContext.h:
  • workers/WorkerContext.idl:
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):

LayoutTests:

2009-06-01 Drew Wilson <atwilson@google.com>

Reviewed by Darin Adler. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=25902

Added WorkerContext.close()

  • fast/workers/worker-close-expected.txt: Added.
  • fast/workers/worker-close.html: Added.
  • fast/workers/resources/worker-close.js: Added.
  • http/tests/xmlhttprequest/workers/close.html: Added.
01:30 Changeset [44318] by abarth@webkit.org
  • 1 edit in trunk/LayoutTests/platform/mac/fast/dynamic/anchor-lock-expected.txt

Add missing expected result.

01:27 Changeset [44317] by ap@webkit.org
  • 9 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=12471
XPathResult not invalidated for documents retrieved via XMLHttpRequest

Test: fast/xpath/detached-subtree-invalidate-iterator.html and existing tests in dom/svg/level3/xpath.

Use DOM tree version instead of DOMSubtreeModified events to invalidate, which is more
reliable and much faster.

  • xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate):
  • xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult): (WebCore::XPathResult::~XPathResult): (WebCore::XPathResult::invalidIteratorState): (WebCore::XPathResult::iterateNext):
  • xml/XPathResult.h: (WebCore::XPathResult::create):
01:18 Changeset [44316] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-06-01 Darin Adler <darin@apple.com>

  • WebView/WebTextCompletionController.mm: Fix Tiger build by adding import of WebTypesInternal.h.
01:11 Changeset [44315] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-06-01 Brett Wilson <brettw@chromium.org>

Reviewed by Darin Adler. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=25750

Test: fast/transforms/bounding-rect-zoom.html

Make getClientRects and getBoundingClientRect account for ther zoom
factor.

  • dom/Element.cpp: (WebCore::adjustFloatPointForAbsoluteZoom): (WebCore::adjustFloatQuadForAbsoluteZoom): (WebCore::adjustIntRectForAbsoluteZoom): (WebCore::Element::getClientRects): (WebCore::Element::getBoundingClientRect):

LayoutTests:

2009-06-01 Brett Wilson <brettw@chromium.org>

Reviewed by Darin Adler. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=25750

Test: fast/transforms/bounding-rect-zoom.html

Make getClientRects and getBoundingClientRect account for ther zoom
factor.

  • fast/transforms/bounding-rect-zoom.html: Added.
  • platform/mac/fast/transforms/bounding-rect-zoom-expected.txt: Added.
01:07 Changeset [44314] by abarth@webkit.org
  • 1 add in trunk/LayoutTests/platform/mac/fast/dynamic/anchor-lock-expected.txt

Add bogus expected result to trick the bot into showing me the real expected results (as suggested by bdash).

00:46 Changeset [44313] by darin@apple.com
  • 4 edits
    2 copies in trunk/WebKit

WebKit:

2009-06-01 Darin Adler <darin@apple.com>

Reviewed by Maciej Stachowiak.

Bug 26113: break WebTextCompletionController out into its own source file
https://bugs.webkit.org/show_bug.cgi?id=26113

  • WebKit.xcodeproj/project.pbxproj: Add WebTextCompletionController.h/mm.

WebKit/mac:

2009-06-01 Darin Adler <darin@apple.com>

Reviewed by Maciej Stachowiak.

Bug 26113: break WebTextCompletionController out into its own source file
https://bugs.webkit.org/show_bug.cgi?id=26113

  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): Updated for new name. (-[WebHTMLViewPrivate clear]): Ditto. (-[WebHTMLView _frameOrBoundsChanged]): Ditto. (-[WebHTMLView menuForEvent:]): Ditto. (-[WebHTMLView windowDidResignKey:]): Ditto. (-[WebHTMLView windowWillClose:]): Ditto. (-[WebHTMLView mouseDown:]): Ditto. (-[WebHTMLView resignFirstResponder]): Ditto. (-[WebHTMLView keyDown:]): Ditto. (-[WebHTMLView complete:]): Ditto. Also pass WebView to init method. (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Ditto.
  • WebView/WebTextCompletionController.h: Copied from mac/WebView/WebHTMLView.mm.
  • WebView/WebTextCompletionController.mm: Copied from mac/WebView/WebHTMLView.mm. Changed initializer to pass in a spearate WebView and WebHTMLView, to smooth the way for handling viewless mode properly in the future.
00:43 Changeset [44312] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-06-01 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26026

Fix an infinite loop when using the keyboard in Chromium select
popups.

Not testable since it involves sending a keyboard event to
the popup, which is not possible (eventSender sends the key
events through webview, we want to go through the webwidget).

  • platform/chromium/PopupMenuChromium.cpp:
00:34 Changeset [44311] by abarth@webkit.org
  • 5 edits
    2 adds in trunk

WebCore:

2009-06-01 Nate Chapin <japhet@google.com>

Reviewed by Dimitri Glazkov. Landed by Adam Barth.


If a url with an anchor is being loaded, ensure that the anchor remains locked in view until the page
has finished loading compeltely or the user has manually scrolled. Refreshing an anchor url after
scrolling to a new location on the page will still result in jumping to the new location.


https://bugs.webkit.org/show_bug.cgi?id=26034

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Set anchor lock after navigating to anchor. (WebCore::FrameLoader::completed): Release anchor lock.
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): Ensure anchor lock starts unset. (WebCore::FrameView::reset): Ensure anchor lock starts unset. (WebCore::FrameView::layout): If anchor lock is set, force a gotoAnchor() after layout. (WebCore::FrameView::scrollRectIntoViewRecursively): Release anchor lock if a programmatic scroll begins. (WebCore::FrameView::setWasScrolledByUser): Release anchor lock if user manually scrolls. (WebCore::FrameView::setScrollPosition): Release anchor lock if a programmatic scroll begins.
  • page/FrameView.h: (WebCore::FrameView::lockedToAnchor): Added. (WebCore::FrameView::setLockedToAnchor): Added.

LayoutTests:

2009-06-01 Nate Chapin <japhet@google.com>

Reviewed by Dimitri Glazkov. Landed by Adam Barth.

Ensure an anchor remains locked in view as images (without height already specified) load around it.


https://bugs.webkit.org/show_bug.cgi?id=26034

  • fast/dynamic/anchor-lock.html: Added.
  • fast/dynamic/resources/largeblank.png: Added.

05/31/09:

23:06 Changeset [44310] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-05-31 Gavin Barraclough <barraclough@apple.com>

Reviewed by Olliej "you just need to change NativeFunctionWrapper.h" Hunt.

Add ENABLE_JIT_OPTIMIZE_NATIVE_CALL switch to allow JIT to operate without native call optimizations.

  • runtime/NativeFunctionWrapper.h:
  • wtf/Platform.h:
22:36 Changeset [44309] by krit@webkit.org
  • 8 edits
    2 adds
    2 deletes in trunk/WebCore

2009-05-31 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991

A short clean-up. FilterBuilder is SVG specific. Move it
to svg/graphics/filters and rename it to SVGFilterBuilder.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/FilterBuilder.cpp: Removed.
  • svg/FilterBuilder.h: Removed.
  • svg/SVGFilterElement.cpp:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter):
  • svg/graphics/SVGResourceFilter.h: (WebCore::SVGResourceFilter::builder):
  • svg/graphics/filters/SVGFilterBuilder.cpp: Added. (WebCore::SVGFilterBuilder::SVGFilterBuilder): (WebCore::SVGFilterBuilder::add): (WebCore::SVGFilterBuilder::getEffectById): (WebCore::SVGFilterBuilder::clearEffects):
  • svg/graphics/filters/SVGFilterBuilder.h: Added. (WebCore::SVGFilterBuilder::lastEffect):
22:35 Changeset [44308] by ap@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix a typo in ChangeLog.

22:23 Changeset [44307] by ap@webkit.org
  • 6 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=13233
Need to implement an optimizing XPath evaluator

Avoid sorting results of hierarchical paths that are natuarlly sorted. On a flat data structure
with 128K nodes and a simple XPath expression, this changes evaluation time from 1.5 minutes
to 33 ms.

  • xml/XPathNodeSet.h: Keep track of whether subtrees rooted at nodes in set are disjoint, which is useful for optimization. (WebCore::XPath::NodeSet::NodeSet): Removed, it was identical to compiler generated one. (WebCore::XPath::NodeSet::operator=): Ditto. (WebCore::XPath::NodeSet::swap): Ditto. (WebCore::XPath::NodeSet::isSorted): Single element sets are always sorted, even if sort() was never called. (WebCore::XPath::NodeSet::markSubtreesDisjoint): Just like being sorted, the new flag is maintained by callers. (WebCore::XPath::NodeSet::subtreesAreDisjoint): A single element set only has one subtree. Currently, the only way for a set to gain this flag is to be produced from a single element set with a hierarchical location path.
  • xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Use the new flag to avoid maintaining a set of unique nodes, and to avoid sorting the result.
21:18 Changeset [44306] by ap@webkit.org
  • 14 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=13233
Need to implement an optimizing XPath evaluator

This patch adds some infrastructure and simple optimizations. Namely,

  • we now avoid building a full NodeSet just to evaluate a predicate in some cases;
  • "/descendant-or-self::node()/child::" is optimized to iterate the tree once when possible;

WebCore:

  • xml/XPathExpressionNode.cpp: (WebCore::XPath::Expression::Expression):
  • xml/XPathExpressionNode.h: (WebCore::XPath::Expression::addSubExpression): (WebCore::XPath::Expression::isContextNodeSensitive): (WebCore::XPath::Expression::isContextPositionSensitive): (WebCore::XPath::Expression::isContextSizeSensitive): (WebCore::XPath::Expression::setIsContextNodeSensitive): (WebCore::XPath::Expression::setIsContextPositionSensitive): (WebCore::XPath::Expression::setIsContextSizeSensitive): XPath expression now knows its result type, and whether evaluation depends on context.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunLast::resultType): (WebCore::XPath::FunLast::FunLast): (WebCore::XPath::FunPosition::resultType): (WebCore::XPath::FunPosition::FunPosition): (WebCore::XPath::FunCount::resultType): (WebCore::XPath::FunId::resultType): (WebCore::XPath::FunLocalName::resultType): (WebCore::XPath::FunLocalName::FunLocalName): (WebCore::XPath::FunNamespaceURI::resultType): (WebCore::XPath::FunNamespaceURI::FunNamespaceURI): (WebCore::XPath::FunName::resultType): (WebCore::XPath::FunName::FunName): (WebCore::XPath::FunString::resultType): (WebCore::XPath::FunString::FunString): (WebCore::XPath::FunConcat::resultType): (WebCore::XPath::FunStartsWith::resultType): (WebCore::XPath::FunContains::resultType): (WebCore::XPath::FunSubstringBefore::resultType): (WebCore::XPath::FunSubstringAfter::resultType): (WebCore::XPath::FunSubstring::resultType): (WebCore::XPath::FunStringLength::resultType): (WebCore::XPath::FunStringLength::FunStringLength): (WebCore::XPath::FunNormalizeSpace::resultType): (WebCore::XPath::FunNormalizeSpace::FunNormalizeSpace): (WebCore::XPath::FunTranslate::resultType): (WebCore::XPath::FunBoolean::resultType): (WebCore::XPath::FunNot::resultType): (WebCore::XPath::FunTrue::resultType): (WebCore::XPath::FunFalse::resultType): (WebCore::XPath::FunLang::resultType): (WebCore::XPath::FunLang::FunLang): (WebCore::XPath::FunNumber::resultType): (WebCore::XPath::FunNumber::FunNumber): (WebCore::XPath::FunSum::resultType): (WebCore::XPath::FunFloor::resultType): (WebCore::XPath::FunCeiling::resultType): (WebCore::XPath::FunRound::resultType): (WebCore::XPath::Function::setArguments): Set optimization details for the expression. Normally, a function does not introduce context node set dependency, but some use context node as default argument, or otherwise use the context.
  • xml/XPathFunctions.h: Tweaked style.
  • xml/XPathPath.cpp: (WebCore::XPath::Filter::Filter): A filter is as context node set sensitive as its expression is. (WebCore::XPath::LocationPath::LocationPath): A location path can only be context node sensitive, and only if the path relative. (WebCore::XPath::LocationPath::appendStep): Invoke compile-time Step optimizations. (WebCore::XPath::LocationPath::insertFirstStep): Ditto. (WebCore::XPath::Path::Path): A path is as context node set sensitive as its filter is.
  • xml/XPathPath.h: (WebCore::XPath::Filter::resultType): Result type of a filter is the same as of its expression (useful filters return NodeSets, of course). (WebCore::XPath::LocationPath::setAbsolute): An absolute location path if context node set insensitive. (WebCore::XPath::LocationPath::resultType): A path's result is always a node set. (WebCore::XPath::Path::resultType): Ditto.
  • xml/XPathPredicate.h: (WebCore::XPath::Number::resultType): Return a proper result type. (WebCore::XPath::StringExpression::resultType): Ditto. (WebCore::XPath::Negative::resultType): Ditto. (WebCore::XPath::NumericOp::resultType): Ditto. (WebCore::XPath::EqTestOp::resultType): Ditto. (WebCore::XPath::LogicalOp::resultType): Ditto. (WebCore::XPath::Union::resultType): Ditto. (WebCore::XPath::Predicate::isContextPositionSensitive): A predicate can be context position sensitive even if its expression is not, because e.g. [5] is a shortcut for [position()=5]. (WebCore::XPath::Predicate::isContextSizeSensitive): This matches expression result.
  • xml/XPathStep.h: (WebCore::XPath::Step::NodeTest::Kind): Removed unused ElementNodeTest, which was previously borrowed from XPath 2.0 to express some optimizations. (WebCore::XPath::Step::NodeTest::mergedPredicates): To avoid building a huge node set and filtering it with predicates, we now try to apply predicates while enumerating an axis. (WebCore::XPath::Step::nodeTest): Expose m_nodeTest.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::~Step): The step owns NodeTest merged predicates, so it is still possible to copy NodeTests. (WebCore::XPath::Step::optimize): Merge predicates into NodeTest if possible. (WebCore::XPath::optimizeStepPair): Optimize some expressions containing "". (WebCore::XPath::Step::predicatesAreContextListInsensitive): The above optimization is only possible if there are no context sensitive predicates for "". (WebCore::XPath::Step::evaluate): Track context position for the first merged predicate. (WebCore::XPath::nodeMatchesBasicTest): Check whether the node matches node test, ignoring merged predicates. (WebCore::XPath::nodeMatches): Additionally check merged predicates, and update position. (WebCore::XPath::Step::nodesInAxis): Check merged predicates in optimized attribute code path.
  • xml/XPathVariableReference.h: (WebCore::XPath::VariableReference::resultType): Variable references are not used with XPathEvaluator, so we'll only need them if we decide to reimplement XSLT. The type of variable reference is not known at compile time.

LayoutTests:

  • fast/xpath/attribute-node-predicate-expected.txt: Added.
  • fast/xpath/attribute-node-predicate.html: Added. Test that predicates on attribute nodes are applied correctly (which I had wrong for a while when working on this patch).
  • fast/xpath/position-expected.txt:
  • fast/xpath/position.html: Added an example from XPath spec.
20:59 Changeset [44305] by mitz@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows results for fast/forms/isindex-placeholder.html

20:55 Changeset [44304] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

2009-05-31 Sam Weinig <sam@webkit.org>

Implement LayoutTestController::clearAllDatabases()
on Windows.

20:05 Changeset [44303] by weinig@apple.com
  • 4 edits
    1 delete in trunk/WebCore

2009-05-31 Sam Weinig <sam@webkit.org>

Rubber-stamped by Dan Bernstein.

Remove unused JSEventTargetBase.h

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventTargetBase.h: Removed.
19:56 Changeset [44302] by weinig@apple.com
  • 6 edits in trunk

WebCore:

2009-05-31 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Part of https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow

Add missing oncanplay, oncanplaythrough, ondurationchange, onemptied,
onended, onloadeddata, onloadedmetadata, onpause, onplay, onplaying,
onratechange, onseeked, onseeking, ontimeupdate, onvolumechange,
onwaiting, onloadstart, onprogress, onstalled, onsuspend, ondrag,
ondragend, ondragenter, ondragleave, ondragover, ondragstart and
ondrop event handlers to the DOMWindow.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::ondrag): (WebCore::DOMWindow::setOndrag): (WebCore::DOMWindow::ondragend): (WebCore::DOMWindow::setOndragend): (WebCore::DOMWindow::ondragenter): (WebCore::DOMWindow::setOndragenter): (WebCore::DOMWindow::ondragleave): (WebCore::DOMWindow::setOndragleave): (WebCore::DOMWindow::ondragover): (WebCore::DOMWindow::setOndragover): (WebCore::DOMWindow::ondragstart): (WebCore::DOMWindow::setOndragstart): (WebCore::DOMWindow::ondrop): (WebCore::DOMWindow::setOndrop): (WebCore::DOMWindow::oncanplay): (WebCore::DOMWindow::setOncanplay): (WebCore::DOMWindow::oncanplaythrough): (WebCore::DOMWindow::setOncanplaythrough): (WebCore::DOMWindow::ondurationchange): (WebCore::DOMWindow::setOndurationchange): (WebCore::DOMWindow::onemptied): (WebCore::DOMWindow::setOnemptied): (WebCore::DOMWindow::onended): (WebCore::DOMWindow::setOnended): (WebCore::DOMWindow::onloadeddata): (WebCore::DOMWindow::setOnloadeddata): (WebCore::DOMWindow::onloadedmetadata): (WebCore::DOMWindow::setOnloadedmetadata): (WebCore::DOMWindow::onpause): (WebCore::DOMWindow::setOnpause): (WebCore::DOMWindow::onplay): (WebCore::DOMWindow::setOnplay): (WebCore::DOMWindow::onplaying): (WebCore::DOMWindow::setOnplaying): (WebCore::DOMWindow::onratechange): (WebCore::DOMWindow::setOnratechange): (WebCore::DOMWindow::onseeked): (WebCore::DOMWindow::setOnseeked): (WebCore::DOMWindow::onseeking): (WebCore::DOMWindow::setOnseeking): (WebCore::DOMWindow::ontimeupdate): (WebCore::DOMWindow::setOntimeupdate): (WebCore::DOMWindow::onvolumechange): (WebCore::DOMWindow::setOnvolumechange): (WebCore::DOMWindow::onwaiting): (WebCore::DOMWindow::setOnwaiting): (WebCore::DOMWindow::onloadstart): (WebCore::DOMWindow::setOnloadstart): (WebCore::DOMWindow::onprogress): (WebCore::DOMWindow::setOnprogress): (WebCore::DOMWindow::onstalled): (WebCore::DOMWindow::setOnstalled): (WebCore::DOMWindow::onsuspend): (WebCore::DOMWindow::setOnsuspend):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

2009-05-31 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Part of https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow

Add missing oncanplay, oncanplaythrough, ondurationchange, onemptied,
onended, onloadeddata, onloadedmetadata, onpause, onplay, onplaying,
onratechange, onseeked, onseeking, ontimeupdate, onvolumechange,
onwaiting, onloadstart, onprogress, onstalled, onsuspend, ondrag,
ondragend, ondragenter, ondragleave, ondragover, ondragstart and
ondrop event handlers to the DOMWindow.

  • fast/dom/Window/window-properties-expected.txt:
17:20 Changeset [44301] by weinig@apple.com
  • 8 edits in trunk

WebCore:

2009-05-31 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Part of https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow

Add missing onstorage event handler to the DOMWindow.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::onstorage): (WebCore::DOMWindow::setOnstorage):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

2009-05-31 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Part of https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow

Add missing onstorage event handler to the DOMWindow.

  • fast/dom/Window/window-properties-expected.txt:
  • storage/domstorage/window-attributes-exist-expected.txt:
  • storage/domstorage/window-attributes-exist.html:
16:47 Changeset [44300] by weinig@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

2009-05-31 Sam Weinig <sam@webkit.org>

Rubber-stamped by Mark Rowe.

Remove duplicate file. The version of window-properties-expected.txt in the
platform/mac-leopard was identical to the one in the normal spot.

  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt: Removed.
16:12 Changeset [44299] by krit@webkit.org
  • 41 edits in trunk/WebCore

2009-05-31 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991

Make use of the new filter system in WebCore for SVG. Deleted Mac bindings
and replace it by a platform independent code. Calculation of subRegions
is missing but needed for a first filter effect.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/Filter.h: (WebCore::Filter::~Filter): (WebCore::Filter::setSourceImage):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent):
  • svg/FilterBuilder.h: (WebCore::FilterBuilder::lastEffect):
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement): (WebCore::SVGFEBlendElement::build):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): (WebCore::SVGFEColorMatrixElement::build):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement): (WebCore::SVGFEComponentTransferElement::build):
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::SVGFECompositeElement): (WebCore::SVGFECompositeElement::build):
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement): (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (WebCore::SVGFEDisplacementMapElement::build):
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::build):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement): (WebCore::SVGFEGaussianBlurElement::build):
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::SVGFEImageElement): (WebCore::SVGFEImageElement::notifyFinished): (WebCore::SVGFEImageElement::build):
  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::SVGFEMergeElement): (WebCore::SVGFEMergeElement::build):
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::SVGFEOffsetElement): (WebCore::SVGFEOffsetElement::build):
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement): (WebCore::SVGFESpecularLightingElement::build):
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::SVGFETileElement): (WebCore::SVGFETileElement::build):
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement): (WebCore::SVGFETurbulenceElement::build):
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::canvasResource):
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
  • svg/SVGFilterPrimitiveStandardAttributes.h: (WebCore::SVGFilterPrimitiveStandardAttributes::contextElement):
  • svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::addFilterEffect): (WebCore::SVGResourceFilter::filterBBoxForItemBBox): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter): (WebCore::SVGResourceFilter::externalRepresentation):
  • svg/graphics/SVGResourceFilter.h: (WebCore::SVGResourceFilter::filterBoundingBox): (WebCore::SVGResourceFilter::setFilterBoundingBox): (WebCore::SVGResourceFilter::itemBoundingBox): (WebCore::SVGResourceFilter::setItemBoundingBox): (WebCore::SVGResourceFilter::builder):
15:24 Changeset [44298] by weinig@apple.com
  • 8 edits in trunk

WebCore:

2009-05-30 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26110
Update online/offline events to match the current spec.

  • Also adds window.ononline and window.onoffline event handler properties.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::onoffline): (WebCore::DOMWindow::setOnoffline): (WebCore::DOMWindow::ononline): (WebCore::DOMWindow::setOnonline):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/Page.cpp: (WebCore::networkStateChanged):

LayoutTests:

2009-05-30 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26110
Update online/offline events to match the current spec.

  • Also adds window.ononline and window.onoffline event handler properties.
  • fast/dom/Window/window-properties-expected.txt:
  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
11:22 Changeset [44297] by krit@webkit.org
  • 6 edits in trunk/WebCore

2009-05-31 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991

Adding 'in1' attribute support for <feFlood>, as specified in SVG 1.1.
This change helps creating test cases, once filters are activated.

  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::parseMappedAttribute): (WebCore::SVGFEFloodElement::build):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFloodElement.idl:
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::FEFlood): (WebCore::FEFlood::create):
  • svg/graphics/filters/SVGFEFlood.h:
10:34 Changeset [44296] by krit@webkit.org
  • 41 edits
    3 adds
    2 deletes in trunk/WebCore

2009-05-31 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991

Replace all occurrences of SVGResourceFilter by Filter. This is the last
step for a SVG independent filter system. Every other part of WebCore can
use the filter system by creating a new Filter object.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/Filter.h: Added. (WebCore::Filter::setSourceImage): (WebCore::Filter::sourceImage):
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::apply):
  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
  • platform/graphics/filters/SourceGraphic.h:
  • svg/Filter.cpp: Removed.
  • svg/Filter.h: Removed.
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::apply):
  • svg/graphics/filters/SVGFEConvolveMatrix.h:
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp: (WebCore::FEDiffuseLighting::apply):
  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
  • svg/graphics/filters/SVGFEDisplacementMap.h:
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply):
  • svg/graphics/filters/SVGFEFlood.h:
  • svg/graphics/filters/SVGFEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply):
  • svg/graphics/filters/SVGFEGaussianBlur.h:
  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply):
  • svg/graphics/filters/SVGFEMerge.h:
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
  • svg/graphics/filters/SVGFEMorphology.h:
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
  • svg/graphics/filters/SVGFEOffset.h:
  • svg/graphics/filters/SVGFESpecularLighting.cpp: (WebCore::FESpecularLighting::apply):
  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
  • svg/graphics/filters/SVGFETile.h:
  • svg/graphics/filters/SVGFETurbulence.cpp: (WebCore::FETurbulence::apply):
  • svg/graphics/filters/SVGFETurbulence.h:
  • svg/graphics/filters/SVGFilter.cpp: Added. (WebCore::SVGFilter::SVGFilter): (WebCore::SVGFilter::calculateEffectSubRegion): (WebCore::SVGFilter::create):
  • svg/graphics/filters/SVGFilter.h: Added.

05/30/09:

20:26 Changeset [44295] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Build fix for platforms without plugins support.

19:32 Changeset [44294] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=25979

Fix regression, local WML files won't load anymore, as the mimetype isn't correctly detected.
Bug filed at <rdar://problem/6917571> to cover this CFNetwork limitation.

17:58 Changeset [44293] by weinig@apple.com
  • 17 edits in trunk

WebCore:

2009-05-29 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26091
Make storage events match the current spec.

  • Storage event listeners are added to the window.
  • Storage events are dispatched to the window.

Updated existing tests.

  • dom/Document.cpp: (WebCore::Document::dispatchWindowEvent):
  • dom/Document.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
  • storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::dispatchStorageEvent):
  • storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::dispatchStorageEvent):

LayoutTests:

2009-05-29 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26091
Make storage events match the current spec.

  • Storage event listeners are added to the window.
  • Storage events are dispatched to the window.
  • storage/domstorage/localstorage/iframe-events.html:
  • storage/domstorage/localstorage/index-get-and-set.html:
  • storage/domstorage/localstorage/resources/iframe-events-second.html:
  • storage/domstorage/localstorage/simple-events.html:
  • storage/domstorage/sessionstorage/iframe-events.html:
  • storage/domstorage/sessionstorage/index-get-and-set.html:
  • storage/domstorage/sessionstorage/resources/iframe-events-second.html:
  • storage/domstorage/sessionstorage/simple-events.html:
16:27 Changeset [44292] by darin@apple.com
  • 7 edits in trunk

WebCore:

2009-05-30 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson.

Bug 26097: REGRESSION (r44283): Tab key doesn't work when focus is on a <select> element

Test: fast/forms/focus-control-to-page.html

  • dom/SelectElement.h: Made destructor protected. Tweaked a bit.
  • html/HTMLSelectElement.cpp: Removed unneeded includes. (WebCore::HTMLSelectElement::remove): Removed unneeded range check of the result of optionToListIndex. (WebCore::HTMLSelectElement::parseMappedAttribute): Removed code to set the unused attribute, m_minwidth. (WebCore::HTMLSelectElement::defaultEventHandler): The actual bug fix. Call through to the base class defaultEventHandler if the event hasn't been handled yet.
  • html/HTMLSelectElement.h: Removed unneeded includes. Made a lot more functions private. Removed unused minWidth function and m_minwidth data member.

LayoutTests:

2009-05-30 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson.

Bug 26097: REGRESSION (r44283): Tab key doesn't work when focus is on a <select> element

  • fast/forms/focus-control-to-page-expected.txt: Updated.
  • fast/forms/focus-control-to-page.html: Added test of <select>, <textarea>, and <input type="password">, and made sure we can tab both in and out of each type.
16:20 Changeset [44291] by bfulgham@webkit.org
  • 2 edits
    1 move
    1 delete in trunk/WebCore

2009-05-30 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Holger Freyther.

The two KeyboardCodes.h files are basically identical and the
qt one is properly #ifdef-ed for different win32 systems. Share
them between Qt and Gtk implementations.

  • GNUmakefile.am:
  • platform/KeyboardCodes.h: Copied from WebCore/platform/qt/KeyboardCodes.h.
  • platform/gtk/KeyboardCodes.h: Removed.
  • platform/qt/KeyboardCodes.h: Removed.
15:58 Changeset [44290] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

Add JSLock to -[WebScriptCallFrame scopeChain]

Reviewed by Darin Adler.

In Debug builds of WebKit, Dashcode launching MobileSafari could
cause the ASSERT(JSLock::lockCount() > 0) assertion to fire in
JSC::Heap::heapAllocate() because the JSLock wasn't taken.

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): Take JSLock before calling into JavaScriptCore.
15:38 Changeset [44289] by bfulgham@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2009-05-30 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Sam Weinig.

LocalStorage and SessionStorage's implicit setters do not correctly
handle null. The custom JS bindings should convert to strings
unconditionally and not try to handle null specially.
https://bugs.webkit.org/show_bug.cgi?id=25970

  • storage/domstorage/localstorage/string-conversion-expected.txt: Added.
  • storage/domstorage/localstorage/string-conversion.html: Added.
  • storage/domstorage/sessionstorage/string-conversion-expected.txt: Added.
  • storage/domstorage/sessionstorage/string-conversion.html: Added.
15:38 Changeset [44288] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-05-30 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Sam Weinig.

LocalStorage and SessionStorage's implicit setters do not correctly
handle null. The custom JS bindings should convert to strings
unconditionally and not try to handle null specially.
https://bugs.webkit.org/show_bug.cgi?id=25970

Tests: storage/domstorage/localstorage/string-conversion.html

storage/domstorage/sessionstorage/string-conversion.html

  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::customPut):
13:35 Changeset [44287] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6935192> REGRESSION (Safari 3-TOT): Scroll bars in key window draw as inactive if the WebView is not active

Test: platform/mac/scrollbars/key-window-not-first-responder.html

  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint): Use the window's key state instead of the WebView's first responder state to switch between active and inactive state.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6935192> REGRESSION (Safari 3-TOT): Scroll bars in key window draw as inactive if the WebView is not active
  • platform/mac/scrollbars/key-window-not-first-responder-expected.checksum: Added.
  • platform/mac/scrollbars/key-window-not-first-responder-expected.png: Added.
  • platform/mac/scrollbars/key-window-not-first-responder-expected.txt: Added.
  • platform/mac/scrollbars/key-window-not-first-responder.html: Added.
13:27 Changeset [44286] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-30 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6935193> REGRESSION (r42734): Celtic Kane JavaScript benchmark does not run:
"Maximum call stack size exceeded"

  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): Use the same recursion limit as the other recursion checks. We need a limit of at least 100 to run the benchmark above. (JSC::arrayProtoFuncToLocaleString): Ditto. (JSC::arrayProtoFuncJoin): Ditto.
10:50 Changeset [44285] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Simon Fraser.

Test: fast/backgrounds/body-generated-image-propagated-to-root.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Check if this is the root element painting a background layer propagated from the body, and if it is, use the body's renderer as the client to StyleImage::image().

LayoutTests:

Reviewed by Simon Fraser.

  • fast/backgrounds/body-generated-image-propagated-to-root.html: Added.
  • platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.checksum: Added.
  • platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.png: Added.
  • platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Added.
09:50 Changeset [44284] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-30 Holger Hans Peter Freyther <zecke@selfish.org>

Unreviewed build fix for AXObjectCache.

For !HAVE(ACCESSIBILITY) postNotification was defined twice. Move
that into the #ifdef.

  • accessibility/AXObjectCache.cpp:

05/29/09:

18:38 Changeset [44283] by zimmermann@webkit.org
  • 22 edits
    6 adds in trunk

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26072

Add support for the last missing WML element: <select>. This patch adds WMLSelectElement, providing
the same functionality HTMLSelectElement has. The WML specific features will follow soon.

Add simple testcase covering <select> element rendering: fast/wml/select.wml

15:55 Changeset [44282] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-29 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

Fixed compile warning when comparing the different navigation types

  • webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_class_init):
15:42 Changeset [44281] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-29 David Levin <levin@chromium.org>

Reviewed by NOBODY (build fix for windows).

http://trac.webkit.org/changeset/44279 left in a "Vector<WCHAR> localeNameBuf"
that it was trying to replace. Resulting in this variable being defined twice (and
the second time incorrectly).

  • platform/win/Language.cpp: (WebCore::localeInfo):
15:02 Changeset [44280] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-29 Takeshi Yoshino <tyoshino@google.com>

Reviewed by Darin Alder.

https://bugs.webkit.org/show_bug.cgi?id=26018

Fix behavior of the Element View of the Web Inspector for double
clicking the element outline tree.

Double clicking the element outline tree should
1) on attribute: enter attribute editing mode
2) on text: enter text editing mode
3) otherwise: change root node to the parent element of double clicked

element.

Now, 3) is broken. For example, clicking <html> clears the element
outline view.

rootDOMNode should be updated to this.representedObject.parentNode, not
this.parent.representedObject which is parent inside the element
outline tree itself.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.ondblclick):
15:02 Changeset [44279] by levin@chromium.org
  • 9 edits in trunk/WebCore

2009-05-29 David Moore <davemoore@google.com>

Reviewed by Darin Alder.

https://bugs.webkit.org/show_bug.cgi?id=26001
Change many of the uses of String::adopt() to String::createUninitialized().
This allows those strings to use an inlined buffer for their characters.

  • dom/StyleElement.cpp: Loop over nodes to precompute length of string and then write the characters into the allocated inline buffer (WebCore::StyleElement::process):
  • dom/Text.cpp: Loop over nodes to precompute length of string and then write the characters into the allocated inline buffer (WebCore::Text::wholeText): (WebCore::Text::rendererIsNeeded): (WebCore::Text::createRenderer): (WebCore::Text::createWithLengthLimit): (WebCore::Text::formatForDebugger):
  • platform/text/String.cpp: (WebCore::String::append): (WebCore::String::insert): (WebCore::String::truncate): (WebCore::String::remove):
  • platform/text/StringBuilder.cpp: (WebCore::StringBuilder::toString):
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): (WebCore::StringImpl::secure): (WebCore::StringImpl::foldCase): (WebCore::StringImpl::replace):
  • platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode):
  • platform/text/TextCodecUserDefined.cpp: (WebCore::TextCodecUserDefined::decode):
  • platform/win/Language.cpp: (WebCore::localeInfo):
15:02 Changeset [44278] by levin@chromium.org
  • 3 edits
    4 adds in trunk

WebCore:

2009-05-29 Takeshi Yoshino <tyoshino@google.com>

Reviewed by Darin Alder.

Bug 25911: Apply href in base elements to anchors shown on the source viewer
https://bugs.webkit.org/show_bug.cgi?id=25911

In rendering HTML sources, parse base elements to apply the base URI to
anchors shown on the source viewer.

This issue was originally reported to the Chromium issue tracker.
http://code.google.com/p/chromium/issues/detail?id=2418

Test: fast/frames/viewsource-link-on-href-value.html

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):

LayoutTests:

2009-05-29 Takeshi Yoshino <tyoshino@google.com>

Reviewed by Darin Alder.

Bug 25911: Apply href in base elements to anchors shown on the source viewer
https://bugs.webkit.org/show_bug.cgi?id=25911

In rendering HTML sources, parse base elements to apply the base URI to
anchors shown on the source viewer.

Add tests to verify this change.

This issue was originally reported to the Chromium issue tracker.
http://code.google.com/p/chromium/issues/detail?id=2418

  • fast/frames/resources/viewsource-frame-3.html: Added.
  • fast/frames/resources/viewsource-frame-4.html: Added.
  • fast/frames/viewsource-link-on-href-value-expected.txt: Added.
  • fast/frames/viewsource-link-on-href-value.html: Added.
15:02 Changeset [44277] by levin@chromium.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-05-29 Rob Buis <rwlbuis@gmail.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=22429
document.styleSheets collection ignores media=presentation

Ensure that stylesheets though <link> show up in document.styleSheets regardless of media attribute.

Test: fast/css/sheet-collection-link.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):

LayoutTests:

2009-05-29 Rob Buis <rwlbuis@gmail.com>

Reviewed by David Hyatt.

Testcase for:
https://bugs.webkit.org/show_bug.cgi?id=22429
document.styleSheets collection ignores media=presentation

  • fast/css/sheet-collection-link.html: Added.
  • fast/css/sheet-collection-link-expected.txt: Added.
15:02 Changeset [44276] by levin@chromium.org
  • 4 edits in trunk/WebCore

2009-05-29 Itai Danan <idanan@chromium.org>

Reviewed by Jon Honeycutt.

Bug 24791: Should have a preference to disable auto scrolling
https://bugs.webkit.org/show_bug.cgi?id=24791

To understand why this is required see the discussion in
issue 24722 (https://bugs.webkit.org/show_bug.cgi?id=24722).

The code review was done in https://bugs.webkit.org/show_bug.cgi?id=21794.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Use autoscroll behavior flag to determine if autoscroll needs to be released on this event. (WebCore::EventHandler::handleMouseReleaseEvent): Use autoscroll behavior flag to determine if autoscroll needs to be released on this event (reverse logic of for Press event).
  • page/Settings.cpp: (WebCore::Settings::Settings): Initialize autoscroll behavior setting.
  • page/Settings.h: (WebCore::Settings::setUsesStickyPanScroll): Autoscroll behavior setting setter. (WebCore::Settings::usesStickyPanScroll): Autoscroll behavior setting getter.
14:58 Changeset [44275] by jianli@chromium.org
  • 3 edits
    3 adds in trunk

WebCore:

2009-05-29 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26069
Fix a crash in custom V8 bindings code for XMLHttpRequest.

Test: fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-29 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26069
Test for the above bug.

  • fast/xmlhttprequest/resources/xmlhttprequest-open-after-iframe-onload-remove-self-child.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html: Added.
14:38 Changeset [44274] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-05-29 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

Bug 26074: SQLTransaction::executeSQL does an unnecessary call to String::copy.
https://bugs.webkit.org/show_bug.cgi?id=26074

The constructor for SQLStatement already does a copy for this string.

  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL):
13:53 Changeset [44273] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Implement WebFrame::startDownload

Fixes the WebKit side of Bug 25729: Alt-clicking a link doesn't start
a download <https://bugs.webkit.org/show_bug.cgi?id=25729>. Fixing
this all the way will require a change in Safari.

Reviewed by Darin Adler.

  • WebFrame.cpp: (WebFrame::startDownload): Call through to WebView::downloadURL.
13:51 Changeset [44272] by darin@apple.com
  • 3 edits in trunk/WebCore

2009-05-29 Darin Adler <darin@apple.com>

Fix build; the new Cairo code compiled on Windows only.

  • platform/graphics/gtk/FontPlatformData.h: Added syntheticBold and syntheticOblique functions as in the Windows version to make it easier to use this cross-platform. Later we can make data members private as in the Windows version.
  • platform/graphics/mac/FontPlatformData.h: Ditto.
13:48 Changeset [44271] by aroben@apple.com
  • 4 edits in trunk/WebKit/win

Move WebContextMenuClient's downloading code to WebView

This will allow other code to trigger downloads using this code, and
matches Mac.

Reviewed by Darin Adler.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::downloadURL): Moved code from here...
  • WebView.cpp: (WebView::downloadURL): ...to here. Also tightened up the code a little bit and removed an unnecessary LOG_ERROR.
  • WebView.h: Added downloadURL.
13:41 Changeset [44270] by aroben@apple.com
  • 7 edits in trunk

Roll out r44269

It contained some changes I didn't mean to have landed, and squashed
some distinct patches into a single commit.

13:33 Changeset [44269] by bfulgham@webkit.org
  • 7 edits in trunk

WebCore:

2009-05-29 Adam Roben <aroben@apple.com>

Make sure PlatformMouseEvent::modifierFlags contains MK_ALT when the
Alt key is pressed

First part of fixing Bug 25729: Alt-clicking a link doesn't start a
download
<https://bugs.webkit.org/show_bug.cgi?id=25729>

Reviewed by Darin Adler.

No test possible.

  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Add MK_ALT to the modifier flags when the Alt key is pressed.

WebKit/win:

2009-05-29 Adam Roben <aroben@apple.com>

Implement WebFrame::startDownload

Fixes Bug 25729: Alt-clicking a link doesn't start a download
<https://bugs.webkit.org/show_bug.cgi?id=25729>

Reviewed by Darin Adler.

  • WebFrame.cpp: (WebFrame::startDownload): Call through to WebView::downloadURL.
12:53 Changeset [44268] by bfulgham@webkit.org
  • 6 edits in trunk/WebCore

2009-05-29 Alexander Macdonald <alexmac@adobe.com>

Reviewed by Darin Adler.

Added support for synthetic bold/oblique font rendering
on platforms that use cairo.

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit):
11:49 Changeset [44267] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

2009-05-29 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Darin Adler.

Correct Windows Cairo build error caused by @r42767.
http://bugs.webkit.org/show_bug.cgi?id=26082.

  • WebError.cpp: (WebError::localizedDescription):
11:32 Changeset [44266] by cfleizach@apple.com
  • 13 edits in trunk/WebCore

Bug 26024: AX: possible to fail assertion because AXPostNotification calls accessibilityIsIgnored
https://bugs.webkit.org/show_bug.cgi?id=26024

09:55 Changeset [44265] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-05-29 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Build fix for Windows Cairo target.
https://bugs.webkit.org/show_bug.cgi?id=25972

Compiler mistakenly selects SMILTime min/max instead of STL version,
resulting in a build error. This change makes the meaning of the
min/max explicit and avoids the problem.

  • html/TimeRanges.h: (WebCore::TimeRanges::Range::unionWithOverlappingOrContiguousRange):
08:56 Changeset [44264] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=26075
[GTK] Refactor key scrolling code

After the scrolling changes in r44177 we can now use the
FrameView::scroll method like the other ports, keeping the magic
constants for the scrolling amounts inside WebCore proper.

  • webkit/webkitwebview.cpp: (webkit_web_view_real_move_cursor):
07:48 Changeset [44263] by kov@webkit.org
  • 12 edits
    2 adds in trunk

2009-05-29 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Jan Alonzo.

Add a test-case for our HTTP backend, currently checking the
ref-counting of the SoupMessage.

  • GNUmakefile.am:

WebCore:

2009-05-29 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Jan Alonzo.

Make SoupMessage a member of ResourceRequest, instead of creating
it in startHttp. Implement updating of ResourceRequest from
SoupMessage, and vice versa.

  • GNUmakefile.am:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::gotHeadersCallback): (WebCore::ResourceHandle::startHttp):
  • platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::~ResourceRequest):
  • platform/network/soup/ResourceRequestSoup.cpp: Added. (WTF::SoupURI): (WebCore::ResourceRequest::soupMessage): (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdateResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest):

WebKit/gtk:

2009-05-29 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Jan Alonzo.

Make NetworkRequest carry a reference of the SoupMessage used by
ResourceRequest, and use that to create new ResourceRequests where
needed, so that no information is lost while passing around
NetworkRequest objects.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::FrameLoaderClient::startDownload):
  • webkit/webkitdownload.cpp: (webkit_download_start):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_finalize): (webkit_network_request_new_with_core_request): (webkit_network_request_new): (webkit_network_request_get_message):
  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_load_request):
04:10 Changeset [44262] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Fix error in test case i accidentally introduced.

05/28/09:

17:45 Changeset [44261] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

17:40 Changeset [44260] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.14

New tag.

17:34 Changeset [44259] by mrowe@apple.com
  • 7 edits
    4 adds in branches/WWDC-2009-branch

Merge r44218.

17:34 Changeset [44258] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebCore

Merge r44241.

17:34 Changeset [44257] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Merge r44216.

16:44 Changeset [44256] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-05-28 Dmitry Titov <dimich@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26068
V8: Remove the remaining b8::Locker usage in worker code.
This completes the fix for https://bugs.webkit.org/show_bug.cgi?id=25944,
since the patches for enabling timers and that bug have "crossed in the queue".
Existing LayoutTests/fast/workers/worker-timeout.html covers this fix (will start work in Chromium).

  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
15:38 Changeset [44255] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

Build fix. Move off a deprecated NSFileManager method.

Rubber-stamped by Dan Bernstein.

  • Misc/WebNSFileManagerExtras.h:
  • Misc/WebNSFileManagerExtras.m:

(-[NSFileManager destinationOfSymbolicLinkAtPath:error:]): Implement a new-in-Leopard method for Tiger to use.
(-[NSFileManager attributesOfItemAtPath:error:]): Ditto.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _initWithPath:]): Use the new non-deprecated methods.

15:18 Changeset [44254] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Simplify the Accept-Encoding header we are sending out, for it
seems some servers do not enjoy parsing the full, explicit
version.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
15:10 Changeset [44253] by krit@webkit.org
  • 186 edits in trunk

2009-05-28 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added a new build flag --filters. This replaces the old --svg-filters and enables
other parts of WebKit to use some basic filters of platform/graphics/filters if needed.
This patch also fixes a bug in dom/DOMImplementation.cpp where we used SVG_FILTER. This flag
doesn't exist and was replaced by FILTERS as well as all SVG_FILTERS occurrences.
Filters are not working yet. This patch is just a preperation. Filters are deactivated by
default.

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap):
  • dom/DOMImplementation.cpp: (WebCore::isSVG10Feature): (WebCore::isSVG11Feature):
  • page/DOMWindow.idl:
  • platform/graphics/filters/FEBlend.cpp:
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp:
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FilterEffect.cpp:
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/SourceAlpha.cpp:
  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp:
  • platform/graphics/filters/SourceGraphic.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint):
  • rendering/RenderSVGModelObject.cpp:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
  • svg/Filter.cpp:
  • svg/Filter.h:
  • svg/FilterBuilder.cpp:
  • svg/FilterBuilder.h:
  • svg/SVGComponentTransferFunctionElement.cpp:
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGFEBlendElement.cpp:
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.cpp:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFEComponentTransferElement.cpp:
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFEComponentTransferElement.idl:
  • svg/SVGFECompositeElement.cpp:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEDiffuseLightingElement.cpp:
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDiffuseLightingElement.idl:
  • svg/SVGFEDisplacementMapElement.cpp:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEDistantLightElement.cpp:
  • svg/SVGFEDistantLightElement.h:
  • svg/SVGFEDistantLightElement.idl:
  • svg/SVGFEFloodElement.cpp:
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFloodElement.idl:
  • svg/SVGFEFuncAElement.cpp:
  • svg/SVGFEFuncAElement.h:
  • svg/SVGFEFuncAElement.idl:
  • svg/SVGFEFuncBElement.cpp:
  • svg/SVGFEFuncBElement.h:
  • svg/SVGFEFuncBElement.idl:
  • svg/SVGFEFuncGElement.cpp:
  • svg/SVGFEFuncGElement.h:
  • svg/SVGFEFuncGElement.idl:
  • svg/SVGFEFuncRElement.cpp:
  • svg/SVGFEFuncRElement.h:
  • svg/SVGFEFuncRElement.idl:
  • svg/SVGFEGaussianBlurElement.cpp:
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEImageElement.cpp:
  • svg/SVGFEImageElement.h:
  • svg/SVGFEImageElement.idl:
  • svg/SVGFELightElement.cpp:
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeElement.cpp:
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMergeElement.idl:
  • svg/SVGFEMergeNodeElement.cpp:
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMergeNodeElement.idl:
  • svg/SVGFEOffsetElement.cpp:
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFEOffsetElement.idl:
  • svg/SVGFEPointLightElement.cpp:
  • svg/SVGFEPointLightElement.h:
  • svg/SVGFEPointLightElement.idl:
  • svg/SVGFESpecularLightingElement.cpp:
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFESpecularLightingElement.idl:
  • svg/SVGFESpotLightElement.cpp:
  • svg/SVGFESpotLightElement.h:
  • svg/SVGFESpotLightElement.idl:
  • svg/SVGFETileElement.cpp:
  • svg/SVGFETileElement.h:
  • svg/SVGFETileElement.idl:
  • svg/SVGFETurbulenceElement.cpp:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGFilterElement.cpp:
  • svg/SVGFilterElement.h:
  • svg/SVGFilterElement.idl:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/graphics/SVGResourceFilter.cpp:
  • svg/graphics/SVGResourceFilter.h:
  • svg/graphics/cairo/SVGResourceFilterCairo.cpp:
  • svg/graphics/cg/SVGResourceFilterCg.cpp:
  • svg/graphics/cg/SVGResourceFilterCg.mm:
  • svg/graphics/filters/SVGDistantLightSource.h:
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp:
  • svg/graphics/filters/SVGFEConvolveMatrix.h:
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp:
  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFEDisplacementMap.cpp:
  • svg/graphics/filters/SVGFEDisplacementMap.h:
  • svg/graphics/filters/SVGFEFlood.cpp:
  • svg/graphics/filters/SVGFEFlood.h:
  • svg/graphics/filters/SVGFEGaussianBlur.cpp:
  • svg/graphics/filters/SVGFEGaussianBlur.h:
  • svg/graphics/filters/SVGFEImage.cpp:
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFEMerge.cpp:
  • svg/graphics/filters/SVGFEMerge.h:
  • svg/graphics/filters/SVGFEMorphology.cpp:
  • svg/graphics/filters/SVGFEMorphology.h:
  • svg/graphics/filters/SVGFEOffset.cpp:
  • svg/graphics/filters/SVGFEOffset.h:
  • svg/graphics/filters/SVGFESpecularLighting.cpp:
  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGFETile.cpp:
  • svg/graphics/filters/SVGFETile.h:
  • svg/graphics/filters/SVGFETurbulence.cpp:
  • svg/graphics/filters/SVGFETurbulence.h:
  • svg/graphics/filters/SVGFilterEffect.cpp:
  • svg/graphics/filters/SVGFilterEffect.h:
  • svg/graphics/filters/SVGLightSource.cpp:
  • svg/graphics/filters/SVGLightSource.h:
  • svg/graphics/filters/SVGPointLightSource.h:
  • svg/graphics/filters/SVGSpotLightSource.h:
  • svg/graphics/filters/cg/SVGFEHelpersCg.h:
  • svg/graphics/filters/cg/SVGFEHelpersCg.mm:
  • svg/graphics/filters/cg/SVGFilterEffectCg.mm:
  • svg/graphics/filters/cg/WKArithmeticFilter.h:
  • svg/graphics/filters/cg/WKArithmeticFilter.m:
  • svg/graphics/filters/cg/WKComponentMergeFilter.h:
  • svg/graphics/filters/cg/WKComponentMergeFilter.m:
  • svg/graphics/filters/cg/WKDiffuseLightingFilter.h:
  • svg/graphics/filters/cg/WKDiffuseLightingFilter.m:
  • svg/graphics/filters/cg/WKDiscreteTransferFilter.h:
  • svg/graphics/filters/cg/WKDiscreteTransferFilter.m:
  • svg/graphics/filters/cg/WKDisplacementMapFilter.h
  • svg/graphics/filters/cg/WKDisplacementMapFilter.m:
  • svg/graphics/filters/cg/WKDistantLightFilter.h:
  • svg/graphics/filters/cg/WKDistantLightFilter.m:
  • svg/graphics/filters/cg/WKGammaTransferFilter.h:
  • svg/graphics/filters/cg/WKGammaTransferFilter.m:
  • svg/graphics/filters/cg/WKIdentityTransferFilter.h:
  • svg/graphics/filters/cg/WKIdentityTransferFilter.m:
  • svg/graphics/filters/cg/WKLinearTransferFilter.h:
  • svg/graphics/filters/cg/WKLinearTransferFilter.m:
  • svg/graphics/filters/cg/WKNormalMapFilter.h:
  • svg/graphics/filters/cg/WKNormalMapFilter.m:
  • svg/graphics/filters/cg/WKPointLightFilter.h:
  • svg/graphics/filters/cg/WKPointLightFilter.m:
  • svg/graphics/filters/cg/WKSpecularLightingFilter.h:
  • svg/graphics/filters/cg/WKSpecularLightingFilter.m:
  • svg/graphics/filters/cg/WKSpotLightFilter.h:
  • svg/graphics/filters/cg/WKSpotLightFilter.m:
  • svg/graphics/filters/cg/WKTableTransferFilter.h:
  • svg/graphics/filters/cg/WKTableTransferFilter.m:
  • svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
  • svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm:
  • svg/graphics/qt/SVGResourceFilterQt.cpp:
  • svg/graphics/skia/SVGResourceFilterSkia.cpp:
  • svg/svgtags.in:

*WebKit/mac/
2009-05-28 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added new build flag --filters. More details in WebCore/ChangeLog.

  • Configurations/FeatureDefines.xcconfig:

*.
2009-05-28 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Enable the new build flag --filters for Gtk. More details in WebCore/ChangeLog.

  • configure.ac:

*JavaScriptCore/
2009-05-28 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added new build flag --filters for Mac. More details in WebCore/ChangeLog.

  • Configurations/FeatureDefines.xcconfig:

*WebKitTools
2009-05-28 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added new build flag --filters. More details in WebCore/ChangeLog.

  • Scripts/build-webkit:
14:05 Changeset [44252] by brettw@chromium.org
  • 2 edits in trunk/WebCore

2009-05-28 Brett Wilson <brettw@chromium.org>

Unreviewed, build fix.

https://bugs.webkit.org/show_bug.cgi?id=26067

Add casts for scale function to make more explicit what is happening
and fix a compiler warning.

  • platform/graphics/IntSize.h: (WebCore::IntSize::scale):
13:56 Changeset [44251] by mrowe@apple.com
  • 2 edits in trunk/WebKit

Symlink WebKitPluginHost.app in to place if needed.

Rubber-stamped by Anders Carlsson.

  • WebKit.xcodeproj/project.pbxproj:
12:37 Changeset [44250] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.8

Tagging 1.1.8.

12:27 Changeset [44249] by weinig@apple.com
  • 4 edits in trunk/WebCore

2009-05-28 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Remove the returnValueSlot concept from JSDOMWindowBase. Now that windows
are not cleared on navigation it is no longer necessary.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData): (WebCore::JSDOMWindowBase::willRemoveFromWindowShell):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::showModalDialog):
11:35 Changeset [44248] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=26048
navigation-policy-decision-requested documentation incomplete

Fix documentation for all policy decision request signals, to
mention that an actual decision is expected when you return TRUE,
meaning that you handled the signal.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
11:33 Changeset [44247] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Mention the implementation of the new AtkText methods.

  • NEWS:
11:20 Changeset [44246] by xan@webkit.org
  • 5 edits
    1 add in trunk

2009-05-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo and Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Add new test file for ATK.

  • GNUmakefile.am:

WebCore:

2009-05-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo and Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Implement atk_text_get_text_{at,after,before}_offset.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

WebKit/gtk:

2009-05-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo and Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

New test file for ATK functionality.

  • tests/testatk.c: Added. (bail_out): (test_get_text_function): (test_webkit_atk_get_text_at_offset): (main):
11:04 Changeset [44245] by zimmermann@webkit.org
  • 5 edits in trunk/WebCore

Rubber-stamped by Darin Adler.
Remove unnecessary destructor from InputElementData/OptionElementData.

10:50 Changeset [44244] by sfalken@apple.com
  • 3 edits in tags/Safari-6530.13.1/WebCore

Merge r44233.

10:49 Changeset [44243] by zimmermann@webkit.org
  • 9 edits in trunk/WebCore

Reviewed by Darin Adler.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=26062

Refactor code from all virtual methods in HTMLSelectElement (that are also needed for WMLSelectElement)
in the recently introduced SelectElement abstract base class. Follow the same design sheme that InputElement uses.

10:48 Changeset [44242] by kov@webkit.org
  • 2 edits in trunk

2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Fix webkitgtk_cleanfiles to clean gtk-doc-related files in the
correct directory, so that we pass make distcheck.

  • GNUmakefile.am:
10:46 Changeset [44241] by aroben@apple.com
  • 2 edits in trunk/WebCore

Don't try to use the new combobox parts on Vista in Classic mode

Fixes:
<rdar://problem/6929277> REGRESSION (r42289+r42350): Windows Classic
theme: drop down lists in Preferences get a line/square
<rdar://problem/6929298> REGRESSION (r42289): Windows Classic: drop
down lists are black with a circle on many sites

Reviewed by Steve Falkenburg.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintMenuList): Only use the new combobox parts when we have a theme (i.e., when we're not in Classic mode). When we don't have a theme, fall back to the pre-r42289 code.
10:36 Changeset [44240] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.13.1

New tag.

10:35 Changeset [44239] by sfalken@apple.com
  • 1 delete in tags/Safari-6530.13.1

Delete incorrect tag.

10:34 Changeset [44238] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.13.1

New tag.

10:29 Changeset [44237] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

2009-05-27 Peter Kasting <pkasting@google.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=25659
Avoid calling frameCount() unnecessarily (which could lead to extra
GIF decoding).

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedDataIfNecessary):
09:58 Changeset [44236] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Document changes worth noting for 1.1.8.

  • NEWS:
09:55 Changeset [44235] by bfulgham@webkit.org
  • 16 edits
    6 adds in trunk

WebCore:

2009-05-28 Simon Fraser <simon.fraser@apple.com>

Reviewed by Oliver Hunt.


https://bugs.webkit.org/show_bug.cgi?id=8736

Tests: fast/borders/border-radius-constraints.html

fast/borders/border-radius-split-inline.html


When the sum of the corner radii on a side exceed the length of the side,
reduce the radii according to CSS 3 rules.


Add RenderStyle::getBorderRadiiForRect() to fetch corner radii, applying
the constraints. Use that for painting borders, box-shadow, clipping replaced
elements

  • platform/graphics/IntSize.h: (WebCore::IntSize::scale): Add a scale method that scales by a float (using C rounding rules, like IntRect::scale()).
  • platform/graphics/Path.cpp: Make the QUARTER const static.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip): Use getBorderRadiiForRect to fetch border radii.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use getBorderRadiiForRect to fetch border radii.

(WebCore::RenderBoxModelObject::paintBorder):
Use getBorderRadiiForRect to fetch border radii, and fix a bug when drawing
borders for split inlines, which used to apply the radii for each segment,
and no longer does.

(WebCore::RenderBoxModelObject::paintBoxShadow):
Use getBorderRadiiForRect to fetch border radii.

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): Use getBorderRadiiForRect to fetch border radii for clipping.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Use getBorderRadiiForRect to fetch border radii for clipping.
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getBorderRadiiForRect): New bottleneck method to fetch corner radiil given a rect, applying the constraint rules.

LayoutTests:

2009-05-28 Simon Fraser <simon.fraser@apple.com>

Reviewed by Oliver Hunt.


https://bugs.webkit.org/show_bug.cgi?id=8736

  • fast/borders/border-radius-constraints.html: Added.
  • platform/mac/fast/borders/border-radius-constraints-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-constraints-expected.png: Added.
  • platform/mac/fast/borders/border-radius-constraints-expected.txt: Added.


Test that corner radii are constrained according to CSS3 rules.

  • fast/borders/border-radius-huge-assert.html:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.checksum:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.png:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.txt:


Now that we constrain border-radius, update the text of the test, and the
expected result.


  • fast/borders/border-radius-split-inline.html: Added.
  • platform/mac/fast/borders/border-radius-split-inline-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/mac/fast/borders/border-radius-split-inline-expected.txt: Added.


New test for border-radius on a split inline.


  • fast/box-shadow/border-radius-big.html:
  • platform/mac/fast/box-shadow/border-radius-big-expected.checksum:
  • platform/mac/fast/box-shadow/border-radius-big-expected.png:
  • platform/mac/fast/box-shadow/border-radius-big-expected.txt:

Now that we constrain border-radius, update the text of the test, and the
expected result.

09:50 Changeset [44234] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-05-28 Olivier DOLE <odole@pleyo.com>

Reviewed by Maciej.

Add options to sunspider-compare-results to know which test suite to
compare (see bug #15941).

  • Scripts/sunspider-compare-results:
09:46 Changeset [44233] by mitz@apple.com
  • 3 edits in branches/WWDC-2009-branch/WebCore

Windows build fix after r44178

09:23 Changeset [44232] by ap@webkit.org
  • 9 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26005
Optimization for XPath * does not preserve context size

Test: fast/xpath/position.html

Fixed the bug by removing the incorrect optimization, and made enough micro-optimizations to
get a performance progression on my tests.

  • xml/XPathPath.h: Removed broken optimizeStepPair().
  • xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Style fix. (WebCore::XPath::LocationPath::appendStep): Don't call optimizeStepPair(). (WebCore::XPath::LocationPath::insertFirstStep): Ditto. (WebCore::XPath::Path::Path): Style fix.
  • xml/XPathStep.cpp: (WebCore::XPath::primaryNodeType): Turned this member function into a static inline helper. (WebCore::XPath::nodeMatches): Ditto. Don't check for namespace axis, which is unsupported (and might never be). (WebCore::XPath::Step::nodesInAxis): Updated for the new nodeMatches() signature.
  • xml/XPathStep.h: (WebCore::XPath::Step::NodeTest::data): (WebCore::XPath::Step::NodeTest::namespaceURI): Made these data members AtomicString to avoid repeated conversions. This is the biggest performance win here.
  • xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Reserve some capacity upfront.
09:20 Changeset [44231] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-28 Stephen White <senorblanco@chromium.org>

Reviewed by Dimitri Glazkov.

When creating a linear or radial gradient with a single stop
at offset 1.0, the Skia layer was allocating 3 stops, but only
filling 2, leaving one uninitialized. Only 2 stops are necessary
in this case, at offsets (0.0, 1.0).

http://bugs.webkit.org/show_bug.cgi?id=26063

Covered by: LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b.svg

LayoutTests/svg/custom/gradient-stop-corner-cases.svg
LayoutTests/svg/custom/js-late-gradient-and-object-creation.svg

  • platform/graphics/skia/GradientSkia.cpp: (WebCore::totalStopsNeeded):
09:14 Changeset [44230] by dglazkov@chromium.org
  • 8 edits in trunk/WebCore

2009-05-28 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=26041
Allow adding resource source to WebInspector.SourceFrame asynchronously.

Provide common implementation for InspectorController::addResourceSourceToFrame and
InspectorController::addSourceToFrame methods.

  • bindings/js/JSInspectorControllerCustom.cpp:
  • bindings/v8/custom/V8InspectorControllerCustom.cpp:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addResourceSourceToFrame):
  • inspector/InspectorController.h:
  • inspector/InspectorController.idl:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.revealLine): (WebInspector.SourceFrame.prototype.highlightLine): (WebInspector.SourceFrame.prototype._loaded): (WebInspector.SourceFrame.prototype._isContentLoaded):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): (WebInspector.SourceView.prototype._contentLoaded):
08:45 Changeset [44229] by xan@webkit.org
  • 2 edits in trunk

2009-05-28 Xan Lopez <xlopez@igalia.com>

Bump version numbers in preparation for 1.1.8 release.

  • configure.ac:
07:52 Changeset [44228] by xan@webkit.org
  • 6 edits in trunk/WebKit/gtk

2009-05-27 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=26039
[GTK] WebKitWebHistoryItem lifetime fixes

Modify the management of history items by the BackForward list.

Having the objects add themselves to a hash table with an extra
reference made impossible for the cleanup code in the dispose
method to be ever called in normal conditions, since dispose is
called before getting rid of the last reference, which the objects
were making to themselves. Get rid of this extra reference and
move the responsibility of the cleanup to the BackForward list
itself, which effectively owns the WebKitWebHistoryItems now.

Also, update the tests to reflect this change.

  • tests/testwebbackforwardlist.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): (test_webkit_web_back_forward_list_add_item):
  • tests/testwebhistoryitem.c: (web_history_item_fixture_setup): (web_history_item_fixture_teardown):
  • webkit/webkitprivate.h:
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_dispose): (webkit_web_back_forward_list_class_init):
  • webkit/webkitwebhistoryitem.cpp: (webkit_history_items): (webkit_history_item_add): (webkit_web_history_item_dispose): (WebKit::kit):
07:52 Changeset [44227] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=26039
[GTK] WebKitWebHistoryItem lifetime fixes

Delete the BackForwardList before the Page, otherwise the references
to the WebKitWebHistoryItems will be gone.

  • webkit/webkitwebview.cpp: (webkit_web_view_dispose):
05:04 Changeset [44226] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-28 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Xan Lopez.

After r44177 we had a problem when increasing the size
of the window the scrollbars stayed and were not hidden.
This was due WebCore giving up on the Scrollbar as it became
unnecessary but the GtkAdjustment remained unchanged.
So from the point of view of the GtkScrolledWindow scrolling
was still necessary and the GtkScrollbar kept being displayed.

Solve the issue by resetting the GtkAdjustment in the
destructor of ScrollbarGtk.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::~ScrollbarGtk):
01:04 Changeset [44225] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

WebCore:

2009-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Clean up window.open()'s use of lexical and dynamic scope.

(Added one unreviewed tweak: use dynamicFrame instead of lexicalFrame
for DOMWindow::allowPopUp.)

Test: http/tests/security/frameNavigation/context-for-window-open.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::toDynamicFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::createWindow):

LayoutTests:

2009-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Test whether lexical or dynamic scope is used for window.open().

  • http/tests/security/frameNavigation/context-for-window-open-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-window-open.html: Added.
  • http/tests/security/frameNavigation/resources/middle-frame-for-location.html:
00:31 Changeset [44224] by abarth@webkit.org
  • 886 edits
    2 deletes in trunk

Revert 44221.

Note: See TracTimeline for information about the timeline view.