Timeline


and

06/12/09:

23:04 Changeset [44649] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2009-06-12 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=26367

Remove the global variables in bidi.cpp. Make a new struct, MidpointState, that holds all of the
midpoint information. Add the remaining global variables as arguments passed down through functions
as needed.

  • platform/text/BidiResolver.h: (WebCore::MidpointState::MidpointState): (WebCore::MidpointState::reset): (WebCore::BidiResolver::midpointState):
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::BidiRun::operator delete): (WebCore::chopMidpointsAt): (WebCore::checkMidpoints): (WebCore::addMidpoint): (WebCore::appendRunsForObject): (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::skipNonBreakingSpace): (WebCore::shouldCollapseWhiteSpace): (WebCore::requiresLineBox): (WebCore::RenderBlock::generatesLineBoxesForInlineChild): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::shouldSkipWhitespaceAfterStartObject): (WebCore::RenderBlock::findNextLineBreak):
22:03 Changeset [44648] by zecke@webkit.org
  • 2 edits in trunk/WebCore

Build fix for Qt. After recent ImageDeocder.h changes.

I want the original change to be backed out as the whole
Skia merging is going in the wrong direction. The discussion
will happen in the bugtracker.

https://bugs.webkit.org/show_bug.cgi?id=25709.

21:15 WebDevelopers edited by timothy@apple.com
(diff)
19:41 Changeset [44647] by jmalonzo@webkit.org
  • 4 edits in trunk

2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[Gtk] Enable more http/tests/navigation tests

  • platform/gtk/Skipped:

[Gtk] use strlen instead of g_utf8_strlen so we can enable more tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpHistoryItem):
19:31 Changeset [44646] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix: include cstdio so we can use sscanf

Gtk/Win Cairo build fix: use isASCIISpace instead of isspace
Suggested by Brent Fulgham

  • platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::decodeDatum):
18:23 Changeset [44645] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

2009-06-12 Peter Kasting <pkasting@google.com>

Yet another Skia bustage fix.

  • platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::setSize): Avoid symbol name clash. The better fix is to take an IntSize(); I'll do that later.
18:18 Changeset [44644] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

Make LiteralParser non-recursive

Reviewed by Geoff Garen.

Convert LiteralParser from using a simple recursive descent parser
to a hand rolled PDA. Relatively simple conversion, but required
modifications to MarkedArgumentBuffer to make it more suitable as
a generic marked vector. I'll refactor and rename MarkedArgumentBuffer
in future as there are many other cases where it will be useful to
have such a class.

17:56 Changeset [44643] by pkasting@chromium.org
  • 3 edits in trunk/WebCore

2009-06-12 Peter Kasting <pkasting@google.com>

Fix remaining Cairo build bustage from
https://bugs.webkit.org/show_bug.cgi?id=25709 changes. Use
Vector<char> in place of std::string.

  • platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::setData): (WebCore::XBMImageDecoder::decodeHeader): (WebCore::XBMImageDecoder::decodeDatum):
  • platform/image-decoders/xbm/XBMImageDecoder.h:
17:47 Changeset [44642] by levin@chromium.org
  • 3 edits in trunk/JavaScriptCore

2009-06-12 David Levin <levin@chromium.org>

Reviewed by NOBODY (build fix for windows).

Adjust the exports for JSC on Windows like what was done for OSX in
the previous commit.

17:41 Changeset [44641] by levin@chromium.org
  • 6 edits in trunk

JavaScriptCore:

2009-06-12 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

UString shouldn't create sharedBuffer for SmallStrings.
https://bugs.webkit.org/show_bug.cgi?id=26360

The methods changed are not used by JSC, so there is no JS perf impact. However,
there is a potential DOM perf impact, so I re-ran several of the tests that
I ran previously and ensured that the perf stay the same which caused me to
adjust the minLengthToShare.

  • JavaScriptCore.exp:
  • runtime/UString.cpp: (JSC::UString::Rep::sharedBuffer):

Determines if the buffer being shared is big enough before doing so.
Previously, BaseString::sharedBuffer was called but it would only know
the length of the base string (BaseString::len) which may not be the same
as the string being shared (Rep::len).

(JSC::UString::BaseString::sharedBuffer):

This is now only be used by Rep::sharedBuffer. which does the length check.

  • runtime/UString.h:

WebCore:

2009-06-12 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

UString shouldn't create sharedBuffer for SmallStrings.
https://bugs.webkit.org/show_bug.cgi?id=26347

Change the call to use the method UString::Rep::sharedBuffer due
to changes in UString.

No noticable change in behavior, so no test.

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::create):
17:11 Changeset [44640] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2009-06-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=26095

Fix crash when a renderer for an anonymous node is composited
by null-checking renderer()->node().

Test: compositing/generated-content.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::rendererHasBackground): (WebCore::RenderLayerBacking::rendererBackgroundColor): (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): (WebCore::RenderLayerBacking::paintIntoLayer):
17:04 Changeset [44639] by pkasting@chromium.org
  • 3 edits in trunk/WebCore

2009-06-12 Peter Kasting <pkasting@google.com>

Fix Chromium and some of Cairo build bustage, fallout from
https://bugs.webkit.org/show_bug.cgi?id=25709 changes.

  • WebCore.vcproj/WebCore.vcproj: Add missing XBM decoder files.
  • platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::copyRowNTimes): Fix typo that broke Skia GIF decoding.
16:39 Changeset [44638] by beidson@apple.com
  • 4 edits
    1 copy
    4 moves
    3 adds in trunk/WebKitSite

2009-06-12 Brady Eidson <beidson@apple.com>

Reviewed by Oliver Hunt

Add a page indexing the various demo applications we have posted.

  • demos/index.html: Added.
  • nav.inc: Add a link to the demos page on the side bar
  • css/main.css: Add a style for date stamps based on the blog.
  • demos/calendar/index.html: Added to redirect to Calendar.html. I'm not moving Calendar.html to index.html as the Calendar.html url has already been published and we should keep it working.

Move the drosera test code to /misc, as it is no longer a meaningful demo:

  • demos/drosera: Removed.
  • demos/drosera/demo.js: Removed.
  • demos/drosera/drosera.png: Removed.
  • demos/drosera/index.html: Removed.
  • misc/drosera: Copied from demos/drosera.

Move the sticky notes example into /demos:

  • demos/sticky-notes: Added.
  • demos/sticky-notes/StickyNotes.manifest: Copied from misc/DatabaseExample.manifest.
  • demos/sticky-notes/deleteButton.png: Copied from misc/deleteButton.png.
  • demos/sticky-notes/deleteButtonPressed.png: Copied from misc/deleteButtonPressed.png.
  • demos/sticky-notes/index.html: Copied from misc/DatabaseExample.html.
  • misc/DatabaseExample.html: Changed to redirect to demos/sticky-notes/index.html. I'm not removing it altogether as the misc/DatabaseExample.html url has already been published and we should keep it working.
  • misc/DatabaseExample.manifest: Removed.
  • misc/deleteButton.png: Removed.
  • misc/deleteButtonPressed.png: Removed.
16:38 Changeset [44637] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-06-12 Simon Fraser <simon.fraser@apple.com>

Fix build when ACCELERATED_COMPOSITING is defined.

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::attachRootGraphicsLayer): (WebCore::EmptyChromeClient::setNeedsOneShotDrawingSynchronization): (WebCore::EmptyChromeClient::scheduleViewUpdate): Add stubs for the compositing-related ChromeClient methods.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition): (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): docWidth()/docHeight() became private. Use overflowWidth()/overflowHeight() instead, which matches what is used to size the WebHTMLView.
16:20 Changeset [44636] by dimich@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2009-06-12 jorlow <jorlow@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26356
http://crbug.com/14006
Create custom bindings for v8. The rest of these files are still
forked (so the review is happening on the chromium review site).
These bindings have been tested on a hacked up Chromium instance
(also running --single-process) and Android.

  • bindings/v8/custom/V8StorageCustom.cpp: Added.
16:20 Changeset [44635] by dimich@chromium.org
  • 3 edits in trunk/WebCore

2009-06-12 Dmitry Titov <dimich@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26359
[v8] Add XMLHttpRequest to WorkerContextExecutionProxy.

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object): Add type == V8ClassIndex::XMLHTTPREQUEST to the convertable types. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): same.
  • bindings/v8/WorkerContextExecutionProxy.h: fix typo in the comment.
15:55 Changeset [44634] by pkasting@chromium.org
  • 7 edits
    8 moves
    8 deletes in trunk/WebCore

2009-06-12 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part eight
Replace placeholder Cairo BMP, ICO, XBM decoders with real ones. Remove
all the decoders from skia/ since they are now just mirrors of the Cairo
ones.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon. Enable XBM decoding on Windows.
  • platform/graphics/skia/ImageSourceSkia.cpp:
  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon.
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.cpp.
  • platform/image-decoders/bmp/BMPImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.h.
  • platform/image-decoders/bmp/BMPImageReader.cpp: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.cpp.
  • platform/image-decoders/bmp/BMPImageReader.h: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.h.
  • platform/image-decoders/ico/ICOImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.cpp.
  • platform/image-decoders/ico/ICOImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.h.
  • platform/image-decoders/skia/BMPImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/BMPImageDecoder.h: Removed.
  • platform/image-decoders/skia/BMPImageReader.cpp: Removed.
  • platform/image-decoders/skia/BMPImageReader.h: Removed.
  • platform/image-decoders/skia/GIFImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/GIFImageDecoder.h: Removed.
  • platform/image-decoders/skia/GIFImageReader.cpp: Removed.
  • platform/image-decoders/skia/GIFImageReader.h: Removed.
  • platform/image-decoders/skia/ICOImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/ICOImageDecoder.h: Removed.
  • platform/image-decoders/skia/JPEGImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/JPEGImageDecoder.h: Removed.
  • platform/image-decoders/skia/PNGImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/PNGImageDecoder.h: Removed.
  • platform/image-decoders/skia/XBMImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/XBMImageDecoder.h: Removed.
  • platform/image-decoders/xbm/XBMImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.cpp.
  • platform/image-decoders/xbm/XBMImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.h.
15:41 Changeset [44633] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-12 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26191
Remove xmath include in MathExtras.h, because it is not needed and also
breaks VS2008 builds with TR1 turned on.

  • wtf/MathExtras.h: Removed xmath include.
15:24 Changeset [44632] by kov@webkit.org
  • 4 edits in trunk

2009-06-12 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25599
[GTK] Enable more tests

Implement dumping of status callback.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewStatusBarTextChanged): (main):
15:17 Web Inspector edited by timothy@apple.com
Changes to be more current. (diff)
15:06 Changeset [44631] by pkasting@chromium.org
  • 8 edits in trunk/WebCore

2009-06-11 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part seven
Update Skia's ImageDecoder.h with a few changes designed to reduce the
delta between specific implementations of ImageDecoder.h. Update
Cairo's ImageDecoder.h to sync up with the API changes in the Skia
version in the last two chage sets. Update Cairo's PNG/JPEG/GIF
decoders to use the APIs as well. All the Cairo image decoder changes
are direct copies of the Skia versions except ImageDecoder.h, which is
modified in the necessary ways for the differences between Cairo and
Skia.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() API.
  • platform/image-decoders/ImageDecoder.h: Sync up with Skia version. (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::copyRowNTimes): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setRGBA): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: Sync up with Skia version. (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow):
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Sync up with Skia version. (WebCore::JPEGImageDecoder::outputScanlines):
  • platform/image-decoders/png/PNGImageDecoder.cpp: Sync up with Skia version. (WebCore::PNGImageDecoder::rowAvailable):
  • platform/image-decoders/skia/ImageDecoder.h: Add various typedefs or helper functions to minimize differences with Cairo version. Reorder functions slightly to match reordering of Cairo's m_hasAlpha variable, which I moved to increase readability. (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::copyRowNTimes): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setRGBA): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/skia/JPEGImageDecoder.cpp: Add #include needed by JPEG headers on some platforms, plus comment.
14:36 Changeset [44630] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-06-12 Brent Fulgham <bfulgham@webkit.org>

Unreviewed build correction.

Revert accidental configuration checkin. Was not meant to
be part of the last changeset.

  • config.h:
14:34 Changeset [44629] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

(Accidentally missed a couple email addresses in the last patch)

14:25 Changeset [44628] by bfulgham@webkit.org
  • 9 edits in trunk/WebCore

2009-06-12 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26353
Corrects handling of Cairo fonts that were getting out of
sync due to default copy construction. Also refactors
some incorrect platform font destruction code that belongs
in the font object's destructor.

  • platform/graphics/win/FontPlatformData.h:
  • platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::~FontPlatformData):
  • platform/graphics/win/FontPlatformDataCairoWin.cpp: (WebCore::FontPlatformData::platformDataInit): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::setFont): (WebCore::FontPlatformData::~FontPlatformData):
  • platform/graphics/win/FontPlatformDataWin.cpp:
  • platform/graphics/win/SimpleFontDataCGWin.cpp:
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformWidthForGlyph):
  • platform/graphics/win/SimpleFontDataWin.cpp:
14:19 Changeset [44627] by pkasting@chromium.org
  • 8 edits in trunk

JavaScriptCore:

2009-06-12 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

  • ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.

WebCore:

2009-06-12 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

  • ChangeLog-2007-10-14: Update my email address.
  • ChangeLog-2008-08-10: Update my email address.

WebKit/mac:

2009-06-12 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

  • ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.

WebKit/win:

2009-06-12 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

  • ChangeLog: Update my email address.
13:00 QtWebKitTodo edited by andre.pedralho@openbossa.org
(diff)
11:02 Changeset [44626] by levin@chromium.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-12 Nate Chapin <japhet@google.com>

Reviewed by David Levin.

Upstream V8Helpers.

https://bugs.webkit.org/show_bug.cgi?id=26332

  • bindings/v8/V8Helpers.cpp: Added. (wrapNPObject): Moved from v8_helpers.cpp. (toV8Context): Moved from v8_helpers.cpp. (toV8Proxy): Moved from v8_helpers.cpp.
  • bindings/v8/V8Helpers.h: Added.
09:15 Changeset [44625] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

wx build fix. Adding JSONObject.cpp to the build.

08:55 Changeset [44624] by jberlin@apple.com
  • 4 edits in trunk/WebCore

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 44622)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,23 @@
+2009-06-12 Jessie Berlin <jberlin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24792
+ rdar://problem/6933055
+
+ Changes the radius in which cursor movement around the 4 arrow icon
+ while pan-scrolling does not cause scrolling from around 10 pixels to
+ 15 pixels, similar to what is found in IE and Firefox.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::setPanScrollCursor):
+ Factor out the no-pan-scroll radius.
+ * platform/ScrollView.h:
+ Create a constant for the no-pan-scroll radius.
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::panScrollFromPoint):
+ Factor out the no-pan-scroll radius.
+

2009-06-12 Xan Lopez <xlopez@igalia.com>


Reviewed by Gustavo Noronha.

Index: WebCore/page/EventHandler.cpp
===================================================================
--- WebCore/page/EventHandler.cpp (revision 44622)
+++ WebCore/page/EventHandler.cpp (working copy)
@@ -661,11 +661,10 @@ void EventHandler::setPanScrollCursor()

At the original click location we draw a 4 arrowed icon. Over this icon there won't be any scroll
So we don't want to change the cursor over this area

  • const int noScrollRadius = 9;
  • bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - noScrollRadius);
  • bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + noScrollRadius);
  • bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + noScrollRadius);
  • bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - noScrollRadius);

+ bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - ScrollView::noPanScrollRadius);
+ bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + ScrollView::noPanScrollRadius);
+ bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + ScrollView::noPanScrollRadius);
+ bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - ScrollView::noPanScrollRadius);

if (north) {

if (east)

Index: WebCore/platform/ScrollView.h
===================================================================
--- WebCore/platform/ScrollView.h (revision 44622)
+++ WebCore/platform/ScrollView.h (working copy)
@@ -214,7 +214,8 @@ public:

virtual void hide();
virtual void setParentVisible(bool);


  • Pan scrolling methods.

+ Pan scrolling.
+ static const int noPanScrollRadius = 15;

void addPanScrollIcon(const IntPoint&);
void removePanScrollIcon();


Index: WebCore/rendering/RenderLayer.cpp
===================================================================
--- WebCore/rendering/RenderLayer.cpp (revision 44622)
+++ WebCore/rendering/RenderLayer.cpp (working copy)
@@ -948,7 +948,6 @@ void RenderLayer::panScrollFromPoint(con

const int shortDistanceLimit = 100; We delimit a 200 pixels long square enclosing the original point
const int speedReducer = 2;
Within this square we divide the scrolling speed by 2


  • const int iconRadius = 10;

Frame* frame = renderer()->document()->frame();
if (!frame)

return;

@@ -965,9 +964,9 @@ void RenderLayer::panScrollFromPoint(con

int xDelta = currentMousePosition.x() - sourcePoint.x();
int yDelta = currentMousePosition.y() - sourcePoint.y();


  • if (abs(xDelta) < iconRadius) at the center we let the space for the icon

+ if (abs(xDelta) < ScrollView::noPanScrollRadius) at the center we let the space for the icon

xDelta = 0;

  • if (abs(yDelta) < iconRadius)

+ if (abs(yDelta) < ScrollView::noPanScrollRadius)

yDelta = 0;


Let's attenuate the speed for the short distances

07:44 Changeset [44623] by ariya@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-12 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Jan Michael Alonzo.

[Qt] Fix build break
https://bugs.webkit.org/show_bug.cgi?id=26340

06/11/09:

23:46 Changeset [44622] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25609
[GTK] Implement support for get_selection and get_n_selections

Only use the VisibleSelection object if it actually belongs to the
object we are using.

This is pretty hacky-ish, but I can't seem to find a direct API to
get the VisibleSelection for a given object, only the global one.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (selectionBelongsToObject): (webkit_accessible_text_get_n_selections): (webkit_accessible_text_get_selection):
17:58 Changeset [44621] by jparent@chromium.org
  • 2 edits
    1 add
    4 deletes in trunk/LayoutTests

2009-06-11 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=2628i
Converted LayoutTests\editing\deleting\4875189.html from a pixel test t

dumpAsText test

since it only checks whether the result contains exactly two paragraphs

or not.

  • editing/deleting/4875189-expected.txt: Added.
  • editing/deleting/4875189.html:
  • platform/mac/editing/deleting/4875189-expected.checksum: Removed.
  • platform/mac/editing/deleting/4875189-expected.png: Removed.
  • platform/mac/editing/deleting/4875189-expected.txt: Removed.
  • platform/qt/editing/deleting/4875189-expected.txt: Removed.
16:47 Changeset [44620] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-11 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

Add a test to perform an actual download.

  • tests/testdownload.c: (navigation_policy_decision_requested_cb): (notify_status_cb): (download_requested_cb): (test_webkit_download_perform): (main):
15:38 Changeset [44619] by kov@webkit.org
  • 5 edits in trunk/WebKit/gtk

2009-06-11 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

Fix crash when downloading, caused by assuming SoupMessage would
be there. This change factors the logic required to create a
ResourceRequest from a WebKitNetworkRequest into a core()
function, like we have for some other classes.

  • webkit/webkitdownload.cpp: (webkit_download_start):
  • webkit/webkitprivate.cpp: (WebKit::core):
  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_load_request):
15:17 Changeset [44618] by eric@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

2009-06-11 Eric Seidel <eric@webkit.org>

Rubber stamped by Dave Levin.

Add missing pixel results

  • platform/mac/editing/style/apply-through-end-of-document-expected.checksum: Added.
  • platform/mac/editing/style/apply-through-end-of-document-expected.png: Added.
  • platform/mac/fast/canvas/canvas-empty-image-pattern-expected.checksum: Copied from LayoutTests/platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum.
  • platform/mac/fast/canvas/canvas-empty-image-pattern-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.png.
  • platform/mac/fast/css/compare-content-style-expected.checksum: Added.
  • platform/mac/fast/css/compare-content-style-expected.png: Added.
  • platform/mac/fast/dynamic/anchor-lock-expected.checksum: Added.
  • platform/mac/fast/dynamic/anchor-lock-expected.png: Added.
  • platform/mac/fast/transforms/bounding-rect-zoom-expected.checksum: Added.
  • platform/mac/fast/transforms/bounding-rect-zoom-expected.png: Added.
  • platform/mac/webarchive/test-link-rel-icon-expected.checksum: Copied from LayoutTests/platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum.
  • platform/mac/webarchive/test-link-rel-icon-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.png.
14:20 Changeset [44617] by eric@webkit.org
  • 4 edits in trunk/WebCore

Speculative fix

13:05 Changeset [44616] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.18

New tag.

13:05 Changeset [44615] by mrowe@apple.com
  • 1 delete in branches/Safari-6530.18

Hrm, this isn't where I should live.

13:03 Changeset [44614] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

13:02 Changeset [44613] by mrowe@apple.com
  • 1 copy in branches/Safari-6530.18

New tag.

12:59 Changeset [44612] by mrowe@apple.com
  • 13 edits in branches/WWDC-2009-branch

Merge r44591.

12:58 Changeset [44611] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

11:47 Changeset [44610] by oliver@apple.com
  • 5 edits in trunk

Lower stringify recursion limit to deal with small windows stack.

11:20 Changeset [44609] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-11 John Abd-El-Malek <jam@chromium.org>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=26306

Revert 42565 as it leads to DumpRenderTree crashing on startup because
Windows can't find CFURLCacheCopySharedURLCache in CoreNetwork.dll.

  • DumpRenderTree/win/DumpRenderTree.cpp:
11:15 Changeset [44608] by bfulgham@webkit.org
  • 8 edits
    4 adds in trunk

2009-06-11 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=25512
Handle texts after unfinished special tags (i.e., script, style, textarea,
title, xmp, and iframe) as the text node under the tags in view-source mode.
Before this change, all texts in unfinished special tags cannot be seen even in view-source mode.

10:57 Changeset [44607] by ariya@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

Fix compilation warnings
<https://bugs.webkit.org/show_bug.cgi?id=26015>

  • wtf/ThreadingNone.cpp: (WTF::ThreadCondition::wait): Fix compilation warning. (WTF::ThreadCondition::timedWait): Ditto.
10:39 Changeset [44606] by ariya@webkit.org
  • 2 edits in trunk

2009-06-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] Fix release build detection
https://bugs.webkit.org/show_bug.cgi?id=26267

  • WebKit.pri:
10:28 Changeset [44605] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-06-11 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Ariya Hidayat.

https://bugs.webkit.org/show_bug.cgi?id=26291

[Qt] build break in ImageDecoderQt.cpp.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::reset): (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::isSizeAvailable):
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::setSize):
09:34 Changeset [44604] by bfulgham@webkit.org
  • 3 edits in trunk/WebKitSite

2009-06-10 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

Fixes https://bugs.webkit.org/show_bug.cgi?id=26309.
Update a few items in the testing language to:
(1) Reflect results are now generated with Leopard (not Tiger)
(2) Explain how to generate pixel-level layout tests.

06:57 Changeset [44603] by hausmann@webkit.org
  • 1 edit
    7 deletes in trunk/WebCore

2009-06-11 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Ariya Hidayat.

Removed obsolete and unmaintained files from the old Symbian port.

04:59 QtWebKitTodo edited by hausmann@webkit.org
(diff)
04:58 QtWebKitTodo edited by hausmann@webkit.org
(diff)

06/10/09:

22:31 Changeset [44602] by bfulgham@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-10 Brent Fulgham <bfulgham@gmail.com>

Unreviewed build fix.
Reverted change to skip file, as Windows build is
still failing.

  • platform/win/Skipped:
21:59 Changeset [44601] by bfulgham@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

2009-06-05 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Eric Seidel.

Re-enable the video-zoom-controls test on Windows.

https://bugs.webkit.org/show_bug.cgi?id=25465

  • platform/win/Skipped:
  • platform/win/media: Added.
  • platform/win/media/video-zoom-controls-expected.checksum: Added.
  • platform/win/media/video-zoom-controls-expected.png: Added.
  • platform/win/media/video-zoom-controls-expected.txt: Added.
21:44 Changeset [44600] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-10 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Jan Alonzo.

[gtk] Change DumpRenderTree to use a GtkScrolledWindow instead of GtkFixed

Change the code to use GtkScrolledWindow and resize the GtkScrolledWindow
to pass more tests. Make sure the content is bigger than a thumbnail.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): (main):
20:14 Changeset [44599] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-10 Gustavo Noronha Silva <gns@gnome.org>

Disabling new tests, and tests that use features of DRT we don't
currently implement.

  • platform/gtk/Skipped:
19:48 Changeset [44598] by kov@webkit.org
  • 6 edits
    1 add in trunk

2009-06-10 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

Add unit tests for our WebKitNetworkRequest object.

  • GNUmakefile.am:

WebKit/gtk

2009-06-10 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

Make WebKitNetworkRequest a proper GObject, making URI and
SoupMessage properties. Also adding unit tests for creation and
destruction.

  • tests/testnetworkrequest.c: Added. (test_network_request_create_destroy): (test_network_request_properties): (main):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_get_property): (webkit_network_request_set_property): (webkit_network_request_class_init): (webkit_network_request_init): (webkit_network_request_constructor): (webkit_network_request_new_with_core_request): (webkit_network_request_new): (webkit_network_request_set_uri): (webkit_network_request_get_uri):
  • webkit/webkitnetworkrequest.h:
17:31 Changeset [44597] by pkasting@chromium.org
  • 11 edits in trunk/WebCore

2009-06-10 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part six
Miscellaneous tiny changes. The important bits here are the ANSI C++
compliance fix in skia/ImageDecoders.h (needed to compile this file on
non-MSVC) and some behavioral fixes for the XBM decoder that Chromium
unit tests partly exposed. Other changes are mostly cosmetic.

  • platform/image-decoders/ImageDecoder.h: Make some variables private again. This will break QTWebKit but those guys have agreed to wait on my finishing the ImageDecoder changes.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0). (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
  • platform/image-decoders/skia/BMPImageReader.cpp: (WebCore::BMPImageReader::decodeBMP): Make more in line with other decoders' comments and structure, use a ref to decrease verbosity. (WebCore::BMPImageReader::processRLEData): Use a ref to decrease verbosity. (WebCore::BMPImageReader::processNonRLEData): Use a ref to decrease verbosity.
  • platform/image-decoders/skia/GIFImageDecoder.cpp: Use IntPoint() instead of the redundant IntPoint(0, 0). (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0). (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
  • platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::copyRowNTimes): Fix ANSI violation that MSVC let me compile (!).
  • platform/image-decoders/skia/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
  • platform/image-decoders/skia/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
  • platform/image-decoders/skia/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::frameBufferAtIndex): Return 0 for non-zero indexes, don't try to decode unnecessarily after failure or when the size couldn't be computed, make more in line with other decoders' comments and structure, call RGBA32Buffer::setRect() appropriately.
17:16 Changeset [44596] by bfulgham@webkit.org
  • 1 edit
    1 move
    2 adds
    1 delete in trunk/LayoutTests

2009-06-10 Brent Fulgham <bfulgham@webkit.org>

Unreviewed build correction.

Clean up some stupid test mistakes, add pixel-level Mac tests
for the new zero-radius gradient test.

16:22 Changeset [44595] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Build correction for @r44574 (missing expected results).
See https://bugs.webkit.org/show_bug.cgi?id=26059.

15:47 Changeset [44594] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

Clear the frame name before we run each tests so we don't get
"someFloaString" or "3" in the target frame name.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
15:40 BuildingQtOnLinux edited by tonikitoo@gmail.com
(diff)
15:37 BuildingQtOnLinux edited by tonikitoo@gmail.com
(diff)
15:37 BuildingQtOnLinux edited by tonikitoo@gmail.com
(diff)
14:54 Changeset [44593] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

Fix collapsing empty shadow nodes in textareas.

13:55 Changeset [44592] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25609
[GTK] Implement support for get_selection and get_n_selections

Implement atk_text_get_n_selections.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_n_selections):
13:37 Changeset [44591] by mitz@apple.com
  • 13 edits in trunk

WebCore:

Reviewed by Anders Carlsson.

  • fix <rdar://problem/6958664> REGRESSION (r42665): When I drag to pan a Google map in iPhoto Places, it drags a map tile instead

Calling stopLoadRequest() from notifyFinished() removed the
ScriptElementData from the CachedScript's client set, which could make
it eligible for purging. The fix is to call removeClient() only after
executing the script, which protects it from being purged while it is
in the document's queue of scripts to execute soon.

  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::execute): Call removeClient() here. (WebCore::ScriptElementData::notifyFinished): Instead of calling stopLoadRequest(), which calls removeClient(), just reset m_cachedScript.

WebKitTools:

Reviewed by Adele Peterson.

  • add a LayoutTestController method for temporarily changing the WebKit cache model
  • DumpRenderTree/LayoutTestController.cpp: (setCacheModelCallback): Added. Calls LayoutTestController::setCacheModel() with the first argument as an integer. (LayoutTestController::staticFunctions): Added setCacheModel.
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setCacheModel):
  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): Reset the cache model to WebCacheModelDocumentBrowser.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setCacheModel): Added. Calls -[WebPreferences setCacheModel:].
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCacheModel):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setCacheModel):

LayoutTests:

Reviewed by Adele Peterson.

  • updated test to cover <rdar://problem/6958664> REGRESSION (r42665): When I drag to pan a Google map in iPhoto Places, it drags a map tile instead
  • fast/dom/HTMLScriptElement/nested-execution.html:
  • fast/dom/HTMLScriptElement/resources/nested-execution.js:
13:36 Changeset [44590] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Mark Rowe and Eric Seidel.

Update WebInspector localizedStrings.js with new resource tracking strings
https://bugs.webkit.org/show_bug.cgi?id=26247

  • English.lproj/localizedStrings.js:
12:43 Changeset [44589] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.9

Tagging 1.1.9.

12:22 Changeset [44588] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android specific files.
https://bugs.webkit.org/show_bug.cgi?id=26280

12:21 Changeset [44587] by bfulgham@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android specific file to WebCore/platform/android (part 9).
https://bugs.webkit.org/show_bug.cgi?id=26266

12:19 Changeset [44586] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android platform specific files.
https://bugs.webkit/org/show_bug.cgi?id=26265 (part 8).

12:18 Changeset [44585] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform. (part 6).
https://bugs.webkit.org/show_bug.cgi?id=26264

12:11 Changeset [44584] by bfulgham@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 7).
https://bugs.webkit.org/show_bug.cgi?id=23296

12:09 Changeset [44583] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 5).
https://bugs.webkit.org/show_bug.cgi?id=23296

12:06 Changeset [44582] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 4).
https://bugs.webkit.org/show_bug.cgi?id=23296

12:05 Changeset [44581] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 3).
https://bugs.webkit.org/show_bug.cgi?id=23296

12:01 Changeset [44580] by bfulgham@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 2).
https://bugs.webkit.org/show_bug.cgi?id=23296

11:46 Changeset [44579] by levin@chromium.org
  • 6 edits
    1 copy in trunk/WebCore

2009-06-10 Nate Chapin <japhet@google.com>

Reviewed by David Levin.

Finish moving V8Custom from src.chromium.org to svn.webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=26258

  • bindings/v8/custom/V8CustomBinding.cpp: Finished upstreaming. (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp. (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp. (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp. (WebCore::V8Custom::GetTargetFrame): Moved from v8_custom.cpp. (WebCore::V8Custom::DowncastSVGPathSeg): Moved from v8_custom.cpp.
  • bindings/v8/custom/V8CustomBinding.h: Finished upstreaming.
  • bindings/v8/custom/V8DatabaseCustom.cpp: Updated includes.
  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Updated includes.
  • bindings/v8/custom/V8SQLTransactionCustom.cpp: Updated includes.
  • bindings/v8/custom/V8WebKitPointConstructor.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp.
11:21 Changeset [44578] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

2009-06-05 Takeshi Yoshino <tyoshino@google.com>

Reviewed by NOBODY (OOPS!).

https://bugs.webkit.org/show_bug.cgi?id=26214
Bug 26214: RenderTextControl: Remove ASSERT for checking that visiblePositionForIndex()'s return is not null.

11:18 Changeset [44577] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

News for 1.1.9.

  • NEWS:
11:16 Changeset [44576] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-06-04 Roland Steiner <rolandsteiner@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26197
Bug 26197: Incorrect variable initialization in PlatformContextSkia.cpp

11:04 Changeset [44575] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

2009-06-10 Dean McNamee <deanm@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26061
Make sure filling a canvas pattern with an empty image doesn't crash.

10:57 Changeset [44574] by bfulgham@webkit.org
  • 4 edits
    1 add in trunk

Correct Bug #26059.
https://bugs.webkit.org/show_bug.cgi?id=26059.

10:46 Changeset [44573] by pkasting@chromium.org
  • 5 edits in trunk/WebCore

2009-06-10 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part five
Rewrite users of ImageDecoder.h to use "safe" API calls, Skia side.
This tweaks the RGBA32Buffer interfaces to be implementable by Cairo as
well and modifies Skia's usage of those interfaces accordingly. Once a
similar change lands on the Cairo side, the Skia and Cairo decoders
should be identical except for the implementation of RGBA32Buffer.

  • platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() function.
  • platform/image-decoders/skia/BMPImageReader.cpp: (WebCore::BMPImageReader::processNonRLEData): Use new RGBA32Buffer::zeroFill() function.
  • platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow): Rewrite to use RGBA32Buffer::setRGBA(x, y, ...) calls as well as other RGBA32Buffer interface calls instead of knowing the underlying types inside the buffer; also try and add clarity.
  • platform/image-decoders/skia/ImageDecoder.h: Removed bitmap(), width(), and height(). (WebCore::RGBA32Buffer::zeroFill): Added. (WebCore::RGBA32Buffer::copyBitmapData): Avoid using bitmap(), which is going away. (WebCore::RGBA32Buffer::copyRowNTimes): Added. (WebCore::RGBA32Buffer::setSize): Use new zeroFill() function. (WebCore::RGBA32Buffer::asNewNativeImage): Added. (WebCore::RGBA32Buffer::setRGBA): Condensed two versions into one that takes coordinates instead of a raw pointer.
10:36 Changeset [44572] by xan@webkit.org
  • 2 edits in trunk

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Version bump in preparation for 1.1.9 release.

  • configure.ac:
10:27 Changeset [44571] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25671
[GTK] Implement support for set_caret_offset

Make an implementation that actually works.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_set_caret_offset):
10:26 Changeset [44570] by bfulgham@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-06-09 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

Clear the frame name before we run each tests so we don't get
"someFloaString" or "3" in the target frame name.

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_clear_main_frame_name):
10:25 Changeset [44569] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-10 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26294

Make sure all member variables are initialized so that the default
assignment operator and copy constructors do not read uninitialized
memory.

  • platform/network/ResourceResponseBase.cpp:
10:18 Changeset [44568] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

2009-06-10 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Update main resource meta-data when resource tracking is disabled.

https://bugs.webkit.org/show_bug.cgi?id=26253

  • inspector/InspectorController.cpp: (WebCore::InspectorController::getTrackedResource): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
  • inspector/InspectorController.h:
10:17 Changeset [44567] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25609
[GTK] Implement support for get_selection and get_n_selections

Implement atk_text_get_selection.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_selection):
10:03 Changeset [44566] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not check if our parent class has the finalize method, it's
guaranteed to be there.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_finalize):
09:25 Changeset [44565] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Brent Fulgham <bfulgham@webkit.org>

Build correct for Windows Cairo targets.

  • WebCore.vcproj/WebCore.vcproj: Disable warning 4611 (interaction between '_setjmp' and C++ object destruction is non-portable) for the two Cairo targets. This used to be disabled in a #pragma, but recent refactoring removed these lines.
09:20 Changeset [44564] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-10 Brent Fulgham <bfulgham@webkit.org>

Build fix for Windows target.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Correct missing </File> tag after @r44550 that prevents the project from being loaded in the Visual Studio IDE.
09:06 QtWebKitTodo edited by andre.pedralho@openbossa.org
(diff)
08:37 Changeset [44563] by hausmann@webkit.org
  • 4 edits in trunk/WebCore

2009-06-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Fix the build of PluginView on Qt with 64-bit where we disable plugins
at compile time.

Use the FooNone.cpp files at compile-time.

08:32 Changeset [44562] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Qt build.

ImageDecoderQt needs m_size and m_sizeAvailable to be protected.

08:21 Changeset [44561] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Use absolute path for install_name on Mac

07:48 Changeset [44560] by ariya@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-06-10 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Ariya Hidayat.

Documented ResolveRule and StylePriority enum values as well as their use in
QWebElement::styleProperty and QWebElement::setStyleProperty methods.

Based on the work of Simon Hausmann.

  • Api/qwebelement.cpp: (QWebElement::styleProperty): (QWebElement::setStyleProperty):
  • Api/qwebelement.h:
06:10 Changeset [44559] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-08 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Reduce duplicated code to access the text of a AtkText
object. doAXStringForRange calls text() internally, so we are
doing exactly the same after the change.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getGailTextUtilForAtk): (getPangoLayoutForAtk):
06:10 Changeset [44558] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Pass a PangoLayout to the GailTextUtil function calls.

It's needed for LINE boundary calls to work correctly.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (updateLayout): (getPangoLayoutForAtk): (webkit_accessible_text_get_text_after_offset): (webkit_accessible_text_get_text_at_offset):
06:10 Changeset [44557] by xan@webkit.org
  • 7 edits in trunk

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Add new dependency on the Gail utils library, needed for our a11y
implementation.

  • GNUmakefile.am:
  • configure.ac:

WebCore:

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Use GailUtilText instead of my crappy partial reimplementation of
it. This should add support for LINE boundaries too, although it's
mostly untested for now.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getGailTextUtilForAtk): (webkit_accessible_text_get_text_after_offset): (webkit_accessible_text_get_text_at_offset):

WebKit/gtk:

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Update test for new implementation (it fixes two bugs and adds
actual implementations for LINE boundaries).

  • tests/testatk.c: (test_webkit_atk_get_text_at_offset):
03:41 Changeset [44556] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix: include <stdio.h> as it is required in jpeglib.h

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

06/09/09:

23:18 Changeset [44555] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Have sunspider-compare-results use the system version of the jsc
command line binary as there's no good reason to rebuild from source
to simply compare results.

Reviewed by Sam Weinig.

  • Scripts/sunspider-compare-results:
23:18 Changeset [44554] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-06-09 Gavin Barraclough <barraclough@apple.com>

Rubber Stamped by Mark Rowe.

Tidy up a couple of comments.

  • assembler/ARMv7Assembler.h:

Fix date in copyright, neaten up a couple of comments.

  • assembler/MacroAssemblerARMv7.h:

Fix date in copyright.

19:23 Changeset [44553] by pkasting@chromium.org
  • 11 edits in trunk/WebCore

2009-06-09 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part four
Most of the remaining Cairo changes needed before merging Skia/Cairo
image decoders. Most of these involve plumbing more error detection and
handling (or, in some cases, merely the capability to detect errors, as
e.g. Skia detects and handles image allocation failure while Cairo
currently doesn't). There is also some general cleanup and
simplification; RGBA32Buffer::m_height and all associated functions have
been removed (set but never used) and some places now rely on superclass
implementations.

  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::RGBA32Buffer): Remove m_height, ensureHeight() and associated stuff (WebCore::RGBA32Buffer::copyBitmapData): Add API function so refcounted backing stores (like Skia uses) can be used with GIFs (WebCore::RGBA32Buffer::setSize): Zero-fill image to avoid garbage (WebCore::RGBA32Buffer::height): Remove (WebCore::RGBA32Buffer::ensureHeight): Remove (WebCore::ImageDecoder::ImageDecoder): Keep member initialization in order, force subclasses to go through size() instead of accessing m_size directly (WebCore::ImageDecoder::isSizeAvailable): Check that decoding hasn't failed (WebCore::ImageDecoder::size): Check that decoding hasn't failed (WebCore::ImageDecoder::setSize): Protect against integer overflow (WebCore::ImageDecoder::isOverSize): Protect against integer overflow
  • platform/image-decoders/gif/GIFImageDecoder.cpp: Remove prepEmptyFrameBuffer() (WebCore::GIFImageDecoder::isSizeAvailable): Rely on superclass isSizeAvailable() for better failure handling (WebCore::GIFImageDecoder::sizeNowAvailable): Add return values for better failure handling, rely on superclass setSize() for overflow protection (WebCore::GIFImageDecoder::initFrameBuffer): Add return values for better failure handling, remove prepEmptyFrameBuffer(), use RGBA32Buffer::setSize() to handle potential allocation failures (won't happen with Cairo port, can in Skia), use RGBA32Buffer::copyBitmapData() so backing store can be refcounted internally (Cairo won't be, Skia is), rely on superclass size() for better failure handling (WebCore::GIFImageDecoder::haveDecodedRow): Fix style violation, remove RGBA32Buffer::ensureHeight() (WebCore::GIFImageDecoder::frameComplete): Remove RGBA32Buffer::ensureHeight()
  • platform/image-decoders/gif/GIFImageDecoder.h: Remove prepEmptyFrameBuffer(), add return values for better failure handling
  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::do_lzw): Protect against array overflow, add comments (GIFImageReader::read): Protect against array overflow, be more tolerant of bad data, better failure handling
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Remove MSVC-specific warning disable (bfulgham will move into build files) (WebCore::JPEGImageReader::decode): Better failure handling (WebCore::JPEGImageDecoder::isSizeAvailable): Rely on superclass isSizeAvailable() for better failure handling (WebCore::JPEGImageDecoder::outputScanlines): Use RGBA32Buffer::setSize() to handle potential allocation failures (won't happen with Cairo port, can in Skia), rely on superclass size() for better failure handling, remove RGBA32Buffer::ensureHeight()
  • platform/image-decoders/jpeg/JPEGImageDecoder.h: Rely on superclass setSize() for overflow protection
  • platform/image-decoders/png/PNGImageDecoder.cpp: Remove MSVC-specific warning disable (bfulgham will move into build files) (WebCore::PNGImageDecoder::PNGImageDecoder): Don't allocate a slot in the framebuffer cache until it's needed (WebCore::PNGImageDecoder::isSizeAvailable): Rely on superclass isSizeAvailable() for better failure handling (WebCore::PNGImageDecoder::frameBufferAtIndex): Don't allocate a slot in the framebuffer cache until it's needed (WebCore::PNGImageDecoder::decode): Don't allocate a slot in the framebuffer cache until it's needed (WebCore::PNGImageDecoder::decodingFailed): Fix style violation (WebCore::PNGImageDecoder::headerAvailable): Rely on superclass isSizeAvailable() and setSize() for overflow protection and better failure handling (WebCore::PNGImageDecoder::rowAvailable): Don't allocate a slot in the framebuffer cache until it's needed, use RGBA32Buffer::setSize() to handle potential allocation failures (won't happen with Cairo port, can in Skia), remove RGBA32Buffer::ensureHeight() (WebCore::PNGImageDecoder::pngComplete): Don't allocate a slot in the framebuffer cache until it's needed
17:44 Changeset [44552] by kevino@webkit.org
  • 5 edits in trunk

wx build fix, adding JSCore/assembler to the list of include dirs, and adding editing/ReplaceNodeSpanCommand.cpp to the build.

17:39 Changeset [44551] by bfulgham@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-09 Brent Fulgham <bfulgham@webkit.org>

No review, build fix only.
Correct DOS line-endings in expected file.
https://bugs.webkit.org/show_bug.cgi?id=26187.

  • fast/canvas/canvas-lineWidth-expected.txt:
17:37 Changeset [44550] by oliver@apple.com
  • 12 edits
    6 adds in trunk

Bug 26249: Support JSON.stringify
<https://bugs.webkit.org/show_bug.cgi?id=26249>

Reviewed by Sam Weinig.

Implement JSON.stringify. This patch handles all the semantics of the ES5
JSON.stringify function, including replacer functions and arrays and both
string and numeric gap arguments.

Currently uses a clamped recursive algorithm basically identical to the spec
description but with a few minor tweaks for performance and corrected semantics
discussed in the es-discuss mailing list.

17:20 Changeset [44549] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

2009-06-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

When checking if the loader is the main resource loader make sure that the loader's frame is the main frame.

https://bugs.webkit.org/show_bug.cgi?id=26218

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::isMainResourceLoader):
  • inspector/InspectorController.h:
17:18 Changeset [44548] by bfulgham@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2009-06-09 Brent Fulgham <bfulgham@webkit.org>

No review, build fix only.
Added missing expected results from
https://bugs.webkit.org/show_bug.cgi?id=26187.

  • fast/canvas/canvas-lineWidth-expected.txt: Added.
15:47 Changeset [44547] by bfulgham@webkit.org
  • 2 edits in trunk/BugsSite

2009-06-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

Add support for displaying added png files in PrettyPatch diffs
https://bugs.webkit.org/show_bug.cgi?id=26210

Currently this is SVN only (git-send-bugzilla patches exclude binary data)
and only works for PNG files but could easily be made to work for other images as needed.

  • PrettyPatch/PrettyPatch.rb:
15:43 Changeset [44546] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-06-09 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26190

Test: media/controls-css-overload.html

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls): Prevent NULL dereference in case containers gets hidden.

LayoutTests:

2009-06-09 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Eric Seidel.

Test case on internal -webkit-media overload.

https://bugs.webkit.org/show_bug.cgi?id=26190

  • media/controls-css-overload-expected.txt: Added.
  • media/controls-css-overload.html: Added.
15:00 Changeset [44545] by pkasting@chromium.org
  • 8 edits in trunk/WebCore

2009-06-08 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part three
Various minor cleanups to the Skia files. Mostly non-functional, except
for two specific changes:

  • JPEGs and PNGs were always marked as transparent; now they are only marked as transparent when they actually are. I doubt this has much of an effect but in theory it could be used to optimize their display.
  • Instead of arbitrarily disallowing images over 32 * 1024 * 1024 px2, only disallow images which are so large they will cause overflow in other parts of the code. This should fix the testcase on http://code.google.com/p/chromium/issues/detail?id=3643.
  • platform/image-decoders/skia/BMPImageReader.h: (WebCore::BMPImageReader::setRGBA): Use simpler non-static setRGBA() form
  • platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer): Remove unneeded code, use more readable setRGBA() form (WebCore::GIFImageDecoder::haveDecodedRow): Fix style violation
  • platform/image-decoders/skia/GIFImageDecoder.h: Remove unneeded code
  • platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::setSize): setSize() should just setStatus() when it fails since all callers were doing it (WebCore::ImageDecoder::isOverSize): Ease "oversized" image constraints to allow any image that won't overflow
  • platform/image-decoders/skia/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::outputScanlines): Remove unneeded code, mark JPEGs as non-transparent
  • platform/image-decoders/skia/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::decodingFailed): Fix style violation (WebCore::PNGImageDecoder::rowAvailable): Mark un-decoded PNGs as non-transparent (this will get reset later as needed)
  • platform/image-decoders/skia/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::frameBufferAtIndex): Remove unneeded code
14:11 Changeset [44544] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-09 Darin Fisher <darin@chromium.org>

Fix Chromium build bustage.


CachedResource.cpp no longer compiles if USE(JSC) is not defined. The
problem is that this file is using a macro from StdLibExtras.h without
including that file. It just happenes to get that file via a JSC
specific include.

  • loader/CachedResource.cpp:
13:47 Changeset [44543] by bfulgham@webkit.org
  • 2 edits
    1 add
    4 deletes in trunk/LayoutTests

2009-06-09 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

Changing editing/deleting/4866671.html to use a dumpAsText test instead of a pixel test
so as to remove the platform dependency.

  • editing/deleting/4866671.html:
13:39 Changeset [44542] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-06-09 Dean McNamee <deanm@chromium.org>

Reviewed by Oliver Hunt.

Make sure the graphics backends are in sync with the canvas lineWidth state.
https://bugs.webkit.org/show_bug.cgi?id=26187

Test: fast/canvas/canvas-line-width.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):

LayoutTests:

2009-06-09 Dean McNamee <deanm@chromium.org>

Reviewed by Oliver Hunt.

Make sure the graphics backends are in sync with the canvas lineWidth state.
https://bugs.webkit.org/show_bug.cgi?id=26187

  • fast/canvas/canvas-lineWidth.html: Added.
  • fast/canvas/canvas-lineWidth.js: Added. (compareRows):
13:34 QtWebKitTodo edited by andre.pedralho@openbossa.org
(diff)
13:03 Changeset [44541] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-06-09 Michael Nordman <michaeln@google.com>

Reviewed by Eric Seidel.

Proactively cancel pending requests at DocLoader dtor time,
otherwise crashes can occur.

https://bugs.webkit.org/show_bug.cgi?id=26230
http://code.google.com/p/chromium/issues/detail?id=12161

Test: fast/frames/javascript-url-as-framesrc-crash.html

  • loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader):

LayoutTests:

2009-06-09 Michael Nordman <michaeln@google.com>

Reviewed by Eric Seidel.

Proactively cancel pending requests at DocLoader dtor time,
otherwise crashes can occur.

https://bugs.webkit.org/show_bug.cgi?id=26230
http://code.google.com/p/chromium/issues/detail?id=12161

  • fast/frames/javascript-url-as-framesrc-crash-expected.txt: Added.
  • fast/frames/javascript-url-as-framesrc-crash.html: Added.
12:34 Changeset [44540] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-06-09 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Fix ASSERT seen in shadow tree testing
https://bugs.webkit.org/show_bug.cgi?id=25092

Test: svg/custom/use-mutation-event-crash.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::instanceForShadowTreeElement):

LayoutTests:

2009-06-09 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Fix ASSERT seen in shadow tree testing
https://bugs.webkit.org/show_bug.cgi?id=25092

  • svg/custom/use-mutation-event-crash.svg: Added.
11:27 Changeset [44539] by bfulgham@webkit.org
  • 8 edits in trunk/WebCore

2009-06-09 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

Fixes https://bugs.webkit.org/show_bug.cgi?id=22891
Scrolling in Windows Cairo Broken if no background color set.

  • platform/graphics/cairo/GradientCairo.cpp: (WebCore::Gradient::fill): Use the GraphicsContext save and restore methods (rather than the Cairo-only functions) so that the Windows device context is kept in sync.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext): Add new constructor call to sync Windows HDC with Cairo surface.
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::syncContext): Provide declaration for Windows HDC sync method (and stub for non-Windows Cairo implementations).
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): Use GraphicsContext save and restore methods (rather than the Cairo-only functions) so that the Windows device context is kept in sync.
  • platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::CairoContextWithHDC): New method to create a valid Cairo context for a given HDC. (WebCore::GraphicsContext::GraphicsContext): Modify constructor to use new CairoContextWithHDC call. (WebCore::GraphicsContext::getWindowsContext): Revise to match behavior of CG implementation. (WebCore::GraphicsContext::releaseWindowsContext): Revise to match behavior of CG implementation. (WebCore::GraphicsContextPlatformPrivate::concatCTM): Get rid of incorrect new HDC, and use object's HDC member for dealing with concatCTM operations. (WebCore::GraphicsContextPlatformPrivate::syncContext): New method to sync Windows HDC with Cairo context.
  • platform/graphics/win/ImageCairoWin.cpp: (WebCore::BitmapImage::getHBITMAPOfSize): Revise implementation to match CG behavior.
11:24 Changeset [44538] by jianli@chromium.org
  • 12 edits in trunk

WebCore:

2009-06-09 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Bug 26196: Fix the problem that worker's importScripts fails if the
script URL is redirected from different origin.
https://bugs.webkit.org/show_bug.cgi?id=26196

Test: http/tests/workers/worker-importScripts.html

The fix is to pass an additional enum parameter to the loader in
order to tell it to perform the redirect origin check or not.

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::create): (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::willSendRequest):
  • loader/DocumentThreadableLoader.h:
  • loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::create): (WebCore::ThreadableLoader::loadResourceSynchronously):
  • loader/ThreadableLoader.h: (WebCore::):
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::loadResourceSynchronously): (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
  • loader/WorkerThreadableLoader.h: (WebCore::WorkerThreadableLoader::create):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously):

LayoutTests:

2009-06-09 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Bug 26196: Fix the problem that worker's importScripts fails if the
script URL is redirected from different origin.
https://bugs.webkit.org/show_bug.cgi?id=26196

Add a test case in the importScripts layout test to cover the scenario
that the import script URL can come from different redirect origin.

  • http/tests/workers/resources/worker-importScripts.js:
  • http/tests/workers/worker-importScripts-expected.txt:
10:09 Changeset [44537] by dglazkov@chromium.org
  • 5 edits
    4 adds in trunk

WebCore:

2009-06-09 Anand K. Mistry <amistry@google.com>

Reviewed by Dimitri Glazkov.

Paint bitmaps with the alpha channel in Skia.
https://bugs.webkit.org/show_bug.cgi?id=26037

Test: fast/canvas/drawImage-with-globalAlpha.html

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::getAlpha):
  • platform/graphics/skia/PlatformContextSkia.h:

LayoutTests:

2009-06-09 Anand K. Mistry <amistry@google.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26037
Test the globalAlpha property of canvas contexts.

  • fast/canvas/drawImage-with-globalAlpha.html: Added.
  • platform/mac/fast/canvas/drawImage-with-globalAlpha-expected.checksum: Added.
  • platform/mac/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
  • platform/mac/fast/canvas/drawImage-with-globalAlpha-expected.txt: Added.
10:05 QtWebKitTodo edited by kenneth.christiansen@gmail.com
(diff)
08:35 Changeset [44536] by kov@webkit.org
  • 7 edits in trunk

WebCore

2009-06-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=26104
[GTK] Make NetworkRequest a proper GObject and expose SoupMessage

Refactor how SoupMessage is handled, so that our ResourceRequest
object doesn't have to store it as a member, which complicates
managing ResourceRequest's lifetime.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
  • platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):

WebKit/gtk

2009-06-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=26104
[GTK] Make NetworkRequest a proper GObject and expose SoupMessage

Refactor how SoupMessage is handled, so that our ResourceRequest
object doesn't have to store it as a member, which complicates
managing ResourceRequest's lifetime.

  • tests/testhttpbackend.c: (navigation_policy_decision_requested_cb): (test_soup_message_lifetime):
  • webkit/webkitnetworkrequest.cpp: (WTF::SoupMessage): (webkit_network_request_new_with_core_request):
07:31 Changeset [44535] by ariya@webkit.org
  • 1 edit in trunk/WebKit/qt/ChangeLog

Correct the reviewer in the previous commit.

07:29 Changeset [44534] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-06-09 Ariya Hidayat <ariya.hidayat@nokia.com>

Rubber-stamped by Tor Arne Vestbø.

Fix qdoc warning, function parameter string must be referred.

  • Api/qwebview.cpp:
06:42 QtWebKitTodo edited by ariya@webkit.org
(diff)
06:42 QtWebKitTodo edited by ariya@webkit.org
(diff)
06:19 QtWebKitTodo edited by hausmann@webkit.org
(diff)
05:54 QtWebKitTodo edited by hausmann@webkit.org
(diff)
05:54 Changeset [44533] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Renamed QWebSettings::AllowUniversalAccessFromFileUrls to
LocalContentCanAccessRemoteUrls, as discussed in the API review.

03:53 QtWebKitTodo edited by hausmann@webkit.org
(diff)
03:51 Changeset [44532] by hausmann@webkit.org
  • 9 edits in trunk

LayoutTests:

2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Adjusted Qt fixed layout testcase to LayoutController API change.

WebKit/qt:

2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Merged useFixedLayout property with fixedLayoutSize and
renamed the latter to fixedContentsSize.

WebKitTools:

2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Removed setUseFixedLayout and renamed setFixedLayoutSize to
setFixedContentsSize.

03:51 QtWebKitTodo edited by hausmann@webkit.org
(diff)
03:51 Changeset [44531] by hausmann@webkit.org
  • 5 edits in trunk/WebKit/qt

2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Renamed QWebHitTestResult::linkTarget to linkElement() and made it return
a QWebElement. The link target itself is always the target DOM attribute.

02:10 QtWebKitTodo edited by hausmann@webkit.org
(diff)
02:00 Changeset [44530] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Qt build, add missing function declaration.

01:50 Changeset [44529] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Qt build, the time functions moved into the WTF namespace.

01:34 QtWebKitTodo edited by hausmann@webkit.org
(diff)
01:31 Changeset [44528] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-09 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Enable JIT_OPTIMIZE_CALL & JIT_OPTIMIZE_METHOD_CALLS on ARMv7 platforms.

These optimizations function correctly with no further changes.

  • wtf/Platform.h:

Change to enable JIT_OPTIMIZE_CALL & JIT_OPTIMIZE_METHOD_CALLS.

01:20 Changeset [44527] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-09 Gavin Barraclough <barraclough@apple.com>

Not Reviewed, build fix.

  • assembler/MacroAssemblerARMv7.h:
01:14 Changeset [44526] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-06-09 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Enable JIT_OPTIMIZE_ARITHMETIC on ARMv7 platforms.

Temporarily split support for 'branchTruncateDoubleToInt32' onto its own switch
('supportsFloatingPointTruncate'). See comment in MacroAssemblerARMv7, we need
to work out wherther we are going to be able to support the current interface on
all platforms, or whether this should be refactored.

  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsFloatingPoint):

Add implementation of supportsFloatingPointTruncate (returns true).

(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):

Add implementation of supportsFloatingPointTruncate (returns false).

(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::storeDouble):
(JSC::MacroAssemblerARMv7::addDouble):
(JSC::MacroAssemblerARMv7::subDouble):
(JSC::MacroAssemblerARMv7::mulDouble):
(JSC::MacroAssemblerARMv7::convertInt32ToDouble):
(JSC::MacroAssemblerARMv7::branchDouble):

Implement FP code genertion operations.

  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::supportsFloatingPointTruncate):

Add implementation of supportsFloatingPointTruncate (returns true).

  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):

Add implementation of supportsFloatingPointTruncate (returns true).

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift):

Changed to call supportsFloatingPointTruncate().

(JSC::JIT::emitSlow_op_rshift):

Changed to call supportsFloatingPointTruncate().

  • wtf/Platform.h:

Change to enable JIT_OPTIMIZE_ARITHMETIC.

00:46 Changeset [44525] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-06-09 Gavin Barraclough <barraclough@apple.com>

Reviewed by Mark Rowe & Geoff Garen.

Enable JIT_OPTIMIZE_PROPERTY_ACCESS on ARMv7 platforms.

Firm up interface for planting load intructions that will be repatched by
repatchLoadPtrToLEA(). This method should now no longer be applied to just
any loadPtr instruction.

  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::loadPtrWithPatchToLEA):

Implement loadPtrWithPatchToLEA interface (plants a load with a fixed width address).

(JSC::MacroAssemblerARMv7::move):
(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::moveWithPatch):
(JSC::MacroAssemblerARMv7::tailRecursiveCall):

Switch to use common method 'moveFixedWidthEncoding()' to perform fixed width (often patchable) loads.

(JSC::MacroAssemblerARMv7::moveFixedWidthEncoding):

Move an immediate to a register, always plants movT3/movt instruction pair.

  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::loadPtrWithPatchToLEA):

Implement loadPtrWithPatchToLEA interface (just a regular 32-bit load on x86).

  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::loadPtrWithPatchToLEA):

Implement loadPtrWithPatchToLEA interface (just a regular 64-bit load on x86_64).

  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id):
  • wtf/Platform.h:

Change to enable JIT_OPTIMIZE_PROPERTY_ACCESS.

00:33 Changeset [44524] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix <https://bugs.webkit.org/show_bug.cgi?id=24642>.
Bug 24642: REGRESSION: Nightly builds sometimes erroneously display a message about failing to launch successfully

Safari 4 on Tiger plays some shenanigans during launch that can confuse the nightly launcher application
in to running its initialization code too soon.

  • WebKitLauncher/WebKitNightlyEnabler.m:

(insideSafariOnTigerTrampoline): Detect these shenanigans.
(enableWebKitNightlyBehaviour): Delay initialization when needed.

06/08/09:

23:52 Changeset [44523] by barraclough@apple.com
  • 8 edits in trunk/JavaScriptCore

2009-06-08 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Enable JS language JIT for ARM thumb2 platforms. Add ARMv7 specific
asm & constants, add appropriate configuration switches to Platform.h.

Landing this disabled until jump linking is completed (see YARR jit patch).

  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::load32):

Fix: should load pointer with ImmPtr not Imm32.

(JSC::MacroAssemblerARMv7::store32):

Fix: should load pointer with ImmPtr not Imm32.

(JSC::MacroAssemblerARMv7::move):

Fix: When moving an Imm32 that is actually a pointer, should call movT3()
not mov(), to ensure code generation is repeatable (for exception handling).

  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):

Disable JIT_OPTIMIZE_NATIVE_CALL specific code generation if the optimization is not enabled.

  • jit/JIT.h:

Add ARMv7 specific values of constants & register names.

  • jit/JITInlineMethods.h: (JSC::JIT::preverveReturnAddressAfterCall): (JSC::JIT::restoreReturnAddressBeforeReturn): (JSC::JIT::restoreArgumentReferenceForTrampoline):

Implement for ARMv7 (move value to/from lr).

  • jit/JITStubs.cpp:

Add JIT entry/thow trampolines, add macro to add thunk wrapper around stub routines.

  • jit/JITStubs.h: (JSC::JITStackFrame::returnAddressSlot):

Add ARMv7 stack frame object.

  • wtf/Platform.h:

Add changes necessary to allow JIT to build on this platform, disabled.

23:24 Changeset [44522] by oliver@apple.com
  • 12 edits
    6 deletes in trunk

Revert r44521 as it causes regressions on windows for some reason.

23:02 Changeset [44521] by oliver@apple.com
  • 12 edits
    6 adds in trunk

Bug 26249: Support JSON.stringify
<https://bugs.webkit.org/show_bug.cgi?id=26249>

Reviewed by Sam Weinig.

Implement JSON.stringify. This patch handles all the semantics of the ES5
JSON.stringify function, including replacer functions and arrays and both
string and numeric gap arguments.

Currently uses a clamped recursive algorithm basically identical to the spec
description but with a few minor tweaks for performance and corrected semantics
discussed in the es-discuss mailing list.

22:27 Changeset [44520] by mitz@apple.com
  • 3 edits
    6 moves in trunk/WebKit

WebKit:

Rubber-stamped by Mark Rowe.

  • updated the project after giving Objective-C++ the .mm extension
  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

Rubber-stamped by Mark Rowe.

  • gave Objective-C++ files the .mm extension
  • Carbon/HIWebView.m: Removed.
  • Carbon/HIWebView.mm: Copied from WebKit/mac/Carbon/HIWebView.m.
  • Misc/WebKitNSStringExtras.m: Removed.
  • Misc/WebKitNSStringExtras.mm: Copied from WebKit/mac/Misc/WebKitNSStringExtras.m.
  • Misc/WebStringTruncator.m: Removed.
  • Misc/WebStringTruncator.mm: Copied from WebKit/mac/Misc/WebStringTruncator.m.
  • WebInspector/WebNodeHighlight.m: Removed.
  • WebInspector/WebNodeHighlight.mm: Copied from WebKit/mac/WebInspector/WebNodeHighlight.m.
  • WebInspector/WebNodeHighlightView.m: Removed.
  • WebInspector/WebNodeHighlightView.mm: Copied from WebKit/mac/WebInspector/WebNodeHighlightView.m.
  • WebView/WebDynamicScrollBarsView.m: Removed.
  • WebView/WebDynamicScrollBarsView.mm: Copied from WebKit/mac/WebView/WebDynamicScrollBarsView.m.
22:11 Changeset [44519] by beidson@apple.com
  • 15 edits
    4 adds in trunk

WebCore:

2009-06-08 Brady Eidson <beidson@apple.com>

Reviewed by Antti Koivisto

<rdar://problem/6727495> Repro crash in WebCore::Loader::Host::servePendingRequests() and dupes.

Test: http/tests/loading/deleted-host-in-resource-load-delegate-callback.html

Loader::Host objects were manually managed via new/delete.
There's a variety of circumstances where a Host might've been deleted while it was still in the middle
of a resource load delegate callback.
Changing them to be RefCounted then adding protectors in the callbacks makes this possibility disappear.

At the same time, remove ProcessingResource which was an earlier fix for this same problem that wasn't
fully implemented.

  • loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::Loader::load): (WebCore::Loader::servePendingRequests): (WebCore::Loader::resumePendingRequests): (WebCore::Loader::cancelRequests): (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail): (WebCore::Loader::Host::didReceiveResponse): (WebCore::Loader::Host::didReceiveData):
  • loader/loader.h: (WebCore::Loader::Host::create):

WebKitTools:

2009-06-08 Brady Eidson <beidson@apple.com>

Reviewed by Antti Koivisto

Add dispatchPendingLoadRequests() to test fix for <rdar://problem/6727495>

  • DumpRenderTree/LayoutTestController.cpp: (dispatchPendingLoadRequestsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::dispatchPendingLoadRequests): Implement using [WebView _dispatchPendingLoadRequests] SPI
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::dispatchPendingLoadRequests): Need implementations.
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::dispatchPendingLoadRequests): Ditto.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::dispatchPendingLoadRequests): Ditto.
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::dispatchPendingLoadRequests): Ditto.

LayoutTests:

2009-06-08 Brady Eidson <beidson@apple.com>

Reviewed by Antti Koivisto

<rdar://problem/6727495> Repro crash in WebCore::Loader::Host::servePendingRequests() and dupes.

Note this "Loader::Host deleted while still in use" could come up in a variety of ways but this layout
test only covers the single most reproducible way we know that *could* be tested by DRT.

  • http/tests/loading/deleted-host-in-resource-load-delegate-callback-expected.txt: Added.
  • http/tests/loading/deleted-host-in-resource-load-delegate-callback.html: Added.
  • http/tests/loading/resources/snow-shoes-vs-pie-copy.png: Added.
  • http/tests/loading/resources/snow-shoes-vs-pie.png: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
21:48 Changeset [44518] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Speculative GTK build fix.

  • wtf/DateMath.cpp:
21:20 Changeset [44517] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-08 Gavin Barraclough <barraclough@apple.com>

Reviewed by Mark Rowe.

Previous patch caused a regression.

Restructure so no new (empty, inline) function calls are added on x86.

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::makeWritable): (JSC::ExecutableAllocator::makeExecutable): (JSC::ExecutableAllocator::reprotectRegion): (JSC::ExecutableAllocator::cacheFlush):
20:56 Changeset [44516] by dglazkov@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-06-08 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, GTK build fix (thanks, bdash).

  • GNUmakefile.am: Moved DateMath with all other wtf kin.
20:01 Changeset [44515] by dimich@chromium.org
  • 13 edits
    1 copy in trunk/WebCore

2009-06-08 Dmitry Titov <dimich@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26126
Refactor methods of WorkerMessagingProxy used to talk to main-thread loader into new interface.

Split a couple of methods used to schedule cross-thread tasks between worker thread and loader thread
implemented on WorkerMessagingProxy into a separate interface so the loading can be implemented in
Chromium's workers.

No changes in functionality so no tests added.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Added WorkerLoaderProxy.h to the bulid.
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): WorkerThread::workerObjectProxy() now returns & instead of *
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): same.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): same. (WebCore::WorkerContext::reportException): same. (WebCore::WorkerContext::addMessage): same. (WebCore::WorkerContext::postMessage): same.
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy): (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation): Use WorkerLoaderProxy instead of WorkerMessagingProxy for the MainThreadBridge. Mostly rename.

(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
In addition to using WorkerLoaderProxy instead of WorkerMessagingProxy, the check for
AskedToTerminate is removed. It seems to be an optimization for a very small number of cases
when worker termination is requested a very short time before the request to load something
(XHR or importScript) was dispatched on the main thread.

  • loader/WorkerThreadableLoader.h: Now keeps a pointer to WorkerLoaderProxy rather then to a WorkerMessagingProxy. This allows to implement WorkerThreadableLoader for Chromium.
  • workers/WorkerLoaderProxy.h: Added. (WebCore::WorkerLoaderProxy::~WorkerLoaderProxy):
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::startWorkerContext): (WebCore::WorkerMessagingProxy::postTaskToLoader): Added ASSERT since this needs to be implemented for nested workers.
  • workers/WorkerMessagingProxy.h: Derived from WorkerLoaderProxy, the methods for posting tasks cross-thread are now virtual. Removed unused postTaskToWorkerContext() method.
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread):
  • workers/WorkerThread.h: (WebCore::WorkerThread::workerLoaderProxy):
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::workerThread):
  • workers/WorkerThread.h: (WebCore::WorkerThread::workerLoaderProxy): (WebCore::WorkerThread::workerObjectProxy): WorkerThread gets a new member of type WorkerLoaderProxy&, and accessor. Also, existing WorkerObjectProxy* member is now WorkerObjectProxy& because it can't be null.
18:40 Changeset [44514] by barraclough@apple.com
  • 8 edits
    2 adds in trunk/JavaScriptCore

2009-06-08 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Add (incomplete) support to YARR for running with the jit enabled
on Arm thumb2 platforms. Adds new Assembler/MacroAssembler classes,
along with cache flushing support, tweaks to MacroAssemblerCodePtr
to support decorated thumb code pointers, and new enter/exit code
to YARR jit for the platform.

Support for this platform is still under development - the assembler
currrently only supports planting and linking jumps with a 16Mb range.
As such, initially commiting in a disabled state.

Add new assembler files.

  • assembler/ARMv7Assembler.h: Added.

Add new Assembler.

  • assembler/AbstractMacroAssembler.h:

Tweaks to ensure sizes of pointer values planted in JIT code do not change.

  • assembler/MacroAssembler.h:

On ARMv7 platforms use MacroAssemblerARMv7.

  • assembler/MacroAssemblerARMv7.h: Added.

Add new MacroAssembler.

  • assembler/MacroAssemblerCodeRef.h: (JSC::FunctionPtr::FunctionPtr):

Add better ASSERT.

(JSC::ReturnAddressPtr::ReturnAddressPtr):

Add better ASSERT.

(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):

On ARMv7, MacroAssemblerCodePtr's mush be 'decorated' with a low bit set,
to indicate to the processor that the code is thumb code, not traditional
32-bit ARM.

(JSC::MacroAssemblerCodePtr::dataLocation):

On ARMv7, decoration must be removed.

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::makeWritable):

Reformatted, no change.

(JSC::ExecutableAllocator::makeExecutable):

When marking code executable also cache flush it, where necessary.

(JSC::ExecutableAllocator::MakeWritable::MakeWritable):

Only use the null implementation of this class if both !ASSEMBLER_WX_EXCLUSIVE
and running on x86(_64) - on other platforms we may also need ensure that
makeExecutable is called at the end to flush caches.

(JSC::ExecutableAllocator::reprotectRegion):

Reformatted, no change.

(JSC::ExecutableAllocator::cacheFlush):

Cache flush a region of memory, or platforms where this is necessary.

  • wtf/Platform.h:

Add changes necessary to allow YARR jit to build on this platform, disabled.

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):

Add support to these methods for ARMv7.

17:37 WebKit Team edited by levin@chromium.org
(diff)
16:59 Changeset [44513] by dglazkov@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-06-08 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, fix my previous fix.

  • runtime/DateInstance.cpp: (JSC::DateInstance::msToGregorianDateTime): Use WTF namespace qualifier to

disambiguate func signatures.

16:52 Changeset [44512] by dglazkov@chromium.org
  • 3 edits in trunk/JavaScriptCore

2009-06-08 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, another Windows build fix.

16:48 Changeset [44511] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Attempt to fix the Tiger build.

  • wtf/Platform.h: Only test the value of the macro once we know it is defined.
16:16 Changeset [44510] by dglazkov@chromium.org
  • 3 edits in trunk/JavaScriptCore

2009-06-08 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, projectile-fixing Windows build.

  • runtime/DateConversion.cpp: Added StringExtras include.
  • wtf/DateMath.cpp: Replaced math with algorithm include (looking for std::min def for Windows).
16:01 Changeset [44509] by dglazkov@chromium.org
  • 5 edits in trunk/JavaScriptCore

2009-06-08 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, Windows build fix.

  • runtime/DateConstructor.cpp: Changed to use WTF namespace.
  • runtime/DateConversion.cpp: Added UString include.
  • runtime/DateInstance.cpp: Changed to use WTF namespace.
  • wtf/DateMath.cpp: Added math include.
15:37 Changeset [44508] by dglazkov@chromium.org
  • 20 edits
    2 copies
    3 moves in trunk

JavaScriptCore:

2009-06-08 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26238
Move most of runtime/DateMath functions to wtf/DateMath, and split off conversion-related
helpers to DateConversion.

  • AllInOneFile.cpp: Changed DateMath->DateConversion.
  • GNUmakefile.am: Ditto and added DateMath.
  • JavaScriptCore.exp: Ditto.
  • JavaScriptCore.pri: Ditto.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Added DateMath.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • JavaScriptCoreSources.bkl: Ditto.
  • pcre/pcre_exec.cpp: Changed to use DateMath.
  • profiler/ProfileNode.cpp: (JSC::getCount): Changed to use DateConversion.
  • runtime/DateConstructor.cpp: Ditto.
  • runtime/DateConversion.cpp: Copied from JavaScriptCore/runtime/DateMath.cpp. (JSC::parseDate): Refactored to use null-terminated characters as input.
  • runtime/DateConversion.h: Copied from JavaScriptCore/runtime/DateMath.h.
  • runtime/DateInstance.cpp: Changed to use wtf/DateMath.
  • runtime/DateInstance.h: Ditto.
  • runtime/DateMath.cpp: Removed.
  • runtime/DateMath.h: Removed.
  • runtime/DatePrototype.cpp: Ditto.
  • runtime/InitializeThreading.cpp: Ditto.
  • wtf/DateMath.cpp: Copied from JavaScriptCore/runtime/DateMath.cpp.
  • wtf/DateMath.h: Copied from JavaScriptCore/runtime/DateMath.h.

WebCore:

2009-06-08 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26238
Add parseDate helper to HTTPParsers, which uses WTF::parseDateFromNullTerminatedCharacters.

  • ForwardingHeaders/runtime/DateMath.h: Removed.
  • ForwardingHeaders/wtf/DateMath.h: Copied from WebCore/ForwardingHeaders/runtime/DateMath.h.
  • platform/network/HTTPParsers.cpp: (WebCore::parseDate): Added.
  • platform/network/HTTPParsers.h:
  • platform/network/ResourceResponseBase.cpp: (WebCore::parseDateValueInHeader): Changed to use the new helper.
14:43 Changeset [44507] by sfalken@apple.com
  • 2 edits in tags/Safari-6530.17.1/JavaScriptCore

Merge r44506.

14:38 Changeset [44506] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

14:18 Changeset [44505] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.17.1

New tag.

13:47 Changeset [44504] by barraclough@apple.com
  • 9 edits in trunk/JavaScriptCore

2009-06-07 David Kilzer <ddkilzer@apple.com>

Make JavaScriptCore compile for iPhone and iPhone Simulator

Reviewed by Gavin Barraclough.

  • Configurations/Base.xcconfig: Split GCC_ENABLE_OBJC_GC on $(REAL_PLATFORM_NAME). Added $(ARCHS_UNIVERSAL_IPHONE_OS) to VALID_ARCHS. Added REAL_PLATFORM_NAME_iphoneos, REAL_PLATFORM_NAME_iphonesimulator, HAVE_DTRACE_iphoneos and HAVE_DTRACE_iphonesimulator variables.
  • Configurations/DebugRelase.xcconfig: Split ARCHS definition on $(REAL_PLATFORM_NAME).
  • Configurations/JavaScriptCore.xcconfig: Added EXPORTED_SYMBOLS_FILE_armv6 and EXPORTED_SYMBOLS_FILE_armv7 variables. Split OTHER_LDFLAGS into OTHER_LDFLAGS_BASE and OTHER_LDFLAGS_$(REAL_PLATFORM_NAME) since CoreServices.framework is only linked to on Mac OS X.
  • JavaScriptCore.xcodeproj/project.pbxproj: Removed references to CoreServices.framework since it's linked using OTHER_LDFLAGS in JavaScriptCore.xcconfig.
  • profiler/ProfilerServer.mm: Added #import for iPhone Simulator. (-[ProfilerServer init]): Conditionalize use of NSDistributedNotificationCenter to non-iPhone or iPhone Simulator.
  • wtf/FastMalloc.cpp: (WTF::TCMallocStats::): Build fix for iPhone and iPhone Simulator.
  • wtf/Platform.h: Defined PLATFORM(IPHONE) and PLATFORM(IPHONE_SIMULATOR).
  • wtf/ThreadingPthreads.cpp: (WTF::setThreadNameInternal): Build fix for iPhone and iPhone Simulator.
10:52 Changeset [44503] by agl@chromium.org
  • 5 edits
    1 add in trunk/WebCore

2009-06-08 Adam Langley <agl@google.com>

Reviewed by Eric Siedel.

Chromium Linux ignored the background color on <select>s. Rather
than encode magic colours, we start with a base color (specified
via CSS) and derive the other colors from it. Thus, setting the
CSS background-color now correctly changes the colour of the
control.

This should not change the appearence controls without
background-colors. However, <select>s with a background-color
will now renderer correctly, which may require rebaselining
pixel tests in the Chromium tree.

https://bugs.webkit.org/show_bug.cgi?id=26030
http://code.google.com/p/chromium/issues/detail?id=12596

  • platform/graphics/Color.cpp: (WebCore::Color::getHSL): new member
  • platform/graphics/Color.h:
  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::systemColor): (WebCore::brightenColor): (WebCore::paintButtonLike):
10:19 Changeset [44502] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-08 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=26240
[GTK] Try again button loses query strings

Only trigger reload, when try again is clicked, this way we do not
lose the query strings, like we did when also triggering a form
submission.

  • resources/error.html:
09:24 Changeset [44501] by dglazkov@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Fixed the name in the ChangeLog

09:23 Changeset [44500] by dglazkov@chromium.org
  • 2 edits
    2 adds in trunk/WebCore

2009-06-08 victorw <victorw@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26087
Bug 26087: Removing element in JS crashes Chrome tab if it fired the change event

Fix tab crash caused by destroying the popup list that fired the change event on abandon.

If a popup list is abandoned (press a key to jump to an item
and then use tab or mouse to get away from the select box),
the current code fires a change event in PopupListBox::updateFromElemt().
The JS that listens to this event may destroy the object and cause the
rest of popup list code crashes.

The updateFromElement() is called before abandon() and this causes
the selected index to be discarded after updateFromElement(). From
the code comments, this appears to be the reason why valueChanged is
called in updateFromElement.

Fix the issue by removing the valueChanged call in updateFromElement,
saving the selected index that we should accept on abandon and pass
it to the valueChange in abandon().

A manual test has been added.

  • manual-tests/chromium: Added.
  • manual-tests/chromium/onchange-reload-popup.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::PopupListBox): (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::updateFromElement):
08:53 Changeset [44499] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Disable a few warnings on Windows

08:53 QtWebKitTodo edited by hausmann@webkit.org
(diff)
08:51 Changeset [44498] by hausmann@webkit.org
  • 6 edits in trunk/WebKit/qt

2009-06-08 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

Renamed QWebElement::enclosingBlock to enclosingBlockElement
and changed the return type to QWebElement, as discussed in
the API review. This API is more generic and through
QWebElement's geometry() it is possible to retrieve the
same information.

08:38 Changeset [44497] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Don't enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH on Windows

This define was brought in after refactoring some code from
PluginPackage(Qt|Gtk).cpp into the shared PluginPackage.cpp.

08:23 QtWebKitTodo edited by hausmann@webkit.org
(diff)
08:14 QtWebKitTodo edited by hausmann@webkit.org
(diff)
08:13 QtWebKitTodo edited by hausmann@webkit.org
(diff)
08:10 QtWebKitTodo edited by hausmann@webkit.org
(diff)
07:35 Changeset [44496] by vestbo@webkit.org
  • 6 edits in trunk

2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Use $QMAKE_PATH_SEP instead of hardcoded / to fix Windows build

07:35 QtWebKitTodo edited by hausmann@webkit.org
(diff)
07:17 QtWebKitTodo edited by hausmann@webkit.org
(diff)
06:25 QtWebKitTodo edited by hausmann@webkit.org
(diff)
05:56 QtWebKitTodo edited by hausmann@webkit.org
(diff)
05:05 Changeset [44495] by ariya@webkit.org
  • 4 edits in trunk/WebCore

2009-06-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Build fix when NETSCAPE_PLUGIN_API support is turned off
https://bugs.webkit.org/show_bug.cgi?id=26244

  • WebCore.pro: Define PLUGIN_PACKAGE_SIMPLE_HASH only if NETSCAPE_PLUGIN_API is turned on
  • plugins/PluginPackage.cpp: Guard initializeBrowserFuncs()
  • plugins/PluginViewNone.cpp: Match guards with PluginView.h
Note: See TracTimeline for information about the timeline view.