Timeline


and

06/14/09:

23:11 Changeset [44678] by cfleizach@apple.com

Bug 26399: REGRESSION: java applet accessibility broken
https://bugs.webkit.org/show_bug.cgi?id=26399

21:46 Changeset [44677] by weinig@apple.com

2009-06-14 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Rename the CustomGetOwnPropertySlot and CustomPutFunction extended attributes
to DelegatingGetOwnPropertySlot and DelegatingPutFunction to more clearly describe
their functionality (customGetOwnPropertySlot and customPut member functions have
been renamed getOwnPropertySlotDelegate and putDelegate). CustomGetOwnPropertySlot
and CustomPutFunction have been repurposed to mean a complete custom implementation
of the function which is inline with other extended attributes prefixed with Custom.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::putDelegate):
  • bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::getOwnPropertySlotDelegate): (WebCore::JSDOMWindow::putDelegate):
  • bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate): (WebCore::JSHTMLAppletElement::putDelegate):
  • bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate): (WebCore::JSHTMLEmbedElement::putDelegate):
  • bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate): (WebCore::JSHTMLObjectElement::putDelegate):
  • bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::getOwnPropertySlotDelegate): (WebCore::JSHistory::putDelegate):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::getOwnPropertySlotDelegate): (WebCore::JSLocation::putDelegate): (WebCore::JSLocationPrototype::putDelegate):
  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::putDelegate):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::getOwnPropertySlotDelegate):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSStyleDeclaration.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLObjectElement.idl:
  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Location.idl:
  • storage/Storage.idl:
  • workers/WorkerContext.idl:
21:36 Changeset [44676] by mitz@apple.com

Reviewed by Darin Adler.

No test, since the back/forward cache is disabled in DumpRenderTree

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::open): Added a call to CachedPage::restore(), which was removed in r40870.
20:07 Changeset [44675] by darin@apple.com

2009-06-14 Darin Adler <darin@apple.com>

  • editing/TextIterator.cpp: (WebCore::BitStack::push): Use named constant instead of hardcoded numbers. (WebCore::BitStack::top): Ditto.
19:39 Changeset [44674] by darin@apple.com

WebCore:

2009-06-14 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 26364: Search can find text that's hidden by overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=26364
<rdar://problem/6952081>

Test: fast/text/find-hidden-text.html

  • editing/TextIterator.cpp: (WebCore::BitStack::BitStack): Added. (WebCore::BitStack::push): Added. (WebCore::BitStack::pop): Added. (WebCore::BitStack::top): Added. (WebCore::BitStack::size): Added. (WebCore::parentOrShadowParent): Added. Helper function for walking up the parent node chain, crossing shadow tree boundaries. (WebCore::depthCrossingShadowBoundaries): Added for use in assertions. Counts the depth of a node using the parentOrShadowParent function. (WebCore::fullyClipsContents): Added. Returns true for an element that fully clips its contents, currently defined as a box that has zero width or height and hides overflow. We can add other cases here later. (WebCore::ignoresContainerClip): Added. Returns true for an element that ignores its container clip, currently defined as an element with absolute or fixed positioning. (WebCore::pushFullyClippedState): Added. Pushes a bit on the stack indicating if the node in question fully clips its contents. (WebCore::setUpFullyClippedStack): Added. Pushes a bit for each ancestor of a node. Used when creating an iterator. (WebCore::TextIterator::TextIterator): Removed code to initialize m_inShadowContent. Call setUpFullyClippedStack. (WebCore::TextIterator::advance): Use parentOrShadowParent. Call pop when moving up to a parent node, and also one extra time when moving to a sibling node. Call pushFullyClippedState when moving to a child node, or when moving to a sibling node after the aforementioned call to pop. (WebCore::TextIterator::handleTextNode): Return early if the node is fully clipped. (WebCore::TextIterator::handleReplacedElement): Ditto. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Call setUpFullyClippedStack. (WebCore::SimplifiedBackwardsTextIterator::advance): Same changes as TextIterator::advance above.
  • editing/TextIterator.h: Added BitStack class and added m_fullyClippedStack to both TextIterator and SimplifiedBackwardsTextIterator. Removed unneeded m_inShadowContent.

LayoutTests:

2009-06-14 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 26364: Search can find text that's hidden by overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=26364
<rdar://problem/6952081>

  • fast/text/find-hidden-text-expected.txt: Added.
  • fast/text/find-hidden-text.html: Added.
  • fast/block/float/crash-replaced-display-block-expected.txt: Removed a space.
  • fast/dom/Range/acid3-surround-contents-expected.txt: Removed a blank line.
  • fast/dom/object-embed-plugin-scripting-expected.txt: Removed four spaces.
  • fast/parser/badentity-expected.txt: Removed a blank line.
  • http/tests/security/local-video-poster-from-remote-expected.txt: Removed a blank line.
16:52 Changeset [44673] by hyatt@apple.com

2009-06-14 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26362

Back out Simon's fix and replace it with a better one that doesn't needlessly destroy RenderObjects.
Use NoInherit rather than Detach for child index changes, and don't worry about other pseudo-class state
changes, since they were handled already with setNeedsStyleRecalcs on the affected objects themselves.

  • dom/Element.cpp: (WebCore::Element::recalcStyle):
  • dom/Node.cpp: (WebCore::Node::diff):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setChildIndex):
14:57 Changeset [44672] by hyatt@apple.com

2009-06-14 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

Move all of the mutable member variables from Font into the refcounted FontFallbackList. This makes
copying of Fonts more efficient and also effectively makes all of the mutations of a Font object happen
inside the FontFallbackList.

  • WebCore.base.exp:
  • platform/graphics/Font.cpp: (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::primaryFont): (WebCore::Font::update):
  • platform/graphics/Font.h: (WebCore::Font::setWordSpacing): (WebCore::Font::setLetterSpacing):
  • platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::determinePitch):
  • platform/graphics/FontFallbackList.h: (WebCore::FontFallbackList::primarySimpleFontData): (WebCore::FontFallbackList::primaryFontData):
  • platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter):
14:27 Changeset [44671] by simon.fraser@apple.com

2009-06-14 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=26362

Fix an issue noted on quirksmode.com where dynamically adding siblings does not
update :nth-child style correctly.

Test: fast/css/nth-child-dynamic.html

  • dom/Node.h: Change diff() to take const RenderStyle*
  • dom/Node.cpp: (WebCore::Node::diff): When comparing styles to decide whether to detach and reattach, we need to look at whether the pseudoclass-related data in the style changed (since RenderStyle::diff doesn't check this).
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getCachedPseudoStyle): (WebCore::RenderStyle::inheritedNotEqual): Make these methods const.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::styleType): (WebCore::InheritedFlags::pseudoClassStateEquivalent): Make methods const. Add new method that compares the pseudoclass-related members.
00:03 Changeset [44670] by sfalken@apple.com

Update V8 benchmark to version 4.


Reviewed by Cameron Zwarich.

  • tests/LIST-V8:
  • tests/v8-crypto.js:
  • tests/v8-deltablue.js:
  • tests/v8-earley-boyer.js:
  • tests/v8-raytrace.js:
  • tests/v8-regexp.js: Added.
  • tests/v8-richards.js:
  • tests/v8-splay.js: Added.

06/13/09:

23:44 Changeset [44669] by pkasting@chromium.org

2009-06-13 Peter Kasting <pkasting@google.com>

Reviewed by Kevin Ollivier.

https://bugs.webkit.org/show_bug.cgi?id=25709 part eleven
Write a wx implementation so the wx port can compile. For now this is
mostly a copy of the Cairo port, but in the future it can be changed to
use a wxBitmap as the storage type everywhere (just as Cairo can
probably be changed).


Also ASSERT for any other ports who call getAddr() (I don't think there
are any, and besides, they probably won't link, but this doesn't hurt).


Also fixes a dumb Cairo build bustage typo introduced in part ten.

  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::createFrameAtIndex):
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/cairo/ImageDecoderCairo.cpp: (WebCore::RGBA32Buffer::setStatus):
  • platform/image-decoders/wx: Added.
  • platform/image-decoders/wx/ImageDecoderWx.cpp: Added. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height):
  • webcore-wx.bkl:
22:06 Changeset [44668] by abarth@webkit.org

2009-06-09 Justin Garcia <justin.garcia@apple.com>

Reviewed by Eric Seidel. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26281

REGRESSION: Copying from TextEdit/OmniGraffle and pasting into editable
region loses images


Prefer RTFD (RTF with inline images) over RTF. In
http://trac.webkit.org/changeset/19745 I accidently reversed their
order.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
21:53 Changeset [44667] by abarth@webkit.org

2009-06-13 Stephen White <senorblanco@chromium.org>

Reviewed by Dimitri Glazkov. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26320

Some minor code cleanup for chromium/skia port. Removed #ifdef's
around skia API changes, since the new version seems solid and we
don't need to go back. Added some comments to
TransparencyWin.h, as requested by Brett in
https://bugs.webkit.org/show_bug.cgi?id=24584.

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/chromium/TransparencyWin.h:
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::boundingRect): (WebCore::boundingBoxForCurrentStroke):
  • platform/graphics/skia/SkiaUtils.cpp: (WebCore::SkPathContainsPoint):
21:29 Changeset [44666] by abarth@webkit.org

Build fix: Another missing header. Arg.

21:24 Changeset [44665] by abarth@webkit.org

Build fix: add missing header.

21:14 Changeset [44664] by abarth@webkit.org

WebCore:

2009-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24492

Moved registerURLSchemeAsLocal and registerURLSchemeAsNoAccess from
FrameLoader to SecurityOrigin.

  • WebCore.base.exp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest): (WebCore::FrameLoader::canLoad):
  • loader/FrameLoader.h:
  • page/SecurityOrigin.cpp: (WebCore::localSchemes): (WebCore::noAccessSchemes): (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::isLocal): (WebCore::SecurityOrigin::registerURLSchemeAsLocal): (WebCore::SecurityOrigin::shouldTreatURLAsLocal): (WebCore::SecurityOrigin::shouldTreatURLSchemeAsLocal): (WebCore::SecurityOrigin::registerURLSchemeAsNoAccess): (WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
  • page/SecurityOrigin.h:

WebKit/mac:

2009-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24492

Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin

  • WebView/WebView.mm: (+[WebView registerURLSchemeAsLocal:]):

WebKit/qt:

2009-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24492

Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.

  • Api/qwebpage.cpp: (QWebPage::acceptNavigationRequest):

WebKit/win:

2009-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24492

Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.

  • WebView.cpp: (WebView::registerURLSchemeAsLocal):
20:47 Changeset [44663] by abarth@webkit.org

2009-06-13 Ben Murdoch <benm@google.com>

Reviewed by David Kilzer. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26189

This patch changes the way PageGroups create their localStorage
objects. Rather than creating a local storage object for the page group
when a page is added to the group, the local storage object is now
created lazily when the local storage object is requested by the
DOMWindow.

  • page/PageGroup.cpp: (WebCore::PageGroup::closeLocalStorage): Before attempting to close a local storage object for a page group, ensure one has been created. (WebCore::PageGroup::addPage): Do not automatically try to create a local storage object when a page is added to the group. (WebCore::PageGroup::localStorage): Create a local storage object if one does not exist and return it.
  • page/PageGroup.h: Add private hasLocalStorage method to PageGroup.
20:44 Changeset [44662] by abarth@webkit.org

2009-06-13 Ben Murdoch <benm@google.com>

Reviewed by Eric Seidel. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26189

Add ENABLE(DOM_STORAGE) guards to the dom storage source files.

  • storage/LocalStorage.cpp: Add ENABLE(DOM_STORAGE) guards to the file.
  • storage/LocalStorage.h: Ditto
  • storage/LocalStorageArea.cpp: Ditto
  • storage/LocalStorageArea.h: Ditto
  • storage/LocalStorageTask.cpp: Ditto
  • storage/LocalStorageTask.h: Ditto
  • storage/LocalStorageThread.cpp: Ditto
  • storage/LocalStorageThread.h: Ditto
  • storage/SessionStorage.cpp: Ditto
  • storage/SessionStorage.h: Ditto
  • storage/SessionStorageArea.cpp: Ditto
  • storage/SessionStorageArea.h: Ditto
  • storage/Storage.cpp: Ditto
  • storage/Storage.h: Ditto
  • storage/StorageArea.cpp: Ditto
  • storage/StorageArea.h: Ditto
  • storage/StorageEvent.cpp: Ditto
  • storage/StorageEvent.h: Ditto
  • storage/StorageMap.cpp: Ditto
  • storage/StorageMap.h: Ditto
  • storage/StorageEvent.idl: Add Conditional=DOM_STORAGE attribute.
  • storage/Storage.idl: Ditto
18:00 Changeset [44661] by pkasting@chromium.org

2009-06-13 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part ten
Make Skia use the root directory ImageDecoder.h and factor out most
Skia-specific bits into skia/ImageDecoderSkia.cpp. Also fix a pair of
style violations in ImageDecoderCairo.cpp. This is the last patch for
this bug, everything beyond this is an enhancement rather than
unforking.

  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/cairo/ImageDecoderCairo.cpp: (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::setStatus):
  • platform/image-decoders/skia/ImageDecoder.h: Removed.
  • platform/image-decoders/skia/ImageDecoderSkia.cpp: Added. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height):
16:11 Changeset [44660] by weinig@apple.com

2009-06-13 Sam Weinig <sam@webkit.org>

Rubber-stamped by Mark "Snowy" Rowe.

Update iExploder/htdocs/cssproperties.in by running update-iexploder-cssproperties.

  • iExploder/htdocs/cssproperties.in:
14:35 Changeset [44659] by abarth@webkit.org

2009-06-13 Victor Wang <victorw@chromium.org>

Reviewed by Eric Seidel. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26333
Alert during a dragenter event handler will crash the renderer


This crash is casued by calling NULL pointer m_documentUnderMouse in
DragController::tryDocumentDrag()

tryDHTMLDrag fires dragenter event. The event listener that listens
to this event may create a nested message loop (open a modal dialog),
which could process dragleave event and reset m_documentUnderMouse in
dragExited.

Fix the crash by checking m_documentUnderMouse after tryDHTMLDrag and
do not continue if the pointer has been set to NULL.

Test: DRT does not show alerts so add a manual test:

manual-tests/drag-enter-alert.html

  • manual-tests/drag-enter-alert.html: Added.
  • manual-tests/resources/drag-image.png: Added.
  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):
14:27 Changeset [44658] by abarth@webkit.org

2009-06-13 Nate Chapin <japhet@google.com>

Reviewed by Dimitri Glazkov. Landed by Adam Barth.

Moved V8 Bindings for V8CustomXPathNSResolver to svn.webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=26227

  • bindings/v8/custom/V8CustomXPathNSResolver.cpp: Added. (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver): Moved from src.chromium.org. (WebCore::V8CustomXPathNSResolver::~V8CustomXPathNSResolver): Moved from src.chromium.org. (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI): Moved from src.chromium.org.
  • bindings/v8/custom/V8CustomXPathNSResolver.h: Added.
  • bindings/v8/custom/V8DocumentCustom.cpp: Updated includes. (WebCore::CALLBACK_FUNC_DECL): Updated class name.
14:23 Changeset [44657] by abarth@webkit.org

2009-06-13 John Abd-El-Malek <jam@chromium.org>

Reviewed by Eric Seidel. Landed by Adam Barth.

Removed dead file.
https://bugs.webkit.org/show_bug.cgi?id=26308

  • DumpRenderTree/win/TestNetscapePlugin/main.c: Removed.
14:19 Changeset [44656] by abarth@webkit.org

2009-06-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Mark Rowe. Landed by Adam Barth.

Remove obsolete declarations for old Symbian port
https://bugs.webkit.org/show_bug.cgi?id=26339

  • platform/graphics/FloatPoint.h: Remove declarations for native SYMBIAN adaptation.
  • platform/graphics/FloatRect.h: Ditto.
  • platform/graphics/IntPoint.h: Ditto.
  • platform/graphics/IntRect.h: Ditto.
  • platform/graphics/IntSize.h: Ditto.
12:54 Changeset [44655] by krit@webkit.org

2009-06-13 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

Added subRegion calculation to SVG filter. Every filter effect is
clipped to the filter region (according to the spec). This makes
ImageBuffers for filter effects smaller and we just need to take
care about big filter regions.
SVGFEImage needed a correction, to avoid an ASSERT. The two filter
effects feOffset and feFlood help to test the new subRegion code.

Tests: svg/filters/subRegion-one-effect.svg

svg/filters/subRegion-two-effects.svg

Added tests for the new subRgion-code on SVG filters.

  • platform/mac/svg/filters: Added.
  • platform/mac/svg/filters/subRegion-one-effect-expected.checksum: Added.
  • platform/mac/svg/filters/subRegion-one-effect-expected.png: Added.
  • platform/mac/svg/filters/subRegion-one-effect-expected.txt: Added.
  • platform/mac/svg/filters/subRegion-two-effects-expected.checksum: Added.
  • platform/mac/svg/filters/subRegion-two-effects-expected.png: Added.
  • platform/mac/svg/filters/subRegion-two-effects-expected.txt: Added.
  • svg/filters: Added.
  • svg/filters/subRegion-one-effect.svg: Added.
  • svg/filters/subRegion-two-effects.svg: Added.
12:36 Changeset [44654] by pkasting@chromium.org

2009-06-13 Peter Kasting <pkasting@google.com>

Bustage: Fix broken GIFs on Cairo due to subtle typo. Fix a warning.

  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::copyRowNTimes):
  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::processBitmasks):
12:10 Changeset [44653] by pkasting@chromium.org

2009-06-13 Peter Kasting <pkasting@google.com>

GTK bustage fix. "inline" is handled differently by different compilers.

  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/cairo/ImageDecoderCairo.cpp:
11:55 Changeset [44652] by pkasting@chromium.org

2009-06-13 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part nine
Factor Cairo-specific implementation out of ImageDecoder.h into
ImageDecoderCairo.cpp. Add some comments to functions declared
in ImageDecoder.h.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/image-decoders/ImageDecoder.h:
  • platform/image-decoders/cairo: Added.
  • platform/image-decoders/cairo/ImageDecoderCairo.cpp: Added. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::getAddr):
10:52 Changeset [44651] by hyatt@apple.com

2009-06-12 Dave Hyatt <hyatt@apple.com>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=26373

Add a new class to Threading in wtf called ReadWriteLock that handles single writer/multiple reader locking.
Provide a pthreads-only implementation of the lock for now, as this class is only going to be used
on Snow Leopard at first.

  • wtf/Threading.h: (WTF::ReadWriteLock::impl):
  • wtf/ThreadingPthreads.cpp: (WTF::ReadWriteLock::ReadWriteLock): (WTF::ReadWriteLock::~ReadWriteLock): (WTF::ReadWriteLock::readLock): (WTF::ReadWriteLock::tryReadLock): (WTF::ReadWriteLock::writeLock): (WTF::ReadWriteLock::tryWriteLock): (WTF::ReadWriteLock::unlock):
10:20 Changeset [44650] by hyatt@apple.com

2009-06-13 David Hyatt <hyatt@apple.com>

Reviewed by Darin Adler.

Cleanup of the new MidpointState class. Turn it into a struct instead. Fix a mistaken
assertion removal and some unintentional whitespace changes.

  • platform/text/BidiResolver.h: (WebCore::MidpointState::reset):
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::BidiRun::operator delete): (WebCore::chopMidpointsAt): (WebCore::checkMidpoints): (WebCore::addMidpoint): (WebCore::appendRunsForObject): (WebCore::RenderBlock::findNextLineBreak):

06/12/09:

23:04 Changeset [44649] by hyatt@apple.com

2009-06-12 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=26367

Remove the global variables in bidi.cpp. Make a new struct, MidpointState, that holds all of the
midpoint information. Add the remaining global variables as arguments passed down through functions
as needed.

  • platform/text/BidiResolver.h: (WebCore::MidpointState::MidpointState): (WebCore::MidpointState::reset): (WebCore::BidiResolver::midpointState):
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::BidiRun::operator delete): (WebCore::chopMidpointsAt): (WebCore::checkMidpoints): (WebCore::addMidpoint): (WebCore::appendRunsForObject): (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::skipNonBreakingSpace): (WebCore::shouldCollapseWhiteSpace): (WebCore::requiresLineBox): (WebCore::RenderBlock::generatesLineBoxesForInlineChild): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::shouldSkipWhitespaceAfterStartObject): (WebCore::RenderBlock::findNextLineBreak):
22:03 Changeset [44648] by zecke@webkit.org

Build fix for Qt. After recent ImageDeocder.h changes.

I want the original change to be backed out as the whole
Skia merging is going in the wrong direction. The discussion
will happen in the bugtracker.

https://bugs.webkit.org/show_bug.cgi?id=25709.

21:15 WebDevelopers edited by timothy@apple.com
(diff)
19:41 Changeset [44647] by jmalonzo@webkit.org

2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[Gtk] Enable more http/tests/navigation tests

  • platform/gtk/Skipped:

[Gtk] use strlen instead of g_utf8_strlen so we can enable more tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpHistoryItem):
19:31 Changeset [44646] by jmalonzo@webkit.org

2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix: include cstdio so we can use sscanf

Gtk/Win Cairo build fix: use isASCIISpace instead of isspace
Suggested by Brent Fulgham

  • platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::decodeDatum):
18:23 Changeset [44645] by pkasting@chromium.org

2009-06-12 Peter Kasting <pkasting@google.com>

Yet another Skia bustage fix.

  • platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::setSize): Avoid symbol name clash. The better fix is to take an IntSize(); I'll do that later.
18:18 Changeset [44644] by oliver@apple.com

Make LiteralParser non-recursive

Reviewed by Geoff Garen.

Convert LiteralParser from using a simple recursive descent parser
to a hand rolled PDA. Relatively simple conversion, but required
modifications to MarkedArgumentBuffer to make it more suitable as
a generic marked vector. I'll refactor and rename MarkedArgumentBuffer
in future as there are many other cases where it will be useful to
have such a class.

17:56 Changeset [44643] by pkasting@chromium.org

2009-06-12 Peter Kasting <pkasting@google.com>

Fix remaining Cairo build bustage from
https://bugs.webkit.org/show_bug.cgi?id=25709 changes. Use
Vector<char> in place of std::string.

  • platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::setData): (WebCore::XBMImageDecoder::decodeHeader): (WebCore::XBMImageDecoder::decodeDatum):
  • platform/image-decoders/xbm/XBMImageDecoder.h:
17:47 Changeset [44642] by levin@chromium.org

2009-06-12 David Levin <levin@chromium.org>

Reviewed by NOBODY (build fix for windows).

Adjust the exports for JSC on Windows like what was done for OSX in
the previous commit.

17:41 Changeset [44641] by levin@chromium.org

JavaScriptCore:

2009-06-12 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

UString shouldn't create sharedBuffer for SmallStrings.
https://bugs.webkit.org/show_bug.cgi?id=26360

The methods changed are not used by JSC, so there is no JS perf impact. However,
there is a potential DOM perf impact, so I re-ran several of the tests that
I ran previously and ensured that the perf stay the same which caused me to
adjust the minLengthToShare.

  • JavaScriptCore.exp:
  • runtime/UString.cpp: (JSC::UString::Rep::sharedBuffer):

Determines if the buffer being shared is big enough before doing so.
Previously, BaseString::sharedBuffer was called but it would only know
the length of the base string (BaseString::len) which may not be the same
as the string being shared (Rep::len).

(JSC::UString::BaseString::sharedBuffer):

This is now only be used by Rep::sharedBuffer. which does the length check.

  • runtime/UString.h:

WebCore:

2009-06-12 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

UString shouldn't create sharedBuffer for SmallStrings.
https://bugs.webkit.org/show_bug.cgi?id=26347

Change the call to use the method UString::Rep::sharedBuffer due
to changes in UString.

No noticable change in behavior, so no test.

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::create):
17:11 Changeset [44640] by simon.fraser@apple.com

2009-06-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=26095

Fix crash when a renderer for an anonymous node is composited
by null-checking renderer()->node().

Test: compositing/generated-content.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::rendererHasBackground): (WebCore::RenderLayerBacking::rendererBackgroundColor): (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): (WebCore::RenderLayerBacking::paintIntoLayer):
17:04 Changeset [44639] by pkasting@chromium.org

2009-06-12 Peter Kasting <pkasting@google.com>

Fix Chromium and some of Cairo build bustage, fallout from
https://bugs.webkit.org/show_bug.cgi?id=25709 changes.

  • WebCore.vcproj/WebCore.vcproj: Add missing XBM decoder files.
  • platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::copyRowNTimes): Fix typo that broke Skia GIF decoding.
16:39 Changeset [44638] by beidson@apple.com

2009-06-12 Brady Eidson <beidson@apple.com>

Reviewed by Oliver Hunt

Add a page indexing the various demo applications we have posted.

  • demos/index.html: Added.
  • nav.inc: Add a link to the demos page on the side bar
  • css/main.css: Add a style for date stamps based on the blog.
  • demos/calendar/index.html: Added to redirect to Calendar.html. I'm not moving Calendar.html to index.html as the Calendar.html url has already been published and we should keep it working.

Move the drosera test code to /misc, as it is no longer a meaningful demo:

  • demos/drosera: Removed.
  • demos/drosera/demo.js: Removed.
  • demos/drosera/drosera.png: Removed.
  • demos/drosera/index.html: Removed.
  • misc/drosera: Copied from demos/drosera.

Move the sticky notes example into /demos:

  • demos/sticky-notes: Added.
  • demos/sticky-notes/StickyNotes.manifest: Copied from misc/DatabaseExample.manifest.
  • demos/sticky-notes/deleteButton.png: Copied from misc/deleteButton.png.
  • demos/sticky-notes/deleteButtonPressed.png: Copied from misc/deleteButtonPressed.png.
  • demos/sticky-notes/index.html: Copied from misc/DatabaseExample.html.
  • misc/DatabaseExample.html: Changed to redirect to demos/sticky-notes/index.html. I'm not removing it altogether as the misc/DatabaseExample.html url has already been published and we should keep it working.
  • misc/DatabaseExample.manifest: Removed.
  • misc/deleteButton.png: Removed.
  • misc/deleteButtonPressed.png: Removed.
16:38 Changeset [44637] by simon.fraser@apple.com

2009-06-12 Simon Fraser <simon.fraser@apple.com>

Fix build when ACCELERATED_COMPOSITING is defined.

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::attachRootGraphicsLayer): (WebCore::EmptyChromeClient::setNeedsOneShotDrawingSynchronization): (WebCore::EmptyChromeClient::scheduleViewUpdate): Add stubs for the compositing-related ChromeClient methods.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition): (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): docWidth()/docHeight() became private. Use overflowWidth()/overflowHeight() instead, which matches what is used to size the WebHTMLView.
16:20 Changeset [44636] by dimich@chromium.org

2009-06-12 jorlow <jorlow@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26356
http://crbug.com/14006
Create custom bindings for v8. The rest of these files are still
forked (so the review is happening on the chromium review site).
These bindings have been tested on a hacked up Chromium instance
(also running --single-process) and Android.

  • bindings/v8/custom/V8StorageCustom.cpp: Added.
16:20 Changeset [44635] by dimich@chromium.org

2009-06-12 Dmitry Titov <dimich@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26359
[v8] Add XMLHttpRequest to WorkerContextExecutionProxy.

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object): Add type == V8ClassIndex::XMLHTTPREQUEST to the convertable types. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): same.
  • bindings/v8/WorkerContextExecutionProxy.h: fix typo in the comment.
15:55 Changeset [44634] by pkasting@chromium.org

2009-06-12 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part eight
Replace placeholder Cairo BMP, ICO, XBM decoders with real ones. Remove
all the decoders from skia/ since they are now just mirrors of the Cairo
ones.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon. Enable XBM decoding on Windows.
  • platform/graphics/skia/ImageSourceSkia.cpp:
  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon.
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.cpp.
  • platform/image-decoders/bmp/BMPImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.h.
  • platform/image-decoders/bmp/BMPImageReader.cpp: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.cpp.
  • platform/image-decoders/bmp/BMPImageReader.h: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.h.
  • platform/image-decoders/ico/ICOImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.cpp.
  • platform/image-decoders/ico/ICOImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.h.
  • platform/image-decoders/skia/BMPImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/BMPImageDecoder.h: Removed.
  • platform/image-decoders/skia/BMPImageReader.cpp: Removed.
  • platform/image-decoders/skia/BMPImageReader.h: Removed.
  • platform/image-decoders/skia/GIFImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/GIFImageDecoder.h: Removed.
  • platform/image-decoders/skia/GIFImageReader.cpp: Removed.
  • platform/image-decoders/skia/GIFImageReader.h: Removed.
  • platform/image-decoders/skia/ICOImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/ICOImageDecoder.h: Removed.
  • platform/image-decoders/skia/JPEGImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/JPEGImageDecoder.h: Removed.
  • platform/image-decoders/skia/PNGImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/PNGImageDecoder.h: Removed.
  • platform/image-decoders/skia/XBMImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/XBMImageDecoder.h: Removed.
  • platform/image-decoders/xbm/XBMImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.cpp.
  • platform/image-decoders/xbm/XBMImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.h.
15:41 Changeset [44633] by eric@webkit.org

2009-06-12 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26191
Remove xmath include in MathExtras.h, because it is not needed and also
breaks VS2008 builds with TR1 turned on.

  • wtf/MathExtras.h: Removed xmath include.
15:24 Changeset [44632] by kov@webkit.org

2009-06-12 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25599
[GTK] Enable more tests

Implement dumping of status callback.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewStatusBarTextChanged): (main):
15:17 Web Inspector edited by timothy@apple.com
Changes to be more current. (diff)
15:06 Changeset [44631] by pkasting@chromium.org

2009-06-11 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part seven
Update Skia's ImageDecoder.h with a few changes designed to reduce the
delta between specific implementations of ImageDecoder.h. Update
Cairo's ImageDecoder.h to sync up with the API changes in the Skia
version in the last two chage sets. Update Cairo's PNG/JPEG/GIF
decoders to use the APIs as well. All the Cairo image decoder changes
are direct copies of the Skia versions except ImageDecoder.h, which is
modified in the necessary ways for the differences between Cairo and
Skia.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() API.
  • platform/image-decoders/ImageDecoder.h: Sync up with Skia version. (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::copyRowNTimes): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setRGBA): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: Sync up with Skia version. (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow):
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Sync up with Skia version. (WebCore::JPEGImageDecoder::outputScanlines):
  • platform/image-decoders/png/PNGImageDecoder.cpp: Sync up with Skia version. (WebCore::PNGImageDecoder::rowAvailable):
  • platform/image-decoders/skia/ImageDecoder.h: Add various typedefs or helper functions to minimize differences with Cairo version. Reorder functions slightly to match reordering of Cairo's m_hasAlpha variable, which I moved to increase readability. (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::copyRowNTimes): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setRGBA): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/skia/JPEGImageDecoder.cpp: Add #include needed by JPEG headers on some platforms, plus comment.
14:36 Changeset [44630] by bfulgham@webkit.org

2009-06-12 Brent Fulgham <bfulgham@webkit.org>

Unreviewed build correction.

Revert accidental configuration checkin. Was not meant to
be part of the last changeset.

  • config.h:
14:34 Changeset [44629] by pkasting@chromium.org

(Accidentally missed a couple email addresses in the last patch)

14:25 Changeset [44628] by bfulgham@webkit.org

2009-06-12 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26353
Corrects handling of Cairo fonts that were getting out of
sync due to default copy construction. Also refactors
some incorrect platform font destruction code that belongs
in the font object's destructor.

  • platform/graphics/win/FontPlatformData.h:
  • platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::~FontPlatformData):
  • platform/graphics/win/FontPlatformDataCairoWin.cpp: (WebCore::FontPlatformData::platformDataInit): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::setFont): (WebCore::FontPlatformData::~FontPlatformData):
  • platform/graphics/win/FontPlatformDataWin.cpp:
  • platform/graphics/win/SimpleFontDataCGWin.cpp:
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformWidthForGlyph):
  • platform/graphics/win/SimpleFontDataWin.cpp:
14:19 Changeset [44627] by pkasting@chromium.org

JavaScriptCore:

2009-06-12 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

  • ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.

WebCore:

2009-06-12 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

  • ChangeLog-2007-10-14: Update my email address.
  • ChangeLog-2008-08-10: Update my email address.

WebKit/mac:

2009-06-12 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

  • ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.

WebKit/win:

2009-06-12 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

  • ChangeLog: Update my email address.
13:00 QtWebKitTodo edited by andre.pedralho@openbossa.org
(diff)
11:02 Changeset [44626] by levin@chromium.org

2009-06-12 Nate Chapin <japhet@google.com>

Reviewed by David Levin.

Upstream V8Helpers.

https://bugs.webkit.org/show_bug.cgi?id=26332

  • bindings/v8/V8Helpers.cpp: Added. (wrapNPObject): Moved from v8_helpers.cpp. (toV8Context): Moved from v8_helpers.cpp. (toV8Proxy): Moved from v8_helpers.cpp.
  • bindings/v8/V8Helpers.h: Added.
09:15 Changeset [44625] by kevino@webkit.org

wx build fix. Adding JSONObject.cpp to the build.

08:55 Changeset [44624] by jberlin@apple.com

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 44622)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,23 @@
+2009-06-12 Jessie Berlin <jberlin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24792
+ rdar://problem/6933055
+
+ Changes the radius in which cursor movement around the 4 arrow icon
+ while pan-scrolling does not cause scrolling from around 10 pixels to
+ 15 pixels, similar to what is found in IE and Firefox.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::setPanScrollCursor):
+ Factor out the no-pan-scroll radius.
+ * platform/ScrollView.h:
+ Create a constant for the no-pan-scroll radius.
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::panScrollFromPoint):
+ Factor out the no-pan-scroll radius.
+

2009-06-12 Xan Lopez <xlopez@igalia.com>


Reviewed by Gustavo Noronha.

Index: WebCore/page/EventHandler.cpp
===================================================================
--- WebCore/page/EventHandler.cpp (revision 44622)
+++ WebCore/page/EventHandler.cpp (working copy)
@@ -661,11 +661,10 @@ void EventHandler::setPanScrollCursor()

At the original click location we draw a 4 arrowed icon. Over this icon there won't be any scroll
So we don't want to change the cursor over this area

  • const int noScrollRadius = 9;
  • bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - noScrollRadius);
  • bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + noScrollRadius);
  • bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + noScrollRadius);
  • bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - noScrollRadius);

+ bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - ScrollView::noPanScrollRadius);
+ bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + ScrollView::noPanScrollRadius);
+ bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + ScrollView::noPanScrollRadius);
+ bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - ScrollView::noPanScrollRadius);

if (north) {

if (east)

Index: WebCore/platform/ScrollView.h
===================================================================
--- WebCore/platform/ScrollView.h (revision 44622)
+++ WebCore/platform/ScrollView.h (working copy)
@@ -214,7 +214,8 @@ public:

virtual void hide();
virtual void setParentVisible(bool);


  • Pan scrolling methods.

+ Pan scrolling.
+ static const int noPanScrollRadius = 15;

void addPanScrollIcon(const IntPoint&);
void removePanScrollIcon();


Index: WebCore/rendering/RenderLayer.cpp
===================================================================
--- WebCore/rendering/RenderLayer.cpp (revision 44622)
+++ WebCore/rendering/RenderLayer.cpp (working copy)
@@ -948,7 +948,6 @@ void RenderLayer::panScrollFromPoint(con

const int shortDistanceLimit = 100; We delimit a 200 pixels long square enclosing the original point
const int speedReducer = 2;
Within this square we divide the scrolling speed by 2


  • const int iconRadius = 10;

Frame* frame = renderer()->document()->frame();
if (!frame)

return;

@@ -965,9 +964,9 @@ void RenderLayer::panScrollFromPoint(con

int xDelta = currentMousePosition.x() - sourcePoint.x();
int yDelta = currentMousePosition.y() - sourcePoint.y();


  • if (abs(xDelta) < iconRadius) at the center we let the space for the icon

+ if (abs(xDelta) < ScrollView::noPanScrollRadius) at the center we let the space for the icon

xDelta = 0;

  • if (abs(yDelta) < iconRadius)

+ if (abs(yDelta) < ScrollView::noPanScrollRadius)

yDelta = 0;


Let's attenuate the speed for the short distances

07:44 Changeset [44623] by ariya@webkit.org

2009-06-12 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Jan Michael Alonzo.

[Qt] Fix build break
https://bugs.webkit.org/show_bug.cgi?id=26340

06/11/09:

23:46 Changeset [44622] by xan@webkit.org

2009-06-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25609
[GTK] Implement support for get_selection and get_n_selections

Only use the VisibleSelection object if it actually belongs to the
object we are using.

This is pretty hacky-ish, but I can't seem to find a direct API to
get the VisibleSelection for a given object, only the global one.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (selectionBelongsToObject): (webkit_accessible_text_get_n_selections): (webkit_accessible_text_get_selection):
17:58 Changeset [44621] by jparent@chromium.org

2009-06-11 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=2628i
Converted LayoutTests\editing\deleting\4875189.html from a pixel test t

dumpAsText test

since it only checks whether the result contains exactly two paragraphs

or not.

  • editing/deleting/4875189-expected.txt: Added.
  • editing/deleting/4875189.html:
  • platform/mac/editing/deleting/4875189-expected.checksum: Removed.
  • platform/mac/editing/deleting/4875189-expected.png: Removed.
  • platform/mac/editing/deleting/4875189-expected.txt: Removed.
  • platform/qt/editing/deleting/4875189-expected.txt: Removed.
16:47 Changeset [44620] by kov@webkit.org

2009-06-11 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

Add a test to perform an actual download.

  • tests/testdownload.c: (navigation_policy_decision_requested_cb): (notify_status_cb): (download_requested_cb): (test_webkit_download_perform): (main):
15:38 Changeset [44619] by kov@webkit.org

2009-06-11 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

Fix crash when downloading, caused by assuming SoupMessage would
be there. This change factors the logic required to create a
ResourceRequest from a WebKitNetworkRequest into a core()
function, like we have for some other classes.

  • webkit/webkitdownload.cpp: (webkit_download_start):
  • webkit/webkitprivate.cpp: (WebKit::core):
  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_load_request):
15:17 Changeset [44618] by eric@webkit.org

2009-06-11 Eric Seidel <eric@webkit.org>

Rubber stamped by Dave Levin.

Add missing pixel results

  • platform/mac/editing/style/apply-through-end-of-document-expected.checksum: Added.
  • platform/mac/editing/style/apply-through-end-of-document-expected.png: Added.
  • platform/mac/fast/canvas/canvas-empty-image-pattern-expected.checksum: Copied from LayoutTests/platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum.
  • platform/mac/fast/canvas/canvas-empty-image-pattern-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.png.
  • platform/mac/fast/css/compare-content-style-expected.checksum: Added.
  • platform/mac/fast/css/compare-content-style-expected.png: Added.
  • platform/mac/fast/dynamic/anchor-lock-expected.checksum: Added.
  • platform/mac/fast/dynamic/anchor-lock-expected.png: Added.
  • platform/mac/fast/transforms/bounding-rect-zoom-expected.checksum: Added.
  • platform/mac/fast/transforms/bounding-rect-zoom-expected.png: Added.
  • platform/mac/webarchive/test-link-rel-icon-expected.checksum: Copied from LayoutTests/platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum.
  • platform/mac/webarchive/test-link-rel-icon-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.png.
14:20 Changeset [44617] by eric@webkit.org

Speculative fix

13:05 Changeset [44616] by mrowe@apple.com

New tag.

13:05 Changeset [44615] by mrowe@apple.com

Hrm, this isn't where I should live.

13:03 Changeset [44614] by mrowe@apple.com

Versioning.

13:02 Changeset [44613] by mrowe@apple.com

New tag.

12:59 Changeset [44612] by mrowe@apple.com

Merge r44591.

12:58 Changeset [44611] by mrowe@apple.com

Versioning.

11:47 Changeset [44610] by oliver@apple.com

Lower stringify recursion limit to deal with small windows stack.

11:20 Changeset [44609] by bfulgham@webkit.org

2009-06-11 John Abd-El-Malek <jam@chromium.org>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=26306

Revert 42565 as it leads to DumpRenderTree crashing on startup because
Windows can't find CFURLCacheCopySharedURLCache in CoreNetwork.dll.

  • DumpRenderTree/win/DumpRenderTree.cpp:
11:15 Changeset [44608] by bfulgham@webkit.org

2009-06-11 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=25512
Handle texts after unfinished special tags (i.e., script, style, textarea,
title, xmp, and iframe) as the text node under the tags in view-source mode.
Before this change, all texts in unfinished special tags cannot be seen even in view-source mode.

10:57 Changeset [44607] by ariya@webkit.org

2009-06-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

Fix compilation warnings
<https://bugs.webkit.org/show_bug.cgi?id=26015>

  • wtf/ThreadingNone.cpp: (WTF::ThreadCondition::wait): Fix compilation warning. (WTF::ThreadCondition::timedWait): Ditto.
10:39 Changeset [44606] by ariya@webkit.org

2009-06-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] Fix release build detection
https://bugs.webkit.org/show_bug.cgi?id=26267

  • WebKit.pri:
10:28 Changeset [44605] by ariya@webkit.org

2009-06-11 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Ariya Hidayat.

https://bugs.webkit.org/show_bug.cgi?id=26291

[Qt] build break in ImageDecoderQt.cpp.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::reset): (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::isSizeAvailable):
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::setSize):
09:34 Changeset [44604] by bfulgham@webkit.org

2009-06-10 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

Fixes https://bugs.webkit.org/show_bug.cgi?id=26309.
Update a few items in the testing language to:
(1) Reflect results are now generated with Leopard (not Tiger)
(2) Explain how to generate pixel-level layout tests.

06:57 Changeset [44603] by hausmann@webkit.org

2009-06-11 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Ariya Hidayat.

Removed obsolete and unmaintained files from the old Symbian port.

04:59 QtWebKitTodo edited by hausmann@webkit.org
(diff)
04:58 QtWebKitTodo edited by hausmann@webkit.org
(diff)

06/10/09:

22:31 Changeset [44602] by bfulgham@webkit.org

2009-06-10 Brent Fulgham <bfulgham@gmail.com>

Unreviewed build fix.
Reverted change to skip file, as Windows build is
still failing.

  • platform/win/Skipped:
21:59 Changeset [44601] by bfulgham@webkit.org

2009-06-05 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Eric Seidel.

Re-enable the video-zoom-controls test on Windows.

https://bugs.webkit.org/show_bug.cgi?id=25465

  • platform/win/Skipped:
  • platform/win/media: Added.
  • platform/win/media/video-zoom-controls-expected.checksum: Added.
  • platform/win/media/video-zoom-controls-expected.png: Added.
  • platform/win/media/video-zoom-controls-expected.txt: Added.
21:44 Changeset [44600] by bfulgham@webkit.org

2009-06-10 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Jan Alonzo.

[gtk] Change DumpRenderTree to use a GtkScrolledWindow instead of GtkFixed

Change the code to use GtkScrolledWindow and resize the GtkScrolledWindow
to pass more tests. Make sure the content is bigger than a thumbnail.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): (main):
20:14 Changeset [44599] by kov@webkit.org

2009-06-10 Gustavo Noronha Silva <gns@gnome.org>

Disabling new tests, and tests that use features of DRT we don't
currently implement.

  • platform/gtk/Skipped:
19:48 Changeset [44598] by kov@webkit.org

2009-06-10 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

Add unit tests for our WebKitNetworkRequest object.

  • GNUmakefile.am:

WebKit/gtk

2009-06-10 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

Make WebKitNetworkRequest a proper GObject, making URI and
SoupMessage properties. Also adding unit tests for creation and
destruction.

  • tests/testnetworkrequest.c: Added. (test_network_request_create_destroy): (test_network_request_properties): (main):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_get_property): (webkit_network_request_set_property): (webkit_network_request_class_init): (webkit_network_request_init): (webkit_network_request_constructor): (webkit_network_request_new_with_core_request): (webkit_network_request_new): (webkit_network_request_set_uri): (webkit_network_request_get_uri):
  • webkit/webkitnetworkrequest.h:
17:31 Changeset [44597] by pkasting@chromium.org

2009-06-10 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part six
Miscellaneous tiny changes. The important bits here are the ANSI C++
compliance fix in skia/ImageDecoders.h (needed to compile this file on
non-MSVC) and some behavioral fixes for the XBM decoder that Chromium
unit tests partly exposed. Other changes are mostly cosmetic.

  • platform/image-decoders/ImageDecoder.h: Make some variables private again. This will break QTWebKit but those guys have agreed to wait on my finishing the ImageDecoder changes.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0). (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
  • platform/image-decoders/skia/BMPImageReader.cpp: (WebCore::BMPImageReader::decodeBMP): Make more in line with other decoders' comments and structure, use a ref to decrease verbosity. (WebCore::BMPImageReader::processRLEData): Use a ref to decrease verbosity. (WebCore::BMPImageReader::processNonRLEData): Use a ref to decrease verbosity.
  • platform/image-decoders/skia/GIFImageDecoder.cpp: Use IntPoint() instead of the redundant IntPoint(0, 0). (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0). (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
  • platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::copyRowNTimes): Fix ANSI violation that MSVC let me compile (!).
  • platform/image-decoders/skia/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
  • platform/image-decoders/skia/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
  • platform/image-decoders/skia/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::frameBufferAtIndex): Return 0 for non-zero indexes, don't try to decode unnecessarily after failure or when the size couldn't be computed, make more in line with other decoders' comments and structure, call RGBA32Buffer::setRect() appropriately.
17:16 Changeset [44596] by bfulgham@webkit.org

2009-06-10 Brent Fulgham <bfulgham@webkit.org>

Unreviewed build correction.

Clean up some stupid test mistakes, add pixel-level Mac tests
for the new zero-radius gradient test.

16:22 Changeset [44595] by bfulgham@webkit.org

Build correction for @r44574 (missing expected results).
See https://bugs.webkit.org/show_bug.cgi?id=26059.

15:47 Changeset [44594] by kov@webkit.org

2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

Clear the frame name before we run each tests so we don't get
"someFloaString" or "3" in the target frame name.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
15:40 BuildingQtOnLinux edited by tonikitoo@gmail.com
(diff)
15:37 BuildingQtOnLinux edited by tonikitoo@gmail.com
(diff)
15:37 BuildingQtOnLinux edited by tonikitoo@gmail.com
(diff)
14:54 Changeset [44593] by ojan@chromium.org

Fix collapsing empty shadow nodes in textareas.

13:55 Changeset [44592] by xan@webkit.org

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25609
[GTK] Implement support for get_selection and get_n_selections

Implement atk_text_get_n_selections.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_n_selections):
13:37 Changeset [44591] by mitz@apple.com

WebCore:

Reviewed by Anders Carlsson.

  • fix <rdar://problem/6958664> REGRESSION (r42665): When I drag to pan a Google map in iPhoto Places, it drags a map tile instead

Calling stopLoadRequest() from notifyFinished() removed the
ScriptElementData from the CachedScript's client set, which could make
it eligible for purging. The fix is to call removeClient() only after
executing the script, which protects it from being purged while it is
in the document's queue of scripts to execute soon.

  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::execute): Call removeClient() here. (WebCore::ScriptElementData::notifyFinished): Instead of calling stopLoadRequest(), which calls removeClient(), just reset m_cachedScript.

WebKitTools:

Reviewed by Adele Peterson.

  • add a LayoutTestController method for temporarily changing the WebKit cache model
  • DumpRenderTree/LayoutTestController.cpp: (setCacheModelCallback): Added. Calls LayoutTestController::setCacheModel() with the first argument as an integer. (LayoutTestController::staticFunctions): Added setCacheModel.
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setCacheModel):
  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): Reset the cache model to WebCacheModelDocumentBrowser.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setCacheModel): Added. Calls -[WebPreferences setCacheModel:].
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCacheModel):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setCacheModel):

LayoutTests:

Reviewed by Adele Peterson.

  • updated test to cover <rdar://problem/6958664> REGRESSION (r42665): When I drag to pan a Google map in iPhoto Places, it drags a map tile instead
  • fast/dom/HTMLScriptElement/nested-execution.html:
  • fast/dom/HTMLScriptElement/resources/nested-execution.js:
13:36 Changeset [44590] by jmalonzo@webkit.org

2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Mark Rowe and Eric Seidel.

Update WebInspector localizedStrings.js with new resource tracking strings
https://bugs.webkit.org/show_bug.cgi?id=26247

  • English.lproj/localizedStrings.js:
12:43 Changeset [44589] by kov@webkit.org

Tagging 1.1.9.

12:22 Changeset [44588] by bfulgham@webkit.org

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android specific files.
https://bugs.webkit.org/show_bug.cgi?id=26280

12:21 Changeset [44587] by bfulgham@webkit.org

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android specific file to WebCore/platform/android (part 9).
https://bugs.webkit.org/show_bug.cgi?id=26266

12:19 Changeset [44586] by bfulgham@webkit.org

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android platform specific files.
https://bugs.webkit/org/show_bug.cgi?id=26265 (part 8).

12:18 Changeset [44585] by bfulgham@webkit.org

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform. (part 6).
https://bugs.webkit.org/show_bug.cgi?id=26264

12:11 Changeset [44584] by bfulgham@webkit.org

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 7).
https://bugs.webkit.org/show_bug.cgi?id=23296

12:09 Changeset [44583] by bfulgham@webkit.org

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 5).
https://bugs.webkit.org/show_bug.cgi?id=23296

12:06 Changeset [44582] by bfulgham@webkit.org

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 4).
https://bugs.webkit.org/show_bug.cgi?id=23296

12:05 Changeset [44581] by bfulgham@webkit.org

2009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 3).
https://bugs.webkit.org/show_bug.cgi?id=23296

12:01 Changeset [44580] by bfulgham@webkit.org

009-06-10 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 2).
https://bugs.webkit.org/show_bug.cgi?id=23296

11:46 Changeset [44579] by levin@chromium.org

2009-06-10 Nate Chapin <japhet@google.com>

Reviewed by David Levin.

Finish moving V8Custom from src.chromium.org to svn.webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=26258

  • bindings/v8/custom/V8CustomBinding.cpp: Finished upstreaming. (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp. (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp. (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp. (WebCore::V8Custom::GetTargetFrame): Moved from v8_custom.cpp. (WebCore::V8Custom::DowncastSVGPathSeg): Moved from v8_custom.cpp.
  • bindings/v8/custom/V8CustomBinding.h: Finished upstreaming.
  • bindings/v8/custom/V8DatabaseCustom.cpp: Updated includes.
  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Updated includes.
  • bindings/v8/custom/V8SQLTransactionCustom.cpp: Updated includes.
  • bindings/v8/custom/V8WebKitPointConstructor.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp.
11:21 Changeset [44578] by bfulgham@webkit.org

2009-06-05 Takeshi Yoshino <tyoshino@google.com>

Reviewed by NOBODY (OOPS!).

https://bugs.webkit.org/show_bug.cgi?id=26214
Bug 26214: RenderTextControl: Remove ASSERT for checking that visiblePositionForIndex()'s return is not null.

11:18 Changeset [44577] by kov@webkit.org

2009-06-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

News for 1.1.9.

  • NEWS:
11:16 Changeset [44576] by bfulgham@webkit.org

2009-06-04 Roland Steiner <rolandsteiner@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26197
Bug 26197: Incorrect variable initialization in PlatformContextSkia.cpp

11:04 Changeset [44575] by bfulgham@webkit.org

2009-06-10 Dean McNamee <deanm@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26061
Make sure filling a canvas pattern with an empty image doesn't crash.

10:57 Changeset [44574] by bfulgham@webkit.org

Correct Bug #26059.
https://bugs.webkit.org/show_bug.cgi?id=26059.

10:46 Changeset [44573] by pkasting@chromium.org

2009-06-10 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part five
Rewrite users of ImageDecoder.h to use "safe" API calls, Skia side.
This tweaks the RGBA32Buffer interfaces to be implementable by Cairo as
well and modifies Skia's usage of those interfaces accordingly. Once a
similar change lands on the Cairo side, the Skia and Cairo decoders
should be identical except for the implementation of RGBA32Buffer.

  • platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() function.
  • platform/image-decoders/skia/BMPImageReader.cpp: (WebCore::BMPImageReader::processNonRLEData): Use new RGBA32Buffer::zeroFill() function.
  • platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow): Rewrite to use RGBA32Buffer::setRGBA(x, y, ...) calls as well as other RGBA32Buffer interface calls instead of knowing the underlying types inside the buffer; also try and add clarity.
  • platform/image-decoders/skia/ImageDecoder.h: Removed bitmap(), width(), and height(). (WebCore::RGBA32Buffer::zeroFill): Added. (WebCore::RGBA32Buffer::copyBitmapData): Avoid using bitmap(), which is going away. (WebCore::RGBA32Buffer::copyRowNTimes): Added. (WebCore::RGBA32Buffer::setSize): Use new zeroFill() function. (WebCore::RGBA32Buffer::asNewNativeImage): Added. (WebCore::RGBA32Buffer::setRGBA): Condensed two versions into one that takes coordinates instead of a raw pointer.
10:36 Changeset [44572] by xan@webkit.org

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Version bump in preparation for 1.1.9 release.

  • configure.ac:
10:27 Changeset [44571] by xan@webkit.org

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25671
[GTK] Implement support for set_caret_offset

Make an implementation that actually works.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_set_caret_offset):
10:26 Changeset [44570] by bfulgham@webkit.org

2009-06-09 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

Clear the frame name before we run each tests so we don't get
"someFloaString" or "3" in the target frame name.

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_clear_main_frame_name):
10:25 Changeset [44569] by darin@chromium.org

2009-06-10 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26294

Make sure all member variables are initialized so that the default
assignment operator and copy constructors do not read uninitialized
memory.

  • platform/network/ResourceResponseBase.cpp:
10:18 Changeset [44568] by bfulgham@webkit.org

2009-06-10 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Update main resource meta-data when resource tracking is disabled.

https://bugs.webkit.org/show_bug.cgi?id=26253

  • inspector/InspectorController.cpp: (WebCore::InspectorController::getTrackedResource): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
  • inspector/InspectorController.h:
10:17 Changeset [44567] by xan@webkit.org

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25609
[GTK] Implement support for get_selection and get_n_selections

Implement atk_text_get_selection.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_selection):
10:03 Changeset [44566] by xan@webkit.org

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not check if our parent class has the finalize method, it's
guaranteed to be there.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_finalize):
09:25 Changeset [44565] by bfulgham@webkit.org

2009-06-10 Brent Fulgham <bfulgham@webkit.org>

Build correct for Windows Cairo targets.

  • WebCore.vcproj/WebCore.vcproj: Disable warning 4611 (interaction between '_setjmp' and C++ object destruction is non-portable) for the two Cairo targets. This used to be disabled in a #pragma, but recent refactoring removed these lines.
09:20 Changeset [44564] by bfulgham@webkit.org

2009-06-10 Brent Fulgham <bfulgham@webkit.org>

Build fix for Windows target.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Correct missing </File> tag after @r44550 that prevents the project from being loaded in the Visual Studio IDE.
09:06 QtWebKitTodo edited by andre.pedralho@openbossa.org
(diff)
08:37 Changeset [44563] by hausmann@webkit.org

2009-06-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Fix the build of PluginView on Qt with 64-bit where we disable plugins
at compile time.

Use the FooNone.cpp files at compile-time.

08:32 Changeset [44562] by hausmann@webkit.org

2009-06-10 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Qt build.

ImageDecoderQt needs m_size and m_sizeAvailable to be protected.

08:21 Changeset [44561] by vestbo@webkit.org

2009-06-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Use absolute path for install_name on Mac

07:48 Changeset [44560] by ariya@webkit.org

2009-06-10 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Ariya Hidayat.

Documented ResolveRule and StylePriority enum values as well as their use in
QWebElement::styleProperty and QWebElement::setStyleProperty methods.

Based on the work of Simon Hausmann.

  • Api/qwebelement.cpp: (QWebElement::styleProperty): (QWebElement::setStyleProperty):
  • Api/qwebelement.h:
06:10 Changeset [44559] by xan@webkit.org

2009-06-08 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Reduce duplicated code to access the text of a AtkText
object. doAXStringForRange calls text() internally, so we are
doing exactly the same after the change.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getGailTextUtilForAtk): (getPangoLayoutForAtk):
06:10 Changeset [44558] by xan@webkit.org

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Pass a PangoLayout to the GailTextUtil function calls.

It's needed for LINE boundary calls to work correctly.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (updateLayout): (getPangoLayoutForAtk): (webkit_accessible_text_get_text_after_offset): (webkit_accessible_text_get_text_at_offset):
06:10 Changeset [44557] by xan@webkit.org

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Add new dependency on the Gail utils library, needed for our a11y
implementation.

  • GNUmakefile.am:
  • configure.ac:

WebCore:

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Use GailUtilText instead of my crappy partial reimplementation of
it. This should add support for LINE boundaries too, although it's
mostly untested for now.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getGailTextUtilForAtk): (webkit_accessible_text_get_text_after_offset): (webkit_accessible_text_get_text_at_offset):

WebKit/gtk:

2009-06-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Update test for new implementation (it fixes two bugs and adds
actual implementations for LINE boundaries).

  • tests/testatk.c: (test_webkit_atk_get_text_at_offset):
03:41 Changeset [44556] by jmalonzo@webkit.org

2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix: include <stdio.h> as it is required in jpeglib.h

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
Note: See TracTimeline for information about the timeline view.