Timeline


and

06/16/09:

23:13 Changeset [44754] by kevino@webkit.org

Reviewed by Kevin Ollivier.

In ImageSource::setData, delete the old m_encoder before replacing it with a new one.

https://bugs.webkit.org/show_bug.cgi?id=26458

22:19 Changeset [44753] by simon.fraser@apple.com

2009-06-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

<rdar://problem/6976766> Control-click on pages with accelerated compositing
content does not work.

Part deux. #ifdef the use of _private->layerHostingView with
USE(ACCELERATED_COMPOSITING)

  • WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]):
22:12 Changeset [44752] by simon.fraser@apple.com

2009-06-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

<rdar://problem/6976766> Control-click on pages with accelerated compositing
content does not work.

Remove the WebLayerHostingView subclass of NSView, with its attempts to
forward events to the WebHTMLView, and just fix -[WebHTMLView hitTest:]
to ignore the layerHostingView.

  • WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]): (-[WebHTMLView attachRootLayer:]):
21:56 Changeset [44751] by levin@chromium.org

WebCore:

2009-06-16 David Levin <levin@chromium.org>

Reviewed by David Hyatt.

REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326

Test: scrollbars/scrollbar-crash-on-refresh.html

  • dom/Document.cpp: (WebCore::Document::detach): Gives the FrameView a change to do any necessary cleanup on Document::detach() which is where the renderArena gets detroyed.
  • page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars): Gets rid of any custom scrollbars (if the docment supplied them).
  • page/FrameView.h:
  • platform/Scrollbar.h: (WebCore::Scrollbar::isCustomScrollbar):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Removed the check for document()->frame(). If frame() is 0 in this code, then the call to animation() is also incorrect (since it does document()->frame()->animation()).
  • rendering/RenderScrollbar.h: (WebCore::RenderScrollbar::isCustomScrollbar):

LayoutTests:

2009-06-16 David Levin <levin@chromium.org>

Reviewed by David Hyatt.

REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326

Test that refreshing an iframe with custom scrollbars works without crashing.

  • scrollbars/resources/page-with-custom-scrollbars.html: Added.
  • scrollbars/scrollbar-crash-on-refresh-expected.txt: Added.
  • scrollbars/scrollbar-crash-on-refresh.html: Added.
19:35 Changeset [44750] by bweinstein@apple.com

2009-06-16 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adele Peterson.

Fix of <rdar://6967547> Ctrl-C copies null value erasing text in clipboard in Safari.
This patch kept the way events were firing as they were before, and Windows events are
consistent with Mac.

  • editing/Editor.cpp: (WebCore::Editor::tryDHTMLCopy): Added check for canCopy() before clearing PasteBoard (WebCore::Editor::tryDHTMLCut): Added check for canCut() before clearing PasteBoard
17:38 Changeset [44749] by antti@apple.com

2009-06-16 Antti Koivisto <antti@apple.com>

Reviewed by Brady Eidson.

<rdar://problem/6660037> CrashTracer: [USER] 46 crashes in Safari at com.apple.WebCore • WebCore::CachedCSSStyleSheet::addClient + 53


When revalidating a resource, calling addClient() on one client might cause another to get removed.


  • made CachedResource::addClient() non-virtual and added virtual didAddClient()
  • in CachedResource::switchClientsToRevalidatedResource() add all clients to the client set of the revalidated resource first
  • check if the client is still in the set before invoking didAddClient() for it


No test case, I didn't manage to construct one. You need some combination of 304 revalidation, stylesheets that
reference each other via @imports and reloading.

  • WebCore.base.exp:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::didAddClient):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedFont.cpp: (WebCore::CachedFont::didAddClient):
  • loader/CachedFont.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::didAddClient):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::addClient): (WebCore::CachedResource::addClientToSet): (WebCore::CachedResource::switchClientsToRevalidatedResource):
  • loader/CachedResource.h:
  • loader/CachedScript.cpp: (WebCore::CachedScript::didAddClient):
  • loader/CachedScript.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::didAddClient):
  • loader/CachedXSLStyleSheet.h:
16:35 Changeset [44748] by barraclough@apple.com

2009-06-16 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver hunt.

Temporarily partially disable r44492, since this is causing some problems on internal builds.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):
  • jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION):
15:39 Changeset [44747] by bdakin@apple.com

2009-06-16 Beth Dakin <bdakin@apple.com>

Rubber-stamped by Mark Rowe.

The rest of the text metric layout test changes for the branch.

  • fast/forms/text-control-intrinsic-widths-expected.txt:
  • fast/forms/textarea-metrics-expected.txt:
  • fast/replaced/table-percent-height-text-controls-expected.txt:
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum:
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.png:
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt:
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum:
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png:
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt:
  • platform/mac-leopard/media/audio-controls-rendering-expected.checksum:
  • platform/mac-leopard/media/audio-controls-rendering-expected.png:
  • platform/mac-leopard/media/video-aspect-ratio-expected.checksum:
  • platform/mac-leopard/media/video-aspect-ratio-expected.png:
  • platform/mac-leopard/media/video-controls-rendering-expected.checksum:
  • platform/mac-leopard/media/video-controls-rendering-expected.png:
  • platform/mac-leopard/media/video-display-toggle-expected.checksum:
  • platform/mac-leopard/media/video-display-toggle-expected.png:
  • platform/mac-leopard/media/video-empty-source-expected.png:
  • platform/mac-leopard/media/video-layer-crash-expected.checksum:
  • platform/mac-leopard/media/video-layer-crash-expected.png:
  • platform/mac-leopard/media/video-transformed-expected.checksum:
  • platform/mac-leopard/media/video-transformed-expected.png:
  • platform/mac-leopard/media/video-zoom-controls-expected.checksum:
  • platform/mac-leopard/media/video-zoom-controls-expected.png:
  • platform/mac-leopard/media/video-zoom-expected.checksum:
  • platform/mac-leopard/media/video-zoom-expected.png:
  • platform/mac/animations/animation-drt-api-expected.png:
  • platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.png:
  • platform/mac/fast/backgrounds/background-clip-text-expected.checksum:
  • platform/mac/fast/backgrounds/background-clip-text-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.png:
  • platform/mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/mac/fast/block/margin-collapse/103-expected.png:
  • platform/mac/fast/block/margin-collapse/103-expected.txt:
  • platform/mac/fast/block/positioning/047-expected.checksum:
  • platform/mac/fast/block/positioning/047-expected.png:
  • platform/mac/fast/borders/border-image-rotate-transform-expected.checksum:
  • platform/mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/mac/fast/css-generated-content/hit-test-generated-content-expected.png:
  • platform/mac/fast/css/line-height-expected.checksum:
  • platform/mac/fast/css/line-height-expected.png:
  • platform/mac/fast/css/line-height-expected.txt:
  • platform/mac/fast/css/line-height-font-order-expected.checksum:
  • platform/mac/fast/css/line-height-font-order-expected.png:
  • platform/mac/fast/css/resize-corner-tracking-expected.checksum:
  • platform/mac/fast/css/resize-corner-tracking-expected.png:
  • platform/mac/fast/css/resize-corner-tracking-expected.txt:
  • platform/mac/fast/css/resize-corner-tracking-transformed-expected.png:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/mac/fast/dom/isindex-002-expected.checksum:
  • platform/mac/fast/dom/isindex-002-expected.png:
  • platform/mac/fast/dom/isindex-002-expected.txt:
  • platform/mac/fast/dynamic/008-expected.checksum:
  • platform/mac/fast/dynamic/008-expected.png:
  • platform/mac/fast/dynamic/008-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.checksum:
  • platform/mac/fast/events/autoscroll-expected.png:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.checksum:
  • platform/mac/fast/events/context-no-deselect-expected.png:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/events/label-focus-expected.checksum:
  • platform/mac/fast/events/label-focus-expected.png:
  • platform/mac/fast/events/label-focus-expected.txt:
  • platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum:
  • platform/mac/fast/events/standalone-image-drag-to-editable-expected.png:
  • platform/mac/fast/forms/001-expected.checksum:
  • platform/mac/fast/forms/001-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.checksum:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.checksum:
  • platform/mac/fast/forms/box-shadow-override-expected.png:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.checksum:
  • platform/mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/encoding-test-expected.checksum:
  • platform/mac/fast/forms/encoding-test-expected.png:
  • platform/mac/fast/forms/encoding-test-expected.txt:
  • platform/mac/fast/forms/fieldset-align-expected.checksum:
  • platform/mac/fast/forms/fieldset-align-expected.png:
  • platform/mac/fast/forms/fieldset-align-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.checksum:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/input-align-expected.checksum:
  • platform/mac/fast/forms/input-align-expected.png:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.checksum:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.checksum:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-disabled-expected.checksum:
  • platform/mac/fast/forms/input-appearance-disabled-expected.png:
  • platform/mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.checksum:
  • platform/mac/fast/forms/input-appearance-focus-expected.png:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.checksum:
  • platform/mac/fast/forms/input-appearance-height-expected.png:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.checksum:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.checksum:
  • platform/mac/fast/forms/input-appearance-readonly-expected.png:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.checksum:
  • platform/mac/fast/forms/input-appearance-selection-expected.png:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-visibility-expected.checksum:
  • platform/mac/fast/forms/input-appearance-visibility-expected.png:
  • platform/mac/fast/forms/input-appearance-visibility-expected.txt:
  • platform/mac/fast/forms/input-appearance-width-expected.checksum:
  • platform/mac/fast/forms/input-appearance-width-expected.png:
  • platform/mac/fast/forms/input-appearance-width-expected.txt:
  • platform/mac/fast/forms/input-baseline-expected.checksum:
  • platform/mac/fast/forms/input-baseline-expected.png:
  • platform/mac/fast/forms/input-baseline-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.checksum:
  • platform/mac/fast/forms/input-disabled-color-expected.png:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.checksum:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-paste-undo-expected.checksum:
  • platform/mac/fast/forms/input-paste-undo-expected.png:
  • platform/mac/fast/forms/input-paste-undo-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.checksum:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.checksum:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.png:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/input-readonly-empty-expected.checksum:
  • platform/mac/fast/forms/input-readonly-empty-expected.png:
  • platform/mac/fast/forms/input-readonly-empty-expected.txt:
  • platform/mac/fast/forms/input-spaces-expected.checksum:
  • platform/mac/fast/forms/input-spaces-expected.png:
  • platform/mac/fast/forms/input-spaces-expected.txt:
  • platform/mac/fast/forms/input-table-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.checksum:
  • platform/mac/fast/forms/input-text-click-inside-expected.png:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-click-outside-expected.checksum:
  • platform/mac/fast/forms/input-text-click-outside-expected.png:
  • platform/mac/fast/forms/input-text-click-outside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.checksum:
  • platform/mac/fast/forms/input-text-double-click-expected.png:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.checksum:
  • platform/mac/fast/forms/input-text-drag-down-expected.png:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.checksum:
  • platform/mac/fast/forms/input-text-option-delete-expected.png:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.checksum:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.checksum:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/input-text-word-wrap-expected.checksum:
  • platform/mac/fast/forms/input-text-word-wrap-expected.png:
  • platform/mac/fast/forms/input-text-word-wrap-expected.txt:
  • platform/mac/fast/forms/input-type-change2-expected.checksum:
  • platform/mac/fast/forms/input-type-change2-expected.png:
  • platform/mac/fast/forms/input-type-change2-expected.txt:
  • platform/mac/fast/forms/input-type-text-min-width-expected.checksum:
  • platform/mac/fast/forms/input-type-text-min-width-expected.png:
  • platform/mac/fast/forms/input-type-text-min-width-expected.txt:
  • platform/mac/fast/forms/input-value-expected.checksum:
  • platform/mac/fast/forms/input-value-expected.png:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/forms/input-width-expected.checksum:
  • platform/mac/fast/forms/input-width-expected.png:
  • platform/mac/fast/forms/input-width-expected.txt:
  • platform/mac/fast/forms/isindex-placeholder-expected.checksum:
  • platform/mac/fast/forms/isindex-placeholder-expected.png:
  • platform/mac/fast/forms/isindex-placeholder-expected.txt:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
  • platform/mac/fast/forms/menulist-clip-expected.checksum:
  • platform/mac/fast/forms/menulist-clip-expected.png:
  • platform/mac/fast/forms/menulist-narrow-width-expected.checksum:
  • platform/mac/fast/forms/menulist-narrow-width-expected.png:
  • platform/mac/fast/forms/menulist-option-wrap-expected.checksum:
  • platform/mac/fast/forms/menulist-option-wrap-expected.png:
  • platform/mac/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/mac/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/mac/fast/forms/negativeLineHeight-expected.checksum:
  • platform/mac/fast/forms/negativeLineHeight-expected.png:
  • platform/mac/fast/forms/negativeLineHeight-expected.txt:
  • platform/mac/fast/forms/password-placeholder-expected.checksum:
  • platform/mac/fast/forms/password-placeholder-expected.png:
  • platform/mac/fast/forms/password-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.checksum:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.png:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.checksum:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.checksum:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.png:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/mac/fast/forms/placeholder-set-value-expected.checksum:
  • platform/mac/fast/forms/placeholder-set-value-expected.png:
  • platform/mac/fast/forms/placeholder-set-value-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.checksum:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.checksum:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.checksum:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.png:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.checksum:
  • platform/mac/fast/forms/search-rtl-expected.png:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/search-transformed-expected.checksum:
  • platform/mac/fast/forms/search-transformed-expected.png:
  • platform/mac/fast/forms/search-transformed-expected.txt:
  • platform/mac/fast/forms/search-zoomed-expected.checksum:
  • platform/mac/fast/forms/search-zoomed-expected.png:
  • platform/mac/fast/forms/search-zoomed-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.checksum:
  • platform/mac/fast/forms/searchfield-heights-expected.png:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/forms/select-baseline-expected.checksum:
  • platform/mac/fast/forms/select-baseline-expected.png:
  • platform/mac/fast/forms/select-style-expected.checksum:
  • platform/mac/fast/forms/select-style-expected.png:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.checksum:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/textAreaLineHeight-expected.checksum:
  • platform/mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/mac/fast/forms/textAreaLineHeight-expected.txt:
  • platform/mac/fast/forms/textarea-align-expected.checksum:
  • platform/mac/fast/forms/textarea-align-expected.png:
  • platform/mac/fast/forms/textarea-align-expected.txt:
  • platform/mac/fast/forms/textarea-rows-cols-expected.checksum:
  • platform/mac/fast/forms/textarea-rows-cols-expected.png:
  • platform/mac/fast/forms/textarea-rows-cols-expected.txt:
  • platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
  • platform/mac/fast/forms/textarea-scroll-height-expected.png:
  • platform/mac/fast/forms/textarea-scroll-height-expected.txt:
  • platform/mac/fast/forms/textarea-scrollbar-expected.checksum:
  • platform/mac/fast/forms/textarea-scrollbar-expected.png:
  • platform/mac/fast/forms/textarea-scrollbar-expected.txt:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.checksum:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.png:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/mac/fast/forms/textarea-setinnerhtml-expected.checksum:
  • platform/mac/fast/forms/textarea-setinnerhtml-expected.png:
  • platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/mac/fast/forms/textarea-width-expected.checksum:
  • platform/mac/fast/forms/textarea-width-expected.png:
  • platform/mac/fast/forms/textarea-width-expected.txt:
  • platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum:
  • platform/mac/fast/forms/textfield-drag-into-disabled-expected.png:
  • platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.checksum:
  • platform/mac/fast/forms/textfield-outline-expected.png:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.checksum:
  • platform/mac/fast/forms/textfield-overflow-expected.png:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/frames/content-opacity-1-expected.checksum:
  • platform/mac/fast/frames/content-opacity-1-expected.png:
  • platform/mac/fast/frames/content-opacity-2-expected.checksum:
  • platform/mac/fast/frames/content-opacity-2-expected.png:
  • platform/mac/fast/inline/long-wrapped-line-expected.checksum:
  • platform/mac/fast/inline/long-wrapped-line-expected.png:
  • platform/mac/fast/invalid/residual-style-expected.txt:
  • platform/mac/fast/layers/normal-flow-hit-test-expected.png:
  • platform/mac/fast/layers/opacity-transforms-expected.png:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.checksum:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.png:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/mac/fast/overflow/overflow-x-y-expected.checksum:
  • platform/mac/fast/overflow/overflow-x-y-expected.png:
  • platform/mac/fast/overflow/overflow-x-y-expected.txt:
  • platform/mac/fast/parser/comment-in-textarea-expected.checksum:
  • platform/mac/fast/parser/comment-in-textarea-expected.png:
  • platform/mac/fast/parser/comment-in-textarea-expected.txt:
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.checksum:
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.png:
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.checksum:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.png:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/mac/fast/reflections/reflection-masks-expected.png:
  • platform/mac/fast/reflections/reflection-overflow-hidden-expected.png:
  • platform/mac/fast/repaint/4776765-expected.png:
  • platform/mac/fast/repaint/change-transform-expected.png:
  • platform/mac/fast/repaint/delete-into-nested-block-expected.png:
  • platform/mac/fast/repaint/fixed-expected.checksum:
  • platform/mac/fast/repaint/fixed-expected.png:
  • platform/mac/fast/repaint/outline-child-repaint-expected.png:
  • platform/mac/fast/repaint/outline-repaint-glitch-expected.png:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/repaint/search-field-cancel-expected.checksum:
  • platform/mac/fast/repaint/search-field-cancel-expected.png:
  • platform/mac/fast/repaint/search-field-cancel-expected.txt:
  • platform/mac/fast/repaint/selected-replaced-expected.png:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.checksum:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.png:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/mac/fast/repaint/table-outer-border-expected.checksum:
  • platform/mac/fast/repaint/table-outer-border-expected.png:
  • platform/mac/fast/repaint/transform-absolute-child-expected.png:
  • platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/mac/fast/repaint/transform-relative-position-expected.png:
  • platform/mac/fast/repaint/transform-repaint-descendants-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-expected.checksum:
  • platform/mac/fast/replaced/replaced-breaking-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.checksum:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.checksum:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.png:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/mac/fast/replaced/width100percent-textarea-expected.checksum:
  • platform/mac/fast/replaced/width100percent-textarea-expected.png:
  • platform/mac/fast/replaced/width100percent-textarea-expected.txt:
  • platform/mac/fast/replaced/width100percent-textfield-expected.checksum:
  • platform/mac/fast/replaced/width100percent-textfield-expected.png:
  • platform/mac/fast/replaced/width100percent-textfield-expected.txt:
  • platform/mac/fast/runin/generated-expected.checksum:
  • platform/mac/fast/runin/generated-expected.png:
  • platform/mac/fast/table/003-expected.checksum:
  • platform/mac/fast/table/003-expected.png:
  • platform/mac/fast/table/003-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-expected.checksum:
  • platform/mac/fast/table/colspanMinWidth-expected.png:
  • platform/mac/fast/table/colspanMinWidth-expected.txt:
  • platform/mac/fast/table/spanOverlapRepaint-expected.checksum:
  • platform/mac/fast/table/spanOverlapRepaint-expected.png:
  • platform/mac/fast/table/spanOverlapRepaint-expected.txt:
  • platform/mac/fast/table/text-field-baseline-expected.checksum:
  • platform/mac/fast/table/text-field-baseline-expected.png:
  • platform/mac/fast/table/text-field-baseline-expected.txt:
  • platform/mac/fast/table/vertical-align-baseline-expected.checksum:
  • platform/mac/fast/table/vertical-align-baseline-expected.png:
  • platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.checksum:
  • platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.png:
  • platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.checksum:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/fast/transforms/transform-on-inline-expected.png:
  • platform/mac/fast/transforms/transform-table-row-expected.png:
  • platform/mac/fast/transforms/transformed-caret-expected.png:
  • platform/mac/fast/transforms/transformed-document-element-expected.png:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.checksum:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac/fonts/serif-expected.checksum:
  • platform/mac/fonts/serif-expected.png:
  • platform/mac/http/tests/navigation/anchor-frames-expected.checksum:
  • platform/mac/http/tests/navigation/anchor-frames-expected.png:
  • platform/mac/http/tests/navigation/anchor-frames-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.checksum:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-01-t-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.checksum:
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
  • platform/mac/svg/batik/paints/patternRegions-expected.checksum:
  • platform/mac/svg/batik/paints/patternRegions-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textOnPath-expected.checksum:
  • platform/mac/svg/batik/text/textOnPath-expected.png:
  • platform/mac/svg/batik/text/verticalText-expected.checksum:
  • platform/mac/svg/batik/text/verticalText-expected.png:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.checksum:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/mac/svg/carto.net/window-expected.checksum:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.checksum:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.png:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.checksum:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.checksum:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.png:
  • platform/mac/svg/custom/gradient-stroke-width-expected.checksum:
  • platform/mac/svg/custom/gradient-stroke-width-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/custom/js-late-marker-and-object-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-marker-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-marker-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-marker-creation-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/mac/svg/custom/marker-changes-expected.checksum:
  • platform/mac/svg/custom/marker-changes-expected.png:
  • platform/mac/svg/custom/marker-child-changes-expected.checksum:
  • platform/mac/svg/custom/marker-child-changes-expected.png:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.checksum:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.png:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.checksum:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.png:
  • platform/mac/svg/custom/path-bad-data-expected.checksum:
  • platform/mac/svg/custom/path-bad-data-expected.png:
  • platform/mac/svg/custom/pattern-rotate-expected.checksum:
  • platform/mac/svg/custom/pattern-rotate-expected.png:
  • platform/mac/svg/custom/pointer-events-path-expected.checksum:
  • platform/mac/svg/custom/pointer-events-path-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.checksum:
  • platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
  • platform/mac/svg/custom/use-elementInstance-event-target-expected.checksum:
  • platform/mac/svg/custom/use-elementInstance-event-target-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.checksum:
  • platform/mac/svg/hixie/mixed/003-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/svg/text/text-fonts-01-t-expected.checksum:
  • platform/mac/svg/text/text-fonts-01-t-expected.png:
  • platform/mac/svg/text/text-path-01-b-expected.checksum:
  • platform/mac/svg/text/text-path-01-b-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-07-t-expected.checksum:
  • platform/mac/svg/text/text-text-07-t-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.png:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug194024-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug194024-expected.png:
  • platform/mac/tables/mozilla/bugs/bug194024-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.png:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.png:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30559-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug30559-expected.png:
  • platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.png:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.png:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.png:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.png:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.png:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.png:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.png:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/mac/tables/mozilla/dom/tableDom-expected.checksum:
  • platform/mac/tables/mozilla/dom/tableDom-expected.png:
  • platform/mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/mac/tables/mozilla/other/move_row-expected.checksum:
  • platform/mac/tables/mozilla/other/move_row-expected.png:
  • platform/mac/tables/mozilla/other/move_row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.checksum:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/mac/transitions/transition-drt-api-expected.png:
  • svg/custom/svg-fonts-in-text-controls-expected.txt:
15:37 Changeset [44746] by simon.fraser@apple.com

2009-06-16 Simon Fraser <simon.fraser@apple.com>

No Review

Fix code inside an #ifdef that draws the video framerate.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::paint):
15:28 Changeset [44745] by weinig@apple.com

2009-06-16 Sam Weinig <sam@webkit.org>

Fix windows build.

  • jit/JIT.cpp: (JSC::JIT::JIT):
15:28 Changeset [44744] by jianli@chromium.org

2009-06-16 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 26456: Hook up V8 bindings for Worker's importScripts functionality.
https://bugs.webkit.org/show_bug.cgi?id=26456

  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WorkerCustom.cpp: Fixed missing exception code handling in Worker constructor for V8 bindings. (WebCore::CALLBACK_FUNC_DECL):
15:20 Changeset [44743] by kmccullough@apple.com

2009-06-16 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Initialize m_bytecodeIndex to -1 in JIT, and correctly initialize
it for each type of stub using the return address to find the correct
offset.

  • jit/JIT.cpp: (JSC::JIT::JIT):
  • jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdSelfList): (JSC::JIT::compileGetByIdProtoList): (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compileCTIMachineTrampolines): (JSC::JIT::compilePatchGetArrayLength):
  • jit/JITStubCall.h: (JSC::JITStubCall::call):
15:19 Changeset [44742] by cmarrin@apple.com

Added spec directories from http://dev.w3.org/cvsweb/csswg/
which is where they will live. We will edit them here and
then push them to the W3C cvs server.

15:09 Changeset [44741] by cmarrin@apple.com

Removed all the specs because they are stale


index.html: Redirected to point at w3c site

14:55 Changeset [44740] by bfulgham@webkit.org

2009-06-16 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Maciej Stachowiak.

Update of https://bugs.webkit.org/show_bug.cgi?id=26353.
Provide an assignment operator to avoid improper reference
counts on the Cairo font objects. This brings the Windows
Cairo port in line with the GTK+ port.

14:35 Changeset [44739] by bweinstein@apple.com

2009-06-16 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.


Switch Control+Mousewheel Zooming definitions to match other browsers on Windows.
Control+Mousewheel-Down now zooms out, Control+Mousewheel-Up now zooms in.
https://bugs.webkit.org/show_bug.cgi?id=25875.
<rdar://problem/6903976>

  • WebView.cpp: (WebView::mouseWheel):
14:08 Changeset [44738] by eric.carlson@apple.com

2009-06-16 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Fix for <rdar://problem/6890126> Theme code should fetch the MediaControlElementType from
the MediaControlInputElement, rather than computing it again

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::percentLoaded): New, utility function for controller implementation.
  • html/HTMLMediaElement.h:
  • rendering/MediaControlElements.h: (WebCore::MediaControlInputElement::displayType): New, return m_displayType.
  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart): Stop using MediaPlayer object, get button state from the button itself and get movie state from HTMLMediaElement.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaMuteButton): Get state from button instead of MediaPlayer. (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto.
14:00 Changeset [44737] by jianli@chromium.org

2009-06-16 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Bug 26450: Rename values of enum RedirectOriginCheck to make them
clearer.
https://bugs.webkit.org/show_bug.cgi?id=26450

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::create): (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::willSendRequest):
  • loader/DocumentThreadableLoader.h:
  • loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::create): (WebCore::ThreadableLoader::loadResourceSynchronously):
  • loader/ThreadableLoader.h:
  • workers/Worker.cpp: (WebCore::Worker::Worker):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::loadResourceSynchronously): (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
  • loader/WorkerThreadableLoader.h: (WebCore::WorkerThreadableLoader::create):
  • workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously):
  • workers/WorkerScriptLoader.h: (WebCore::WorkerContext::importScripts):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously):
13:36 Changeset [44736] by bdakin@apple.com

2009-06-15 Beth Dakin <bdakin@apple.com>

Rubber-stamped by Geoff Garen.

Updating tests on the branch from when we backed out the text
control metrics change. This only covers the editing directory.

  • platform/mac/editing/deleting/5168598-expected.checksum:
  • platform/mac/editing/deleting/5168598-expected.png:
  • platform/mac/editing/deleting/5168598-expected.txt:
  • platform/mac/editing/deleting/delete-to-select-table-expected.checksum:
  • platform/mac/editing/deleting/delete-to-select-table-expected.png:
  • platform/mac/editing/deleting/type-delete-after-quote-expected.checksum:
  • platform/mac/editing/deleting/type-delete-after-quote-expected.png:
  • platform/mac/editing/inserting/4960120-1-expected.checksum:
  • platform/mac/editing/inserting/4960120-1-expected.png:
  • platform/mac/editing/inserting/4960120-1-expected.txt:
  • platform/mac/editing/inserting/5418891-expected.checksum:
  • platform/mac/editing/inserting/5418891-expected.png:
  • platform/mac/editing/inserting/5607069-2-expected.checksum:
  • platform/mac/editing/inserting/5607069-2-expected.png:
  • platform/mac/editing/inserting/5607069-2-expected.txt:
  • platform/mac/editing/inserting/5607069-3-expected.checksum:
  • platform/mac/editing/inserting/5607069-3-expected.png:
  • platform/mac/editing/inserting/5607069-3-expected.txt:
  • platform/mac/editing/inserting/before-after-input-element-expected.checksum:
  • platform/mac/editing/inserting/before-after-input-element-expected.png:
  • platform/mac/editing/inserting/before-after-input-element-expected.txt:
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.checksum:
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.png:
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
  • platform/mac/editing/pasteboard/4806874-expected.checksum:
  • platform/mac/editing/pasteboard/4806874-expected.png:
  • platform/mac/editing/pasteboard/4806874-expected.txt:
  • platform/mac/editing/pasteboard/5387578-expected.checksum:
  • platform/mac/editing/pasteboard/5387578-expected.png:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.checksum:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/input-field-1-expected.checksum:
  • platform/mac/editing/pasteboard/input-field-1-expected.png:
  • platform/mac/editing/pasteboard/input-field-1-expected.txt:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.checksum:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.png:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/mac/editing/selection/3690703-2-expected.checksum:
  • platform/mac/editing/selection/3690703-2-expected.png:
  • platform/mac/editing/selection/3690703-2-expected.txt:
  • platform/mac/editing/selection/3690703-expected.checksum:
  • platform/mac/editing/selection/3690703-expected.png:
  • platform/mac/editing/selection/3690703-expected.txt:
  • platform/mac/editing/selection/3690719-expected.checksum:
  • platform/mac/editing/selection/3690719-expected.png:
  • platform/mac/editing/selection/3690719-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.checksum:
  • platform/mac/editing/selection/4895428-3-expected.png:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.checksum:
  • platform/mac/editing/selection/4975120-expected.png:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/5136696-expected.checksum:
  • platform/mac/editing/selection/5136696-expected.png:
  • platform/mac/editing/selection/5136696-expected.txt:
  • platform/mac/editing/selection/5213963-expected.checksum:
  • platform/mac/editing/selection/5213963-expected.png:
  • platform/mac/editing/selection/5213963-expected.txt:
  • platform/mac/editing/selection/caret-rtl-2-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-2-expected.png:
  • platform/mac/editing/selection/drag-select-1-expected.checksum:
  • platform/mac/editing/selection/drag-select-1-expected.png:
  • platform/mac/editing/selection/drag-select-1-expected.txt:
  • platform/mac/editing/selection/drag-text-delay-expected.checksum:
  • platform/mac/editing/selection/drag-text-delay-expected.png:
  • platform/mac/editing/selection/drag-text-delay-expected.txt:
  • platform/mac/editing/selection/extend-by-word-002-expected.checksum:
  • platform/mac/editing/selection/extend-by-word-002-expected.png:
  • platform/mac/editing/selection/select-all-002-expected.checksum:
  • platform/mac/editing/selection/select-all-002-expected.png:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.checksum:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/editing/spelling/spellcheck-attribute-expected.checksum:
  • platform/mac/editing/spelling/spellcheck-attribute-expected.png:
  • platform/mac/editing/spelling/spellcheck-attribute-expected.txt:
13:31 Changeset [44735] by dglazkov@chromium.org

2009-06-16 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

Fix a UMR in WebCore::BitStack by initializing new memory to 0.
https://bugs.webkit.org/show_bug.cgi?id=26449
No new tests, covered by purify.

  • editing/TextIterator.cpp: (WebCore::BitStack::push):
13:27 Changeset [44734] by bfulgham@webkit.org

009-06-16 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Xan Lopez.

Fixes https://bugs.webkit.org/show_bug.cgi?id=26453.
Null Cairo contextwill crash Windows Cairo build.

Test: fast/multicol/columns-shorthand-parsing.html

12:27 Changeset [44733] by pkasting@chromium.org

2009-06-16 Peter Kasting <pkasting@google.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=26447
Fix animated GIF breakage in Cairo/wx ports.

  • platform/image-decoders/cairo/ImageDecoderCairo.cpp: (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::operator=):
  • platform/image-decoders/wx/ImageDecoderWx.cpp: (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::operator=):
12:26 Changeset [44732] by simon.fraser@apple.com

2009-06-16 Simon Fraser <simon.fraser@apple.com>

Rubber-stamped by Anders Carlsson.

Update WebKitSystemInterface for <rdar://problem/6937882>.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
11:51 Changeset [44731] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

Disable another new test.

  • platform/gtk/Skipped:
11:36 Changeset [44730] by simon.fraser@apple.com

2009-06-16 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by John Sullivan

<rdar://problem/6937882>

Tweak "time remaining" and "time elapsed" fields in the overlay video controller.

  • css/mediaControlsQT.css:
11:36 Changeset [44729] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not use g_assert_cmpint to test for NULL pointer, just
g_assert.

  • tests/testnetworkrequest.c: (test_network_request_create_destroy):
11:27 Changeset [44728] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

editing/deleting/4875189.html was changed from pixel to
dumpAsText, so remove it from Skipped list.

  • platform/gtk/Skipped:
11:19 Changeset [44727] by abarth@webkit.org

2009-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26437

Make the commit-log-editor match the ambient line endings in commit
messages.

  • Scripts/commit-log-editor:
11:12 Changeset [44726] by jianli@chromium.org

WebCore:

2009-06-16 Jian Li <jianli@chromium.org>

Reviewed by Adam Barth and David Levin.

Bug 26146: Change to use ThreadableLoader to load the worker script
in order to check URL origin for redirection.
https://bugs.webkit.org/show_bug.cgi?id=26146

Test: http/tests/workers/worker-redirect.html

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • workers/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::notifyFinished):
  • workers/Worker.h:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • workers/WorkerImportScriptsClient.cpp: Removed.
  • workers/WorkerImportScriptsClient.h: Removed.
  • workers/WorkerScriptLoader.cpp: Renamed from workers/WorkerImportScriptsClient.cpp. This to make it more generic so worker script loading could use it. (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously): (WebCore::WorkerScriptLoader::didFinishLoading): (WebCore::WorkerScriptLoader::didFail): (WebCore::WorkerScriptLoader::didFailRedirectCheck): (WebCore::WorkerScriptLoader::didReceiveAuthenticationCancellation): (WebCore::WorkerScriptLoader::notifyFinished):
  • workers/WorkerScriptLoader.h: Renamed from workers/WorkerImportScriptsClient.h. This to make it more generic so worker script loading could use it.
  • workers/WorkerScriptLoaderClient.h: Added.

LayoutTests:

2009-06-16 Jian Li <jianli@chromium.org>

Reviewed by Adam Barth and David Levin.

Bug 26146: Change to use ThreadableLoader to load the worker script
in order to check URL origin for redirection.
https://bugs.webkit.org/show_bug.cgi?id=26146

Add a layout test to cover the scenario that the worker script is
loaded from different redirect origin.

  • http/tests/workers/resources/worker-redirect-target.js: Added.
  • http/tests/workers/worker-redirect-expected.txt: Added.
  • http/tests/workers/worker-redirect.html: Added.
10:59 Changeset [44725] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

Fix typo in test name.

  • platform/gtk/Skipped:
10:48 Changeset [44724] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

Disable new tests.

  • platform/gtk/Skipped:
10:10 BuildingOnWindows edited by bfulgham@gmail.com
(diff)
10:10 BuildingOnWindows edited by bfulgham@gmail.com
(diff)
09:59 BuildingOnWindows edited by aroben@apple.com
Add instructions for rebasing libphp4 on Vista (diff)
09:44 Changeset [44723] by bfulgham@webkit.org

009-06-16 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Darin Adler.

Use consistent GUID comparison functions.
https://bugs.webkit.org/show_bug.cgi?id=26427

07:09 Changeset [44722] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix compiler warning.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_class_init):
07:09 Changeset [44721] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Remove dummy AtkStreamableContent implementation.

It's completely empty, we'll add it back (and conditionally
instead of unconditionally) when it does something.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (GetAtkInterfaceTypeFromWAIType): (getInterfaceMaskFromObject):
06:32 Changeset [44720] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update GtkLauncher to recent API changes in the progress property,
which now goes from 0.0 to 1.0.

  • GtkLauncher/main.c:
01:40 Changeset [44719] by hausmann@webkit.org

2009-06-16 David Boddie <dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Doc: Fixed QWebPage::forwardUnsupportedContent documentation and added
more information about Web plugins.

01:40 Changeset [44718] by hausmann@webkit.org

2009-06-16 Morten Engvoldsen <morten.engvoldsen@nokia.com>

Reviewed by Ariya Hidayat.

Clearifying QWebFrame docs

Adding docs to toHtml() and toPlainText()

01:10 Changeset [44717] by abarth@webkit.org

Fix ChangeLog typo.

01:06 Changeset [44716] by abarth@webkit.org

2009-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Darin Alder.

https://bugs.webkit.org/show_bug.cgi?id=26000

Teach prepare-ChangeLog to match the line ends that are already present
in ChangeLog files. This helps folks whose use cygwin perl with CR LF
line endings on Windows.

Also, teach prepare-ChangeLog to normalize backslashes in paths. This
helps folks who use Windows SVN prepare correct ChangeLogs.

  • Scripts/prepare-ChangeLog:
00:35 Changeset [44715] by mrowe@apple.com

Roll over some ChangeLog files.

00:35 Changeset [44714] by mrowe@apple.com

Add a script to automate the rolling over of ChangeLog files when they grow too large.

Reviewed by Oliver Hunt.

  • Scripts/roll-over-ChangeLogs: Added.

06/15/09:

23:52 Changeset [44713] by barraclough@apple.com

2009-06-15 Gavin Barraclough <barraclough@apple.com>

Rubber Stamped by Sam Weinig.

Rename PatchBuffer to LinkBuffer. Previously our terminology has been a little
mixed up, but we have decided to fix on refering to the process that takes place
at the end of code generation as 'linking', and on any modifications that take
place later (and once the code has potentially already been executed) as 'patching'.

However, the term 'PatchBuffer' is already in use, and needs to be repurposed.

To try to minimize confusion, we're going to switch the terminology over in stages,
so for now we'll refer to later modifications as 'repatching'. This means that the
new 'PatchBuffer' has been introduced with the name 'RepatchBuffer' instead.

This patch renames the old 'PatchBuffer' to 'LinkBuffer'. We'll leave ToT in this
state for a week or so to try to avoid to much overlap of the meaning of the term
'PatchBuffer', then will come back and rename 'RepatchBuffer'.

  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::LinkBuffer::LinkBuffer): (JSC::AbstractMacroAssembler::LinkBuffer::~LinkBuffer):
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::compile):
23:17 Changeset [44712] by adele@apple.com

WebCore:

2009-06-15 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): When inserting a newline after the blockquote, we don't want to apply the original style after the insertion.

LayoutTests:

2009-06-15 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Updating test for:
<rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros

This test case covered inserting a newline after a blockquote, but outside of the blockquote. I added some
text insertion to verify that the newline doesn't get any old styles copied from the blockquote.

  • editing/pasteboard/5368833.html:
  • platform/mac/editing/pasteboard/5368833-expected.checksum:
  • platform/mac/editing/pasteboard/5368833-expected.png:
  • platform/mac/editing/pasteboard/5368833-expected.txt:
22:35 Changeset [44711] by barraclough@apple.com

2009-06-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Having moved most of their functionality into the RepatchBuffer class,
we can simplify the CodeLocation* classes.

The CodeLocation* classes are currently a tangle of templatey and friendly
badness, burried in the middle of AbstractMacroAssembler. Having moved
the ability to repatch out into RepatchBufer they are now do-nothing wrappers
on CodePtr (MacroAssemblerCodePtr), that only exist to provide type-safety.

Simplify the code, and move them off into their own header.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::PatchBuffer::patch):
  • assembler/CodeLocation.h: Copied from assembler/AbstractMacroAssembler.h. (JSC::CodeLocationCommon::CodeLocationCommon): (JSC::CodeLocationInstruction::CodeLocationInstruction): (JSC::CodeLocationLabel::CodeLocationLabel): (JSC::CodeLocationJump::CodeLocationJump): (JSC::CodeLocationCall::CodeLocationCall): (JSC::CodeLocationNearCall::CodeLocationNearCall): (JSC::CodeLocationDataLabel32::CodeLocationDataLabel32): (JSC::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr): (JSC::CodeLocationCommon::instructionAtOffset): (JSC::CodeLocationCommon::labelAtOffset): (JSC::CodeLocationCommon::jumpAtOffset): (JSC::CodeLocationCommon::callAtOffset): (JSC::CodeLocationCommon::nearCallAtOffset): (JSC::CodeLocationCommon::dataLabelPtrAtOffset): (JSC::CodeLocationCommon::dataLabel32AtOffset):
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::operator!):
  • bytecode/CodeBlock.h: (JSC::getStructureStubInfoReturnLocation): (JSC::getCallLinkInfoReturnLocation): (JSC::getMethodCallLinkInfoReturnLocation):
  • bytecode/Instruction.h:
  • bytecode/JumpTable.h: (JSC::StringJumpTable::ctiForValue): (JSC::SimpleJumpTable::ctiForValue):
  • bytecode/StructureStubInfo.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitCatch):
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION): (JSC::JITStubs::getPolymorphicAccessStructureListSlot):
22:03 Changeset [44710] by weinig@apple.com

2009-06-15 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove outdated comment.

  • bindings/js/JSDOMWindowBase.h:
21:58 Changeset [44709] by weinig@apple.com

2009-06-15 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Bring CustomGetPropertyNames more inline with the other
extended attributes prefixed with Custom, by making it
require a complete implementation.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getPropertyNames):
  • bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::getPropertyNames):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::getPropertyNames):
  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::getPropertyNames):
  • bindings/scripts/CodeGeneratorJS.pm:
21:04 Changeset [44708] by weinig@apple.com

2009-06-15 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove commented out ondataunavailable attribute event listener which
has now been removed from HTML 5.

  • page/DOMWindow.idl:
21:02 Changeset [44707] by weinig@apple.com

2009-06-15 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Move entire custom implementation of getOwnPropertySlot and put
for JSDOMWindow into JSDOMWindowCustom, eliminating the bit in
JSDOMWindowBase.

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter): (WebCore::childFrameGetter): (WebCore::indexGetter): (WebCore::namedItemGetter): (WebCore::JSDOMWindow::getOwnPropertySlot): (WebCore::JSDOMWindow::put): (WebCore::JSDOMWindow::getPropertyAttributes):
  • bindings/js/JSDOMWindowCustom.h:
  • page/DOMWindow.idl:
21:00 Changeset [44706] by dglazkov@chromium.org

2009-06-15 Jeremy Orlow (jorlow@chromium.org)

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26356
Define the functions in V8CustomBindings.h. "Forgot" this in my
earlier patch since it wasn't fully upstreamed when I wrote the
patch.

  • bindings/v8/custom/V8CustomBinding.h:
20:01 Changeset [44705] by barraclough@apple.com

2009-06-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Having introduced the RepatchBuffer, ProcessorReturnAddress is now a do-nothing
wrapper around ReturnAddressPtr. Remove it. In tugging on this piece of string
it made sense to roll out the use of ReturnAddressPtr a little further into
JITStubs (which had always been the intention).

No performance impact.

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToFunction): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkNearCallerToTrampoline):
  • assembler/MacroAssemblerCodeRef.h: (JSC::ReturnAddressPtr::ReturnAddressPtr):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::getStubInfo): (JSC::CodeBlock::getCallLinkInfo): (JSC::CodeBlock::getMethodCallLinkInfo): (JSC::CodeBlock::getBytecodeIndex):
  • interpreter/Interpreter.cpp: (JSC::bytecodeOffsetForPC):
  • jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress):
  • jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compilePatchGetArrayLength):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::StackHack::StackHack): (JSC::returnToThrowTrampoline): (JSC::throwStackOverflowError): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h: (JSC::): (JSC::JITStackFrame::returnAddressSlot):
  • runtime/JSGlobalData.h:
19:13 Changeset [44704] by eric@webkit.org

2009-06-15 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by Adam Treat.

Support the back/forward/stop/refresh multimedia keys and accept the
event when handling backspace and shift backspace as we should.

  • Api/qwebpage.cpp: (QWebPagePrivate::keyPressEvent):
18:36 Changeset [44703] by mitz@apple.com

2009-06-15 Andre Boule <aboule@apple.com>

Reviewed by Cameron Zwarich and Dan Bernstein.

  • fix <rdar://problem/6967975> crash with NSString drawAtPoint

No test possible because this crash can only occur if the client uses
WebKit text drawing without ever using WebCore text, and DumpRenderTree
cannot do either.

  • platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): Null-check

gFontPlatformDataCache.

18:27 Changeset [44702] by simon.fraser@apple.com

2009-06-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

<rdar://problem/6974857>

Define ENABLE_3D_RENDERING and WTF_USE_ACCELERATED_COMPOSITING when building on 10.6.
Move the ENABLE_3D_RENDERING switch from config.h and WebKitPrefix.h to wtf/Platform.h

18:12 Changeset [44701] by eric@webkit.org

2009-06-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Make WebInspector's console evaluation/completion asynchronous.
This way of evaluation allows serializing calls between
InspectorController and its frontend.

https://bugs.webkit.org/show_bug.cgi?id=26350

  • inspector/front-end/Console.js: (WebInspector.Console.prototype.completions): (WebInspector.Console.prototype._reportCompletions): (WebInspector.Console.prototype._evalInInspectedWindow): (WebInspector.Console.prototype._enterKeyPressed.printResult): (WebInspector.Console.prototype._enterKeyPressed):
  • inspector/front-end/DatabaseQueryView.js:
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.evaluateExpression):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): (WebInspector.TextPrompt.prototype._completionsReady):
17:26 Changeset [44700] by barraclough@apple.com

2009-06-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Move repatching methods into a set of methods on a class. This will allow us to
coallesce memory reprotection calls. Really, we want this class to be called
PatchBuffer, we want the class PatchBuffer to be called LinkBuffer, we want both
to be memblers of MacroAssembler rather then AbstractMacroAssembler, we don't
want the CodeLocationFoo types anymore (they are now only really there to provide
type safety, and that is completely undermined by the way we use offsets). Then
the link & patch buffers should delegate the actual patching calls to the
architecture-specific layer of the MacroAssembler. Landing all these changes as a
sequence of patches.

No performance impact.

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall): (JSC::AbstractMacroAssembler::CodeLocationNearCall::CodeLocationNearCall): (JSC::AbstractMacroAssembler::CodeLocationNearCall::calleeReturnAddressValue): (JSC::AbstractMacroAssembler::RepatchBuffer::RepatchBuffer): (JSC::AbstractMacroAssembler::RepatchBuffer::relink): (JSC::AbstractMacroAssembler::RepatchBuffer::repatch): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToFunction): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkNearCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::repatchLoadPtrToLEA):
  • jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress): (JSC::JIT::unlinkCall): (JSC::JIT::linkCall):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchMethodCallProto): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
16:19 Web Inspector edited by timothy@apple.com
(diff)
16:19 Web Inspector edited by timothy@apple.com
(diff)
16:16 Changeset [44699] by andersca@apple.com

2009-06-15 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6967569>
CrashTracer: 15 crashes in Safari at com.apple.WebKit • WebKit::NetscapePluginHostManager::didCreateWindow + 85


Make sure to remove the entry from the plug-in host map so we won't end up with an entry that has a null value.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPackage):
16:10 Changeset [44698] by kmccullough@apple.com

2009-06-15 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

Reverted previous change as the old behavior was correct for heavy view.

  • inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
15:39 Changeset [44697] by kmccullough@apple.com

2009-06-15 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/6968125> Profiler 'Call' count is incorrect in Heavy
view (26418)

  • Removed code that copied call and time data from it's ancestor.
  • inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
15:21 Changeset [44696] by cmarrin@apple.com

Reviewed by Simon Fraser <simon.fraser@apple.com>.

https://bugs.webkit.org/show_bug.cgi?id=26163

Added logic to updateTransitions similar to that in updateKeyframeAnimations
which detects and removes stale transitions.

Test: transitions/cancel-transition.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::ImplicitAnimation):
  • page/animation/ImplicitAnimation.h: (WebCore::ImplicitAnimation::active): (WebCore::ImplicitAnimation::setActive):
14:18 Changeset [44695] by mitz@apple.com

WebCore:

Reviewed by Tim Hatcher.

  • allow the source code font in the Web Inspector to be customized
  • css/view-source.css: Use the default monospace font family and size

for source code.

  • inspector/front-end/inspector.css: Use the default monospace font

family and size for console I/O.

WebKit/mac:

Reviewed by Tim Hatcher.

  • make the source code font in the Web Inspector match Mac defaults
  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Set the default monospace font to 11px Menlo, except on Leopard and Tiger where it is 10px Monaco.

WebKit/win:

Reviewed by Tim Hatcher.

  • use a nice source code font in the Web Inspector
  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::createPage): Set the default monospace font to

13px Courier New, which is the default source code font in Visual
Studio.

LayoutTests:

Reviewed by Tim Hatcher.

  • updated results after changing source view to use the default monospace font family and size
  • platform/mac/fast/frames/viewsource-attribute-expected.checksum:
  • platform/mac/fast/frames/viewsource-attribute-expected.png:
  • platform/mac/fast/frames/viewsource-attribute-expected.txt:
13:25 Changeset [44694] by xan@webkit.org

2009-06-15 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=26377
[GTK] Confusion about range of 'progress' property

Range for the progress property is 0.0 .. 1.0, don't multiply it
by 100 to make it a percentage.

  • webkit/webkitwebview.cpp: (webkit_web_view_get_progress):
13:17 Changeset [44693] by barraclough@apple.com

2009-06-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Hunt & Oliver Garen.

We are currently generating two copies of the slow path for op_call for no reason. Stop that.

Originally op_call used two slow paths since the first set up the pointer to the CallLinkInfo
for use when linking. However this is now looked up using the return address (as we do for
property accesses) so the two paths are now identical.

No performance impact, reduces memory footprint.

  • bytecode/CodeBlock.h:
  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::linkCall):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase):
  • jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION):
11:39 Changeset [44692] by treat@webkit.org

2009-06-15 Andre Pedralho <andre.pedralho@openbossa.org>

Reviewed by Adam Treat

https://bugs.webkit.org/show_bug.cgi?id=26351
Remove bool QWebHitTestResult::isScrollBar() const and make sure a null QWebHitTestResult is returned instead.

11:39 Changeset [44691] by andersca@apple.com

2009-06-15 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Add Core Animation movie plug-in example.


  • NetscapeCoreAnimationMoviePlugin: Added.
  • NetscapeCoreAnimationMoviePlugin/English.lproj: Added.
  • NetscapeCoreAnimationMoviePlugin/English.lproj/InfoPlist.strings: Added.
  • NetscapeCoreAnimationMoviePlugin/Info.plist: Added.
  • NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.h: Added.
  • NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.m: Added. (createImageNamed): (-[MovieControllerLayer init]): (-[MovieControllerLayer dealloc]): (-[MovieControllerLayer _playPauseButtonRect]): (-[MovieControllerLayer _sliderRect]): (-[MovieControllerLayer _sliderThumbRect]): (-[MovieControllerLayer _innerSliderRect]): (-[MovieControllerLayer _drawPlayPauseButtonInContext:]): (-[MovieControllerLayer _drawSliderInContext:]): (-[MovieControllerLayer drawInContext:]): (-[MovieControllerLayer _currentTime]): (-[MovieControllerLayer _duration]): (-[MovieControllerLayer _isPlaying]): (-[MovieControllerLayer _updateTime:]): (-[MovieControllerLayer _rateDidChange:]): (-[MovieControllerLayer _timeDidChange:]): (-[MovieControllerLayer actionForKey:]): (-[MovieControllerLayer setMovie:]): (-[MovieControllerLayer _setNewTimeForThumbCenterX:]): (-[MovieControllerLayer handleMouseDown:]): (-[MovieControllerLayer handleMouseUp:]): (-[MovieControllerLayer handleMouseDragged:]):
  • NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Added.
  • NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj: Added.
  • NetscapeCoreAnimationMoviePlugin/Pause.tiff: Added.
  • NetscapeCoreAnimationMoviePlugin/Play.tiff: Added.
  • NetscapeCoreAnimationMoviePlugin/SliderTrackCenter.tiff: Added.
  • NetscapeCoreAnimationMoviePlugin/SliderTrackLeft.tiff: Added.
  • NetscapeCoreAnimationMoviePlugin/SliderTrackRight.tiff: Added.
  • NetscapeCoreAnimationMoviePlugin/Thumb.tiff: Added.
  • NetscapeCoreAnimationMoviePlugin/main.m: Added. (NP_Initialize): (NP_GetEntryPoints): (NP_Shutdown): (NPP_New): (NPP_Destroy): (NPP_SetWindow): (NPP_NewStream): (NPP_DestroyStream): (NPP_WriteReady): (NPP_Write): (NPP_StreamAsFile): (NPP_Print): (handleMouseDown): (togglePlayPause): (handleMouseUp): (handleMouseDragged): (handleMouseEntered): (handleMouseExited): (handleKeyDown): (handleScrollEvent): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue): (NPP_SetValue):
  • NetscapeCoreAnimationMoviePlugin/test.html: Added.
11:14 Changeset [44690] by kov@webkit.org

Tagging 1.1.10.

08:40 Changeset [44689] by kov@webkit.org

2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Add new symbols list for 1.1.10 release.

  • docs/webkitgtk-docs.sgml:
08:39 Changeset [44688] by kov@webkit.org

2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Fix Since tags for the new uri and message properties.

  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_class_init):
08:38 Changeset [44687] by hausmann@webkit.org

2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by and done with Tor Arne Vestbø.

Fix initialization of uninitialized members in FontFallbackListQt, leading
to random crashes when rendering text.

08:30 Changeset [44686] by kov@webkit.org

2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Adding new documented API to the generated
documentation.

  • docs/webkitgtk-sections.txt:
07:38 Changeset [44685] by hausmann@webkit.org

2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Adam Treat.

Fix the logic for disabling the fixed layout feature, when an invalid
QSize is set.

07:31 Changeset [44684] by xan@webkit.org

2009-06-15 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Version bump in preparation for 1.1.10 release.

  • configure.ac:

WebKit/gtk:

2009-06-15 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update NEWS for 1.1.10 release.

  • NEWS:
07:17 Changeset [44683] by xan@webkit.org

2009-06-15 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25895
[Gtk] Segfault when deleting the last/only character in an entry if a11y is enabled

Use computeOffsetInContainerNode instead of the inline
offsetInContainerNode to return the caret offset, since the former
can handle all types of anchoring. Otherwise we'll hit an ASSERT
in some situations in debug builds, and crash.

  • editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
04:53 Changeset [44682] by hausmann@webkit.org

2009-06-15 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix build break
Rename JSONObject to InspectorJSONObject

https://bugs.webkit.org/show_bug.cgi?id=26340

01:39 Changeset [44681] by vestbo@webkit.org

2009-06-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Mark Rowe.
Reviewed by Simon Hausmann.
Reviewed by Xan Lopez.

Refactor handling of options in the build-webkit script

Options are now defined in one place, and then reused when creating
the usage help text, the arguments to GetOptions(), and when passing
the options on to the underlying port-dependent build systems.

This allows the Qt port to read the defaults for the options from the
pro file (dynamically), and to pass the options on to qmake at build.

00:37 Changeset [44680] by mrowe@apple.com

Fix <https://bugs.webkit.org/show_bug.cgi?id=26312>.
Bug 26312: Multiple copies of Safari opened with WebKit nightly and Safari 3.2.3

Reviewed by Cameron Zwarich.

Skip the trampoline detection for versions of Safari < 4.0 as they don't play these
tricks, and having WebKitNightlyEnabler assume that we were in the trampoline was
preventing our LaunchServices trickery from being run. This led to fresh copies of
WebKit.app being launched when a URL or file was opened from an external application
rather than the existing instance being reused.

  • WebKitLauncher/WebKitNightlyEnabler.m:

(insideSafari4OnTigerTrampoline):
(enableWebKitNightlyBehaviour):

00:02 Changeset [44679] by vestbo@webkit.org

Fix Qt build break after r44672

06/14/09:

23:11 Changeset [44678] by cfleizach@apple.com

Bug 26399: REGRESSION: java applet accessibility broken
https://bugs.webkit.org/show_bug.cgi?id=26399

21:46 Changeset [44677] by weinig@apple.com

2009-06-14 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Rename the CustomGetOwnPropertySlot and CustomPutFunction extended attributes
to DelegatingGetOwnPropertySlot and DelegatingPutFunction to more clearly describe
their functionality (customGetOwnPropertySlot and customPut member functions have
been renamed getOwnPropertySlotDelegate and putDelegate). CustomGetOwnPropertySlot
and CustomPutFunction have been repurposed to mean a complete custom implementation
of the function which is inline with other extended attributes prefixed with Custom.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::putDelegate):
  • bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::getOwnPropertySlotDelegate): (WebCore::JSDOMWindow::putDelegate):
  • bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate): (WebCore::JSHTMLAppletElement::putDelegate):
  • bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate): (WebCore::JSHTMLEmbedElement::putDelegate):
  • bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate): (WebCore::JSHTMLObjectElement::putDelegate):
  • bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::getOwnPropertySlotDelegate): (WebCore::JSHistory::putDelegate):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::getOwnPropertySlotDelegate): (WebCore::JSLocation::putDelegate): (WebCore::JSLocationPrototype::putDelegate):
  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::putDelegate):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::getOwnPropertySlotDelegate):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSStyleDeclaration.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLObjectElement.idl:
  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Location.idl:
  • storage/Storage.idl:
  • workers/WorkerContext.idl:
21:36 Changeset [44676] by mitz@apple.com

Reviewed by Darin Adler.

No test, since the back/forward cache is disabled in DumpRenderTree

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::open): Added a call to CachedPage::restore(), which was removed in r40870.
20:07 Changeset [44675] by darin@apple.com

2009-06-14 Darin Adler <darin@apple.com>

  • editing/TextIterator.cpp: (WebCore::BitStack::push): Use named constant instead of hardcoded numbers. (WebCore::BitStack::top): Ditto.
19:39 Changeset [44674] by darin@apple.com

WebCore:

2009-06-14 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 26364: Search can find text that's hidden by overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=26364
<rdar://problem/6952081>

Test: fast/text/find-hidden-text.html

  • editing/TextIterator.cpp: (WebCore::BitStack::BitStack): Added. (WebCore::BitStack::push): Added. (WebCore::BitStack::pop): Added. (WebCore::BitStack::top): Added. (WebCore::BitStack::size): Added. (WebCore::parentOrShadowParent): Added. Helper function for walking up the parent node chain, crossing shadow tree boundaries. (WebCore::depthCrossingShadowBoundaries): Added for use in assertions. Counts the depth of a node using the parentOrShadowParent function. (WebCore::fullyClipsContents): Added. Returns true for an element that fully clips its contents, currently defined as a box that has zero width or height and hides overflow. We can add other cases here later. (WebCore::ignoresContainerClip): Added. Returns true for an element that ignores its container clip, currently defined as an element with absolute or fixed positioning. (WebCore::pushFullyClippedState): Added. Pushes a bit on the stack indicating if the node in question fully clips its contents. (WebCore::setUpFullyClippedStack): Added. Pushes a bit for each ancestor of a node. Used when creating an iterator. (WebCore::TextIterator::TextIterator): Removed code to initialize m_inShadowContent. Call setUpFullyClippedStack. (WebCore::TextIterator::advance): Use parentOrShadowParent. Call pop when moving up to a parent node, and also one extra time when moving to a sibling node. Call pushFullyClippedState when moving to a child node, or when moving to a sibling node after the aforementioned call to pop. (WebCore::TextIterator::handleTextNode): Return early if the node is fully clipped. (WebCore::TextIterator::handleReplacedElement): Ditto. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Call setUpFullyClippedStack. (WebCore::SimplifiedBackwardsTextIterator::advance): Same changes as TextIterator::advance above.
  • editing/TextIterator.h: Added BitStack class and added m_fullyClippedStack to both TextIterator and SimplifiedBackwardsTextIterator. Removed unneeded m_inShadowContent.

LayoutTests:

2009-06-14 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 26364: Search can find text that's hidden by overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=26364
<rdar://problem/6952081>

  • fast/text/find-hidden-text-expected.txt: Added.
  • fast/text/find-hidden-text.html: Added.
  • fast/block/float/crash-replaced-display-block-expected.txt: Removed a space.
  • fast/dom/Range/acid3-surround-contents-expected.txt: Removed a blank line.
  • fast/dom/object-embed-plugin-scripting-expected.txt: Removed four spaces.
  • fast/parser/badentity-expected.txt: Removed a blank line.
  • http/tests/security/local-video-poster-from-remote-expected.txt: Removed a blank line.
16:52 Changeset [44673] by hyatt@apple.com

2009-06-14 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26362

Back out Simon's fix and replace it with a better one that doesn't needlessly destroy RenderObjects.
Use NoInherit rather than Detach for child index changes, and don't worry about other pseudo-class state
changes, since they were handled already with setNeedsStyleRecalcs on the affected objects themselves.

  • dom/Element.cpp: (WebCore::Element::recalcStyle):
  • dom/Node.cpp: (WebCore::Node::diff):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setChildIndex):
14:57 Changeset [44672] by hyatt@apple.com

2009-06-14 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

Move all of the mutable member variables from Font into the refcounted FontFallbackList. This makes
copying of Fonts more efficient and also effectively makes all of the mutations of a Font object happen
inside the FontFallbackList.

  • WebCore.base.exp:
  • platform/graphics/Font.cpp: (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::primaryFont): (WebCore::Font::update):
  • platform/graphics/Font.h: (WebCore::Font::setWordSpacing): (WebCore::Font::setLetterSpacing):
  • platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::determinePitch):
  • platform/graphics/FontFallbackList.h: (WebCore::FontFallbackList::primarySimpleFontData): (WebCore::FontFallbackList::primaryFontData):
  • platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter):
14:27 Changeset [44671] by simon.fraser@apple.com

2009-06-14 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=26362

Fix an issue noted on quirksmode.com where dynamically adding siblings does not
update :nth-child style correctly.

Test: fast/css/nth-child-dynamic.html

  • dom/Node.h: Change diff() to take const RenderStyle*
  • dom/Node.cpp: (WebCore::Node::diff): When comparing styles to decide whether to detach and reattach, we need to look at whether the pseudoclass-related data in the style changed (since RenderStyle::diff doesn't check this).
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getCachedPseudoStyle): (WebCore::RenderStyle::inheritedNotEqual): Make these methods const.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::styleType): (WebCore::InheritedFlags::pseudoClassStateEquivalent): Make methods const. Add new method that compares the pseudoclass-related members.
00:03 Changeset [44670] by sfalken@apple.com

Update V8 benchmark to version 4.


Reviewed by Cameron Zwarich.

  • tests/LIST-V8:
  • tests/v8-crypto.js:
  • tests/v8-deltablue.js:
  • tests/v8-earley-boyer.js:
  • tests/v8-raytrace.js:
  • tests/v8-regexp.js: Added.
  • tests/v8-richards.js:
  • tests/v8-splay.js: Added.

06/13/09:

23:44 Changeset [44669] by pkasting@chromium.org

2009-06-13 Peter Kasting <pkasting@google.com>

Reviewed by Kevin Ollivier.

https://bugs.webkit.org/show_bug.cgi?id=25709 part eleven
Write a wx implementation so the wx port can compile. For now this is
mostly a copy of the Cairo port, but in the future it can be changed to
use a wxBitmap as the storage type everywhere (just as Cairo can
probably be changed).


Also ASSERT for any other ports who call getAddr() (I don't think there
are any, and besides, they probably won't link, but this doesn't hurt).


Also fixes a dumb Cairo build bustage typo introduced in part ten.

  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::createFrameAtIndex):
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/cairo/ImageDecoderCairo.cpp: (WebCore::RGBA32Buffer::setStatus):
  • platform/image-decoders/wx: Added.
  • platform/image-decoders/wx/ImageDecoderWx.cpp: Added. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height):
  • webcore-wx.bkl:
22:06 Changeset [44668] by abarth@webkit.org

2009-06-09 Justin Garcia <justin.garcia@apple.com>

Reviewed by Eric Seidel. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26281

REGRESSION: Copying from TextEdit/OmniGraffle and pasting into editable
region loses images


Prefer RTFD (RTF with inline images) over RTF. In
http://trac.webkit.org/changeset/19745 I accidently reversed their
order.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
21:53 Changeset [44667] by abarth@webkit.org

2009-06-13 Stephen White <senorblanco@chromium.org>

Reviewed by Dimitri Glazkov. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26320

Some minor code cleanup for chromium/skia port. Removed #ifdef's
around skia API changes, since the new version seems solid and we
don't need to go back. Added some comments to
TransparencyWin.h, as requested by Brett in
https://bugs.webkit.org/show_bug.cgi?id=24584.

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/chromium/TransparencyWin.h:
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::boundingRect): (WebCore::boundingBoxForCurrentStroke):
  • platform/graphics/skia/SkiaUtils.cpp: (WebCore::SkPathContainsPoint):
21:29 Changeset [44666] by abarth@webkit.org

Build fix: Another missing header. Arg.

21:24 Changeset [44665] by abarth@webkit.org

Build fix: add missing header.

21:14 Changeset [44664] by abarth@webkit.org

WebCore:

2009-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24492

Moved registerURLSchemeAsLocal and registerURLSchemeAsNoAccess from
FrameLoader to SecurityOrigin.

  • WebCore.base.exp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest): (WebCore::FrameLoader::canLoad):
  • loader/FrameLoader.h:
  • page/SecurityOrigin.cpp: (WebCore::localSchemes): (WebCore::noAccessSchemes): (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::isLocal): (WebCore::SecurityOrigin::registerURLSchemeAsLocal): (WebCore::SecurityOrigin::shouldTreatURLAsLocal): (WebCore::SecurityOrigin::shouldTreatURLSchemeAsLocal): (WebCore::SecurityOrigin::registerURLSchemeAsNoAccess): (WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
  • page/SecurityOrigin.h:

WebKit/mac:

2009-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24492

Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin

  • WebView/WebView.mm: (+[WebView registerURLSchemeAsLocal:]):

WebKit/qt:

2009-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24492

Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.

  • Api/qwebpage.cpp: (QWebPage::acceptNavigationRequest):

WebKit/win:

2009-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24492

Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.

  • WebView.cpp: (WebView::registerURLSchemeAsLocal):
20:47 Changeset [44663] by abarth@webkit.org

2009-06-13 Ben Murdoch <benm@google.com>

Reviewed by David Kilzer. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26189

This patch changes the way PageGroups create their localStorage
objects. Rather than creating a local storage object for the page group
when a page is added to the group, the local storage object is now
created lazily when the local storage object is requested by the
DOMWindow.

  • page/PageGroup.cpp: (WebCore::PageGroup::closeLocalStorage): Before attempting to close a local storage object for a page group, ensure one has been created. (WebCore::PageGroup::addPage): Do not automatically try to create a local storage object when a page is added to the group. (WebCore::PageGroup::localStorage): Create a local storage object if one does not exist and return it.
  • page/PageGroup.h: Add private hasLocalStorage method to PageGroup.
20:44 Changeset [44662] by abarth@webkit.org

2009-06-13 Ben Murdoch <benm@google.com>

Reviewed by Eric Seidel. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26189

Add ENABLE(DOM_STORAGE) guards to the dom storage source files.

  • storage/LocalStorage.cpp: Add ENABLE(DOM_STORAGE) guards to the file.
  • storage/LocalStorage.h: Ditto
  • storage/LocalStorageArea.cpp: Ditto
  • storage/LocalStorageArea.h: Ditto
  • storage/LocalStorageTask.cpp: Ditto
  • storage/LocalStorageTask.h: Ditto
  • storage/LocalStorageThread.cpp: Ditto
  • storage/LocalStorageThread.h: Ditto
  • storage/SessionStorage.cpp: Ditto
  • storage/SessionStorage.h: Ditto
  • storage/SessionStorageArea.cpp: Ditto
  • storage/SessionStorageArea.h: Ditto
  • storage/Storage.cpp: Ditto
  • storage/Storage.h: Ditto
  • storage/StorageArea.cpp: Ditto
  • storage/StorageArea.h: Ditto
  • storage/StorageEvent.cpp: Ditto
  • storage/StorageEvent.h: Ditto
  • storage/StorageMap.cpp: Ditto
  • storage/StorageMap.h: Ditto
  • storage/StorageEvent.idl: Add Conditional=DOM_STORAGE attribute.
  • storage/Storage.idl: Ditto
18:00 Changeset [44661] by pkasting@chromium.org

2009-06-13 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part ten
Make Skia use the root directory ImageDecoder.h and factor out most
Skia-specific bits into skia/ImageDecoderSkia.cpp. Also fix a pair of
style violations in ImageDecoderCairo.cpp. This is the last patch for
this bug, everything beyond this is an enhancement rather than
unforking.

  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/cairo/ImageDecoderCairo.cpp: (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::setStatus):
  • platform/image-decoders/skia/ImageDecoder.h: Removed.
  • platform/image-decoders/skia/ImageDecoderSkia.cpp: Added. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height):
16:11 Changeset [44660] by weinig@apple.com

2009-06-13 Sam Weinig <sam@webkit.org>

Rubber-stamped by Mark "Snowy" Rowe.

Update iExploder/htdocs/cssproperties.in by running update-iexploder-cssproperties.

  • iExploder/htdocs/cssproperties.in:
14:35 Changeset [44659] by abarth@webkit.org

2009-06-13 Victor Wang <victorw@chromium.org>

Reviewed by Eric Seidel. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26333
Alert during a dragenter event handler will crash the renderer


This crash is casued by calling NULL pointer m_documentUnderMouse in
DragController::tryDocumentDrag()

tryDHTMLDrag fires dragenter event. The event listener that listens
to this event may create a nested message loop (open a modal dialog),
which could process dragleave event and reset m_documentUnderMouse in
dragExited.

Fix the crash by checking m_documentUnderMouse after tryDHTMLDrag and
do not continue if the pointer has been set to NULL.

Test: DRT does not show alerts so add a manual test:

manual-tests/drag-enter-alert.html

  • manual-tests/drag-enter-alert.html: Added.
  • manual-tests/resources/drag-image.png: Added.
  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):
14:27 Changeset [44658] by abarth@webkit.org

2009-06-13 Nate Chapin <japhet@google.com>

Reviewed by Dimitri Glazkov. Landed by Adam Barth.

Moved V8 Bindings for V8CustomXPathNSResolver to svn.webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=26227

  • bindings/v8/custom/V8CustomXPathNSResolver.cpp: Added. (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver): Moved from src.chromium.org. (WebCore::V8CustomXPathNSResolver::~V8CustomXPathNSResolver): Moved from src.chromium.org. (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI): Moved from src.chromium.org.
  • bindings/v8/custom/V8CustomXPathNSResolver.h: Added.
  • bindings/v8/custom/V8DocumentCustom.cpp: Updated includes. (WebCore::CALLBACK_FUNC_DECL): Updated class name.
14:23 Changeset [44657] by abarth@webkit.org

2009-06-13 John Abd-El-Malek <jam@chromium.org>

Reviewed by Eric Seidel. Landed by Adam Barth.

Removed dead file.
https://bugs.webkit.org/show_bug.cgi?id=26308

  • DumpRenderTree/win/TestNetscapePlugin/main.c: Removed.
14:19 Changeset [44656] by abarth@webkit.org

2009-06-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Mark Rowe. Landed by Adam Barth.

Remove obsolete declarations for old Symbian port
https://bugs.webkit.org/show_bug.cgi?id=26339

  • platform/graphics/FloatPoint.h: Remove declarations for native SYMBIAN adaptation.
  • platform/graphics/FloatRect.h: Ditto.
  • platform/graphics/IntPoint.h: Ditto.
  • platform/graphics/IntRect.h: Ditto.
  • platform/graphics/IntSize.h: Ditto.
12:54 Changeset [44655] by krit@webkit.org

2009-06-13 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

Added subRegion calculation to SVG filter. Every filter effect is
clipped to the filter region (according to the spec). This makes
ImageBuffers for filter effects smaller and we just need to take
care about big filter regions.
SVGFEImage needed a correction, to avoid an ASSERT. The two filter
effects feOffset and feFlood help to test the new subRegion code.

Tests: svg/filters/subRegion-one-effect.svg

svg/filters/subRegion-two-effects.svg

Added tests for the new subRgion-code on SVG filters.

  • platform/mac/svg/filters: Added.
  • platform/mac/svg/filters/subRegion-one-effect-expected.checksum: Added.
  • platform/mac/svg/filters/subRegion-one-effect-expected.png: Added.
  • platform/mac/svg/filters/subRegion-one-effect-expected.txt: Added.
  • platform/mac/svg/filters/subRegion-two-effects-expected.checksum: Added.
  • platform/mac/svg/filters/subRegion-two-effects-expected.png: Added.
  • platform/mac/svg/filters/subRegion-two-effects-expected.txt: Added.
  • svg/filters: Added.
  • svg/filters/subRegion-one-effect.svg: Added.
  • svg/filters/subRegion-two-effects.svg: Added.
12:36 Changeset [44654] by pkasting@chromium.org

2009-06-13 Peter Kasting <pkasting@google.com>

Bustage: Fix broken GIFs on Cairo due to subtle typo. Fix a warning.

  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::copyRowNTimes):
  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::processBitmasks):
12:10 Changeset [44653] by pkasting@chromium.org

2009-06-13 Peter Kasting <pkasting@google.com>

GTK bustage fix. "inline" is handled differently by different compilers.

  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/cairo/ImageDecoderCairo.cpp:
11:55 Changeset [44652] by pkasting@chromium.org

2009-06-13 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part nine
Factor Cairo-specific implementation out of ImageDecoder.h into
ImageDecoderCairo.cpp. Add some comments to functions declared
in ImageDecoder.h.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/image-decoders/ImageDecoder.h:
  • platform/image-decoders/cairo: Added.
  • platform/image-decoders/cairo/ImageDecoderCairo.cpp: Added. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::getAddr):
10:52 Changeset [44651] by hyatt@apple.com

2009-06-12 Dave Hyatt <hyatt@apple.com>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=26373

Add a new class to Threading in wtf called ReadWriteLock that handles single writer/multiple reader locking.
Provide a pthreads-only implementation of the lock for now, as this class is only going to be used
on Snow Leopard at first.

  • wtf/Threading.h: (WTF::ReadWriteLock::impl):
  • wtf/ThreadingPthreads.cpp: (WTF::ReadWriteLock::ReadWriteLock): (WTF::ReadWriteLock::~ReadWriteLock): (WTF::ReadWriteLock::readLock): (WTF::ReadWriteLock::tryReadLock): (WTF::ReadWriteLock::writeLock): (WTF::ReadWriteLock::tryWriteLock): (WTF::ReadWriteLock::unlock):
10:20 Changeset [44650] by hyatt@apple.com

2009-06-13 David Hyatt <hyatt@apple.com>

Reviewed by Darin Adler.

Cleanup of the new MidpointState class. Turn it into a struct instead. Fix a mistaken
assertion removal and some unintentional whitespace changes.

  • platform/text/BidiResolver.h: (WebCore::MidpointState::reset):
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::BidiRun::operator delete): (WebCore::chopMidpointsAt): (WebCore::checkMidpoints): (WebCore::addMidpoint): (WebCore::appendRunsForObject): (WebCore::RenderBlock::findNextLineBreak):

06/12/09:

23:04 Changeset [44649] by hyatt@apple.com

2009-06-12 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=26367

Remove the global variables in bidi.cpp. Make a new struct, MidpointState, that holds all of the
midpoint information. Add the remaining global variables as arguments passed down through functions
as needed.

  • platform/text/BidiResolver.h: (WebCore::MidpointState::MidpointState): (WebCore::MidpointState::reset): (WebCore::BidiResolver::midpointState):
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::BidiRun::operator delete): (WebCore::chopMidpointsAt): (WebCore::checkMidpoints): (WebCore::addMidpoint): (WebCore::appendRunsForObject): (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::skipNonBreakingSpace): (WebCore::shouldCollapseWhiteSpace): (WebCore::requiresLineBox): (WebCore::RenderBlock::generatesLineBoxesForInlineChild): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::shouldSkipWhitespaceAfterStartObject): (WebCore::RenderBlock::findNextLineBreak):
22:03 Changeset [44648] by zecke@webkit.org

Build fix for Qt. After recent ImageDeocder.h changes.

I want the original change to be backed out as the whole
Skia merging is going in the wrong direction. The discussion
will happen in the bugtracker.

https://bugs.webkit.org/show_bug.cgi?id=25709.

21:15 WebDevelopers edited by timothy@apple.com
(diff)
19:41 Changeset [44647] by jmalonzo@webkit.org

2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[Gtk] Enable more http/tests/navigation tests

  • platform/gtk/Skipped:

[Gtk] use strlen instead of g_utf8_strlen so we can enable more tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpHistoryItem):
19:31 Changeset [44646] by jmalonzo@webkit.org

2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix: include cstdio so we can use sscanf

Gtk/Win Cairo build fix: use isASCIISpace instead of isspace
Suggested by Brent Fulgham

  • platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::decodeDatum):
18:23 Changeset [44645] by pkasting@chromium.org

2009-06-12 Peter Kasting <pkasting@google.com>

Yet another Skia bustage fix.

  • platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::setSize): Avoid symbol name clash. The better fix is to take an IntSize(); I'll do that later.
18:18 Changeset [44644] by oliver@apple.com

Make LiteralParser non-recursive

Reviewed by Geoff Garen.

Convert LiteralParser from using a simple recursive descent parser
to a hand rolled PDA. Relatively simple conversion, but required
modifications to MarkedArgumentBuffer to make it more suitable as
a generic marked vector. I'll refactor and rename MarkedArgumentBuffer
in future as there are many other cases where it will be useful to
have such a class.

17:56 Changeset [44643] by pkasting@chromium.org

2009-06-12 Peter Kasting <pkasting@google.com>

Fix remaining Cairo build bustage from
https://bugs.webkit.org/show_bug.cgi?id=25709 changes. Use
Vector<char> in place of std::string.

  • platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::setData): (WebCore::XBMImageDecoder::decodeHeader): (WebCore::XBMImageDecoder::decodeDatum):
  • platform/image-decoders/xbm/XBMImageDecoder.h:
17:47 Changeset [44642] by levin@chromium.org

2009-06-12 David Levin <levin@chromium.org>

Reviewed by NOBODY (build fix for windows).

Adjust the exports for JSC on Windows like what was done for OSX in
the previous commit.

17:41 Changeset [44641] by levin@chromium.org

JavaScriptCore:

2009-06-12 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

UString shouldn't create sharedBuffer for SmallStrings.
https://bugs.webkit.org/show_bug.cgi?id=26360

The methods changed are not used by JSC, so there is no JS perf impact. However,
there is a potential DOM perf impact, so I re-ran several of the tests that
I ran previously and ensured that the perf stay the same which caused me to
adjust the minLengthToShare.

  • JavaScriptCore.exp:
  • runtime/UString.cpp: (JSC::UString::Rep::sharedBuffer):

Determines if the buffer being shared is big enough before doing so.
Previously, BaseString::sharedBuffer was called but it would only know
the length of the base string (BaseString::len) which may not be the same
as the string being shared (Rep::len).

(JSC::UString::BaseString::sharedBuffer):

This is now only be used by Rep::sharedBuffer. which does the length check.

  • runtime/UString.h:

WebCore:

2009-06-12 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

UString shouldn't create sharedBuffer for SmallStrings.
https://bugs.webkit.org/show_bug.cgi?id=26347

Change the call to use the method UString::Rep::sharedBuffer due
to changes in UString.

No noticable change in behavior, so no test.

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::create):
17:11 Changeset [44640] by simon.fraser@apple.com

2009-06-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=26095

Fix crash when a renderer for an anonymous node is composited
by null-checking renderer()->node().

Test: compositing/generated-content.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::rendererHasBackground): (WebCore::RenderLayerBacking::rendererBackgroundColor): (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): (WebCore::RenderLayerBacking::paintIntoLayer):
17:04 Changeset [44639] by pkasting@chromium.org

2009-06-12 Peter Kasting <pkasting@google.com>

Fix Chromium and some of Cairo build bustage, fallout from
https://bugs.webkit.org/show_bug.cgi?id=25709 changes.

  • WebCore.vcproj/WebCore.vcproj: Add missing XBM decoder files.
  • platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::copyRowNTimes): Fix typo that broke Skia GIF decoding.
16:39 Changeset [44638] by beidson@apple.com

2009-06-12 Brady Eidson <beidson@apple.com>

Reviewed by Oliver Hunt

Add a page indexing the various demo applications we have posted.

  • demos/index.html: Added.
  • nav.inc: Add a link to the demos page on the side bar
  • css/main.css: Add a style for date stamps based on the blog.
  • demos/calendar/index.html: Added to redirect to Calendar.html. I'm not moving Calendar.html to index.html as the Calendar.html url has already been published and we should keep it working.

Move the drosera test code to /misc, as it is no longer a meaningful demo:

  • demos/drosera: Removed.
  • demos/drosera/demo.js: Removed.
  • demos/drosera/drosera.png: Removed.
  • demos/drosera/index.html: Removed.
  • misc/drosera: Copied from demos/drosera.

Move the sticky notes example into /demos:

  • demos/sticky-notes: Added.
  • demos/sticky-notes/StickyNotes.manifest: Copied from misc/DatabaseExample.manifest.
  • demos/sticky-notes/deleteButton.png: Copied from misc/deleteButton.png.
  • demos/sticky-notes/deleteButtonPressed.png: Copied from misc/deleteButtonPressed.png.
  • demos/sticky-notes/index.html: Copied from misc/DatabaseExample.html.
  • misc/DatabaseExample.html: Changed to redirect to demos/sticky-notes/index.html. I'm not removing it altogether as the misc/DatabaseExample.html url has already been published and we should keep it working.
  • misc/DatabaseExample.manifest: Removed.
  • misc/deleteButton.png: Removed.
  • misc/deleteButtonPressed.png: Removed.
16:38 Changeset [44637] by simon.fraser@apple.com

2009-06-12 Simon Fraser <simon.fraser@apple.com>

Fix build when ACCELERATED_COMPOSITING is defined.

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::attachRootGraphicsLayer): (WebCore::EmptyChromeClient::setNeedsOneShotDrawingSynchronization): (WebCore::EmptyChromeClient::scheduleViewUpdate): Add stubs for the compositing-related ChromeClient methods.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition): (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): docWidth()/docHeight() became private. Use overflowWidth()/overflowHeight() instead, which matches what is used to size the WebHTMLView.
16:20 Changeset [44636] by dimich@chromium.org

2009-06-12 jorlow <jorlow@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26356
http://crbug.com/14006
Create custom bindings for v8. The rest of these files are still
forked (so the review is happening on the chromium review site).
These bindings have been tested on a hacked up Chromium instance
(also running --single-process) and Android.

  • bindings/v8/custom/V8StorageCustom.cpp: Added.
16:20 Changeset [44635] by dimich@chromium.org

2009-06-12 Dmitry Titov <dimich@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26359
[v8] Add XMLHttpRequest to WorkerContextExecutionProxy.

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object): Add type == V8ClassIndex::XMLHTTPREQUEST to the convertable types. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): same.
  • bindings/v8/WorkerContextExecutionProxy.h: fix typo in the comment.
15:55 Changeset [44634] by pkasting@chromium.org

2009-06-12 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part eight
Replace placeholder Cairo BMP, ICO, XBM decoders with real ones. Remove
all the decoders from skia/ since they are now just mirrors of the Cairo
ones.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon. Enable XBM decoding on Windows.
  • platform/graphics/skia/ImageSourceSkia.cpp:
  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon.
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.cpp.
  • platform/image-decoders/bmp/BMPImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.h.
  • platform/image-decoders/bmp/BMPImageReader.cpp: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.cpp.
  • platform/image-decoders/bmp/BMPImageReader.h: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.h.
  • platform/image-decoders/ico/ICOImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.cpp.
  • platform/image-decoders/ico/ICOImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.h.
  • platform/image-decoders/skia/BMPImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/BMPImageDecoder.h: Removed.
  • platform/image-decoders/skia/BMPImageReader.cpp: Removed.
  • platform/image-decoders/skia/BMPImageReader.h: Removed.
  • platform/image-decoders/skia/GIFImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/GIFImageDecoder.h: Removed.
  • platform/image-decoders/skia/GIFImageReader.cpp: Removed.
  • platform/image-decoders/skia/GIFImageReader.h: Removed.
  • platform/image-decoders/skia/ICOImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/ICOImageDecoder.h: Removed.
  • platform/image-decoders/skia/JPEGImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/JPEGImageDecoder.h: Removed.
  • platform/image-decoders/skia/PNGImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/PNGImageDecoder.h: Removed.
  • platform/image-decoders/skia/XBMImageDecoder.cpp: Removed.
  • platform/image-decoders/skia/XBMImageDecoder.h: Removed.
  • platform/image-decoders/xbm/XBMImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.cpp.
  • platform/image-decoders/xbm/XBMImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.h.
15:41 Changeset [44633] by eric@webkit.org

2009-06-12 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26191
Remove xmath include in MathExtras.h, because it is not needed and also
breaks VS2008 builds with TR1 turned on.

  • wtf/MathExtras.h: Removed xmath include.
15:24 Changeset [44632] by kov@webkit.org

2009-06-12 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25599
[GTK] Enable more tests

Implement dumping of status callback.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewStatusBarTextChanged): (main):
15:17 Web Inspector edited by timothy@apple.com
Changes to be more current. (diff)
15:06 Changeset [44631] by pkasting@chromium.org

2009-06-11 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part seven
Update Skia's ImageDecoder.h with a few changes designed to reduce the
delta between specific implementations of ImageDecoder.h. Update
Cairo's ImageDecoder.h to sync up with the API changes in the Skia
version in the last two chage sets. Update Cairo's PNG/JPEG/GIF
decoders to use the APIs as well. All the Cairo image decoder changes
are direct copies of the Skia versions except ImageDecoder.h, which is
modified in the necessary ways for the differences between Cairo and
Skia.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() API.
  • platform/image-decoders/ImageDecoder.h: Sync up with Skia version. (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::copyRowNTimes): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setRGBA): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: Sync up with Skia version. (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow):
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Sync up with Skia version. (WebCore::JPEGImageDecoder::outputScanlines):
  • platform/image-decoders/png/PNGImageDecoder.cpp: Sync up with Skia version. (WebCore::PNGImageDecoder::rowAvailable):
  • platform/image-decoders/skia/ImageDecoder.h: Add various typedefs or helper functions to minimize differences with Cairo version. Reorder functions slightly to match reordering of Cairo's m_hasAlpha variable, which I moved to increase readability. (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::copyRowNTimes): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setRGBA): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/skia/JPEGImageDecoder.cpp: Add #include needed by JPEG headers on some platforms, plus comment.
14:36 Changeset [44630] by bfulgham@webkit.org

2009-06-12 Brent Fulgham <bfulgham@webkit.org>

Unreviewed build correction.

Revert accidental configuration checkin. Was not meant to
be part of the last changeset.

  • config.h:
14:34 Changeset [44629] by pkasting@chromium.org

(Accidentally missed a couple email addresses in the last patch)

14:25 Changeset [44628] by bfulgham@webkit.org

2009-06-12 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26353
Corrects handling of Cairo fonts that were getting out of
sync due to default copy construction. Also refactors
some incorrect platform font destruction code that belongs
in the font object's destructor.

  • platform/graphics/win/FontPlatformData.h:
  • platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::~FontPlatformData):
  • platform/graphics/win/FontPlatformDataCairoWin.cpp: (WebCore::FontPlatformData::platformDataInit): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::setFont): (WebCore::FontPlatformData::~FontPlatformData):
  • platform/graphics/win/FontPlatformDataWin.cpp:
  • platform/graphics/win/SimpleFontDataCGWin.cpp:
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformWidthForGlyph):
  • platform/graphics/win/SimpleFontDataWin.cpp:
14:19 Changeset [44627] by pkasting@chromium.org

JavaScriptCore:

2009-06-12 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

  • ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.

WebCore:

2009-06-12 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

  • ChangeLog-2007-10-14: Update my email address.
  • ChangeLog-2008-08-10: Update my email address.

WebKit/mac:

2009-06-12 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

  • ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.

WebKit/win:

2009-06-12 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

  • ChangeLog: Update my email address.
13:00 QtWebKitTodo edited by andre.pedralho@openbossa.org
(diff)
11:02 Changeset [44626] by levin@chromium.org

2009-06-12 Nate Chapin <japhet@google.com>

Reviewed by David Levin.

Upstream V8Helpers.

https://bugs.webkit.org/show_bug.cgi?id=26332

  • bindings/v8/V8Helpers.cpp: Added. (wrapNPObject): Moved from v8_helpers.cpp. (toV8Context): Moved from v8_helpers.cpp. (toV8Proxy): Moved from v8_helpers.cpp.
  • bindings/v8/V8Helpers.h: Added.
09:15 Changeset [44625] by kevino@webkit.org

wx build fix. Adding JSONObject.cpp to the build.

08:55 Changeset [44624] by jberlin@apple.com

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 44622)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,23 @@
+2009-06-12 Jessie Berlin <jberlin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24792
+ rdar://problem/6933055
+
+ Changes the radius in which cursor movement around the 4 arrow icon
+ while pan-scrolling does not cause scrolling from around 10 pixels to
+ 15 pixels, similar to what is found in IE and Firefox.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::setPanScrollCursor):
+ Factor out the no-pan-scroll radius.
+ * platform/ScrollView.h:
+ Create a constant for the no-pan-scroll radius.
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::panScrollFromPoint):
+ Factor out the no-pan-scroll radius.
+

2009-06-12 Xan Lopez <xlopez@igalia.com>


Reviewed by Gustavo Noronha.

Index: WebCore/page/EventHandler.cpp
===================================================================
--- WebCore/page/EventHandler.cpp (revision 44622)
+++ WebCore/page/EventHandler.cpp (working copy)
@@ -661,11 +661,10 @@ void EventHandler::setPanScrollCursor()

At the original click location we draw a 4 arrowed icon. Over this icon there won't be any scroll
So we don't want to change the cursor over this area

  • const int noScrollRadius = 9;
  • bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - noScrollRadius);
  • bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + noScrollRadius);
  • bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + noScrollRadius);
  • bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - noScrollRadius);

+ bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - ScrollView::noPanScrollRadius);
+ bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + ScrollView::noPanScrollRadius);
+ bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + ScrollView::noPanScrollRadius);
+ bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - ScrollView::noPanScrollRadius);

if (north) {

if (east)

Index: WebCore/platform/ScrollView.h
===================================================================
--- WebCore/platform/ScrollView.h (revision 44622)
+++ WebCore/platform/ScrollView.h (working copy)
@@ -214,7 +214,8 @@ public:

virtual void hide();
virtual void setParentVisible(bool);


  • Pan scrolling methods.

+ Pan scrolling.
+ static const int noPanScrollRadius = 15;

void addPanScrollIcon(const IntPoint&);
void removePanScrollIcon();


Index: WebCore/rendering/RenderLayer.cpp
===================================================================
--- WebCore/rendering/RenderLayer.cpp (revision 44622)
+++ WebCore/rendering/RenderLayer.cpp (working copy)
@@ -948,7 +948,6 @@ void RenderLayer::panScrollFromPoint(con

const int shortDistanceLimit = 100; We delimit a 200 pixels long square enclosing the original point
const int speedReducer = 2;
Within this square we divide the scrolling speed by 2


  • const int iconRadius = 10;

Frame* frame = renderer()->document()->frame();
if (!frame)

return;

@@ -965,9 +964,9 @@ void RenderLayer::panScrollFromPoint(con

int xDelta = currentMousePosition.x() - sourcePoint.x();
int yDelta = currentMousePosition.y() - sourcePoint.y();


  • if (abs(xDelta) < iconRadius) at the center we let the space for the icon

+ if (abs(xDelta) < ScrollView::noPanScrollRadius) at the center we let the space for the icon

xDelta = 0;

  • if (abs(yDelta) < iconRadius)

+ if (abs(yDelta) < ScrollView::noPanScrollRadius)

yDelta = 0;


Let's attenuate the speed for the short distances

07:44 Changeset [44623] by ariya@webkit.org

2009-06-12 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Jan Michael Alonzo.

[Qt] Fix build break
https://bugs.webkit.org/show_bug.cgi?id=26340

Note: See TracTimeline for information about the timeline view.