Timeline


and

06/19/09:

23:21 Changeset [44890] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

2009-06-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=26494
Bug 26494: RenderTheme::themeForPage reads from Settings before it has
been initialized by WebKit

Get the shouldPaintNativeControls preference and update the settings
before initializing the page, as the page depends on it after the
themeForPage change.

  • WebView.cpp: (WebView::initWithFrame):
18:29 Changeset [44889] by barraclough@apple.com
  • 9 edits in trunk/JavaScriptCore

2009-06-19 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY (build fix take 2 - rename FIELD_OFFSET to something that doesn't conflict with winnt.h).

  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::emitGetVariableObjectRegister): (JSC::JIT::emitPutVariableObjectRegister):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::compileBinaryArithOp):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference): (JSC::JIT::checkStructure):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call): (JSC::JIT::emitSlow_op_get_by_val):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
18:29 Changeset [44888] by darin@apple.com
  • 2 edits in trunk/WebKitTools

2009-06-19 Darin Adler <darin@apple.com>

  • Scripts/do-webcore-rename: More renaming ideas.
18:19 Changeset [44887] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-06-19 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY (Windows build fix).

  • jit/JIT.h:
  • jit/JITInlineMethods.h:
18:07 Changeset [44886] by barraclough@apple.com
  • 12 edits in trunk/JavaScriptCore

2009-06-19 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Reorganize ARM architecture specific macros.
Use PLATFORM_ARM_ARCH(7) instead of PLATFORM(ARM_V7).

Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>

  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReferenceForTrampoline):
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • wtf/Platform.h:
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
17:52 Changeset [44885] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/ChangeLog

Fixed the changelog, copied the same thing into both on accident.

17:49 Changeset [44884] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-06-19 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix armv7 JIT build issues.

Unfortunate the arm compiler does not like the use of offsetof on JITStackFrame (since it now contains non POD types),
and the FIELD_OFFSET macro does not appear constantish enough for it to be happy with its use in COMPILE_ASSERT macros.

  • Replace offsetofs with FIELD_OFFSETs (safe on C++ objects).
  • Move COMPILE_ASSERTs defending layout of JITStackFrame structure on armv7 into JITThunks constructor.
  • jit/JIT.cpp:
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_catch):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
17:35 Changeset [44883] by bweinstein@apple.com
  • 7 edits
    1 add in trunk

2009-06-19 Brian Weinstein <bweinstein@apple.com>

Reviewed by Steve Falkenburg.


https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7


The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.


Unable to add tests to simulate touch behavior/gestures.

  • platform/PlatformWheelEvent.h:
  • platform/win/WheelEventWin.cpp:

2009-06-19 Brian Weinstein <bweinstein@apple.com>

Reviewed by Steve Falkenburg.


https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7


The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.


Unable to add tests to simulate touch behavior/gestures.

  • platform/PlatformWheelEvent.h:
  • platform/win/WheelEventWin.cpp:
17:27 Changeset [44882] by bfulgham@webkit.org
  • 2 edits
    1 add
    4 deletes in trunk/LayoutTests

2009-06-19 Ryosuke Niwa <rniwa@google.com>

Reviewed by Maciej Stachowiak.

This fixs the bug 26361. The original test case did not invoke the event that
triggered the actual test. This patch adds code to invoke this event, and also
converts it from a pixel test to a dumpAsText test.

16:54 Changeset [44881] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

Fixed a build error, which only shows up in the i386 compile

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
16:35 Changeset [44880] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-06-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6988385> REGRESSION: In full page video player, movie's
video track becomes detached from its controller.

When in the media document, the MediaPlayer should not report that it
is capable of hardware acceleration, because it renders via a QTMovieView
which is already accelerated.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
16:14 Changeset [44879] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Adding XSSAuditor.cpp to the wx build.

15:43 Changeset [44878] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=26544

If I am doing a Matrix hardware animation and any matrix is singular, I revert to software.
This is not really testable, since we can't see what the hardware animation is doing.

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
15:32 Changeset [44877] by ggaren@apple.com
  • 5 edits in trunk/WebCore

2009-06-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


An additional fix for Bug 26532: Native functions do not correctly unlink
from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> | <rdar://problem/6625385>

Use "NativeFunctionWrapper" instead of "PrototypeFunction" in cross-frame
accessors, so the type of object you get to wrap a function is the same,
regardless of whether the access to the function is cross-frame.


This is faster and more idiomatic than what we had before. It also would
have avoided Bug 26532 because it would have prevented a conflicting
PrototypeFunction from being allocated to wrap postMessage, where a
NativeFunctionWrapper had been allocated previously.


  • bindings/js/JSDOMBinding.cpp: (WebCore::objectToStringFunctionGetter):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter):
  • bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter):
  • bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter):
15:23 Changeset [44876] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-06-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by John Sullivan

<rdar://problem/6953673> Crash in RenderLayerCompositor::setCompositingParent

Fix a crash that could occur in complex content due to timing issues
when doing a partial layer tree rebuild which is required when painting;
setCompositingParent() could be called with a parent which has not been made
compositing yet.

15:16 Changeset [44875] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-06-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Build fix. Adding missing HTMLDataGrid* files to the build.

  • GNUmakefile.am:
14:49 Changeset [44874] by pkasting@chromium.org
  • 7 edits in trunk/WebCore

2009-06-19 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26460 part three
Make BMPImageReader a standalone class that is used by ICOImageDecoder
and BMPImageDecoder to decode individual BMPs within a file. These
decoders now inherit directly from ImageDecoder.


This also makes these decoders decode on-demand in isSizeAvailable() and
frameBufferAtIndex(), like the other decoders, instead of when setData()
is called, like before. This should provide a speedup on pages
containing BMPs that aren't immediately onscreen.

  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::setData): (WebCore::BMPImageDecoder::isSizeAvailable): (WebCore::BMPImageDecoder::frameBufferAtIndex): (WebCore::BMPImageDecoder::decodeWithCheckForDataEnded): (WebCore::BMPImageDecoder::decode): (WebCore::BMPImageDecoder::processFileHeader):
  • platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32):
  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::BMPImageReader): (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::readInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData): (WebCore::BMPImageReader::setFailed):
  • platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::setBuffer): (WebCore::BMPImageReader::setData): (WebCore::BMPImageReader::): (WebCore::BMPImageReader::pastEndOfImage): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::setRGBA):
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::setData): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::size): (WebCore::ICOImageDecoder::frameBufferAtIndex): (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded): (WebCore::ICOImageDecoder::decode): (WebCore::ICOImageDecoder::processDirectory): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::readDirectoryEntry): (WebCore::ICOImageDecoder::processImageType):
  • platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32):
14:31 Changeset [44873] by treat@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-06-19 Adam Treat <adam.treat@torchmobile.com>

Blind attempt at build fix.

14:09 Changeset [44872] by hyatt@apple.com
  • 1 add in trunk/WebCore/html/HTMLDataGridElement.cpp

Add missed file.

14:07 Changeset [44871] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Inherits CallIdentifier struct from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/profiler/CallIdentifier.h:86.

  • wtf/HashCountedSet.h:
13:57 Changeset [44870] by treat@webkit.org
  • 6 edits
    6 adds in trunk

2009-06-19 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=26540
Currently the SunSpider test driver lacks an option to run a test suite that
will test JavaScriptCore parsing performance only. This patch adds just such
a test suite and option to SunSpider as well as the jsc test shell. I've included
three large javascript source files found in the wild: jquery, mootools and prototype.
Combined with the concatenation of all three, these form a new testsuite to measure
and test pure JavaScriptCore parsing performance.

13:38 Changeset [44869] by abarth@webkit.org
  • 6 edits in trunk/WebCore

2009-06-19 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26555

Fix the Chromium canary bot. Turns out ScriptSourceCode doesn't have
the same API in V8 and JSC.

  • WebCore/bindings/js/ScriptController.cpp:
  • WebCore/bindings/js/ScriptSourceCode.h:
  • WebCore/bindings/v8/ScriptController.cpp:
  • WebCore/page/XSSAuditor.cpp:
  • WebCore/page/XSSAuditor.h:
13:30 Changeset [44868] by bfulgham@webkit.org
  • 3 edits
    1 add in trunk

009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.


Inherits HashCountedSet class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Collector.cpp:1095.

  • wtf/HashCountedSet.h:
13:17 Changeset [44867] by hyatt@apple.com
  • 16 edits
    3 adds in trunk

WebCore:

2009-06-19 David Hyatt <hyatt@apple.com>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=26547


Implement the IDL interface for HTMLDataGridColElement.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLAttributeNames.in:
  • html/HTMLDataGridColElement.cpp: Added. (WebCore::HTMLDataGridColElement::HTMLDataGridColElement): (WebCore::HTMLDataGridColElement::label): (WebCore::HTMLDataGridColElement::setLabel): (WebCore::HTMLDataGridColElement::type): (WebCore::HTMLDataGridColElement::setType): (WebCore::HTMLDataGridColElement::sortable): (WebCore::HTMLDataGridColElement::setSortable): (WebCore::HTMLDataGridColElement::sortDirection): (WebCore::HTMLDataGridColElement::setSortDirection): (WebCore::HTMLDataGridColElement::selected): (WebCore::HTMLDataGridColElement::setSelected):
  • html/HTMLDataGridColElement.h: Added. (WebCore::HTMLDataGridColElement::endTagRequirement): (WebCore::HTMLDataGridColElement::tagPriority):
  • html/HTMLDataGridColElement.idl: Added.
  • html/HTMLDataGridElement.h:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

LayoutTests:

2009-06-19 David Hyatt <hyatt@apple.com>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=26547


Implement the IDL interface for HTMLDataGridColELement.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
13:09 Changeset [44866] by treat@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-06-19 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=26558
Declare these symbols extern for WINCE as they are provided by libce.

  • runtime/DateConstructor.cpp:
  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
12:54 Changeset [44865] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-06-19 Chris Evans <scarybeasts@gmail.com>

Reviewed by Eric Seidel.

There is no new test because this cannot be tested deterministically.
I've not been able to cause a crash at all in the test framework, but
I have verified that this is happening in the wild and that the patch
fixes the likely cause in the debugger.

  • loader/TextResourceDecoder.cpp: careful not to iterate off the end of our input buffer looking for the end of the comment.
12:37 Changeset [44864] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

12:35 Changeset [44863] by mrowe@apple.com
  • 1 copy in tags/Safari-6531

New tag.

11:48 Changeset [44862] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

<rdar://problem/6988973> ScopeChain leak in interpreter builds

Reviewed by Maciej Stachowiak

Move the Scopechain destruction code in JSFunction outside of the ENABLE(JIT)
path.

11:25 Changeset [44861] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-06-19 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26536

Fix external-script-URL-location.html and
write-external-script-open.html LayoutTests.

implicitOpen is called from several places. We need to setXSSAuditor
each time, so I moved the call inside implicitOpen.

  • dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::implicitOpen):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin):
11:22 Changeset [44860] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-19 Kent Tamura <tkent@chromium.org>

Reviewed by David Levin.

Use WebCore::multipleFileUploadText() in Chromium to fix a problem
that Chromium shows only the first filename even if a user selects
multiple files for <input type=file multiple>.
<https://bugs.webkit.org/show_bug.cgi?id=26502>

  • platform/chromium/FileChooserChromium.cpp: (WebCore::FileChooser::basenameForWidth):
11:14 Changeset [44859] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d

Test: editing/selection/move-by-line-005.html

The root cause of this bug was searchAheadForBetterMatch() continuing
past the first rendered text object after the given object. While we
want to skip non-rendered text and empty containers, when we encounter
rendered text object, we must return a text box for that object.

  • dom/Position.cpp: (WebCore::searchAheadForBetterMatch):

LayoutTests:

Reviewed by Dave Hyatt.

  • text for <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d
  • editing/selection/move-by-line-005-expected.txt: Added.
  • editing/selection/move-by-line-005.html: Added.
10:46 Changeset [44858] by jshin@chromium.org
  • 2 edits
    1 add in trunk/WebCore

2009-06-18 Jungshik Shin <jshin@chromium.org>

Reviewed by David Levin

https://bugs.webkit.org/show_bug.cgi?id=25657

Chromium Linux port does not handle non-BMP characters properly.
It's fixed with a 'UTF-16 iterator macro' to extract Unicode
codepoints out of a UTF-16 input string.

A manual test is added for non-BMP character rendering,
which we can use until a small freely-distributable font
covering non-BMP is added to the Webkit source tree.

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • manual-tests/non-bmp.html: Added.
10:01 Changeset [44857] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-19 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=26543
Windows CE uses 'GetLastError' instead of 'errno.'

  • interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::grow):
09:52 Changeset [44856] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Anders Carlsson.

  • update test results after r44806
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
08:47 Changeset [44855] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-06-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

V8 Bindings: return proper state from the script stack.

https://bugs.webkit.org/show_bug.cgi?id=26512

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::state):
08:34 Changeset [44854] by jberlin@apple.com
  • 2 edits in trunk/WebCore

2009-06-19 Jessie Berlin <jberlin@apple.com>

Reviewed by Simon Fraser.

Windows build fix.


  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
07:28 Changeset [44853] by yael.aharon@nokia.com
  • 3 edits in trunk/WebCore

2009-06-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.
Build fix after 44825.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::isSizeAvailable):
  • platform/graphics/qt/ImageDecoderQt.h:
05:18 Changeset [44852] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-06-19 Daniel Teske <qt-info@nokia.com>

Reviewed by Simon Hausmann.

Remove warnings for QString() constructions from const char *

By explicitly wrapping it with QLatin1String() / QLatin1Char()

02:58 Changeset [44851] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-15 Andre Pedralho <andre.pedralho@openbossa.org>

Reviewed by Tor Arne Vestbø.

Only pass --makeargs along if an argument is given.

02:23 Changeset [44850] by oliver@apple.com
  • 6 edits in trunk

2009-06-18 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Oliver Hunt.

Bug 26426: Canvas: rotation of 'no-repeat' pattern is weird
<https://bugs.webkit.org/show_bug.cgi?id=26426>

Use 1<<23-1 as steps of no-repeat patterns instead of 100000000.0f.
The original number cannot be represented by mantissa of float
(23bit) so that it caused some error.

Test: fast/canvas/image-object-in-canvas.html:

  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
02:06 Changeset [44849] by abarth@webkit.org
  • 1 edit in trunk/WebCore/bindings/v8/ScriptController.cpp

Fix copy/paste error.

01:57 Changeset [44848] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-06-19 abarth <abarth@webkit.org>

Unreviewed attempt to fix the Chromium build.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::xssAuditor):
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
01:29 Changeset [44847] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-06-19 Adam Barth <abarth@webkit.org>

Unreviewed attempt to fix Windows build.

  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled):
01:12 Changeset [44846] by abarth@webkit.org
  • 35 edits
    7 adds in trunk

WebCore:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added an experimental reflective XSS filter. The filter is disabled by
default.

Test: http/tests/security/xssAuditor/script-tag.html

  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
  • bindings/js/ScriptController.h: (WebCore::ScriptController::xssAuditor):
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • dom/Tokenizer.h: (WebCore::Tokenizer::xssAuditor): (WebCore::Tokenizer::setXSSAuditor): (WebCore::Tokenizer::Tokenizer):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::requestObject):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setXSSAuditorEnabled):
  • page/Settings.h: (WebCore::Settings::xssAuditorEnabled):
  • page/XSSAuditor.cpp: Added. (WebCore::isControlCharacter): (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::~XSSAuditor): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h: Added. (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::setXSSAuditorEnabled):

WebKit/mac:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added preference to enable the XSSAuditor.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isXSSAuditorEnabled]): (-[WebPreferences setXSSAuditorEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

WebKit/win:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added preference to enable the XSSAuditor.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isXSSAuditorEnabled): (WebPreferences::setXSSAuditorEnabled):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

WebKitTools:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Add support for testing the XSSAuditor.

  • DumpRenderTree/LayoutTestController.cpp: (setXSSAuditorEnabledCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setPopupBlockingEnabled):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setXSSAuditorEnabled):

LayoutTests:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added a basic test for the XSSAuditor.

  • http/tests/security/xssAuditor/resources/echo-intertag.php: Added.
  • http/tests/security/xssAuditor/script-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag.html: Added.
00:59 Changeset [44845] by levin@chromium.org
  • 3 edits in trunk/JavaScriptCore

2009-06-19 David Levin <levin@chromium.org>

Reviewed by NOBODY (Windows build fix).

Add export for Windows corresponding to OSX export done in r44844.

00:10 Changeset [44844] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

Bug 26532: Native functions do not correctly unlink from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> <rdar://problem/6625385>

Reviewed by Gavin "Viceroy of Venezuela" Barraclough.

We need to make sure that each native function instance correctly unlinks any references to it
when it is collected. Allowing this to happen required a few changes:

  • Every native function needs a codeblock to track the link information
  • To have this codeblock, every function now also needs its own functionbodynode so we no longer get to have a single shared instance.
  • Identifying a host function is now done by looking for CodeBlock::codeType() == NativeCode

06/18/09:

22:39 Changeset [44843] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-18 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY (Windows build fix).

  • wtf/DateMath.cpp: (WTF::calculateUTCOffset):
22:06 Changeset [44842] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-18 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Timezone calculation incorrect in Venezuela.

https://bugs.webkit.org/show_bug.cgi?id=26531
<rdar://problem/6646169> Time is incorrectly reported to JavaScript in both Safari 3 and Firefox 3

The problem is that we're calculating the timezone relative to 01/01/2000,
but the VET timezone changed from -4 hours to -4:30 hours on 12/09/2007.
According to the spec, section 15.9.1.9 states "the time since the beginning
of the year", presumably meaning the *current* year. Change the calculation
to be based on whatever the current year is, rather than a canned date.

No performance impact.

  • wtf/DateMath.cpp: (WTF::calculateUTCOffset):
22:06 Changeset [44841] by krit@webkit.org
  • 3 edits
    4 adds in trunk

2009-06-18 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

feOffset and objectBoundingBox
https://bugs.webkit.org/show_bug.cgi?id=26441

If we use objectBoundingBox for primitiveUnits, the fractions given
to dx or dy of feOffset must be multiplied with the referenced objects
objectBoundingBox size.

Test: svg/filters/feOffset.svg

  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):

Test for feOffset with the primitiveUnits objectBoundingBox
and userSpaceOnUse.

  • platform/mac/svg/filters/feOffset-expected.checksum: Added.
  • platform/mac/svg/filters/feOffset-expected.png: Added.
  • platform/mac/svg/filters/feOffset-expected.txt: Added.
  • svg/filters/feOffset.svg: Added.
22:00 Changeset [44840] by krit@webkit.org
  • 6 edits
    8 adds in trunk

2009-06-18 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

feTile implementation missing
https://bugs.webkit.org/show_bug.cgi?id=26419

Implementation of feTile, a pattern effect for SVG filters. It was
necessary to modify FilterEffect since source inputs need a secial
logic and we have to identify if an effect is a source input.

Tests: svg/batik/filters/feTile.svg

svg/filters/feTile.svg

  • platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::isSourceInput):
  • platform/graphics/filters/SourceAlpha.h: (WebCore::SourceAlpha::isSourceInput):
  • platform/graphics/filters/SourceGraphic.h: (WebCore::SourceGraphic::isSourceInput):
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):

Reviewed by Oliver Hunt.

Added a test of batik and a own one to check behavior of the
new feTile effect in SVG.

  • platform/mac/svg/batik/filters/feTile-expected.checksum: Added.
  • platform/mac/svg/batik/filters/feTile-expected.png: Added.
  • platform/mac/svg/batik/filters/feTile-expected.txt: Added.
  • platform/mac/svg/filters/feTile-expected.checksum: Added.
  • platform/mac/svg/filters/feTile-expected.png: Added.
  • platform/mac/svg/filters/feTile-expected.txt: Added.
  • svg/batik/filters/feTile.svg: Added.
  • svg/filters/feTile.svg: Added.
21:44 Changeset [44839] by krit@webkit.org
  • 4 edits
    4 adds in trunk

2009-06-18 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

feMerge implementation
https://bugs.webkit.org/show_bug.cgi?id=26480

Added feMerge to the SVG Filter system.

Test: svg/filters/feMerge.svg

  • svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::uniteChildEffectSubregions): (WebCore::FEMerge::apply):
  • svg/graphics/filters/SVGFEMerge.h:

Check the feMerge implementation.

  • platform/mac/svg/filters/feMerge-expected.checksum: Added.
  • platform/mac/svg/filters/feMerge-expected.png: Added.
  • platform/mac/svg/filters/feMerge-expected.txt: Added.
  • svg/filters/feMerge.svg: Added.
19:32 Changeset [44838] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-06-18 Gavin Barraclough <barraclough@apple.com>

Rubber Stamped by Mark Rowe (originally reviewed by Sam Weinig).

(Reintroducing patch added in r44492, and reverted in r44796.)

Change the implementation of op_throw so the stub function always modifies its
return address - if it doesn't find a 'catch' it will switch to a trampoline
to force a return from JIT execution. This saves memory, by avoiding the need
for a unique return for every op_throw.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):

JITStubs::cti_op_throw now always changes its return address,
remove return code generated after the stub call (this is now
handled by ctiOpThrowNotCaught).

  • jit/JITStubs.cpp: (JSC::):

Add ctiOpThrowNotCaught definitions.

(JSC::JITStubs::DEFINE_STUB_FUNCTION):

Change cti_op_throw to always change its return address.

  • jit/JITStubs.h:

Add ctiOpThrowNotCaught declaration.

18:51 Changeset [44837] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Speculative Windows build fix.

  • page/win/FrameCGWin.cpp: Add missing #include.
18:21 Changeset [44836] by bfulgham@webkit.org
  • 8 edits in trunk

WebCore:

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=26425
Final refactorings, picking up a few places where BitmapInfo
could be used.

  • page/win/FrameCGWin.cpp: (WebCore::imageFromRect):
  • platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):

WebKit/win:

2009-06-18 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Dave Levin.

Remove some boilerplate using the BitmapInfo struct.
https://bugs.webkit.org/show_bug.cgi?id=26425

  • WebFrame.cpp: (WebFrame::spoolPages):
  • WebIconDatabase.cpp: (createDIB):
  • WebKit.vcproj/WebKit.sln:
  • WebNodeHighlight.cpp: (WebNodeHighlight::update):
  • WebView.cpp: (WebView::ensureBackingStore):
18:20 Changeset [44835] by cfleizach@apple.com
  • 4 edits
    2 adds in trunk

Bug 26522: In DOM mode, VoiceOver reads some mouseover text on web sites strangely
https://bugs.webkit.org/show_bug.cgi?id=26522

18:18 Changeset [44834] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix after recent RenderTheme changes.

18:14 Changeset [44833] by pkasting@chromium.org
  • 7 edits in trunk/WebCore

2009-06-18 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26460 part two
Attempt to minimize diff of following functional change by first landing
non-functional change to:

  • Make readUintX() public and static (since they will need to be once BMPImageReader is included in *ImageDecoder via composition rather than inheritance). Add wrappers in each class so callers can be simpler. In the next patch, these wrappers will be beefed up slightly and the callers will get even simpler.
  • Change direct setting of m_failed to use setFailed(), since in the next patch much of this code won't even have direct access to m_failed
  • Add a helper function in ICOImageDecoder to determine the image type instead of simply doing it inline
  • Rewrap lines that used to be <=80 cols and slipped over it during the original landing of these decoders
  • Other misc. changes, e.g. adding constructor definitions, reordering functions, changing RGBA32Buffer& to RGBA32Buffer*, etc. that have no functional effect but minimize the subsequent diff for readability
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::processFileHeader):
  • platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32):
  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::getInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData):
  • platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16Helper): (WebCore::BMPImageReader::readUint32Helper): (WebCore::BMPImageReader::): (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::getComponent): (WebCore::BMPImageReader::setI): (WebCore::BMPImageReader::setRGBA): (WebCore::BMPImageReader::fillRGBA):
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::size): (WebCore::ICOImageDecoder::decodeImage): (WebCore::ICOImageDecoder::processDirectory): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::isBetterEntry): (WebCore::ICOImageDecoder::processImageType):
  • platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32):
15:52 Changeset [44832] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

2009-06-18 Peter Kasting <pkasting@google.com>

Fix build bustage.

  • platform/image-decoders/gif/GIFImageDecoder.h:
15:34 Changeset [44831] by kmccullough@apple.com
  • 11 edits in trunk

JavaScriptCore:

2009-06-18 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit

  • Exposed functions now needed by WebCore.

WebCore:

2009-06-18 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit

Convert intptr_t to Strings so that we don't loose bits in the
conversion to JS. Previously they were being put into 32bit ints.

  • inspector/InspectorController.cpp: Convert the String back to an intptr_t. (WebCore::InspectorController::addBreakpoint): (WebCore::InspectorController::removeBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorController.idl: Use strings in JS to avoid 32bit truncation.
  • inspector/InspectorFrontend.cpp: Make the intptr_t into a String. (WebCore::InspectorFrontend::parsedScriptSource):
  • platform/text/PlatformString.h: Implemented the necessary conversion functions to be able to convert to and from an intptr_t.
  • platform/text/String.cpp: Ditto. (WebCore::String::toIntPtrStrict): (WebCore::String::toIntPtr): (WebCore::charactersToIntPtrStrict): (WebCore::charactersToIntPtr):
  • platform/text/StringImpl.cpp: Ditto. (WebCore::StringImpl::toIntPtrStrict): (WebCore::StringImpl::toIntPtr):
  • platform/text/StringImpl.h: Ditto.
15:15 Changeset [44830] by jparent@chromium.org
  • 3 edits
    2 adds
    8 deletes in trunk/LayoutTests

2009-06-18 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/insertHTML-expected.txt: Added.
  • editing/execCommand/insertHTML.html:
  • editing/execCommand/switch-list-type-expected.txt: Added.
  • editing/execCommand/switch-list-type.html:
  • platform/mac/editing/execCommand/insertHTML-expected.checksum: Removed.
  • platform/mac/editing/execCommand/insertHTML-expected.png: Removed.
  • platform/mac/editing/execCommand/insertHTML-expected.txt: Removed.
  • platform/mac/editing/execCommand/switch-list-type-expected.checksum: Removed.
  • platform/mac/editing/execCommand/switch-list-type-expected.png: Removed.
  • platform/mac/editing/execCommand/switch-list-type-expected.txt: Removed.
  • platform/qt/editing/execCommand/insertHTML-expected.txt: Removed.
  • platform/qt/editing/execCommand/switch-list-type-expected.txt: Removed.
15:04 Changeset [44829] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

Final cleanups in this refactoring:
(1) Move WindowsBitmap implementation from CG-specific file to

the platform-common GraphicsContextWin.cpp, since it is
equally useful on both platforms.

(2) Revise the TransformationMatrix logic as suggested by

Adam Roben in his review comments to Part #2 of this
refactoring.

  • platform/graphics/win/GraphicsContextCGWin.cpp:
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): (WebCore::GraphicsContext::WindowsBitmap::~WindowsBitmap): (WebCore::GraphicsContext::createWindowsBitmap): (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
14:44 Changeset [44828] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6926859>
NPN_ConvertPoint doesn't give the right value when converting to/from NPCoordinateSpaceFlippedScreen


When inverting Y, use the height of the first screen instead of the screen the window is on.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::windowFrameChanged): (WebKit::NetscapePluginInstanceProxy::mouseEvent):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
14:39 Changeset [44827] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez and Christian Dywan.

Add a new load status to report that the first visually non-empty
layout has been done.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
  • webkit/webkitwebframe.h:
14:39 Changeset [44826] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Fix parameters of navigation-policy-decision-requested callback,
to be correct in number and type

  • tests/testhttpbackend.c: (navigation_policy_decision_requested_cb):
14:29 Changeset [44825] by pkasting@chromium.org
  • 12 edits in trunk/WebCore

2009-06-18 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26460 part one
Make isSizeAvailable non-const, since it's not logically const (it
triggers lazy decoding), and simplify all the implementations (without
changing behavior; just make less verbose). Remove some other
inappropriate consts, which enables the removal of all the mutable
declarations in the decoders.

  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::isSizeAvailable): (WebCore::ImageDecoder::setSize): Make public to avoid needing a friend declaration in the JPEG decoder, and because the ICO/BMP decoders will soon need this.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::isSizeAvailable): (WebCore::GIFImageDecoder::repetitionCount): (WebCore::GIFImageDecoder::decode):
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::isSizeAvailable):
  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::isSizeAvailable): (WebCore::JPEGImageDecoder::decode):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::isSizeAvailable): (WebCore::PNGImageDecoder::decode):
  • platform/image-decoders/png/PNGImageDecoder.h:
  • platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::isSizeAvailable): (WebCore::XBMImageDecoder::frameBufferAtIndex): (WebCore::XBMImageDecoder::decode):
  • platform/image-decoders/xbm/XBMImageDecoder.h: Rename decodeXBM() to decode() for consistency with the JPEG/PNG decoders, and in the future the ICO/BMP decoders.
14:25 Changeset [44824] by jparent@chromium.org
  • 4 edits
    3 adds
    12 deletes in trunk/LayoutTests

2009-06-18 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/5207369-expected.txt: Added.
  • editing/execCommand/5207369.html:
  • editing/execCommand/5210032-expected.txt: Added.
  • editing/execCommand/5210032.html:
  • editing/execCommand/5432254-1-expected.txt: Added.
  • editing/execCommand/5432254-1.html:
  • platform/mac/editing/execCommand/5207369-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5207369-expected.png: Removed.
  • platform/mac/editing/execCommand/5207369-expected.txt: Removed.
  • platform/mac/editing/execCommand/5210032-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5210032-expected.png: Removed.
  • platform/mac/editing/execCommand/5210032-expected.txt: Removed.
  • platform/mac/editing/execCommand/5432254-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5432254-1-expected.png: Removed.
  • platform/mac/editing/execCommand/5432254-1-expected.txt: Removed.
  • platform/qt/editing/execCommand/5207369-expected.txt: Removed.
  • platform/qt/editing/execCommand/5210032-expected.txt: Removed.
  • platform/qt/editing/execCommand/5432254-1-expected.txt: Removed.
14:21 Changeset [44823] by jparent@chromium.org
  • 4 edits
    3 adds
    12 deletes in trunk/LayoutTests

Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/5142012-3-expected.txt: Added.
  • editing/execCommand/5142012-3.html:
  • editing/execCommand/5144139-1-expected.txt: Added.
  • editing/execCommand/5144139-1.html:
  • editing/execCommand/5164796-expected.txt: Added.
  • editing/execCommand/5164796.html:
  • platform/mac/editing/execCommand/5142012-3-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5142012-3-expected.png: Removed.
  • platform/mac/editing/execCommand/5142012-3-expected.txt: Removed.
  • platform/mac/editing/execCommand/5144139-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5144139-1-expected.png: Removed.
  • platform/mac/editing/execCommand/5144139-1-expected.txt: Removed.
  • platform/mac/editing/execCommand/5164796-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5164796-expected.png: Removed.
  • platform/mac/editing/execCommand/5164796-expected.txt: Removed.
  • platform/qt/editing/execCommand/5142012-3-expected.txt: Removed.
  • platform/qt/editing/execCommand/5144139-1-expected.txt: Removed.
  • platform/qt/editing/execCommand/5164796-expected.txt: Removed.
14:13 Changeset [44822] by jparent@chromium.org
  • 4 edits
    3 adds
    12 deletes in trunk/LayoutTests

Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests.

This

fixes the bug 26336 partially.

  • editing/execCommand/4916583-expected.txt: Added.
  • editing/execCommand/4916583.html:
  • editing/execCommand/5119244-expected.txt: Added.
  • editing/execCommand/5119244.html:
  • editing/execCommand/5120591-expected.txt: Added.
  • editing/execCommand/5120591.html:
  • platform/mac/editing/execCommand/4916583-expected.checksum: Removed.
  • platform/mac/editing/execCommand/4916583-expected.png: Removed.
  • platform/mac/editing/execCommand/4916583-expected.txt: Removed.
  • platform/mac/editing/execCommand/5119244-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5119244-expected.png: Removed.
  • platform/mac/editing/execCommand/5119244-expected.txt: Removed.
  • platform/mac/editing/execCommand/5120591-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5120591-expected.png: Removed.
  • platform/mac/editing/execCommand/5120591-expected.txt: Removed.
  • platform/qt/editing/execCommand/4916583-expected.txt: Removed.
  • platform/qt/editing/execCommand/5119244-expected.txt: Removed.
  • platform/qt/editing/execCommand/5120591-expected.txt: Removed.
13:47 Changeset [44821] by bfulgham@webkit.org
  • 6 edits in trunk/WebCore

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

Move some common functions out of platform files and into
the common implementation.

https://bugs.webkit.org/show_bug.cgi?id=26425.
Add a new platform context method (flush) so that the
getWindowsContext method can be consolidated into the common
GraphicsContextWin.cpp file.


  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::flush):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::flush):
  • platform/graphics/win/GraphicsContextCGWin.cpp: Remove getWindowContext method.
  • platform/graphics/win/GraphicsContextCairoWin.cpp: Remove getWindowContext method and fillWithClearColor methods.
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::fillWithClearColor): Moved from *CairoWin.cpp (WebCore::GraphicsContext::getWindowsContext): Moved from *CairoWin.cpp
13:44 Changeset [44820] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-18 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::loadDone): (WebKit::FrameLoaderClient::dispatchDidFinishLoad): (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidFailLoad): Introduce the static function loadDone to emit "load-done" and update the status and update the relevent places. We missed some status notifications before.
13:30 Changeset [44819] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Be consistent in always using the term URI instead of URL in the
documentation of WebKitWebView signals.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
13:28 Changeset [44818] by ojan@chromium.org
  • 2 edits in trunk/WebCore

2009-06-18 Ojan Vafai <ojan@chromium.org>

Reviewed by Oliver Hunt.

Remove code that I accidentally committed in r44811.

  • editing/markup.cpp: (WebCore::createMarkup):
13:25 Changeset [44817] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2009-06-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6983207> Non-layer content is not re-rendered when transition
starts sometimes (with hardware acceleration).

When deciding which RenderLayers should be composited, when a layer goes into
compositing mode we repaint the old location. However, we did that before
we'd looked at all the factors that may force a layer to composite, so missed
some cases. Fix by doing the repaint once we really know whether it's going
to composite.

Test: compositing/repaint/become-overlay-composited-layer.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
12:58 Changeset [44816] by ap@webkit.org
  • 2 edits
    8 adds in trunk/LayoutTests

Reviewed by Maciej Stachowiak and Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=26510
Add tests for authentication behavior with cross-origin XMLHttpRequest

  • http/tests/xmlhttprequest/cross-origin-authorization-expected.txt: Added.
  • http/tests/xmlhttprequest/cross-origin-authorization.html: Added.
  • http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
  • http/tests/xmlhttprequest/cross-origin-no-authorization.html: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-authorization.php: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-preset-authorization-frame.html: Added.
  • platform/mac-tiger/Skipped:
12:21 Changeset [44815] by darin@apple.com
  • 1 edit in trunk/WebKitTools/ChangeLog

2009-06-18 Darin Adler <darin@apple.com>

Rubber stamped by Mark Rowe.

  • DumpRenderTree/mac/DumpRenderTreeWindow.mm: (-[DumpRenderTreeWindow close]): Resolved crashes seen during regression tests. The close method can be called on a window that's already closed so we can't assert here.
12:19 Changeset [44814] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-06-18 Simon Fraser <simon.fraser@apple.com>

Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined, and
the Tiger build where QTMovieLayer does not exist.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::destroyQTMovieLayer): (WebCore::MediaPlayerPrivate::currentRenderingMode): (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::tearDownVideoRendering): (WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):
12:18 Changeset [44813] by darin@apple.com
  • 12 edits in trunk

JavaScriptCore:

2009-06-17 Darin Adler <darin@apple.com>

Reviewed by Oliver Hunt.

Bug 26429: Make JSON.stringify non-recursive so it can handle objects
of arbitrary complexity
https://bugs.webkit.org/show_bug.cgi?id=26429

For marking I decided not to use gcProtect, because this is inside the engine
so it's easy enough to just do marking. And that darned gcProtect does locking!
Oliver tried to convince me to used MarkedArgumentBuffer, but the constructor
for that class says "FIXME: Remove all clients of this API, then remove this API."

  • runtime/Collector.cpp: (JSC::Heap::collect): Add a call to JSONObject::markStringifiers.
  • runtime/CommonIdentifiers.cpp: (JSC::CommonIdentifiers::CommonIdentifiers): Added emptyIdentifier.
  • runtime/CommonIdentifiers.h: Ditto.
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Initialize firstStringifierToMark to 0.
  • runtime/JSGlobalData.h: Added firstStringifierToMark.
  • runtime/JSONObject.cpp: Cut down the includes to the needed ones only. (JSC::unwrapNumberOrString): Added. Helper for unwrapping number and string objects to get their number and string values. (JSC::ReplacerPropertyName::ReplacerPropertyName): Added. The class is used to wrap an identifier or integer so we don't have to do any work unless we actually call a replacer. (JSC::ReplacerPropertyName::value): Added. (JSC::gap): Added. Helper function for the Stringifier constructor. (JSC::PropertyNameForFunctionCall::PropertyNameForFunctionCall): Added. The class is used to wrap an identifier or integer so we don't have to allocate a number or string until we actually call toJSON or a replacer. (JSC::PropertyNameForFunctionCall::asJSValue): Added. (JSC::Stringifier::Stringifier): Updated and moved out of the class definition. Added code to hook this into a singly linked list for marking. (JSC::Stringifier::~Stringifier): Remove from the singly linked list. (JSC::Stringifier::mark): Mark all the objects in the holder stacks. (JSC::Stringifier::stringify): Updated. (JSC::Stringifier::appendQuotedString): Tweaked and streamlined a bit. (JSC::Stringifier::toJSON): Renamed from toJSONValue. (JSC::Stringifier::appendStringifiedValue): Renamed from stringify. Added code to use the m_holderStack to do non-recursive stringify of objects and arrays. This code also uses the timeout checker since in pathological cases it could be slow even without calling into the JavaScript virtual machine. (JSC::Stringifier::willIndent): Added. (JSC::Stringifier::indent): Added. (JSC::Stringifier::unindent): Added. (JSC::Stringifier::startNewLine): Added. (JSC::Stringifier::Holder::Holder): Added. (JSC::Stringifier::Holder::appendNextProperty): Added. This is the function that handles the format of arrays and objects. (JSC::JSONObject::getOwnPropertySlot): Moved this down to the bottom of the file so the JSONObject class is not interleaved with the Stringifier class. (JSC::JSONObject::markStringifiers): Added. Calls mark. (JSC::JSONProtoFuncStringify): Streamlined the code here. The code to compute the gap string is now a separate function.
  • runtime/JSONObject.h: Made everything private. Added markStringifiers.

LayoutTests:

2009-06-17 Darin Adler <darin@apple.com>

Reviewed by Oliver Hunt.

Bug 26429: Make JSON.stringify non-recursive so it can handle objects
of arbitrary complexity
https://bugs.webkit.org/show_bug.cgi?id=26429

  • fast/js/JSON-stringify-expected.txt: Updated.
  • fast/js/resources/JSON-stringify.js: Changed the infinite object and infinite array tests to instead just test something a fixed number of levels deep. Otherwise we end up with an infinite loop in the test, which would lead to the slow-script dialog in the production web browser. Also raised the number from 512 to 2048 since there's no fixed limit any more.
12:14 EFLWebKit edited by tonikitoo@gmail.com
(diff)
12:06 Changeset [44812] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-06-18 Simon Fraser <simon.fraser@apple.com>

Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::currentRenderingMode): (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::tearDownVideoRendering):
11:58 Changeset [44811] by ojan@chromium.org
  • 6 edits
    3 adds in trunk

2009-06-17 Erik Arvidsson <arv@chromium.org>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=15189
Adds the HTML5 input event support for textarea.


Also, moves the oninput attribute parse handling to HTMLElement so that
it can be set on any HTML element so that bubbling events can be handled
using HTML attribute handlers.

Test: fast/forms/textarea-input-event.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
11:53 Changeset [44810] by krit@webkit.org
  • 6 edits in trunk/WebCore

2009-06-18 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Share code between filterEffects
https://bugs.webkit.org/show_bug.cgi?id=26479

Share more code of filter effects. The imageBuffer creation can move to
FilterEffect ant every effect asks for the GraphicsContext. Move the
drawingRect calculation to FilterEffect.

  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::calculateDrawingRect): (WebCore::FilterEffect::getEffectContext):
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply):
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
11:52 Changeset [44809] by simon.fraser@apple.com
  • 14 edits in trunk/WebCore

2009-06-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=26499

Support hardware-accelerationed rendering of video elements.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks): (WebCore::HTMLMediaElement::mediaPlayerRepaint): Just move these methods to group the render-related methods together.

(WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated):
Call out method to ask the RenderLayerCompositor if presentation of this video
can be acclerated. It might say no, if, for example, the video has a reflection.

(WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer):
Fetch the GraphicsLayer from the RenderVideo that will host the movie layer.

  • html/HTMLMediaElement.h: Reordered the rendering-related methods, and added two methods related to video acceleration.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::acceleratedRenderingStateChanged): Called by the rendering system when it determines that the video must go into, or fall off of the hardware-accelerated path.

(WebCore::MediaPlayer::supportsAcceleratedRendering):
Method to say whether the media engine supports accelerated rendering.

  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerRepaint): (WebCore::MediaPlayerClient::mediaPlayerSizeChanged): Moved.

(WebCore::MediaPlayerClient::mediaPlayerRenderingCanBeAccelerated):
(WebCore::MediaPlayerClient::mediaPlayerGraphicsLayer):
New methods to ask the client if the rendering system can support accelerated
rendering, and to get a GraphicsLayer to plug the movie layer into.

  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsAcceleratedRendering): (WebCore::MediaPlayerPrivateInterface::acceleratedRenderingStateChanged): Forwarding methods from MediaPlayer.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Some new methods related to using a QTMovieLayer, and to simplify the rendering mode logic.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::destroyQTMovieLayer): Methods to create and destroy the QTMovieLayer.

(WebCore::MediaPlayerPrivate::currentRenderingMode):
(WebCore::MediaPlayerPrivate::preferredRenderingMode):
Methods to clarify the code that decides which of the 3 rendering modes to use.

(WebCore::MediaPlayerPrivate::setUpVideoRendering):
Changed to use the new rendering mode methods.

(WebCore::MediaPlayerPrivate::tearDownVideoRendering):
Destroy the layer if we have one.

(WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):
Small utility method.

(WebCore::MediaPlayerPrivate::updateStates):
Move the call to setUpVideoRendering() to before we send out the state notifications,
so that we will have created the rendering objects already.

(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
Return true if we have QTMovieLayer.

(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
We've been told that we went into or out of accelerated mode; maybe reset
the renderer, and set the layer if we have to.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::rendererContentChanged): We may need to udpate compositing layers if the video went into accelerated mode.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::canUseDirectCompositing): Add smarts to deal with video, which allows us to avoid extra backing store.

(WebCore::RenderLayerBacking::contentsBox):
Use the videoBox to use the content layer for video layers.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateLayerCompositingState): Poke the RenderVideo if the state changed.

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
Handle an edge case when the video element itself is a stacking context
because of opacity or transform.

(WebCore::RenderLayerCompositor::canAccelerateVideoRendering):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
Allow video to throw us into compositing mode if the media engine supports it.

  • rendering/RenderLayerCompositor.h: New methods related to video.
  • rendering/RenderVideo.h:
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer): Call rendererContentChanged() to give the compositor a change to throw the video into compositing mode.

(WebCore::RenderVideo::supportsAcceleratedRendering):
(WebCore::RenderVideo::acceleratedRenderingStateChanged):
(WebCore::RenderVideo::videoGraphicsLayer):
Methods to allow the MediaPlayer to do rendering-related stuff via the media element.

11:40 Changeset [44808] by rwlbuis@webkit.org
  • 4 edits
    4 adds in trunk

Reviewed by Niko.

https://bugs.webkit.org/show_bug.cgi?id=26385
Root SVG element is not checked on requiredFeatures, requiredExtension like other elements

Also do the isValid check for outer <svg>.

Test: svg/custom/outer-svg-unknown-feature.svg

11:08 Changeset [44807] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

2009-06-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=26499

New expected results after making <video> elements get RenderLayers.

  • platform/mac/fast/replaced/border-radius-clip-expected.txt:
10:54 Changeset [44806] by mitz@apple.com
  • 6 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6913221> REGRESSION (Safari 3-4): Search field on apple.com cuts entered text

Test: fast/forms/search-vertical-alignment.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): Vertically center the

the search field's inner block.

LayoutTests:

Reviewed by Darin Adler.

  • test and updated result for <rdar://problem/6913221> REGRESSION (Safari 3-4): Search field on apple.com cuts entered text
  • fast/forms/search-vertical-alignment.html: Added.
  • platform/mac/fast/forms/search-vertical-alignment-expected.checksum: Added.
  • platform/mac/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt: Added.
  • platform/mac/fast/forms/search-zoomed-expected.checksum:
  • platform/mac/fast/forms/search-zoomed-expected.png:
  • platform/mac/fast/forms/search-zoomed-expected.txt:
09:30 EFLWebKit edited by tonikitoo@gmail.com
(diff)
09:28 EFLWebKit edited by tonikitoo@gmail.com
(diff)
08:08 Changeset [44805] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-06-18 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Simon Hausmann.

Fix compilation with Symbian WINSCW compiler, which produced
multiple definitions of the CSSPrimitiveValue conversion operators.

It turns out that they are defined inline but not declared inline.

Adding the inline keyword to the declaration fixes the build.

07:45 Changeset [44804] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-06-18 Friedemann Kleint <Friedemann.Kleint@nokia.com>

Reviewed by Simon Hausmann.

Fixed MinGW compilation.

07:41 Changeset [44803] by hausmann@webkit.org
  • 4 edits in trunk

2009-06-18 Markus Goetz <Markus.Goetz@nokia.com>

Reviewed by Simon Hausman.

Clarify in docs how to compile with debug information.

07:40 EFLWebKit edited by tonikitoo@gmail.com
(diff)
06:42 Changeset [44802] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-06-18 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] When writing an URL to the clipboard, save the corresponding title
in the mime data as well.

  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeURL):
06:40 Changeset [44801] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-06-18 Jakub Wieczorek <faw217@gmail.com>

[Qt] Fix build. Add HTMLDataGridElement.

  • WebCore.pro:
03:25 Changeset [44800] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-18 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix.

Add HTMLDataGridElement header and IDL to the build script.

  • GNUmakefile.am:
00:55 Changeset [44799] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-06-18 Chris Evans <scarybeasts@gmail.com>

Reviewed by Adam Barth.

Fix 8-digit long hex entities. Fixes bug 26454
https://bugs.webkit.org/show_bug.cgi?id=26454

Test: fast/parser/eightdigithexentity.html

  • html/HTMLTokenizer.cpp: fix off-by-ones.

LayoutTests:

2009-06-18 Chris Evans <scarybeasts@gmail.com>

Reviewed by Adam Barth.

Added test for bug 26454 (broken 8-digit hex entities).
https://bugs.webkit.org/show_bug.cgi?id=26454

  • fast/parser/eightdigithexentity-expected.txt: Added.
  • fast/parser/eightdigithexentity.html: Added.
00:08 Changeset [44798] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-18 David Levin <levin@chromium.org>

Fix chromium linux build.

Fixes a mistake that happened during the complicated merge for
landing r44775, r44776, r44777.

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::create):

06/17/09:

23:40 Changeset [44797] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

<rdar://problem/6974140> REGRESSION(r43849): Crash in cti_op_call_NotJSFunction when getting directions on maps.google.com

Reviewed by Gavin Barraclough

Roll out r43849 as it appears that we cannot rely on the address of
an objects property storage being constant even if the structure is
unchanged.

22:50 Changeset [44796] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-06-17 Gavin Barraclough <barraclough@apple.com>

Rubber Stamped by Mark Rowe.

Fully revert r44492 & r44748 while we fix a bug they cause on internal builds <rdar://problem/6955963>.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):
  • jit/JITStubs.cpp: (JSC::): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h:
19:37 Changeset [44795] by barraclough@apple.com
  • 5 edits in trunk

JavaScriptCore:

2009-06-17 Gavin Barraclough <barraclough@apple.com>

Reviewed by Mark Rowe.

<rdar://problem/6947426> sunspider math-cordic.js exhibits different intermediate results running 32-bit vs. 64-bit

On 64-bit, NaN-encoded values must be detagged before they can be used in rshift.

No performance impact.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift):

LayoutTests:

2009-06-17 Gavin Barraclough <barraclough@apple.com>

Reviewed by Mark Rowe.

Add tests to check shifts by non-constant amounts.

  • fast/js/kde/operators-expected.txt:
  • fast/js/kde/resources/operators.js:
18:49 Changeset [44794] by simon.fraser@apple.com
  • 12 edits in trunk

2009-06-17 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26499

First step to making video rendering be hardware-accelerated:
make <video> elements get self-painting RenderLayers, and add
an isVideo() virtual method to RenderObject.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): (WebCore::HTMLMediaElement::mediaPlayerSizeChanged):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer):
  • rendering/RenderObject.h: (WebCore::RenderObject::isVideo):
  • rendering/RenderVideo.h: (WebCore::RenderVideo::requiresLayer): (WebCore::RenderVideo::isVideo):
18:22 Changeset [44793] by bfulgham@webkit.org
  • 6 edits
    1 add in trunk/WebCore

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Refactor a few common routines in the various Windows ports
and reduce some duplicated code.

(1) Create TransformationMatrix XFORM casting operator, and

switch various XFORM structure uses to utilize it.

(2) Push concatCTM call to GraphicsContextWin now that the

TransformationMatrix can directly create XFORM (rather
than converting to CGAffineTransform/cairo_matrix_t first.)

  • WebCore.vcproj/WebCore.vcproj: Add new BitmapInfo structure.
  • platform/graphics/transforms/TransformationMatrix.h:
  • platform/graphics/win/GraphicsContextCGWin.cpp:
  • platform/graphics/win/GraphicsContextCairoWin.cpp:
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/win/TransformationMatrixWin.cpp: Added. (WebCore::TransformationMatrix::operator XFORM): New operator
18:05 Changeset [44792] by simon.fraser@apple.com
  • 12 edits
    6 copies
    1 add in trunk/LayoutTests

2009-06-17 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

Update results after enabling 3d rendering on SnowLeopard.

  • platform/mac-leopard/fast/media/mq-transform-02-expected.checksum: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.checksum.
  • platform/mac-leopard/fast/media/mq-transform-02-expected.png: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.png.
  • platform/mac-leopard/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.txt.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.checksum: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.checksum.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.png: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.png.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.txt. Copy the old "mac" results to "mac-leopard" since 3d-rendering is disabled there.
  • platform/mac/fast/media/mq-transform-02-expected.checksum:
  • platform/mac/fast/media/mq-transform-02-expected.png:
  • platform/mac/fast/media/mq-transform-02-expected.txt:
  • platform/mac/fast/media/mq-transform-03-expected.checksum:
  • platform/mac/fast/media/mq-transform-03-expected.png:
  • platform/mac/fast/media/mq-transform-03-expected.txt: New "mac" results for 3d rendering enabled.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Update the results now that these tests are active.
17:41 Changeset [44791] by sfalken@apple.com
  • 20 edits in trunk

WebKit/win:

2009-06-17 Steve Falkenburg <sfalken@apple.com>

Consolidate WebKit COM interfaces.
Moved IID from the highest numbered COM interface to the first interface and combined all methods.

Numbered interfaces can be combined since the latest shipping Safari 4 supports the latest interfaces.


Reviewed by Adam Roben.

  • Interfaces/IWebFrameLoadDelegate.idl:
  • Interfaces/IWebFrameLoadDelegatePrivate.idl:
  • Interfaces/IWebResourceLoadDelegatePrivate.idl:
  • Interfaces/IWebUIDelegate.idl:
  • Interfaces/IWebUIDelegatePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebContextMenuClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebInspectorDelegate.h:
  • WebFrame.cpp:
  • WebView.cpp:

WebKitTools:

2009-06-17 Steve Falkenburg <sfalken@apple.com>

Updated for consolidated WebKit COM interfaces.


Reviewed by Adam Roben.

  • DumpRenderTree/win/FrameLoadDelegate.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.h:
  • DumpRenderTree/win/UIDelegate.cpp:
  • DumpRenderTree/win/UIDelegate.h:
  • WinLauncher/WinLauncher.h:
17:37 Changeset [44790] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Non-CG Windows build fix after @r44758.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderTheme::themeForPage):
17:32 Changeset [44789] by bfulgham@webkit.org
  • 8 edits
    2 adds in trunk/WebCore

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Refactor a few common routines in the various Windows ports
and reduce some duplicated code.
https://bugs.webkit.org/show_bug.cgi?id=26425.

Refactor use of BITMAPINFO for the new BitmapInfo structure.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/BitmapInfo.cpp: Added. (WebCore::bitmapInfoForSize): (WebCore::BitmapInfo::create): (WebCore::BitmapInfo::createBottomUp):
  • platform/win/BitmapInfo.h: Added.
  • platform/graphics/win/GraphicsContextCairoWin.cpp:
  • platform/graphics/win/GraphicsContextCGWin.cpp:
  • platform/graphics/win/TransformationMatrixWin.cpp: Added. (WebCore::TransformationMatrix::operator XFORM): New operator
  • platform/win/DragImageCGWin.cpp: (WebCore::allocImage):
  • platform/win/DragImageCairoWin.cpp: (WebCore::allocImage):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
17:28 Changeset [44788] by mrowe@apple.com
  • 4 copies
    1 add in releases/Apple/Safari 4.0.1

Create Safari 4.0.1 release tag, consisting of version 5530.18 of WebCore and WebKit. JavaScriptCore and JavaScriptGlue remain unchanged.

17:21 Changeset [44787] by mrowe@apple.com
  • 4 copies
    1 add in releases/Apple/Safari 4.0

Create Safari 4.0 release tag, consisting of version x530.17 of each project.

15:37 Changeset [44786] by aroben@apple.com
  • 3 edits in trunk/WebCore

Remove unnecessary 6th parameter from SOFT_LINK_OPTIONAL

Reviewed by Mark Rowe.

  • platform/graphics/win/ColorSafari.cpp: Removed the 6th parameter and an unnecessary parameter name.
  • platform/win/SoftLinking.h: Removed the unused 6th parameter.
15:10 Changeset [44785] by aroben@apple.com
  • 3 edits in trunk/WebCore

Make Settings::shouldPaintNativeControls default to true

This matches the default up in WebKit (that was changed in r43318).

Fixes Bug 26493: REGRESSION (r44758): First tab always uses Mac-style
form controls
<https://bugs.webkit.org/show_bug.cgi?id=26493>

Reviewed by Darin Adler and Dave Hyatt.

No test possible since DRT always uses Mac-style form controls.

  • page/Settings.cpp: Changed the initial value of gShouldPaintNativeControls to true.
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderTheme::themeForPage): Added a FIXME about the design flaw here involving querying Settings before it's been initialized.
14:42 WebKit Team edited by ben@webkit.org
(diff)
14:26 Changeset [44784] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/fast/js/global-constructors-expected.txt

Update layout test results for addition of datagrid element.

14:24 Changeset [44783] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-17 David Levin <levin@chromium.org>

Fix chromium Windows build.

A mistake that happened during the complicated merge for
landing r44775, r44776, r44777.

  • rendering/RenderThemeChromiumWin.h: (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin):
14:17 EFLWebKit edited by tonikitoo@gmail.com
(diff)
14:16 Changeset [44782] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-06-17 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6981193> Crash in MediaControlInputElement::attachToParent

  • rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::attachToParent): NULL check element renderer or parent renderer. (WebCore::MediaControlInputElement::attachToParent): Ditto.
14:03 EFLWebKit edited by tonikitoo@gmail.com
(diff)
14:02 EFLWebKit edited by tonikitoo@gmail.com
(diff)
13:51 EFLWebKit edited by tonikitoo@gmail.com
(diff)
13:46 EFLWebKit edited by tonikitoo@gmail.com
(diff)
13:45 EFLWebKit edited by tonikitoo@gmail.com
(diff)
13:31 EFLWebKit edited by tonikitoo@gmail.com
(diff)
13:11 Changeset [44781] by weinig@apple.com
  • 2 edits in trunk/WebKitSite

2009-06-17 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

  • security/index.html: Fix some typos.
13:05 Changeset [44780] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-06-17 David Hyatt <hyatt@apple.com>

Fix Windows build. There's no HTMLDataGridElement.cpp file yet.

  • html/HTMLElementsAllInOne.cpp:
12:56 Changeset [44779] by weinig@apple.com
  • 2 edits
    1 move in trunk/WebKitSite

2009-06-17 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Move security policy to security/index.html so that
webkit.org/security/ works.

  • nav.inc:
  • security/index.html: Copied from security/security-policy.html.
  • security/security-policy.html: Removed.
12:33 Changeset [44778] by hyatt@apple.com
  • 15 edits
    2 adds in trunk

WebCore:

2009-06-17 David Hyatt <hyatt@apple.com>

Reviewed by Adam Roben and Anders Carlsson.

Stub out the HTMLDataGridElement.

  • DerivedSources.make:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing):
  • html/HTMLDataGridElement.h: Added. (WebCore::HTMLDataGridElement::HTMLDataGridElement): (WebCore::HTMLDataGridElement::tagPriority):
  • html/HTMLDataGridElement.idl: Added.
  • html/HTMLElement.cpp: (WebCore::inlineTagList):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::isAffectedByResidualStyle):
  • html/HTMLTagNames.in:

LayoutTests:

2009-06-17 David Hyatt <hyatt@apple.com>

Reviewed by Anders Carlsson.

Update window properties layout test for HTMLDataGridElement addition.

  • fast/dom/Window/window-properties-expected.txt:
12:31 Changeset [44777] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-17 David Levin <levin@chromium.org>

Reviewed by NOBODY (chromium build fix).

Fix typo in previous changes.

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::defaultGUIFont):
12:18 Changeset [44776] by levin@chromium.org
  • 7 edits in trunk/WebCore

2009-06-17 Albert J. Wong <ajwong@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26148
Remove common code from RenderThemeChromiumWin that is shared with
RenderThemeChromiumSkia.

Also move supportsControlTints to RenderThemeChromiumLinux since it
is linux specific.

There are no tests changed because this just removes functions with
duplicate implementations between the base and derived classes.

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::supportsControlTints):
  • rendering/RenderThemeChromiumLinux.h:
  • rendering/RenderThemeChromiumSkia.cpp:
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::): (WebCore::getNonClientMetrics): (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::systemFont): (WebCore::RenderThemeChromiumWin::paintCheckbox): (WebCore::RenderThemeChromiumWin::paintRadio): (WebCore::RenderThemeChromiumWin::paintSliderThumb): (WebCore::RenderThemeChromiumWin::caretBlinkIntervalInternal):
  • rendering/RenderThemeChromiumWin.h:
12:18 Changeset [44775] by levin@chromium.org
  • 5 edits in trunk/WebCore

2009-06-17 Albert J. Wong <ajwong@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26148
Move RenderThemeChromiumSkia into its own file. This is purely a code move.

  • rendering/RenderThemeChromiumLinux.cpp:
  • rendering/RenderThemeChromiumLinux.h:
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::): (WebCore::setSizeIfAuto): (WebCore::mediaElementParent): (WebCore::RenderThemeChromiumSkia::defaultGUIFont): (WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::~RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumSkia::extraQuirksStyleSheet): (WebCore::RenderThemeChromiumSkia::extraMediaControlsStyleSheet): (WebCore::RenderThemeChromiumSkia::supportsHover): (WebCore::RenderThemeChromiumSkia::supportsFocusRing): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformTextSearchHighlightColor): (WebCore::RenderThemeChromiumSkia::caretBlinkInterval): (WebCore::RenderThemeChromiumSkia::systemFont): (WebCore::RenderThemeChromiumSkia::minimumMenuListSize): (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::paintRadio): (WebCore::RenderThemeChromiumSkia::setRadioSize): (WebCore::brightenColor): (WebCore::paintButtonLike): (WebCore::RenderThemeChromiumSkia::paintButton): (WebCore::RenderThemeChromiumSkia::paintTextField): (WebCore::RenderThemeChromiumSkia::paintTextArea): (WebCore::RenderThemeChromiumSkia::paintSearchField): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumSkia::paintMediaButtonInternal): (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): (WebCore::RenderThemeChromiumSkia::adjustMenuListStyle): (WebCore::RenderThemeChromiumSkia::paintMenuList): (WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumSkia::paintMenuListButton): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::caretBlinkIntervalInternal): (WebCore::RenderThemeChromiumSkia::menuListInternalPadding):
  • rendering/RenderThemeChromiumSkia.h: (WebCore::RenderThemeChromiumSkia::supportsControlTints):
12:17 Changeset [44774] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-06-17 Albert J. Wong <ajwong@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26148
Extract RenderThemeChromiumSkia out of RenderThemeChromiumLinux. This
is mostly a code shuffle. The non-suffle changes are:

1) Creation of a caretBlinkIntervalInternal.
2) Moving of some inline functions into the implementation files.
3) Changing of defaultGUIFont into a static class constant from a

static function. Also the type is changed to String.

4) Changing of defaultFontSize into a static class constant from a

static variable in the file scope.

5) The static supportsFocus function was collapsed into

supportsFocusRing.

6) Split the extraDefaultStyleSheet into Skia and Linux versions.

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumSkia::defaultGUIFont): (WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::~RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumSkia::extraQuirksStyleSheet): (WebCore::RenderThemeChromiumSkia::extraMediaControlsStyleSheet): (WebCore::RenderThemeChromiumSkia::supportsHover): (WebCore::RenderThemeChromiumSkia::supportsFocusRing): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformTextSearchHighlightColor): (WebCore::RenderThemeChromiumSkia::caretBlinkInterval): (WebCore::RenderThemeChromiumSkia::systemFont): (WebCore::RenderThemeChromiumSkia::minimumMenuListSize): (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::paintRadio): (WebCore::RenderThemeChromiumSkia::setRadioSize): (WebCore::RenderThemeChromiumSkia::paintButton): (WebCore::RenderThemeChromiumSkia::paintTextField): (WebCore::RenderThemeChromiumSkia::paintTextArea): (WebCore::RenderThemeChromiumSkia::paintSearchField): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumSkia::paintMediaButtonInternal): (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): (WebCore::RenderThemeChromiumSkia::adjustMenuListStyle): (WebCore::RenderThemeChromiumSkia::paintMenuList): (WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumSkia::paintMenuListButton): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::caretBlinkIntervalInternal): (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::~RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::systemColor): (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumSkia::menuListInternalPadding):
  • rendering/RenderThemeChromiumLinux.h:
12:07 Changeset [44773] by weinig@apple.com
  • 2 edits
    3 adds in trunk/WebKitSite

2009-06-13 Sam Weinig <sam@webkit.org>

Reviewed by Timothy Hatcher.

Add WebKit Security Policy and member list of the WebKit Security Group.

  • nav.inc:
  • security: Added.
  • security/security-group-members.html: Added.
  • security/security-policy.html: Added.
12:02 Changeset [44772] by aroben@apple.com
  • 3 edits in trunk/WebCore

Add a SOFT_LINK_OPTIONAL macro

This macro is useful when soft-linking functions that are present in
only some versions of a particular library (e.g., APIs added in
Windows Vista that aren't available on Windows XP).

Reviewed by Ada Chan.

  • platform/graphics/win/ColorSafari.cpp: (WebCore::focusRingColor): Use the SoftLinking.h macros instead of doing the soft-link ourselves. Also removed an unused call to focusRingColor.isValid().
  • platform/win/SoftLinking.h: Added SOFT_LINK_OPTIONAL.
11:25 Changeset [44771] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Gustavo Noronha Silva.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26470.
The use of zero-width or zero-height rectangles in generating
gradients caused Windows Cairo to crash, and webkitgtk to
produce invalid images.

11:22 Changeset [44770] by ojan@chromium.org
  • 2 edits in trunk/WebCore

2009-06-17 Ojan Vafai <ojan@chromium.org>

Reviewed by NOBODY (OOPS!).

If loading a font fails because of the sandbox, we ask the browser process to
try to load it by calling ensureFontLoaded. If it still fails after
ensureFontLoaded, we hit a ASSERT_NOT_REACHED.

This case happens once in a while during browser shutdown. The browser will
queue a message to the renderer to shutdown, and will then stop answering sync
messages from the renderer. If the renderer is still loading a page during this
time, it might try to call the browser process to ask to load a font. The
browser process will ignore the request, and the font will fail to load, even
after the second try.

This is unfortunate, but there is no real risk here, since the renderer will be
going away as soon as it processes another message.

This can't be layout tested as it depends on the sandbox.

https://bugs.webkit.org/show_bug.cgi?id=26484

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter):
11:21 Changeset [44769] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2009-06-17 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=26482
<rdar://problem/6978590> When setting playback rate to 0, the audio element stops
playing (doesn't resume later)

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setRate): Always set the rate, even when "paused".
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::setRate): Ditto.
10:13 Changeset [44768] by aroben@apple.com
  • 2 edits in trunk/WebCore

Add all the generated JS*.cpp files back to WebCore.vcproj

They are not compiled by the vcproj directly. Instead they are
compiled as part of DerivedSources.cpp. Having them listed in the
vcproj makes them be included in Project Find, etc.

Rubber-stamped in advance by Steve Falkenburg.

  • WebCore.vcproj/WebCore.vcproj:
10:01 Changeset [44767] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-17 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

Don't fire redundant 'change' events for a file upload form.
https://bugs.webkit.org/show_bug.cgi?id=26471

  • platform/FileChooser.cpp: (WebCore::FileChooser::chooseFiles): Suppress change event if the existing selected files and the incoming selected files are equal. (WebCore::FileChooser::chooseIcon): Returns 0 if there is no selected files.
09:45 Changeset [44766] by treat@webkit.org
  • 4 edits in trunk

2009-06-17 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=23155
Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.

09:39 Changeset [44765] by treat@webkit.org
  • 15 edits in trunk

2009-06-17 George Staikos <george.staikos@torchmobile.com>

Reviewed by Adam Treat.

https://bugs.webkit.org/show_bug.cgi?id=23155
Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.

08:54 Changeset [44764] by aroben@apple.com
  • 3 edits in trunk/LayoutTests

Fix Skipped file format after r44519

  • platform/qt/Skipped:
  • platform/win/Skipped: Removed bogus ": Added."s in these files.
08:42 Changeset [44763] by aroben@apple.com
  • 5 edits in trunk/WebCore

Speculative Mac build fix

  • page/Page.h: Forward-declare RenderTheme instead of including RenderTheme.h so that we don't need to make RenderTheme.h a private header for WebKit's benefit.
  • editing/SelectionController.cpp:
  • rendering/InlineTextBox.cpp:
  • rendering/RenderObject.cpp: Added #includes of RenderTheme.h.
08:32 Changeset [44762] by aroben@apple.com
  • 2 edits in trunk/WebCore

Speculative Mac build fix

  • rendering/RenderThemeMac.mm: (WebCore::RenderTheme::create): Added.
08:26 Changeset [44761] by aroben@apple.com
  • 2 edits in trunk/WebCore

Speculative Mac build fix

  • rendering/RenderThemeMac.mm: (WebCore::RenderTheme::themeForPage): Remove the name of an unused parameter.
08:14 Changeset [44760] by aroben@apple.com
  • 2 edits in trunk/WebCore

Speculative Mac build fix

  • page/Page.cpp: (WebCore::Page::Page): Change the initializer order to match the declaration order.
07:52 Changeset [44759] by aroben@apple.com
  • 3 edits in trunk/WebCore

2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Follow up to bug https://bugs.webkit.org/show_bug.cgi?id=26278
Patch that make WebCore have a RenderTheme per page

Make the Qt implementation of RenderTheme create a theme per page,
and use the QStyle associated with the view of each page, in order
to make the QWidget setStyle() method work as advertised.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::qStyle): (WebCore::findFrameLineWidth): (WebCore::inflateButtonRect): (WebCore::RenderThemeQt::adjustRepaintRect): (WebCore::RenderThemeQt::isControlStyled): (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::setButtonPadding): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::setPopupPadding):
  • platform/qt/RenderThemeQt.h:
07:52 Changeset [44758] by aroben@apple.com
  • 39 edits in trunk

2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Dave Hyatt and Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=26278
Patch that make WebCore have a RenderTheme per page

Create a different RenderTheme per page, so that RenderTheme has
access to page specific theming. This is needed for the Qt port, as Qt
supports setting the theme (style) per widget.

This change was suggested and discussed with Dave Hyatt.

More detailed:

1) Create a theme per page or one global one, depending on the needs

of the platform.

2) Add an accesser to the theme from RenderObject.
3) Change all uses of the theming to access the theme through

RenderObject, using the global default theme as fallback, when the
document of RenderObject has no page.
When we don't have access to a RenderObject, use the default theme.

4) Modify all RenderTheme platform implementations to work with the

above changes, still creating only one global theme.

02:11 Changeset [44757] by barraclough@apple.com
  • 8 edits in trunk

JavaScriptCore:

2009-06-17 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6974175> ASSERT in JITStubs.cpp at appsaccess.apple.com

Remove PropertySlot::putValue - PropertySlots should only be used for getting,
not putting. Rename JSGlobalObject::getOwnPropertySlot to hasOwnPropertyForWrite,
which is what it really was being used to ask, and remove some other getOwnPropertySlot
& getOwnPropertySlotForWrite methods, which were unused and likely to lead to confusion.

  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::hasOwnPropertyForWrite):
  • runtime/JSObject.h:
  • runtime/JSStaticScopeObject.cpp:
  • runtime/JSStaticScopeObject.h:
  • runtime/PropertySlot.h:

WebCore:

2009-06-17 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6974175> ASSERT in JITStubs.cpp at appsaccess.apple.com

JSDOMWindowCustom was using PropertySlot::putValue, however this interface
appears to be fundaementally incorrect - PropertySlots are only used to get
values, all puts use PutPropertySlot. However PutPropertySlot cannot be
used in the fashion desired here - it only reports the caching type of a
write that has been performed.

(This caused a bug where the put should have triggered a transition, and
failed to do so.)

Removing the faulty case from the optimization leads to a ~0.5% progression
on in-browser SunSpider (presumably the very first case was not being hit
often, and the simplification here is beneficial).

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::put):
01:48 Changeset [44756] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-06-17 Markus Goetz <Markus.Goetz@nokia.com>

Reviewed by Simon Hausmann.

QWebPage: Don't call supportsSsl()

This stops QWebPage from loading the OpenSSL libs,
certificates etc. when they are not needed for the non-HTTPS case.

Loading the SSL libraries can be a very slow operation.

00:41 Changeset [44755] by levin@chromium.org
  • 8 edits
    3 deletes in trunk

WebCore:

2009-06-17 David Levin <levin@chromium.org>

Reviewed by NOBODY, layout tests fix.

https://bugs.webkit.org/show_bug.cgi?id=26326
This reverts commit r44751.

Once that change was checked scrollbars/scrollbar-orientation.html started
crashing on Windows.

  • dom/Document.cpp: (WebCore::Document::detach):
  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/Scrollbar.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
  • rendering/RenderScrollbar.h:

LayoutTests:

2009-06-17 David Levin <levin@chromium.org>

Reviewed by NOBODY, layout tests fix.

https://bugs.webkit.org/show_bug.cgi?id=26326
This reverts commit r44751.

Once that change was checked scrollbars/scrollbar-orientation.html started
crashing on Windows.

  • scrollbars/resources/page-with-custom-scrollbars.html: Removed.
  • scrollbars/scrollbar-crash-on-refresh-expected.txt: Removed.
  • scrollbars/scrollbar-crash-on-refresh.html: Removed.

06/16/09:

23:13 Changeset [44754] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

In ImageSource::setData, delete the old m_encoder before replacing it with a new one.

https://bugs.webkit.org/show_bug.cgi?id=26458

22:19 Changeset [44753] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-06-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

<rdar://problem/6976766> Control-click on pages with accelerated compositing
content does not work.

Part deux. #ifdef the use of _private->layerHostingView with
USE(ACCELERATED_COMPOSITING)

  • WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]):
22:12 Changeset [44752] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-06-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

<rdar://problem/6976766> Control-click on pages with accelerated compositing
content does not work.

Remove the WebLayerHostingView subclass of NSView, with its attempts to
forward events to the WebHTMLView, and just fix -[WebHTMLView hitTest:]
to ignore the layerHostingView.

  • WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]): (-[WebHTMLView attachRootLayer:]):
21:56 Changeset [44751] by levin@chromium.org
  • 8 edits
    3 adds in trunk

WebCore:

2009-06-16 David Levin <levin@chromium.org>

Reviewed by David Hyatt.

REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326

Test: scrollbars/scrollbar-crash-on-refresh.html

  • dom/Document.cpp: (WebCore::Document::detach): Gives the FrameView a change to do any necessary cleanup on Document::detach() which is where the renderArena gets detroyed.
  • page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars): Gets rid of any custom scrollbars (if the docment supplied them).
  • page/FrameView.h:
  • platform/Scrollbar.h: (WebCore::Scrollbar::isCustomScrollbar):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Removed the check for document()->frame(). If frame() is 0 in this code, then the call to animation() is also incorrect (since it does document()->frame()->animation()).
  • rendering/RenderScrollbar.h: (WebCore::RenderScrollbar::isCustomScrollbar):

LayoutTests:

2009-06-16 David Levin <levin@chromium.org>

Reviewed by David Hyatt.

REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326

Test that refreshing an iframe with custom scrollbars works without crashing.

  • scrollbars/resources/page-with-custom-scrollbars.html: Added.
  • scrollbars/scrollbar-crash-on-refresh-expected.txt: Added.
  • scrollbars/scrollbar-crash-on-refresh.html: Added.
19:35 Changeset [44750] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

2009-06-16 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adele Peterson.

Fix of <rdar://6967547> Ctrl-C copies null value erasing text in clipboard in Safari.
This patch kept the way events were firing as they were before, and Windows events are
consistent with Mac.

  • editing/Editor.cpp: (WebCore::Editor::tryDHTMLCopy): Added check for canCopy() before clearing PasteBoard (WebCore::Editor::tryDHTMLCut): Added check for canCut() before clearing PasteBoard
17:38 Changeset [44749] by antti@apple.com
  • 14 edits in trunk/WebCore

2009-06-16 Antti Koivisto <antti@apple.com>

Reviewed by Brady Eidson.

<rdar://problem/6660037> CrashTracer: [USER] 46 crashes in Safari at com.apple.WebCore • WebCore::CachedCSSStyleSheet::addClient + 53


When revalidating a resource, calling addClient() on one client might cause another to get removed.


  • made CachedResource::addClient() non-virtual and added virtual didAddClient()
  • in CachedResource::switchClientsToRevalidatedResource() add all clients to the client set of the revalidated resource first
  • check if the client is still in the set before invoking didAddClient() for it


No test case, I didn't manage to construct one. You need some combination of 304 revalidation, stylesheets that
reference each other via @imports and reloading.

  • WebCore.base.exp:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::didAddClient):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedFont.cpp: (WebCore::CachedFont::didAddClient):
  • loader/CachedFont.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::didAddClient):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::addClient): (WebCore::CachedResource::addClientToSet): (WebCore::CachedResource::switchClientsToRevalidatedResource):
  • loader/CachedResource.h:
  • loader/CachedScript.cpp: (WebCore::CachedScript::didAddClient):
  • loader/CachedScript.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::didAddClient):
  • loader/CachedXSLStyleSheet.h:
16:35 Changeset [44748] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-06-16 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver hunt.

Temporarily partially disable r44492, since this is causing some problems on internal builds.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):
  • jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION):
15:39 Changeset [44747] by bdakin@apple.com
  • 533 edits in branches/WWDC-2009-branch/LayoutTests

2009-06-16 Beth Dakin <bdakin@apple.com>

Rubber-stamped by Mark Rowe.

The rest of the text metric layout test changes for the branch.

  • fast/forms/text-control-intrinsic-widths-expected.txt:
  • fast/forms/textarea-metrics-expected.txt:
  • fast/replaced/table-percent-height-text-controls-expected.txt:
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum:
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.png:
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt:
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum:
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png:
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt:
  • platform/mac-leopard/media/audio-controls-rendering-expected.checksum:
  • platform/mac-leopard/media/audio-controls-rendering-expected.png:
  • platform/mac-leopard/media/video-aspect-ratio-expected.checksum:
  • platform/mac-leopard/media/video-aspect-ratio-expected.png:
  • platform/mac-leopard/media/video-controls-rendering-expected.checksum:
  • platform/mac-leopard/media/video-controls-rendering-expected.png:
  • platform/mac-leopard/media/video-display-toggle-expected.checksum:
  • platform/mac-leopard/media/video-display-toggle-expected.png:
  • platform/mac-leopard/media/video-empty-source-expected.png:
  • platform/mac-leopard/media/video-layer-crash-expected.checksum:
  • platform/mac-leopard/media/video-layer-crash-expected.png:
  • platform/mac-leopard/media/video-transformed-expected.checksum:
  • platform/mac-leopard/media/video-transformed-expected.png:
  • platform/mac-leopard/media/video-zoom-controls-expected.checksum:
  • platform/mac-leopard/media/video-zoom-controls-expected.png:
  • platform/mac-leopard/media/video-zoom-expected.checksum:
  • platform/mac-leopard/media/video-zoom-expected.png:
  • platform/mac/animations/animation-drt-api-expected.png:
  • platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.png:
  • platform/mac/fast/backgrounds/background-clip-text-expected.checksum:
  • platform/mac/fast/backgrounds/background-clip-text-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.png:
  • platform/mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/mac/fast/block/margin-collapse/103-expected.png:
  • platform/mac/fast/block/margin-collapse/103-expected.txt:
  • platform/mac/fast/block/positioning/047-expected.checksum:
  • platform/mac/fast/block/positioning/047-expected.png:
  • platform/mac/fast/borders/border-image-rotate-transform-expected.checksum:
  • platform/mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/mac/fast/css-generated-content/hit-test-generated-content-expected.png:
  • platform/mac/fast/css/line-height-expected.checksum:
  • platform/mac/fast/css/line-height-expected.png:
  • platform/mac/fast/css/line-height-expected.txt:
  • platform/mac/fast/css/line-height-font-order-expected.checksum:
  • platform/mac/fast/css/line-height-font-order-expected.png:
  • platform/mac/fast/css/resize-corner-tracking-expected.checksum:
  • platform/mac/fast/css/resize-corner-tracking-expected.png:
  • platform/mac/fast/css/resize-corner-tracking-expected.txt:
  • platform/mac/fast/css/resize-corner-tracking-transformed-expected.png:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/mac/fast/dom/isindex-002-expected.checksum:
  • platform/mac/fast/dom/isindex-002-expected.png:
  • platform/mac/fast/dom/isindex-002-expected.txt:
  • platform/mac/fast/dynamic/008-expected.checksum:
  • platform/mac/fast/dynamic/008-expected.png:
  • platform/mac/fast/dynamic/008-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.checksum:
  • platform/mac/fast/events/autoscroll-expected.png:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.checksum:
  • platform/mac/fast/events/context-no-deselect-expected.png:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/events/label-focus-expected.checksum:
  • platform/mac/fast/events/label-focus-expected.png:
  • platform/mac/fast/events/label-focus-expected.txt:
  • platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum:
  • platform/mac/fast/events/standalone-image-drag-to-editable-expected.png:
  • platform/mac/fast/forms/001-expected.checksum:
  • platform/mac/fast/forms/001-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.checksum:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.checksum:
  • platform/mac/fast/forms/box-shadow-override-expected.png:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.checksum:
  • platform/mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/encoding-test-expected.checksum:
  • platform/mac/fast/forms/encoding-test-expected.png:
  • platform/mac/fast/forms/encoding-test-expected.txt:
  • platform/mac/fast/forms/fieldset-align-expected.checksum:
  • platform/mac/fast/forms/fieldset-align-expected.png:
  • platform/mac/fast/forms/fieldset-align-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.checksum:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/input-align-expected.checksum:
  • platform/mac/fast/forms/input-align-expected.png:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.checksum:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.checksum:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-disabled-expected.checksum:
  • platform/mac/fast/forms/input-appearance-disabled-expected.png:
  • platform/mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.checksum:
  • platform/mac/fast/forms/input-appearance-focus-expected.png:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.checksum:
  • platform/mac/fast/forms/input-appearance-height-expected.png:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.checksum:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.checksum:
  • platform/mac/fast/forms/input-appearance-readonly-expected.png:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.checksum:
  • platform/mac/fast/forms/input-appearance-selection-expected.png:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-visibility-expected.checksum:
  • platform/mac/fast/forms/input-appearance-visibility-expected.png:
  • platform/mac/fast/forms/input-appearance-visibility-expected.txt:
  • platform/mac/fast/forms/input-appearance-width-expected.checksum:
  • platform/mac/fast/forms/input-appearance-width-expected.png:
  • platform/mac/fast/forms/input-appearance-width-expected.txt:
  • platform/mac/fast/forms/input-baseline-expected.checksum:
  • platform/mac/fast/forms/input-baseline-expected.png:
  • platform/mac/fast/forms/input-baseline-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.checksum:
  • platform/mac/fast/forms/input-disabled-color-expected.png:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.checksum:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-paste-undo-expected.checksum:
  • platform/mac/fast/forms/input-paste-undo-expected.png:
  • platform/mac/fast/forms/input-paste-undo-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.checksum:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.checksum:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.png:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/input-readonly-empty-expected.checksum:
  • platform/mac/fast/forms/input-readonly-empty-expected.png:
  • platform/mac/fast/forms/input-readonly-empty-expected.txt:
  • platform/mac/fast/forms/input-spaces-expected.checksum:
  • platform/mac/fast/forms/input-spaces-expected.png:
  • platform/mac/fast/forms/input-spaces-expected.txt:
  • platform/mac/fast/forms/input-table-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.checksum:
  • platform/mac/fast/forms/input-text-click-inside-expected.png:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-click-outside-expected.checksum:
  • platform/mac/fast/forms/input-text-click-outside-expected.png:
  • platform/mac/fast/forms/input-text-click-outside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.checksum:
  • platform/mac/fast/forms/input-text-double-click-expected.png:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.checksum:
  • platform/mac/fast/forms/input-text-drag-down-expected.png:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.checksum:
  • platform/mac/fast/forms/input-text-option-delete-expected.png:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.checksum:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.checksum:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/input-text-word-wrap-expected.checksum:
  • platform/mac/fast/forms/input-text-word-wrap-expected.png:
  • platform/mac/fast/forms/input-text-word-wrap-expected.txt:
  • platform/mac/fast/forms/input-type-change2-expected.checksum:
  • platform/mac/fast/forms/input-type-change2-expected.png:
  • platform/mac/fast/forms/input-type-change2-expected.txt:
  • platform/mac/fast/forms/input-type-text-min-width-expected.checksum:
  • platform/mac/fast/forms/input-type-text-min-width-expected.png:
  • platform/mac/fast/forms/input-type-text-min-width-expected.txt:
  • platform/mac/fast/forms/input-value-expected.checksum:
  • platform/mac/fast/forms/input-value-expected.png:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/forms/input-width-expected.checksum:
  • platform/mac/fast/forms/input-width-expected.png:
  • platform/mac/fast/forms/input-width-expected.txt:
  • platform/mac/fast/forms/isindex-placeholder-expected.checksum:
  • platform/mac/fast/forms/isindex-placeholder-expected.png:
  • platform/mac/fast/forms/isindex-placeholder-expected.txt:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
  • platform/mac/fast/forms/menulist-clip-expected.checksum:
  • platform/mac/fast/forms/menulist-clip-expected.png:
  • platform/mac/fast/forms/menulist-narrow-width-expected.checksum:
  • platform/mac/fast/forms/menulist-narrow-width-expected.png:
  • platform/mac/fast/forms/menulist-option-wrap-expected.checksum:
  • platform/mac/fast/forms/menulist-option-wrap-expected.png:
  • platform/mac/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/mac/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/mac/fast/forms/negativeLineHeight-expected.checksum:
  • platform/mac/fast/forms/negativeLineHeight-expected.png:
  • platform/mac/fast/forms/negativeLineHeight-expected.txt:
  • platform/mac/fast/forms/password-placeholder-expected.checksum:
  • platform/mac/fast/forms/password-placeholder-expected.png:
  • platform/mac/fast/forms/password-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.checksum:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.png:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.checksum:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.checksum:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.png:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/mac/fast/forms/placeholder-set-value-expected.checksum:
  • platform/mac/fast/forms/placeholder-set-value-expected.png:
  • platform/mac/fast/forms/placeholder-set-value-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.checksum:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.checksum:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.checksum:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.png:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.checksum:
  • platform/mac/fast/forms/search-rtl-expected.png:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/search-transformed-expected.checksum:
  • platform/mac/fast/forms/search-transformed-expected.png:
  • platform/mac/fast/forms/search-transformed-expected.txt:
  • platform/mac/fast/forms/search-zoomed-expected.checksum:
  • platform/mac/fast/forms/search-zoomed-expected.png:
  • platform/mac/fast/forms/search-zoomed-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.checksum:
  • platform/mac/fast/forms/searchfield-heights-expected.png:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/forms/select-baseline-expected.checksum:
  • platform/mac/fast/forms/select-baseline-expected.png:
  • platform/mac/fast/forms/select-style-expected.checksum:
  • platform/mac/fast/forms/select-style-expected.png:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.checksum:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/textAreaLineHeight-expected.checksum:
  • platform/mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/mac/fast/forms/textAreaLineHeight-expected.txt:
  • platform/mac/fast/forms/textarea-align-expected.checksum:
  • platform/mac/fast/forms/textarea-align-expected.png:
  • platform/mac/fast/forms/textarea-align-expected.txt:
  • platform/mac/fast/forms/textarea-rows-cols-expected.checksum:
  • platform/mac/fast/forms/textarea-rows-cols-expected.png:
  • platform/mac/fast/forms/textarea-rows-cols-expected.txt:
  • platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
  • platform/mac/fast/forms/textarea-scroll-height-expected.png:
  • platform/mac/fast/forms/textarea-scroll-height-expected.txt:
  • platform/mac/fast/forms/textarea-scrollbar-expected.checksum:
  • platform/mac/fast/forms/textarea-scrollbar-expected.png:
  • platform/mac/fast/forms/textarea-scrollbar-expected.txt:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.checksum:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.png:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/mac/fast/forms/textarea-setinnerhtml-expected.checksum:
  • platform/mac/fast/forms/textarea-setinnerhtml-expected.png:
  • platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/mac/fast/forms/textarea-width-expected.checksum:
  • platform/mac/fast/forms/textarea-width-expected.png:
  • platform/mac/fast/forms/textarea-width-expected.txt:
  • platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum:
  • platform/mac/fast/forms/textfield-drag-into-disabled-expected.png:
  • platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.checksum:
  • platform/mac/fast/forms/textfield-outline-expected.png:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.checksum:
  • platform/mac/fast/forms/textfield-overflow-expected.png:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/frames/content-opacity-1-expected.checksum:
  • platform/mac/fast/frames/content-opacity-1-expected.png:
  • platform/mac/fast/frames/content-opacity-2-expected.checksum:
  • platform/mac/fast/frames/content-opacity-2-expected.png:
  • platform/mac/fast/inline/long-wrapped-line-expected.checksum:
  • platform/mac/fast/inline/long-wrapped-line-expected.png:
  • platform/mac/fast/invalid/residual-style-expected.txt:
  • platform/mac/fast/layers/normal-flow-hit-test-expected.png:
  • platform/mac/fast/layers/opacity-transforms-expected.png:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.checksum:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.png:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/mac/fast/overflow/overflow-x-y-expected.checksum:
  • platform/mac/fast/overflow/overflow-x-y-expected.png:
  • platform/mac/fast/overflow/overflow-x-y-expected.txt:
  • platform/mac/fast/parser/comment-in-textarea-expected.checksum:
  • platform/mac/fast/parser/comment-in-textarea-expected.png:
  • platform/mac/fast/parser/comment-in-textarea-expected.txt:
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.checksum:
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.png:
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.checksum:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.png:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/mac/fast/reflections/reflection-masks-expected.png:
  • platform/mac/fast/reflections/reflection-overflow-hidden-expected.png:
  • platform/mac/fast/repaint/4776765-expected.png:
  • platform/mac/fast/repaint/change-transform-expected.png:
  • platform/mac/fast/repaint/delete-into-nested-block-expected.png:
  • platform/mac/fast/repaint/fixed-expected.checksum:
  • platform/mac/fast/repaint/fixed-expected.png:
  • platform/mac/fast/repaint/outline-child-repaint-expected.png:
  • platform/mac/fast/repaint/outline-repaint-glitch-expected.png:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/repaint/search-field-cancel-expected.checksum:
  • platform/mac/fast/repaint/search-field-cancel-expected.png:
  • platform/mac/fast/repaint/search-field-cancel-expected.txt:
  • platform/mac/fast/repaint/selected-replaced-expected.png:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.checksum:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.png:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/mac/fast/repaint/table-outer-border-expected.checksum:
  • platform/mac/fast/repaint/table-outer-border-expected.png:
  • platform/mac/fast/repaint/transform-absolute-child-expected.png:
  • platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/mac/fast/repaint/transform-relative-position-expected.png:
  • platform/mac/fast/repaint/transform-repaint-descendants-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-expected.checksum:
  • platform/mac/fast/replaced/replaced-breaking-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.checksum:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.checksum:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.png:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/mac/fast/replaced/width100percent-textarea-expected.checksum:
  • platform/mac/fast/replaced/width100percent-textarea-expected.png:
  • platform/mac/fast/replaced/width100percent-textarea-expected.txt:
  • platform/mac/fast/replaced/width100percent-textfield-expected.checksum:
  • platform/mac/fast/replaced/width100percent-textfield-expected.png:
  • platform/mac/fast/replaced/width100percent-textfield-expected.txt:
  • platform/mac/fast/runin/generated-expected.checksum:
  • platform/mac/fast/runin/generated-expected.png:
  • platform/mac/fast/table/003-expected.checksum:
  • platform/mac/fast/table/003-expected.png:
  • platform/mac/fast/table/003-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-expected.checksum:
  • platform/mac/fast/table/colspanMinWidth-expected.png:
  • platform/mac/fast/table/colspanMinWidth-expected.txt:
  • platform/mac/fast/table/spanOverlapRepaint-expected.checksum:
  • platform/mac/fast/table/spanOverlapRepaint-expected.png:
  • platform/mac/fast/table/spanOverlapRepaint-expected.txt:
  • platform/mac/fast/table/text-field-baseline-expected.checksum:
  • platform/mac/fast/table/text-field-baseline-expected.png:
  • platform/mac/fast/table/text-field-baseline-expected.txt:
  • platform/mac/fast/table/vertical-align-baseline-expected.checksum:
  • platform/mac/fast/table/vertical-align-baseline-expected.png:
  • platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.checksum:
  • platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.png:
  • platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.checksum:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/fast/transforms/transform-on-inline-expected.png:
  • platform/mac/fast/transforms/transform-table-row-expected.png:
  • platform/mac/fast/transforms/transformed-caret-expected.png:
  • platform/mac/fast/transforms/transformed-document-element-expected.png:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.checksum:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac/fonts/serif-expected.checksum:
  • platform/mac/fonts/serif-expected.png:
  • platform/mac/http/tests/navigation/anchor-frames-expected.checksum:
  • platform/mac/http/tests/navigation/anchor-frames-expected.png:
  • platform/mac/http/tests/navigation/anchor-frames-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.checksum:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-01-t-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.checksum:
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
  • platform/mac/svg/batik/paints/patternRegions-expected.checksum:
  • platform/mac/svg/batik/paints/patternRegions-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textOnPath-expected.checksum:
  • platform/mac/svg/batik/text/textOnPath-expected.png:
  • platform/mac/svg/batik/text/verticalText-expected.checksum:
  • platform/mac/svg/batik/text/verticalText-expected.png:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.checksum:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/mac/svg/carto.net/window-expected.checksum:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.checksum:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.png:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.checksum:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.checksum:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.png:
  • platform/mac/svg/custom/gradient-stroke-width-expected.checksum:
  • platform/mac/svg/custom/gradient-stroke-width-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/custom/js-late-marker-and-object-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-marker-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-marker-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-marker-creation-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/mac/svg/custom/marker-changes-expected.checksum:
  • platform/mac/svg/custom/marker-changes-expected.png:
  • platform/mac/svg/custom/marker-child-changes-expected.checksum:
  • platform/mac/svg/custom/marker-child-changes-expected.png:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.checksum:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.png:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.checksum:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.png:
  • platform/mac/svg/custom/path-bad-data-expected.checksum:
  • platform/mac/svg/custom/path-bad-data-expected.png:
  • platform/mac/svg/custom/pattern-rotate-expected.checksum:
  • platform/mac/svg/custom/pattern-rotate-expected.png:
  • platform/mac/svg/custom/pointer-events-path-expected.checksum:
  • platform/mac/svg/custom/pointer-events-path-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.checksum:
  • platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
  • platform/mac/svg/custom/use-elementInstance-event-target-expected.checksum:
  • platform/mac/svg/custom/use-elementInstance-event-target-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.checksum:
  • platform/mac/svg/hixie/mixed/003-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/svg/text/text-fonts-01-t-expected.checksum:
  • platform/mac/svg/text/text-fonts-01-t-expected.png:
  • platform/mac/svg/text/text-path-01-b-expected.checksum:
  • platform/mac/svg/text/text-path-01-b-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-07-t-expected.checksum:
  • platform/mac/svg/text/text-text-07-t-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.png:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug194024-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug194024-expected.png:
  • platform/mac/tables/mozilla/bugs/bug194024-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.png:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.png:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30559-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug30559-expected.png:
  • platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.png:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.png:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.png:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.png:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.png:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.png:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.png:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/mac/tables/mozilla/dom/tableDom-expected.checksum:
  • platform/mac/tables/mozilla/dom/tableDom-expected.png:
  • platform/mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/mac/tables/mozilla/other/move_row-expected.checksum:
  • platform/mac/tables/mozilla/other/move_row-expected.png:
  • platform/mac/tables/mozilla/other/move_row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.checksum:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/mac/transitions/transition-drt-api-expected.png:
  • svg/custom/svg-fonts-in-text-controls-expected.txt:
15:37 Changeset [44746] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-06-16 Simon Fraser <simon.fraser@apple.com>

No Review

Fix code inside an #ifdef that draws the video framerate.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::paint):
15:28 Changeset [44745] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-16 Sam Weinig <sam@webkit.org>

Fix windows build.

  • jit/JIT.cpp: (JSC::JIT::JIT):
15:28 Changeset [44744] by jianli@chromium.org
  • 3 edits in trunk/WebCore

2009-06-16 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 26456: Hook up V8 bindings for Worker's importScripts functionality.
https://bugs.webkit.org/show_bug.cgi?id=26456

  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WorkerCustom.cpp: Fixed missing exception code handling in Worker constructor for V8 bindings. (WebCore::CALLBACK_FUNC_DECL):
15:20 Changeset [44743] by kmccullough@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-06-16 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Initialize m_bytecodeIndex to -1 in JIT, and correctly initialize
it for each type of stub using the return address to find the correct
offset.

  • jit/JIT.cpp: (JSC::JIT::JIT):
  • jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdSelfList): (JSC::JIT::compileGetByIdProtoList): (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compileCTIMachineTrampolines): (JSC::JIT::compilePatchGetArrayLength):
  • jit/JITStubCall.h: (JSC::JITStubCall::call):
15:19 Changeset [44742] by cmarrin@apple.com
  • 1 edit
    35 adds in trunk/WebKitSite/specs/CSSVisualEffects

Added spec directories from http://dev.w3.org/cvsweb/csswg/
which is where they will live. We will edit them here and
then push them to the W3C cvs server.

15:09 Changeset [44741] by cmarrin@apple.com
  • 2 edits
    12 deletes in trunk/WebKitSite/specs/CSSVisualEffects

Removed all the specs because they are stale


index.html: Redirected to point at w3c site

14:55 Changeset [44740] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

2009-06-16 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Maciej Stachowiak.

Update of https://bugs.webkit.org/show_bug.cgi?id=26353.
Provide an assignment operator to avoid improper reference
counts on the Cairo font objects. This brings the Windows
Cairo port in line with the GTK+ port.

14:35 Changeset [44739] by bweinstein@apple.com
  • 2 edits in trunk/WebKit/win

2009-06-16 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.


Switch Control+Mousewheel Zooming definitions to match other browsers on Windows.
Control+Mousewheel-Down now zooms out, Control+Mousewheel-Up now zooms in.
https://bugs.webkit.org/show_bug.cgi?id=25875.
<rdar://problem/6903976>

  • WebView.cpp: (WebView::mouseWheel):
14:08 Changeset [44738] by eric.carlson@apple.com
  • 6 edits in trunk/WebCore

2009-06-16 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Fix for <rdar://problem/6890126> Theme code should fetch the MediaControlElementType from
the MediaControlInputElement, rather than computing it again

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::percentLoaded): New, utility function for controller implementation.
  • html/HTMLMediaElement.h:
  • rendering/MediaControlElements.h: (WebCore::MediaControlInputElement::displayType): New, return m_displayType.
  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart): Stop using MediaPlayer object, get button state from the button itself and get movie state from HTMLMediaElement.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaMuteButton): Get state from button instead of MediaPlayer. (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto.
14:00 Changeset [44737] by jianli@chromium.org
  • 12 edits in trunk/WebCore

2009-06-16 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Bug 26450: Rename values of enum RedirectOriginCheck to make them
clearer.
https://bugs.webkit.org/show_bug.cgi?id=26450

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::create): (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::willSendRequest):
  • loader/DocumentThreadableLoader.h:
  • loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::create): (WebCore::ThreadableLoader::loadResourceSynchronously):
  • loader/ThreadableLoader.h:
  • workers/Worker.cpp: (WebCore::Worker::Worker):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::loadResourceSynchronously): (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
  • loader/WorkerThreadableLoader.h: (WebCore::WorkerThreadableLoader::create):
  • workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously):
  • workers/WorkerScriptLoader.h: (WebCore::WorkerContext::importScripts):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously):
13:36 Changeset [44736] by bdakin@apple.com
  • 84 edits in branches/WWDC-2009-branch/LayoutTests

2009-06-15 Beth Dakin <bdakin@apple.com>

Rubber-stamped by Geoff Garen.

Updating tests on the branch from when we backed out the text
control metrics change. This only covers the editing directory.

  • platform/mac/editing/deleting/5168598-expected.checksum:
  • platform/mac/editing/deleting/5168598-expected.png:
  • platform/mac/editing/deleting/5168598-expected.txt:
  • platform/mac/editing/deleting/delete-to-select-table-expected.checksum:
  • platform/mac/editing/deleting/delete-to-select-table-expected.png:
  • platform/mac/editing/deleting/type-delete-after-quote-expected.checksum:
  • platform/mac/editing/deleting/type-delete-after-quote-expected.png:
  • platform/mac/editing/inserting/4960120-1-expected.checksum:
  • platform/mac/editing/inserting/4960120-1-expected.png:
  • platform/mac/editing/inserting/4960120-1-expected.txt:
  • platform/mac/editing/inserting/5418891-expected.checksum:
  • platform/mac/editing/inserting/5418891-expected.png:
  • platform/mac/editing/inserting/5607069-2-expected.checksum:
  • platform/mac/editing/inserting/5607069-2-expected.png:
  • platform/mac/editing/inserting/5607069-2-expected.txt:
  • platform/mac/editing/inserting/5607069-3-expected.checksum:
  • platform/mac/editing/inserting/5607069-3-expected.png:
  • platform/mac/editing/inserting/5607069-3-expected.txt:
  • platform/mac/editing/inserting/before-after-input-element-expected.checksum:
  • platform/mac/editing/inserting/before-after-input-element-expected.png:
  • platform/mac/editing/inserting/before-after-input-element-expected.txt:
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.checksum:
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.png:
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
  • platform/mac/editing/pasteboard/4806874-expected.checksum:
  • platform/mac/editing/pasteboard/4806874-expected.png:
  • platform/mac/editing/pasteboard/4806874-expected.txt:
  • platform/mac/editing/pasteboard/5387578-expected.checksum:
  • platform/mac/editing/pasteboard/5387578-expected.png:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.checksum:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/input-field-1-expected.checksum:
  • platform/mac/editing/pasteboard/input-field-1-expected.png:
  • platform/mac/editing/pasteboard/input-field-1-expected.txt:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.checksum:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.png:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/mac/editing/selection/3690703-2-expected.checksum:
  • platform/mac/editing/selection/3690703-2-expected.png:
  • platform/mac/editing/selection/3690703-2-expected.txt:
  • platform/mac/editing/selection/3690703-expected.checksum:
  • platform/mac/editing/selection/3690703-expected.png:
  • platform/mac/editing/selection/3690703-expected.txt:
  • platform/mac/editing/selection/3690719-expected.checksum:
  • platform/mac/editing/selection/3690719-expected.png:
  • platform/mac/editing/selection/3690719-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.checksum:
  • platform/mac/editing/selection/4895428-3-expected.png:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.checksum:
  • platform/mac/editing/selection/4975120-expected.png:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/5136696-expected.checksum:
  • platform/mac/editing/selection/5136696-expected.png:
  • platform/mac/editing/selection/5136696-expected.txt:
  • platform/mac/editing/selection/5213963-expected.checksum:
  • platform/mac/editing/selection/5213963-expected.png:
  • platform/mac/editing/selection/5213963-expected.txt:
  • platform/mac/editing/selection/caret-rtl-2-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-2-expected.png:
  • platform/mac/editing/selection/drag-select-1-expected.checksum:
  • platform/mac/editing/selection/drag-select-1-expected.png:
  • platform/mac/editing/selection/drag-select-1-expected.txt:
  • platform/mac/editing/selection/drag-text-delay-expected.checksum:
  • platform/mac/editing/selection/drag-text-delay-expected.png:
  • platform/mac/editing/selection/drag-text-delay-expected.txt:
  • platform/mac/editing/selection/extend-by-word-002-expected.checksum:
  • platform/mac/editing/selection/extend-by-word-002-expected.png:
  • platform/mac/editing/selection/select-all-002-expected.checksum:
  • platform/mac/editing/selection/select-all-002-expected.png:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.checksum:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/editing/spelling/spellcheck-attribute-expected.checksum:
  • platform/mac/editing/spelling/spellcheck-attribute-expected.png:
  • platform/mac/editing/spelling/spellcheck-attribute-expected.txt:
13:31 Changeset [44735] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-06-16 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

Fix a UMR in WebCore::BitStack by initializing new memory to 0.
https://bugs.webkit.org/show_bug.cgi?id=26449
No new tests, covered by purify.

  • editing/TextIterator.cpp: (WebCore::BitStack::push):
13:27 Changeset [44734] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

009-06-16 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Xan Lopez.

Fixes https://bugs.webkit.org/show_bug.cgi?id=26453.
Null Cairo contextwill crash Windows Cairo build.

Test: fast/multicol/columns-shorthand-parsing.html

12:27 Changeset [44733] by pkasting@chromium.org
  • 3 edits in trunk/WebCore

2009-06-16 Peter Kasting <pkasting@google.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=26447
Fix animated GIF breakage in Cairo/wx ports.

  • platform/image-decoders/cairo/ImageDecoderCairo.cpp: (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::operator=):
  • platform/image-decoders/wx/ImageDecoderWx.cpp: (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::operator=):
12:26 Changeset [44732] by simon.fraser@apple.com
  • 4 edits in trunk/WebKitLibraries

2009-06-16 Simon Fraser <simon.fraser@apple.com>

Rubber-stamped by Anders Carlsson.

Update WebKitSystemInterface for <rdar://problem/6937882>.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
11:51 Changeset [44731] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-16 Xan Lopez <xlopez@igalia.com>

Disable another new test.

  • platform/gtk/Skipped:
11:36 Changeset [44730] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-06-16 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by John Sullivan

<rdar://problem/6937882>

Tweak "time remaining" and "time elapsed" fields in the overlay video controller.

  • css/mediaControlsQT.css:
11:36 Changeset [44729] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not use g_assert_cmpint to test for NULL pointer, just
g_assert.

  • tests/testnetworkrequest.c: (test_network_request_create_destroy):
11:27 Changeset [44728] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-16 Xan Lopez <xlopez@igalia.com>

editing/deleting/4875189.html was changed from pixel to
dumpAsText, so remove it from Skipped list.

  • platform/gtk/Skipped:
11:19 Changeset [44727] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26437

Make the commit-log-editor match the ambient line endings in commit
messages.

  • Scripts/commit-log-editor:
11:12 Changeset [44726] by jianli@chromium.org
  • 9 edits
    2 moves
    4 adds in trunk

WebCore:

2009-06-16 Jian Li <jianli@chromium.org>

Reviewed by Adam Barth and David Levin.

Bug 26146: Change to use ThreadableLoader to load the worker script
in order to check URL origin for redirection.
https://bugs.webkit.org/show_bug.cgi?id=26146

Test: http/tests/workers/worker-redirect.html

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • workers/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::notifyFinished):
  • workers/Worker.h:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • workers/WorkerImportScriptsClient.cpp: Removed.
  • workers/WorkerImportScriptsClient.h: Removed.
  • workers/WorkerScriptLoader.cpp: Renamed from workers/WorkerImportScriptsClient.cpp. This to make it more generic so worker script loading could use it. (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously): (WebCore::WorkerScriptLoader::didFinishLoading): (WebCore::WorkerScriptLoader::didFail): (WebCore::WorkerScriptLoader::didFailRedirectCheck): (WebCore::WorkerScriptLoader::didReceiveAuthenticationCancellation): (WebCore::WorkerScriptLoader::notifyFinished):
  • workers/WorkerScriptLoader.h: Renamed from workers/WorkerImportScriptsClient.h. This to make it more generic so worker script loading could use it.
  • workers/WorkerScriptLoaderClient.h: Added.

LayoutTests:

2009-06-16 Jian Li <jianli@chromium.org>

Reviewed by Adam Barth and David Levin.

Bug 26146: Change to use ThreadableLoader to load the worker script
in order to check URL origin for redirection.
https://bugs.webkit.org/show_bug.cgi?id=26146

Add a layout test to cover the scenario that the worker script is
loaded from different redirect origin.

  • http/tests/workers/resources/worker-redirect-target.js: Added.
  • http/tests/workers/worker-redirect-expected.txt: Added.
  • http/tests/workers/worker-redirect.html: Added.
10:59 Changeset [44725] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-16 Xan Lopez <xlopez@igalia.com>

Fix typo in test name.

  • platform/gtk/Skipped:
10:48 Changeset [44724] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-16 Xan Lopez <xlopez@igalia.com>

Disable new tests.

  • platform/gtk/Skipped:
10:10 BuildingOnWindows edited by bfulgham@gmail.com
(diff)
10:10 BuildingOnWindows edited by bfulgham@gmail.com
(diff)
09:59 BuildingOnWindows edited by aroben@apple.com
Add instructions for rebasing libphp4 on Vista (diff)
09:44 Changeset [44723] by bfulgham@webkit.org
  • 4 edits in trunk

009-06-16 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Darin Adler.

Use consistent GUID comparison functions.
https://bugs.webkit.org/show_bug.cgi?id=26427

07:09 Changeset [44722] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix compiler warning.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_class_init):
07:09 Changeset [44721] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Remove dummy AtkStreamableContent implementation.

It's completely empty, we'll add it back (and conditionally
instead of unconditionally) when it does something.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (GetAtkInterfaceTypeFromWAIType): (getInterfaceMaskFromObject):
06:32 Changeset [44720] by xan@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update GtkLauncher to recent API changes in the progress property,
which now goes from 0.0 to 1.0.

  • GtkLauncher/main.c:
01:40 Changeset [44719] by hausmann@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-06-16 David Boddie <dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Doc: Fixed QWebPage::forwardUnsupportedContent documentation and added
more information about Web plugins.

01:40 Changeset [44718] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-06-16 Morten Engvoldsen <morten.engvoldsen@nokia.com>

Reviewed by Ariya Hidayat.

Clearifying QWebFrame docs

Adding docs to toHtml() and toPlainText()

01:10 Changeset [44717] by abarth@webkit.org
  • 1 edit in trunk/WebKitTools/ChangeLog

Fix ChangeLog typo.

01:06 Changeset [44716] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Darin Alder.

https://bugs.webkit.org/show_bug.cgi?id=26000

Teach prepare-ChangeLog to match the line ends that are already present
in ChangeLog files. This helps folks whose use cygwin perl with CR LF
line endings on Windows.

Also, teach prepare-ChangeLog to normalize backslashes in paths. This
helps folks who use Windows SVN prepare correct ChangeLogs.

  • Scripts/prepare-ChangeLog:
00:35 Changeset [44715] by mrowe@apple.com
  • 5 edits
    5 copies in trunk

Roll over some ChangeLog files.

00:35 Changeset [44714] by mrowe@apple.com
  • 1 edit
    1 add in trunk/WebKitTools

Add a script to automate the rolling over of ChangeLog files when they grow too large.

Reviewed by Oliver Hunt.

  • Scripts/roll-over-ChangeLogs: Added.

06/15/09:

23:52 Changeset [44713] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-06-15 Gavin Barraclough <barraclough@apple.com>

Rubber Stamped by Sam Weinig.

Rename PatchBuffer to LinkBuffer. Previously our terminology has been a little
mixed up, but we have decided to fix on refering to the process that takes place
at the end of code generation as 'linking', and on any modifications that take
place later (and once the code has potentially already been executed) as 'patching'.

However, the term 'PatchBuffer' is already in use, and needs to be repurposed.

To try to minimize confusion, we're going to switch the terminology over in stages,
so for now we'll refer to later modifications as 'repatching'. This means that the
new 'PatchBuffer' has been introduced with the name 'RepatchBuffer' instead.

This patch renames the old 'PatchBuffer' to 'LinkBuffer'. We'll leave ToT in this
state for a week or so to try to avoid to much overlap of the meaning of the term
'PatchBuffer', then will come back and rename 'RepatchBuffer'.

  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::LinkBuffer::LinkBuffer): (JSC::AbstractMacroAssembler::LinkBuffer::~LinkBuffer):
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::compile):
23:17 Changeset [44712] by adele@apple.com
  • 7 edits in trunk

WebCore:

2009-06-15 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): When inserting a newline after the blockquote, we don't want to apply the original style after the insertion.

LayoutTests:

2009-06-15 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Updating test for:
<rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros

This test case covered inserting a newline after a blockquote, but outside of the blockquote. I added some
text insertion to verify that the newline doesn't get any old styles copied from the blockquote.

  • editing/pasteboard/5368833.html:
  • platform/mac/editing/pasteboard/5368833-expected.checksum:
  • platform/mac/editing/pasteboard/5368833-expected.png:
  • platform/mac/editing/pasteboard/5368833-expected.txt:
22:35 Changeset [44711] by barraclough@apple.com
  • 11 edits
    1 copy in trunk/JavaScriptCore

2009-06-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Having moved most of their functionality into the RepatchBuffer class,
we can simplify the CodeLocation* classes.

The CodeLocation* classes are currently a tangle of templatey and friendly
badness, burried in the middle of AbstractMacroAssembler. Having moved
the ability to repatch out into RepatchBufer they are now do-nothing wrappers
on CodePtr (MacroAssemblerCodePtr), that only exist to provide type-safety.

Simplify the code, and move them off into their own header.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::PatchBuffer::patch):
  • assembler/CodeLocation.h: Copied from assembler/AbstractMacroAssembler.h. (JSC::CodeLocationCommon::CodeLocationCommon): (JSC::CodeLocationInstruction::CodeLocationInstruction): (JSC::CodeLocationLabel::CodeLocationLabel): (JSC::CodeLocationJump::CodeLocationJump): (JSC::CodeLocationCall::CodeLocationCall): (JSC::CodeLocationNearCall::CodeLocationNearCall): (JSC::CodeLocationDataLabel32::CodeLocationDataLabel32): (JSC::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr): (JSC::CodeLocationCommon::instructionAtOffset): (JSC::CodeLocationCommon::labelAtOffset): (JSC::CodeLocationCommon::jumpAtOffset): (JSC::CodeLocationCommon::callAtOffset): (JSC::CodeLocationCommon::nearCallAtOffset): (JSC::CodeLocationCommon::dataLabelPtrAtOffset): (JSC::CodeLocationCommon::dataLabel32AtOffset):
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::operator!):
  • bytecode/CodeBlock.h: (JSC::getStructureStubInfoReturnLocation): (JSC::getCallLinkInfoReturnLocation): (JSC::getMethodCallLinkInfoReturnLocation):
  • bytecode/Instruction.h:
  • bytecode/JumpTable.h: (JSC::StringJumpTable::ctiForValue): (JSC::SimpleJumpTable::ctiForValue):
  • bytecode/StructureStubInfo.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitCatch):
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION): (JSC::JITStubs::getPolymorphicAccessStructureListSlot):
22:03 Changeset [44710] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-06-15 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove outdated comment.

  • bindings/js/JSDOMWindowBase.h:
21:58 Changeset [44709] by weinig@apple.com
  • 6 edits in trunk/WebCore

2009-06-15 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Bring CustomGetPropertyNames more inline with the other
extended attributes prefixed with Custom, by making it
require a complete implementation.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getPropertyNames):
  • bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::getPropertyNames):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::getPropertyNames):
  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::getPropertyNames):
  • bindings/scripts/CodeGeneratorJS.pm:
21:04 Changeset [44708] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-06-15 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove commented out ondataunavailable attribute event listener which
has now been removed from HTML 5.

  • page/DOMWindow.idl:
21:02 Changeset [44707] by weinig@apple.com
  • 6 edits in trunk/WebCore

2009-06-15 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Move entire custom implementation of getOwnPropertySlot and put
for JSDOMWindow into JSDOMWindowCustom, eliminating the bit in
JSDOMWindowBase.

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter): (WebCore::childFrameGetter): (WebCore::indexGetter): (WebCore::namedItemGetter): (WebCore::JSDOMWindow::getOwnPropertySlot): (WebCore::JSDOMWindow::put): (WebCore::JSDOMWindow::getPropertyAttributes):
  • bindings/js/JSDOMWindowCustom.h:
  • page/DOMWindow.idl:
21:00 Changeset [44706] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-06-15 Jeremy Orlow (jorlow@chromium.org)

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26356
Define the functions in V8CustomBindings.h. "Forgot" this in my
earlier patch since it wasn't fully upstreamed when I wrote the
patch.

  • bindings/v8/custom/V8CustomBinding.h:
20:01 Changeset [44705] by barraclough@apple.com
  • 11 edits in trunk/JavaScriptCore

2009-06-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Having introduced the RepatchBuffer, ProcessorReturnAddress is now a do-nothing
wrapper around ReturnAddressPtr. Remove it. In tugging on this piece of string
it made sense to roll out the use of ReturnAddressPtr a little further into
JITStubs (which had always been the intention).

No performance impact.

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToFunction): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkNearCallerToTrampoline):
  • assembler/MacroAssemblerCodeRef.h: (JSC::ReturnAddressPtr::ReturnAddressPtr):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::getStubInfo): (JSC::CodeBlock::getCallLinkInfo): (JSC::CodeBlock::getMethodCallLinkInfo): (JSC::CodeBlock::getBytecodeIndex):
  • interpreter/Interpreter.cpp: (JSC::bytecodeOffsetForPC):
  • jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress):
  • jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compilePatchGetArrayLength):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::StackHack::StackHack): (JSC::returnToThrowTrampoline): (JSC::throwStackOverflowError): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h: (JSC::): (JSC::JITStackFrame::returnAddressSlot):
  • runtime/JSGlobalData.h:
19:13 Changeset [44704] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-06-15 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by Adam Treat.

Support the back/forward/stop/refresh multimedia keys and accept the
event when handling backspace and shift backspace as we should.

  • Api/qwebpage.cpp: (QWebPagePrivate::keyPressEvent):
18:36 Changeset [44703] by mitz@apple.com
  • 2 edits in trunk/WebCore

2009-06-15 Andre Boule <aboule@apple.com>

Reviewed by Cameron Zwarich and Dan Bernstein.

  • fix <rdar://problem/6967975> crash with NSString drawAtPoint

No test possible because this crash can only occur if the client uses
WebKit text drawing without ever using WebCore text, and DumpRenderTree
cannot do either.

  • platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): Null-check

gFontPlatformDataCache.

18:27 Changeset [44702] by simon.fraser@apple.com
  • 11 edits in trunk

2009-06-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

<rdar://problem/6974857>

Define ENABLE_3D_RENDERING and WTF_USE_ACCELERATED_COMPOSITING when building on 10.6.
Move the ENABLE_3D_RENDERING switch from config.h and WebKitPrefix.h to wtf/Platform.h

18:12 Changeset [44701] by eric@webkit.org
  • 6 edits in trunk/WebCore

2009-06-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Make WebInspector's console evaluation/completion asynchronous.
This way of evaluation allows serializing calls between
InspectorController and its frontend.

https://bugs.webkit.org/show_bug.cgi?id=26350

  • inspector/front-end/Console.js: (WebInspector.Console.prototype.completions): (WebInspector.Console.prototype._reportCompletions): (WebInspector.Console.prototype._evalInInspectedWindow): (WebInspector.Console.prototype._enterKeyPressed.printResult): (WebInspector.Console.prototype._enterKeyPressed):
  • inspector/front-end/DatabaseQueryView.js:
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.evaluateExpression):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): (WebInspector.TextPrompt.prototype._completionsReady):
17:26 Changeset [44700] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-06-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Move repatching methods into a set of methods on a class. This will allow us to
coallesce memory reprotection calls. Really, we want this class to be called
PatchBuffer, we want the class PatchBuffer to be called LinkBuffer, we want both
to be memblers of MacroAssembler rather then AbstractMacroAssembler, we don't
want the CodeLocationFoo types anymore (they are now only really there to provide
type safety, and that is completely undermined by the way we use offsets). Then
the link & patch buffers should delegate the actual patching calls to the
architecture-specific layer of the MacroAssembler. Landing all these changes as a
sequence of patches.

No performance impact.

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall): (JSC::AbstractMacroAssembler::CodeLocationNearCall::CodeLocationNearCall): (JSC::AbstractMacroAssembler::CodeLocationNearCall::calleeReturnAddressValue): (JSC::AbstractMacroAssembler::RepatchBuffer::RepatchBuffer): (JSC::AbstractMacroAssembler::RepatchBuffer::relink): (JSC::AbstractMacroAssembler::RepatchBuffer::repatch): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToFunction): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkNearCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::repatchLoadPtrToLEA):
  • jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress): (JSC::JIT::unlinkCall): (JSC::JIT::linkCall):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchMethodCallProto): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
16:19 Web Inspector edited by timothy@apple.com
(diff)
16:19 Web Inspector edited by timothy@apple.com
(diff)
16:16 Changeset [44699] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-06-15 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6967569>
CrashTracer: 15 crashes in Safari at com.apple.WebKit • WebKit::NetscapePluginHostManager::didCreateWindow + 85


Make sure to remove the entry from the plug-in host map so we won't end up with an entry that has a null value.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPackage):
16:10 Changeset [44698] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2009-06-15 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

Reverted previous change as the old behavior was correct for heavy view.

  • inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
15:39 Changeset [44697] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2009-06-15 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/6968125> Profiler 'Call' count is incorrect in Heavy
view (26418)

  • Removed code that copied call and time data from it's ancestor.
  • inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
15:21 Changeset [44696] by cmarrin@apple.com
  • 5 edits
    2 adds in trunk

Reviewed by Simon Fraser <simon.fraser@apple.com>.

https://bugs.webkit.org/show_bug.cgi?id=26163

Added logic to updateTransitions similar to that in updateKeyframeAnimations
which detects and removes stale transitions.

Test: transitions/cancel-transition.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::ImplicitAnimation):
  • page/animation/ImplicitAnimation.h: (WebCore::ImplicitAnimation::active): (WebCore::ImplicitAnimation::setActive):
14:18 Changeset [44695] by mitz@apple.com
  • 11 edits in trunk

WebCore:

Reviewed by Tim Hatcher.

  • allow the source code font in the Web Inspector to be customized
  • css/view-source.css: Use the default monospace font family and size

for source code.

  • inspector/front-end/inspector.css: Use the default monospace font

family and size for console I/O.

WebKit/mac:

Reviewed by Tim Hatcher.

  • make the source code font in the Web Inspector match Mac defaults
  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Set the default monospace font to 11px Menlo, except on Leopard and Tiger where it is 10px Monaco.

WebKit/win:

Reviewed by Tim Hatcher.

  • use a nice source code font in the Web Inspector
  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::createPage): Set the default monospace font to

13px Courier New, which is the default source code font in Visual
Studio.

LayoutTests:

Reviewed by Tim Hatcher.

  • updated results after changing source view to use the default monospace font family and size
  • platform/mac/fast/frames/viewsource-attribute-expected.checksum:
  • platform/mac/fast/frames/viewsource-attribute-expected.png:
  • platform/mac/fast/frames/viewsource-attribute-expected.txt:
13:25 Changeset [44694] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-15 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=26377
[GTK] Confusion about range of 'progress' property

Range for the progress property is 0.0 .. 1.0, don't multiply it
by 100 to make it a percentage.

  • webkit/webkitwebview.cpp: (webkit_web_view_get_progress):
13:17 Changeset [44693] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-06-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Hunt & Oliver Garen.

We are currently generating two copies of the slow path for op_call for no reason. Stop that.

Originally op_call used two slow paths since the first set up the pointer to the CallLinkInfo
for use when linking. However this is now looked up using the return address (as we do for
property accesses) so the two paths are now identical.

No performance impact, reduces memory footprint.

  • bytecode/CodeBlock.h:
  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::linkCall):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase):
  • jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION):
11:39 Changeset [44692] by treat@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-06-15 Andre Pedralho <andre.pedralho@openbossa.org>

Reviewed by Adam Treat

https://bugs.webkit.org/show_bug.cgi?id=26351
Remove bool QWebHitTestResult::isScrollBar() const and make sure a null QWebHitTestResult is returned instead.

11:39 Changeset [44691] by andersca@apple.com
  • 1 edit
    16 adds in trunk/WebKitExamplePlugins

2009-06-15 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Add Core Animation movie plug-in example.


  • NetscapeCoreAnimationMoviePlugin: Added.
  • NetscapeCoreAnimationMoviePlugin/English.lproj: Added.
  • NetscapeCoreAnimationMoviePlugin/English.lproj/InfoPlist.strings: Added.
  • NetscapeCoreAnimationMoviePlugin/Info.plist: Added.
  • NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.h: Added.
  • NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.m: Added. (createImageNamed): (-[MovieControllerLayer init]): (-[MovieControllerLayer dealloc]): (-[MovieControllerLayer _playPauseButtonRect]): (-[MovieControllerLayer _sliderRect]): (-[MovieControllerLayer _sliderThumbRect]): (-[MovieControllerLayer _innerSliderRect]): (-[MovieControllerLayer _drawPlayPauseButtonInContext:]): (-[MovieControllerLayer _drawSliderInContext:]): (-[MovieControllerLayer drawInContext:]): (-[MovieControllerLayer _currentTime]): (-[MovieControllerLayer _duration]): (-[MovieControllerLayer _isPlaying]): (-[MovieControllerLayer _updateTime:]): (-[MovieControllerLayer _rateDidChange:]): (-[MovieControllerLayer _timeDidChange:]): (-[MovieControllerLayer actionForKey:]): (-[MovieControllerLayer setMovie:]): (-[MovieControllerLayer _setNewTimeForThumbCenterX:]): (-[MovieControllerLayer handleMouseDown:]): (-[MovieControllerLayer handleMouseUp:]): (-[MovieControllerLayer handleMouseDragged:]):
  • NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Added.
  • NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj: Added.
  • NetscapeCoreAnimationMoviePlugin/Pause.tiff: Added.
  • NetscapeCoreAnimationMoviePlugin/Play.tiff: Added.
  • NetscapeCoreAnimationMoviePlugin/SliderTrackCenter.tiff: Added.
  • NetscapeCoreAnimationMoviePlugin/SliderTrackLeft.tiff: Added.
  • NetscapeCoreAnimationMoviePlugin/SliderTrackRight.tiff: Added.
  • NetscapeCoreAnimationMoviePlugin/Thumb.tiff: Added.
  • NetscapeCoreAnimationMoviePlugin/main.m: Added. (NP_Initialize): (NP_GetEntryPoints): (NP_Shutdown): (NPP_New): (NPP_Destroy): (NPP_SetWindow): (NPP_NewStream): (NPP_DestroyStream): (NPP_WriteReady): (NPP_Write): (NPP_StreamAsFile): (NPP_Print): (handleMouseDown): (togglePlayPause): (handleMouseUp): (handleMouseDragged): (handleMouseEntered): (handleMouseExited): (handleKeyDown): (handleScrollEvent): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue): (NPP_SetValue):
  • NetscapeCoreAnimationMoviePlugin/test.html: Added.
11:14 Changeset [44690] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.10

Tagging 1.1.10.

08:40 Changeset [44689] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Add new symbols list for 1.1.10 release.

  • docs/webkitgtk-docs.sgml:
08:39 Changeset [44688] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Fix Since tags for the new uri and message properties.

  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_class_init):
08:38 Changeset [44687] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by and done with Tor Arne Vestbø.

Fix initialization of uninitialized members in FontFallbackListQt, leading
to random crashes when rendering text.

08:30 Changeset [44686] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Adding new documented API to the generated
documentation.

  • docs/webkitgtk-sections.txt:
07:38 Changeset [44685] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Adam Treat.

Fix the logic for disabling the fixed layout feature, when an invalid
QSize is set.

07:31 Changeset [44684] by xan@webkit.org
  • 4 edits in trunk

2009-06-15 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Version bump in preparation for 1.1.10 release.

  • configure.ac:

WebKit/gtk:

2009-06-15 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update NEWS for 1.1.10 release.

  • NEWS:
07:17 Changeset [44683] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-15 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25895
[Gtk] Segfault when deleting the last/only character in an entry if a11y is enabled

Use computeOffsetInContainerNode instead of the inline
offsetInContainerNode to return the caret offset, since the former
can handle all types of anchoring. Otherwise we'll hit an ASSERT
in some situations in debug builds, and crash.

  • editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
04:53 Changeset [44682] by hausmann@webkit.org
  • 12 edits
    2 moves in trunk/WebCore

2009-06-15 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix build break
Rename JSONObject to InspectorJSONObject

https://bugs.webkit.org/show_bug.cgi?id=26340

01:39 Changeset [44681] by vestbo@webkit.org
  • 7 edits in trunk

2009-06-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Mark Rowe.
Reviewed by Simon Hausmann.
Reviewed by Xan Lopez.

Refactor handling of options in the build-webkit script

Options are now defined in one place, and then reused when creating
the usage help text, the arguments to GetOptions(), and when passing
the options on to the underlying port-dependent build systems.

This allows the Qt port to read the defaults for the options from the
pro file (dynamically), and to pass the options on to qmake at build.

00:37 Changeset [44680] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix <https://bugs.webkit.org/show_bug.cgi?id=26312>.
Bug 26312: Multiple copies of Safari opened with WebKit nightly and Safari 3.2.3

Reviewed by Cameron Zwarich.

Skip the trampoline detection for versions of Safari < 4.0 as they don't play these
tricks, and having WebKitNightlyEnabler assume that we were in the trampoline was
preventing our LaunchServices trickery from being run. This led to fresh copies of
WebKit.app being launched when a URL or file was opened from an external application
rather than the existing instance being reused.

  • WebKitLauncher/WebKitNightlyEnabler.m:

(insideSafari4OnTigerTrampoline):
(enableWebKitNightlyBehaviour):

00:02 Changeset [44679] by vestbo@webkit.org
  • 1 edit in trunk/WebCore/platform/graphics/qt/FontFallbackListQt.cpp

Fix Qt build break after r44672

Note: See TracTimeline for information about the timeline view.