Timeline


and

06/22/09:

22:53 Changeset [44975] by ap@webkit.org

2009-06-22 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=17820

Skip layout tests for DST if the test runs not in PST/PDT.

  • fast/js/date-DST-time-cusps-expected.txt:
  • fast/js/date-big-setdate-expected.txt:
  • fast/js/resources/date-DST-time-cusps.js:
  • fast/js/resources/date-big-setdate.js:
22:44 Changeset [44974] by oliver@apple.com

Bug 26640: JSON.stringify needs to special case Boolean objects
<https://bugs.webkit.org/show_bug.cgi?id=26640>

Reviewed by Alexey Proskuryakov.

Add special case handling of the Boolean object so we match current
ES5 errata.

21:53 Changeset [44973] by simon.fraser@apple.com

2009-06-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6991146> Scrollbars in hardware layers don't change to the
inactive look in background windows

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Don't short-circuit the "painting" pass that is used to udpate control tints.
21:36 Changeset [44972] by dglazkov@chromium.org

2009-06-22 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26567
Upstream V8 bindings code generator. With this change, also added interface ancestor
traversal to IDL parser, which is necessary for V8 bindings. The traversal is used
to determine whether an interface is a Node to facilitate proper casting and storage
in V8DOMMap.

  • bindings/scripts/CodeGenerator.pm: Added parent traversal sub, needed

by V8 bindings.

  • bindings/scripts/CodeGeneratorV8.pm: Added.
  • bindings/scripts/IDLParser.pm: Modified to allow limited parsing for

parent traversal cases.

20:37 Changeset [44971] by barraclough@apple.com

2009-06-22 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Remove 'arguments' field from Register union. Having JSCell derived types in the union is
dangerous since it opens the possibility for the field to be written as a raw pointer but
then read as a JSValue. This will lead to statle data being read for the tag, which may
be dangerous. Having removed Arguments* types form Register, all arguments objects must
always explicitly be stored in the register file as JSValues.

  • interpreter/CallFrame.h: (JSC::ExecState::optionalCalleeArguments):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
  • interpreter/Register.h: (JSC::Register::):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_tear_off_arguments):
  • runtime/Arguments.h: (JSC::JSActivation::copyRegisters):
  • runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
  • runtime/JSActivation.h:
20:07 Changeset [44970] by mrowe@apple.com

Roll out r44967 as that build slave hates freedom.

20:05 Changeset [44969] by weinig@apple.com

WebCore:

2009-06-22 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Add event handler attribute getter/setters to HTMLFrameSetElement
as specified in HTML 5. These match the ones on HTMLBodyElement.

  • dom/Node.h:
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::onblur): (WebCore::HTMLFrameSetElement::setOnblur): (WebCore::HTMLFrameSetElement::onerror): (WebCore::HTMLFrameSetElement::setOnerror): (WebCore::HTMLFrameSetElement::onfocus): (WebCore::HTMLFrameSetElement::setOnfocus): (WebCore::HTMLFrameSetElement::onload): (WebCore::HTMLFrameSetElement::setOnload): (WebCore::HTMLFrameSetElement::onbeforeunload): (WebCore::HTMLFrameSetElement::setOnbeforeunload): (WebCore::HTMLFrameSetElement::onmessage): (WebCore::HTMLFrameSetElement::setOnmessage): (WebCore::HTMLFrameSetElement::onoffline): (WebCore::HTMLFrameSetElement::setOnoffline): (WebCore::HTMLFrameSetElement::ononline): (WebCore::HTMLFrameSetElement::setOnonline): (WebCore::HTMLFrameSetElement::onresize): (WebCore::HTMLFrameSetElement::setOnresize): (WebCore::HTMLFrameSetElement::onstorage): (WebCore::HTMLFrameSetElement::setOnstorage): (WebCore::HTMLFrameSetElement::onunload): (WebCore::HTMLFrameSetElement::setOnunload):
  • html/HTMLFrameSetElement.h:
  • html/HTMLFrameSetElement.idl:

LayoutTests:

2009-06-22 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Add event handler attribute getter/setters to HTMLFrameSetElement
as specified in HTML 5. These match the ones on HTMLBodyElement.

  • fast/dom/event-attribute-availability-expected.txt:
  • fast/dom/resources/event-attribute-availability.js:
18:27 Changeset [44968] by oliver@apple.com

Bug 26591: Support revivers in JSON.parse
<https://bugs.webkit.org/show_bug.cgi?id=26591>

Reviewed by Darin Adler.

Add reviver support to JSON.parse. This completes the JSON object.

18:27 Changeset [44967] by mrowe@apple.com

Update build.webkit.org config for new machine.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
18:04 Changeset [44966] by darin@apple.com

2009-06-22 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
https://bugs.webkit.org/show_bug.cgi?id=25425

  • bindings/scripts/CodeGeneratorJS.pm: Added handling for ReflectURL.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • dom/Element.cpp: (WebCore::Element::getURLAttribute): Added. For use implementing getters for ReflectURL.
  • dom/Element.h: Added getURLAttribute.
  • html/HTMLImageElement.idl: Use Reflect and ReflectURL.
17:41 Changeset [44965] by jianli@chromium.org

2009-06-22 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 26626: Make WorkerContextExecutionProxy::toV8Object handle exception
objects.
https://bugs.webkit.org/show_bug.cgi?id=26626

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object):
16:24 Changeset [44964] by hyatt@apple.com

2009-06-22 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig.

Add RenderDataGrid to the build. Give it some basic default styling (that more or less matches a listbox). It has a default size
of 300x150.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • css/html4.css:
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::createRenderer):
  • html/HTMLDataGridElement.h:
  • html/HTMLDataGridElement.idl:
  • rendering/RenderDataGrid.cpp: Added. (WebCore::RenderDataGrid::RenderDataGrid): (WebCore::RenderDataGrid::~RenderDataGrid): (WebCore::RenderDataGrid::calcPrefWidths): (WebCore::RenderDataGrid::paintObject): (WebCore::RenderDataGrid::valueChanged): (WebCore::RenderDataGrid::invalidateScrollbarRect): (WebCore::RenderDataGrid::isActive):
  • rendering/RenderDataGrid.h: Added. (WebCore::RenderDataGrid::renderName): (WebCore::RenderDataGrid::canHaveChildren): (WebCore::RenderDataGrid::scrollbarCornerPresent):
16:01 Changeset [44963] by sfalken@apple.com

Remove errant line of code mistakenly checked in.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main):
16:00 Changeset [44962] by sfalken@apple.com

Pass correct value to setShouldPaintNativeControls.


Rubber stamped by Mark Rowe.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main):
15:45 Changeset [44961] by simon.fraser@apple.com

2009-06-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=26430
<rdar://problem/6944442> Elements jump around when they become composited (WWDC checkers demo)
<rdar://problem/6989006> Lots of time spent in RenderLayerCompositor::calculateCompositedBounds()

during window resize when using hardware layers

Fix an ordering dependency which caused the compositing position of a layer
to be affected by some later sibling, which affected the compositing ancestor's
composited bounds.

The fix is to only update the compositing positions of layers in some subtree
when updateAfterLayout() has been called on all the layers in that subtree,
from the ancestor down.

Also cache the composited bounds of a RenderLayerBacking, now that we can
guarantee that those bounds are accurate.

Test: compositing/sibling-positioning.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::hitTestLayer):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::updateAfterLayout): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer): (WebCore::RenderLayerBacking::paintContents): (WebCore::RenderLayerBacking::compositedBounds): (WebCore::RenderLayerBacking::setCompositedBounds):
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::updateLayerCompositingState): (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::layerWillBeRemoved): (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::updateCompositingChildrenGeometry):
  • rendering/RenderLayerCompositor.h:
15:41 Moving to Git edited by joe.mason@torchmobile.com
Add link to evmar's doc (diff)
15:31 Moving to Git edited by joe.mason@torchmobile.com
Discussion of patch review branches (diff)
14:59 Changeset [44960] by barraclough@apple.com

Merged r43552:43558 into nitro-extreme branch.

14:58 Changeset [44959] by darin@chromium.org

2009-06-22 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

First step in https://bugs.webkit.org/show_bug.cgi?id=25376

Add StorageSyncManager.cpp/h

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

In preparation for combining SessionStorage and LocalStorage into a
single StorageManager, move the syncing bits out of LocalStorage and
into its own class.

The next step is to combine LocalStorageArea and SessionStorageArea
into one. Then SessionStorage and LocalStorage can be combined.

Note that combining them will cut down on code paths that must be
proxied, eliminate virtual dispatch, and allow Chromium to (eventually)
write historical sessionStorage to disk when memory is getting tight.

Also remove a couple bits of cruft including code for quotas which is
unnecessary (since a meta-data db is unnecessary since you can just
count bytes as you read the local storage databases into memory).

  • storage/LocalStorage.cpp: (WebCore::LocalStorage::LocalStorage): (WebCore::LocalStorage::storageArea): (WebCore::LocalStorage::close):
  • storage/LocalStorage.h:
  • storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::scheduleFinalSync): (WebCore::LocalStorageArea::syncTimerFired): (WebCore::LocalStorageArea::performImport):
  • storage/LocalStorageArea.h: (WebCore::LocalStorageArea::create):
  • storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::performTask):
  • storage/LocalStorageTask.h: (WebCore::LocalStorageTask::): (WebCore::LocalStorageTask::createImport):
  • storage/LocalStorageThread.cpp:
  • storage/LocalStorageThread.h:
  • storage/SessionStorage.h:
  • storage/StorageSyncManager.cpp: Copied from WebCore/storage/LocalStorage.cpp. (WebCore::StorageSyncManager::create): (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::fullDatabaseFilename): (WebCore::StorageSyncManager::close): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
  • storage/StorageSyncManager.h: Copied from WebCore/storage/LocalStorage.h. (WebCore::):
14:47 Changeset [44958] by barraclough@apple.com

Merged r43550:43552 into nitro-extreme branch - fix error in merging changelogs.

14:43 Changeset [44957] by barraclough@apple.com

Merged r43550:43552 into nitro-extreme branch.

14:38 Changeset [44956] by darin@chromium.org

2009-06-22 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26622
Add ChromiumDataObject::copy()

  • platform/chromium/ChromiumDataObject.cpp:
  • platform/chromium/ChromiumDataObject.h:
14:31 Changeset [44955] by timothy@apple.com

Add Mail on Tiger and Leopard to the list of applications that need the WebView init thread workaround.

<rdar://problem/6929524> Console shows WebKit Threading Violations from Mail

Reviewed by Anders Carlsson.

  • WebView/WebView.mm: (clientNeedsWebViewInitThreadWorkaround): Return true for com.apple.Mail.
14:30 Moving to Git edited by treat@kde.org
(diff)
14:25 Changeset [44954] by timothy@apple.com

Add a silhouette image for the enable view of the Resource panel.

Reviewed by Kevin McCullough.

  • inspector/front-end/Images/resourcesSilhouette.png: Added.
  • inspector/front-end/inspector.css:
14:02 Changeset [44953] by levin@chromium.org

2009-06-22 Kyle Prete <kylep@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26552
Add V8 JS bindings for Audio Constructor.

  • bindings/v8/custom/V8CustomBinding.h: Added a callback declaration for audio ctor to macro.
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Added the whole file.
13:14 Changeset [44952] by ap@webkit.org

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26600
StringImpl::copy() no longer copies empty string correctly

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::ustring): Changed method calling syntax to look less like calling a static method. (WebCore::StringImpl::copy): Reverted part of r41917 that caused the problem.
12:51 Changeset [44951] by mitz@apple.com

Reviewed by Anders Carlsson.

  • speculative fix for <rdar://problem/6889082> Crash at -[WebHTMLView(WebPrivate) _updateMouseoverWithEvent:]

The crash seems to happen because lastHitView points to a deleted
object. Since -close calls -_clearLastHitViewIfSelf, I speculate that
lastHitView has been set to an already-closed view.

  • WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]): Return nil if the view is closed.
12:34 Changeset [44950] by levin@chromium.org

2009-06-22 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix layout tests to account for removal of DOMStringList, which was done
in http://trac.webkit.org/changeset/44943.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
12:20 Changeset [44949] by barraclough@apple.com

Merged r43544:43550 into nitro-extreme branch.

11:54 Changeset [44948] by jshin@chromium.org

2009-06-22 Xiaomei Ji <xji@chromium.org>

Reviewed by Eric Seidel

Not auto-testable since it involves sending a keyboard event to
the popup, which is not possible (eventSender sends the key
events through webview, we want to go through the webwidget).

This patch is one part of the fix for issue "keyboard selection in
Hebrew select element does not work in Windows". The other part of the
fix is in chromium's webkit/glue layer.
https://bugs.webkit.org/show_bug.cgi?id=25899

  • manual-tests/keyboard_select_non_english.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::isCharacterTypeEvent): Added. Check whether the event is a character type event. "Char" in Windows or "KeyDown" in Mac is character type event. (WebCore::PopupListBox::typeAheadFind): Since m_lastCharTime is used to indicate whether user types multiple characters continuely as a search prefix or not, it should be only assigned when the event is character type event.
11:51 Changeset [44947] by kmccullough@apple.com

2009-06-22 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6115819> Notify of profile start in console

Put a message in the console that announces that a profile has started,
similar to how a console message announces that a profile has finished.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): Use renamed function. (WebCore::InspectorController::addProfileFinishedMessageToConsole): Renamed. (WebCore::InspectorController::addStartProfilingMessageToConsole): New function that logs the message about the profile starting. (WebCore::InspectorController::startUserInitiatedProfiling): Ditto
  • inspector/InspectorController.h:
  • inspector/front-end/ProfilesPanel.js: Print the "run" of the profile's title if there are multiple profiles, and take into account the fact that titles are displayed twice as much now. (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink):
  • page/Console.cpp: (WebCore::Console::profile): Call new function.
11:47 Changeset [44946] by hyatt@apple.com

2009-06-22 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26615

Add IDL interface for datagrid cell elements. Add a few more properties to the datagrid itself that
correspond to ones you find on <select> elements.

Add an expanded property to row elements.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLAttributeNames.in:
  • html/HTMLDataGridCellElement.cpp: Added. (WebCore::HTMLDataGridCellElement::HTMLDataGridCellElement): (WebCore::HTMLDataGridCellElement::label): (WebCore::HTMLDataGridCellElement::setLabel): (WebCore::HTMLDataGridCellElement::focused): (WebCore::HTMLDataGridCellElement::setFocused): (WebCore::HTMLDataGridCellElement::checked): (WebCore::HTMLDataGridCellElement::setChecked): (WebCore::HTMLDataGridCellElement::indeterminate): (WebCore::HTMLDataGridCellElement::setIndeterminate): (WebCore::HTMLDataGridCellElement::progress): (WebCore::HTMLDataGridCellElement::setProgress):
  • html/HTMLDataGridCellElement.h: Added. (WebCore::HTMLDataGridCellElement::endTagRequirement): (WebCore::HTMLDataGridCellElement::tagPriority):
  • html/HTMLDataGridCellElement.idl: Added.
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::autofocus): (WebCore::HTMLDataGridElement::setAutofocus): (WebCore::HTMLDataGridElement::disabled): (WebCore::HTMLDataGridElement::setDisabled): (WebCore::HTMLDataGridElement::size): (WebCore::HTMLDataGridElement::setSize):
  • html/HTMLDataGridElement.h:
  • html/HTMLDataGridElement.idl:
  • html/HTMLDataGridRowElement.cpp: (WebCore::HTMLDataGridRowElement::checkDTD): (WebCore::HTMLDataGridRowElement::expanded): (WebCore::HTMLDataGridRowElement::setExpanded):
  • html/HTMLDataGridRowElement.h:
  • html/HTMLDataGridRowElement.idl:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
11:32 Changeset [44945] by sfalken@apple.com

Fix last DumpRenderTree change to correctly set preferences flag without crashing.


Reviewed by Mark Rowe.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main):
11:32 Changeset [44944] by weinig@apple.com

WebCore:

2009-06-22 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Add event handler attribute getter/setters to HTMLBodyElement
as specified in HTML 5.

  • Removes erroneous inclusion of the onresize and onunload event handler attributes in Element and Document.
  • dom/Document.cpp: (WebCore::Document::getWindowAttributeEventListener):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.cpp:
  • dom/Node.h: onblur, onerror, onfocus, and onload all need to be declared virtual, since their behavior for HTMLBodyElement differs from the base implementation.
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::onblur): (WebCore::HTMLBodyElement::setOnblur): (WebCore::HTMLBodyElement::onerror): (WebCore::HTMLBodyElement::setOnerror): (WebCore::HTMLBodyElement::onfocus): (WebCore::HTMLBodyElement::setOnfocus): (WebCore::HTMLBodyElement::onload): (WebCore::HTMLBodyElement::setOnload): (WebCore::HTMLBodyElement::onbeforeunload): (WebCore::HTMLBodyElement::setOnbeforeunload): (WebCore::HTMLBodyElement::onmessage): (WebCore::HTMLBodyElement::setOnmessage): (WebCore::HTMLBodyElement::onoffline): (WebCore::HTMLBodyElement::setOnoffline): (WebCore::HTMLBodyElement::ononline): (WebCore::HTMLBodyElement::setOnonline): (WebCore::HTMLBodyElement::onresize): (WebCore::HTMLBodyElement::setOnresize): (WebCore::HTMLBodyElement::onstorage): (WebCore::HTMLBodyElement::setOnstorage): (WebCore::HTMLBodyElement::onunload): (WebCore::HTMLBodyElement::setOnunload):
  • html/HTMLBodyElement.h:
  • html/HTMLBodyElement.idl:

LayoutTests:

2009-06-22 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Add event handler attribute getter/setters to HTMLBodyElement
as specified in HTML 5.

  • fast/dom/event-attribute-availability-expected.txt:
  • fast/dom/resources/event-attribute-availability.js:
11:22 Changeset [44943] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26601
Remove disabled code for appcache dynamic entries

This also removes code for DOM 3 Core DOMStringList, which we don't use for anything else yet.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDOMStringListCustom.cpp: Removed.
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMStringListCustom.cpp: Removed.
  • dom/DOMStringList.cpp: Removed.
  • dom/DOMStringList.h: Removed.
  • dom/DOMStringList.idl: Removed.
  • dom/StaticStringList.cpp: Removed.
  • dom/StaticStringList.h: Removed.
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addResource):
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
  • loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::dumpType):
  • loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeUpdatedType):
  • loader/appcache/DOMApplicationCache.cpp:
  • loader/appcache/DOMApplicationCache.h:
  • loader/appcache/DOMApplicationCache.idl:
  • page/DOMWindow.idl:
10:56 Changeset [44942] by sfalken@apple.com

Windows build fix.

  • DerivedSources.cpp:
  • html/HTMLElementsAllInOne.cpp:
10:33 Changeset [44941] by ap@webkit.org

Reviewed by John Sullivan.

<rdar://problem/6956606> REGRESSION (S4Beta -> Final): After the password is input,
Japanese can't be input.

WebKit uses a per-frame input context for most editable fields, and application's global
context for password fields, manually controlling secure input state and the list of available
input methods.

We were setting TSMDocument property to disable non-Roman input methods after focus changed
to a password field, but before selection was updated. This resulted in the property being
applied to a wrong TSMDocument in some cases, because TSMGetActiveDocument() uses input
context cached by +[NSApplication updateWindows], we change context based on selection,
not on focus.

  • page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Since there is only one context that we use for password fields - the global one - there is no need to get the active one.
10:20 Changeset [44940] by levin@chromium.org

WebCore:

2009-06-22 David Levin <levin@chromium.org>

Reviewed by David Hyatt and Eric Seidel.

REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326

Test: scrollbars/scrollbar-crash-on-refresh.html

  • dom/Document.cpp: (WebCore::Document::detach): Gives the FrameView a change to do any necessary cleanup on Document::detach() which is where the renderArena gets detroyed.
  • page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars): Gets rid of any custom scrollbars (if the docment supplied them).
  • page/FrameView.h:
  • platform/Scrollbar.h: (WebCore::Scrollbar::isCustomScrollbar):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Removed the check for document()->frame(). If frame() is 0 in this code, then the call to animation() is also incorrect (since it does document()->frame()->animation()).
  • rendering/RenderScrollbar.h: (WebCore::RenderScrollbar::isCustomScrollbar):

LayoutTests:

2009-06-22 David Levin <levin@chromium.org>

Reviewed by David Hyatt and Eric Seidel.

REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326

Test that refreshing an iframe with custom scrollbars works without crashing.

  • scrollbars/resources/page-with-custom-scrollbars.html: Added.
  • scrollbars/scrollbar-crash-on-refresh-expected.txt: Added.
  • scrollbars/scrollbar-crash-on-refresh.html: Added.
09:50 Changeset [44939] by mitz@apple.com

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6990938> REGRESSION (r42787): After showing and hiding the Find banner, the WebHTMLView's height is not restored
  • WebView/WebFrameView.mm: (-[WebFrameView setFrameSize:]): Mark the FrameView for layout when the WebFrameView's size changes.
  • WebView/WebView.mm: (-[WebView setFrameSize:]): Left the resize logic here, but only for the single view model.
09:42 Changeset [44938] by mitz@apple.com

WebCore:

Reviewed by Simon Fraser.

Test: fast/repaint/background-generated.html

  • rendering/RenderObject.cpp: (WebCore::mustRepaintFillLayers): Return true if the layer does not specify a size and the image uses the container size.

LayoutTests:

Reviewed by Simon Fraser.

  • fast/repaint/background-generated.html: Added.
  • platform/mac/fast/repaint/background-generated-expected.checksum: Added.
  • platform/mac/fast/repaint/background-generated-expected.png: Added.
  • platform/mac/fast/repaint/background-generated-expected.txt: Added.
09:34 Changeset [44937] by hyatt@apple.com

2009-06-22 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26607

Add IDL for HTMLDataGridRowElement.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLAttributeNames.in:
  • html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::primary): (WebCore::HTMLDataGridColElement::setPrimary):
  • html/HTMLDataGridColElement.h:
  • html/HTMLDataGridColElement.idl:
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::checkDTD): (WebCore::HTMLDataGridElement::multiple): (WebCore::HTMLDataGridElement::setMultiple):
  • html/HTMLDataGridElement.h:
  • html/HTMLDataGridElement.idl:
  • html/HTMLDataGridRowElement.cpp: Added. (WebCore::HTMLDataGridRowElement::HTMLDataGridRowElement): (WebCore::HTMLDataGridRowElement::selected): (WebCore::HTMLDataGridRowElement::setSelected): (WebCore::HTMLDataGridRowElement::focused): (WebCore::HTMLDataGridRowElement::setFocused):
  • html/HTMLDataGridRowElement.h: Added. (WebCore::HTMLDataGridRowElement::tagPriority):
  • html/HTMLDataGridRowElement.idl: Added.
  • html/HTMLTagNames.in:
09:32 Changeset [44936] by darin@apple.com

2009-06-22 Darin Adler <darin@apple.com>

  • platform/gtk/Skipped: Skip two new tests.
08:44 Changeset [44935] by darin@apple.com

2009-06-22 Darin Adler <darin@apple.com>

  • fast/js/JSON-stringify-expected.txt: Update results.
06:22 Changeset [44934] by yael.aharon@nokia.com

2009-06-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=26556

Fix a crash in case that the QNetworkReply::readReady signal is
"stuck" in deferred mode due to JavaScript alert, and in the meantime,
QNetworkreply::finished signal is received and processed before
QNetworkReply::readReady is processed.

  • manual-tests/qt/unload-alert.html: Added.
  • platform/network/qt/QNetworkReplyHandler.cpp:
  • platform/network/qt/QNetworkReplyHandler.h:
04:55 Changeset [44933] by vestbo@webkit.org

2009-06-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Fix the Qt build.

  • WebCore.pro:
00:33 Changeset [44932] by sfalken@apple.com

Set up global native controls flag before creating the first WebView.


Reviewed by Darin Adler.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main):

06/21/09:

23:35 Changeset [44931] by oliver@apple.com

Bug 26592: Support standard toJSON functions
<https://bugs.webkit.org/show_bug.cgi?id=26592>

Reviewed by Darin Adler

Add support for the standard Date.toJSON function.

23:17 Changeset [44930] by darin@apple.com

2009-06-21 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
https://bugs.webkit.org/show_bug.cgi?id=25425

  • bindings/scripts/CodeGeneratorJS.pm: Tweaked mechanism for includes to be a bit more consistent and to make SVGElement.h be included in the header rather than in every implementation file that includes the header. Added code to use getAttribute and setAttribute directly when the [Reflect] extended attribute is used.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • html/HTMLElement.idl: Used [Reflect] for all the attributes in this class that reflect content attributes. Restricting this to one class for now to keep the patch small and start out slowly.
22:08 Changeset [44929] by oliver@apple.com

Bug 26594: JSC needs to support Date.toISOString
<https://bugs.webkit.org/show_bug.cgi?id=26594>

Reviewed by Sam Weinig

Add support for Date.toISOString.

21:59 Changeset [44928] by weinig@apple.com

WebCore:

2009-06-21 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.

Test: fast/dom/event-attribute-availability.html

  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.cpp:
  • dom/Node.h:
  • dom/Node.idl:

LayoutTests:

2009-06-21 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Test for https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.

  • fast/dom/event-attribute-availability-expected.txt: Added.
  • fast/dom/event-attribute-availability.html: Added.
  • fast/dom/resources/event-attribute-availability.js: Added.
18:39 Changeset [44927] by abarth@webkit.org

WebCore:

2009-06-21 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26580


Fix to enable XSSAuditor on child windows.


Test: http/tests/security/xssAuditor/link-opens-new-window.html


  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject):
  • page/XSSAuditor.h: Removed method setXSSAuditorEnabled, and field m_isEnabled. Moved implementation of isEnabled to XSSAuditor.cpp and changed implementation to query Settings.

LayoutTests:

2009-06-21 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.


Test for https://bugs.webkit.org/show_bug.cgi?id=26580


Tests that XSSAuditor (if enabled) prevents script execution in child window.

  • http/tests/security/xssAuditor/link-opens-new-window-expected.txt: Added.
  • http/tests/security/xssAuditor/link-opens-new-window.html: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-and-notify.php: Added.
17:23 Changeset [44926] by mitz@apple.com

Rubber-stamped by Mark Rowe.

  • make repaint tests more reliable when run in Safari
  • fast/repaint/resources/repaint.js: (runRepaintTest): Increased the timeout from 0 to 100, to ensure that painting occurs once before repaintTest() is called.
17:03 Changeset [44925] by mrowe@apple.com

Set a sensible user agent string for the HTTP requests that Sparkle makes (checking for and downloading updates).

Reviewed by Sam Weinig.

  • WebKitLauncher/WebKitNightlyEnablerSparkle.m:

(userAgentStringForSparkle):
(initializeSparkle):

16:32 Changeset [44924] by oliver@apple.com

Fix build by removing dead code.

16:02 Changeset [44923] by oliver@apple.com

Bug 26587: Support JSON.parse
<https://bugs.webkit.org/show_bug.cgi?id=26587>

Reviewed by Darin Adler and Cameron Zwarich.

Extend the LiteralParser to support the full strict JSON
grammar, fix a few places where the grammar was incorrectly
lenient. Doesn't yet support the JSON.parse reviver function
but that does not block the JSON.parse functionality itself.

15:46 Changeset [44922] by levin@chromium.org

2009-06-21 David Levin <levin@chromium.org>

Reviewed by NOBODY (speculative build fix for windows).

Simply removed some whitespace form this file to make windows build wtf and
hopefully copy the new MessageQueque.h so that WebCore picks it up.

  • wtf/Assertions.cpp:
15:16 Changeset [44921] by levin@chromium.org

2009-06-21 David Levin <levin@chromium.org>

Reviewed by NOBODY.

Speculative windows build fix (idea by Mark Rowe).

  • WebCore.vcproj/WebCore.vcproj:
15:03 Changeset [44920] by mrowe@apple.com

Add a hook to the WebKit launcher application to allow a link on the nightly build start page to
trigger an update via the built-in software update mechanism.

Reviewed by Sam Weinig.

  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitLauncherURLProtocol.h: Added.
  • WebKitLauncher/WebKitLauncherURLProtocol.m: Added.

(+[WebKitLauncherURLProtocol load]):
(+[WebKitLauncherURLProtocol canInitWithRequest:]): Only allow use of the x-webkit-launcher scheme from .webkit.org subdomains.
(+[WebKitLauncherURLProtocol canonicalRequestForRequest:]):
(-[WebKitLauncherURLProtocol startLoading]):
(-[WebKitLauncherURLProtocol stopLoading]):
(-[WebKitLauncherURLProtocol handleIsWebKitLauncherAvailableJS]): Return a brief JavaScript snippet that can be used to programatically
determine whether the x-webkit-launcher is available and working.
(-[WebKitLauncherURLProtocol handleCheckForUpdates]): Trigger a software update on the main thread.
(-[WebKitLauncherURLProtocol resourceNotFound]): Fail with a generic "File does not exist" error.

15:02 Changeset [44919] by levin@chromium.org

2009-06-21 David Levin <levin@chromium.org>

Reviewed by NOBODY (Speculative gtk build fix).

  • GNUmakefile.am:
14:56 Changeset [44918] by levin@chromium.org

2009-06-21 David Levin <levin@chromium.org>

Reviewed by NOBODY.

Speculative tiger build fix and a windows build fix.
More fixes may still be in order.

  • WebCore.vcproj/WebCoreCommon.vsprops:
  • dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
14:46 Changeset [44917] by levin@chromium.org

2009-06-21 David Levin <levin@chromium.org>

Reviewed by NOBODY (Speculative tiger build fix).

  • dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::~MessagePortQueue):
14:32 Changeset [44916] by levin@chromium.org

WebCore:

2009-06-21 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=26448>

Added optimized GC for MessagePorts when the entangled port is run by the same thread.
Fixed bug in isProxyFor() that was not properly throwing an exception when trying to clone the entangled port.

  • bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext): Now marks remotely entangled ports as in-use, in addition to those with pending activity.
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark): Now checks if the entangled port is local (run by same thread) and if so mark()s it.
  • dom/MessagePort.cpp: (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): Removes cloned ports from the ScriptExecutionContext - this allows cloned ports to be GC'd as otherwise they look like remotely entangled ports. (WebCore::MessagePort::start): (WebCore::MessagePort::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread
  • dom/MessagePort.h:
  • dom/MessagePortProxyWrapper.h:
  • dom/default/MessagePortProxy.cpp: (WebCore::MessagePortProxyWrapper::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread (WebCore::MessagePortProxy::hasPendingActivity): Changed definition of hasPendingActivity() to be stricter - only returns true if there are pending messages. (WebCore::MessagePortProxy::locallyEntangledPort):
  • dom/default/MessagePortProxy.h:

LayoutTests:

2009-06-21 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=26448>

New tests for MessagePort GC cases that weren't previously covered.

  • fast/events/message-channel-gc-4-expected.txt: Added. Test for case where both MessagePorts are in-transit (cloned) when a GC occurs.
  • fast/events/message-channel-gc-4.html-disabled: Added.
14:32 Changeset [44915] by levin@chromium.org

JavaScriptCore:

2009-06-21 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=25043>
Added support for multi-threaded MessagePorts.

  • wtf/MessageQueue.h: (WTF::::appendAndCheckEmpty):

Added API to test whether the queue was empty before adding an element.

WebCore:

2009-06-21 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=25043>
Removed obsolete MessagePort.startConversation(), active and onclose APIs.

Refactored MessagePortProxy into MessagePortChannel and a platform-dependent PlatformMessagePortChannel
implementation. Modified APIs to simplify cross-process implementations by moving the messaging code
entirely into the platform-dependent proxy.

Created a thread-safe default PlatformMessagePortChannel implementation.

Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how
cross-thread MessagePorts work.

  • GNUMakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added MessagePortChannel/PlatformMessagePortChannel files.

  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):

Changed ports to not mark their entangled pair as reachable, per the spec.

  • bindings/v8/custom/V8MessagePortCustom.cpp:
  • dom/MessageChannel.cpp: (WebCore::MessageChannel::MessageChannel):

Updated to use PlatformMessagePortChannel::createChannel() to entangle the ports.

  • dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::~MessagePort): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): (WebCore::MessagePort::messageAvailable): (WebCore::MessagePort::start): (WebCore::MessagePort::close): (WebCore::MessagePort::entangle): (WebCore::MessagePort::contextDestroyed): (WebCore::MessagePort::dispatchMessages): (WebCore::MessagePort::setOnmessage): (WebCore::MessagePort::hasPendingActivity):

Changed these APIs to delegate to new PlatformMessagePortChannel APIs.

  • dom/MessagePort.h:

Renamed isQueueOpen() to started().

  • dom/MessagePort.idl:

Removed startConversation and onclose.

  • dom/MessagePortProxy.h: Removed.
  • dom/MessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::EventData::create): (WebCore::MessagePortChannel::EventData::EventData): (WebCore::MessagePortChannel::~MessagePortChannel):
  • dom/MessagePortChannel.h: Added. (WebCore::MessagePortChannel::EventData::message): (WebCore::MessagePortChannel::EventData::channel):

Changed EventData to hold a reference to a MessagePortChannel object instead of a MessagePort to enable cross-thread messaging.

(WebCore::MessagePortChannel::MessagePortChannel):
(WebCore::MessagePortChannel::create):

  • dom/ScriptExecutionContext.cpp: (WebCore:ScriptExecutionContext::dispatchMessagePortEvents):

Renamed isQueueOpen() to started().

  • dom/default/PlatformMessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::entangleIfOpen): (WebCore::MessagePortChannel::disentangle): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::MessagePortChannel::close): (WebCore::MessagePortChannel::isConnectedTo): (WebCore::MessagePortChannel::hasPendingActivity): (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::createChannel): (WebCore::PlatformMessagePortChannel::entangleIfOpen): (WebCore::PlatformMessagePortChannel::disentangle): (WebCore::PlatformMessagePortChannel::setRemotePort): (WebCore::PlatformMessagePortChannel::remotePort): (WebCore::PlatformMessagePortChannel::entangledChannel): (WebCore::PlatformMessagePortChannel::setEntangledChannel): (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote): (WebCore::PlatformMessagePortChannel::isConnectedTo): (WebCore::PlatformMessagePortChannel::close): (WebCore::PlatformMessagePortChannel::closeInternal): (WebCore::PlatformMessagePortChannel::hasPendingActivity):
  • dom/default/PlatformMessagePortChannel.h: Added. (WebCore::PlatformMessagePortChannel::MessagePortQueue::create): (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage): (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::isEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::MessagePortQueue):
  • page/DOMWindow.cpp: (WebCore::PostMessageTimer::PostMessageTimer):

Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how cross-thread MessagePorts work.

(WebCore::PostMessageTimer::event):
(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

2009-06-21 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=25043>
Updated MessageChannel/MessagePorts tests to reflect latest spec (close event has been removed).
Added more tests of port cloning.

  • fast/events/message-channel-gc-2-expected.txt:
  • fast/events/message-channel-gc-2.html-disabled:
  • fast/events/message-channel-gc-3-expected.txt:
  • fast/events/message-channel-gc-3.html-disabled:
  • fast/events/message-channel-gc-expected.txt:
  • fast/events/message-channel-gc.html-disabled:
  • fast/events/message-port-clone-expected.txt: Added.
  • fast/events/message-port-clone.html-disabled: Added.
  • fast/events/message-port-expected.txt:
  • fast/events/message-port-no-wrapper-expected.txt: Added.
  • fast/events/message-port-onclose-expected.txt: Removed.
  • fast/events/message-port-onclose.html-disabled: Removed.
  • fast/events/message-port.html-disabled:
13:56 Changeset [44914] by mitz@apple.com

WebCore:

Reviewed by Sam Weinig.

Test: fast/css/resize-single-axis.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): Ignore movement along the non-resizing axis.

LayoutTests:

Reviewed by Sam Weinig.

  • fast/css/resize-single-axis-expected.txt: Added.
  • fast/css/resize-single-axis.html: Added.
13:47 Changeset [44913] by weinig@apple.com

WebCore:

2009-06-21 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel

Fix for https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox

Test: fast/events/event-trace.html

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Make the DOMWindow the currentTarget when events are dispatched to it. We previously used the document because DOMWindow was not yet an EventTarget.

LayoutTests:

2009-06-21 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel.

Test for https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox

  • fast/events/event-trace-expected.txt: Added.
  • fast/events/event-trace.html: Added.
13:16 Changeset [44912] by mitz@apple.com

WebCore:

Reviewed by Sam Weinig.

Test: fast/css/resize-value-compared.html

  • rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::operator==): Compare the resize member.

LayoutTests:

Reviewed by Sam Weinig.

  • fast/css/resize-value-compared-expected.txt: Added.
  • fast/css/resize-value-compared.html: Added.
00:19 Changeset [44911] by darin@apple.com

2009-06-21 Darin Adler <darin@apple.com>

  • platform/gtk/Skipped: Skip one more test.

06/20/09:

23:19 Changeset [44910] by darin@apple.com

2009-06-20 Darin Adler <darin@apple.com>

  • platform/gtk/Skipped: Skip some new tests.
23:15 Changeset [44909] by darin@apple.com

2009-06-20 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6964221> Need more processing of pluginspage.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
22:42 Changeset [44908] by alice.liu@apple.com

WebCore:

2009-06-19 Alice Liu <alice.liu@apple.com>

Fix https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>

Reviewed by Maciej Stachowiak.

Can't test this bug with an automated layout test since it requires b/f caching

  • manual-tests/animated-gif-bfcache-crash.html: Added.
  • manual-tests/resources/containsAnimatedGif.html: Added.

Adding checks for hostWindow() since there is no guarantee that the Page is alive

  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::contentsToScreen): (WebCore::ScrollView::screenToContents): (WebCore::ScrollView::wheelEvent):

LayoutTests:

2009-06-19 Alice Liu <alice.liu@apple.com>

Fix https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>

Reviewed by Maciej Stachowiak.

Adding resource used in WebCore/manual-tests/animated-gif-bfcache-crash.html

  • http/tests/misc/resources/animated-gif-with-offsets.gif: Added.
19:43 Changeset [44907] by mrowe@apple.com

Roll out the Windows portion of r44905 as it broke the build.

19:05 Changeset [44906] by weinig@apple.com

WebCore:

2009-06-20 Sam Weinig <sam@webkit.org>

Reviewed by Adam Barth.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26554
Shadowing of top and parent

  • page/DOMWindow.idl:

LayoutTests:

2009-06-20 Sam Weinig <sam@webkit.org>

Reviewed by Adam Barth.

Test for https://bugs.webkit.org/show_bug.cgi?id=26554

Test writing to parent and top.

  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/cross-frame-access-put.html:
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
16:07 Changeset [44905] by darin@apple.com

WebKit/mac:

2009-06-20 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6964221> Need more processing of pluginspage.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.

WebKit/win:

2009-06-20 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6964221> Need more processing of pluginspage.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
14:57 Changeset [44904] by jmalonzo@webkit.org

Reviewed by Gustavo Noronha and Xan Lopez.

[Gtk] Implement DRT XSS auditor support
https://bugs.webkit.org/show_bug.cgi?id=26571

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
14:56 Changeset [44903] by jmalonzo@webkit.org

2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha and Xan Lopez.

webkit_web_back_forward_list_add_item() should add a ref for the history item
https://bugs.webkit.org/show_bug.cgi?id=26517

Add a ref to the WebHistoryItem when it's added to the back
forward list through webkit_web_back_forward_list_add_item.
This keeps the history item alive and prevents pywebkitgtk from
crashing

  • tests/testwebbackforwardlist.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): (test_webkit_web_back_forward_list_add_item):
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_add_item):
14:54 Changeset [44902] by mrowe@apple.com

Fix <https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none

Reviewed by Dan Bernstein.

We allow selections to begin within an element that has -webkit-user-select: none set,
unless the element is draggable as dragging should take priority over starting a selection.

Test: editing/selection/user-drag-element-and-user-select-none.html

  • dom/Node.cpp:

(WebCore::Node::canStartSelection):

Test for <https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none

  • editing/selection/user-drag-element-and-user-select-none-expected.txt: Added.
  • editing/selection/user-drag-element-and-user-select-none.html: Added.
13:34 Changeset [44901] by darin@apple.com

WebCore:

2009-06-20 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329

  • editing/TextIterator.cpp: (WebCore::TextIterator::handleReplacedElement): When entering a text control, start at the top of the shadow tree (by calling shadowTreeRootNode). Also remove assumption that innerTextElement will never be 0 since RenderTextControl doesn't really guarantee this.

LayoutTests:

2009-06-20 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329

  • editing/selection/find-in-text-control-expected.txt: Updated to expect finding text in <input type="text"> and <input type="search">, but not in <input type="password">.
  • editing/selection/find-in-text-control.html: Added tests for <input> elements as well as <textarea> elements. Also tweaked result output format to accomodate multiple text nodes.
11:06 Changeset [44900] by ddkilzer@apple.com

Fix namespace comment in SegmentedVector.h

  • wtf/SegmentedVector.h: Updated namespace comment to reflect new namespace after r44897.
06:27 Changeset [44899] by ddkilzer@apple.com

2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>

Reviewed by Oliver Hunt.

An Iterator added for SegmentedVector. Currently
only the pre ++ operator is supported.

  • wtf/SegmentedVector.h: (WTF::SegmentedVectorIterator::~SegmentedVectorIterator): (WTF::SegmentedVectorIterator::operator*): (WTF::SegmentedVectorIterator::operator->): (WTF::SegmentedVectorIterator::operator++): (WTF::SegmentedVectorIterator::operator==): (WTF::SegmentedVectorIterator::operator!=): (WTF::SegmentedVectorIterator::operator=): (WTF::SegmentedVectorIterator::SegmentedVectorIterator): (WTF::SegmentedVector::alloc): (WTF::SegmentedVector::begin): (WTF::SegmentedVector::end):
06:20 Changeset [44898] by kov@webkit.org

2009-06-20 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Jan Alonzo.

Initial test case for loading statuses.

  • tests/testloading.c: Added. (load_finished_cb): (status_changed_cb): (test_loading_status): (main):
06:14 Changeset [44897] by ddkilzer@apple.com

2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>

Reviewed by Oliver Hunt.

Move SegmentedVector to /wtf subdirectory
and change "namespace JSC" to "namespace WTF"

Additional build file updates by David Kilzer.

  • GNUmakefile.am: Updated path to SegmentedVector.h.
  • JavaScriptCore.order: Updated SegmentedVector namespace from JSC to WTF in mangled C++ method name.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed reference to bytecompiler\SegmentedVector.h.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Added reference to wtf\SegmentedVector.h.
  • JavaScriptCore.xcodeproj/project.pbxproj: Moved SegmentedVector.h definition from bytecompiler subdirectory to wtf subdirectory.
  • bytecompiler/BytecodeGenerator.h: Updated #include path to
SegmentedVector.h and prepended WTF
namespace to its use.
  • parser/Lexer.h: Ditto.
  • wtf/SegmentedVector.h: Renamed from JavaScriptCore/bytecompiler/SegmentedVector.h. (WTF::SegmentedVector::SegmentedVector): (WTF::SegmentedVector::~SegmentedVector): (WTF::SegmentedVector::size): (WTF::SegmentedVector::at): (WTF::SegmentedVector::operator[]): (WTF::SegmentedVector::last): (WTF::SegmentedVector::append): (WTF::SegmentedVector::removeLast): (WTF::SegmentedVector::grow): (WTF::SegmentedVector::clear): (WTF::SegmentedVector::deleteAllSegments): (WTF::SegmentedVector::segmentExistsFor): (WTF::SegmentedVector::segmentFor): (WTF::SegmentedVector::subscriptFor): (WTF::SegmentedVector::ensureSegmentsFor): (WTF::SegmentedVector::ensureSegment):
05:34 Changeset [44896] by kov@webkit.org

2009-06-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Jan Alonzo.

Fix the ordering in which the new load status goes into the enum
to avoid ABI breakage.

  • webkit/webkitwebframe.h:
02:48 Changeset [44895] by jmalonzo@webkit.org

2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by NOBODY.

Speculative Qt build fix - add HTMLDataGridColElement to the build script.

  • WebCore.pro:
02:20 Changeset [44894] by abarth@webkit.org

2009-06-19 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26561

Remove a memcpy by retrieving the already existing copy of a string
instead of making a new one.

  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::source):
  • bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::source):
01:11 Changeset [44893] by xan@webkit.org

2009-06-20 Xan Lopez <xlopez@igalia.com>

Skip new accessibility test, we still lack and accessibilityController.

  • platform/gtk/Skipped:
01:00 Changeset [44892] by xan@webkit.org

2009-06-20 Xan Lopez <xlopez@igalia.com>

We don't seem to support these new HTTP tests either, skip them.

  • platform/gtk/Skipped:
00:53 Changeset [44891] by xan@webkit.org

2009-06-20 Xan Lopez <xlopez@igalia.com>

Skip test that requires eventSender.

  • platform/gtk/Skipped:

06/19/09:

23:21 Changeset [44890] by sfalken@apple.com

2009-06-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=26494
Bug 26494: RenderTheme::themeForPage reads from Settings before it has
been initialized by WebKit

Get the shouldPaintNativeControls preference and update the settings
before initializing the page, as the page depends on it after the
themeForPage change.

  • WebView.cpp: (WebView::initWithFrame):
18:29 Changeset [44889] by barraclough@apple.com

2009-06-19 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY (build fix take 2 - rename FIELD_OFFSET to something that doesn't conflict with winnt.h).

  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::emitGetVariableObjectRegister): (JSC::JIT::emitPutVariableObjectRegister):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::compileBinaryArithOp):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference): (JSC::JIT::checkStructure):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call): (JSC::JIT::emitSlow_op_get_by_val):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
18:29 Changeset [44888] by darin@apple.com

2009-06-19 Darin Adler <darin@apple.com>

  • Scripts/do-webcore-rename: More renaming ideas.
18:19 Changeset [44887] by barraclough@apple.com

2009-06-19 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY (Windows build fix).

  • jit/JIT.h:
  • jit/JITInlineMethods.h:
18:07 Changeset [44886] by barraclough@apple.com

2009-06-19 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Reorganize ARM architecture specific macros.
Use PLATFORM_ARM_ARCH(7) instead of PLATFORM(ARM_V7).

Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>

  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReferenceForTrampoline):
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • wtf/Platform.h:
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
17:52 Changeset [44885] by bweinstein@apple.com

Fixed the changelog, copied the same thing into both on accident.

17:49 Changeset [44884] by barraclough@apple.com

2009-06-19 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix armv7 JIT build issues.

Unfortunate the arm compiler does not like the use of offsetof on JITStackFrame (since it now contains non POD types),
and the FIELD_OFFSET macro does not appear constantish enough for it to be happy with its use in COMPILE_ASSERT macros.

  • Replace offsetofs with FIELD_OFFSETs (safe on C++ objects).
  • Move COMPILE_ASSERTs defending layout of JITStackFrame structure on armv7 into JITThunks constructor.
  • jit/JIT.cpp:
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_catch):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
17:35 Changeset [44883] by bweinstein@apple.com

2009-06-19 Brian Weinstein <bweinstein@apple.com>

Reviewed by Steve Falkenburg.


https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7


The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.


Unable to add tests to simulate touch behavior/gestures.

  • platform/PlatformWheelEvent.h:
  • platform/win/WheelEventWin.cpp:

2009-06-19 Brian Weinstein <bweinstein@apple.com>

Reviewed by Steve Falkenburg.


https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7


The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.


Unable to add tests to simulate touch behavior/gestures.

  • platform/PlatformWheelEvent.h:
  • platform/win/WheelEventWin.cpp:
17:27 Changeset [44882] by bfulgham@webkit.org

2009-06-19 Ryosuke Niwa <rniwa@google.com>

Reviewed by Maciej Stachowiak.

This fixs the bug 26361. The original test case did not invoke the event that
triggered the actual test. This patch adds code to invoke this event, and also
converts it from a pixel test to a dumpAsText test.

16:54 Changeset [44881] by cmarrin@apple.com

Fixed a build error, which only shows up in the i386 compile

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
16:35 Changeset [44880] by simon.fraser@apple.com

2009-06-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6988385> REGRESSION: In full page video player, movie's
video track becomes detached from its controller.

When in the media document, the MediaPlayer should not report that it
is capable of hardware acceleration, because it renders via a QTMovieView
which is already accelerated.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
16:14 Changeset [44879] by kevino@webkit.org

Adding XSSAuditor.cpp to the wx build.

15:43 Changeset [44878] by cmarrin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=26544

If I am doing a Matrix hardware animation and any matrix is singular, I revert to software.
This is not really testable, since we can't see what the hardware animation is doing.

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
15:32 Changeset [44877] by ggaren@apple.com

2009-06-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


An additional fix for Bug 26532: Native functions do not correctly unlink
from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> | <rdar://problem/6625385>

Use "NativeFunctionWrapper" instead of "PrototypeFunction" in cross-frame
accessors, so the type of object you get to wrap a function is the same,
regardless of whether the access to the function is cross-frame.


This is faster and more idiomatic than what we had before. It also would
have avoided Bug 26532 because it would have prevented a conflicting
PrototypeFunction from being allocated to wrap postMessage, where a
NativeFunctionWrapper had been allocated previously.


  • bindings/js/JSDOMBinding.cpp: (WebCore::objectToStringFunctionGetter):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter):
  • bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter):
  • bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter):
15:23 Changeset [44876] by simon.fraser@apple.com

2009-06-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by John Sullivan

<rdar://problem/6953673> Crash in RenderLayerCompositor::setCompositingParent

Fix a crash that could occur in complex content due to timing issues
when doing a partial layer tree rebuild which is required when painting;
setCompositingParent() could be called with a parent which has not been made
compositing yet.

15:16 Changeset [44875] by kov@webkit.org

2009-06-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Build fix. Adding missing HTMLDataGrid* files to the build.

  • GNUmakefile.am:
14:49 Changeset [44874] by pkasting@chromium.org

2009-06-19 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26460 part three
Make BMPImageReader a standalone class that is used by ICOImageDecoder
and BMPImageDecoder to decode individual BMPs within a file. These
decoders now inherit directly from ImageDecoder.


This also makes these decoders decode on-demand in isSizeAvailable() and
frameBufferAtIndex(), like the other decoders, instead of when setData()
is called, like before. This should provide a speedup on pages
containing BMPs that aren't immediately onscreen.

  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::setData): (WebCore::BMPImageDecoder::isSizeAvailable): (WebCore::BMPImageDecoder::frameBufferAtIndex): (WebCore::BMPImageDecoder::decodeWithCheckForDataEnded): (WebCore::BMPImageDecoder::decode): (WebCore::BMPImageDecoder::processFileHeader):
  • platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32):
  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::BMPImageReader): (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::readInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData): (WebCore::BMPImageReader::setFailed):
  • platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::setBuffer): (WebCore::BMPImageReader::setData): (WebCore::BMPImageReader::): (WebCore::BMPImageReader::pastEndOfImage): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::setRGBA):
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::setData): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::size): (WebCore::ICOImageDecoder::frameBufferAtIndex): (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded): (WebCore::ICOImageDecoder::decode): (WebCore::ICOImageDecoder::processDirectory): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::readDirectoryEntry): (WebCore::ICOImageDecoder::processImageType):
  • platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32):
14:31 Changeset [44873] by treat@webkit.org

2009-06-19 Adam Treat <adam.treat@torchmobile.com>

Blind attempt at build fix.

14:09 Changeset [44872] by hyatt@apple.com

Add missed file.

14:07 Changeset [44871] by bfulgham@webkit.org

2009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Inherits CallIdentifier struct from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/profiler/CallIdentifier.h:86.

  • wtf/HashCountedSet.h:
13:57 Changeset [44870] by treat@webkit.org

2009-06-19 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=26540
Currently the SunSpider test driver lacks an option to run a test suite that
will test JavaScriptCore parsing performance only. This patch adds just such
a test suite and option to SunSpider as well as the jsc test shell. I've included
three large javascript source files found in the wild: jquery, mootools and prototype.
Combined with the concatenation of all three, these form a new testsuite to measure
and test pure JavaScriptCore parsing performance.

13:38 Changeset [44869] by abarth@webkit.org

2009-06-19 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26555

Fix the Chromium canary bot. Turns out ScriptSourceCode doesn't have
the same API in V8 and JSC.

  • WebCore/bindings/js/ScriptController.cpp:
  • WebCore/bindings/js/ScriptSourceCode.h:
  • WebCore/bindings/v8/ScriptController.cpp:
  • WebCore/page/XSSAuditor.cpp:
  • WebCore/page/XSSAuditor.h:
13:30 Changeset [44868] by bfulgham@webkit.org

009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.


Inherits HashCountedSet class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Collector.cpp:1095.

  • wtf/HashCountedSet.h:
13:17 Changeset [44867] by hyatt@apple.com

WebCore:

2009-06-19 David Hyatt <hyatt@apple.com>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=26547


Implement the IDL interface for HTMLDataGridColElement.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLAttributeNames.in:
  • html/HTMLDataGridColElement.cpp: Added. (WebCore::HTMLDataGridColElement::HTMLDataGridColElement): (WebCore::HTMLDataGridColElement::label): (WebCore::HTMLDataGridColElement::setLabel): (WebCore::HTMLDataGridColElement::type): (WebCore::HTMLDataGridColElement::setType): (WebCore::HTMLDataGridColElement::sortable): (WebCore::HTMLDataGridColElement::setSortable): (WebCore::HTMLDataGridColElement::sortDirection): (WebCore::HTMLDataGridColElement::setSortDirection): (WebCore::HTMLDataGridColElement::selected): (WebCore::HTMLDataGridColElement::setSelected):
  • html/HTMLDataGridColElement.h: Added. (WebCore::HTMLDataGridColElement::endTagRequirement): (WebCore::HTMLDataGridColElement::tagPriority):
  • html/HTMLDataGridColElement.idl: Added.
  • html/HTMLDataGridElement.h:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

LayoutTests:

2009-06-19 David Hyatt <hyatt@apple.com>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=26547


Implement the IDL interface for HTMLDataGridColELement.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
13:09 Changeset [44866] by treat@webkit.org

2009-06-19 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=26558
Declare these symbols extern for WINCE as they are provided by libce.

  • runtime/DateConstructor.cpp:
  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
12:54 Changeset [44865] by bfulgham@webkit.org

2009-06-19 Chris Evans <scarybeasts@gmail.com>

Reviewed by Eric Seidel.

There is no new test because this cannot be tested deterministically.
I've not been able to cause a crash at all in the test framework, but
I have verified that this is happening in the wild and that the patch
fixes the likely cause in the debugger.

  • loader/TextResourceDecoder.cpp: careful not to iterate off the end of our input buffer looking for the end of the comment.
12:37 Changeset [44864] by mrowe@apple.com

Versioning.

12:35 Changeset [44863] by mrowe@apple.com

New tag.

11:48 Changeset [44862] by oliver@apple.com

<rdar://problem/6988973> ScopeChain leak in interpreter builds

Reviewed by Maciej Stachowiak

Move the Scopechain destruction code in JSFunction outside of the ENABLE(JIT)
path.

11:25 Changeset [44861] by abarth@webkit.org

2009-06-19 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26536

Fix external-script-URL-location.html and
write-external-script-open.html LayoutTests.

implicitOpen is called from several places. We need to setXSSAuditor
each time, so I moved the call inside implicitOpen.

  • dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::implicitOpen):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin):
11:22 Changeset [44860] by levin@chromium.org

2009-06-19 Kent Tamura <tkent@chromium.org>

Reviewed by David Levin.

Use WebCore::multipleFileUploadText() in Chromium to fix a problem
that Chromium shows only the first filename even if a user selects
multiple files for <input type=file multiple>.
<https://bugs.webkit.org/show_bug.cgi?id=26502>

  • platform/chromium/FileChooserChromium.cpp: (WebCore::FileChooser::basenameForWidth):
11:14 Changeset [44859] by mitz@apple.com

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d

Test: editing/selection/move-by-line-005.html

The root cause of this bug was searchAheadForBetterMatch() continuing
past the first rendered text object after the given object. While we
want to skip non-rendered text and empty containers, when we encounter
rendered text object, we must return a text box for that object.

  • dom/Position.cpp: (WebCore::searchAheadForBetterMatch):

LayoutTests:

Reviewed by Dave Hyatt.

  • text for <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d
  • editing/selection/move-by-line-005-expected.txt: Added.
  • editing/selection/move-by-line-005.html: Added.
10:46 Changeset [44858] by jshin@chromium.org

2009-06-18 Jungshik Shin <jshin@chromium.org>

Reviewed by David Levin

https://bugs.webkit.org/show_bug.cgi?id=25657

Chromium Linux port does not handle non-BMP characters properly.
It's fixed with a 'UTF-16 iterator macro' to extract Unicode
codepoints out of a UTF-16 input string.

A manual test is added for non-BMP character rendering,
which we can use until a small freely-distributable font
covering non-BMP is added to the Webkit source tree.

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • manual-tests/non-bmp.html: Added.
10:01 Changeset [44857] by treat@webkit.org

2009-06-19 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=26543
Windows CE uses 'GetLastError' instead of 'errno.'

  • interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::grow):
09:52 Changeset [44856] by mitz@apple.com

Reviewed by Anders Carlsson.

  • update test results after r44806
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
08:47 Changeset [44855] by dglazkov@chromium.org

2009-06-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

V8 Bindings: return proper state from the script stack.

https://bugs.webkit.org/show_bug.cgi?id=26512

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::state):
08:34 Changeset [44854] by jberlin@apple.com

2009-06-19 Jessie Berlin <jberlin@apple.com>

Reviewed by Simon Fraser.

Windows build fix.


  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
07:28 Changeset [44853] by yael.aharon@nokia.com

2009-06-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.
Build fix after 44825.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::isSizeAvailable):
  • platform/graphics/qt/ImageDecoderQt.h:
05:18 Changeset [44852] by hausmann@webkit.org

2009-06-19 Daniel Teske <qt-info@nokia.com>

Reviewed by Simon Hausmann.

Remove warnings for QString() constructions from const char *

By explicitly wrapping it with QLatin1String() / QLatin1Char()

02:58 Changeset [44851] by vestbo@webkit.org

2009-06-15 Andre Pedralho <andre.pedralho@openbossa.org>

Reviewed by Tor Arne Vestbø.

Only pass --makeargs along if an argument is given.

02:23 Changeset [44850] by oliver@apple.com

2009-06-18 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Oliver Hunt.

Bug 26426: Canvas: rotation of 'no-repeat' pattern is weird
<https://bugs.webkit.org/show_bug.cgi?id=26426>

Use 1<<23-1 as steps of no-repeat patterns instead of 100000000.0f.
The original number cannot be represented by mantissa of float
(23bit) so that it caused some error.

Test: fast/canvas/image-object-in-canvas.html:

  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
02:06 Changeset [44849] by abarth@webkit.org

Fix copy/paste error.

01:57 Changeset [44848] by abarth@webkit.org

2009-06-19 abarth <abarth@webkit.org>

Unreviewed attempt to fix the Chromium build.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::xssAuditor):
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
01:29 Changeset [44847] by abarth@webkit.org

2009-06-19 Adam Barth <abarth@webkit.org>

Unreviewed attempt to fix Windows build.

  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled):
01:12 Changeset [44846] by abarth@webkit.org

WebCore:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added an experimental reflective XSS filter. The filter is disabled by
default.

Test: http/tests/security/xssAuditor/script-tag.html

  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
  • bindings/js/ScriptController.h: (WebCore::ScriptController::xssAuditor):
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • dom/Tokenizer.h: (WebCore::Tokenizer::xssAuditor): (WebCore::Tokenizer::setXSSAuditor): (WebCore::Tokenizer::Tokenizer):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::requestObject):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setXSSAuditorEnabled):
  • page/Settings.h: (WebCore::Settings::xssAuditorEnabled):
  • page/XSSAuditor.cpp: Added. (WebCore::isControlCharacter): (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::~XSSAuditor): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h: Added. (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::setXSSAuditorEnabled):

WebKit/mac:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added preference to enable the XSSAuditor.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isXSSAuditorEnabled]): (-[WebPreferences setXSSAuditorEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

WebKit/win:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added preference to enable the XSSAuditor.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isXSSAuditorEnabled): (WebPreferences::setXSSAuditorEnabled):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

WebKitTools:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Add support for testing the XSSAuditor.

  • DumpRenderTree/LayoutTestController.cpp: (setXSSAuditorEnabledCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setPopupBlockingEnabled):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setXSSAuditorEnabled):

LayoutTests:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added a basic test for the XSSAuditor.

  • http/tests/security/xssAuditor/resources/echo-intertag.php: Added.
  • http/tests/security/xssAuditor/script-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag.html: Added.
00:59 Changeset [44845] by levin@chromium.org

2009-06-19 David Levin <levin@chromium.org>

Reviewed by NOBODY (Windows build fix).

Add export for Windows corresponding to OSX export done in r44844.

00:10 Changeset [44844] by oliver@apple.com

Bug 26532: Native functions do not correctly unlink from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> <rdar://problem/6625385>

Reviewed by Gavin "Viceroy of Venezuela" Barraclough.

We need to make sure that each native function instance correctly unlinks any references to it
when it is collected. Allowing this to happen required a few changes:

  • Every native function needs a codeblock to track the link information
  • To have this codeblock, every function now also needs its own functionbodynode so we no longer get to have a single shared instance.
  • Identifying a host function is now done by looking for CodeBlock::codeType() == NativeCode

06/18/09:

22:39 Changeset [44843] by barraclough@apple.com

2009-06-18 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY (Windows build fix).

  • wtf/DateMath.cpp: (WTF::calculateUTCOffset):
22:06 Changeset [44842] by barraclough@apple.com

2009-06-18 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Timezone calculation incorrect in Venezuela.

https://bugs.webkit.org/show_bug.cgi?id=26531
<rdar://problem/6646169> Time is incorrectly reported to JavaScript in both Safari 3 and Firefox 3

The problem is that we're calculating the timezone relative to 01/01/2000,
but the VET timezone changed from -4 hours to -4:30 hours on 12/09/2007.
According to the spec, section 15.9.1.9 states "the time since the beginning
of the year", presumably meaning the *current* year. Change the calculation
to be based on whatever the current year is, rather than a canned date.

No performance impact.

  • wtf/DateMath.cpp: (WTF::calculateUTCOffset):
22:06 Changeset [44841] by krit@webkit.org

2009-06-18 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

feOffset and objectBoundingBox
https://bugs.webkit.org/show_bug.cgi?id=26441

If we use objectBoundingBox for primitiveUnits, the fractions given
to dx or dy of feOffset must be multiplied with the referenced objects
objectBoundingBox size.

Test: svg/filters/feOffset.svg

  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):

Test for feOffset with the primitiveUnits objectBoundingBox
and userSpaceOnUse.

  • platform/mac/svg/filters/feOffset-expected.checksum: Added.
  • platform/mac/svg/filters/feOffset-expected.png: Added.
  • platform/mac/svg/filters/feOffset-expected.txt: Added.
  • svg/filters/feOffset.svg: Added.
22:00 Changeset [44840] by krit@webkit.org

2009-06-18 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

feTile implementation missing
https://bugs.webkit.org/show_bug.cgi?id=26419

Implementation of feTile, a pattern effect for SVG filters. It was
necessary to modify FilterEffect since source inputs need a secial
logic and we have to identify if an effect is a source input.

Tests: svg/batik/filters/feTile.svg

svg/filters/feTile.svg

  • platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::isSourceInput):
  • platform/graphics/filters/SourceAlpha.h: (WebCore::SourceAlpha::isSourceInput):
  • platform/graphics/filters/SourceGraphic.h: (WebCore::SourceGraphic::isSourceInput):
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):

Reviewed by Oliver Hunt.

Added a test of batik and a own one to check behavior of the
new feTile effect in SVG.

  • platform/mac/svg/batik/filters/feTile-expected.checksum: Added.
  • platform/mac/svg/batik/filters/feTile-expected.png: Added.
  • platform/mac/svg/batik/filters/feTile-expected.txt: Added.
  • platform/mac/svg/filters/feTile-expected.checksum: Added.
  • platform/mac/svg/filters/feTile-expected.png: Added.
  • platform/mac/svg/filters/feTile-expected.txt: Added.
  • svg/batik/filters/feTile.svg: Added.
  • svg/filters/feTile.svg: Added.
21:44 Changeset [44839] by krit@webkit.org

2009-06-18 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

feMerge implementation
https://bugs.webkit.org/show_bug.cgi?id=26480

Added feMerge to the SVG Filter system.

Test: svg/filters/feMerge.svg

  • svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::uniteChildEffectSubregions): (WebCore::FEMerge::apply):
  • svg/graphics/filters/SVGFEMerge.h:

Check the feMerge implementation.

  • platform/mac/svg/filters/feMerge-expected.checksum: Added.
  • platform/mac/svg/filters/feMerge-expected.png: Added.
  • platform/mac/svg/filters/feMerge-expected.txt: Added.
  • svg/filters/feMerge.svg: Added.
19:32 Changeset [44838] by barraclough@apple.com

2009-06-18 Gavin Barraclough <barraclough@apple.com>

Rubber Stamped by Mark Rowe (originally reviewed by Sam Weinig).

(Reintroducing patch added in r44492, and reverted in r44796.)

Change the implementation of op_throw so the stub function always modifies its
return address - if it doesn't find a 'catch' it will switch to a trampoline
to force a return from JIT execution. This saves memory, by avoiding the need
for a unique return for every op_throw.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):

JITStubs::cti_op_throw now always changes its return address,
remove return code generated after the stub call (this is now
handled by ctiOpThrowNotCaught).

  • jit/JITStubs.cpp: (JSC::):

Add ctiOpThrowNotCaught definitions.

(JSC::JITStubs::DEFINE_STUB_FUNCTION):

Change cti_op_throw to always change its return address.

  • jit/JITStubs.h:

Add ctiOpThrowNotCaught declaration.

18:51 Changeset [44837] by mrowe@apple.com

Speculative Windows build fix.

  • page/win/FrameCGWin.cpp: Add missing #include.
18:21 Changeset [44836] by bfulgham@webkit.org

WebCore:

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=26425
Final refactorings, picking up a few places where BitmapInfo
could be used.

  • page/win/FrameCGWin.cpp: (WebCore::imageFromRect):
  • platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):

WebKit/win:

2009-06-18 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Dave Levin.

Remove some boilerplate using the BitmapInfo struct.
https://bugs.webkit.org/show_bug.cgi?id=26425

  • WebFrame.cpp: (WebFrame::spoolPages):
  • WebIconDatabase.cpp: (createDIB):
  • WebKit.vcproj/WebKit.sln:
  • WebNodeHighlight.cpp: (WebNodeHighlight::update):
  • WebView.cpp: (WebView::ensureBackingStore):
18:20 Changeset [44835] by cfleizach@apple.com

Bug 26522: In DOM mode, VoiceOver reads some mouseover text on web sites strangely
https://bugs.webkit.org/show_bug.cgi?id=26522

18:18 Changeset [44834] by kevino@webkit.org

wx build fix after recent RenderTheme changes.

18:14 Changeset [44833] by pkasting@chromium.org

2009-06-18 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26460 part two
Attempt to minimize diff of following functional change by first landing
non-functional change to:

  • Make readUintX() public and static (since they will need to be once BMPImageReader is included in *ImageDecoder via composition rather than inheritance). Add wrappers in each class so callers can be simpler. In the next patch, these wrappers will be beefed up slightly and the callers will get even simpler.
  • Change direct setting of m_failed to use setFailed(), since in the next patch much of this code won't even have direct access to m_failed
  • Add a helper function in ICOImageDecoder to determine the image type instead of simply doing it inline
  • Rewrap lines that used to be <=80 cols and slipped over it during the original landing of these decoders
  • Other misc. changes, e.g. adding constructor definitions, reordering functions, changing RGBA32Buffer& to RGBA32Buffer*, etc. that have no functional effect but minimize the subsequent diff for readability
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::processFileHeader):
  • platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32):
  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::getInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData):
  • platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16Helper): (WebCore::BMPImageReader::readUint32Helper): (WebCore::BMPImageReader::): (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::getComponent): (WebCore::BMPImageReader::setI): (WebCore::BMPImageReader::setRGBA): (WebCore::BMPImageReader::fillRGBA):
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::size): (WebCore::ICOImageDecoder::decodeImage): (WebCore::ICOImageDecoder::processDirectory): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::isBetterEntry): (WebCore::ICOImageDecoder::processImageType):
  • platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32):
15:52 Changeset [44832] by pkasting@chromium.org

2009-06-18 Peter Kasting <pkasting@google.com>

Fix build bustage.

  • platform/image-decoders/gif/GIFImageDecoder.h:
15:34 Changeset [44831] by kmccullough@apple.com

JavaScriptCore:

2009-06-18 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit

  • Exposed functions now needed by WebCore.

WebCore:

2009-06-18 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit

Convert intptr_t to Strings so that we don't loose bits in the
conversion to JS. Previously they were being put into 32bit ints.

  • inspector/InspectorController.cpp: Convert the String back to an intptr_t. (WebCore::InspectorController::addBreakpoint): (WebCore::InspectorController::removeBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorController.idl: Use strings in JS to avoid 32bit truncation.
  • inspector/InspectorFrontend.cpp: Make the intptr_t into a String. (WebCore::InspectorFrontend::parsedScriptSource):
  • platform/text/PlatformString.h: Implemented the necessary conversion functions to be able to convert to and from an intptr_t.
  • platform/text/String.cpp: Ditto. (WebCore::String::toIntPtrStrict): (WebCore::String::toIntPtr): (WebCore::charactersToIntPtrStrict): (WebCore::charactersToIntPtr):
  • platform/text/StringImpl.cpp: Ditto. (WebCore::StringImpl::toIntPtrStrict): (WebCore::StringImpl::toIntPtr):
  • platform/text/StringImpl.h: Ditto.
15:15 Changeset [44830] by jparent@chromium.org

2009-06-18 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/insertHTML-expected.txt: Added.
  • editing/execCommand/insertHTML.html:
  • editing/execCommand/switch-list-type-expected.txt: Added.
  • editing/execCommand/switch-list-type.html:
  • platform/mac/editing/execCommand/insertHTML-expected.checksum: Removed.
  • platform/mac/editing/execCommand/insertHTML-expected.png: Removed.
  • platform/mac/editing/execCommand/insertHTML-expected.txt: Removed.
  • platform/mac/editing/execCommand/switch-list-type-expected.checksum: Removed.
  • platform/mac/editing/execCommand/switch-list-type-expected.png: Removed.
  • platform/mac/editing/execCommand/switch-list-type-expected.txt: Removed.
  • platform/qt/editing/execCommand/insertHTML-expected.txt: Removed.
  • platform/qt/editing/execCommand/switch-list-type-expected.txt: Removed.
15:04 Changeset [44829] by bfulgham@webkit.org

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

Final cleanups in this refactoring:
(1) Move WindowsBitmap implementation from CG-specific file to

the platform-common GraphicsContextWin.cpp, since it is
equally useful on both platforms.

(2) Revise the TransformationMatrix logic as suggested by

Adam Roben in his review comments to Part #2 of this
refactoring.

  • platform/graphics/win/GraphicsContextCGWin.cpp:
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): (WebCore::GraphicsContext::WindowsBitmap::~WindowsBitmap): (WebCore::GraphicsContext::createWindowsBitmap): (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
14:44 Changeset [44828] by andersca@apple.com

2009-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6926859>
NPN_ConvertPoint doesn't give the right value when converting to/from NPCoordinateSpaceFlippedScreen


When inverting Y, use the height of the first screen instead of the screen the window is on.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::windowFrameChanged): (WebKit::NetscapePluginInstanceProxy::mouseEvent):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
14:39 Changeset [44827] by kov@webkit.org

2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez and Christian Dywan.

Add a new load status to report that the first visually non-empty
layout has been done.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
  • webkit/webkitwebframe.h:
14:39 Changeset [44826] by kov@webkit.org

2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Fix parameters of navigation-policy-decision-requested callback,
to be correct in number and type

  • tests/testhttpbackend.c: (navigation_policy_decision_requested_cb):
14:29 Changeset [44825] by pkasting@chromium.org

2009-06-18 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26460 part one
Make isSizeAvailable non-const, since it's not logically const (it
triggers lazy decoding), and simplify all the implementations (without
changing behavior; just make less verbose). Remove some other
inappropriate consts, which enables the removal of all the mutable
declarations in the decoders.

  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::isSizeAvailable): (WebCore::ImageDecoder::setSize): Make public to avoid needing a friend declaration in the JPEG decoder, and because the ICO/BMP decoders will soon need this.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::isSizeAvailable): (WebCore::GIFImageDecoder::repetitionCount): (WebCore::GIFImageDecoder::decode):
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::isSizeAvailable):
  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::isSizeAvailable): (WebCore::JPEGImageDecoder::decode):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::isSizeAvailable): (WebCore::PNGImageDecoder::decode):
  • platform/image-decoders/png/PNGImageDecoder.h:
  • platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::isSizeAvailable): (WebCore::XBMImageDecoder::frameBufferAtIndex): (WebCore::XBMImageDecoder::decode):
  • platform/image-decoders/xbm/XBMImageDecoder.h: Rename decodeXBM() to decode() for consistency with the JPEG/PNG decoders, and in the future the ICO/BMP decoders.
14:25 Changeset [44824] by jparent@chromium.org

2009-06-18 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/5207369-expected.txt: Added.
  • editing/execCommand/5207369.html:
  • editing/execCommand/5210032-expected.txt: Added.
  • editing/execCommand/5210032.html:
  • editing/execCommand/5432254-1-expected.txt: Added.
  • editing/execCommand/5432254-1.html:
  • platform/mac/editing/execCommand/5207369-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5207369-expected.png: Removed.
  • platform/mac/editing/execCommand/5207369-expected.txt: Removed.
  • platform/mac/editing/execCommand/5210032-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5210032-expected.png: Removed.
  • platform/mac/editing/execCommand/5210032-expected.txt: Removed.
  • platform/mac/editing/execCommand/5432254-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5432254-1-expected.png: Removed.
  • platform/mac/editing/execCommand/5432254-1-expected.txt: Removed.
  • platform/qt/editing/execCommand/5207369-expected.txt: Removed.
  • platform/qt/editing/execCommand/5210032-expected.txt: Removed.
  • platform/qt/editing/execCommand/5432254-1-expected.txt: Removed.
14:21 Changeset [44823] by jparent@chromium.org

Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/5142012-3-expected.txt: Added.
  • editing/execCommand/5142012-3.html:
  • editing/execCommand/5144139-1-expected.txt: Added.
  • editing/execCommand/5144139-1.html:
  • editing/execCommand/5164796-expected.txt: Added.
  • editing/execCommand/5164796.html:
  • platform/mac/editing/execCommand/5142012-3-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5142012-3-expected.png: Removed.
  • platform/mac/editing/execCommand/5142012-3-expected.txt: Removed.
  • platform/mac/editing/execCommand/5144139-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5144139-1-expected.png: Removed.
  • platform/mac/editing/execCommand/5144139-1-expected.txt: Removed.
  • platform/mac/editing/execCommand/5164796-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5164796-expected.png: Removed.
  • platform/mac/editing/execCommand/5164796-expected.txt: Removed.
  • platform/qt/editing/execCommand/5142012-3-expected.txt: Removed.
  • platform/qt/editing/execCommand/5144139-1-expected.txt: Removed.
  • platform/qt/editing/execCommand/5164796-expected.txt: Removed.
14:13 Changeset [44822] by jparent@chromium.org

Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests.

This

fixes the bug 26336 partially.

  • editing/execCommand/4916583-expected.txt: Added.
  • editing/execCommand/4916583.html:
  • editing/execCommand/5119244-expected.txt: Added.
  • editing/execCommand/5119244.html:
  • editing/execCommand/5120591-expected.txt: Added.
  • editing/execCommand/5120591.html:
  • platform/mac/editing/execCommand/4916583-expected.checksum: Removed.
  • platform/mac/editing/execCommand/4916583-expected.png: Removed.
  • platform/mac/editing/execCommand/4916583-expected.txt: Removed.
  • platform/mac/editing/execCommand/5119244-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5119244-expected.png: Removed.
  • platform/mac/editing/execCommand/5119244-expected.txt: Removed.
  • platform/mac/editing/execCommand/5120591-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5120591-expected.png: Removed.
  • platform/mac/editing/execCommand/5120591-expected.txt: Removed.
  • platform/qt/editing/execCommand/4916583-expected.txt: Removed.
  • platform/qt/editing/execCommand/5119244-expected.txt: Removed.
  • platform/qt/editing/execCommand/5120591-expected.txt: Removed.
13:47 Changeset [44821] by bfulgham@webkit.org

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

Move some common functions out of platform files and into
the common implementation.

https://bugs.webkit.org/show_bug.cgi?id=26425.
Add a new platform context method (flush) so that the
getWindowsContext method can be consolidated into the common
GraphicsContextWin.cpp file.


  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::flush):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::flush):
  • platform/graphics/win/GraphicsContextCGWin.cpp: Remove getWindowContext method.
  • platform/graphics/win/GraphicsContextCairoWin.cpp: Remove getWindowContext method and fillWithClearColor methods.
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::fillWithClearColor): Moved from *CairoWin.cpp (WebCore::GraphicsContext::getWindowsContext): Moved from *CairoWin.cpp
13:44 Changeset [44820] by christian@webkit.org

2009-06-18 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::loadDone): (WebKit::FrameLoaderClient::dispatchDidFinishLoad): (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidFailLoad): Introduce the static function loadDone to emit "load-done" and update the status and update the relevent places. We missed some status notifications before.
13:30 Changeset [44819] by kov@webkit.org

2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Be consistent in always using the term URI instead of URL in the
documentation of WebKitWebView signals.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
13:28 Changeset [44818] by ojan@chromium.org

2009-06-18 Ojan Vafai <ojan@chromium.org>

Reviewed by Oliver Hunt.

Remove code that I accidentally committed in r44811.

  • editing/markup.cpp: (WebCore::createMarkup):
13:25 Changeset [44817] by simon.fraser@apple.com

2009-06-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6983207> Non-layer content is not re-rendered when transition
starts sometimes (with hardware acceleration).

When deciding which RenderLayers should be composited, when a layer goes into
compositing mode we repaint the old location. However, we did that before
we'd looked at all the factors that may force a layer to composite, so missed
some cases. Fix by doing the repaint once we really know whether it's going
to composite.

Test: compositing/repaint/become-overlay-composited-layer.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
12:58 Changeset [44816] by ap@webkit.org

Reviewed by Maciej Stachowiak and Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=26510
Add tests for authentication behavior with cross-origin XMLHttpRequest

  • http/tests/xmlhttprequest/cross-origin-authorization-expected.txt: Added.
  • http/tests/xmlhttprequest/cross-origin-authorization.html: Added.
  • http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
  • http/tests/xmlhttprequest/cross-origin-no-authorization.html: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-authorization.php: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-preset-authorization-frame.html: Added.
  • platform/mac-tiger/Skipped:
12:21 Changeset [44815] by darin@apple.com

2009-06-18 Darin Adler <darin@apple.com>

Rubber stamped by Mark Rowe.

  • DumpRenderTree/mac/DumpRenderTreeWindow.mm: (-[DumpRenderTreeWindow close]): Resolved crashes seen during regression tests. The close method can be called on a window that's already closed so we can't assert here.
12:19 Changeset [44814] by simon.fraser@apple.com

2009-06-18 Simon Fraser <simon.fraser@apple.com>

Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined, and
the Tiger build where QTMovieLayer does not exist.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::destroyQTMovieLayer): (WebCore::MediaPlayerPrivate::currentRenderingMode): (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::tearDownVideoRendering): (WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):
12:18 Changeset [44813] by darin@apple.com

JavaScriptCore:

2009-06-17 Darin Adler <darin@apple.com>

Reviewed by Oliver Hunt.

Bug 26429: Make JSON.stringify non-recursive so it can handle objects
of arbitrary complexity
https://bugs.webkit.org/show_bug.cgi?id=26429

For marking I decided not to use gcProtect, because this is inside the engine
so it's easy enough to just do marking. And that darned gcProtect does locking!
Oliver tried to convince me to used MarkedArgumentBuffer, but the constructor
for that class says "FIXME: Remove all clients of this API, then remove this API."

  • runtime/Collector.cpp: (JSC::Heap::collect): Add a call to JSONObject::markStringifiers.
  • runtime/CommonIdentifiers.cpp: (JSC::CommonIdentifiers::CommonIdentifiers): Added emptyIdentifier.
  • runtime/CommonIdentifiers.h: Ditto.
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Initialize firstStringifierToMark to 0.
  • runtime/JSGlobalData.h: Added firstStringifierToMark.
  • runtime/JSONObject.cpp: Cut down the includes to the needed ones only. (JSC::unwrapNumberOrString): Added. Helper for unwrapping number and string objects to get their number and string values. (JSC::ReplacerPropertyName::ReplacerPropertyName): Added. The class is used to wrap an identifier or integer so we don't have to do any work unless we actually call a replacer. (JSC::ReplacerPropertyName::value): Added. (JSC::gap): Added. Helper function for the Stringifier constructor. (JSC::PropertyNameForFunctionCall::PropertyNameForFunctionCall): Added. The class is used to wrap an identifier or integer so we don't have to allocate a number or string until we actually call toJSON or a replacer. (JSC::PropertyNameForFunctionCall::asJSValue): Added. (JSC::Stringifier::Stringifier): Updated and moved out of the class definition. Added code to hook this into a singly linked list for marking. (JSC::Stringifier::~Stringifier): Remove from the singly linked list. (JSC::Stringifier::mark): Mark all the objects in the holder stacks. (JSC::Stringifier::stringify): Updated. (JSC::Stringifier::appendQuotedString): Tweaked and streamlined a bit. (JSC::Stringifier::toJSON): Renamed from toJSONValue. (JSC::Stringifier::appendStringifiedValue): Renamed from stringify. Added code to use the m_holderStack to do non-recursive stringify of objects and arrays. This code also uses the timeout checker since in pathological cases it could be slow even without calling into the JavaScript virtual machine. (JSC::Stringifier::willIndent): Added. (JSC::Stringifier::indent): Added. (JSC::Stringifier::unindent): Added. (JSC::Stringifier::startNewLine): Added. (JSC::Stringifier::Holder::Holder): Added. (JSC::Stringifier::Holder::appendNextProperty): Added. This is the function that handles the format of arrays and objects. (JSC::JSONObject::getOwnPropertySlot): Moved this down to the bottom of the file so the JSONObject class is not interleaved with the Stringifier class. (JSC::JSONObject::markStringifiers): Added. Calls mark. (JSC::JSONProtoFuncStringify): Streamlined the code here. The code to compute the gap string is now a separate function.
  • runtime/JSONObject.h: Made everything private. Added markStringifiers.

LayoutTests:

2009-06-17 Darin Adler <darin@apple.com>

Reviewed by Oliver Hunt.

Bug 26429: Make JSON.stringify non-recursive so it can handle objects
of arbitrary complexity
https://bugs.webkit.org/show_bug.cgi?id=26429

  • fast/js/JSON-stringify-expected.txt: Updated.
  • fast/js/resources/JSON-stringify.js: Changed the infinite object and infinite array tests to instead just test something a fixed number of levels deep. Otherwise we end up with an infinite loop in the test, which would lead to the slow-script dialog in the production web browser. Also raised the number from 512 to 2048 since there's no fixed limit any more.
12:14 EFLWebKit edited by tonikitoo@gmail.com
(diff)
12:06 Changeset [44812] by simon.fraser@apple.com

2009-06-18 Simon Fraser <simon.fraser@apple.com>

Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::currentRenderingMode): (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::tearDownVideoRendering):
11:58 Changeset [44811] by ojan@chromium.org

2009-06-17 Erik Arvidsson <arv@chromium.org>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=15189
Adds the HTML5 input event support for textarea.


Also, moves the oninput attribute parse handling to HTMLElement so that
it can be set on any HTML element so that bubbling events can be handled
using HTML attribute handlers.

Test: fast/forms/textarea-input-event.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
11:53 Changeset [44810] by krit@webkit.org

2009-06-18 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Share code between filterEffects
https://bugs.webkit.org/show_bug.cgi?id=26479

Share more code of filter effects. The imageBuffer creation can move to
FilterEffect ant every effect asks for the GraphicsContext. Move the
drawingRect calculation to FilterEffect.

  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::calculateDrawingRect): (WebCore::FilterEffect::getEffectContext):
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply):
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
11:52 Changeset [44809] by simon.fraser@apple.com

2009-06-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=26499

Support hardware-accelerationed rendering of video elements.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks): (WebCore::HTMLMediaElement::mediaPlayerRepaint): Just move these methods to group the render-related methods together.

(WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated):
Call out method to ask the RenderLayerCompositor if presentation of this video
can be acclerated. It might say no, if, for example, the video has a reflection.

(WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer):
Fetch the GraphicsLayer from the RenderVideo that will host the movie layer.

  • html/HTMLMediaElement.h: Reordered the rendering-related methods, and added two methods related to video acceleration.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::acceleratedRenderingStateChanged): Called by the rendering system when it determines that the video must go into, or fall off of the hardware-accelerated path.

(WebCore::MediaPlayer::supportsAcceleratedRendering):
Method to say whether the media engine supports accelerated rendering.

  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerRepaint): (WebCore::MediaPlayerClient::mediaPlayerSizeChanged): Moved.

(WebCore::MediaPlayerClient::mediaPlayerRenderingCanBeAccelerated):
(WebCore::MediaPlayerClient::mediaPlayerGraphicsLayer):
New methods to ask the client if the rendering system can support accelerated
rendering, and to get a GraphicsLayer to plug the movie layer into.

  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsAcceleratedRendering): (WebCore::MediaPlayerPrivateInterface::acceleratedRenderingStateChanged): Forwarding methods from MediaPlayer.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Some new methods related to using a QTMovieLayer, and to simplify the rendering mode logic.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::destroyQTMovieLayer): Methods to create and destroy the QTMovieLayer.

(WebCore::MediaPlayerPrivate::currentRenderingMode):
(WebCore::MediaPlayerPrivate::preferredRenderingMode):
Methods to clarify the code that decides which of the 3 rendering modes to use.

(WebCore::MediaPlayerPrivate::setUpVideoRendering):
Changed to use the new rendering mode methods.

(WebCore::MediaPlayerPrivate::tearDownVideoRendering):
Destroy the layer if we have one.

(WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):
Small utility method.

(WebCore::MediaPlayerPrivate::updateStates):
Move the call to setUpVideoRendering() to before we send out the state notifications,
so that we will have created the rendering objects already.

(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
Return true if we have QTMovieLayer.

(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
We've been told that we went into or out of accelerated mode; maybe reset
the renderer, and set the layer if we have to.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::rendererContentChanged): We may need to udpate compositing layers if the video went into accelerated mode.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::canUseDirectCompositing): Add smarts to deal with video, which allows us to avoid extra backing store.

(WebCore::RenderLayerBacking::contentsBox):
Use the videoBox to use the content layer for video layers.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateLayerCompositingState): Poke the RenderVideo if the state changed.

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
Handle an edge case when the video element itself is a stacking context
because of opacity or transform.

(WebCore::RenderLayerCompositor::canAccelerateVideoRendering):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
Allow video to throw us into compositing mode if the media engine supports it.

  • rendering/RenderLayerCompositor.h: New methods related to video.
  • rendering/RenderVideo.h:
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer): Call rendererContentChanged() to give the compositor a change to throw the video into compositing mode.

(WebCore::RenderVideo::supportsAcceleratedRendering):
(WebCore::RenderVideo::acceleratedRenderingStateChanged):
(WebCore::RenderVideo::videoGraphicsLayer):
Methods to allow the MediaPlayer to do rendering-related stuff via the media element.

11:40 Changeset [44808] by rwlbuis@webkit.org

Reviewed by Niko.

https://bugs.webkit.org/show_bug.cgi?id=26385
Root SVG element is not checked on requiredFeatures, requiredExtension like other elements

Also do the isValid check for outer <svg>.

Test: svg/custom/outer-svg-unknown-feature.svg

11:08 Changeset [44807] by simon.fraser@apple.com

2009-06-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=26499

New expected results after making <video> elements get RenderLayers.

  • platform/mac/fast/replaced/border-radius-clip-expected.txt:
10:54 Changeset [44806] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6913221> REGRESSION (Safari 3-4): Search field on apple.com cuts entered text

Test: fast/forms/search-vertical-alignment.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): Vertically center the

the search field's inner block.

LayoutTests:

Reviewed by Darin Adler.

  • test and updated result for <rdar://problem/6913221> REGRESSION (Safari 3-4): Search field on apple.com cuts entered text
  • fast/forms/search-vertical-alignment.html: Added.
  • platform/mac/fast/forms/search-vertical-alignment-expected.checksum: Added.
  • platform/mac/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt: Added.
  • platform/mac/fast/forms/search-zoomed-expected.checksum:
  • platform/mac/fast/forms/search-zoomed-expected.png:
  • platform/mac/fast/forms/search-zoomed-expected.txt:
09:30 EFLWebKit edited by tonikitoo@gmail.com
(diff)
09:28 EFLWebKit edited by tonikitoo@gmail.com
(diff)
08:08 Changeset [44805] by hausmann@webkit.org

2009-06-18 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Simon Hausmann.

Fix compilation with Symbian WINSCW compiler, which produced
multiple definitions of the CSSPrimitiveValue conversion operators.

It turns out that they are defined inline but not declared inline.

Adding the inline keyword to the declaration fixes the build.

07:45 Changeset [44804] by hausmann@webkit.org

2009-06-18 Friedemann Kleint <Friedemann.Kleint@nokia.com>

Reviewed by Simon Hausmann.

Fixed MinGW compilation.

07:41 Changeset [44803] by hausmann@webkit.org

2009-06-18 Markus Goetz <Markus.Goetz@nokia.com>

Reviewed by Simon Hausman.

Clarify in docs how to compile with debug information.

07:40 EFLWebKit edited by tonikitoo@gmail.com
(diff)
06:42 Changeset [44802] by ariya@webkit.org

2009-06-18 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] When writing an URL to the clipboard, save the corresponding title
in the mime data as well.

  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeURL):
06:40 Changeset [44801] by ariya@webkit.org

2009-06-18 Jakub Wieczorek <faw217@gmail.com>

[Qt] Fix build. Add HTMLDataGridElement.

  • WebCore.pro:
03:25 Changeset [44800] by jmalonzo@webkit.org

2009-06-18 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix.

Add HTMLDataGridElement header and IDL to the build script.

  • GNUmakefile.am:
00:55 Changeset [44799] by abarth@webkit.org

WebCore:

2009-06-18 Chris Evans <scarybeasts@gmail.com>

Reviewed by Adam Barth.

Fix 8-digit long hex entities. Fixes bug 26454
https://bugs.webkit.org/show_bug.cgi?id=26454

Test: fast/parser/eightdigithexentity.html

  • html/HTMLTokenizer.cpp: fix off-by-ones.

LayoutTests:

2009-06-18 Chris Evans <scarybeasts@gmail.com>

Reviewed by Adam Barth.

Added test for bug 26454 (broken 8-digit hex entities).
https://bugs.webkit.org/show_bug.cgi?id=26454

  • fast/parser/eightdigithexentity-expected.txt: Added.
  • fast/parser/eightdigithexentity.html: Added.
00:08 Changeset [44798] by levin@chromium.org

2009-06-18 David Levin <levin@chromium.org>

Fix chromium linux build.

Fixes a mistake that happened during the complicated merge for
landing r44775, r44776, r44777.

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::create):
Note: See TracTimeline for information about the timeline view.