Timeline


and

06/23/09:

23:40 Changeset [45063] by oliver@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add expected results for test i landed earlier

23:26 Changeset [45062] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-06-23 Eric Seidel <eric@webkit.org>

Reviewed by Dave Levin.

Fix missing comment message during land-patches and SVN.commit_with_message respecting --dry-run
https://bugs.webkit.org/show_bug.cgi?id=26669

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
23:25 Changeset [45061] by barraclough@apple.com
  • 29 edits in branches/nitro-extreme/JavaScriptCore

Merged r44075:44076 into nitro-extreme branch. (Adds infrastructure for op_method_check, but does not implement optimization.)

23:19 Changeset [45060] by oliver@apple.com
  • 15 edits
    2 adds in trunk

<rdar://problem/6164797> Add Canvas API to allow drawing of <video> frames
<https://bugs.webkit.org/show_bug.cgi?id=25920>

Reviewed by Sam Weinig and Dave Hyatt.

Add support for drawing the contents of the video element to the canvas
in accordance with the current HTML5 draft.

Test: media/video-canvas.html

22:55 Changeset [45059] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-06-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Bit off a tiny bit more of standardizing opcode behavior to help with result
caching.


SunSpider reports no change, v8 maybe a tiny speedup.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emitSlow_op_to_jsnumber): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emitSlow_op_convert_this):
22:37 Changeset [45058] by barraclough@apple.com
  • 90 edits
    9 copies
    2 deletes in branches/nitro-extreme

Merged r44030:44075 into nitro-extreme branch.

22:31 Changeset [45057] by ggaren@apple.com
  • 12 edits in branches/nitro-extreme/JavaScriptCore

2009-06-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Bit off a tiny bit more of standardizing opcode behavior to help with result
caching -- including removing my old enemy, op_resolve_function, because
it was non-standard, and removing it felt better than helping it limp along.


SunSpider reports no change, v8 maybe a tiny speedup.


  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emitSlow_op_to_primitive):
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • parser/Nodes.cpp: (JSC::FunctionCallResolveNode::emitBytecode):
22:16 Changeset [45056] by barraclough@apple.com
  • 17 edits
    1 copy in branches/nitro-extreme/JavaScriptCore

Merged r44029:44030 into nitro-extreme branch.

21:56 Changeset [45055] by barraclough@apple.com
  • 18 edits
    8 copies in branches/nitro-extreme

Merged r44000:44029 into nitro-extreme branch.

21:41 Changeset [45054] by barraclough@apple.com
  • 192 edits
    51 copies
    6 deletes in branches/nitro-extreme

Merged r43853:44000 into nitro-extreme branch.

21:33 Changeset [45053] by barraclough@apple.com
  • 9 edits
    18 copies in branches/nitro-extreme

Merged r43848:43853 into nitro-extreme branch.

21:26 Changeset [45052] by barraclough@apple.com
  • 203 edits
    84 copies
    47 deletes in branches/nitro-extreme

Merged r43781:43848 into nitro-extreme branch.

21:19 Changeset [45051] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-06-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Bit off a tiny bit of standardizing opcode behavior to help with result
caching.


0.6% SunSpider speedup. 0.3% v8 speedup.

  • jit/JITInlineMethods.h: (JSC::JIT::emitLoad): Accomodate a base register that overlaps with payload by loading tag before payload, to avoid stomping base/payload.
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_mov): Abide by the standard "tag in regT1, payload in regT0" semantics.

(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var): Ditto. Also, removed some irrelevent
loads while I was at it. The global object's "d" pointer never changes
after construction.

21:16 Changeset [45050] by barraclough@apple.com
  • 10 edits in branches/nitro-extreme/JavaScriptCore

Merged r43780:43781 into nitro-extreme branch.

20:13 Changeset [45049] by barraclough@apple.com
  • 72 edits
    8 copies in branches/nitro-extreme

Merged r43750:43780 into nitro-extreme branch.

20:11 Changeset [45048] by mrowe@apple.com
  • 3 edits
    2 adds in branches/WWDC-2009-branch

Merge r44799.

20:11 Changeset [45047] by mrowe@apple.com
  • 14 edits in branches/WWDC-2009-branch/WebCore

Merge r44749.

20:11 Changeset [45046] by mrowe@apple.com
  • 15 edits
    4 adds in branches/WWDC-2009-branch

Merge r44519.

20:11 Changeset [45045] by mrowe@apple.com
  • 13 edits in branches/WWDC-2009-branch/WebCore

Merge r44266.

20:11 Changeset [45044] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/LayoutTests/http/tests/security/postMessage

Merge r44134.

20:11 Changeset [45043] by mrowe@apple.com
  • 4 edits
    1 add in branches/WWDC-2009-branch/LayoutTests

Merge r44133.

20:11 Changeset [45042] by mrowe@apple.com
  • 1 edit in branches/WWDC-2009-branch/WebCore/ChangeLog

Merge r44125.

20:11 Changeset [45041] by mrowe@apple.com
  • 4 edits
    3 adds in branches/WWDC-2009-branch

Merge r44124.

19:59 Changeset [45040] by barraclough@apple.com
  • 167 edits
    73 copies
    97 deletes in branches/nitro-extreme

Merged r43666:43750 into nitro-extreme branch.

19:47 Changeset [45039] by oliver@apple.com
  • 7 edits
    2 adds in trunk

<rdar://problem/6992806> REGRESSION: Enumeration can skip new properties in cases of prototypes that have more than 64 (26593)
<https://bugs.webkit.org/show_bug.cgi?id=26593>

Reviewed by Gavin Barraclough.

Add tests to ensure we correctly invalidate caching that depends on structure chains
that include dictionaries.

19:45 WikiStart edited by whzeng@126.com
(diff)
19:41 Changeset [45038] by agl@chromium.org
  • 3 edits in trunk/WebCore

2009-06-23 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium: Fix crash with inherited font-size in <option>

https://bugs.webkit.org/show_bug.cgi?id=26656
http://code.google.com/p/chromium/issues/detail?id=14853

In r42597 (https://bugs.webkit.org/show_bug.cgi?id=25244), I changed
the <select> handing for Chromium to fix a rendering bug. However,
although the font-size is correctly ignored, getRowHeight wasn't
updated and so was calculating the height of the rows in an
inconsistent manner. This can lead to a crash.

  • manual-tests/optgroup-empty-and-nested.html: adding test case for crash
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::getRowHeight):
19:38 WikiStart edited by whzeng@126.com
Add maxthon's port. (diff)
19:37 Changeset [45037] by barraclough@apple.com
  • 85 edits
    13 copies
    1 delete in branches/nitro-extreme

Merged r43660:43666 into nitro-extreme branch.

19:18 Changeset [45036] by barraclough@apple.com
  • 27 edits
    15 copies in branches/nitro-extreme

Merged r43642:43660 into nitro-extreme branch.

19:13 Changeset [45035] by barraclough@apple.com
  • 43 edits in branches/nitro-extreme

Merged r43641:43642 into nitro-extreme branch.

19:08 Changeset [45034] by barraclough@apple.com
  • 47 edits
    6 copies in branches/nitro-extreme

Merged r43619:43641 into nitro-extreme branch.

19:02 Changeset [45033] by barraclough@apple.com
  • 14 edits in branches/nitro-extreme/JavaScriptCore

Merged r43618:43619 into nitro-extreme branch.

18:50 Changeset [45032] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-23 Takeshi Yoshino <tyoshino@google.com>

Reviewed by Mark Rowe.

Bug 26537: Builds from command-line fail if custom build product directory is set and ~/Library/Preferences/xcodebuild.plist exists
https://bugs.webkit.org/show_bug.cgi?id=26537

Let determineBaseProductDir subroutine remove
~/Library/Preferences/xcodebuild.plist. It can prevent xcodebuild from
respecting global settings such as a custom build products directory
(<rdar://problem/5585899>).

  • Scripts/webkitdirs.pm:
18:49 Changeset [45031] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-06-23 Brady Eidson <beidson@apple.com>

Patch by Antti Koivisto.
Reviewed by Brady Eidson.

<rdar://problem/6988010> Failed resources not reloaded when built against Tiger SDK

A latent bug that cache revalidation uncovered. When a CachedResource failed to load,
it should always be revalidated upon reload.

  • loader/CachedResource.cpp: (WebCore::CachedResource::canUseCacheValidator): (WebCore::CachedResource::mustRevalidate):
18:45 Changeset [45030] by barraclough@apple.com
  • 25 edits
    13 copies in branches/nitro-extreme

Merged r43598:43618 into nitro-extreme branch.

18:40 Changeset [45029] by barraclough@apple.com
  • 32 edits
    21 copies
    2 deletes in branches/nitro-extreme

Merged r43583:43598 into nitro-extreme branch.

18:36 Changeset [45028] by barraclough@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

Merged r43582:43583 into nitro-extreme branch.

18:33 Changeset [45027] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2009-06-23 Ojan Vafai <ojan@chromium.org>

Reviewed by Mark Rowe.

Resets the results for a test that was missed in
http://trac.webkit.org/changeset/45016.

  • editing/execCommand/5142012-3-expected.txt:
18:31 Changeset [45026] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-06-23 Eric Seidel <eric@webkit.org>

Reviewed by Dave Levin.

Make SCM.run_command smarter, and make all previous
os.system and subprocess.popen use SCM.run_command instead.
https://bugs.webkit.org/show_bug.cgi?id=26666

This makes it easier to handle errors in a standard way throughout all the code.
Since this new code raises by default when the exit_code != 0,
we should prevent future problems of bugzilla-tool continuing after
a git or svn command failed.

  • Scripts/modules/scm.py:
18:29 Changeset [45025] by barraclough@apple.com
  • 21 edits
    4 copies in branches/nitro-extreme

Merged r43560:43582 into nitro-extreme branch.

18:14 Changeset [45024] by barraclough@apple.com
  • 8 edits in branches/nitro-extreme

Merged r43559:43560 into nitro-extreme branch.

18:00 Changeset [45023] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

17:57 Changeset [45022] by mrowe@apple.com
  • 1 edit in branches/WWDC-2009-branch/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Versioning.

17:44 Changeset [45021] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2009-06-23 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6950660> REGRESSION: iSale 5.5.3 crashes after I click a template to load

Due to some subtle WebKit changes - presumably some delegate callback behavior - a latent bug in
iSale was uncovered where they aren't properly retaining their FrameLoadDelegate, and we ended up
calling back to a dealloc'ed object.

  • WebView/WebView.mm: (-[WebView _needsAdobeFrameReloadingQuirk]): Use more intelligent C++-style initialization. (-[WebView _needsKeyboardEventDisambiguationQuirks]): Ditto. (-[WebView _needsFrameLoadDelegateRetainQuirk]): YES for iSale versions under 5.6 (-[WebView dealloc]): Release the delegate if the quirk is in effect. (-[WebView setFrameLoadDelegate:]): Retain the new delegate if the quirk is in effect.
17:41 Changeset [45020] by barraclough@apple.com
  • 11 edits in branches/nitro-extreme/JavaScriptCore

Merged r43558:43559 into nitro-extreme branch.

17:40 Changeset [45019] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix <rdar://problem/6634228> Crash in [NSScroller mouseDown:] beneath EventHandler::passMouseDownEventToWidget()
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseDownEventToWidget): Surround the -mouseDown: call with calls to Widget::beforeMouseDown() and Widget::afterMouseDown(), which prevent the widget's view hierarchy from being removed from its parent view while the scroller is tracking the mouse.
17:39 Changeset [45018] by weinig@apple.com
  • 10 edits
    7 adds in trunk

WebCore:

2009-06-23 Sam Weinig <sam@webkit.org>

Reviewed by Dave Hyatt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26516
Add initial implementation of DataGridDataSource

  • Initial implementation only supports the initialize callback function.

Test: fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html

  • WebCore.xcodeproj/project.pbxproj:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDataGridDataSource.cpp: Added. (WebCore::JSDataGridDataSource::JSDataGridDataSource): (WebCore::JSDataGridDataSource::~JSDataGridDataSource): (WebCore::JSDataGridDataSource::initialize):
  • bindings/js/JSDataGridDataSource.h: Added. (WebCore::JSDataGridDataSource::create): (WebCore::JSDataGridDataSource::isJSDataGridDataSource): (WebCore::JSDataGridDataSource::jsDataSource): (WebCore::asJSDataGridDataSource):
  • bindings/js/JSHTMLDataGridElementCustom.cpp: Added. (WebCore::JSHTMLDataGridElement::listener): (WebCore::JSHTMLDataGridElement::setListener):
  • html/DataGridDataSource.h: Added. (WebCore::DataGridDataSource::~DataGridDataSource): (WebCore::DataGridDataSource::isJSDataGridDataSource):
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::HTMLDataGridElement): (WebCore::HTMLDataGridElement::setDataSource): (WebCore::HTMLDataGridElement::initializationTimerFired):
  • html/HTMLDataGridElement.h: (WebCore::HTMLDataGridElement::dataSource):
  • html/HTMLDataGridElement.idl:

LayoutTests:

2009-06-23 Sam Weinig <sam@webkit.org>

Reviewed by Dave Hyatt.

Test for https://bugs.webkit.org/show_bug.cgi?id=26516
Add initial implementation of DataGridDataSource

  • fast/dom/HTMLDataGridElement: Added.
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic-expected.txt: Added.
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html: Added.
17:09 Changeset [45017] by barraclough@apple.com
  • 8 edits in branches/nitro-extreme/JavaScriptCore

2009-06-23 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Remove 'arguments' field from Register union (again).
This time do so without breaking tests (radical, I know).

  • interpreter/CallFrame.h: (JSC::ExecState::optionalCalleeArguments): (JSC::ExecState::setArgumentCount): (JSC::ExecState::init):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
  • interpreter/Register.h: (JSC::Register::withInt): (JSC::Register::): (JSC::Register::Register): (JSC::Register::i):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_tear_off_arguments):
  • runtime/Arguments.h: (JSC::JSActivation::copyRegisters): (JSC::Register::arguments):
  • runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
  • runtime/JSActivation.h:
16:56 Changeset [45016] by jparent@chromium.org
  • 20 edits
    2 adds in trunk

WebCore:

2009-06-23 Ryosuke Niwa <rniwa@google.com>

Reviewed by Justin Garcia.

Undo the changeset 21212 to fix the regression bug 14062.
The changeset 21212 attempted to fix rdar://problem/5002441.
The changeset 21212 modified InsertTextCommand::input so as to convert
all spaces in text to non-breaking spaces for rdar://problem/5002441.
However, the bug was originally caused by rebalanceWhitespaceAt
and this workaround introduced a regression bug 14062.
Because rebalanceWhitespaceAt appears to behave correctly now,
the workaround introduced in 21212 is no longer needed.

Test: editing/inserting/space-after-removeformat.html

  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):

LayoutTests:

2009-06-23 Ryosuke Niwa <rniwa@google.com>

Reviewed by Justin Garcia.

Undo the changeset 21212 to fix the regression bug 14062.
The changeset 21212 attempted to fix rdar://problem/5002441.
The changeset 21212 modified InsertTextCommand::input so as to convert
all spaces in text to non-breaking spaces for rdar://problem/5002441.
However, the bug was originally caused by rebalanceWhitespaceAt
and this workaround introduced a regression bug 14062.
Because rebalanceWhitespaceAt appears to behave correctly now,
the workaround introduced in 21212 is no longer needed.

The following test cases are affected by this change.
This patch removes unappropriate non-breaking spaces (&nbsp;) and
inserts normal spaces instead.

  • editing/deleting/2610675-1-expected.txt: Replaced.
  • editing/deleting/2610675-2-expected.txt: Replaced.
  • editing/deleting/2610675-3-expected.txt: Replaced.
  • editing/inserting/insert-before-link-1-expected.txt: Replaced.
  • editing/inserting/space-after-removeformat-expected.txt: Added.
  • editing/inserting/space-after-removeformat.html: Added.
  • platform/mac/editing/execCommand/5482023-expected.checksum: Replaced.
  • platform/mac/editing/execCommand/5482023-expected.png: Replaced.
  • platform/mac/editing/execCommand/5482023-expected.txt: Replaced.
  • platform/mac/editing/input/text-input-controller-expected.txt: Replaced.
  • platform/mac/editing/inserting/editable-html-element-expected.checksum: Replaced.
  • platform/mac/editing/inserting/editable-html-element-expected.png: Replaced.
  • platform/mac/editing/inserting/editable-html-element-expected.txt: Replaced.
  • platform/mac/editing/pasteboard/4989774-expected.checksum: Replaced.
  • platform/mac/editing/pasteboard/4989774-expected.png: Replaced.
  • platform/mac/editing/pasteboard/4989774-expected.txt: Replaced.
  • platform/mac/editing/selection/4983858-expected.checksum: Replaced.
  • platform/mac/editing/selection/4983858-expected.png: Replaced.
  • platform/mac/editing/selection/4983858-expected.txt: Replaced.
16:42 Changeset [45015] by bdakin@apple.com
  • 8 edits
    6 adds in trunk

WebCore:

2009-06-23 Beth Dakin <bdakin@apple.com>

Reviewed by Dave Hyatt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26523 <col>
elements width can't be changed with javascript

This patch both fixes setting the width attribute directly in
JavaScript, and setting the width on the style attribute.

  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::parseMappedAttribute): If we have a new width, call setNeedsLayoutAndPrefWidthsRecalc()

Call calcPrefWidths() on the table cols.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):


Call layoutIfNeeded on the table cols.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::clippedOverflowRectForRepaint): Use new table() convenience function. (WebCore::RenderTableCol::calcPrefWidths): Just call setPrefWidthsDirty(false) on ourself and our children. (WebCore::RenderTableCol::table):
  • rendering/RenderTableCol.h:

LayoutTests:

2009-06-23 Beth Dakin <bdakin@apple.com>

Reviewed by Dave Hyatt.

Test for https://bugs.webkit.org/show_bug.cgi?id=26523 <col>
elements width can't be changed with javascript

  • fast/dom/HTMLTableColElement: Added.
  • fast/dom/HTMLTableColElement/resize-table-using-col-width.html: Added.
  • platform/mac/fast/dom/HTMLTableColElement: Added.
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.
16:35 Changeset [45014] by ojan@chromium.org
  • 8 edits
    5 adds in trunk

WebCore:

2009-06-23 Ojan Vafai <ojan@chromium.org>

Reviewed by Dan Bernstein.

Add logic to CSSStyleDeclaration::diff to deal with font-sizes that are
keyword values. When diff is called on a CSSStyleDeclaration, we check
the keywordSize to see if font-size matches a keyword value.

This ensures that when we diff a CSSMutableStyleDeclaration returned from
copyInheritableProperties on a CSSComputedStyleDeclaration that we
correctly identify matching font-sizes.

https://bugs.webkit.org/show_bug.cgi?id=26279

Test: editing/inserting/font-size-clears-from-typing-style.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
  • css/CSSComputedStyleDeclaration.h:
  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::cssPropertyMatches): (WebCore::CSSStyleDeclaration::diff):
  • css/CSSStyleDeclaration.h:

LayoutTests:

2009-06-23 Ojan Vafai <ojan@chromium.org>

Reviewed by Dan Bernstein.

This test hits an edge case where typingStyle would never get cleared.
In addition to making every text insertion go into its own text node,
this caused large performance problems.

https://bugs.webkit.org/show_bug.cgi?id=26279

  • editing/execCommand/5770834-1-expected.txt:

These results match how they were before r43243. It's not clear to me
why changes to font-size are affecting text-align styling though.

  • editing/inserting/font-size-clears-from-typing-style-expected.txt: Added.
  • editing/inserting/font-size-clears-from-typing-style.html: Added.
  • editing/inserting/resources/TEMPLATE.html: Copied from LayoutTests/editing/execCommand/resources/TEMPLATE.html.
  • editing/inserting/resources/font-size-clears-from-typing-style.js: Added.
  • platform/mac/editing/execCommand/remove-formatting-2-expected.txt:
16:18 Changeset [45013] by ggaren@apple.com
  • 9 edits in branches/nitro-extreme/JavaScriptCore

2009-06-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Removed some result register tracking cruft in preparation for a new
result tracking mechanism.


SunSpider reports no change.

  • assembler/AbstractMacroAssembler.h:
  • assembler/X86Assembler.h: (JSC::X86Assembler::JmpDst::JmpDst): No need to track jump targets in machine code; we already do this in bytecode.
  • jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::emitTimeoutCheck): Make sure to save and restore the result registers, so an opcode with a timeout check can still benefit from result register caching.

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases): Removed calls to killLastResultRegister()
in preparation for something new.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jnlesseq):
  • jit/JITInlineMethods.h: (JSC::JIT::emitGetFromCallFrameHeaderPtr): (JSC::JIT::emitGetFromCallFrameHeader32):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jmp): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_jsr): (JSC::JIT::emit_op_sret): (JSC::JIT::emit_op_jmp_scopes): ditto
  • jit/JITStubCall.h: (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::getArgument): added a mechanism for reloading an argument you passed to a JIT stub, for use in emitTimeoutCheck.
16:10 Changeset [45012] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-23 Joe Mason <joe.mason@torchmobile.com>

Reviewed by Adam Treat.

https://bugs.webkit.org/show_bug.cgi?id=26664

  • Scripts/prepare-ChangeLog: Added --git-index mode to list only the changes which are already staged in the index. Useful to create an entry for what you're about to commit while ignoring unstaged changes.
16:06 Changeset [45011] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-23 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=26654
Add the proper export define for the JavaScriptCore API when building for WINCE.

15:38 Changeset [45010] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-06-23 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

  • Fix <rdar://problem/6965672>


Defer calls to WKPCInvalidateRect, so we don't try to invalidate while waiting for a reply, since
that is too early.


  • Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::isProcessingRequests):
  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): (WebKit::NetscapePluginHostProxy::processRequests): (WKPCInvalidateRect):
15:25 Changeset [45009] by kmccullough@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-06-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6994790> CrashTracer: [USER] 8 crashes in Mail trying to
add a blank line to pasted Facebook content (under
CompositeEditCommand::positionAvoidingSpecialElementBoundary)

  • Just added null checks and I will create a new bug to prevent the bad behavior.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):

LayoutTests:

2009-06-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6994790> CrashTracer: [USER] 8 crashes in Mail trying to
add a blank line to pasted Facebook content (under
CompositeEditCommand::positionAvoidingSpecialElementBoundary)

  • editing/inserting/return-with-object-element-expected.txt: Added.
  • editing/inserting/return-with-object-element.html: Added.
14:51 Changeset [45008] by weinig@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-06-23 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Remove now-useless inplace variants of binary ops.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_bitand): (JSC::JIT::emit_op_bitor): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emit_op_add): (JSC::JIT::emit_op_sub): (JSC::JIT::emit_op_mul):
14:48 Changeset [45007] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-06-23 Simon Fraser <simon.fraser@apple.com>

Build fix.

Wrap shouldDoSoftwarePaint() in #if USE(ACCELERATED_COMPOSITING) to avoid warning when
ACCELERATED_COMPOSITING is not defined.

  • rendering/RenderLayer.cpp:
14:43 Changeset [45006] by weinig@apple.com
  • 6 edits in branches/nitro-extreme/JavaScriptCore

2009-06-23 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Move off memory operands to aid in re-enabling result caching.

  • No regression measured.
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emit_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emit_op_bitand): (JSC::JIT::emitBitAnd32Constant): (JSC::JIT::emitBitAnd32InPlace): (JSC::JIT::emit_op_bitor): (JSC::JIT::emitBitOr32Constant): (JSC::JIT::emitBitOr32InPlace): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emitBitXor32Constant): (JSC::JIT::emitBitXor32InPlace): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emitSlow_op_pre_dec): (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitAdd32InPlace): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlowAdd32Constant): (JSC::JIT::emit_op_sub): (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSub32ConstantLeft): (JSC::JIT::emitSub32ConstantRight): (JSC::JIT::emitSub32InPlaceLeft): (JSC::JIT::emitSub32InPlaceRight): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul): (JSC::JIT::emitMul32InPlace): (JSC::JIT::emit_op_div): (JSC::JIT::emit_op_mod):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emit_op_not): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emit_op_to_jsnumber):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val):
14:25 Changeset [45005] by simon.fraser@apple.com
  • 6 edits
    4 adds in trunk

2009-06-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24863

Fix reflection painting on elements with compositing layers.

Test: compositing/reflections/reflection-on-composited.html

  • rendering/RenderLayer.h: Add a new PaintLayerPaintingReflection flag which is set while painting inside reflections. (WebCore::RenderLayer::setPaintingInsideReflection): Add a setter so that RenderLayerBacking can call it.
  • rendering/RenderLayer.cpp: (WebCore::shouldDoSoftwarePaint): Utility to clarify the logic of when a composited layer should do a software paint.

(WebCore::RenderLayer::paintLayer):
Use shouldDoSoftwarePaint() to determine when to software-paint a reflected layer.
Remove transform-related tests from the reflection-painting if test because they appear
to be unnecessary.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer): Add the code to paint reflections to the composited layer painting method.
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint): Set the PaintLayerPaintingReflection flag.
13:26 Changeset [45004] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-06-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed some missing and/or misplaced labels in bytecode generation, so
we don't have to work around them in JIT code generation.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitJumpSubroutine):
  • parser/Nodes.cpp: (JSC::TryNode::emitBytecode):
13:01 Changeset [45003] by antti@apple.com
  • 7 edits in trunk

WebCore:

2009-06-23 Antti Koivisto <antti@apple.com>

Reviewed by Darin Adler.


https://bugs.webkit.org/show_bug.cgi?id=26643
Memory cache should respect Cache-Control: no-store


Make resources with Cache-Control: no-store uncacheable in the memory cache.
They get evicted immediately when all clients are gone and are always
reloaded from the server.

Conforms to RFC2616 14.9.2 and seems also match Firefox behavior.

  • loader/CachedResource.cpp: (WebCore::CachedResource::removeClient): (WebCore::CachedResource::canUseCacheValidator): (WebCore::CachedResource::mustRevalidate):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::parseCacheControlDirectives): (WebCore::ResourceResponseBase::cacheControlContainsNoStore):
  • platform/network/ResourceResponseBase.h:

LayoutTests:

2009-06-23 Antti Koivisto <antti@apple.com>

Reviewed by Darin Adler.


https://bugs.webkit.org/show_bug.cgi?id=26643
Memory cache should respect Cache-Control: no-store


Update the test to cover no-store.

  • http/tests/cache/subresource-expiration-expected.txt:
  • http/tests/cache/subresource-expiration.html:
12:48 Changeset [45002] by beidson@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

12:46 Changeset [45001] by simon.fraser@apple.com
  • 6 edits in trunk/WebCore

2009-06-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

First part of https://bugs.webkit.org/show_bug.cgi?id=26652

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): (WebCore::RenderLayer::paintLayer):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::):
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint): Replace the 3 boolean params to RenderLayer::paintLayer() with a bit mask for readability.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer): (WebCore::RenderLayerBacking::paintContents):
  • rendering/RenderLayerBacking.h: Remove the unused 'haveTransparency' param to paintIntoLayer().
12:12 Changeset [45000] by kmccullough@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

2009-06-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6902203> REGRESSION: 'Return' insertion point incorrect
after manually quoting blank line then hitting return

If the insertion point is both the begining and ending visible position
then we need to insert at the end instead of the begining, which is what
would normally happen if the insertion point was as the begining.

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):

LayoutTests:

2009-06-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6902203> REGRESSION: 'Return' insertion point incorrect
after manually quoting blank line then hitting return

  • editing/inserting/insert-br-quoted-007-expected.txt: Added.
  • editing/inserting/insert-br-quoted-007.html: Added.
12:05 Changeset [44999] by beidson@apple.com
  • 13 edits in trunk/WebCore

2009-06-23 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig, and looked over by Eric Carlson.

<rdar://problem/6980466> Media elements should provide option for changing pitch correction

Introduce a new boolean property to HTMLMediaElement called webkitPreservesPitch for script to control this.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Currently the platforms that have a flexible pitch preservation property (Quicktime on Mac and Win) have had it on by default, so continue that default for now. (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::webkitPreservesPitch): (WebCore::HTMLMediaElement::setWebkitPreservesPitch):
  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::setPreservesPitch): (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::preservesPitch): (WebCore::MediaPlayer::setPreservesPitch):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setPreservesPitch):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createQTMovie): Rework to allow recreation of the movie with almost the exact same attributes as before, with pitch preservation being the difference. (WebCore::MediaPlayerPrivate::setPreservesPitch): Recreate the QTMovie if the flag actually changes. (WebCore::MediaPlayerPrivate::updateStates): Restore current time and rate if this is a recreated movie. (WebCore::MediaPlayerPrivate::timeChanged): Clear the time-to-be-restored, as this callback means it has been effectively overwritten.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::setPreservesPitch):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::QTMovieWinPrivate): (QTMovieWinPrivate::~QTMovieWinPrivate): (QTMovieWinPrivate::task): Restore current time and rate if this is a re-created movie. (QTMovieWin::play): Clear the time-to-be-restored, as this effectively overwrites it. (QTMovieWin::pause): Ditto. (QTMovieWin::setRate): Ditto. (QTMovieWin::setCurrentTime): Ditto. (QTMovieWin::setPreservesPitch): Recreate the Movie if the flag actually changes. (QTMovieWin::load): Rework to allow recreation of the Movie with similar state as the movie before it, but changing the pitch preservation flag.
  • platform/graphics/win/QTMovieWin.h:
12:04 Changeset [44998] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-06-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6998286> Crash after leaving page with <video>


Don't try to post events after going into the page cache.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::documentWillBecomeInactive): Cancel pending events and stop event timers so we won't try to post events after going into the cache.
11:52 Changeset [44997] by darin@chromium.org
  • 5 edits in trunk/WebCore

2009-06-23 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Brady Eidson.

Simplify the interaction between LocalStorageArea/SessionStorageArea
and StorageArea by creating a "blockUntilImportComplete()" function
rather than bouncing back and forth between the child and parent
classes in a somewhat unintuitive manner.

This patch also paves the way for LocalStorageArea and
SessionStorageArea being merged into one. It's part of several in a
set which are separating syncing (to disk) code from the rest of the
implementation so that local storage and session storage's code can be
unified.

https://bugs.webkit.org/show_bug.cgi?id=25376

  • storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::blockUntilImportComplete):
  • storage/LocalStorageArea.h:
  • storage/StorageArea.cpp: (WebCore::StorageArea::length): (WebCore::StorageArea::key): (WebCore::StorageArea::getItem): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear): (WebCore::StorageArea::contains):
  • storage/StorageArea.h: (WebCore::StorageArea::blockUntilImportComplete):
11:36 Changeset [44996] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-06-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6997929> Assertion at WebCore::RenderLayer::updateClipRects with hardware acceleration

The updatingControlTints() painting pass goes through compositing layer boundaries,
so we need to ensure we don't cache clip rects computed with the wrong root by
setting temporaryClipRects to true.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer): Remove a printf that I left in by mistake.
11:03 Changeset [44995] by andersca@apple.com
  • 10 edits in trunk

WebCore:

2009-06-23 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

WebCore side of <rdar://problem/6946094>.


  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::setExternalDataObject):
  • platform/win/ClipboardWin.h:

WebKit/win:

2009-06-23 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

WebKit side of <rdar://problem/6946094>.

  • Interfaces/IWebUIDelegate.idl: Add a newPasteboard out parameter to willPerformDragSourceAction.


  • WebCoreSupport/WebDragClient.cpp: (WebDragClient::willPerformDragSourceAction): Implement this. If the client returns a new pasteboard, use it for the drag.


  • WebCoreSupport/WebInspectorDelegate.h: (WebInspectorDelegate::willPerformDragSourceAction): Add the new parameter.

WebKitTools:

2009-06-23 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.


Update for WebKit changes.


  • DumpRenderTree/win/UIDelegate.h: (UIDelegate::willPerformDragSourceAction):
10:29 Changeset [44994] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-06-23 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26650

Add setFormContentType and setFormData since it is awkward for Chromium
to use setFormInfoFromRequest to set the underlying members. Also, add
a clearChildren method that Chromium needs. These methods are used as
part of the Chromium code that serializes a HistoryItem for storing in
the browser's session history.

  • history/HistoryItem.cpp:
  • history/HistoryItem.h:
08:45 Changeset [44993] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-23 Joe Mason <joe.mason@torchmobile.com>

Reviewed by Adam Treat.

Authors: Yong Li <yong.li@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>

https://bugs.webkit.org/show_bug.cgi?id=26611
Implement currentThreadStackBase on WINCE by adding a global,
g_stackBase, which must be set to the address of a local variable
by the caller before calling any WebKit function that invokes JSC.

08:44 Changeset [44992] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

2009-06-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by NOBODY, layout tests fix.


'timeupdate' events are, by definition, timing dependent so it isn't
a good idea to log them in layout test results.

  • media/event-attributes-expected.txt:
  • media/event-attributes.html:
07:49 Changeset [44991] by eric.carlson@apple.com
  • 11 edits
    2 adds in trunk

2009-06-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6978938> Need HTML 5 event attributes for media elements

Test: media/event-attributes.html

  • html/HTMLAttributeNames.in: Add media event attribute names.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute): Handle media event attributes.

2009-06-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.


<rdar://problem/6978938> Need HTML 5 event attributes for media elements

  • media/event-attributes-expected.txt: Added.
  • media/event-attributes.html: Added.
  • media/progress-event-total.html: Cleanup, use event handler attributes.
  • media/progress-event.html: Ditto.
  • media/video-size-intrinsic-scale.html: Remove duplicate 'waitForEvent("ratechange")'
  • media/video-source-add-src.html: Ditto.
  • media/video-source-error.html: Ditto.
  • media/video-timeupdate-during-playback.html: Ditto.
  • platform/gtk/Skipped: Skip new test.
06:03 Changeset [44990] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-06-23 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Simon Hausmann.

Fix Qt build with Phonon.

The #include <phonon> header no longer exists. And the <Phonon> or
<Phonon/Phonon> headers have never existed (neither for us nor for the
Phonon sources). You have to select each and every header that you do
want now.

05:43 Changeset [44989] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Remove duplicated code in Qt & GTK logging initialization

We now share the getChannelFromName() function in Logging.cpp

  • platform/gtk/LoggingGtk.cpp:
  • platform/qt/LoggingQt.cpp:
05:43 Changeset [44988] by vestbo@webkit.org
  • 12 edits in trunk/WebCore

2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Rename the plugin logging channel to plural form 'Plugins'

This matches both the other logging channel names, as well as the
WebKit logging channel used by Safari/Mac for plugins.

  • platform/Logging.cpp:
  • platform/Logging.h:
  • platform/gtk/LoggingGtk.cpp:
  • platform/mac/LoggingMac.mm:
  • platform/qt/LoggingQt.cpp:
  • platform/win/LoggingWin.cpp:
  • plugins/PluginDebug.h:
  • plugins/gtk/PluginPackageGtk.cpp:
  • plugins/mac/PluginPackageMac.cpp:
  • plugins/mac/PluginViewMac.cpp:
  • plugins/qt/PluginPackageQt.cpp:
03:17 Changeset [44987] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Fix NPAPI mouse translation issues on Mac

The WindowRef we pass to the plugin refers to the the top level window,
so the x and y positions have to be relative to this position, but we
have to manually compensate for title bar decorations and other parents
of the QWebView since contentsToWindow() only traverses to the QWebView.

Previously we did this compensation when passing on mouse coordinates to
the plugin, which caused various issues with translations such as not
being able to close the Flash settings dialog, or the hand cursor not
appearing over links.

We now do the compensation as part of the call to NPP_SetWindow, and
then pass mouse coordinates in global context without any compensation,
similar to how both Safari and Mozilla does it.

03:11 Changeset [44986] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] Resolve absolute path to library install_name manually

Since our target.path is set to the Qt directory (to be able
to do 'make install') the 'absolute_library_soname' option
to QMake did not do the right thing.

We now compute the absolute path manually using DESTDIR.

  • WebCore.pro:
02:17 Changeset [44985] by abarth@webkit.org
  • 2 edits
    25 copies
    1 delete in trunk/LayoutTests

2009-06-23 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26589

More tests for the XSSAuditor. (I converted the server side to Perl
after Sam reviewed the patch because the PHP scripts didn't agree with
the Tiger and Windows buildbots.)

  • http/tests/security/xssAuditor/img-onerror-tricky-expected.txt: Added.
  • http/tests/security/xssAuditor/img-onerror-tricky.html: Added.
  • http/tests/security/xssAuditor/link-onclick-expected.txt: Added.
  • http/tests/security/xssAuditor/link-onclick.html: Added.
  • http/tests/security/xssAuditor/property-escape-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape.html: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-post.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag.php: Removed.
  • http/tests/security/xssAuditor/resources/echo-intertag.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-property.pl: Added.
  • http/tests/security/xssAuditor/resources/redir.php: Added.
  • http/tests/security/xssAuditor/resources/xss.js: Added.
  • http/tests/security/xssAuditor/script-tag-convoluted-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-convoluted.html: Added.
  • http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-open-redirect.html: Added.
  • http/tests/security/xssAuditor/script-tag-post-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-post.html: Added.
  • http/tests/security/xssAuditor/script-tag-redirect-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-redirect.html: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source.html: Added.
  • http/tests/security/xssAuditor/script-tag.html:
02:14 Changeset [44984] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix stupid performance problem in the LiteralParser

Reviewed by Alexey Proskuryakov.

The LiteralParser was making a new UString in order to use
toDouble, however UString's toDouble allows a much wider range
of numberic strings than the LiteralParser accepts, and requires
an additional heap allocation or two for the construciton of the
UString. To rectify this we just call WTF::dtoa directly using
a stack allocated buffer to hold the validated numeric literal.

02:11 Changeset [44983] by abarth@webkit.org
  • 2 edits
    1 copy
    25 deletes in trunk/LayoutTests

Revert 44981. The buildbots hate me.

02:01 Changeset [44982] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-23 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

  • Scripts/modules/scm.py: Fix commit_with_message to return the commit output.
01:51 Changeset [44981] by abarth@webkit.org
  • 2 edits
    25 adds
    1 delete in trunk/LayoutTests

2009-06-23 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26589

More tests for the XSSAuditor. (I converted the server side to Perl
after Sam reviewed the patch because the PHP scripts didn't agree with
the Tiger and Windows buildbots.)

  • http/tests/security/xssAuditor/img-onerror-tricky-expected.txt: Added.
  • http/tests/security/xssAuditor/img-onerror-tricky.html: Added.
  • http/tests/security/xssAuditor/link-onclick-expected.txt: Added.
  • http/tests/security/xssAuditor/link-onclick.html: Added.
  • http/tests/security/xssAuditor/property-escape-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape.html: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-post.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag.php: Removed.
  • http/tests/security/xssAuditor/resources/echo-intertag.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-property.pl: Added.
  • http/tests/security/xssAuditor/resources/redir.php: Added.
  • http/tests/security/xssAuditor/resources/xss.js: Added.
  • http/tests/security/xssAuditor/script-tag-convoluted-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-convoluted.html: Added.
  • http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-open-redirect.html: Added.
  • http/tests/security/xssAuditor/script-tag-post-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-post.html: Added.
  • http/tests/security/xssAuditor/script-tag-redirect-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-redirect.html: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source.html: Added.
  • http/tests/security/xssAuditor/script-tag.html:
01:46 Changeset [44980] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-23 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

  • Scripts/modules/scm.py: Fix error seen when commiting r44979.
01:40 Changeset [44979] by eric@webkit.org
  • 1 edit
    5 adds in trunk/WebKitTools

2009-06-18 Eric Seidel <eric@webkit.org>

Reviewed by Dave Levin.

WebKit needs a script to interact with bugzilla and automate
parts of the patch posting and commit processes.
https://bugs.webkit.org/show_bug.cgi?id=26283

This is really a first-draft tool.
It's to the point where it's useful to more people than just me now though.
Git support works. SVN support is written, but mostly untested.

This tool requires BeautifulSoup and mechanize python modules to run:
sudo easy_install BeautifulSoup
sudo easy_install mechanize

More important than the tool itself are the Bugzilla, Git and SVN class abstractions
which I hope will allow easy writing of future tools.

The tool currently implements 10 commands, described below.

Helpers for scripting dealing with the commit queue:
bugs-to-commit Bugs in the commit queue
patches-to-commit Patches attached to bugs in the commit queue

Dealing with bugzilla:
reviewed-patches BUGID r+'d patches on a bug
apply-patches BUGID Applies all patches on a bug to the local working directory without committing.
land-and-update BUGID Lands the current working directory diff and updates the bug.
land-patches [options] BUGID Lands all patches on a bug optionally testing them first
obsolete-attachments BUGID Marks all attachments on a bug as obsolete.
commit-message Prints a commit message suitable for the uncommitted changes.

These effectively replace git-send-bugzilla:
post-diff BUGID Attaches the current working directory diff to a bug as a patch file.
post-commits BUGID COMMITISH Attaches a range of local commits to a bug as patch files.

post-diff works for SVN and Git, post-commits only works for SCMs with local-commit support (like Git)

land-* commands in a Git environment only work with simple patches due to svn-apply bugs:
https://bugs.webkit.org/show_bug.cgi?id=26299
https://bugs.webkit.org/show_bug.cgi?id=26300

This script follows python style (similar to how for Obj-C we follow AppKit style)
http://www.python.org/doc/essays/styleguide.html
The Python community has a strong style culture and the WebKit style guide is silent re: Python.

I've filed a bug to update the WebKit style guide to mention python:
https://bugs.webkit.org/show_bug.cgi?id=26524

  • Scripts/bugzilla-tool: Added.
00:48 Changeset [44978] by abarth@webkit.org
  • 2 edits
    22 deletes in trunk/LayoutTests

Revert 44977 because Tiger and Windows don't like the new tests.

00:11 Changeset [44977] by abarth@webkit.org
  • 2 edits
    22 adds in trunk/LayoutTests

2009-06-23 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26589

More tests for the XSSAuditor.

  • http/tests/security/xssAuditor/link-onclick-expected.txt: Added.
  • http/tests/security/xssAuditor/link-onclick.html: Added.
  • http/tests/security/xssAuditor/property-escape-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape.html: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.php: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-post.php: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-utf-7.php: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag.php:
  • http/tests/security/xssAuditor/resources/echo-property.php: Added.
  • http/tests/security/xssAuditor/resources/redir.php: Added.
  • http/tests/security/xssAuditor/resources/xss.js: Added.
  • http/tests/security/xssAuditor/script-tag-convoluted-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-convoluted.html: Added.
  • http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-open-redirect.html: Added.
  • http/tests/security/xssAuditor/script-tag-post-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-post.html: Added.
  • http/tests/security/xssAuditor/script-tag-redirect-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-redirect.html: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source.html: Added.
00:00 Changeset [44976] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-06-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


For member function calls, emit "this" directly into the "this" slot
for the function call, instead of moving it there later. This reduces
time spent in op_mov during certain calls, like "a.b.c()".


1%-2% speedup on v8, mostly richards and delta-blue.

  • parser/Nodes.cpp: (JSC::FunctionCallDotNode::emitBytecode):

06/22/09:

22:53 Changeset [44975] by ap@webkit.org
  • 5 edits in trunk/LayoutTests

2009-06-22 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=17820

Skip layout tests for DST if the test runs not in PST/PDT.

  • fast/js/date-DST-time-cusps-expected.txt:
  • fast/js/date-big-setdate-expected.txt:
  • fast/js/resources/date-DST-time-cusps.js:
  • fast/js/resources/date-big-setdate.js:
22:44 Changeset [44974] by oliver@apple.com
  • 6 edits in trunk

Bug 26640: JSON.stringify needs to special case Boolean objects
<https://bugs.webkit.org/show_bug.cgi?id=26640>

Reviewed by Alexey Proskuryakov.

Add special case handling of the Boolean object so we match current
ES5 errata.

21:53 Changeset [44973] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-06-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6991146> Scrollbars in hardware layers don't change to the
inactive look in background windows

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Don't short-circuit the "painting" pass that is used to udpate control tints.
21:36 Changeset [44972] by dglazkov@chromium.org
  • 3 edits
    1 add in trunk/WebCore

2009-06-22 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26567
Upstream V8 bindings code generator. With this change, also added interface ancestor
traversal to IDL parser, which is necessary for V8 bindings. The traversal is used
to determine whether an interface is a Node to facilitate proper casting and storage
in V8DOMMap.

  • bindings/scripts/CodeGenerator.pm: Added parent traversal sub, needed

by V8 bindings.

  • bindings/scripts/CodeGeneratorV8.pm: Added.
  • bindings/scripts/IDLParser.pm: Modified to allow limited parsing for

parent traversal cases.

20:37 Changeset [44971] by barraclough@apple.com
  • 8 edits in branches/nitro-extreme/JavaScriptCore

2009-06-22 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Remove 'arguments' field from Register union. Having JSCell derived types in the union is
dangerous since it opens the possibility for the field to be written as a raw pointer but
then read as a JSValue. This will lead to statle data being read for the tag, which may
be dangerous. Having removed Arguments* types form Register, all arguments objects must
always explicitly be stored in the register file as JSValues.

  • interpreter/CallFrame.h: (JSC::ExecState::optionalCalleeArguments):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
  • interpreter/Register.h: (JSC::Register::):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_tear_off_arguments):
  • runtime/Arguments.h: (JSC::JSActivation::copyRegisters):
  • runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
  • runtime/JSActivation.h:
20:07 Changeset [44970] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Roll out r44967 as that build slave hates freedom.

20:05 Changeset [44969] by weinig@apple.com
  • 8 edits in trunk

WebCore:

2009-06-22 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Add event handler attribute getter/setters to HTMLFrameSetElement
as specified in HTML 5. These match the ones on HTMLBodyElement.

  • dom/Node.h:
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::onblur): (WebCore::HTMLFrameSetElement::setOnblur): (WebCore::HTMLFrameSetElement::onerror): (WebCore::HTMLFrameSetElement::setOnerror): (WebCore::HTMLFrameSetElement::onfocus): (WebCore::HTMLFrameSetElement::setOnfocus): (WebCore::HTMLFrameSetElement::onload): (WebCore::HTMLFrameSetElement::setOnload): (WebCore::HTMLFrameSetElement::onbeforeunload): (WebCore::HTMLFrameSetElement::setOnbeforeunload): (WebCore::HTMLFrameSetElement::onmessage): (WebCore::HTMLFrameSetElement::setOnmessage): (WebCore::HTMLFrameSetElement::onoffline): (WebCore::HTMLFrameSetElement::setOnoffline): (WebCore::HTMLFrameSetElement::ononline): (WebCore::HTMLFrameSetElement::setOnonline): (WebCore::HTMLFrameSetElement::onresize): (WebCore::HTMLFrameSetElement::setOnresize): (WebCore::HTMLFrameSetElement::onstorage): (WebCore::HTMLFrameSetElement::setOnstorage): (WebCore::HTMLFrameSetElement::onunload): (WebCore::HTMLFrameSetElement::setOnunload):
  • html/HTMLFrameSetElement.h:
  • html/HTMLFrameSetElement.idl:

LayoutTests:

2009-06-22 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Add event handler attribute getter/setters to HTMLFrameSetElement
as specified in HTML 5. These match the ones on HTMLBodyElement.

  • fast/dom/event-attribute-availability-expected.txt:
  • fast/dom/resources/event-attribute-availability.js:
18:27 Changeset [44968] by oliver@apple.com
  • 5 edits in trunk

Bug 26591: Support revivers in JSON.parse
<https://bugs.webkit.org/show_bug.cgi?id=26591>

Reviewed by Darin Adler.

Add reviver support to JSON.parse. This completes the JSON object.

18:27 Changeset [44967] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Update build.webkit.org config for new machine.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
18:04 Changeset [44966] by darin@apple.com
  • 6 edits in trunk/WebCore

2009-06-22 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
https://bugs.webkit.org/show_bug.cgi?id=25425

  • bindings/scripts/CodeGeneratorJS.pm: Added handling for ReflectURL.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • dom/Element.cpp: (WebCore::Element::getURLAttribute): Added. For use implementing getters for ReflectURL.
  • dom/Element.h: Added getURLAttribute.
  • html/HTMLImageElement.idl: Use Reflect and ReflectURL.
17:41 Changeset [44965] by jianli@chromium.org
  • 2 edits in trunk/WebCore

2009-06-22 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 26626: Make WorkerContextExecutionProxy::toV8Object handle exception
objects.
https://bugs.webkit.org/show_bug.cgi?id=26626

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object):
16:24 Changeset [44964] by hyatt@apple.com
  • 10 edits
    2 adds in trunk/WebCore

2009-06-22 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig.

Add RenderDataGrid to the build. Give it some basic default styling (that more or less matches a listbox). It has a default size
of 300x150.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • css/html4.css:
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::createRenderer):
  • html/HTMLDataGridElement.h:
  • html/HTMLDataGridElement.idl:
  • rendering/RenderDataGrid.cpp: Added. (WebCore::RenderDataGrid::RenderDataGrid): (WebCore::RenderDataGrid::~RenderDataGrid): (WebCore::RenderDataGrid::calcPrefWidths): (WebCore::RenderDataGrid::paintObject): (WebCore::RenderDataGrid::valueChanged): (WebCore::RenderDataGrid::invalidateScrollbarRect): (WebCore::RenderDataGrid::isActive):
  • rendering/RenderDataGrid.h: Added. (WebCore::RenderDataGrid::renderName): (WebCore::RenderDataGrid::canHaveChildren): (WebCore::RenderDataGrid::scrollbarCornerPresent):
16:01 Changeset [44963] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Remove errant line of code mistakenly checked in.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main):
16:00 Changeset [44962] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Pass correct value to setShouldPaintNativeControls.


Rubber stamped by Mark Rowe.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main):
15:45 Changeset [44961] by simon.fraser@apple.com
  • 7 edits
    2 adds in trunk

2009-06-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=26430
<rdar://problem/6944442> Elements jump around when they become composited (WWDC checkers demo)
<rdar://problem/6989006> Lots of time spent in RenderLayerCompositor::calculateCompositedBounds()

during window resize when using hardware layers

Fix an ordering dependency which caused the compositing position of a layer
to be affected by some later sibling, which affected the compositing ancestor's
composited bounds.

The fix is to only update the compositing positions of layers in some subtree
when updateAfterLayout() has been called on all the layers in that subtree,
from the ancestor down.

Also cache the composited bounds of a RenderLayerBacking, now that we can
guarantee that those bounds are accurate.

Test: compositing/sibling-positioning.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::hitTestLayer):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::updateAfterLayout): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer): (WebCore::RenderLayerBacking::paintContents): (WebCore::RenderLayerBacking::compositedBounds): (WebCore::RenderLayerBacking::setCompositedBounds):
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::updateLayerCompositingState): (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::layerWillBeRemoved): (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::updateCompositingChildrenGeometry):
  • rendering/RenderLayerCompositor.h:
15:41 Moving to Git edited by joe.mason@torchmobile.com
Add link to evmar's doc (diff)
15:31 Moving to Git edited by joe.mason@torchmobile.com
Discussion of patch review branches (diff)
14:59 Changeset [44960] by barraclough@apple.com
  • 5 edits in branches/nitro-extreme

Merged r43552:43558 into nitro-extreme branch.

14:58 Changeset [44959] by darin@chromium.org
  • 15 edits
    2 copies in trunk/WebCore

2009-06-22 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

First step in https://bugs.webkit.org/show_bug.cgi?id=25376

Add StorageSyncManager.cpp/h

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

In preparation for combining SessionStorage and LocalStorage into a
single StorageManager, move the syncing bits out of LocalStorage and
into its own class.

The next step is to combine LocalStorageArea and SessionStorageArea
into one. Then SessionStorage and LocalStorage can be combined.

Note that combining them will cut down on code paths that must be
proxied, eliminate virtual dispatch, and allow Chromium to (eventually)
write historical sessionStorage to disk when memory is getting tight.

Also remove a couple bits of cruft including code for quotas which is
unnecessary (since a meta-data db is unnecessary since you can just
count bytes as you read the local storage databases into memory).

  • storage/LocalStorage.cpp: (WebCore::LocalStorage::LocalStorage): (WebCore::LocalStorage::storageArea): (WebCore::LocalStorage::close):
  • storage/LocalStorage.h:
  • storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::scheduleFinalSync): (WebCore::LocalStorageArea::syncTimerFired): (WebCore::LocalStorageArea::performImport):
  • storage/LocalStorageArea.h: (WebCore::LocalStorageArea::create):
  • storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::performTask):
  • storage/LocalStorageTask.h: (WebCore::LocalStorageTask::): (WebCore::LocalStorageTask::createImport):
  • storage/LocalStorageThread.cpp:
  • storage/LocalStorageThread.h:
  • storage/SessionStorage.h:
  • storage/StorageSyncManager.cpp: Copied from WebCore/storage/LocalStorage.cpp. (WebCore::StorageSyncManager::create): (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::fullDatabaseFilename): (WebCore::StorageSyncManager::close): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
  • storage/StorageSyncManager.h: Copied from WebCore/storage/LocalStorage.h. (WebCore::):
14:47 Changeset [44958] by barraclough@apple.com
  • 2 edits in branches/nitro-extreme

Merged r43550:43552 into nitro-extreme branch - fix error in merging changelogs.

14:43 Changeset [44957] by barraclough@apple.com
  • 5 edits
    7 copies in branches/nitro-extreme

Merged r43550:43552 into nitro-extreme branch.

14:38 Changeset [44956] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-06-22 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26622
Add ChromiumDataObject::copy()

  • platform/chromium/ChromiumDataObject.cpp:
  • platform/chromium/ChromiumDataObject.h:
14:31 Changeset [44955] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Add Mail on Tiger and Leopard to the list of applications that need the WebView init thread workaround.

<rdar://problem/6929524> Console shows WebKit Threading Violations from Mail

Reviewed by Anders Carlsson.

  • WebView/WebView.mm: (clientNeedsWebViewInitThreadWorkaround): Return true for com.apple.Mail.
14:30 Moving to Git edited by treat@kde.org
(diff)
14:25 Changeset [44954] by timothy@apple.com
  • 2 edits
    1 add in trunk/WebCore

Add a silhouette image for the enable view of the Resource panel.

Reviewed by Kevin McCullough.

  • inspector/front-end/Images/resourcesSilhouette.png: Added.
  • inspector/front-end/inspector.css:
14:02 Changeset [44953] by levin@chromium.org
  • 2 edits
    1 add in trunk/WebCore

2009-06-22 Kyle Prete <kylep@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26552
Add V8 JS bindings for Audio Constructor.

  • bindings/v8/custom/V8CustomBinding.h: Added a callback declaration for audio ctor to macro.
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Added the whole file.
13:14 Changeset [44952] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26600
StringImpl::copy() no longer copies empty string correctly

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::ustring): Changed method calling syntax to look less like calling a static method. (WebCore::StringImpl::copy): Reverted part of r41917 that caused the problem.
12:51 Changeset [44951] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

  • speculative fix for <rdar://problem/6889082> Crash at -[WebHTMLView(WebPrivate) _updateMouseoverWithEvent:]

The crash seems to happen because lastHitView points to a deleted
object. Since -close calls -_clearLastHitViewIfSelf, I speculate that
lastHitView has been set to an already-closed view.

  • WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]): Return nil if the view is closed.
12:34 Changeset [44950] by levin@chromium.org
  • 3 edits in trunk/LayoutTests

2009-06-22 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix layout tests to account for removal of DOMStringList, which was done
in http://trac.webkit.org/changeset/44943.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
12:20 Changeset [44949] by barraclough@apple.com
  • 3 edits in branches/nitro-extreme/WebCore

Merged r43544:43550 into nitro-extreme branch.

11:54 Changeset [44948] by jshin@chromium.org
  • 2 edits
    1 add in trunk/WebCore

2009-06-22 Xiaomei Ji <xji@chromium.org>

Reviewed by Eric Seidel

Not auto-testable since it involves sending a keyboard event to
the popup, which is not possible (eventSender sends the key
events through webview, we want to go through the webwidget).

This patch is one part of the fix for issue "keyboard selection in
Hebrew select element does not work in Windows". The other part of the
fix is in chromium's webkit/glue layer.
https://bugs.webkit.org/show_bug.cgi?id=25899

  • manual-tests/keyboard_select_non_english.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::isCharacterTypeEvent): Added. Check whether the event is a character type event. "Char" in Windows or "KeyDown" in Mac is character type event. (WebCore::PopupListBox::typeAheadFind): Since m_lastCharTime is used to indicate whether user types multiple characters continuely as a search prefix or not, it should be only assigned when the event is character type event.
11:51 Changeset [44947] by kmccullough@apple.com
  • 5 edits in trunk/WebCore

2009-06-22 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6115819> Notify of profile start in console

Put a message in the console that announces that a profile has started,
similar to how a console message announces that a profile has finished.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): Use renamed function. (WebCore::InspectorController::addProfileFinishedMessageToConsole): Renamed. (WebCore::InspectorController::addStartProfilingMessageToConsole): New function that logs the message about the profile starting. (WebCore::InspectorController::startUserInitiatedProfiling): Ditto
  • inspector/InspectorController.h:
  • inspector/front-end/ProfilesPanel.js: Print the "run" of the profile's title if there are multiple profiles, and take into account the fact that titles are displayed twice as much now. (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink):
  • page/Console.cpp: (WebCore::Console::profile): Call new function.
11:47 Changeset [44946] by hyatt@apple.com
  • 17 edits
    3 adds in trunk/WebCore

2009-06-22 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26615

Add IDL interface for datagrid cell elements. Add a few more properties to the datagrid itself that
correspond to ones you find on <select> elements.

Add an expanded property to row elements.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLAttributeNames.in:
  • html/HTMLDataGridCellElement.cpp: Added. (WebCore::HTMLDataGridCellElement::HTMLDataGridCellElement): (WebCore::HTMLDataGridCellElement::label): (WebCore::HTMLDataGridCellElement::setLabel): (WebCore::HTMLDataGridCellElement::focused): (WebCore::HTMLDataGridCellElement::setFocused): (WebCore::HTMLDataGridCellElement::checked): (WebCore::HTMLDataGridCellElement::setChecked): (WebCore::HTMLDataGridCellElement::indeterminate): (WebCore::HTMLDataGridCellElement::setIndeterminate): (WebCore::HTMLDataGridCellElement::progress): (WebCore::HTMLDataGridCellElement::setProgress):
  • html/HTMLDataGridCellElement.h: Added. (WebCore::HTMLDataGridCellElement::endTagRequirement): (WebCore::HTMLDataGridCellElement::tagPriority):
  • html/HTMLDataGridCellElement.idl: Added.
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::autofocus): (WebCore::HTMLDataGridElement::setAutofocus): (WebCore::HTMLDataGridElement::disabled): (WebCore::HTMLDataGridElement::setDisabled): (WebCore::HTMLDataGridElement::size): (WebCore::HTMLDataGridElement::setSize):
  • html/HTMLDataGridElement.h:
  • html/HTMLDataGridElement.idl:
  • html/HTMLDataGridRowElement.cpp: (WebCore::HTMLDataGridRowElement::checkDTD): (WebCore::HTMLDataGridRowElement::expanded): (WebCore::HTMLDataGridRowElement::setExpanded):
  • html/HTMLDataGridRowElement.h:
  • html/HTMLDataGridRowElement.idl:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
11:32 Changeset [44945] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Fix last DumpRenderTree change to correctly set preferences flag without crashing.


Reviewed by Mark Rowe.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main):
11:32 Changeset [44944] by weinig@apple.com
  • 13 edits in trunk

WebCore:

2009-06-22 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Add event handler attribute getter/setters to HTMLBodyElement
as specified in HTML 5.

  • Removes erroneous inclusion of the onresize and onunload event handler attributes in Element and Document.
  • dom/Document.cpp: (WebCore::Document::getWindowAttributeEventListener):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.cpp:
  • dom/Node.h: onblur, onerror, onfocus, and onload all need to be declared virtual, since their behavior for HTMLBodyElement differs from the base implementation.
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::onblur): (WebCore::HTMLBodyElement::setOnblur): (WebCore::HTMLBodyElement::onerror): (WebCore::HTMLBodyElement::setOnerror): (WebCore::HTMLBodyElement::onfocus): (WebCore::HTMLBodyElement::setOnfocus): (WebCore::HTMLBodyElement::onload): (WebCore::HTMLBodyElement::setOnload): (WebCore::HTMLBodyElement::onbeforeunload): (WebCore::HTMLBodyElement::setOnbeforeunload): (WebCore::HTMLBodyElement::onmessage): (WebCore::HTMLBodyElement::setOnmessage): (WebCore::HTMLBodyElement::onoffline): (WebCore::HTMLBodyElement::setOnoffline): (WebCore::HTMLBodyElement::ononline): (WebCore::HTMLBodyElement::setOnonline): (WebCore::HTMLBodyElement::onresize): (WebCore::HTMLBodyElement::setOnresize): (WebCore::HTMLBodyElement::onstorage): (WebCore::HTMLBodyElement::setOnstorage): (WebCore::HTMLBodyElement::onunload): (WebCore::HTMLBodyElement::setOnunload):
  • html/HTMLBodyElement.h:
  • html/HTMLBodyElement.idl:

LayoutTests:

2009-06-22 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Add event handler attribute getter/setters to HTMLBodyElement
as specified in HTML 5.

  • fast/dom/event-attribute-availability-expected.txt:
  • fast/dom/resources/event-attribute-availability.js:
11:22 Changeset [44943] by ap@webkit.org
  • 24 edits
    7 deletes in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26601
Remove disabled code for appcache dynamic entries

This also removes code for DOM 3 Core DOMStringList, which we don't use for anything else yet.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDOMStringListCustom.cpp: Removed.
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMStringListCustom.cpp: Removed.
  • dom/DOMStringList.cpp: Removed.
  • dom/DOMStringList.h: Removed.
  • dom/DOMStringList.idl: Removed.
  • dom/StaticStringList.cpp: Removed.
  • dom/StaticStringList.h: Removed.
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addResource):
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
  • loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::dumpType):
  • loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeUpdatedType):
  • loader/appcache/DOMApplicationCache.cpp:
  • loader/appcache/DOMApplicationCache.h:
  • loader/appcache/DOMApplicationCache.idl:
  • page/DOMWindow.idl:
10:56 Changeset [44942] by sfalken@apple.com
  • 3 edits in trunk/WebCore

Windows build fix.

  • DerivedSources.cpp:
  • html/HTMLElementsAllInOne.cpp:
10:33 Changeset [44941] by ap@webkit.org
  • 4 edits in trunk

Reviewed by John Sullivan.

<rdar://problem/6956606> REGRESSION (S4Beta -> Final): After the password is input,
Japanese can't be input.

WebKit uses a per-frame input context for most editable fields, and application's global
context for password fields, manually controlling secure input state and the list of available
input methods.

We were setting TSMDocument property to disable non-Roman input methods after focus changed
to a password field, but before selection was updated. This resulted in the property being
applied to a wrong TSMDocument in some cases, because TSMGetActiveDocument() uses input
context cached by +[NSApplication updateWindows], we change context based on selection,
not on focus.

  • page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Since there is only one context that we use for password fields - the global one - there is no need to get the active one.
10:20 Changeset [44940] by levin@chromium.org
  • 8 edits
    3 adds in trunk

WebCore:

2009-06-22 David Levin <levin@chromium.org>

Reviewed by David Hyatt and Eric Seidel.

REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326

Test: scrollbars/scrollbar-crash-on-refresh.html

  • dom/Document.cpp: (WebCore::Document::detach): Gives the FrameView a change to do any necessary cleanup on Document::detach() which is where the renderArena gets detroyed.
  • page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars): Gets rid of any custom scrollbars (if the docment supplied them).
  • page/FrameView.h:
  • platform/Scrollbar.h: (WebCore::Scrollbar::isCustomScrollbar):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Removed the check for document()->frame(). If frame() is 0 in this code, then the call to animation() is also incorrect (since it does document()->frame()->animation()).
  • rendering/RenderScrollbar.h: (WebCore::RenderScrollbar::isCustomScrollbar):

LayoutTests:

2009-06-22 David Levin <levin@chromium.org>

Reviewed by David Hyatt and Eric Seidel.

REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326

Test that refreshing an iframe with custom scrollbars works without crashing.

  • scrollbars/resources/page-with-custom-scrollbars.html: Added.
  • scrollbars/scrollbar-crash-on-refresh-expected.txt: Added.
  • scrollbars/scrollbar-crash-on-refresh.html: Added.
09:50 Changeset [44939] by mitz@apple.com
  • 3 edits in trunk/WebKit/mac

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6990938> REGRESSION (r42787): After showing and hiding the Find banner, the WebHTMLView's height is not restored
  • WebView/WebFrameView.mm: (-[WebFrameView setFrameSize:]): Mark the FrameView for layout when the WebFrameView's size changes.
  • WebView/WebView.mm: (-[WebView setFrameSize:]): Left the resize logic here, but only for the single view model.
09:42 Changeset [44938] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Simon Fraser.

Test: fast/repaint/background-generated.html

  • rendering/RenderObject.cpp: (WebCore::mustRepaintFillLayers): Return true if the layer does not specify a size and the image uses the container size.

LayoutTests:

Reviewed by Simon Fraser.

  • fast/repaint/background-generated.html: Added.
  • platform/mac/fast/repaint/background-generated-expected.checksum: Added.
  • platform/mac/fast/repaint/background-generated-expected.png: Added.
  • platform/mac/fast/repaint/background-generated-expected.txt: Added.
09:34 Changeset [44937] by hyatt@apple.com
  • 15 edits
    3 adds in trunk/WebCore

2009-06-22 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26607

Add IDL for HTMLDataGridRowElement.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLAttributeNames.in:
  • html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::primary): (WebCore::HTMLDataGridColElement::setPrimary):
  • html/HTMLDataGridColElement.h:
  • html/HTMLDataGridColElement.idl:
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::checkDTD): (WebCore::HTMLDataGridElement::multiple): (WebCore::HTMLDataGridElement::setMultiple):
  • html/HTMLDataGridElement.h:
  • html/HTMLDataGridElement.idl:
  • html/HTMLDataGridRowElement.cpp: Added. (WebCore::HTMLDataGridRowElement::HTMLDataGridRowElement): (WebCore::HTMLDataGridRowElement::selected): (WebCore::HTMLDataGridRowElement::setSelected): (WebCore::HTMLDataGridRowElement::focused): (WebCore::HTMLDataGridRowElement::setFocused):
  • html/HTMLDataGridRowElement.h: Added. (WebCore::HTMLDataGridRowElement::tagPriority):
  • html/HTMLDataGridRowElement.idl: Added.
  • html/HTMLTagNames.in:
09:32 Changeset [44936] by darin@apple.com
  • 2 edits in trunk/LayoutTests

2009-06-22 Darin Adler <darin@apple.com>

  • platform/gtk/Skipped: Skip two new tests.
08:44 Changeset [44935] by darin@apple.com
  • 2 edits in trunk/LayoutTests

2009-06-22 Darin Adler <darin@apple.com>

  • fast/js/JSON-stringify-expected.txt: Update results.
06:22 Changeset [44934] by yael.aharon@nokia.com
  • 3 edits
    1 add in trunk/WebCore

2009-06-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=26556

Fix a crash in case that the QNetworkReply::readReady signal is
"stuck" in deferred mode due to JavaScript alert, and in the meantime,
QNetworkreply::finished signal is received and processed before
QNetworkReply::readReady is processed.

  • manual-tests/qt/unload-alert.html: Added.
  • platform/network/qt/QNetworkReplyHandler.cpp:
  • platform/network/qt/QNetworkReplyHandler.h:
04:55 Changeset [44933] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Fix the Qt build.

  • WebCore.pro:
00:33 Changeset [44932] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Set up global native controls flag before creating the first WebView.


Reviewed by Darin Adler.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main):

06/21/09:

23:35 Changeset [44931] by oliver@apple.com
  • 6 edits in trunk

Bug 26592: Support standard toJSON functions
<https://bugs.webkit.org/show_bug.cgi?id=26592>

Reviewed by Darin Adler

Add support for the standard Date.toJSON function.

23:17 Changeset [44930] by darin@apple.com
  • 4 edits in trunk/WebCore

2009-06-21 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
https://bugs.webkit.org/show_bug.cgi?id=25425

  • bindings/scripts/CodeGeneratorJS.pm: Tweaked mechanism for includes to be a bit more consistent and to make SVGElement.h be included in the header rather than in every implementation file that includes the header. Added code to use getAttribute and setAttribute directly when the [Reflect] extended attribute is used.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • html/HTMLElement.idl: Used [Reflect] for all the attributes in this class that reflect content attributes. Restricting this to one class for now to keep the patch small and start out slowly.
22:08 Changeset [44929] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Bug 26594: JSC needs to support Date.toISOString
<https://bugs.webkit.org/show_bug.cgi?id=26594>

Reviewed by Sam Weinig

Add support for Date.toISOString.

21:59 Changeset [44928] by weinig@apple.com
  • 7 edits
    3 adds in trunk

WebCore:

2009-06-21 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.

Test: fast/dom/event-attribute-availability.html

  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.cpp:
  • dom/Node.h:
  • dom/Node.idl:

LayoutTests:

2009-06-21 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Test for https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.

  • fast/dom/event-attribute-availability-expected.txt: Added.
  • fast/dom/event-attribute-availability.html: Added.
  • fast/dom/resources/event-attribute-availability.js: Added.
18:39 Changeset [44927] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

WebCore:

2009-06-21 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26580


Fix to enable XSSAuditor on child windows.


Test: http/tests/security/xssAuditor/link-opens-new-window.html


  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject):
  • page/XSSAuditor.h: Removed method setXSSAuditorEnabled, and field m_isEnabled. Moved implementation of isEnabled to XSSAuditor.cpp and changed implementation to query Settings.

LayoutTests:

2009-06-21 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.


Test for https://bugs.webkit.org/show_bug.cgi?id=26580


Tests that XSSAuditor (if enabled) prevents script execution in child window.

  • http/tests/security/xssAuditor/link-opens-new-window-expected.txt: Added.
  • http/tests/security/xssAuditor/link-opens-new-window.html: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-and-notify.php: Added.
17:23 Changeset [44926] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

  • make repaint tests more reliable when run in Safari
  • fast/repaint/resources/repaint.js: (runRepaintTest): Increased the timeout from 0 to 100, to ensure that painting occurs once before repaintTest() is called.
17:03 Changeset [44925] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Set a sensible user agent string for the HTTP requests that Sparkle makes (checking for and downloading updates).

Reviewed by Sam Weinig.

  • WebKitLauncher/WebKitNightlyEnablerSparkle.m:

(userAgentStringForSparkle):
(initializeSparkle):

16:32 Changeset [44924] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix build by removing dead code.

16:02 Changeset [44923] by oliver@apple.com
  • 7 edits
    3 adds in trunk

Bug 26587: Support JSON.parse
<https://bugs.webkit.org/show_bug.cgi?id=26587>

Reviewed by Darin Adler and Cameron Zwarich.

Extend the LiteralParser to support the full strict JSON
grammar, fix a few places where the grammar was incorrectly
lenient. Doesn't yet support the JSON.parse reviver function
but that does not block the JSON.parse functionality itself.

15:46 Changeset [44922] by levin@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-06-21 David Levin <levin@chromium.org>

Reviewed by NOBODY (speculative build fix for windows).

Simply removed some whitespace form this file to make windows build wtf and
hopefully copy the new MessageQueque.h so that WebCore picks it up.

  • wtf/Assertions.cpp:
15:16 Changeset [44921] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-21 David Levin <levin@chromium.org>

Reviewed by NOBODY.

Speculative windows build fix (idea by Mark Rowe).

  • WebCore.vcproj/WebCore.vcproj:
15:03 Changeset [44920] by mrowe@apple.com
  • 2 edits
    2 adds in trunk/WebKitTools

Add a hook to the WebKit launcher application to allow a link on the nightly build start page to
trigger an update via the built-in software update mechanism.

Reviewed by Sam Weinig.

  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitLauncherURLProtocol.h: Added.
  • WebKitLauncher/WebKitLauncherURLProtocol.m: Added.

(+[WebKitLauncherURLProtocol load]):
(+[WebKitLauncherURLProtocol canInitWithRequest:]): Only allow use of the x-webkit-launcher scheme from .webkit.org subdomains.
(+[WebKitLauncherURLProtocol canonicalRequestForRequest:]):
(-[WebKitLauncherURLProtocol startLoading]):
(-[WebKitLauncherURLProtocol stopLoading]):
(-[WebKitLauncherURLProtocol handleIsWebKitLauncherAvailableJS]): Return a brief JavaScript snippet that can be used to programatically
determine whether the x-webkit-launcher is available and working.
(-[WebKitLauncherURLProtocol handleCheckForUpdates]): Trigger a software update on the main thread.
(-[WebKitLauncherURLProtocol resourceNotFound]): Fail with a generic "File does not exist" error.

15:02 Changeset [44919] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-21 David Levin <levin@chromium.org>

Reviewed by NOBODY (Speculative gtk build fix).

  • GNUmakefile.am:
14:56 Changeset [44918] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-06-21 David Levin <levin@chromium.org>

Reviewed by NOBODY.

Speculative tiger build fix and a windows build fix.
More fixes may still be in order.

  • WebCore.vcproj/WebCoreCommon.vsprops:
  • dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
14:46 Changeset [44917] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-21 David Levin <levin@chromium.org>

Reviewed by NOBODY (Speculative tiger build fix).

  • dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::~MessagePortQueue):
14:32 Changeset [44916] by levin@chromium.org
  • 9 edits
    2 adds in trunk

WebCore:

2009-06-21 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=26448>

Added optimized GC for MessagePorts when the entangled port is run by the same thread.
Fixed bug in isProxyFor() that was not properly throwing an exception when trying to clone the entangled port.

  • bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext): Now marks remotely entangled ports as in-use, in addition to those with pending activity.
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark): Now checks if the entangled port is local (run by same thread) and if so mark()s it.
  • dom/MessagePort.cpp: (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): Removes cloned ports from the ScriptExecutionContext - this allows cloned ports to be GC'd as otherwise they look like remotely entangled ports. (WebCore::MessagePort::start): (WebCore::MessagePort::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread
  • dom/MessagePort.h:
  • dom/MessagePortProxyWrapper.h:
  • dom/default/MessagePortProxy.cpp: (WebCore::MessagePortProxyWrapper::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread (WebCore::MessagePortProxy::hasPendingActivity): Changed definition of hasPendingActivity() to be stricter - only returns true if there are pending messages. (WebCore::MessagePortProxy::locallyEntangledPort):
  • dom/default/MessagePortProxy.h:

LayoutTests:

2009-06-21 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=26448>

New tests for MessagePort GC cases that weren't previously covered.

  • fast/events/message-channel-gc-4-expected.txt: Added. Test for case where both MessagePorts are in-transit (cloned) when a GC occurs.
  • fast/events/message-channel-gc-4.html-disabled: Added.
14:32 Changeset [44915] by levin@chromium.org
  • 23 edits
    1 move
    7 adds
    2 deletes in trunk

JavaScriptCore:

2009-06-21 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=25043>
Added support for multi-threaded MessagePorts.

  • wtf/MessageQueue.h: (WTF::::appendAndCheckEmpty):

Added API to test whether the queue was empty before adding an element.

WebCore:

2009-06-21 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=25043>
Removed obsolete MessagePort.startConversation(), active and onclose APIs.

Refactored MessagePortProxy into MessagePortChannel and a platform-dependent PlatformMessagePortChannel
implementation. Modified APIs to simplify cross-process implementations by moving the messaging code
entirely into the platform-dependent proxy.

Created a thread-safe default PlatformMessagePortChannel implementation.

Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how
cross-thread MessagePorts work.

  • GNUMakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added MessagePortChannel/PlatformMessagePortChannel files.

  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):

Changed ports to not mark their entangled pair as reachable, per the spec.

  • bindings/v8/custom/V8MessagePortCustom.cpp:
  • dom/MessageChannel.cpp: (WebCore::MessageChannel::MessageChannel):

Updated to use PlatformMessagePortChannel::createChannel() to entangle the ports.

  • dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::~MessagePort): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): (WebCore::MessagePort::messageAvailable): (WebCore::MessagePort::start): (WebCore::MessagePort::close): (WebCore::MessagePort::entangle): (WebCore::MessagePort::contextDestroyed): (WebCore::MessagePort::dispatchMessages): (WebCore::MessagePort::setOnmessage): (WebCore::MessagePort::hasPendingActivity):

Changed these APIs to delegate to new PlatformMessagePortChannel APIs.

  • dom/MessagePort.h:

Renamed isQueueOpen() to started().

  • dom/MessagePort.idl:

Removed startConversation and onclose.

  • dom/MessagePortProxy.h: Removed.
  • dom/MessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::EventData::create): (WebCore::MessagePortChannel::EventData::EventData): (WebCore::MessagePortChannel::~MessagePortChannel):
  • dom/MessagePortChannel.h: Added. (WebCore::MessagePortChannel::EventData::message): (WebCore::MessagePortChannel::EventData::channel):

Changed EventData to hold a reference to a MessagePortChannel object instead of a MessagePort to enable cross-thread messaging.

(WebCore::MessagePortChannel::MessagePortChannel):
(WebCore::MessagePortChannel::create):

  • dom/ScriptExecutionContext.cpp: (WebCore:ScriptExecutionContext::dispatchMessagePortEvents):

Renamed isQueueOpen() to started().

  • dom/default/PlatformMessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::entangleIfOpen): (WebCore::MessagePortChannel::disentangle): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::MessagePortChannel::close): (WebCore::MessagePortChannel::isConnectedTo): (WebCore::MessagePortChannel::hasPendingActivity): (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::createChannel): (WebCore::PlatformMessagePortChannel::entangleIfOpen): (WebCore::PlatformMessagePortChannel::disentangle): (WebCore::PlatformMessagePortChannel::setRemotePort): (WebCore::PlatformMessagePortChannel::remotePort): (WebCore::PlatformMessagePortChannel::entangledChannel): (WebCore::PlatformMessagePortChannel::setEntangledChannel): (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote): (WebCore::PlatformMessagePortChannel::isConnectedTo): (WebCore::PlatformMessagePortChannel::close): (WebCore::PlatformMessagePortChannel::closeInternal): (WebCore::PlatformMessagePortChannel::hasPendingActivity):
  • dom/default/PlatformMessagePortChannel.h: Added. (WebCore::PlatformMessagePortChannel::MessagePortQueue::create): (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage): (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::isEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::MessagePortQueue):
  • page/DOMWindow.cpp: (WebCore::PostMessageTimer::PostMessageTimer):

Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how cross-thread MessagePorts work.

(WebCore::PostMessageTimer::event):
(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

2009-06-21 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=25043>
Updated MessageChannel/MessagePorts tests to reflect latest spec (close event has been removed).
Added more tests of port cloning.

  • fast/events/message-channel-gc-2-expected.txt:
  • fast/events/message-channel-gc-2.html-disabled:
  • fast/events/message-channel-gc-3-expected.txt:
  • fast/events/message-channel-gc-3.html-disabled:
  • fast/events/message-channel-gc-expected.txt:
  • fast/events/message-channel-gc.html-disabled:
  • fast/events/message-port-clone-expected.txt: Added.
  • fast/events/message-port-clone.html-disabled: Added.
  • fast/events/message-port-expected.txt:
  • fast/events/message-port-no-wrapper-expected.txt: Added.
  • fast/events/message-port-onclose-expected.txt: Removed.
  • fast/events/message-port-onclose.html-disabled: Removed.
  • fast/events/message-port.html-disabled:
13:56 Changeset [44914] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Sam Weinig.

Test: fast/css/resize-single-axis.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): Ignore movement along the non-resizing axis.

LayoutTests:

Reviewed by Sam Weinig.

  • fast/css/resize-single-axis-expected.txt: Added.
  • fast/css/resize-single-axis.html: Added.
13:47 Changeset [44913] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-06-21 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel

Fix for https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox

Test: fast/events/event-trace.html

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Make the DOMWindow the currentTarget when events are dispatched to it. We previously used the document because DOMWindow was not yet an EventTarget.

LayoutTests:

2009-06-21 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel.

Test for https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox

  • fast/events/event-trace-expected.txt: Added.
  • fast/events/event-trace.html: Added.
13:16 Changeset [44912] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Sam Weinig.

Test: fast/css/resize-value-compared.html

  • rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::operator==): Compare the resize member.

LayoutTests:

Reviewed by Sam Weinig.

  • fast/css/resize-value-compared-expected.txt: Added.
  • fast/css/resize-value-compared.html: Added.
00:19 Changeset [44911] by darin@apple.com
  • 2 edits in trunk/LayoutTests

2009-06-21 Darin Adler <darin@apple.com>

  • platform/gtk/Skipped: Skip one more test.

06/20/09:

23:19 Changeset [44910] by darin@apple.com
  • 2 edits in trunk/LayoutTests

2009-06-20 Darin Adler <darin@apple.com>

  • platform/gtk/Skipped: Skip some new tests.
23:15 Changeset [44909] by darin@apple.com
  • 2 edits in trunk/WebKit/win

2009-06-20 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6964221> Need more processing of pluginspage.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
22:42 Changeset [44908] by alice.liu@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2009-06-19 Alice Liu <alice.liu@apple.com>

Fix https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>

Reviewed by Maciej Stachowiak.

Can't test this bug with an automated layout test since it requires b/f caching

  • manual-tests/animated-gif-bfcache-crash.html: Added.
  • manual-tests/resources/containsAnimatedGif.html: Added.

Adding checks for hostWindow() since there is no guarantee that the Page is alive

  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::contentsToScreen): (WebCore::ScrollView::screenToContents): (WebCore::ScrollView::wheelEvent):

LayoutTests:

2009-06-19 Alice Liu <alice.liu@apple.com>

Fix https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>

Reviewed by Maciej Stachowiak.

Adding resource used in WebCore/manual-tests/animated-gif-bfcache-crash.html

  • http/tests/misc/resources/animated-gif-with-offsets.gif: Added.
19:43 Changeset [44907] by mrowe@apple.com
  • 2 edits in trunk/WebKit/win

Roll out the Windows portion of r44905 as it broke the build.

19:05 Changeset [44906] by weinig@apple.com
  • 6 edits in trunk

WebCore:

2009-06-20 Sam Weinig <sam@webkit.org>

Reviewed by Adam Barth.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26554
Shadowing of top and parent

  • page/DOMWindow.idl:

LayoutTests:

2009-06-20 Sam Weinig <sam@webkit.org>

Reviewed by Adam Barth.

Test for https://bugs.webkit.org/show_bug.cgi?id=26554

Test writing to parent and top.

  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/cross-frame-access-put.html:
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
16:07 Changeset [44905] by darin@apple.com
  • 4 edits in trunk/WebKit

WebKit/mac:

2009-06-20 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6964221> Need more processing of pluginspage.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.

WebKit/win:

2009-06-20 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6964221> Need more processing of pluginspage.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
14:57 Changeset [44904] by jmalonzo@webkit.org
  • 6 edits in trunk

Reviewed by Gustavo Noronha and Xan Lopez.

[Gtk] Implement DRT XSS auditor support
https://bugs.webkit.org/show_bug.cgi?id=26571

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
14:56 Changeset [44903] by jmalonzo@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha and Xan Lopez.

webkit_web_back_forward_list_add_item() should add a ref for the history item
https://bugs.webkit.org/show_bug.cgi?id=26517

Add a ref to the WebHistoryItem when it's added to the back
forward list through webkit_web_back_forward_list_add_item.
This keeps the history item alive and prevents pywebkitgtk from
crashing

  • tests/testwebbackforwardlist.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): (test_webkit_web_back_forward_list_add_item):
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_add_item):
14:54 Changeset [44902] by mrowe@apple.com
  • 3 edits
    2 adds in trunk

Fix <https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none

Reviewed by Dan Bernstein.

We allow selections to begin within an element that has -webkit-user-select: none set,
unless the element is draggable as dragging should take priority over starting a selection.

Test: editing/selection/user-drag-element-and-user-select-none.html

  • dom/Node.cpp:

(WebCore::Node::canStartSelection):

Test for <https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none

  • editing/selection/user-drag-element-and-user-select-none-expected.txt: Added.
  • editing/selection/user-drag-element-and-user-select-none.html: Added.
13:34 Changeset [44901] by darin@apple.com
  • 5 edits in trunk

WebCore:

2009-06-20 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329

  • editing/TextIterator.cpp: (WebCore::TextIterator::handleReplacedElement): When entering a text control, start at the top of the shadow tree (by calling shadowTreeRootNode). Also remove assumption that innerTextElement will never be 0 since RenderTextControl doesn't really guarantee this.

LayoutTests:

2009-06-20 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329

  • editing/selection/find-in-text-control-expected.txt: Updated to expect finding text in <input type="text"> and <input type="search">, but not in <input type="password">.
  • editing/selection/find-in-text-control.html: Added tests for <input> elements as well as <textarea> elements. Also tweaked result output format to accomodate multiple text nodes.
11:06 Changeset [44900] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix namespace comment in SegmentedVector.h

  • wtf/SegmentedVector.h: Updated namespace comment to reflect new namespace after r44897.
06:27 Changeset [44899] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>

Reviewed by Oliver Hunt.

An Iterator added for SegmentedVector. Currently
only the pre ++ operator is supported.

  • wtf/SegmentedVector.h: (WTF::SegmentedVectorIterator::~SegmentedVectorIterator): (WTF::SegmentedVectorIterator::operator*): (WTF::SegmentedVectorIterator::operator->): (WTF::SegmentedVectorIterator::operator++): (WTF::SegmentedVectorIterator::operator==): (WTF::SegmentedVectorIterator::operator!=): (WTF::SegmentedVectorIterator::operator=): (WTF::SegmentedVectorIterator::SegmentedVectorIterator): (WTF::SegmentedVector::alloc): (WTF::SegmentedVector::begin): (WTF::SegmentedVector::end):
06:20 Changeset [44898] by kov@webkit.org
  • 3 edits
    1 add in trunk

2009-06-20 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Jan Alonzo.

Initial test case for loading statuses.

  • tests/testloading.c: Added. (load_finished_cb): (status_changed_cb): (test_loading_status): (main):
06:14 Changeset [44897] by ddkilzer@apple.com
  • 8 edits
    1 move in trunk/JavaScriptCore

2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>

Reviewed by Oliver Hunt.

Move SegmentedVector to /wtf subdirectory
and change "namespace JSC" to "namespace WTF"

Additional build file updates by David Kilzer.

  • GNUmakefile.am: Updated path to SegmentedVector.h.
  • JavaScriptCore.order: Updated SegmentedVector namespace from JSC to WTF in mangled C++ method name.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed reference to bytecompiler\SegmentedVector.h.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Added reference to wtf\SegmentedVector.h.
  • JavaScriptCore.xcodeproj/project.pbxproj: Moved SegmentedVector.h definition from bytecompiler subdirectory to wtf subdirectory.
  • bytecompiler/BytecodeGenerator.h: Updated #include path to
SegmentedVector.h and prepended WTF
namespace to its use.
  • parser/Lexer.h: Ditto.
  • wtf/SegmentedVector.h: Renamed from JavaScriptCore/bytecompiler/SegmentedVector.h. (WTF::SegmentedVector::SegmentedVector): (WTF::SegmentedVector::~SegmentedVector): (WTF::SegmentedVector::size): (WTF::SegmentedVector::at): (WTF::SegmentedVector::operator[]): (WTF::SegmentedVector::last): (WTF::SegmentedVector::append): (WTF::SegmentedVector::removeLast): (WTF::SegmentedVector::grow): (WTF::SegmentedVector::clear): (WTF::SegmentedVector::deleteAllSegments): (WTF::SegmentedVector::segmentExistsFor): (WTF::SegmentedVector::segmentFor): (WTF::SegmentedVector::subscriptFor): (WTF::SegmentedVector::ensureSegmentsFor): (WTF::SegmentedVector::ensureSegment):
05:34 Changeset [44896] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Jan Alonzo.

Fix the ordering in which the new load status goes into the enum
to avoid ABI breakage.

  • webkit/webkitwebframe.h:
02:48 Changeset [44895] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by NOBODY.

Speculative Qt build fix - add HTMLDataGridColElement to the build script.

  • WebCore.pro:
02:20 Changeset [44894] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-06-19 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26561

Remove a memcpy by retrieving the already existing copy of a string
instead of making a new one.

  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::source):
  • bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::source):
01:11 Changeset [44893] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-20 Xan Lopez <xlopez@igalia.com>

Skip new accessibility test, we still lack and accessibilityController.

  • platform/gtk/Skipped:
01:00 Changeset [44892] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-20 Xan Lopez <xlopez@igalia.com>

We don't seem to support these new HTTP tests either, skip them.

  • platform/gtk/Skipped:
00:53 Changeset [44891] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-20 Xan Lopez <xlopez@igalia.com>

Skip test that requires eventSender.

  • platform/gtk/Skipped:

06/19/09:

23:21 Changeset [44890] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

2009-06-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=26494
Bug 26494: RenderTheme::themeForPage reads from Settings before it has
been initialized by WebKit

Get the shouldPaintNativeControls preference and update the settings
before initializing the page, as the page depends on it after the
themeForPage change.

  • WebView.cpp: (WebView::initWithFrame):
18:29 Changeset [44889] by barraclough@apple.com
  • 9 edits in trunk/JavaScriptCore

2009-06-19 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY (build fix take 2 - rename FIELD_OFFSET to something that doesn't conflict with winnt.h).

  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::emitGetVariableObjectRegister): (JSC::JIT::emitPutVariableObjectRegister):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::compileBinaryArithOp):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference): (JSC::JIT::checkStructure):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call): (JSC::JIT::emitSlow_op_get_by_val):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
18:29 Changeset [44888] by darin@apple.com
  • 2 edits in trunk/WebKitTools

2009-06-19 Darin Adler <darin@apple.com>

  • Scripts/do-webcore-rename: More renaming ideas.
18:19 Changeset [44887] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-06-19 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY (Windows build fix).

  • jit/JIT.h:
  • jit/JITInlineMethods.h:
18:07 Changeset [44886] by barraclough@apple.com
  • 12 edits in trunk/JavaScriptCore

2009-06-19 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Reorganize ARM architecture specific macros.
Use PLATFORM_ARM_ARCH(7) instead of PLATFORM(ARM_V7).

Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>

  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReferenceForTrampoline):
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • wtf/Platform.h:
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
17:52 Changeset [44885] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/ChangeLog

Fixed the changelog, copied the same thing into both on accident.

17:49 Changeset [44884] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-06-19 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix armv7 JIT build issues.

Unfortunate the arm compiler does not like the use of offsetof on JITStackFrame (since it now contains non POD types),
and the FIELD_OFFSET macro does not appear constantish enough for it to be happy with its use in COMPILE_ASSERT macros.

  • Replace offsetofs with FIELD_OFFSETs (safe on C++ objects).
  • Move COMPILE_ASSERTs defending layout of JITStackFrame structure on armv7 into JITThunks constructor.
  • jit/JIT.cpp:
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_catch):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
17:35 Changeset [44883] by bweinstein@apple.com
  • 7 edits
    1 add in trunk

2009-06-19 Brian Weinstein <bweinstein@apple.com>

Reviewed by Steve Falkenburg.


https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7


The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.


Unable to add tests to simulate touch behavior/gestures.

  • platform/PlatformWheelEvent.h:
  • platform/win/WheelEventWin.cpp:

2009-06-19 Brian Weinstein <bweinstein@apple.com>

Reviewed by Steve Falkenburg.


https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7


The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.


Unable to add tests to simulate touch behavior/gestures.

  • platform/PlatformWheelEvent.h:
  • platform/win/WheelEventWin.cpp:
17:27 Changeset [44882] by bfulgham@webkit.org
  • 2 edits
    1 add
    4 deletes in trunk/LayoutTests

2009-06-19 Ryosuke Niwa <rniwa@google.com>

Reviewed by Maciej Stachowiak.

This fixs the bug 26361. The original test case did not invoke the event that
triggered the actual test. This patch adds code to invoke this event, and also
converts it from a pixel test to a dumpAsText test.

16:54 Changeset [44881] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

Fixed a build error, which only shows up in the i386 compile

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
16:35 Changeset [44880] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-06-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6988385> REGRESSION: In full page video player, movie's
video track becomes detached from its controller.

When in the media document, the MediaPlayer should not report that it
is capable of hardware acceleration, because it renders via a QTMovieView
which is already accelerated.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
16:14 Changeset [44879] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Adding XSSAuditor.cpp to the wx build.

15:43 Changeset [44878] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=26544

If I am doing a Matrix hardware animation and any matrix is singular, I revert to software.
This is not really testable, since we can't see what the hardware animation is doing.

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
15:32 Changeset [44877] by ggaren@apple.com
  • 5 edits in trunk/WebCore

2009-06-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


An additional fix for Bug 26532: Native functions do not correctly unlink
from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> | <rdar://problem/6625385>

Use "NativeFunctionWrapper" instead of "PrototypeFunction" in cross-frame
accessors, so the type of object you get to wrap a function is the same,
regardless of whether the access to the function is cross-frame.


This is faster and more idiomatic than what we had before. It also would
have avoided Bug 26532 because it would have prevented a conflicting
PrototypeFunction from being allocated to wrap postMessage, where a
NativeFunctionWrapper had been allocated previously.


  • bindings/js/JSDOMBinding.cpp: (WebCore::objectToStringFunctionGetter):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter):
  • bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter):
  • bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter):
15:23 Changeset [44876] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-06-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by John Sullivan

<rdar://problem/6953673> Crash in RenderLayerCompositor::setCompositingParent

Fix a crash that could occur in complex content due to timing issues
when doing a partial layer tree rebuild which is required when painting;
setCompositingParent() could be called with a parent which has not been made
compositing yet.

15:16 Changeset [44875] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-06-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Build fix. Adding missing HTMLDataGrid* files to the build.

  • GNUmakefile.am:
14:49 Changeset [44874] by pkasting@chromium.org
  • 7 edits in trunk/WebCore

2009-06-19 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26460 part three
Make BMPImageReader a standalone class that is used by ICOImageDecoder
and BMPImageDecoder to decode individual BMPs within a file. These
decoders now inherit directly from ImageDecoder.


This also makes these decoders decode on-demand in isSizeAvailable() and
frameBufferAtIndex(), like the other decoders, instead of when setData()
is called, like before. This should provide a speedup on pages
containing BMPs that aren't immediately onscreen.

  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::setData): (WebCore::BMPImageDecoder::isSizeAvailable): (WebCore::BMPImageDecoder::frameBufferAtIndex): (WebCore::BMPImageDecoder::decodeWithCheckForDataEnded): (WebCore::BMPImageDecoder::decode): (WebCore::BMPImageDecoder::processFileHeader):
  • platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32):
  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::BMPImageReader): (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::readInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData): (WebCore::BMPImageReader::setFailed):
  • platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::setBuffer): (WebCore::BMPImageReader::setData): (WebCore::BMPImageReader::): (WebCore::BMPImageReader::pastEndOfImage): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::setRGBA):
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::setData): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::size): (WebCore::ICOImageDecoder::frameBufferAtIndex): (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded): (WebCore::ICOImageDecoder::decode): (WebCore::ICOImageDecoder::processDirectory): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::readDirectoryEntry): (WebCore::ICOImageDecoder::processImageType):
  • platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32):
14:31 Changeset [44873] by treat@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-06-19 Adam Treat <adam.treat@torchmobile.com>

Blind attempt at build fix.

14:09 Changeset [44872] by hyatt@apple.com
  • 1 add in trunk/WebCore/html/HTMLDataGridElement.cpp

Add missed file.

14:07 Changeset [44871] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Inherits CallIdentifier struct from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/profiler/CallIdentifier.h:86.

  • wtf/HashCountedSet.h:
13:57 Changeset [44870] by treat@webkit.org
  • 6 edits
    6 adds in trunk

2009-06-19 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=26540
Currently the SunSpider test driver lacks an option to run a test suite that
will test JavaScriptCore parsing performance only. This patch adds just such
a test suite and option to SunSpider as well as the jsc test shell. I've included
three large javascript source files found in the wild: jquery, mootools and prototype.
Combined with the concatenation of all three, these form a new testsuite to measure
and test pure JavaScriptCore parsing performance.

13:38 Changeset [44869] by abarth@webkit.org
  • 6 edits in trunk/WebCore

2009-06-19 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26555

Fix the Chromium canary bot. Turns out ScriptSourceCode doesn't have
the same API in V8 and JSC.

  • WebCore/bindings/js/ScriptController.cpp:
  • WebCore/bindings/js/ScriptSourceCode.h:
  • WebCore/bindings/v8/ScriptController.cpp:
  • WebCore/page/XSSAuditor.cpp:
  • WebCore/page/XSSAuditor.h:
13:30 Changeset [44868] by bfulgham@webkit.org
  • 3 edits
    1 add in trunk

009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.


Inherits HashCountedSet class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Collector.cpp:1095.

  • wtf/HashCountedSet.h:
13:17 Changeset [44867] by hyatt@apple.com
  • 16 edits
    3 adds in trunk

WebCore:

2009-06-19 David Hyatt <hyatt@apple.com>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=26547


Implement the IDL interface for HTMLDataGridColElement.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLAttributeNames.in:
  • html/HTMLDataGridColElement.cpp: Added. (WebCore::HTMLDataGridColElement::HTMLDataGridColElement): (WebCore::HTMLDataGridColElement::label): (WebCore::HTMLDataGridColElement::setLabel): (WebCore::HTMLDataGridColElement::type): (WebCore::HTMLDataGridColElement::setType): (WebCore::HTMLDataGridColElement::sortable): (WebCore::HTMLDataGridColElement::setSortable): (WebCore::HTMLDataGridColElement::sortDirection): (WebCore::HTMLDataGridColElement::setSortDirection): (WebCore::HTMLDataGridColElement::selected): (WebCore::HTMLDataGridColElement::setSelected):
  • html/HTMLDataGridColElement.h: Added. (WebCore::HTMLDataGridColElement::endTagRequirement): (WebCore::HTMLDataGridColElement::tagPriority):
  • html/HTMLDataGridColElement.idl: Added.
  • html/HTMLDataGridElement.h:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

LayoutTests:

2009-06-19 David Hyatt <hyatt@apple.com>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=26547


Implement the IDL interface for HTMLDataGridColELement.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
13:09 Changeset [44866] by treat@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-06-19 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=26558
Declare these symbols extern for WINCE as they are provided by libce.

  • runtime/DateConstructor.cpp:
  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
12:54 Changeset [44865] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-06-19 Chris Evans <scarybeasts@gmail.com>

Reviewed by Eric Seidel.

There is no new test because this cannot be tested deterministically.
I've not been able to cause a crash at all in the test framework, but
I have verified that this is happening in the wild and that the patch
fixes the likely cause in the debugger.

  • loader/TextResourceDecoder.cpp: careful not to iterate off the end of our input buffer looking for the end of the comment.
12:37 Changeset [44864] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

12:35 Changeset [44863] by mrowe@apple.com
  • 1 copy in tags/Safari-6531

New tag.

11:48 Changeset [44862] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

<rdar://problem/6988973> ScopeChain leak in interpreter builds

Reviewed by Maciej Stachowiak

Move the Scopechain destruction code in JSFunction outside of the ENABLE(JIT)
path.

11:25 Changeset [44861] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-06-19 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26536

Fix external-script-URL-location.html and
write-external-script-open.html LayoutTests.

implicitOpen is called from several places. We need to setXSSAuditor
each time, so I moved the call inside implicitOpen.

  • dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::implicitOpen):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin):
11:22 Changeset [44860] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-19 Kent Tamura <tkent@chromium.org>

Reviewed by David Levin.

Use WebCore::multipleFileUploadText() in Chromium to fix a problem
that Chromium shows only the first filename even if a user selects
multiple files for <input type=file multiple>.
<https://bugs.webkit.org/show_bug.cgi?id=26502>

  • platform/chromium/FileChooserChromium.cpp: (WebCore::FileChooser::basenameForWidth):
11:14 Changeset [44859] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d

Test: editing/selection/move-by-line-005.html

The root cause of this bug was searchAheadForBetterMatch() continuing
past the first rendered text object after the given object. While we
want to skip non-rendered text and empty containers, when we encounter
rendered text object, we must return a text box for that object.

  • dom/Position.cpp: (WebCore::searchAheadForBetterMatch):

LayoutTests:

Reviewed by Dave Hyatt.

  • text for <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d
  • editing/selection/move-by-line-005-expected.txt: Added.
  • editing/selection/move-by-line-005.html: Added.
10:46 Changeset [44858] by jshin@chromium.org
  • 2 edits
    1 add in trunk/WebCore

2009-06-18 Jungshik Shin <jshin@chromium.org>

Reviewed by David Levin

https://bugs.webkit.org/show_bug.cgi?id=25657

Chromium Linux port does not handle non-BMP characters properly.
It's fixed with a 'UTF-16 iterator macro' to extract Unicode
codepoints out of a UTF-16 input string.

A manual test is added for non-BMP character rendering,
which we can use until a small freely-distributable font
covering non-BMP is added to the Webkit source tree.

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • manual-tests/non-bmp.html: Added.
10:01 Changeset [44857] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-19 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=26543
Windows CE uses 'GetLastError' instead of 'errno.'

  • interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::grow):
09:52 Changeset [44856] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Anders Carlsson.

  • update test results after r44806
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
08:47 Changeset [44855] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-06-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

V8 Bindings: return proper state from the script stack.

https://bugs.webkit.org/show_bug.cgi?id=26512

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::state):
08:34 Changeset [44854] by jberlin@apple.com
  • 2 edits in trunk/WebCore

2009-06-19 Jessie Berlin <jberlin@apple.com>

Reviewed by Simon Fraser.

Windows build fix.


  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
07:28 Changeset [44853] by yael.aharon@nokia.com
  • 3 edits in trunk/WebCore

2009-06-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.
Build fix after 44825.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::isSizeAvailable):
  • platform/graphics/qt/ImageDecoderQt.h:
05:18 Changeset [44852] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-06-19 Daniel Teske <qt-info@nokia.com>

Reviewed by Simon Hausmann.

Remove warnings for QString() constructions from const char *

By explicitly wrapping it with QLatin1String() / QLatin1Char()

02:58 Changeset [44851] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-15 Andre Pedralho <andre.pedralho@openbossa.org>

Reviewed by Tor Arne Vestbø.

Only pass --makeargs along if an argument is given.

02:23 Changeset [44850] by oliver@apple.com
  • 6 edits in trunk

2009-06-18 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Oliver Hunt.

Bug 26426: Canvas: rotation of 'no-repeat' pattern is weird
<https://bugs.webkit.org/show_bug.cgi?id=26426>

Use 1<<23-1 as steps of no-repeat patterns instead of 100000000.0f.
The original number cannot be represented by mantissa of float
(23bit) so that it caused some error.

Test: fast/canvas/image-object-in-canvas.html:

  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
02:06 Changeset [44849] by abarth@webkit.org
  • 1 edit in trunk/WebCore/bindings/v8/ScriptController.cpp

Fix copy/paste error.

01:57 Changeset [44848] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-06-19 abarth <abarth@webkit.org>

Unreviewed attempt to fix the Chromium build.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::xssAuditor):
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
01:29 Changeset [44847] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-06-19 Adam Barth <abarth@webkit.org>

Unreviewed attempt to fix Windows build.

  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled):
01:12 Changeset [44846] by abarth@webkit.org
  • 35 edits
    7 adds in trunk

WebCore:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added an experimental reflective XSS filter. The filter is disabled by
default.

Test: http/tests/security/xssAuditor/script-tag.html

  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
  • bindings/js/ScriptController.h: (WebCore::ScriptController::xssAuditor):
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • dom/Tokenizer.h: (WebCore::Tokenizer::xssAuditor): (WebCore::Tokenizer::setXSSAuditor): (WebCore::Tokenizer::Tokenizer):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::requestObject):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setXSSAuditorEnabled):
  • page/Settings.h: (WebCore::Settings::xssAuditorEnabled):
  • page/XSSAuditor.cpp: Added. (WebCore::isControlCharacter): (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::~XSSAuditor): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h: Added. (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::setXSSAuditorEnabled):

WebKit/mac:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added preference to enable the XSSAuditor.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isXSSAuditorEnabled]): (-[WebPreferences setXSSAuditorEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

WebKit/win:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added preference to enable the XSSAuditor.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isXSSAuditorEnabled): (WebPreferences::setXSSAuditorEnabled):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

WebKitTools:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Add support for testing the XSSAuditor.

  • DumpRenderTree/LayoutTestController.cpp: (setXSSAuditorEnabledCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setPopupBlockingEnabled):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setXSSAuditorEnabled):

LayoutTests:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added a basic test for the XSSAuditor.

  • http/tests/security/xssAuditor/resources/echo-intertag.php: Added.
  • http/tests/security/xssAuditor/script-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag.html: Added.
00:59 Changeset [44845] by levin@chromium.org
  • 3 edits in trunk/JavaScriptCore

2009-06-19 David Levin <levin@chromium.org>

Reviewed by NOBODY (Windows build fix).

Add export for Windows corresponding to OSX export done in r44844.

00:10 Changeset [44844] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

Bug 26532: Native functions do not correctly unlink from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> <rdar://problem/6625385>

Reviewed by Gavin "Viceroy of Venezuela" Barraclough.

We need to make sure that each native function instance correctly unlinks any references to it
when it is collected. Allowing this to happen required a few changes:

  • Every native function needs a codeblock to track the link information
  • To have this codeblock, every function now also needs its own functionbodynode so we no longer get to have a single shared instance.
  • Identifying a host function is now done by looking for CodeBlock::codeType() == NativeCode
Note: See TracTimeline for information about the timeline view.