Timeline



Jun 28, 2009:

10:24 PM Changeset in webkit [45335] by xan@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-06-28 Xan Lopez <xlopez@igalia.com>

Fix the GTK+ build.

  • WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::ContextMenuClient::isSpeaking):
  • WebCoreSupport/ContextMenuClientGtk.h:
9:28 PM Changeset in webkit [45334] by ggaren@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-06-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Standardized op_get_by_id to put { tag, payload } in { regT1, regT0 }.


SunSpider and v8 report maybe 0.2%-0.4% regressions, but the optimization
this enables will win much more than that back.

  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
8:06 PM Changeset in webkit [45333] by sullivan@apple.com
  • 7 edits in trunk

WebCore:

2009-06-26 John Sullivan <sullivan@apple.com>

Added Speech submenu to context menu on Mac when there's a non-editable selection
(it was already present when there's an editable selection).
Also added support for disabling "Stop Speaking" when there is no speaking to stop.

Reviewed by Tim Hatcher.

  • loader/EmptyClients.h: (WebCore::EmptyContextMenuClient::isSpeaking): implemented this new virtual function to return false


  • page/ContextMenuClient.h: declared this new pure virtual function


  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): insert Speech item (after a separator) on Mac when there's selected non-editable text (WebCore::ContextMenu::checkOrEnableIfNeeded): enable Stop Speaking item only if the context menu client returns true for isSpeaking()

WebKit/mac:

2009-06-26 John Sullivan <sullivan@apple.com>

Added support for disabling Stop Speaking when there is no speaking to stop.
Also fixed Stop Speaking so that it works (formerly it would throw an exception, and
selecting it from the menu would perform a web search instead (!)).

Reviewed by Tim Hatcher.

  • WebCoreSupport/WebContextMenuClient.h: declare isSpeaking()


  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::isSpeaking): implement by calling through to NSApplication (WebContextMenuClient::stopSpeaking): fixed implementation by correcting the signature of the NSApplication method
7:54 PM Changeset in webkit [45332] by mitz@apple.com
  • 5 edits in trunk

WebCore:

Reviewed by Simon Fraser.

Test: added a case to fast/dom/Element/scrollWidth.html

Ensure that scroll{Width, Height} is greater or equal to
client{Width, Height}.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):

LayoutTests:

Reviewed by Simon Fraser.

  • fast/dom/Element/scrollWidth-expected.txt:
  • fast/dom/Element/scrollWidth.html:
3:06 PM Changeset in webkit [45331] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

10:25 AM Changeset in webkit [45330] by Simon Fraser
  • 5 edits
    5 adds in trunk

2009-06-27 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26780

Do not make compositing layers for non-self-painting RenderLayers,
since these exist only to push a clip onto the clipping stack. If such
a layer gets compositied for some other reason, it should not paint.

Also ensure that we update composited layer positions correctly
inside overflow:scroll layers. We can't assume that the contents
are child layers, so we have to go up to the compositing ancestor,
and tell it to update all its child layer positions as we do
after layout.

Tests: compositing/layers-inside-overflow-scroll.html

compositing/self-painting-layers.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::needsToBeComposited):
5:40 AM Changeset in webkit [45329] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-06-28 Sriram Yadavalli <sriram.yadavalli@nokia.com>

Reviewed by Eric Seidel.

[Qt] Fix build break for Qt
https://bugs.webkit.org/show_bug.cgi?id=26779

  • Api/qwebpage.cpp: (QWebPage::swallowContextMenuEvent):
4:58 AM Changeset in webkit [45328] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix - include stdarg.h for va_start/va_end.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
4:15 AM Changeset in webkit [45327] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-06-28 Luke Kenneth Casson Leighton <lkcl@lkcl.net>

Reviewed by Eric Seidel.

PurgeableBuffer #defines leave out functions on gtk MacOSX 10.4 build
https://bugs.webkit.org/show_bug.cgi?id=23057

Define these functions for Gtk as well.

  • platform/PurgeableBuffer.h:
4:14 AM Changeset in webkit [45326] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-06-28 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Update CodeGeneratorV8.pm to match the new api for V8Proxy.

https://bugs.webkit.org/show_bug.cgi?id=26765

  • bindings/scripts/CodeGeneratorV8.pm: Match the current version of V8Proxy.
4:13 AM Changeset in webkit [45325] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-06-28 Nicolas Sylvain <nsylvain@chromium.org>

Reviewed by Dimitri Glazkov.

If loading a font fails because of the sandbox, we ask the browser process to
try to load it by calling ensureFontLoaded. If it still fails after
ensureFontLoaded, we hit a ASSERT_NOT_REACHED.

This case happens once in a while during browser shutdown. The browser will
queue a message to the renderer to shutdown, and will then stop answering sync
messages from the renderer. If the renderer is still loading a page during this
time, it might try to call the browser process to ask to load a font. The
browser process will ignore the request, and the font will fail to load, even
after the second try.

This is unfortunate, but there is no real risk here, since the renderer will be
going away as soon as it processes another message.

This can't be layout tested as it depends on the sandbox.

https://bugs.webkit.org/show_bug.cgi?id=26743

  • platform/graphics/chromium/FontChromiumWin.cpp:
  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
3:31 AM Changeset in webkit [45324] by eric@webkit.org
  • 8 edits
    2 adds in trunk

2009-06-28 John Abd-El-Malek <jam@chromium.org>

https://bugs.webkit.org/show_bug.cgi?id=15457

Layout tests to ensure that "src" paramater is added when it's missing
but "data" is present.

  • plugins/netscape-plugin-map-data-to-src-expected.txt: Added.
  • plugins/netscape-plugin-map-data-to-src.html: Added.

2009-06-28 John Abd-El-Malek <jam@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=15457

Test: plugins/netscape-plugin-map-data-to-src.html

Fix problems with Real or WMP plugins not displaying because "data" was set
on the OBJECT tag instead of "src". This is based on what Firefox does, see
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsObjectFrame.cpp#3045

  • rendering/RenderPartObject.cpp: (WebCore::mapDataParamToSrc): (WebCore::RenderPartObject::updateWidget):

2009-06-28 John Abd-El-Malek <jam@chromium.org>

https://bugs.webkit.org/show_bug.cgi?id=15457

Modify NPAPI test plugin to verify that "src" paramater is added when
it's missing but "data" is present.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginLog):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_Destroy): (NPP_SetWindow): (handleEventCarbon): (handleEventCocoa):
  • DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_New):
3:19 AM Changeset in webkit [45323] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-28 Eric Seidel <eric@webkit.org>

No review. Just updating test results Kevin seems to have missed.

Test failure started with:
http://trac.webkit.org/changeset/45287
The new results definitely look better.

  • fast/profiler/profile-with-no-title-expected.txt:
2:36 AM Changeset in webkit [45322] by jmalonzo@webkit.org
  • 1 edit
    2 adds in trunk/WebKit/gtk/po

2009-06-28 Miloš Popović <gpopac@gmail.com>

Rubber-stamped by Jan Alonzo.

New Serbian translation.

Jun 27, 2009:

11:05 PM Changeset in webkit [45321] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-06-27 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=26780

Fix up previous change. When computeCompositingRequirements() determines
that the current layer is composited, it needs to inform its parent
by setting compositingState.m_subtreeIsCompositing() to true. That didn't
always happen after the previous patch. Clarified the logic here.

  • rendering/RenderLayerCompositor.cpp: (WebCore::CompositingState::CompositingState): (WebCore::RenderLayerCompositor::computeCompositingRequirements):
10:54 PM Changeset in webkit [45320] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-27 Laszlo Gombos <Laszlo Gombos>

Reviewed by Jan Alonzo.

[Qt] Build fix after r45290
https://bugs.webkit.org/show_bug.cgi?id=26769

  • WebCore.pro:
10:54 PM Changeset in webkit [45319] by jmalonzo@webkit.org
  • 4 edits in trunk

2009-06-27 Emilio Pozuelo Monfort <pochu27@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Don't use deprecated GTK+ symbols.
https://bugs.webkit.org/show_bug.cgi?id=26583

  • plugins/gtk/gtk2xtbin.c: (gtk_xtbin_class_init): (gtk_xtbin_new): (gtk_xtbin_destroy):
  • GtkLauncher/main.c: (create_toolbar):
9:38 PM Changeset in webkit [45318] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-06-27 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=26780

First part: fix the RenderLayer::hasCompositingDescendant() flag to be set
correctly.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements): Do not unconditionally set compositingState.m_subtreeIsCompositing, because that can clobber the value from an earlier sibling. Add some more comments.

Remove a final use of Vector iterators.

(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
Move the normalFlowList() processing outside the test for isStackingContext().

9:19 PM Changeset in webkit [45317] by mitz@apple.com
  • 10 edits in trunk/WebCore

Reviewed by Simon Fraser and Antti Koivisto.

  • make paintFillLayerExtended() non-virtual and remove its clipY and clipH parameters

These parameters were computed and passed along to
paintFillLayerExtended in order to vertically constrain the rect fill to
the damage rect, because Qt cannot paint tall rectangles (see
<http://websvn.kde.org/?view=rev&revision=42721>). Since the damage rect
is passed along in the PaintInfo, the extra parameters are redundant,
and the intersection can just take place in paintFillLayerExtended().

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::paintMask): (WebCore::RenderBox::paintMaskImages): (WebCore::RenderBox::paintFillLayers): (WebCore::RenderBox::paintFillLayer):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintMask):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations): (WebCore::RenderTable::paintMask):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintMask):
8:13 PM Changeset in webkit [45316] by bfulgham@webkit.org
  • 6 edits
    22 adds in trunk

WebCore:

2009-06-27 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26762

Clean up for IndentOutdentCommand::indentRegion, and solved most of problems related to the bug 21712.
https://bugs.webkit.org/show_bug.cgi?id=21712

Added few utility functions to htmlediting.h/cpp

isVisibilyAdjacent checks whether the first position is visibly next to the second position.
i.e. there is no visible node between the first and second positions

canMergeLists checks whether two lists can be merged.
It checks the type of list, the editing boundary, and adjacency of the lists.

Tests: editing/execCommand/indent-nested-lists-1.html

editing/execCommand/indent-nested-lists-2.html
editing/execCommand/indent-nested-lists-3.html
editing/execCommand/indent-nested-lists-4.html
editing/execCommand/indent-nested-lists-5.html
editing/execCommand/indent-nested-lists-6.html
editing/execCommand/indent-nested-lists-7.html
editing/execCommand/outdent-nested-lists-1.html
editing/execCommand/outdent-nested-lists-2.html
editing/execCommand/outdent-nested-lists-3.html
editing/execCommand/outdent-nested-lists-4.html

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): (WebCore::IndentOutdentCommand::tryIndentingAsListItem): (WebCore::IndentOutdentCommand::indentIntoBlockquote): (WebCore::IndentOutdentCommand::indentRegion):
  • editing/IndentOutdentCommand.h:
  • editing/htmlediting.cpp: (WebCore::enclosingListChild): (WebCore::canMergeLists): (WebCore::isVisibilyAdjacent):
  • editing/htmlediting.h:

LayoutTests:

2009-06-27 Ryosuke Niwa <set EMAIL_ADDRESS environment variable>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26762

Clean up for IndentOutdentCommand::indentRegion, and solved most of problems related to the bug 21712.
https://bugs.webkit.org/show_bug.cgi?id=21712


The following test cases are intended for 21712, but included here
since this patch already solved a lot of problems.

  • editing/execCommand/indent-nested-lists-1-expected.txt: Added.
  • editing/execCommand/indent-nested-lists-1.html: Added.
  • editing/execCommand/indent-nested-lists-2-expected.txt: Added.
  • editing/execCommand/indent-nested-lists-2.html: Added.
  • editing/execCommand/indent-nested-lists-3-expected.txt: Added.
  • editing/execCommand/indent-nested-lists-3.html: Added.
  • editing/execCommand/indent-nested-lists-4-expected.txt: Added.
  • editing/execCommand/indent-nested-lists-4.html: Added.
  • editing/execCommand/indent-nested-lists-5-expected.txt: Added.
  • editing/execCommand/indent-nested-lists-5.html: Added.
  • editing/execCommand/indent-nested-lists-6-expected.txt: Added.
  • editing/execCommand/indent-nested-lists-6.html: Added.
  • editing/execCommand/indent-nested-lists-7-expected.txt: Added.
  • editing/execCommand/indent-nested-lists-7.html: Added.
  • editing/execCommand/outdent-nested-lists-1-expected.txt: Added.
  • editing/execCommand/outdent-nested-lists-1.html: Added.
  • editing/execCommand/outdent-nested-lists-2-expected.txt: Added.
  • editing/execCommand/outdent-nested-lists-2.html: Added.
  • editing/execCommand/outdent-nested-lists-3-expected.txt: Added.
  • editing/execCommand/outdent-nested-lists-3.html: Added.
  • editing/execCommand/outdent-nested-lists-4-expected.txt: Added.
  • editing/execCommand/outdent-nested-lists-4.html: Added.
7:31 PM Changeset in webkit [45315] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-06-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Fix completion when iterating options using Tab.

https://bugs.webkit.org/show_bug.cgi?id=26722

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._completionsReady):
5:32 PM Changeset in webkit [45314] by abarth@webkit.org
  • 1 edit
    33 adds in trunk/LayoutTests

2009-06-27 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.


https://bugs.webkit.org/show_bug.cgi?id=26776


More tests for the XSSAuditor.

  • http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event.html: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL.html: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location.html: Added.
  • http/tests/security/xssAuditor/dom-write-URL-expected.txt: Added.
  • http/tests/security/xssAuditor/dom-write-URL.html: Added.
  • http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt: Added.
  • http/tests/security/xssAuditor/dom-write-innerHTML.html: Added.
  • http/tests/security/xssAuditor/dom-write-location-expected.txt: Added.
  • http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt: Added.
  • http/tests/security/xssAuditor/dom-write-location-inline-event.html: Added.
  • http/tests/security/xssAuditor/dom-write-location-javascript-URL-expected.txt: Added.
  • http/tests/security/xssAuditor/dom-write-location-javascript-URL.html: Added.
  • http/tests/security/xssAuditor/dom-write-location.html: Added.
  • http/tests/security/xssAuditor/faux-script1-expected.txt: Added.
  • http/tests/security/xssAuditor/faux-script1.html: Added.
  • http/tests/security/xssAuditor/faux-script2-expected.txt: Added.
  • http/tests/security/xssAuditor/faux-script2.html: Added.
  • http/tests/security/xssAuditor/faux-script3-expected.txt: Added.
  • http/tests/security/xssAuditor/faux-script3.html: Added.
  • http/tests/security/xssAuditor/get-from-iframe-expected.txt: Added.
  • http/tests/security/xssAuditor/get-from-iframe.html: Added.
  • http/tests/security/xssAuditor/malformed-HTML-expected.txt: Added.
  • http/tests/security/xssAuditor/malformed-HTML.html: Added.
  • http/tests/security/xssAuditor/post-from-iframe-expected.txt: Added.
  • http/tests/security/xssAuditor/post-from-iframe.html: Added.
  • http/tests/security/xssAuditor/resources/anchor-url-dom-write-location-click.html: Added.
  • http/tests/security/xssAuditor/resources/echo-dom-write-URL.html: Added.
  • http/tests/security/xssAuditor/resources/echo-dom-write-innerHTML.html: Added.
  • http/tests/security/xssAuditor/resources/echo-dom-write-location.html: Added.
  • http/tests/security/xssAuditor/resources/utilities.js: Added. (sendRequestFromIFrame):
2:38 PM Changeset in webkit [45313] by kov@webkit.org
  • 3 edits in trunk/WebCore

2009-06-27 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable

Override visibleContentRect to handle GTK+'s case, in which
scrollbars or equivalent decoration are painted by the parent
widget.

  • platform/ScrollView.cpp:
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::visibleContentRect):
12:36 PM Changeset in webkit [45312] by abarth@webkit.org
  • 7 edits
    9 adds in trunk

WebCore:

2009-06-27 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26708


Fix addresses false negatives with respect to scheme relative paths, iFrame JavaScript URLs,
and UTF-7 encoded payloads.

Tests: http/tests/security/xssAuditor/http-equiv-utf-7-encoded.html

http/tests/security/xssAuditor/iframe-javascript-url.html
http/tests/security/xssAuditor/script-tag-utf-7-encoded.html
http/tests/security/xssAuditor/script-tag-with-source-relative-scheme.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): Moved XSSAuditor check to HTMLTokenizer::parseTag. (WebCore::HTMLTokenizer::parseTag):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe): Modified to inform XSSAuditor of parent frame so as to compare against iFrame javascript URL.
  • page/XSSAuditor.cpp: Removed method XSSAuditor::isControlCharacter. Instead, exposed method isControlCharacter in ResourceResponseBase.cpp. (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::decodeURL): Modified to decode string using specified encoder. (WebCore::XSSAuditor::findInRequest): Generalized to arbitrary frame so as to prevent execution of iFrame javascript URL.
  • page/XSSAuditor.h: Added field m_parentFrame.
  • platform/network/ResourceResponseBase.cpp: (WebCore::isControlCharacter):
  • platform/network/ResourceResponseBase.h:

LayoutTests:

2009-06-27 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

Tests for https://bugs.webkit.org/show_bug.cgi?id=26708

Tests prevention of injected scripts with scheme relative paths, iFrame JavaScript URLs,
and UTF-7 encoding.

  • http/tests/security/xssAuditor/http-equiv-utf-7-encoded-expected.txt: Added.
  • http/tests/security/xssAuditor/http-equiv-utf-7-encoded.html: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url.html: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-default-encode.pl: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7-encoded-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7-encoded.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-relative-scheme.html: Added.
1:34 AM Changeset in webkit [45311] by oliver@apple.com
  • 4 edits
    2 adds in trunk

Bug 26771: Canvas is incorrectly tainted when drawing from a video element that uses <source> elements

Reviewed by Maciej Stachowiak.

The drawImage(<video>) logic naively assumes that it just needs
to check the src attribute of the video element when in fact it
needs to look at the url that is being played instead. Failure
to do this means that video provided through source elements
taints the canvas.

Test: media/video-canvas-source.html

12:34 AM Changeset in webkit [45310] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-06-27 Simon Hausmann <simon.hausmann@nokia.com>

Build fix for Qt under Windows.

  • Api/qwebhistory.h: Use consistent export linkage for the datastream operators.

Jun 26, 2009:

11:22 PM Changeset in webkit [45309] by Simon Fraser
  • 3 edits in trunk/WebCore

2009-06-26 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/7011924> Opacity transitions should not trigger hardware compositing mode

Don't go into compositing mode just for opacity transitions, but they will be
hardware accelerated if we're already compositing.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingLayer): (WebCore::RenderLayerCompositor::requiresCompositingForTransform): (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
  • rendering/RenderLayerCompositor.h:
10:19 PM Changeset in webkit [45308] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Updating Tiger results for a recently modified test.

  • platform/mac-tiger/fast/encoding/idn-security-expected.txt:
10:15 PM Changeset in webkit [45307] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

<rdar://problem/7009684> REGRESSION(r45039): Crashes inside JSEvent::put on PowerPC (26746)
<https://bugs.webkit.org/show_bug.cgi?id=26746>

Reviewed by Dan Bernstein

Fix for r45039 incorrectly uncached a get_by_id by converting it to put_by_id. Clearly this
is less than correct. This patch corrects that error.

7:49 PM Changeset in webkit [45306] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/WebCore.base.exp

Mac build fix part 2 - add new mangled symbol

7:40 PM Changeset in webkit [45305] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/WebCore.base.exp

First part of Mac Build Fix - find missing symbol

7:23 PM Changeset in webkit [45304] by bweinstein@apple.com
  • 12 edits in trunk

2009-06-26 Brian Weinstein <bweinstein@apple.com>

Reviewed by Simon Fraser.


Changed call of scrollbarUnderMouse to scrollbarUnderPoint to match new API.

  • Api/qwebpage.cpp: (QWebPage::swallowContextMenuEvent):

2009-06-26 Brian Weinstein <bweinstein@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26695

Added hit testing on scrollbars, so if you start a gesture over a scrollbar,
it isn't counted, and lets the user drag the scrollbar itself instead of a
panning gesture. Also cleaned up code in gesture.

  • WebView.cpp: (WebView::gestureNotify): (WebView::gesture):

2009-06-26 Brian Weinstein <bweinstein@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26695


Added the ability to do scrollbar hit testing in EventHandler, changed the
signature of a PlatformWheelEvent constructor, and changed scrollbarUnderMouse
to scrollbarUnderPoint, and updated all calls to that function.

  • page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent):
  • page/EventHandler.h: (WebCore::):
  • platform/PlatformWheelEvent.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollbarUnderPoint):
  • platform/ScrollView.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::handleMouseDownEvent): (WebCore::PopupListBox::handleMouseMoveEvent):
  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
7:02 PM Changeset in webkit [45303] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-06-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Standardized op_call to put { tag, payload } in { regT1, regT0 }.


SunSpider and v8 report no change.

  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallSetupArgs): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::compileOpCallVarargsSetupArgs): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
6:52 PM Changeset in webkit [45302] by abarth@webkit.org
  • 2 edits in trunk/WebKit/win

2009-06-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26767

Fix a build break due to LocalStorage.h being included in WebKitDLL.cpp
despite it being deleted from the repo by the following patch/commit:
https://bugs.webkit.org/show_bug.cgi?id=26732
http://trac.webkit.org/changeset/45290

  • WebKitDLL.cpp:
6:49 PM Changeset in webkit [45301] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make SVN work (again?).

  • Scripts/modules/scm.py:
5:58 PM Changeset in webkit [45300] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-06-26 Simon Fraser <Simon Fraser>

Rubber-stamped by Dave Levin

Rename ioCompState to compositingState to better match WebCore coding style.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
5:50 PM Changeset in webkit [45299] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • revert unintentional project changes from r45277
  • WebCore.xcodeproj/project.pbxproj:
5:44 PM Changeset in webkit [45298] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the Windows build.

5:37 PM Changeset in webkit [45297] by Simon Fraser
  • 3 edits in trunk/WebCore

2009-06-26 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=26766

Change to use array indexing rather than Vector enumerators; the former
are preferred style.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::hasNonCompositingContent):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::updateCompositingChildrenGeometry): (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): (WebCore::RenderLayerCompositor::layerHas3DContent):
5:17 PM Changeset in webkit [45296] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

  • fix <rdar://problem/6961476> REGRESSION (r42043): scrollWidth reported as 1 px

Test: fast/dom/Element/scrollWidth.html

Changed scrollWidth and scrollHeight to use the same logic for
visible overflow boxes that is used for clipped overflow boxes. In
particular, borders are not included and
{leftmost,rightmost,lowest}Position() are used. This logic matches IE8.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/dom/Element/scrollWidth-expected.txt: Added.
  • fast/dom/Element/scrollWidth.html: Added.
5:07 PM Changeset in webkit [45295] by Chris Fleizach
  • 10 edits
    6 adds in trunk

Bug 26725: aria-hidden, aria-disabled, aria-readonly need to be implemented
https://bugs.webkit.org/show_bug.cgi?id=26725

5:02 PM Changeset in webkit [45294] by beidson@apple.com
  • 1 edit
    1 move
    4 adds in trunk/LayoutTests

2009-06-26 Brady Eidson <beidson@apple.com>

OMG.

  • platform/mac-tiger/fast/loader/file-url-mimetypes-expected.txt: Removed.
  • platform/mac-tiger/platform: Added.
  • platform/mac-tiger/platform/mac: Added.
  • platform/mac-tiger/platform/mac/fast: Added.
  • platform/mac-tiger/platform/mac/fast/loader: Added.
  • platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Copied from platform/mac-tiger/fast/loader/file-url-mimetypes-expected.txt.
4:09 PM Changeset in webkit [45293] by brettw@chromium.org
  • 3 edits in trunk/WebCore

2009-06-26 Brett Wilson <brettw@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26759

GIFImageDecoder is broken.

Make the GIFImageDecoder.repetitionCount function const to match the
base class. The mismatched definitions were causing the function to not
get called.

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::repetitionCount):
  • platform/image-decoders/gif/GIFImageDecoder.h:
3:58 PM Changeset in webkit [45292] by cmarrin@apple.com
  • 4 edits in trunk

Additional fix for https://bugs.webkit.org/show_bug.cgi?id=26651

The flag should always default to true to avoid it getting set
to false in a build with accelerated compositing turned off
and then disabling accelerated compositing when subsequently
running a build with it turned on.

3:53 PM Changeset in webkit [45291] by beidson@apple.com
  • 3 edits in trunk/WebCore

2009-06-26 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Followup for the fix for <rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails

Now that other MIME type correction stuff is in our swizzled method, Tiger needs it too!

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
  • platform/network/mac/WebCoreURLResponse.h:
3:49 PM Changeset in webkit [45290] by Dimitri Glazkov
  • 17 edits
    1 move
    1 add
    3 deletes in trunk/WebCore

2009-06-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26732

For the final step of https://bugs.webkit.org/show_bug.cgi?id=25376,
combine LocalStorage and SessionStorage into StorageNamespace. The
synching code (for LocalStorage) has already been removed, so these
classes are now very similar. All they do is essentially contain a
logical grouping of origins that are attached to specific contexts
(be it PageGroups for LocalStorage and Page for SessionStorage).

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • page/Chrome.cpp: (WebCore::Chrome::createWindow):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage):
  • page/DOMWindow.h:
  • page/Page.cpp: (WebCore::Page::sessionStorage): (WebCore::Page::setSessionStorage):
  • page/Page.h:
  • page/PageGroup.cpp: (WebCore::PageGroup::localStorage):
  • page/PageGroup.h:
  • storage/LocalStorage.cpp: Removed.
  • storage/LocalStorage.h: Removed.
  • storage/LocalStorageTask.cpp:
  • storage/LocalStorageThread.cpp:
  • storage/SessionStorage.cpp: Removed.
  • storage/SessionStorage.h: Removed.
  • storage/StorageArea.cpp: (WebCore::StorageArea::create): (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::copy): (WebCore::StorageArea::length): (WebCore::StorageArea::key): (WebCore::StorageArea::getItem): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear): (WebCore::StorageArea::contains): (WebCore::StorageArea::importItem): (WebCore::StorageArea::close): (WebCore::StorageArea::dispatchStorageEvent):
  • storage/StorageArea.h: (WebCore::):
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::scheduleFinalSync):
  • storage/StorageNamespace.cpp: Copied from WebCore/storage/LocalStorage.cpp. (WebCore::localStorageNamespaceMap): (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace): (WebCore::StorageNamespace::StorageNamespace): (WebCore::StorageNamespace::~StorageNamespace): (WebCore::StorageNamespace::copy): (WebCore::StorageNamespace::storageArea): (WebCore::StorageNamespace::close):
  • storage/StorageNamespace.h: Copied from WebCore/storage/LocalStorage.h.
3:48 PM Changeset in webkit [45289] by beidson@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2009-06-26 Brady Eidson <beidson@apple.com>

Fix Tiger results for the new mime type layout test.

  • platform/mac-tiger/fast/loader: Added.
  • platform/mac-tiger/fast/loader/file-url-mimetypes-expected.txt: Added.
3:22 PM Changeset in webkit [45288] by Nate Chapin
  • 83 edits
    1 add in trunk/WebCore

2009-06-26 Nate Chapin <Nate Chapin>

Reviewed by David Levin.

Upstream V8Proxy. This involved updating a lot of function and variable names to match WebKit style, hence the large size.

https://bugs.webkit.org/show_bug.cgi?id=26623

3:08 PM Changeset in webkit [45287] by kmccullough@apple.com
  • 4 edits in trunk/WebCore

2009-06-26 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/7011047> Profiler shows the record button 'on' even
though it's finished

I consolidated the creation of the user initiated profile name into
its own function and then called it from console::profile instead of
calling startUserInitiatedProfiling(). This way we don't call
toggleRecordButton() which turns on the record button.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::getCurrentUserInitiatedProfileName): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
  • inspector/InspectorController.h:
  • page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
3:06 PM Changeset in webkit [45286] by jberlin@apple.com
  • 2 edits in trunk/LayoutTests

2009-06-26 Jessie Berlin <jberlin@apple.com>

Reviewed by Mark Rowe.


Fix the build bots.

  • editing/selection/drag-start-event-client-x-y-expected.txt:
2:53 PM Changeset in webkit [45285] by jeremy@chromium.org
  • 19 edits
    1 add
    3 deletes in trunk/WebCore

Move focusRingColor to RenderTheme

2:51 PM Changeset in webkit [45284] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-06-26 Dmitry Titov <dimich@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26761
[Chromium] Enable Dedicated Workers in Chromium.

  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Remove the check that prevented workers from being created w/o a command-line switch. The flag itself and methods will be removed in a subsequent patch, after corresponding change in Chromium.
2:46 PM Changeset in webkit [45283] by beidson@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

2009-06-26 Brady Eidson <beidson@apple.com>

Step 2 (new Mac results)

  • platform/mac/fast/images/favicon-as-image-expected.checksum: Added.
  • platform/mac/fast/images/favicon-as-image-expected.png: Added.
  • platform/mac/fast/images/favicon-as-image-expected.txt: Added.
2:44 PM Changeset in webkit [45282] by beidson@apple.com
  • 1 edit
    3 moves
    1 add
    6 deletes in trunk/LayoutTests

2009-06-26 Brady Eidson <beidson@apple.com>

1st step of fixing the layout test I broke on Mac platforms.

  • platform/mac-leopard/fast/images/favicon-as-image-expected.checksum: Removed.
  • platform/mac-leopard/fast/images/favicon-as-image-expected.png: Removed.
  • platform/mac-leopard/fast/images/favicon-as-image-expected.txt: Removed.
  • platform/mac-tiger/fast/images/favicon-as-image-expected.checksum: Removed.
  • platform/mac-tiger/fast/images/favicon-as-image-expected.png: Removed.
  • platform/mac-tiger/fast/images/favicon-as-image-expected.txt: Removed.
  • platform/mac/fast/images/favicon-as-image-expected.checksum: Removed.
  • platform/mac/fast/images/favicon-as-image-expected.png: Removed.
  • platform/mac/fast/images/favicon-as-image-expected.txt: Removed.
  • platform/win/fast/images: Added.
  • platform/win/fast/images/favicon-as-image-expected.checksum: Copied from platform/mac/fast/images/favicon-as-image-expected.checksum.
  • platform/win/fast/images/favicon-as-image-expected.png: Copied from platform/mac/fast/images/favicon-as-image-expected.png.
  • platform/win/fast/images/favicon-as-image-expected.txt: Copied from platform/mac/fast/images/favicon-as-image-expected.txt.
2:01 PM Moving to Git edited by treat@kde.org
(diff)
1:51 PM Changeset in webkit [45281] by weinig@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-06-26 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Handle multiplying by zero a little better by
inlining the case that both operands are non-negative
into the slowpath.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::branchOr32):
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul):
1:49 PM Changeset in webkit [45280] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2009-06-26 Brady Eidson <beidson@apple.com>

Fix SnowLeopard build.

  • Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::didReceiveResponse):
1:40 PM Changeset in webkit [45279] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Land updated results after the test change.

  • editing/selection/user-drag-element-and-user-select-none-expected.txt:
1:29 PM Changeset in webkit [45278] by jberlin@apple.com
  • 4 edits
    2 adds in trunk

2009-06-26 Jessie Berlin <jberlin@apple.com>

Fix: https://bugs.webkit.org/show_bug.cgi?id=26723
Where the m_mouseDown event was never being set on windows, so the
client X and Y coordinates were always being reported as zero in a
dragstart handler.


Reviewed by Mark Rowe.

Test: editing/selection/drag-start-event-client-x-y.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Set the m_mouseDown event when the mouse press is handled.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::mouseDown): Removed now redundant setting of m_mouseDown.


Layout test for making sure the client X Y coordinates of the event
in a dragstart handler are correct.


https://bugs.webkit.org/show_bug.cgi?id=26723

  • editing/selection/drag-start-event-client-x-y-expected.txt: Added.
  • editing/selection/drag-start-event-client-x-y.html: Added.
1:13 PM Changeset in webkit [45277] by beidson@apple.com
  • 3 edits in trunk/WebCore

2009-06-26 Brady Eidson <beidson@apple.com>

Tiger build fix

  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/mac/WebCoreURLResponse.mm: (swizzleMIMETypeMethodIfNecessary):
12:43 PM Changeset in webkit [45276] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Fix user-drag-element-and-user-select-none.html to not rely on a bug in Mac DRT.

Reviewed by Sam Weinig.

  • editing/selection/user-drag-element-and-user-select-none.html:
12:38 PM Changeset in webkit [45275] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26681
Problem updating applicationCache when server returns 304


Improve the fix, make the test pass on Tiger.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): Fix another code path to remove the current item from list.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): On Tiger, conditional requests that cannot be cached by network layer cause errors with default cache policy.
12:23 PM Changeset in webkit [45274] by beidson@apple.com
  • 17 edits
    269 adds in trunk

WebCore:

2009-06-26 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails

When we disabled content sniffing for file urls we lost knowledge of many file extensions that we
didn't intend to lose. Turns out the CoreTypes UTI database doesn't know about every extension Gatekeeper
knew about.

By comparing CoreTypes' database to Gatekeepers, this patch adds a hardcoded list of file extension to MIME
type mappings that are missing in CoreType's database.

Test: platform/mac/fast/loader/file-url-mimetypes.html

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Move the MIME Type swizzling code to WebCoreURLResponse.
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): _webcore_MIMEType -> MIMEType, as we now have only one place where we do all MIMEType correction.
  • platform/network/mac/WebCoreURLResponse.h: Remove _webcore_MIMEType, as it is now folded into the swizzled implementation of MIMEType.
  • platform/network/mac/WebCoreURLResponse.mm: (createBinaryExtensionsSet): (createExtensionToMIMETypeMap): (swizzleMIMETypeMethodIfNecessary): (webNSURLResponseMIMEType): If it's a file URL and there's no MIME type, see if the extension exists in the extension -> MIME type map before turning to the default MIME type. Also roll in what was previously implemented in _webcore_MIMEType.
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::~SVGImage): Tweak this ASSERT - SVGImages might get destroyed without ever having a client.

WebKit/mac:

2009-06-26 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails

Replace all usage of the now obsolete [NSURLResponse _webcore_MIMEType].

  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::didReceiveResponse):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginView:receivedData:]):
  • Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
  • WebView/WebDataSource.mm: (-[WebDataSource _responseMIMEType]):
  • WebView/WebResource.mm: (-[WebResource _initWithData:URL:response:]):

WebKitTools:

2009-06-26 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails

Add a dumpResourceResponseMIMETypes() mode so the ResourceLoadDelegate will dump the mime type from
the NSURLResponse. Needed for the test for this bug fix.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpResourceResponseMIMETypesCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpResourceResponseMIMETypes): (LayoutTestController::setDumpResourceResponseMIMETypes):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):

LayoutTests:

2009-06-25 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails

Add a test file for each of file extensions we think WebKit on Mac should know the MIME type for.

  • platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
  • platform/mac/fast/loader/file-url-mimetypes.html: Added.
  • platform/mac/fast/loader/resources: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-3g2.3g2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-3gp.3gp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-3gp2.3gp2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-3gpp.3gpp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-Z.Z: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ac3.ac3: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ai.ai: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-aif.aif: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-aifc.aifc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-aiff.aiff: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-asc.asc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-asf.asf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-asx.asx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-au.au: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-avi.avi: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-bcpio.bcpio: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-bin.bin: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-bmp.bmp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-bz.bz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-bz2.bz2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cdf.cdf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-class.class: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cpgz.cpgz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cpio.cpio: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cpt.cpt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-crw.crw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-csh.csh: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-css.css: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dcr.dcr: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dif.dif: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dir.dir: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dll.dll: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dls.dls: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dmg.dmg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dms.dms: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-doc.doc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-docm.docm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-docx.docx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dotm.dotm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dotx.dotx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dv.dv: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dvi.dvi: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dxr.dxr: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-efx.efx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-eps.eps: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-etx.etx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-exe.exe: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ez.ez: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fdf.fdf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fla.fla: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fp.fp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fp2.fp2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fp3.fp3: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fp4.fp4: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fp5.fp5: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fp6.fp6: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fpx.fpx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-gif.gif: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-gtar.gtar: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-gz.gz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-gzip.gzip: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hdf.hdf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hqx.hqx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-htm.htm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-html.html: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ice.ice: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ico.ico: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ics.ics: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ief.ief: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-iges.iges: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-igs.igs: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-iso.iso: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-j2k.j2k: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jar.jar: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-javascript.javascript: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jhtml.jhtml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jnlp.jnlp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jp2.jp2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jpe.jpe: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jpeg.jpeg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jpf.jpf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jpg.jpg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jpx.jpx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-js.js: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jscript.jscript: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-kar.kar: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-latex.latex: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lha.lha: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lzh.lzh: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m15.m15: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m2v.m2v: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m3u.m3u: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m4p.m4p: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m75.m75: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mac.mac: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-man.man: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-me.me: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mesh.mesh: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mid.mid: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-midi.midi: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mif.mif: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mov.mov: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-movie.movie: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mp2.mp2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mp3.mp3: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mp4.mp4: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mpe.mpe: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mpeg.mpeg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mpg.mpg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mpga.mpga: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ms.ms: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-msh.msh: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mxu.mxu: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-nc.nc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-oda.oda: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-odc.odc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-odf.odf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-odg.odg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-odi.odi: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-odm.odm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-odp.odp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ods.ods: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-odt.odt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-otc.otc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-otf.otf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-otg.otg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-oth.oth: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-oti.oti: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-otp.otp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ots.ots: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ott.ott: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pbm.pbm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pct.pct: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pcx.pcx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pdb.pdb: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pdf.pdf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pgm.pgm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pgn.pgn: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ph3.ph3: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ph4.ph4: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-php.php: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-php3.php3: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-php4.php4: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-phtml.phtml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pic.pic: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pict.pict: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pl.pl: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pls.pls: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pm.pm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-png.png: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pnm.pnm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pnt.pnt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pntg.pntg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-potm.potm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-potx.potx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ppm.ppm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ppsm.ppsm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ppsx.ppsx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ppt.ppt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pptm.pptm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pptx.pptx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ps.ps: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-psd.psd: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-py.py: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-qif.qif: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-qt.qt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-qti.qti: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-qtif.qtif: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-qtz.qtz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ra.ra: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ram.ram: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ras.ras: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-rb.rb: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-rbw.rbw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-rgb.rgb: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-rm.rm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-roff.roff: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-rpm.rpm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-rtf.rtf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-rtx.rtx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sgi.sgi: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sgm.sgm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sgml.sgml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sh.sh: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-shar.shar: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-shtm.shtm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-shtml.shtml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-silo.silo: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sit.sit: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sitx.sitx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-skd.skd: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-skm.skm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-skp.skp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-skt.skt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-smf.smf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-smi.smi: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-smil.smil: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-snd.snd: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-so.so: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-spl.spl: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-src.src: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sv4cpio.sv4cpio: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sv4crc.sv4crc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-svg.svg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-svgz.svgz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-swf.swf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-t.t: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tar.tar: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-targa.targa: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tcl.tcl: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tex.tex: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-texi.texi: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-texinfo.texinfo: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-text.text: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tga.tga: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tgz.tgz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tif.tif: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tiff.tiff: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-torrent.torrent: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tr.tr: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tsv.tsv: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-txt.txt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ustar.ustar: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-vcard.vcard: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-vcd.vcd: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-vcf.vcf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-vfw.vfw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-vrml.vrml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wav.wav: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wave.wave: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wax.wax: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wbmp.wbmp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wbxml.wbxml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-webarchive.webarchive: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wm.wm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wma.wma: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wmd.wmd: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wml.wml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wmlc.wmlc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wmls.wmls: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wmlsc.wmlsc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wmp.wmp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wmv.wmv: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wmx.wmx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wrl.wrl: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wvx.wvx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xbm.xbm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xdp.xdp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xfd.xfd: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xfdf.xfdf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xht.xht: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xhtm.xhtm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xhtml.xhtml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xls.xls: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xlsb.xlsb: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xlsm.xlsm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xlsx.xlsx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xltm.xltm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xltx.xltx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xml.xml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xpm.xpm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xsl.xsl: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xwd.xwd: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xyz.xyz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-zip.zip: Added.
11:28 AM Changeset in webkit [45273] by Simon Fraser
  • 8 edits in trunk/WebCore

2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Show the fullscreen button only if the backend has support for it.

https://bugs.webkit.org/show_bug.cgi?id=26661

No test since this is not reachable via the DOM.

  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::supportsFullscreen): new
  • html/HTMLVideoElement.h: (WebCore::HTMLVideoElement::supportsFullscreen): new
  • platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::supportsFullscreen): new (WebCore::MediaPlayer::supportsFullscreen): new
  • platform/graphics/MediaPlayer.h: new
  • platform/graphics/MediaPlayerPrivate.h: new (WebCore::MediaPlayerPrivateInterface::supportsFullscreen): new
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlFullscreenButtonElement::rendererIsNeeded): new
  • rendering/MediaControlElements.h:
11:02 AM Changeset in webkit [45272] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7007776> Controller doesn't automatically update counters when file
is playing ( http://www.jazzguitar.be/mp3/Michael%20Lewis%20-%20SSSJ.mp3 )

Update the time display when the movie time changes.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):
11:00 AM Changeset in webkit [45271] by Simon Fraser
  • 10 edits in trunk

2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26659

Support hidding a control bar element from the Media element controller.

Update layout tests since the fullscreen button no longer has a renderer.

  • rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::update): call updateStyle() so everything is updated properly. (WebCore::MediaControlInputElement::MediaControlInputElement): (WebCore::MediaControlInputElement::update): call updateStyle() (WebCore::MediaControlInputElement::updateStyle): create the renderer properly or not depending on what rendererIsNeeded() return.
  • rendering/MediaControlElements.h:
10:48 AM Changeset in webkit [45270] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2009-06-26 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6968137> Profiler title numbers increment even after a
reload.

  • Now the numbers are reset when the profiles are.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
10:36 AM Changeset in webkit [45269] by eric@webkit.org
  • 8 edits in trunk/JavaScriptCore

2009-06-26 Eric Seidel <eric@webkit.org>

No review, only rolling out r45259.

Roll out r45259 after crash appeared on the bots:
plugins/undefined-property-crash.html
ASSERTION FAILED: s <= HeapConstants<heapType>::cellSize
(leopard-intel-debug-tests/build/JavaScriptCore/runtime/Collector.cpp:278
void* JSC::Heap::heapAllocate(size_t) [with JSC::HeapType heapType = PrimaryHeap])

  • runtime/DateInstance.cpp:
  • runtime/Identifier.cpp:
  • runtime/Lookup.h:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpObject.h:
  • runtime/ScopeChain.h:
  • runtime/UString.h:
10:17 AM Changeset in webkit [45268] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Update build-dumprendertree to use buildXCodeProject()

Reviewed by Adam Roben.

  • Scripts/build-dumprendertree: Updated to use buildXCodeProject() when building for isAppleMacWebKit(). This provides additional command-line switch parsing for free. Also added --clean and --help switches. Updated copyright.
10:07 AM Changeset in webkit [45267] by cmarrin@apple.com
  • 1 edit in trunk/WebCore/page/Settings.cpp

got rid of cruft accidentally left in from my last commit

9:53 AM Changeset in webkit [45266] by adele@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

2009-06-26 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/7000796>
REGRESSION(34681): Breaking up quoted text makes new, unquoted text blue after certain steps; repros with some messages

Test: editing/inserting/break-blockquote-after-delete.html

Keep track of whether the typing style should be preserved after the TypingCommand is applied. When adding onto an open
typing command, keep that flag up to date.

In this case, an InsertParagraphSeparatorInQuotedContent command, which should not preserve typing style,
was following an open Delete command, which does preserve the typing style. So we were applying the original
typing style (from before the delete, so blue text) to the cursor in the unquoted area after breaking up the blockquote.

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::typingAddedToOpenCommand): (WebCore::TypingCommand::insertTextRunWithoutNewlines): (WebCore::TypingCommand::insertLineBreak): (WebCore::TypingCommand::insertParagraphSeparator): (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::deleteSelection): (WebCore::TypingCommand::updatePreservesTypingStyle):
  • editing/TypingCommand.h: (WebCore::TypingCommand::preservesTypingStyle):

LayoutTests:

2009-06-26 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Test for <rdar://problem/7000796>
REGRESSION(34681): Breaking up quoted text makes new, unquoted text blue after certain steps; repros with some messages

  • editing/inserting/break-blockquote-after-delete.html: Added.
  • platform/mac/editing/inserting/break-blockquote-after-delete-expected.checksum: Added.
  • platform/mac/editing/inserting/break-blockquote-after-delete-expected.png: Added.
  • platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt: Added.
9:30 AM Changeset in webkit [45265] by Simon Hausmann
  • 8 edits
    1 add in trunk

2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Add support for saving and loading of QWebHistory to and from a QByteArray.

This includes streaming operators for QWebHistory. for convenience.

New autotests that test QWebHistory and QWebHistoryItem serialization.

9:29 AM Changeset in webkit [45264] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Fix the behaviour of QWebHistory::itemAt to interpret the specified index as absolute index.

Returns an invalid QWebHistoryItem if the index is out of range.

9:29 AM Changeset in webkit [45263] by Simon Hausmann
  • 2 edits
    11 adds in trunk/WebKit/qt

2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Added a few autotest to QWebHistory.

9:29 AM Changeset in webkit [45262] by Simon Hausmann
  • 6 edits in trunk

JavaScriptCore:

2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Add support for QDataStream operators to Vector.

WebCore:

2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Add support for QDataStream operators to String and IntPoint.

9:27 AM Changeset in webkit [45261] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-26 Ben Murdoch <benm@google.com>

Reviewed by Darin Fisher.

Add #if ENABLE(DOM_STORAGE) to the V8 custom bindings for local/session storage.
https://bugs.webkit.org/show_bug.cgi?id=26757

  • bindings/v8/custom/V8StorageCustom.cpp
9:27 AM Changeset in webkit [45260] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Fix support for documenting functions prefixed with QWEBKIT_EXPORT

Add QWEBKIT_EXPORT to the list of macros to ignore by qdoc.

3:27 AM Changeset in webkit [45259] by eric@webkit.org
  • 8 edits in trunk/JavaScriptCore

2009-06-26 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26750

Allow custom memory allocation control for JavaScriptCore/runtime
directory's classes which instantiated by new:

class IdentifierTable
struct RegExpObjectData
class HashEntry
struct DataInstance::Cache
class UString
struct RegExpConstructorPrivate
class ScopeChain

  • runtime/DateInstance.cpp:
  • runtime/Identifier.cpp:
  • runtime/Lookup.h:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpObject.h:
  • runtime/ScopeChain.h:
  • runtime/UString.h:
3:07 AM Changeset in webkit [45258] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-06-26 Eric Seidel <eric@webkit.org>

Reviewed by Tor Arne Vestbø.

Remove non-sense --update option to land-patches
and make land-patches update before every patch application.
This makes it slightly less likely that multi-patch landings will fail.

Also updated git diff command to include staged modifications.

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
3:06 AM Changeset in webkit [45257] by eric@webkit.org
  • 9 edits
    2 adds in trunk

2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Eric Seidel.

Bug 20303: [Qt] Key events are not working in frames.

Add a layout test to test the event is sent to the right sub-frame.

  • platform/qt/fast/events/event-sender-keydown-frame-expected.txt: Added.
  • platform/qt/fast/events/event-sender-keydown-frame.html: Added.

2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Eric Seidel.

Test: platform/qt/fast/events/event-sender-keydown-frame.html

Bug 20303: [Qt] Key events are not working in frames.

Merge scrolling handling code in qt and win port, move it to
EventHandler.

  • page/EventHandler.cpp: (WebCore::EventHandler::scrollRecursively):
  • page/EventHandler.h:

2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Eric Seidel.

Bug 20303: [Qt] Key events are not working in frames.

Send scrolling events to current focused frame, bubble the event
up to parent frame if it is not handled. Use EventHandler's new
shared scrolling code.

  • Api/qwebpage.cpp: (QWebPagePrivate::keyPressEvent): (QWebPagePrivate::handleScrolling):
  • Api/qwebpage_p.h:

2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Eric Seidel.

Bug 20303: [Qt] Key events are not working in frames.

Move the scroll handling code to EventHandler so that other
ports can share the functionality.

  • WebView.cpp: (WebView::keyDown): (EnumTextMatches::QueryInterface):
2:42 AM Changeset in webkit [45256] by rwlbuis@webkit.org
  • 3 edits
    4 adds in trunk

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26682
Bug 26682: It should be possible to add image to SVG DOM programmatically (using JavaScript)

Make sure the xlink:href animated property setting syncs the corresponding attribute with the right namespace.

Test: svg/custom/createImageElement.svg

2:36 AM Changeset in webkit [45255] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2009-06-26 Takeshi Yoshino <tyoshino@google.com>

Reviewed by Timothy Hatcher.

Bug 26156: In view-source mode, always render the contents using HTMLViewSourceDocument
https://bugs.webkit.org/show_bug.cgi?id=26156

When in view-source mode, render the contents using HTMLViewSourceDocument
regardless it's applicable for any plugin or not.

Chromium tells WebCore to render the contents of specified URL when
view-source: prefix is added to the URL. But currently, DOMImplementation
ignores inViewSourceMode() when the MIME type is indicating that the contents
are neither texts nor HTML family documents.

For example, we can check the contents of asf file without launching media
player. Rendering contents for view-source:-specified input is not what user
expects.

http://code.google.com/p/chromium/issues/detail?id=10545

I want to fix this issue by this patch. IMHO, regardless of this Chromium
specific issue, I think we should force use of HTMLViewSourceDocument when
inViewSourceMode() is specified.

  • fast/frames/resources/viewsource-fake-image-file.png: Added.
  • fast/frames/viewsource-on-image-file.html: Added.
  • platform/mac/fast/frames/viewsource-on-image-file-expected.txt: Added.

2009-06-26 Takeshi Yoshino <tyoshino@google.com>

Reviewed by Timothy Hatcher.

Bug 26156: In view-source mode, always render the contents using HTMLViewSourceDocument
https://bugs.webkit.org/show_bug.cgi?id=26156

When in view-source mode, render the contents using HTMLViewSourceDocument
regardless it's applicable for any plugin or not.

Chromium tells WebCore to render the contents of specified URL when
view-source: prefix is added to the URL. But currently, DOMImplementation
ignores inViewSourceMode() when the MIME type is indicating that the contents
are neither texts nor HTML family documents.

For example, we can check the contents of asf file without launching media
player. Rendering contents for view-source:-specified input is not what user
expects.

http://code.google.com/p/chromium/issues/detail?id=10545

I want to fix this issue by this patch. IMHO, regardless of this Chromium
specific issue, I think we should force use of HTMLViewSourceDocument when
inViewSourceMode() is specified.

Test: fast/frames/viewsource-on-image-file.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer):
  • html/HTMLViewSourceDocument.h:
2:25 AM Changeset in webkit [45254] by ap@webkit.org
  • 5 edits in trunk

Reviewed by Sam Weinig.

<rdar://problem/6651201> Update lookalike character list.

  • Misc/WebNSURLExtras.mm: (isLookalikeCharacter): Added more characters to the list.
2:20 AM Changeset in webkit [45253] by eric@webkit.org
  • 2 edits
    7 adds in trunk/LayoutTests

2009-06-26 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

Add an additional test for bug 23786 (mistreatment of CR/LF
as zero-width characters in Chromium port). Tests using Bidi text were
added when the fix was checked in. Without the patch, Chromium used
to fail the same way with LTR complex scripts as well. (that is,
CR and LF were treated as zero-width space). To prevent a potential
regression in the future, a new test with Hindi (a LTR complex script)
is added.

The expected results for Mac and Windows are added while this test
is added to Skipped file for gtk. I guess this test just needs
a new test result generated on gtk.

https://bugs.webkit.org/show_bug.cgi?id=25698

  • fast/text/international/hindi-whitespace.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/fast/text/international/hindi-whitespace-expected.checksum: Added.
  • platform/mac/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/mac/fast/text/international/hindi-whitespace-expected.txt: Added.
  • platform/win/fast/text/international/hindi-whitespace-expected.checksum: Added.
  • platform/win/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/win/fast/text/international/hindi-whitespace-expected.txt: Added.
2:12 AM Changeset in webkit [45252] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25529
[Gtk] Expected states not exposed to assistive technologies

Add support for VISIBLE, EDITABLE and SENSITIVE states.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject):
1:40 AM Changeset in webkit [45251] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-06-26 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

"Pointer to incomplete class type is not allowed" error with RVCT
https://bugs.webkit.org/show_bug.cgi?id=26721

Based on Norbert Leser's work.

  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • dom/Node.cpp: (WebCore::Node::dispatchMouseEvent):
  • dom/Node.h: Remove the default value for PassRefPtr<Event> args, to eliminate dependency on the Event class definition
1:32 AM Changeset in webkit [45250] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-25 Eric Seidel <eric@webkit.org>

Reviewed by Jan Alonzo.

Fix obsolete_attachment to work when passed a comment.
https://bugs.webkit.org/show_bug.cgi?id=26745

  • Scripts/modules/bugzilla.py:
1:28 AM Changeset in webkit [45249] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Mark Rowe.

bugzilla-tool apply-patch throws exception in Linux
https://bugs.webkit.org/show_bug.cgi?id=26738

HEAD is case-sensitive in Linux. Convert uses of head to HEAD in
the scm module.

  • Scripts/modules/scm.py:
12:58 AM Changeset in webkit [45248] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-06-26 Laszlo Gombos <Laszlo Gombos>

Reviewed by Maciej Stachowiak.

[Qt] Build fix after r45183
https://bugs.webkit.org/show_bug.cgi?id=26748

  • WebCore.pro:

Jun 25, 2009:

9:44 PM Changeset in webkit [45247] by ap@webkit.org
  • 4 edits
    1 add in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26681
<rdar://problem/7003461> Problem updating applicationCache when server returns 304

Test: http/tests/appcache/update-cache.html

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): We're already done with the resource, don't try to load it again.
9:21 PM Changeset in webkit [45246] by barraclough@apple.com
  • 1 edit in branches/nitro-extreme/JavaScriptCore/ChangeLog

Fix up JavaScriptCore/ChangeLog, messed up slightly in the merge.

8:32 PM Changeset in webkit [45245] by Simon Fraser
  • 3 edits
    2 adds in trunk

2009-06-25 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt.

<rdar://problem/6990481>

Handle perspective computation on non-layer objects.

Test: transforms/3d/general/perspective-non-layer.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):
8:03 PM Changeset in webkit [45244] by barraclough@apple.com
  • 110 edits
    32 copies
    22 deletes in branches/nitro-extreme

Merged r45138:45243 into nitro-extreme branch.

7:56 PM Changeset in webkit [45243] by barraclough@apple.com
  • 3 edits
    2 adds in branches/nitro-extreme

Merged r45137:45138 into nitro-extreme branch.

7:53 PM Changeset in webkit [45242] by barraclough@apple.com
  • 125 edits
    49 copies in branches/nitro-extreme

Merged r45039:45137 into nitro-extreme branch.

7:47 PM Changeset in webkit [45241] by barraclough@apple.com
  • 7 edits
    2 copies in branches/nitro-extreme

Merged r45038:45039 into nitro-extreme branch.

7:35 PM Changeset in webkit [45240] by barraclough@apple.com
  • 67 edits
    26 copies in branches/nitro-extreme

Merged r45000:45038 into nitro-extreme branch.

7:32 PM Changeset in webkit [45239] by eric@webkit.org
  • 3 edits
    1 move
    1 add
    7 deletes in trunk/LayoutTests

2009-06-25 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/remove-list-1-expected.txt: Added.
  • editing/execCommand/remove-list-1.html:
  • editing/execCommand/remove-list-items-expected.txt: Added.
  • editing/execCommand/remove-list-items.html:
  • platform/mac/editing/execCommand/remove-list-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/remove-list-1-expected.png: Removed.
  • platform/mac/editing/execCommand/remove-list-1-expected.txt: Removed.
  • platform/mac/editing/execCommand/remove-list-items-expected.checksum: Removed.
  • platform/mac/editing/execCommand/remove-list-items-expected.png: Removed.
  • platform/mac/editing/execCommand/remove-list-items-expected.txt: Removed.
  • platform/qt/editing/execCommand/remove-list-1-expected.txt: Removed.
  • platform/qt/editing/execCommand/remove-list-items-expected.txt: Removed.
7:31 PM Changeset in webkit [45238] by barraclough@apple.com
  • 95 edits
    36 copies
    1 delete in branches/nitro-extreme

Merged r44960:45000 into nitro-extreme branch.

7:20 PM Changeset in webkit [45237] by barraclough@apple.com
  • 53 edits
    2 adds in branches/nitro-extreme

Merged r44943:44960 into nitro-extreme branch.

7:19 PM Changeset in webkit [45236] by Simon Fraser
  • 2 edits in trunk/LayoutTests

2009-06-25 Simon Fraser <Simon Fraser>

Rubber-stamped by Eric Seidel

Update this test after the video controller changes.

  • platform/mac/fast/layers/video-layer-expected.txt:
7:13 PM Changeset in webkit [45235] by barraclough@apple.com
  • 22 edits
    7 deletes in branches/nitro-extreme/WebCore

Merged r44942:44943 into nitro-extreme branch.

7:12 PM Changeset in webkit [45234] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Not reviewed. Skip another failing test due to lack of eventSender impl.

  • platform/gtk/Skipped:
6:42 PM Changeset in webkit [45233] by barraclough@apple.com
  • 6 adds in branches/nitro-extreme/WebCore/html

Build fixes, mostly files not added.

6:38 PM Changeset in webkit [45232] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Not reviewed. Skip failing gtk tests due to missing DRT features.

  • platform/gtk/Skipped:
6:28 PM Changeset in webkit [45231] by barraclough@apple.com
  • 2 adds in branches/nitro-extreme/WebCore/dom

Build fixes, mostly files not added.

6:16 PM Changeset in webkit [45230] by Simon Fraser
  • 1 edit
    3 adds in trunk/LayoutTests

2009-06-25 Simon Fraser <Simon Fraser>

Rubber-stamped by Dan Bernstein.

Add Windows-specific test results, since Windows does not have
3d transforms enabled.

  • platform/win/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/media/mq-transform-02-expected.txt.
  • platform/win/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/media/mq-transform-03-expected.txt.
6:08 PM Changeset in webkit [45229] by barraclough@apple.com
  • 1 edit in branches/nitro-extreme/WebCore/bindings/scripts/CodeGeneratorJS.pm

Build fix

6:06 PM Changeset in webkit [45228] by Simon Fraser
  • 9 edits in trunk

2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26653

Use flex box in the mediaControls.css style, to nicely scale if a button gets
dynamically added or removed.

Media tests results are affected by this changes.

  • css/mediaControls.css:
  • css/mediaControlsQT.css:
6:03 PM Changeset in webkit [45227] by Simon Fraser
  • 4 edits in trunk/WebKitLibraries

2009-06-25 Simon Fraser <Simon Fraser>

Rubber-stamped by Mark Rowe.

<rdar://problem/6999737>

Update the media controller images.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
5:58 PM Changeset in webkit [45226] by barraclough@apple.com
  • 57 edits
    19 copies
    2 adds in branches/nitro-extreme

Merged r44920:44942 into nitro-extreme branch.

5:50 PM Changeset in webkit [45225] by barraclough@apple.com
  • 64 edits
    17 copies
    4 deletes in branches/nitro-extreme

Merged r44889:44920 into nitro-extreme branch.

5:49 PM Changeset in webkit [45224] by eric@webkit.org
  • 4 edits
    3 adds
    10 deletes in trunk/LayoutTests

2009-06-25 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/5432254-2-expected.txt: Added.
  • editing/execCommand/5432254-2.html:
  • editing/execCommand/5700414-1-expected.txt: Added.
  • editing/execCommand/5700414-1.html:
  • editing/execCommand/5700414-2-expected.txt: Added.
  • editing/execCommand/5700414-2.html:
  • platform/mac/editing/execCommand/5432254-2-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5432254-2-expected.png: Removed.
  • platform/mac/editing/execCommand/5432254-2-expected.txt: Removed.
  • platform/mac/editing/execCommand/5700414-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5700414-1-expected.png: Removed.
  • platform/mac/editing/execCommand/5700414-1-expected.txt: Removed.
  • platform/mac/editing/execCommand/5700414-2-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5700414-2-expected.png: Removed.
  • platform/mac/editing/execCommand/5700414-2-expected.txt: Removed.
  • platform/qt/editing/execCommand/5432254-2-expected.txt: Removed.
5:34 PM Changeset in webkit [45223] by barraclough@apple.com
  • 8 edits in branches/nitro-extreme/JavaScriptCore

Merged r44888:44889 into nitro-extreme branch.

5:28 PM Changeset in webkit [45222] by barraclough@apple.com
  • 15 edits in branches/nitro-extreme

Merged r44884:44888 into nitro-extreme branch.

5:26 PM Changeset in webkit [45221] by beidson@apple.com
  • 2 edits in trunk/WebKitSite

2009-06-24 Brady Eidson <beidson@apple.com>

Reviewed by Mark Rowe

  • demos/index.html: Fix more typos etc.
5:24 PM Changeset in webkit [45220] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-06-25 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Treat.

Add highlight functionality to the QWebPage::findText() method. Introduced is
new HighlightAllOccurrences flag which passed to the function will make it mark
all existing occurrences of specified string in the page.

  • Api/qwebpage.cpp: (QWebPage::findText):
  • Api/qwebpage.h:
  • Api/qwebview.cpp:
5:22 PM Changeset in webkit [45219] by jmalonzo@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-06-25 Duy Nguyen <pclouds@gmail.com>

Rubber-stamped by Jan Alonzo.

Gtk port Vietnamese translation
https://bugs.webkit.org/show_bug.cgi?id=26739

  • vi.po: Added.
5:22 PM Changeset in webkit [45218] by barraclough@apple.com
  • 6 edits in branches/nitro-extreme/JavaScriptCore

Merged r44883:44884 into nitro-extreme branch.

5:16 PM Changeset in webkit [45217] by barraclough@apple.com
  • 103 edits
    23 copies
    4 deletes in branches/nitro-extreme

Merged r44844:44883 into nitro-extreme branch.

5:07 PM Changeset in webkit [45216] by barraclough@apple.com
  • 11 edits in branches/nitro-extreme/JavaScriptCore

Merged r44843:44844 into nitro-extreme branch.

4:58 PM Changeset in webkit [45215] by darin@chromium.org
  • 5 edits in trunk/WebCore

2009-06-25 Albert J. Wong <ajwong@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26724

Move relavent part of setDefaultFontSize from RenderThemeChromiumWin
up into RenderThemeChromiumSkia.

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::setDefaultFontSize):
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::setDefaultFontSize):
  • rendering/RenderThemeChromiumWin.h:
4:54 PM Changeset in webkit [45214] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-06-25 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6989017>
REGRESSION (SnowLeopard): RealPlayer content replays when opening a new tab or switching back to the RealPlayer tab


If a plug-in fails in NPP_New, we would try to recreate it whenever the preferences for a web view would change.


Fix this by setting a flag when we fail to instantiate the plug-in, so we only try once.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView start]):
4:49 PM Changeset in webkit [45213] by barraclough@apple.com
  • 11 edits
    16 copies in branches/nitro-extreme

Merged r44838:44843 into nitro-extreme branch.

4:45 PM Changeset in webkit [45212] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-06-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Optimize x++ to ++x inside for loops.


Sadly, no measurable speedup, but this should help with result chaining.

  • parser/Nodes.cpp: (JSC::ForNode::emitBytecode):
4:39 PM Changeset in webkit [45211] by barraclough@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

Merged r44837:44838 into nitro-extreme branch.

4:36 PM Changeset in webkit [45210] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Mark Rowe.

bugzilla-tool apply-patch throws exception in Linux
https://bugs.webkit.org/show_bug.cgi?id=26738

HEAD is case-sensitive in Linux. Convert uses of head to HEAD in
the scm module.

  • Scripts/modules/scm.py:
4:24 PM Changeset in webkit [45209] by barraclough@apple.com
  • 111 edits
    36 copies
    44 deletes in branches/nitro-extreme

Merged r44796:44837 into nitro-extreme branch.

4:21 PM Changeset in webkit [45208] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-06-25 Matt Perry <mpcomplete@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26733

Add V8-only methods to FrameLoaderClient that V8 can use to send
out notifications when it creates/destroys a script context.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didCreateScriptContext): (WebCore::EmptyFrameLoaderClient::didDestroyScriptContext):
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::didCreateScriptContext): (WebCore::FrameLoaderClient::didDestroyScriptContext):
4:11 PM Changeset in webkit [45207] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-06-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

Correct a few typos that snuck in when I was reformatting CodeGeneratorV8.pm
to match WebKit style.

  • bindings/scripts/CodeGeneratorV8.pm: Corrected lots of typos.
3:42 PM Changeset in webkit [45206] by barraclough@apple.com
  • 3 edits in branches/nitro-extreme/WebCore

Build fix, revert part of last build fix.

3:37 PM Changeset in webkit [45205] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-06-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_bitnot): (JSC::JIT::emit_op_post_inc):
3:35 PM Changeset in webkit [45204] by cmarrin@apple.com
  • 4 edits in trunk

Some cosmetic fixes I missed in my last checkin

3:32 PM Changeset in webkit [45203] by agl@chromium.org
  • 2 edits in trunk/WebCore

2009-06-25 Adam Langley <agl@google.com>

TBRed: fix for Chromium tree.

Add missing include for r45199.

https://bugs.webkit.org/show_bug.cgi?id=26736

r45199 added a reference to throwError without including V8Proxy.h

  • bindings/v8/WorkerScriptController.cpp:
3:16 PM Changeset in webkit [45202] by barraclough@apple.com
  • 3 edits
    9 adds in branches/nitro-extreme

Build fixes, mostly files not added.

3:13 PM Changeset in webkit [45201] by agl@chromium.org
  • 2 edits in trunk/WebCore

2009-06-25 Adam Langley <agl@google.com>

TBRed: fix for Chromium tree.

https://bugs.webkit.org/show_bug.cgi?id=26735

Fix V8IsolatedWorld to point to the correct include file.

The deprecated v8_index.h was removed from the Chromium tree in r19291
and upstreamed into WebKit with r45193. However V8IsolatedWorld
slipped in between the cracks and broke the build.

  • bindings/v8/V8IsolatedWorld.h: update with new header location.
3:09 PM Changeset in webkit [45200] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-06-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emitSlow_op_pre_dec):
3:03 PM Changeset in webkit [45199] by cmarrin@apple.com
  • 16 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=26651


Preference is named "WebKitAcceleratedCompositingEnabled"
and is a boolean value. When false, prevents compositing layers from
being created, which prevents hardware animation from running.
Also forces video to do software rendering. Added a cache for
the flag in RenderLayerCompositing and made it all work
on-the-fly when the flag is changed while a page is loaded.

2:54 PM Changeset in webkit [45198] by jianli@chromium.org
  • 2 edits in trunk/WebCore

2009-06-25 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 26701: Implement the missing code for "FIXME: Need to return an
exception" in WorkerScriptController::evaluate for v8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=26701

  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
2:52 PM Changeset in webkit [45197] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-06-25 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

Call WebKitTools/Scripts scripts by their absolute paths
https://bugs.webkit.org/show_bug.cgi?id=26704

bugzilla-tool used to use whatever build-webkit was in your path.
That could end up building the wrong copy of WebKit.

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
2:51 PM Changeset in webkit [45196] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.19.1

New tag.

2:44 PM Changeset in webkit [45195] by sfalken@apple.com
  • 2 edits in branches/WWDC-2009-branch/JavaScriptCore

2009-06-24 Mark Rowe <mrowe@apple.com>

Merge r44117.

2009-05-24 Steve Falkenburg <sfalken@apple.com>

Build fix for experimental PGO Windows target.


2:42 PM Changeset in webkit [45194] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-06-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emitSlow_op_negate):
  • jit/JITCall.cpp: (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emitSlow_op_construct_verify):
2:39 PM Changeset in webkit [45193] by Nate Chapin
  • 2 edits
    1 add in trunk/WebCore

2009-06-25 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Upstream V8Index.

https://bugs.webkit.org/show_bug.cgi?id=26495

  • bindings/v8/V8Index.cpp: Added. (WebCore::V8ClassIndex::GetFactory): Moved from src.chromium.org. (WebCore::V8ClassIndex::GetCache): Moved from src.chromium.org.
  • bindings/v8/V8Index.h: (WebCore::V8ClassIndex::): Moved from src.chromium.org. (WebCore::V8ClassIndex::ToInt): Moved from src.chromium.org. (WebCore::V8ClassIndex::FromInt): Moved from src.chromium.org.
2:26 PM Changeset in webkit [45192] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Dave Levin.

Use unicode() instead of str when reading from bugzilla.
Also add Simon Fraser as a reviewer.
https://bugs.webkit.org/show_bug.cgi?id=26719

  • Scripts/modules/bugzilla.py:
2:15 PM Changeset in webkit [45191] by agl@chromium.org
  • 3 edits in trunk/WebCore

2009-06-25 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26529

This is hopefully the last step before our renderers can run
cleanly in a chroot.

WebKit needs to be able to ask for the correct font to use in
the case that the current font doesn't include glyphs for
certain code points. Currently we make a fontconfig call in our
WebKit port to handle this.

This patch changes this so that the call is sent our via
ChromiumBridge.

http://codereview.chromium.org/132007

This should not affect any layout tests.

  • platform/chromium/ChromiumBridge.h:
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
2:02 PM Changeset in webkit [45190] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-06-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_true): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null):
1:34 PM Changeset in webkit [45189] by levin@chromium.org
  • 1 edit
    4 adds in trunk/WebCore

2009-06-25 Albert J. Wong <ajwong@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26566
Upstream these files from the chromium v8 code. No tests were
affected because this is essentially a code move.

  • bindings/v8/NPV8Object.cpp: Added. (allocV8NPObject): (freeV8NPObject): (listFromVariantArgs): (npIdentifierToV8Identifier): (npCreateV8ScriptObject): (NPN_Invoke): (NPN_InvokeDefault): (NPN_Evaluate): (NPN_EvaluateHelper): (NPN_GetProperty): (NPN_SetProperty): (NPN_RemoveProperty): (NPN_HasProperty): (NPN_HasMethod): (NPN_SetException): (NPN_Enumerate): (NPN_Construct):
  • bindings/v8/NPV8Object.h: Added. (PrivateIdentifier::):
  • bindings/v8/V8NPUtils.cpp: Added. (convertV8ObjectToNPVariant): (convertNPVariantToV8Object): (getStringIdentifier):
  • bindings/v8/V8NPUtils.h: Added.
1:34 PM Changeset in webkit [45188] by levin@chromium.org
  • 3 edits
    3 adds in trunk

WebCore:

2009-06-25 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26436

Windows Chromium bug fix: save context of destination canvas in
TransparencyWin::compositeTextComposite() before the function
modifies the context.

Test: fast/canvas/translate-text.html

  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::compositeTextComposite):

LayoutTests:

2009-06-25 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26436

Windows Chromium bug fix: save context of destination canvas in
TransparencyWin::compositeTextComposite() before the function
modifies the context.

  • fast/canvas/resources/translate-text.js: Added. (description.pixelValueAt): (pixelToString): (pixelShouldBe):
  • fast/canvas/translate-text-expected.txt: Added.
  • fast/canvas/translate-text.html: Added.
1:34 PM Changeset in webkit [45187] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

2009-06-25 Takeshi Yoshino <tyoshino@google.com>

Reviewed by David Levin.

Bug 26207: Rebaseline the expected image for fast/forms/select-style.html for Mac.
https://bugs.webkit.org/show_bug.cgi?id=26207

Replace the expected image for fast/forms/select-style-expected.html for
Mac which need to be rebaselined due to r43903
(http://trac.webkit.org/changeset/43903).

  • platform/mac/fast/forms/select-style-expected.png:
1:34 PM Changeset in webkit [45186] by levin@chromium.org
  • 3 edits
    1 add in trunk/WebCore

2009-06-25 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Show the filename and first line for "(program)" in the Profiler/Debugger
https://bugs.webkit.org/show_bug.cgi?id=25475

Add support to associate a sourceURL with an eval()'d string
via a @sourceURL comment. Currently the sourceURL is only available
in the script debugger, not in the console or profiler, but it's
most needed in the script debugger.

  • English.lproj/localizedStrings.js: added new "(program): %s" string
  • inspector/front-end/Script.js: (WebInspector.Script): if no sourceURL is available for the Script, search for a comment of the form @ sourceURL=(url) to use as the sourceURL instead.
  • manual-tests/inspector/named-evals.html: Added.
1:34 PM Changeset in webkit [45185] by levin@chromium.org
  • 7 edits
    2 adds in trunk

WebCore:

2009-06-25 John Gregg <johnnyg@google.com>

Reviewed by Sam Weinig.

Bug 23721: Changing dropdown's selectedIndex within onchange handler fires another onchange
https://bugs.webkit.org/show_bug.cgi?id=23721

onchange events fire when a SELECT element has
focus and the selectedIndex is updated by script in some way--either
during another onchange, onkeypress, onfocus, or timer--and then
focus is lost.

Fixed by making a separate method for user-driven selectedIndex
changes, leaving scripts to use one which doesn't cause onchange to
be queued.

Test: fast/forms/select-script-onchange.html

  • dom/SelectElement.cpp: check if the pending change is user driven before calling onchange (WebCore::SelectElement::menuListOnChange): (WebCore::SelectElement::setSelectedIndex):
  • dom/SelectElement.h: store whether the pending change is user driven (WebCore::SelectElementData::userDrivenChange): (WebCore::SelectElementData::setUserDrivenChange):
  • html/HTMLSelectElement.cpp: split into two methods -- script version [non-user-driven] corresponds to IDL defined property name (WebCore::HTMLSelectElement::setSelectedIndex): (WebCore::HTMLSelectElement::setSelectedIndexByUser):
  • html/HTMLSelectElement.h:
  • rendering/RenderMenuList.cpp: use ByUser method when coming through the renderer (WebCore::RenderMenuList::valueChanged):

LayoutTests:

2009-06-25 John Gregg <johnnyg@google.com>

Reviewed by Sam Weinig.

Bug 23721: Changing dropdown's selectedIndex within onchange handler fires another onchange
https://bugs.webkit.org/show_bug.cgi?id=23721

Check for unnecessary calls to onchange in response to script
actions.

  • fast/forms/select-script-onchange-expected.txt: Added.
  • fast/forms/select-script-onchange.html: Added.
1:10 PM Changeset in webkit [45184] by mrowe@apple.com
  • 4 edits in tags/Safari-6531.1

Versioning.

1:02 PM Changeset in webkit [45183] by darin@chromium.org
  • 14 edits
    4 deletes in trunk/WebCore

2009-06-25 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26698

Combined LocalStorageArea and SessionStorageArea into StorageArea since
(after my other refactorings) there are no longer substantial
differences between the two.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea):
  • storage/LocalStorage.h:
  • storage/LocalStorageArea.cpp: Removed.
  • storage/LocalStorageArea.h: Removed.
  • storage/SessionStorage.cpp: (WebCore::SessionStorage::copy): (WebCore::SessionStorage::storageArea):
  • storage/SessionStorage.h:
  • storage/SessionStorageArea.cpp: Removed.
  • storage/SessionStorageArea.h: Removed.
  • storage/StorageArea.cpp: (WebCore::StorageArea::createLocalStorage): (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::createSessionStorage): (WebCore::StorageArea::copy): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear): (WebCore::StorageArea::scheduleFinalSync): (WebCore::StorageArea::blockUntilImportComplete): (WebCore::StorageArea::dispatchStorageEvent):
  • storage/StorageArea.h:
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::scheduleFinalSync): (WebCore::StorageAreaSync::syncTimerFired): (WebCore::StorageAreaSync::performImport):
  • storage/StorageAreaSync.h:
  • storage/StorageSyncManager.h:
12:50 PM Changeset in webkit [45182] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

12:48 PM Changeset in webkit [45181] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.1

New tag.

12:45 PM Changeset in webkit [45180] by mitz@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/dom/style-sheet-candidate-remove-unrendered-document.html

When a "style sheet candidate" element is removed from a document,
call Document::removeStyleSheetCandidateNode() regardless of whether
the document is rendered. Otherwise, the document's style sheet
candidate set can end up containing stale references.

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::removedFromDocument):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::removedFromDocument):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::removedFromDocument):

LayoutTests:

Reviewed by Darin Adler.

  • fast/dom/style-sheet-candidate-remove-unrendered-document-expected.txt: Added.
  • fast/dom/style-sheet-candidate-remove-unrendered-document.html: Added.
11:53 AM Changeset in webkit [45179] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-06-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

Update CodeGeneratorV8.pm to sync up with the changes downstream.

  • bindings/scripts/CodeGeneratorV8.pm: Added HTMLFrameSetElement check, FileList as a ref-counted type, and DataGridColumn as typeCanFailConversion.
11:14 AM Changeset in webkit [45178] by rwlbuis@webkit.org
  • 2 edits in trunk

Credit the correct reviewer.

10:23 AM Changeset in webkit [45177] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-06-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig (sort of, maybe).


Fixed some ASSERTs in http/tests/security.


These ASSERTs were introduced by http://trac.webkit.org/changeset/45057,
but the underlying problem was actually older. http://trac.webkit.org/changeset/45057
just exposed the problem by enabling optimization in more cases.


The ASSERTs fired because we tested PropertySlot::slotBase() for validity,
but slotBase() ASSERTs if it's invalid, so we would ASSERT before
the test could happen. Solution: Remove the ASSERT. Maybe it was valid
once, but it clearly goes against a pattern we've deployed of late.


The underlying problem was that WebCore would re-use a PropertySlot in
the case of a forwarding access, and the second use would not completely
overwrite the first use. Solution: Make sure to overwrite m_offset when
setting a value on a PropertySlot. (Other values already get implicitly
overwritten during reuse.)

  • runtime/PropertySlot.h: (JSC::PropertySlot::PropertySlot): (JSC::PropertySlot::setValueSlot): (JSC::PropertySlot::setValue): (JSC::PropertySlot::setRegisterSlot): (JSC::PropertySlot::setUndefined): (JSC::PropertySlot::slotBase): (JSC::PropertySlot::clearOffset):
9:08 AM ProjectVision edited by treat@kde.org
(diff)
9:03 AM QtWebKit edited by treat@kde.org
(diff)
9:00 AM QtWebKitContrib edited by treat@kde.org
(diff)
8:54 AM QtWebKitGitInstructions edited by treat@kde.org
(diff)
8:50 AM Changeset in webkit [45176] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-06-25 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

Add FileList.h include to fix Chromium build.

  • platform/chromium/ClipboardChromium.cpp: Added FileList.h include.
8:48 AM UsingGitWithWebKit edited by treat@kde.org
(diff)
8:46 AM UsingGitWithWebKit edited by treat@kde.org
(diff)
8:46 AM UsingGitWithWebKit edited by treat@kde.org
(diff)
8:37 AM UsingGitWithWebKit edited by treat@kde.org
Make this more explicit. (diff)
6:14 AM Changeset in webkit [45175] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Use Q_ASSERT in Qt's DumpRenderTree instead of JSC's ASSERT

The WTFReportAssertionFailure function in JSC is not exported when
building QtWebKit in both debug and release on Mac, so DRT fails to
link.

We can revert this patch once the Qt port builds JSC as a separate
library, and we add the proper export macros to Assertions.cpp

  • DumpRenderTree/qt/WorkQueue.cpp: (WorkQueue::queue): (WorkQueue::dequeue):
6:11 AM Changeset in webkit [45174] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Jan Alonzo.

bugzilla-tool: Add Simon Hausmann as reviewer

  • Scripts/modules/bugzilla.py:
5:42 AM Changeset in webkit [45173] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2009-06-25 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Jan Alonzo.

Bug 26489: Web Inspector: Typo in DatabaseQuery Error Message
https://bugs.webkit.org/show_bug.cgi?id=26489

Fixed a Typo in a Web Inspector error message.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryError):
4:11 AM Changeset in webkit [45172] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-06-25 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Qt build, add missing StorageAreaSync files to the build.

  • WebCore.pro:
3:56 AM Changeset in webkit [45171] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-06-25 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by and done with Tor Arne Vestbø.

Fix shortcut keyboard handling with plugins on the Qt/Mac build.

When we receive shortcut events like Ctrl+V then the text in the QKeyEvent is
empty. If we're asked to disambiguate the event into a Char keyboard event,
we try to detect this situation and still set the text, to ensure that the
general event handling sends a key press event after this disambiguation.

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
3:05 AM Changeset in webkit [45170] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2009-06-25 Eric Seidel <eric@webkit.org>

No review, just skipping a new test.

Skip new test on platforms missing eventSender.beginDragWithFiles
Test: http/tests/security/clipboard/clipboard-file-access.html
https://bugs.webkit.org/show_bug.cgi?id=25916

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
2:49 AM Changeset in webkit [45169] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-06-25 Eric Seidel <eric@webkit.org>

Build fix only, no review.

Add FileList.h and NotImplemented.h includes in an attempt to fix bots.

  • platform/gtk/ClipboardGtk.cpp:
  • platform/qt/ClipboardQt.cpp:
  • platform/win/ClipboardWin.cpp:
  • platform/wx/ClipboardWx.cpp:
2:24 AM Changeset in webkit [45168] by eric@webkit.org
  • 16 edits
    8 adds in trunk

2009-06-24 Dan Bernstein <mitz@apple.com>

Reviewed by Simon Fraser.

  • test for <rdar://problem/7001817> REGRESSION (r41902): Base position track at UCSC Genome Browser doesn't work because image map prevents img from hit-testing
  • fast/replaced/image-map-2-expected.txt: Added.
  • fast/replaced/image-map-2.html: Added.

2009-05-21 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

Expose files in the clipboard in ondrop events
https://bugs.webkit.org/show_bug.cgi?id=25916

Make it possible for applications like gmail to implement
drag and drop of attachments onto email messages.

This patch exposes an event.dataTransfer.files accessor
on the drop event. No information is exposed during dragover.
This follows the HTML 5 drag and drop security model:
http://www.w3.org/TR/html5/editing.html#security-risks-in-the-drag-and-drop-model
The test http/tests/security/clipboard/clipboard-file-access.html
verifies this behavior.

Internet Explorer shows historical documentation of supporting
getData('File') as a way of exposing files on the pasteboard. The current version of their docs:
http://msdn.microsoft.com/en-us/library/ms537658(VS.85).aspx
has removed this reference (as far as I can tell IE never implemented it)
I have a printed copy of that URL from 2008 on my desk describing getData('File') in IE.
IE does not follow the HTML5 clipboard security model and always allows access to the full clipboard, even on dragover.

I choose not to use IE's getData('File') and instead added .files
so that the accessor could have a type, matching WebKit's existing
.files accessor on HTMLInputElement.

Mozilla has equivalent file access:
event.dataTransfer.mozGetDataAt("application/x-moz-file", 0);
which also does not return a typed value.
https://developer.mozilla.org/En/DragDrop/Recommended_Drag_Types#Dragging_Files

This is only implemented for Mac WebKit. All other platforms (including Apple's Win WebKit)
have incomplete Clipboard implementations and will require experts from those platforms
to add this functionality. Right now they all have Clipboard*::files() methods which call notImplemented();

Test: http/tests/security/clipboard/clipboard-file-access.html

  • dom/Clipboard.h:
  • dom/Clipboard.idl:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::files):
  • platform/chromium/ClipboardChromium.h:
  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::files):
  • platform/gtk/ClipboardGtk.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::absoluteURLsFromPasteboardFilenames): (WebCore::absoluteURLsFromPasteboard): (WebCore::ClipboardMac::files):
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::files):
  • platform/qt/ClipboardQt.h:
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::files):
  • platform/win/ClipboardWin.h:
  • platform/wx/ClipboardWx.cpp: (WebCore::ClipboardWx::files):
  • platform/wx/ClipboardWx.h:
1:51 AM Changeset in webkit [45167] by barraclough@apple.com
  • 4 edits in branches/nitro-extreme

Merged r44794:44796 into nitro-extreme branch.

1:41 AM Changeset in webkit [45166] by barraclough@apple.com
  • 151 edits
    2 copies in branches/nitro-extreme

Merged r44747:44794 into nitro-extreme branch.

1:27 AM Changeset in webkit [45165] by eric@webkit.org
  • 1 edit
    4 adds in trunk/WebCore

2009-06-25 Eric Seidel <eric@webkit.org>

No review, only completing revert of r45144.

Add back files deleted by r45144.

  • storage/LocalStorageArea.cpp: Added. (WebCore::LocalStorageArea::create): (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::scheduleFinalSync): (WebCore::LocalStorageArea::itemChanged): (WebCore::LocalStorageArea::itemRemoved): (WebCore::LocalStorageArea::areaCleared): (WebCore::LocalStorageArea::blockUntilImportComplete): (WebCore::LocalStorageArea::dispatchStorageEvent):
  • storage/LocalStorageArea.h: Added.
  • storage/SessionStorageArea.cpp: Added. (WebCore::SessionStorageArea::copy): (WebCore::SessionStorageArea::SessionStorageArea): (WebCore::SessionStorageArea::itemChanged): (WebCore::SessionStorageArea::itemRemoved): (WebCore::SessionStorageArea::areaCleared): (WebCore::SessionStorageArea::blockUntilImportComplete): (WebCore::SessionStorageArea::dispatchStorageEvent):
  • storage/SessionStorageArea.h: Added. (WebCore::SessionStorageArea::create):
1:26 AM Changeset in webkit [45164] by barraclough@apple.com
  • 6 edits in branches/nitro-extreme

Merged r44743:44747 into nitro-extreme branch.

1:22 AM Changeset in webkit [45163] by barraclough@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

Merged r44742:44743 into nitro-extreme branch.

1:19 AM Changeset in webkit [45162] by eric@webkit.org
  • 14 edits in trunk/WebCore

2009-06-25 Eric Seidel <eric@webkit.org>

No review, reverting r45144 only.

Roll out r45144 after 18 test failures appeared on the bots.
https://bugs.webkit.org/show_bug.cgi?id=26698

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea):
  • storage/LocalStorage.h:
  • storage/SessionStorage.cpp: (WebCore::SessionStorage::copy): (WebCore::SessionStorage::storageArea):
  • storage/SessionStorage.h:
  • storage/StorageArea.cpp: (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::~StorageArea): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear):
  • storage/StorageArea.h:
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::scheduleFinalSync): (WebCore::StorageAreaSync::syncTimerFired): (WebCore::StorageAreaSync::performImport):
  • storage/StorageAreaSync.h:
  • storage/StorageSyncManager.h:
1:17 AM Changeset in webkit [45161] by barraclough@apple.com
  • 56 edits
    47 copies
    14 deletes in branches/nitro-extreme

Merged r44712:44742 into nitro-extreme branch.

1:09 AM Changeset in webkit [45160] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-06-24 Eric Seidel <eric@webkit.org>

Reviewed by Dave Levin.

Support local commits during apply-patches
and let land-patches take multiple bug ids.
https://bugs.webkit.org/show_bug.cgi?id=26703

I also restructured parts of land-patches into
class methods and static methods in preparation
for future code sharing with other commands.

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
  • Scripts/modules/scm.py:
1:09 AM Changeset in webkit [45159] by barraclough@apple.com
  • 18 edits
    1 copy in branches/nitro-extreme

Merged r44710:44712 into nitro-extreme branch.

1:03 AM Changeset in webkit [45158] by barraclough@apple.com
  • 11 edits in branches/nitro-extreme/WebCore

Merged r44705:44710 into nitro-extreme branch.

1:01 AM Changeset in webkit [45157] by barraclough@apple.com
  • 11 edits in branches/nitro-extreme/JavaScriptCore

Merged r44704:44705 into nitro-extreme branch.

12:56 AM Changeset in webkit [45156] by barraclough@apple.com
  • 2 adds in branches/nitro-extreme/JavaScriptCore/runtime

Build-fix, had failed to add JSONObject.cpp/.h.

12:52 AM Changeset in webkit [45155] by barraclough@apple.com
  • 19 edits in branches/nitro-extreme

Merged r44700:44704 into nitro-extreme branch.

12:49 AM Changeset in webkit [45154] by barraclough@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

Merged r44699:44700 into nitro-extreme branch.

12:45 AM Changeset in webkit [45153] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-25 Eric Seidel <eric@webkit.org>

Reviewed by Tor Arne Vestbø.

Make svn-apply work with Git too
https://bugs.webkit.org/show_bug.cgi?id=26299

Add an --force option to svn-apply and otherwise make svn-apply
exit non-zero when patch application fails.
https://bugs.webkit.org/show_bug.cgi?id=26300

I did not update svn-unapply, because it makes no sense in a Git world.
You don't roll in and out patch files. You make commits and deal with those.
Git users can just git reset --hard to get the same functionality.

  • Scripts/svn-apply:
12:42 AM Changeset in webkit [45152] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-06-25 Eric Seidel <eric@webkit.org>

Reviewed by Tor Arne Vestbø.

Remove use of os.system to fix reviewers with unicode chars in their names
https://bugs.webkit.org/show_bug.cgi?id=26713

Also change to latin1 encoding of ø to make python happy.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/scm.py:
12:42 AM Changeset in webkit [45151] by barraclough@apple.com
  • 17 edits
    2 copies in branches/nitro-extreme

Merged r44693:44699 into nitro-extreme branch.

12:34 AM Changeset in webkit [45150] by barraclough@apple.com
  • 6 edits in branches/nitro-extreme/JavaScriptCore

Merged r44692:44693 into nitro-extreme branch.

12:22 AM Changeset in webkit [45149] by barraclough@apple.com
  • 319 edits
    140 copies
    39 deletes in branches/nitro-extreme

Merged r44526:44692 into nitro-extreme branch.

12:07 AM Changeset in webkit [45148] by barraclough@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

Merged r44525:44526 into nitro-extreme branch.

12:06 AM Changeset in webkit [45147] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-25 Eric Seidel <eric@webkit.org>

Reviewed by Tor Arne Vestbø.

Add Adam Roben and Tor Arne Vestbø to the reviewers list.

  • Scripts/modules/bugzilla.py:
12:00 AM Changeset in webkit [45146] by barraclough@apple.com
  • 8 edits in branches/nitro-extreme

Merged r44523:44525 into nitro-extreme branch.

Jun 24, 2009:

11:56 PM Changeset in webkit [45145] by barraclough@apple.com
  • 8 edits in branches/nitro-extreme/JavaScriptCore

Merged r44520:44523 into nitro-extreme branch.

11:16 PM Changeset in webkit [45144] by darin@chromium.org
  • 14 edits
    4 deletes in trunk/WebCore

2009-06-24 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26698

Combined LocalStorageArea and SessionStorageArea into StorageArea since
(after my other refactorings) there are no longer substantial
differences between the two.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea):
  • storage/LocalStorage.h:
  • storage/LocalStorageArea.cpp: Removed.
  • storage/LocalStorageArea.h: Removed.
  • storage/SessionStorage.cpp: (WebCore::SessionStorage::copy): (WebCore::SessionStorage::storageArea):
  • storage/SessionStorage.h:
  • storage/SessionStorageArea.cpp: Removed.
  • storage/SessionStorageArea.h: Removed.
  • storage/StorageArea.cpp: (WebCore::StorageArea::createLocalStorage): (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::createSessionStorage): (WebCore::StorageArea::copy): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear): (WebCore::StorageArea::scheduleFinalSync): (WebCore::StorageArea::blockUntilImportComplete): (WebCore::StorageArea::dispatchStorageEvent):
  • storage/StorageArea.h:
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::scheduleFinalSync): (WebCore::StorageAreaSync::syncTimerFired): (WebCore::StorageAreaSync::performImport):
  • storage/StorageAreaSync.h:
  • storage/StorageSyncManager.h:
10:01 PM Changeset in webkit [45143] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Simon Fraser.

  • fix <rdar://problem/7001817> REGRESSION (r41902): Base position track at UCSC Genome Browser doesn't work because image map prevents img from hit-testing

Test: fast/replaced/image-map-2.html

  • rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint): Do not reset 'inside' to false if the image map failed the hit test.

LayoutTests:

Reviewed by Simon Fraser.

  • test for <rdar://problem/7001817> REGRESSION (r41902): Base position track at UCSC Genome Browser doesn't work because image map prevents img from hit-testing
  • fast/replaced/image-map-2-expected.txt: Added.
  • fast/replaced/image-map-2.html: Added.
8:41 PM Changeset in webkit [45142] by barraclough@apple.com
  • 34 edits
    11 copies
    6 deletes in branches/nitro-extreme

Merged r44514:44520 into nitro-extreme branch.

8:34 PM Changeset in webkit [45141] by barraclough@apple.com
  • 8 edits
    2 copies in branches/nitro-extreme/JavaScriptCore

Merged r44513:44514 into nitro-extreme branch.

8:30 PM Changeset in webkit [45140] by barraclough@apple.com
  • 53 edits
    8 copies
    3 deletes in branches/nitro-extreme

Merged r44492:44513 into nitro-extreme branch.

8:18 PM Changeset in webkit [45139] by barraclough@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

Merged r44491:44492 into nitro-extreme branch.

8:07 PM Changeset in webkit [45138] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-06-24 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Make the opcode sampler work once again.

  • jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdSelfList): (JSC::JIT::compileGetByIdProtoList): (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compileCTIMachineTrampolines): (JSC::JIT::compilePatchGetArrayLength):
  • jit/JITStubCall.h: (JSC::JITStubCall::call):
8:06 PM Changeset in webkit [45137] by barraclough@apple.com
  • 80 edits
    4 copies
    1 delete in branches/nitro-extreme

Merged r44460:44491 into nitro-extreme branch.

8:00 PM Changeset in webkit [45136] by barraclough@apple.com
  • 12 edits in branches/nitro-extreme

Merged r44455:44460 into nitro-extreme branch.

7:56 PM Changeset in webkit [45135] by barraclough@apple.com
  • 13 edits in branches/nitro-extreme/JavaScriptCore

Merged r44454:44455 into nitro-extreme branch.

7:38 PM Changeset in webkit [45134] by abarth@webkit.org
  • 5 edits
    2 adds in trunk/WebCore

2009-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26366

Refactor V8DOMMap to support isolated worlds.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluateInNewWorld):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8DOMMap.cpp: (WebCore::DOMDataStore::InternalDOMWrapperMap::InternalDOMWrapperMap): (WebCore::DOMDataStore::allStores): (WebCore::DOMDataStore::allStoresMutex): (WebCore::DOMDataStore::domData): (WebCore::ScopedDOMDataStore::ScopedDOMDataStore): (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore): (WebCore::StaticDOMDataStore::StaticDOMDataStore): (WebCore::): (WebCore::MainThreadDOMData::MainThreadDOMData): (WebCore::MainThreadDOMData::getStore): (WebCore::ChildThreadDOMData::ChildThreadDOMData): (WebCore::ChildThreadDOMData::getStore): (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStoreHandle::DOMDataStoreHandle): (WebCore::DOMDataStoreHandle::~DOMDataStoreHandle): (WebCore::::forget): (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap): (WebCore::DOMData::getCurrent): (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::ensureDeref): (WebCore::weakDOMObjectCallback): (WebCore::weakActiveDOMObjectCallback): (WebCore::weakNodeCallback): (WebCore::weakSVGElementInstanceCallback): (WebCore::weakSVGObjectWithContextCallback): (WebCore::DOMData::derefObject): (WebCore::DOMData::derefDelayedObjects): (WebCore::DOMData::derefDelayedObjectsInCurrentThread): (WebCore::DOMData::removeObjectsFromWrapperMap): (WebCore::removeAllDOMObjectsInCurrentThreadHelper): (WebCore::visitDOMNodesInCurrentThread): (WebCore::visitDOMObjectsInCurrentThread): (WebCore::visitActiveDOMObjectsInCurrentThread): (WebCore::visitDOMSVGElementInstancesInCurrentThread): (WebCore::visitSVGObjectsInCurrentThread):
  • bindings/v8/V8DOMMap.h: (WebCore::DOMDataStoreHandle::getStore):
  • bindings/v8/V8IsolatedWorld.cpp: Added. (WebCore::getIsolatedWorldKey): (WebCore::contextWeakReferenceCallback): (WebCore::V8IsolatedWorld::evaluate): (WebCore::V8IsolatedWorld::V8IsolatedWorld): (WebCore::V8IsolatedWorld::~V8IsolatedWorld): (WebCore::V8IsolatedWorld::getEntered):
  • bindings/v8/V8IsolatedWorld.h: Added. (WebCore::V8IsolatedWorld::getDOMDataStore):
7:06 PM Changeset in webkit [45133] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

7:04 PM Changeset in webkit [45132] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.19

New tag.

6:52 PM Changeset in webkit [45131] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-06-24 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Bug 26604: Search doesn't work in Web Inspector Profiler
https://bugs.webkit.org/show_bug.cgi?id=26604

Seems like search was damaged in revision 42808.

  • inspector/front-end/ProfileView.js: (WebInspector.ProfileView.prototype.refresh): Here and in other functions: nodes we're searching in are profile data grid nodes, so there is no more need for '_dataGridNode' references. (WebInspector.ProfileView.prototype.searchCanceled): (WebInspector.ProfileView.prototype.performSearch.matchesQuery): Fixed accidental semicolon that caused 'matchesQuery' always return true. (WebInspector.ProfileView.prototype.performSearch): To perform search correctly in the case of bottom up tree, we need to populate the tree, because there's no 1-to-1 correspondence between profile nodes and data grid nodes in this case. (WebInspector.ProfileView.prototype._jumpToSearchResult):
6:32 PM Changeset in webkit [45130] by eric@webkit.org
  • 5 edits in trunk/JavaScriptCore

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Maciej Stachowiak.

Extend FastAllocBase.h with 'using WTF::FastAllocBase' to avoid

unnecessary WTF
usings.
Remove existing unnecessary WTF
usings.
  • interpreter/Interpreter.h:
  • profiler/CallIdentifier.h:
  • runtime/ScopeChain.h:
  • wtf/FastAllocBase.h:
6:07 PM Changeset in webkit [45129] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-06-24 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

<rdar://problem/6450239&6574516>

Fix flashing issues caused by compositing layers rendering content before
a deferred layout has happened. Because the -viewWillDraw machinery doesn't
work for composited layers, we need to use scheduleViewUpdate() to queue
up a layout via the run loop observer in WebKit, whenever we know we
are going to be painting soon.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::setContentsNeedDisplay): (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
5:45 PM Changeset in webkit [45128] by levin@chromium.org
  • 5 edits
    1 add in trunk

JavaScriptCore:

2009-06-24 David Levin <levin@chromium.org>

Fix all builds.

  • bytecode/CodeBlock.h:
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Register.h:

WebCore:

2009-06-24 David Levin <levin@chromium.org>

Fix all builds.

  • ForwardingHeaders/wtf/FastAllocBase.h: Added.
5:42 PM Changeset in webkit [45127] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

5:25 PM Changeset in webkit [45126] by barraclough@apple.com
  • 64 edits
    11 copies
    1 delete in branches/nitro-extreme

Merged r44437:44454 into nitro-extreme branch.

5:20 PM Changeset in webkit [45125] by barraclough@apple.com
  • 6 edits in branches/nitro-extreme/JavaScriptCore

Merged r44436:44437 into nitro-extreme branch.

4:56 PM Changeset in webkit [45124] by darin@chromium.org
  • 16 edits
    2 copies in trunk/WebCore

2009-06-24 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26658

Split the syncing portions of LocalStorageArea into StorageAreaSync.
This name will make more sense in the next patch (in this set) when
LocalStorageArea and SessionStorageArea are merged to become simply
StorageArea. (Thus the synching portion of StorageArea is in
StorageAreaSync.)

This looks like a big patch, but really all it's doing is splitting
code and patching split-related things up.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::create): (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::scheduleFinalSync): (WebCore::LocalStorageArea::itemChanged): (WebCore::LocalStorageArea::itemRemoved): (WebCore::LocalStorageArea::areaCleared): (WebCore::LocalStorageArea::blockUntilImportComplete):
  • storage/LocalStorageArea.h:
  • storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::LocalStorageTask):
  • storage/LocalStorageTask.h: (WebCore::LocalStorageTask::createImport): (WebCore::LocalStorageTask::createSync):
  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync):
  • storage/LocalStorageThread.h:
  • storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::blockUntilImportComplete):
  • storage/SessionStorageArea.h:
  • storage/StorageArea.h:
  • storage/StorageAreaSync.cpp: Copied from WebCore/storage/LocalStorageArea.cpp.
  • storage/StorageAreaSync.h: Copied from WebCore/storage/LocalStorageArea.h.
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
  • storage/StorageSyncManager.h:
4:55 PM Changeset in webkit [45123] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26677

Inherits CodeBlock class from FastAllocBase because it
has been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.h:217.

  • bytecode/CodeBlock.h:
4:55 PM Changeset in webkit [45122] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26676

Inherits BytecodeGenerator class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/parser/Nodes.cpp:1892.

  • bytecompiler/BytecodeGenerator.h:
4:54 PM Changeset in webkit [45121] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26675

Inherits Register class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/JSVariableObject.h:149.

  • interpreter/Register.h:
4:53 PM Changeset in webkit [45120] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26674

Inherits HashMap class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Structure.cpp:458.

  • wtf/HashMap.h:
4:52 PM Changeset in webkit [45119] by barraclough@apple.com
  • 49 edits
    11 copies in branches/nitro-extreme

Merged r44412:44436 into nitro-extreme branch.

4:33 PM Changeset in webkit [45118] by barraclough@apple.com
  • 10 edits in branches/nitro-extreme/JavaScriptCore

Merged r44411:44412 into nitro-extreme branch.

4:32 PM Changeset in webkit [45117] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-06-24 Adam Treat <adam.treat@torchmobile.com>

Fix Qt build.

  • WebCore.pro:
4:23 PM Changeset in webkit [45116] by mrowe@apple.com
  • 5 edits in branches/WWDC-2009-branch/WebCore

Merge r44877.

4:23 PM Changeset in webkit [45115] by mrowe@apple.com
  • 3 edits in branches/WWDC-2009-branch/JavaScriptCore

Merge r44845.

4:23 PM Changeset in webkit [45114] by mrowe@apple.com
  • 11 edits in branches/WWDC-2009-branch/JavaScriptCore

Merge r44844.

4:23 PM Changeset in webkit [45113] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/LayoutTests

Merge r44262.

4:00 PM Changeset in webkit [45112] by Chris Fleizach
  • 2 edits in trunk/WebKitTools

Windows build fix for fallout from

Bug 26668: AX: need a way to retrieve the language for an element

3:47 PM Changeset in webkit [45111] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-06-24 David Levin <levin@chromium.org>

Reviewed by David Hyatt.

Bug 26696: Member functions in DataGridColumnList should return pointers instead of PassRefPtr.
https://bugs.webkit.org/show_bug.cgi?id=26696

  • html/DataGridColumnList.cpp: (WebCore::DataGridColumnList::itemWithName): (WebCore::DataGridColumnList::add):
  • html/DataGridColumnList.h: (WebCore::DataGridColumnList::item): (WebCore::DataGridColumnList::primaryColumn): (WebCore::DataGridColumnList::sortColumn):
3:19 PM Changeset in webkit [45110] by weinig@apple.com
  • 18 edits in trunk/WebCore

2009-06-24 Sam Weinig <sam@webkit.org>

Reviewed by Dave "Messy" Hyatt.

Little bit of style cleanup.

  • html/DataGridColumn.cpp:
  • html/DataGridColumn.h:
  • html/DataGridColumn.idl:
  • html/DataGridColumnList.cpp:
  • html/DataGridColumnList.h:
  • html/DataGridColumnList.idl:
  • html/HTMLDataGridCellElement.cpp:
  • html/HTMLDataGridCellElement.h:
  • html/HTMLDataGridCellElement.idl:
  • html/HTMLDataGridColElement.cpp:
  • html/HTMLDataGridColElement.h:
  • html/HTMLDataGridColElement.idl:
  • html/HTMLDataGridElement.h:
  • html/HTMLDataGridElement.idl:
  • html/HTMLDataGridRowElement.cpp:
  • html/HTMLDataGridRowElement.h:
  • html/HTMLDataGridRowElement.idl:
3:14 PM Changeset in webkit [45109] by Chris Fleizach
  • 11 edits
    2 adds in trunk

Bug 26668: AX: need a way to retrieve the language for an element
https://bugs.webkit.org/show_bug.cgi?id=26668

3:12 PM Changeset in webkit [45108] by barraclough@apple.com
  • 132 edits
    31 copies
    6 deletes in branches/nitro-extreme

Merged r44350:44411 into nitro-extreme branch.

3:04 PM Changeset in webkit [45107] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-06-24 Brady Eidson <beidson@apple.com>

Reviewed by Dan Bernstein.


<rdar://problem/6893811> Instead of downloading files linked from Google Earth, file contents displayed in browser window as text.

  • platform/network/mac/WebCoreURLResponse.mm: (createBinaryExtensionsSet): Add '.kmz' to the list of known-to-be-binary extensions.
3:01 PM Changeset in webkit [45106] by oliver@apple.com
  • 6 edits
    3 adds in trunk

<rdar://problem/6940519> REGRESSION (Safari 4 Public Beta - TOT): google.com/adplanner shows blank page instead of site details in "basic research'

Reviewed by Darin Adler.

The problem was caused by the page returned with a function using a
var declaration list containing around ~3000 variables. The solution
to this is to flatten the comma expression representation and make
codegen comma expressions and initializer lists iterative rather than
recursive.

2:53 PM Changeset in webkit [45105] by barraclough@apple.com
  • 29 edits
    3 copies in branches/nitro-extreme

Merged r44340:44350 into nitro-extreme branch.

2:12 PM Changeset in webkit [45104] by mitz@apple.com
  • 1 edit in trunk/WebKit/mac/ChangeLog

Rephrased change log

2:10 PM Changeset in webkit [45103] by eric@webkit.org
  • 8 edits in trunk/WebCore

2009-06-24 Nicolas Weber <thakis@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26685
Accomodate for backwards-incompatible skia api changes.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setCompositeOperation):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap): (WebCore::Image::drawPattern):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): (PlatformContextSkia::setupPaintCommon): (PlatformContextSkia::setXfermodeMode): (PlatformContextSkia::applyClipFromImage):
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaUtils.cpp: (WebCore::): (WebCore::WebCoreCompositeToSkiaComposite):
  • platform/graphics/skia/SkiaUtils.h:
2:05 PM Changeset in webkit [45102] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

Fix the most recently seen kind of crash seen in
<rdar://problem/5983224>

  • WebView/WebHTMLView.mm: (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Null-check the Frame.
2:01 PM Changeset in webkit [45101] by barraclough@apple.com
  • 1286 edits
    98 copies
    17 deletes in branches/nitro-extreme

Merged r44170:44340 into nitro-extreme branch.

1:51 PM Changeset in webkit [45100] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-24 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix. Add files that were added in r45093 and r45096

  • GNUmakefile.am:
1:36 PM Changeset in webkit [45099] by barraclough@apple.com
  • 242 edits
    60 copies
    9 deletes in branches/nitro-extreme

Merged r44076:44170 into nitro-extreme branch.

1:33 PM Changeset in webkit [45098] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-06-24 Brady Eidson <beidson@apple.com>

Fix 64-bit SnowLeopard build.

  • html/DataGridColumnList.cpp: (WebCore::DataGridColumnList::remove): (WebCore::DataGridColumnList::move):
1:15 PM Changeset in webkit [45097] by barraclough@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-06-24 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Enable JIT_OPTIMIZE_METHOD_CALLS on the branch, implementation matches current implemenatation in ToT.

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emitSlow_op_method_check): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::compileGetByIdSlowCase):
1:06 PM Changeset in webkit [45096] by hyatt@apple.com
  • 1 add in trunk/WebCore/bindings/js/JSDataGridColumnListCustom.cpp

Fix Mac build.

12:44 PM Changeset in webkit [45095] by rwlbuis@webkit.org
  • 3 edits
    12 adds in trunk

Reviewed by Niko.

https://bugs.webkit.org/show_bug.cgi?id=26392
Bug 26392: In html, modification of xlink:href of an newly inserted svg image does not work.
https://bugs.webkit.org/show_bug.cgi?id=26328
Bug 26328: changing href attribute of svg images dows not work when changing display attribute as well

React to href updates even when there is no renderer, i.e. display=none.

Tests: svg/custom/js-update-image-and-display.svg

svg/custom/js-update-image-and-display2.svg
svg/custom/js-update-image-and-display3.svg

12:41 PM Changeset in webkit [45094] by mitz@apple.com
  • 2 edits
    5 adds in trunk/LayoutTests

Add Windows test results for a couple of search field tests

12:22 PM Changeset in webkit [45093] by hyatt@apple.com
  • 16 edits
    8 adds in trunk

WebCore:

2009-06-24 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26687

Add basic back-end column support to datagrid.

Added fast/dom/HTMLDataGridElement/ column tests.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/DataGridColumn.cpp: Added. (WebCore::DataGridColumn::setPrimary):
  • html/DataGridColumn.h: Added. (WebCore::DataGridColumn::create): (WebCore::DataGridColumn::id): (WebCore::DataGridColumn::setId): (WebCore::DataGridColumn::label): (WebCore::DataGridColumn::setLabel): (WebCore::DataGridColumn::type): (WebCore::DataGridColumn::setType): (WebCore::DataGridColumn::sortable): (WebCore::DataGridColumn::setSortable): (WebCore::DataGridColumn::sortDirection): (WebCore::DataGridColumn::setSortDirection): (WebCore::DataGridColumn::primary): (WebCore::DataGridColumn::detachFromColumnList): (WebCore::DataGridColumn::DataGridColumn):
  • html/DataGridColumn.idl: Added.
  • html/DataGridColumnList.cpp: Added. (WebCore::DataGridColumnList::~DataGridColumnList): (WebCore::DataGridColumnList::itemWithName): (WebCore::DataGridColumnList::add): (WebCore::DataGridColumnList::remove): (WebCore::DataGridColumnList::move): (WebCore::DataGridColumnList::clear): (WebCore::DataGridColumnList::primaryColumnChanged):
  • html/DataGridColumnList.h: Added. (WebCore::DataGridColumnList::create): (WebCore::DataGridColumnList::length): (WebCore::DataGridColumnList::item): (WebCore::DataGridColumnList::primaryColumn): (WebCore::DataGridColumnList::sortColumn):
  • html/DataGridColumnList.idl: Added.
  • html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::sortable): (WebCore::HTMLDataGridColElement::setSortable): (WebCore::HTMLDataGridColElement::sortDirection): (WebCore::HTMLDataGridColElement::setSortDirection):
  • html/HTMLDataGridColElement.h:
  • html/HTMLDataGridColElement.idl:
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::HTMLDataGridElement):
  • html/HTMLDataGridElement.h: (WebCore::HTMLDataGridElement::columns):
  • html/HTMLDataGridElement.idl:
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::paintObject): (WebCore::RenderDataGrid::paintColumnHeaders): (WebCore::RenderDataGrid::rebuildColumns):
  • rendering/RenderDataGrid.h: (WebCore::RenderDataGrid::gridElement):

LayoutTests:

2009-06-24 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig.

Add test for https://bugs.webkit.org/show_bug.cgi?id=26687.

  • fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt: Added.
  • fast/dom/HTMLDataGridElement/DataGridColumns-basic.html: Added.
12:14 PM Changeset in webkit [45092] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44951.

12:13 PM Changeset in webkit [45091] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Merge r44941.

12:13 PM Changeset in webkit [45090] by mrowe@apple.com
  • 8 edits
    3 adds in branches/WWDC-2009-branch

Merge r44940.

12:13 PM Changeset in webkit [45089] by mrowe@apple.com
  • 3 edits
    3 adds in branches/WWDC-2009-branch

Merge r44908.

12:13 PM Changeset in webkit [45088] by mrowe@apple.com
  • 6 edits in branches/WWDC-2009-branch

Merge r44906.

10:29 AM Changeset in webkit [45087] by jberlin@apple.com
  • 3 edits
    1 add in trunk/WebCore

2009-06-24 Jessie Berlin <jberlin@apple.com>

Reviewed by Adam Roben.

Partially fixes: https://bugs.webkit.org/show_bug.cgi?id=24735
(<rdar://problem/5015942>)
Where on windows it was not possible to set an element as the drag
image using setDragImage on the dataTransfer object.


Does not "fix" the case of dragging a link where the default link image
is still used, even when the -webkit-user-drag is set to "element". This
is the same behavior as is found on OS X.


Added a manual test because it is not possible to check that what is
contained in the image snapshot is indeed the requested element.

  • dom/Clipboard.h: (WebCore::Clipboard::dragImageElement): Made getting the raw pointer from the RefPtr a const operation.
  • manual-tests/drag-with-div-or-image-as-data-image.html: Added.
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::createDragImage): Get an image of the rendered element and its subtree.
9:48 AM Changeset in webkit [45086] by darin@chromium.org
  • 2 edits
    1 add in trunk/WebCore

2009-06-24 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26683
Fix Chromium build bustage: Add custom binding for HTMLDataGridElement.dataSource

This change just adds a stub implementation for now to help fix the build.

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Added.
8:53 AM Changeset in webkit [45085] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Build fixes for ENABLE(PLUGIN_PROXY_FOR_VIDEO)

Reviewed by Adam Roben.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::deliverNotification): Removed ExceptionCode parameter from togglePlayState(). (WebCore::HTMLMediaElement::initialURL): Don't convert a KURL object to a String when assigning to a KURL variable.
8:44 AM Moving to Git edited by treat@kde.org
(diff)
8:00 AM Changeset in webkit [45084] by Nikolas Zimmermann
  • 13 edits in trunk/WebCore

Reviewed by Adam Treat.

Save memory by not storing attribute values in member variables, if not absolutely needed.
Also fixes bugs where we're substituting variables too early (noticeable with the upcoming <select> element).

7:35 AM Changeset in webkit [45083] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.
Forgot to initialize m_task member variable. Results in crashes sometimes.

7:34 AM Changeset in webkit [45082] by Nikolas Zimmermann
  • 1 edit
    1 add in trunk/WebCore

Not reviewed. Forgot to include within last patch.

7:30 AM Changeset in webkit [45081] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

Reviewed by Nikolas Zimmermann.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26474
Adding WML <card> title attribute handling.

7:02 AM Changeset in webkit [45080] by zecke@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-06-24 Jiahua Huang <jhuangjiahua@gmail.com>

Reviewed by Holger Freyther.

[Gtk] Add Undo/Redo support to WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=26573

Implement EditorClient::undo and other interested funcs.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::registerCommandForUndo): (WebKit::EditorClient::registerCommandForRedo): (WebKit::EditorClient::clearUndoRedoOperations): (WebKit::EditorClient::canUndo): (WebKit::EditorClient::canRedo): (WebKit::EditorClient::undo): (WebKit::EditorClient::redo): (WebKit::EditorClient::EditorClient):
  • WebCoreSupport/EditorClientGtk.h:
3:00 AM Changeset in webkit [45079] by Simon Hausmann
  • 3 edits in trunk/WebCore

2009-06-24 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Fix the build without ENABLE_VIDEO.

  • html/CanvasRenderingContext2D.cpp: Add #if ENABLE guards.
  • html/CanvasRenderingContext2D.h: Ditto.
2:26 AM Changeset in webkit [45078] by oliver@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Temporarily disable failing test

1:56 AM Changeset in webkit [45077] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2009-06-24 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

Add new drag tests to the Skipped lists for non-mac platforms.

Skipped tests:
fast/events/drag-to-navigate.html
fast/events/prevent-drag-to-navigate.html

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
1:15 AM Changeset in webkit [45076] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26645

Inherits ScopeChainNode class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/ScopeChain.h:95.

  • wtf/RefPtr.h:
1:12 AM Changeset in webkit [45075] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2009-06-24 Siddhartha Chattopadhyay <sidchat@google.com>

Reviewed by Eric Seidel.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26200 which I introduced earlier. I had
the smartReplace set TRUE initially, which was wrong since the purpose of this call is
to just replace the selection, and place the caret at the end of the selection it replaced.

  • editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition):
  • manual-tests/textarea-caret-position-after-auto-spell-correct.html: Added.
1:00 AM Changeset in webkit [45074] by eric@webkit.org
  • 2 edits in trunk/WebKit/mac

2009-06-24 Jeff Johnson <opendarwin@lapcatsoftware.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26638 WebKitErrors.m: _initWithPluginErrorCode: does not set localizedDescription

Add localized descriptions for plugin errors.
The localized strings already existed but were unused; now NSLocalizedDescriptionKey is added to the NSError userInfo.

  • Misc/WebKitErrors.m: (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]):
12:54 AM Changeset in webkit [45073] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26648

Inherits Deque class from FastAllocBase because it has been
instantiated by 'new' with DEFINE_STATIC_LOCAL macro in
JavaScriptCore/wtf/MainThread.cpp:62.

  • wtf/Deque.h:
12:53 AM Changeset in webkit [45072] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26644

Inherits RefPtr class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/StructureChain.cpp:41.

  • wtf/RefPtr.h:
12:52 AM Changeset in webkit [45071] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Attempting to make test more reliable.

12:47 AM Changeset in webkit [45070] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-06-24 Kevin Watters <kevinwatters@gmail.com>

Reviewed by Kevin Ollivier.

Don't use an unsigned int for intervalInMS because we sometimes initialize
it with a negative value.

  • platform/wx/SharedTimerWx.cpp: (WebCore::setSharedTimerFireTime):
12:45 AM Changeset in webkit [45069] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Inherits HashSet class from FastAllocBase, because it has been
instantiated by 'new' in JavaScriptCore/runtime/Collector.h:116.

  • wtf/HashSet.h:
12:40 AM Changeset in webkit [45068] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Inherits Vector class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Structure.cpp:633.

  • wtf/Vector.h:
12:34 AM Changeset in webkit [45067] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-24 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

Spell Maciej's name right and add Brady Eidson.

  • Scripts/modules/bugzilla.py:
12:26 AM Changeset in webkit [45066] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-24 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Maciej Stachoviak.

The BytecodeGenerator objects were instantiated on stack, which takes up ~38kB per instance
(each instance includes copy of JSC::CodeBlock with large SymbolTable, etc.).
Specifically, since there is nested invocation (e.g., GlobalCode --> FunctionCode),
the stack overflows immediately on Symbian hardware (max. 80 kB).
Proposed change allocates generator objects on heap.
Performance impact (if any) should be negligible and change is proposed as general fix,
rather than ifdef'd for SYMBIAN.

  • parser/Nodes.cpp: (JSC::ProgramNode::generateBytecode): (JSC::EvalNode::generateBytecode): (JSC::EvalNode::bytecodeForExceptionInfoReparse): (JSC::FunctionBodyNode::generateBytecode): (JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):
12:20 AM Changeset in webkit [45065] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-06-24 Eric Seidel <eric@webkit.org>

No review, build fix only.

The previous checkin had an improper merge. This fixes the build.

  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):
12:07 AM Changeset in webkit [45064] by eric@webkit.org
  • 4 edits
    6 adds in trunk

2009-06-05 Eric Seidel <eric@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=25922
Fix dropEffect = "none" to work as expected.

  • fast/events/drag-to-navigate-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
  • fast/events/drag-to-navigate.html: Added.
  • fast/events/prevent-drag-to-navigate-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
  • fast/events/prevent-drag-to-navigate.html: Added.
  • fast/events/resources/file-for-drag-to-navigate.html: Added.
  • fast/events/resources/file-for-prevent-drag-to-navigate.html: Added.

2009-06-05 Eric Seidel <eric@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=25922
JS setting dropEffect = "none" causes tryDHTMLDrag
to return DragOperationNone. Which is also the value
tryDHTMLDrag previously used to indicate JS did not
want to handle the drag.

Make it possible for the DragController::try* methods
to return a bool to indicate if javascript accepted
or rejected the drag event, separate from the DragOperation.

Tests:

  • fast/events/drag-to-navigate.html
  • fast/events/prevent-drag-to-navigate.html
  • page/DragController.cpp: (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::defaultOperationForDrag): (WebCore::DragController::tryDHTMLDrag):
  • page/DragController.h:
Note: See TracTimeline for information about the timeline view.