Timeline


and

07/02/09:

22:21 Changeset [45530] by pdherbemont@apple.com

Edit WebCore/ChangeLog last entry to fix a spelling typo.

Pointed out by Mark Rowe.

22:12 Changeset [45529] by pdherbemont@apple.com

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26947

Fix the media controls hit tests. They may loose click events.

Test cases already covered in the video-controls-zoomed tests.

Don't trust wkHitTestMediaUIPart for the tests. We are accurate enough.

  • rendering/RenderThemeMac.h: Remove hitTestMediaControlPart.
  • rendering/RenderThemeMac.mm: Remove hitTestMediaControlPart.
20:34 Changeset [45528] by ddkilzer@apple.com

Ignore data/template cache directory and update data/params.

20:15 Changeset [45527] by bfulgham@webkit.org

2009-07-02 Brent Fulgham <bfulgham@webkit.org>

Unreviewed build fix (Cairo this time) for DumpRenderTree.
Put Cairo code back in, but use original include order
for the CG stuff to avoid compile issues.

  • DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView):
19:14 Changeset [45526] by ddkilzer@apple.com

Config file for contrib/recode.pl when upgrading bugs.webkit.org

Current as of midday on Wednesday, July 1, 2009.

  • contrib/recode-overrides.txt: Added.
19:14 Changeset [45525] by ddkilzer@apple.com

Workaround for WebKit Bug 9630 when running contrib/recode.pl

A number of WebKit nightly builds included Bug 9630 which caused
non-breaking space characters (0xA0) to be submitted within the
content of textarea elements.

  • contrib/recode.pl: To work around these 0xA0 characters, try an encoding of cp1252 and use it if it works.
19:14 Changeset [45524] by ddkilzer@apple.com

Don't print "Failed to guess" warning if an override is available

  • contrib/recode.pl: Check that %overrides does NOT contain a key matching the current digest before printing out the warning about a failed charset guess.
19:14 Changeset [45523] by ddkilzer@apple.com

Added --[no-]truncate switch to contrib/recode.pl

  • contrib/recode.pl: Added --[no-]truncate switch to make debugging of failed charset guessing easier. Often times the illegal character was truncated in the output.
19:14 Changeset [45522] by ddkilzer@apple.com

Changed Perl scripts to use #!/usr/bin/env perl

perl -pi -e 's@#\!/usr/bin/perl@#\!/usr/bin/env perl@' *.cgi *.pl */*.pl

19:14 Changeset [45521] by ddkilzer@apple.com

Replace Bugzilla favicon with webkit.org favicon

  • favicon.ico: Removed.
  • images/favicon.ico: Replaced. Copied from favicon.ico.
19:14 Changeset [45520] by ddkilzer@apple.com

Merged BugsSite to Bugzilla-3.2.3

Updated to the latest-and-greatest stable version.

19:13 Changeset [45519] by ddkilzer@apple.com

Merged BugsSite to Bugzilla-3.0.3

Nothing to see here. Move along.

18:38 Changeset [45518] by pdherbemont@apple.com

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26944

Make sure we support full page zoom in video controls.

This is tracked by a the video-controls-zoom test case.

  • css/mediaControlsQT.css: Make sure we don't have any inherited margin.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::updateStyle): Propagate the style to the innertext.
  • rendering/RenderThemeMac.mm: Adjust the painting rect. (WebCore::getUnzoomedRectAndAdjustCurrentContext): (WebCore::RenderThemeMac::paintMediaSliderTrack): (WebCore::RenderThemeMac::paintMediaCurrentTime): (WebCore::RenderThemeMac::paintMediaTimeRemaining):
18:29 Changeset [45517] by eric@webkit.org

2009-07-02 Roland Steiner <rolandsteiner@google.com>

Reviewed by Eric Seidel.

RenderBlock and RenderInline have confusingly named object creation methods:
RenderBlock::createRootBox/createRootInlineBox
RenderInline::createFlowBox/createInlineFlowBox
where the 2nd method in both cases just calls the first and then appends the created object.
I therefore renamed those methods to something IMHO more informative:

createRootBox() -> createRootInlineBox()
createRootInlineBox() -> createAndAppendRootInlineBox();
createFlowBox() -> createInlineFlowBox();
createInlineFlowBox() -> createAndAppendInlineFlowBox();

https://bugs.webkit.org/show_bug.cgi?id=26828

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::createRootInlineBox): (WebCore::RenderBlock::createAndAppendRootInlineBox):
  • rendering/RenderBlock.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::createInlineFlowBox): (WebCore::RenderInline::createAndAppendInlineFlowBox):
  • rendering/RenderInline.h:
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createInlineFlowBox):
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createRootInlineBox):
  • rendering/RenderSVGText.h:
  • rendering/bidi.cpp: (WebCore::createInlineBoxForRenderer):
18:23 Changeset [45516] by eric@webkit.org

2009-07-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Fix typo in the resource panel enabler caption.

https://bugs.webkit.org/show_bug.cgi?id=26753

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel):
18:06 Changeset [45515] by eric@webkit.org

2009-07-02 Erik Arvidsson <arv@chromium.org>

Reviewed by Adam Roben.

[Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
https://bugs.webkit.org/show_bug.cgi?id=26699

  • manual-tests/drag-escape.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::dragSourceEndedAt):

2009-07-02 Erik Arvidsson <arv@chromium.org>

Reviewed by Adam Roben.

[Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
https://bugs.webkit.org/show_bug.cgi?id=26699

  • WebDropSource.cpp: (WebDropSource::QueryContinueDrag):
17:55 Changeset [45514] by eric@webkit.org

2009-07-02 Eric Seidel <eric@webkit.org>

Correct blatant typo (missing []), no review.

  • Scripts/modules/scm.py:
17:54 Changeset [45513] by pdherbemont@apple.com

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Added the test result of r45511 for platform/mac.

  • platform/mac/media/controls-strict-expected.txt: Added.
17:37 Changeset [45512] by bfulgham@webkit.org

2009-07-02 Brent Fulgham <bfulgham@webkit.org>

Windows build fix, no review.

Reverting PixelDumpSupportWin.cpp change to avoid strange
error on the build-bot.


  • DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView):
17:18 Changeset [45511] by pdherbemont@apple.com

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Fix the Gtk build after r45474. The localized strings should
have been added there.

  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText):
17:07 Changeset [45510] by pdherbemont@apple.com

WebCore:

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26939

Media controller is rendered badly at http://www.mozilla.com/en-US/firefox/video/firefox-3.5.html

We fix two things:

  • We use px instead of em, because px is used everywhere else and because 0.09em hit the font size limit.
  • We use -webkit-box instead of inline-block because in strict mode inline-block has a different behavior.

Test: media/controls-strict.html

  • css/mediaControlsQT.css:

LayoutTests:

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26939

Media controller is rendered badly at http://www.mozilla.com/en-US/firefox/video/firefox-3.5.html

Test that the controller renders correctly in strict mode as well.

  • media/controls-strict.html: Added.
  • platform/mac/media/controls-strict-mode-expected.txt: Added.
17:03 Changeset [45509] by bfulgham@webkit.org

2009-07-02 Brent Fulgham <bfulgham@webkit.org>

Build fix, no review.

  • DumpRenderTree/config.h:
16:55 Changeset [45508] by oliver@apple.com

<rdar://problem/6939593> REGRESSION (r37793): Hitting back button on Google often gives non-interactive Google page (26670)
<https://bugs.webkit.org/show_bug.cgi?id=26670>

Reviewed by Anders Carlsson

Make windows loader client match mac behaviour more closely.

16:53 Changeset [45507] by eric@webkit.org

2009-07-02 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

bugzilla-tool needs to handle login failure
https://bugs.webkit.org/show_bug.cgi?id=26913

We now exit(1) on login failure.

  • Scripts/modules/bugzilla.py:
16:53 Changeset [45506] by hyatt@apple.com

2009-07-02 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

TextIterator should use hasOverflowClip when checking for overflow instead of looking at the style.
https://bugs.webkit.org/show_bug.cgi?id=26942

  • editing/TextIterator.cpp: (WebCore::fullyClipsContents):
16:49 Changeset [45505] by bfulgham@webkit.org

WebKit/win:

2009-06-30 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Adam Roben.

Build DumpRenderTree under Cairo.
https://bugs.webkit.org/show_bug.cgi?id=26457

  • WebKit.vcproj/WebKit.sln: Add Cairo targets to the DumpRenderTree build, and use the in the Debug_Cairo and Release_Cairo targets.

WebKitTools:

2009-06-30 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Add build support for a Windows Cairo version of
DumpRenderTree. Share as much logic between the
CG and Cairo builds as possible.
https://bugs.webkit.org/show_bug.cgi?id=26457

  • DumpRenderTree/PixelDumpSupport.cpp: Added. (dumpWebViewAsPixelsAndCompareWithExpected): Moved common logic from CG-specific file. (printPNG): Moved common logic from CG-specific file.
  • DumpRenderTree/PixelDumpSupport.h: Add declaration for new common printPNG function.
  • DumpRenderTree/cairo: Added.
  • DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Added. Implement cairo-specific logic for dealing with Cairo surfaces. (writeFunction): (printPNG): Cairo-specific PNG handling logic. (computeMD5HashStringForBitmapContext): New Cairo routine using the generic BitmapContext signature. (dumpBitmap): New function containing Cairo-specific portions of the dumping routine.
  • DumpRenderTree/cairo/PixelDumpSupportCairo.h: Added. Provide Cairo version of the BitmapContext structure so that dumping routines can work on an abstract type. (BitmapContext::createByAdoptingBitmapAndContext): (BitmapContext::~BitmapContext): (BitmapContext::cairoContext): (BitmapContext::BitmapContext):
  • DumpRenderTree/cg/PixelDumpSupportCG.cpp: (printPNG): CG-specific PNG handling logic. (computeMD5HashStringForBitmapContext): Revised to use generic BitmapContext signature. (dumpBitmap): New function containing CG-specific portions of the dumping routine.
  • DumpRenderTree/cg/PixelDumpSupportCG.h: Add new signatures.
  • DumpRenderTree/win/DumpRenderTree.cpp: Disable CFNetwork logic when building the non-CFNetwork version. (main):
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView): Provide parallel Cairo implementation of CG bitmap/context setup.
16:45 Changeset [45504] by weinig@apple.com

2009-07-02 Sam Weinig <sam@webkit.org>

Reviewed by Dave Hyatt.

Fix for <rdar://problem/5230700>
Remove local .xhtml file workaround

  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): Work around is no longer necessary.
16:36 Changeset [45503] by mrowe@apple.com

Versioning.

16:34 Changeset [45502] by andersca@apple.com

WebCore:

2009-07-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Sort, add functions used by WebKit.


  • WebCore.base.exp:

WebKit/mac:

2009-07-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6978783>
Software-rendered plug-in does not update correctly when inside a hardware layer


Replace calls to setNeedsDisplay: and setNeedsDisplayInRect: with a call to the new method
invalidatePluginContentRect:. This new method will ask WebCore to do the repainting, taking
transforms into account.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invalidateRect):
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginHostDied]):
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView preferencesHaveChanged:]): (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView invalidateRect:]): (-[WebNetscapePluginView invalidateRegion:]): (-[WebNetscapePluginView forceRedraw]):
16:33 Changeset [45501] by mrowe@apple.com

New tag.

16:31 Changeset [45500] by hyatt@apple.com

2009-07-02 David Hyatt <hyatt@apple.com>

Reviewed by Mark Rowe.

Land new results from my change to make replaced elements no longer be overflow:hidden by
default. This affected plaintext dumping, which is clearly a bug in and of itself. For now
I am just updating the results and will file a followup bug about the fact that text dumping actually
does something different with overflow on replaced elements (when it clearly should not).

  • fast/block/float/crash-replaced-display-block-expected.txt:
  • fast/dom/Range/acid3-surround-contents-expected.txt:
  • fast/dom/object-embed-plugin-scripting-expected.txt:
  • fast/parser/badentity-expected.txt:
  • http/tests/security/local-video-poster-from-remote-expected.txt:
16:28 Changeset [45499] by beidson@apple.com

2009-07-02 Brady Eidson <beidson@apple.com>

Rubberstamped by Sam Weinig.

More of <rdar://problem/6969425> Safari 4.0 doesn't recognize text/plain files if their extension is unknown.

  • platform/network/mac/WebCoreURLResponse.mm: (webNSURLResponseMIMEType): Give Tiger a chance to query the UTI machinery.
16:18 Changeset [45498] by beidson@apple.com

2009-07-02 Brady Eidson <beidson@apple.com>

Rubberstamped by John Sullivan.

Add Tiger-specific results for these tests.

  • platform/mac-tiger/Skipped:
  • platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
  • platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
  • platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-expected.txt:
16:01 Changeset [45497] by beidson@apple.com

2009-07-02 Brady Eidson <beidson@apple.com>

Skip the correct test names.

  • platform/mac-tiger/Skipped:
15:40 Changeset [45496] by agl@chromium.org

2009-07-02 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium Linux: fix complex text rendering with line break characters.

https://bugs.webkit.org/show_bug.cgi?id=26935

If the CSS white-space property is inhibiting line breaking, we might
find end-of-line characters rendered via the complex text path. Fonts
don't provide glyphs for these code points so, if we find one, we
simulate the space glyph being interposed in this case. Because the
input is variable-length per code point, we walk the input in step
with the output.

Covered by:

LayoutTests/fast/text/international/bidi-linebreak-002.html
LayoutTests/fast/text/international/bidi-linebreak-003.html
LayoutTests/fast/text/international/hindi-whitespace.html

  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::stringToGlyphs):
15:25 Changeset [45495] by beidson@apple.com

2009-07-02 Brady Eidson <beidson@apple.com>

Rubberstamped by Sam Weinig

Split up file-url-mimetypes.html into 3 tests to avoid any risk of timing out on slower machines.

  • platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
  • platform/mac/fast/loader/file-url-mimetypes-2.html: Copied from platform/mac/fast/loader/file-url-mimetypes.html.
  • platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
  • platform/mac/fast/loader/file-url-mimetypes-3.html: Copied from platform/mac/fast/loader/file-url-mimetypes.html.
  • platform/mac/fast/loader/file-url-mimetypes-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes.html:
  • platform/mac-tiger/Skipped:
15:22 Changeset [45494] by dglazkov@chromium.org

2009-07-02 Victor Wang <victorw@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26521
Expose file size to chromium.

Implement getFileSize() for Chromium.

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/FileSystemChromium.cpp: (WebCore::getFileSize):
15:21 Changeset [45493] by eric@webkit.org

2009-07-02 Eric Seidel <eric@webkit.org>

No review, just adding Antti as a reviewer.

  • Scripts/modules/bugzilla.py:
15:21 Changeset [45492] by japhet@chromium.org

2009-07-02 Nate Chapin <japhet@chromium.org>

Unreviewed, build fix.

  • bindings/v8/V8SVGPODTypeWrapper.h: Lost a space in nested template argument list.
15:19 Changeset [45491] by simon.fraser@apple.com

2009-07-02 Simon Fraser <simon.fraser@apple.com>

Build fix: add missing #include.

  • platform/mac/ThemeMac.mm:
15:17 Changeset [45490] by beidson@apple.com

2009-07-02 Brady Eidson <beidson@apple.com>

Resolve failing Tiger layout test until I can fix it.

  • platform/mac-tiger/Skipped:
14:56 Changeset [45489] by simon.fraser@apple.com

2009-07-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

<rdar://problem/7028682> ThemeMac::paintRadio() throws Obj-C exceptions when zoomed

Add BEGIN_BLOCK_OBJC_EXCEPTIONS/END_BLOCK_OBJC_EXCEPTIONS guards around code
that can possibly throw Objective-C exceptions when drawing Mac form controls.

  • platform/mac/ThemeMac.mm: (WebCore::paintCheckbox): (WebCore::paintRadio): (WebCore::paintButton): (WebCore::ThemeMac::inflateControlPaintRect):
14:47 Changeset [45488] by japhet@chromium.org

2009-07-02 Nate Chapin <japhet@chromium.org>

Reviewed by David Levin.

Upstream V8SVGPODTypeWrapper.

https://bugs.webkit.org/show_bug.cgi?id=26907

14:40 Changeset [45487] by dglazkov@chromium.org

2009-07-02 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adds an abstraction layer between the DB classes and the file
system, which allows us to add our own logic for storing, opening,
deleting, etc. databases.

The patch was tested using the tests in WebCore/storage.

https://bugs.webkit.org/show_bug.cgi?id=26054

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open): Delegating the job of opening DB files to SQLiteFileSystem to allow use of custom VFSs.
  • platform/sql/SQLiteFileSystem.cpp: Added.
  • platform/sql/SQLiteFileSystem.h: Added.
  • platform/win/FileSystemWin.cpp: (WebCore::directoryName): Implemented.
  • storage/Database.cpp: (WebCore::Database::databaseSize): The code that returns the size of a DB file moved to SQLiteFileSystem.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker): Added the ability to register a custom SQLite VFS. (WebCore::DatabaseTracker::trackerDatabasePath): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::openTrackerDatabase): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::originPath): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::fullPathForDatabase): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::usageForDatabase): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::deleteOrigin): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::deleteDatabaseFile): DB file-related operations moved to SQLiteFileSystem.
  • storage/OriginUsageRecord.cpp: (WebCore::OriginUsageRecord::diskUsage): DB file-related operations moved to SQLiteFileSystem.
13:47 Changeset [45486] by hyatt@apple.com

2009-07-02 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

Always clip replaced elements to border radii.
https://bugs.webkit.org/show_bug.cgi?id=26933

Make sure to always clip replaced elements to border radii, even when overflow is visible.
Stop defaulting those elements to overflow:hidden in the UA sheet, since it is now no longer
necessary.

Covered by existing tests (since the UA default changing keeps the behavior exactly the same).

  • css/html.css:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
13:18 Changeset [45485] by hyatt@apple.com

2009-07-02 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Simon Fraser.

convertFromScrollbarToContainingView and friends should be in ScrollView
https://bugs.webkit.org/show_bug.cgi?id=26929

This is breaking Chromium's build because PopupMenuChromium inherits
from ScrollView, but these functions are pure virtual in it. I could
put it directly in PopupMenuChromium, but that seems a bit silly since
the functions are fairly generic.

Passes existing layout tests.

  • page/FrameView.cpp: Remove the 4 functions Hyatt just added (IntRect WebCore::FrameView::convertFromScrollbarToContainingView): (IntRect WebCore::FrameView::convertFromContainingViewToScrollBar): (IntPoint WebCore::FrameView::convertFromScrollbarToContainingView): (IntPoint WebCore::FrameView::convertFromContainingViewToScrollBar):
  • page/FrameView.h: ditto
  • platform/ScrollView.cpp: Move the 4 functions from FrameView here (IntRect WebCore::ScrollView::convertFromScrollbarToContainingView): (IntRect WebCore::ScrollView::convertFromContainingViewToScrollBar): (IntPoint WebCore::ScrollView::convertFromScrollbarToContainingView): (IntPoint WebCore::ScrollView::convertFromContainingViewToScrollBar):
  • platform/ScrollView.h: ditto
11:39 Changeset [45484] by aroben@apple.com

Fix warnings from update-webkit-localizable-strings

WebKit:

Fix warnings from update-webkit-localizable-strings

Rubber-stamped by Eric Carlson.

  • English.lproj/Localizable.strings: Updated.

WebKit/mac:

Fix warnings from update-webkit-localizable-strings

Rubber-stamped by Eric Carlson.

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory mediaElementLoadingStateText]): (-[WebViewFactory mediaElementLiveBroadcastStateText]): Changed the localization comments to match the comments in the Windows version of this file, to avoid warnings about different comments for the same localized string.
11:39 Changeset [45483] by aroben@apple.com

Update StringsNotToBeLocalized.txt for (not so) recent changes

Bug 26926: StringsNotToBeLocalized.txt is out-of-date
<https://bugs.webkit.org/show_bug.cgi?id=26926>

Reviewed by John Sullivan.

  • StringsNotToBeLocalized.txt:
11:06 Changeset [45482] by darin@chromium.org

2009-07-02 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Fisher.

Fix https://bugs.webkit.org/show_bug.cgi?id=26088 - TransparencyWin
doesn't handle errors well at all; revise it to fail silently
(drawing nothing), and bulletproof FontChromiumWin to handle the
failure accordingly.

Tests: fast/text/text-large-negative-letter-spacing-with-opacity.html

fast/text/text-letter-spacing.html

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::TransparencyWin): (WebCore::TransparencyWin::setupLayerForNoLayer): (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer): (WebCore::TransparencyWin::setupLayerForWhiteLayer): (WebCore::TransparencyWin::setupTransformForKeepTransform): (WebCore::TransparencyWin::setupTransformForScaleTransform): (WebCore::TransparencyWin::initializeNewContext): (WebCore::TransparencyWin::compositeOpaqueComposite): (WebCore::TransparencyWin::compositeTextComposite): (WebCore::TransparencyWin::makeLayerOpaque):
  • platform/graphics/chromium/TransparencyWin.h: (WebCore::TransparencyWin::platformContext):
10:51 Changeset [45481] by hyatt@apple.com

Fix build bustage caused by wrong include case.

10:41 Changeset [45480] by eric.carlson@apple.com

2009-07-02 Eric Carlson <eric.carlson@apple.com>

Change #import to #include to fix non-ObjC builds.

  • rendering/MediaControlElements.cpp:

2009-07-02 Eric Carlson <eric.carlson@apple.com>

Fix Windows build by including missing localized string methods.

  • WebCoreLocalizedStrings.cpp: (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText):
10:32 Changeset [45479] by andersca@apple.com

2009-07-02 Anders Carlsson <andersca@apple.com>

Build fix.


  • platform/network/mac/WebCoreURLResponse.mm: (mimeTypeFromUTITree):
10:31 Changeset [45478] by hyatt@apple.com

WebCore:

2009-07-02 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

Fix for bug 22119, clicks in the scrollbars of transformed content don't work. Add new
conversion methods for going across parent/child widget boundaries that can be implemented
by the FrameView and ScrollbarClient to be transform-aware.

Test cases added in platform/mac/fast/forms and platform/mac/fast/overflow.

  • WebCore.base.exp:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):
  • page/FrameView.cpp: (WebCore::FrameView::convertFromScrollbarToContainingView): (WebCore::FrameView::convertFromContainingViewToScrollbar): (WebCore::FrameView::convertFromRenderer): (WebCore::FrameView::convertToRenderer): (WebCore::FrameView::convertToContainingView): (WebCore::FrameView::convertFromContainingView):
  • page/FrameView.h:
  • platform/ScrollView.h:
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::convertToContainingView): (WebCore::Scrollbar::convertFromContainingView):
  • platform/Scrollbar.h:
  • platform/ScrollbarClient.h: (WebCore::ScrollbarClient::convertFromScrollbarToContainingView): (WebCore::ScrollbarClient::convertFromContainingViewToScrollbar):
  • platform/Widget.cpp: (WebCore::Widget::convertFromContainingWindow): (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromRootToContainingWindow): (WebCore::Widget::convertFromContainingWindowToRoot): (WebCore::Widget::convertToContainingView): (WebCore::Widget::convertFromContainingView):
  • platform/Widget.h:
  • platform/graphics/IntPoint.h: (WebCore::IntPoint::move):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::convertFromRootToContainingWindow): (WebCore::Widget::convertFromContainingWindowToRoot):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInOverflowControl):
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::convertFromScrollbarToContainingView): (WebCore::RenderDataGrid::convertFromContainingViewToScrollbar):
  • rendering/RenderDataGrid.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::convertFromScrollbarToContainingView): (WebCore::RenderLayer::convertFromContainingViewToScrollbar): (WebCore::RenderLayer::scrollbarOffset): (WebCore::RenderLayer::hitTestOverflowControls):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInOverflowControl): (WebCore::RenderListBox::convertFromScrollbarToContainingView): (WebCore::RenderListBox::convertFromContainingViewToScrollbar):
  • rendering/RenderListBox.h:

LayoutTests:

2009-07-02 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

Test cases for bug 22119, clicks in scrollbar of transformed element don't work.

  • platform/mac/fast/forms/listbox-scrollbar-hit-test-expected.txt: Added.
  • platform/mac/fast/forms/listbox-scrollbar-hit-test.html: Added.
  • platform/mac/fast/overflow/overflow-scrollbar-hit-test-expected.txt: Added.
  • platform/mac/fast/overflow/overflow-scrollbar-hit-test.html: Added.
10:19 Changeset [45477] by mitz@apple.com

WebCore:

Reviewed by Dave Hyatt and Simon Fraser.

  • fix <rdar://problem/6933052> SPOD playing video in a div with a box shadow

Test: fast/box-shadow/transform-fringing.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Clip out the box even if it has an opaque background, but in that case, inset the clip path by 1 pixel, to avoid antialiasing artifacts. Do not inset the clip rect by 1 pixel if the CTM is purely a translation. Move the shadow-casting path away in the non-rounded-rect case (it was already being done in the rounded-rect case), to avoid a black fringe when the CTM is not purely a translation.

LayoutTests:

Reviewed by Dave Hyatt and Simon Fraser.

  • test for part of <rdar://problem/6933052> SPOD playing video in a div with a box shadow
  • fast/box-shadow/transform-fringing.html: Added.
  • platform/mac/fast/box-shadow/transform-fringing-expected.checksum: Added.
  • platform/mac/fast/box-shadow/transform-fringing-expected.png: Added.
  • platform/mac/fast/box-shadow/transform-fringing-expected.txt: Added.
10:00 Changeset [45476] by beidson@apple.com

WebCore:

2009-07-02 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6969425> Safari 4.0 doesn't recognize text/plain files if their extension is unknown.

Walk the CoreTypes UTI tree for extensions with unknown MIME types, using the first MIME type found.

For many types of text files (such as source code files) this ends up being text/plain.

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Tweak the logging output.
  • platform/network/mac/WebCoreURLResponse.h:
  • platform/network/mac/WebCoreURLResponse.mm: (mimeTypeFromUTITree): (webNSURLResponseMIMEType): Use mimeTypeFromUTITree() to find a UTI-based MIME type for this file's extension. (-[NSURLResponse _webcore_reportedMIMEType]): Return the actual MIME type that CFNetwork gave us.

LayoutTests:

2009-07-02 Brady Eidson <beidson@apple.com>

Rubberstamped by Sam Weinig.

Add more sample files for extensions we should know the MIME types for.

  • platform/mac/fast/loader/file-url-mimetypes.html:
  • platform/mac/fast/loader/file-url-mimetypes-expected.txt:
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-3fr.3fr: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-aaf.aaf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ada.ada: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-adb.adb: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ads.ads: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-app.app: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-applescript.applescript: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-arw.arw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-as.as: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-aupreset.aupreset: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-c++.c++: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-c.c: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-caf.caf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cc.cc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cp.cp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cpp.cpp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cr2.cr2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cxx.cxx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-defs.defs: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dfont.dfont: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dlyan.dlyan: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dng.dng: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dylib.dylib: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-exp.exp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-exr.exr: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-f.f: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-f77.f77: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-f90.f90: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-f95.f95: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fff.fff: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-for.for: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-h++.h++: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-h.h: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hh.hh: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hp.hp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hpp.hpp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hxx.hxx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-icc.icc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-icm.icm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-icns.icns: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jav.jav: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-java.java: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jfx.jfx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-l.l: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lid.lid: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lm.lm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lmm.lmm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lpp.lpp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lxx.lxx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m.m: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m4a.m4a: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m4b.m4b: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m4v.m4v: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mig.mig: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mm.mm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mos.mos: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mrw.mrw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-nef.nef: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-o.o: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-omf.omf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-orf.orf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pas.pas: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pch++.pch++: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pch.pch: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pef.pef: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pf.pf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pfa.pfa: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pfb.pfb: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-plist.plist: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-r.r: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-raf.raf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-raw.raw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-s.s: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-scpt.scpt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sd2.sd2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sf2.sf2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-srf.srf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-suit.suit: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tbz.tbz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tbz2.tbz2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ttc.ttc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ttf.ttf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ul.ul: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ulaw.ulaw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ulw.ulw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-war.war: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-y.y: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ym.ym: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ymm.ymm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ypp.ypp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-yxx.yxx: Added.
09:33 Changeset [45475] by simon.fraser@apple.com

2009-07-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Compositing-related preference methods are not public API; should move to WebPreferencesPrivate.h
<rdar://problem/7027363>

Move accelerated-compositing pref to WebPreferencesPrivate.h

  • WebView/WebPreferences.h:
  • WebView/WebPreferences.mm: (-[WebPreferences acceleratedCompositingEnabled]): (-[WebPreferences setAcceleratedCompositingEnabled:]):
  • WebView/WebPreferencesPrivate.h:
08:47 Changeset [45474] by eric.carlson@apple.com

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6518119>

Add a rewind button and hide the timeline for live broadcasts when
in MediaUI mode.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Add the new pseudo element.
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
  • css/CSSValueKeywords.in: Ditto.
  • css/mediaControls.css: Ditto.
  • css/mediaControlsQT.css: Ditto.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::rewind): New. (WebCore::HTMLMediaElement::returnToRealTime): New. (WebCore::HTMLMediaElement::isStreaming): New.
  • html/HTMLMediaElement.h:
  • page/mac/WebCoreViewFactory.h: Declare mediaElementLoadingStateText and mediaElementLiveBroadcastStateText.
  • platform/LocalizedStrings.h: Add localized media state messages.
  • platform/ThemeTypes.h: Add the new pseudo element.
  • platform/mac/LocalizedStringsMac.mm: (WebCore::mediaElementLoadingStateText): Add localized media state. (WebCore::mediaElementLiveBroadcastStateText): Ditto.
  • platform/mac/WebCoreSystemInterface.h: Change BOOL param wkDrawMediaUIPart to an int to support

multiple states.

  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::MediaControlElement): Deal with new elements. (WebCore::MediaControlElement::attachToParent): Ditto. (WebCore::MediaControlElement::update): Ditto. (WebCore::MediaControlElement::updateStyle): Ditto. (WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement): Ditto. (WebCore::MediaControlTimelineContainerElement::rendererIsNeeded): Ditto. (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement): Ditto. (WebCore::MediaControlStatusDisplayElement::update): Ditto. (WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): Ditto. (WebCore::MediaControlInputElement::MediaControlInputElement): Ditto. (WebCore::MediaControlInputElement::attachToParent): Ditto. (WebCore::MediaControlInputElement::updateStyle): Ditto. (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Ditto. (WebCore::MediaControlRewindButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::rendererIsNeeded): Ditto. (WebCore::MediaControlTimelineElement::defaultEventHandler): Ditto. (WebCore::MediaControlTimelineElement::update): Ditto. (WebCore::MediaControlFullscreenButtonElement::rendererIsNeeded): Ditto.
  • rendering/MediaControlElements.h: Ditto.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange): Deal with the new elements. (WebCore::RenderMedia::createPanel): Ditto. (WebCore::RenderMedia::createRewindButton): Ditto. (WebCore::RenderMedia::createReturnToRealtimeButton): Ditto. (WebCore::RenderMedia::createStatusDisplay): Ditto. (WebCore::RenderMedia::createTimelineContainer): Ditto. (WebCore::RenderMedia::createCurrentTimeDisplay): Ditto. (WebCore::RenderMedia::createTimeRemainingDisplay): Ditto. (WebCore::RenderMedia::updateControls): Ditto. (WebCore::RenderMedia::forwardEvent): Ditto.
  • rendering/RenderMedia.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Deal with the new elements.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::paintMediaRewindButton): Deal with the new elements. (WebCore::RenderTheme::paintMediaReturnToRealtimeButton): Ditto. (WebCore::RenderTheme::paintMediaControlsBackground): Ditto.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaRewindButton): Deal with the new elements. (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton): Ditto. (WebCore::RenderThemeMac::paintMediaControlsBackground): Ditto.
  • rendering/style/RenderStyleConstants.h: Add constants for the new elements.

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6518119>

Add localized strings for media controller status messages.

  • English.lproj/Localizable.strings: Localized text.

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6518119>

Add localized strings for media controller status.

  • WebCoreSupport/WebViewFactory.mm: Add new localized text. (-[WebViewFactory mediaElementLoadingStateText]): (-[WebViewFactory mediaElementLiveBroadcastStateText]):

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Update WebKitSystemInterface for <rdar://problem/6518119>

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
07:15 Changeset [45473] by hausmann@webkit.org

WebKitTools:

2009-07-02 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=26896

[Qt] Set DRT's default fontsize to 13.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage):

LayoutTests:

2009-07-02 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=26896

Updated computed-style-expected.txt and computed-style-without-renderer-expected.txt
files according to the default font size value (13) set in DumpRenderTree/qt/DumpRenderTree.cpp .

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
07:00 Changeset [45472] by hausmann@webkit.org

2009-07-02 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Improve documentation of QWebFrame::setFocus and hasFocus()
Added missing Q_PROPERTY for QWebFrame::hasFocus.

  • Api/qwebframe.cpp: Clarify the docs.
  • Api/qwebframe.h: add Q_PROPERTY(focus).
06:47 Changeset [45471] by hausmann@webkit.org

2009-07-02 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

Bug 26855: [Qt] New methods for QWebFrame to check and set focus.

Added new public methods QWebFrame::hasFocus() and QWebFrame::setFocus()
Added auto test.

  • Api/qwebframe.cpp: (QWebFrame::hasFocus): (QWebFrame::setFocus):
  • Api/qwebframe.h:
  • tests/qwebframe/tst_qwebframe.cpp:
04:50 Changeset [45470] by xan@webkit.org

2009-07-02 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

Update the new boolean property in FocusController that keeps
track of whether or not the Page is focused.

  • webkit/webkitwebview.cpp: (webkit_web_view_focus_in_event): (webkit_web_view_focus_out_event):

07/01/09:

23:54 Changeset [45469] by eric@webkit.org

2009-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool fails for SVN users
https://bugs.webkit.org/show_bug.cgi?id=26914

To fix this I moved svn from -F - to using -m
In order for -m to work I had to move us off of shell=True
To move off of shell=True all call sites for run_command
which take args, need to pass their args as an list instead of a string.

In order for the final bug update to work correctly, I had to
abstract the way that we parse out revision numbers from the commit text.

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
23:30 Changeset [45468] by simon.fraser@apple.com

2009-07-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

<video> fails to show on http://camendesign.com/code/video_for_everybody
<rdar://problem/7026010>
https://bugs.webkit.org/show_bug.cgi?id=26919

Fix an issue introduced in r44961. In that revision we changed to only update
compositing layer geometry when all siblings had been laid out (i.e. we pushed
the updates one level down). However, that left out the root layer, so this
fix ensures that the root layer geometry gets updated at the end.

Test: compositing/geometry/root-layer-update.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout):
23:26 Changeset [45467] by darin@chromium.org

2009-07-01 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

Small refactoring of MessagePortChannel so that PlatformMessagePortChannel
may be defined at the WebKit layer.

https://bugs.webkit.org/show_bug.cgi?id=26905

  • dom/MessageChannel.cpp: (WebCore::MessageChannel::MessageChannel):
  • dom/MessagePortChannel.cpp:
  • dom/MessagePortChannel.h:
  • dom/default/PlatformMessagePortChannel.cpp: (WebCore::MessagePortChannel::createChannel): (WebCore::MessagePortChannel::create): (WebCore::MessagePortChannel::MessagePortChannel): (WebCore::MessagePortChannel::~MessagePortChannel):
23:04 Changeset [45466] by xan@webkit.org

2009-07-01 Xan Lopez <xlopez@igalia.com>

Disable accessibility tests until we have the accessibility
controller.

  • platform/gtk/Skipped:
22:13 Changeset [45465] by simon.fraser@apple.com

2009-07-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

<rdar://problem/7026010> <video> fails to show on http://camendesign.com/code/video_for_everybody

First part of fix: when outline width changes, don't to a synchronous
layer update right away, but just set the flag to say that compositing
layers need updating. The synchronous layer update left the layer geometries
out of whack when it happened in the middle of layout (e.g. when inside ::first-letter).

Test: compositing/geometry/outline-change.html

  • rendering/RenderView.cpp: (WebCore::RenderView::setMaximalOutlineSize):
22:13 Changeset [45464] by eric@webkit.org

2009-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

prepare-ChangeLog should have a --bug= argument and use it for url autofill
https://bugs.webkit.org/show_bug.cgi?id=26383

prepare-ChangeLog now knows how to grab the bug title from bugs.webkit.org
I also added a bit more template text in an effort to get better ChangeLogs
from casual contributers.

  • Scripts/prepare-ChangeLog:
19:08 Changeset [45463] by eric@webkit.org

2009-07-01 Robert Hogan <robert@roberthogan.net>

Reviewed by NOBODY.


Fix Qt segfault when javascript disabled.
If clients call addToJavaScriptWindowObject even though JavascriptEnabled is false
webkit will segfault on the assert:

ASSERTION FAILED: _rootObject
(../../../WebCore/bridge/runtime.cpp:52
JSC::Bindings::Instance::Instance(WTF::PassRefPtr<JSC::Bindings::RootObject>))

Fix is to ensure JavaScript is enabled when client calls addToJavaScriptWindowObject.

https://bugs.webkit.org/show_bug.cgi?id=26906

  • Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject):
19:01 Changeset [45462] by eric@webkit.org

2009-07-01 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26842
Build fix when ENABLE_DATABASE is off

Move Database.h into ENABLE(DATABASE) guard so toggling ENABLE_DATABASE
off does not break builds.

  • bindings/js/ScriptObjectQuarantine.cpp:
18:35 Changeset [45461] by abarth@webkit.org

WebCore:

2009-07-01 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.


https://bugs.webkit.org/show_bug.cgi?id=26899


Modified XSSAuditor::decodeURL to only remove null characters so that
it is consistent with the behavior of HTMLTokenizer and prevents
injected scripts that contain control characters.

Tests: http/tests/security/xssAuditor/script-tag-control-char.html

http/tests/security/xssAuditor/script-tag-null-char.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeURL): Modified to only remove null characters.
  • page/XSSAuditor.h: Reverted naming of third argument of method XSSAuditor::decodeURL from allowControlCharacters back to allowNullCharacters.
  • platform/network/ResourceResponseBase.cpp: Reverted back to rev #45003. (WebCore::isControlCharacter):
  • platform/network/ResourceResponseBase.h: Reverted back to rev #45003.

LayoutTests:

2009-07-01 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.


https://bugs.webkit.org/show_bug.cgi?id=26899


Tests that XSSAuditor prevents injected scripts that contain control characters.

  • http/tests/security/xssAuditor/script-tag-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-control-char.html: Added.
  • http/tests/security/xssAuditor/script-tag-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-null-char.html: Added.
18:03 Changeset [45460] by eric@webkit.org

2009-07-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

  • supported keyboard shortcuts compatible with Firebug in Scripts Debugger: F5, Ctrl+/ (win,lin), Command+/ (mac) - continue F10, Ctrl+' (win, lin), Command+' (mac) - step over F11, Ctrl+; (win, lin), Command+; (mac) - step into Shift+F11, Ctrl+Shift+; (win, lin), Command+Shift+; (mac) - step out
  • added call stack navigation shortcuts: Ctrl+. - next call frame Ctrl+, - previouse call frame

https://bugs.webkit.org/show_bug.cgi?id=23849

  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.handleKeyEvent): (WebInspector.CallStackSidebarPane.prototype._selectNextCallFrameOnStack): (WebInspector.CallStackSidebarPane.prototype._selectPreviousCallFrameOnStack): (WebInspector.CallStackSidebarPane.prototype._selectedPlacardByIndex): (WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
  • inspector/front-end/KeyboardShortcut.js: Added. (WebInspector.KeyboardShortcut): (WebInspector.KeyboardShortcut.makeKey): (WebInspector.KeyboardShortcut.makeKeyFromEvent): (WebInspector.KeyboardShortcut.makeKeyFromCodeAndModifiers_):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.handleKeyEvent):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
17:54 Changeset [45459] by agl@chromium.org

2009-07-01 Daniel Erat <derat@google.com>

Reviewed by David Levin.

Chromium Linux: Move the scrollbar thumb on middle-click.

https://bugs.webkit.org/show_bug.cgi?id=26910
http://code.google.com/p/chromium/issues/detail?id=11976

Tested by building Chrome and checking that the scrollbar moves as expected.

  • platform/chromium/ScrollbarThemeChromium.cpp:
  • platform/chromium/ScrollbarThemeChromium.h:
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp:
  • platform/chromium/ScrollbarThemeChromiumLinux.h:
  • platform/chromium/ScrollbarThemeChromiumWin.cpp:
  • platform/chromium/ScrollbarThemeChromiumWin.h:
17:38 Changeset [45458] by beidson@apple.com

WebCore:

2009-07-01 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Add a preference/setting to toggle whether content sniffing is enabled for file URLs.

  • WebCore.base.exp:
  • page/Settings.cpp: (WebCore::Settings::setLocalFileContentSniffingEnabled):
  • page/Settings.h: (WebCore::Settings::localFileContentSniffingEnabled):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

WebKit/mac:

2009-07-01 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Add a preference/setting to toggle whether content sniffing is enabled for file URLs.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences localFileContentSniffingEnabled]): (-[WebPreferences setLocalFileContentSniffingEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
17:13 Changeset [45457] by weinig@apple.com

2009-07-01 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Don't reload values in emitBinaryDoubleOp.

SunSpider reports a 0.6% progression.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitBinaryDoubleOp):
16:34 Changeset [45456] by cfleizach@apple.com

Bug 26909: aria-label needs to be supported
https://bugs.webkit.org/show_bug.cgi?id=26909

16:31 Changeset [45455] by eric@webkit.org

2009-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

prepare-ChangeLog should fail when EMAIL_ADDRESS or REAL_NAME are missing:
https://bugs.webkit.org/show_bug.cgi?id=26692

I also made prepare-ChangeLog sanity-check names and email addresses a little.
Names must contain a space, and email addresses must contain '@'

Also "fixed" $email_address to $emailAddress. This script uses mixed variable name styles.

  • Scripts/prepare-ChangeLog:
16:15 Changeset [45454] by hyatt@apple.com

2009-07-01 David Hyatt <hyatt@apple.com>

Reviewed by Oliver Hunt.

More datagrid columns work. Make sure columns cache both a style for the column header as well
as a style for the column background (behind the cells).

Hook up to CSSStyleSelector methods for obtaining the pseudo styles for columns (stubbed out and
unimplemented).

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::pseudoStyleForDataGridColumn): (WebCore::CSSStyleSelector::pseudoStyleForDataGridColumnHeader):
  • css/CSSStyleSelector.h:
  • html/DataGridColumn.h: (WebCore::DataGridColumn::setColumnList): (WebCore::DataGridColumn::columnStyle): (WebCore::DataGridColumn::setColumnStyle): (WebCore::DataGridColumn::headerStyle): (WebCore::DataGridColumn::setHeaderStyle):
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::recalcStyleForColumn): (WebCore::RenderDataGrid::columnStyle): (WebCore::RenderDataGrid::headerStyle): (WebCore::RenderDataGrid::paintColumnHeaders):
  • rendering/RenderDataGrid.h:
16:12 JSC edited by bfulgham@webkit.org
(diff)
16:06 JSC edited by bfulgham@webkit.org
Add information about built-in functions. (diff)
15:33 Changeset [45453] by eric.carlson@apple.com

2009-07-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.


<rdar://problem/7009870> After <audio> movie finishes playing, Pause button fails to change
back to Play button

Grab onto the current time when QTKit "ended" notification fires and use it as
duration from that point on as QuickTime sometimes refuses to play all the way to
the time it reports for duration and buffered. HTMLMediaElement assumes that there
more to play in this situation and tries to restart playback, endlessly.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:

Rename m_duration to m_reportedDuration. Declare m_cachedDuration.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):

Rename m_duration to m_reportedDuration. Initialize m_cachedDuration.

(WebCore::MediaPlayerPrivate::duration):

Return m_cachedDuration once it has been set.

(WebCore::MediaPlayerPrivate::updateStates):

Rename m_duration to m_reportedDuration.

(WebCore::MediaPlayerPrivate::didEnd):

Set m_cachedDuration to currentTime().

15:29 JSC edited by bfulgham@webkit.org
(diff)
15:01 Changeset [45452] by cfleizach@apple.com

Bug 26900: AX: Manual spell check with Command-; does not bring up suggestions
https://bugs.webkit.org/show_bug.cgi?id=26900

14:41 Changeset [45451] by mrowe@apple.com

Change how WebKitNightlyEnabler.dylib lies about Safari's identity to LaunchServices.

This makes WebKit.app behave as expected when set as the default web browser on a wider
range of OS versions.

Reviewed by Simon Fraser.

  • WebKitLauncher/WebKitNightlyEnabler.m:

(poseAsWebKitApp):
(enableWebKitNightlyBehaviour):

14:41 Changeset [45450] by mrowe@apple.com

Shuffle some code around in preparation for a change to how poseAsWebKitApp works.

Reviewed by Simon Fraser.

  • WebKitLauncher/WebKitNightlyEnabler.m:

(systemVersion):
(webKitLauncherBundle):
(insideSafari4OnTigerTrampoline):

14:19 Changeset [45449] by weinig@apple.com

2009-07-01 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Convert op_div to load op1 and op2 up front.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_div):
14:06 Changeset [45448] by levin@chromium.org

2009-07-01 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

Remove unused code in SVGTransformList and SVGTransformDistance
<https://bugs.webkit.org/show_bug.cgi?id=26891>

  • svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance):
  • svg/SVGTransformList.cpp:
  • svg/SVGTransformList.h:
14:02 Changeset [45447] by weinig@apple.com

2009-07-01 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Don't emit code in emitBinaryDoubleOp if code is unreachable, observable
via an empty (unlinked) jumplist passed in. This only effects op_jnless
and op_jnlesseq at present.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emitBinaryDoubleOp):
13:59 Changeset [45446] by hyatt@apple.com

2009-07-01 David Hyatt <hyatt@apple.com>

Reviewed by Anders Carlsson.

Begin stubbing out functions for layout, painting and style/geometry caching on columns. Not enough
is implemented for this to do much of anything yet, but it should help keep patch sizes down. :)

  • html/DataGridColumn.cpp: (WebCore::DataGridColumn::columnChanged):
  • html/DataGridColumn.h: (WebCore::DataGridColumn::setId): (WebCore::DataGridColumn::setLabel): (WebCore::DataGridColumn::setType): (WebCore::DataGridColumn::setSortable): (WebCore::DataGridColumn::setSortDirection): (WebCore::DataGridColumn::setColumnList): (WebCore::DataGridColumn::style): (WebCore::DataGridColumn::setStyle): (WebCore::DataGridColumn::rect): (WebCore::DataGridColumn::setRect):
  • html/DataGridColumnList.cpp: (WebCore::DataGridColumnList::DataGridColumnList): (WebCore::DataGridColumnList::setDataGridNeedsLayout): (WebCore::DataGridColumnList::add): (WebCore::DataGridColumnList::remove): (WebCore::DataGridColumnList::move): (WebCore::DataGridColumnList::clear): (WebCore::DataGridColumnList::primaryColumnChanged):
  • html/DataGridColumnList.h: (WebCore::DataGridColumnList::create): (WebCore::DataGridColumnList::dataGrid): (WebCore::DataGridColumnList::clearDataGrid):
  • html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::HTMLDataGridColElement): (WebCore::HTMLDataGridColElement::findDataGridAncestor): (WebCore::HTMLDataGridColElement::insertedIntoTree): (WebCore::HTMLDataGridColElement::removedFromTree):
  • html/HTMLDataGridColElement.h: (WebCore::HTMLDataGridColElement::dataGrid):
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::HTMLDataGridElement): (WebCore::HTMLDataGridElement::~HTMLDataGridElement):
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::styleDidChange): (WebCore::RenderDataGrid::recalcStyleForColumns): (WebCore::RenderDataGrid::recalcStyleForColumn): (WebCore::RenderDataGrid::styleForColumn): (WebCore::RenderDataGrid::layout): (WebCore::RenderDataGrid::layoutColumns): (WebCore::RenderDataGrid::paintColumnHeaders): (WebCore::RenderDataGrid::paintColumnHeader):
  • rendering/RenderDataGrid.h: (WebCore::RenderDataGrid::renderName): (WebCore::RenderDataGrid::canHaveChildren):
13:41 JSC created by bfulgham@webkit.org
Initial entry to document the utility.
13:38 Changeset [45445] by abarth@webkit.org

2009-07-01 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26807


Fixes this address by checking whether frame->document()->decoder() is null.

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest):
12:01 Changeset [45444] by zimmermann@webkit.org

2009-07-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26885

Correctly reset history length to '0', not '1'. Old relict from early WML days.
Add some new WML testcases covering the use of history length (by onenterforward event handling)

Tests: wml/onenterforward-event.html

wml/onenterforward-inline-event.html
wml/ontimer-event.html


  • wml/WMLPageState.cpp: (WebCore::WMLPageState::reset):

2009-07-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26885

Add new WML testcases covering onenterforward/ontimer support.

  • wml/onenterforward-event-expected.txt: Added.
  • wml/onenterforward-event.html: Added.
  • wml/onenterforward-inline-event-expected.txt: Added.
  • wml/onenterforward-inline-event.html: Added.
  • wml/ontimer-event-expected.txt: Added.
  • wml/ontimer-event.html: Added.
  • wml/resources/onenterforward-event.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/onenterforward-event.wml: Added.
  • wml/resources/onenterforward-inline-event.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/onenterforward-inline-event.wml: Added.
  • wml/resources/ontimer-event.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/ontimer-event.wml: Added.
  • wml/resources/ontimer-inline-event.js:
11:41 Changeset [45443] by hyatt@apple.com

WebCore:

2009-07-01 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

Make sure setting attributes on dcol elements properly updates the corresponding DataGridColumn object.

Added new test in fast/dom/HTMLDataGridElement.

  • html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::parseMappedAttribute):
  • html/HTMLDataGridColElement.h:

LayoutTests:

2009-07-01 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

Add layout test for being able to set attributes on dcol elements.


  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes-expected.txt: Added.
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html: Added.
11:19 Changeset [45442] by simon.fraser@apple.com

2009-07-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dimitri Glazkov.

Add some missing pixel results for compositing tests.

  • platform/mac/compositing/layers-inside-overflow-scroll-expected.checksum: Added.
  • platform/mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/mac/compositing/overflow/overflow-scroll-expected.checksum: Added.
  • platform/mac/compositing/overflow/overflow-scroll-expected.png: Added.
11:12 Changeset [45441] by ggaren@apple.com

2009-07-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Converted op_mod to put { tag, payload } in { regT1, regT0 }, and
tidied up its constant case.


SunSpider reports a 0.2% regression, but a micro-benchmark of op_mod
shows a 12% speedup, and the SunSpider test that uses op_mod most should
benefit a lot from result caching in the end, since it almost always
performs (expression) % constant.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):
11:11 Drosera edited by bfulgham@webkit.org
Add link to Web Inspector page. (diff)
09:53 Changeset [45440] by hyatt@apple.com

WebCore:

2009-07-01 David Hyatt <hyatt@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
even though the field is not actually focused for keyboard input


Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the
focused frame and focused node to both be cached and changed programmatically even when the Page itself doesn't
actually happen to have focus at that time.

  • WebCore.base.exp:
  • page/FocusController.cpp: (WebCore::FocusController::FocusController): (WebCore::FocusController::setFocusedFrame): (WebCore::FocusController::setFocused): (WebCore::FocusController::setActive):
  • page/FocusController.h: (WebCore::FocusController::isFocused):

WebKit/mac:

2009-07-01 David Hyatt <hyatt@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
even though the field is not actually focused for keyboard input


Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the
focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't
have focus.

  • WebView/WebHTMLView.mm: (-[WebHTMLView becomeFirstResponder]): (-[WebHTMLView resignFirstResponder]):

WebKit/win:

2009-07-01 David Hyatt <hyatt@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
even though the field is not actually focused for keyboard input


Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the
focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't
have focus.

  • WebView.cpp: (WebViewWndProc):
09:47 Changeset [45439] by zimmermann@webkit.org

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26884

WMLTestCase.js relies on timing-dependant hacks, making it difficult to predict results on slower machines.
Fix by rewriting and simplifying the testing procedure, which contained unnecessary quirks working around older WML bugs.

09:06 Changeset [45438] by eric.carlson@apple.com

2009-07-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Update WebKitSystemInterface for <rdar://problem/7014990>

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
08:44 Changeset [45437] by zimmermann@webkit.org

Not reviewed. Ignore *.pyc files to not clutter up 'svn st'.

08:10 Changeset [45436] by zimmermann@webkit.org

Reviewed by Holger Freyther.
Apply same cleanup to WML testcases living in http/tests/wml/. Forgot about them in my last commit.

08:03 Changeset [45435] by zimmermann@webkit.org

Reviewed by Holger Freyther.

Slightly cleanup some WML testcases:
Use "anchorElement.textContent = '...'" instead of "anchorElement.appendChild(document.createTextNode('...'))"

05:55 Changeset [45434] by hausmann@webkit.org

WebCore:

2009-07-01 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Move some API headers from WebCore.pro to headers.pri so that they
get installed when running make install from the build directory.

  • WebCore.pro:

WebKit/qt:

2009-07-01 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Move some API headers from WebCore.pro to headers.pri so that they
get installed when running make install from the build directory.

  • Api/headers.pri:
04:36 Changeset [45433] by hausmann@webkit.org

2009-07-01 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Fixed robotized QtLauncher to work when there is no index.html in the user's home.

  • QtLauncher/main.cpp: (main):
02:40 Changeset [45432] by hausmann@webkit.org

2009-07-01 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Ariya Hidayat.

Ran WebKitTools/Scripts/generate-qt-inspector-resource to update the
qrc file with new png files from the web inspector.

  • inspector/front-end/WebKit.qrc:

06/30/09:

23:51 Changeset [45431] by xan@webkit.org

2009-06-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=26877
[GTK] DRT fixes to pass new plugin test

Silence compiler warnings.

Newer GCC don't like using or returning a static string where a
'char*' is expected. Ideally we'd change the function signatures
to return or take 'const char*' I suppose, but since we can't do
that just cast the strings to 'char*'.

  • DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_get_value):
23:42 Changeset [45430] by xan@webkit.org

2009-06-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=26877
[GTK] DRT fixes to pass new plugin test

Use the common pluginLog function instead of a local copy.

  • DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_destroy_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
23:41 Changeset [45429] by xan@webkit.org

2009-06-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=26877
[GTK] DRT fixes to pass new plugin test

Modify our DRT as done in bug #15457 to log logSrc as src in order
to pass test plugins/netscape-plugin-map-data-to-src.html.

  • DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance):
23:10 Changeset [45428] by weinig@apple.com

2009-06-30 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Converted some more arithmetic ops to put { tag, payload } in
{ regT1, regT0 }.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul):
23:07 Changeset [45427] by adele@apple.com

2009-06-30 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/7014389> REGRESSION(4-TOT): Hyperlinks have no tooltips in Mail unless you first click in the message body

Updated these new methods (added as part of the viewless WebKit effort) that call through to WebHTMLView to use _selectedOrMainFrame,
instead of just selectedFrame. When the selection changes, I don't think there is a situation where there's no selected frame, but
it seems better to keep these two uses the same, since if there is a case, this will be more like the old behavior, before there was
a version of _selectionChanged in WebView.

  • WebView/WebView.mm: (-[WebView _setToolTip:]): (-[WebView _selectionChanged]):
22:58 Changeset [45426] by xan@webkit.org

2009-06-30 Xan Lopez <xlopez@igalia.com>

Disable test using eventSender.

  • platform/gtk/Skipped:
22:44 Changeset [45425] by xan@webkit.org

2009-06-30 Xan Lopez <xlopez@igalia.com>

Disable new tests until we enable the accessibility controller.

  • platform/gtk/Skipped:
22:28 Changeset [45424] by ggaren@apple.com

2009-06-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Converted some more arithmetic ops to put { tag, payload } in
{ regT1, regT0 }, and added a case for subtract constant.


SunSpider says no change. v8 says 0.3% slower.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emit_op_sub): (JSC::JIT::emitSub32Constant): (JSC::JIT::emitSlow_op_sub):
22:19 Changeset [45423] by mrowe@apple.com

Land some code that has a hope of compiling.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::imageSourceOptions):

21:55 Changeset [45422] by barraclough@apple.com

2009-06-30 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Remove more uses of addressFor(), load double constants directly from
the constantpool in the CodeBlock, rather than from the register file.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitBinaryDoubleOp):
21:37 Changeset [45421] by slewis@apple.com

2009-06-30 Stephanie Lewis <slewis@apple.com>

Reviewed by Simon Fraser.

Flip back on block caching. Throwing away block data, while
a perceived memory win, is a performance hit in cases where we
are repainting large images (i.e. backgrounds) frequently
(i.e. a flash video playing on top).
<rdar://problem/6933515> REGRESSION(L-SL): Large JPEG images are
decoded on drawing, slowing down painting of sites that frequently
repaint e.g. because of Flash (pandora.com, Starcraft 2)

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::imageSourceOptions):
20:50 Changeset [45420] by ggaren@apple.com

JavaScriptCore:

2009-06-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed a bug in postfix ops, where we would treat x = x++ and x = x--
as a no-op, even if x were not an int, and the ++/-- could have side-effects.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_post_inc): (JSC::JIT::emitSlow_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emitSlow_op_post_dec):

LayoutTests:

2009-06-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Added a test for x=x++ and x=x-- where the ++ / -- have side-effects.

  • fast/js/postfix-syntax-expected.txt:
  • fast/js/resources/postfix-syntax.js: (o.valueOf):
20:24 Changeset [45419] by mjs@apple.com

2009-06-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::loadFullDefaultStyle):
  • css/html.css: Copied from css/html4.css.
  • css/html4.css: Removed.
  • css/themeWin.css:
  • platform/Theme.h:
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustMenuListButtonStyle):
  • rendering/RenderTheme.h:
19:53 Changeset [45418] by jmalonzo@webkit.org

Fix ChangeLog of r45415

19:40 Changeset [45417] by ggaren@apple.com

Fixed a ChangeLog merge fail.

19:40 Changeset [45416] by ggaren@apple.com

2009-06-30 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Start removing cases of addressFor().

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_div):
  • jit/JITInlineMethods.h: (JSC::JIT::emitLoadDouble): (JSC::JIT::emitLoadInt32ToDouble): (JSC::JIT::emitStoreDouble):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue):
19:27 Changeset [45415] by jmalonzo@webkit.org

2009-06-30 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Jan Alonzo.

[GTK] GtkLauncher depends on gtk+2-2.15 because of gtk_orientable_set_orientation()
https://bugs.webkit.org/show_bug.cgi?id=26835

  • GtkLauncher/main.c: (create_toolbar):
19:16 Changeset [45414] by jmalonzo@webkit.org

2009-06-30 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642

Define DragImageRef as GdkPixbuf and implement essential
functions which manipulate drag images.

  • platform/DragImage.h:
  • platform/gtk/DragImageGtk.cpp: (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::createDragImageFromImage):
19:15 Changeset [45413] by jmalonzo@webkit.org

2009-06-30 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

StorageNamespace.cpp build issue
https://bugs.webkit.org/show_bug.cgi?id=26859

Moved #endif ENABLE(DOM_STORAGE) position
so that the build doesn't fail.
The namespace WebCore was started after the #if ENABLE(DOM_STORAGE)
but closed after the #endif.

  • storage/StorageNamespace.cpp:
18:01 Changeset [45412] by barraclough@apple.com

2009-06-30 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Start removing cases of addressFor().

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_div):
  • jit/JITInlineMethods.h: (JSC::JIT::emitLoadDouble): (JSC::JIT::emitLoadInt32ToDouble): (JSC::JIT::emitStoreDouble):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue):
17:40 Changeset [45411] by simon.fraser@apple.com

2009-06-30 Simon Fraser <simon.fraser@apple.com>

Rubber-stamped by Dan Bernstein.

Update compositing pixel results now that DRT dumps them correctly.

  • compositing/overflow/overflow-scroll.html: Fixed typo in this testcase.
  • platform/mac/compositing/overflow/ancestor-overflow-expected.checksum:
  • platform/mac/compositing/overflow/ancestor-overflow-expected.png:
  • platform/mac/compositing/overflow/overflow-positioning-expected.checksum:
  • platform/mac/compositing/overflow/overflow-positioning-expected.png:
  • platform/mac/compositing/overflow/overflow-scroll-expected.txt:
  • platform/mac/compositing/overflow/parent-overflow-expected.checksum:
  • platform/mac/compositing/overflow/parent-overflow-expected.png:
  • platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
  • platform/mac/compositing/repaint/content-into-overflow-expected.png:
  • platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
  • platform/mac/compositing/repaint/overflow-into-content-expected.png:
17:40 Changeset [45410] by simon.fraser@apple.com

2009-06-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Fix drawing of view background in pixel snapshots when using compositing.
We still need to call -displayIfNeeded to ensure that the NSView drawing
has happened.

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):
16:29 Changeset [45409] by ggaren@apple.com

2009-06-30 Geoffrey Garen <ggaren@apple.com>

Rolled back in my last patch with regression fixed.

  • jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq):
16:09 Changeset [45408] by eric@webkit.org

2009-06-30 Eric Seidel <eric@webkit.org>

No review, reverting r45396. (George Staikos agrees the change was wrong.)
http://trac.webkit.org/changeset/45396

  • fast/css/getComputedStyle/computed-style-font-family-expected.txt:
16:01 Changeset [45407] by eric.carlson@apple.com

2009-06-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/7020825> HTMLMediaElement should not assume seeking is only possible in
buffered time ranges

  • html/HTMLMediaElement.cpp:

Don't ASSERT if the network state goes to Idle when when the ready state is
HaveEnoughData or higher, it is perfectly legal.

(WebCore::HTMLMediaElement::setReadyState):

Don't clear m_seeking after posting a 'seeking' event.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::seek):

Do nothing when asked to seek to the same time we are already seeking to. Check requested
seek time against maxTimeSeekable, not maxTimeLoaded.

(WebCore::MediaPlayerPrivate::doSeek):

Don't bother stopping a movie that isn't playing. Minor cleanup to make the code more readable.

(WebCore::MediaPlayerPrivate::seekTimerFired):

Check requested seek time against maxTimeSeekable, not maxTimeLoaded.

(WebCore::MediaPlayerPrivate::updateStates):

A streaming movie has as much data as it needs once it reaches "playable", so
set the ready state to HaveFutureData. A movie with metadata doesn't drop back
to "have nothing" when seeking. A streaming movie doesn't use the network when paused.

(WebCore::MediaPlayerPrivate::timeChanged):

It may not be possible to seek to a specific time in a streamed movie but when seeking
in a streaming movie QuickTime sets the time to closest time possible and posts a
timechanged notification, so update m_seekTo so we can detect when the seek completes.

15:43 Changeset [45406] by ggaren@apple.com

2009-06-30 Geoffrey Garen <ggaren@apple.com>

Rolled out my last patch because it was a 2% SunSpider regression.

  • jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq):
15:43 Changeset [45405] by eric@webkit.org

2009-06-30 Eric Seidel <eric@webkit.org>

Typo fix only, no review.

Fix typo causing failure during land-diff

  • Scripts/bugzilla-tool:
15:27 Changeset [45404] by ggaren@apple.com

2009-06-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin "Sam Weinig" Barraclough.


Standardized the rest of our opcodes to put { tag, payload } in
{ regT1, regT0 } where possible.

  • jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq):
15:06 Changeset [45403] by sfalken@apple.com

https://bugs.webkit.org/show_bug.cgi?id=26860

Reviewed by Sam Weinig.

Blacklist Yahoo Application State plug-in for versions prior to 1.0.0.6.
Earlier versions cause corruption crashes.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::isPluginBlacklisted):
14:57 Changeset [45402] by dino@apple.com

2009-06-30 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7005207> <video> in canvas broken with ACCEL_COMPOSITING

Fix drawImage of video in CanvasRenderingContext2D when
accelerated compositing is enabled. This is done by
adding a new paint method to HTMLVideoElement that
is only called from canvas, which will create the software
renderer if necessary, but otherwise calls the regular
paint method. Meanwhile, add logic to the software video
renderer so that it can be created without calling repaint
every time it sees a new frame.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::paintCurrentFrameInContext):
  • html/HTMLVideoElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::paintCurrentFrameInContext):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::paintCurrentFrameInContext):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): (WebCore::MediaPlayerPrivate::createQTVideoRenderer): (WebCore::MediaPlayerPrivate::currentRenderingMode): (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::tearDownVideoRendering): (WebCore::MediaPlayerPrivate::paintCurrentFrameInContext):
14:47 Changeset [45401] by eric@webkit.org

2009-06-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

createBitmapContextFromWebView() incorrectly used #ifdef BUILDING_ON_LEOPARD,
and thus failed on SnowLeopard.

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):
14:39 Changeset [45400] by barraclough@apple.com

2009-06-30 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoffrey Garen.

Replace calls to store32(tagFor()) and store32(payloadFor())
with emitStoreInt32(), emitStoreBool(), and emitStoreCell().

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emit_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emit_op_bitand): (JSC::JIT::emitBitAnd32Constant): (JSC::JIT::emit_op_bitor): (JSC::JIT::emitBitOr32Constant): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emitBitXor32Constant): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emit_op_sub): (JSC::JIT::emitSub32ConstantLeft): (JSC::JIT::emitSub32ConstantRight): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emit_op_div): (JSC::JIT::emit_op_mod):
  • jit/JITCall.cpp: (JSC::JIT::emit_op_load_varargs):
  • jit/JITInlineMethods.h: (JSC::JIT::emitStoreInt32): (JSC::JIT::emitStoreCell): (JSC::JIT::emitStoreBool): (JSC::JIT::emitStore):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_not): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq): (JSC::JIT::compileOpStrictEq): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null):
  • jit/JITStubCall.h: (JSC::JITStubCall::call):
14:38 Changeset [45399] by hyatt@apple.com

Remove conflict markers from ChangeLog.

14:37 Changeset [45398] by simon.fraser@apple.com

2009-06-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

createBitmapContextFromWebView() incorrectly used #ifdef BUILDING_ON_LEOPARD,
and thus failed on SnowLeopard.

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):
14:37 Changeset [45397] by hyatt@apple.com

WebCore:

<<<<<<< .mine

LayoutTests:

2009-06-30 David Hyatt <hyatt@apple.com>

Reviewed by Beth Dakin.

Add layout test for https://bugs.webkit.org/show_bug.cgi?id=26858.

  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt: Added.
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom.html: Added.
14:27 Changeset [45396] by hausmann@webkit.org

2009-06-30 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

Updated LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt
according to the default font size value set in WebKit/qt/Api/qwebsettings.cpp (in
this case '14').

  • fast/css/getComputedStyle/computed-style-font-family-expected.txt:
14:27 Changeset [45395] by hausmann@webkit.org

2009-06-30 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

Updated LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
to some newly cross-platform CSS properties.

  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
14:07 Changeset [45394] by levin@chromium.org

2009-06-30 Jeremy Orlow (jorlow@chromium.org)

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26852

Fix some minor build issues in the v8 bindings.

  • bindings/v8/custom/V8StorageCustom.cpp: (WebCore::V8Custom::v8StorageNamedPropertyEnumerator): (WebCore::storageGetter): (WebCore::storageSetter): (WebCore::storageDeleter):
  • storage/StorageArea.cpp:
13:16 Changeset [45393] by mrowe@apple.com

Versioning.

13:16 Changeset [45392] by mrowe@apple.com

New tag.

13:10 Changeset [45391] by agl@chromium.org

2009-06-30 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium Linux: use different fonts for each script run.

https://bugs.webkit.org/show_bug.cgi?id=26853

Previously, when rendering complex text, we picked a single font which
could render all the glyphs needed for the run. However, this meant
that sometimes lines were rendered with, for example, [LATIN, THAI,
LATIN] and we could end up with a different font for the Latin parts
than for lines without Thai in them.

With this patch, we pick a font for each script run.

This change is covered by existing layout tests.

13:02 Changeset [45390] by mrowe@apple.com

Fix up the ChangeLog.

13:02 Changeset [45389] by levin@chromium.org

2009-06-30 David Levin <levin@chromium.org>

Reviewed by Oliver Hunt.

Make media/video-document-types pass again. It broke when the
call to waitUntilDone was accidently made asynchronous in r45378.

  • media/video-document-types.html:
12:57 Changeset [45388] by mrowe@apple.com

Merge r45386.

12:53 Changeset [45387] by simon.fraser@apple.com

2009-06-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt, Dan Bernstein.

<rdar://problem/6191676> Redraw issues scrolling overflow:scroll div with compositing

There are two parts to this fix. First, if a compositing layer has overflow clipping
or a mask, then the compositing layer does not need to be sized to encompass all
non-composited children.

Second, when scrolling, we have to back up to the compositing ancestor and have
it reposition descendant compositing layers, because overflow doesn't follow
the z-order tree.

Test: compositing/overflow/overflow-scroll.html

  • page/FrameView.cpp: (WebCore::FrameView::layout): Pass the UpdateCompositingLayers flag when updating layers after layout, so that we can reposition compositing layers if we're not about to do a layer rebuild.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): Only update compositing layers if the flag is set.

(WebCore::RenderLayer::scrollToOffset):
Do compositing layer updates from the compositing ancestor in one fell swoop.

  • rendering/RenderLayer.h: Replace the unused FullUpdate flag with one that allows us to specify whether compositing layers should be updated.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout):
  • rendering/RenderLayerBacking.h: New param that we can pass to updateCompositingDescendantGeometry to control whether the update goes deep.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): We can return earlier if this is not a self-painting layer. If the layer has overflow clip or a mask, then the composited bounds are just the local bounds, excluding descendants.

(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):

  • rendering/RenderLayerCompositor.h: Renamed from updateCompositingChildrenGeometry, and added a flag that allows us to do a deep update.
12:52 Changeset [45386] by mrowe@apple.com

<rdar://problem/7006959> 'Save as…’ does not work in Mail

Reviewed by Timothy Hatcher.

  • WebView/WebFrameView.mm:

(-[WebFrameView initWithFrame:]): Call _needMailThreadWorkaroundIfCalledOffMainThread rather than
needMailThreadWorkaround, as the latter is intended to be used at the point which a workaround would
be applied and thus contains a main thread check. Since -initWithFrame: is called on the main thread,
this was causing us to not switch from exception-throwing to logging for the thread violation behavior.

11:27 Changeset [45385] by ap@webkit.org

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=26764
Uncaught NOT_FOUND_ERR: DOMException 8 loading empty text file

Test: fast/parser/empty-text-resource.html

  • loader/TextDocument.cpp: (WebCore::TextTokenizer::finish): Create document tree if it hasn't been created yet.
11:23 Changeset [45384] by bweinstein@apple.com

2009-06-30 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

Renamed scrollbarUnderPoint to scrollbarAtPoint.

  • page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent):
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollbarAtPoint):
  • platform/ScrollView.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::handleMouseDownEvent): (WebCore::PopupListBox::handleMouseMoveEvent):

2009-06-30 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.


Renamed scrollbarUnderPoint to scrollbarAtPoint to follow conventions.

  • Api/qwebpage.cpp: (QWebPage::swallowContextMenuEvent):
11:05 Changeset [45383] by oliver@apple.com

<rdar://problem/6960286> CrashTracer: [REGRESSION] 1120 crashes in Safari at com.apple.WebCore • WebCore::JSLazyEventListener::parseCode const + 62

Reviewed by Geoff Garen

<select> elements and other elements the produce popups can keep their popups
live across a page load. If this occurs and the <select> element has an
onchange handler it is possible to get into a state where we try to execute
JS on a page that no longer has an execution context.

10:42 Changeset [45382] by ggaren@apple.com

2009-06-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Standardized the rest of the property access instructions to put { tag,
payload } in { regT1, regT0 }.

Small v8 speedup, 0.2% SunSpider slowdown.

  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::emitLoad): (JSC::JIT::emitLoad2):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::patchPutByIdReplace):
10:32 Changeset [45381] by levin@chromium.org

WebCore:

2009-06-30 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=25435>

Added support for sending MessagePorts to/from Workers via postMessage().

  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::messageChannel): Exposes MessageChannel constructor WorkerContext.
  • bindings/js/JSWorkerCustom.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Now correctly handles being instantiated from within a Worker.
  • platform/CrossThreadCopier.h: (WebCore::GenericWorkerTaskTraits<PassOwnPtr>): Added support for passing PassOwnPtr as argument to GenericWorkerTask
  • workers/GenericWorkerTask.h: (WebCore::):
    • workers/Worker.cpp: (WebCore::Worker::postMessage): Now handles disentangling/entangling MessagePorts sent to/from via postMessage. (WebCore::Worker::dispatchMessage):
    • workers/Worker.h:
    • workers/Worker.idl: Added an optional MessagePort argument to postMessage()
    • workers/WorkerContext.cpp: (WebCore::WorkerContext::hasPendingActivity): Workers now report pending activity whenever there are remotely entangled ports. (WebCore::WorkerContext::postMessage): Now handles disentangling/entangling MessagePorts sent to/from via postMessage. (WebCore::WorkerContext::dispatchMessage):
    • workers/WorkerContext.h:
    • workers/WorkerContext.idl: Added an optional MessagePort argument to postMessage()
    • workers/WorkerContextProxy.h:
    • workers/WorkerMessagingProxy.cpp: Updated messaging infrastructure to transport an optional MessagePort/MessagePortChannel. (WebCore::MessageWorkerContextTask::create): (WebCore::MessageWorkerContextTask::MessageWorkerContextTask): (WebCore::MessageWorkerContextTask::performTask): (WebCore::MessageWorkerTask::create): (WebCore::MessageWorkerTask::MessageWorkerTask): (WebCore::MessageWorkerTask::performTask): (WebCore::WorkerMessagingProxy::postMessageToWorkerObject): (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
    • workers/WorkerMessagingProxy.h: Added additional postMessage() API that accepts a MessagePort
    • workers/WorkerObjectProxy.h: Added additional postMessage() API that accepts a MessagePort

LayoutTests:

2009-06-30 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=25435>

Added tests for sending MessagePorts to/from workers.

  • fast/workers/resources/worker-cloneport.js: Added. (onmessage):
  • fast/workers/resources/worker-messageport.js: Added. (onmessage): (pingBack):
  • fast/workers/worker-cloneport-expected.txt: Added.
  • fast/workers/worker-cloneport.html-disabled: Added. Tests for cloning a port while messages are sent from another thread.
  • fast/workers/worker-messageport-expected.txt: Added.
  • fast/workers/worker-messageport.html-disabled: Added. General tests for sending messages to workers via message ports.
  • fast/workers/worker-messageport-gc-expected.txt: Added.
  • fast/workers/worker-messageport-gc.html-disabled: Added. Tests to ensure Workers don't shut down when reachable only via MessagePorts.
10:07 Changeset [45380] by treat@webkit.org

2009-06-30 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Adam Treat.

Bug 26422: [Qt] QWebPagePrivate::frameAt calculates wrong frame

Added a public method QWebPage::frameAt
Removed QWebPagePrivate::frameAt, which calcuated the wrong frame
Modified QWebPage::swallowContextMenuEvent to use the new frameAt method
New test case for frameAt added to tst_qwebpage.cpp

09:57 Changeset [45379] by agl@chromium.org

2009-06-30 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium: Add complex text support on Linux.

https://bugs.webkit.org/show_bug.cgi?id=25068

This patch adds complex text support on Linux using Harfbuzz. It's not
the fastest code possible: some caching of font tables will certainly
be required. However, it's probably the simplest code that works.

This will require checking in new baselines in the Chromium tree for
those layout tests which now pass.

09:30 Changeset [45378] by eric.carlson@apple.com

2009-06-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7019799> Slow loading MediaDocument can fall back to plug-in unnecessarily

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates):

Always fall back to a plug-in if m_hasUnsupportedTracks is set.

(WebCore::MediaPlayerPrivate::disableUnsupportedTracks):

Set m_hasUnsupportedTracks if we disable a track.

2009-06-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.


<rdar://problem/7019799> Slow loading MediaDocument can fall back to plug-in unnecessarily


Don't test iframe immediately, switch over from <video> to <embed> may not have
happend when the document 'load' event fires.

  • media/video-document-types.html:
09:25 Changeset [45377] by japhet@chromium.org

2009-06-30 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Fix inverted if/else that's causing a layout test in src.chromium.org to fail.

https://bugs.webkit.org/show_bug.cgi?id=26820

08:49 Changeset [45376] by mitz@apple.com

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6946611> REGRESSION (r30673): Shade10:" D_Snap to Grid" window is clipping

Added an app-specific quirk to revert the behavior of <link> elements
to the way it was before r30673, namely that if the rel attribute
is not "stylesheet" but the type attribute contains "text/css", the
link behaves as a stylesheet link.

  • WebCore.base.exp: Exported setTreatsAnyTextCSSLinkAsStylesheet().
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): Check

Settings::treatsAnyTextCSSLinkAsStylesheet() and if true, allow a
style sheet link if the type contains "text/css".

  • page/Settings.cpp: (WebCore::Settings::Settings):

Initialize m_treatsAnyTextCSSLinkAsStylesheet.

(WebCore::Settings::setTreatsAnyTextCSSLinkAsStylesheet): Added.

  • page/Settings.h: (WebCore::Settings::treatsAnyTextCSSLinkAsStylesheet): Added.

WebKit/mac:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6946611> REGRESSION (r30673): Shade10:" D_Snap to Grid" window is clipping
  • Misc/WebKitVersionChecks.h: Added

WEBKIT_FIRST_VERSION_WITHOUT_SHADE10_QUIRK

  • WebView/WebView.mm: (-[WebView _needsLinkElementTextCSSQuirk]): Added. Returns YES if the

client app is a version of Shade 10 earlier than 10.6 and it was
linked against a version of WebKit earlier than 531.2.

(-[WebView _preferencesChangedNotification:]): Added a call to

Settings::setTreatsAnyTextCSSLinkAsStylesheet().

07:14 Changeset [45375] by hausmann@webkit.org

2009-06-30 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

Add QWebFrame::baseUrl() function that exposes the base URL of a frame.
Autotests included.

  • Api/qwebframe.cpp: (QWebFrame::baseUrl):
  • Api/qwebframe.h:
  • tests/qwebframe/tst_qwebframe.cpp:
07:05 Changeset [45374] by staikos@webkit.org

2009-06-30 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

Override operator new/delete with const std::nothrow_t& as the second
argument.

06:54 QtWebKitContrib edited by treat@kde.org
(diff)
06:51 QtWebKitContrib edited by treat@kde.org
(diff)
05:15 Changeset [45373] by xan@webkit.org

2009-06-30 Adrien Nader <camaradetux@gmail.com>

Reviewed by Xan Lopez.

Fix typo in GNUMakefile.am: it reads WebCOre instead of WebCore.

  • GNUmakefile.am:
05:10 Changeset [45372] by jmalonzo@webkit.org

2009-06-30 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Turn on ENABLE_DATAGRID so we can run the layout tests.

  • GNUmakefile.am:
03:55 Changeset [45371] by xan@webkit.org

2009-06-30 Xan Lopez <xlopez@igalia.com>

Skip new editing tests.

They are failing because we don't have a dumpEditingCallbacks
implementation.

  • platform/gtk/Skipped:
02:55 Changeset [45370] by ddkilzer@apple.com

2009-06-30 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Sam Weinig.

<https://bugs.webkit.org/show_bug.cgi?id=24986>

Remove unnecessary references to AssemblerBuffer.

  • interpreter/Interpreter.cpp:
  • interpreter/Interpreter.h:
02:33 Changeset [45369] by eric@webkit.org

2009-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

Include a built copy of BeautifulSoup 3.1.0.1 so that
bugzilla-tool users do not need to install it manually.
https://bugs.webkit.org/show_bug.cgi?id=26833

BeautifulSoup is BSD-licensed (thus WebKit compatible) and available from:
http://www.crummy.com/software/BeautifulSoup

  • Scripts/bugzilla-tool: fixed a typo in a log message.
  • Scripts/modules/BeautifulSoup.py: Added.
  • Scripts/modules/bugzilla.py:
02:03 Changeset [45368] by eric@webkit.org

2009-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Simon Hausmann.

Fix our create_patch handling to not
hang when creating large patches.
https://bugs.webkit.org/show_bug.cgi?id=26834

We're now using StringIO to make an in-memory buffer for the patch
instead of piping from the patch command directly to the upload.
The previous hang was caused by calling wait() when the process had already
filed the stdout buffer.

  • Scripts/modules/scm.py:
00:52 Changeset [45367] by hausmann@webkit.org

2009-06-30 Raju Kunnath <raju.kunnath@nokia.com>

Reviewed by Simon Hausmann.

<https://bugs.webkit.org/show_bug.cgi?id=26752>

[Qt] Windows release build issue with Qt4.5 due to -GL flag on msvc2005 and msvc2008.

  • WebCore.pro: Removed -GL compiler option for win32-msvc2005|win32-msvc2008.
00:48 Changeset [45366] by xan@webkit.org

2009-06-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

Initialize member variables in the right order. Fixes compiler
warning.

  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::BMPImageReader):
00:24 Changeset [45365] by xan@webkit.org

2009-06-29 Xan Lopez <xlopez@igalia.com>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26831
Fix compiler warning in WorkerLoaderProxy.h

Forward declaration of a class within a class is not allowed,
since the compiler can't know if the declaration is legal at that
point. This gives the following compiler warning:

../../WebCore/workers/WorkerLoaderProxy.h:40: warning: declaration
"class WebCore::ScriptExecutionContext::Task" does not declare
anything

Include the full ScriptExecutionHeader header instead.

  • workers/WorkerLoaderProxy.h:

06/29/09:

23:43 Changeset [45364] by xan@webkit.org

2009-06-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

Fix a couple of compiler warnings.

  • webkit/webkitwebnavigationaction.cpp:
  • webkit/webkitwebview.cpp: (webkit_web_view_real_move_cursor):
22:56 Changeset [45363] by xan@webkit.org

2009-06-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

Remove unused function.

  • plugins/gtk/PluginPackageGtk.cpp:
22:12 Changeset [45362] by simon.fraser@apple.com

2009-06-29 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Change RenderLayer::updateLayerPositions() to use a bitmask instead of two
boolean arguments. FullUpdate is unused at present, but will be used soon.

  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::scrollToOffset):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::):
20:08 Changeset [45361] by weinig@apple.com

2009-06-29 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Various cleanups.

  • Use fpRegT* instead of X86::xmm*.
  • Use a switch statement in emitBinaryDoubleOp instead of a bunch of if/elses.
  • jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_div):
17:09 Changeset [45360] by levin@chromium.org

2009-06-29 David Levin <levin@chromium.org>

Reviewed by Oliver Hunt.

Still seeing occasional leaks from UString::sharedBuffer code
https://bugs.webkit.org/show_bug.cgi?id=26420

The problem is that the pointer to the memory allocation isn't visible
by "leaks" due to the lower bits being used as flags. The fix is to
make the pointer visible in memory (in debug only). The downside of
this fix that the memory allocated by sharedBuffer will still look like
a leak in non-debug builds when any flags are set.

  • wtf/PtrAndFlags.h: (WTF::PtrAndFlags::set):
16:44 Changeset [45359] by japhet@chromium.org

2009-06-29 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Fix one more bad merge in V8Proxy.

https://bugs.webkit.org/show_bug.cgi?id=26819

16:21 Changeset [45358] by hyatt@apple.com

2009-06-29 David Hyatt <hyatt@apple.com>

Fix Windows bustage. Missed two configurations for enabling DATAGRID.

  • WebKit.vcproj/WebKit.vcproj:
15:35 Changeset [45357] by weinig@apple.com

JavaScriptCore:

2009-06-29 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Remove more unused scons support.

  • SConstruct: Removed.

WebCore:

2009-06-29 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Remove more unused scons support.

  • SConstruct: Removed.

WebKitTools:

2009-06-29 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Remove more unused scons support.

  • Scripts/build-jsc:
  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
15:33 Changeset [45356] by oliver@apple.com

<rdar://problem/7016214> JSON.parse fails to parse valid JSON with most Unicode characters
<https://bugs.webkit.org/show_bug.cgi?id=26802>

Reviewed by Gavin Barraclough.

In the original JSON.parse patch unicode was handled correctly, however in some last
minute "clean up" I oversimplified isSafeStringCharacter. This patch corrects this bug.

14:38 Changeset [45355] by weinig@apple.com

2009-06-29 Sam Weinig <sam@webkit.org>

Reviewed by Dave Hyatt.

Fix some incorrect create functions.

  • html/DataGridColumn.h: (WebCore::DataGridColumn::create):
  • html/DataGridColumnList.h: (WebCore::DataGridColumnList::create):
14:32 Changeset [45354] by hausmann@webkit.org

2009-06-29 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

Updated LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-expected.txt to some newly cross-platform CSS properties.

The file has not been updated for a while.

14:31 Changeset [45353] by weinig@apple.com

WebCore:

2009-06-29 Sam Weinig <sam@webkit.org>

Reviewed by Dave Hyatt.

Remove initialize method from DataGridDataSource and add
DOMDataGridDataSource.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDataGridDataSource.cpp:
  • bindings/js/JSDataGridDataSource.h:
  • bindings/js/JSHTMLDataGridElementCustom.cpp: (WebCore::JSHTMLDataGridElement::setDataSource):
  • html/DOMDataGridDataSource.cpp: Added. (WebCore::DOMDataGridDataSource::DOMDataGridDataSource): (WebCore::DOMDataGridDataSource::~DOMDataGridDataSource):
  • html/DOMDataGridDataSource.h: Added. (WebCore::DOMDataGridDataSource::create): (WebCore::DOMDataGridDataSource::isDOMDataGridDataSource): (WebCore::asDOMDataGridDataSource):
  • html/DataGridDataSource.h: (WebCore::DataGridDataSource::isDOMDataGridDataSource): (WebCore::DataGridDataSource::isJSDataGridDataSource):
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::HTMLDataGridElement): (WebCore::HTMLDataGridElement::setDataSource): (WebCore::HTMLDataGridElement::dataSource):
  • html/HTMLDataGridElement.h:

LayoutTests:

2009-06-29 Sam Weinig <sam@webkit.org>

Reviewed by Dave Hyatt.

Update for the change in DataGridDataSource API.

  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
13:58 Changeset [45352] by japhet@chromium.org

2009-06-29 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a couple of bad merge items from my previous V8Proxy patch.

https://bugs.webkit.org/show_bug.cgi?id=26813

13:42 Changeset [45351] by eric@webkit.org

2009-06-26 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

Rename land-and-update to land-diff and make it awesome.
https://bugs.webkit.org/show_bug.cgi?id=26734

Renamed land-and-update to land-diff
Made the BUGID argument optional.
Added optional support for building and testing before landing.

land-diff [options] [BUGID] Lands the current working directory diff and updates the bug if provided.

Options:

-r REVIEWER, --reviewer=REVIEWER

Update ChangeLogs to say Reviewed by REVIEWER.

--no-close Leave bug open after landing.
--no-build Commit without building first, implies --no-test.
--no-test Commit without running run-webkit-tests.

  • Scripts/bugzilla-tool:
13:41 Changeset [45350] by cmarrin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=26706

Fixed crash due to dereference of m_toStyle

13:36 Changeset [45349] by alice.liu@apple.com

build fix. accidental omission of end paren

13:22 Changeset [45348] by eric.carlson@apple.com

2009-06-29 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7014813> Ask media engine if a movie is streamed or downloaded.

  • WebCore.base.exp:

Export _wkQTMovieGetType

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::hasSingleSecurityOrigin):

Move to keep with other non-callback functions.

(WebCore::MediaPlayer::movieLoadType):

New, returns the movie type.

  • platform/graphics/MediaPlayer.h:

Declare MovieLoadType enum and movieLoadType method.

  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::movieLoadType):

Default implementation of movieLoadType

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):

Don't base m_isStreaming on protocol, there are other types of streaming movies.

(WebCore::MediaPlayerPrivate::maxTimeBuffered):

Don't assume all streams are unbuffered.

(WebCore::MediaPlayerPrivate::updateStates):

Update m_isStreaming once we have metadata.

(WebCore::MediaPlayerPrivate::disableUnsupportedTracks):

Tracks that are disabled to begin with shouldn't be included in m_enabledTrackCount.

(WebCore::MediaPlayerPrivate::movieLoadType):

New, return movie type.

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Add wkQTMovieGetType.

2009-06-29 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7014813> Ask media engine if a movie is streamed or downloaded.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

Add QTMovieGetType.

2009-06-29 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Update WebKitSystemInterface for <rdar://problem/7014813>

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
13:15 Changeset [45347] by alice.liu@apple.com

2009-06-29 Alice Liu <alice.liu@apple.com>

Fixed <rdar://problem/6930280> Reproducible crash at USA Today photo gallery

Reviewed by Anders Carlsson.

No test added because the crash requires a flash plugin

  • plugins/win/PluginMessageThrottlerWin.cpp: Rely on the hWnd of the plugin to tell us whether the PluginView has been deleted during execution of its wndProc. (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
13:02 Changeset [45346] by dimich@chromium.org

2009-06-29 Dmitry Titov <dimich@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26811

[Chromium] Remove a flag and functions used to enable workers in runtime.

  • bindings/v8/WorkerContextExecutionProxy.cpp:
  • bindings/v8/WorkerContextExecutionProxy.h:
13:00 Changeset [45345] by simon.fraser@apple.com

2009-06-29 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

<rdar://problem/6976712> Text antialiasing problems when rendering into compositing layers.

Improve the appearance of text in compositing layers by making use of
CA's layer geometry flipping, rather that doing it ourselves with a flip
transform. This allows CG to use font autohinting in the layer text.

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setGeometryOrientation): (WebCore::GraphicsLayer::geometryOrientation): New methods to set whether this layer uses flipped geometry.
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setGeometryOrientation): (WebCore::GraphicsLayerCA::geometryOrientation): Subclass in order to call into CA

(WebCore::GraphicsLayerCA::setContentsLayer):
Now that CA is doing the geometry flipping, we no longer need to flip the content
layers for image and video manually

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Turn on flipping on the root layer.
12:52 Changeset [45344] by hyatt@apple.com

2009-06-29 David Hyatt <hyatt@apple.com>

Reviewed by Mark Rowe.

Update layout tests for addition of HTMLDataGridCellElement constructor.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
12:36 Changeset [45343] by zimmermann@webkit.org

Reviewed by Adam Treat.
Rename go-task-animation.* to ontimer-inline-event.* to reflect what it really tests.

12:11 Changeset [45342] by zimmermann@webkit.org

Reviewed by Adam Treat.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26246

Implement most WML specific <select> element features.
Add 'iname' / 'ivalue' support and support variable references.

Add two tests covering most select/variable related functionality.
Needs more tests when adding full 'iname' / 'ivalue' support (used in conjuction with onpick).

Tests: http/tests/wml/post-data-to-server.html

wml/select-element-variables.html

11:11 Changeset [45341] by weinig@apple.com

2009-06-29 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Add inline code dealing with doubles for op_jfalse and op_jtrue.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::): (JSC::MacroAssemblerX86Common::zeroDouble):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue):
09:34 Changeset [45340] by jberlin@apple.com

2009-06-29 Jessie Berlin <jberlin@apple.com>

Fix the windows build.

Reviewed by Adam Roben.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::isSpeaking):
  • WebCoreSupport/WebContextMenuClient.h:
09:03 Changeset [45339] by hyatt@apple.com

2009-06-29 David Hyatt <hyatt@apple.com>

Reviewed by Adam Roben.

Make sure to patch all configurations to have datagrid enabled.

  • WebKit.vcproj/WebKit.vcproj:
08:52 Changeset [45338] by hyatt@apple.com

WebCore:

2009-06-29 David Hyatt <hyatt@apple.com>

Reviewed by Adam Roben.

Put <datagrid> behind an ifdef.

  • Configurations/FeatureDefines.xcconfig:
  • bindings/js/JSDataGridColumnListCustom.cpp:
  • bindings/js/JSDataGridDataSource.cpp:
  • bindings/js/JSDataGridDataSource.h:
  • bindings/js/JSHTMLDataGridElementCustom.cpp:
  • html/DataGridColumn.cpp:
  • html/DataGridColumn.h:
  • html/DataGridColumn.idl:
  • html/DataGridColumnList.cpp:
  • html/DataGridColumnList.h:
  • html/DataGridColumnList.idl:
  • html/DataGridDataSource.h:
  • html/HTMLDataGridCellElement.cpp:
  • html/HTMLDataGridCellElement.h:
  • html/HTMLDataGridCellElement.idl:
  • html/HTMLDataGridColElement.cpp:
  • html/HTMLDataGridColElement.h:
  • html/HTMLDataGridColElement.idl:
  • html/HTMLDataGridElement.cpp:
  • html/HTMLDataGridElement.h:
  • html/HTMLDataGridElement.idl:
  • html/HTMLDataGridRowElement.cpp:
  • html/HTMLDataGridRowElement.h:
  • html/HTMLDataGridRowElement.idl:
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:
  • rendering/RenderDataGrid.cpp:
  • rendering/RenderDataGrid.h:

WebKit/mac:

2009-06-29 David Hyatt <hyatt@apple.com>

Reviewed by Adam Roben.

Put datagrid behind an #ifdef.

  • Configurations/FeatureDefines.xcconfig:

WebKit/win:

2009-06-29 David Hyatt <hyatt@apple.com>

Reviewed by Adam Roben.

Put <datagrid> behind an ifdef.

  • WebKit.vcproj/WebKit.vcproj:
06:57 Changeset [45337] by hausmann@webkit.org

2009-06-29 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat and Adam Roben.

Fix compilation with MINGW. Ported MSVC inline assembly to
GNU inline assembly. Also fixed casting errors where gcc
refused to cast a pointer-to-function to a pointer-to-object,
without an intermediate cast to a non-pointer type.

02:17 Changeset [45336] by hausmann@webkit.org

2009-06-29 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Qt build, add missing isSpeaking() implementation to
ContextMenuClient.

06/28/09:

22:24 Changeset [45335] by xan@webkit.org

2009-06-28 Xan Lopez <xlopez@igalia.com>

Fix the GTK+ build.

  • WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::ContextMenuClient::isSpeaking):
  • WebCoreSupport/ContextMenuClientGtk.h:
21:28 Changeset [45334] by ggaren@apple.com

2009-06-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Standardized op_get_by_id to put { tag, payload } in { regT1, regT0 }.


SunSpider and v8 report maybe 0.2%-0.4% regressions, but the optimization
this enables will win much more than that back.

  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
20:06 Changeset [45333] by sullivan@apple.com

WebCore:

2009-06-26 John Sullivan <sullivan@apple.com>

Added Speech submenu to context menu on Mac when there's a non-editable selection
(it was already present when there's an editable selection).
Also added support for disabling "Stop Speaking" when there is no speaking to stop.

Reviewed by Tim Hatcher.

  • loader/EmptyClients.h: (WebCore::EmptyContextMenuClient::isSpeaking): implemented this new virtual function to return false


  • page/ContextMenuClient.h: declared this new pure virtual function


  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): insert Speech item (after a separator) on Mac when there's selected non-editable text (WebCore::ContextMenu::checkOrEnableIfNeeded): enable Stop Speaking item only if the context menu client returns true for isSpeaking()

WebKit/mac:

2009-06-26 John Sullivan <sullivan@apple.com>

Added support for disabling Stop Speaking when there is no speaking to stop.
Also fixed Stop Speaking so that it works (formerly it would throw an exception, and
selecting it from the menu would perform a web search instead (!)).

Reviewed by Tim Hatcher.

  • WebCoreSupport/WebContextMenuClient.h: declare isSpeaking()


  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::isSpeaking): implement by calling through to NSApplication (WebContextMenuClient::stopSpeaking): fixed implementation by correcting the signature of the NSApplication method
19:54 Changeset [45332] by mitz@apple.com

WebCore:

Reviewed by Simon Fraser.

Test: added a case to fast/dom/Element/scrollWidth.html

Ensure that scroll{Width, Height} is greater or equal to
client{Width, Height}.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):

LayoutTests:

Reviewed by Simon Fraser.

  • fast/dom/Element/scrollWidth-expected.txt:
  • fast/dom/Element/scrollWidth.html:
15:06 Changeset [45331] by mrowe@apple.com

Versioning.

10:25 Changeset [45330] by simon.fraser@apple.com

2009-06-27 Simon Fraser <simon.fraser@apple.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26780

Do not make compositing layers for non-self-painting RenderLayers,
since these exist only to push a clip onto the clipping stack. If such
a layer gets compositied for some other reason, it should not paint.

Also ensure that we update composited layer positions correctly
inside overflow:scroll layers. We can't assume that the contents
are child layers, so we have to go up to the compositing ancestor,
and tell it to update all its child layer positions as we do
after layout.

Tests: compositing/layers-inside-overflow-scroll.html

compositing/self-painting-layers.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::needsToBeComposited):
05:40 Changeset [45329] by jmalonzo@webkit.org

2009-06-28 Sriram Yadavalli <sriram.yadavalli@nokia.com>

Reviewed by Eric Seidel.

[Qt] Fix build break for Qt
https://bugs.webkit.org/show_bug.cgi?id=26779

  • Api/qwebpage.cpp: (QWebPage::swallowContextMenuEvent):
04:58 Changeset [45328] by jmalonzo@webkit.org

2009-06-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix - include stdarg.h for va_start/va_end.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
04:15 Changeset [45327] by eric@webkit.org

2009-06-28 Luke Kenneth Casson Leighton <lkcl@lkcl.net>

Reviewed by Eric Seidel.

PurgeableBuffer #defines leave out functions on gtk MacOSX 10.4 build
https://bugs.webkit.org/show_bug.cgi?id=23057

Define these functions for Gtk as well.

  • platform/PurgeableBuffer.h:
04:14 Changeset [45326] by eric@webkit.org

2009-06-28 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Update CodeGeneratorV8.pm to match the new api for V8Proxy.

https://bugs.webkit.org/show_bug.cgi?id=26765

  • bindings/scripts/CodeGeneratorV8.pm: Match the current version of V8Proxy.
04:13 Changeset [45325] by eric@webkit.org

2009-06-28 Nicolas Sylvain <nsylvain@chromium.org>

Reviewed by Dimitri Glazkov.

If loading a font fails because of the sandbox, we ask the browser process to
try to load it by calling ensureFontLoaded. If it still fails after
ensureFontLoaded, we hit a ASSERT_NOT_REACHED.

This case happens once in a while during browser shutdown. The browser will
queue a message to the renderer to shutdown, and will then stop answering sync
messages from the renderer. If the renderer is still loading a page during this
time, it might try to call the browser process to ask to load a font. The
browser process will ignore the request, and the font will fail to load, even
after the second try.

This is unfortunate, but there is no real risk here, since the renderer will be
going away as soon as it processes another message.

This can't be layout tested as it depends on the sandbox.

https://bugs.webkit.org/show_bug.cgi?id=26743

  • platform/graphics/chromium/FontChromiumWin.cpp:
  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
03:31 Changeset [45324] by eric@webkit.org

2009-06-28 John Abd-El-Malek <jam@chromium.org>

https://bugs.webkit.org/show_bug.cgi?id=15457

Layout tests to ensure that "src" paramater is added when it's missing
but "data" is present.

  • plugins/netscape-plugin-map-data-to-src-expected.txt: Added.
  • plugins/netscape-plugin-map-data-to-src.html: Added.

2009-06-28 John Abd-El-Malek <jam@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=15457

Test: plugins/netscape-plugin-map-data-to-src.html

Fix problems with Real or WMP plugins not displaying because "data" was set
on the OBJECT tag instead of "src". This is based on what Firefox does, see
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsObjectFrame.cpp#3045

  • rendering/RenderPartObject.cpp: (WebCore::mapDataParamToSrc): (WebCore::RenderPartObject::updateWidget):

2009-06-28 John Abd-El-Malek <jam@chromium.org>

https://bugs.webkit.org/show_bug.cgi?id=15457

Modify NPAPI test plugin to verify that "src" paramater is added when
it's missing but "data" is present.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginLog):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_Destroy): (NPP_SetWindow): (handleEventCarbon): (handleEventCocoa):
  • DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_New):
03:19 Changeset [45323] by eric@webkit.org

2009-06-28 Eric Seidel <eric@webkit.org>

No review. Just updating test results Kevin seems to have missed.

Test failure started with:
http://trac.webkit.org/changeset/45287
The new results definitely look better.

  • fast/profiler/profile-with-no-title-expected.txt:
02:36 Changeset [45322] by jmalonzo@webkit.org

2009-06-28 Miloš Popović <gpopac@gmail.com>

Rubber-stamped by Jan Alonzo.

New Serbian translation.

06/27/09:

23:05 Changeset [45321] by simon.fraser@apple.com

2009-06-27 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=26780

Fix up previous change. When computeCompositingRequirements() determines
that the current layer is composited, it needs to inform its parent
by setting compositingState.m_subtreeIsCompositing() to true. That didn't
always happen after the previous patch. Clarified the logic here.

  • rendering/RenderLayerCompositor.cpp: (WebCore::CompositingState::CompositingState): (WebCore::RenderLayerCompositor::computeCompositingRequirements):
22:54 Changeset [45320] by jmalonzo@webkit.org

2009-06-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Jan Alonzo.

[Qt] Build fix after r45290
https://bugs.webkit.org/show_bug.cgi?id=26769

  • WebCore.pro:
22:54 Changeset [45319] by jmalonzo@webkit.org

2009-06-27 Emilio Pozuelo Monfort <pochu27@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Don't use deprecated GTK+ symbols.
https://bugs.webkit.org/show_bug.cgi?id=26583

  • plugins/gtk/gtk2xtbin.c: (gtk_xtbin_class_init): (gtk_xtbin_new): (gtk_xtbin_destroy):
  • GtkLauncher/main.c: (create_toolbar):
21:38 Changeset [45318] by simon.fraser@apple.com

2009-06-27 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=26780

First part: fix the RenderLayer::hasCompositingDescendant() flag to be set
correctly.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements): Do not unconditionally set compositingState.m_subtreeIsCompositing, because that can clobber the value from an earlier sibling. Add some more comments.

Remove a final use of Vector iterators.

(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
Move the normalFlowList() processing outside the test for isStackingContext().

21:19 Changeset [45317] by mitz@apple.com

Reviewed by Simon Fraser and Antti Koivisto.

  • make paintFillLayerExtended() non-virtual and remove its clipY and clipH parameters

These parameters were computed and passed along to
paintFillLayerExtended in order to vertically constrain the rect fill to
the damage rect, because Qt cannot paint tall rectangles (see
<http://websvn.kde.org/?view=rev&revision=42721>). Since the damage rect
is passed along in the PaintInfo, the extra parameters are redundant,
and the intersection can just take place in paintFillLayerExtended().

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::paintMask): (WebCore::RenderBox::paintMaskImages): (WebCore::RenderBox::paintFillLayers): (WebCore::RenderBox::paintFillLayer):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintMask):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations): (WebCore::RenderTable::paintMask):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintMask):
20:13 Changeset [45316] by bfulgham@webkit.org

WebCore:

2009-06-27 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26762

Clean up for IndentOutdentCommand::indentRegion, and solved most of problems related to the bug 21712.
https://bugs.webkit.org/show_bug.cgi?id=21712

Added few utility functions to htmlediting.h/cpp

isVisibilyAdjacent checks whether the first position is visibly next to the second position.
i.e. there is no visible node between the first and second positions

canMergeLists checks whether two lists can be merged.
It checks the type of list, the editing boundary, and adjacency of the lists.

Tests: editing/execCommand/indent-nested-lists-1.html

editing/execCommand/indent-nested-lists-2.html
editing/execCommand/indent-nested-lists-3.html
editing/execCommand/indent-nested-lists-4.html
editing/execCommand/indent-nested-lists-5.html
editing/execCommand/indent-nested-lists-6.html
editing/execCommand/indent-nested-lists-7.html
editing/execCommand/outdent-nested-lists-1.html
editing/execCommand/outdent-nested-lists-2.html
editing/execCommand/outdent-nested-lists-3.html
editing/execCommand/outdent-nested-lists-4.html

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): (WebCore::IndentOutdentCommand::tryIndentingAsListItem): (WebCore::IndentOutdentCommand::indentIntoBlockquote): (WebCore::IndentOutdentCommand::indentRegion):
  • editing/IndentOutdentCommand.h:
  • editing/htmlediting.cpp: (WebCore::enclosingListChild): (WebCore::canMergeLists): (WebCore::isVisibilyAdjacent):
  • editing/htmlediting.h:

LayoutTests:

2009-06-27 Ryosuke Niwa <set EMAIL_ADDRESS environment variable>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26762

Clean up for IndentOutdentCommand::indentRegion, and solved most of problems related to the bug 21712.
https://bugs.webkit.org/show_bug.cgi?id=21712


The following test cases are intended for 21712, but included here
since this patch already solved a lot of problems.

  • editing/execCommand/indent-nested-lists-1-expected.txt: Added.
  • editing/execCommand/indent-nested-lists-1.html: Added.
  • editing/execCommand/indent-nested-lists-2-expected.txt: Added.
  • editing/execCommand/indent-nested-lists-2.html: Added.
  • editing/execCommand/indent-nested-lists-3-expected.txt: Added.
  • editing/execCommand/indent-nested-lists-3.html: Added.
  • editing/execCommand/indent-nested-lists-4-expected.txt: Added.
  • editing/execCommand/indent-nested-lists-4.html: Added.
  • editing/execCommand/indent-nested-lists-5-expected.txt: Added.
  • editing/execCommand/indent-nested-lists-5.html: Added.
  • editing/execCommand/indent-nested-lists-6-expected.txt: Added.
  • editing/execCommand/indent-nested-lists-6.html: Added.
  • editing/execCommand/indent-nested-lists-7-expected.txt: Added.
  • editing/execCommand/indent-nested-lists-7.html: Added.
  • editing/execCommand/outdent-nested-lists-1-expected.txt: Added.
  • editing/execCommand/outdent-nested-lists-1.html: Added.
  • editing/execCommand/outdent-nested-lists-2-expected.txt: Added.
  • editing/execCommand/outdent-nested-lists-2.html: Added.
  • editing/execCommand/outdent-nested-lists-3-expected.txt: Added.
  • editing/execCommand/outdent-nested-lists-3.html: Added.
  • editing/execCommand/outdent-nested-lists-4-expected.txt: Added.
  • editing/execCommand/outdent-nested-lists-4.html: Added.
19:31 Changeset [45315] by bfulgham@webkit.org

2009-06-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Fix completion when iterating options using Tab.

https://bugs.webkit.org/show_bug.cgi?id=26722

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._completionsReady):
17:32 Changeset [45314] by abarth@webkit.org

2009-06-27 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.


https://bugs.webkit.org/show_bug.cgi?id=26776


More tests for the XSSAuditor.

  • http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event.html: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL.html: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location.html: Added.
  • http/tests/security/xssAuditor/dom-write-URL-expected.txt: Added.
  • http/tests/security/xssAuditor/dom-write-URL.html: Added.
  • http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt: Added.
  • http/tests/security/xssAuditor/dom-write-innerHTML.html: Added.
  • http/tests/security/xssAuditor/dom-write-location-expected.txt: Added.
  • http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt: Added.
  • http/tests/security/xssAuditor/dom-write-location-inline-event.html: Added.
  • http/tests/security/xssAuditor/dom-write-location-javascript-URL-expected.txt: Added.
  • http/tests/security/xssAuditor/dom-write-location-javascript-URL.html: Added.
  • http/tests/security/xssAuditor/dom-write-location.html: Added.
  • http/tests/security/xssAuditor/faux-script1-expected.txt: Added.
  • http/tests/security/xssAuditor/faux-script1.html: Added.
  • http/tests/security/xssAuditor/faux-script2-expected.txt: Added.
  • http/tests/security/xssAuditor/faux-script2.html: Added.
  • http/tests/security/xssAuditor/faux-script3-expected.txt: Added.
  • http/tests/security/xssAuditor/faux-script3.html: Added.
  • http/tests/security/xssAuditor/get-from-iframe-expected.txt: Added.
  • http/tests/security/xssAuditor/get-from-iframe.html: Added.
  • http/tests/security/xssAuditor/malformed-HTML-expected.txt: Added.
  • http/tests/security/xssAuditor/malformed-HTML.html: Added.
  • http/tests/security/xssAuditor/post-from-iframe-expected.txt: Added.
  • http/tests/security/xssAuditor/post-from-iframe.html: Added.
  • http/tests/security/xssAuditor/resources/anchor-url-dom-write-location-click.html: Added.
  • http/tests/security/xssAuditor/resources/echo-dom-write-URL.html: Added.
  • http/tests/security/xssAuditor/resources/echo-dom-write-innerHTML.html: Added.
  • http/tests/security/xssAuditor/resources/echo-dom-write-location.html: Added.
  • http/tests/security/xssAuditor/resources/utilities.js: Added. (sendRequestFromIFrame):
14:38 Changeset [45313] by kov@webkit.org

2009-06-27 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable

Override visibleContentRect to handle GTK+'s case, in which
scrollbars or equivalent decoration are painted by the parent
widget.

  • platform/ScrollView.cpp:
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::visibleContentRect):
12:36 Changeset [45312] by abarth@webkit.org

WebCore:

2009-06-27 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26708


Fix addresses false negatives with respect to scheme relative paths, iFrame JavaScript URLs,
and UTF-7 encoded payloads.

Tests: http/tests/security/xssAuditor/http-equiv-utf-7-encoded.html

http/tests/security/xssAuditor/iframe-javascript-url.html
http/tests/security/xssAuditor/script-tag-utf-7-encoded.html
http/tests/security/xssAuditor/script-tag-with-source-relative-scheme.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): Moved XSSAuditor check to HTMLTokenizer::parseTag. (WebCore::HTMLTokenizer::parseTag):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe): Modified to inform XSSAuditor of parent frame so as to compare against iFrame javascript URL.
  • page/XSSAuditor.cpp: Removed method XSSAuditor::isControlCharacter. Instead, exposed method isControlCharacter in ResourceResponseBase.cpp. (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::decodeURL): Modified to decode string using specified encoder. (WebCore::XSSAuditor::findInRequest): Generalized to arbitrary frame so as to prevent execution of iFrame javascript URL.
  • page/XSSAuditor.h: Added field m_parentFrame.
  • platform/network/ResourceResponseBase.cpp: (WebCore::isControlCharacter):
  • platform/network/ResourceResponseBase.h:

LayoutTests:

2009-06-27 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

Tests for https://bugs.webkit.org/show_bug.cgi?id=26708

Tests prevention of injected scripts with scheme relative paths, iFrame JavaScript URLs,
and UTF-7 encoding.

  • http/tests/security/xssAuditor/http-equiv-utf-7-encoded-expected.txt: Added.
  • http/tests/security/xssAuditor/http-equiv-utf-7-encoded.html: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url.html: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-default-encode.pl: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7-encoded-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7-encoded.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-relative-scheme.html: Added.
01:34 Changeset [45311] by oliver@apple.com

Bug 26771: Canvas is incorrectly tainted when drawing from a video element that uses <source> elements

Reviewed by Maciej Stachowiak.

The drawImage(<video>) logic naively assumes that it just needs
to check the src attribute of the video element when in fact it
needs to look at the url that is being played instead. Failure
to do this means that video provided through source elements
taints the canvas.

Test: media/video-canvas-source.html

00:34 Changeset [45310] by hausmann@webkit.org

2009-06-27 Simon Hausmann <simon.hausmann@nokia.com>

Build fix for Qt under Windows.

  • Api/qwebhistory.h: Use consistent export linkage for the datastream operators.

06/26/09:

23:22 Changeset [45309] by simon.fraser@apple.com

2009-06-26 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7011924> Opacity transitions should not trigger hardware compositing mode

Don't go into compositing mode just for opacity transitions, but they will be
hardware accelerated if we're already compositing.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingLayer): (WebCore::RenderLayerCompositor::requiresCompositingForTransform): (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
  • rendering/RenderLayerCompositor.h:
22:19 Changeset [45308] by ap@webkit.org

Updating Tiger results for a recently modified test.

  • platform/mac-tiger/fast/encoding/idn-security-expected.txt:
22:15 Changeset [45307] by oliver@apple.com

<rdar://problem/7009684> REGRESSION(r45039): Crashes inside JSEvent::put on PowerPC (26746)
<https://bugs.webkit.org/show_bug.cgi?id=26746>

Reviewed by Dan Bernstein

Fix for r45039 incorrectly uncached a get_by_id by converting it to put_by_id. Clearly this
is less than correct. This patch corrects that error.

19:49 Changeset [45306] by bweinstein@apple.com

Mac build fix part 2 - add new mangled symbol

19:40 Changeset [45305] by bweinstein@apple.com

First part of Mac Build Fix - find missing symbol

19:23 Changeset [45304] by bweinstein@apple.com

2009-06-26 Brian Weinstein <bweinstein@apple.com>

Reviewed by Simon Fraser.


Changed call of scrollbarUnderMouse to scrollbarUnderPoint to match new API.

  • Api/qwebpage.cpp: (QWebPage::swallowContextMenuEvent):

2009-06-26 Brian Weinstein <bweinstein@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26695

Added hit testing on scrollbars, so if you start a gesture over a scrollbar,
it isn't counted, and lets the user drag the scrollbar itself instead of a
panning gesture. Also cleaned up code in gesture.

  • WebView.cpp: (WebView::gestureNotify): (WebView::gesture):

2009-06-26 Brian Weinstein <bweinstein@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26695


Added the ability to do scrollbar hit testing in EventHandler, changed the
signature of a PlatformWheelEvent constructor, and changed scrollbarUnderMouse
to scrollbarUnderPoint, and updated all calls to that function.

  • page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent):
  • page/EventHandler.h: (WebCore::):
  • platform/PlatformWheelEvent.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollbarUnderPoint):
  • platform/ScrollView.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::handleMouseDownEvent): (WebCore::PopupListBox::handleMouseMoveEvent):
  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
19:02 Changeset [45303] by ggaren@apple.com

2009-06-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Standardized op_call to put { tag, payload } in { regT1, regT0 }.


SunSpider and v8 report no change.

  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallSetupArgs): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::compileOpCallVarargsSetupArgs): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
18:52 Changeset [45302] by abarth@webkit.org

2009-06-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26767

Fix a build break due to LocalStorage.h being included in WebKitDLL.cpp
despite it being deleted from the repo by the following patch/commit:
https://bugs.webkit.org/show_bug.cgi?id=26732
http://trac.webkit.org/changeset/45290

  • WebKitDLL.cpp:
18:49 Changeset [45301] by abarth@webkit.org

2009-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make SVN work (again?).

  • Scripts/modules/scm.py:
17:58 Changeset [45300] by simon.fraser@apple.com

2009-06-26 Simon Fraser <simon.fraser@apple.com>

Rubber-stamped by Dave Levin

Rename ioCompState to compositingState to better match WebCore coding style.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
17:50 Changeset [45299] by mitz@apple.com

Reviewed by Mark Rowe.

  • revert unintentional project changes from r45277
  • WebCore.xcodeproj/project.pbxproj:
17:44 Changeset [45298] by mrowe@apple.com

Fix the Windows build.

17:37 Changeset [45297] by simon.fraser@apple.com

2009-06-26 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=26766

Change to use array indexing rather than Vector enumerators; the former
are preferred style.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::hasNonCompositingContent):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::updateCompositingChildrenGeometry): (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): (WebCore::RenderLayerCompositor::layerHas3DContent):
17:17 Changeset [45296] by mitz@apple.com

WebCore:

Reviewed by Oliver Hunt.

  • fix <rdar://problem/6961476> REGRESSION (r42043): scrollWidth reported as 1 px

Test: fast/dom/Element/scrollWidth.html

Changed scrollWidth and scrollHeight to use the same logic for
visible overflow boxes that is used for clipped overflow boxes. In
particular, borders are not included and
{leftmost,rightmost,lowest}Position() are used. This logic matches IE8.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/dom/Element/scrollWidth-expected.txt: Added.
  • fast/dom/Element/scrollWidth.html: Added.
17:07 Changeset [45295] by cfleizach@apple.com

Bug 26725: aria-hidden, aria-disabled, aria-readonly need to be implemented
https://bugs.webkit.org/show_bug.cgi?id=26725

17:02 Changeset [45294] by beidson@apple.com

2009-06-26 Brady Eidson <beidson@apple.com>

OMG.

  • platform/mac-tiger/fast/loader/file-url-mimetypes-expected.txt: Removed.
  • platform/mac-tiger/platform: Added.
  • platform/mac-tiger/platform/mac: Added.
  • platform/mac-tiger/platform/mac/fast: Added.
  • platform/mac-tiger/platform/mac/fast/loader: Added.
  • platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Copied from platform/mac-tiger/fast/loader/file-url-mimetypes-expected.txt.
16:09 Changeset [45293] by brettw@chromium.org

2009-06-26 Brett Wilson <brettw@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26759

GIFImageDecoder is broken.

Make the GIFImageDecoder.repetitionCount function const to match the
base class. The mismatched definitions were causing the function to not
get called.

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::repetitionCount):
  • platform/image-decoders/gif/GIFImageDecoder.h:
15:58 Changeset [45292] by cmarrin@apple.com

Additional fix for https://bugs.webkit.org/show_bug.cgi?id=26651

The flag should always default to true to avoid it getting set
to false in a build with accelerated compositing turned off
and then disabling accelerated compositing when subsequently
running a build with it turned on.

15:53 Changeset [45291] by beidson@apple.com

2009-06-26 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Followup for the fix for <rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails

Now that other MIME type correction stuff is in our swizzled method, Tiger needs it too!

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
  • platform/network/mac/WebCoreURLResponse.h:
15:49 Changeset [45290] by dglazkov@chromium.org

2009-06-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26732

For the final step of https://bugs.webkit.org/show_bug.cgi?id=25376,
combine LocalStorage and SessionStorage into StorageNamespace. The
synching code (for LocalStorage) has already been removed, so these
classes are now very similar. All they do is essentially contain a
logical grouping of origins that are attached to specific contexts
(be it PageGroups for LocalStorage and Page for SessionStorage).

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • page/Chrome.cpp: (WebCore::Chrome::createWindow):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage):
  • page/DOMWindow.h:
  • page/Page.cpp: (WebCore::Page::sessionStorage): (WebCore::Page::setSessionStorage):
  • page/Page.h:
  • page/PageGroup.cpp: (WebCore::PageGroup::localStorage):
  • page/PageGroup.h:
  • storage/LocalStorage.cpp: Removed.
  • storage/LocalStorage.h: Removed.
  • storage/LocalStorageTask.cpp:
  • storage/LocalStorageThread.cpp:
  • storage/SessionStorage.cpp: Removed.
  • storage/SessionStorage.h: Removed.
  • storage/StorageArea.cpp: (WebCore::StorageArea::create): (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::copy): (WebCore::StorageArea::length): (WebCore::StorageArea::key): (WebCore::StorageArea::getItem): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear): (WebCore::StorageArea::contains): (WebCore::StorageArea::importItem): (WebCore::StorageArea::close): (WebCore::StorageArea::dispatchStorageEvent):
  • storage/StorageArea.h: (WebCore::):
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::scheduleFinalSync):
  • storage/StorageNamespace.cpp: Copied from WebCore/storage/LocalStorage.cpp. (WebCore::localStorageNamespaceMap): (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace): (WebCore::StorageNamespace::StorageNamespace): (WebCore::StorageNamespace::~StorageNamespace): (WebCore::StorageNamespace::copy): (WebCore::StorageNamespace::storageArea): (WebCore::StorageNamespace::close):
  • storage/StorageNamespace.h: Copied from WebCore/storage/LocalStorage.h.
15:48 Changeset [45289] by beidson@apple.com

2009-06-26 Brady Eidson <beidson@apple.com>

Fix Tiger results for the new mime type layout test.

  • platform/mac-tiger/fast/loader: Added.
  • platform/mac-tiger/fast/loader/file-url-mimetypes-expected.txt: Added.
15:22 Changeset [45288] by japhet@chromium.org

2009-06-26 Nate Chapin <japhet@chromium.org>

Reviewed by David Levin.

Upstream V8Proxy. This involved updating a lot of function and variable names to match WebKit style, hence the large size.

https://bugs.webkit.org/show_bug.cgi?id=26623

15:08 Changeset [45287] by kmccullough@apple.com

2009-06-26 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/7011047> Profiler shows the record button 'on' even
though it's finished

I consolidated the creation of the user initiated profile name into
its own function and then called it from console::profile instead of
calling startUserInitiatedProfiling(). This way we don't call
toggleRecordButton() which turns on the record button.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::getCurrentUserInitiatedProfileName): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
  • inspector/InspectorController.h:
  • page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
15:06 Changeset [45286] by jberlin@apple.com

2009-06-26 Jessie Berlin <jberlin@apple.com>

Reviewed by Mark Rowe.


Fix the build bots.

  • editing/selection/drag-start-event-client-x-y-expected.txt:
14:53 Changeset [45285] by jeremy@chromium.org

Move focusRingColor to RenderTheme

14:51 Changeset [45284] by dimich@chromium.org

2009-06-26 Dmitry Titov <dimich@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26761
[Chromium] Enable Dedicated Workers in Chromium.

  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Remove the check that prevented workers from being created w/o a command-line switch. The flag itself and methods will be removed in a subsequent patch, after corresponding change in Chromium.
14:46 Changeset [45283] by beidson@apple.com

2009-06-26 Brady Eidson <beidson@apple.com>

Step 2 (new Mac results)

  • platform/mac/fast/images/favicon-as-image-expected.checksum: Added.
  • platform/mac/fast/images/favicon-as-image-expected.png: Added.
  • platform/mac/fast/images/favicon-as-image-expected.txt: Added.
14:44 Changeset [45282] by beidson@apple.com

2009-06-26 Brady Eidson <beidson@apple.com>

1st step of fixing the layout test I broke on Mac platforms.

  • platform/mac-leopard/fast/images/favicon-as-image-expected.checksum: Removed.
  • platform/mac-leopard/fast/images/favicon-as-image-expected.png: Removed.
  • platform/mac-leopard/fast/images/favicon-as-image-expected.txt: Removed.
  • platform/mac-tiger/fast/images/favicon-as-image-expected.checksum: Removed.
  • platform/mac-tiger/fast/images/favicon-as-image-expected.png: Removed.
  • platform/mac-tiger/fast/images/favicon-as-image-expected.txt: Removed.
  • platform/mac/fast/images/favicon-as-image-expected.checksum: Removed.
  • platform/mac/fast/images/favicon-as-image-expected.png: Removed.
  • platform/mac/fast/images/favicon-as-image-expected.txt: Removed.
  • platform/win/fast/images: Added.
  • platform/win/fast/images/favicon-as-image-expected.checksum: Copied from platform/mac/fast/images/favicon-as-image-expected.checksum.
  • platform/win/fast/images/favicon-as-image-expected.png: Copied from platform/mac/fast/images/favicon-as-image-expected.png.
  • platform/win/fast/images/favicon-as-image-expected.txt: Copied from platform/mac/fast/images/favicon-as-image-expected.txt.
14:01 Moving to Git edited by treat@kde.org
(diff)
13:51 Changeset [45281] by weinig@apple.com

2009-06-26 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Handle multiplying by zero a little better by
inlining the case that both operands are non-negative
into the slowpath.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::branchOr32):
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul):
13:49 Changeset [45280] by beidson@apple.com

2009-06-26 Brady Eidson <beidson@apple.com>

Fix SnowLeopard build.

  • Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::didReceiveResponse):
13:40 Changeset [45279] by mrowe@apple.com

Land updated results after the test change.

  • editing/selection/user-drag-element-and-user-select-none-expected.txt:
13:29 Changeset [45278] by jberlin@apple.com

2009-06-26 Jessie Berlin <jberlin@apple.com>

Fix: https://bugs.webkit.org/show_bug.cgi?id=26723
Where the m_mouseDown event was never being set on windows, so the
client X and Y coordinates were always being reported as zero in a
dragstart handler.


Reviewed by Mark Rowe.

Test: editing/selection/drag-start-event-client-x-y.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Set the m_mouseDown event when the mouse press is handled.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::mouseDown): Removed now redundant setting of m_mouseDown.


Layout test for making sure the client X Y coordinates of the event
in a dragstart handler are correct.


https://bugs.webkit.org/show_bug.cgi?id=26723

  • editing/selection/drag-start-event-client-x-y-expected.txt: Added.
  • editing/selection/drag-start-event-client-x-y.html: Added.
13:13 Changeset [45277] by beidson@apple.com

2009-06-26 Brady Eidson <beidson@apple.com>

Tiger build fix

  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/mac/WebCoreURLResponse.mm: (swizzleMIMETypeMethodIfNecessary):
12:43 Changeset [45276] by mrowe@apple.com

Fix user-drag-element-and-user-select-none.html to not rely on a bug in Mac DRT.

Reviewed by Sam Weinig.

  • editing/selection/user-drag-element-and-user-select-none.html:
12:38 Changeset [45275] by ap@webkit.org

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26681
Problem updating applicationCache when server returns 304


Improve the fix, make the test pass on Tiger.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): Fix another code path to remove the current item from list.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): On Tiger, conditional requests that cannot be cached by network layer cause errors with default cache policy.
12:23 Changeset [45274] by beidson@apple.com

WebCore:

2009-06-26 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails

When we disabled content sniffing for file urls we lost knowledge of many file extensions that we
didn't intend to lose. Turns out the CoreTypes UTI database doesn't know about every extension Gatekeeper
knew about.

By comparing CoreTypes' database to Gatekeepers, this patch adds a hardcoded list of file extension to MIME
type mappings that are missing in CoreType's database.

Test: platform/mac/fast/loader/file-url-mimetypes.html

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Move the MIME Type swizzling code to WebCoreURLResponse.
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): _webcore_MIMEType -> MIMEType, as we now have only one place where we do all MIMEType correction.
  • platform/network/mac/WebCoreURLResponse.h: Remove _webcore_MIMEType, as it is now folded into the swizzled implementation of MIMEType.
  • platform/network/mac/WebCoreURLResponse.mm: (createBinaryExtensionsSet): (createExtensionToMIMETypeMap): (swizzleMIMETypeMethodIfNecessary): (webNSURLResponseMIMEType): If it's a file URL and there's no MIME type, see if the extension exists in the extension -> MIME type map before turning to the default MIME type. Also roll in what was previously implemented in _webcore_MIMEType.
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::~SVGImage): Tweak this ASSERT - SVGImages might get destroyed without ever having a client.

WebKit/mac:

2009-06-26 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails

Replace all usage of the now obsolete [NSURLResponse _webcore_MIMEType].

  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::didReceiveResponse):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginView:receivedData:]):
  • Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
  • WebView/WebDataSource.mm: (-[WebDataSource _responseMIMEType]):
  • WebView/WebResource.mm: (-[WebResource _initWithData:URL:response:]):

WebKitTools:

2009-06-26 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails

Add a dumpResourceResponseMIMETypes() mode so the ResourceLoadDelegate will dump the mime type from
the NSURLResponse. Needed for the test for this bug fix.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpResourceResponseMIMETypesCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpResourceResponseMIMETypes): (LayoutTestController::setDumpResourceResponseMIMETypes):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):

LayoutTests:

2009-06-25 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails

Add a test file for each of file extensions we think WebKit on Mac should know the MIME type for.

  • platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
  • platform/mac/fast/loader/file-url-mimetypes.html: Added.
  • platform/mac/fast/loader/resources: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-3g2.3g2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-3gp.3gp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-3gp2.3gp2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-3gpp.3gpp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-Z.Z: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ac3.ac3: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ai.ai: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-aif.aif: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-aifc.aifc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-aiff.aiff: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-asc.asc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-asf.asf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-asx.asx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-au.au: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-avi.avi: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-bcpio.bcpio: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-bin.bin: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-bmp.bmp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-bz.bz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-bz2.bz2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cdf.cdf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-class.class: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cpgz.cpgz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cpio.cpio: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cpt.cpt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-crw.crw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-csh.csh: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-css.css: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dcr.dcr: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dif.dif: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dir.dir: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dll.dll: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dls.dls: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dmg.dmg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dms.dms: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-doc.doc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-docm.docm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-docx.docx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dotm.dotm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dotx.dotx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dv.dv: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dvi.dvi: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dxr.dxr: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-efx.efx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-eps.eps: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-etx.etx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-exe.exe: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ez.ez: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fdf.fdf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fla.fla: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fp.fp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fp2.fp2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fp3.fp3: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fp4.fp4: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fp5.fp5: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fp6.fp6: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fpx.fpx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-gif.gif: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-gtar.gtar: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-gz.gz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-gzip.gzip: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hdf.hdf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hqx.hqx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-htm.htm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-html.html: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ice.ice: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ico.ico: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ics.ics: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ief.ief: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-iges.iges: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-igs.igs: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-iso.iso: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-j2k.j2k: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jar.jar: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-javascript.javascript: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jhtml.jhtml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jnlp.jnlp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jp2.jp2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jpe.jpe: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jpeg.jpeg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jpf.jpf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jpg.jpg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jpx.jpx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-js.js: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jscript.jscript: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-kar.kar: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-latex.latex: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lha.lha: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lzh.lzh: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m15.m15: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m2v.m2v: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m3u.m3u: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m4p.m4p: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m75.m75: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mac.mac: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-man.man: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-me.me: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mesh.mesh: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mid.mid: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-midi.midi: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mif.mif: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mov.mov: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-movie.movie: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mp2.mp2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mp3.mp3: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mp4.mp4: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mpe.mpe: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mpeg.mpeg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mpg.mpg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mpga.mpga: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ms.ms: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-msh.msh: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mxu.mxu: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-nc.nc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-oda.oda: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-odc.odc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-odf.odf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-odg.odg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-odi.odi: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-odm.odm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-odp.odp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ods.ods: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-odt.odt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-otc.otc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-otf.otf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-otg.otg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-oth.oth: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-oti.oti: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-otp.otp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ots.ots: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ott.ott: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pbm.pbm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pct.pct: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pcx.pcx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pdb.pdb: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pdf.pdf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pgm.pgm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pgn.pgn: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ph3.ph3: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ph4.ph4: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-php.php: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-php3.php3: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-php4.php4: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-phtml.phtml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pic.pic: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pict.pict: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pl.pl: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pls.pls: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pm.pm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-png.png: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pnm.pnm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pnt.pnt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pntg.pntg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-potm.potm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-potx.potx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ppm.ppm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ppsm.ppsm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ppsx.ppsx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ppt.ppt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pptm.pptm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pptx.pptx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ps.ps: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-psd.psd: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-py.py: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-qif.qif: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-qt.qt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-qti.qti: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-qtif.qtif: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-qtz.qtz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ra.ra: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ram.ram: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ras.ras: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-rb.rb: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-rbw.rbw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-rgb.rgb: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-rm.rm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-roff.roff: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-rpm.rpm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-rtf.rtf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-rtx.rtx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sgi.sgi: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sgm.sgm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sgml.sgml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sh.sh: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-shar.shar: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-shtm.shtm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-shtml.shtml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-silo.silo: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sit.sit: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sitx.sitx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-skd.skd: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-skm.skm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-skp.skp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-skt.skt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-smf.smf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-smi.smi: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-smil.smil: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-snd.snd: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-so.so: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-spl.spl: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-src.src: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sv4cpio.sv4cpio: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sv4crc.sv4crc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-svg.svg: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-svgz.svgz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-swf.swf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-t.t: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tar.tar: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-targa.targa: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tcl.tcl: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tex.tex: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-texi.texi: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-texinfo.texinfo: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-text.text: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tga.tga: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tgz.tgz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tif.tif: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tiff.tiff: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-torrent.torrent: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tr.tr: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tsv.tsv: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-txt.txt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ustar.ustar: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-vcard.vcard: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-vcd.vcd: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-vcf.vcf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-vfw.vfw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-vrml.vrml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wav.wav: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wave.wave: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wax.wax: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wbmp.wbmp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wbxml.wbxml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-webarchive.webarchive: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wm.wm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wma.wma: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wmd.wmd: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wml.wml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wmlc.wmlc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wmls.wmls: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wmlsc.wmlsc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wmp.wmp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wmv.wmv: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wmx.wmx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wrl.wrl: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-wvx.wvx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xbm.xbm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xdp.xdp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xfd.xfd: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xfdf.xfdf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xht.xht: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xhtm.xhtm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xhtml.xhtml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xls.xls: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xlsb.xlsb: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xlsm.xlsm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xlsx.xlsx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xltm.xltm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xltx.xltx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xml.xml: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xpm.xpm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xsl.xsl: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xwd.xwd: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-xyz.xyz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-zip.zip: Added.
11:28 Changeset [45273] by simon.fraser@apple.com

2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Show the fullscreen button only if the backend has support for it.

https://bugs.webkit.org/show_bug.cgi?id=26661

No test since this is not reachable via the DOM.

  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::supportsFullscreen): new
  • html/HTMLVideoElement.h: (WebCore::HTMLVideoElement::supportsFullscreen): new
  • platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::supportsFullscreen): new (WebCore::MediaPlayer::supportsFullscreen): new
  • platform/graphics/MediaPlayer.h: new
  • platform/graphics/MediaPlayerPrivate.h: new (WebCore::MediaPlayerPrivateInterface::supportsFullscreen): new
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlFullscreenButtonElement::rendererIsNeeded): new
  • rendering/MediaControlElements.h:
11:02 Changeset [45272] by simon.fraser@apple.com

2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7007776> Controller doesn't automatically update counters when file
is playing ( http://www.jazzguitar.be/mp3/Michael%20Lewis%20-%20SSSJ.mp3 )

Update the time display when the movie time changes.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):
11:00 Changeset [45271] by simon.fraser@apple.com

2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26659

Support hidding a control bar element from the Media element controller.

Update layout tests since the fullscreen button no longer has a renderer.

  • rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::update): call updateStyle() so everything is updated properly. (WebCore::MediaControlInputElement::MediaControlInputElement): (WebCore::MediaControlInputElement::update): call updateStyle() (WebCore::MediaControlInputElement::updateStyle): create the renderer properly or not depending on what rendererIsNeeded() return.
  • rendering/MediaControlElements.h:
10:48 Changeset [45270] by kmccullough@apple.com

2009-06-26 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6968137> Profiler title numbers increment even after a
reload.

  • Now the numbers are reset when the profiles are.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
10:36 Changeset [45269] by eric@webkit.org

2009-06-26 Eric Seidel <eric@webkit.org>

No review, only rolling out r45259.

Roll out r45259 after crash appeared on the bots:
plugins/undefined-property-crash.html
ASSERTION FAILED: s <= HeapConstants<heapType>::cellSize
(leopard-intel-debug-tests/build/JavaScriptCore/runtime/Collector.cpp:278
void* JSC::Heap::heapAllocate(size_t) [with JSC::HeapType heapType = PrimaryHeap])

  • runtime/DateInstance.cpp:
  • runtime/Identifier.cpp:
  • runtime/Lookup.h:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpObject.h:
  • runtime/ScopeChain.h:
  • runtime/UString.h:
10:17 Changeset [45268] by ddkilzer@apple.com

Update build-dumprendertree to use buildXCodeProject()

Reviewed by Adam Roben.

  • Scripts/build-dumprendertree: Updated to use buildXCodeProject() when building for isAppleMacWebKit(). This provides additional command-line switch parsing for free. Also added --clean and --help switches. Updated copyright.
10:07 Changeset [45267] by cmarrin@apple.com

got rid of cruft accidentally left in from my last commit

09:53 Changeset [45266] by adele@apple.com

WebCore:

2009-06-26 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/7000796>
REGRESSION(34681): Breaking up quoted text makes new, unquoted text blue after certain steps; repros with some messages

Test: editing/inserting/break-blockquote-after-delete.html

Keep track of whether the typing style should be preserved after the TypingCommand is applied. When adding onto an open
typing command, keep that flag up to date.

In this case, an InsertParagraphSeparatorInQuotedContent command, which should not preserve typing style,
was following an open Delete command, which does preserve the typing style. So we were applying the original
typing style (from before the delete, so blue text) to the cursor in the unquoted area after breaking up the blockquote.

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::typingAddedToOpenCommand): (WebCore::TypingCommand::insertTextRunWithoutNewlines): (WebCore::TypingCommand::insertLineBreak): (WebCore::TypingCommand::insertParagraphSeparator): (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::deleteSelection): (WebCore::TypingCommand::updatePreservesTypingStyle):
  • editing/TypingCommand.h: (WebCore::TypingCommand::preservesTypingStyle):

LayoutTests:

2009-06-26 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Test for <rdar://problem/7000796>
REGRESSION(34681): Breaking up quoted text makes new, unquoted text blue after certain steps; repros with some messages

  • editing/inserting/break-blockquote-after-delete.html: Added.
  • platform/mac/editing/inserting/break-blockquote-after-delete-expected.checksum: Added.
  • platform/mac/editing/inserting/break-blockquote-after-delete-expected.png: Added.
  • platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt: Added.
09:30 Changeset [45265] by hausmann@webkit.org

2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Add support for saving and loading of QWebHistory to and from a QByteArray.

This includes streaming operators for QWebHistory. for convenience.

New autotests that test QWebHistory and QWebHistoryItem serialization.

09:29 Changeset [45264] by hausmann@webkit.org

2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Fix the behaviour of QWebHistory::itemAt to interpret the specified index as absolute index.

Returns an invalid QWebHistoryItem if the index is out of range.

09:29 Changeset [45263] by hausmann@webkit.org

2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Added a few autotest to QWebHistory.

09:29 Changeset [45262] by hausmann@webkit.org

JavaScriptCore:

2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Add support for QDataStream operators to Vector.

WebCore:

2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Add support for QDataStream operators to String and IntPoint.

09:27 Changeset [45261] by darin@chromium.org

2009-06-26 Ben Murdoch <benm@google.com>

Reviewed by Darin Fisher.

Add #if ENABLE(DOM_STORAGE) to the V8 custom bindings for local/session storage.
https://bugs.webkit.org/show_bug.cgi?id=26757

  • bindings/v8/custom/V8StorageCustom.cpp
09:27 Changeset [45260] by hausmann@webkit.org

2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Fix support for documenting functions prefixed with QWEBKIT_EXPORT

Add QWEBKIT_EXPORT to the list of macros to ignore by qdoc.

03:27 Changeset [45259] by eric@webkit.org

2009-06-26 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26750

Allow custom memory allocation control for JavaScriptCore/runtime
directory's classes which instantiated by new:

class IdentifierTable
struct RegExpObjectData
class HashEntry
struct DataInstance::Cache
class UString
struct RegExpConstructorPrivate
class ScopeChain

  • runtime/DateInstance.cpp:
  • runtime/Identifier.cpp:
  • runtime/Lookup.h:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpObject.h:
  • runtime/ScopeChain.h:
  • runtime/UString.h:
03:07 Changeset [45258] by eric@webkit.org

2009-06-26 Eric Seidel <eric@webkit.org>

Reviewed by Tor Arne Vestbø.

Remove non-sense --update option to land-patches
and make land-patches update before every patch application.
This makes it slightly less likely that multi-patch landings will fail.

Also updated git diff command to include staged modifications.

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
03:06 Changeset [45257] by eric@webkit.org

2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Eric Seidel.

Bug 20303: [Qt] Key events are not working in frames.

Add a layout test to test the event is sent to the right sub-frame.

  • platform/qt/fast/events/event-sender-keydown-frame-expected.txt: Added.
  • platform/qt/fast/events/event-sender-keydown-frame.html: Added.

2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Eric Seidel.

Test: platform/qt/fast/events/event-sender-keydown-frame.html

Bug 20303: [Qt] Key events are not working in frames.

Merge scrolling handling code in qt and win port, move it to
EventHandler.

  • page/EventHandler.cpp: (WebCore::EventHandler::scrollRecursively):
  • page/EventHandler.h:

2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Eric Seidel.

Bug 20303: [Qt] Key events are not working in frames.

Send scrolling events to current focused frame, bubble the event
up to parent frame if it is not handled. Use EventHandler's new
shared scrolling code.

  • Api/qwebpage.cpp: (QWebPagePrivate::keyPressEvent): (QWebPagePrivate::handleScrolling):
  • Api/qwebpage_p.h:

2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Eric Seidel.

Bug 20303: [Qt] Key events are not working in frames.

Move the scroll handling code to EventHandler so that other
ports can share the functionality.

  • WebView.cpp: (WebView::keyDown): (EnumTextMatches::QueryInterface):
02:42 Changeset [45256] by rwlbuis@webkit.org

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26682
Bug 26682: It should be possible to add image to SVG DOM programmatically (using JavaScript)

Make sure the xlink:href animated property setting syncs the corresponding attribute with the right namespace.

Test: svg/custom/createImageElement.svg

02:36 Changeset [45255] by eric@webkit.org

2009-06-26 Takeshi Yoshino <tyoshino@google.com>

Reviewed by Timothy Hatcher.

Bug 26156: In view-source mode, always render the contents using HTMLViewSourceDocument
https://bugs.webkit.org/show_bug.cgi?id=26156

When in view-source mode, render the contents using HTMLViewSourceDocument
regardless it's applicable for any plugin or not.

Chromium tells WebCore to render the contents of specified URL when
view-source: prefix is added to the URL. But currently, DOMImplementation
ignores inViewSourceMode() when the MIME type is indicating that the contents
are neither texts nor HTML family documents.

For example, we can check the contents of asf file without launching media
player. Rendering contents for view-source:-specified input is not what user
expects.

http://code.google.com/p/chromium/issues/detail?id=10545

I want to fix this issue by this patch. IMHO, regardless of this Chromium
specific issue, I think we should force use of HTMLViewSourceDocument when
inViewSourceMode() is specified.

  • fast/frames/resources/viewsource-fake-image-file.png: Added.
  • fast/frames/viewsource-on-image-file.html: Added.
  • platform/mac/fast/frames/viewsource-on-image-file-expected.txt: Added.

2009-06-26 Takeshi Yoshino <tyoshino@google.com>

Reviewed by Timothy Hatcher.

Bug 26156: In view-source mode, always render the contents using HTMLViewSourceDocument
https://bugs.webkit.org/show_bug.cgi?id=26156

When in view-source mode, render the contents using HTMLViewSourceDocument
regardless it's applicable for any plugin or not.

Chromium tells WebCore to render the contents of specified URL when
view-source: prefix is added to the URL. But currently, DOMImplementation
ignores inViewSourceMode() when the MIME type is indicating that the contents
are neither texts nor HTML family documents.

For example, we can check the contents of asf file without launching media
player. Rendering contents for view-source:-specified input is not what user
expects.

http://code.google.com/p/chromium/issues/detail?id=10545

I want to fix this issue by this patch. IMHO, regardless of this Chromium
specific issue, I think we should force use of HTMLViewSourceDocument when
inViewSourceMode() is specified.

Test: fast/frames/viewsource-on-image-file.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer):
  • html/HTMLViewSourceDocument.h:
02:25 Changeset [45254] by ap@webkit.org

Reviewed by Sam Weinig.

<rdar://problem/6651201> Update lookalike character list.

  • Misc/WebNSURLExtras.mm: (isLookalikeCharacter): Added more characters to the list.
02:20 Changeset [45253] by eric@webkit.org

2009-06-26 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

Add an additional test for bug 23786 (mistreatment of CR/LF
as zero-width characters in Chromium port). Tests using Bidi text were
added when the fix was checked in. Without the patch, Chromium used
to fail the same way with LTR complex scripts as well. (that is,
CR and LF were treated as zero-width space). To prevent a potential
regression in the future, a new test with Hindi (a LTR complex script)
is added.

The expected results for Mac and Windows are added while this test
is added to Skipped file for gtk. I guess this test just needs
a new test result generated on gtk.

https://bugs.webkit.org/show_bug.cgi?id=25698

  • fast/text/international/hindi-whitespace.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/fast/text/international/hindi-whitespace-expected.checksum: Added.
  • platform/mac/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/mac/fast/text/international/hindi-whitespace-expected.txt: Added.
  • platform/win/fast/text/international/hindi-whitespace-expected.checksum: Added.
  • platform/win/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/win/fast/text/international/hindi-whitespace-expected.txt: Added.
02:12 Changeset [45252] by xan@webkit.org

2009-06-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25529
[Gtk] Expected states not exposed to assistive technologies

Add support for VISIBLE, EDITABLE and SENSITIVE states.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject):
01:40 Changeset [45251] by eric@webkit.org

2009-06-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

"Pointer to incomplete class type is not allowed" error with RVCT
https://bugs.webkit.org/show_bug.cgi?id=26721

Based on Norbert Leser's work.

  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • dom/Node.cpp: (WebCore::Node::dispatchMouseEvent):
  • dom/Node.h: Remove the default value for PassRefPtr<Event> args, to eliminate dependency on the Event class definition
01:32 Changeset [45250] by eric@webkit.org

2009-06-25 Eric Seidel <eric@webkit.org>

Reviewed by Jan Alonzo.

Fix obsolete_attachment to work when passed a comment.
https://bugs.webkit.org/show_bug.cgi?id=26745

  • Scripts/modules/bugzilla.py:
01:28 Changeset [45249] by eric@webkit.org

2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Mark Rowe.

bugzilla-tool apply-patch throws exception in Linux
https://bugs.webkit.org/show_bug.cgi?id=26738

HEAD is case-sensitive in Linux. Convert uses of head to HEAD in
the scm module.

  • Scripts/modules/scm.py:
00:58 Changeset [45248] by eric@webkit.org

2009-06-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Maciej Stachowiak.

[Qt] Build fix after r45183
https://bugs.webkit.org/show_bug.cgi?id=26748

  • WebCore.pro:

06/25/09:

21:44 Changeset [45247] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26681
<rdar://problem/7003461> Problem updating applicationCache when server returns 304

Test: http/tests/appcache/update-cache.html

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): We're already done with the resource, don't try to load it again.
21:21 Changeset [45246] by barraclough@apple.com

Fix up JavaScriptCore/ChangeLog, messed up slightly in the merge.

20:32 Changeset [45245] by simon.fraser@apple.com

2009-06-25 Simon Fraser <simon.fraser@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6990481>

Handle perspective computation on non-layer objects.

Test: transforms/3d/general/perspective-non-layer.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):
20:03 Changeset [45244] by barraclough@apple.com

Merged r45138:45243 into nitro-extreme branch.

19:56 Changeset [45243] by barraclough@apple.com

Merged r45137:45138 into nitro-extreme branch.

19:53 Changeset [45242] by barraclough@apple.com

Merged r45039:45137 into nitro-extreme branch.

19:47 Changeset [45241] by barraclough@apple.com

Merged r45038:45039 into nitro-extreme branch.

19:35 Changeset [45240] by barraclough@apple.com

Merged r45000:45038 into nitro-extreme branch.

19:32 Changeset [45239] by eric@webkit.org

2009-06-25 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/remove-list-1-expected.txt: Added.
  • editing/execCommand/remove-list-1.html:
  • editing/execCommand/remove-list-items-expected.txt: Added.
  • editing/execCommand/remove-list-items.html:
  • platform/mac/editing/execCommand/remove-list-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/remove-list-1-expected.png: Removed.
  • platform/mac/editing/execCommand/remove-list-1-expected.txt: Removed.
  • platform/mac/editing/execCommand/remove-list-items-expected.checksum: Removed.
  • platform/mac/editing/execCommand/remove-list-items-expected.png: Removed.
  • platform/mac/editing/execCommand/remove-list-items-expected.txt: Removed.
  • platform/qt/editing/execCommand/remove-list-1-expected.txt: Removed.
  • platform/qt/editing/execCommand/remove-list-items-expected.txt: Removed.
19:31 Changeset [45238] by barraclough@apple.com

Merged r44960:45000 into nitro-extreme branch.

19:20 Changeset [45237] by barraclough@apple.com

Merged r44943:44960 into nitro-extreme branch.

19:19 Changeset [45236] by simon.fraser@apple.com

2009-06-25 Simon Fraser <simon.fraser@apple.com>

Rubber-stamped by Eric Seidel

Update this test after the video controller changes.

  • platform/mac/fast/layers/video-layer-expected.txt:
19:13 Changeset [45235] by barraclough@apple.com

Merged r44942:44943 into nitro-extreme branch.

19:12 Changeset [45234] by jmalonzo@webkit.org

2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Not reviewed. Skip another failing test due to lack of eventSender impl.

  • platform/gtk/Skipped:
18:42 Changeset [45233] by barraclough@apple.com

Build fixes, mostly files not added.

18:38 Changeset [45232] by jmalonzo@webkit.org

2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Not reviewed. Skip failing gtk tests due to missing DRT features.

  • platform/gtk/Skipped:
18:28 Changeset [45231] by barraclough@apple.com

Build fixes, mostly files not added.

18:16 Changeset [45230] by simon.fraser@apple.com

2009-06-25 Simon Fraser <simon.fraser@apple.com>

Rubber-stamped by Dan Bernstein.

Add Windows-specific test results, since Windows does not have
3d transforms enabled.

  • platform/win/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/media/mq-transform-02-expected.txt.
  • platform/win/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/media/mq-transform-03-expected.txt.
18:08 Changeset [45229] by barraclough@apple.com

Build fix

18:06 Changeset [45228] by simon.fraser@apple.com

2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26653

Use flex box in the mediaControls.css style, to nicely scale if a button gets
dynamically added or removed.

Media tests results are affected by this changes.

  • css/mediaControls.css:
  • css/mediaControlsQT.css:
18:03 Changeset [45227] by simon.fraser@apple.com

2009-06-25 Simon Fraser <simon.fraser@apple.com>

Rubber-stamped by Mark Rowe.

<rdar://problem/6999737>

Update the media controller images.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
17:58 Changeset [45226] by barraclough@apple.com

Merged r44920:44942 into nitro-extreme branch.

17:50 Changeset [45225] by barraclough@apple.com

Merged r44889:44920 into nitro-extreme branch.

17:49 Changeset [45224] by eric@webkit.org

2009-06-25 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/5432254-2-expected.txt: Added.
  • editing/execCommand/5432254-2.html:
  • editing/execCommand/5700414-1-expected.txt: Added.
  • editing/execCommand/5700414-1.html:
  • editing/execCommand/5700414-2-expected.txt: Added.
  • editing/execCommand/5700414-2.html:
  • platform/mac/editing/execCommand/5432254-2-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5432254-2-expected.png: Removed.
  • platform/mac/editing/execCommand/5432254-2-expected.txt: Removed.
  • platform/mac/editing/execCommand/5700414-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5700414-1-expected.png: Removed.
  • platform/mac/editing/execCommand/5700414-1-expected.txt: Removed.
  • platform/mac/editing/execCommand/5700414-2-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5700414-2-expected.png: Removed.
  • platform/mac/editing/execCommand/5700414-2-expected.txt: Removed.
  • platform/qt/editing/execCommand/5432254-2-expected.txt: Removed.
17:34 Changeset [45223] by barraclough@apple.com

Merged r44888:44889 into nitro-extreme branch.

17:28 Changeset [45222] by barraclough@apple.com

Merged r44884:44888 into nitro-extreme branch.

17:26 Changeset [45221] by beidson@apple.com

2009-06-24 Brady Eidson <beidson@apple.com>

Reviewed by Mark Rowe

  • demos/index.html: Fix more typos etc.
17:24 Changeset [45220] by eric@webkit.org

2009-06-25 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Treat.

Add highlight functionality to the QWebPage::findText() method. Introduced is
new HighlightAllOccurrences flag which passed to the function will make it mark
all existing occurrences of specified string in the page.

  • Api/qwebpage.cpp: (QWebPage::findText):
  • Api/qwebpage.h:
  • Api/qwebview.cpp:
17:22 Changeset [45219] by jmalonzo@webkit.org

2009-06-25 Duy Nguyen <pclouds@gmail.com>

Rubber-stamped by Jan Alonzo.

Gtk port Vietnamese translation
https://bugs.webkit.org/show_bug.cgi?id=26739

  • vi.po: Added.
17:22 Changeset [45218] by barraclough@apple.com

Merged r44883:44884 into nitro-extreme branch.

17:16 Changeset [45217] by barraclough@apple.com

Merged r44844:44883 into nitro-extreme branch.

17:07 Changeset [45216] by barraclough@apple.com

Merged r44843:44844 into nitro-extreme branch.

16:58 Changeset [45215] by darin@chromium.org

2009-06-25 Albert J. Wong <ajwong@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26724

Move relavent part of setDefaultFontSize from RenderThemeChromiumWin
up into RenderThemeChromiumSkia.

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::setDefaultFontSize):
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::setDefaultFontSize):
  • rendering/RenderThemeChromiumWin.h:
16:54 Changeset [45214] by andersca@apple.com

2009-06-25 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6989017>
REGRESSION (SnowLeopard): RealPlayer content replays when opening a new tab or switching back to the RealPlayer tab


If a plug-in fails in NPP_New, we would try to recreate it whenever the preferences for a web view would change.


Fix this by setting a flag when we fail to instantiate the plug-in, so we only try once.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView start]):
16:49 Changeset [45213] by barraclough@apple.com

Merged r44838:44843 into nitro-extreme branch.

16:45 Changeset [45212] by ggaren@apple.com

2009-06-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Optimize x++ to ++x inside for loops.


Sadly, no measurable speedup, but this should help with result chaining.

  • parser/Nodes.cpp: (JSC::ForNode::emitBytecode):
16:39 Changeset [45211] by barraclough@apple.com

Merged r44837:44838 into nitro-extreme branch.

16:36 Changeset [45210] by jmalonzo@webkit.org

2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Mark Rowe.

bugzilla-tool apply-patch throws exception in Linux
https://bugs.webkit.org/show_bug.cgi?id=26738

HEAD is case-sensitive in Linux. Convert uses of head to HEAD in
the scm module.

  • Scripts/modules/scm.py:
16:24 Changeset [45209] by barraclough@apple.com

Merged r44796:44837 into nitro-extreme branch.

16:21 Changeset [45208] by darin@chromium.org

2009-06-25 Matt Perry <mpcomplete@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26733

Add V8-only methods to FrameLoaderClient that V8 can use to send
out notifications when it creates/destroys a script context.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didCreateScriptContext): (WebCore::EmptyFrameLoaderClient::didDestroyScriptContext):
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::didCreateScriptContext): (WebCore::FrameLoaderClient::didDestroyScriptContext):
16:11 Changeset [45207] by dglazkov@chromium.org

2009-06-25 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by David Levin.

Correct a few typos that snuck in when I was reformatting CodeGeneratorV8.pm
to match WebKit style.

  • bindings/scripts/CodeGeneratorV8.pm: Corrected lots of typos.
15:42 Changeset [45206] by barraclough@apple.com

Build fix, revert part of last build fix.

15:37 Changeset [45205] by ggaren@apple.com

2009-06-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_bitnot): (JSC::JIT::emit_op_post_inc):
15:35 Changeset [45204] by cmarrin@apple.com

Some cosmetic fixes I missed in my last checkin

15:32 Changeset [45203] by agl@chromium.org

2009-06-25 Adam Langley <agl@google.com>

TBRed: fix for Chromium tree.

Add missing include for r45199.

https://bugs.webkit.org/show_bug.cgi?id=26736

r45199 added a reference to throwError without including V8Proxy.h

  • bindings/v8/WorkerScriptController.cpp:
15:16 Changeset [45202] by barraclough@apple.com

Build fixes, mostly files not added.

15:13 Changeset [45201] by agl@chromium.org

2009-06-25 Adam Langley <agl@google.com>

TBRed: fix for Chromium tree.

https://bugs.webkit.org/show_bug.cgi?id=26735

Fix V8IsolatedWorld to point to the correct include file.

The deprecated v8_index.h was removed from the Chromium tree in r19291
and upstreamed into WebKit with r45193. However V8IsolatedWorld
slipped in between the cracks and broke the build.

  • bindings/v8/V8IsolatedWorld.h: update with new header location.
15:09 Changeset [45200] by ggaren@apple.com

2009-06-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emitSlow_op_pre_dec):
15:03 Changeset [45199] by cmarrin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=26651


Preference is named "WebKitAcceleratedCompositingEnabled"
and is a boolean value. When false, prevents compositing layers from
being created, which prevents hardware animation from running.
Also forces video to do software rendering. Added a cache for
the flag in RenderLayerCompositing and made it all work
on-the-fly when the flag is changed while a page is loaded.

14:54 Changeset [45198] by jianli@chromium.org

2009-06-25 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 26701: Implement the missing code for "FIXME: Need to return an
exception" in WorkerScriptController::evaluate for v8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=26701

  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
14:52 Changeset [45197] by eric@webkit.org

2009-06-25 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

Call WebKitTools/Scripts scripts by their absolute paths
https://bugs.webkit.org/show_bug.cgi?id=26704

bugzilla-tool used to use whatever build-webkit was in your path.
That could end up building the wrong copy of WebKit.

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
14:51 Changeset [45196] by sfalken@apple.com

New tag.

14:44 Changeset [45195] by sfalken@apple.com

2009-06-24 Mark Rowe <mrowe@apple.com>

Merge r44117.

2009-05-24 Steve Falkenburg <sfalken@apple.com>

Build fix for experimental PGO Windows target.


14:42 Changeset [45194] by ggaren@apple.com

2009-06-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emitSlow_op_negate):
  • jit/JITCall.cpp: (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emitSlow_op_construct_verify):
14:39 Changeset [45193] by japhet@chromium.org

2009-06-25 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream V8Index.

https://bugs.webkit.org/show_bug.cgi?id=26495

  • bindings/v8/V8Index.cpp: Added. (WebCore::V8ClassIndex::GetFactory): Moved from src.chromium.org. (WebCore::V8ClassIndex::GetCache): Moved from src.chromium.org.
  • bindings/v8/V8Index.h: (WebCore::V8ClassIndex::): Moved from src.chromium.org. (WebCore::V8ClassIndex::ToInt): Moved from src.chromium.org. (WebCore::V8ClassIndex::FromInt): Moved from src.chromium.org.
14:26 Changeset [45192] by eric@webkit.org

2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Dave Levin.

Use unicode() instead of str when reading from bugzilla.
Also add Simon Fraser as a reviewer.
https://bugs.webkit.org/show_bug.cgi?id=26719

  • Scripts/modules/bugzilla.py:
14:15 Changeset [45191] by agl@chromium.org

2009-06-25 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26529

This is hopefully the last step before our renderers can run
cleanly in a chroot.

WebKit needs to be able to ask for the correct font to use in
the case that the current font doesn't include glyphs for
certain code points. Currently we make a fontconfig call in our
WebKit port to handle this.

This patch changes this so that the call is sent our via
ChromiumBridge.

http://codereview.chromium.org/132007

This should not affect any layout tests.

  • platform/chromium/ChromiumBridge.h:
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
14:02 Changeset [45190] by ggaren@apple.com

2009-06-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_true): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null):
13:34 Changeset [45189] by levin@chromium.org

2009-06-25 Albert J. Wong <ajwong@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26566
Upstream these files from the chromium v8 code. No tests were
affected because this is essentially a code move.

  • bindings/v8/NPV8Object.cpp: Added. (allocV8NPObject): (freeV8NPObject): (listFromVariantArgs): (npIdentifierToV8Identifier): (npCreateV8ScriptObject): (NPN_Invoke): (NPN_InvokeDefault): (NPN_Evaluate): (NPN_EvaluateHelper): (NPN_GetProperty): (NPN_SetProperty): (NPN_RemoveProperty): (NPN_HasProperty): (NPN_HasMethod): (NPN_SetException): (NPN_Enumerate): (NPN_Construct):
  • bindings/v8/NPV8Object.h: Added. (PrivateIdentifier::):
  • bindings/v8/V8NPUtils.cpp: Added. (convertV8ObjectToNPVariant): (convertNPVariantToV8Object): (getStringIdentifier):
  • bindings/v8/V8NPUtils.h: Added.
13:34 Changeset [45188] by levin@chromium.org

WebCore:

2009-06-25 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26436

Windows Chromium bug fix: save context of destination canvas in
TransparencyWin::compositeTextComposite() before the function
modifies the context.

Test: fast/canvas/translate-text.html

  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::compositeTextComposite):

LayoutTests:

2009-06-25 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26436

Windows Chromium bug fix: save context of destination canvas in
TransparencyWin::compositeTextComposite() before the function
modifies the context.

  • fast/canvas/resources/translate-text.js: Added. (description.pixelValueAt): (pixelToString): (pixelShouldBe):
  • fast/canvas/translate-text-expected.txt: Added.
  • fast/canvas/translate-text.html: Added.
13:34 Changeset [45187] by levin@chromium.org

2009-06-25 Takeshi Yoshino <tyoshino@google.com>

Reviewed by David Levin.

Bug 26207: Rebaseline the expected image for fast/forms/select-style.html for Mac.
https://bugs.webkit.org/show_bug.cgi?id=26207

Replace the expected image for fast/forms/select-style-expected.html for
Mac which need to be rebaselined due to r43903
(http://trac.webkit.org/changeset/43903).

  • platform/mac/fast/forms/select-style-expected.png:
13:34 Changeset [45186] by levin@chromium.org

2009-06-25 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Show the filename and first line for "(program)" in the Profiler/Debugger
https://bugs.webkit.org/show_bug.cgi?id=25475

Add support to associate a sourceURL with an eval()'d string
via a @sourceURL comment. Currently the sourceURL is only available
in the script debugger, not in the console or profiler, but it's
most needed in the script debugger.

  • English.lproj/localizedStrings.js: added new "(program): %s" string
  • inspector/front-end/Script.js: (WebInspector.Script): if no sourceURL is available for the Script, search for a comment of the form @ sourceURL=(url) to use as the sourceURL instead.
  • manual-tests/inspector/named-evals.html: Added.
13:34 Changeset [45185] by levin@chromium.org

WebCore:

2009-06-25 John Gregg <johnnyg@google.com>

Reviewed by Sam Weinig.

Bug 23721: Changing dropdown's selectedIndex within onchange handler fires another onchange
https://bugs.webkit.org/show_bug.cgi?id=23721

onchange events fire when a SELECT element has
focus and the selectedIndex is updated by script in some way--either
during another onchange, onkeypress, onfocus, or timer--and then
focus is lost.

Fixed by making a separate method for user-driven selectedIndex
changes, leaving scripts to use one which doesn't cause onchange to
be queued.

Test: fast/forms/select-script-onchange.html

  • dom/SelectElement.cpp: check if the pending change is user driven before calling onchange (WebCore::SelectElement::menuListOnChange): (WebCore::SelectElement::setSelectedIndex):
  • dom/SelectElement.h: store whether the pending change is user driven (WebCore::SelectElementData::userDrivenChange): (WebCore::SelectElementData::setUserDrivenChange):
  • html/HTMLSelectElement.cpp: split into two methods -- script version [non-user-driven] corresponds to IDL defined property name (WebCore::HTMLSelectElement::setSelectedIndex): (WebCore::HTMLSelectElement::setSelectedIndexByUser):
  • html/HTMLSelectElement.h:
  • rendering/RenderMenuList.cpp: use ByUser method when coming through the renderer (WebCore::RenderMenuList::valueChanged):

LayoutTests:

2009-06-25 John Gregg <johnnyg@google.com>

Reviewed by Sam Weinig.

Bug 23721: Changing dropdown's selectedIndex within onchange handler fires another onchange
https://bugs.webkit.org/show_bug.cgi?id=23721

Check for unnecessary calls to onchange in response to script
actions.

  • fast/forms/select-script-onchange-expected.txt: Added.
  • fast/forms/select-script-onchange.html: Added.
13:10 Changeset [45184] by mrowe@apple.com

Versioning.

13:02 Changeset [45183] by darin@chromium.org

2009-06-25 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26698

Combined LocalStorageArea and SessionStorageArea into StorageArea since
(after my other refactorings) there are no longer substantial
differences between the two.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea):
  • storage/LocalStorage.h:
  • storage/LocalStorageArea.cpp: Removed.
  • storage/LocalStorageArea.h: Removed.
  • storage/SessionStorage.cpp: (WebCore::SessionStorage::copy): (WebCore::SessionStorage::storageArea):
  • storage/SessionStorage.h:
  • storage/SessionStorageArea.cpp: Removed.
  • storage/SessionStorageArea.h: Removed.
  • storage/StorageArea.cpp: (WebCore::StorageArea::createLocalStorage): (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::createSessionStorage): (WebCore::StorageArea::copy): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear): (WebCore::StorageArea::scheduleFinalSync): (WebCore::StorageArea::blockUntilImportComplete): (WebCore::StorageArea::dispatchStorageEvent):
  • storage/StorageArea.h:
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::scheduleFinalSync): (WebCore::StorageAreaSync::syncTimerFired): (WebCore::StorageAreaSync::performImport):
  • storage/StorageAreaSync.h:
  • storage/StorageSyncManager.h:
12:50 Changeset [45182] by mrowe@apple.com

Versioning.

12:48 Changeset [45181] by mrowe@apple.com

New tag.

12:45 Changeset [45180] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

Test: fast/dom/style-sheet-candidate-remove-unrendered-document.html

When a "style sheet candidate" element is removed from a document,
call Document::removeStyleSheetCandidateNode() regardless of whether
the document is rendered. Otherwise, the document's style sheet
candidate set can end up containing stale references.

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::removedFromDocument):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::removedFromDocument):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::removedFromDocument):

LayoutTests:

Reviewed by Darin Adler.

  • fast/dom/style-sheet-candidate-remove-unrendered-document-expected.txt: Added.
  • fast/dom/style-sheet-candidate-remove-unrendered-document.html: Added.
11:53 Changeset [45179] by dglazkov@chromium.org

2009-06-25 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

Update CodeGeneratorV8.pm to sync up with the changes downstream.

  • bindings/scripts/CodeGeneratorV8.pm: Added HTMLFrameSetElement check, FileList as a ref-counted type, and DataGridColumn as typeCanFailConversion.
11:14 Changeset [45178] by rwlbuis@webkit.org

Credit the correct reviewer.

10:23 Changeset [45177] by ggaren@apple.com

2009-06-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig (sort of, maybe).


Fixed some ASSERTs in http/tests/security.


These ASSERTs were introduced by http://trac.webkit.org/changeset/45057,
but the underlying problem was actually older. http://trac.webkit.org/changeset/45057
just exposed the problem by enabling optimization in more cases.


The ASSERTs fired because we tested PropertySlot::slotBase() for validity,
but slotBase() ASSERTs if it's invalid, so we would ASSERT before
the test could happen. Solution: Remove the ASSERT. Maybe it was valid
once, but it clearly goes against a pattern we've deployed of late.


The underlying problem was that WebCore would re-use a PropertySlot in
the case of a forwarding access, and the second use would not completely
overwrite the first use. Solution: Make sure to overwrite m_offset when
setting a value on a PropertySlot. (Other values already get implicitly
overwritten during reuse.)

  • runtime/PropertySlot.h: (JSC::PropertySlot::PropertySlot): (JSC::PropertySlot::setValueSlot): (JSC::PropertySlot::setValue): (JSC::PropertySlot::setRegisterSlot): (JSC::PropertySlot::setUndefined): (JSC::PropertySlot::slotBase): (JSC::PropertySlot::clearOffset):
09:08 ProjectVision edited by treat@kde.org
(diff)
09:03 QtWebKit edited by treat@kde.org
(diff)
09:00 QtWebKitContrib edited by treat@kde.org
(diff)
08:54 QtWebKitGitInstructions edited by treat@kde.org
(diff)
08:50 Changeset [45176] by dglazkov@chromium.org

2009-06-25 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

Add FileList.h include to fix Chromium build.

  • platform/chromium/ClipboardChromium.cpp: Added FileList.h include.
08:48 UsingGitWithWebKit edited by treat@kde.org
(diff)
08:46 UsingGitWithWebKit edited by treat@kde.org
(diff)
08:46 UsingGitWithWebKit edited by treat@kde.org
(diff)
08:37 UsingGitWithWebKit edited by treat@kde.org
Make this more explicit. (diff)
06:14 Changeset [45175] by vestbo@webkit.org

2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Use Q_ASSERT in Qt's DumpRenderTree instead of JSC's ASSERT

The WTFReportAssertionFailure function in JSC is not exported when
building QtWebKit in both debug and release on Mac, so DRT fails to
link.

We can revert this patch once the Qt port builds JSC as a separate
library, and we add the proper export macros to Assertions.cpp

  • DumpRenderTree/qt/WorkQueue.cpp: (WorkQueue::queue): (WorkQueue::dequeue):
06:11 Changeset [45174] by vestbo@webkit.org

2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Jan Alonzo.

bugzilla-tool: Add Simon Hausmann as reviewer

  • Scripts/modules/bugzilla.py:
05:42 Changeset [45173] by jmalonzo@webkit.org

2009-06-25 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Jan Alonzo.

Bug 26489: Web Inspector: Typo in DatabaseQuery Error Message
https://bugs.webkit.org/show_bug.cgi?id=26489

Fixed a Typo in a Web Inspector error message.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryError):
04:11 Changeset [45172] by hausmann@webkit.org

2009-06-25 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Qt build, add missing StorageAreaSync files to the build.

  • WebCore.pro:
03:56 Changeset [45171] by hausmann@webkit.org

2009-06-25 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by and done with Tor Arne Vestbø.

Fix shortcut keyboard handling with plugins on the Qt/Mac build.

When we receive shortcut events like Ctrl+V then the text in the QKeyEvent is
empty. If we're asked to disambiguate the event into a Char keyboard event,
we try to detect this situation and still set the text, to ensure that the
general event handling sends a key press event after this disambiguation.

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
03:05 Changeset [45170] by eric@webkit.org

2009-06-25 Eric Seidel <eric@webkit.org>

No review, just skipping a new test.

Skip new test on platforms missing eventSender.beginDragWithFiles
Test: http/tests/security/clipboard/clipboard-file-access.html
https://bugs.webkit.org/show_bug.cgi?id=25916

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
02:49 Changeset [45169] by eric@webkit.org

2009-06-25 Eric Seidel <eric@webkit.org>

Build fix only, no review.

Add FileList.h and NotImplemented.h includes in an attempt to fix bots.

  • platform/gtk/ClipboardGtk.cpp:
  • platform/qt/ClipboardQt.cpp:
  • platform/win/ClipboardWin.cpp:
  • platform/wx/ClipboardWx.cpp:
02:24 Changeset [45168] by eric@webkit.org

2009-06-24 Dan Bernstein <mitz@apple.com>

Reviewed by Simon Fraser.

  • test for <rdar://problem/7001817> REGRESSION (r41902): Base position track at UCSC Genome Browser doesn't work because image map prevents img from hit-testing
  • fast/replaced/image-map-2-expected.txt: Added.
  • fast/replaced/image-map-2.html: Added.

2009-05-21 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

Expose files in the clipboard in ondrop events
https://bugs.webkit.org/show_bug.cgi?id=25916

Make it possible for applications like gmail to implement
drag and drop of attachments onto email messages.

This patch exposes an event.dataTransfer.files accessor
on the drop event. No information is exposed during dragover.
This follows the HTML 5 drag and drop security model:
http://www.w3.org/TR/html5/editing.html#security-risks-in-the-drag-and-drop-model
The test http/tests/security/clipboard/clipboard-file-access.html
verifies this behavior.

Internet Explorer shows historical documentation of supporting
getData('File') as a way of exposing files on the pasteboard. The current version of their docs:
http://msdn.microsoft.com/en-us/library/ms537658(VS.85).aspx
has removed this reference (as far as I can tell IE never implemented it)
I have a printed copy of that URL from 2008 on my desk describing getData('File') in IE.
IE does not follow the HTML5 clipboard security model and always allows access to the full clipboard, even on dragover.

I choose not to use IE's getData('File') and instead added .files
so that the accessor could have a type, matching WebKit's existing
.files accessor on HTMLInputElement.

Mozilla has equivalent file access:
event.dataTransfer.mozGetDataAt("application/x-moz-file", 0);
which also does not return a typed value.
https://developer.mozilla.org/En/DragDrop/Recommended_Drag_Types#Dragging_Files

This is only implemented for Mac WebKit. All other platforms (including Apple's Win WebKit)
have incomplete Clipboard implementations and will require experts from those platforms
to add this functionality. Right now they all have Clipboard*::files() methods which call notImplemented();

Test: http/tests/security/clipboard/clipboard-file-access.html

  • dom/Clipboard.h:
  • dom/Clipboard.idl:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::files):
  • platform/chromium/ClipboardChromium.h:
  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::files):
  • platform/gtk/ClipboardGtk.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::absoluteURLsFromPasteboardFilenames): (WebCore::absoluteURLsFromPasteboard): (WebCore::ClipboardMac::files):
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::files):
  • platform/qt/ClipboardQt.h:
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::files):
  • platform/win/ClipboardWin.h:
  • platform/wx/ClipboardWx.cpp: (WebCore::ClipboardWx::files):
  • platform/wx/ClipboardWx.h:
01:51 Changeset [45167] by barraclough@apple.com

Merged r44794:44796 into nitro-extreme branch.

01:41 Changeset [45166] by barraclough@apple.com

Merged r44747:44794 into nitro-extreme branch.

01:27 Changeset [45165] by eric@webkit.org

2009-06-25 Eric Seidel <eric@webkit.org>

No review, only completing revert of r45144.

Add back files deleted by r45144.

  • storage/LocalStorageArea.cpp: Added. (WebCore::LocalStorageArea::create): (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::scheduleFinalSync): (WebCore::LocalStorageArea::itemChanged): (WebCore::LocalStorageArea::itemRemoved): (WebCore::LocalStorageArea::areaCleared): (WebCore::LocalStorageArea::blockUntilImportComplete): (WebCore::LocalStorageArea::dispatchStorageEvent):
  • storage/LocalStorageArea.h: Added.
  • storage/SessionStorageArea.cpp: Added. (WebCore::SessionStorageArea::copy): (WebCore::SessionStorageArea::SessionStorageArea): (WebCore::SessionStorageArea::itemChanged): (WebCore::SessionStorageArea::itemRemoved): (WebCore::SessionStorageArea::areaCleared): (WebCore::SessionStorageArea::blockUntilImportComplete): (WebCore::SessionStorageArea::dispatchStorageEvent):
  • storage/SessionStorageArea.h: Added. (WebCore::SessionStorageArea::create):
01:26 Changeset [45164] by barraclough@apple.com

Merged r44743:44747 into nitro-extreme branch.

01:22 Changeset [45163] by barraclough@apple.com

Merged r44742:44743 into nitro-extreme branch.

01:19 Changeset [45162] by eric@webkit.org

2009-06-25 Eric Seidel <eric@webkit.org>

No review, reverting r45144 only.

Roll out r45144 after 18 test failures appeared on the bots.
https://bugs.webkit.org/show_bug.cgi?id=26698

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea):
  • storage/LocalStorage.h:
  • storage/SessionStorage.cpp: (WebCore::SessionStorage::copy): (WebCore::SessionStorage::storageArea):
  • storage/SessionStorage.h:
  • storage/StorageArea.cpp: (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::~StorageArea): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear):
  • storage/StorageArea.h:
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::scheduleFinalSync): (WebCore::StorageAreaSync::syncTimerFired): (WebCore::StorageAreaSync::performImport):
  • storage/StorageAreaSync.h:
  • storage/StorageSyncManager.h:
01:17 Changeset [45161] by barraclough@apple.com

Merged r44712:44742 into nitro-extreme branch.

01:09 Changeset [45160] by eric@webkit.org

2009-06-24 Eric Seidel <eric@webkit.org>

Reviewed by Dave Levin.

Support local commits during apply-patches
and let land-patches take multiple bug ids.
https://bugs.webkit.org/show_bug.cgi?id=26703

I also restructured parts of land-patches into
class methods and static methods in preparation
for future code sharing with other commands.

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
  • Scripts/modules/scm.py:
01:09 Changeset [45159] by barraclough@apple.com

Merged r44710:44712 into nitro-extreme branch.

01:03 Changeset [45158] by barraclough@apple.com

Merged r44705:44710 into nitro-extreme branch.

01:01 Changeset [45157] by barraclough@apple.com

Merged r44704:44705 into nitro-extreme branch.

00:56 Changeset [45156] by barraclough@apple.com

Build-fix, had failed to add JSONObject.cpp/.h.

00:52 Changeset [45155] by barraclough@apple.com

Merged r44700:44704 into nitro-extreme branch.

00:49 Changeset [45154] by barraclough@apple.com

Merged r44699:44700 into nitro-extreme branch.

00:45 Changeset [45153] by eric@webkit.org

2009-06-25 Eric Seidel <eric@webkit.org>

Reviewed by Tor Arne Vestbø.

Make svn-apply work with Git too
https://bugs.webkit.org/show_bug.cgi?id=26299

Add an --force option to svn-apply and otherwise make svn-apply
exit non-zero when patch application fails.
https://bugs.webkit.org/show_bug.cgi?id=26300

I did not update svn-unapply, because it makes no sense in a Git world.
You don't roll in and out patch files. You make commits and deal with those.
Git users can just git reset --hard to get the same functionality.

  • Scripts/svn-apply:
00:42 Changeset [45152] by eric@webkit.org

2009-06-25 Eric Seidel <eric@webkit.org>

Reviewed by Tor Arne Vestbø.

Remove use of os.system to fix reviewers with unicode chars in their names
https://bugs.webkit.org/show_bug.cgi?id=26713

Also change to latin1 encoding of ø to make python happy.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/scm.py:
00:42 Changeset [45151] by barraclough@apple.com

Merged r44693:44699 into nitro-extreme branch.

00:34 Changeset [45150] by barraclough@apple.com

Merged r44692:44693 into nitro-extreme branch.

00:22 Changeset [45149] by barraclough@apple.com

Merged r44526:44692 into nitro-extreme branch.

00:07 Changeset [45148] by barraclough@apple.com

Merged r44525:44526 into nitro-extreme branch.

00:06 Changeset [45147] by eric@webkit.org

2009-06-25 Eric Seidel <eric@webkit.org>

Reviewed by Tor Arne Vestbø.

Add Adam Roben and Tor Arne Vestbø to the reviewers list.

  • Scripts/modules/bugzilla.py:
00:00 Changeset [45146] by barraclough@apple.com

Merged r44523:44525 into nitro-extreme branch.

06/24/09:

23:56 Changeset [45145] by barraclough@apple.com

Merged r44520:44523 into nitro-extreme branch.

23:16 Changeset [45144] by darin@chromium.org

2009-06-24 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26698

Combined LocalStorageArea and SessionStorageArea into StorageArea since
(after my other refactorings) there are no longer substantial
differences between the two.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea):
  • storage/LocalStorage.h:
  • storage/LocalStorageArea.cpp: Removed.
  • storage/LocalStorageArea.h: Removed.
  • storage/SessionStorage.cpp: (WebCore::SessionStorage::copy): (WebCore::SessionStorage::storageArea):
  • storage/SessionStorage.h:
  • storage/SessionStorageArea.cpp: Removed.
  • storage/SessionStorageArea.h: Removed.
  • storage/StorageArea.cpp: (WebCore::StorageArea::createLocalStorage): (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::createSessionStorage): (WebCore::StorageArea::copy): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear): (WebCore::StorageArea::scheduleFinalSync): (WebCore::StorageArea::blockUntilImportComplete): (WebCore::StorageArea::dispatchStorageEvent):
  • storage/StorageArea.h:
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::scheduleFinalSync): (WebCore::StorageAreaSync::syncTimerFired): (WebCore::StorageAreaSync::performImport):
  • storage/StorageAreaSync.h:
  • storage/StorageSyncManager.h:
22:01 Changeset [45143] by mitz@apple.com

WebCore:

Reviewed by Simon Fraser.

  • fix <rdar://problem/7001817> REGRESSION (r41902): Base position track at UCSC Genome Browser doesn't work because image map prevents img from hit-testing

Test: fast/replaced/image-map-2.html

  • rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint): Do not reset 'inside' to false if the image map failed the hit test.

LayoutTests:

Reviewed by Simon Fraser.

  • test for <rdar://problem/7001817> REGRESSION (r41902): Base position track at UCSC Genome Browser doesn't work because image map prevents img from hit-testing
  • fast/replaced/image-map-2-expected.txt: Added.
  • fast/replaced/image-map-2.html: Added.
20:41 Changeset [45142] by barraclough@apple.com

Merged r44514:44520 into nitro-extreme branch.

20:34 Changeset [45141] by barraclough@apple.com

Merged r44513:44514 into nitro-extreme branch.

20:30 Changeset [45140] by barraclough@apple.com

Merged r44492:44513 into nitro-extreme branch.

20:18 Changeset [45139] by barraclough@apple.com

Merged r44491:44492 into nitro-extreme branch.

20:07 Changeset [45138] by weinig@apple.com

2009-06-24 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Make the opcode sampler work once again.

  • jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdSelfList): (JSC::JIT::compileGetByIdProtoList): (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compileCTIMachineTrampolines): (JSC::JIT::compilePatchGetArrayLength):
  • jit/JITStubCall.h: (JSC::JITStubCall::call):
20:06 Changeset [45137] by barraclough@apple.com

Merged r44460:44491 into nitro-extreme branch.

20:00 Changeset [45136] by barraclough@apple.com

Merged r44455:44460 into nitro-extreme branch.

19:56 Changeset [45135] by barraclough@apple.com

Merged r44454:44455 into nitro-extreme branch.

19:38 Changeset [45134] by abarth@webkit.org

2009-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26366

Refactor V8DOMMap to support isolated worlds.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluateInNewWorld):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8DOMMap.cpp: (WebCore::DOMDataStore::InternalDOMWrapperMap::InternalDOMWrapperMap): (WebCore::DOMDataStore::allStores): (WebCore::DOMDataStore::allStoresMutex): (WebCore::DOMDataStore::domData): (WebCore::ScopedDOMDataStore::ScopedDOMDataStore): (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore): (WebCore::StaticDOMDataStore::StaticDOMDataStore): (WebCore::): (WebCore::MainThreadDOMData::MainThreadDOMData): (WebCore::MainThreadDOMData::getStore): (WebCore::ChildThreadDOMData::ChildThreadDOMData): (WebCore::ChildThreadDOMData::getStore): (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStoreHandle::DOMDataStoreHandle): (WebCore::DOMDataStoreHandle::~DOMDataStoreHandle): (WebCore::::forget): (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap): (WebCore::DOMData::getCurrent): (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::ensureDeref): (WebCore::weakDOMObjectCallback): (WebCore::weakActiveDOMObjectCallback): (WebCore::weakNodeCallback): (WebCore::weakSVGElementInstanceCallback): (WebCore::weakSVGObjectWithContextCallback): (WebCore::DOMData::derefObject): (WebCore::DOMData::derefDelayedObjects): (WebCore::DOMData::derefDelayedObjectsInCurrentThread): (WebCore::DOMData::removeObjectsFromWrapperMap): (WebCore::removeAllDOMObjectsInCurrentThreadHelper): (WebCore::visitDOMNodesInCurrentThread): (WebCore::visitDOMObjectsInCurrentThread): (WebCore::visitActiveDOMObjectsInCurrentThread): (WebCore::visitDOMSVGElementInstancesInCurrentThread): (WebCore::visitSVGObjectsInCurrentThread):
  • bindings/v8/V8DOMMap.h: (WebCore::DOMDataStoreHandle::getStore):
  • bindings/v8/V8IsolatedWorld.cpp: Added. (WebCore::getIsolatedWorldKey): (WebCore::contextWeakReferenceCallback): (WebCore::V8IsolatedWorld::evaluate): (WebCore::V8IsolatedWorld::V8IsolatedWorld): (WebCore::V8IsolatedWorld::~V8IsolatedWorld): (WebCore::V8IsolatedWorld::getEntered):
  • bindings/v8/V8IsolatedWorld.h: Added. (WebCore::V8IsolatedWorld::getDOMDataStore):
19:06 Changeset [45133] by mrowe@apple.com

Versioning.

19:04 Changeset [45132] by mrowe@apple.com

New tag.

18:52 Changeset [45131] by eric@webkit.org

2009-06-24 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Bug 26604: Search doesn't work in Web Inspector Profiler
https://bugs.webkit.org/show_bug.cgi?id=26604

Seems like search was damaged in revision 42808.

  • inspector/front-end/ProfileView.js: (WebInspector.ProfileView.prototype.refresh): Here and in other functions: nodes we're searching in are profile data grid nodes, so there is no more need for '_dataGridNode' references. (WebInspector.ProfileView.prototype.searchCanceled): (WebInspector.ProfileView.prototype.performSearch.matchesQuery): Fixed accidental semicolon that caused 'matchesQuery' always return true. (WebInspector.ProfileView.prototype.performSearch): To perform search correctly in the case of bottom up tree, we need to populate the tree, because there's no 1-to-1 correspondence between profile nodes and data grid nodes in this case. (WebInspector.ProfileView.prototype._jumpToSearchResult):
18:32 Changeset [45130] by eric@webkit.org

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Maciej Stachowiak.

Extend FastAllocBase.h with 'using WTF::FastAllocBase' to avoid

unnecessary WTF
usings.
Remove existing unnecessary WTF
usings.
  • interpreter/Interpreter.h:
  • profiler/CallIdentifier.h:
  • runtime/ScopeChain.h:
  • wtf/FastAllocBase.h:
18:07 Changeset [45129] by simon.fraser@apple.com

2009-06-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6450239&6574516>

Fix flashing issues caused by compositing layers rendering content before
a deferred layout has happened. Because the -viewWillDraw machinery doesn't
work for composited layers, we need to use scheduleViewUpdate() to queue
up a layout via the run loop observer in WebKit, whenever we know we
are going to be painting soon.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::setContentsNeedDisplay): (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
17:45 Changeset [45128] by levin@chromium.org

JavaScriptCore:

2009-06-24 David Levin <levin@chromium.org>

Fix all builds.

  • bytecode/CodeBlock.h:
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Register.h:

WebCore:

2009-06-24 David Levin <levin@chromium.org>

Fix all builds.

  • ForwardingHeaders/wtf/FastAllocBase.h: Added.
17:42 Changeset [45127] by mrowe@apple.com

Versioning.

17:25 Changeset [45126] by barraclough@apple.com

Merged r44437:44454 into nitro-extreme branch.

17:20 Changeset [45125] by barraclough@apple.com

Merged r44436:44437 into nitro-extreme branch.

16:56 Changeset [45124] by darin@chromium.org

2009-06-24 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26658

Split the syncing portions of LocalStorageArea into StorageAreaSync.
This name will make more sense in the next patch (in this set) when
LocalStorageArea and SessionStorageArea are merged to become simply
StorageArea. (Thus the synching portion of StorageArea is in
StorageAreaSync.)

This looks like a big patch, but really all it's doing is splitting
code and patching split-related things up.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::create): (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::scheduleFinalSync): (WebCore::LocalStorageArea::itemChanged): (WebCore::LocalStorageArea::itemRemoved): (WebCore::LocalStorageArea::areaCleared): (WebCore::LocalStorageArea::blockUntilImportComplete):
  • storage/LocalStorageArea.h:
  • storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::LocalStorageTask):
  • storage/LocalStorageTask.h: (WebCore::LocalStorageTask::createImport): (WebCore::LocalStorageTask::createSync):
  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync):
  • storage/LocalStorageThread.h:
  • storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::blockUntilImportComplete):
  • storage/SessionStorageArea.h:
  • storage/StorageArea.h:
  • storage/StorageAreaSync.cpp: Copied from WebCore/storage/LocalStorageArea.cpp.
  • storage/StorageAreaSync.h: Copied from WebCore/storage/LocalStorageArea.h.
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
  • storage/StorageSyncManager.h:
16:55 Changeset [45123] by eric@webkit.org

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26677

Inherits CodeBlock class from FastAllocBase because it
has been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.h:217.

  • bytecode/CodeBlock.h:
16:55 Changeset [45122] by eric@webkit.org

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26676

Inherits BytecodeGenerator class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/parser/Nodes.cpp:1892.

  • bytecompiler/BytecodeGenerator.h:
16:54 Changeset [45121] by eric@webkit.org

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26675

Inherits Register class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/JSVariableObject.h:149.

  • interpreter/Register.h:
16:53 Changeset [45120] by eric@webkit.org

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26674

Inherits HashMap class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Structure.cpp:458.

  • wtf/HashMap.h:
16:52 Changeset [45119] by barraclough@apple.com

Merged r44412:44436 into nitro-extreme branch.

16:33 Changeset [45118] by barraclough@apple.com

Merged r44411:44412 into nitro-extreme branch.

16:32 Changeset [45117] by treat@webkit.org

2009-06-24 Adam Treat <adam.treat@torchmobile.com>

Fix Qt build.

  • WebCore.pro:
16:23 Changeset [45116] by mrowe@apple.com

Merge r44877.

16:23 Changeset [45115] by mrowe@apple.com

Merge r44845.

16:23 Changeset [45114] by mrowe@apple.com

Merge r44844.

16:23 Changeset [45113] by mrowe@apple.com

Merge r44262.

16:00 Changeset [45112] by cfleizach@apple.com

Windows build fix for fallout from

Bug 26668: AX: need a way to retrieve the language for an element

15:47 Changeset [45111] by levin@chromium.org

2009-06-24 David Levin <levin@chromium.org>

Reviewed by David Hyatt.

Bug 26696: Member functions in DataGridColumnList should return pointers instead of PassRefPtr.
https://bugs.webkit.org/show_bug.cgi?id=26696

  • html/DataGridColumnList.cpp: (WebCore::DataGridColumnList::itemWithName): (WebCore::DataGridColumnList::add):
  • html/DataGridColumnList.h: (WebCore::DataGridColumnList::item): (WebCore::DataGridColumnList::primaryColumn): (WebCore::DataGridColumnList::sortColumn):
15:19 Changeset [45110] by weinig@apple.com

2009-06-24 Sam Weinig <sam@webkit.org>

Reviewed by Dave "Messy" Hyatt.

Little bit of style cleanup.

  • html/DataGridColumn.cpp:
  • html/DataGridColumn.h:
  • html/DataGridColumn.idl:
  • html/DataGridColumnList.cpp:
  • html/DataGridColumnList.h:
  • html/DataGridColumnList.idl:
  • html/HTMLDataGridCellElement.cpp:
  • html/HTMLDataGridCellElement.h:
  • html/HTMLDataGridCellElement.idl:
  • html/HTMLDataGridColElement.cpp:
  • html/HTMLDataGridColElement.h:
  • html/HTMLDataGridColElement.idl:
  • html/HTMLDataGridElement.h:
  • html/HTMLDataGridElement.idl:
  • html/HTMLDataGridRowElement.cpp:
  • html/HTMLDataGridRowElement.h:
  • html/HTMLDataGridRowElement.idl:
15:14 Changeset [45109] by cfleizach@apple.com

Bug 26668: AX: need a way to retrieve the language for an element
https://bugs.webkit.org/show_bug.cgi?id=26668

15:12 Changeset [45108] by barraclough@apple.com

Merged r44350:44411 into nitro-extreme branch.

15:04 Changeset [45107] by beidson@apple.com

2009-06-24 Brady Eidson <beidson@apple.com>

Reviewed by Dan Bernstein.


<rdar://problem/6893811> Instead of downloading files linked from Google Earth, file contents displayed in browser window as text.

  • platform/network/mac/WebCoreURLResponse.mm: (createBinaryExtensionsSet): Add '.kmz' to the list of known-to-be-binary extensions.
15:01 Changeset [45106] by oliver@apple.com

<rdar://problem/6940519> REGRESSION (Safari 4 Public Beta - TOT): google.com/adplanner shows blank page instead of site details in "basic research'

Reviewed by Darin Adler.

The problem was caused by the page returned with a function using a
var declaration list containing around ~3000 variables. The solution
to this is to flatten the comma expression representation and make
codegen comma expressions and initializer lists iterative rather than
recursive.

14:53 Changeset [45105] by barraclough@apple.com

Merged r44340:44350 into nitro-extreme branch.

14:12 Changeset [45104] by mitz@apple.com

Rephrased change log

14:10 Changeset [45103] by eric@webkit.org

2009-06-24 Nicolas Weber <thakis@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26685
Accomodate for backwards-incompatible skia api changes.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setCompositeOperation):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap): (WebCore::Image::drawPattern):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): (PlatformContextSkia::setupPaintCommon): (PlatformContextSkia::setXfermodeMode): (PlatformContextSkia::applyClipFromImage):
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaUtils.cpp: (WebCore::): (WebCore::WebCoreCompositeToSkiaComposite):
  • platform/graphics/skia/SkiaUtils.h:
14:05 Changeset [45102] by mitz@apple.com

Reviewed by Anders Carlsson.

Fix the most recently seen kind of crash seen in
<rdar://problem/5983224>

  • WebView/WebHTMLView.mm: (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Null-check the Frame.
14:01 Changeset [45101] by barraclough@apple.com

Merged r44170:44340 into nitro-extreme branch.

13:51 Changeset [45100] by jmalonzo@webkit.org

2009-06-24 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix. Add files that were added in r45093 and r45096

  • GNUmakefile.am:
13:36 Changeset [45099] by barraclough@apple.com

Merged r44076:44170 into nitro-extreme branch.

13:33 Changeset [45098] by beidson@apple.com

2009-06-24 Brady Eidson <beidson@apple.com>

Fix 64-bit SnowLeopard build.

  • html/DataGridColumnList.cpp: (WebCore::DataGridColumnList::remove): (WebCore::DataGridColumnList::move):
13:15 Changeset [45097] by barraclough@apple.com

2009-06-24 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Enable JIT_OPTIMIZE_METHOD_CALLS on the branch, implementation matches current implemenatation in ToT.

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emitSlow_op_method_check): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::compileGetByIdSlowCase):
13:06 Changeset [45096] by hyatt@apple.com

Fix Mac build.

12:44 Changeset [45095] by rwlbuis@webkit.org

Reviewed by Niko.

https://bugs.webkit.org/show_bug.cgi?id=26392
Bug 26392: In html, modification of xlink:href of an newly inserted svg image does not work.
https://bugs.webkit.org/show_bug.cgi?id=26328
Bug 26328: changing href attribute of svg images dows not work when changing display attribute as well

React to href updates even when there is no renderer, i.e. display=none.

Tests: svg/custom/js-update-image-and-display.svg

svg/custom/js-update-image-and-display2.svg
svg/custom/js-update-image-and-display3.svg

12:41 Changeset [45094] by mitz@apple.com

Add Windows test results for a couple of search field tests

12:22 Changeset [45093] by hyatt@apple.com

WebCore:

2009-06-24 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26687

Add basic back-end column support to datagrid.

Added fast/dom/HTMLDataGridElement/ column tests.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/DataGridColumn.cpp: Added. (WebCore::DataGridColumn::setPrimary):
  • html/DataGridColumn.h: Added. (WebCore::DataGridColumn::create): (WebCore::DataGridColumn::id): (WebCore::DataGridColumn::setId): (WebCore::DataGridColumn::label): (WebCore::DataGridColumn::setLabel): (WebCore::DataGridColumn::type): (WebCore::DataGridColumn::setType): (WebCore::DataGridColumn::sortable): (WebCore::DataGridColumn::setSortable): (WebCore::DataGridColumn::sortDirection): (WebCore::DataGridColumn::setSortDirection): (WebCore::DataGridColumn::primary): (WebCore::DataGridColumn::detachFromColumnList): (WebCore::DataGridColumn::DataGridColumn):
  • html/DataGridColumn.idl: Added.
  • html/DataGridColumnList.cpp: Added. (WebCore::DataGridColumnList::~DataGridColumnList): (WebCore::DataGridColumnList::itemWithName): (WebCore::DataGridColumnList::add): (WebCore::DataGridColumnList::remove): (WebCore::DataGridColumnList::move): (WebCore::DataGridColumnList::clear): (WebCore::DataGridColumnList::primaryColumnChanged):
  • html/DataGridColumnList.h: Added. (WebCore::DataGridColumnList::create): (WebCore::DataGridColumnList::length): (WebCore::DataGridColumnList::item): (WebCore::DataGridColumnList::primaryColumn): (WebCore::DataGridColumnList::sortColumn):
  • html/DataGridColumnList.idl: Added.
  • html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::sortable): (WebCore::HTMLDataGridColElement::setSortable): (WebCore::HTMLDataGridColElement::sortDirection): (WebCore::HTMLDataGridColElement::setSortDirection):
  • html/HTMLDataGridColElement.h:
  • html/HTMLDataGridColElement.idl:
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::HTMLDataGridElement):
  • html/HTMLDataGridElement.h: (WebCore::HTMLDataGridElement::columns):
  • html/HTMLDataGridElement.idl:
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::paintObject): (WebCore::RenderDataGrid::paintColumnHeaders): (WebCore::RenderDataGrid::rebuildColumns):
  • rendering/RenderDataGrid.h: (WebCore::RenderDataGrid::gridElement):

LayoutTests:

2009-06-24 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig.

Add test for https://bugs.webkit.org/show_bug.cgi?id=26687.

  • fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt: Added.
  • fast/dom/HTMLDataGridElement/DataGridColumns-basic.html: Added.
12:14 Changeset [45092] by mrowe@apple.com

Merge r44951.

12:13 Changeset [45091] by mrowe@apple.com

Merge r44941.

12:13 Changeset [45090] by mrowe@apple.com

Merge r44940.

12:13 Changeset [45089] by mrowe@apple.com

Merge r44908.

12:13 Changeset [45088] by mrowe@apple.com

Merge r44906.

10:29 Changeset [45087] by jberlin@apple.com

2009-06-24 Jessie Berlin <jberlin@apple.com>

Reviewed by Adam Roben.

Partially fixes: https://bugs.webkit.org/show_bug.cgi?id=24735
(<rdar://problem/5015942>)
Where on windows it was not possible to set an element as the drag
image using setDragImage on the dataTransfer object.


Does not "fix" the case of dragging a link where the default link image
is still used, even when the -webkit-user-drag is set to "element". This
is the same behavior as is found on OS X.


Added a manual test because it is not possible to check that what is
contained in the image snapshot is indeed the requested element.

  • dom/Clipboard.h: (WebCore::Clipboard::dragImageElement): Made getting the raw pointer from the RefPtr a const operation.
  • manual-tests/drag-with-div-or-image-as-data-image.html: Added.
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::createDragImage): Get an image of the rendered element and its subtree.
09:48 Changeset [45086] by darin@chromium.org

2009-06-24 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26683
Fix Chromium build bustage: Add custom binding for HTMLDataGridElement.dataSource

This change just adds a stub implementation for now to help fix the build.

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Added.
08:53 Changeset [45085] by ddkilzer@apple.com

Build fixes for ENABLE(PLUGIN_PROXY_FOR_VIDEO)

Reviewed by Adam Roben.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::deliverNotification): Removed ExceptionCode parameter from togglePlayState(). (WebCore::HTMLMediaElement::initialURL): Don't convert a KURL object to a String when assigning to a KURL variable.
08:44 Moving to Git edited by treat@kde.org
(diff)
08:00 Changeset [45084] by zimmermann@webkit.org

Reviewed by Adam Treat.

Save memory by not storing attribute values in member variables, if not absolutely needed.
Also fixes bugs where we're substituting variables too early (noticeable with the upcoming <select> element).

07:35 Changeset [45083] by zimmermann@webkit.org

Reviewed by Adam Roben.
Forgot to initialize m_task member variable. Results in crashes sometimes.

07:34 Changeset [45082] by zimmermann@webkit.org

Not reviewed. Forgot to include within last patch.

07:30 Changeset [45081] by zimmermann@webkit.org

Reviewed by Nikolas Zimmermann.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26474
Adding WML <card> title attribute handling.

07:02 Changeset [45080] by zecke@webkit.org

2009-06-24 Jiahua Huang <jhuangjiahua@gmail.com>

Reviewed by Holger Freyther.

[Gtk] Add Undo/Redo support to WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=26573

Implement EditorClient::undo and other interested funcs.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::registerCommandForUndo): (WebKit::EditorClient::registerCommandForRedo): (WebKit::EditorClient::clearUndoRedoOperations): (WebKit::EditorClient::canUndo): (WebKit::EditorClient::canRedo): (WebKit::EditorClient::undo): (WebKit::EditorClient::redo): (WebKit::EditorClient::EditorClient):
  • WebCoreSupport/EditorClientGtk.h:
03:00 Changeset [45079] by hausmann@webkit.org

2009-06-24 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Fix the build without ENABLE_VIDEO.

  • html/CanvasRenderingContext2D.cpp: Add #if ENABLE guards.
  • html/CanvasRenderingContext2D.h: Ditto.
02:26 Changeset [45078] by oliver@apple.com

Temporarily disable failing test

01:56 Changeset [45077] by eric@webkit.org

2009-06-24 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

Add new drag tests to the Skipped lists for non-mac platforms.

Skipped tests:
fast/events/drag-to-navigate.html
fast/events/prevent-drag-to-navigate.html

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
01:15 Changeset [45076] by eric@webkit.org

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26645

Inherits ScopeChainNode class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/ScopeChain.h:95.

  • wtf/RefPtr.h:
01:12 Changeset [45075] by eric@webkit.org

2009-06-24 Siddhartha Chattopadhyay <sidchat@google.com>

Reviewed by Eric Seidel.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26200 which I introduced earlier. I had
the smartReplace set TRUE initially, which was wrong since the purpose of this call is
to just replace the selection, and place the caret at the end of the selection it replaced.

  • editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition):
  • manual-tests/textarea-caret-position-after-auto-spell-correct.html: Added.
01:00 Changeset [45074] by eric@webkit.org

2009-06-24 Jeff Johnson <opendarwin@lapcatsoftware.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26638 WebKitErrors.m: _initWithPluginErrorCode: does not set localizedDescription

Add localized descriptions for plugin errors.
The localized strings already existed but were unused; now NSLocalizedDescriptionKey is added to the NSError userInfo.

  • Misc/WebKitErrors.m: (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]):
00:54 Changeset [45073] by eric@webkit.org

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26648

Inherits Deque class from FastAllocBase because it has been
instantiated by 'new' with DEFINE_STATIC_LOCAL macro in
JavaScriptCore/wtf/MainThread.cpp:62.

  • wtf/Deque.h:
00:53 Changeset [45072] by eric@webkit.org

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26644

Inherits RefPtr class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/StructureChain.cpp:41.

  • wtf/RefPtr.h:
00:52 Changeset [45071] by oliver@apple.com

Attempting to make test more reliable.

00:47 Changeset [45070] by eric@webkit.org

2009-06-24 Kevin Watters <kevinwatters@gmail.com>

Reviewed by Kevin Ollivier.

Don't use an unsigned int for intervalInMS because we sometimes initialize
it with a negative value.

  • platform/wx/SharedTimerWx.cpp: (WebCore::setSharedTimerFireTime):
00:45 Changeset [45069] by eric@webkit.org

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Inherits HashSet class from FastAllocBase, because it has been
instantiated by 'new' in JavaScriptCore/runtime/Collector.h:116.

  • wtf/HashSet.h:
00:40 Changeset [45068] by eric@webkit.org

2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Inherits Vector class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Structure.cpp:633.

  • wtf/Vector.h:
00:34 Changeset [45067] by eric@webkit.org

2009-06-24 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

Spell Maciej's name right and add Brady Eidson.

  • Scripts/modules/bugzilla.py:
00:26 Changeset [45066] by eric@webkit.org

2009-06-24 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Maciej Stachoviak.

The BytecodeGenerator objects were instantiated on stack, which takes up ~38kB per instance
(each instance includes copy of JSC::CodeBlock with large SymbolTable, etc.).
Specifically, since there is nested invocation (e.g., GlobalCode --> FunctionCode),
the stack overflows immediately on Symbian hardware (max. 80 kB).
Proposed change allocates generator objects on heap.
Performance impact (if any) should be negligible and change is proposed as general fix,
rather than ifdef'd for SYMBIAN.

  • parser/Nodes.cpp: (JSC::ProgramNode::generateBytecode): (JSC::EvalNode::generateBytecode): (JSC::EvalNode::bytecodeForExceptionInfoReparse): (JSC::FunctionBodyNode::generateBytecode): (JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):
00:20 Changeset [45065] by eric@webkit.org

2009-06-24 Eric Seidel <eric@webkit.org>

No review, build fix only.

The previous checkin had an improper merge. This fixes the build.

  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):
00:07 Changeset [45064] by eric@webkit.org

2009-06-05 Eric Seidel <eric@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=25922
Fix dropEffect = "none" to work as expected.

  • fast/events/drag-to-navigate-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
  • fast/events/drag-to-navigate.html: Added.
  • fast/events/prevent-drag-to-navigate-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
  • fast/events/prevent-drag-to-navigate.html: Added.
  • fast/events/resources/file-for-drag-to-navigate.html: Added.
  • fast/events/resources/file-for-prevent-drag-to-navigate.html: Added.

2009-06-05 Eric Seidel <eric@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=25922
JS setting dropEffect = "none" causes tryDHTMLDrag
to return DragOperationNone. Which is also the value
tryDHTMLDrag previously used to indicate JS did not
want to handle the drag.

Make it possible for the DragController::try* methods
to return a bool to indicate if javascript accepted
or rejected the drag event, separate from the DragOperation.

Tests:

  • fast/events/drag-to-navigate.html
  • fast/events/prevent-drag-to-navigate.html
  • page/DragController.cpp: (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::defaultOperationForDrag): (WebCore::DragController::tryDHTMLDrag):
  • page/DragController.h:

06/23/09:

23:40 Changeset [45063] by oliver@apple.com

Add expected results for test i landed earlier

23:26 Changeset [45062] by eric@webkit.org

2009-06-23 Eric Seidel <eric@webkit.org>

Reviewed by Dave Levin.

Fix missing comment message during land-patches and SVN.commit_with_message respecting --dry-run
https://bugs.webkit.org/show_bug.cgi?id=26669

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
23:25 Changeset [45061] by barraclough@apple.com

Merged r44075:44076 into nitro-extreme branch. (Adds infrastructure for op_method_check, but does not implement optimization.)

23:19 Changeset [45060] by oliver@apple.com

<rdar://problem/6164797> Add Canvas API to allow drawing of <video> frames
<https://bugs.webkit.org/show_bug.cgi?id=25920>

Reviewed by Sam Weinig and Dave Hyatt.

Add support for drawing the contents of the video element to the canvas
in accordance with the current HTML5 draft.

Test: media/video-canvas.html

22:55 Changeset [45059] by ggaren@apple.com

2009-06-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Bit off a tiny bit more of standardizing opcode behavior to help with result
caching.


SunSpider reports no change, v8 maybe a tiny speedup.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emitSlow_op_to_jsnumber): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emitSlow_op_convert_this):
22:37 Changeset [45058] by barraclough@apple.com

Merged r44030:44075 into nitro-extreme branch.

22:31 Changeset [45057] by ggaren@apple.com

2009-06-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Bit off a tiny bit more of standardizing opcode behavior to help with result
caching -- including removing my old enemy, op_resolve_function, because
it was non-standard, and removing it felt better than helping it limp along.


SunSpider reports no change, v8 maybe a tiny speedup.


  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emitSlow_op_to_primitive):
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • parser/Nodes.cpp: (JSC::FunctionCallResolveNode::emitBytecode):
22:16 Changeset [45056] by barraclough@apple.com

Merged r44029:44030 into nitro-extreme branch.

21:56 Changeset [45055] by barraclough@apple.com

Merged r44000:44029 into nitro-extreme branch.

21:41 Changeset [45054] by barraclough@apple.com

Merged r43853:44000 into nitro-extreme branch.

21:33 Changeset [45053] by barraclough@apple.com

Merged r43848:43853 into nitro-extreme branch.

21:26 Changeset [45052] by barraclough@apple.com

Merged r43781:43848 into nitro-extreme branch.

21:19 Changeset [45051] by ggaren@apple.com

2009-06-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Bit off a tiny bit of standardizing opcode behavior to help with result
caching.


0.6% SunSpider speedup. 0.3% v8 speedup.

  • jit/JITInlineMethods.h: (JSC::JIT::emitLoad): Accomodate a base register that overlaps with payload by loading tag before payload, to avoid stomping base/payload.
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_mov): Abide by the standard "tag in regT1, payload in regT0" semantics.

(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var): Ditto. Also, removed some irrelevent
loads while I was at it. The global object's "d" pointer never changes
after construction.

21:16 Changeset [45050] by barraclough@apple.com

Merged r43780:43781 into nitro-extreme branch.

20:13 Changeset [45049] by barraclough@apple.com

Merged r43750:43780 into nitro-extreme branch.

20:11 Changeset [45048] by mrowe@apple.com

Merge r44799.

20:11 Changeset [45047] by mrowe@apple.com

Merge r44749.

20:11 Changeset [45046] by mrowe@apple.com

Merge r44519.

20:11 Changeset [45045] by mrowe@apple.com

Merge r44266.

20:11 Changeset [45044] by mrowe@apple.com

Merge r44134.

20:11 Changeset [45043] by mrowe@apple.com

Merge r44133.

20:11 Changeset [45042] by mrowe@apple.com

Merge r44125.

20:11 Changeset [45041] by mrowe@apple.com

Merge r44124.

19:59 Changeset [45040] by barraclough@apple.com

Merged r43666:43750 into nitro-extreme branch.

19:47 Changeset [45039] by oliver@apple.com

<rdar://problem/6992806> REGRESSION: Enumeration can skip new properties in cases of prototypes that have more than 64 (26593)
<https://bugs.webkit.org/show_bug.cgi?id=26593>

Reviewed by Gavin Barraclough.

Add tests to ensure we correctly invalidate caching that depends on structure chains
that include dictionaries.

19:45 WikiStart edited by whzeng@126.com
(diff)
19:41 Changeset [45038] by agl@chromium.org

2009-06-23 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium: Fix crash with inherited font-size in <option>

https://bugs.webkit.org/show_bug.cgi?id=26656
http://code.google.com/p/chromium/issues/detail?id=14853

In r42597 (https://bugs.webkit.org/show_bug.cgi?id=25244), I changed
the <select> handing for Chromium to fix a rendering bug. However,
although the font-size is correctly ignored, getRowHeight wasn't
updated and so was calculating the height of the rows in an
inconsistent manner. This can lead to a crash.

  • manual-tests/optgroup-empty-and-nested.html: adding test case for crash
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::getRowHeight):
19:38 WikiStart edited by whzeng@126.com
Add maxthon's port. (diff)
19:37 Changeset [45037] by barraclough@apple.com

Merged r43660:43666 into nitro-extreme branch.

19:18 Changeset [45036] by barraclough@apple.com

Merged r43642:43660 into nitro-extreme branch.

19:13 Changeset [45035] by barraclough@apple.com

Merged r43641:43642 into nitro-extreme branch.

19:08 Changeset [45034] by barraclough@apple.com

Merged r43619:43641 into nitro-extreme branch.

19:02 Changeset [45033] by barraclough@apple.com

Merged r43618:43619 into nitro-extreme branch.

18:50 Changeset [45032] by eric@webkit.org

2009-06-23 Takeshi Yoshino <tyoshino@google.com>

Reviewed by Mark Rowe.

Bug 26537: Builds from command-line fail if custom build product directory is set and ~/Library/Preferences/xcodebuild.plist exists
https://bugs.webkit.org/show_bug.cgi?id=26537

Let determineBaseProductDir subroutine remove
~/Library/Preferences/xcodebuild.plist. It can prevent xcodebuild from
respecting global settings such as a custom build products directory
(<rdar://problem/5585899>).

  • Scripts/webkitdirs.pm:
18:49 Changeset [45031] by beidson@apple.com

2009-06-23 Brady Eidson <beidson@apple.com>

Patch by Antti Koivisto.
Reviewed by Brady Eidson.

<rdar://problem/6988010> Failed resources not reloaded when built against Tiger SDK

A latent bug that cache revalidation uncovered. When a CachedResource failed to load,
it should always be revalidated upon reload.

  • loader/CachedResource.cpp: (WebCore::CachedResource::canUseCacheValidator): (WebCore::CachedResource::mustRevalidate):
18:45 Changeset [45030] by barraclough@apple.com

Merged r43598:43618 into nitro-extreme branch.

18:40 Changeset [45029] by barraclough@apple.com

Merged r43583:43598 into nitro-extreme branch.

18:36 Changeset [45028] by barraclough@apple.com

Merged r43582:43583 into nitro-extreme branch.

18:33 Changeset [45027] by ojan@chromium.org

2009-06-23 Ojan Vafai <ojan@chromium.org>

Reviewed by Mark Rowe.

Resets the results for a test that was missed in
http://trac.webkit.org/changeset/45016.

  • editing/execCommand/5142012-3-expected.txt:
18:31 Changeset [45026] by eric@webkit.org

2009-06-23 Eric Seidel <eric@webkit.org>

Reviewed by Dave Levin.

Make SCM.run_command smarter, and make all previous
os.system and subprocess.popen use SCM.run_command instead.
https://bugs.webkit.org/show_bug.cgi?id=26666

This makes it easier to handle errors in a standard way throughout all the code.
Since this new code raises by default when the exit_code != 0,
we should prevent future problems of bugzilla-tool continuing after
a git or svn command failed.

  • Scripts/modules/scm.py:
18:29 Changeset [45025] by barraclough@apple.com

Merged r43560:43582 into nitro-extreme branch.

18:14 Changeset [45024] by barraclough@apple.com

Merged r43559:43560 into nitro-extreme branch.

18:00 Changeset [45023] by mrowe@apple.com

Versioning.

17:57 Changeset [45022] by mrowe@apple.com

Versioning.

17:44 Changeset [45021] by beidson@apple.com

2009-06-23 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6950660> REGRESSION: iSale 5.5.3 crashes after I click a template to load

Due to some subtle WebKit changes - presumably some delegate callback behavior - a latent bug in
iSale was uncovered where they aren't properly retaining their FrameLoadDelegate, and we ended up
calling back to a dealloc'ed object.

  • WebView/WebView.mm: (-[WebView _needsAdobeFrameReloadingQuirk]): Use more intelligent C++-style initialization. (-[WebView _needsKeyboardEventDisambiguationQuirks]): Ditto. (-[WebView _needsFrameLoadDelegateRetainQuirk]): YES for iSale versions under 5.6 (-[WebView dealloc]): Release the delegate if the quirk is in effect. (-[WebView setFrameLoadDelegate:]): Retain the new delegate if the quirk is in effect.
17:41 Changeset [45020] by barraclough@apple.com

Merged r43558:43559 into nitro-extreme branch.

17:40 Changeset [45019] by mitz@apple.com

Reviewed by Darin Adler.

  • fix <rdar://problem/6634228> Crash in [NSScroller mouseDown:] beneath EventHandler::passMouseDownEventToWidget()
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseDownEventToWidget): Surround the -mouseDown: call with calls to Widget::beforeMouseDown() and Widget::afterMouseDown(), which prevent the widget's view hierarchy from being removed from its parent view while the scroller is tracking the mouse.
17:39 Changeset [45018] by weinig@apple.com

WebCore:

2009-06-23 Sam Weinig <sam@webkit.org>

Reviewed by Dave Hyatt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26516
Add initial implementation of DataGridDataSource

  • Initial implementation only supports the initialize callback function.

Test: fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html

  • WebCore.xcodeproj/project.pbxproj:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDataGridDataSource.cpp: Added. (WebCore::JSDataGridDataSource::JSDataGridDataSource): (WebCore::JSDataGridDataSource::~JSDataGridDataSource): (WebCore::JSDataGridDataSource::initialize):
  • bindings/js/JSDataGridDataSource.h: Added. (WebCore::JSDataGridDataSource::create): (WebCore::JSDataGridDataSource::isJSDataGridDataSource): (WebCore::JSDataGridDataSource::jsDataSource): (WebCore::asJSDataGridDataSource):
  • bindings/js/JSHTMLDataGridElementCustom.cpp: Added. (WebCore::JSHTMLDataGridElement::listener): (WebCore::JSHTMLDataGridElement::setListener):
  • html/DataGridDataSource.h: Added. (WebCore::DataGridDataSource::~DataGridDataSource): (WebCore::DataGridDataSource::isJSDataGridDataSource):
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::HTMLDataGridElement): (WebCore::HTMLDataGridElement::setDataSource): (WebCore::HTMLDataGridElement::initializationTimerFired):
  • html/HTMLDataGridElement.h: (WebCore::HTMLDataGridElement::dataSource):
  • html/HTMLDataGridElement.idl:

LayoutTests:

2009-06-23 Sam Weinig <sam@webkit.org>

Reviewed by Dave Hyatt.

Test for https://bugs.webkit.org/show_bug.cgi?id=26516
Add initial implementation of DataGridDataSource

  • fast/dom/HTMLDataGridElement: Added.
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic-expected.txt: Added.
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html: Added.
17:09 Changeset [45017] by barraclough@apple.com

2009-06-23 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Remove 'arguments' field from Register union (again).
This time do so without breaking tests (radical, I know).

  • interpreter/CallFrame.h: (JSC::ExecState::optionalCalleeArguments): (JSC::ExecState::setArgumentCount): (JSC::ExecState::init):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
  • interpreter/Register.h: (JSC::Register::withInt): (JSC::Register::): (JSC::Register::Register): (JSC::Register::i):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_tear_off_arguments):
  • runtime/Arguments.h: (JSC::JSActivation::copyRegisters): (JSC::Register::arguments):
  • runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
  • runtime/JSActivation.h:
16:56 Changeset [45016] by jparent@chromium.org

WebCore:

2009-06-23 Ryosuke Niwa <rniwa@google.com>

Reviewed by Justin Garcia.

Undo the changeset 21212 to fix the regression bug 14062.
The changeset 21212 attempted to fix rdar://problem/5002441.
The changeset 21212 modified InsertTextCommand::input so as to convert
all spaces in text to non-breaking spaces for rdar://problem/5002441.
However, the bug was originally caused by rebalanceWhitespaceAt
and this workaround introduced a regression bug 14062.
Because rebalanceWhitespaceAt appears to behave correctly now,
the workaround introduced in 21212 is no longer needed.

Test: editing/inserting/space-after-removeformat.html

  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):

LayoutTests:

2009-06-23 Ryosuke Niwa <rniwa@google.com>

Reviewed by Justin Garcia.

Undo the changeset 21212 to fix the regression bug 14062.
The changeset 21212 attempted to fix rdar://problem/5002441.
The changeset 21212 modified InsertTextCommand::input so as to convert
all spaces in text to non-breaking spaces for rdar://problem/5002441.
However, the bug was originally caused by rebalanceWhitespaceAt
and this workaround introduced a regression bug 14062.
Because rebalanceWhitespaceAt appears to behave correctly now,
the workaround introduced in 21212 is no longer needed.

The following test cases are affected by this change.
This patch removes unappropriate non-breaking spaces (&nbsp;) and
inserts normal spaces instead.

  • editing/deleting/2610675-1-expected.txt: Replaced.
  • editing/deleting/2610675-2-expected.txt: Replaced.
  • editing/deleting/2610675-3-expected.txt: Replaced.
  • editing/inserting/insert-before-link-1-expected.txt: Replaced.
  • editing/inserting/space-after-removeformat-expected.txt: Added.
  • editing/inserting/space-after-removeformat.html: Added.
  • platform/mac/editing/execCommand/5482023-expected.checksum: Replaced.
  • platform/mac/editing/execCommand/5482023-expected.png: Replaced.
  • platform/mac/editing/execCommand/5482023-expected.txt: Replaced.
  • platform/mac/editing/input/text-input-controller-expected.txt: Replaced.
  • platform/mac/editing/inserting/editable-html-element-expected.checksum: Replaced.
  • platform/mac/editing/inserting/editable-html-element-expected.png: Replaced.
  • platform/mac/editing/inserting/editable-html-element-expected.txt: Replaced.
  • platform/mac/editing/pasteboard/4989774-expected.checksum: Replaced.
  • platform/mac/editing/pasteboard/4989774-expected.png: Replaced.
  • platform/mac/editing/pasteboard/4989774-expected.txt: Replaced.
  • platform/mac/editing/selection/4983858-expected.checksum: Replaced.
  • platform/mac/editing/selection/4983858-expected.png: Replaced.
  • platform/mac/editing/selection/4983858-expected.txt: Replaced.
16:42 Changeset [45015] by bdakin@apple.com

WebCore:

2009-06-23 Beth Dakin <bdakin@apple.com>

Reviewed by Dave Hyatt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26523 <col>
elements width can't be changed with javascript

This patch both fixes setting the width attribute directly in
JavaScript, and setting the width on the style attribute.

  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::parseMappedAttribute): If we have a new width, call setNeedsLayoutAndPrefWidthsRecalc()

Call calcPrefWidths() on the table cols.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):


Call layoutIfNeeded on the table cols.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::clippedOverflowRectForRepaint): Use new table() convenience function. (WebCore::RenderTableCol::calcPrefWidths): Just call setPrefWidthsDirty(false) on ourself and our children. (WebCore::RenderTableCol::table):
  • rendering/RenderTableCol.h:

LayoutTests:

2009-06-23 Beth Dakin <bdakin@apple.com>

Reviewed by Dave Hyatt.

Test for https://bugs.webkit.org/show_bug.cgi?id=26523 <col>
elements width can't be changed with javascript

  • fast/dom/HTMLTableColElement: Added.
  • fast/dom/HTMLTableColElement/resize-table-using-col-width.html: Added.
  • platform/mac/fast/dom/HTMLTableColElement: Added.
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.
16:35 Changeset [45014] by ojan@chromium.org

WebCore:

2009-06-23 Ojan Vafai <ojan@chromium.org>

Reviewed by Dan Bernstein.

Add logic to CSSStyleDeclaration::diff to deal with font-sizes that are
keyword values. When diff is called on a CSSStyleDeclaration, we check
the keywordSize to see if font-size matches a keyword value.

This ensures that when we diff a CSSMutableStyleDeclaration returned from
copyInheritableProperties on a CSSComputedStyleDeclaration that we
correctly identify matching font-sizes.

https://bugs.webkit.org/show_bug.cgi?id=26279

Test: editing/inserting/font-size-clears-from-typing-style.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
  • css/CSSComputedStyleDeclaration.h:
  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::cssPropertyMatches): (WebCore::CSSStyleDeclaration::diff):
  • css/CSSStyleDeclaration.h:

LayoutTests:

2009-06-23 Ojan Vafai <ojan@chromium.org>

Reviewed by Dan Bernstein.

This test hits an edge case where typingStyle would never get cleared.
In addition to making every text insertion go into its own text node,
this caused large performance problems.

https://bugs.webkit.org/show_bug.cgi?id=26279

  • editing/execCommand/5770834-1-expected.txt:

These results match how they were before r43243. It's not clear to me
why changes to font-size are affecting text-align styling though.

  • editing/inserting/font-size-clears-from-typing-style-expected.txt: Added.
  • editing/inserting/font-size-clears-from-typing-style.html: Added.
  • editing/inserting/resources/TEMPLATE.html: Copied from LayoutTests/editing/execCommand/resources/TEMPLATE.html.
  • editing/inserting/resources/font-size-clears-from-typing-style.js: Added.
  • platform/mac/editing/execCommand/remove-formatting-2-expected.txt:
16:18 Changeset [45013] by ggaren@apple.com

2009-06-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Removed some result register tracking cruft in preparation for a new
result tracking mechanism.


SunSpider reports no change.

  • assembler/AbstractMacroAssembler.h:
  • assembler/X86Assembler.h: (JSC::X86Assembler::JmpDst::JmpDst): No need to track jump targets in machine code; we already do this in bytecode.
  • jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::emitTimeoutCheck): Make sure to save and restore the result registers, so an opcode with a timeout check can still benefit from result register caching.

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases): Removed calls to killLastResultRegister()
in preparation for something new.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jnlesseq):
  • jit/JITInlineMethods.h: (JSC::JIT::emitGetFromCallFrameHeaderPtr): (JSC::JIT::emitGetFromCallFrameHeader32):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jmp): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_jsr): (JSC::JIT::emit_op_sret): (JSC::JIT::emit_op_jmp_scopes): ditto
  • jit/JITStubCall.h: (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::getArgument): added a mechanism for reloading an argument you passed to a JIT stub, for use in emitTimeoutCheck.
16:10 Changeset [45012] by treat@webkit.org

2009-06-23 Joe Mason <joe.mason@torchmobile.com>

Reviewed by Adam Treat.

https://bugs.webkit.org/show_bug.cgi?id=26664

  • Scripts/prepare-ChangeLog: Added --git-index mode to list only the changes which are already staged in the index. Useful to create an entry for what you're about to commit while ignoring unstaged changes.
16:06 Changeset [45011] by treat@webkit.org

2009-06-23 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=26654
Add the proper export define for the JavaScriptCore API when building for WINCE.

15:38 Changeset [45010] by andersca@apple.com

2009-06-23 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

  • Fix <rdar://problem/6965672>


Defer calls to WKPCInvalidateRect, so we don't try to invalidate while waiting for a reply, since
that is too early.


  • Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::isProcessingRequests):
  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): (WebKit::NetscapePluginHostProxy::processRequests): (WKPCInvalidateRect):
15:25 Changeset [45009] by kmccullough@apple.com

WebCore:

2009-06-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6994790> CrashTracer: [USER] 8 crashes in Mail trying to
add a blank line to pasted Facebook content (under
CompositeEditCommand::positionAvoidingSpecialElementBoundary)

  • Just added null checks and I will create a new bug to prevent the bad behavior.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):

LayoutTests:

2009-06-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6994790> CrashTracer: [USER] 8 crashes in Mail trying to
add a blank line to pasted Facebook content (under
CompositeEditCommand::positionAvoidingSpecialElementBoundary)

  • editing/inserting/return-with-object-element-expected.txt: Added.
  • editing/inserting/return-with-object-element.html: Added.
14:51 Changeset [45008] by weinig@apple.com

2009-06-23 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Remove now-useless inplace variants of binary ops.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_bitand): (JSC::JIT::emit_op_bitor): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emit_op_add): (JSC::JIT::emit_op_sub): (JSC::JIT::emit_op_mul):
14:48 Changeset [45007] by simon.fraser@apple.com

2009-06-23 Simon Fraser <simon.fraser@apple.com>

Build fix.

Wrap shouldDoSoftwarePaint() in #if USE(ACCELERATED_COMPOSITING) to avoid warning when
ACCELERATED_COMPOSITING is not defined.

  • rendering/RenderLayer.cpp:
14:43 Changeset [45006] by weinig@apple.com

2009-06-23 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Move off memory operands to aid in re-enabling result caching.

  • No regression measured.
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emit_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emit_op_bitand): (JSC::JIT::emitBitAnd32Constant): (JSC::JIT::emitBitAnd32InPlace): (JSC::JIT::emit_op_bitor): (JSC::JIT::emitBitOr32Constant): (JSC::JIT::emitBitOr32InPlace): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emitBitXor32Constant): (JSC::JIT::emitBitXor32InPlace): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emitSlow_op_pre_dec): (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitAdd32InPlace): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlowAdd32Constant): (JSC::JIT::emit_op_sub): (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSub32ConstantLeft): (JSC::JIT::emitSub32ConstantRight): (JSC::JIT::emitSub32InPlaceLeft): (JSC::JIT::emitSub32InPlaceRight): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul): (JSC::JIT::emitMul32InPlace): (JSC::JIT::emit_op_div): (JSC::JIT::emit_op_mod):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emit_op_not): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emit_op_to_jsnumber):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val):
14:25 Changeset [45005] by simon.fraser@apple.com

2009-06-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24863

Fix reflection painting on elements with compositing layers.

Test: compositing/reflections/reflection-on-composited.html

  • rendering/RenderLayer.h: Add a new PaintLayerPaintingReflection flag which is set while painting inside reflections. (WebCore::RenderLayer::setPaintingInsideReflection): Add a setter so that RenderLayerBacking can call it.
  • rendering/RenderLayer.cpp: (WebCore::shouldDoSoftwarePaint): Utility to clarify the logic of when a composited layer should do a software paint.

(WebCore::RenderLayer::paintLayer):
Use shouldDoSoftwarePaint() to determine when to software-paint a reflected layer.
Remove transform-related tests from the reflection-painting if test because they appear
to be unnecessary.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer): Add the code to paint reflections to the composited layer painting method.
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint): Set the PaintLayerPaintingReflection flag.
13:26 Changeset [45004] by ggaren@apple.com

2009-06-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed some missing and/or misplaced labels in bytecode generation, so
we don't have to work around them in JIT code generation.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitJumpSubroutine):
  • parser/Nodes.cpp: (JSC::TryNode::emitBytecode):
13:01 Changeset [45003] by antti@apple.com

WebCore:

2009-06-23 Antti Koivisto <antti@apple.com>

Reviewed by Darin Adler.


https://bugs.webkit.org/show_bug.cgi?id=26643
Memory cache should respect Cache-Control: no-store


Make resources with Cache-Control: no-store uncacheable in the memory cache.
They get evicted immediately when all clients are gone and are always
reloaded from the server.

Conforms to RFC2616 14.9.2 and seems also match Firefox behavior.

  • loader/CachedResource.cpp: (WebCore::CachedResource::removeClient): (WebCore::CachedResource::canUseCacheValidator): (WebCore::CachedResource::mustRevalidate):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::parseCacheControlDirectives): (WebCore::ResourceResponseBase::cacheControlContainsNoStore):
  • platform/network/ResourceResponseBase.h:

LayoutTests:

2009-06-23 Antti Koivisto <antti@apple.com>

Reviewed by Darin Adler.


https://bugs.webkit.org/show_bug.cgi?id=26643
Memory cache should respect Cache-Control: no-store


Update the test to cover no-store.

  • http/tests/cache/subresource-expiration-expected.txt:
  • http/tests/cache/subresource-expiration.html:
12:48 Changeset [45002] by beidson@apple.com

Windows build fix

12:46 Changeset [45001] by simon.fraser@apple.com

2009-06-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

First part of https://bugs.webkit.org/show_bug.cgi?id=26652

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): (WebCore::RenderLayer::paintLayer):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::):
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint): Replace the 3 boolean params to RenderLayer::paintLayer() with a bit mask for readability.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer): (WebCore::RenderLayerBacking::paintContents):
  • rendering/RenderLayerBacking.h: Remove the unused 'haveTransparency' param to paintIntoLayer().
12:12 Changeset [45000] by kmccullough@apple.com

WebCore:

2009-06-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6902203> REGRESSION: 'Return' insertion point incorrect
after manually quoting blank line then hitting return

If the insertion point is both the begining and ending visible position
then we need to insert at the end instead of the begining, which is what
would normally happen if the insertion point was as the begining.

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):

LayoutTests:

2009-06-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6902203> REGRESSION: 'Return' insertion point incorrect
after manually quoting blank line then hitting return

  • editing/inserting/insert-br-quoted-007-expected.txt: Added.
  • editing/inserting/insert-br-quoted-007.html: Added.
12:05 Changeset [44999] by beidson@apple.com

2009-06-23 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig, and looked over by Eric Carlson.

<rdar://problem/6980466> Media elements should provide option for changing pitch correction

Introduce a new boolean property to HTMLMediaElement called webkitPreservesPitch for script to control this.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Currently the platforms that have a flexible pitch preservation property (Quicktime on Mac and Win) have had it on by default, so continue that default for now. (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::webkitPreservesPitch): (WebCore::HTMLMediaElement::setWebkitPreservesPitch):
  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::setPreservesPitch): (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::preservesPitch): (WebCore::MediaPlayer::setPreservesPitch):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setPreservesPitch):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createQTMovie): Rework to allow recreation of the movie with almost the exact same attributes as before, with pitch preservation being the difference. (WebCore::MediaPlayerPrivate::setPreservesPitch): Recreate the QTMovie if the flag actually changes. (WebCore::MediaPlayerPrivate::updateStates): Restore current time and rate if this is a recreated movie. (WebCore::MediaPlayerPrivate::timeChanged): Clear the time-to-be-restored, as this callback means it has been effectively overwritten.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::setPreservesPitch):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::QTMovieWinPrivate): (QTMovieWinPrivate::~QTMovieWinPrivate): (QTMovieWinPrivate::task): Restore current time and rate if this is a re-created movie. (QTMovieWin::play): Clear the time-to-be-restored, as this effectively overwrites it. (QTMovieWin::pause): Ditto. (QTMovieWin::setRate): Ditto. (QTMovieWin::setCurrentTime): Ditto. (QTMovieWin::setPreservesPitch): Recreate the Movie if the flag actually changes. (QTMovieWin::load): Rework to allow recreation of the Movie with similar state as the movie before it, but changing the pitch preservation flag.
  • platform/graphics/win/QTMovieWin.h:
12:04 Changeset [44998] by eric.carlson@apple.com

2009-06-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6998286> Crash after leaving page with <video>


Don't try to post events after going into the page cache.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::documentWillBecomeInactive): Cancel pending events and stop event timers so we won't try to post events after going into the cache.
11:52 Changeset [44997] by darin@chromium.org

2009-06-23 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Brady Eidson.

Simplify the interaction between LocalStorageArea/SessionStorageArea
and StorageArea by creating a "blockUntilImportComplete()" function
rather than bouncing back and forth between the child and parent
classes in a somewhat unintuitive manner.

This patch also paves the way for LocalStorageArea and
SessionStorageArea being merged into one. It's part of several in a
set which are separating syncing (to disk) code from the rest of the
implementation so that local storage and session storage's code can be
unified.

https://bugs.webkit.org/show_bug.cgi?id=25376

  • storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::blockUntilImportComplete):
  • storage/LocalStorageArea.h:
  • storage/StorageArea.cpp: (WebCore::StorageArea::length): (WebCore::StorageArea::key): (WebCore::StorageArea::getItem): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear): (WebCore::StorageArea::contains):
  • storage/StorageArea.h: (WebCore::StorageArea::blockUntilImportComplete):
11:36 Changeset [44996] by simon.fraser@apple.com

2009-06-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6997929> Assertion at WebCore::RenderLayer::updateClipRects with hardware acceleration

The updatingControlTints() painting pass goes through compositing layer boundaries,
so we need to ensure we don't cache clip rects computed with the wrong root by
setting temporaryClipRects to true.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer): Remove a printf that I left in by mistake.
11:03 Changeset [44995] by andersca@apple.com

WebCore:

2009-06-23 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

WebCore side of <rdar://problem/6946094>.


  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::setExternalDataObject):
  • platform/win/ClipboardWin.h:

WebKit/win:

2009-06-23 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

WebKit side of <rdar://problem/6946094>.

  • Interfaces/IWebUIDelegate.idl: Add a newPasteboard out parameter to willPerformDragSourceAction.


  • WebCoreSupport/WebDragClient.cpp: (WebDragClient::willPerformDragSourceAction): Implement this. If the client returns a new pasteboard, use it for the drag.


  • WebCoreSupport/WebInspectorDelegate.h: (WebInspectorDelegate::willPerformDragSourceAction): Add the new parameter.

WebKitTools:

2009-06-23 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.


Update for WebKit changes.


  • DumpRenderTree/win/UIDelegate.h: (UIDelegate::willPerformDragSourceAction):
10:29 Changeset [44994] by darin@chromium.org

2009-06-23 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26650

Add setFormContentType and setFormData since it is awkward for Chromium
to use setFormInfoFromRequest to set the underlying members. Also, add
a clearChildren method that Chromium needs. These methods are used as
part of the Chromium code that serializes a HistoryItem for storing in
the browser's session history.

  • history/HistoryItem.cpp:
  • history/HistoryItem.h:
08:45 Changeset [44993] by treat@webkit.org

2009-06-23 Joe Mason <joe.mason@torchmobile.com>

Reviewed by Adam Treat.

Authors: Yong Li <yong.li@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>

https://bugs.webkit.org/show_bug.cgi?id=26611
Implement currentThreadStackBase on WINCE by adding a global,
g_stackBase, which must be set to the address of a local variable
by the caller before calling any WebKit function that invokes JSC.

08:44 Changeset [44992] by eric.carlson@apple.com

2009-06-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by NOBODY, layout tests fix.


'timeupdate' events are, by definition, timing dependent so it isn't
a good idea to log them in layout test results.

  • media/event-attributes-expected.txt:
  • media/event-attributes.html:
07:49 Changeset [44991] by eric.carlson@apple.com

2009-06-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6978938> Need HTML 5 event attributes for media elements

Test: media/event-attributes.html

  • html/HTMLAttributeNames.in: Add media event attribute names.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute): Handle media event attributes.

2009-06-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.


<rdar://problem/6978938> Need HTML 5 event attributes for media elements

  • media/event-attributes-expected.txt: Added.
  • media/event-attributes.html: Added.
  • media/progress-event-total.html: Cleanup, use event handler attributes.
  • media/progress-event.html: Ditto.
  • media/video-size-intrinsic-scale.html: Remove duplicate 'waitForEvent("ratechange")'
  • media/video-source-add-src.html: Ditto.
  • media/video-source-error.html: Ditto.
  • media/video-timeupdate-during-playback.html: Ditto.
  • platform/gtk/Skipped: Skip new test.
06:03 Changeset [44990] by hausmann@webkit.org

2009-06-23 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Simon Hausmann.

Fix Qt build with Phonon.

The #include <phonon> header no longer exists. And the <Phonon> or
<Phonon/Phonon> headers have never existed (neither for us nor for the
Phonon sources). You have to select each and every header that you do
want now.

05:43 Changeset [44989] by vestbo@webkit.org

2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Remove duplicated code in Qt & GTK logging initialization

We now share the getChannelFromName() function in Logging.cpp

  • platform/gtk/LoggingGtk.cpp:
  • platform/qt/LoggingQt.cpp:
05:43 Changeset [44988] by vestbo@webkit.org

2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Rename the plugin logging channel to plural form 'Plugins'

This matches both the other logging channel names, as well as the
WebKit logging channel used by Safari/Mac for plugins.

  • platform/Logging.cpp:
  • platform/Logging.h:
  • platform/gtk/LoggingGtk.cpp:
  • platform/mac/LoggingMac.mm:
  • platform/qt/LoggingQt.cpp:
  • platform/win/LoggingWin.cpp:
  • plugins/PluginDebug.h:
  • plugins/gtk/PluginPackageGtk.cpp:
  • plugins/mac/PluginPackageMac.cpp:
  • plugins/mac/PluginViewMac.cpp:
  • plugins/qt/PluginPackageQt.cpp:
03:17 Changeset [44987] by vestbo@webkit.org

2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Fix NPAPI mouse translation issues on Mac

The WindowRef we pass to the plugin refers to the the top level window,
so the x and y positions have to be relative to this position, but we
have to manually compensate for title bar decorations and other parents
of the QWebView since contentsToWindow() only traverses to the QWebView.

Previously we did this compensation when passing on mouse coordinates to
the plugin, which caused various issues with translations such as not
being able to close the Flash settings dialog, or the hand cursor not
appearing over links.

We now do the compensation as part of the call to NPP_SetWindow, and
then pass mouse coordinates in global context without any compensation,
similar to how both Safari and Mozilla does it.

03:11 Changeset [44986] by vestbo@webkit.org

2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] Resolve absolute path to library install_name manually

Since our target.path is set to the Qt directory (to be able
to do 'make install') the 'absolute_library_soname' option
to QMake did not do the right thing.

We now compute the absolute path manually using DESTDIR.

  • WebCore.pro:
02:17 Changeset [44985] by abarth@webkit.org

2009-06-23 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26589

More tests for the XSSAuditor. (I converted the server side to Perl
after Sam reviewed the patch because the PHP scripts didn't agree with
the Tiger and Windows buildbots.)

  • http/tests/security/xssAuditor/img-onerror-tricky-expected.txt: Added.
  • http/tests/security/xssAuditor/img-onerror-tricky.html: Added.
  • http/tests/security/xssAuditor/link-onclick-expected.txt: Added.
  • http/tests/security/xssAuditor/link-onclick.html: Added.
  • http/tests/security/xssAuditor/property-escape-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape.html: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-post.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag.php: Removed.
  • http/tests/security/xssAuditor/resources/echo-intertag.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-property.pl: Added.
  • http/tests/security/xssAuditor/resources/redir.php: Added.
  • http/tests/security/xssAuditor/resources/xss.js: Added.
  • http/tests/security/xssAuditor/script-tag-convoluted-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-convoluted.html: Added.
  • http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-open-redirect.html: Added.
  • http/tests/security/xssAuditor/script-tag-post-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-post.html: Added.
  • http/tests/security/xssAuditor/script-tag-redirect-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-redirect.html: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source.html: Added.
  • http/tests/security/xssAuditor/script-tag.html:
02:14 Changeset [44984] by oliver@apple.com

Fix stupid performance problem in the LiteralParser

Reviewed by Alexey Proskuryakov.

The LiteralParser was making a new UString in order to use
toDouble, however UString's toDouble allows a much wider range
of numberic strings than the LiteralParser accepts, and requires
an additional heap allocation or two for the construciton of the
UString. To rectify this we just call WTF::dtoa directly using
a stack allocated buffer to hold the validated numeric literal.

02:11 Changeset [44983] by abarth@webkit.org

Revert 44981. The buildbots hate me.

02:01 Changeset [44982] by eric@webkit.org

2009-06-23 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

  • Scripts/modules/scm.py: Fix commit_with_message to return the commit output.
01:51 Changeset [44981] by abarth@webkit.org

2009-06-23 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26589

More tests for the XSSAuditor. (I converted the server side to Perl
after Sam reviewed the patch because the PHP scripts didn't agree with
the Tiger and Windows buildbots.)

  • http/tests/security/xssAuditor/img-onerror-tricky-expected.txt: Added.
  • http/tests/security/xssAuditor/img-onerror-tricky.html: Added.
  • http/tests/security/xssAuditor/link-onclick-expected.txt: Added.
  • http/tests/security/xssAuditor/link-onclick.html: Added.
  • http/tests/security/xssAuditor/property-escape-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape.html: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-post.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag.php: Removed.
  • http/tests/security/xssAuditor/resources/echo-intertag.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-property.pl: Added.
  • http/tests/security/xssAuditor/resources/redir.php: Added.
  • http/tests/security/xssAuditor/resources/xss.js: Added.
  • http/tests/security/xssAuditor/script-tag-convoluted-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-convoluted.html: Added.
  • http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-open-redirect.html: Added.
  • http/tests/security/xssAuditor/script-tag-post-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-post.html: Added.
  • http/tests/security/xssAuditor/script-tag-redirect-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-redirect.html: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source.html: Added.
  • http/tests/security/xssAuditor/script-tag.html:
01:46 Changeset [44980] by eric@webkit.org

2009-06-23 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

  • Scripts/modules/scm.py: Fix error seen when commiting r44979.
01:40 Changeset [44979] by eric@webkit.org

2009-06-18 Eric Seidel <eric@webkit.org>

Reviewed by Dave Levin.

WebKit needs a script to interact with bugzilla and automate
parts of the patch posting and commit processes.
https://bugs.webkit.org/show_bug.cgi?id=26283

This is really a first-draft tool.
It's to the point where it's useful to more people than just me now though.
Git support works. SVN support is written, but mostly untested.

This tool requires BeautifulSoup and mechanize python modules to run:
sudo easy_install BeautifulSoup
sudo easy_install mechanize

More important than the tool itself are the Bugzilla, Git and SVN class abstractions
which I hope will allow easy writing of future tools.

The tool currently implements 10 commands, described below.

Helpers for scripting dealing with the commit queue:
bugs-to-commit Bugs in the commit queue
patches-to-commit Patches attached to bugs in the commit queue

Dealing with bugzilla:
reviewed-patches BUGID r+'d patches on a bug
apply-patches BUGID Applies all patches on a bug to the local working directory without committing.
land-and-update BUGID Lands the current working directory diff and updates the bug.
land-patches [options] BUGID Lands all patches on a bug optionally testing them first
obsolete-attachments BUGID Marks all attachments on a bug as obsolete.
commit-message Prints a commit message suitable for the uncommitted changes.

These effectively replace git-send-bugzilla:
post-diff BUGID Attaches the current working directory diff to a bug as a patch file.
post-commits BUGID COMMITISH Attaches a range of local commits to a bug as patch files.

post-diff works for SVN and Git, post-commits only works for SCMs with local-commit support (like Git)

land-* commands in a Git environment only work with simple patches due to svn-apply bugs:
https://bugs.webkit.org/show_bug.cgi?id=26299
https://bugs.webkit.org/show_bug.cgi?id=26300

This script follows python style (similar to how for Obj-C we follow AppKit style)
http://www.python.org/doc/essays/styleguide.html
The Python community has a strong style culture and the WebKit style guide is silent re: Python.

I've filed a bug to update the WebKit style guide to mention python:
https://bugs.webkit.org/show_bug.cgi?id=26524

  • Scripts/bugzilla-tool: Added.
00:48 Changeset [44978] by abarth@webkit.org

Revert 44977 because Tiger and Windows don't like the new tests.

00:11 Changeset [44977] by abarth@webkit.org

2009-06-23 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26589

More tests for the XSSAuditor.

  • http/tests/security/xssAuditor/link-onclick-expected.txt: Added.
  • http/tests/security/xssAuditor/link-onclick.html: Added.
  • http/tests/security/xssAuditor/property-escape-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape.html: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.php: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-post.php: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-utf-7.php: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag.php:
  • http/tests/security/xssAuditor/resources/echo-property.php: Added.
  • http/tests/security/xssAuditor/resources/redir.php: Added.
  • http/tests/security/xssAuditor/resources/xss.js: Added.
  • http/tests/security/xssAuditor/script-tag-convoluted-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-convoluted.html: Added.
  • http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-open-redirect.html: Added.
  • http/tests/security/xssAuditor/script-tag-post-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-post.html: Added.
  • http/tests/security/xssAuditor/script-tag-redirect-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-redirect.html: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-utf-7.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source.html: Added.
00:00 Changeset [44976] by ggaren@apple.com

2009-06-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


For member function calls, emit "this" directly into the "this" slot
for the function call, instead of moving it there later. This reduces
time spent in op_mov during certain calls, like "a.b.c()".


1%-2% speedup on v8, mostly richards and delta-blue.

  • parser/Nodes.cpp: (JSC::FunctionCallDotNode::emitBytecode):

06/22/09:

22:53 Changeset [44975] by ap@webkit.org

2009-06-22 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=17820

Skip layout tests for DST if the test runs not in PST/PDT.

  • fast/js/date-DST-time-cusps-expected.txt:
  • fast/js/date-big-setdate-expected.txt:
  • fast/js/resources/date-DST-time-cusps.js:
  • fast/js/resources/date-big-setdate.js:
22:44 Changeset [44974] by oliver@apple.com

Bug 26640: JSON.stringify needs to special case Boolean objects
<https://bugs.webkit.org/show_bug.cgi?id=26640>

Reviewed by Alexey Proskuryakov.

Add special case handling of the Boolean object so we match current
ES5 errata.

21:53 Changeset [44973] by simon.fraser@apple.com

2009-06-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6991146> Scrollbars in hardware layers don't change to the
inactive look in background windows

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Don't short-circuit the "painting" pass that is used to udpate control tints.
21:36 Changeset [44972] by dglazkov@chromium.org

2009-06-22 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26567
Upstream V8 bindings code generator. With this change, also added interface ancestor
traversal to IDL parser, which is necessary for V8 bindings. The traversal is used
to determine whether an interface is a Node to facilitate proper casting and storage
in V8DOMMap.

  • bindings/scripts/CodeGenerator.pm: Added parent traversal sub, needed

by V8 bindings.

  • bindings/scripts/CodeGeneratorV8.pm: Added.
  • bindings/scripts/IDLParser.pm: Modified to allow limited parsing for

parent traversal cases.

20:37 Changeset [44971] by barraclough@apple.com

2009-06-22 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Remove 'arguments' field from Register union. Having JSCell derived types in the union is
dangerous since it opens the possibility for the field to be written as a raw pointer but
then read as a JSValue. This will lead to statle data being read for the tag, which may
be dangerous. Having removed Arguments* types form Register, all arguments objects must
always explicitly be stored in the register file as JSValues.

  • interpreter/CallFrame.h: (JSC::ExecState::optionalCalleeArguments):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
  • interpreter/Register.h: (JSC::Register::):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_tear_off_arguments):
  • runtime/Arguments.h: (JSC::JSActivation::copyRegisters):
  • runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
  • runtime/JSActivation.h:
20:07 Changeset [44970] by mrowe@apple.com

Roll out r44967 as that build slave hates freedom.

20:05 Changeset [44969] by weinig@apple.com

WebCore:

2009-06-22 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Add event handler attribute getter/setters to HTMLFrameSetElement
as specified in HTML 5. These match the ones on HTMLBodyElement.

  • dom/Node.h:
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::onblur): (WebCore::HTMLFrameSetElement::setOnblur): (WebCore::HTMLFrameSetElement::onerror): (WebCore::HTMLFrameSetElement::setOnerror): (WebCore::HTMLFrameSetElement::onfocus): (WebCore::HTMLFrameSetElement::setOnfocus): (WebCore::HTMLFrameSetElement::onload): (WebCore::HTMLFrameSetElement::setOnload): (WebCore::HTMLFrameSetElement::onbeforeunload): (WebCore::HTMLFrameSetElement::setOnbeforeunload): (WebCore::HTMLFrameSetElement::onmessage): (WebCore::HTMLFrameSetElement::setOnmessage): (WebCore::HTMLFrameSetElement::onoffline): (WebCore::HTMLFrameSetElement::setOnoffline): (WebCore::HTMLFrameSetElement::ononline): (WebCore::HTMLFrameSetElement::setOnonline): (WebCore::HTMLFrameSetElement::onresize): (WebCore::HTMLFrameSetElement::setOnresize): (WebCore::HTMLFrameSetElement::onstorage): (WebCore::HTMLFrameSetElement::setOnstorage): (WebCore::HTMLFrameSetElement::onunload): (WebCore::HTMLFrameSetElement::setOnunload):
  • html/HTMLFrameSetElement.h:
  • html/HTMLFrameSetElement.idl:

LayoutTests:

2009-06-22 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Add event handler attribute getter/setters to HTMLFrameSetElement
as specified in HTML 5. These match the ones on HTMLBodyElement.

  • fast/dom/event-attribute-availability-expected.txt:
  • fast/dom/resources/event-attribute-availability.js:
18:27 Changeset [44968] by oliver@apple.com

Bug 26591: Support revivers in JSON.parse
<https://bugs.webkit.org/show_bug.cgi?id=26591>

Reviewed by Darin Adler.

Add reviver support to JSON.parse. This completes the JSON object.

18:27 Changeset [44967] by mrowe@apple.com

Update build.webkit.org config for new machine.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
18:04 Changeset [44966] by darin@apple.com

2009-06-22 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
https://bugs.webkit.org/show_bug.cgi?id=25425

  • bindings/scripts/CodeGeneratorJS.pm: Added handling for ReflectURL.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • dom/Element.cpp: (WebCore::Element::getURLAttribute): Added. For use implementing getters for ReflectURL.
  • dom/Element.h: Added getURLAttribute.
  • html/HTMLImageElement.idl: Use Reflect and ReflectURL.
17:41 Changeset [44965] by jianli@chromium.org

2009-06-22 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 26626: Make WorkerContextExecutionProxy::toV8Object handle exception
objects.
https://bugs.webkit.org/show_bug.cgi?id=26626

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object):
16:24 Changeset [44964] by hyatt@apple.com

2009-06-22 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig.

Add RenderDataGrid to the build. Give it some basic default styling (that more or less matches a listbox). It has a default size
of 300x150.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • css/html4.css:
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::createRenderer):
  • html/HTMLDataGridElement.h:
  • html/HTMLDataGridElement.idl:
  • rendering/RenderDataGrid.cpp: Added. (WebCore::RenderDataGrid::RenderDataGrid): (WebCore::RenderDataGrid::~RenderDataGrid): (WebCore::RenderDataGrid::calcPrefWidths): (WebCore::RenderDataGrid::paintObject): (WebCore::RenderDataGrid::valueChanged): (WebCore::RenderDataGrid::invalidateScrollbarRect): (WebCore::RenderDataGrid::isActive):
  • rendering/RenderDataGrid.h: Added. (WebCore::RenderDataGrid::renderName): (WebCore::RenderDataGrid::canHaveChildren): (WebCore::RenderDataGrid::scrollbarCornerPresent):
16:01 Changeset [44963] by sfalken@apple.com

Remove errant line of code mistakenly checked in.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main):
16:00 Changeset [44962] by sfalken@apple.com

Pass correct value to setShouldPaintNativeControls.


Rubber stamped by Mark Rowe.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main):
15:45 Changeset [44961] by simon.fraser@apple.com

2009-06-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=26430
<rdar://problem/6944442> Elements jump around when they become composited (WWDC checkers demo)
<rdar://problem/6989006> Lots of time spent in RenderLayerCompositor::calculateCompositedBounds()

during window resize when using hardware layers

Fix an ordering dependency which caused the compositing position of a layer
to be affected by some later sibling, which affected the compositing ancestor's
composited bounds.

The fix is to only update the compositing positions of layers in some subtree
when updateAfterLayout() has been called on all the layers in that subtree,
from the ancestor down.

Also cache the composited bounds of a RenderLayerBacking, now that we can
guarantee that those bounds are accurate.

Test: compositing/sibling-positioning.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::hitTestLayer):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::updateAfterLayout): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer): (WebCore::RenderLayerBacking::paintContents): (WebCore::RenderLayerBacking::compositedBounds): (WebCore::RenderLayerBacking::setCompositedBounds):
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::updateLayerCompositingState): (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::layerWillBeRemoved): (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::updateCompositingChildrenGeometry):
  • rendering/RenderLayerCompositor.h:
15:41 Moving to Git edited by joe.mason@torchmobile.com
Add link to evmar's doc (diff)
15:31 Moving to Git edited by joe.mason@torchmobile.com
Discussion of patch review branches (diff)
14:59 Changeset [44960] by barraclough@apple.com

Merged r43552:43558 into nitro-extreme branch.

14:58 Changeset [44959] by darin@chromium.org

2009-06-22 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

First step in https://bugs.webkit.org/show_bug.cgi?id=25376

Add StorageSyncManager.cpp/h

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

In preparation for combining SessionStorage and LocalStorage into a
single StorageManager, move the syncing bits out of LocalStorage and
into its own class.

The next step is to combine LocalStorageArea and SessionStorageArea
into one. Then SessionStorage and LocalStorage can be combined.

Note that combining them will cut down on code paths that must be
proxied, eliminate virtual dispatch, and allow Chromium to (eventually)
write historical sessionStorage to disk when memory is getting tight.

Also remove a couple bits of cruft including code for quotas which is
unnecessary (since a meta-data db is unnecessary since you can just
count bytes as you read the local storage databases into memory).

  • storage/LocalStorage.cpp: (WebCore::LocalStorage::LocalStorage): (WebCore::LocalStorage::storageArea): (WebCore::LocalStorage::close):
  • storage/LocalStorage.h:
  • storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::scheduleFinalSync): (WebCore::LocalStorageArea::syncTimerFired): (WebCore::LocalStorageArea::performImport):
  • storage/LocalStorageArea.h: (WebCore::LocalStorageArea::create):
  • storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::performTask):
  • storage/LocalStorageTask.h: (WebCore::LocalStorageTask::): (WebCore::LocalStorageTask::createImport):
  • storage/LocalStorageThread.cpp:
  • storage/LocalStorageThread.h:
  • storage/SessionStorage.h:
  • storage/StorageSyncManager.cpp: Copied from WebCore/storage/LocalStorage.cpp. (WebCore::StorageSyncManager::create): (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::fullDatabaseFilename): (WebCore::StorageSyncManager::close): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
  • storage/StorageSyncManager.h: Copied from WebCore/storage/LocalStorage.h. (WebCore::):
14:47 Changeset [44958] by barraclough@apple.com

Merged r43550:43552 into nitro-extreme branch - fix error in merging changelogs.

14:43 Changeset [44957] by barraclough@apple.com

Merged r43550:43552 into nitro-extreme branch.

14:38 Changeset [44956] by darin@chromium.org

2009-06-22 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26622
Add ChromiumDataObject::copy()

  • platform/chromium/ChromiumDataObject.cpp:
  • platform/chromium/ChromiumDataObject.h:
14:31 Changeset [44955] by timothy@apple.com

Add Mail on Tiger and Leopard to the list of applications that need the WebView init thread workaround.

<rdar://problem/6929524> Console shows WebKit Threading Violations from Mail

Reviewed by Anders Carlsson.

  • WebView/WebView.mm: (clientNeedsWebViewInitThreadWorkaround): Return true for com.apple.Mail.
14:30 Moving to Git edited by treat@kde.org
(diff)
14:25 Changeset [44954] by timothy@apple.com

Add a silhouette image for the enable view of the Resource panel.

Reviewed by Kevin McCullough.

  • inspector/front-end/Images/resourcesSilhouette.png: Added.
  • inspector/front-end/inspector.css:
14:02 Changeset [44953] by levin@chromium.org

2009-06-22 Kyle Prete <kylep@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26552
Add V8 JS bindings for Audio Constructor.

  • bindings/v8/custom/V8CustomBinding.h: Added a callback declaration for audio ctor to macro.
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Added the whole file.
13:14 Changeset [44952] by ap@webkit.org

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=26600
StringImpl::copy() no longer copies empty string correctly

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::ustring): Changed method calling syntax to look less like calling a static method. (WebCore::StringImpl::copy): Reverted part of r41917 that caused the problem.
12:51 Changeset [44951] by mitz@apple.com

Reviewed by Anders Carlsson.

  • speculative fix for <rdar://problem/6889082> Crash at -[WebHTMLView(WebPrivate) _updateMouseoverWithEvent:]

The crash seems to happen because lastHitView points to a deleted
object. Since -close calls -_clearLastHitViewIfSelf, I speculate that
lastHitView has been set to an already-closed view.

  • WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]): Return nil if the view is closed.
12:34 Changeset [44950] by levin@chromium.org

2009-06-22 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix layout tests to account for removal of DOMStringList, which was done
in http://trac.webkit.org/changeset/44943.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
12:20 Changeset [44949] by barraclough@apple.com

Merged r43544:43550 into nitro-extreme branch.

11:54 Changeset [44948] by jshin@chromium.org

2009-06-22 Xiaomei Ji <xji@chromium.org>

Reviewed by Eric Seidel

Not auto-testable since it involves sending a keyboard event to
the popup, which is not possible (eventSender sends the key
events through webview, we want to go through the webwidget).

This patch is one part of the fix for issue "keyboard selection in
Hebrew select element does not work in Windows". The other part of the
fix is in chromium's webkit/glue layer.
https://bugs.webkit.org/show_bug.cgi?id=25899

  • manual-tests/keyboard_select_non_english.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::isCharacterTypeEvent): Added. Check whether the event is a character type event. "Char" in Windows or "KeyDown" in Mac is character type event. (WebCore::PopupListBox::typeAheadFind): Since m_lastCharTime is used to indicate whether user types multiple characters continuely as a search prefix or not, it should be only assigned when the event is character type event.
11:51 Changeset [44947] by kmccullough@apple.com

2009-06-22 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6115819> Notify of profile start in console

Put a message in the console that announces that a profile has started,
similar to how a console message announces that a profile has finished.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): Use renamed function. (WebCore::InspectorController::addProfileFinishedMessageToConsole): Renamed. (WebCore::InspectorController::addStartProfilingMessageToConsole): New function that logs the message about the profile starting. (WebCore::InspectorController::startUserInitiatedProfiling): Ditto
  • inspector/InspectorController.h:
  • inspector/front-end/ProfilesPanel.js: Print the "run" of the profile's title if there are multiple profiles, and take into account the fact that titles are displayed twice as much now. (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink):
  • page/Console.cpp: (WebCore::Console::profile): Call new function.
11:47 Changeset [44946] by hyatt@apple.com

2009-06-22 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26615

Add IDL interface for datagrid cell elements. Add a few more properties to the datagrid itself that
correspond to ones you find on <select> elements.

Add an expanded property to row elements.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLAttributeNames.in:
  • html/HTMLDataGridCellElement.cpp: Added. (WebCore::HTMLDataGridCellElement::HTMLDataGridCellElement): (WebCore::HTMLDataGridCellElement::label): (WebCore::HTMLDataGridCellElement::setLabel): (WebCore::HTMLDataGridCellElement::focused): (WebCore::HTMLDataGridCellElement::setFocused): (WebCore::HTMLDataGridCellElement::checked): (WebCore::HTMLDataGridCellElement::setChecked): (WebCore::HTMLDataGridCellElement::indeterminate): (WebCore::HTMLDataGridCellElement::setIndeterminate): (WebCore::HTMLDataGridCellElement::progress): (WebCore::HTMLDataGridCellElement::setProgress):
  • html/HTMLDataGridCellElement.h: Added. (WebCore::HTMLDataGridCellElement::endTagRequirement): (WebCore::HTMLDataGridCellElement::tagPriority):
  • html/HTMLDataGridCellElement.idl: Added.
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::autofocus): (WebCore::HTMLDataGridElement::setAutofocus): (WebCore::HTMLDataGridElement::disabled): (WebCore::HTMLDataGridElement::setDisabled): (WebCore::HTMLDataGridElement::size): (WebCore::HTMLDataGridElement::setSize):
  • html/HTMLDataGridElement.h:
  • html/HTMLDataGridElement.idl:
  • html/HTMLDataGridRowElement.cpp: (WebCore::HTMLDataGridRowElement::checkDTD): (WebCore::HTMLDataGridRowElement::expanded): (WebCore::HTMLDataGridRowElement::setExpanded):
  • html/HTMLDataGridRowElement.h:
  • html/HTMLDataGridRowElement.idl:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
11:32 Changeset [44945] by sfalken@apple.com

Fix last DumpRenderTree change to correctly set preferences flag without crashing.


Reviewed by Mark Rowe.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main):
11:32 Changeset [44944] by weinig@apple.com

WebCore:

2009-06-22 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Add event handler attribute getter/setters to HTMLBodyElement
as specified in HTML 5.

  • Removes erroneous inclusion of the onresize and onunload event handler attributes in Element and Document.
  • dom/Document.cpp: (WebCore::Document::getWindowAttributeEventListener):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.cpp:
  • dom/Node.h: onblur, onerror, onfocus, and onload all need to be declared virtual, since their behavior for HTMLBodyElement differs from the base implementation.
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::onblur): (WebCore::HTMLBodyElement::setOnblur): (WebCore::HTMLBodyElement::onerror): (WebCore::HTMLBodyElement::setOnerror): (WebCore::HTMLBodyElement::onfocus): (WebCore::HTMLBodyElement::setOnfocus): (WebCore::HTMLBodyElement::onload): (WebCore::HTMLBodyElement::setOnload): (WebCore::HTMLBodyElement::onbeforeunload): (WebCore::HTMLBodyElement::setOnbeforeunload): (WebCore::HTMLBodyElement::onmessage): (WebCore::HTMLBodyElement::setOnmessage): (WebCore::HTMLBodyElement::onoffline): (WebCore::HTMLBodyElement::setOnoffline): (WebCore::HTMLBodyElement::ononline): (WebCore::HTMLBodyElement::setOnonline): (WebCore::HTMLBodyElement::onresize): (WebCore::HTMLBodyElement::setOnresize): (WebCore::HTMLBodyElement::onstorage): (WebCore::HTMLBodyElement::setOnstorage): (WebCore::HTMLBodyElement::onunload): (WebCore::HTMLBodyElement::setOnunload):
  • html/HTMLBodyElement.h:
  • html/HTMLBodyElement.idl:

LayoutTests:

2009-06-22 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Add event handler attribute getter/setters to HTMLBodyElement
as specified in HTML 5.

  • fast/dom/event-attribute-availability-expected.txt:
  • fast/dom/resources/event-attribute-availability.js:
11:22 Changeset [44943] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26601
Remove disabled code for appcache dynamic entries

This also removes code for DOM 3 Core DOMStringList, which we don't use for anything else yet.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDOMStringListCustom.cpp: Removed.
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMStringListCustom.cpp: Removed.
  • dom/DOMStringList.cpp: Removed.
  • dom/DOMStringList.h: Removed.
  • dom/DOMStringList.idl: Removed.
  • dom/StaticStringList.cpp: Removed.
  • dom/StaticStringList.h: Removed.
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addResource):
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
  • loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::dumpType):
  • loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeUpdatedType):
  • loader/appcache/DOMApplicationCache.cpp:
  • loader/appcache/DOMApplicationCache.h:
  • loader/appcache/DOMApplicationCache.idl:
  • page/DOMWindow.idl:
10:56 Changeset [44942] by sfalken@apple.com

Windows build fix.

  • DerivedSources.cpp:
  • html/HTMLElementsAllInOne.cpp:
10:33 Changeset [44941] by ap@webkit.org

Reviewed by John Sullivan.

<rdar://problem/6956606> REGRESSION (S4Beta -> Final): After the password is input,
Japanese can't be input.

WebKit uses a per-frame input context for most editable fields, and application's global
context for password fields, manually controlling secure input state and the list of available
input methods.

We were setting TSMDocument property to disable non-Roman input methods after focus changed
to a password field, but before selection was updated. This resulted in the property being
applied to a wrong TSMDocument in some cases, because TSMGetActiveDocument() uses input
context cached by +[NSApplication updateWindows], we change context based on selection,
not on focus.

  • page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Since there is only one context that we use for password fields - the global one - there is no need to get the active one.
10:20 Changeset [44940] by levin@chromium.org

WebCore:

2009-06-22 David Levin <levin@chromium.org>

Reviewed by David Hyatt and Eric Seidel.

REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326

Test: scrollbars/scrollbar-crash-on-refresh.html

  • dom/Document.cpp: (WebCore::Document::detach): Gives the FrameView a change to do any necessary cleanup on Document::detach() which is where the renderArena gets detroyed.
  • page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars): Gets rid of any custom scrollbars (if the docment supplied them).
  • page/FrameView.h:
  • platform/Scrollbar.h: (WebCore::Scrollbar::isCustomScrollbar):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Removed the check for document()->frame(). If frame() is 0 in this code, then the call to animation() is also incorrect (since it does document()->frame()->animation()).
  • rendering/RenderScrollbar.h: (WebCore::RenderScrollbar::isCustomScrollbar):

LayoutTests:

2009-06-22 David Levin <levin@chromium.org>

Reviewed by David Hyatt and Eric Seidel.

REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326

Test that refreshing an iframe with custom scrollbars works without crashing.

  • scrollbars/resources/page-with-custom-scrollbars.html: Added.
  • scrollbars/scrollbar-crash-on-refresh-expected.txt: Added.
  • scrollbars/scrollbar-crash-on-refresh.html: Added.
09:50 Changeset [44939] by mitz@apple.com

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6990938> REGRESSION (r42787): After showing and hiding the Find banner, the WebHTMLView's height is not restored
  • WebView/WebFrameView.mm: (-[WebFrameView setFrameSize:]): Mark the FrameView for layout when the WebFrameView's size changes.
  • WebView/WebView.mm: (-[WebView setFrameSize:]): Left the resize logic here, but only for the single view model.
09:42 Changeset [44938] by mitz@apple.com

WebCore:

Reviewed by Simon Fraser.

Test: fast/repaint/background-generated.html

  • rendering/RenderObject.cpp: (WebCore::mustRepaintFillLayers): Return true if the layer does not specify a size and the image uses the container size.

LayoutTests:

Reviewed by Simon Fraser.

  • fast/repaint/background-generated.html: Added.
  • platform/mac/fast/repaint/background-generated-expected.checksum: Added.
  • platform/mac/fast/repaint/background-generated-expected.png: Added.
  • platform/mac/fast/repaint/background-generated-expected.txt: Added.
09:34 Changeset [44937] by hyatt@apple.com

2009-06-22 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26607

Add IDL for HTMLDataGridRowElement.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLAttributeNames.in:
  • html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::primary): (WebCore::HTMLDataGridColElement::setPrimary):
  • html/HTMLDataGridColElement.h:
  • html/HTMLDataGridColElement.idl:
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::checkDTD): (WebCore::HTMLDataGridElement::multiple): (WebCore::HTMLDataGridElement::setMultiple):
  • html/HTMLDataGridElement.h:
  • html/HTMLDataGridElement.idl:
  • html/HTMLDataGridRowElement.cpp: Added. (WebCore::HTMLDataGridRowElement::HTMLDataGridRowElement): (WebCore::HTMLDataGridRowElement::selected): (WebCore::HTMLDataGridRowElement::setSelected): (WebCore::HTMLDataGridRowElement::focused): (WebCore::HTMLDataGridRowElement::setFocused):
  • html/HTMLDataGridRowElement.h: Added. (WebCore::HTMLDataGridRowElement::tagPriority):
  • html/HTMLDataGridRowElement.idl: Added.
  • html/HTMLTagNames.in:
09:32 Changeset [44936] by darin@apple.com

2009-06-22 Darin Adler <darin@apple.com>

  • platform/gtk/Skipped: Skip two new tests.
08:44 Changeset [44935] by darin@apple.com

2009-06-22 Darin Adler <darin@apple.com>

  • fast/js/JSON-stringify-expected.txt: Update results.
06:22 Changeset [44934] by yael.aharon@nokia.com

2009-06-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=26556

Fix a crash in case that the QNetworkReply::readReady signal is
"stuck" in deferred mode due to JavaScript alert, and in the meantime,
QNetworkreply::finished signal is received and processed before
QNetworkReply::readReady is processed.

  • manual-tests/qt/unload-alert.html: Added.
  • platform/network/qt/QNetworkReplyHandler.cpp:
  • platform/network/qt/QNetworkReplyHandler.h:
04:55 Changeset [44933] by vestbo@webkit.org

2009-06-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Fix the Qt build.

  • WebCore.pro:
00:33 Changeset [44932] by sfalken@apple.com

Set up global native controls flag before creating the first WebView.


Reviewed by Darin Adler.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main):

06/21/09:

23:35 Changeset [44931] by oliver@apple.com

Bug 26592: Support standard toJSON functions
<https://bugs.webkit.org/show_bug.cgi?id=26592>

Reviewed by Darin Adler

Add support for the standard Date.toJSON function.

23:17 Changeset [44930] by darin@apple.com

2009-06-21 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
https://bugs.webkit.org/show_bug.cgi?id=25425

  • bindings/scripts/CodeGeneratorJS.pm: Tweaked mechanism for includes to be a bit more consistent and to make SVGElement.h be included in the header rather than in every implementation file that includes the header. Added code to use getAttribute and setAttribute directly when the [Reflect] extended attribute is used.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • html/HTMLElement.idl: Used [Reflect] for all the attributes in this class that reflect content attributes. Restricting this to one class for now to keep the patch small and start out slowly.
22:08 Changeset [44929] by oliver@apple.com

Bug 26594: JSC needs to support Date.toISOString
<https://bugs.webkit.org/show_bug.cgi?id=26594>

Reviewed by Sam Weinig

Add support for Date.toISOString.

21:59 Changeset [44928] by weinig@apple.com

WebCore:

2009-06-21 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.

Test: fast/dom/event-attribute-availability.html

  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.cpp:
  • dom/Node.h:
  • dom/Node.idl:

LayoutTests:

2009-06-21 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Test for https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.

  • fast/dom/event-attribute-availability-expected.txt: Added.
  • fast/dom/event-attribute-availability.html: Added.
  • fast/dom/resources/event-attribute-availability.js: Added.
18:39 Changeset [44927] by abarth@webkit.org

WebCore:

2009-06-21 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26580


Fix to enable XSSAuditor on child windows.


Test: http/tests/security/xssAuditor/link-opens-new-window.html


  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject):
  • page/XSSAuditor.h: Removed method setXSSAuditorEnabled, and field m_isEnabled. Moved implementation of isEnabled to XSSAuditor.cpp and changed implementation to query Settings.

LayoutTests:

2009-06-21 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.


Test for https://bugs.webkit.org/show_bug.cgi?id=26580


Tests that XSSAuditor (if enabled) prevents script execution in child window.

  • http/tests/security/xssAuditor/link-opens-new-window-expected.txt: Added.
  • http/tests/security/xssAuditor/link-opens-new-window.html: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-and-notify.php: Added.
17:23 Changeset [44926] by mitz@apple.com

Rubber-stamped by Mark Rowe.

  • make repaint tests more reliable when run in Safari
  • fast/repaint/resources/repaint.js: (runRepaintTest): Increased the timeout from 0 to 100, to ensure that painting occurs once before repaintTest() is called.
17:03 Changeset [44925] by mrowe@apple.com

Set a sensible user agent string for the HTTP requests that Sparkle makes (checking for and downloading updates).

Reviewed by Sam Weinig.

  • WebKitLauncher/WebKitNightlyEnablerSparkle.m:

(userAgentStringForSparkle):
(initializeSparkle):

16:32 Changeset [44924] by oliver@apple.com

Fix build by removing dead code.

16:02 Changeset [44923] by oliver@apple.com

Bug 26587: Support JSON.parse
<https://bugs.webkit.org/show_bug.cgi?id=26587>

Reviewed by Darin Adler and Cameron Zwarich.

Extend the LiteralParser to support the full strict JSON
grammar, fix a few places where the grammar was incorrectly
lenient. Doesn't yet support the JSON.parse reviver function
but that does not block the JSON.parse functionality itself.

15:46 Changeset [44922] by levin@chromium.org

2009-06-21 David Levin <levin@chromium.org>

Reviewed by NOBODY (speculative build fix for windows).

Simply removed some whitespace form this file to make windows build wtf and
hopefully copy the new MessageQueque.h so that WebCore picks it up.

  • wtf/Assertions.cpp:
15:16 Changeset [44921] by levin@chromium.org

2009-06-21 David Levin <levin@chromium.org>

Reviewed by NOBODY.

Speculative windows build fix (idea by Mark Rowe).

  • WebCore.vcproj/WebCore.vcproj:
15:03 Changeset [44920] by mrowe@apple.com

Add a hook to the WebKit launcher application to allow a link on the nightly build start page to
trigger an update via the built-in software update mechanism.

Reviewed by Sam Weinig.

  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitLauncherURLProtocol.h: Added.
  • WebKitLauncher/WebKitLauncherURLProtocol.m: Added.

(+[WebKitLauncherURLProtocol load]):
(+[WebKitLauncherURLProtocol canInitWithRequest:]): Only allow use of the x-webkit-launcher scheme from .webkit.org subdomains.
(+[WebKitLauncherURLProtocol canonicalRequestForRequest:]):
(-[WebKitLauncherURLProtocol startLoading]):
(-[WebKitLauncherURLProtocol stopLoading]):
(-[WebKitLauncherURLProtocol handleIsWebKitLauncherAvailableJS]): Return a brief JavaScript snippet that can be used to programatically
determine whether the x-webkit-launcher is available and working.
(-[WebKitLauncherURLProtocol handleCheckForUpdates]): Trigger a software update on the main thread.
(-[WebKitLauncherURLProtocol resourceNotFound]): Fail with a generic "File does not exist" error.

15:02 Changeset [44919] by levin@chromium.org

2009-06-21 David Levin <levin@chromium.org>

Reviewed by NOBODY (Speculative gtk build fix).

  • GNUmakefile.am:
14:56 Changeset [44918] by levin@chromium.org

2009-06-21 David Levin <levin@chromium.org>

Reviewed by NOBODY.

Speculative tiger build fix and a windows build fix.
More fixes may still be in order.

  • WebCore.vcproj/WebCoreCommon.vsprops:
  • dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
14:46 Changeset [44917] by levin@chromium.org

2009-06-21 David Levin <levin@chromium.org>

Reviewed by NOBODY (Speculative tiger build fix).

  • dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::~MessagePortQueue):
14:32 Changeset [44916] by levin@chromium.org

WebCore:

2009-06-21 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=26448>

Added optimized GC for MessagePorts when the entangled port is run by the same thread.
Fixed bug in isProxyFor() that was not properly throwing an exception when trying to clone the entangled port.

  • bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext): Now marks remotely entangled ports as in-use, in addition to those with pending activity.
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark): Now checks if the entangled port is local (run by same thread) and if so mark()s it.
  • dom/MessagePort.cpp: (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): Removes cloned ports from the ScriptExecutionContext - this allows cloned ports to be GC'd as otherwise they look like remotely entangled ports. (WebCore::MessagePort::start): (WebCore::MessagePort::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread
  • dom/MessagePort.h:
  • dom/MessagePortProxyWrapper.h:
  • dom/default/MessagePortProxy.cpp: (WebCore::MessagePortProxyWrapper::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread (WebCore::MessagePortProxy::hasPendingActivity): Changed definition of hasPendingActivity() to be stricter - only returns true if there are pending messages. (WebCore::MessagePortProxy::locallyEntangledPort):
  • dom/default/MessagePortProxy.h:

LayoutTests:

2009-06-21 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=26448>

New tests for MessagePort GC cases that weren't previously covered.

  • fast/events/message-channel-gc-4-expected.txt: Added. Test for case where both MessagePorts are in-transit (cloned) when a GC occurs.
  • fast/events/message-channel-gc-4.html-disabled: Added.
14:32 Changeset [44915] by levin@chromium.org

JavaScriptCore:

2009-06-21 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=25043>
Added support for multi-threaded MessagePorts.

  • wtf/MessageQueue.h: (WTF::::appendAndCheckEmpty):

Added API to test whether the queue was empty before adding an element.

WebCore:

2009-06-21 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=25043>
Removed obsolete MessagePort.startConversation(), active and onclose APIs.

Refactored MessagePortProxy into MessagePortChannel and a platform-dependent PlatformMessagePortChannel
implementation. Modified APIs to simplify cross-process implementations by moving the messaging code
entirely into the platform-dependent proxy.

Created a thread-safe default PlatformMessagePortChannel implementation.

Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how
cross-thread MessagePorts work.

  • GNUMakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added MessagePortChannel/PlatformMessagePortChannel files.

  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):

Changed ports to not mark their entangled pair as reachable, per the spec.

  • bindings/v8/custom/V8MessagePortCustom.cpp:
  • dom/MessageChannel.cpp: (WebCore::MessageChannel::MessageChannel):

Updated to use PlatformMessagePortChannel::createChannel() to entangle the ports.

  • dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::~MessagePort): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): (WebCore::MessagePort::messageAvailable): (WebCore::MessagePort::start): (WebCore::MessagePort::close): (WebCore::MessagePort::entangle): (WebCore::MessagePort::contextDestroyed): (WebCore::MessagePort::dispatchMessages): (WebCore::MessagePort::setOnmessage): (WebCore::MessagePort::hasPendingActivity):

Changed these APIs to delegate to new PlatformMessagePortChannel APIs.

  • dom/MessagePort.h:

Renamed isQueueOpen() to started().

  • dom/MessagePort.idl:

Removed startConversation and onclose.

  • dom/MessagePortProxy.h: Removed.
  • dom/MessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::EventData::create): (WebCore::MessagePortChannel::EventData::EventData): (WebCore::MessagePortChannel::~MessagePortChannel):
  • dom/MessagePortChannel.h: Added. (WebCore::MessagePortChannel::EventData::message): (WebCore::MessagePortChannel::EventData::channel):

Changed EventData to hold a reference to a MessagePortChannel object instead of a MessagePort to enable cross-thread messaging.

(WebCore::MessagePortChannel::MessagePortChannel):
(WebCore::MessagePortChannel::create):

  • dom/ScriptExecutionContext.cpp: (WebCore:ScriptExecutionContext::dispatchMessagePortEvents):

Renamed isQueueOpen() to started().

  • dom/default/PlatformMessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::entangleIfOpen): (WebCore::MessagePortChannel::disentangle): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::MessagePortChannel::close): (WebCore::MessagePortChannel::isConnectedTo): (WebCore::MessagePortChannel::hasPendingActivity): (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::createChannel): (WebCore::PlatformMessagePortChannel::entangleIfOpen): (WebCore::PlatformMessagePortChannel::disentangle): (WebCore::PlatformMessagePortChannel::setRemotePort): (WebCore::PlatformMessagePortChannel::remotePort): (WebCore::PlatformMessagePortChannel::entangledChannel): (WebCore::PlatformMessagePortChannel::setEntangledChannel): (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote): (WebCore::PlatformMessagePortChannel::isConnectedTo): (WebCore::PlatformMessagePortChannel::close): (WebCore::PlatformMessagePortChannel::closeInternal): (WebCore::PlatformMessagePortChannel::hasPendingActivity):
  • dom/default/PlatformMessagePortChannel.h: Added. (WebCore::PlatformMessagePortChannel::MessagePortQueue::create): (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage): (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::isEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::MessagePortQueue):
  • page/DOMWindow.cpp: (WebCore::PostMessageTimer::PostMessageTimer):

Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how cross-thread MessagePorts work.

(WebCore::PostMessageTimer::event):
(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

2009-06-21 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

<https://bugs.webkit.org/show_bug.cgi?id=25043>
Updated MessageChannel/MessagePorts tests to reflect latest spec (close event has been removed).
Added more tests of port cloning.

  • fast/events/message-channel-gc-2-expected.txt:
  • fast/events/message-channel-gc-2.html-disabled:
  • fast/events/message-channel-gc-3-expected.txt:
  • fast/events/message-channel-gc-3.html-disabled:
  • fast/events/message-channel-gc-expected.txt:
  • fast/events/message-channel-gc.html-disabled:
  • fast/events/message-port-clone-expected.txt: Added.
  • fast/events/message-port-clone.html-disabled: Added.
  • fast/events/message-port-expected.txt:
  • fast/events/message-port-no-wrapper-expected.txt: Added.
  • fast/events/message-port-onclose-expected.txt: Removed.
  • fast/events/message-port-onclose.html-disabled: Removed.
  • fast/events/message-port.html-disabled:
13:56 Changeset [44914] by mitz@apple.com

WebCore:

Reviewed by Sam Weinig.

Test: fast/css/resize-single-axis.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): Ignore movement along the non-resizing axis.

LayoutTests:

Reviewed by Sam Weinig.

  • fast/css/resize-single-axis-expected.txt: Added.
  • fast/css/resize-single-axis.html: Added.
13:47 Changeset [44913] by weinig@apple.com

WebCore:

2009-06-21 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel

Fix for https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox

Test: fast/events/event-trace.html

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Make the DOMWindow the currentTarget when events are dispatched to it. We previously used the document because DOMWindow was not yet an EventTarget.

LayoutTests:

2009-06-21 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel.

Test for https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox

  • fast/events/event-trace-expected.txt: Added.
  • fast/events/event-trace.html: Added.
13:16 Changeset [44912] by mitz@apple.com

WebCore:

Reviewed by Sam Weinig.

Test: fast/css/resize-value-compared.html

  • rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::operator==): Compare the resize member.

LayoutTests:

Reviewed by Sam Weinig.

  • fast/css/resize-value-compared-expected.txt: Added.
  • fast/css/resize-value-compared.html: Added.
00:19 Changeset [44911] by darin@apple.com

2009-06-21 Darin Adler <darin@apple.com>

  • platform/gtk/Skipped: Skip one more test.

06/20/09:

23:19 Changeset [44910] by darin@apple.com

2009-06-20 Darin Adler <darin@apple.com>

  • platform/gtk/Skipped: Skip some new tests.
23:15 Changeset [44909] by darin@apple.com

2009-06-20 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6964221> Need more processing of pluginspage.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
22:42 Changeset [44908] by alice.liu@apple.com

WebCore:

2009-06-19 Alice Liu <alice.liu@apple.com>

Fix https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>

Reviewed by Maciej Stachowiak.

Can't test this bug with an automated layout test since it requires b/f caching

  • manual-tests/animated-gif-bfcache-crash.html: Added.
  • manual-tests/resources/containsAnimatedGif.html: Added.

Adding checks for hostWindow() since there is no guarantee that the Page is alive

  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::contentsToScreen): (WebCore::ScrollView::screenToContents): (WebCore::ScrollView::wheelEvent):

LayoutTests:

2009-06-19 Alice Liu <alice.liu@apple.com>

Fix https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>

Reviewed by Maciej Stachowiak.

Adding resource used in WebCore/manual-tests/animated-gif-bfcache-crash.html

  • http/tests/misc/resources/animated-gif-with-offsets.gif: Added.
19:43 Changeset [44907] by mrowe@apple.com

Roll out the Windows portion of r44905 as it broke the build.

19:05 Changeset [44906] by weinig@apple.com

WebCore:

2009-06-20 Sam Weinig <sam@webkit.org>

Reviewed by Adam Barth.

Fix for https://bugs.webkit.org/show_bug.cgi?id=26554
Shadowing of top and parent

  • page/DOMWindow.idl:

LayoutTests:

2009-06-20 Sam Weinig <sam@webkit.org>

Reviewed by Adam Barth.

Test for https://bugs.webkit.org/show_bug.cgi?id=26554

Test writing to parent and top.

  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/cross-frame-access-put.html:
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
16:07 Changeset [44905] by darin@apple.com

WebKit/mac:

2009-06-20 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6964221> Need more processing of pluginspage.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.

WebKit/win:

2009-06-20 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6964221> Need more processing of pluginspage.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
14:57 Changeset [44904] by jmalonzo@webkit.org

Reviewed by Gustavo Noronha and Xan Lopez.

[Gtk] Implement DRT XSS auditor support
https://bugs.webkit.org/show_bug.cgi?id=26571

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
14:56 Changeset [44903] by jmalonzo@webkit.org

2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha and Xan Lopez.

webkit_web_back_forward_list_add_item() should add a ref for the history item
https://bugs.webkit.org/show_bug.cgi?id=26517

Add a ref to the WebHistoryItem when it's added to the back
forward list through webkit_web_back_forward_list_add_item.
This keeps the history item alive and prevents pywebkitgtk from
crashing

  • tests/testwebbackforwardlist.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): (test_webkit_web_back_forward_list_add_item):
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_add_item):
14:54 Changeset [44902] by mrowe@apple.com

Fix <https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none

Reviewed by Dan Bernstein.

We allow selections to begin within an element that has -webkit-user-select: none set,
unless the element is draggable as dragging should take priority over starting a selection.

Test: editing/selection/user-drag-element-and-user-select-none.html

  • dom/Node.cpp:

(WebCore::Node::canStartSelection):

Test for <https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none

  • editing/selection/user-drag-element-and-user-select-none-expected.txt: Added.
  • editing/selection/user-drag-element-and-user-select-none.html: Added.
13:34 Changeset [44901] by darin@apple.com

WebCore:

2009-06-20 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329

  • editing/TextIterator.cpp: (WebCore::TextIterator::handleReplacedElement): When entering a text control, start at the top of the shadow tree (by calling shadowTreeRootNode). Also remove assumption that innerTextElement will never be 0 since RenderTextControl doesn't really guarantee this.

LayoutTests:

2009-06-20 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329

  • editing/selection/find-in-text-control-expected.txt: Updated to expect finding text in <input type="text"> and <input type="search">, but not in <input type="password">.
  • editing/selection/find-in-text-control.html: Added tests for <input> elements as well as <textarea> elements. Also tweaked result output format to accomodate multiple text nodes.
11:06 Changeset [44900] by ddkilzer@apple.com

Fix namespace comment in SegmentedVector.h

  • wtf/SegmentedVector.h: Updated namespace comment to reflect new namespace after r44897.
06:27 Changeset [44899] by ddkilzer@apple.com

2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>

Reviewed by Oliver Hunt.

An Iterator added for SegmentedVector. Currently
only the pre ++ operator is supported.

  • wtf/SegmentedVector.h: (WTF::SegmentedVectorIterator::~SegmentedVectorIterator): (WTF::SegmentedVectorIterator::operator*): (WTF::SegmentedVectorIterator::operator->): (WTF::SegmentedVectorIterator::operator++): (WTF::SegmentedVectorIterator::operator==): (WTF::SegmentedVectorIterator::operator!=): (WTF::SegmentedVectorIterator::operator=): (WTF::SegmentedVectorIterator::SegmentedVectorIterator): (WTF::SegmentedVector::alloc): (WTF::SegmentedVector::begin): (WTF::SegmentedVector::end):
06:20 Changeset [44898] by kov@webkit.org

2009-06-20 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Jan Alonzo.

Initial test case for loading statuses.

  • tests/testloading.c: Added. (load_finished_cb): (status_changed_cb): (test_loading_status): (main):
06:14 Changeset [44897] by ddkilzer@apple.com

2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>

Reviewed by Oliver Hunt.

Move SegmentedVector to /wtf subdirectory
and change "namespace JSC" to "namespace WTF"

Additional build file updates by David Kilzer.

  • GNUmakefile.am: Updated path to SegmentedVector.h.
  • JavaScriptCore.order: Updated SegmentedVector namespace from JSC to WTF in mangled C++ method name.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed reference to bytecompiler\SegmentedVector.h.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Added reference to wtf\SegmentedVector.h.
  • JavaScriptCore.xcodeproj/project.pbxproj: Moved SegmentedVector.h definition from bytecompiler subdirectory to wtf subdirectory.
  • bytecompiler/BytecodeGenerator.h: Updated #include path to
SegmentedVector.h and prepended WTF
namespace to its use.
  • parser/Lexer.h: Ditto.
  • wtf/SegmentedVector.h: Renamed from JavaScriptCore/bytecompiler/SegmentedVector.h. (WTF::SegmentedVector::SegmentedVector): (WTF::SegmentedVector::~SegmentedVector): (WTF::SegmentedVector::size): (WTF::SegmentedVector::at): (WTF::SegmentedVector::operator[]): (WTF::SegmentedVector::last): (WTF::SegmentedVector::append): (WTF::SegmentedVector::removeLast): (WTF::SegmentedVector::grow): (WTF::SegmentedVector::clear): (WTF::SegmentedVector::deleteAllSegments): (WTF::SegmentedVector::segmentExistsFor): (WTF::SegmentedVector::segmentFor): (WTF::SegmentedVector::subscriptFor): (WTF::SegmentedVector::ensureSegmentsFor): (WTF::SegmentedVector::ensureSegment):
05:34 Changeset [44896] by kov@webkit.org

2009-06-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Jan Alonzo.

Fix the ordering in which the new load status goes into the enum
to avoid ABI breakage.

  • webkit/webkitwebframe.h:
02:48 Changeset [44895] by jmalonzo@webkit.org

2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by NOBODY.

Speculative Qt build fix - add HTMLDataGridColElement to the build script.

  • WebCore.pro:
02:20 Changeset [44894] by abarth@webkit.org

2009-06-19 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26561

Remove a memcpy by retrieving the already existing copy of a string
instead of making a new one.

  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::source):
  • bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::source):
01:11 Changeset [44893] by xan@webkit.org

2009-06-20 Xan Lopez <xlopez@igalia.com>

Skip new accessibility test, we still lack and accessibilityController.

  • platform/gtk/Skipped:
01:00 Changeset [44892] by xan@webkit.org

2009-06-20 Xan Lopez <xlopez@igalia.com>

We don't seem to support these new HTTP tests either, skip them.

  • platform/gtk/Skipped:
00:53 Changeset [44891] by xan@webkit.org

2009-06-20 Xan Lopez <xlopez@igalia.com>

Skip test that requires eventSender.

  • platform/gtk/Skipped:

06/19/09:

23:21 Changeset [44890] by sfalken@apple.com

2009-06-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=26494
Bug 26494: RenderTheme::themeForPage reads from Settings before it has
been initialized by WebKit

Get the shouldPaintNativeControls preference and update the settings
before initializing the page, as the page depends on it after the
themeForPage change.

  • WebView.cpp: (WebView::initWithFrame):
18:29 Changeset [44889] by barraclough@apple.com

2009-06-19 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY (build fix take 2 - rename FIELD_OFFSET to something that doesn't conflict with winnt.h).

  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::emitGetVariableObjectRegister): (JSC::JIT::emitPutVariableObjectRegister):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::compileBinaryArithOp):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference): (JSC::JIT::checkStructure):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call): (JSC::JIT::emitSlow_op_get_by_val):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
18:29 Changeset [44888] by darin@apple.com

2009-06-19 Darin Adler <darin@apple.com>

  • Scripts/do-webcore-rename: More renaming ideas.
18:19 Changeset [44887] by barraclough@apple.com

2009-06-19 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY (Windows build fix).

  • jit/JIT.h:
  • jit/JITInlineMethods.h:
18:07 Changeset [44886] by barraclough@apple.com

2009-06-19 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Reorganize ARM architecture specific macros.
Use PLATFORM_ARM_ARCH(7) instead of PLATFORM(ARM_V7).

Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>

  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReferenceForTrampoline):
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • wtf/Platform.h:
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
17:52 Changeset [44885] by bweinstein@apple.com

Fixed the changelog, copied the same thing into both on accident.

17:49 Changeset [44884] by barraclough@apple.com

2009-06-19 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix armv7 JIT build issues.

Unfortunate the arm compiler does not like the use of offsetof on JITStackFrame (since it now contains non POD types),
and the FIELD_OFFSET macro does not appear constantish enough for it to be happy with its use in COMPILE_ASSERT macros.

  • Replace offsetofs with FIELD_OFFSETs (safe on C++ objects).
  • Move COMPILE_ASSERTs defending layout of JITStackFrame structure on armv7 into JITThunks constructor.
  • jit/JIT.cpp:
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_catch):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
17:35 Changeset [44883] by bweinstein@apple.com

2009-06-19 Brian Weinstein <bweinstein@apple.com>

Reviewed by Steve Falkenburg.


https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7


The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.


Unable to add tests to simulate touch behavior/gestures.

  • platform/PlatformWheelEvent.h:
  • platform/win/WheelEventWin.cpp:

2009-06-19 Brian Weinstein <bweinstein@apple.com>

Reviewed by Steve Falkenburg.


https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7


The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.


Unable to add tests to simulate touch behavior/gestures.

  • platform/PlatformWheelEvent.h:
  • platform/win/WheelEventWin.cpp:
17:27 Changeset [44882] by bfulgham@webkit.org

2009-06-19 Ryosuke Niwa <rniwa@google.com>

Reviewed by Maciej Stachowiak.

This fixs the bug 26361. The original test case did not invoke the event that
triggered the actual test. This patch adds code to invoke this event, and also
converts it from a pixel test to a dumpAsText test.

16:54 Changeset [44881] by cmarrin@apple.com

Fixed a build error, which only shows up in the i386 compile

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
16:35 Changeset [44880] by simon.fraser@apple.com

2009-06-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6988385> REGRESSION: In full page video player, movie's
video track becomes detached from its controller.

When in the media document, the MediaPlayer should not report that it
is capable of hardware acceleration, because it renders via a QTMovieView
which is already accelerated.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
16:14 Changeset [44879] by kevino@webkit.org

Adding XSSAuditor.cpp to the wx build.

15:43 Changeset [44878] by cmarrin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=26544

If I am doing a Matrix hardware animation and any matrix is singular, I revert to software.
This is not really testable, since we can't see what the hardware animation is doing.

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
15:32 Changeset [44877] by ggaren@apple.com

2009-06-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


An additional fix for Bug 26532: Native functions do not correctly unlink
from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> | <rdar://problem/6625385>

Use "NativeFunctionWrapper" instead of "PrototypeFunction" in cross-frame
accessors, so the type of object you get to wrap a function is the same,
regardless of whether the access to the function is cross-frame.


This is faster and more idiomatic than what we had before. It also would
have avoided Bug 26532 because it would have prevented a conflicting
PrototypeFunction from being allocated to wrap postMessage, where a
NativeFunctionWrapper had been allocated previously.


  • bindings/js/JSDOMBinding.cpp: (WebCore::objectToStringFunctionGetter):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter):
  • bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter):
  • bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter):
15:23 Changeset [44876] by simon.fraser@apple.com

2009-06-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by John Sullivan

<rdar://problem/6953673> Crash in RenderLayerCompositor::setCompositingParent

Fix a crash that could occur in complex content due to timing issues
when doing a partial layer tree rebuild which is required when painting;
setCompositingParent() could be called with a parent which has not been made
compositing yet.

15:16 Changeset [44875] by kov@webkit.org

2009-06-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Build fix. Adding missing HTMLDataGrid* files to the build.

  • GNUmakefile.am:
14:49 Changeset [44874] by pkasting@chromium.org

2009-06-19 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26460 part three
Make BMPImageReader a standalone class that is used by ICOImageDecoder
and BMPImageDecoder to decode individual BMPs within a file. These
decoders now inherit directly from ImageDecoder.


This also makes these decoders decode on-demand in isSizeAvailable() and
frameBufferAtIndex(), like the other decoders, instead of when setData()
is called, like before. This should provide a speedup on pages
containing BMPs that aren't immediately onscreen.

  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::setData): (WebCore::BMPImageDecoder::isSizeAvailable): (WebCore::BMPImageDecoder::frameBufferAtIndex): (WebCore::BMPImageDecoder::decodeWithCheckForDataEnded): (WebCore::BMPImageDecoder::decode): (WebCore::BMPImageDecoder::processFileHeader):
  • platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32):
  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::BMPImageReader): (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::readInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData): (WebCore::BMPImageReader::setFailed):
  • platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::setBuffer): (WebCore::BMPImageReader::setData): (WebCore::BMPImageReader::): (WebCore::BMPImageReader::pastEndOfImage): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::setRGBA):
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::setData): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::size): (WebCore::ICOImageDecoder::frameBufferAtIndex): (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded): (WebCore::ICOImageDecoder::decode): (WebCore::ICOImageDecoder::processDirectory): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::readDirectoryEntry): (WebCore::ICOImageDecoder::processImageType):
  • platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32):
14:31 Changeset [44873] by treat@webkit.org

2009-06-19 Adam Treat <adam.treat@torchmobile.com>

Blind attempt at build fix.

14:09 Changeset [44872] by hyatt@apple.com

Add missed file.

14:07 Changeset [44871] by bfulgham@webkit.org

2009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Inherits CallIdentifier struct from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/profiler/CallIdentifier.h:86.

  • wtf/HashCountedSet.h:
13:57 Changeset [44870] by treat@webkit.org

2009-06-19 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=26540
Currently the SunSpider test driver lacks an option to run a test suite that
will test JavaScriptCore parsing performance only. This patch adds just such
a test suite and option to SunSpider as well as the jsc test shell. I've included
three large javascript source files found in the wild: jquery, mootools and prototype.
Combined with the concatenation of all three, these form a new testsuite to measure
and test pure JavaScriptCore parsing performance.

13:38 Changeset [44869] by abarth@webkit.org

2009-06-19 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26555

Fix the Chromium canary bot. Turns out ScriptSourceCode doesn't have
the same API in V8 and JSC.

  • WebCore/bindings/js/ScriptController.cpp:
  • WebCore/bindings/js/ScriptSourceCode.h:
  • WebCore/bindings/v8/ScriptController.cpp:
  • WebCore/page/XSSAuditor.cpp:
  • WebCore/page/XSSAuditor.h:
13:30 Changeset [44868] by bfulgham@webkit.org

009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.


Inherits HashCountedSet class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Collector.cpp:1095.

  • wtf/HashCountedSet.h:
13:17 Changeset [44867] by hyatt@apple.com

WebCore:

2009-06-19 David Hyatt <hyatt@apple.com>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=26547


Implement the IDL interface for HTMLDataGridColElement.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLAttributeNames.in:
  • html/HTMLDataGridColElement.cpp: Added. (WebCore::HTMLDataGridColElement::HTMLDataGridColElement): (WebCore::HTMLDataGridColElement::label): (WebCore::HTMLDataGridColElement::setLabel): (WebCore::HTMLDataGridColElement::type): (WebCore::HTMLDataGridColElement::setType): (WebCore::HTMLDataGridColElement::sortable): (WebCore::HTMLDataGridColElement::setSortable): (WebCore::HTMLDataGridColElement::sortDirection): (WebCore::HTMLDataGridColElement::setSortDirection): (WebCore::HTMLDataGridColElement::selected): (WebCore::HTMLDataGridColElement::setSelected):
  • html/HTMLDataGridColElement.h: Added. (WebCore::HTMLDataGridColElement::endTagRequirement): (WebCore::HTMLDataGridColElement::tagPriority):
  • html/HTMLDataGridColElement.idl: Added.
  • html/HTMLDataGridElement.h:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

LayoutTests:

2009-06-19 David Hyatt <hyatt@apple.com>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=26547


Implement the IDL interface for HTMLDataGridColELement.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
13:09 Changeset [44866] by treat@webkit.org

2009-06-19 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=26558
Declare these symbols extern for WINCE as they are provided by libce.

  • runtime/DateConstructor.cpp:
  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
12:54 Changeset [44865] by bfulgham@webkit.org

2009-06-19 Chris Evans <scarybeasts@gmail.com>

Reviewed by Eric Seidel.

There is no new test because this cannot be tested deterministically.
I've not been able to cause a crash at all in the test framework, but
I have verified that this is happening in the wild and that the patch
fixes the likely cause in the debugger.

  • loader/TextResourceDecoder.cpp: careful not to iterate off the end of our input buffer looking for the end of the comment.
12:37 Changeset [44864] by mrowe@apple.com

Versioning.

12:35 Changeset [44863] by mrowe@apple.com

New tag.

11:48 Changeset [44862] by oliver@apple.com

<rdar://problem/6988973> ScopeChain leak in interpreter builds

Reviewed by Maciej Stachowiak

Move the Scopechain destruction code in JSFunction outside of the ENABLE(JIT)
path.

11:25 Changeset [44861] by abarth@webkit.org

2009-06-19 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26536

Fix external-script-URL-location.html and
write-external-script-open.html LayoutTests.

implicitOpen is called from several places. We need to setXSSAuditor
each time, so I moved the call inside implicitOpen.

  • dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::implicitOpen):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin):
11:22 Changeset [44860] by levin@chromium.org

2009-06-19 Kent Tamura <tkent@chromium.org>

Reviewed by David Levin.

Use WebCore::multipleFileUploadText() in Chromium to fix a problem
that Chromium shows only the first filename even if a user selects
multiple files for <input type=file multiple>.
<https://bugs.webkit.org/show_bug.cgi?id=26502>

  • platform/chromium/FileChooserChromium.cpp: (WebCore::FileChooser::basenameForWidth):
11:14 Changeset [44859] by mitz@apple.com

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d

Test: editing/selection/move-by-line-005.html

The root cause of this bug was searchAheadForBetterMatch() continuing
past the first rendered text object after the given object. While we
want to skip non-rendered text and empty containers, when we encounter
rendered text object, we must return a text box for that object.

  • dom/Position.cpp: (WebCore::searchAheadForBetterMatch):

LayoutTests:

Reviewed by Dave Hyatt.

  • text for <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d
  • editing/selection/move-by-line-005-expected.txt: Added.
  • editing/selection/move-by-line-005.html: Added.
10:46 Changeset [44858] by jshin@chromium.org

2009-06-18 Jungshik Shin <jshin@chromium.org>

Reviewed by David Levin

https://bugs.webkit.org/show_bug.cgi?id=25657

Chromium Linux port does not handle non-BMP characters properly.
It's fixed with a 'UTF-16 iterator macro' to extract Unicode
codepoints out of a UTF-16 input string.

A manual test is added for non-BMP character rendering,
which we can use until a small freely-distributable font
covering non-BMP is added to the Webkit source tree.

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • manual-tests/non-bmp.html: Added.
10:01 Changeset [44857] by treat@webkit.org

2009-06-19 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=26543
Windows CE uses 'GetLastError' instead of 'errno.'

  • interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::grow):
09:52 Changeset [44856] by mitz@apple.com

Reviewed by Anders Carlsson.

  • update test results after r44806
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
08:47 Changeset [44855] by dglazkov@chromium.org

2009-06-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

V8 Bindings: return proper state from the script stack.

https://bugs.webkit.org/show_bug.cgi?id=26512

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::state):
08:34 Changeset [44854] by jberlin@apple.com

2009-06-19 Jessie Berlin <jberlin@apple.com>

Reviewed by Simon Fraser.

Windows build fix.


  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
07:28 Changeset [44853] by yael.aharon@nokia.com

2009-06-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.
Build fix after 44825.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::isSizeAvailable):
  • platform/graphics/qt/ImageDecoderQt.h:
05:18 Changeset [44852] by hausmann@webkit.org

2009-06-19 Daniel Teske <qt-info@nokia.com>

Reviewed by Simon Hausmann.

Remove warnings for QString() constructions from const char *

By explicitly wrapping it with QLatin1String() / QLatin1Char()

02:58 Changeset [44851] by vestbo@webkit.org

2009-06-15 Andre Pedralho <andre.pedralho@openbossa.org>

Reviewed by Tor Arne Vestbø.

Only pass --makeargs along if an argument is given.

02:23 Changeset [44850] by oliver@apple.com

2009-06-18 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Oliver Hunt.

Bug 26426: Canvas: rotation of 'no-repeat' pattern is weird
<https://bugs.webkit.org/show_bug.cgi?id=26426>

Use 1<<23-1 as steps of no-repeat patterns instead of 100000000.0f.
The original number cannot be represented by mantissa of float
(23bit) so that it caused some error.

Test: fast/canvas/image-object-in-canvas.html:

  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
02:06 Changeset [44849] by abarth@webkit.org

Fix copy/paste error.

01:57 Changeset [44848] by abarth@webkit.org

2009-06-19 abarth <abarth@webkit.org>

Unreviewed attempt to fix the Chromium build.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::xssAuditor):
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
01:29 Changeset [44847] by abarth@webkit.org

2009-06-19 Adam Barth <abarth@webkit.org>

Unreviewed attempt to fix Windows build.

  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled):
01:12 Changeset [44846] by abarth@webkit.org

WebCore:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added an experimental reflective XSS filter. The filter is disabled by
default.

Test: http/tests/security/xssAuditor/script-tag.html

  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
  • bindings/js/ScriptController.h: (WebCore::ScriptController::xssAuditor):
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • dom/Tokenizer.h: (WebCore::Tokenizer::xssAuditor): (WebCore::Tokenizer::setXSSAuditor): (WebCore::Tokenizer::Tokenizer):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::requestObject):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setXSSAuditorEnabled):
  • page/Settings.h: (WebCore::Settings::xssAuditorEnabled):
  • page/XSSAuditor.cpp: Added. (WebCore::isControlCharacter): (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::~XSSAuditor): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h: Added. (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::setXSSAuditorEnabled):

WebKit/mac:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added preference to enable the XSSAuditor.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isXSSAuditorEnabled]): (-[WebPreferences setXSSAuditorEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

WebKit/win:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added preference to enable the XSSAuditor.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isXSSAuditorEnabled): (WebPreferences::setXSSAuditorEnabled):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

WebKitTools:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Add support for testing the XSSAuditor.

  • DumpRenderTree/LayoutTestController.cpp: (setXSSAuditorEnabledCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setPopupBlockingEnabled):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setXSSAuditorEnabled):

LayoutTests:

2009-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26199

Added a basic test for the XSSAuditor.

  • http/tests/security/xssAuditor/resources/echo-intertag.php: Added.
  • http/tests/security/xssAuditor/script-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag.html: Added.
00:59 Changeset [44845] by levin@chromium.org

2009-06-19 David Levin <levin@chromium.org>

Reviewed by NOBODY (Windows build fix).

Add export for Windows corresponding to OSX export done in r44844.

00:10 Changeset [44844] by oliver@apple.com

Bug 26532: Native functions do not correctly unlink from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> <rdar://problem/6625385>

Reviewed by Gavin "Viceroy of Venezuela" Barraclough.

We need to make sure that each native function instance correctly unlinks any references to it
when it is collected. Allowing this to happen required a few changes:

  • Every native function needs a codeblock to track the link information
  • To have this codeblock, every function now also needs its own functionbodynode so we no longer get to have a single shared instance.
  • Identifying a host function is now done by looking for CodeBlock::codeType() == NativeCode

06/18/09:

22:39 Changeset [44843] by barraclough@apple.com

2009-06-18 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY (Windows build fix).

  • wtf/DateMath.cpp: (WTF::calculateUTCOffset):
22:06 Changeset [44842] by barraclough@apple.com

2009-06-18 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Timezone calculation incorrect in Venezuela.

https://bugs.webkit.org/show_bug.cgi?id=26531
<rdar://problem/6646169> Time is incorrectly reported to JavaScript in both Safari 3 and Firefox 3

The problem is that we're calculating the timezone relative to 01/01/2000,
but the VET timezone changed from -4 hours to -4:30 hours on 12/09/2007.
According to the spec, section 15.9.1.9 states "the time since the beginning
of the year", presumably meaning the *current* year. Change the calculation
to be based on whatever the current year is, rather than a canned date.

No performance impact.

  • wtf/DateMath.cpp: (WTF::calculateUTCOffset):
22:06 Changeset [44841] by krit@webkit.org

2009-06-18 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

feOffset and objectBoundingBox
https://bugs.webkit.org/show_bug.cgi?id=26441

If we use objectBoundingBox for primitiveUnits, the fractions given
to dx or dy of feOffset must be multiplied with the referenced objects
objectBoundingBox size.

Test: svg/filters/feOffset.svg

  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):

Test for feOffset with the primitiveUnits objectBoundingBox
and userSpaceOnUse.

  • platform/mac/svg/filters/feOffset-expected.checksum: Added.
  • platform/mac/svg/filters/feOffset-expected.png: Added.
  • platform/mac/svg/filters/feOffset-expected.txt: Added.
  • svg/filters/feOffset.svg: Added.
22:00 Changeset [44840] by krit@webkit.org

2009-06-18 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

feTile implementation missing
https://bugs.webkit.org/show_bug.cgi?id=26419

Implementation of feTile, a pattern effect for SVG filters. It was
necessary to modify FilterEffect since source inputs need a secial
logic and we have to identify if an effect is a source input.

Tests: svg/batik/filters/feTile.svg

svg/filters/feTile.svg

  • platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::isSourceInput):
  • platform/graphics/filters/SourceAlpha.h: (WebCore::SourceAlpha::isSourceInput):
  • platform/graphics/filters/SourceGraphic.h: (WebCore::SourceGraphic::isSourceInput):
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):

Reviewed by Oliver Hunt.

Added a test of batik and a own one to check behavior of the
new feTile effect in SVG.

  • platform/mac/svg/batik/filters/feTile-expected.checksum: Added.
  • platform/mac/svg/batik/filters/feTile-expected.png: Added.
  • platform/mac/svg/batik/filters/feTile-expected.txt: Added.
  • platform/mac/svg/filters/feTile-expected.checksum: Added.
  • platform/mac/svg/filters/feTile-expected.png: Added.
  • platform/mac/svg/filters/feTile-expected.txt: Added.
  • svg/batik/filters/feTile.svg: Added.
  • svg/filters/feTile.svg: Added.
21:44 Changeset [44839] by krit@webkit.org

2009-06-18 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

feMerge implementation
https://bugs.webkit.org/show_bug.cgi?id=26480

Added feMerge to the SVG Filter system.

Test: svg/filters/feMerge.svg

  • svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::uniteChildEffectSubregions): (WebCore::FEMerge::apply):
  • svg/graphics/filters/SVGFEMerge.h:

Check the feMerge implementation.

  • platform/mac/svg/filters/feMerge-expected.checksum: Added.
  • platform/mac/svg/filters/feMerge-expected.png: Added.
  • platform/mac/svg/filters/feMerge-expected.txt: Added.
  • svg/filters/feMerge.svg: Added.
19:32 Changeset [44838] by barraclough@apple.com

2009-06-18 Gavin Barraclough <barraclough@apple.com>

Rubber Stamped by Mark Rowe (originally reviewed by Sam Weinig).

(Reintroducing patch added in r44492, and reverted in r44796.)

Change the implementation of op_throw so the stub function always modifies its
return address - if it doesn't find a 'catch' it will switch to a trampoline
to force a return from JIT execution. This saves memory, by avoiding the need
for a unique return for every op_throw.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):

JITStubs::cti_op_throw now always changes its return address,
remove return code generated after the stub call (this is now
handled by ctiOpThrowNotCaught).

  • jit/JITStubs.cpp: (JSC::):

Add ctiOpThrowNotCaught definitions.

(JSC::JITStubs::DEFINE_STUB_FUNCTION):

Change cti_op_throw to always change its return address.

  • jit/JITStubs.h:

Add ctiOpThrowNotCaught declaration.

18:51 Changeset [44837] by mrowe@apple.com

Speculative Windows build fix.

  • page/win/FrameCGWin.cpp: Add missing #include.
18:21 Changeset [44836] by bfulgham@webkit.org

WebCore:

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=26425
Final refactorings, picking up a few places where BitmapInfo
could be used.

  • page/win/FrameCGWin.cpp: (WebCore::imageFromRect):
  • platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):

WebKit/win:

2009-06-18 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Dave Levin.

Remove some boilerplate using the BitmapInfo struct.
https://bugs.webkit.org/show_bug.cgi?id=26425

  • WebFrame.cpp: (WebFrame::spoolPages):
  • WebIconDatabase.cpp: (createDIB):
  • WebKit.vcproj/WebKit.sln:
  • WebNodeHighlight.cpp: (WebNodeHighlight::update):
  • WebView.cpp: (WebView::ensureBackingStore):
18:20 Changeset [44835] by cfleizach@apple.com

Bug 26522: In DOM mode, VoiceOver reads some mouseover text on web sites strangely
https://bugs.webkit.org/show_bug.cgi?id=26522

18:18 Changeset [44834] by kevino@webkit.org

wx build fix after recent RenderTheme changes.

18:14 Changeset [44833] by pkasting@chromium.org

2009-06-18 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26460 part two
Attempt to minimize diff of following functional change by first landing
non-functional change to:

  • Make readUintX() public and static (since they will need to be once BMPImageReader is included in *ImageDecoder via composition rather than inheritance). Add wrappers in each class so callers can be simpler. In the next patch, these wrappers will be beefed up slightly and the callers will get even simpler.
  • Change direct setting of m_failed to use setFailed(), since in the next patch much of this code won't even have direct access to m_failed
  • Add a helper function in ICOImageDecoder to determine the image type instead of simply doing it inline
  • Rewrap lines that used to be <=80 cols and slipped over it during the original landing of these decoders
  • Other misc. changes, e.g. adding constructor definitions, reordering functions, changing RGBA32Buffer& to RGBA32Buffer*, etc. that have no functional effect but minimize the subsequent diff for readability
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::processFileHeader):
  • platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32):
  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::getInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData):
  • platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16Helper): (WebCore::BMPImageReader::readUint32Helper): (WebCore::BMPImageReader::): (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::getComponent): (WebCore::BMPImageReader::setI): (WebCore::BMPImageReader::setRGBA): (WebCore::BMPImageReader::fillRGBA):
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::size): (WebCore::ICOImageDecoder::decodeImage): (WebCore::ICOImageDecoder::processDirectory): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::isBetterEntry): (WebCore::ICOImageDecoder::processImageType):
  • platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32):
15:52 Changeset [44832] by pkasting@chromium.org

2009-06-18 Peter Kasting <pkasting@google.com>

Fix build bustage.

  • platform/image-decoders/gif/GIFImageDecoder.h:
15:34 Changeset [44831] by kmccullough@apple.com

JavaScriptCore:

2009-06-18 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit

  • Exposed functions now needed by WebCore.

WebCore:

2009-06-18 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit

Convert intptr_t to Strings so that we don't loose bits in the
conversion to JS. Previously they were being put into 32bit ints.

  • inspector/InspectorController.cpp: Convert the String back to an intptr_t. (WebCore::InspectorController::addBreakpoint): (WebCore::InspectorController::removeBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorController.idl: Use strings in JS to avoid 32bit truncation.
  • inspector/InspectorFrontend.cpp: Make the intptr_t into a String. (WebCore::InspectorFrontend::parsedScriptSource):
  • platform/text/PlatformString.h: Implemented the necessary conversion functions to be able to convert to and from an intptr_t.
  • platform/text/String.cpp: Ditto. (WebCore::String::toIntPtrStrict): (WebCore::String::toIntPtr): (WebCore::charactersToIntPtrStrict): (WebCore::charactersToIntPtr):
  • platform/text/StringImpl.cpp: Ditto. (WebCore::StringImpl::toIntPtrStrict): (WebCore::StringImpl::toIntPtr):
  • platform/text/StringImpl.h: Ditto.
15:15 Changeset [44830] by jparent@chromium.org

2009-06-18 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/insertHTML-expected.txt: Added.
  • editing/execCommand/insertHTML.html:
  • editing/execCommand/switch-list-type-expected.txt: Added.
  • editing/execCommand/switch-list-type.html:
  • platform/mac/editing/execCommand/insertHTML-expected.checksum: Removed.
  • platform/mac/editing/execCommand/insertHTML-expected.png: Removed.
  • platform/mac/editing/execCommand/insertHTML-expected.txt: Removed.
  • platform/mac/editing/execCommand/switch-list-type-expected.checksum: Removed.
  • platform/mac/editing/execCommand/switch-list-type-expected.png: Removed.
  • platform/mac/editing/execCommand/switch-list-type-expected.txt: Removed.
  • platform/qt/editing/execCommand/insertHTML-expected.txt: Removed.
  • platform/qt/editing/execCommand/switch-list-type-expected.txt: Removed.
15:04 Changeset [44829] by bfulgham@webkit.org

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

Final cleanups in this refactoring:
(1) Move WindowsBitmap implementation from CG-specific file to

the platform-common GraphicsContextWin.cpp, since it is
equally useful on both platforms.

(2) Revise the TransformationMatrix logic as suggested by

Adam Roben in his review comments to Part #2 of this
refactoring.

  • platform/graphics/win/GraphicsContextCGWin.cpp:
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): (WebCore::GraphicsContext::WindowsBitmap::~WindowsBitmap): (WebCore::GraphicsContext::createWindowsBitmap): (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
14:44 Changeset [44828] by andersca@apple.com

2009-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6926859>
NPN_ConvertPoint doesn't give the right value when converting to/from NPCoordinateSpaceFlippedScreen


When inverting Y, use the height of the first screen instead of the screen the window is on.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::windowFrameChanged): (WebKit::NetscapePluginInstanceProxy::mouseEvent):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
14:39 Changeset [44827] by kov@webkit.org

2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez and Christian Dywan.

Add a new load status to report that the first visually non-empty
layout has been done.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
  • webkit/webkitwebframe.h:
14:39 Changeset [44826] by kov@webkit.org

2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Fix parameters of navigation-policy-decision-requested callback,
to be correct in number and type

  • tests/testhttpbackend.c: (navigation_policy_decision_requested_cb):
14:29 Changeset [44825] by pkasting@chromium.org

2009-06-18 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26460 part one
Make isSizeAvailable non-const, since it's not logically const (it
triggers lazy decoding), and simplify all the implementations (without
changing behavior; just make less verbose). Remove some other
inappropriate consts, which enables the removal of all the mutable
declarations in the decoders.

  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::isSizeAvailable): (WebCore::ImageDecoder::setSize): Make public to avoid needing a friend declaration in the JPEG decoder, and because the ICO/BMP decoders will soon need this.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::isSizeAvailable): (WebCore::GIFImageDecoder::repetitionCount): (WebCore::GIFImageDecoder::decode):
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::isSizeAvailable):
  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::isSizeAvailable): (WebCore::JPEGImageDecoder::decode):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::isSizeAvailable): (WebCore::PNGImageDecoder::decode):
  • platform/image-decoders/png/PNGImageDecoder.h:
  • platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::isSizeAvailable): (WebCore::XBMImageDecoder::frameBufferAtIndex): (WebCore::XBMImageDecoder::decode):
  • platform/image-decoders/xbm/XBMImageDecoder.h: Rename decodeXBM() to decode() for consistency with the JPEG/PNG decoders, and in the future the ICO/BMP decoders.
14:25 Changeset [44824] by jparent@chromium.org

2009-06-18 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/5207369-expected.txt: Added.
  • editing/execCommand/5207369.html:
  • editing/execCommand/5210032-expected.txt: Added.
  • editing/execCommand/5210032.html:
  • editing/execCommand/5432254-1-expected.txt: Added.
  • editing/execCommand/5432254-1.html:
  • platform/mac/editing/execCommand/5207369-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5207369-expected.png: Removed.
  • platform/mac/editing/execCommand/5207369-expected.txt: Removed.
  • platform/mac/editing/execCommand/5210032-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5210032-expected.png: Removed.
  • platform/mac/editing/execCommand/5210032-expected.txt: Removed.
  • platform/mac/editing/execCommand/5432254-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5432254-1-expected.png: Removed.
  • platform/mac/editing/execCommand/5432254-1-expected.txt: Removed.
  • platform/qt/editing/execCommand/5207369-expected.txt: Removed.
  • platform/qt/editing/execCommand/5210032-expected.txt: Removed.
  • platform/qt/editing/execCommand/5432254-1-expected.txt: Removed.
14:21 Changeset [44823] by jparent@chromium.org

Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/5142012-3-expected.txt: Added.
  • editing/execCommand/5142012-3.html:
  • editing/execCommand/5144139-1-expected.txt: Added.
  • editing/execCommand/5144139-1.html:
  • editing/execCommand/5164796-expected.txt: Added.
  • editing/execCommand/5164796.html:
  • platform/mac/editing/execCommand/5142012-3-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5142012-3-expected.png: Removed.
  • platform/mac/editing/execCommand/5142012-3-expected.txt: Removed.
  • platform/mac/editing/execCommand/5144139-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5144139-1-expected.png: Removed.
  • platform/mac/editing/execCommand/5144139-1-expected.txt: Removed.
  • platform/mac/editing/execCommand/5164796-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5164796-expected.png: Removed.
  • platform/mac/editing/execCommand/5164796-expected.txt: Removed.
  • platform/qt/editing/execCommand/5142012-3-expected.txt: Removed.
  • platform/qt/editing/execCommand/5144139-1-expected.txt: Removed.
  • platform/qt/editing/execCommand/5164796-expected.txt: Removed.
14:13 Changeset [44822] by jparent@chromium.org

Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests.

This

fixes the bug 26336 partially.

  • editing/execCommand/4916583-expected.txt: Added.
  • editing/execCommand/4916583.html:
  • editing/execCommand/5119244-expected.txt: Added.
  • editing/execCommand/5119244.html:
  • editing/execCommand/5120591-expected.txt: Added.
  • editing/execCommand/5120591.html:
  • platform/mac/editing/execCommand/4916583-expected.checksum: Removed.
  • platform/mac/editing/execCommand/4916583-expected.png: Removed.
  • platform/mac/editing/execCommand/4916583-expected.txt: Removed.
  • platform/mac/editing/execCommand/5119244-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5119244-expected.png: Removed.
  • platform/mac/editing/execCommand/5119244-expected.txt: Removed.
  • platform/mac/editing/execCommand/5120591-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5120591-expected.png: Removed.
  • platform/mac/editing/execCommand/5120591-expected.txt: Removed.
  • platform/qt/editing/execCommand/4916583-expected.txt: Removed.
  • platform/qt/editing/execCommand/5119244-expected.txt: Removed.
  • platform/qt/editing/execCommand/5120591-expected.txt: Removed.
13:47 Changeset [44821] by bfulgham@webkit.org

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

Move some common functions out of platform files and into
the common implementation.

https://bugs.webkit.org/show_bug.cgi?id=26425.
Add a new platform context method (flush) so that the
getWindowsContext method can be consolidated into the common
GraphicsContextWin.cpp file.


  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::flush):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::flush):
  • platform/graphics/win/GraphicsContextCGWin.cpp: Remove getWindowContext method.
  • platform/graphics/win/GraphicsContextCairoWin.cpp: Remove getWindowContext method and fillWithClearColor methods.
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::fillWithClearColor): Moved from *CairoWin.cpp (WebCore::GraphicsContext::getWindowsContext): Moved from *CairoWin.cpp
13:44 Changeset [44820] by christian@webkit.org

2009-06-18 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::loadDone): (WebKit::FrameLoaderClient::dispatchDidFinishLoad): (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidFailLoad): Introduce the static function loadDone to emit "load-done" and update the status and update the relevent places. We missed some status notifications before.
13:30 Changeset [44819] by kov@webkit.org

2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Be consistent in always using the term URI instead of URL in the
documentation of WebKitWebView signals.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
13:28 Changeset [44818] by ojan@chromium.org

2009-06-18 Ojan Vafai <ojan@chromium.org>

Reviewed by Oliver Hunt.

Remove code that I accidentally committed in r44811.

  • editing/markup.cpp: (WebCore::createMarkup):
13:25 Changeset [44817] by simon.fraser@apple.com

2009-06-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6983207> Non-layer content is not re-rendered when transition
starts sometimes (with hardware acceleration).

When deciding which RenderLayers should be composited, when a layer goes into
compositing mode we repaint the old location. However, we did that before
we'd looked at all the factors that may force a layer to composite, so missed
some cases. Fix by doing the repaint once we really know whether it's going
to composite.

Test: compositing/repaint/become-overlay-composited-layer.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
12:58 Changeset [44816] by ap@webkit.org

Reviewed by Maciej Stachowiak and Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=26510
Add tests for authentication behavior with cross-origin XMLHttpRequest

  • http/tests/xmlhttprequest/cross-origin-authorization-expected.txt: Added.
  • http/tests/xmlhttprequest/cross-origin-authorization.html: Added.
  • http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
  • http/tests/xmlhttprequest/cross-origin-no-authorization.html: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-authorization.php: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-preset-authorization-frame.html: Added.
  • platform/mac-tiger/Skipped:
12:21 Changeset [44815] by darin@apple.com

2009-06-18 Darin Adler <darin@apple.com>

Rubber stamped by Mark Rowe.

  • DumpRenderTree/mac/DumpRenderTreeWindow.mm: (-[DumpRenderTreeWindow close]): Resolved crashes seen during regression tests. The close method can be called on a window that's already closed so we can't assert here.
12:19 Changeset [44814] by simon.fraser@apple.com

2009-06-18 Simon Fraser <simon.fraser@apple.com>

Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined, and
the Tiger build where QTMovieLayer does not exist.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::destroyQTMovieLayer): (WebCore::MediaPlayerPrivate::currentRenderingMode): (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::tearDownVideoRendering): (WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):
12:18 Changeset [44813] by darin@apple.com

JavaScriptCore:

2009-06-17 Darin Adler <darin@apple.com>

Reviewed by Oliver Hunt.

Bug 26429: Make JSON.stringify non-recursive so it can handle objects
of arbitrary complexity
https://bugs.webkit.org/show_bug.cgi?id=26429

For marking I decided not to use gcProtect, because this is inside the engine
so it's easy enough to just do marking. And that darned gcProtect does locking!
Oliver tried to convince me to used MarkedArgumentBuffer, but the constructor
for that class says "FIXME: Remove all clients of this API, then remove this API."

  • runtime/Collector.cpp: (JSC::Heap::collect): Add a call to JSONObject::markStringifiers.
  • runtime/CommonIdentifiers.cpp: (JSC::CommonIdentifiers::CommonIdentifiers): Added emptyIdentifier.
  • runtime/CommonIdentifiers.h: Ditto.
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Initialize firstStringifierToMark to 0.
  • runtime/JSGlobalData.h: Added firstStringifierToMark.
  • runtime/JSONObject.cpp: Cut down the includes to the needed ones only. (JSC::unwrapNumberOrString): Added. Helper for unwrapping number and string objects to get their number and string values. (JSC::ReplacerPropertyName::ReplacerPropertyName): Added. The class is used to wrap an identifier or integer so we don't have to do any work unless we actually call a replacer. (JSC::ReplacerPropertyName::value): Added. (JSC::gap): Added. Helper function for the Stringifier constructor. (JSC::PropertyNameForFunctionCall::PropertyNameForFunctionCall): Added. The class is used to wrap an identifier or integer so we don't have to allocate a number or string until we actually call toJSON or a replacer. (JSC::PropertyNameForFunctionCall::asJSValue): Added. (JSC::Stringifier::Stringifier): Updated and moved out of the class definition. Added code to hook this into a singly linked list for marking. (JSC::Stringifier::~Stringifier): Remove from the singly linked list. (JSC::Stringifier::mark): Mark all the objects in the holder stacks. (JSC::Stringifier::stringify): Updated. (JSC::Stringifier::appendQuotedString): Tweaked and streamlined a bit. (JSC::Stringifier::toJSON): Renamed from toJSONValue. (JSC::Stringifier::appendStringifiedValue): Renamed from stringify. Added code to use the m_holderStack to do non-recursive stringify of objects and arrays. This code also uses the timeout checker since in pathological cases it could be slow even without calling into the JavaScript virtual machine. (JSC::Stringifier::willIndent): Added. (JSC::Stringifier::indent): Added. (JSC::Stringifier::unindent): Added. (JSC::Stringifier::startNewLine): Added. (JSC::Stringifier::Holder::Holder): Added. (JSC::Stringifier::Holder::appendNextProperty): Added. This is the function that handles the format of arrays and objects. (JSC::JSONObject::getOwnPropertySlot): Moved this down to the bottom of the file so the JSONObject class is not interleaved with the Stringifier class. (JSC::JSONObject::markStringifiers): Added. Calls mark. (JSC::JSONProtoFuncStringify): Streamlined the code here. The code to compute the gap string is now a separate function.
  • runtime/JSONObject.h: Made everything private. Added markStringifiers.

LayoutTests:

2009-06-17 Darin Adler <darin@apple.com>

Reviewed by Oliver Hunt.

Bug 26429: Make JSON.stringify non-recursive so it can handle objects
of arbitrary complexity
https://bugs.webkit.org/show_bug.cgi?id=26429

  • fast/js/JSON-stringify-expected.txt: Updated.
  • fast/js/resources/JSON-stringify.js: Changed the infinite object and infinite array tests to instead just test something a fixed number of levels deep. Otherwise we end up with an infinite loop in the test, which would lead to the slow-script dialog in the production web browser. Also raised the number from 512 to 2048 since there's no fixed limit any more.
12:14 EFLWebKit edited by tonikitoo@gmail.com
(diff)
12:06 Changeset [44812] by simon.fraser@apple.com

2009-06-18 Simon Fraser <simon.fraser@apple.com>

Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::currentRenderingMode): (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::tearDownVideoRendering):
11:58 Changeset [44811] by ojan@chromium.org

2009-06-17 Erik Arvidsson <arv@chromium.org>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=15189
Adds the HTML5 input event support for textarea.


Also, moves the oninput attribute parse handling to HTMLElement so that
it can be set on any HTML element so that bubbling events can be handled
using HTML attribute handlers.

Test: fast/forms/textarea-input-event.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
11:53 Changeset [44810] by krit@webkit.org

2009-06-18 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Share code between filterEffects
https://bugs.webkit.org/show_bug.cgi?id=26479

Share more code of filter effects. The imageBuffer creation can move to
FilterEffect ant every effect asks for the GraphicsContext. Move the
drawingRect calculation to FilterEffect.

  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::calculateDrawingRect): (WebCore::FilterEffect::getEffectContext):
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply):
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
11:52 Changeset [44809] by simon.fraser@apple.com

2009-06-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=26499

Support hardware-accelerationed rendering of video elements.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks): (WebCore::HTMLMediaElement::mediaPlayerRepaint): Just move these methods to group the render-related methods together.

(WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated):
Call out method to ask the RenderLayerCompositor if presentation of this video
can be acclerated. It might say no, if, for example, the video has a reflection.

(WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer):
Fetch the GraphicsLayer from the RenderVideo that will host the movie layer.

  • html/HTMLMediaElement.h: Reordered the rendering-related methods, and added two methods related to video acceleration.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::acceleratedRenderingStateChanged): Called by the rendering system when it determines that the video must go into, or fall off of the hardware-accelerated path.

(WebCore::MediaPlayer::supportsAcceleratedRendering):
Method to say whether the media engine supports accelerated rendering.

  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerRepaint): (WebCore::MediaPlayerClient::mediaPlayerSizeChanged): Moved.

(WebCore::MediaPlayerClient::mediaPlayerRenderingCanBeAccelerated):
(WebCore::MediaPlayerClient::mediaPlayerGraphicsLayer):
New methods to ask the client if the rendering system can support accelerated
rendering, and to get a GraphicsLayer to plug the movie layer into.

  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsAcceleratedRendering): (WebCore::MediaPlayerPrivateInterface::acceleratedRenderingStateChanged): Forwarding methods from MediaPlayer.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Some new methods related to using a QTMovieLayer, and to simplify the rendering mode logic.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::destroyQTMovieLayer): Methods to create and destroy the QTMovieLayer.

(WebCore::MediaPlayerPrivate::currentRenderingMode):
(WebCore::MediaPlayerPrivate::preferredRenderingMode):
Methods to clarify the code that decides which of the 3 rendering modes to use.

(WebCore::MediaPlayerPrivate::setUpVideoRendering):
Changed to use the new rendering mode methods.

(WebCore::MediaPlayerPrivate::tearDownVideoRendering):
Destroy the layer if we have one.

(WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):
Small utility method.

(WebCore::MediaPlayerPrivate::updateStates):
Move the call to setUpVideoRendering() to before we send out the state notifications,
so that we will have created the rendering objects already.

(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
Return true if we have QTMovieLayer.

(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
We've been told that we went into or out of accelerated mode; maybe reset
the renderer, and set the layer if we have to.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::rendererContentChanged): We may need to udpate compositing layers if the video went into accelerated mode.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::canUseDirectCompositing): Add smarts to deal with video, which allows us to avoid extra backing store.

(WebCore::RenderLayerBacking::contentsBox):
Use the videoBox to use the content layer for video layers.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateLayerCompositingState): Poke the RenderVideo if the state changed.

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
Handle an edge case when the video element itself is a stacking context
because of opacity or transform.

(WebCore::RenderLayerCompositor::canAccelerateVideoRendering):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
Allow video to throw us into compositing mode if the media engine supports it.

  • rendering/RenderLayerCompositor.h: New methods related to video.
  • rendering/RenderVideo.h:
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer): Call rendererContentChanged() to give the compositor a change to throw the video into compositing mode.

(WebCore::RenderVideo::supportsAcceleratedRendering):
(WebCore::RenderVideo::acceleratedRenderingStateChanged):
(WebCore::RenderVideo::videoGraphicsLayer):
Methods to allow the MediaPlayer to do rendering-related stuff via the media element.

11:40 Changeset [44808] by rwlbuis@webkit.org

Reviewed by Niko.

https://bugs.webkit.org/show_bug.cgi?id=26385
Root SVG element is not checked on requiredFeatures, requiredExtension like other elements

Also do the isValid check for outer <svg>.

Test: svg/custom/outer-svg-unknown-feature.svg

11:08 Changeset [44807] by simon.fraser@apple.com

2009-06-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=26499

New expected results after making <video> elements get RenderLayers.

  • platform/mac/fast/replaced/border-radius-clip-expected.txt:
10:54 Changeset [44806] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6913221> REGRESSION (Safari 3-4): Search field on apple.com cuts entered text

Test: fast/forms/search-vertical-alignment.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): Vertically center the

the search field's inner block.

LayoutTests:

Reviewed by Darin Adler.

  • test and updated result for <rdar://problem/6913221> REGRESSION (Safari 3-4): Search field on apple.com cuts entered text
  • fast/forms/search-vertical-alignment.html: Added.
  • platform/mac/fast/forms/search-vertical-alignment-expected.checksum: Added.
  • platform/mac/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt: Added.
  • platform/mac/fast/forms/search-zoomed-expected.checksum:
  • platform/mac/fast/forms/search-zoomed-expected.png:
  • platform/mac/fast/forms/search-zoomed-expected.txt:
09:30 EFLWebKit edited by tonikitoo@gmail.com
(diff)
09:28 EFLWebKit edited by tonikitoo@gmail.com
(diff)
08:08 Changeset [44805] by hausmann@webkit.org

2009-06-18 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Simon Hausmann.

Fix compilation with Symbian WINSCW compiler, which produced
multiple definitions of the CSSPrimitiveValue conversion operators.

It turns out that they are defined inline but not declared inline.

Adding the inline keyword to the declaration fixes the build.

07:45 Changeset [44804] by hausmann@webkit.org

2009-06-18 Friedemann Kleint <Friedemann.Kleint@nokia.com>

Reviewed by Simon Hausmann.

Fixed MinGW compilation.

07:41 Changeset [44803] by hausmann@webkit.org

2009-06-18 Markus Goetz <Markus.Goetz@nokia.com>

Reviewed by Simon Hausman.

Clarify in docs how to compile with debug information.

07:40 EFLWebKit edited by tonikitoo@gmail.com
(diff)
06:42 Changeset [44802] by ariya@webkit.org

2009-06-18 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] When writing an URL to the clipboard, save the corresponding title
in the mime data as well.

  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeURL):
06:40 Changeset [44801] by ariya@webkit.org

2009-06-18 Jakub Wieczorek <faw217@gmail.com>

[Qt] Fix build. Add HTMLDataGridElement.

  • WebCore.pro:
03:25 Changeset [44800] by jmalonzo@webkit.org

2009-06-18 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix.

Add HTMLDataGridElement header and IDL to the build script.

  • GNUmakefile.am:
00:55 Changeset [44799] by abarth@webkit.org

WebCore:

2009-06-18 Chris Evans <scarybeasts@gmail.com>

Reviewed by Adam Barth.

Fix 8-digit long hex entities. Fixes bug 26454
https://bugs.webkit.org/show_bug.cgi?id=26454

Test: fast/parser/eightdigithexentity.html

  • html/HTMLTokenizer.cpp: fix off-by-ones.

LayoutTests:

2009-06-18 Chris Evans <scarybeasts@gmail.com>

Reviewed by Adam Barth.

Added test for bug 26454 (broken 8-digit hex entities).
https://bugs.webkit.org/show_bug.cgi?id=26454

  • fast/parser/eightdigithexentity-expected.txt: Added.
  • fast/parser/eightdigithexentity.html: Added.
00:08 Changeset [44798] by levin@chromium.org

2009-06-18 David Levin <levin@chromium.org>

Fix chromium linux build.

Fixes a mistake that happened during the complicated merge for
landing r44775, r44776, r44777.

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::create):

06/17/09:

23:40 Changeset [44797] by oliver@apple.com

<rdar://problem/6974140> REGRESSION(r43849): Crash in cti_op_call_NotJSFunction when getting directions on maps.google.com

Reviewed by Gavin Barraclough

Roll out r43849 as it appears that we cannot rely on the address of
an objects property storage being constant even if the structure is
unchanged.

22:50 Changeset [44796] by barraclough@apple.com

2009-06-17 Gavin Barraclough <barraclough@apple.com>

Rubber Stamped by Mark Rowe.

Fully revert r44492 & r44748 while we fix a bug they cause on internal builds <rdar://problem/6955963>.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):
  • jit/JITStubs.cpp: (JSC::): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h:
19:37 Changeset [44795] by barraclough@apple.com

JavaScriptCore:

2009-06-17 Gavin Barraclough <barraclough@apple.com>

Reviewed by Mark Rowe.

<rdar://problem/6947426> sunspider math-cordic.js exhibits different intermediate results running 32-bit vs. 64-bit

On 64-bit, NaN-encoded values must be detagged before they can be used in rshift.

No performance impact.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift):

LayoutTests:

2009-06-17 Gavin Barraclough <barraclough@apple.com>

Reviewed by Mark Rowe.

Add tests to check shifts by non-constant amounts.

  • fast/js/kde/operators-expected.txt:
  • fast/js/kde/resources/operators.js:
18:49 Changeset [44794] by simon.fraser@apple.com

2009-06-17 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26499

First step to making video rendering be hardware-accelerated:
make <video> elements get self-painting RenderLayers, and add
an isVideo() virtual method to RenderObject.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): (WebCore::HTMLMediaElement::mediaPlayerSizeChanged):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer):
  • rendering/RenderObject.h: (WebCore::RenderObject::isVideo):
  • rendering/RenderVideo.h: (WebCore::RenderVideo::requiresLayer): (WebCore::RenderVideo::isVideo):
18:22 Changeset [44793] by bfulgham@webkit.org

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Refactor a few common routines in the various Windows ports
and reduce some duplicated code.

(1) Create TransformationMatrix XFORM casting operator, and

switch various XFORM structure uses to utilize it.

(2) Push concatCTM call to GraphicsContextWin now that the

TransformationMatrix can directly create XFORM (rather
than converting to CGAffineTransform/cairo_matrix_t first.)

  • WebCore.vcproj/WebCore.vcproj: Add new BitmapInfo structure.
  • platform/graphics/transforms/TransformationMatrix.h:
  • platform/graphics/win/GraphicsContextCGWin.cpp:
  • platform/graphics/win/GraphicsContextCairoWin.cpp:
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/win/TransformationMatrixWin.cpp: Added. (WebCore::TransformationMatrix::operator XFORM): New operator
18:05 Changeset [44792] by simon.fraser@apple.com

2009-06-17 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

Update results after enabling 3d rendering on SnowLeopard.

  • platform/mac-leopard/fast/media/mq-transform-02-expected.checksum: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.checksum.
  • platform/mac-leopard/fast/media/mq-transform-02-expected.png: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.png.
  • platform/mac-leopard/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.txt.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.checksum: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.checksum.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.png: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.png.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.txt. Copy the old "mac" results to "mac-leopard" since 3d-rendering is disabled there.
  • platform/mac/fast/media/mq-transform-02-expected.checksum:
  • platform/mac/fast/media/mq-transform-02-expected.png:
  • platform/mac/fast/media/mq-transform-02-expected.txt:
  • platform/mac/fast/media/mq-transform-03-expected.checksum:
  • platform/mac/fast/media/mq-transform-03-expected.png:
  • platform/mac/fast/media/mq-transform-03-expected.txt: New "mac" results for 3d rendering enabled.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Update the results now that these tests are active.
17:41 Changeset [44791] by sfalken@apple.com

WebKit/win:

2009-06-17 Steve Falkenburg <sfalken@apple.com>

Consolidate WebKit COM interfaces.
Moved IID from the highest numbered COM interface to the first interface and combined all methods.

Numbered interfaces can be combined since the latest shipping Safari 4 supports the latest interfaces.


Reviewed by Adam Roben.

  • Interfaces/IWebFrameLoadDelegate.idl:
  • Interfaces/IWebFrameLoadDelegatePrivate.idl:
  • Interfaces/IWebResourceLoadDelegatePrivate.idl:
  • Interfaces/IWebUIDelegate.idl:
  • Interfaces/IWebUIDelegatePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebContextMenuClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebInspectorDelegate.h:
  • WebFrame.cpp:
  • WebView.cpp:

WebKitTools:

2009-06-17 Steve Falkenburg <sfalken@apple.com>

Updated for consolidated WebKit COM interfaces.


Reviewed by Adam Roben.

  • DumpRenderTree/win/FrameLoadDelegate.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.h:
  • DumpRenderTree/win/UIDelegate.cpp:
  • DumpRenderTree/win/UIDelegate.h:
  • WinLauncher/WinLauncher.h:
17:37 Changeset [44790] by bfulgham@webkit.org

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Non-CG Windows build fix after @r44758.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderTheme::themeForPage):
17:32 Changeset [44789] by bfulgham@webkit.org

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Refactor a few common routines in the various Windows ports
and reduce some duplicated code.
https://bugs.webkit.org/show_bug.cgi?id=26425.

Refactor use of BITMAPINFO for the new BitmapInfo structure.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/BitmapInfo.cpp: Added. (WebCore::bitmapInfoForSize): (WebCore::BitmapInfo::create): (WebCore::BitmapInfo::createBottomUp):
  • platform/win/BitmapInfo.h: Added.
  • platform/graphics/win/GraphicsContextCairoWin.cpp:
  • platform/graphics/win/GraphicsContextCGWin.cpp:
  • platform/graphics/win/TransformationMatrixWin.cpp: Added. (WebCore::TransformationMatrix::operator XFORM): New operator
  • platform/win/DragImageCGWin.cpp: (WebCore::allocImage):
  • platform/win/DragImageCairoWin.cpp: (WebCore::allocImage):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
17:28 Changeset [44788] by mrowe@apple.com

Create Safari 4.0.1 release tag, consisting of version 5530.18 of WebCore and WebKit. JavaScriptCore and JavaScriptGlue remain unchanged.

17:21 Changeset [44787] by mrowe@apple.com

Create Safari 4.0 release tag, consisting of version x530.17 of each project.

15:37 Changeset [44786] by aroben@apple.com

Remove unnecessary 6th parameter from SOFT_LINK_OPTIONAL

Reviewed by Mark Rowe.

  • platform/graphics/win/ColorSafari.cpp: Removed the 6th parameter and an unnecessary parameter name.
  • platform/win/SoftLinking.h: Removed the unused 6th parameter.
15:10 Changeset [44785] by aroben@apple.com

Make Settings::shouldPaintNativeControls default to true

This matches the default up in WebKit (that was changed in r43318).

Fixes Bug 26493: REGRESSION (r44758): First tab always uses Mac-style
form controls
<https://bugs.webkit.org/show_bug.cgi?id=26493>

Reviewed by Darin Adler and Dave Hyatt.

No test possible since DRT always uses Mac-style form controls.

  • page/Settings.cpp: Changed the initial value of gShouldPaintNativeControls to true.
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderTheme::themeForPage): Added a FIXME about the design flaw here involving querying Settings before it's been initialized.
14:42 WebKit Team edited by ben@webkit.org
(diff)
14:26 Changeset [44784] by hyatt@apple.com

Update layout test results for addition of datagrid element.

14:24 Changeset [44783] by levin@chromium.org

2009-06-17 David Levin <levin@chromium.org>

Fix chromium Windows build.

A mistake that happened during the complicated merge for
landing r44775, r44776, r44777.

  • rendering/RenderThemeChromiumWin.h: (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin):
14:17 EFLWebKit edited by tonikitoo@gmail.com
(diff)
14:16 Changeset [44782] by eric.carlson@apple.com

2009-06-17 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6981193> Crash in MediaControlInputElement::attachToParent

  • rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::attachToParent): NULL check element renderer or parent renderer. (WebCore::MediaControlInputElement::attachToParent): Ditto.
14:03 EFLWebKit edited by tonikitoo@gmail.com
(diff)
14:02 EFLWebKit edited by tonikitoo@gmail.com
(diff)
13:51 EFLWebKit edited by tonikitoo@gmail.com
(diff)
13:46 EFLWebKit edited by tonikitoo@gmail.com
(diff)
13:45 EFLWebKit edited by tonikitoo@gmail.com
(diff)
13:31 EFLWebKit edited by tonikitoo@gmail.com
(diff)
13:11 Changeset [44781] by weinig@apple.com

2009-06-17 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

  • security/index.html: Fix some typos.
13:05 Changeset [44780] by hyatt@apple.com

2009-06-17 David Hyatt <hyatt@apple.com>

Fix Windows build. There's no HTMLDataGridElement.cpp file yet.

  • html/HTMLElementsAllInOne.cpp:
12:56 Changeset [44779] by weinig@apple.com

2009-06-17 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Move security policy to security/index.html so that
webkit.org/security/ works.

  • nav.inc:
  • security/index.html: Copied from security/security-policy.html.
  • security/security-policy.html: Removed.
12:33 Changeset [44778] by hyatt@apple.com

WebCore:

2009-06-17 David Hyatt <hyatt@apple.com>

Reviewed by Adam Roben and Anders Carlsson.

Stub out the HTMLDataGridElement.

  • DerivedSources.make:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing):
  • html/HTMLDataGridElement.h: Added. (WebCore::HTMLDataGridElement::HTMLDataGridElement): (WebCore::HTMLDataGridElement::tagPriority):
  • html/HTMLDataGridElement.idl: Added.
  • html/HTMLElement.cpp: (WebCore::inlineTagList):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::isAffectedByResidualStyle):
  • html/HTMLTagNames.in:

LayoutTests:

2009-06-17 David Hyatt <hyatt@apple.com>

Reviewed by Anders Carlsson.

Update window properties layout test for HTMLDataGridElement addition.

  • fast/dom/Window/window-properties-expected.txt:
12:31 Changeset [44777] by levin@chromium.org

2009-06-17 David Levin <levin@chromium.org>

Reviewed by NOBODY (chromium build fix).

Fix typo in previous changes.

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::defaultGUIFont):
12:18 Changeset [44776] by levin@chromium.org

2009-06-17 Albert J. Wong <ajwong@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26148
Remove common code from RenderThemeChromiumWin that is shared with
RenderThemeChromiumSkia.

Also move supportsControlTints to RenderThemeChromiumLinux since it
is linux specific.

There are no tests changed because this just removes functions with
duplicate implementations between the base and derived classes.

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::supportsControlTints):
  • rendering/RenderThemeChromiumLinux.h:
  • rendering/RenderThemeChromiumSkia.cpp:
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::): (WebCore::getNonClientMetrics): (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::systemFont): (WebCore::RenderThemeChromiumWin::paintCheckbox): (WebCore::RenderThemeChromiumWin::paintRadio): (WebCore::RenderThemeChromiumWin::paintSliderThumb): (WebCore::RenderThemeChromiumWin::caretBlinkIntervalInternal):
  • rendering/RenderThemeChromiumWin.h:
12:18 Changeset [44775] by levin@chromium.org

2009-06-17 Albert J. Wong <ajwong@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26148
Move RenderThemeChromiumSkia into its own file. This is purely a code move.

  • rendering/RenderThemeChromiumLinux.cpp:
  • rendering/RenderThemeChromiumLinux.h:
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::): (WebCore::setSizeIfAuto): (WebCore::mediaElementParent): (WebCore::RenderThemeChromiumSkia::defaultGUIFont): (WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::~RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumSkia::extraQuirksStyleSheet): (WebCore::RenderThemeChromiumSkia::extraMediaControlsStyleSheet): (WebCore::RenderThemeChromiumSkia::supportsHover): (WebCore::RenderThemeChromiumSkia::supportsFocusRing): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformTextSearchHighlightColor): (WebCore::RenderThemeChromiumSkia::caretBlinkInterval): (WebCore::RenderThemeChromiumSkia::systemFont): (WebCore::RenderThemeChromiumSkia::minimumMenuListSize): (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::paintRadio): (WebCore::RenderThemeChromiumSkia::setRadioSize): (WebCore::brightenColor): (WebCore::paintButtonLike): (WebCore::RenderThemeChromiumSkia::paintButton): (WebCore::RenderThemeChromiumSkia::paintTextField): (WebCore::RenderThemeChromiumSkia::paintTextArea): (WebCore::RenderThemeChromiumSkia::paintSearchField): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumSkia::paintMediaButtonInternal): (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): (WebCore::RenderThemeChromiumSkia::adjustMenuListStyle): (WebCore::RenderThemeChromiumSkia::paintMenuList): (WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumSkia::paintMenuListButton): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::caretBlinkIntervalInternal): (WebCore::RenderThemeChromiumSkia::menuListInternalPadding):
  • rendering/RenderThemeChromiumSkia.h: (WebCore::RenderThemeChromiumSkia::supportsControlTints):
12:17 Changeset [44774] by levin@chromium.org

2009-06-17 Albert J. Wong <ajwong@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26148
Extract RenderThemeChromiumSkia out of RenderThemeChromiumLinux. This
is mostly a code shuffle. The non-suffle changes are:

1) Creation of a caretBlinkIntervalInternal.
2) Moving of some inline functions into the implementation files.
3) Changing of defaultGUIFont into a static class constant from a

static function. Also the type is changed to String.

4) Changing of defaultFontSize into a static class constant from a

static variable in the file scope.

5) The static supportsFocus function was collapsed into

supportsFocusRing.

6) Split the extraDefaultStyleSheet into Skia and Linux versions.

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumSkia::defaultGUIFont): (WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::~RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumSkia::extraQuirksStyleSheet): (WebCore::RenderThemeChromiumSkia::extraMediaControlsStyleSheet): (WebCore::RenderThemeChromiumSkia::supportsHover): (WebCore::RenderThemeChromiumSkia::supportsFocusRing): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformTextSearchHighlightColor): (WebCore::RenderThemeChromiumSkia::caretBlinkInterval): (WebCore::RenderThemeChromiumSkia::systemFont): (WebCore::RenderThemeChromiumSkia::minimumMenuListSize): (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::paintRadio): (WebCore::RenderThemeChromiumSkia::setRadioSize): (WebCore::RenderThemeChromiumSkia::paintButton): (WebCore::RenderThemeChromiumSkia::paintTextField): (WebCore::RenderThemeChromiumSkia::paintTextArea): (WebCore::RenderThemeChromiumSkia::paintSearchField): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumSkia::paintMediaButtonInternal): (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): (WebCore::RenderThemeChromiumSkia::adjustMenuListStyle): (WebCore::RenderThemeChromiumSkia::paintMenuList): (WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumSkia::paintMenuListButton): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::caretBlinkIntervalInternal): (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::~RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::systemColor): (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumSkia::menuListInternalPadding):
  • rendering/RenderThemeChromiumLinux.h:
12:07 Changeset [44773] by weinig@apple.com

2009-06-13 Sam Weinig <sam@webkit.org>

Reviewed by Timothy Hatcher.

Add WebKit Security Policy and member list of the WebKit Security Group.

  • nav.inc:
  • security: Added.
  • security/security-group-members.html: Added.
  • security/security-policy.html: Added.
12:02 Changeset [44772] by aroben@apple.com

Add a SOFT_LINK_OPTIONAL macro

This macro is useful when soft-linking functions that are present in
only some versions of a particular library (e.g., APIs added in
Windows Vista that aren't available on Windows XP).

Reviewed by Ada Chan.

  • platform/graphics/win/ColorSafari.cpp: (WebCore::focusRingColor): Use the SoftLinking.h macros instead of doing the soft-link ourselves. Also removed an unused call to focusRingColor.isValid().
  • platform/win/SoftLinking.h: Added SOFT_LINK_OPTIONAL.
11:25 Changeset [44771] by bfulgham@webkit.org

2009-06-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Gustavo Noronha Silva.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26470.
The use of zero-width or zero-height rectangles in generating
gradients caused Windows Cairo to crash, and webkitgtk to
produce invalid images.

11:22 Changeset [44770] by ojan@chromium.org

2009-06-17 Ojan Vafai <ojan@chromium.org>

Reviewed by NOBODY (OOPS!).

If loading a font fails because of the sandbox, we ask the browser process to
try to load it by calling ensureFontLoaded. If it still fails after
ensureFontLoaded, we hit a ASSERT_NOT_REACHED.

This case happens once in a while during browser shutdown. The browser will
queue a message to the renderer to shutdown, and will then stop answering sync
messages from the renderer. If the renderer is still loading a page during this
time, it might try to call the browser process to ask to load a font. The
browser process will ignore the request, and the font will fail to load, even
after the second try.

This is unfortunate, but there is no real risk here, since the renderer will be
going away as soon as it processes another message.

This can't be layout tested as it depends on the sandbox.

https://bugs.webkit.org/show_bug.cgi?id=26484

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter):
11:21 Changeset [44769] by eric.carlson@apple.com

2009-06-17 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=26482
<rdar://problem/6978590> When setting playback rate to 0, the audio element stops
playing (doesn't resume later)

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setRate): Always set the rate, even when "paused".
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::setRate): Ditto.
10:13 Changeset [44768] by aroben@apple.com

Add all the generated JS*.cpp files back to WebCore.vcproj

They are not compiled by the vcproj directly. Instead they are
compiled as part of DerivedSources.cpp. Having them listed in the
vcproj makes them be included in Project Find, etc.

Rubber-stamped in advance by Steve Falkenburg.

  • WebCore.vcproj/WebCore.vcproj:
10:01 Changeset [44767] by darin@chromium.org

2009-06-17 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

Don't fire redundant 'change' events for a file upload form.
https://bugs.webkit.org/show_bug.cgi?id=26471

  • platform/FileChooser.cpp: (WebCore::FileChooser::chooseFiles): Suppress change event if the existing selected files and the incoming selected files are equal. (WebCore::FileChooser::chooseIcon): Returns 0 if there is no selected files.
09:45 Changeset [44766] by treat@webkit.org

2009-06-17 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=23155
Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.

09:39 Changeset [44765] by treat@webkit.org

2009-06-17 George Staikos <george.staikos@torchmobile.com>

Reviewed by Adam Treat.

https://bugs.webkit.org/show_bug.cgi?id=23155
Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.

08:54 Changeset [44764] by aroben@apple.com

Fix Skipped file format after r44519

  • platform/qt/Skipped:
  • platform/win/Skipped: Removed bogus ": Added."s in these files.
08:42 Changeset [44763] by aroben@apple.com

Speculative Mac build fix

  • page/Page.h: Forward-declare RenderTheme instead of including RenderTheme.h so that we don't need to make RenderTheme.h a private header for WebKit's benefit.
  • editing/SelectionController.cpp:
  • rendering/InlineTextBox.cpp:
  • rendering/RenderObject.cpp: Added #includes of RenderTheme.h.
08:32 Changeset [44762] by aroben@apple.com

Speculative Mac build fix

  • rendering/RenderThemeMac.mm: (WebCore::RenderTheme::create): Added.
08:26 Changeset [44761] by aroben@apple.com

Speculative Mac build fix

  • rendering/RenderThemeMac.mm: (WebCore::RenderTheme::themeForPage): Remove the name of an unused parameter.
08:14 Changeset [44760] by aroben@apple.com

Speculative Mac build fix

  • page/Page.cpp: (WebCore::Page::Page): Change the initializer order to match the declaration order.
07:52 Changeset [44759] by aroben@apple.com

2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Follow up to bug https://bugs.webkit.org/show_bug.cgi?id=26278
Patch that make WebCore have a RenderTheme per page

Make the Qt implementation of RenderTheme create a theme per page,
and use the QStyle associated with the view of each page, in order
to make the QWidget setStyle() method work as advertised.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::qStyle): (WebCore::findFrameLineWidth): (WebCore::inflateButtonRect): (WebCore::RenderThemeQt::adjustRepaintRect): (WebCore::RenderThemeQt::isControlStyled): (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::setButtonPadding): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::setPopupPadding):
  • platform/qt/RenderThemeQt.h:
07:52 Changeset [44758] by aroben@apple.com

2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Dave Hyatt and Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=26278
Patch that make WebCore have a RenderTheme per page

Create a different RenderTheme per page, so that RenderTheme has
access to page specific theming. This is needed for the Qt port, as Qt
supports setting the theme (style) per widget.

This change was suggested and discussed with Dave Hyatt.

More detailed:

1) Create a theme per page or one global one, depending on the needs

of the platform.

2) Add an accesser to the theme from RenderObject.
3) Change all uses of the theming to access the theme through

RenderObject, using the global default theme as fallback, when the
document of RenderObject has no page.
When we don't have access to a RenderObject, use the default theme.

4) Modify all RenderTheme platform implementations to work with the

above changes, still creating only one global theme.

02:11 Changeset [44757] by barraclough@apple.com

JavaScriptCore:

2009-06-17 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6974175> ASSERT in JITStubs.cpp at appsaccess.apple.com

Remove PropertySlot::putValue - PropertySlots should only be used for getting,
not putting. Rename JSGlobalObject::getOwnPropertySlot to hasOwnPropertyForWrite,
which is what it really was being used to ask, and remove some other getOwnPropertySlot
& getOwnPropertySlotForWrite methods, which were unused and likely to lead to confusion.

  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::hasOwnPropertyForWrite):
  • runtime/JSObject.h:
  • runtime/JSStaticScopeObject.cpp:
  • runtime/JSStaticScopeObject.h:
  • runtime/PropertySlot.h:

WebCore:

2009-06-17 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6974175> ASSERT in JITStubs.cpp at appsaccess.apple.com

JSDOMWindowCustom was using PropertySlot::putValue, however this interface
appears to be fundaementally incorrect - PropertySlots are only used to get
values, all puts use PutPropertySlot. However PutPropertySlot cannot be
used in the fashion desired here - it only reports the caching type of a
write that has been performed.

(This caused a bug where the put should have triggered a transition, and
failed to do so.)

Removing the faulty case from the optimization leads to a ~0.5% progression
on in-browser SunSpider (presumably the very first case was not being hit
often, and the simplification here is beneficial).

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::put):
01:48 Changeset [44756] by hausmann@webkit.org

2009-06-17 Markus Goetz <Markus.Goetz@nokia.com>

Reviewed by Simon Hausmann.

QWebPage: Don't call supportsSsl()

This stops QWebPage from loading the OpenSSL libs,
certificates etc. when they are not needed for the non-HTTPS case.

Loading the SSL libraries can be a very slow operation.

00:41 Changeset [44755] by levin@chromium.org

WebCore:

2009-06-17 David Levin <levin@chromium.org>

Reviewed by NOBODY, layout tests fix.

https://bugs.webkit.org/show_bug.cgi?id=26326
This reverts commit r44751.

Once that change was checked scrollbars/scrollbar-orientation.html started
crashing on Windows.

  • dom/Document.cpp: (WebCore::Document::detach):
  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/Scrollbar.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
  • rendering/RenderScrollbar.h:

LayoutTests:

2009-06-17 David Levin <levin@chromium.org>

Reviewed by NOBODY, layout tests fix.

https://bugs.webkit.org/show_bug.cgi?id=26326
This reverts commit r44751.

Once that change was checked scrollbars/scrollbar-orientation.html started
crashing on Windows.

  • scrollbars/resources/page-with-custom-scrollbars.html: Removed.
  • scrollbars/scrollbar-crash-on-refresh-expected.txt: Removed.
  • scrollbars/scrollbar-crash-on-refresh.html: Removed.

06/16/09:

23:13 Changeset [44754] by kevino@webkit.org

Reviewed by Kevin Ollivier.

In ImageSource::setData, delete the old m_encoder before replacing it with a new one.

https://bugs.webkit.org/show_bug.cgi?id=26458

22:19 Changeset [44753] by simon.fraser@apple.com

2009-06-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

<rdar://problem/6976766> Control-click on pages with accelerated compositing
content does not work.

Part deux. #ifdef the use of _private->layerHostingView with
USE(ACCELERATED_COMPOSITING)

  • WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]):
22:12 Changeset [44752] by simon.fraser@apple.com

2009-06-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

<rdar://problem/6976766> Control-click on pages with accelerated compositing
content does not work.

Remove the WebLayerHostingView subclass of NSView, with its attempts to
forward events to the WebHTMLView, and just fix -[WebHTMLView hitTest:]
to ignore the layerHostingView.

  • WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]): (-[WebHTMLView attachRootLayer:]):
21:56 Changeset [44751] by levin@chromium.org

WebCore:

2009-06-16 David Levin <levin@chromium.org>

Reviewed by David Hyatt.

REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326

Test: scrollbars/scrollbar-crash-on-refresh.html

  • dom/Document.cpp: (WebCore::Document::detach): Gives the FrameView a change to do any necessary cleanup on Document::detach() which is where the renderArena gets detroyed.
  • page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars): Gets rid of any custom scrollbars (if the docment supplied them).
  • page/FrameView.h:
  • platform/Scrollbar.h: (WebCore::Scrollbar::isCustomScrollbar):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Removed the check for document()->frame(). If frame() is 0 in this code, then the call to animation() is also incorrect (since it does document()->frame()->animation()).
  • rendering/RenderScrollbar.h: (WebCore::RenderScrollbar::isCustomScrollbar):

LayoutTests:

2009-06-16 David Levin <levin@chromium.org>

Reviewed by David Hyatt.

REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326

Test that refreshing an iframe with custom scrollbars works without crashing.

  • scrollbars/resources/page-with-custom-scrollbars.html: Added.
  • scrollbars/scrollbar-crash-on-refresh-expected.txt: Added.
  • scrollbars/scrollbar-crash-on-refresh.html: Added.
19:35 Changeset [44750] by bweinstein@apple.com

2009-06-16 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adele Peterson.

Fix of <rdar://6967547> Ctrl-C copies null value erasing text in clipboard in Safari.
This patch kept the way events were firing as they were before, and Windows events are
consistent with Mac.

  • editing/Editor.cpp: (WebCore::Editor::tryDHTMLCopy): Added check for canCopy() before clearing PasteBoard (WebCore::Editor::tryDHTMLCut): Added check for canCut() before clearing PasteBoard
17:38 Changeset [44749] by antti@apple.com

2009-06-16 Antti Koivisto <antti@apple.com>

Reviewed by Brady Eidson.

<rdar://problem/6660037> CrashTracer: [USER] 46 crashes in Safari at com.apple.WebCore • WebCore::CachedCSSStyleSheet::addClient + 53


When revalidating a resource, calling addClient() on one client might cause another to get removed.


  • made CachedResource::addClient() non-virtual and added virtual didAddClient()
  • in CachedResource::switchClientsToRevalidatedResource() add all clients to the client set of the revalidated resource first
  • check if the client is still in the set before invoking didAddClient() for it


No test case, I didn't manage to construct one. You need some combination of 304 revalidation, stylesheets that
reference each other via @imports and reloading.

  • WebCore.base.exp:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::didAddClient):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedFont.cpp: (WebCore::CachedFont::didAddClient):
  • loader/CachedFont.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::didAddClient):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::addClient): (WebCore::CachedResource::addClientToSet): (WebCore::CachedResource::switchClientsToRevalidatedResource):
  • loader/CachedResource.h:
  • loader/CachedScript.cpp: (WebCore::CachedScript::didAddClient):
  • loader/CachedScript.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::didAddClient):
  • loader/CachedXSLStyleSheet.h:
16:35 Changeset [44748] by barraclough@apple.com

2009-06-16 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver hunt.

Temporarily partially disable r44492, since this is causing some problems on internal builds.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):
  • jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION):
15:39 Changeset [44747] by bdakin@apple.com

2009-06-16 Beth Dakin <bdakin@apple.com>

Rubber-stamped by Mark Rowe.

The rest of the text metric layout test changes for the branch.

  • fast/forms/text-control-intrinsic-widths-expected.txt:
  • fast/forms/textarea-metrics-expected.txt:
  • fast/replaced/table-percent-height-text-controls-expected.txt:
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum:
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.png:
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt:
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum:
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png:
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt:
  • platform/mac-leopard/media/audio-controls-rendering-expected.checksum:
  • platform/mac-leopard/media/audio-controls-rendering-expected.png:
  • platform/mac-leopard/media/video-aspect-ratio-expected.checksum:
  • platform/mac-leopard/media/video-aspect-ratio-expected.png:
  • platform/mac-leopard/media/video-controls-rendering-expected.checksum:
  • platform/mac-leopard/media/video-controls-rendering-expected.png:
  • platform/mac-leopard/media/video-display-toggle-expected.checksum:
  • platform/mac-leopard/media/video-display-toggle-expected.png:
  • platform/mac-leopard/media/video-empty-source-expected.png:
  • platform/mac-leopard/media/video-layer-crash-expected.checksum:
  • platform/mac-leopard/media/video-layer-crash-expected.png:
  • platform/mac-leopard/media/video-transformed-expected.checksum:
  • platform/mac-leopard/media/video-transformed-expected.png:
  • platform/mac-leopard/media/video-zoom-controls-expected.checksum:
  • platform/mac-leopard/media/video-zoom-controls-expected.png:
  • platform/mac-leopard/media/video-zoom-expected.checksum:
  • platform/mac-leopard/media/video-zoom-expected.png:
  • platform/mac/animations/animation-drt-api-expected.png:
  • platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.png:
  • platform/mac/fast/backgrounds/background-clip-text-expected.checksum:
  • platform/mac/fast/backgrounds/background-clip-text-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.png:
  • platform/mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/mac/fast/block/margin-collapse/103-expected.png:
  • platform/mac/fast/block/margin-collapse/103-expected.txt:
  • platform/mac/fast/block/positioning/047-expected.checksum:
  • platform/mac/fast/block/positioning/047-expected.png:
  • platform/mac/fast/borders/border-image-rotate-transform-expected.checksum:
  • platform/mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/mac/fast/css-generated-content/hit-test-generated-content-expected.png:
  • platform/mac/fast/css/line-height-expected.checksum:
  • platform/mac/fast/css/line-height-expected.png:
  • platform/mac/fast/css/line-height-expected.txt:
  • platform/mac/fast/css/line-height-font-order-expected.checksum:
  • platform/mac/fast/css/line-height-font-order-expected.png:
  • platform/mac/fast/css/resize-corner-tracking-expected.checksum:
  • platform/mac/fast/css/resize-corner-tracking-expected.png:
  • platform/mac/fast/css/resize-corner-tracking-expected.txt:
  • platform/mac/fast/css/resize-corner-tracking-transformed-expected.png:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/mac/fast/dom/isindex-002-expected.checksum:
  • platform/mac/fast/dom/isindex-002-expected.png:
  • platform/mac/fast/dom/isindex-002-expected.txt:
  • platform/mac/fast/dynamic/008-expected.checksum:
  • platform/mac/fast/dynamic/008-expected.png:
  • platform/mac/fast/dynamic/008-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.checksum:
  • platform/mac/fast/events/autoscroll-expected.png:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.checksum:
  • platform/mac/fast/events/context-no-deselect-expected.png:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/events/label-focus-expected.checksum:
  • platform/mac/fast/events/label-focus-expected.png:
  • platform/mac/fast/events/label-focus-expected.txt:
  • platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum:
  • platform/mac/fast/events/standalone-image-drag-to-editable-expected.png:
  • platform/mac/fast/forms/001-expected.checksum:
  • platform/mac/fast/forms/001-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.checksum:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.checksum:
  • platform/mac/fast/forms/box-shadow-override-expected.png:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.checksum:
  • platform/mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/encoding-test-expected.checksum:
  • platform/mac/fast/forms/encoding-test-expected.png:
  • platform/mac/fast/forms/encoding-test-expected.txt:
  • platform/mac/fast/forms/fieldset-align-expected.checksum:
  • platform/mac/fast/forms/fieldset-align-expected.png:
  • platform/mac/fast/forms/fieldset-align-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.checksum:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/input-align-expected.checksum:
  • platform/mac/fast/forms/input-align-expected.png:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.checksum:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.checksum:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-disabled-expected.checksum:
  • platform/mac/fast/forms/input-appearance-disabled-expected.png:
  • platform/mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.checksum:
  • platform/mac/fast/forms/input-appearance-focus-expected.png:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.checksum:
  • platform/mac/fast/forms/input-appearance-height-expected.png:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.checksum:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.checksum:
  • platform/mac/fast/forms/input-appearance-readonly-expected.png:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.checksum:
  • platform/mac/fast/forms/input-appearance-selection-expected.png:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-visibility-expected.checksum:
  • platform/mac/fast/forms/input-appearance-visibility-expected.png:
  • platform/mac/fast/forms/input-appearance-visibility-expected.txt:
  • platform/mac/fast/forms/input-appearance-width-expected.checksum:
  • platform/mac/fast/forms/input-appearance-width-expected.png:
  • platform/mac/fast/forms/input-appearance-width-expected.txt:
  • platform/mac/fast/forms/input-baseline-expected.checksum:
  • platform/mac/fast/forms/input-baseline-expected.png:
  • platform/mac/fast/forms/input-baseline-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.checksum:
  • platform/mac/fast/forms/input-disabled-color-expected.png:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.checksum:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-paste-undo-expected.checksum:
  • platform/mac/fast/forms/input-paste-undo-expected.png:
  • platform/mac/fast/forms/input-paste-undo-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.checksum:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.checksum:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.png:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/input-readonly-empty-expected.checksum:
  • platform/mac/fast/forms/input-readonly-empty-expected.png:
  • platform/mac/fast/forms/input-readonly-empty-expected.txt:
  • platform/mac/fast/forms/input-spaces-expected.checksum:
  • platform/mac/fast/forms/input-spaces-expected.png:
  • platform/mac/fast/forms/input-spaces-expected.txt:
  • platform/mac/fast/forms/input-table-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.checksum:
  • platform/mac/fast/forms/input-text-click-inside-expected.png:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-click-outside-expected.checksum:
  • platform/mac/fast/forms/input-text-click-outside-expected.png:
  • platform/mac/fast/forms/input-text-click-outside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.checksum:
  • platform/mac/fast/forms/input-text-double-click-expected.png:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.checksum:
  • platform/mac/fast/forms/input-text-drag-down-expected.png:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.checksum:
  • platform/mac/fast/forms/input-text-option-delete-expected.png:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.checksum:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.checksum:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/input-text-word-wrap-expected.checksum:
  • platform/mac/fast/forms/input-text-word-wrap-expected.png:
  • platform/mac/fast/forms/input-text-word-wrap-expected.txt:
  • platform/mac/fast/forms/input-type-change2-expected.checksum:
  • platform/mac/fast/forms/input-type-change2-expected.png:
  • platform/mac/fast/forms/input-type-change2-expected.txt:
  • platform/mac/fast/forms/input-type-text-min-width-expected.checksum:
  • platform/mac/fast/forms/input-type-text-min-width-expected.png:
  • platform/mac/fast/forms/input-type-text-min-width-expected.txt:
  • platform/mac/fast/forms/input-value-expected.checksum:
  • platform/mac/fast/forms/input-value-expected.png:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/forms/input-width-expected.checksum:
  • platform/mac/fast/forms/input-width-expected.png:
  • platform/mac/fast/forms/input-width-expected.txt:
  • platform/mac/fast/forms/isindex-placeholder-expected.checksum:
  • platform/mac/fast/forms/isindex-placeholder-expected.png:
  • platform/mac/fast/forms/isindex-placeholder-expected.txt:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
  • platform/mac/fast/forms/menulist-clip-expected.checksum:
  • platform/mac/fast/forms/menulist-clip-expected.png:
  • platform/mac/fast/forms/menulist-narrow-width-expected.checksum:
  • platform/mac/fast/forms/menulist-narrow-width-expected.png:
  • platform/mac/fast/forms/menulist-option-wrap-expected.checksum:
  • platform/mac/fast/forms/menulist-option-wrap-expected.png:
  • platform/mac/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/mac/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/mac/fast/forms/negativeLineHeight-expected.checksum:
  • platform/mac/fast/forms/negativeLineHeight-expected.png:
  • platform/mac/fast/forms/negativeLineHeight-expected.txt:
  • platform/mac/fast/forms/password-placeholder-expected.checksum:
  • platform/mac/fast/forms/password-placeholder-expected.png:
  • platform/mac/fast/forms/password-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.checksum:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.png:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.checksum:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.checksum:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.png:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/mac/fast/forms/placeholder-set-value-expected.checksum:
  • platform/mac/fast/forms/placeholder-set-value-expected.png:
  • platform/mac/fast/forms/placeholder-set-value-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.checksum:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.checksum:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.checksum:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.png:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.checksum:
  • platform/mac/fast/forms/search-rtl-expected.png:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/search-transformed-expected.checksum:
  • platform/mac/fast/forms/search-transformed-expected.png:
  • platform/mac/fast/forms/search-transformed-expected.txt:
  • platform/mac/fast/forms/search-zoomed-expected.checksum:
  • platform/mac/fast/forms/search-zoomed-expected.png:
  • platform/mac/fast/forms/search-zoomed-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.checksum:
  • platform/mac/fast/forms/searchfield-heights-expected.png:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/forms/select-baseline-expected.checksum:
  • platform/mac/fast/forms/select-baseline-expected.png:
  • platform/mac/fast/forms/select-style-expected.checksum:
  • platform/mac/fast/forms/select-style-expected.png:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.checksum:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/textAreaLineHeight-expected.checksum:
  • platform/mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/mac/fast/forms/textAreaLineHeight-expected.txt:
  • platform/mac/fast/forms/textarea-align-expected.checksum:
  • platform/mac/fast/forms/textarea-align-expected.png:
  • platform/mac/fast/forms/textarea-align-expected.txt:
  • platform/mac/fast/forms/textarea-rows-cols-expected.checksum:
  • platform/mac/fast/forms/textarea-rows-cols-expected.png:
  • platform/mac/fast/forms/textarea-rows-cols-expected.txt:
  • platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
  • platform/mac/fast/forms/textarea-scroll-height-expected.png:
  • platform/mac/fast/forms/textarea-scroll-height-expected.txt:
  • platform/mac/fast/forms/textarea-scrollbar-expected.checksum:
  • platform/mac/fast/forms/textarea-scrollbar-expected.png:
  • platform/mac/fast/forms/textarea-scrollbar-expected.txt:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.checksum:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.png:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/mac/fast/forms/textarea-setinnerhtml-expected.checksum:
  • platform/mac/fast/forms/textarea-setinnerhtml-expected.png:
  • platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/mac/fast/forms/textarea-width-expected.checksum:
  • platform/mac/fast/forms/textarea-width-expected.png:
  • platform/mac/fast/forms/textarea-width-expected.txt:
  • platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum:
  • platform/mac/fast/forms/textfield-drag-into-disabled-expected.png:
  • platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.checksum:
  • platform/mac/fast/forms/textfield-outline-expected.png:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.checksum:
  • platform/mac/fast/forms/textfield-overflow-expected.png:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/frames/content-opacity-1-expected.checksum:
  • platform/mac/fast/frames/content-opacity-1-expected.png:
  • platform/mac/fast/frames/content-opacity-2-expected.checksum:
  • platform/mac/fast/frames/content-opacity-2-expected.png:
  • platform/mac/fast/inline/long-wrapped-line-expected.checksum:
  • platform/mac/fast/inline/long-wrapped-line-expected.png:
  • platform/mac/fast/invalid/residual-style-expected.txt:
  • platform/mac/fast/layers/normal-flow-hit-test-expected.png:
  • platform/mac/fast/layers/opacity-transforms-expected.png:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.checksum:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.png:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/mac/fast/overflow/overflow-x-y-expected.checksum:
  • platform/mac/fast/overflow/overflow-x-y-expected.png:
  • platform/mac/fast/overflow/overflow-x-y-expected.txt:
  • platform/mac/fast/parser/comment-in-textarea-expected.checksum:
  • platform/mac/fast/parser/comment-in-textarea-expected.png:
  • platform/mac/fast/parser/comment-in-textarea-expected.txt:
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.checksum:
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.png:
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.checksum:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.png:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/mac/fast/reflections/reflection-masks-expected.png:
  • platform/mac/fast/reflections/reflection-overflow-hidden-expected.png:
  • platform/mac/fast/repaint/4776765-expected.png:
  • platform/mac/fast/repaint/change-transform-expected.png:
  • platform/mac/fast/repaint/delete-into-nested-block-expected.png:
  • platform/mac/fast/repaint/fixed-expected.checksum:
  • platform/mac/fast/repaint/fixed-expected.png:
  • platform/mac/fast/repaint/outline-child-repaint-expected.png:
  • platform/mac/fast/repaint/outline-repaint-glitch-expected.png:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/repaint/search-field-cancel-expected.checksum:
  • platform/mac/fast/repaint/search-field-cancel-expected.png:
  • platform/mac/fast/repaint/search-field-cancel-expected.txt:
  • platform/mac/fast/repaint/selected-replaced-expected.png:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.checksum:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.png:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/mac/fast/repaint/table-outer-border-expected.checksum:
  • platform/mac/fast/repaint/table-outer-border-expected.png:
  • platform/mac/fast/repaint/transform-absolute-child-expected.png:
  • platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/mac/fast/repaint/transform-relative-position-expected.png:
  • platform/mac/fast/repaint/transform-repaint-descendants-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-expected.checksum:
  • platform/mac/fast/replaced/replaced-breaking-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.checksum:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.checksum:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.png:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/mac/fast/replaced/width100percent-textarea-expected.checksum:
  • platform/mac/fast/replaced/width100percent-textarea-expected.png:
  • platform/mac/fast/replaced/width100percent-textarea-expected.txt:
  • platform/mac/fast/replaced/width100percent-textfield-expected.checksum:
  • platform/mac/fast/replaced/width100percent-textfield-expected.png:
  • platform/mac/fast/replaced/width100percent-textfield-expected.txt:
  • platform/mac/fast/runin/generated-expected.checksum:
  • platform/mac/fast/runin/generated-expected.png:
  • platform/mac/fast/table/003-expected.checksum:
  • platform/mac/fast/table/003-expected.png:
  • platform/mac/fast/table/003-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-expected.checksum:
  • platform/mac/fast/table/colspanMinWidth-expected.png:
  • platform/mac/fast/table/colspanMinWidth-expected.txt:
  • platform/mac/fast/table/spanOverlapRepaint-expected.checksum:
  • platform/mac/fast/table/spanOverlapRepaint-expected.png:
  • platform/mac/fast/table/spanOverlapRepaint-expected.txt:
  • platform/mac/fast/table/text-field-baseline-expected.checksum:
  • platform/mac/fast/table/text-field-baseline-expected.png:
  • platform/mac/fast/table/text-field-baseline-expected.txt:
  • platform/mac/fast/table/vertical-align-baseline-expected.checksum:
  • platform/mac/fast/table/vertical-align-baseline-expected.png:
  • platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.checksum:
  • platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.png:
  • platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.checksum:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/fast/transforms/transform-on-inline-expected.png:
  • platform/mac/fast/transforms/transform-table-row-expected.png:
  • platform/mac/fast/transforms/transformed-caret-expected.png:
  • platform/mac/fast/transforms/transformed-document-element-expected.png:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.checksum:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac/fonts/serif-expected.checksum:
  • platform/mac/fonts/serif-expected.png:
  • platform/mac/http/tests/navigation/anchor-frames-expected.checksum:
  • platform/mac/http/tests/navigation/anchor-frames-expected.png:
  • platform/mac/http/tests/navigation/anchor-frames-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.checksum:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-01-t-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.checksum:
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
  • platform/mac/svg/batik/paints/patternRegions-expected.checksum:
  • platform/mac/svg/batik/paints/patternRegions-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textOnPath-expected.checksum:
  • platform/mac/svg/batik/text/textOnPath-expected.png:
  • platform/mac/svg/batik/text/verticalText-expected.checksum:
  • platform/mac/svg/batik/text/verticalText-expected.png:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.checksum:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/mac/svg/carto.net/window-expected.checksum:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.checksum:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.png:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.checksum:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.checksum:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.png:
  • platform/mac/svg/custom/gradient-stroke-width-expected.checksum:
  • platform/mac/svg/custom/gradient-stroke-width-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/custom/js-late-marker-and-object-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-marker-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-marker-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-marker-creation-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/mac/svg/custom/marker-changes-expected.checksum:
  • platform/mac/svg/custom/marker-changes-expected.png:
  • platform/mac/svg/custom/marker-child-changes-expected.checksum:
  • platform/mac/svg/custom/marker-child-changes-expected.png:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.checksum:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.png:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.checksum:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.png:
  • platform/mac/svg/custom/path-bad-data-expected.checksum:
  • platform/mac/svg/custom/path-bad-data-expected.png:
  • platform/mac/svg/custom/pattern-rotate-expected.checksum:
  • platform/mac/svg/custom/pattern-rotate-expected.png:
  • platform/mac/svg/custom/pointer-events-path-expected.checksum:
  • platform/mac/svg/custom/pointer-events-path-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.checksum:
  • platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
  • platform/mac/svg/custom/use-elementInstance-event-target-expected.checksum:
  • platform/mac/svg/custom/use-elementInstance-event-target-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.checksum:
  • platform/mac/svg/hixie/mixed/003-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/svg/text/text-fonts-01-t-expected.checksum:
  • platform/mac/svg/text/text-fonts-01-t-expected.png:
  • platform/mac/svg/text/text-path-01-b-expected.checksum:
  • platform/mac/svg/text/text-path-01-b-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-07-t-expected.checksum:
  • platform/mac/svg/text/text-text-07-t-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.png:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug194024-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug194024-expected.png:
  • platform/mac/tables/mozilla/bugs/bug194024-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.png:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.png:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30559-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug30559-expected.png:
  • platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.png:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.png:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.png:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.png:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.png:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.png:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.png:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/mac/tables/mozilla/dom/tableDom-expected.checksum:
  • platform/mac/tables/mozilla/dom/tableDom-expected.png:
  • platform/mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/mac/tables/mozilla/other/move_row-expected.checksum:
  • platform/mac/tables/mozilla/other/move_row-expected.png:
  • platform/mac/tables/mozilla/other/move_row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.checksum:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/mac/transitions/transition-drt-api-expected.png:
  • svg/custom/svg-fonts-in-text-controls-expected.txt:
15:37 Changeset [44746] by simon.fraser@apple.com

2009-06-16 Simon Fraser <simon.fraser@apple.com>

No Review

Fix code inside an #ifdef that draws the video framerate.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::paint):
15:28 Changeset [44745] by weinig@apple.com

2009-06-16 Sam Weinig <sam@webkit.org>

Fix windows build.

  • jit/JIT.cpp: (JSC::JIT::JIT):
15:28 Changeset [44744] by jianli@chromium.org

2009-06-16 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 26456: Hook up V8 bindings for Worker's importScripts functionality.
https://bugs.webkit.org/show_bug.cgi?id=26456

  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WorkerCustom.cpp: Fixed missing exception code handling in Worker constructor for V8 bindings. (WebCore::CALLBACK_FUNC_DECL):
15:20 Changeset [44743] by kmccullough@apple.com

2009-06-16 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Initialize m_bytecodeIndex to -1 in JIT, and correctly initialize
it for each type of stub using the return address to find the correct
offset.

  • jit/JIT.cpp: (JSC::JIT::JIT):
  • jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdSelfList): (JSC::JIT::compileGetByIdProtoList): (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compileCTIMachineTrampolines): (JSC::JIT::compilePatchGetArrayLength):
  • jit/JITStubCall.h: (JSC::JITStubCall::call):
15:19 Changeset [44742] by cmarrin@apple.com

Added spec directories from http://dev.w3.org/cvsweb/csswg/
which is where they will live. We will edit them here and
then push them to the W3C cvs server.

15:09 Changeset [44741] by cmarrin@apple.com

Removed all the specs because they are stale


index.html: Redirected to point at w3c site

14:55 Changeset [44740] by bfulgham@webkit.org

2009-06-16 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Maciej Stachowiak.

Update of https://bugs.webkit.org/show_bug.cgi?id=26353.
Provide an assignment operator to avoid improper reference
counts on the Cairo font objects. This brings the Windows
Cairo port in line with the GTK+ port.

14:35 Changeset [44739] by bweinstein@apple.com

2009-06-16 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.


Switch Control+Mousewheel Zooming definitions to match other browsers on Windows.
Control+Mousewheel-Down now zooms out, Control+Mousewheel-Up now zooms in.
https://bugs.webkit.org/show_bug.cgi?id=25875.
<rdar://problem/6903976>

  • WebView.cpp: (WebView::mouseWheel):
14:08 Changeset [44738] by eric.carlson@apple.com

2009-06-16 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Fix for <rdar://problem/6890126> Theme code should fetch the MediaControlElementType from
the MediaControlInputElement, rather than computing it again

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::percentLoaded): New, utility function for controller implementation.
  • html/HTMLMediaElement.h:
  • rendering/MediaControlElements.h: (WebCore::MediaControlInputElement::displayType): New, return m_displayType.
  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart): Stop using MediaPlayer object, get button state from the button itself and get movie state from HTMLMediaElement.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaMuteButton): Get state from button instead of MediaPlayer. (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto.
14:00 Changeset [44737] by jianli@chromium.org

2009-06-16 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Bug 26450: Rename values of enum RedirectOriginCheck to make them
clearer.
https://bugs.webkit.org/show_bug.cgi?id=26450

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::create): (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::willSendRequest):
  • loader/DocumentThreadableLoader.h:
  • loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::create): (WebCore::ThreadableLoader::loadResourceSynchronously):
  • loader/ThreadableLoader.h:
  • workers/Worker.cpp: (WebCore::Worker::Worker):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::loadResourceSynchronously): (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
  • loader/WorkerThreadableLoader.h: (WebCore::WorkerThreadableLoader::create):
  • workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously):
  • workers/WorkerScriptLoader.h: (WebCore::WorkerContext::importScripts):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously):
13:36 Changeset [44736] by bdakin@apple.com

2009-06-15 Beth Dakin <bdakin@apple.com>

Rubber-stamped by Geoff Garen.

Updating tests on the branch from when we backed out the text
control metrics change. This only covers the editing directory.

  • platform/mac/editing/deleting/5168598-expected.checksum:
  • platform/mac/editing/deleting/5168598-expected.png:
  • platform/mac/editing/deleting/5168598-expected.txt:
  • platform/mac/editing/deleting/delete-to-select-table-expected.checksum:
  • platform/mac/editing/deleting/delete-to-select-table-expected.png:
  • platform/mac/editing/deleting/type-delete-after-quote-expected.checksum:
  • platform/mac/editing/deleting/type-delete-after-quote-expected.png:
  • platform/mac/editing/inserting/4960120-1-expected.checksum:
  • platform/mac/editing/inserting/4960120-1-expected.png:
  • platform/mac/editing/inserting/4960120-1-expected.txt:
  • platform/mac/editing/inserting/5418891-expected.checksum:
  • platform/mac/editing/inserting/5418891-expected.png:
  • platform/mac/editing/inserting/5607069-2-expected.checksum:
  • platform/mac/editing/inserting/5607069-2-expected.png:
  • platform/mac/editing/inserting/5607069-2-expected.txt:
  • platform/mac/editing/inserting/5607069-3-expected.checksum:
  • platform/mac/editing/inserting/5607069-3-expected.png:
  • platform/mac/editing/inserting/5607069-3-expected.txt:
  • platform/mac/editing/inserting/before-after-input-element-expected.checksum:
  • platform/mac/editing/inserting/before-after-input-element-expected.png:
  • platform/mac/editing/inserting/before-after-input-element-expected.txt:
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.checksum:
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.png:
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
  • platform/mac/editing/pasteboard/4806874-expected.checksum:
  • platform/mac/editing/pasteboard/4806874-expected.png:
  • platform/mac/editing/pasteboard/4806874-expected.txt:
  • platform/mac/editing/pasteboard/5387578-expected.checksum:
  • platform/mac/editing/pasteboard/5387578-expected.png:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.checksum:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/input-field-1-expected.checksum:
  • platform/mac/editing/pasteboard/input-field-1-expected.png:
  • platform/mac/editing/pasteboard/input-field-1-expected.txt:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.checksum:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.png:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/mac/editing/selection/3690703-2-expected.checksum:
  • platform/mac/editing/selection/3690703-2-expected.png:
  • platform/mac/editing/selection/3690703-2-expected.txt:
  • platform/mac/editing/selection/3690703-expected.checksum:
  • platform/mac/editing/selection/3690703-expected.png:
  • platform/mac/editing/selection/3690703-expected.txt:
  • platform/mac/editing/selection/3690719-expected.checksum:
  • platform/mac/editing/selection/3690719-expected.png:
  • platform/mac/editing/selection/3690719-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.checksum:
  • platform/mac/editing/selection/4895428-3-expected.png:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.checksum:
  • platform/mac/editing/selection/4975120-expected.png:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/5136696-expected.checksum:
  • platform/mac/editing/selection/5136696-expected.png:
  • platform/mac/editing/selection/5136696-expected.txt:
  • platform/mac/editing/selection/5213963-expected.checksum:
  • platform/mac/editing/selection/5213963-expected.png:
  • platform/mac/editing/selection/5213963-expected.txt:
  • platform/mac/editing/selection/caret-rtl-2-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-2-expected.png:
  • platform/mac/editing/selection/drag-select-1-expected.checksum:
  • platform/mac/editing/selection/drag-select-1-expected.png:
  • platform/mac/editing/selection/drag-select-1-expected.txt:
  • platform/mac/editing/selection/drag-text-delay-expected.checksum:
  • platform/mac/editing/selection/drag-text-delay-expected.png:
  • platform/mac/editing/selection/drag-text-delay-expected.txt:
  • platform/mac/editing/selection/extend-by-word-002-expected.checksum:
  • platform/mac/editing/selection/extend-by-word-002-expected.png:
  • platform/mac/editing/selection/select-all-002-expected.checksum:
  • platform/mac/editing/selection/select-all-002-expected.png:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.checksum:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/editing/spelling/spellcheck-attribute-expected.checksum:
  • platform/mac/editing/spelling/spellcheck-attribute-expected.png:
  • platform/mac/editing/spelling/spellcheck-attribute-expected.txt:
13:31 Changeset [44735] by dglazkov@chromium.org

2009-06-16 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

Fix a UMR in WebCore::BitStack by initializing new memory to 0.
https://bugs.webkit.org/show_bug.cgi?id=26449
No new tests, covered by purify.

  • editing/TextIterator.cpp: (WebCore::BitStack::push):
13:27 Changeset [44734] by bfulgham@webkit.org

009-06-16 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Xan Lopez.

Fixes https://bugs.webkit.org/show_bug.cgi?id=26453.
Null Cairo contextwill crash Windows Cairo build.

Test: fast/multicol/columns-shorthand-parsing.html

12:27 Changeset [44733] by pkasting@chromium.org

2009-06-16 Peter Kasting <pkasting@google.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=26447
Fix animated GIF breakage in Cairo/wx ports.

  • platform/image-decoders/cairo/ImageDecoderCairo.cpp: (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::operator=):
  • platform/image-decoders/wx/ImageDecoderWx.cpp: (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::operator=):
12:26 Changeset [44732] by simon.fraser@apple.com

2009-06-16 Simon Fraser <simon.fraser@apple.com>

Rubber-stamped by Anders Carlsson.

Update WebKitSystemInterface for <rdar://problem/6937882>.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
11:51 Changeset [44731] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

Disable another new test.

  • platform/gtk/Skipped:
11:36 Changeset [44730] by simon.fraser@apple.com

2009-06-16 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by John Sullivan

<rdar://problem/6937882>

Tweak "time remaining" and "time elapsed" fields in the overlay video controller.

  • css/mediaControlsQT.css:
11:36 Changeset [44729] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not use g_assert_cmpint to test for NULL pointer, just
g_assert.

  • tests/testnetworkrequest.c: (test_network_request_create_destroy):
11:27 Changeset [44728] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

editing/deleting/4875189.html was changed from pixel to
dumpAsText, so remove it from Skipped list.

  • platform/gtk/Skipped:
11:19 Changeset [44727] by abarth@webkit.org

2009-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26437

Make the commit-log-editor match the ambient line endings in commit
messages.

  • Scripts/commit-log-editor:
11:12 Changeset [44726] by jianli@chromium.org

WebCore:

2009-06-16 Jian Li <jianli@chromium.org>

Reviewed by Adam Barth and David Levin.

Bug 26146: Change to use ThreadableLoader to load the worker script
in order to check URL origin for redirection.
https://bugs.webkit.org/show_bug.cgi?id=26146

Test: http/tests/workers/worker-redirect.html

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • workers/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::notifyFinished):
  • workers/Worker.h:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • workers/WorkerImportScriptsClient.cpp: Removed.
  • workers/WorkerImportScriptsClient.h: Removed.
  • workers/WorkerScriptLoader.cpp: Renamed from workers/WorkerImportScriptsClient.cpp. This to make it more generic so worker script loading could use it. (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously): (WebCore::WorkerScriptLoader::didFinishLoading): (WebCore::WorkerScriptLoader::didFail): (WebCore::WorkerScriptLoader::didFailRedirectCheck): (WebCore::WorkerScriptLoader::didReceiveAuthenticationCancellation): (WebCore::WorkerScriptLoader::notifyFinished):
  • workers/WorkerScriptLoader.h: Renamed from workers/WorkerImportScriptsClient.h. This to make it more generic so worker script loading could use it.
  • workers/WorkerScriptLoaderClient.h: Added.

LayoutTests:

2009-06-16 Jian Li <jianli@chromium.org>

Reviewed by Adam Barth and David Levin.

Bug 26146: Change to use ThreadableLoader to load the worker script
in order to check URL origin for redirection.
https://bugs.webkit.org/show_bug.cgi?id=26146

Add a layout test to cover the scenario that the worker script is
loaded from different redirect origin.

  • http/tests/workers/resources/worker-redirect-target.js: Added.
  • http/tests/workers/worker-redirect-expected.txt: Added.
  • http/tests/workers/worker-redirect.html: Added.
10:59 Changeset [44725] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

Fix typo in test name.

  • platform/gtk/Skipped:
10:48 Changeset [44724] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

Disable new tests.

  • platform/gtk/Skipped:
10:10 BuildingOnWindows edited by bfulgham@gmail.com
(diff)
10:10 BuildingOnWindows edited by bfulgham@gmail.com
(diff)
09:59 BuildingOnWindows edited by aroben@apple.com
Add instructions for rebasing libphp4 on Vista (diff)
09:44 Changeset [44723] by bfulgham@webkit.org

009-06-16 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Darin Adler.

Use consistent GUID comparison functions.
https://bugs.webkit.org/show_bug.cgi?id=26427

07:09 Changeset [44722] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix compiler warning.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_class_init):
07:09 Changeset [44721] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Remove dummy AtkStreamableContent implementation.

It's completely empty, we'll add it back (and conditionally
instead of unconditionally) when it does something.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (GetAtkInterfaceTypeFromWAIType): (getInterfaceMaskFromObject):
06:32 Changeset [44720] by xan@webkit.org

2009-06-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update GtkLauncher to recent API changes in the progress property,
which now goes from 0.0 to 1.0.

  • GtkLauncher/main.c:
01:40 Changeset [44719] by hausmann@webkit.org

2009-06-16 David Boddie <dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Doc: Fixed QWebPage::forwardUnsupportedContent documentation and added
more information about Web plugins.

01:40 Changeset [44718] by hausmann@webkit.org

2009-06-16 Morten Engvoldsen <morten.engvoldsen@nokia.com>

Reviewed by Ariya Hidayat.

Clearifying QWebFrame docs

Adding docs to toHtml() and toPlainText()

01:10 Changeset [44717] by abarth@webkit.org

Fix ChangeLog typo.

01:06 Changeset [44716] by abarth@webkit.org

2009-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Darin Alder.

https://bugs.webkit.org/show_bug.cgi?id=26000

Teach prepare-ChangeLog to match the line ends that are already present
in ChangeLog files. This helps folks whose use cygwin perl with CR LF
line endings on Windows.

Also, teach prepare-ChangeLog to normalize backslashes in paths. This
helps folks who use Windows SVN prepare correct ChangeLogs.

  • Scripts/prepare-ChangeLog:
00:35 Changeset [44715] by mrowe@apple.com

Roll over some ChangeLog files.

00:35 Changeset [44714] by mrowe@apple.com

Add a script to automate the rolling over of ChangeLog files when they grow too large.

Reviewed by Oliver Hunt.

  • Scripts/roll-over-ChangeLogs: Added.

06/15/09:

23:52 Changeset [44713] by barraclough@apple.com

2009-06-15 Gavin Barraclough <barraclough@apple.com>

Rubber Stamped by Sam Weinig.

Rename PatchBuffer to LinkBuffer. Previously our terminology has been a little
mixed up, but we have decided to fix on refering to the process that takes place
at the end of code generation as 'linking', and on any modifications that take
place later (and once the code has potentially already been executed) as 'patching'.

However, the term 'PatchBuffer' is already in use, and needs to be repurposed.

To try to minimize confusion, we're going to switch the terminology over in stages,
so for now we'll refer to later modifications as 'repatching'. This means that the
new 'PatchBuffer' has been introduced with the name 'RepatchBuffer' instead.

This patch renames the old 'PatchBuffer' to 'LinkBuffer'. We'll leave ToT in this
state for a week or so to try to avoid to much overlap of the meaning of the term
'PatchBuffer', then will come back and rename 'RepatchBuffer'.

  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::LinkBuffer::LinkBuffer): (JSC::AbstractMacroAssembler::LinkBuffer::~LinkBuffer):
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::compile):
23:17 Changeset [44712] by adele@apple.com

WebCore:

2009-06-15 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): When inserting a newline after the blockquote, we don't want to apply the original style after the insertion.

LayoutTests:

2009-06-15 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Updating test for:
<rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros

This test case covered inserting a newline after a blockquote, but outside of the blockquote. I added some
text insertion to verify that the newline doesn't get any old styles copied from the blockquote.

  • editing/pasteboard/5368833.html:
  • platform/mac/editing/pasteboard/5368833-expected.checksum:
  • platform/mac/editing/pasteboard/5368833-expected.png:
  • platform/mac/editing/pasteboard/5368833-expected.txt:
22:35 Changeset [44711] by barraclough@apple.com

2009-06-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Having moved most of their functionality into the RepatchBuffer class,
we can simplify the CodeLocation* classes.

The CodeLocation* classes are currently a tangle of templatey and friendly
badness, burried in the middle of AbstractMacroAssembler. Having moved
the ability to repatch out into RepatchBufer they are now do-nothing wrappers
on CodePtr (MacroAssemblerCodePtr), that only exist to provide type-safety.

Simplify the code, and move them off into their own header.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::PatchBuffer::patch):
  • assembler/CodeLocation.h: Copied from assembler/AbstractMacroAssembler.h. (JSC::CodeLocationCommon::CodeLocationCommon): (JSC::CodeLocationInstruction::CodeLocationInstruction): (JSC::CodeLocationLabel::CodeLocationLabel): (JSC::CodeLocationJump::CodeLocationJump): (JSC::CodeLocationCall::CodeLocationCall): (JSC::CodeLocationNearCall::CodeLocationNearCall): (JSC::CodeLocationDataLabel32::CodeLocationDataLabel32): (JSC::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr): (JSC::CodeLocationCommon::instructionAtOffset): (JSC::CodeLocationCommon::labelAtOffset): (JSC::CodeLocationCommon::jumpAtOffset): (JSC::CodeLocationCommon::callAtOffset): (JSC::CodeLocationCommon::nearCallAtOffset): (JSC::CodeLocationCommon::dataLabelPtrAtOffset): (JSC::CodeLocationCommon::dataLabel32AtOffset):
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::operator!):
  • bytecode/CodeBlock.h: (JSC::getStructureStubInfoReturnLocation): (JSC::getCallLinkInfoReturnLocation): (JSC::getMethodCallLinkInfoReturnLocation):
  • bytecode/Instruction.h:
  • bytecode/JumpTable.h: (JSC::StringJumpTable::ctiForValue): (JSC::SimpleJumpTable::ctiForValue):
  • bytecode/StructureStubInfo.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitCatch):
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION): (JSC::JITStubs::getPolymorphicAccessStructureListSlot):
22:03 Changeset [44710] by weinig@apple.com

2009-06-15 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove outdated comment.

  • bindings/js/JSDOMWindowBase.h:
21:58 Changeset [44709] by weinig@apple.com

2009-06-15 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Bring CustomGetPropertyNames more inline with the other
extended attributes prefixed with Custom, by making it
require a complete implementation.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getPropertyNames):
  • bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::getPropertyNames):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::getPropertyNames):
  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::getPropertyNames):
  • bindings/scripts/CodeGeneratorJS.pm:
21:04 Changeset [44708] by weinig@apple.com

2009-06-15 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove commented out ondataunavailable attribute event listener which
has now been removed from HTML 5.

  • page/DOMWindow.idl:
21:02 Changeset [44707] by weinig@apple.com

2009-06-15 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Move entire custom implementation of getOwnPropertySlot and put
for JSDOMWindow into JSDOMWindowCustom, eliminating the bit in
JSDOMWindowBase.

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter): (WebCore::childFrameGetter): (WebCore::indexGetter): (WebCore::namedItemGetter): (WebCore::JSDOMWindow::getOwnPropertySlot): (WebCore::JSDOMWindow::put): (WebCore::JSDOMWindow::getPropertyAttributes):
  • bindings/js/JSDOMWindowCustom.h:
  • page/DOMWindow.idl:
21:00 Changeset [44706] by dglazkov@chromium.org

2009-06-15 Jeremy Orlow (jorlow@chromium.org)

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26356
Define the functions in V8CustomBindings.h. "Forgot" this in my
earlier patch since it wasn't fully upstreamed when I wrote the
patch.

  • bindings/v8/custom/V8CustomBinding.h:
20:01 Changeset [44705] by barraclough@apple.com

2009-06-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Having introduced the RepatchBuffer, ProcessorReturnAddress is now a do-nothing
wrapper around ReturnAddressPtr. Remove it. In tugging on this piece of string
it made sense to roll out the use of ReturnAddressPtr a little further into
JITStubs (which had always been the intention).

No performance impact.

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToFunction): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkNearCallerToTrampoline):
  • assembler/MacroAssemblerCodeRef.h: (JSC::ReturnAddressPtr::ReturnAddressPtr):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::getStubInfo): (JSC::CodeBlock::getCallLinkInfo): (JSC::CodeBlock::getMethodCallLinkInfo): (JSC::CodeBlock::getBytecodeIndex):
  • interpreter/Interpreter.cpp: (JSC::bytecodeOffsetForPC):
  • jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress):
  • jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compilePatchGetArrayLength):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::StackHack::StackHack): (JSC::returnToThrowTrampoline): (JSC::throwStackOverflowError): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h: (JSC::): (JSC::JITStackFrame::returnAddressSlot):
  • runtime/JSGlobalData.h:
19:13 Changeset [44704] by eric@webkit.org

2009-06-15 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by Adam Treat.

Support the back/forward/stop/refresh multimedia keys and accept the
event when handling backspace and shift backspace as we should.

  • Api/qwebpage.cpp: (QWebPagePrivate::keyPressEvent):
18:36 Changeset [44703] by mitz@apple.com

2009-06-15 Andre Boule <aboule@apple.com>

Reviewed by Cameron Zwarich and Dan Bernstein.

  • fix <rdar://problem/6967975> crash with NSString drawAtPoint

No test possible because this crash can only occur if the client uses
WebKit text drawing without ever using WebCore text, and DumpRenderTree
cannot do either.

  • platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): Null-check

gFontPlatformDataCache.

18:27 Changeset [44702] by simon.fraser@apple.com

2009-06-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

<rdar://problem/6974857>

Define ENABLE_3D_RENDERING and WTF_USE_ACCELERATED_COMPOSITING when building on 10.6.
Move the ENABLE_3D_RENDERING switch from config.h and WebKitPrefix.h to wtf/Platform.h

18:12 Changeset [44701] by <