Timeline


and

07/06/09:

23:42 Changeset [45587] by ggaren@apple.com

JavaScriptCore:

2009-07-06 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig (?).


Fixed an assertion seen during the stress test.


Don't assume that, if op1 is constant, op2 is not, and vice versa. Sadly,
not all constants get folded.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq):

LayoutTests:

2009-07-06 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig (?).

Test for an assertion seen during the stress test.


  • fast/js/arithmetic-expected.txt:
  • fast/js/resources/arithmetic.js:
22:34 Changeset [45586] by barraclough@apple.com

JavaScriptCore:

2009-07-06 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Stop loading constants into the register file.

Instead, use high register values (highest bit bar the sign bit set) to indicate
constants in the instruction stream, and when we encounter such a value load it
directly from the CodeBlock.

Since constants are no longer copied into the register file, this patch renders
the 'unexpected constant' mechanism redundant, and removes it.

2% improvement, thanks to Sam Weinig.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::mark): (JSC::CodeBlock::shrinkToFit):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::isTemporaryRegisterIndex): (JSC::CodeBlock::constantRegister): (JSC::CodeBlock::isConstantRegisterIndex): (JSC::CodeBlock::getConstant): (JSC::ExecState::r):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::preserveLastVar): (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::addConstantValue): (JSC::BytecodeGenerator::emitEqualityOp): (JSC::BytecodeGenerator::emitLoad): (JSC::BytecodeGenerator::emitResolveBase): (JSC::BytecodeGenerator::emitResolveWithBase): (JSC::BytecodeGenerator::emitNewError):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitNode):
  • interpreter/CallFrame.h: (JSC::ExecState::noCaller): (JSC::ExecState::hasHostCallFrameFlag): (JSC::ExecState::addHostCallFrameFlag): (JSC::ExecState::removeHostCallFrameFlag):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveBase): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::resolveBaseAndFunc): (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::throwException): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JITInlineMethods.h: (JSC::JIT::emitLoadDouble): (JSC::JIT::emitLoadInt32ToDouble):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_error): (JSC::JIT::emit_op_enter): (JSC::JIT::emit_op_enter_with_activation):
  • parser/Nodes.cpp: (JSC::DeleteResolveNode::emitBytecode): (JSC::DeleteValueNode::emitBytecode): (JSC::PrefixResolveNode::emitBytecode):
  • runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation):
  • wtf/Platform.h:

LayoutTests:

2009-07-06 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

fast/js/global-recursion-on-full-stack.html is a little finicky.

The test recurses down the JS stack to find the bottom (catching this with an exception),
then tries to call a host function (document.write), switch writes new '<script>' code,
and expects this code to be run, then expects this code to try to call 'f();' again,
which it expects to fail, and it expects to catch that exception. However it is possible
that one of the earlier stages (the call to document.write, entering the interpreter to
run the new global code) will fail, depending on exactly how much stack space was free at
the point the last call to f() failed.

Tweak the test to make it work.

  • fast/js/global-recursion-on-full-stack.html:
20:40 Changeset [45585] by eric@webkit.org

2009-07-06 Albert J. Wong <ajwong@chromium.org>

Reviewed by Maciej Stachowiak.

Update RenderThemeChromiumMac for wkDrawMediaUIPart and wkDrawMediaSlider API
change.

Fix compile RenderThemeChromiumMac.mm due to API changes from r45572
https://bugs.webkit.org/show_bug.cgi?id=27018

This is mainly an API change update to fix the chromium compile. It
also has a small fix of a typo in RenderThemeMac.mm.

Compilation against the head of chromium trunk passed. Since this is
a compile fix, that should be sufficient.

  • rendering/RenderThemeChromiumMac.mm: (WebCore::): (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekBackButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekForwardButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
  • rendering/RenderThemeMac.mm: (WebCore::):
19:49 Changeset [45584] by ddkilzer@apple.com

Bug 27006: Build fix when MAC_JAVA_BRIDGE is disabled

<https://bugs.webkit.org/show_bug.cgi?id=27006>

Reviewed by Darin Adler.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createJavaAppletWidget): Wrap contents of the method in #if ENABLE(MAC_JAVA_BRIDGE)/#endif and return 0 when this feature is disabled.
19:44 Changeset [45583] by ddkilzer@apple.com

Bug 27005: Build fixes when NETSCAPE_PLUGIN_API is disabled

<https://bugs.webkit.org/show_bug.cgi?id=27005>

Reviewed by Geoff Garen.

  • Plugins/WebPluginController.mm: (-[WebPluginController destroyPlugin:]): Wrap call to ScriptController::cleanupScriptObjectsForPlugin() in #if ENABLE(NETSCAPE_PLUGIN_API)/#endif macro. (-[WebPluginController destroyAllPlugins]): Ditto.
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase removePluginInstanceViewsFor:]): Wrap WebBaseNetscapePluginView class checks in #if ENABLE(NETSCAPE_PLUGIN_API)/#endif macro. (-[WebPluginDatabase destroyAllPluginInstanceViews]): Ditto.
19:39 Changeset [45582] by ddkilzer@apple.com

BUILD FIX: Use ENABLE(NETSCAPE_PLUGIN_API) instead of USE(PLUGIN_HOST_PROCESS)

In r45579, #if/#endif macros for USE(PLUGIN_HOST_PROCESS) were
used, but ENABLE(NETSCAPE_PLUGIN_API) should have been used
instead.

  • Plugins/WebNetscapeContainerCheckContextInfo.h:
  • Plugins/WebNetscapeContainerCheckContextInfo.mm:
  • Plugins/WebNetscapeContainerCheckPrivate.mm:
19:18 Changeset [45581] by ddkilzer@apple.com

Bug 27004: Build fix for ENABLE(PLUGIN_PROXY_FOR_VIDEO) after r42618

<https://bugs.webkit.org/show_bug.cgi?id=27004>

Reviewed by Geoff Garen.

  • Plugins/WebPluginController.mm: (mediaProxyClient): Use core() method to convert from DOMElement to WebCore::Element.
19:18 Changeset [45580] by eric@webkit.org

2009-07-06 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

bugzilla-tool fails to close bugs with bugzilla 3.0
https://bugs.webkit.org/show_bug.cgi?id=27008

Update bugzilla.py to match changes in the bug page "changeform"
Update scm.py to add bug_ids to attachments to make error reporting nicer.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/scm.py:
19:14 Changeset [45579] by ddkilzer@apple.com

Bug 27003: Build fix when USE(PLUGIN_HOST_PROCESS) is disabled

<https://bugs.webkit.org/show_bug.cgi?id=27003>

Reviewed by Geoff Garen.

  • Plugins/WebNetscapeContainerCheckContextInfo.h: Added #if USE(PLUGIN_HOST_PROCESS)/#endif guards.
  • Plugins/WebNetscapeContainerCheckContextInfo.mm: Ditto.
  • Plugins/WebNetscapeContainerCheckPrivate.mm: Ditto.
18:01 Changeset [45578] by ddkilzer@apple.com

Bug 27002: Build fix when DASHBOARD_SUPPORT is disabled with -Wunused-parameter

<https://bugs.webkit.org/show_bug.cgi?id=27002>

Reviewed by Geoff Garen.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::prepareGradientForDashboard): Mark gradient as an unused parameter when DASHBOARD_SUPPORT is disabled.
17:59 Changeset [45577] by ddkilzer@apple.com

Bug 27001: Fix improper use of PassRefPtr<Node> to RefPtr<Node>

<https://bugs.webkit.org/show_bug.cgi?id=27001>

Reviewed by Geoff Garen.

PassRefPtr<> should only be used for arguments to functions that
take ownership of the object, or as return values from functions
that relinquish ownership of the object.

  • editing/Editor.cpp: (WebCore::Editor::increaseSelectionListLevelOrdered): Changed stack-allocated PassRefPtr<Node> to RefPtr<Node> and call release() on returned object. (WebCore::Editor::increaseSelectionListLevelUnordered): Ditto.
17:44 Changeset [45576] by eric.carlson@apple.com

2009-07-06 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7035474> Make new media controller UI default on SnowLeopard

  • rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):

New media controller UI is enabled by default on SnowLeopard.

2009-07-06 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7035474> Make new media controller UI default on SnowLeopard

Disable media tests that depend on controller size/position on SnowLeopard until
<rdar://problem/6502936> Update run-webkit-tests to deal with new media controller look
has been fixed

  • platform/mac-snowleopard/Skipped:
16:54 Changeset [45575] by ggaren@apple.com

2009-07-06 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Include op_convert_this in result caching.


No change on SunSpider or v8.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_convert_this):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h: (JSC::): Made the op_convert_this JIT stub return an EncodedJSValue, so to maintain the result caching contract that { tag, payload } can be found in { regT1, regT0 }.
16:18 Changeset [45574] by japhet@chromium.org

2009-07-06 Nate Chapin <japhet@chromium.org>

Unreviewed, build fix.

Roll out r45559 to fix Chromium canary.

https://bugs.webkit.org/show_bug.cgi?id=26857

15:59 Changeset [45573] by ggaren@apple.com

2009-07-06 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Implemented result chaining.


1% faster on SunSpider. 4%-5% faster on v8.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::move):
  • assembler/X86Assembler.h: (JSC::X86Assembler::movl_rr): Added an optimization to eliminate no-op mov instructions, to simplify chaining.
  • jit/JIT.cpp: (JSC::JIT::JIT):
  • jit/JIT.h: Added data members and helper functions for recording chained results. We record both a mapping from virtual to machine register and the opcode for which the mapping is valid, to help ensure that the mapping isn't used after the mapped register has been stomped by other instructions.
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCallVarargsSlowCase): (JSC::JIT::emit_op_ret): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase): Chain function call results.
  • jit/JITInlineMethods.h: (JSC::JIT::emitLoadTag): (JSC::JIT::emitLoadPayload): (JSC::JIT::emitLoad): (JSC::JIT::emitLoad2): (JSC::JIT::isLabeled): (JSC::JIT::map): (JSC::JIT::unmap): (JSC::JIT::isMapped): (JSC::JIT::getMappedPayload): (JSC::JIT::getMappedTag): Use helper functions when loading virtual registers into machine registers, in case the loads can be eliminated by chaining.
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_mov): (JSC::JIT::emit_op_end): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_catch): Chain results from these opcodes.

(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call): Load the profiler into regT2 to
avoid stomping a chained result.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_get_by_id): Chain results from these opcodes.
  • jit/JITStubCall.h: (JSC::JITStubCall::addArgument): Always use { regT1, regT0 }, to facilitate chaining.

(JSC::JITStubCall::call): Unmap all mapped registers, since our callee
stub might stomp them.

15:56 Changeset [45572] by eric.carlson@apple.com

2009-07-06 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/7008093> Media controller can’t be used to scrub when movie is
narrow — track is too narrow

Do not show media controller time display elements when the a movie is too narrow.

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

The 'state' parameter to wkDrawMediaUIPart is now an unsigned bitfield.

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):

Give current time and time remaining controls a common base class.

(WebCore::MediaControlTimeDisplayElement::setVisible):

New method, hide and show the element.

  • rendering/MediaControlElements.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia):

Initialize m_previousVisible.

(WebCore::RenderMedia::layout):

Show/hide the time display elements as the movie width changes.

(WebCore::RenderMedia::createCurrentTimeDisplay):
(WebCore::RenderMedia::createTimeRemainingDisplay):

Base class is now MediaControlTimeDisplayElement, not MediaControlElement.

(WebCore::RenderMedia::shouldShowTimeDisplayControls):

New, decide if time display elements should be visible or not.

  • rendering/RenderMedia.h:
  • rendering/RenderThemeMac.mm: (WebCore::): (WebCore::RenderThemeMac::paintMediaFullscreenButton): (WebCore::RenderThemeMac::paintMediaMuteButton): (WebCore::RenderThemeMac::paintMediaPlayButton): (WebCore::RenderThemeMac::paintMediaSeekBackButton): (WebCore::RenderThemeMac::paintMediaSeekForwardButton): (WebCore::RenderThemeMac::paintMediaSliderTrack): (WebCore::RenderThemeMac::paintMediaSliderThumb): (WebCore::RenderThemeMac::paintMediaRewindButton): (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton): (WebCore::RenderThemeMac::paintMediaControlsBackground): (WebCore::RenderThemeMac::paintMediaCurrentTime): (WebCore::RenderThemeMac::paintMediaTimeRemaining):

The 'state' parameter to wkDrawMediaUIPart is now an unsigned bitfield.

2009-07-06 Eric Carlson <eric.carlson@apple.com>

Update WebKitSystemInterface for <rdar://problem/7008093>.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
15:46 Changeset [45571] by ddkilzer@apple.com

Bug 27000: Minor clean up to runtime_root.{cpp|h}

<https://bugs.webkit.org/show_bug.cgi?id=27000>

Reviewed by Geoff Garen.

  • bridge/runtime_root.cpp: Added blank line between license and the first #include statement.
  • bridge/runtime_root.h: Added comment to #endif.
15:42 Changeset [45570] by eric@webkit.org

2009-07-06 Roland Steiner <rolandsteiner@google.com>

Reviewed by Maciej Stachowiak.

generalize the special height treatment for SVG (to be re-used for ruby):

renamed InlineBox::m_isSVG to m_hasVirtualHeight
renamed InlineBox::isSVG() to hasVirtualHeight()
renamed InlineBox::setIsSVG() to setHasVirtualHeight()

  • rendering/InlineBox.cpp: (WebCore::InlineBox::height):
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::isText): (WebCore::InlineBox::setIsText): (WebCore::InlineBox::isSVGRootInlineBox): (WebCore::InlineBox::hasVirtualHeight): (WebCore::InlineBox::setHasVirtualHeight): (WebCore::InlineBox::virtualHeight):
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createFlowBox):
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::createTextBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createRootBox):
  • rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::virtualHeight):
  • rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::virtualHeight):
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::virtualHeight):
15:11 Changeset [45569] by alice.liu@apple.com

2009-07-06 Alice Liu <alice.liu@apple.com>

Reviewed by Darin Adler.

REGRESSION(r45285): focus rings are black on windows safari
https://bugs.webkit.org/show_bug.cgi?id=26821
<rdar://problem/7018252>

Add a mechanism for setting a custom focus ring color, and relocate the
determination of focus ring color to base class RenderTheme.

No new tests. Already-existing tests run in pixel mode would have caught this regression

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Move the responsibility of determining focus color to base class RenderTheme.
  • rendering/RenderTheme.cpp: (WebCore::customFocusRingColor): Added static local. (WebCore::RenderTheme::setCustomFocusRingColor): Added (WebCore::RenderTheme::focusRingColor): Use custom color over platform color.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::platformFocusRingColor): default implementation, black color
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderTheme::themeForPage): Circumstances that lead to returning the RenderThemeWin are the same under which we want to use the focus ring color from SafariTheme. (WebCore::RenderThemeSafari::platformFocusRingColor): Renamed from focusRingColor
  • rendering/RenderThemeSafari.h:

Renaming focusRingColor to platformFocusRingColor in these files:

  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::platformFocusRingColor):
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::platformFocusRingColor):
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::platformFocusRingColor):

Cleanup leftover from removal of WebCore::Color in r45285 in these files:

  • WebCore.order:
  • platform/graphics/Color.h:
14:53 Changeset [45568] by eric@webkit.org

2009-07-06 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Hyatt.

Bug 15135: REGRESSION (r19843-r19850): Changing a flexbox's
contents makes its container scroll to the top
https://bugs.webkit.org/show_bug.cgi?id=15135

Delay updateing scroll bar of descendants of flexbox until their
positions are determined. In this way we can prevent descendants
of flexible boxes from changing positions of their scrollbars
using tentative positions.

  • fast/flexbox/repaint-scrollbar-expected.txt: Added.
  • fast/flexbox/repaint-scrollbar.html: Added.
  • fast/flexbox/resources/repaint-scrollbar.js: Added.

2009-07-06 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Hyatt.

Bug 15135: REGRESSION (r19843-r19850): Changing a flexbox's
contents makes its container scroll to the top
https://bugs.webkit.org/show_bug.cgi?id=15135

Delay updateing scroll bar of descendants of flexbox until their
positions are determined. In this way we can prevent descendants
of flexible boxes from changing positions of their scrollbars
using tentative positions.

Test: fast/flexbox/repaint-scrollbar.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::startDelayUpdateScrollInfo): (WebCore::RenderBlock::finishDelayUpdateScrollInfo): (WebCore::RenderBlock::updateScrollInfoAfterLayout): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::layoutOnlyPositionedObjects):
  • rendering/RenderBlock.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
14:33 Changeset [45567] by eric@webkit.org

2009-07-06 Hironori Bono <hbono@chromium.org>

Reviewed by Maciej Stachowiak.

Make unconfirmed IME text affect textarea's value.
This matches input and contentEditable elements as well
IE and Firefox.

This fixes https://bugs.webkit.org/show_bug.cgi?id=25061.

Input elements would go down this code path because it
would always get a null compositionNode from frame->editor().
Special casing compositionNodes is wrong because we explicitly
want unconfirmed IME input in the textarea's value (assuming we
want to match IE and Firefox here).

This change is originally created by Ojan Vafai <ojan@chromium.org> and
I just changed its manual tests with an automated test on his behalf.

  • platform/mac/editing/input/text-control-ime-input-expected.txt: Added.
  • platform/mac/editing/input/text-control-ime-input.html: Added.

2009-07-06 Hironori Bono <hbono@chromium.org>

Reviewed by Maciej Stachowiak.

Make unconfirmed IME text affect textarea's value.
This matches input and contentEditable elements as well
IE and Firefox.

This fixes https://bugs.webkit.org/show_bug.cgi?id=25061.

Input elements would go down this code path because it
would always get a null compositionNode from frame->editor().
Special casing compositionNodes is wrong because we explicitly
want unconfirmed IME input in the textarea's value (assuming we
want to match IE and Firefox here).

This change is originally created by Ojan Vafai <ojan@chromium.org> and
I just changed its manual tests with an automated test on his behalf.

Test: platform/mac/editing/input/text-control-ime-input.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::text): (WebCore::RenderTextControl::textWithHardLineBreaks):
14:13 Changeset [45566] by adachan@apple.com

Reviewed by Darin Adler and Mark Rowe.

Decommitted spans are added to the list of normal spans rather than
the returned spans in TCMalloc_PageHeap::Delete().
https://bugs.webkit.org/show_bug.cgi?id=26998


In TCMalloc_PageHeap::Delete(), the deleted span can be decommitted in
the process of merging with neighboring spans that are also decommitted.
The merged span needs to be placed in the list of returned spans (spans
whose memory has been returned to the system). Right now it's always added
to the list of the normal spans which can theoretically cause thrashing.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::Delete):
13:59 Changeset [45565] by andersca@apple.com

WebCore:

2009-07-06 Anders Carlsson <andersca@apple.com>

Reviewed by Adele Peterson.

Add the ability for wheel events to latch to a node.


  • WebCore.base.exp:
  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::clear): (WebCore::EventHandler::handleWheelEvent):
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::wheelEvent):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit/mac:

2009-07-06 Anders Carlsson <andersca@apple.com>

Reviewed by Adele Peterson.

Initialize wkIsLatchingWheelEvent.


  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
13:55 Changeset [45564] by japhet@chromium.org

2009-07-06 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a bunch of layout test crahses in Chromium caused by a bad usage of DEFINE_STATIC_LOCAL.

https://bugs.webkit.org/show_bug.cgi?id=26997

  • bindings/v8/V8Binding.cpp: (WebCore::v8ValueToWebCoreString): Use a regular static declaration instead of DEFINE_STATIC_LOCAL.
13:48 Changeset [45563] by andersca@apple.com

2009-07-06 Anders Carlsson <andersca@apple.com>

Update WebKitSystemInterface.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
13:47 Changeset [45562] by eric@webkit.org

2009-07-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: suggest global properties based on async evaluation.

https://bugs.webkit.org/show_bug.cgi?id=26976

Before this change, empty string was evaluated to the global object
(or scope chain object) synchronously. This is now fixed and global
object is evaluated using the same control flow.

  • inspector/front-end/Console.js: (WebInspector.Console.prototype.completions): (WebInspector.Console.prototype._evalInInspectedWindow):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._variablesInScope):
13:37 Changeset [45561] by ojan@chromium.org

WebCore:

2009-07-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Fix crash when indenting in an empty table cell.
https://bugs.webkit.org/show_bug.cgi?id=26872

The crash is that we would call splitTreeToNode where the node
and the nodeToSplitTo were the same node.

Test: editing/execCommand/indent-empty-table-cell.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode): Added an assert in that node and nodeToSplitTo are different nodes to make this assumption explicit.
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::isAtUnsplittableElement): (WebCore::IndentOutdentCommand::indentRegion):
  • editing/IndentOutdentCommand.h:

LayoutTests:

2009-07-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Fix crash when indenting in an empty table cell.
https://bugs.webkit.org/show_bug.cgi?id=26872

The crash is that we would call splitTreeToNode where the node
and the nodeToSplitTo were the same node.

  • editing/execCommand/indent-empty-table-cell-expected.txt: Added.
  • editing/execCommand/indent-empty-table-cell.html: Added.
11:10 Changeset [45560] by cmarrin@apple.com

added pseudocode form decomposition method

10:38 Changeset [45559] by japhet@chromium.org

2009-07-06 Nate Chapin <japhet@chromium.org>

Reviewed by David Levin.

Upstream V8Binding and update some function names.

https://bugs.webkit.org/show_bug.cgi?id=26857

07:37 Changeset [45558] by kov@webkit.org

WebCore

2009-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Jan Alonzo.

Use soup's content sniffing
https://bugs.webkit.org/show_bug.cgi?id=26982

Drop our hackish content sniffing code, and use the new libsoup
feature to do that job for us.

Testing this is in a cross-platform way is not obvious or possible
while we are using platform-specific code for sniffing.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::contentSniffedCallback): (WebCore::gotChunkCallback): (WebCore::ResourceHandle::startHttp):

WebKit/gtk

2009-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Jan Alonzo.

Use soup's content sniffing
https://bugs.webkit.org/show_bug.cgi?id=26982

Add the new Content Sniffing feature provided by libsoup.

  • webkit/webkitprivate.cpp: (webkit_init):

07/05/09:

22:22 Changeset [45557] by darin@apple.com

2009-07-05 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Darin Adler.

REGRESSION (r40499): fast/dom/cssTarget-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=20342

Re-added code removed by commit r40499.
Without this, both Qt and Mac were crashing while running the test.

Note that this does not entirely fix the bug. It fixes the WebCore
crash, but the test no longer seems to work due to loader changes.
So this patch does not reenable the test. The test probably has to
be rewritten.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removedFromDocument): Re-added code to set the CSS target of the document to 0.
18:46 Changeset [45556] by simon.fraser@apple.com

2009-07-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26943

When one transition finishes slightly before another the longer
one will fire a second time. This is because the second
ImplicitAnmation object is culled too early, before its final
RenderStyle is in place. This is done by cleanupFinishedAnimations()
so I got rid of that method completely and now cleanup each
transition or animation at the point where I am setting the final
style, or when I detect that the transition or animation has been
terminated early (which happens when you remove it from the style).

Test: transitions/extra-transition.html

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate):
  • page/animation/CompositeAnimation.h:
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent): Avoid a divide by zero if m_animation->duration() is zero, which can happen if the duration is changed to zero while the animation is running.
12:39 Changeset [45555] by simon.fraser@apple.com

2009-07-05 Simon Fraser <simon.fraser@apple.com>

Revert the previous commit because it broke the
animations/transition-and-animation-1.html
testcase.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent):
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate): (WebCore::CompositeAnimation::cleanupFinishedAnimations):
  • page/animation/CompositeAnimation.h:
12:18 Changeset [45554] by simon.fraser@apple.com

2009-07-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26943

When one transition finishes slightly before another the longer
one will fire a second time. This is because the second
ImplicitAnmation object is culled too early, before its final
RenderStyle is in place. This is done by cleanupFinishedAnimations()
so I got rid of that method completely and now cleanup each
transition or animation at the point where I am setting the final
style, or when I detect that the transition or animation has been
terminated early (which happens when you remove it from the style).

Test: transitions/extra-transition.html

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate):
  • page/animation/CompositeAnimation.h:
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent): Avoid a divide by zero if m_animation->duration() is zero, which can happen if the duration is changed to zero while the animation is running.
08:45 Changeset [45553] by hausmann@webkit.org

JavaScriptCore:

2009-07-05 Lars Knoll <lars.knoll@nokia.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26843

Fix run-time crashes in JavaScriptCore with the Metrowerks compiler on Symbian.

The Metrowerks compiler on the Symbian platform moves the globally
defined Hashtables into read-only memory, despite one of the members
being mutable. This causes crashes at run-time due to write access to
read-only memory.

Avoid the use of const with this compiler by introducing the
JSC_CONST_HASHTABLE macro.

Based on idea by Norbert Leser.

  • runtime/Lookup.h: Define JSC_CONST_HASHTABLE as const for !WINSCW.
  • create_hash_table: Use JSC_CONST_HASHTABLE for hashtables.
  • runtime/JSGlobalData.cpp: Import various global hashtables via the macro.

WebCore:

2009-07-05 Lars Knoll <lars.knoll@nokia.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26843

Fix run-time crashes in JavaScriptCore with the Metrowerks compiler on Symbian.

The Metrowerks compiler on the Symbian platform moves the globally
defined Hashtables into read-only memory, despite one of the members
being mutable. This causes crashes at run-time due to write access to
read-only memory.

Avoid the use of const with this compiler by introducing the
JSC_CONST_HASHTABLE macro.

Based on idea by Norbert Leser.

  • bindings/scripts/CodeGeneratorJS.pm: Use JSC_CONST_HASHTABLE for hash tables define in the bindings.
07:53 Changeset [45552] by zecke@webkit.org

2009-07-05 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Xan Lopez.

Always initialize WebCore.

It is possible that WebKitWebSettings and other classes get
constructed before the WebKitWebView. In this case WebCore is
not yet properly initialized. Add webkit_init to every class
that can be constructed by API users.

  • webkit/webkitdownload.cpp: (webkit_download_class_init):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_class_init):
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_class_init):
  • webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_class_init):
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
  • webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_class_init):
07:33 Changeset [45551] by hausmann@webkit.org

2009-07-05 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger Freyther.

Fix two qdoc warnings.

Added missing \property for QWebFrame::hasFocus and added \a
tag for pos of QWebPage::frameAt.

  • Api/qwebframe.cpp:
  • Api/qwebpage.cpp:
06:06 Changeset [45550] by rwlbuis@webkit.org

Reviewed by Maciej Stachowiak.

Bug 26897 - Dynamic SVG images do not display correctly
https://bugs.webkit.org/show_bug.cgi?id=26897

Use repaint() to fix a rendering problem with a SVG image embedded in xhtml.

Test: svg/custom/createImageElement2.xhtml

  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged):
03:43 Changeset [45549] by xan@webkit.org

2009-07-05 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=26960
[Gtk] caret offset not updated when selecting text

Report the caret offset from the end of the selection so it works
correctly for multi-char selections too (ie, anything that is not
the zero width caret).

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset):
00:28 Changeset [45548] by zecke@webkit.org

Fix Qt link error by adding two new localized strings

In r45474 two new strings got added to LocalizedStrings.h add
the definition of them to Qt.

00:27 Changeset [45547] by zecke@webkit.org

2009-07-04 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Simon Hausmann.

Use the recently introduced FocusController::setFocused

Use the recently introduced FocusController::setFocused
in the Qt platform. The SelectionController will be updated
from within the FocusController now.

  • Api/qwebpage.cpp: (QWebPagePrivate::focusInEvent): (QWebPagePrivate::focusOutEvent):

07/04/09:

10:53 Changeset [45546] by mitz@apple.com
  • debug build fix
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::getLastParen):
07:21 Changeset [45545] by mjs@apple.com

2009-07-03 Yong Li <yong.li@torchmobile.com>

Reviewed by Maciej Stachowiak (and revised slightly)

RegExp::match to be optimized
https://bugs.webkit.org/show_bug.cgi?id=26957

Allow regexp matching to use Vectors with inline capacity instead of
allocating a new ovector buffer every time.


~5% speedup on SunSpider string-unpack-code test, 0.3% on SunSpider overall.

  • runtime/RegExp.cpp: (JSC::RegExp::match):
  • runtime/RegExp.h:
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructorPrivate::RegExpConstructorPrivate): (JSC::RegExpConstructorPrivate::lastOvector): (JSC::RegExpConstructorPrivate::tempOvector): (JSC::RegExpConstructorPrivate::changeLastOvector): (JSC::RegExpConstructor::performMatch): (JSC::RegExpMatchesArray::RegExpMatchesArray): (JSC::RegExpMatchesArray::fillArrayInstance): (JSC::RegExpConstructor::getBackref): (JSC::RegExpConstructor::getLastParen): (JSC::RegExpConstructor::getLeftContext): (JSC::RegExpConstructor::getRightContext):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncSplit):
07:20 Changeset [45544] by mjs@apple.com

2009-07-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric Seidel.

bugzilla-tool forgot how to obsolete patches
https://bugs.webkit.org/show_bug.cgi?id=26951

  • Scripts/modules/bugzilla.py:

07/03/09:

21:50 Changeset [45543] by darin@apple.com

Added Radar link I left out by accident the first time.

21:48 Changeset [45542] by darin@apple.com

2009-07-03 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r44670-r44680): Typing is suprisingly slow in password field on reddit.com
https://bugs.webkit.org/show_bug.cgi?id=26959

The code to handle iteration boundaries was malfunctioning when the boundary was
at the edge of a shadow tree. This happens all the time with <input> elements.

It's not immediately obvious how to make a regression test for this since the
symptom was a performance problem, not incorrect behavior. I'll add a test if I
figure out a way to make one.

  • editing/TextIterator.cpp: (WebCore::parentCrossingShadowBoundaries): Renamed from parentOrShadowParent. (WebCore::depthCrossingShadowBoundaries): Updated for name change. (WebCore::nextInPreOrderCrossingShadowBoundaries): Added. (WebCore::previousInPostOrderCrossingShadowBoundaries): Added. (WebCore::setUpFullyClippedStack): Updated for name change. (WebCore::TextIterator::TextIterator): Updated for name change. Use nextInPreOrderCrossingShadowBoundaries instead of Range::pastLastNode to fix the bug. (WebCore::TextIterator::advance): Updated for name change. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Tweaked formatting. (WebCore::SimplifiedBackwardsTextIterator::advance): Ditto. Changed code that initializes m_pastStartNode to use previousInPostOrderCrossingShadowBoundaries. (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode): Tweaked formatting. (WebCore::SimplifiedBackwardsTextIterator::exitNode): Ditto.
20:56 Changeset [45541] by mitz@apple.com

Reviewed by Simon Fraser.

  • fix <rdar://problem/6964278> REGRESSION (r42118): Scrolling redraw problem in FileMaker Pro
  • WebView/WebHTMLView.mm: (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Perform layout if needed, even on Mac OS X versions that have -viewWillDraw. This prevents attempts to draw without layout in case -viewWillDraw was not called due to NSView issues or the client did something during the display operation that re-invalidated the layout.
20:27 Changeset [45540] by ddkilzer@apple.com

Bug 26958: Change edit link to review link in request messages

<https://bugs.webkit.org/show_bug.cgi?id=26958>

Reviewed by Dan Bernstein.

  • template/en/custom/request/email.txt.tmpl: Copied from BugsSite/template/en/default/request/email.txt.tmpl. Changed link from "action=edit" to "action=review".
18:09 Changeset [45539] by zimmermann@webkit.org

Not reviewed. Forgot to land ontimer-inline-event.html results within my last WML commit.

17:19 Changeset [45538] by ddkilzer@apple.com

Bug 26950: Make the summary and alias fields support click-to-edit
<https://bugs.webkit.org/show_bug.cgi?id=26950>

Reviewed by Maciej Stachowiak.

Original patch by Maciej Stachowiak.

  • js/field.js: (hideEditableField): Updated to add click event listeners to the alias and short description elements to make them easier to edit. Renamed field_id parameter to field2_id (short description id) and added a field1_id parameter (alias id). (showEditableField): If a third parameter is passed in the ContainerInputArray parameter, use it to find the element to focus. Otherwise, fall back to the original behavior of focusing the first input field. (hideAliasAndSummary): Changed to pass the id for the alias element to hideEditableField().
13:54 Changeset [45537] by simon.fraser@apple.com

2009-07-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Background audio stops playing when JS GC runs
https://bugs.webkit.org/show_bug.cgi?id=26956

Ensure we keep the Audio object around while it is playing, so that it
doesn't get collected.

Not testable because there's no way to know whether the audio keeps
playing without holding a reference to it.

  • bindings/js/JSDOMBinding.cpp: (WebCore::isObservableThroughDOM):
12:34 Changeset [45536] by abarth@webkit.org

2009-07-03 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Adam and Collin's affiliation is incorrect
https://bugs.webkit.org/show_bug.cgi?id=26954

This change corrects their affiliation.

  • security/security-group-members.html:
07:08 Changeset [45535] by xan@webkit.org

2009-07-02 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=26814
[Gtk] Caret-moved events are not issued for the correct offset
when text is selected forward

Report the caret offset from the end of the selection, otherwise
we'll report the same offset when moving the caret while
modififying the selection (eg, with Shift + Right).

  • editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
07:08 Changeset [45534] by xan@webkit.org

2009-07-02 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=26815
[Gtk] text-selection-changed events are not issued for the correct
object when the selection spans multiple objects

Get the focused node from the end of the selection, not the start,
so we can detect when we cross object boundaries.

  • editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
03:47 Changeset [45533] by dimich@chromium.org

2009-07-03 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Fisher.

Increase delay in worker-terminate layout test to make it more reliable.
https://bugs.webkit.org/show_bug.cgi?id=26917

This test used time delay to see of terminated worker does not return
messages (terminated). In some test conditions, the current delay (500ms)
is too short and test fails. Move setting the delay to the end of initialization
and increase it 2x to make test more reliable.

  • fast/workers/worker-terminate.html:
03:24 Changeset [45532] by jmalonzo@webkit.org

2009-07-03 Jan Michael Alonzo <jmalonzo@webkit.org>

Skip tests that require expected results that Gtk doesn't have.

  • platform/gtk/Skipped:
02:57 Changeset [45531] by jmalonzo@webkit.org

2009-07-03 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez and Gustavo Noronha.

Set user-agent from application
https://bugs.webkit.org/show_bug.cgi?id=17375

Add 'user-agent' setter/getter API to WebSettings.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): (WebKit::FrameLoaderClient::userAgent):
  • WebCoreSupport/FrameLoaderClientGtk.h:
  • webkit/webkitprivate.h:
  • webkit/webkitversion.h.in:
  • webkit/webkitwebsettings.cpp: (webkit_get_user_agent): (webkit_web_settings_class_init): (webkit_web_settings_finalize): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy): (webkit_web_settings_get_user_agent):
  • webkit/webkitwebsettings.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_dispose):

Define UA version macros to be used by the UA string.
Add new WebSettings unit test for the User-Agent string API.

  • GNUmakefile.am:
  • configure.ac:

07/02/09:

22:21 Changeset [45530] by pdherbemont@apple.com

Edit WebCore/ChangeLog last entry to fix a spelling typo.

Pointed out by Mark Rowe.

22:12 Changeset [45529] by pdherbemont@apple.com

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26947

Fix the media controls hit tests. They may loose click events.

Test cases already covered in the video-controls-zoomed tests.

Don't trust wkHitTestMediaUIPart for the tests. We are accurate enough.

  • rendering/RenderThemeMac.h: Remove hitTestMediaControlPart.
  • rendering/RenderThemeMac.mm: Remove hitTestMediaControlPart.
20:34 Changeset [45528] by ddkilzer@apple.com

Ignore data/template cache directory and update data/params.

20:15 Changeset [45527] by bfulgham@webkit.org

2009-07-02 Brent Fulgham <bfulgham@webkit.org>

Unreviewed build fix (Cairo this time) for DumpRenderTree.
Put Cairo code back in, but use original include order
for the CG stuff to avoid compile issues.

  • DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView):
19:14 Changeset [45526] by ddkilzer@apple.com

Config file for contrib/recode.pl when upgrading bugs.webkit.org

Current as of midday on Wednesday, July 1, 2009.

  • contrib/recode-overrides.txt: Added.
19:14 Changeset [45525] by ddkilzer@apple.com

Workaround for WebKit Bug 9630 when running contrib/recode.pl

A number of WebKit nightly builds included Bug 9630 which caused
non-breaking space characters (0xA0) to be submitted within the
content of textarea elements.

  • contrib/recode.pl: To work around these 0xA0 characters, try an encoding of cp1252 and use it if it works.
19:14 Changeset [45524] by ddkilzer@apple.com

Don't print "Failed to guess" warning if an override is available

  • contrib/recode.pl: Check that %overrides does NOT contain a key matching the current digest before printing out the warning about a failed charset guess.
19:14 Changeset [45523] by ddkilzer@apple.com

Added --[no-]truncate switch to contrib/recode.pl

  • contrib/recode.pl: Added --[no-]truncate switch to make debugging of failed charset guessing easier. Often times the illegal character was truncated in the output.
19:14 Changeset [45522] by ddkilzer@apple.com

Changed Perl scripts to use #!/usr/bin/env perl

perl -pi -e 's@#\!/usr/bin/perl@#\!/usr/bin/env perl@' *.cgi *.pl */*.pl

19:14 Changeset [45521] by ddkilzer@apple.com

Replace Bugzilla favicon with webkit.org favicon

  • favicon.ico: Removed.
  • images/favicon.ico: Replaced. Copied from favicon.ico.
19:14 Changeset [45520] by ddkilzer@apple.com

Merged BugsSite to Bugzilla-3.2.3

Updated to the latest-and-greatest stable version.

19:13 Changeset [45519] by ddkilzer@apple.com

Merged BugsSite to Bugzilla-3.0.3

Nothing to see here. Move along.

18:38 Changeset [45518] by pdherbemont@apple.com

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26944

Make sure we support full page zoom in video controls.

This is tracked by a the video-controls-zoom test case.

  • css/mediaControlsQT.css: Make sure we don't have any inherited margin.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::updateStyle): Propagate the style to the innertext.
  • rendering/RenderThemeMac.mm: Adjust the painting rect. (WebCore::getUnzoomedRectAndAdjustCurrentContext): (WebCore::RenderThemeMac::paintMediaSliderTrack): (WebCore::RenderThemeMac::paintMediaCurrentTime): (WebCore::RenderThemeMac::paintMediaTimeRemaining):
18:29 Changeset [45517] by eric@webkit.org

2009-07-02 Roland Steiner <rolandsteiner@google.com>

Reviewed by Eric Seidel.

RenderBlock and RenderInline have confusingly named object creation methods:
RenderBlock::createRootBox/createRootInlineBox
RenderInline::createFlowBox/createInlineFlowBox
where the 2nd method in both cases just calls the first and then appends the created object.
I therefore renamed those methods to something IMHO more informative:

createRootBox() -> createRootInlineBox()
createRootInlineBox() -> createAndAppendRootInlineBox();
createFlowBox() -> createInlineFlowBox();
createInlineFlowBox() -> createAndAppendInlineFlowBox();

https://bugs.webkit.org/show_bug.cgi?id=26828

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::createRootInlineBox): (WebCore::RenderBlock::createAndAppendRootInlineBox):
  • rendering/RenderBlock.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::createInlineFlowBox): (WebCore::RenderInline::createAndAppendInlineFlowBox):
  • rendering/RenderInline.h:
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createInlineFlowBox):
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createRootInlineBox):
  • rendering/RenderSVGText.h:
  • rendering/bidi.cpp: (WebCore::createInlineBoxForRenderer):
18:23 Changeset [45516] by eric@webkit.org

2009-07-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Fix typo in the resource panel enabler caption.

https://bugs.webkit.org/show_bug.cgi?id=26753

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel):
18:06 Changeset [45515] by eric@webkit.org

2009-07-02 Erik Arvidsson <arv@chromium.org>

Reviewed by Adam Roben.

[Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
https://bugs.webkit.org/show_bug.cgi?id=26699

  • manual-tests/drag-escape.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::dragSourceEndedAt):

2009-07-02 Erik Arvidsson <arv@chromium.org>

Reviewed by Adam Roben.

[Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
https://bugs.webkit.org/show_bug.cgi?id=26699

  • WebDropSource.cpp: (WebDropSource::QueryContinueDrag):
17:55 Changeset [45514] by eric@webkit.org

2009-07-02 Eric Seidel <eric@webkit.org>

Correct blatant typo (missing []), no review.

  • Scripts/modules/scm.py:
17:54 Changeset [45513] by pdherbemont@apple.com

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Added the test result of r45511 for platform/mac.

  • platform/mac/media/controls-strict-expected.txt: Added.
17:37 Changeset [45512] by bfulgham@webkit.org

2009-07-02 Brent Fulgham <bfulgham@webkit.org>

Windows build fix, no review.

Reverting PixelDumpSupportWin.cpp change to avoid strange
error on the build-bot.


  • DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView):
17:18 Changeset [45511] by pdherbemont@apple.com

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Fix the Gtk build after r45474. The localized strings should
have been added there.

  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText):
17:07 Changeset [45510] by pdherbemont@apple.com

WebCore:

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26939

Media controller is rendered badly at http://www.mozilla.com/en-US/firefox/video/firefox-3.5.html

We fix two things:

  • We use px instead of em, because px is used everywhere else and because 0.09em hit the font size limit.
  • We use -webkit-box instead of inline-block because in strict mode inline-block has a different behavior.

Test: media/controls-strict.html

  • css/mediaControlsQT.css:

LayoutTests:

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26939

Media controller is rendered badly at http://www.mozilla.com/en-US/firefox/video/firefox-3.5.html

Test that the controller renders correctly in strict mode as well.

  • media/controls-strict.html: Added.
  • platform/mac/media/controls-strict-mode-expected.txt: Added.
17:03 Changeset [45509] by bfulgham@webkit.org

2009-07-02 Brent Fulgham <bfulgham@webkit.org>

Build fix, no review.

  • DumpRenderTree/config.h:
16:55 Changeset [45508] by oliver@apple.com

<rdar://problem/6939593> REGRESSION (r37793): Hitting back button on Google often gives non-interactive Google page (26670)
<https://bugs.webkit.org/show_bug.cgi?id=26670>

Reviewed by Anders Carlsson

Make windows loader client match mac behaviour more closely.

16:53 Changeset [45507] by eric@webkit.org

2009-07-02 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

bugzilla-tool needs to handle login failure
https://bugs.webkit.org/show_bug.cgi?id=26913

We now exit(1) on login failure.

  • Scripts/modules/bugzilla.py:
16:53 Changeset [45506] by hyatt@apple.com

2009-07-02 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

TextIterator should use hasOverflowClip when checking for overflow instead of looking at the style.
https://bugs.webkit.org/show_bug.cgi?id=26942

  • editing/TextIterator.cpp: (WebCore::fullyClipsContents):
16:49 Changeset [45505] by bfulgham@webkit.org

WebKit/win:

2009-06-30 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Adam Roben.

Build DumpRenderTree under Cairo.
https://bugs.webkit.org/show_bug.cgi?id=26457

  • WebKit.vcproj/WebKit.sln: Add Cairo targets to the DumpRenderTree build, and use the in the Debug_Cairo and Release_Cairo targets.

WebKitTools:

2009-06-30 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Add build support for a Windows Cairo version of
DumpRenderTree. Share as much logic between the
CG and Cairo builds as possible.
https://bugs.webkit.org/show_bug.cgi?id=26457

  • DumpRenderTree/PixelDumpSupport.cpp: Added. (dumpWebViewAsPixelsAndCompareWithExpected): Moved common logic from CG-specific file. (printPNG): Moved common logic from CG-specific file.
  • DumpRenderTree/PixelDumpSupport.h: Add declaration for new common printPNG function.
  • DumpRenderTree/cairo: Added.
  • DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Added. Implement cairo-specific logic for dealing with Cairo surfaces. (writeFunction): (printPNG): Cairo-specific PNG handling logic. (computeMD5HashStringForBitmapContext): New Cairo routine using the generic BitmapContext signature. (dumpBitmap): New function containing Cairo-specific portions of the dumping routine.
  • DumpRenderTree/cairo/PixelDumpSupportCairo.h: Added. Provide Cairo version of the BitmapContext structure so that dumping routines can work on an abstract type. (BitmapContext::createByAdoptingBitmapAndContext): (BitmapContext::~BitmapContext): (BitmapContext::cairoContext): (BitmapContext::BitmapContext):
  • DumpRenderTree/cg/PixelDumpSupportCG.cpp: (printPNG): CG-specific PNG handling logic. (computeMD5HashStringForBitmapContext): Revised to use generic BitmapContext signature. (dumpBitmap): New function containing CG-specific portions of the dumping routine.
  • DumpRenderTree/cg/PixelDumpSupportCG.h: Add new signatures.
  • DumpRenderTree/win/DumpRenderTree.cpp: Disable CFNetwork logic when building the non-CFNetwork version. (main):
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView): Provide parallel Cairo implementation of CG bitmap/context setup.
16:45 Changeset [45504] by weinig@apple.com

2009-07-02 Sam Weinig <sam@webkit.org>

Reviewed by Dave Hyatt.

Fix for <rdar://problem/5230700>
Remove local .xhtml file workaround

  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): Work around is no longer necessary.
16:36 Changeset [45503] by mrowe@apple.com

Versioning.

16:34 Changeset [45502] by andersca@apple.com

WebCore:

2009-07-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Sort, add functions used by WebKit.


  • WebCore.base.exp:

WebKit/mac:

2009-07-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6978783>
Software-rendered plug-in does not update correctly when inside a hardware layer


Replace calls to setNeedsDisplay: and setNeedsDisplayInRect: with a call to the new method
invalidatePluginContentRect:. This new method will ask WebCore to do the repainting, taking
transforms into account.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invalidateRect):
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginHostDied]):
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView preferencesHaveChanged:]): (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView invalidateRect:]): (-[WebNetscapePluginView invalidateRegion:]): (-[WebNetscapePluginView forceRedraw]):
16:33 Changeset [45501] by mrowe@apple.com

New tag.

16:31 Changeset [45500] by hyatt@apple.com

2009-07-02 David Hyatt <hyatt@apple.com>

Reviewed by Mark Rowe.

Land new results from my change to make replaced elements no longer be overflow:hidden by
default. This affected plaintext dumping, which is clearly a bug in and of itself. For now
I am just updating the results and will file a followup bug about the fact that text dumping actually
does something different with overflow on replaced elements (when it clearly should not).

  • fast/block/float/crash-replaced-display-block-expected.txt:
  • fast/dom/Range/acid3-surround-contents-expected.txt:
  • fast/dom/object-embed-plugin-scripting-expected.txt:
  • fast/parser/badentity-expected.txt:
  • http/tests/security/local-video-poster-from-remote-expected.txt:
16:28 Changeset [45499] by beidson@apple.com

2009-07-02 Brady Eidson <beidson@apple.com>

Rubberstamped by Sam Weinig.

More of <rdar://problem/6969425> Safari 4.0 doesn't recognize text/plain files if their extension is unknown.

  • platform/network/mac/WebCoreURLResponse.mm: (webNSURLResponseMIMEType): Give Tiger a chance to query the UTI machinery.
16:18 Changeset [45498] by beidson@apple.com

2009-07-02 Brady Eidson <beidson@apple.com>

Rubberstamped by John Sullivan.

Add Tiger-specific results for these tests.

  • platform/mac-tiger/Skipped:
  • platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
  • platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
  • platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-expected.txt:
16:01 Changeset [45497] by beidson@apple.com

2009-07-02 Brady Eidson <beidson@apple.com>

Skip the correct test names.

  • platform/mac-tiger/Skipped:
15:40 Changeset [45496] by agl@chromium.org

2009-07-02 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium Linux: fix complex text rendering with line break characters.

https://bugs.webkit.org/show_bug.cgi?id=26935

If the CSS white-space property is inhibiting line breaking, we might
find end-of-line characters rendered via the complex text path. Fonts
don't provide glyphs for these code points so, if we find one, we
simulate the space glyph being interposed in this case. Because the
input is variable-length per code point, we walk the input in step
with the output.

Covered by:

LayoutTests/fast/text/international/bidi-linebreak-002.html
LayoutTests/fast/text/international/bidi-linebreak-003.html
LayoutTests/fast/text/international/hindi-whitespace.html

  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::stringToGlyphs):
15:25 Changeset [45495] by beidson@apple.com

2009-07-02 Brady Eidson <beidson@apple.com>

Rubberstamped by Sam Weinig

Split up file-url-mimetypes.html into 3 tests to avoid any risk of timing out on slower machines.

  • platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
  • platform/mac/fast/loader/file-url-mimetypes-2.html: Copied from platform/mac/fast/loader/file-url-mimetypes.html.
  • platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
  • platform/mac/fast/loader/file-url-mimetypes-3.html: Copied from platform/mac/fast/loader/file-url-mimetypes.html.
  • platform/mac/fast/loader/file-url-mimetypes-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes.html:
  • platform/mac-tiger/Skipped:
15:22 Changeset [45494] by dglazkov@chromium.org

2009-07-02 Victor Wang <victorw@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26521
Expose file size to chromium.

Implement getFileSize() for Chromium.

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/FileSystemChromium.cpp: (WebCore::getFileSize):
15:21 Changeset [45493] by eric@webkit.org

2009-07-02 Eric Seidel <eric@webkit.org>

No review, just adding Antti as a reviewer.

  • Scripts/modules/bugzilla.py:
15:21 Changeset [45492] by japhet@chromium.org

2009-07-02 Nate Chapin <japhet@chromium.org>

Unreviewed, build fix.

  • bindings/v8/V8SVGPODTypeWrapper.h: Lost a space in nested template argument list.
15:19 Changeset [45491] by simon.fraser@apple.com

2009-07-02 Simon Fraser <simon.fraser@apple.com>

Build fix: add missing #include.

  • platform/mac/ThemeMac.mm:
15:17 Changeset [45490] by beidson@apple.com

2009-07-02 Brady Eidson <beidson@apple.com>

Resolve failing Tiger layout test until I can fix it.

  • platform/mac-tiger/Skipped:
14:56 Changeset [45489] by simon.fraser@apple.com

2009-07-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

<rdar://problem/7028682> ThemeMac::paintRadio() throws Obj-C exceptions when zoomed

Add BEGIN_BLOCK_OBJC_EXCEPTIONS/END_BLOCK_OBJC_EXCEPTIONS guards around code
that can possibly throw Objective-C exceptions when drawing Mac form controls.

  • platform/mac/ThemeMac.mm: (WebCore::paintCheckbox): (WebCore::paintRadio): (WebCore::paintButton): (WebCore::ThemeMac::inflateControlPaintRect):
14:47 Changeset [45488] by japhet@chromium.org

2009-07-02 Nate Chapin <japhet@chromium.org>

Reviewed by David Levin.

Upstream V8SVGPODTypeWrapper.

https://bugs.webkit.org/show_bug.cgi?id=26907

14:40 Changeset [45487] by dglazkov@chromium.org

2009-07-02 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adds an abstraction layer between the DB classes and the file
system, which allows us to add our own logic for storing, opening,
deleting, etc. databases.

The patch was tested using the tests in WebCore/storage.

https://bugs.webkit.org/show_bug.cgi?id=26054

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open): Delegating the job of opening DB files to SQLiteFileSystem to allow use of custom VFSs.
  • platform/sql/SQLiteFileSystem.cpp: Added.
  • platform/sql/SQLiteFileSystem.h: Added.
  • platform/win/FileSystemWin.cpp: (WebCore::directoryName): Implemented.
  • storage/Database.cpp: (WebCore::Database::databaseSize): The code that returns the size of a DB file moved to SQLiteFileSystem.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker): Added the ability to register a custom SQLite VFS. (WebCore::DatabaseTracker::trackerDatabasePath): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::openTrackerDatabase): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::originPath): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::fullPathForDatabase): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::usageForDatabase): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::deleteOrigin): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::deleteDatabaseFile): DB file-related operations moved to SQLiteFileSystem.
  • storage/OriginUsageRecord.cpp: (WebCore::OriginUsageRecord::diskUsage): DB file-related operations moved to SQLiteFileSystem.
13:47 Changeset [45486] by hyatt@apple.com

2009-07-02 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

Always clip replaced elements to border radii.
https://bugs.webkit.org/show_bug.cgi?id=26933

Make sure to always clip replaced elements to border radii, even when overflow is visible.
Stop defaulting those elements to overflow:hidden in the UA sheet, since it is now no longer
necessary.

Covered by existing tests (since the UA default changing keeps the behavior exactly the same).

  • css/html.css:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
13:18 Changeset [45485] by hyatt@apple.com

2009-07-02 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Simon Fraser.

convertFromScrollbarToContainingView and friends should be in ScrollView
https://bugs.webkit.org/show_bug.cgi?id=26929

This is breaking Chromium's build because PopupMenuChromium inherits
from ScrollView, but these functions are pure virtual in it. I could
put it directly in PopupMenuChromium, but that seems a bit silly since
the functions are fairly generic.

Passes existing layout tests.

  • page/FrameView.cpp: Remove the 4 functions Hyatt just added (IntRect WebCore::FrameView::convertFromScrollbarToContainingView): (IntRect WebCore::FrameView::convertFromContainingViewToScrollBar): (IntPoint WebCore::FrameView::convertFromScrollbarToContainingView): (IntPoint WebCore::FrameView::convertFromContainingViewToScrollBar):
  • page/FrameView.h: ditto
  • platform/ScrollView.cpp: Move the 4 functions from FrameView here (IntRect WebCore::ScrollView::convertFromScrollbarToContainingView): (IntRect WebCore::ScrollView::convertFromContainingViewToScrollBar): (IntPoint WebCore::ScrollView::convertFromScrollbarToContainingView): (IntPoint WebCore::ScrollView::convertFromContainingViewToScrollBar):
  • platform/ScrollView.h: ditto
11:39 Changeset [45484] by aroben@apple.com

Fix warnings from update-webkit-localizable-strings

WebKit:

Fix warnings from update-webkit-localizable-strings

Rubber-stamped by Eric Carlson.

  • English.lproj/Localizable.strings: Updated.

WebKit/mac:

Fix warnings from update-webkit-localizable-strings

Rubber-stamped by Eric Carlson.

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory mediaElementLoadingStateText]): (-[WebViewFactory mediaElementLiveBroadcastStateText]): Changed the localization comments to match the comments in the Windows version of this file, to avoid warnings about different comments for the same localized string.
11:39 Changeset [45483] by aroben@apple.com

Update StringsNotToBeLocalized.txt for (not so) recent changes

Bug 26926: StringsNotToBeLocalized.txt is out-of-date
<https://bugs.webkit.org/show_bug.cgi?id=26926>

Reviewed by John Sullivan.

  • StringsNotToBeLocalized.txt:
11:06 Changeset [45482] by darin@chromium.org

2009-07-02 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Fisher.

Fix https://bugs.webkit.org/show_bug.cgi?id=26088 - TransparencyWin
doesn't handle errors well at all; revise it to fail silently
(drawing nothing), and bulletproof FontChromiumWin to handle the
failure accordingly.

Tests: fast/text/text-large-negative-letter-spacing-with-opacity.html

fast/text/text-letter-spacing.html

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::TransparencyWin): (WebCore::TransparencyWin::setupLayerForNoLayer): (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer): (WebCore::TransparencyWin::setupLayerForWhiteLayer): (WebCore::TransparencyWin::setupTransformForKeepTransform): (WebCore::TransparencyWin::setupTransformForScaleTransform): (WebCore::TransparencyWin::initializeNewContext): (WebCore::TransparencyWin::compositeOpaqueComposite): (WebCore::TransparencyWin::compositeTextComposite): (WebCore::TransparencyWin::makeLayerOpaque):
  • platform/graphics/chromium/TransparencyWin.h: (WebCore::TransparencyWin::platformContext):
10:51 Changeset [45481] by hyatt@apple.com

Fix build bustage caused by wrong include case.

10:41 Changeset [45480] by eric.carlson@apple.com

2009-07-02 Eric Carlson <eric.carlson@apple.com>

Change #import to #include to fix non-ObjC builds.

  • rendering/MediaControlElements.cpp:

2009-07-02 Eric Carlson <eric.carlson@apple.com>

Fix Windows build by including missing localized string methods.

  • WebCoreLocalizedStrings.cpp: (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText):
10:32 Changeset [45479] by andersca@apple.com

2009-07-02 Anders Carlsson <andersca@apple.com>

Build fix.


  • platform/network/mac/WebCoreURLResponse.mm: (mimeTypeFromUTITree):
10:31 Changeset [45478] by hyatt@apple.com

WebCore:

2009-07-02 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

Fix for bug 22119, clicks in the scrollbars of transformed content don't work. Add new
conversion methods for going across parent/child widget boundaries that can be implemented
by the FrameView and ScrollbarClient to be transform-aware.

Test cases added in platform/mac/fast/forms and platform/mac/fast/overflow.

  • WebCore.base.exp:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):
  • page/FrameView.cpp: (WebCore::FrameView::convertFromScrollbarToContainingView): (WebCore::FrameView::convertFromContainingViewToScrollbar): (WebCore::FrameView::convertFromRenderer): (WebCore::FrameView::convertToRenderer): (WebCore::FrameView::convertToContainingView): (WebCore::FrameView::convertFromContainingView):
  • page/FrameView.h:
  • platform/ScrollView.h:
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::convertToContainingView): (WebCore::Scrollbar::convertFromContainingView):
  • platform/Scrollbar.h:
  • platform/ScrollbarClient.h: (WebCore::ScrollbarClient::convertFromScrollbarToContainingView): (WebCore::ScrollbarClient::convertFromContainingViewToScrollbar):
  • platform/Widget.cpp: (WebCore::Widget::convertFromContainingWindow): (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromRootToContainingWindow): (WebCore::Widget::convertFromContainingWindowToRoot): (WebCore::Widget::convertToContainingView): (WebCore::Widget::convertFromContainingView):
  • platform/Widget.h:
  • platform/graphics/IntPoint.h: (WebCore::IntPoint::move):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::convertFromRootToContainingWindow): (WebCore::Widget::convertFromContainingWindowToRoot):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInOverflowControl):
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::convertFromScrollbarToContainingView): (WebCore::RenderDataGrid::convertFromContainingViewToScrollbar):
  • rendering/RenderDataGrid.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::convertFromScrollbarToContainingView): (WebCore::RenderLayer::convertFromContainingViewToScrollbar): (WebCore::RenderLayer::scrollbarOffset): (WebCore::RenderLayer::hitTestOverflowControls):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInOverflowControl): (WebCore::RenderListBox::convertFromScrollbarToContainingView): (WebCore::RenderListBox::convertFromContainingViewToScrollbar):
  • rendering/RenderListBox.h:

LayoutTests:

2009-07-02 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

Test cases for bug 22119, clicks in scrollbar of transformed element don't work.

  • platform/mac/fast/forms/listbox-scrollbar-hit-test-expected.txt: Added.
  • platform/mac/fast/forms/listbox-scrollbar-hit-test.html: Added.
  • platform/mac/fast/overflow/overflow-scrollbar-hit-test-expected.txt: Added.
  • platform/mac/fast/overflow/overflow-scrollbar-hit-test.html: Added.
10:19 Changeset [45477] by mitz@apple.com

WebCore:

Reviewed by Dave Hyatt and Simon Fraser.

  • fix <rdar://problem/6933052> SPOD playing video in a div with a box shadow

Test: fast/box-shadow/transform-fringing.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Clip out the box even if it has an opaque background, but in that case, inset the clip path by 1 pixel, to avoid antialiasing artifacts. Do not inset the clip rect by 1 pixel if the CTM is purely a translation. Move the shadow-casting path away in the non-rounded-rect case (it was already being done in the rounded-rect case), to avoid a black fringe when the CTM is not purely a translation.

LayoutTests:

Reviewed by Dave Hyatt and Simon Fraser.

  • test for part of <rdar://problem/6933052> SPOD playing video in a div with a box shadow
  • fast/box-shadow/transform-fringing.html: Added.
  • platform/mac/fast/box-shadow/transform-fringing-expected.checksum: Added.
  • platform/mac/fast/box-shadow/transform-fringing-expected.png: Added.
  • platform/mac/fast/box-shadow/transform-fringing-expected.txt: Added.
10:00 Changeset [45476] by beidson@apple.com

WebCore:

2009-07-02 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6969425> Safari 4.0 doesn't recognize text/plain files if their extension is unknown.

Walk the CoreTypes UTI tree for extensions with unknown MIME types, using the first MIME type found.

For many types of text files (such as source code files) this ends up being text/plain.

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Tweak the logging output.
  • platform/network/mac/WebCoreURLResponse.h:
  • platform/network/mac/WebCoreURLResponse.mm: (mimeTypeFromUTITree): (webNSURLResponseMIMEType): Use mimeTypeFromUTITree() to find a UTI-based MIME type for this file's extension. (-[NSURLResponse _webcore_reportedMIMEType]): Return the actual MIME type that CFNetwork gave us.

LayoutTests:

2009-07-02 Brady Eidson <beidson@apple.com>

Rubberstamped by Sam Weinig.

Add more sample files for extensions we should know the MIME types for.

  • platform/mac/fast/loader/file-url-mimetypes.html:
  • platform/mac/fast/loader/file-url-mimetypes-expected.txt:
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-3fr.3fr: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-aaf.aaf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ada.ada: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-adb.adb: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ads.ads: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-app.app: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-applescript.applescript: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-arw.arw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-as.as: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-aupreset.aupreset: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-c++.c++: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-c.c: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-caf.caf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cc.cc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cp.cp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cpp.cpp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cr2.cr2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cxx.cxx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-defs.defs: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dfont.dfont: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dlyan.dlyan: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dng.dng: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dylib.dylib: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-exp.exp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-exr.exr: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-f.f: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-f77.f77: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-f90.f90: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-f95.f95: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fff.fff: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-for.for: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-h++.h++: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-h.h: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hh.hh: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hp.hp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hpp.hpp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hxx.hxx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-icc.icc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-icm.icm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-icns.icns: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jav.jav: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-java.java: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jfx.jfx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-l.l: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lid.lid: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lm.lm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lmm.lmm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lpp.lpp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lxx.lxx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m.m: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m4a.m4a: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m4b.m4b: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m4v.m4v: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mig.mig: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mm.mm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mos.mos: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mrw.mrw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-nef.nef: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-o.o: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-omf.omf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-orf.orf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pas.pas: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pch++.pch++: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pch.pch: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pef.pef: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pf.pf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pfa.pfa: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pfb.pfb: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-plist.plist: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-r.r: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-raf.raf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-raw.raw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-s.s: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-scpt.scpt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sd2.sd2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sf2.sf2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-srf.srf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-suit.suit: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tbz.tbz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tbz2.tbz2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ttc.ttc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ttf.ttf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ul.ul: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ulaw.ulaw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ulw.ulw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-war.war: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-y.y: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ym.ym: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ymm.ymm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ypp.ypp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-yxx.yxx: Added.
09:33 Changeset [45475] by simon.fraser@apple.com

2009-07-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Compositing-related preference methods are not public API; should move to WebPreferencesPrivate.h
<rdar://problem/7027363>

Move accelerated-compositing pref to WebPreferencesPrivate.h

  • WebView/WebPreferences.h:
  • WebView/WebPreferences.mm: (-[WebPreferences acceleratedCompositingEnabled]): (-[WebPreferences setAcceleratedCompositingEnabled:]):
  • WebView/WebPreferencesPrivate.h:
08:47 Changeset [45474] by eric.carlson@apple.com

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6518119>

Add a rewind button and hide the timeline for live broadcasts when
in MediaUI mode.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Add the new pseudo element.
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
  • css/CSSValueKeywords.in: Ditto.
  • css/mediaControls.css: Ditto.
  • css/mediaControlsQT.css: Ditto.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::rewind): New. (WebCore::HTMLMediaElement::returnToRealTime): New. (WebCore::HTMLMediaElement::isStreaming): New.
  • html/HTMLMediaElement.h:
  • page/mac/WebCoreViewFactory.h: Declare mediaElementLoadingStateText and mediaElementLiveBroadcastStateText.
  • platform/LocalizedStrings.h: Add localized media state messages.
  • platform/ThemeTypes.h: Add the new pseudo element.
  • platform/mac/LocalizedStringsMac.mm: (WebCore::mediaElementLoadingStateText): Add localized media state. (WebCore::mediaElementLiveBroadcastStateText): Ditto.
  • platform/mac/WebCoreSystemInterface.h: Change BOOL param wkDrawMediaUIPart to an int to support

multiple states.

  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::MediaControlElement): Deal with new elements. (WebCore::MediaControlElement::attachToParent): Ditto. (WebCore::MediaControlElement::update): Ditto. (WebCore::MediaControlElement::updateStyle): Ditto. (WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement): Ditto. (WebCore::MediaControlTimelineContainerElement::rendererIsNeeded): Ditto. (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement): Ditto. (WebCore::MediaControlStatusDisplayElement::update): Ditto. (WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): Ditto. (WebCore::MediaControlInputElement::MediaControlInputElement): Ditto. (WebCore::MediaControlInputElement::attachToParent): Ditto. (WebCore::MediaControlInputElement::updateStyle): Ditto. (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Ditto. (WebCore::MediaControlRewindButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::rendererIsNeeded): Ditto. (WebCore::MediaControlTimelineElement::defaultEventHandler): Ditto. (WebCore::MediaControlTimelineElement::update): Ditto. (WebCore::MediaControlFullscreenButtonElement::rendererIsNeeded): Ditto.
  • rendering/MediaControlElements.h: Ditto.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange): Deal with the new elements. (WebCore::RenderMedia::createPanel): Ditto. (WebCore::RenderMedia::createRewindButton): Ditto. (WebCore::RenderMedia::createReturnToRealtimeButton): Ditto. (WebCore::RenderMedia::createStatusDisplay): Ditto. (WebCore::RenderMedia::createTimelineContainer): Ditto. (WebCore::RenderMedia::createCurrentTimeDisplay): Ditto. (WebCore::RenderMedia::createTimeRemainingDisplay): Ditto. (WebCore::RenderMedia::updateControls): Ditto. (WebCore::RenderMedia::forwardEvent): Ditto.
  • rendering/RenderMedia.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Deal with the new elements.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::paintMediaRewindButton): Deal with the new elements. (WebCore::RenderTheme::paintMediaReturnToRealtimeButton): Ditto. (WebCore::RenderTheme::paintMediaControlsBackground): Ditto.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaRewindButton): Deal with the new elements. (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton): Ditto. (WebCore::RenderThemeMac::paintMediaControlsBackground): Ditto.
  • rendering/style/RenderStyleConstants.h: Add constants for the new elements.

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6518119>

Add localized strings for media controller status messages.

  • English.lproj/Localizable.strings: Localized text.

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6518119>

Add localized strings for media controller status.

  • WebCoreSupport/WebViewFactory.mm: Add new localized text. (-[WebViewFactory mediaElementLoadingStateText]): (-[WebViewFactory mediaElementLiveBroadcastStateText]):

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Update WebKitSystemInterface for <rdar://problem/6518119>

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
07:15 Changeset [45473] by hausmann@webkit.org

WebKitTools:

2009-07-02 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=26896

[Qt] Set DRT's default fontsize to 13.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage):

LayoutTests:

2009-07-02 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=26896

Updated computed-style-expected.txt and computed-style-without-renderer-expected.txt
files according to the default font size value (13) set in DumpRenderTree/qt/DumpRenderTree.cpp .

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
07:00 Changeset [45472] by hausmann@webkit.org

2009-07-02 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Improve documentation of QWebFrame::setFocus and hasFocus()
Added missing Q_PROPERTY for QWebFrame::hasFocus.

  • Api/qwebframe.cpp: Clarify the docs.
  • Api/qwebframe.h: add Q_PROPERTY(focus).
06:47 Changeset [45471] by hausmann@webkit.org

2009-07-02 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

Bug 26855: [Qt] New methods for QWebFrame to check and set focus.

Added new public methods QWebFrame::hasFocus() and QWebFrame::setFocus()
Added auto test.

  • Api/qwebframe.cpp: (QWebFrame::hasFocus): (QWebFrame::setFocus):
  • Api/qwebframe.h:
  • tests/qwebframe/tst_qwebframe.cpp:
04:50 Changeset [45470] by xan@webkit.org

2009-07-02 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

Update the new boolean property in FocusController that keeps
track of whether or not the Page is focused.

  • webkit/webkitwebview.cpp: (webkit_web_view_focus_in_event): (webkit_web_view_focus_out_event):
Note: See TracTimeline for information about the timeline view.