Timeline


and

07/09/09:

22:26 Changeset [45702] by bfulgham@webkit.org
  • 6 edits in trunk/WebCore

2009-07-09 Roland Steiner <rolandsteiner@google.com>

Reviewed by Maciej Stachowiak.

added InlineBox::isLeaf()
firstLeafChild()/lastLeafChild() not virtual and not callable on InlineBox anymore.
firstLeafChild()/lastLeafChild() will no longer return a node outside of the given subtree.
Removed firstLeafChildAfterBox()/lastLeafChildBeforeBox()
Removed potentially quadratic behavior if all nodes before/after a given box are empty InlineFlowBoxes

Currently, these methods are called on RootInlineBox objects only, so above changes should not have
any observable effect (only the removal of the square performance behavior could apply,
but the conditions for that are probably of a rather theoretical nature).

  • rendering/InlineBox.cpp: (WebCore::InlineBox::nextLeafChild): (WebCore::InlineBox::prevLeafChild):
  • rendering/InlineBox.h: (WebCore::InlineBox::isLeaf):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::firstLeafChild): (WebCore::InlineFlowBox::lastLeafChild):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::firstChild): (WebCore::InlineFlowBox::lastChild): (WebCore::InlineFlowBox::isLeaf):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::closestLeafChildForXPos):
22:12 Changeset [45701] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

2009-07-09 Roland Steiner <rolandsteiner@google.com>

Reviewed by Maciej Stachowiak.

Added InlineBox::baselinePosition() and lineHeight() methods
(adapted remaining code accordingly to use those methods)

No change in functionality.

  • rendering/InlineBox.h: (WebCore::InlineBox::baselinePosition): (WebCore::InlineBox::lineHeight):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::adjustMaxAscentAndDescent): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically):
22:10 Changeset [45700] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-07-09 Maciej Stachowiak <mjs@apple.com>

Not reviewed, build fix.

Windows build fix for the last change.

  • wtf/dtoa.cpp: Forgot to include Vector.h
22:01 Changeset [45699] by oliver@apple.com
  • 5 edits in trunk

Bug 27142 - canPlayType() should return empty string for unsupported content
<https://bugs.webkit.org/show_bug.cgi?id=27142>

Reviewed by Maciej Stachowiak

Return "" instead of "no" for unsupport media types.

21:42 Changeset [45698] by bfulgham@webkit.org
  • 8 edits
    3 adds in trunk

WebCore:

2009-07-09 Roland Steiner <rolandsteiner@google.com>

Reviewed by Maciej Stachowiak.

Implement the part of HTML5 spec that deals with parsing of <rp> and <rt> tags
in that their end tags are optional if followed by <rp>/<rt>.

Also specify a new accessibility role "annotation" for <rp> and <rt>.

Affected code parts are not enclosed in #IF ENABLE(RUBY), since the parsing
is not affected by whether ruby is rendered properly or not (in fact, it may
be more profound without ruby layouting, since the contents of <rp> are not hidden).

Test: fast/ruby/parse-rp.html

  • accessibility/AccessibilityObject.h: (WebCore::):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::roleValue):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::endTagRequirement): (WebCore::HTMLElement::tagPriority): (WebCore::inlineTagList):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::rpCreateErrorCheck): (WebCore::HTMLParser::rtCreateErrorCheck): (WebCore::HTMLParser::getNode):
  • html/HTMLParser.h:
  • html/HTMLTagNames.in:

LayoutTests:

2009-07-09 Roland Steiner <rolandsteiner@google.com>

Reviewed by Maciej Stachowiak.

Test proper parsing of HTML5 <rp> and <rt> tags.
Both tags are optional if followed by another <rp>/<rt> tag.


See also https://bugs.webkit.org/show_bug.cgi?id=26985

  • fast/ruby: Added.
  • fast/ruby/parse-rp-expected.txt: Added.
  • fast/ruby/parse-rp.html: Added.
21:29 Changeset [45697] by dimich@chromium.org
  • 5 edits in trunk/WebCore

2009-07-09 Dmitry Titov <dimich@chromium.org>

Not reviewed, fix for previous commit.

The change http://trac.webkit.org/changeset/45695 did not correctly
enabled GTL and QT build flags. This caused layout tests failure.
This is speculative fix for those failures.

  • GNUmakefile.am: added ENABLE_CHANNEL_MESSAGING flag.
  • WebCore.pro: ditto.
  • page/DOMWindow.idl: touched to cause recompile.
  • workers/WorkerContext.idl: ditto.
20:45 Changeset [45696] by mjs@apple.com
  • 3 edits
    7 adds in trunk

2009-07-09 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

REGRESSION: crash in edge cases of floating point parsing.
https://bugs.webkit.org/show_bug.cgi?id=27110
<rdar://problem/7044458>


Tests: fast/css/number-parsing-crash.html

fast/css/number-parsing-crash.html
fast/js/number-parsing-crash.html


  • wtf/dtoa.cpp: (WTF::BigInt::BigInt): Converted this to more a proper class, using a Vector with inline capacity

(WTF::lshift): Rearranged logic somewhat nontrivially to deal with the new way of sizing BigInts.
Added an assertion to verify that invariants are maintained.

All other functions are adapted fairly mechanically to the above changes.
(WTF::BigInt::clear):
(WTF::BigInt::size):
(WTF::BigInt::resize):
(WTF::BigInt::words):
(WTF::BigInt::append):
(WTF::multadd):
(WTF::s2b):
(WTF::i2b):
(WTF::mult):
(WTF::cmp):
(WTF::diff):
(WTF::b2d):
(WTF::d2b):
(WTF::ratio):
(WTF::strtod):
(WTF::quorem):
(WTF::dtoa):

2009-07-09 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.


REGRESSION: crash in edge cases of floating point parsing.
<rdar://problem/7044458>
https://bugs.webkit.org/show_bug.cgi?id=27110


Test cases for both JavaScript and CSS use of dtoa.

  • fast/css/number-parsing-crash-2-expected.txt: Added.
  • fast/css/number-parsing-crash-2.html: Added.
  • fast/css/number-parsing-crash-expected.txt: Added.
  • fast/css/number-parsing-crash.html: Added.
  • fast/js/number-parsing-crash-expected.txt: Added.
  • fast/js/number-parsing-crash.html: Added.
  • fast/js/resources/number-parsing-crash.js: Added.
20:20 Changeset [45695] by dimich@chromium.org
  • 22 edits
    16 moves in trunk

2009-07-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.

  • configure.ac: enable CHANNEL_MESSAGING.

JavaScriptCore:

2009-07-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.

  • Configurations/FeatureDefines.xcconfig:

WebCore:

2009-07-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
is now implemented for Web Workers and is reasonably stable.

Tests: fast/events/message-channel-gc-2.html

fast/events/message-channel-gc-3.html
fast/events/message-channel-gc-4.html
fast/events/message-channel-gc.html
fast/events/message-channel-listener-circular-ownership.html
fast/events/message-port-clone.html
fast/events/message-port-constructor-for-deleted-document.html
fast/events/message-port-deleted-document.html
fast/events/message-port-deleted-frame.html
fast/events/message-port-inactive-document.html
fast/events/message-port-no-wrapper.html
fast/events/message-port.html
fast/workers/worker-cloneport.html
fast/workers/worker-messageport-gc.html
fast/workers/worker-messageport.html

  • Configurations/FeatureDefines.xcconfig: Turned on ENABLE_CHANNEL_MESSAGING.
  • WebCore/WebCore.vcproj/WebCoreCommon.vsprops: ditto.
  • WebCore/WebCore.vcproj/build-generated-files.sh: ditto.
  • WebCore/page/DOMWindow.idl: touch the file to cause re-generation of headers.
  • WebCore/workers/WorkerContext.idl: ditto.

WebKit/mac:

2009-07-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.

  • Configurations/FeatureDefines.xcconfig:

WebKit/win:

2009-07-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.

  • WebKit.vcproj/WebKit.vcproj:

WebKitTools:

2009-07-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.

  • Scripts/build-webkit:

LayoutTests:

2009-07-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default, re-enabled the various tests, and updated expected results.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/constructors-cached-navigate-expected.txt:
  • fast/events/message-channel-gc-2.html: Renamed from LayoutTests/fast/events/message-channel-gc-2.html-disabled.
  • fast/events/message-channel-gc-3.html: Renamed from LayoutTests/fast/events/message-channel-gc-3.html-disabled.
  • fast/events/message-channel-gc-4.html: Renamed from LayoutTests/fast/events/message-channel-gc-4.html-disabled.
  • fast/events/message-channel-gc.html: Renamed from LayoutTests/fast/events/message-channel-gc.html-disabled.
  • fast/events/message-channel-listener-circular-ownership.html: Renamed from LayoutTests/fast/events/message-channel-listener-circular-ownership.html-disabled.
  • fast/events/message-port-clone.html: Renamed from LayoutTests/fast/events/message-port-clone.html-disabled.
  • fast/events/message-port-constructor-for-deleted-document.html: Renamed from LayoutTests/fast/events/message-port-constructor-for-deleted-document.html-disabled.
  • fast/events/message-port-deleted-document.html: Renamed from LayoutTests/fast/events/message-port-deleted-document.html-disabled.
  • fast/events/message-port-deleted-frame.html: Renamed from LayoutTests/fast/events/message-port-deleted-frame.html-disabled.
  • fast/events/message-port-inactive-document.html: Renamed from LayoutTests/fast/events/message-port-inactive-document.html-disabled.
  • fast/events/message-port-no-wrapper.html: Renamed from LayoutTests/fast/events/message-port-no-wrapper.html-disabled.
  • fast/events/message-port.html: Renamed from LayoutTests/fast/events/message-port.html-disabled.
  • fast/js/global-constructors-expected.txt:
  • fast/workers/worker-cloneport.html: Renamed from LayoutTests/fast/workers/worker-cloneport.html-disabled.
  • fast/workers/worker-messageport-gc.html: Renamed from LayoutTests/fast/workers/worker-messageport-gc.html-disabled.
  • fast/workers/worker-messageport.html: Renamed from LayoutTests/fast/workers/worker-messageport.html-disabled.
  • http/tests/security/MessagePort/event-listener-context.html: Renamed from LayoutTests/http/tests/security/MessagePort/event-listener-context.html-disabled
20:01 Changeset [45694] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

19:44 Changeset [45693] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 27016 - Interpreter crashes due to invalid array indexes
<https://bugs.webkit.org/show_bug.cgi?id=27016>

Reviewed by Darin Adler.

Unsigned vs signed conversions results in incorrect behaviour in
64bit interpreter builds.

19:15 Changeset [45692] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Jon Honeycutt <jhoneycutt@apple.com>

A more robust fix for <rdar://problem/6930280> Reproducible crash at
USA Today photo gallery

Reviewed by Steve Falkenburg.

  • plugins/win/PluginMessageThrottlerWin.cpp: (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired): Protect the PluginView from destruction before calling its window proc.
19:15 Changeset [45691] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Jon Honeycutt <jhoneycutt@apple.com>

<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)

Reviewed by Darin Adler.

  • plugins/PluginView.cpp: (WebCore::PluginView::bindingInstance): Protect the PluginView from destruction before calling NPN_GetValue. If the renderer for the PluginView was destroyed during the call, and the PluginView's ref count is now 1, return null.
19:15 Changeset [45690] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Jon Honeycutt <jhoneycutt@apple.com>

Speculative fix for <rdar://problem/6991251> WER #13: Crash in
WebKit!WebCore::PluginView::performRequest+203 (1311461169)

Reviewed by Darin Adler.

  • plugins/PluginView.cpp: (WebCore::PluginView::performRequest): Protect the PluginView from destruction before performing a load. Removed some trailing whitespace.
18:49 Changeset [45689] by bweinstein@apple.com
  • 2 edits in trunk/WebKit/win

2009-07-09 Brian Weinstein <bweinstein@apple.com>

Reviewed by Alice Liu.

Fix of <rdar://5712929> Add preferences key to remember if the Inspector was docked (14271)
https://bugs.webkit.org/show_bug.cgi?id=27140

Added a preference key to remember whether the user prefers the inspector detached or attached.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::showWindow): Pass both parameters into setWindowVisible (WebInspectorClient::closeWindow): Ditto (WebInspectorClient::attachWindow): Set preference to attached windows here (WebInspectorClient::detachWindow): Set preference to detached windows here (WebInspectorClient::showWindowWithoutNotifications): Read preference for attached vs. detached (WebInspectorClient::onClose): Pass both parameters into setWindowVisible
18:19 Changeset [45688] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-07-09 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson and Dan Bernstein.

<rdar://problem/7024972> Cannot set font to Helvetica Neue Light in Mail compose window

No regression test because this only affects the font panel.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _addToStyle:fontA:fontB:]): Fix code that detects whether the font would survive a round trip by using the weight corresponding to "bold" or "normal" rather than the actual weight number.
18:04 Changeset [45687] by pdherbemont@apple.com
  • 8 edits
    1 copy
    2 deletes in trunk

WebCore:

2009-07-09 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Full page zoom breaks remaining and elapsed time display in the <video> controller.
https://bugs.webkit.org/show_bug.cgi?id=27123

We are changing the size of the time remaining and time elapsed field, to
automatically hide them, when the controller is too short.

Because we toggle the size between 0 and the previous value of the
controller, we miss any width change that may occur during full page zoom,
and we fail to restore a correct width.

This change fixes that problem by using a cloned style on which we
set the width to 0, and restoring the previous style when going back to
the normal width.

We take care about properly using the cloned style or the pseudo style,
by overriding styleForElement().

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::styleForElement): (WebCore::MediaControlElement::attach): (WebCore::MediaControlElement::updateStyle): (WebCore::MediaControlInputElement::styleForElement): (WebCore::MediaControlInputElement::attach): (WebCore::MediaControlInputElement::updateStyle): (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement): (WebCore::MediaControlTimeDisplayElement::styleForElement): (WebCore::MediaControlTimeDisplayElement::setVisible):
  • rendering/MediaControlElements.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::shouldShowTimeDisplayControls): Make sure we take in account the zoom level when deciding if we should hide the ellapsed and remaining time.

LayoutTests:

2009-07-09 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Full page zoom breaks remaining and elapsed time display in the &lt;video&gt; controller.
https://bugs.webkit.org/show_bug.cgi?id=27123

  • media/video-zoom-controls.html: Remove duplicated code.
  • platform/mac-leopard/media/video-zoom-controls-expected.txt: Copied from LayoutTests/platform/mac/media/video-zoom-controls-expected.txt.
  • platform/mac-snowleopard/Skipped:
  • platform/mac/media/video-zoom-controls-expected.checksum: Removed. The test is not reliable for pixel test.
  • platform/mac/media/video-zoom-controls-expected.png: Removed.
  • platform/mac/media/video-zoom-controls-expected.txt: Updated
18:00 Changeset [45686] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/27114> bugzilla-tool: Parse short bug URL from commit log messages

Reviewed by Adam Roben.

  • Scripts/bugzilla-tool: (bug_id_from_commit_message): Check for the short bug URL before checking for the longer bugs.webkit.org URL.
17:55 Changeset [45685] by dimich@chromium.org
  • 3 edits in trunk/WebCore

2009-07-09 Michael Nordman <michaeln@google.com>

Reviewed by Darin Adler.

Fix chromium build bustage due to Widget being a RefCounted class.
https://bugs.webkit.org/show_bug.cgi?id=27139

  • platform/chromium/PopupMenuChromium.cpp:
  • platform/chromium/PopupMenuChromium.h:
17:41 Changeset [45684] by cfleizach@apple.com
  • 4 edits
    2 adds in trunk

Bug 27130 - Need to implement ARIA role="toolbar"
https://bugs.webkit.org/show_bug.cgi?id=27130

16:26 Changeset [45683] by dglazkov@chromium.org
  • 2 edits
    2 adds in trunk

JavaScriptCore:

2009-07-09 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Upstream JavaScriptCore.gypi, the project file for Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=27135

WebCore:

2009-07-09 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Upstream WebCore.gypi, the project file for Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=27135

  • WebCore.gypi: Added.
16:03 Changeset [45682] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Jon Honeycutt <jhoneycutt@apple.com>

Build fix.

  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
15:54 Changeset [45681] by ap@webkit.org
  • 7 edits in trunk/WebKit/win

Reviewed by Oliver Hunt.

<rdar://problem/6921671> Visit count shouldn't be incremented by redirects.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Do not increase visit count if there is a redirect source. As a result, only pages that were explicitly visited by the user (by typing a URL, choosing one from bookmarks, or clicking a link) will be counted.
  • Interfaces/IWebHistoryItemPrivate.idl:
  • WebHistory.cpp: (WebHistory::visitedURL):
  • WebHistory.h:
  • WebHistoryItem.cpp: (WebHistoryItem::visitedWithTitle):
  • WebHistoryItem.h: Marshal this new argument all the way down to WebCore.
15:33 Changeset [45680] by simon.fraser@apple.com
  • 4 edits in trunk/WebCore

2009-07-09 Simon Fraser <simon.fraser@apple.com>

Build fix for SnowLeopard.

Avoid using the contentsTransform methods if not on Leopard, because
we don't need to call them.

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::updateContentsTransform):
  • platform/graphics/mac/WebLayer.mm: (-[WebLayer setNeedsDisplayInRect:]):
  • platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer setNeedsDisplayInRect:]):
15:26 Changeset [45679] by bdakin@apple.com
  • 37 edits in trunk

WebCore:

2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix or make fixable:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::createPlugin): Changed to return PassRefPtr (WebCore::EmptyFrameLoaderClient::createJavaAppletWidget): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::loadPlugin): Make the widget variable a RefPtr. Use .get() when passing it to RenderPart::setWidget(). (WebCore::FrameLoader::createJavaAppletWidget): Make the widget variable a RefPtr.
  • loader/FrameLoader.h: Changed the return type of createJavaAppletWidget().
  • loader/FrameLoaderClient.h: Change the return types of createPlugin() and createJavaAppletWidget().
  • page/Frame.cpp: (WebCore::Frame::createView): No need to call .get() since setWidget() takes a RefPtr.
  • page/FrameView.cpp: (WebCore::FrameView::layoutIfNeededRecursive): children() now returns a HashSet of RefPtrs.
  • page/FrameView.h: Remove inheritance from RefCounted; we pick this up from ScrollView through Widget.
  • platform/ScrollView.cpp: (WebCore::ScrollView::addChild): addChild() now takes a PassRefPtr and m_children now keeps a HashSet of RefPtrs.
  • platform/ScrollView.h: ScrollView constructor is now protected. (WebCore::ScrollView::children): m_children is now a HashSet of RefPtrs.
  • platform/Scrollbar.h: Remove inheritance from RefCounted; we pick this up from ScrollView through Widget.
  • platform/Widget.h: Inherit from RefCounted. Cleaned up some whitespace. Make m_widget a RefPtr.
  • plugins/PluginView.cpp: (WebCore::PluginView::create): Adopt the PluginView when returning it.
  • plugins/PluginView.h: Changed create() to return a PassRefPtr.
  • rendering/RenderApplet.cpp: Receive result in a RefPtr when calling createJavaAppletWidget().
  • rendering/RenderPart.cpp: (WebCore::RenderPart::setWidget): setWidget() now takes a PassRefPtr. Also removed the manual ref of FrameViews. This is handled by having m_widget be a RefPtr. Removed deleteWidget().
  • rendering/RenderPart.h: Removed override of deleteWidget().
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): (WebCore::RenderWidget::setWidget): (WebCore::RenderWidget::paint): (WebCore::RenderWidget::setOverlapTestResult): (WebCore::RenderWidget::updateWidgetPosition): Use .get(). (WebCore::RenderWidget::clearWidget): Don't call deleteWidget(). It was removed.
  • rendering/RenderWidget.h: Removed deleteWidget(). Made m_widget a RefPtr. (WebCore::RenderWidget::widget): Use .get().

WebKit/gtk:

2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin): (WebKit::FrameLoaderClient::createJavaAppletWidget):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):

WebKit/qt:

2009-07-09 Beth Dakin <bdakin@apple.com>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin): (WebCore::FrameLoaderClientQt::createJavaAppletWidget):
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp: (WebFrame::createJavaAppletWidget):
  • WebFrame.h:

WebKit/wx:

2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::createPlugin): (WebCore::FrameLoaderClientWx::createJavaAppletWidget):
  • WebKitSupport/FrameLoaderClientWx.h:
15:17 Changeset [45678] by weinig@apple.com
  • 25 edits in trunk/WebKit

WebKit/mac:

2009-07-09 Sam Weinig <sam@webkit.org>

Reviewed by Steve Falkenburg.

Roll out r43848. The quirk is no longer necessary.

  • WebView/WebView.mm: (-[WebView WebCore::_userAgentForURL:WebCore::]):

WebKit/win:

2009-07-09 Sam Weinig <sam@webkit.org>

Reviewed by Steve Falkenburg.

Roll out r43848. The quirk is no longer necessary.

  • WebView.cpp: (WebView::userAgentForKURL):
15:11 Changeset [45677] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

Bug 27129 - AX: possible assertion for a non-native image in accessibility
https://bugs.webkit.org/show_bug.cgi?id=27129

14:57 Changeset [45676] by simon.fraser@apple.com
  • 8 edits in trunk/WebCore

2009-07-09 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

Improve the appearance of text in compositing layers when -[CALayer geometryFlipped]
is not available.
<rdar://problem/6120614>

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsOrientation): (WebCore::GraphicsLayer::contentsOrientation):
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer): Add a m_contentsOrientation member and getter/setter to control whether the contents of this layer have a transform applied to them before display.
  • platform/graphics/mac/GraphicsLayerCA.h: New method to return the default contents orientation.
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::flipTransform): Convenience method to return a transform with a Y flip.

(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setSize):
After the size changes we have to update the contentsTransform.

(WebCore::GraphicsLayerCA::setGeometryOrientation):
(WebCore::GraphicsLayerCA::geometryOrientation):
If -setGeometryFlipped: is not available, use a children transform.

(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
Tiled layers have issues with flipped contentsTransform, so just use
top-down drawing for them. Call updateContentsTransform() to set the
new contents transform after swapping layers.

(WebCore::GraphicsLayerCA::defaultContentsOrientation):
Use bottom-up when -geometryFlipped is not available, otherwise top-down.

(WebCore::GraphicsLayerCA::updateContentsTransform):
Set the layer contents transform based on contentsOrientation().

(WebCore::GraphicsLayerCA::setContentsLayer):
We have to manually flip contents layers if we're not using -geometryFlipped.

  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm: Do early return if layerContents is nil. Flip the CTM if the layer has bottom-up coordinates, so that CG sees a CTM with no flip. Do the CGContextRestoreGState() after drawing the debug indicator.

(-[WebLayer setNeedsDisplayInRect:]):

  • platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer setNeedsDisplayInRect:]): Need to map the dirty rect through the contentsTransform.
14:53 Changeset [45675] by ap@webkit.org
  • 10 edits in trunk

Reviewed by Geoff Garen.

<rdar://problem/6921671> Visit counter shouldn't be incremented by redirects.

Can't test this functionality with layout tests.

WebCore:

  • WebCore.base.exp:
  • history/HistoryItem.cpp: (WebCore::HistoryItem::recordVisitAtTime): (WebCore::HistoryItem::visited):
  • history/HistoryItem.h: Only increase visit count if explicitly told to. Now, some visits change last access time, but do not increase visit count.

WebKit:

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Do not increase visit count if there is a redirect source. As a result, only pages that were explicitly visited by the user (by typing a URL, choosing one from bookmarks, or clicking a link) will be counted.
  • History/WebHistory.mm: (-[WebHistoryPrivate visitedURL:withTitle:increaseVisitCount:]): (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
  • History/WebHistoryInternal.h:
  • History/WebHistoryItem.mm: (-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]):
  • History/WebHistoryItemInternal.h: Marshal this new argument all the way down to WebCore.
14:47 Changeset [45674] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7046098> MediaControllerThemeQT requires QuickTime 7.6.3

Require QuickTime 7.6.3 or higher to enable the new media controller UI.

  • rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):
13:57 Changeset [45673] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Sam Weinig <sam@webkit.org>

Reviewed by Beth Dakin.

Remove incorrect comment.

  • page/MouseEventWithHitTestResults.h:
13:49 Changeset [45672] by mrowe@apple.com
  • 1 edit in tags/Safari-6531.3/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Versioning.

13:42 Changeset [45671] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

13:40 Changeset [45670] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.3

New tag.

13:00 Changeset [45669] by ddkilzer@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-07-09 Joe Mason <joe.mason@torchmobile.com>

Reviewed by George Staikos.

Authors: Yong Li <yong.li@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>

https://bugs.webkit.org/show_bug.cgi?id=27031
Add an override for deleteOwnedPtr(HDC) on Windows

  • wtf/OwnPtrCommon.h:
  • wtf/OwnPtrWin.cpp: (WTF::deleteOwnedPtr):
12:20 Changeset [45668] by oliver@apple.com
  • 2 edits in trunk/WebKitSite

JavaScript section of http://webkit.org is excessively out of date.

Reviewed by Geoff Garen.

This removes old todo entries (like adding an API, which we've had since Leopard),
and adds an additional todo for a webkit-less Objective-C API.

12:11 Changeset [45667] by ddkilzer@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-07-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

Guard singal.h dependency with HAVE(SIGNAL_H) to enable building jsc
on SYMBIAN.

https://bugs.webkit.org/show_bug.cgi?id=27026

Based on Norbert Leser's work.

  • jsc.cpp: (printUsageStatement): (parseArguments):
  • wtf/Platform.h:
11:18 Changeset [45666] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2009-07-09 Mads Ager <ager@chromium.org>

Reviewed by Dimitri Glazkov.

Update the V8 bindings codegenerator to use the RGBColor::create
method to handle refcounts for RGBColor objects correctly.


  • bindings/scripts/CodeGeneratorV8.pm: Use RGBColor::create to create RGBColor objects.
10:41 Changeset [45665] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

Crash in RenderMedia::styleDidChange.
<rdar://problem/7044313> CrashTracer: quicklook crashed generating thumbnail for page with
media element (RenderMedia::styleDidChange + 115)

Speculative fix for crash in styleDidChange. Null check controller elements before tell
them to update style.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange):
10:37 Changeset [45664] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

2009-07-09 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Move V8DOMWrapper to its own file
https://bugs.webkit.org/show_bug.cgi?id=27121

  • bindings/v8/V8DOMWrapper.cpp: Added. (WebCore::GetToStringName): (WebCore::ConstructorToString): (WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object): (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::domObjectHasJSWrapper): (WebCore::V8DOMWrapper::setJSWrapperForDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForDOMNode): (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::setHiddenWindowReference): (WebCore::V8DOMWrapper::domWrapperType): (WebCore::V8DOMWrapper::convertToNativeObjectImpl): (WebCore::V8DOMWrapper::convertToSVGPODTypeImpl): (WebCore::V8DOMWrapper::lookupDOMWrapper): (WebCore::V8DOMWrapper::convertDOMWrapperToNodeHelper): (WebCore::V8DOMWrapper::wrapNativeNodeFilter): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::setDOMWrapper): (WebCore::V8DOMWrapper::maybeDOMWrapper): (WebCore::V8DOMWrapper::isDOMEventWrapper): (WebCore::V8DOMWrapper::isWrapperOfType): (WebCore::V8DOMWrapper::htmlElementType): (WebCore::V8DOMWrapper::svgElementType): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::convertDOMImplementationToV8Object): (WebCore::V8DOMWrapper::convertStyleSheetToV8Object): (WebCore::V8DOMWrapper::convertCSSValueToV8Object): (WebCore::V8DOMWrapper::convertCSSRuleToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object):
  • bindings/v8/V8DOMWrapper.h: Added. (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::wrapCPointer): (WebCore::V8DOMWrapper::extractCPointer): (WebCore::V8DOMWrapper::convertDOMWrapperToNode): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertToNativeObject): (WebCore::V8DOMWrapper::convertToNativeEvent): (WebCore::V8DOMWrapper::extractCPointerImpl): (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
10:20 Changeset [45663] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 David Hyatt <hyatt@apple.com>

Reviewed by Adele Peterson.

Crash in setFocusedFrame.
<rdar://7032869> Crashing in setFocusedFrame on blogger.com.

Speculative fix for crasher in setFocusedFrame. Make sure to ref both frames and fire
the events only after the local member has been updated.

  • page/FocusController.cpp: (WebCore::FocusController::setFocusedFrame):
10:05 Changeset [45662] by eric.carlson@apple.com
  • 8 edits
    8 adds in trunk

2009-07-09 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

Possible crashes when mouse clicks not dispatched because range input destroyed while
thumb is being dragged (e.g. scrub to end of movie)
<rdar://problem/7037494>
https://bugs.webkit.org/show_bug.cgi?id=27101

Some shadow nodes "capture" all mouse events from mouseDown to mouseUp so they continue to
get mouse events even when the mouse is moved outside of the node. This is done by putting
EventHandler into a mode where it sends all mouse events to the node regardless of the
actual mouse position. The mode is set on mouseDown and cleared on mouseUp but if the
node is deleted while in this mode, the mouseUp is never sent and EventHandler continues
to try to send events to the deleted node. This sometimes results in a crash, and sometimes
in a page that doesn't respond to click events.

Tests: fast/forms/search-delete-while-cancel-button-clicked.html

fast/forms/slider-delete-while-dragging-thumb.html
media/audio-delete-while-slider-thumb-clicked.html
media/audio-delete-while-step-button-clicked.html

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlSeekButtonElement::detach):

New, call setCapturingMouseEventsNode if capturing mouse events.

  • rendering/MediaControlElements.h:

Declare detach().

  • rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::detach):

New, call setCapturingMouseEventsNode if capturing mouse events.

  • rendering/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::detach):

New, call setCapturingMouseEventsNode if capturing mouse events.

  • rendering/TextControlInnerElements.h:

Declare detach().

2009-07-09 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

Possible crashes when mouse clicks not dispatched because range input destroyed while
thumb is being dragged (e.g. scrub to end of movie)
<rdar://problem/7037494>
https://bugs.webkit.org/show_bug.cgi?id=27101

Tests deleting a control while capturing mouse events.

  • fast/forms/search-delete-while-cancel-button-clicked-expected.txt: Added.
  • fast/forms/search-delete-while-cancel-button-clicked.html: Added.
  • fast/forms/slider-delete-while-dragging-thumb-expected.txt: Added.
  • fast/forms/slider-delete-while-dragging-thumb.html: Added.
  • media/audio-delete-while-slider-thumb-clicked-expected.txt: Added.
  • media/audio-delete-while-slider-thumb-clicked.html: Added.
  • media/audio-delete-while-step-button-clicked-expected.txt: Added.
  • media/audio-delete-while-step-button-clicked.html: Added.
  • platform/mac-snowleopard/Skipped:

Skip the new media controller tests until <rdar://problem/6502936> is fixed.

08:50 Changeset [45661] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-07-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Dimitri Glazkov.

Enter the Frame's context before creating new objects in setContextDebugId.

https://bugs.webkit.org/show_bug.cgi?id=27112

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setContextDebugId):
01:58 Changeset [45660] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-09 Simon Hausmann <hausmann@webkit.org>

Fix the Qt build.

  • WebCore.pro: Add new storage impl files to the build.
00:11 Changeset [45659] by abarth@webkit.org
  • 72 edits in trunk/WebCore

2009-07-08 Adam Barth <abarth@webkit.org>

Rubber stamped by Eric Seidel.

[V8] Move DOM wrapper functions in V8Proxy to V8DOMWrapper
https://bugs.webkit.org/show_bug.cgi?id=27107

This patch is just renaming. Code motion will occur next.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::createScriptObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent): (WebCore::V8AbstractEventListener::getReceiverObject):
  • bindings/v8/V8Collection.cpp: (WebCore::toOptionsCollectionSetter):
  • bindings/v8/V8Collection.h: (WebCore::getV8Object): (WebCore::getNamedPropertyOfCollection): (WebCore::nodeCollectionNamedPropertyGetter): (WebCore::getIndexedPropertyOfCollection): (WebCore::nodeCollectionIndexedPropertyGetter): (WebCore::nodeCollectionIndexedPropertyEnumerator): (WebCore::collectionIndexedPropertyEnumerator): (WebCore::collectionStringOrNullIndexedPropertyGetter):
  • bindings/v8/V8DOMMap.cpp: (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::removeObjectsFromWrapperMap):
  • bindings/v8/V8GCController.cpp: (WebCore::enumerateDOMObjectMap): (WebCore::DOMObjectVisitor::visitDOMWrapper): (WebCore::GCPrologueVisitor::visitDOMWrapper): (WebCore::GCEpilogueVisitor::visitDOMWrapper):
  • bindings/v8/V8Helpers.cpp: (WebCore::wrapNPObject):
  • bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object): (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::domObjectHasJSWrapper): (WebCore::V8DOMWrapper::setJSWrapperForDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForDOMNode): (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::getConstructor): (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8Proxy::retrieveWindow): (WebCore::V8Proxy::updateDocumentWrapperCache): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::installDOMWindow): (WebCore::setDOMExceptionHelper): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::setHiddenWindowReference): (WebCore::V8DOMWrapper::domWrapperType): (WebCore::V8DOMWrapper::convertToNativeObjectImpl): (WebCore::V8DOMWrapper::convertToSVGPODTypeImpl): (WebCore::V8DOMWrapper::lookupDOMWrapper): (WebCore::V8DOMWrapper::convertDOMWrapperToNodeHelper): (WebCore::V8DOMWrapper::wrapNativeNodeFilter): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::setDOMWrapper): (WebCore::V8DOMWrapper::maybeDOMWrapper): (WebCore::V8DOMWrapper::isDOMEventWrapper): (WebCore::V8DOMWrapper::isWrapperOfType): (WebCore::V8DOMWrapper::htmlElementType): (WebCore::V8DOMWrapper::svgElementType): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::convertDOMImplementationToV8Object): (WebCore::V8DOMWrapper::convertStyleSheetToV8Object): (WebCore::V8DOMWrapper::convertCSSValueToV8Object): (WebCore::V8DOMWrapper::convertCSSRuleToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object): (WebCore::V8Proxy::bindJsObjectToWindow):
  • bindings/v8/V8Proxy.h: (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::wrapCPointer): (WebCore::V8DOMWrapper::extractCPointer): (WebCore::V8DOMWrapper::convertDOMWrapperToNode): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertToNativeObject): (WebCore::V8DOMWrapper::convertToNativeEvent): (WebCore::V8DOMWrapper::extractCPointerImpl): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8Proxy::constructDOMObject): (WebCore::toV8):
  • bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::V8SVGPODTypeUtil::toSVGPODType):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::retrieve): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::GetConstructor): (WebCore::WorkerContextExecutionProxy::ToV8Object): (WebCore::WorkerContextExecutionProxy::EventToV8Object): (WebCore::WorkerContextExecutionProxy::toV8):
  • bindings/v8/custom/V8AttrCustom.cpp: (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_SETTER):
  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toV8): (WebCore::toCanvasStyle): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ClientRectListCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER):
  • bindings/v8/custom/V8ClipboardCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8CustomBinding.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::INDEXED_ACCESS_CHECK): (WebCore::NAMED_ACCESS_CHECK): (WebCore::V8Custom::GetTargetFrame):
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp: (WebCore::V8CustomSQLStatementCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: (WebCore::V8CustomSQLTransactionCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::V8Custom::ClearTimeoutImpl): (WebCore::NAMED_ACCESS_CHECK): (WebCore::INDEXED_ACCESS_CHECK):
  • bindings/v8/custom/V8DatabaseCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp: (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLInputElementCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_SETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::removeElement):
  • bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_ACCESS_CHECK): (WebCore::NAMED_ACCESS_CHECK):
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8NavigatorCustom.cpp: (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SQLTransactionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SVGElementInstanceCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SVGLengthCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8StorageCustom.cpp: (WebCore::V8Custom::v8StorageNamedPropertyEnumerator): (WebCore::storageGetter): (WebCore::storageSetter): (WebCore::storageDeleter):
  • bindings/v8/custom/V8StyleSheetListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::SetTimeoutOrInterval): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

07/08/09:

21:12 Changeset [45658] by pdherbemont@apple.com
  • 6 edits in trunk

WebCore:

2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Make sure we can click outside the slider thumb and start dragging.
https://bugs.webkit.org/show_bug.cgi?id=26229

Previously we were assuming that if the thumb hasn't been clicked, we
wouldn't issue any value change upon dragging.

We need to handle the two different cases:

  • Clicked in the thumb, we need to make sure the cursor is always pointing the same slider thumb point.
  • Clicked outside, the cursor should always be pointing to the center of the thumb.

For simplicity, we don't remember the original point of the mouse down,
but an offset between that point and the thumb.

  • rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::SliderThumbElement): (WebCore::SliderThumbElement::defaultEventHandler): (WebCore::RenderSlider::mouseEventOffsetToThumb): Utility function.
  • rendering/RenderSlider.h:

LayoutTests:

2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Make sure we can click outside the slider thumb and start dragging.
https://bugs.webkit.org/show_bug.cgi?id=26229

Along with the events chain, test that the slider value are correct,
and that clicking outside the slider and dragging works as expected.

  • fast/forms/slider-mouse-events-expected.txt:
  • fast/forms/slider-mouse-events.html:
21:09 Changeset [45657] by mitz@apple.com
  • 3 edits in trunk/JavaScriptGlue

2009-07-08 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein

  • fix <rdar://problem/6971484> REGRESSION (r30534): "Scrolling Credits" effect does not scroll on iMovie 7.1.4 on Tiger

In <http://trac.webkit.org/changeset/30534>, the prototype of
JSObject::put() which UserObjectImp had been overriding changed, but
UserObjectImp wasn't updated, so its override was no longer getting
called after that.

  • UserObjectImp.cpp: (UserObjectImp::put): Match the current prototype of JSObject::put(). The PutPropertySlot argument is unused.
  • UserObjectImp.h: Ditto.
18:29 Changeset [45656] by sfalken@apple.com
  • 1 edit in trunk/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Versioning.

18:25 Changeset [45655] by pdherbemont@apple.com
  • 9 edits
    1 copy in trunk

WebCore:

2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=27100
<rdar://problem/7042621>

Don't display "loading" in the <video> controller when
there is no src specified.

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlStatusDisplayElement::update): The only way to find out if we have an element is currentSrc(). networkState() will always report LOADING according to the spec.

LayoutTests:

2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=27100

Reenable media/video-empty-source.html. Test the controls
look when there is no src specified in a <video> element.

  • platform/mac-leopard/media/video-empty-source-expected.checksum:
  • platform/mac-leopard/media/video-empty-source-expected.png:
  • platform/mac-leopard/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/mac/media/video-empty-source-expected.txt.
  • platform/mac-snowleopard/Skipped:
  • platform/mac/media/video-empty-source-expected.checksum:
  • platform/mac/media/video-empty-source-expected.png:
  • platform/mac/media/video-empty-source-expected.txt:
18:25 Changeset [45654] by ddkilzer@apple.com
  • 4 edits in trunk/WebKitTools

Bug 27062: bugzilla-tool: post-commits should read bug id from commit log and actually work

<https://bugs.webkit.org/show_bug.cgi?id=27062>

Reviewed by Eric Seidel.

Removed the required BUGID argument from the "post-commits"

command and replaced it with a -bbug-id switch or parsing the

commit log message for the bug URL. Fixed a bug in the
"post-commits" that would ignore the COMMITISH used and post a
patch of local changes against HEAD. Added --no-commit switch
to disable using the bulk of the ChangeLog entry as the comment
for the new patch.

  • Scripts/bugzilla-tool: (bug_id_from_commit_message): Added. Returns a bug id from the commit log message, thus enforcing the need for a bug URL in the message. (PostCommitsAsPatchesToBug.init): Updated help description to match new behavior of pulling bug ids from commit log
messages instead of from the command line. Added -bbug-id

switch and --no-comment switch.
(PostCommitsAsPatchesToBug.execute): Updated to use
bug_id_from_commit_message() to pull bug ids from commit log
messages. Also switched from SCM.create_patch() to use
SCM.create_patch_from_local_commit() to fix a bug where local
repository changes were posted as a patch instead of the

specific COMMITISH. Fall back to -bbug-id if no URL is found

in the commit log message. Don't specify a comment for the
patch if --no-comment is used. Set cherry_pick argument to True
for Git.commit_ids_from_range_arguments() since we don't want
implicit commit range behavior for this command.

  • Scripts/modules/bugzilla.py: Import datetime module. (timestamp): Added. Returns a timestamp in the form of "YYYYMMDDhhmmss". (Bugzilla.bug_server_regex): Added static attribute. (Bugzilla.add_patch_to_bug): Construct a more meaningful patch file name using the bug_id and timestamp().
  • Scripts/modules/scm.py: (SCM.create_patch_from_local_commit): Added. (Git.create_patch_from_local_commit): Added. Runs "git diff" to return a patch for the given commit_id.
18:15 Changeset [45653] by pdherbemont@apple.com
  • 3 edits in trunk/LayoutTests

2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>

Rubber-stamped by Simon Fraser.

Fix the media/controls-after-reload.html and media/controls-styling.html
on windows. (Needed a line at end of file)

  • platform/win/media/controls-after-reload-expected.txt:
  • platform/win/media/controls-styling-expected.txt:
17:15 Changeset [45652] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

2009-07-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[V8] Move V8GCController functions to their own file
https://bugs.webkit.org/show_bug.cgi?id=27102

  • bindings/v8/V8GCController.cpp: Added.
  • bindings/v8/V8GCController.h: Added.
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
16:55 Changeset [45651] by darin@chromium.org
  • 10 edits
    4 copies in trunk/WebCore

2009-07-08 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Split StorageArea and StorageNamespace into an interface and implementation.
https://bugs.webkit.org/show_bug.cgi?id=27072

I need to split StorageNamespace and StorageArea into an interface and
implementation. In a later patch, I'll implement a proxy interface
that'll run inside the Chromium renderer process.

Additionally, fix the alphabetical ordering of files I recently added
in the project files.

This is a continuation of other refactoring work:
https://bugs.webkit.org/show_bug.cgi?id=25376

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • storage/StorageArea.cpp: (WebCore::StorageArea::create):
  • storage/StorageArea.h: (WebCore::StorageArea::~StorageArea):
  • storage/StorageAreaImpl.cpp: Copied from WebCore/storage/StorageArea.cpp. (WebCore::StorageAreaImpl::create): (WebCore::StorageAreaImpl::~StorageAreaImpl): (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::copy): (WebCore::StorageAreaImpl::length): (WebCore::StorageAreaImpl::key): (WebCore::StorageAreaImpl::getItem): (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::removeItem): (WebCore::StorageAreaImpl::clear): (WebCore::StorageAreaImpl::contains): (WebCore::StorageAreaImpl::importItem): (WebCore::StorageAreaImpl::securityOrigin): (WebCore::StorageAreaImpl::close): (WebCore::StorageAreaImpl::blockUntilImportComplete): (WebCore::StorageAreaImpl::dispatchStorageEvent):
  • storage/StorageAreaImpl.h: Copied from WebCore/storage/StorageArea.h.
  • storage/StorageAreaSync.h:
  • storage/StorageNamespace.cpp: (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace):
  • storage/StorageNamespace.h: (WebCore::StorageNamespace::~StorageNamespace):
  • storage/StorageNamespaceImpl.cpp: Copied from WebCore/storage/StorageNamespace.cpp. (WebCore::StorageNamespaceImpl::localStorageNamespace): (WebCore::StorageNamespaceImpl::sessionStorageNamespace): (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::~StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea): (WebCore::StorageNamespaceImpl::close):
  • storage/StorageNamespaceImpl.h: Copied from WebCore/storage/StorageNamespace.h.
16:26 Changeset [45650] by barraclough@apple.com
  • 108 edits
    35 copies
    1 delete in branches/nitro-extreme

Merged r45600:45633 into nitro-extreme branch.

16:06 Changeset [45649] by abarth@webkit.org
  • 1 edit in trunk/WebCore/bindings/v8/V8Proxy.cpp

Unreviewed fix for Chromium link errors.

15:59 Changeset [45648] by abarth@webkit.org
  • 1 edit in trunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-head-base-href.pl

Unreviewed change: Mark echo-head-base-href.pl executable to try to make tree green.

15:58 Changeset [45647] by mjs@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-08 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

Make prepare-ChangeLog less shouty
https://bugs.webkit.org/show_bug.cgi?id=27098

  • Scripts/prepare-ChangeLog:
15:48 Changeset [45646] by abarth@webkit.org
  • 12 edits in trunk/WebCore

2009-07-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[V8] Move garbage collector related functions from V8Proxy to V8GCController
https://bugs.webkit.org/show_bug.cgi?id=26967

This patch just moves the functions around in V8Proxy. We'll actually
move them to a separate file in another patch.

  • bindings/v8/NPV8Object.cpp: (freeV8NPObject):
  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::~ScheduledAction):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::gcProtectJSWrapper): (WebCore::ScriptController::gcUnprotectJSWrapper):
  • bindings/v8/ScriptInstance.cpp: (WebCore::V8ScriptInstance::clear): (WebCore::V8ScriptInstance::set):
  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::operator=): (WebCore::ScriptValue::clear):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::disposeListenerObject):
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::~V8LazyEventListener): (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListener::getWrappedListenerFunction):
  • bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::V8NodeFilterCondition): (WebCore::V8NodeFilterCondition::~V8NodeFilterCondition):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8GCController::registerGlobalHandle): (WebCore::V8GCController::unregisterGlobalHandle): (WebCore::V8GCController::gcProtect): (WebCore::V8GCController::gcUnprotect): (WebCore::V8Proxy::destroyGlobal): (WebCore::V8Proxy::updateDocumentWrapper): (WebCore::V8Proxy::clearDocumentWrapper): (WebCore::V8Proxy::disposeContextHandles): (WebCore::V8Proxy::initContextIfNeeded):
  • bindings/v8/V8Proxy.h: (WebCore::): (WebCore::GlobalHandleInfo::GlobalHandleInfo):
  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener):
15:42 Changeset [45645] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-08 Simon Hausmann <hausmann@webkit.org>

Rubber-stamped by Holger Freyther a while ago.

Add two more tests to the Qt skip list due to missing DRT
features.

  • platform/qt/Skipped:
15:36 Changeset [45644] by darin@chromium.org
  • 11 edits
    4 deletes in trunk/WebCore

Reverting r45643 due to build bustage.

15:27 Changeset [45643] by darin@chromium.org
  • 11 edits
    4 copies in trunk/WebCore

2009-07-08 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Split StorageArea and StorageNamespace into an interface and implementation.
https://bugs.webkit.org/show_bug.cgi?id=27072

I need to split StorageNamespace and StorageArea into an interface and
implementation. In a later patch, I'll implement a proxy interface
that'll run inside the Chromium renderer process.

Additionally, fix the alphabetical ordering of files I recently added
in the project files.

This is a continuation of other refactoring work:
https://bugs.webkit.org/show_bug.cgi?id=25376

  • WebCore.xcodeproj/project.pbxproj:
  • storage/StorageArea.cpp: (WebCore::StorageArea::create): (WebCore::StorageArea::~StorageArea):
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp: Copied from WebCore/storage/StorageArea.cpp. (WebCore::StorageAreaImpl::create): (WebCore::StorageAreaImpl::~StorageAreaImpl): (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::copy): (WebCore::StorageAreaImpl::length): (WebCore::StorageAreaImpl::key): (WebCore::StorageAreaImpl::getItem): (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::removeItem): (WebCore::StorageAreaImpl::clear): (WebCore::StorageAreaImpl::contains): (WebCore::StorageAreaImpl::importItem): (WebCore::StorageAreaImpl::securityOrigin): (WebCore::StorageAreaImpl::close): (WebCore::StorageAreaImpl::blockUntilImportComplete): (WebCore::StorageAreaImpl::dispatchStorageEvent):
  • storage/StorageAreaImpl.h: Copied from WebCore/storage/StorageArea.h.
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::create): (WebCore::StorageAreaSync::StorageAreaSync):
  • storage/StorageAreaSync.h:
  • storage/StorageNamespace.cpp: (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace): (WebCore::StorageNamespace::~StorageNamespace):
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp: Copied from WebCore/storage/StorageNamespace.cpp. (WebCore::StorageNamespaceImpl::localStorageNamespace): (WebCore::StorageNamespaceImpl::sessionStorageNamespace): (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::~StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea): (WebCore::StorageNamespaceImpl::close):
  • storage/StorageNamespaceImpl.h: Copied from WebCore/storage/StorageNamespace.h.
15:13 Changeset [45642] by abarth@webkit.org
  • 6 edits
    18 adds in trunk

2009-07-08 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.


https://bugs.webkit.org/show_bug.cgi?id=26918


Prevents injection of HTML Base tag.

Tests: http/tests/security/xssAuditor/base-href-control-char.html

http/tests/security/xssAuditor/base-href-null-char.html
http/tests/security/xssAuditor/base-href-safe.html
http/tests/security/xssAuditor/base-href-safe2.html
http/tests/security/xssAuditor/base-href-scheme-relative.html
http/tests/security/xssAuditor/base-href.html

  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::parseMappedAttribute): (WebCore::HTMLBaseElement::process): Modified to call XSSAuditor::canSetBaseElementURL to determine if it is safe to use base element URL.
  • html/HTMLBaseElement.h: Added field m_hrefAttrValue to store unparsed base element URL.
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canSetBaseElementURL):
  • page/XSSAuditor.h:

2009-07-08 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.


https://bugs.webkit.org/show_bug.cgi?id=26918


Tests prevention of injected HTML Base tag.

  • http/tests/security/xssAuditor/base-href-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-control-char.html: Added.
  • http/tests/security/xssAuditor/base-href-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-null-char.html: Added.
  • http/tests/security/xssAuditor/base-href-safe-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-safe.html: Added.
  • http/tests/security/xssAuditor/base-href-safe2-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-safe2.html: Added.
  • http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-scheme-relative.html: Added.
  • http/tests/security/xssAuditor/base-href.html: Added.
  • http/tests/security/xssAuditor/resources/base-href: Added.
  • http/tests/security/xssAuditor/resources/base-href/base-href-safe2.html: Added.
  • http/tests/security/xssAuditor/resources/base-href/really-safe-script.js: Added.
  • http/tests/security/xssAuditor/resources/base-href/safe-script.js: Added.
  • http/tests/security/xssAuditor/resources/echo-head-base-href.pl: Added.
  • http/tests/security/xssAuditor/resources/safe-script.js: Added.
14:51 Changeset [45641] by japhet@chromium.org
  • 1 edit
    4 adds in trunk/WebCore

2009-07-08 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream V8 npruntime bindings.

https://bugs.webkit.org/show_bug.cgi?id=27094

14:35 Changeset [45640] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-08 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Darin Fisher.

Extending the PlatformFileHandle definition from PLATFORM(WIN) to
PLATFORM(WIN_OS)

https://bugs.webkit.org/show_bug.cgi?id=27013

  • platform/FileSystem.h:
14:27 Changeset [45639] by abarth@webkit.org
  • 4 edits
    28 adds in trunk

2009-07-08 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.


https://bugs.webkit.org/show_bug.cgi?id=27071


Resolves issue when HTTP parameters contain null- and non-null-control- characters.

Tests: http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char.html

http/tests/security/xssAuditor/embed-tag-control-char.html
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/embed-tag.html
http/tests/security/xssAuditor/link-onclick-control-char.html
http/tests/security/xssAuditor/link-onclick-null-char.html
http/tests/security/xssAuditor/object-embed-tag-control-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag.html
http/tests/security/xssAuditor/object-tag.html
http/tests/security/xssAuditor/script-tag-post-control-char.html
http/tests/security/xssAuditor/script-tag-post-null-char.html
http/tests/security/xssAuditor/script-tag-with-source-control-char.html
http/tests/security/xssAuditor/script-tag-with-source-null-char.html

  • page/XSSAuditor.cpp: (WebCore::isNonNullControlCharacter): Called by XSSAuditor::decodeURL. (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::decodeURL): Added parameters matchNullCharacters, and matchNonNullControlCharacters. (WebCore::XSSAuditor::findInRequest): Added parameters matchNullCharacters, and matchNonNullControlCharacters.
  • page/XSSAuditor.h:

2009-07-08 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27071

Tests that HTTP parameters that contain null- and non-null-control characters are
properly handled by XSSAuditor.


  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char.html: Added.
  • http/tests/security/xssAuditor/embed-tag-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/embed-tag-control-char.html: Added.
  • http/tests/security/xssAuditor/embed-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/embed-tag-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/embed-tag-null-char.html: Added.
  • http/tests/security/xssAuditor/embed-tag.html: Added.
  • http/tests/security/xssAuditor/link-onclick-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/link-onclick-control-char.html: Added.
  • http/tests/security/xssAuditor/link-onclick-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/link-onclick-null-char.html: Added.
  • http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/object-embed-tag-control-char.html: Added.
  • http/tests/security/xssAuditor/object-embed-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/object-embed-tag-null-char.html: Added.
  • http/tests/security/xssAuditor/object-embed-tag.html: Added.
  • http/tests/security/xssAuditor/object-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/object-tag.html: Added.
  • http/tests/security/xssAuditor/resources/execGetURL.swf: Added.
  • http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-post-control-char.html: Added.
  • http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-post-null-char.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-control-char.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-null-char.html: Added.
14:22 Changeset [45638] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 27083: bugzilla.py: Clean up bug_server use

<https://bugs.webkit.org/show_bug.cgi?id=27083>

Reviewed by Darin Adler.

  • Scripts/modules/bugzilla.py: (Bugzilla.fetch_bug_ids_from_commit_queue): Use bug_server instead of hard-coding the URL. (Bugzilla.authenticate): Remove extra '/' before URL path. (Bugzilla.add_patch_to_bug): Ditto.
14:19 Changeset [45637] by dglazkov@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2009-07-08 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Dimitri Glazkov.

Add DerivesSourcesAllInOne.cpp to help with release windows compilation.
https://bugs.webkit.org/show_bug.cgi?id=27093

This is specific for v8, no change in behavior.

  • bindings/v8/DerivedSourcesAllInOne.cpp: Added.
14:14 Changeset [45636] by pdherbemont@apple.com
  • 3 edits in trunk/WebCore

2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by NOBODY (OOPS!).

https://bugs.webkit.org/show_bug.cgi?id=27086

Make sure the Media controller doesn't fade in for no reason.
This is happening because a update() call to the controller
panel may reset the opacity to 1.0, given that it reloads the
style.

We also add a different fade in and fade out time to soften
the fade out effect.

No test case because this depends on how the movie is loaded.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): (WebCore::RenderMedia::updateControls): (WebCore::RenderMedia::updateControlVisibility): Simplify , and make sure we stop the timer if there is no animation to do. (WebCore::RenderMedia::opacityAnimationTimerFired):
  • rendering/RenderMedia.h:
14:05 Changeset [45635] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Bug 27081: Wrap RunLoopTimerCF.cpp in PLATFORM(MAC) && HAVE(RUNLOOP_TIMER)

<https://bugs.webkit.org/show_bug.cgi?id=27081>

Reviewed by Timothy Hatcher.

  • platform/cf/RunLoopTimerCF.cpp: This code is only used on Mac OS X when HAVE(RUNLOOP_TIMER) is enabled, so wrap the code in that macro as well.
13:56 Changeset [45634] by bolsinga@apple.com
  • 8 edits in trunk

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:
13:34 Changeset [45633] by ap@webkit.org
  • 6 edits in trunk/WebCore

Reviewed (an earlier version) by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=27090
Remove lockBackForwardList argument from HTMLFormElement::submit()

No change in behavior, so no tests.

  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::submit):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
  • html/HTMLFormElement.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::scheduleFormSubmission):
  • loader/FrameLoader.h: Don't pass lockBackForwardList around when it's known to be false.
13:32 Changeset [45632] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-08 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Adam Barth.

Fix V8 idl codegen to use unique constant names
<https://bugs.webkit.org/show_bug.cgi?id=27089>

Embed the interface name in the global constant names so coagulating all
the .cc files into one compile unit works with V8 bindings.

Nothing added; Still compiles and pass tests.

  • bindings/scripts/CodeGeneratorV8.pm:
11:56 Changeset [45631] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-08 Brent Fulgham <bfulgham@webkit.org>

Build fix for Windows Cairo.

Cairo build was incorrectly #including the PixelDumpSupportCG.h
instead of PixelDumpSupportCairo.h

  • DumpRenderTree/win/PixelDumpSupportWin.cpp: Correct #include
11:01 Changeset [45630] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

2009-07-08 Brent Fulgham <bfulgham@webkit.org>

Build fix: Add missing #includes for Windows (cURL) build.
The <winsock2.h> and <windows.h> headers were not being
included in Windows cURL builds.

  • platform/network/ResourceHandleInternal.h:
  • platform/network/curl/ResourceHandleManager.h:
10:50 Changeset [45629] by pdherbemont@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Add special test results for media/controls-after-reload.html
and media/controls-styling.html on Windows.

  • platform/win/media/controls-after-reload-expected.txt: Added.
  • platform/win/media/controls-styling-expected.txt: Added.
10:20 Changeset [45628] by pdherbemont@apple.com
  • 2 edits in trunk/LayoutTests

2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>

Fix the Leopard test result for media/controls-after-reload.txt.

  • platform/mac-leopard/media/controls-after-reload-expected.txt:
09:42 Changeset [45627] by ariya@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-08 David Faure <faure@kde.org>

Reviewed by Ariya Hidayat.

Small documentation improvement for build-webkit --help

  • Scripts/build-webkit: mention --debug option
09:38 Changeset [45626] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-08 Pradeepto Bhattacharya <pradeepto@kde.org>

Reviewed by Ariya Hidayat.

Build fix.

  • WebCoreSupport/FrameLoaderClientQt.h: Removed the slot slotCallPolicyFunction().
07:44 Changeset [45625] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-07-08 Simon Hausmann <hausmann@webkit.org>

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=27080

Fix DRT instability issues with fast/loader/submit-form-while-parsing-2.html

When the form is submitted we call the policy function in the frame
loader delayed with a queued connection. That queued connection
sometimes interferes with the javascript timeout set in the testcase.

Eliminate the entire delayed policy function mechanism and instead always
call back directly, like in the other ports. In most other places we called
the slot directly anyway.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Remove m_policyFunction. (WebCore::FrameLoaderClientQt::callPolicyFunction): Call the policy function directly instead of emitting the queued signal. (WebCore::FrameLoaderClientQt::cancelPolicyCheck): Call callPolicyFunction directly. (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm): Ditto. (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType): Ditto. (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): Ditto. (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): Ditto.
  • WebCoreSupport/FrameLoaderClientQt.h: Remove m_policyFunction as well as the associated signal.
07:24 BuildingQtOnLinux edited by faure@kde.org
mention --debug argument for build-webkit, rather useful for developers (diff)
06:55 Changeset [45624] by ddkilzer@apple.com
  • 30 edits in trunk/WebCore

2009-07-08 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Kilzer.

WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Fix bunch of style issues in WebCore/rendering.
This patch is created to demonstrate cpplint.py.

No testcase because it's just a style fixes.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::layout):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeEllipsisBox):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintTextMatchMarker):
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler):
  • rendering/MediaControlElements.h:
  • rendering/RenderArena.cpp:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::startDelayUpdateScrollInfo): (WebCore::RenderBlock::finishDelayUpdateScrollInfo): (WebCore::RenderBlock::updateScrollInfoAfterLayout): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::newLine): (WebCore::RenderBlock::floatBottom): (WebCore::RenderBlock::leftBottom): (WebCore::RenderBlock::rightBottom):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedWidthUsing):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::layoutLegend):
  • rendering/RenderFlexibleBox.cpp: (WebCore::FlexBoxIterator::FlexBoxIterator): (WebCore::FlexBoxIterator::reset): (WebCore::FlexBoxIterator::first): (WebCore::FlexBoxIterator::next): (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderFrameSet.cpp: (WebCore::borderStartEdgeColor):
  • rendering/RenderFrameSet.h:
  • rendering/RenderImage.cpp:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::panScroll):
  • rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::updateMarqueeStyle):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawLineForBoxSide): (WebCore::RenderObject::localCaretRect):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
  • rendering/RenderSlider.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::outerBorderBottom):
  • rendering/RenderTableCol.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::itemIsSeparator):
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::supportsHover):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::supportsFocusRing):
  • rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGCharacterLayoutInfo::addStackContent):
  • rendering/SVGCharacterLayoutInfo.h:
  • rendering/TextControlInnerElements.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine):
06:33 Changeset [45623] by vestbo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Rubber-stamped by Simon Hausmann.

Remove non-existing tests from the Qt skipped list.

  • platform/qt/Skipped:
06:33 Changeset [45622] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Rubber-stamped by Simon Hausmann.

Correct git url of the Qt test-fonts.

  • DumpRenderTree/qt/main.cpp: (main):

07/07/09:

23:46 Changeset [45621] by ggaren@apple.com
  • 2190 edits
    69 copies
    214 adds
    411 deletes in branches/nitro-extreme

Merged r45243:45600 into nitro-extreme branch.

22:38 Changeset [45620] by oliver@apple.com
  • 5 edits in trunk/WebCore

Reduce complexity of lifetime management in DynamicNodeList caches
<https://bugs.webkit.org/show_bug.cgi?id=27068>

Reviewed by Maciej Stachowiak

Switch the Cache object used by DynamicNodeList into a normal
refcounted object rather than having a weird flag controlled
refcounting system, where positive refcount did not automatically
imply the cache object would actually still be live.

22:33 Changeset [45619] by mitz@apple.com
  • 25 edits in trunk/LayoutTests/platform

Set the svn:mime-type property of recently-added PNG files to image/png.

22:26 Changeset [45618] by simon.fraser@apple.com
  • 4 edits
    8 adds in trunk

2009-07-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

-webkit-perspective should be a Length
https://bugs.webkit.org/show_bug.cgi?id=27066

-webkit-perspective should not take a magic valueless number, but should
be a normal Length value which responds to zooming. Treat valueless numbers
as pixels for backward compatibility.

Test: transforms/3d/general/perspective-units.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
19:26 Changeset [45617] by adachan@apple.com
  • 2 edits in trunk/WebKit/win

Reviewed by Dave Hyatt.

Missed a call to FocusController::setFocused(true) when handling WM_SETFOCUS in WebView.
https://bugs.webkit.org/show_bug.cgi?id=27057

  • WebView.cpp: (WebViewWndProc):
18:55 Changeset [45616] by beidson@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-07 Brady Eidson <beidson@apple.com>

Tiger build fix, work around missing NSString API.

  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpHistoryItem):
18:41 Changeset [45615] by beidson@apple.com
  • 5 edits in trunk

WebKitTools:

2009-07-07 Brady Eidson <beidson@apple.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27049 - In dumpBackForwardList() mode, DRT should normalize file urls.

Make the dump of a history item agnostic to the layout of filesystem on the testing machine.

  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpHistoryItem):
  • DumpRenderTree/win/DumpRenderTree.cpp: (dumpHistoryItem):

LayoutTests:

2009-07-07 Brady Eidson <beidson@apple.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27049 - In dumpBackForwardList() mode, DRT should normalize file urls.

  • fast/loader/subframe-navigate-during-main-frame-load-expected.txt: Make the results agnostic to the layout of filesystem on the testing machine.
18:19 Changeset [45614] by pdherbemont@apple.com
  • 5 edits
    3 adds in trunk

WebCore:

2009-07-07 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=27047

We need to make sure that when we reattach, we also reattach
the children in every MediaControlElement. Else we may end up
having no remaining or elapsed time.

We have to handle that, because we are using a special shadow
tree in the DOM, and that we are ourselves handling
attaching/detaching the renderer.

The strategy here is to try to implement ::attach(), and try
to reuse as much code as we can from the super class, including
children attachement.

Test: media/controls-after-reload.html

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::styleForElement): Code factoring. (WebCore::MediaControlElement::rendererIsNeeded): Code factoring. (WebCore::MediaControlElement::attach): Implement attach and call super class so that children are also attached. (WebCore::MediaControlElement::updateStyle): Use attach() (WebCore::MediaControlInputElement::styleForElement): Code factoring. (WebCore::MediaControlInputElement::rendererIsNeeded): Code factoring. (WebCore::MediaControlInputElement::attach): See above. (WebCore::MediaControlInputElement::updateStyle): Use attach()
  • rendering/MediaControlElements.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls): Directly run attach() on the m_panel, which is a root node for our shadow tree.

LayoutTests:

2009-07-07 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=27047

Make sure nothing changing the src and reloading doesn't
change the look of the controller.

  • media/controls-after-reload.html: Added.
  • platform/mac-leopard/media/controls-after-reload-expected.txt: Added.
  • platform/mac/media/controls-after-reload-expected.txt: Added.
17:19 Changeset [45613] by simon.fraser@apple.com
  • 5 edits
    4 adds in trunk

2009-07-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Repaint issue after layer drops out of composited mode.
<https://bugs.webkit.org/show_bug.cgi?id=27022>

RenderLayers cache repaint rects in the form of m_repaintRect and m_outlineBox,
and expect these to stay valid from one style change to the next. These rects
are relative to the repaint container, so if a layer stops being composited,
we need to recompute them.

Test: compositing/repaint/layer-repaint-rects.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::computeRepaintRects):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking):
16:45 Changeset [45612] by mitz@apple.com
  • 8 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt and Darin Adler.

Test: fast/css/pseudo-cache-stale.html

  • dom/Element.cpp: (WebCore::Element::pseudoStyleCacheIsInvalid): Added. Given the old style and the new style, goes over cached pseudo-styles in the old style and re-resolves the same style types off the new style. If any of the new pseudo-styles is different from the currently cached corresponding style, returns true. Otherwise, returns false. (WebCore::Element::recalcStyle): Validate the pseudo-style cache before deciding to keep the existing style.
  • dom/Element.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::uncachedFirstLineStyle): Added this version that returns an uncached first-line style based off the given style. (WebCore::RenderObject::getUncachedPseudoStyle): Added the 'ownStyle' parameter.
  • rendering/RenderObject.h:
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getPseudoStyleCache): Added. Returns the cached pseudo-styles in the passed-in vector.
  • rendering/style/RenderStyle.h:

LayoutTests:

Reviewed by Dave Hyatt and Darin Adler.

  • fast/css/pseudo-cache-stale.html: Added.
  • platform/mac/fast/css/pseudo-cache-stale-expected.checksum: Added.
  • platform/mac/fast/css/pseudo-cache-stale-expected.png: Added.
  • platform/mac/fast/css/pseudo-cache-stale-expected.txt: Added.
16:44 Changeset [45611] by darin@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

2009-07-07 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Fisher.

revise test expectations for bug 26088
http://bugs.webkit.org/show_bug.cgi?id=26088

generate pixel expectations, move location of generic expected file
for the crash test.

  • fast/text/text-large-negative-letter-spacing-with-opacity-expected.txt: Copied from platform/mac/fast/text/text-large-negative-letter-spacing-with-opacity-expected.txt.
  • platform/mac/fast/text/text-large-negative-letter-spacing-with-opacity-expected.txt: Removed.
  • platform/mac/fast/text/text-letter-spacing-expected.checksum: Added.
  • platform/mac/fast/text/text-letter-spacing-expected.png: Added.
15:04 Changeset [45610] by pdherbemont@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

2009-07-07 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Add a specific leopard result for controls-styling.html, given that it doesn't
use the new controller look.

  • platform/mac-leopard/media/controls-styling-expected.txt: Added.
14:52 Changeset [45609] by barraclough@apple.com
  • 15 edits in trunk

JavaScriptCore:

2009-07-07 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Stop loading constants into the register file.

Instead, use high register values (highest bit bar the sign bit set) to indicate
constants in the instruction stream, and when we encounter such a value load it
directly from the CodeBlock.

Since constants are no longer copied into the register file, this patch renders
the 'unexpected constant' mechanism redundant, and removes it.

2% improvement, thanks to Sam Weinig.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::mark): (JSC::CodeBlock::shrinkToFit):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::isTemporaryRegisterIndex): (JSC::CodeBlock::constantRegister): (JSC::CodeBlock::isConstantRegisterIndex): (JSC::CodeBlock::getConstant): (JSC::ExecState::r):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::preserveLastVar): (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::addConstantValue): (JSC::BytecodeGenerator::emitEqualityOp): (JSC::BytecodeGenerator::emitLoad): (JSC::BytecodeGenerator::emitResolveBase): (JSC::BytecodeGenerator::emitResolveWithBase): (JSC::BytecodeGenerator::emitNewError):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitNode):
  • interpreter/CallFrame.h: (JSC::ExecState::noCaller): (JSC::ExecState::hasHostCallFrameFlag): (JSC::ExecState::addHostCallFrameFlag): (JSC::ExecState::removeHostCallFrameFlag):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveBase): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::resolveBaseAndFunc): (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::throwException): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JITInlineMethods.h: (JSC::JIT::emitLoadDouble): (JSC::JIT::emitLoadInt32ToDouble):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_error): (JSC::JIT::emit_op_enter): (JSC::JIT::emit_op_enter_with_activation):
  • parser/Nodes.cpp: (JSC::DeleteResolveNode::emitBytecode): (JSC::DeleteValueNode::emitBytecode): (JSC::PrefixResolveNode::emitBytecode):
  • runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation):
  • wtf/Platform.h:

LayoutTests:

2009-07-07 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

fast/js/global-recursion-on-full-stack.html is a little finicky.

The test recurses down the JS stack to find the bottom (catching this with an exception),
then tries to call a host function (document.write), switch writes new '<script>' code,
and expects this code to be run, then expects this code to try to call 'f();' again,
which it expects to fail, and it expects to catch that exception. However it is possible
that one of the earlier stages (the call to document.write, entering the interpreter to
run the new global code) will fail, depending on exactly how much stack space was free at
the point the last call to f() failed.

Tweak the test to make it work.

  • fast/js/global-recursion-on-full-stack.html:
14:36 Changeset [45608] by mitz@apple.com
  • 5 edits
    8 adds in trunk

WebCore:

Reviewed by Simon Fraser.

Tests: fast/repaint/float-in-new-block-with-layout-delta.html

fast/repaint/float-new-in-block.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): If the child has never been laid out before, paint its overhanging floats in addition to itself.
  • rendering/RenderBlock.h: (WebCore::RenderBlock::FloatWithRect::FloatWithRect): Added and initialized a boolean everHadLayout member.
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Paint floats that have never been laid out before and did not move from (0, 0).

LayoutTests:

Reviewed by Simon Fraser.

  • fast/repaint/float-in-new-block-with-layout-delta.html: Added.
  • fast/repaint/float-new-in-block.html: Added.
  • platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum: Added.
  • platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Added.
  • platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Added.
  • platform/mac/fast/repaint/float-new-in-block-expected.checksum: Added.
  • platform/mac/fast/repaint/float-new-in-block-expected.png: Added.
  • platform/mac/fast/repaint/float-new-in-block-expected.txt: Added.
14:27 Changeset [45607] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-07-07 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

  • Fix <rdar://problem/6544693>.


For Flash, don't cache which methods or fields in an object are missing, since they can
be added at any time.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPackage):
  • Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::shouldCacheMissingPropertiesAndMethods):
  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::methodsNamed): (WebKit::ProxyInstance::fieldNamed):
14:19 Changeset [45606] by beidson@apple.com
  • 6 edits
    3 adds in trunk

WebCore:

2009-07-07 Brady Eidson <beidson@apple.com>

Contributions from both Darin Adler and Brady Eidson.
Reviewed by Darin Adler.

<rdar://problem/7024039> REGRESSION (r42158): Back-forward navigation does not work correctly on nytimes.com

In r42158 we lost some exclusions to making back/forward items for subframe navigations when a main frame
navigation was still in progress.

This patch makes things even better than it used to be by:

  • Locking back/forward history at the time the navigation is scheduled, not after the load has committed.
  • Locking back/forward history if *any* ancestor frame is still loading instead of just the main frame.

Test: fast/loader/subframe-navigate-during-main-frame-load.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Move out the history locking logic into a standalone function so it can be used from multiple sites. (WebCore::mustLockBackForwardList): Returns true if any ancestor frame is still loading. (WebCore::FrameLoader::scheduleLocationChange): Respect mustLockBackForwardList() in addition to the passed in lockBackForwardList flag. (WebCore::FrameLoader::scheduleFormSubmission): Ditto.

LayoutTests:

2009-07-07 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/7024039> REGRESSION (r42158): Back-forward navigation does not work correctly on nytimes.com

  • fast/loader/resources/subframe-navigate-during-main-frame-load2.html: Added.
  • fast/loader/subframe-navigate-during-main-frame-load-expected.txt: Added.
  • fast/loader/subframe-navigate-during-main-frame-load.html: Added.
  • http/tests/navigation/javascriptlink-subframeload-expected.txt: Updated results to reflect the progression!
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt: Ditto!
  • http/tests/misc/redirect-to-about-blank.html: Add missing semi-colons.
14:15 Changeset [45605] by japhet@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2009-07-07 Nate Chapin <japhet@chromium.org>

Reviewed by Darin Fisher.

Upstream DOMObjectsInclude.h from src.chromium.org.

https://bugs.webkit.org/show_bug.cgi?id=27035

  • bindings/v8/DOMObjectsInclude.h: Added.
13:16 Changeset [45604] by mrowe@apple.com
  • 1 edit in trunk/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Versioning.k

13:02 Changeset [45603] by japhet@chromium.org
  • 17 edits
    1 copy in trunk/WebCore

2009-07-07 Nate Chapin <japhet@chromium.org>

Reviewed by David Levin.

Relanding r45559, which was rolled back at r45574.

https://bugs.webkit.org/show_bug.cgi?id=26857

12:05 Changeset [45602] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

Bug 26995 - AX: Some webpages do not send AXLoadComplete
https://bugs.webkit.org/show_bug.cgi?id=26995

11:02 Changeset [45601] by pdherbemont@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

2009-07-06 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=27015

Make sure that the CSS properties letter-spacing, word-spacing,
line-height, text-transform, text-indent, text-shadow,
text-decoration and color do not affect the media element controls,
that display text.

Controls that display text are only present in when the theme
MediaControllerThemeQT is being used.

Test: media/controls-styling.html

  • css/mediaControlsQT.css:
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::updateStyle): Special case for text-decoration. text-decoration can't be overriden from CSS, because text-decoration is additive for historical reasons.

LayoutTests:

2009-07-06 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Make sure overriding properties won't affect the media controller.

  • media/controls-styling.html: Added.
10:54 Changeset [45600] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 27025: Crashes and regression test failures related to regexps in 64-bit
Fix <https://bugs.webkit.org/show_bug.cgi?id=27025> / <rdar://problem/7033448>.

Reviewed by Darin Adler.

For x86_64 RegexGenerator uses rbx, a callee-save register, as a scratch register but
neglects to save and restore it. The change in handling of the output vector in r45545
altered code generation so that the RegExp::match was now storing important data in rbx,
which caused crashes and bogus results when it was clobbered.

  • yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::generateEnter): Save rbx.
(JSC::Yarr::RegexGenerator::generateReturn): Restore rbx.

10:30 Changeset [45599] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-07-07 Albert Wong <ajwong@chromium.org>

Not reviewed, Chromium build fix.

Add in missing header + fix syntax issue that crept into last patch.
https://bugs.webkit.org/show_bug.cgi?id=27027

  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton):
10:15 Changeset [45598] by simon.fraser@apple.com
  • 9 edits in trunk/WebCore

2009-07-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Make use of geometry information to decide which layers become composited.

<rdar://problem/7011947>
<https://bugs.webkit.org/show_bug.cgi?id=27021>

In addition to looking at painting order, also, optionally, take layer
overlap into account when deciding which RenderLayers need to be composited.

No testcase because DRT doesn't dump which layers are composited.

  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers): Removed the unused CompositingUpdate parameter, and just do an early return when there is no view.
  • rendering/RenderLayer.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::rendererContentChanged): (WebCore::RenderLayer::dirtyZOrderLists): (WebCore::RenderLayer::dirtyNormalFlowList): (WebCore::RenderLayer::styleChanged): (WebCore::RenderLayer::mustOverlapCompositedLayers): (WebCore::RenderLayer::setMustOverlapCompositedLayers): Change "overlay" to "overlap" for consistency with the use of "overlap" elsewhere.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout): compositingLayersNeedUpdate() renamed to compositingLayersNeedRebuild().

(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
Tell the compositor that we started an accelerated animation or transition.

  • rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::compositingLayersNeedRebuild): Renamed, since it's explicitly about changes in hierarchy now.

(WebCore::RenderLayerCompositor::setCompositingConsultsOverlap):
(WebCore::RenderLayerCompositor::compositingConsultsOverlap):
New getter and setter for whether compositing should take overlap into account.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): Add m_compositingConsultsOverlap, re-order some member variables.

(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingEnabledFlag):
Whitespace cleanup and method rename.

(WebCore::RenderLayerCompositor::setCompositingLayersNeedRebuild):
Method and variable renaming.

(WebCore::RenderLayerCompositor::updateCompositingLayers):
Now we have to run through the layer hierarchy every time if looking
at overlap, because changes in layout can now alter compositing behavior.
We minimize work by tracking whether we actually need to change the layer
hierarchy via needLayerRebuild.

(WebCore::RenderLayerCompositor::updateBacking):
3D transforms turn off overlap mode.

(WebCore::RenderLayerCompositor::layerWasAdded):
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
Method rename.

(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::overlapsCompositedLayers):
Utility methods to add a layer to the overlapMap (computing the absolute
bounding box only if we haven't already done so), and testing the map
entries.

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
If a layer would composite only because it comes after other compositing
layers in the painting order, then consult the overlap map to determine whether
it overlaps, and thus actually needs to composite.

Add layers to the map when they must be composited.

(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
Only do re-parenting work if the updateHierarchy flag is set.

(WebCore::RenderLayerCompositor::didStartAcceleratedAnimation):
When we start an accelerated transition or animation, we stop looking at
overlap because we can no longer guarantee correct front-to-back ordering while the
accelerated animation is running.

(WebCore::RenderLayerCompositor::needsToBeComposited):
Method renames.

  • rendering/RenderView.cpp: (WebCore::RenderView::setMaximalOutlineSize): Add comment indicating that this could be optimized.
09:52 Changeset [45597] by ddkilzer@apple.com
  • 4 edits
    35 adds in trunk/BugsSite

Updated BugsSite with local changes on server

The new files were created by checksetup.pl during the upgrade
to Bugzilla 3.2.3. The rest are self-explanatory.

  • data: Added "bugzilla-update.xml" to svn:ignore.
  • data/attachments: Added "groups.*" to svn:ignore.
  • data/params: Updated for a few changed parameters.
  • lib/.htaccess: Added.
  • skins/contrib/Dusk/IE-fixes.css: Added.
  • skins/contrib/Dusk/admin.css: Added.
  • skins/contrib/Dusk/create_attachment.css: Added.
  • skins/contrib/Dusk/dependency-tree.css: Added.
  • skins/contrib/Dusk/duplicates.css: Added.
  • skins/contrib/Dusk/editusers.css: Added.
  • skins/contrib/Dusk/help.css: Added.
  • skins/contrib/Dusk/index.css: Added.
  • skins/contrib/Dusk/panel.css: Added.
  • skins/contrib/Dusk/params.css: Added.
  • skins/contrib/Dusk/release-notes.css: Added.
  • skins/contrib/Dusk/show_bug.css: Added.
  • skins/contrib/Dusk/show_multiple.css: Added.
  • skins/contrib/Dusk/summarize-time.css: Added.
  • skins/contrib/Dusk/voting.css: Added.
  • skins/contrib/Dusk/yui: Added.
  • skins/contrib/Dusk/yui/calendar.css: Added.
  • skins/custom/IE-fixes.css: Added.
  • skins/custom/admin.css: Added.
  • skins/custom/buglist.css: Added.
  • skins/custom/create_attachment.css: Added.
  • skins/custom/dependency-tree.css: Added.
  • skins/custom/duplicates.css: Added.
  • skins/custom/editusers.css: Added.
  • skins/custom/help.css: Added.
  • skins/custom/panel.css: Added.
  • skins/custom/params.css: Added.
  • skins/custom/release-notes.css: Added.
  • skins/custom/show_bug.css: Added.
  • skins/custom/show_multiple.css: Added.
  • skins/custom/summarize-time.css: Added.
  • skins/custom/voting.css: Added.
  • skins/custom/yui: Added.
  • skins/custom/yui/calendar.css: Added.
09:16 Changeset [45596] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-07 Anton Muhin <antonm@chromium.org>

Reviewed by Darin Fisher.

Speed up creation of V8 wrappers for DOM nodes.

https://bugs.webkit.org/show_bug.cgi?id=26882

This patch doesn't require new tests as it a set of refactorings
to speed up wrapper creation.

  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
08:51 Changeset [45595] by jmalonzo@webkit.org
  • 5 edits in trunk

2009-07-07 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[GTK] textarea height property works only if other property are defined
https://bugs.webkit.org/show_bug.cgi?id=18984

Let WebCore handle textarea's metrics instead of readjusting it RenderthemeGtk.

Test: fast/forms/textarea-metrics.html

  • platform/gtk/RenderThemeGtk.cpp:
  • platform/gtk/RenderThemeGtk.h:
  • LayoutTests/platform/gtk/Skipped:
07:29 Changeset [45594] by jmalonzo@webkit.org
  • 6 edits
    3 adds in trunk

2009-07-07 Ben Murdoch <benm@google.com>

Reviewed by Antti Koivisto.

HTML5 Database becomes locked if a transaction is in progress when the page is refreshed.
https://bugs.webkit.org/show_bug.cgi?id=25711

Tests fix for https://bugs.webkit.org/show_bug.cgi?id=25711, where
web storage databases could become locked until the browser is
shut down if the page is refreshed whilst a transaction is in
progress.

  • storage/database-lock-after-reload-expected.txt: Added.
  • storage/database-lock-after-reload.html: Added.
  • storage/resources/database-lock-after-reload-2.html: Added.

Fix for https://bugs.webkit.org/show_bug.cgi?id=25711 where web
storage databases could become locked until the browser is shut
down if the page is refreshed whilst a transaction is in progress.

Test: storage/database-lock-after-reload.html

  • storage/Database.cpp: (WebCore::Database::Database): (WebCore::Database::close): add code to inform the database thread we've closed the database. (WebCore::Database::performOpenAndVerify): add code to inform the database thread we've opened a database.
  • storage/Database.h: (WebCore::Database::opened): return true iff the underlying sqlite database has been opened but not closed.
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::databaseThread): Before the database thread terminates, close any databases that ran transactions in this thread. (WebCore::DatabaseThread::recordDatabaseOpen): Records a database that executed a transaction in this thread. (WebCore::DatabaseThread::recordDatabaseClosed): Removes a database from the set of open databases.
  • storage/DatabaseThread.h: (WebCore::DatabaseThread::getThreadID): return the thread id for the database thread.
07:04 Changeset [45593] by hausmann@webkit.org
  • 6 edits in trunk

WebKit/qt:

2009-07-07 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger Freyther.

Add Qt DRT hook for clearing the frame name.

  • Api/qwebframe.cpp: (qt_drt_clearFrameName):

WebKitTools:

2009-07-07 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger Freyther.

Clear the main frame's name between loading pages, like in r36652. This
reduces the side-effects between test cases.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):

LayoutTests:

2009-07-07 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger Freyther.

Removed subframe-self-close.html from the Qt skip list.

  • platform/qt/Skipped:
05:52 Changeset [45592] by jmalonzo@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2009-07-07 Jiahua Huang <jhuangjiahua@gmail.com>

Reviewed by Jan Alonzo.

[Gtk] Paste of rich text from firefox results garbled markup
https://bugs.webkit.org/show_bug.cgi?id=26791

Fix problem with UTF-16 clipboard pasted.

  • manual-tests/gtk/paste-richtext-from-firefox.html: Added.
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::documentFragment):
05:35 Changeset [45591] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-07 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Change 'Continue debug' shortcut from F5 to F8 for consistency with Firebug.

https://bugs.webkit.org/show_bug.cgi?id=23849

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
03:48 Changeset [45590] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-07 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger Freyther.

Added all current failing Qt DRT tests to the skip list, for a fresh start.

  • platform/qt/Skipped:
03:27 Changeset [45589] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-06 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger Freyther.

Fix various layout tests with Qt's DRT.

Remember to set the focus on the web page before
loading.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
03:25 Changeset [45588] by hausmann@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-07 Simon Hausmann <hausmann@webkit.org>

Reviewed by Tor Arne Vestbø and Holger Freyther.

Fix timeout timer handling in Qt DRT.

Use QBasicTimer instead of startTimer/killTimer, to fix the
problem that starting the timeout timer did not stop a
previously started timer, causing multiple emissions of timeout.
The timerEvent() implementation now also checks the timer id, to
protect against double timeouts.

  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::waitUntilDone): (LayoutTestController::notifyDone): (LayoutTestController::timerEvent):
  • DumpRenderTree/qt/jsobjects.h:

07/06/09:

23:42 Changeset [45587] by ggaren@apple.com
  • 5 edits in branches/nitro-extreme

JavaScriptCore:

2009-07-06 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig (?).


Fixed an assertion seen during the stress test.


Don't assume that, if op1 is constant, op2 is not, and vice versa. Sadly,
not all constants get folded.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq):

LayoutTests:

2009-07-06 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig (?).

Test for an assertion seen during the stress test.


  • fast/js/arithmetic-expected.txt:
  • fast/js/resources/arithmetic.js:
22:34 Changeset [45586] by barraclough@apple.com
  • 16 edits in branches/nitro-extreme

JavaScriptCore:

2009-07-06 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Stop loading constants into the register file.

Instead, use high register values (highest bit bar the sign bit set) to indicate
constants in the instruction stream, and when we encounter such a value load it
directly from the CodeBlock.

Since constants are no longer copied into the register file, this patch renders
the 'unexpected constant' mechanism redundant, and removes it.

2% improvement, thanks to Sam Weinig.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::mark): (JSC::CodeBlock::shrinkToFit):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::isTemporaryRegisterIndex): (JSC::CodeBlock::constantRegister): (JSC::CodeBlock::isConstantRegisterIndex): (JSC::CodeBlock::getConstant): (JSC::ExecState::r):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::preserveLastVar): (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::addConstantValue): (JSC::BytecodeGenerator::emitEqualityOp): (JSC::BytecodeGenerator::emitLoad): (JSC::BytecodeGenerator::emitResolveBase): (JSC::BytecodeGenerator::emitResolveWithBase): (JSC::BytecodeGenerator::emitNewError):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitNode):
  • interpreter/CallFrame.h: (JSC::ExecState::noCaller): (JSC::ExecState::hasHostCallFrameFlag): (JSC::ExecState::addHostCallFrameFlag): (JSC::ExecState::removeHostCallFrameFlag):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveBase): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::resolveBaseAndFunc): (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::throwException): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JITInlineMethods.h: (JSC::JIT::emitLoadDouble): (JSC::JIT::emitLoadInt32ToDouble):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_error): (JSC::JIT::emit_op_enter): (JSC::JIT::emit_op_enter_with_activation):
  • parser/Nodes.cpp: (JSC::DeleteResolveNode::emitBytecode): (JSC::DeleteValueNode::emitBytecode): (JSC::PrefixResolveNode::emitBytecode):
  • runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation):
  • wtf/Platform.h:

LayoutTests:

2009-07-06 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

fast/js/global-recursion-on-full-stack.html is a little finicky.

The test recurses down the JS stack to find the bottom (catching this with an exception),
then tries to call a host function (document.write), switch writes new '<script>' code,
and expects this code to be run, then expects this code to try to call 'f();' again,
which it expects to fail, and it expects to catch that exception. However it is possible
that one of the earlier stages (the call to document.write, entering the interpreter to
run the new global code) will fail, depending on exactly how much stack space was free at
the point the last call to f() failed.

Tweak the test to make it work.

  • fast/js/global-recursion-on-full-stack.html:
20:40 Changeset [45585] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-07-06 Albert J. Wong <ajwong@chromium.org>

Reviewed by Maciej Stachowiak.

Update RenderThemeChromiumMac for wkDrawMediaUIPart and wkDrawMediaSlider API
change.

Fix compile RenderThemeChromiumMac.mm due to API changes from r45572
https://bugs.webkit.org/show_bug.cgi?id=27018

This is mainly an API change update to fix the chromium compile. It
also has a small fix of a typo in RenderThemeMac.mm.

Compilation against the head of chromium trunk passed. Since this is
a compile fix, that should be sufficient.

  • rendering/RenderThemeChromiumMac.mm: (WebCore::): (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekBackButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekForwardButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
  • rendering/RenderThemeMac.mm: (WebCore::):
19:49 Changeset [45584] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

Bug 27006: Build fix when MAC_JAVA_BRIDGE is disabled

<https://bugs.webkit.org/show_bug.cgi?id=27006>

Reviewed by Darin Adler.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createJavaAppletWidget): Wrap contents of the method in #if ENABLE(MAC_JAVA_BRIDGE)/#endif and return 0 when this feature is disabled.
19:44 Changeset [45583] by ddkilzer@apple.com
  • 3 edits in trunk/WebKit/mac

Bug 27005: Build fixes when NETSCAPE_PLUGIN_API is disabled

<https://bugs.webkit.org/show_bug.cgi?id=27005>

Reviewed by Geoff Garen.

  • Plugins/WebPluginController.mm: (-[WebPluginController destroyPlugin:]): Wrap call to ScriptController::cleanupScriptObjectsForPlugin() in #if ENABLE(NETSCAPE_PLUGIN_API)/#endif macro. (-[WebPluginController destroyAllPlugins]): Ditto.
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase removePluginInstanceViewsFor:]): Wrap WebBaseNetscapePluginView class checks in #if ENABLE(NETSCAPE_PLUGIN_API)/#endif macro. (-[WebPluginDatabase destroyAllPluginInstanceViews]): Ditto.
19:39 Changeset [45582] by ddkilzer@apple.com
  • 4 edits in trunk/WebKit/mac

BUILD FIX: Use ENABLE(NETSCAPE_PLUGIN_API) instead of USE(PLUGIN_HOST_PROCESS)

In r45579, #if/#endif macros for USE(PLUGIN_HOST_PROCESS) were
used, but ENABLE(NETSCAPE_PLUGIN_API) should have been used
instead.

  • Plugins/WebNetscapeContainerCheckContextInfo.h:
  • Plugins/WebNetscapeContainerCheckContextInfo.mm:
  • Plugins/WebNetscapeContainerCheckPrivate.mm:
19:18 Changeset [45581] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

Bug 27004: Build fix for ENABLE(PLUGIN_PROXY_FOR_VIDEO) after r42618

<https://bugs.webkit.org/show_bug.cgi?id=27004>

Reviewed by Geoff Garen.

  • Plugins/WebPluginController.mm: (mediaProxyClient): Use core() method to convert from DOMElement to WebCore::Element.
19:18 Changeset [45580] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-06 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

bugzilla-tool fails to close bugs with bugzilla 3.0
https://bugs.webkit.org/show_bug.cgi?id=27008

Update bugzilla.py to match changes in the bug page "changeform"
Update scm.py to add bug_ids to attachments to make error reporting nicer.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/scm.py:
19:14 Changeset [45579] by ddkilzer@apple.com
  • 4 edits in trunk/WebKit/mac

Bug 27003: Build fix when USE(PLUGIN_HOST_PROCESS) is disabled

<https://bugs.webkit.org/show_bug.cgi?id=27003>

Reviewed by Geoff Garen.

  • Plugins/WebNetscapeContainerCheckContextInfo.h: Added #if USE(PLUGIN_HOST_PROCESS)/#endif guards.
  • Plugins/WebNetscapeContainerCheckContextInfo.mm: Ditto.
  • Plugins/WebNetscapeContainerCheckPrivate.mm: Ditto.
18:01 Changeset [45578] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Bug 27002: Build fix when DASHBOARD_SUPPORT is disabled with -Wunused-parameter

<https://bugs.webkit.org/show_bug.cgi?id=27002>

Reviewed by Geoff Garen.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::prepareGradientForDashboard): Mark gradient as an unused parameter when DASHBOARD_SUPPORT is disabled.
17:59 Changeset [45577] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Bug 27001: Fix improper use of PassRefPtr<Node> to RefPtr<Node>

<https://bugs.webkit.org/show_bug.cgi?id=27001>

Reviewed by Geoff Garen.

PassRefPtr<> should only be used for arguments to functions that
take ownership of the object, or as return values from functions
that relinquish ownership of the object.

  • editing/Editor.cpp: (WebCore::Editor::increaseSelectionListLevelOrdered): Changed stack-allocated PassRefPtr<Node> to RefPtr<Node> and call release() on returned object. (WebCore::Editor::increaseSelectionListLevelUnordered): Ditto.
17:44 Changeset [45576] by eric.carlson@apple.com
  • 4 edits in trunk

2009-07-06 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7035474> Make new media controller UI default on SnowLeopard

  • rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):

New media controller UI is enabled by default on SnowLeopard.

2009-07-06 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7035474> Make new media controller UI default on SnowLeopard

Disable media tests that depend on controller size/position on SnowLeopard until
<rdar://problem/6502936> Update run-webkit-tests to deal with new media controller look
has been fixed

  • platform/mac-snowleopard/Skipped:
16:54 Changeset [45575] by ggaren@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-07-06 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Include op_convert_this in result caching.


No change on SunSpider or v8.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_convert_this):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h: (JSC::): Made the op_convert_this JIT stub return an EncodedJSValue, so to maintain the result caching contract that { tag, payload } can be found in { regT1, regT0 }.
16:18 Changeset [45574] by japhet@chromium.org
  • 17 edits
    1 delete in trunk/WebCore

2009-07-06 Nate Chapin <japhet@chromium.org>

Unreviewed, build fix.

Roll out r45559 to fix Chromium canary.

https://bugs.webkit.org/show_bug.cgi?id=26857

15:59 Changeset [45573] by ggaren@apple.com
  • 10 edits in branches/nitro-extreme/JavaScriptCore

2009-07-06 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Implemented result chaining.


1% faster on SunSpider. 4%-5% faster on v8.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::move):
  • assembler/X86Assembler.h: (JSC::X86Assembler::movl_rr): Added an optimization to eliminate no-op mov instructions, to simplify chaining.
  • jit/JIT.cpp: (JSC::JIT::JIT):
  • jit/JIT.h: Added data members and helper functions for recording chained results. We record both a mapping from virtual to machine register and the opcode for which the mapping is valid, to help ensure that the mapping isn't used after the mapped register has been stomped by other instructions.
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCallVarargsSlowCase): (JSC::JIT::emit_op_ret): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase): Chain function call results.
  • jit/JITInlineMethods.h: (JSC::JIT::emitLoadTag): (JSC::JIT::emitLoadPayload): (JSC::JIT::emitLoad): (JSC::JIT::emitLoad2): (JSC::JIT::isLabeled): (JSC::JIT::map): (JSC::JIT::unmap): (JSC::JIT::isMapped): (JSC::JIT::getMappedPayload): (JSC::JIT::getMappedTag): Use helper functions when loading virtual registers into machine registers, in case the loads can be eliminated by chaining.
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_mov): (JSC::JIT::emit_op_end): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_catch): Chain results from these opcodes.

(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call): Load the profiler into regT2 to
avoid stomping a chained result.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_get_by_id): Chain results from these opcodes.
  • jit/JITStubCall.h: (JSC::JITStubCall::addArgument): Always use { regT1, regT0 }, to facilitate chaining.

(JSC::JITStubCall::call): Unmap all mapped registers, since our callee
stub might stomp them.

15:56 Changeset [45572] by eric.carlson@apple.com
  • 13 edits in trunk

2009-07-06 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/7008093> Media controller can’t be used to scrub when movie is
narrow — track is too narrow

Do not show media controller time display elements when the a movie is too narrow.

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

The 'state' parameter to wkDrawMediaUIPart is now an unsigned bitfield.

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):

Give current time and time remaining controls a common base class.

(WebCore::MediaControlTimeDisplayElement::setVisible):

New method, hide and show the element.

  • rendering/MediaControlElements.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia):

Initialize m_previousVisible.

(WebCore::RenderMedia::layout):

Show/hide the time display elements as the movie width changes.

(WebCore::RenderMedia::createCurrentTimeDisplay):
(WebCore::RenderMedia::createTimeRemainingDisplay):

Base class is now MediaControlTimeDisplayElement, not MediaControlElement.

(WebCore::RenderMedia::shouldShowTimeDisplayControls):

New, decide if time display elements should be visible or not.

  • rendering/RenderMedia.h:
  • rendering/RenderThemeMac.mm: (WebCore::): (WebCore::RenderThemeMac::paintMediaFullscreenButton): (WebCore::RenderThemeMac::paintMediaMuteButton): (WebCore::RenderThemeMac::paintMediaPlayButton): (WebCore::RenderThemeMac::paintMediaSeekBackButton): (WebCore::RenderThemeMac::paintMediaSeekForwardButton): (WebCore::RenderThemeMac::paintMediaSliderTrack): (WebCore::RenderThemeMac::paintMediaSliderThumb): (WebCore::RenderThemeMac::paintMediaRewindButton): (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton): (WebCore::RenderThemeMac::paintMediaControlsBackground): (WebCore::RenderThemeMac::paintMediaCurrentTime): (WebCore::RenderThemeMac::paintMediaTimeRemaining):

The 'state' parameter to wkDrawMediaUIPart is now an unsigned bitfield.

2009-07-06 Eric Carlson <eric.carlson@apple.com>

Update WebKitSystemInterface for <rdar://problem/7008093>.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
15:46 Changeset [45571] by ddkilzer@apple.com
  • 3 edits in trunk/WebCore

Bug 27000: Minor clean up to runtime_root.{cpp|h}

<https://bugs.webkit.org/show_bug.cgi?id=27000>

Reviewed by Geoff Garen.

  • bridge/runtime_root.cpp: Added blank line between license and the first #include statement.
  • bridge/runtime_root.h: Added comment to #endif.
15:42 Changeset [45570] by eric@webkit.org
  • 9 edits in trunk/WebCore

2009-07-06 Roland Steiner <rolandsteiner@google.com>

Reviewed by Maciej Stachowiak.

generalize the special height treatment for SVG (to be re-used for ruby):

renamed InlineBox::m_isSVG to m_hasVirtualHeight
renamed InlineBox::isSVG() to hasVirtualHeight()
renamed InlineBox::setIsSVG() to setHasVirtualHeight()

  • rendering/InlineBox.cpp: (WebCore::InlineBox::height):
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::isText): (WebCore::InlineBox::setIsText): (WebCore::InlineBox::isSVGRootInlineBox): (WebCore::InlineBox::hasVirtualHeight): (WebCore::InlineBox::setHasVirtualHeight): (WebCore::InlineBox::virtualHeight):
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createFlowBox):
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::createTextBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createRootBox):
  • rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::virtualHeight):
  • rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::virtualHeight):
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::virtualHeight):
15:11 Changeset [45569] by alice.liu@apple.com
  • 14 edits in trunk/WebCore

2009-07-06 Alice Liu <alice.liu@apple.com>

Reviewed by Darin Adler.

REGRESSION(r45285): focus rings are black on windows safari
https://bugs.webkit.org/show_bug.cgi?id=26821
<rdar://problem/7018252>

Add a mechanism for setting a custom focus ring color, and relocate the
determination of focus ring color to base class RenderTheme.

No new tests. Already-existing tests run in pixel mode would have caught this regression

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Move the responsibility of determining focus color to base class RenderTheme.
  • rendering/RenderTheme.cpp: (WebCore::customFocusRingColor): Added static local. (WebCore::RenderTheme::setCustomFocusRingColor): Added (WebCore::RenderTheme::focusRingColor): Use custom color over platform color.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::platformFocusRingColor): default implementation, black color
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderTheme::themeForPage): Circumstances that lead to returning the RenderThemeWin are the same under which we want to use the focus ring color from SafariTheme. (WebCore::RenderThemeSafari::platformFocusRingColor): Renamed from focusRingColor
  • rendering/RenderThemeSafari.h:

Renaming focusRingColor to platformFocusRingColor in these files:

  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::platformFocusRingColor):
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::platformFocusRingColor):
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::platformFocusRingColor):

Cleanup leftover from removal of WebCore::Color in r45285 in these files:

  • WebCore.order:
  • platform/graphics/Color.h:
14:53 Changeset [45568] by eric@webkit.org
  • 5 edits
    4 adds in trunk

2009-07-06 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Hyatt.

Bug 15135: REGRESSION (r19843-r19850): Changing a flexbox's
contents makes its container scroll to the top
https://bugs.webkit.org/show_bug.cgi?id=15135

Delay updateing scroll bar of descendants of flexbox until their
positions are determined. In this way we can prevent descendants
of flexible boxes from changing positions of their scrollbars
using tentative positions.

  • fast/flexbox/repaint-scrollbar-expected.txt: Added.
  • fast/flexbox/repaint-scrollbar.html: Added.
  • fast/flexbox/resources/repaint-scrollbar.js: Added.

2009-07-06 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Hyatt.

Bug 15135: REGRESSION (r19843-r19850): Changing a flexbox's
contents makes its container scroll to the top
https://bugs.webkit.org/show_bug.cgi?id=15135

Delay updateing scroll bar of descendants of flexbox until their
positions are determined. In this way we can prevent descendants
of flexible boxes from changing positions of their scrollbars
using tentative positions.

Test: fast/flexbox/repaint-scrollbar.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::startDelayUpdateScrollInfo): (WebCore::RenderBlock::finishDelayUpdateScrollInfo): (WebCore::RenderBlock::updateScrollInfoAfterLayout): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::layoutOnlyPositionedObjects):
  • rendering/RenderBlock.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
14:33 Changeset [45567] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-07-06 Hironori Bono <hbono@chromium.org>

Reviewed by Maciej Stachowiak.

Make unconfirmed IME text affect textarea's value.
This matches input and contentEditable elements as well
IE and Firefox.

This fixes https://bugs.webkit.org/show_bug.cgi?id=25061.

Input elements would go down this code path because it
would always get a null compositionNode from frame->editor().
Special casing compositionNodes is wrong because we explicitly
want unconfirmed IME input in the textarea's value (assuming we
want to match IE and Firefox here).

This change is originally created by Ojan Vafai <ojan@chromium.org> and
I just changed its manual tests with an automated test on his behalf.

  • platform/mac/editing/input/text-control-ime-input-expected.txt: Added.
  • platform/mac/editing/input/text-control-ime-input.html: Added.

2009-07-06 Hironori Bono <hbono@chromium.org>

Reviewed by Maciej Stachowiak.

Make unconfirmed IME text affect textarea's value.
This matches input and contentEditable elements as well
IE and Firefox.

This fixes https://bugs.webkit.org/show_bug.cgi?id=25061.

Input elements would go down this code path because it
would always get a null compositionNode from frame->editor().
Special casing compositionNodes is wrong because we explicitly
want unconfirmed IME input in the textarea's value (assuming we
want to match IE and Firefox here).

This change is originally created by Ojan Vafai <ojan@chromium.org> and
I just changed its manual tests with an automated test on his behalf.

Test: platform/mac/editing/input/text-control-ime-input.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::text): (WebCore::RenderTextControl::textWithHardLineBreaks):
14:13 Changeset [45566] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler and Mark Rowe.

Decommitted spans are added to the list of normal spans rather than
the returned spans in TCMalloc_PageHeap::Delete().
https://bugs.webkit.org/show_bug.cgi?id=26998


In TCMalloc_PageHeap::Delete(), the deleted span can be decommitted in
the process of merging with neighboring spans that are also decommitted.
The merged span needs to be placed in the list of returned spans (spans
whose memory has been returned to the system). Right now it's always added
to the list of the normal spans which can theoretically cause thrashing.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::Delete):
13:59 Changeset [45565] by andersca@apple.com
  • 9 edits in trunk

WebCore:

2009-07-06 Anders Carlsson <andersca@apple.com>

Reviewed by Adele Peterson.

Add the ability for wheel events to latch to a node.


  • WebCore.base.exp:
  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::clear): (WebCore::EventHandler::handleWheelEvent):
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::wheelEvent):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit/mac:

2009-07-06 Anders Carlsson <andersca@apple.com>

Reviewed by Adele Peterson.

Initialize wkIsLatchingWheelEvent.


  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
13:55 Changeset [45564] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2009-07-06 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a bunch of layout test crahses in Chromium caused by a bad usage of DEFINE_STATIC_LOCAL.

https://bugs.webkit.org/show_bug.cgi?id=26997

  • bindings/v8/V8Binding.cpp: (WebCore::v8ValueToWebCoreString): Use a regular static declaration instead of DEFINE_STATIC_LOCAL.
13:48 Changeset [45563] by andersca@apple.com
  • 5 edits in trunk/WebKitLibraries

2009-07-06 Anders Carlsson <andersca@apple.com>

Update WebKitSystemInterface.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
13:47 Changeset [45562] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-07-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: suggest global properties based on async evaluation.

https://bugs.webkit.org/show_bug.cgi?id=26976

Before this change, empty string was evaluated to the global object
(or scope chain object) synchronously. This is now fixed and global
object is evaluated using the same control flow.

  • inspector/front-end/Console.js: (WebInspector.Console.prototype.completions): (WebInspector.Console.prototype._evalInInspectedWindow):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._variablesInScope):
13:37 Changeset [45561] by ojan@chromium.org
  • 5 edits
    2 adds in trunk

WebCore:

2009-07-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Fix crash when indenting in an empty table cell.
https://bugs.webkit.org/show_bug.cgi?id=26872

The crash is that we would call splitTreeToNode where the node
and the nodeToSplitTo were the same node.

Test: editing/execCommand/indent-empty-table-cell.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode): Added an assert in that node and nodeToSplitTo are different nodes to make this assumption explicit.
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::isAtUnsplittableElement): (WebCore::IndentOutdentCommand::indentRegion):
  • editing/IndentOutdentCommand.h:

LayoutTests:

2009-07-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Fix crash when indenting in an empty table cell.
https://bugs.webkit.org/show_bug.cgi?id=26872

The crash is that we would call splitTreeToNode where the node
and the nodeToSplitTo were the same node.

  • editing/execCommand/indent-empty-table-cell-expected.txt: Added.
  • editing/execCommand/indent-empty-table-cell.html: Added.
11:10 Changeset [45560] by cmarrin@apple.com
  • 2 edits in trunk/WebKitSite/specs/CSSVisualEffects/css3-2d-transforms

added pseudocode form decomposition method

10:38 Changeset [45559] by japhet@chromium.org
  • 17 edits
    1 add in trunk/WebCore

2009-07-06 Nate Chapin <japhet@chromium.org>

Reviewed by David Levin.

Upstream V8Binding and update some function names.

https://bugs.webkit.org/show_bug.cgi?id=26857

07:37 Changeset [45558] by kov@webkit.org
  • 5 edits in trunk

WebCore

2009-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Jan Alonzo.

Use soup's content sniffing
https://bugs.webkit.org/show_bug.cgi?id=26982

Drop our hackish content sniffing code, and use the new libsoup
feature to do that job for us.

Testing this is in a cross-platform way is not obvious or possible
while we are using platform-specific code for sniffing.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::contentSniffedCallback): (WebCore::gotChunkCallback): (WebCore::ResourceHandle::startHttp):

WebKit/gtk

2009-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Jan Alonzo.

Use soup's content sniffing
https://bugs.webkit.org/show_bug.cgi?id=26982

Add the new Content Sniffing feature provided by libsoup.

  • webkit/webkitprivate.cpp: (webkit_init):

07/05/09:

22:22 Changeset [45557] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-07-05 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Darin Adler.

REGRESSION (r40499): fast/dom/cssTarget-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=20342

Re-added code removed by commit r40499.
Without this, both Qt and Mac were crashing while running the test.

Note that this does not entirely fix the bug. It fixes the WebCore
crash, but the test no longer seems to work due to loader changes.
So this patch does not reenable the test. The test probably has to
be rewritten.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removedFromDocument): Re-added code to set the CSS target of the document to 0.
18:46 Changeset [45556] by simon.fraser@apple.com
  • 6 edits
    3 adds in trunk

2009-07-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26943

When one transition finishes slightly before another the longer
one will fire a second time. This is because the second
ImplicitAnmation object is culled too early, before its final
RenderStyle is in place. This is done by cleanupFinishedAnimations()
so I got rid of that method completely and now cleanup each
transition or animation at the point where I am setting the final
style, or when I detect that the transition or animation has been
terminated early (which happens when you remove it from the style).

Test: transitions/extra-transition.html

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate):
  • page/animation/CompositeAnimation.h:
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent): Avoid a divide by zero if m_animation->duration() is zero, which can happen if the duration is changed to zero while the animation is running.
12:39 Changeset [45555] by simon.fraser@apple.com
  • 6 edits
    3 deletes in trunk

2009-07-05 Simon Fraser <simon.fraser@apple.com>

Revert the previous commit because it broke the
animations/transition-and-animation-1.html
testcase.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent):
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate): (WebCore::CompositeAnimation::cleanupFinishedAnimations):
  • page/animation/CompositeAnimation.h:
12:18 Changeset [45554] by simon.fraser@apple.com
  • 6 edits
    4 adds in trunk

2009-07-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26943

When one transition finishes slightly before another the longer
one will fire a second time. This is because the second
ImplicitAnmation object is culled too early, before its final
RenderStyle is in place. This is done by cleanupFinishedAnimations()
so I got rid of that method completely and now cleanup each
transition or animation at the point where I am setting the final
style, or when I detect that the transition or animation has been
terminated early (which happens when you remove it from the style).

Test: transitions/extra-transition.html

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate):
  • page/animation/CompositeAnimation.h:
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent): Avoid a divide by zero if m_animation->duration() is zero, which can happen if the duration is changed to zero while the animation is running.
08:45 Changeset [45553] by hausmann@webkit.org
  • 6 edits in trunk

JavaScriptCore:

2009-07-05 Lars Knoll <lars.knoll@nokia.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26843

Fix run-time crashes in JavaScriptCore with the Metrowerks compiler on Symbian.

The Metrowerks compiler on the Symbian platform moves the globally
defined Hashtables into read-only memory, despite one of the members
being mutable. This causes crashes at run-time due to write access to
read-only memory.

Avoid the use of const with this compiler by introducing the
JSC_CONST_HASHTABLE macro.

Based on idea by Norbert Leser.

  • runtime/Lookup.h: Define JSC_CONST_HASHTABLE as const for !WINSCW.
  • create_hash_table: Use JSC_CONST_HASHTABLE for hashtables.
  • runtime/JSGlobalData.cpp: Import various global hashtables via the macro.

WebCore:

2009-07-05 Lars Knoll <lars.knoll@nokia.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26843

Fix run-time crashes in JavaScriptCore with the Metrowerks compiler on Symbian.

The Metrowerks compiler on the Symbian platform moves the globally
defined Hashtables into read-only memory, despite one of the members
being mutable. This causes crashes at run-time due to write access to
read-only memory.

Avoid the use of const with this compiler by introducing the
JSC_CONST_HASHTABLE macro.

Based on idea by Norbert Leser.

  • bindings/scripts/CodeGeneratorJS.pm: Use JSC_CONST_HASHTABLE for hash tables define in the bindings.
07:53 Changeset [45552] by zecke@webkit.org
  • 7 edits in trunk/WebKit/gtk

2009-07-05 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Xan Lopez.

Always initialize WebCore.

It is possible that WebKitWebSettings and other classes get
constructed before the WebKitWebView. In this case WebCore is
not yet properly initialized. Add webkit_init to every class
that can be constructed by API users.

  • webkit/webkitdownload.cpp: (webkit_download_class_init):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_class_init):
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_class_init):
  • webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_class_init):
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
  • webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_class_init):
07:33 Changeset [45551] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-07-05 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger Freyther.

Fix two qdoc warnings.

Added missing \property for QWebFrame::hasFocus and added \a
tag for pos of QWebPage::frameAt.

  • Api/qwebframe.cpp:
  • Api/qwebpage.cpp:
06:06 Changeset [45550] by rwlbuis@webkit.org
  • 3 edits
    4 adds in trunk

Reviewed by Maciej Stachowiak.

Bug 26897 - Dynamic SVG images do not display correctly
https://bugs.webkit.org/show_bug.cgi?id=26897

Use repaint() to fix a rendering problem with a SVG image embedded in xhtml.

Test: svg/custom/createImageElement2.xhtml

  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged):
03:43 Changeset [45549] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-05 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=26960
[Gtk] caret offset not updated when selecting text

Report the caret offset from the end of the selection so it works
correctly for multi-char selections too (ie, anything that is not
the zero width caret).

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset):
00:28 Changeset [45548] by zecke@webkit.org
  • 2 edits in trunk/WebCore

Fix Qt link error by adding two new localized strings

In r45474 two new strings got added to LocalizedStrings.h add
the definition of them to Qt.

00:27 Changeset [45547] by zecke@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-04 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Simon Hausmann.

Use the recently introduced FocusController::setFocused

Use the recently introduced FocusController::setFocused
in the Qt platform. The SelectionController will be updated
from within the FocusController now.

  • Api/qwebpage.cpp: (QWebPagePrivate::focusInEvent): (QWebPagePrivate::focusOutEvent):
Note: See TracTimeline for information about the timeline view.