Timeline


and

07/13/09:

23:06 BuildingCairoOnWindows edited by bfulgham@webkit.org
(diff)
23:05 BuildingCairoOnWindows edited by bfulgham@webkit.org
Remove instruction to include GIFLIB, as this is no longer necessary. (diff)
23:04 BuildingCairoOnWindows edited by bfulgham@webkit.org
Removed instructions to edit config.h, as this is no longer necessary! (diff)
22:35 Changeset [45855] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-07-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: handle debugger shortcuts while on source frame or on
script file selector.

https://bugs.webkit.org/show_bug.cgi?id=27224

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
21:00 Changeset [45854] by weinig@apple.com
  • 3 edits in trunk/WebCore

2009-07-13 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Use standard HashCountedSet instead of a hand rolled one
in HTMLDocument.

  • html/HTMLDocument.cpp: (WebCore::addItemToMap): (WebCore::removeItemFromMap):
  • html/HTMLDocument.h:
20:32 WebKit Team edited by tonikitoo@gmail.com
added indt folks (diff)
19:44 Changeset [45853] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

2009-07-13 Brady Eidson <beidson@apple.com>

Fix Leopard regression I just introduced.

  • platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
19:01 Changeset [45852] by beidson@apple.com
  • 4 edits
    3 copies
    1 add in trunk/LayoutTests

2009-07-13 Brady Eidson <beidson@apple.com>

Rubberstamped by Mark Rowe.

Add SnowLeopard specific results for differing MIME types that are (mostly) progressions.

  • platform/mac-leopard/platform/mac/fast/loader: Added.
  • platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-2-expected.txt.
  • platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-3-expected.txt.
  • platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-expected.txt.
  • platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes-3-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes-expected.txt:
18:04 Changeset [45851] by darin@apple.com
  • 12 edits
    5 adds in trunk

WebCore:

2009-07-13 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler and Maciej Stachowiak.

Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262

This adds support for the HTML5 draggable attribute and its DOM binding. It maps the draggable property
to the CSS properties -webkit-user-drag and -webkit-user-select respectively.

Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-draggable-attribute

Test: fast/html/draggable.html

  • css/html.css:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::draggable):
  • html/HTMLAnchorElement.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::draggable): (WebCore::HTMLElement::setDraggable):
  • html/HTMLElement.h:
  • html/HTMLElement.idl:
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::draggable):
  • html/HTMLImageElement.h:

LayoutTests:

2009-07-13 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler and Maciej Stachowiak.

Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262

This adds support for the HTML5 draggable attribute and its DOM binding. It maps the draggable property
to the CSS properties -webkit-user-drag and -webkit-user-select respectively.

Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-draggable-attribute

  • fast/html/draggable-expected.txt: Added.
  • fast/html/draggable.html: Added.
  • fast/html/resources: Added.
  • fast/html/resources/images: Added.
  • fast/html/resources/images/lime.png: Added.
  • fast/dom/resources/domListEnumeration.js: Updated.
  • fast/dom/domListEnumeration-expected.txt: Updated.
17:47 Changeset [45850] by simon.fraser@apple.com
  • 3 edits
    9 adds in trunk

2009-07-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Image rendered as layer contents looks different from image rendered via CG.
<rdar://problem/7048830>

Fix a visible color profile difference between between images rendered via Core Graphics
and those rendered via a compositing layer, by assigning the GenericRGB profile to
untagged images (which come through as having the DeviceRGB profile) when they are set
as layer contents.

Test: compositing/color-matching/image-color-matching.html

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToImage):
17:20 Changeset [45849] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-07-13 Darin Adler <darin@apple.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=27220
Assertion failure in createSearcher() (usearch_open() status is U_USING_DEFAULT_WARNING)

  • editing/TextIterator.cpp: (WebCore::createSearcher): Add U_USING_DEFAULT_WARNING as a possible status code in the assertion. Affects only the assertion.
17:07 Changeset [45848] by ap@webkit.org
  • 6 edits
    4 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26925
<rdar://problem/7027850> URL Fragment Breaks Application Cache Loads

Test: http/tests/appcache/main-resource-hash.html

  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::resourceForURL): (WebCore::ApplicationCache::resourceForRequest):
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::cacheForMainRequest): (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didFail): (WebCore::ApplicationCacheGroup::addEntry): Remove URL fragment at appcache code borders.
  • loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::create):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::findOrCreateCacheGroup): (WebCore::ApplicationCacheStorage::cacheGroupForURL): (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Assert that there is no URL fragment in URL at key points in appcache code.
17:02 Changeset [45847] by darin@apple.com
  • 3 edits
    1 copy
    1 add in trunk

WebCore:

2009-07-13 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27166
rdar://problem/7015857
Find for strings composed entirely of spaces doesn't work

Test: fast/text/find-spaces.html

  • editing/TextIterator.cpp: (WebCore::findPlainText): Removed unneeded special case. The empty string case already works correctly.

LayoutTests:

2009-07-13 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27166
rdar://problem/7015857
Find for strings composed entirely of spaces doesn't work

  • fast/text/find-spaces-expected.txt: Added.
  • fast/text/find-spaces.html: Copied from LayoutTests/fast/text/find-case-folding.html.
16:42 Changeset [45846] by bfulgham@webkit.org
  • 3 edits in trunk/WebKit/win

2009-07-13 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Refactor WebFrame::spoolPages for easier sharing with Windows Cairo.
https://bugs.webkit.org/show_bug.cgi?id=27240.

  • WebFrame.cpp: (WebFrame::printHeader): New shared method to print the header. (WebFrame::printFooter): New shared method to print the footer. (WebFrame::spoolPage): New conditionally-compiled method to print a page. (WebFrame::spoolPages): Revised to call the platform-specific spoolPage for each page.
  • WebFrame.h: Add new method prototypes.
16:23 Changeset [45845] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-07-13 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Remove NPPVpluginPrivateModeBool, it was removed from the spec.


  • bridge/npapi.h:
16:08 Changeset [45844] by feng@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Feng Qian <feng@chromium.org>

Reviewed by Dimitri Glazkov.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27237

Make V8DOMMap.h compiling with gcc option -Werror=non=virtual-dtor.

  • bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::WeakReferenceMap): (WebCore::WeakReferenceMap::~WeakReferenceMap):
16:03 Changeset [45843] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

Remove an accidental add of bidi.(cpp|h) to WebCore.gypi.

  • WebCore.gypi: Removed bidi.cpp and bidi.h
15:46 Changeset [45842] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

Update WebCore.gyp in preparation to hooking it up.

  • WebCore.gypi: Added files that were mid-stream while switching over.
15:41 Changeset [45841] by mrowe@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add Leopard-specific results for fast/text/international/khmer-selection.html.

  • platform/mac-leopard/fast/text/international/khmer-selection-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/khmer-selection-expected.txt.
15:08 Changeset [45840] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Dmitry Titov <dimich@chromium.org>

Not reviewed, another small fix for Chromium build.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
15:00 Changeset [45839] by dimich@chromium.org
  • 4 edits in trunk/WebCore

2009-07-13 Dmitry Titov <dimich@chromium.org>

Not reviewed, fix Chromium build bustage.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/v8/V8Proxy.cpp: (WebCore::JavaScriptConsoleMessage::addToPage):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::handleConsoleMessage):
13:45 Changeset [45838] by mrowe@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add a missing layout test result to improve the quality of life of the Mac buildbots.

  • platform/mac/fast/text/international/khmer-selection-expected.txt: Added.
13:32 Changeset [45837] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-07-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein, Adam Roben.

"Unrecognized selector" console log when the Safari 4 Welcome page navigates to Top Sites.
<rdar://problem/6994893

attachRootGraphicsLayer() should not assume that the frameView's documentView
is a WebHTMLView.

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::attachRootGraphicsLayer):
13:16 Changeset [45836] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-07-13 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27234
<rdar://problem/7054356>

Add null page check in HTMLDocument::hasFocus.

Test: fast/dom/HTMLDocument/hasFocus-frameless-crash.html

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::hasFocus): Add page null check. (WebCore::HTMLDocument::createTokenizer): Cleanup page null check.

LayoutTests:

2009-07-13 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Test for https://bugs.webkit.org/show_bug.cgi?id=27234
<rdar://problem/7054356>

  • fast/dom/HTMLDocument/hasFocus-frameless-crash-expected.txt: Added.
  • fast/dom/HTMLDocument/hasFocus-frameless-crash.html: Added.
13:13 Changeset [45835] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Disable continuous spell checking in the inspector
https://bugs.webkit.org/show_bug.cgi?id=27131

  • inspector/front-end/inspector.html: Added spellcheck="false" to the

main-panels and console-prompt containers.

12:38 Changeset [45834] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-07-13 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler and Kevin Decker.

<rdar://problem/7053687> Core Animation plug-ins continue to grow larger and larger when opening new tabs (32 bit-only)

  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView setLayer:]): Add a FIXME.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setLayer:]): Make sure to set the size of the layer before changing the autoresizing mask so it won't grow everytime it's inserted into the layer tree.
12:14 Changeset [45833] by agl@chromium.org
  • 3 edits
    1 add in trunk

2009-07-13 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium Linux: fix assertion when rendering google.com.kh

https://bugs.webkit.org/show_bug.cgi?id=26924

Some shapers (i.e. Khmer) will produce cluster logs which report that
/no/ code points contributed to certain glyphs. Because of this, we
take any code point which contributed to the glyph in question, or any
subsequent glyph. If we run off the end, then we take the last code
point.

Added LayoutTests/fast/text/international/khmar-selection.html

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::offsetForPositionForComplexText):
12:05 Changeset [45832] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

spellcheck="false" is ignored
<rdar://problem/7054177>

  • editing/Editor.cpp: (WebCore::markMisspellingsOrBadGrammar): Moved code to check the

spellcheck attribute from here...

(WebCore::Editor::spellCheckingEnabledInFocusedNode): ...to here.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Bail out

if spell chcking is disabled by the spellcheck attribute.

  • editing/Editor.h:
11:34 Changeset [45831] by bfulgham@webkit.org
  • 9 edits
    1 add in trunk

WebCore:

2009-07-13 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087


  • WebCore.vcproj/WebCore.vcproj: Add new WinCairo.vsprops to Debug_Cairo and Release_Cairo builds.
  • config.h: Check for presence of WIN_CAIRO and select appropriate configuration. Defaults to standard Apple build.

WebKit/win:

2009-07-13 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087

  • WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to Debug_Cairo and Release_Cairo targets.

WebKitLibraries:

2009-07-13 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087


  • win/tools/vsprops/WinCairo.vsprops: Added. Defines the new WIN_CAIRO flag used to drive non-Apple Windows build.

WebKitTools:

2009-07-13 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087

  • DumpRenderTree/config.h: Check for presence of WIN_CAIRO and select appropriate configuration. Defaults to standard Apple build.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Add new WinCairo.vsprops to Debug_Cairo and Release_Cairo targets.
11:15 Changeset [45830] by pkasting@chromium.org
  • 17 edits
    1 move
    5 deletes in trunk

WebCore:

2009-07-13 Peter Kasting <pkasting@google.com>

https://bugs.webkit.org/show_bug.cgi?id=19562
Back out previous patch for this bug (too many problems).

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLButtonElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::form):
  • html/HTMLInputElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/ValidityState.cpp: Removed.
  • html/ValidityState.h: Removed.
  • html/ValidityState.idl: Removed.

LayoutTests:

2009-07-13 Peter Kasting <pkasting@google.com>

https://bugs.webkit.org/show_bug.cgi?id=19562
Back out previous patch for this bug (too many problems).
This also re-enables fast/dom/domListEnumeration.html.

  • fast/dom/domListEnumeration.html: Copied from LayoutTests/fast/dom/domListEnumeration.html-disabled.
  • fast/dom/domListEnumeration.html-disabled: Removed.
  • fast/forms/ValidityState-001-expected.txt: Removed.
  • fast/forms/ValidityState-001.html: Removed.
11:11 Changeset [45829] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Add HTMLAllCollection to WebCore.gypi.

https://bugs.webkit.org/show_bug.cgi?id=27223

10:08 Changeset [45828] by bolsinga@apple.com
  • 2 edits in trunk/WebKit/mac

2009-07-13 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

Correct these delegate methods' declarations by adding parameter names.

  • WebView/WebUIDelegatePrivate.h:
09:44 Changeset [45827] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Late NEWS file for 1.1.11.

  • NEWS:
09:40 Changeset [45826] by dglazkov@chromium.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-07-13 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

[V8] Add a missing check for constructor call in WebKitCSSMatrixConstructor.
https://bugs.webkit.org/show_bug.cgi?id=27218

Test: fast/css/matrix-as-function-crash.html

  • bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Added a check for constructor call.

LayoutTests:

2009-07-13 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

Make sure that calling WebKitCSSMatrix as function does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=27218

  • fast/css/matrix-as-function-crash-expected.txt: Added.
  • fast/css/matrix-as-function-crash.html: Added.
08:53 Changeset [45825] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.11

Tagging 1.1.11.

08:29 Changeset [45824] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Changes to the doc control files for 1.1.11.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
08:23 Changeset [45823] by kov@webkit.org
  • 2 edits in trunk

2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed build fix. Require the correct libsoup version now that
it's released.

  • configure.ac:
07:55 Changeset [45822] by hausmann@webkit.org
  • 2 adds in trunk/WebKitTools/DumpRenderTree/qt/TestNetscapePlugin

Added .pro file missing from r45813

07:54 Changeset [45821] by vestbo@webkit.org
  • 2 edits in trunk

2009-07-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Build fix for QtWebKit on Win
https://bugs.webkit.org/show_bug.cgi?id=27205

  • WebKit.pri: Include the major version number in the QtWebKit library file for Win.
07:32 Changeset [45820] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Fix qdoc warnings for QWebPage::shouldInterruptJavaScript() and mention
how to re-implement it.

  • Api/qwebpage.cpp:
07:20 Changeset [45819] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Holger Freyther.

Fix unit test to use the correct assumption that the SoupMessage
will be NULL when WebKitNetworkRequest is created from an URI.

  • tests/testnetworkrequest.c: (test_network_request_create_destroy):
06:58 WebKit Team edited by treat@kde.org
(diff)
06:15 Changeset [45818] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Ariya Hidayat.

Unskip three more fast/js tests that pass with the Qt DRT.

  • platform/qt/Skipped:
06:04 Changeset [45817] by hausmann@webkit.org
  • 3 edits
    1 delete in trunk

WebKitTools:

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Always run the Qt DRT with the raster graphicssystem on X11, for
increased stability in the image based tests, in particular canvas.

  • DumpRenderTree/qt/main.cpp: (main):

LayoutTests:

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Removed Qt DRT specific result for canvas-getImageData as we pass this
test with the raster graphicssystem.

  • platform/qt/fast/canvas/canvas-getImageData-expected.txt: Removed.
05:29 Changeset [45816] by kov@webkit.org
  • 4 edits in trunk

Unreviewed make dist build fix.

05:27 Changeset [45815] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-13 Cédric Luthi <cedric.luthi@gmail.com>

Reviewed by Tor Arne Vestbø.

Fix NPWindow clip rect in PluginViewMac

The rect should be in window-coordinates. This bug can be observed
with Flash 10 here: http://www.permadi.com/tutorial/cursorTracker/

  • plugins/mac/PluginViewMac.cpp:
03:55 Changeset [45814] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Fix crash with plugins when the plugin stream is cancelled.

Similar to r26667 handle the case where didReceiveResponse on the
plugin view results in failure to set up the stream and
setMainDocumentError being called instead. This will set the
m_pluginView back to 0 and we need check for it before calling
didReceiveData.

This was triggered by consecutive execution of
LayoutTests/plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
followed by LayoutTests/scrollbars/scrollbar-crash-on-refresh.html

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::committedLoad):
03:55 Changeset [45813] by hausmann@webkit.org
  • 7 edits in trunk

.:

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Add the test netscape plugin for the Qt DRT to the build.

  • WebKit.pro:

WebKitTools:

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Fix test netscape plugin usage with the Qt DRT.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): Enable plugins in the settings.
  • Scripts/run-webkit-tests: Set the QT_WEBKIT_PLUGIN path to the correct build directory to make Qt DRT find the test netscape plugin.

LayoutTests:

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Enable a bunch of plugin layout tests for the Qt DRT.

  • platform/qt/Skipped:
03:53 Changeset [45812] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Make sure to disable the fixed contents size when resetting the page/view
state between test runs, to avoid side-effects.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open): Call setFixedContentsSize() with an invalid QSize to disable the fixed layout.
03:52 Changeset [45811] by hausmann@webkit.org
  • 4 edits in trunk

WebKitTools:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

When creating new windows, don't forget to connect the new
page's main frame. This ensures that for example the layoutTestController
is also available there.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::createWindow):

LayoutTests:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Removed two more storage tests from the Qt DRT skip list that relied on
layoutTestController to be accessible in newly opened windows.

  • platform/qt/Skipped:
03:50 Changeset [45810] by hausmann@webkit.org
  • 5 edits in trunk

WebKitTools:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Added support for LayoutTestController.setPrivateBrowsingEnabled.

  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setPrivateBrowsingEnabled):
  • DumpRenderTree/qt/jsobjects.h:

LayoutTests:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Removed three tests from the Qt DRT Skip list that rely on
LayoutTestController.setPrivateBrowsingEnabled and pass now.

  • platform/qt/Skipped:
03:49 Changeset [45809] by hausmann@webkit.org
  • 11 edits in trunk

WebKit/qt:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Added QWebDatabase::removeAllDatabases, as a way to delete all
databases from the offline storage path.

Used by the Qt DRT.

  • Api/qwebdatabase.cpp: (QWebDatabase::removeAllDatabases):
  • Api/qwebdatabase.h:

WebKitTools:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Added support for database callbacks, storage quota setting,
and clearing of all databases.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::dumpDatabaseQuota):
  • DumpRenderTree/qt/DumpRenderTree.h:
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setDatabaseQuota): (LayoutTestController::clearAllDatabases):
  • DumpRenderTree/qt/jsobjects.h: (LayoutTestController::shouldDumpDatabaseCallbacks): (LayoutTestController::dumpDatabaseCallbacks):
  • DumpRenderTree/qt/main.cpp: (main):

LayoutTests:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Enable a bunch of more storage layout tests for the Qt DRT, now that
they pass.

  • platform/qt/Skipped:
03:48 Changeset [45808] by hausmann@webkit.org
  • 4 edits in trunk

WebKitTools:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Setup the path in the Qt DRT for HTML 5 Databases, to enable some of
the storage layout tests.

  • DumpRenderTree/qt/main.cpp: (main):

LayoutTests:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Enable some storage layout tests in the Qt DRT, as the pass now.

  • platform/qt/Skipped:
03:46 Changeset [45807] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Fix Qt implementation of WebCore::directoryName to return the absolute
directory name instead of the base file name.

  • platform/qt/FileSystemQt.cpp: (WebCore::directoryName):
03:45 Changeset [45806] by hausmann@webkit.org
  • 8 edits in trunk

WebKit/qt:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Added loadStarted() and loadFinished() signals to QWebFrame,
to allow load tracking of individual frames, as opposed to
QWebPage's loadStarted/loadFinished signals that are emitted
whenever _any_ child frame loads/finishes.

  • Api/qwebframe.cpp: Document new signals.
  • Api/qwebframe.h: Add new signals.
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::setFrame): Connect new signals.

WebKitTools:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Make the test output more robust by dumping only when the main
frame finishes loading, instead of when _any_ frame finishes.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): Connect to the main frame's loadFinished() signal instead of the page's one.

LayoutTests:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Removed 20 more frame tests from the Qt skip list as they pass now
after making sure we only dump after the main frame's loadFinished
signal.

  • platform/qt/Skipped:
03:40 Changeset [45805] by hausmann@webkit.org
  • 9 edits in trunk

WebKit/qt:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Add hooks for the GCController JavaScript interface needed by the
Qt DRT.

Fixed sort order of includes in qwebframe.cpp.

  • Api/qwebframe.cpp: (qt_drt_javaScriptObjectsCount): (qt_drt_garbageCollector_collect): (qt_drt_garbageCollector_collectOnAlternateThread):

WebKitTools:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Implement the GCController DRT interface in the Qt DRT.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): Allocate the GCController. (WebCore::DumpRenderTree::initJSObjects): Register the interface with the JS engine.
  • DumpRenderTree/qt/DumpRenderTree.h: Declare m_gcController.
  • DumpRenderTree/qt/jsobjects.cpp: Implement GCController. (GCController::GCController): (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
  • DumpRenderTree/qt/jsobjects.h: Declare GCController.

LayoutTests:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Remove fast/frames/removal-before-attach-crash.html and
fast/dom/StyleSheet/ownerNode-lifetime-2.html from the Qt DRT skip
list, as they pass now with support for the GCController.

  • platform/qt/Skipped:
03:34 Changeset [45804] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Fix WebCore::Path::isEmpty() for the Qt port to return true
if there is no element in the path.

QPainterPath::isEmpty() returns also true if there is one single
MoveTo element inside, which makes sense but doesn't patch Webcore's
is-empty definition.

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::isEmpty): Use elementCount() == 0.
03:22 Changeset [45803] by jmalonzo@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-07-13 Reinout van Schouwen <reinouts@gnome.org>

<https://bugs.webkit.org/show_bug.cgi?id=26980> [Gtk] Updated Dutch translation

Rubber-stamped by Jan Alonzo.

  • nl.po: Added.
03:11 Changeset [45802] by jmalonzo@webkit.org
  • 4 edits in trunk

2009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org>

<https://bugs.webkit.org/show_bug.cgi?id=27171> [Gtk]
REGRESSION (r45440): fails at fast/events/frame-programmatic-focus.html

Reviewed by Gustavo Noronha.

Unskip fast/events/frame-programmatic-focus.html

  • platform/gtk/Skipped:

focus-in and focus-out events only get triggered when there's user
interaction, hence setFocused(bool) never gets called when
focusEvent is triggered when running the layout tests. The
solution seems to be to implement grab-focus too so we can call
setFocused(bool) when a widget has focus.

  • webkit/webkitwebview.cpp: (webkit_web_view_grab_focus): (webkit_web_view_focus_in_event): (webkit_web_view_class_init):
02:57 Changeset [45801] by jmalonzo@webkit.org
  • 12 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=26718 [Gtk] Add support for javascript windows for DRT

Reviewed by Gustavo Noronha and Xan Lopez.

Unskip tests that now pass due to support for JS windows in Gtk DRT.

  • platform/gtk/Skipped:

Add API to support opening and closing of JavaScript windows automatically.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
  • webkit/webkitprivate.h:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_real_close_web_view): (webkit_web_view_class_init): (webkit_web_view_update_settings): (webkit_web_view_settings_notify): (webkit_web_view_set_group_name):
  • webkit/webkitwebview.h:

Support running of tests that open and close JS windows automatically.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpFramesAsText): (dumpBackForwardListForAllWebViews): (resetWebViewToConsistentStateBeforeTesting): (dump): (runTest): (webViewClose): (createWebView): (webViewCreate): (main):
  • DumpRenderTree/gtk/DumpRenderTreeGtk.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::windowCount): (LayoutTestController::setPopupBlockingEnabled):
02:47 Changeset [45800] by hausmann@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Oliver Hunt.

Tweak mouseout-dead-subframe.html to be more robust.

The test calls notifyDone() and then dumpAsText(). The latter call has no effect
as notifyDone() performs the dump, but it passes in the mac DRT because the mime-type
of the .html file is detected as text/plain and therefore the text is dumped instead
of the render tree.

Changed the testcase to call dumpAsText() first and then notifyDone(), to make it
pass without relying on the mime type detection.

That also makes the test pass in the Qt DRT.

  • fast/events/mouseout-dead-subframe.html: Swapped notifyDone() and dumpAsText() calls to call the former before the latter.
  • platform/qt/Skipped: Removed skipped test.
02:36 Changeset [45799] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Maciej Stachowiak.

prepare-ChangeLog should decode HTML entities in short description
https://bugs.webkit.org/show_bug.cgi?id=27122

Decode the short description by adding a function which decodes HTML
entities. It can decode &, <, >, ", and ' . They may be sufficient
as the description seems to be encoded by xml_quote in
http://mxr.mozilla.org/bugzilla/source/Bugzilla/Util.pm

  • Scripts/prepare-ChangeLog:
02:31 Changeset [45798] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Albert J. Wong <ajwong@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream fixes to NPV8Object.cpp that make ~30 layout tests pass.
https://bugs.webkit.org/show_bug.cgi?id=27127

There were a number of bugs introduced during the last upstreaming
effort that broke around 30 layout tests. This fixes those bugs.
It also has compile fixes to match the recent cutting apart of
V8Proxy.

  • bindings/v8/NPV8Object.cpp: (freeV8NPObject): (npCreateV8ScriptObject): (NPN_Invoke): (NPN_InvokeDefault): (NPN_EvaluateHelper): (NPN_SetException): (NPN_Construct):
02:31 Changeset [45797] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

Fix memory leak in the V8 binding layer.
https://bugs.webkit.org/show_bug.cgi?id=27163

Reinitializing the context is not necessary when clearing the proxy for navigation
and it will lead us to hold on to an empty context for each frame.

Test for empty context instead of empty global object handle when
updating the document for a context.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::updateDocument):
02:31 Changeset [45796] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 John Gregg <johnnyg@google.com>

Reviewed by David Levin.

Correct the logic to determine if a V8 callback returns a value.
https://bugs.webkit.org/show_bug.cgi?id=27155

  • bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback):
  • Don't crash if result.IsEmpty().
01:58 Changeset [45795] by levin@chromium.org
  • 25 edits
    16 adds in trunk

2009-07-13 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

.:

Added ENABLE(SHARED_WORKERS) flag.

  • configure.ac:

JavaScriptCore:

Added ENABLE(SHARED_WORKERS) flag (off by default).

  • Configurations/FeatureDefines.xcconfig:

WebCore:

Initial IDL definition and bindings for SharedWorkers.

  • Configurations/FeatureDefines.xcconfig: Added new files for SharedWorker support.
  • DerivedSources.make: Added new files for SharedWorker support.
  • GNUmakefile.am: Added new files for SharedWorker support.
  • WebCore.gypi: Added new files for SharedWorker support.
  • WebCore.pro: Added new files for SharedWorker support.
  • WebCore.xcodeproj/project.pbxproj: Added new files for SharedWorker support.
  • bindings/js/JSAbstractWorkerCustom.cpp: Added. (WebCore::JSAbstractWorker::mark): Custom mark handler that marks the event listeners. (WebCore::JSAbstractWorker::addEventListener): (WebCore::JSAbstractWorker::removeEventListener): (WebCore::JSAbstractWorker::toJS): Custom toJS handler which differentiates between various subclasses.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::sharedWorker): SharedWorker constructor (only enabled when SHARED_WORKERS is enabled).
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): (WebCore::toEventTarget): Added support for converting to/from SharedWorkers.
  • bindings/js/JSSharedWorkerConstructor.cpp: Added. (WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor): (WebCore::constructSharedWorker): (WebCore::JSSharedWorkerConstructor::getConstructData):
  • bindings/js/JSSharedWorkerConstructor.h: Added. (WebCore::JSSharedWorkerConstructor::classInfo):
  • bindings/js/JSSharedWorkerCustom.cpp: Added. (WebCore::JSSharedWorker::mark): Custom mark function that marks the internal MessagePort.
  • bindings/v8/DOMObjectsInclude.h: Updated to include new header files.
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp: Added. (WebCore::getEventListener): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): V8 handlers for add/removeEventListener().
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8SharedWorkerCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): Custom constructor for SharedWorker.
  • dom/EventTarget.cpp: (WebCore::EventTarget::toSharedWorker):
  • dom/EventTarget.h:
  • page/DOMWindow.idl:
  • workers/AbstractWorker.cpp: Added. (WebCore::AbstractWorker::AbstractWorker): Common base class for SharedWorker and (soon) Worker. The functions below were copied from Worker.cpp. This is the first step in refactoring Worker to derive from AbstractWorker to enable code sharing. (WebCore::AbstractWorker::~AbstractWorker): (WebCore::AbstractWorker::addEventListener): (WebCore::AbstractWorker::removeEventListener): (WebCore::AbstractWorker::dispatchEvent): (WebCore::AbstractWorker::dispatchLoadErrorEvent): (WebCore::AbstractWorker::dispatchScriptErrorEvent):
  • workers/AbstractWorker.h: Added. Definitions of functionality shared by Worker.h and SharedWorker.h. In a future patch, Worker will derive from AbstractWorker. (WebCore::AbstractWorker::scriptExecutionContext): (WebCore::AbstractWorker::setOnerror): (WebCore::AbstractWorker::onerror): (WebCore::AbstractWorker::eventListeners): (WebCore::AbstractWorker::refEventTarget): (WebCore::AbstractWorker::derefEventTarget):
  • workers/AbstractWorker.idl: Added.
  • workers/SharedWorker.cpp: Added. (WebCore::SharedWorker::SharedWorker): (WebCore::SharedWorker::~SharedWorker):
  • workers/SharedWorker.h: Added. (WebCore::SharedWorker::create): (WebCore::SharedWorker::port): (WebCore::SharedWorker::toSharedWorker):
  • workers/SharedWorker.idl: Added.

WebKit/mac:

Added ENABLE(SHARED_WORKERS) flag (disabled by default).

  • Configurations/FeatureDefines.xcconfig:

WebKitTools:

Added support for --shared-workers (turned off by default)

  • Scripts/build-webkit:

LayoutTests:

Unit tests for new SharedWorker APIs (disabled by default).

  • fast/workers/shared-worker-constructor-expected.txt: Added.
  • fast/workers/shared-worker-constructor.html-disabled: Added.
  • fast/workers/shared-worker-event-listener-expected.txt: Added.
  • fast/workers/shared-worker-event-listener.html-disabled: Added.
01:32 Changeset [45794] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Cleanup - Remove prf install target
https://bugs.webkit.org/show_bug.cgi?id=27191

qtwebkit.prf has been removed; this cleans up the related
install target as well.

  • WebCore.pro: Remove prf install target
01:30 Changeset [45793] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-07 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Maciej Stachoviak.

https://bugs.webkit.org/show_bug.cgi?id=27058

Removed superfluous parenthesis around single expression.
Compilers on Symbian platform fail to properly parse and compile.

01:24 Changeset [45792] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-13 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Maciej Stachoviak.

https://bugs.webkit.org/show_bug.cgi?id=27054

Renamed Translator to HashTranslator

Codewarrior compiler (WINSCW) latest b482 cannot resolve typename
mismatch between template declaration and definition
(HashTranslator / Translator)

  • wtf/HashSet.h:
01:20 Changeset [45791] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-13 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27053

Ambiguity in LabelScope initialization

Codewarrior compiler (WINSCW) latest b482 on Symbian cannot resolve
type of "0" unambiguously. Set expression explicitly to
PassRefPtr<Label>::PassRefPtr()

  • bytecompiler/BytecodeGenerator.cpp

07/12/09:

23:12 Changeset [45790] by bfulgham@webkit.org
  • 10 edits in trunk/WebKit

WebKit/gtk:

2009-07-12 Brent Fulgham <bfulgham@gmail.com>

Speculative build fix after http://trac.webkit.org/changeset/45786.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::addMessageToConsole):
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/qt:

2009-07-12 Brent Fulgham <bfulgham@gmail.com>

Speculative build fix after http://trac.webkit.org/changeset/45786.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::addMessageToConsole):
  • WebCoreSupport/ChromeClientQt.h:

WebKit/wx:

2009-07-12 Brent Fulgham <bfulgham@gmail.com>

Speculative build fix after http://trac.webkit.org/changeset/45786.

  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::addMessageToConsole):
  • WebKitSupport/ChromeClientWx.h:
23:02 Changeset [45789] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

2009-07-12 Brent Fulgham <bfulgham@gmail.com>

Speculative Windows build fix after http://trac.webkit.org/changeset/45786.

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::addMessageToConsole):
22:38 Changeset [45788] by abarth@webkit.org
  • 1 edit in trunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-script-src.pl

Fix executable bit. We should fix bugzilla-tool to understand executable bits.

22:36 Changeset [45787] by abarth@webkit.org
  • 6 edits
    7 adds in trunk

2009-07-12 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

Facebook Chat is broken due to XSS auditor
https://bugs.webkit.org/show_bug.cgi?id=27179

Instead of just using the script's URL as to detect an XSS attack, we
now use a bit of context before the URL. In particular, we use the
bytes from the beginning of the attribute name to the end of the
attribute value. In virtually all injection attacks, the attacker
would need to supply the attribute name as well as the attribute value.
However, in the Facebook false positive, the attribute name is not
present in the URL.

Tests: http/tests/security/xssAuditor/script-tag-src-redirect-safe.html

http/tests/security/xssAuditor/script-tag-with-source-double-quote.html
http/tests/security/xssAuditor/script-tag-with-source-no-quote.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
  • html/HTMLTokenizer.h:
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
  • page/XSSAuditor.h:

2009-07-12 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

Facebook Chat is broken due to XSS auditor
https://bugs.webkit.org/show_bug.cgi?id=27179

Add some more test coverage to our handling of script tags with src
attributes. Also, ensure that we don't raise the alarm when a URL
parameter is injected directly into the attribute value.

  • http/tests/security/xssAuditor/resources/echo-script-src.pl: Added.
  • http/tests/security/xssAuditor/script-tag-src-redirect-safe-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/base-href-safe-expected.txt.
  • http/tests/security/xssAuditor/script-tag-src-redirect-safe.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt.
  • http/tests/security/xssAuditor/script-tag-with-source-double-quote.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt.
  • http/tests/security/xssAuditor/script-tag-with-source-no-quote.html: Added.
22:08 Changeset [45786] by bfulgham@webkit.org
  • 36 edits in trunk

WebCore:

2009-07-12 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Refactor ConsoleMessage to add MessageType attribute.
https://bugs.webkit.org/show_bug.cgi?id=20625

  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::printErrorMessage):
  • dom/Document.cpp: (WebCore::Document::reportException): (WebCore::Document::addMessage):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::isEqual):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::endGroup): (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole): (WebCore::InspectorController::count):
  • inspector/InspectorController.h:
  • inspector/front-end/Console.js: (WebInspector.Console.prototype.addMessage): (WebInspector.ConsoleMessage): Added type property. (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype.toString): (WebInspector.ConsoleMessage.prototype.isEqual): (WebInspector.ConsoleCommandResult): (WebInspector.ConsoleGroup.prototype.addMessage): (WebInspector.ConsoleGroup.prototype._titleClicked):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._addTip): (WebInspector.Resource.prototype._checkWarning):
  • inspector/front-end/inspector.css: Changed ".console-group-title-level" to ".console-group-title"
  • inspector/front-end/inspector.js: (WebInspector.addMessageToConsole):
  • loader/DocLoader.cpp: (WebCore::DocLoader::printAccessDeniedMessage):
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::addMessageToConsole):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::reportLocalLoadFailed): (WebCore::FrameLoader::shouldAllowNavigation):
  • page/ChromeClient.h:
  • page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix): (WebCore::Console::addMessage): (WebCore::Console::error): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::trace): (WebCore::Console::assertCondition): (WebCore::Console::timeEnd): (WebCore::Console::warn):
  • page/Console.h: Added MessageType enum. (WebCore::):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessageTimerFired):
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject):
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::reportWarning): (WebCore::SVGDocumentExtensions::reportError):
  • wml/WMLErrorHandling.cpp: (WebCore::reportWMLError):
  • workers/GenericWorkerTask.h: Added GenericWorkerTask8 for the extra argument. (WebCore::GenericWorkerTask8::create): (WebCore::GenericWorkerTask8::GenericWorkerTask8): (WebCore::GenericWorkerTask8::performTask): (WebCore::createCallbackTask):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::addMessage): (WebCore::WorkerContext::importScripts):
  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::postConsoleMessageTask): (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerObjectProxy.h:
  • xml/XMLHttpRequest.cpp: (WebCore::reportUnsafeUsage): (WebCore::XMLHttpRequest::didFinishLoading):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::parseErrorFunc):

WebKit/mac:

2009-07-12 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Refactor ConsoleMessage to add MessageType attribute.
https://bugs.webkit.org/show_bug.cgi?id=20625

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addMessageToConsole):
21:07 Changeset [45785] by bfulgham@webkit.org
  • 7 edits
    1 add in trunk/WebCore

2009-07-12 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream UndetectableHTMLCollection.idl as HTMLAllCollection.idl.

https://bugs.webkit.org/show_bug.cgi?id=27132

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • dom/HTMLAllCollection.idl: Added.
20:55 Changeset [45784] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-12 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Maciej Stachowiak.

Inspector: Duplicate Computation in Autocompletion
https://bugs.webkit.org/show_bug.cgi?id=26778

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._completionsReady):
18:43 Changeset [45783] by eric.carlson@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

2009-07-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27197
QuickTime supports data: urls, add a layout test.

  • media/audio-data-url-expected.txt: Added.
  • media/audio-data-url.html: Added.

New test.

  • platform/gtk/Skipped:

Skip the new test.

17:54 Changeset [45782] by mitz@apple.com
  • 10 edits
    1 move
    1 delete in trunk

WebCore:

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=27196
Rename bidi.cpp to RenderBlockLineLayout.cpp and remove bidi.h

  • GNUmakefile.am: Updated.
  • WebCore.gypi: Updated.
  • WebCore.pro: Updated.
  • WebCore.vcproj/WebCore.vcproj: Updated.
  • WebCore.xcodeproj/project.pbxproj: Updated.
  • WebCoreSources.bkl: Updated.
  • rendering/RenderBlock.h: Removed unnecessary forward declaration and

updated comments.

  • rendering/RenderBlockLineLayout.cpp: Copied from WebCore/rendering/bidi.cpp.

Removed unnecessary #include statements.

(WebCore::BidiRun::BidiRun): Moved here from bidi.h.
(WebCore::RenderBlock::layoutInlineChildren): Removed outdated comment.

  • rendering/bidi.cpp: Removed.
  • rendering/bidi.h: Removed.

WebKitTools:

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=27196
Update check-for-global-initializers for the renaming for bidi.cpp to
RenderBlockLineLayout.cpp

  • Scripts/check-for-global-initializers:
16:48 Changeset [45781] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

16:41 Changeset [45780] by mitz@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • Image cleanup
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData): Use the data() accessor instead of the m_data member. (WebCore::BitmapImage::dataChanged): Ditto.
  • platform/graphics/Image.h: Re-ordered #includes and class declarations. Removed the drawPatternCallback() declaration. Made member variables private.
  • platform/graphics/cg/ImageCG.cpp: (WebCore::drawPatternCallback): Changed this from a member function to a static function.
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged): Use the data() accessor instead of the m_data member.
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Ditto.
14:49 Changeset [45779] by mrowe@apple.com
  • 7 edits in branches/safari-4-branch

Merge r45758.

14:49 Changeset [45778] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r45755.

14:49 Changeset [45777] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebKit/mac

Merge r45745.

14:49 Changeset [45776] by mrowe@apple.com
  • 18 edits in branches/safari-4-branch

Merge r45744.

14:49 Changeset [45775] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r45736.

14:49 Changeset [45774] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r45735.

14:48 Changeset [45773] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r45734.

14:48 Changeset [45772] by mrowe@apple.com
  • 7 edits in branches/safari-4-branch

Merge r45733.

14:48 Changeset [45771] by mrowe@apple.com
  • 5 edits in branches/safari-4-branch/WebCore

Merge r45732.

14:48 Changeset [45770] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r45728.

14:48 Changeset [45769] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r45721.

14:48 Changeset [45768] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebCore

Merge r45715.

14:48 Changeset [45767] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-4-branch

Merge r45710.

14:48 Changeset [45766] by mrowe@apple.com
  • 169 edits in branches/safari-4-branch

2009-07-10 Beth Dakin <bdakin@apple.com>

<rdar://problem/7045243> Roll text metrics change out

  • css/html.css:
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/mac/SimpleFontDataMac.mm:
  • platform/graphics/win/SimpleFontDataCGWin.cpp:
  • platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth):
14:47 Changeset [45765] by mrowe@apple.com
  • 29 edits in branches/safari-4-branch

<rdar://problem/7047403> Disable channel messaging

14:47 Changeset [45764] by mrowe@apple.com
  • 14 edits in branches/safari-4-branch

<rdar://problem/7048551> Disable datagrid

14:46 Changeset [45763] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2009-07-12 Daniel Bates <dbates@intudata.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27189


Fixes insufficient check in XSSAuditor::canSetBaseElementURL that caused
XSSAuditor to incorrectly block HTML Base elements whose base path coincided
with the URL of the page.

Test: http/tests/security/xssAuditor/base-href-safe3.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canSetBaseElementURL): Changed conditional to only call XSSAuditor::findInRequest() if the host in the page URL disagrees with the host in the base element URL.

2009-07-12 Daniel Bates <dbates@intudata.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27189


Tests that XSSAuditor does not block HTML Base elements whose path has the
same host as the page.

  • http/tests/security/xssAuditor/base-href-safe3-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-safe3.html: Added.
  • http/tests/security/xssAuditor/resources/base-href/base-href-safe3.html: Added.
13:27 Changeset [45762] by darin@apple.com
  • 9 edits in trunk/WebCore

2009-07-12 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Text searching with ICU should take the user's default locale into account
https://bugs.webkit.org/show_bug.cgi?id=27184
rdar://problem/6812121

No simple way to test this since it's dependent on user locale.
After this, the user's default locale is used only on Mac.

  • editing/TextIterator.cpp: (WebCore::createSearcher): Pass result of the currentSearchLocaleID function as the locale.
  • platform/text/TextBreakIteratorInternalICU.h: Added declaration of currentSearchLocaleID function.
  • platform/text/android/TextBreakIteratorInternalICU.cpp: (WebCore::currentSearchLocaleID): Added. Returns the empty string.
  • platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: (WebCore::currentSearchLocaleID): Ditto.
  • platform/text/gtk/TextBreakIteratorInternalICUGtk.cpp: (WebCore::currentSearchLocaleID): Ditto.
  • platform/text/mac/TextBreakIteratorInternalICUMac.mm: (WebCore::textBreakLocalePreference): Added. Returns the value of the AppleTextBreakLocale preference. (WebCore::topLanguagePreference): Added. Returns the value of the first item in the AppleLanguages preference. (WebCore::canonicalLanguageIdentifier): Added. Cover for the CFLocaleCreateCanonicalLanguageIdentifierFromString function. (WebCore::getLocale): Added. Transfers the locale from a CFStringRef into a buffer. (WebCore::getSearchLocale): Added. Calls topLanguagePreference, canonicalLanguageIdentifier, and getLocale. (WebCore::currentSearchLocaleID): Added. Calls getSearchLocale once. (WebCore::getTextBreakLocale): Changed to call textBreakLocalePreference, topLanguagePreference, canonicalLanguageIdentifier, and getLocale.
  • platform/text/win/TextBreakIteratorInternalICUWin.cpp: (WebCore::currentSearchLocaleID): Added. Returns the empty string.
  • platform/wx/TemporaryLinkStubs.cpp: (WebCore::currentSearchLocaleID): Ditto.
11:42 Changeset [45761] by xan@webkit.org
  • 2 edits in trunk

2009-07-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump version in preparation for 1.1.11 release.

  • configure.ac:
10:25 Changeset [45760] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Create a PangoLayout that properly represents the visual
appearance of the text in the web page so that the line boundary
modes of getText{At,Before,After}Offset work correctly.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (UTF16ToUTF8): (g_substr): (convertUniCharToUTF8): (getPangoLayoutForAtk):

07/11/09:

22:17 Changeset [45759] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Bug 27187 - Match Gecko behaviour for canvas path mutation APIs on an empty path
<https://bugs.webkit.org/show_bug.cgi?id=27187>

Reviewed by Simon Fraser

Simple API change, check for the empty path and add appropriate point if necessary.

Test: fast/canvas/canvas-modify-emptyPath.html

19:15 Changeset [45758] by eric.carlson@apple.com
  • 7 edits in trunk

2009-07-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

HTMLMediaElement.canPlayType "maybe" and "probably" reversed
https://bugs.webkit.org/show_bug.cgi?id=27186

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::supportsType):

Return "probably" if type has codecs parameter.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsType):

Ditto.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::supportsType):

Ditto.

2009-07-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

HTMLMediaElement.canPlayType "maybe" and "probably" reversed
https://bugs.webkit.org/show_bug.cgi?id=27186

  • media/video-can-play-type-expected.txt:
  • media/video-can-play-type.html:
13:26 Changeset [45757] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

13:24 Changeset [45756] by mrowe@apple.com
  • 1 copy in branches/safari-4-branch

New branch.

12:21 Changeset [45755] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-07-11 Brady Eidson <beidson@apple.com>

Reviewed by Mark Rowe.

A worker-thread inspired follow-up for:
https://bugs.webkit.org/show_bug.cgi?id=26496 and <rdar://problem/7046520>
REGRESSION: XHR stream connection blocks iFrame loading and resource downloading

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously): Don't perform the XHR compensation when the XHR is running on a worker thread. Accessing the global Cache data structures from a non-main thread is not currently supported.
11:44 Changeset [45754] by simon.fraser@apple.com
  • 10 edits
    6 moves
    35 adds in trunk

2009-07-11 Simon Fraser <simon.fraser@apple.com>

Enable support for accelerated compositing and 3d transforms on Leopard.
<https://bugs.webkit.org/show_bug.cgi?id=20166>
<rdar://problem/6120614>

Reviewed by Oliver Hunt.

03:18 Changeset [45753] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

2009-07-11 Simon Hausmann <hausmann@webkit.org>

Fix the Qt build after r45724.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp):
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):

07/10/09:

23:46 Changeset [45752] by abarth@webkit.org
  • 4 edits
    16 adds in trunk

WebCore:

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26921

Implements support for HTML entities, so XSSAuditor can protect against attacks
encoded with HTML entities.

Tests: http/tests/security/xssAuditor/inline-event-HTML-entities.html

http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char.html
http/tests/security/xssAuditor/javascript-link-HTML-entities-named.html
http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char.html
http/tests/security/xssAuditor/javascript-link-HTML-entities.html
http/tests/security/xssAuditor/link-onclick-entities.html
http/tests/security/xssAuditor/script-tag-entities.html
http/tests/security/xssAuditor/script-tag-with-source-entities.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::decodeURL): Modified to call WebCore::XSSAuditor::decodeHTMLEntities to decode HTML entities. (WebCore::XSSAuditor::decodeHTMLEntities): Added method to decode HTML entities. (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h:

LayoutTests:

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26921

Tests protection against HTML entities encoded attacks.

  • http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt: Added.
  • http/tests/security/xssAuditor/inline-event-HTML-entities.html: Added.
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char.html: Added.
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-named.html: Added.
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char.html: Added.
  • http/tests/security/xssAuditor/javascript-link-HTML-entities.html: Added.
  • http/tests/security/xssAuditor/link-onclick-entities-expected.txt: Added.
  • http/tests/security/xssAuditor/link-onclick-entities.html: Added.
  • http/tests/security/xssAuditor/script-tag-entities-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-entities.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-entities.html: Added.
23:25 Changeset [45751] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/27173> svn-apply: Fix typo in git command used to find deleted files

Reviewed by Eric Seidel.

  • Scripts/svn-apply: (scmWillDeleteFile): Changed 'head' to 'HEAD'.
23:16 Changeset [45750] by ddkilzer@apple.com
  • 11 edits in trunk

Bug 27007: Build fixes when ICONDATABASE is disabled

<https://bugs.webkit.org/show_bug.cgi?id=27007>

Reviewed by Sam Weinig.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Added IconDatabaseNone.cpp to the project.
  • loader/icon/IconDatabase.cpp: Added #if ENABLE(ICONDATABASE)/#endif macro guard.
  • loader/icon/IconDatabase.h: Removed three public methods from #if ENABLE(ICONDATABASE)/#endif macro so that they may be stubbed out in IconDatabaseNone.cpp.
  • loader/icon/IconDatabaseNone.cpp: Added #if !ENABLE(ICONDATABASE)/#endif macro guard. (WebCore::IconDatabase::importIconURLForPageURL): Added. (WebCore::IconDatabase::importIconDataForIconURL): Added. (WebCore::IconDatabase::shouldStopThreadActivity): Added.

WebKit/mac:

  • Misc/WebIconDatabase.mm: (defaultClient): Return 0 if ICONDATABASE is disabled.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveIcon): Commented out the body of the method if ICONDATABASE is disabled. (WebFrameLoaderClient::registerForIconNotification): Ditto.
  • WebCoreSupport/WebIconDatabaseClient.mm: Added #if ENABLE(ICONDATABASE)/#endif guard to source.
  • WebView/WebView.mm: (-[WebView setFrameLoadDelegate:]): Wrapped code that starts the icon database machinery in #if ENABLE(ICONDATABASE)/#endif. (-[WebView _registerForIconNotification:]): Wrapped method in #if ENABLE(ICONDATABASE)/#endif guard. (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Ditto.
  • WebView/WebViewInternal.h: Wrapped methods in #if ENABLE(ICONDATABASE)/#endif guard. (-[WebView _registerForIconNotification:]): (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
23:02 Changeset [45749] by abarth@webkit.org
  • 6 edits
    7 copies in trunk

WebCore:

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27151

Fixes issue where JavaScript URLs that contain null- and non-null control characters can
bypass XSSAuditor.

Tests: http/tests/security/xssAuditor/javascript-link-control-char.html

http/tests/security/xssAuditor/javascript-link-null-char.html
http/tests/security/xssAuditor/javascript-link.html

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): Separated out logic for JavaScript URLs from inline scripts. For JavaScript URLs, calls XSSAuditor::canEvaluateJavaScriptURL.
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): Made similar changes to evaluate() as in bindings/js/ScriptController.cpp.
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Separated out logic for JavaScript URLs into its own method.
  • page/XSSAuditor.h:

LayoutTests:

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27151

Tests prevention of JavaScript URLs that contain null- and non-null control characters.

  • http/tests/security/xssAuditor/javascript-link-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-control-char.html: Added.
  • http/tests/security/xssAuditor/javascript-link-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-null-char.html: Added.
  • http/tests/security/xssAuditor/javascript-link.html: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Added.
22:50 Changeset [45748] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-10 Jan Michael Alonzo <jmalonzo@webkit.org>

Skip tests in the Gtk port that

  • are dependent on eventSender
  • require platform-specific results
  • regressed (with links to the regression bug report)
  • failing (due to missing/incomplete implementation)
  • platform/gtk/Skipped:
22:36 Changeset [45747] by ddkilzer@apple.com
  • 141 edits in trunk/WebCore

2009-07-10 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Kilzer.

WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Fix bunch of style issues by autofix of cpplint.
This patch is created to demonstrate the autofix of cpplint.py.

No new testcases because it's a style fix

  • css/CSSParser.cpp: (WebCore::CSSParser::parseMediaQuery): (WebCore::CSSParser::validUnit): (WebCore::CSSParser::parseValue): (WebCore::skipCommaInDashboardRegion): (WebCore::CSSParser::parseDashboardRegions): (WebCore::ShadowParseContext::commitValue): (WebCore::ShadowParseContext::commitLength): (WebCore::ShadowParseContext::commitColor): (WebCore::BorderImageParseContext::commitNumber): (WebCore::BorderImageParseContext::commitWidth): (WebCore::BorderImageParseContext::commitRule): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::lex): (WebCore::CSSParser::text):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/MediaList.cpp: (WebCore::MediaList::deleteMedium):
  • css/MediaQuery.h:
  • css/MediaQueryEvaluator.cpp: (WebCore::parseAspectRatio):
  • css/MediaQueryEvaluator.h:
  • css/MediaQueryExp.h: (WebCore::MediaQueryExp::operator==):
  • css/WebKitCSSMatrix.h:
  • dom/Comment.h:
  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • dom/Document.h: (WebCore::Document::setHasDashboardRegions):
  • dom/DocumentFragment.cpp: (WebCore::DocumentFragment::nodeName):
  • dom/DocumentFragment.h:
  • dom/DynamicNodeList.h:
  • dom/EditingText.h:
  • dom/Element.cpp: (WebCore::Element::dispatchAttrAdditionEvent):
  • dom/NamedAttrMap.cpp: (WebCore::NamedNodeMap::item):
  • dom/Node.cpp: (WebCore::Node::nodeValue): (WebCore::Node::nodeIndex):
  • dom/NodeRareData.h: (WebCore::NodeListsNodeData::create):
  • dom/Notation.h:
  • dom/ProcessingInstruction.h:
  • dom/Range.cpp: (WebCore::Range::processContents):
  • dom/StyledElement.cpp: (WebCore::toHex):
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::): (WebCore::OffsetBuffer::readOutBytes): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::attributesStartElementNsHandler):
  • dom/XMLTokenizerQt.cpp: (WebCore::attributesStartElementNsHandler): (WebCore::XMLTokenizer::parseStartElement):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode):
  • editing/Editor.cpp: (WebCore::Editor::pasteAsPlainText):
  • editing/SelectionController.cpp: (WebCore::SelectionController::directionOfEnclosingBlock):
  • editing/SmartReplaceICU.cpp: (WebCore::addAllCodePoints):
  • history/HistoryItem.cpp: (WebCore::HistoryItem::icon): (WebCore::HistoryItem::adoptVisitCounts):
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyFillColor):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setActive): (WebCore::HTMLAnchorElement::isLiveLink):
  • html/HTMLAppletElement.h:
  • html/HTMLAudioElement.h:
  • html/HTMLBRElement.h:
  • html/HTMLBaseElement.h:
  • html/HTMLBaseFontElement.h:
  • html/HTMLDListElement.h:
  • html/HTMLDirectoryElement.h:
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::reset):
  • html/HTMLHRElement.cpp: (WebCore::HTMLHRElement::parseMappedAttribute):
  • html/HTMLHeadElement.h:
  • html/HTMLHtmlElement.h:
  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::setLoadManually):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selection):
  • html/HTMLIsIndexElement.h:
  • html/HTMLMarqueeElement.cpp:
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::):
  • html/HTMLMenuElement.h:
  • html/HTMLMetaElement.h:
  • html/HTMLModElement.h:
  • html/HTMLOListElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::childrenChanged):
  • html/HTMLParamElement.h:
  • html/HTMLQuoteElement.h:
  • html/HTMLStyleElement.h:
  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableCellElement.h:
  • html/HTMLTableColElement.h:
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::deleteRow):
  • html/HTMLTitleElement.h:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseNonHTMLText): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write):
  • html/HTMLUListElement.h:
  • html/HTMLVideoElement.h:
  • html/TimeRanges.h: (WebCore::TimeRanges::Range::Range):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::newInspectorJSONObject):
  • page/Console.cpp: (WebCore::Console::addMessage):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::defaultKeyboardEventHandler):
  • page/Frame.cpp: (WebCore::Frame::jsDefaultStatusBarText):
  • page/android/DragControllerAndroid.cpp: (WebCore::DragController::dragOperation):
  • page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::eventActivatedView):
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
  • page/gtk/DragControllerGtk.cpp: (WebCore::DragController::dragOperation):
  • page/qt/DragControllerQt.cpp:
  • page/win/DragControllerWin.cpp: (WebCore::DragController::isCopyKeyDown):
  • page/win/FrameWin.h:
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventOffsetToThumb):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setVerticalAlignLength): (WebCore::InheritedFlags::setUnicodeBidi): (WebCore::InheritedFlags::setCursor):
  • rendering/style/RenderStyleConstants.h: (WebCore::):
  • rendering/style/SVGRenderStyleDefs.h:
  • rendering/style/StyleInheritedData.h: (WebCore::StyleInheritedData::operator!=):
  • storage/DatabaseTask.h:
  • svg/GradientAttributes.h:
  • svg/LinearGradientAttributes.h:
  • svg/PatternAttributes.h:
  • svg/RadialGradientAttributes.h:
  • svg/SVGAnimatedPathData.h:
  • svg/SVGAnimatedPoints.h:
  • svg/SVGAnimationElement.h:
  • svg/SVGClipPathElement.h:
  • svg/SVGElementInstance.h:
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::build):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::build):
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::build):
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::build):
  • svg/SVGFEDistantLightElement.h:
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFuncAElement.h:
  • svg/SVGFEFuncBElement.h:
  • svg/SVGFEFuncGElement.h:
  • svg/SVGFEFuncRElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::build):
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build):
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::build):
  • svg/SVGFEPointLightElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
  • svg/SVGFESpotLightElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::build):
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::parseMappedAttribute):
  • svg/SVGList.h:
  • svg/SVGListTraits.h: (WebCore::):
  • svg/SVGMPathElement.h:
  • svg/SVGMetadataElement.h:
  • svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG): (WebCore::SVGPathParser::calculateArc):
  • svg/SVGPathElement.h:
  • svg/SVGPathSegClosePath.h:
  • svg/SVGSVGElement.h:
  • svg/SVGSetElement.h:
  • svg/SVGSwitchElement.h:
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::parseMappedAttribute):
  • svg/SVGTextPathElement.h:
  • svg/SVGTitleElement.h:
  • svg/SVGTransformable.cpp: (WebCore::):
  • svg/SVGViewSpec.cpp: (WebCore::):
  • svg/animation/SMILTime.cpp: (WebCore::operator+): (WebCore::operator-): (WebCore::operator*):
  • svg/animation/SVGSMILElement.h:
  • svg/graphics/SVGResource.cpp: (WebCore::clientMap):
  • wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::value):
  • wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::value):
  • workers/WorkerRunLoop.cpp:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection):
  • xml/XPathPath.h:
22:22 Changeset [45746] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/27167> bugzilla-tool: hide help for unsupported commands

Reviewed by Eric Seidel.

When bugzilla-tool -hhelp is invoked in an svn working

directory, don't print help for commands that are only supported
on git working directories.

  • Scripts/bugzilla-tool: (Command.init): Added requires_local_commits argument with a default of False. Set self.requires_local_commits attribute. (PostCommitsAsPatchesToBug.execute): Removed SCM.supports_local_commits() check since this is now handled by BugzillaTool.main(). (PostCommitsAsPatchesToBug.init): Added requires_local_commits=True argument to Command.init(). (BugzillaTool.commands_usage): Don't print help for commands if they require local commits and the current SCM doesn't support them. (BugzillaTool.main): If command_object requires local commits and the current SCM doesn't, exit with an error message.
21:20 Changeset [45745] by simon.fraser@apple.com
  • 3 edits in trunk/WebKit/mac

2009-07-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by John Sullivan.

Flashing as hardware layers are created and destroyed in some content
<rdar://problem/7032246>

There's a window of time between the end of one runloop cycle, after CA layers changes
have been committed, and the window display at the start of the next cycle when
CA may push updates to the screen before AppKit has drawn the view contents. If
we know that we need to do drawing synchronization (which we do when content moves
between a layer and the view), then we need to call -disableScreenUpdatesUntilFlush
from the existing runloop observer that is set up when layers need repainting to
ensure that layer updates don't reach the screen before view-based painting does.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]): Tweak the comments
  • WebView/WebView.mm: (viewUpdateRunLoopObserverCallBack): (-[WebView _scheduleViewUpdate]): Add a big comment to explain the timing of things. Call -disableScreenUpdatesUntilFlush when the view _needsOneShotDrawingSynchronization.
21:02 Changeset [45744] by eric.carlson@apple.com
  • 18 edits in trunk

2009-07-10 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7049066>.
Update SnowLeopard media controller layout.

  • css/mediaControlsQT.css:

Update for new layout.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::movieLoadType):

Added to replace isStreaming.

  • html/HTMLMediaElement.h:

Declare movieLoadType, remove isStreaming.

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlStatusDisplayElement::update):

Use movieLoadType instead of isStreaming.

(WebCore::MediaControlTimelineContainerElement::rendererIsNeeded):

MediaControlElement is the base class, not HTMLInputElement.

(WebCore::MediaControlStatusDisplayElement::rendererIsNeeded):

Ditto.

(WebCore::MediaControlRewindButtonElement::rendererIsNeeded):

Don't display rewind button for live streams.

(WebCore::MediaControlReturnToRealtimeButtonElement::rendererIsNeeded):

MediaControlInputElement is the base class, not HTMLInputElement.

  • rendering/MediaControlElements.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::getMediaUIPartStateFlags):

New, return wkDrawMediaUIPart flags.

(WebCore::RenderThemeMac::paintMediaFullscreenButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):
(WebCore::RenderThemeMac::paintMediaSeekBackButton):
(WebCore::RenderThemeMac::paintMediaSeekForwardButton):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaSliderThumb):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaControlsBackground):
(WebCore::RenderThemeMac::paintMediaCurrentTime):
(WebCore::RenderThemeMac::paintMediaTimeRemaining):

Use getMediaUIPartStateFlags.

2009-07-10 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Update WebKitSystemInterface for <rdar://problem/7049066>.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

2009-07-10 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7049066>.
Update media tests for new SnowLeopard controller layout.

  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-styling-expected.txt:
  • platform/mac/media/video-empty-source-expected.txt:
  • platform/mac/media/video-zoom-controls-expected.txt:
19:02 Changeset [45743] by abarth@webkit.org
  • 6 edits
    7 deletes in trunk

Reverted 45741. Tests failed.

18:39 Changeset [45742] by pkasting@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2009-07-10 Peter Kasting <pkasting@google.com>

https://bugs.webkit.org/show_bug.cgi?id=19562
Disable a failing layout test caused by the patch for this bug until
I have time to determine that the obvious fix is correct.

  • fast/dom/domListEnumeration.html: Removed.
  • fast/dom/domListEnumeration.html-disabled: Copied from LayoutTests/fast/dom/domListEnumeration.html.
18:31 Changeset [45741] by abarth@webkit.org
  • 6 edits
    7 adds in trunk

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27151


Fixes issue where JavaScript URLs that contain null- and non-null control characters can
bypass XSSAuditor.

Tests: http/tests/security/xssAuditor/javascript-link-control-char.html

http/tests/security/xssAuditor/javascript-link-null-char.html
http/tests/security/xssAuditor/javascript-link.html

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): Separated out logic for JavaScript URLs from inline scripts. For JavaScript URLs, calls XSSAuditor::canEvaluateJavaScriptURL.
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): Made similar changes to evaluate() as in bindings/js/ScriptController.cpp.
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Separated out logic for JavaScript URLs into its own method.
  • page/XSSAuditor.h:

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27151

Tests prevention of JavaScript URLs that contain null- and non-null control characters.

  • http/tests/security/xssAuditor/javascript-link-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-control-char.html: Added.
  • http/tests/security/xssAuditor/javascript-link-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-null-char.html: Added.
  • http/tests/security/xssAuditor/javascript-link.html: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Added.
18:21 Changeset [45740] by abarth@webkit.org
  • 4 edits in trunk/WebKit

WebKit/mac:

2009-07-10 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig with the power of Grayskull.

Enable XSSAuditor by default.

  • WebView/WebPreferences.mm: (+[WebPreferences initialize]):

WebKit/win:

2009-07-10 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig with the power of Grayskull.

Enable XSSAuditor by default.

  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):
17:57 Changeset [45739] by pkasting@chromium.org
  • 17 edits
    5 adds in trunk

WebCore:

2009-07-10 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=19562
Added build stuff and stub for the ValidityState class, part of HTML5
section Forms:
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#validitystate

Test: fast/forms/ValidityState-001.html

  • DerivedSources.cpp: Fix aimed to include ValidityState files
  • DerivedSources.make: ditto
  • GNUmakefile.am: ditto
  • WebCore.gypi: ditto
  • WebCore.pro: ditto
  • WebCore.vcproj/WebCore.vcproj: ditto
  • WebCore.xcodeproj/project.pbxproj: ditto
  • WebCoreSources.bkl: ditto
  • html/HTMLButtonElement.idl: "validity" attribute
  • html/HTMLFieldSetElement.idl: ditto
  • html/HTMLFormControlElement.cpp: object getter (WebCore::HTMLFormControlElement::validity):
  • html/HTMLFormControlElement.h: ditto
  • html/HTMLInputElement.idl: "validity" attribute
  • html/HTMLSelectElement.idl: ditto
  • html/HTMLTextAreaElement.idl: ditto
  • html/ValidityState.cpp: Added. (WebCore::ValidityState::ValidityState): (WebCore::ValidityState::valid): validation flag
  • html/ValidityState.h: Added. (WebCore::ValidityState::create): creation routine (WebCore::ValidityState::control): ValidityState's parent getter (WebCore::ValidityState::valueMissing): validation flag (WebCore::ValidityState::typeMismatch): ditto (WebCore::ValidityState::patternMismatch): ditto (WebCore::ValidityState::tooLong): ditto (WebCore::ValidityState::rangeUnderflow): ditto (WebCore::ValidityState::rangeOverflow): ditto (WebCore::ValidityState::stepMismatch): ditto (WebCore::ValidityState::customError): ditto
  • html/ValidityState.idl: Added.

LayoutTests:

2009-07-10 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=19562
Minimal test case for ValidityState; more tests are going to be added
along with specific validation routines.

  • fast/forms/ValidityState-001-expected.txt: Added.
  • fast/forms/ValidityState-001.html: Added.
16:55 Changeset [45738] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

16:54 Changeset [45737] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.4

New tag.

16:21 Changeset [45736] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Second part of the "make Windows happier" dance.

16:15 Changeset [45735] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Try and make the Windows build happy.

16:01 Changeset [45734] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-07-10 Brady Eidson <beidson@apple.com>

Style cleanup over my last patch.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::~XMLHttpRequest):
16:00 Changeset [45733] by kmccullough@apple.com
  • 7 edits in trunk

JavaScriptCore:

2009-07-10 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoffrey Garen.

  • debugger/Debugger.h: Made this function virtual for use in WebCore's WebInspector.

WebCore:

2009-07-10 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoffrey Garen.

  • inspector/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::dynamicGlobalObject):
  • inspector/JavaScriptCallFrame.h: New helper method, used below.
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::detach): In the special case where we detach from a window currently executing JavaScript, manually tear down our representation of the JavaScript call stack, since we won't get any more callbacks from JavaScriptCore to automatically tear it down. It's too bad that WebCore is responsible for this kind of tracking -- in the future, it would be nice if more of the breakpoint handling was inside of JavaScriptCore.
15:57 Changeset [45732] by beidson@apple.com
  • 5 edits in trunk/WebCore

2009-07-10 Brady Eidson <beidson@apple.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=26496 and <rdar://problem/7046520>
REGRESSION: XHR stream connection blocks iFrame loading and resource downloading

With this test we ended up going over the maximum-connections-per-host limit that CFNetwork expected.
When that happened, the first request that was over the limit ended up in a bizarre state where it
wasn't fully serviced until after the long running XHR was complete.

Loader and Loader::Host work together to try to not exceed the max-connection limit but non-cache
resources - such as XHR - could still end up causing this limit to be exceeded.

This fix adds a workaround specifically for XHR while we hash out a more thorough solution that will
handle this at the resource handle level.

  • loader/loader.cpp: (WebCore::Loader::nonCacheRequestInFlight): (WebCore::Loader::nonCacheRequestComplete): (WebCore::Loader::Host::Host): (WebCore::Loader::Host::nonCacheRequestInFlight): (WebCore::Loader::Host::nonCacheRequestComplete): (WebCore::Loader::Host::servePendingRequests): Take nonCacheRequestsInFlight into account.
  • loader/loader.h: (WebCore::Loader::Host::processingResource): Take nonCacheRequestsInFlight into account.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::loadRequestAsynchronously): Bump the nonCacheRequestInFlight count. (WebCore::XMLHttpRequest::didFail): Decrement that count if the Loader was notified. (WebCore::XMLHttpRequest::didFinishLoading): Ditto.
15:09 Changeset [45731] by yael.aharon@nokia.com
  • 5 edits in trunk/WebKit/qt

2009-07-10 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=27136

Fix a bug where webkit hangs when executing infinite JavaScript loop.

  • Api/qwebpage.cpp:
  • Api/qwebpage.h:
  • WebCoreSupport/ChromeClientQt.cpp:
  • tests/qwebpage/tst_qwebpage.cpp:
14:53 Changeset [45730] by bfulgham@webkit.org
  • 4 edits in trunk

2009-07-10 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

ParserArenaDeletable should override delete
https://bugs.webkit.org/show_bug.cgi?id=26790

ParserArenaDeletable overrides new, but it does not override delete.
ParserArenaDeletable must be freed by fastFree
because it is allocated by fastMalloc.

  • parser/NodeConstructors.h: (JSC::ParserArenaDeletable::operator delete):
  • parser/Nodes.h:
14:31 Changeset [45729] by antti@apple.com
  • 2 edits in trunk/WebCore

2009-07-10 Antti Koivisto <antti@apple.com>

Try to unbreak non-Mac build.

  • page/ChromeClient.h: (WebCore::ChromeClient::formDidFocus): (WebCore::ChromeClient::formDidBlur):
14:28 Changeset [45728] by bdakin@apple.com
  • 2 edits in trunk/WebCore

2009-07-10 Beth Dakin <bdakin@apple.com>

Reviewed by Anders Carlsson.

The rest of the fix for <rdar://problem/7038831> REGRESSION (TOT):
In Mail, a crash occurs at WebCore::Widget::afterMouseDown() after
clicking To Do's close box

Make the Widget* in passMouseDownEventToWidget() a RefPtr.

  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseDownEventToWidget):
14:19 Changeset [45727] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-10 Simon Hausmann <hausmann@webkit.org>

No Review, just re-ordering Qt DRT skip list.

Moved skipped crash tests to the crash section.

  • platform/qt/Skipped:
14:10 Changeset [45726] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/27117> bugzilla-tool: use Mac OS X keychain for authentication

Reviewed by Eric Seidel.

Try reading credentials from git config first, then keychain if
running on Mac OS X, else prompt at the command-line.

  • Scripts/modules/bugzilla.py: Added "import platform". (credentials_from_git): Added. (credentials_from_keychain): Added. (is_mac_os_x): Added. (read_credentials): Added. (Bugzilla.init): Moved instance attribute bug_server to a static attribute named bug-server_url. (Bugzilla.bug_server_host): Added. Extracted host name from bug_server_url. (Bugzilla.bug_server_regex): Updated to be created using bug_server_host. (Bugzilla.bug_server_url): Renamed from bug_server. (Bugzilla.bug_url_for_bug_id): Updated for renaming of bug_server to bug_server_url. (Bugzilla.attachment_url_for_id): Ditto. (Bugzilla.fetch_bug_ids_from_commit_queue): Ditto. (Bugzilla.authenticate): Ditto. Updated to use read_credentials(). (Bugzilla.add_patch_to_bug): Ditto.
14:02 Changeset [45725] by ddkilzer@apple.com
  • 4 edits
    1 add in trunk/WebKitTools

<http://webkit.org/b/27115> bugzilla-tool: extract duplicate logging methods into a module

Reviewed by Adam Roben.

  • Scripts/bugzilla-tool: Removed error() and log() methods and added import of new logging module.
  • Scripts/modules/bugzilla.py: Ditto. Removed "import sys".
  • Scripts/modules/scm.py: Ditto.
  • Scripts/modules/logging.py: Added. (log): Added. (error): Added. Prefix error messages with "ERROR: ".
13:53 Changeset [45724] by eric@webkit.org
  • 8 edits in trunk/WebCore

2009-07-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

rename getDOMStructure calls w/o JSGlobalObject* to deprecatedGetDOMStructure
https://bugs.webkit.org/show_bug.cgi?id=27157

This is the first step to fixing
https://bugs.webkit.org/show_bug.cgi?id=27088

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.h: (WebCore::deprecatedGetDOMStructure): (WebCore::createDOMObjectWrapper): (WebCore::createDOMNodeWrapper):
  • bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
  • bindings/js/JSRGBColor.cpp: (WebCore::JSRGBColor::JSRGBColor):
  • bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
  • bridge/runtime_array.cpp: (JSC::RuntimeArray::RuntimeArray):
  • bridge/runtime_method.cpp: (JSC::RuntimeMethod::RuntimeMethod):
  • bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::RuntimeObjectImp):
13:32 Changeset [45723] by bolsinga@apple.com
  • 9 edits in trunk

WebCore:

2009-07-10 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Antti Koivisto.

Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153

Call the appropriate new ChromeClient methods for focus and blur.

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::dispatchFocusEvent): (WebCore::HTMLFormControlElement::dispatchBlurEvent):
  • html/HTMLFormControlElement.h:
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::formDidFocus): (WebCore::EmptyChromeClient::formDidBlur):
  • page/ChromeClient.h:

WebKit/mac:

2009-07-10 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Antti Koivisto.

Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153

Call the appropriate private delegate methods from the ChromeClient.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::formStateDidChange): (WebChromeClient::formDidFocus): (WebChromeClient::formDidBlur):
  • WebView/WebUIDelegatePrivate.h:
13:26 Changeset [45722] by dglazkov@chromium.org
  • 3 edits in trunk/LayoutTests

2009-07-10 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Adler.

Changing the test string from a platform-dependent file:/// to a more
generic http://.

https://bugs.webkit.org/show_bug.cgi?id=27138

  • fast/dom/anchor-toString-expected.txt:
  • fast/dom/anchor-toString.html:
13:25 Changeset [45721] by sfalken@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7048741> REGRESSION: Error about missing SwMenuX.dll opening pages with Shockwave


Use altered search path while loading plug-ins. This modifies the DLL search order
to look in the directory containing the plug-in even if a call to SetDllDirectory
was previously made. Use of SetDllDirectory removes the current directory from the search path,
breaking the previous strategy for locating any dependent DLLs of the plug-in.


Reviewed by Jon Honeycutt.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load): Use LoadLibraryEx with LOAD_WITH_ALTERED_SEARCH_PATH
13:15 Changeset [45720] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-10 Simon Hausmann <hausmann@webkit.org>

No Review, just skipping a new test for Qt DRT.

Skip fast/forms/slider-delete-while-dragging-thumb.html due to missing eventSender
bits & pieces.

  • platform/qt/Skipped:
12:19 Changeset [45719] by aroben@apple.com
  • 16 edits in trunk

Sort all our Xcode projects

Accomplished using sort-Xcode-project-file.

Requested by Dave Kilzer.

JavaScriptCore:

JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKitExamplePlugins:

  • NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj:
  • NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj:
  • NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj/project.pbxproj:

WebKitTools:

  • DrawTest/DrawTest.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
12:18 Changeset [45718] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Print prepare-ChangeLog's reminders to STDERR so they don't end up in the diff output

Fixes REGRESSION (r45647): prepare-ChangeLog -d puts non-diff lines
into the diff
<https://bugs.webkit.org/show_bug.cgi?id=27150>

Reviewed by Maciej Stachowiak.

  • Scripts/prepare-ChangeLog:
12:18 Changeset [45717] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Use case-insensitive comparisons when sorting Xcode project files

This matches the sorting used in Xcode's files list.

Fixes Bug 27079: sort-Xcode-project-file should sort
case-insensitively, to match Xcode's files list
<https://bugs.webkit.org/show_bug.cgi?id=27079>

Reviewed by Dave Kilzer.

  • Scripts/sort-Xcode-project-file: (sortChildrenByFileName): (sortFilesByFileName): Lowercase the strings before comparing them so that the comparison will be case-insensitive.
12:10 Changeset [45716] by agl@chromium.org
  • 2 edits in trunk/WebCore

2009-07-10 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: use disabled images for disabled widgets.

https://bugs.webkit.org/show_bug.cgi?id=27106

Previously, checkboxes and radio controls rendered the same even if disabled.
The Chromium side of this change is r20224.

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::paintRadio):
11:54 Changeset [45715] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-07-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by John Sullivan.

Fix crash when changing the zoom level in http://iphone.akamai.com/
<rdar://problem/7029077>

RenderLayerBacking's paintIntoLayer() method called updateLayerListsIfNeeded(),
which could potentially destroy that compositing layer, causing a crash.
Prevent this from happening by not doing a compositing update from paintIntoLayer().

The existing updateLayerListsIfNeeded() was renamed to updateCompositingAndLayerListsIfNeeded(),
and still does the compositing update. The new updateLayerListsIfNeeded() does not touch
compositing layers, and is still called from paintIntoLayer().

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::updateLayerListsIfNeeded): (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
  • rendering/RenderLayer.h:
11:46 Changeset [45714] by dimich@chromium.org
  • 11 edits in trunk/WebCore

2009-07-10 Drew Wilson <atwilson@google.com>

Reviewed by Darin Adler.

Need to remove UsesManualToJSImplementation() in favor of CustomToJS.
https://bugs.webkit.org/show_bug.cgi?id=27010

Added support for CustomToJS IDL attribute to replace the hard-coded class list in UsesManualToJSImplementation().

This is just a cleanup of existing functionality, so existing LayoutTests adequately cover this patch.

  • bindings/scripts/CodeGeneratorJS.pm: Removed UsesManualToJSImplementation(), added support for CustomToJS attribute.
  • css/CSSRule.idl:
  • css/CSSValue.idl:
  • css/StyleSheet.idl:
  • dom/Document.idl:
  • dom/Event.idl:
  • dom/Node.idl:
  • html/ImageData.idl:
  • svg/SVGElementInstance.idl:
  • svg/SVGPathSeg.idl: Added CustomToJS attribute to all the above IDL files.
10:45 Changeset [45713] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • fix the build by reverting the ill-advised r45711
  • page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor):
10:41 Changeset [45712] by bweinstein@apple.com
  • 4 edits in trunk

2009-07-09 Brian Weinstein <bweinstein@apple.com>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=27141


Updated WebInspectorClient to use Web Inspector Preferences to remember whether or not it should be
docked or a free window instead of NSUserDefaults it used to have.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]):

2009-07-09 Brian Weinstein <bweinstein@apple.com>

Reviewed by Tim Hatcher.

Updated WebCore.base.exp to add some needed functions.

  • WebCore.base.exp:
09:56 Changeset [45711] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • address a review comment from Simon Fraser which I forgot to include in the last check-in
  • page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor): Pass true to getRect() for maximum transform friendliness!
09:54 Changeset [45710] by mitz@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Simon Fraser.

Test: fast/loader/goto-anchor-infinite-layout.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Moved the code to update layout, find the renderer to scroll to, and scroll from here to methods on FrameView, and replaced it with a call to FrameView::maintainScrollPositionAtAnchor(). (WebCore::FrameLoader::completed): Call maintainScrollPositionAtAnchor() instead of setLockedToAnchor().
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): Removed initialization of m_lockedToAnchor. (WebCore::FrameView::reset): Reset m_maintainScrollPositionAnchor instead of m_lockedToAnchor. (WebCore::FrameView::layout): Removed the code related to scrolling to the anchor from here, because scrolling can trigger events which invalidate the layout, and as such, belongs with the post-layout tasks. (WebCore::FrameView::maintainScrollPositionAtAnchor): Added. When called with a node scrolls the view to the top of that node and maintains it scrolled to the top of the node during subsequent layouts, until this function is called with 0 or other things trigger scrolling. (WebCore::FrameView::scrollRectIntoViewRecursively): Reset m_maintainScrollPositionAnchor. (WebCore::FrameView::setScrollPosition): Ditto. (WebCore::FrameView::scrollToAnchor): Added. Scrolls to the top of m_maintainScrollPositionAnchor, if it is set. (WebCore::FrameView::performPostLayoutTasks): Call scrollToAnchor(). (WebCore::FrameView::setWasScrolledByUser): Reset m_maintainScrollPositionAnchor.
  • page/FrameView.h: Removed lockedToAnchor(), setLockedToAnchor(), and m_lockedToAnchor. Added maintainScrollPositionAtAnchor() and m_maintainScrollPositionAnchor.

LayoutTests:

Reviewed by Simon Fraser.

  • fast/loader/goto-anchor-infinite-layout-expected.txt: Added.
  • fast/loader/goto-anchor-infinite-layout.html: Added.
08:39 Changeset [45709] by hausmann@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2009-07-09 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger Freyther.

Re-enabled dom/xhtml/level2/html/HTMLBaseElement0{1,2} for the Qt DRT,
as there's now a cross-platform result and it passes.

  • platform/qt/Skipped:
  • platform/qt/dom/xhtml/level2/html/HTMLBaseElement01-expected.txt: Removed.
  • platform/qt/dom/xhtml/level2/html/HTMLBaseElement02-expected.txt: Removed.
08:30 Changeset [45708] by hausmann@webkit.org
  • 7 edits in trunk

WebKit/qt:

2009-07-10 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=27108

Fix crash when in frame tree of a new frame before the new frame
has been installed in the frame tree, similar to r35088.

After calling Frame::init() the frame it may have been removed from the
frame tree again through JavaScript. Detect this by checking the page()
afterwards.

To make this check safe the Frame::init() code was moved into
QWebFrameData's constructor, where a RefPtr holds a reference to the frame.
After the check back in FrameLoaderClientQt we would hold the single
reference left and after release() the frame, its frame loader, its
client as well as the QWebFrame should have disappeared then.

  • Api/qwebframe.cpp: (QWebFramePrivate::init): Only call Frame::init here, the rest is done in QWebFrameData's constructor. (QWebFrame::QWebFrame):
  • Api/qwebframe_p.h: Adjust declaration. (QWebFrameData::QWebFrameData): Create the Frame here.
  • Api/qwebpage.cpp: (QWebPagePrivate::createMainFrame): Adjust and simplify to new QWebFrame constructor.
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame): Adjust to new QWebFrame construction using QWebFrameData and add the check like in r35088.

LayoutTests:

2009-07-08 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=27108

Remove fast/loader/frame-creation-removal.html from the skip list, it
passes now.

  • platform/qt/Skipped:
06:25 Changeset [45707] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-04 Sriram Yadavalli <sriram.yadavalli@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=26439

QtWebKit fails in loading www.nytimes.com in Windows/Linux

QNetworkReplyHandler is ignoring content associated with 401 error.
This causes the XHR response handling to fail.

Simon: Added also ProxyAuthenticationRequiredError, to handle the same
case when going through proxies, as suggested by Prasanth.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
05:47 Changeset [45706] by hausmann@webkit.org
  • 6 edits in trunk

WebKitTools:

2009-07-08 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=27109

Fix side-effects in the Qt DRT with tests using application fonts.

Detect if a test used application fonts and re-initialize the fontconfig
application fontset accordingly.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open): call initializeFonts and remove all application fonts after running a testcase. (WebCore::DumpRenderTree::initializeFonts): Moved fontconfig initialization code here from main.
  • DumpRenderTree/qt/DumpRenderTree.h: Declare initializeFonts.
  • DumpRenderTree/qt/main.cpp: (main): Moved fontconfig initialization code to DRT::initializeFonts.

LayoutTests:

2009-07-08 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=27109

Remove various tests from the Qt skip list that previously failed
due to DRT side-effects.

  • platform/qt/Skipped:
04:33 Changeset [45705] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-10 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

[QT] [ARM] Add pkg-config entry for FontConfig on DRT.pro
https://bugs.webkit.org/show_bug.cgi?id=26990

Missing pkg-config entry for FontConfig in DRT.pro causes some compilers to
not link fine against FontConfig bits.

  • DumpRenderTree/qt/DumpRenderTree.pro:
04:20 Changeset [45704] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-10 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

Enable HTML 5 Messaging to fix message channel Qt DRT failures in
fast/events.

  • WebCore.pro:
04:15 Changeset [45703] by hausmann@webkit.org
  • 2 edits in trunk

2009-07-07 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Exclude DumpRenderTree.pro from symbian build

  • WebKit.pro:

07/09/09:

22:26 Changeset [45702] by bfulgham@webkit.org
  • 6 edits in trunk/WebCore

2009-07-09 Roland Steiner <rolandsteiner@google.com>

Reviewed by Maciej Stachowiak.

added InlineBox::isLeaf()
firstLeafChild()/lastLeafChild() not virtual and not callable on InlineBox anymore.
firstLeafChild()/lastLeafChild() will no longer return a node outside of the given subtree.
Removed firstLeafChildAfterBox()/lastLeafChildBeforeBox()
Removed potentially quadratic behavior if all nodes before/after a given box are empty InlineFlowBoxes

Currently, these methods are called on RootInlineBox objects only, so above changes should not have
any observable effect (only the removal of the square performance behavior could apply,
but the conditions for that are probably of a rather theoretical nature).

  • rendering/InlineBox.cpp: (WebCore::InlineBox::nextLeafChild): (WebCore::InlineBox::prevLeafChild):
  • rendering/InlineBox.h: (WebCore::InlineBox::isLeaf):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::firstLeafChild): (WebCore::InlineFlowBox::lastLeafChild):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::firstChild): (WebCore::InlineFlowBox::lastChild): (WebCore::InlineFlowBox::isLeaf):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::closestLeafChildForXPos):
22:12 Changeset [45701] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

2009-07-09 Roland Steiner <rolandsteiner@google.com>

Reviewed by Maciej Stachowiak.

Added InlineBox::baselinePosition() and lineHeight() methods
(adapted remaining code accordingly to use those methods)

No change in functionality.

  • rendering/InlineBox.h: (WebCore::InlineBox::baselinePosition): (WebCore::InlineBox::lineHeight):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::adjustMaxAscentAndDescent): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically):
22:10 Changeset [45700] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-07-09 Maciej Stachowiak <mjs@apple.com>

Not reviewed, build fix.

Windows build fix for the last change.

  • wtf/dtoa.cpp: Forgot to include Vector.h
22:01 Changeset [45699] by oliver@apple.com
  • 5 edits in trunk

Bug 27142 - canPlayType() should return empty string for unsupported content
<https://bugs.webkit.org/show_bug.cgi?id=27142>

Reviewed by Maciej Stachowiak

Return "" instead of "no" for unsupport media types.

21:42 Changeset [45698] by bfulgham@webkit.org
  • 8 edits
    3 adds in trunk

WebCore:

2009-07-09 Roland Steiner <rolandsteiner@google.com>

Reviewed by Maciej Stachowiak.

Implement the part of HTML5 spec that deals with parsing of <rp> and <rt> tags
in that their end tags are optional if followed by <rp>/<rt>.

Also specify a new accessibility role "annotation" for <rp> and <rt>.

Affected code parts are not enclosed in #IF ENABLE(RUBY), since the parsing
is not affected by whether ruby is rendered properly or not (in fact, it may
be more profound without ruby layouting, since the contents of <rp> are not hidden).

Test: fast/ruby/parse-rp.html

  • accessibility/AccessibilityObject.h: (WebCore::):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::roleValue):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::endTagRequirement): (WebCore::HTMLElement::tagPriority): (WebCore::inlineTagList):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::rpCreateErrorCheck): (WebCore::HTMLParser::rtCreateErrorCheck): (WebCore::HTMLParser::getNode):
  • html/HTMLParser.h:
  • html/HTMLTagNames.in:

LayoutTests:

2009-07-09 Roland Steiner <rolandsteiner@google.com>

Reviewed by Maciej Stachowiak.

Test proper parsing of HTML5 <rp> and <rt> tags.
Both tags are optional if followed by another <rp>/<rt> tag.


See also https://bugs.webkit.org/show_bug.cgi?id=26985

  • fast/ruby: Added.
  • fast/ruby/parse-rp-expected.txt: Added.
  • fast/ruby/parse-rp.html: Added.
21:29 Changeset [45697] by dimich@chromium.org
  • 5 edits in trunk/WebCore

2009-07-09 Dmitry Titov <dimich@chromium.org>

Not reviewed, fix for previous commit.

The change http://trac.webkit.org/changeset/45695 did not correctly
enabled GTL and QT build flags. This caused layout tests failure.
This is speculative fix for those failures.

  • GNUmakefile.am: added ENABLE_CHANNEL_MESSAGING flag.
  • WebCore.pro: ditto.
  • page/DOMWindow.idl: touched to cause recompile.
  • workers/WorkerContext.idl: ditto.
20:45 Changeset [45696] by mjs@apple.com
  • 3 edits
    7 adds in trunk

2009-07-09 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

REGRESSION: crash in edge cases of floating point parsing.
https://bugs.webkit.org/show_bug.cgi?id=27110
<rdar://problem/7044458>


Tests: fast/css/number-parsing-crash.html

fast/css/number-parsing-crash.html
fast/js/number-parsing-crash.html


  • wtf/dtoa.cpp: (WTF::BigInt::BigInt): Converted this to more a proper class, using a Vector with inline capacity

(WTF::lshift): Rearranged logic somewhat nontrivially to deal with the new way of sizing BigInts.
Added an assertion to verify that invariants are maintained.

All other functions are adapted fairly mechanically to the above changes.
(WTF::BigInt::clear):
(WTF::BigInt::size):
(WTF::BigInt::resize):
(WTF::BigInt::words):
(WTF::BigInt::append):
(WTF::multadd):
(WTF::s2b):
(WTF::i2b):
(WTF::mult):
(WTF::cmp):
(WTF::diff):
(WTF::b2d):
(WTF::d2b):
(WTF::ratio):
(WTF::strtod):
(WTF::quorem):
(WTF::dtoa):

2009-07-09 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.


REGRESSION: crash in edge cases of floating point parsing.
<rdar://problem/7044458>
https://bugs.webkit.org/show_bug.cgi?id=27110


Test cases for both JavaScript and CSS use of dtoa.

  • fast/css/number-parsing-crash-2-expected.txt: Added.
  • fast/css/number-parsing-crash-2.html: Added.
  • fast/css/number-parsing-crash-expected.txt: Added.
  • fast/css/number-parsing-crash.html: Added.
  • fast/js/number-parsing-crash-expected.txt: Added.
  • fast/js/number-parsing-crash.html: Added.
  • fast/js/resources/number-parsing-crash.js: Added.
20:20 Changeset [45695] by dimich@chromium.org
  • 22 edits
    16 moves in trunk

2009-07-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.

  • configure.ac: enable CHANNEL_MESSAGING.

JavaScriptCore:

2009-07-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.

  • Configurations/FeatureDefines.xcconfig:

WebCore:

2009-07-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
is now implemented for Web Workers and is reasonably stable.

Tests: fast/events/message-channel-gc-2.html

fast/events/message-channel-gc-3.html
fast/events/message-channel-gc-4.html
fast/events/message-channel-gc.html
fast/events/message-channel-listener-circular-ownership.html
fast/events/message-port-clone.html
fast/events/message-port-constructor-for-deleted-document.html
fast/events/message-port-deleted-document.html
fast/events/message-port-deleted-frame.html
fast/events/message-port-inactive-document.html
fast/events/message-port-no-wrapper.html
fast/events/message-port.html
fast/workers/worker-cloneport.html
fast/workers/worker-messageport-gc.html
fast/workers/worker-messageport.html

  • Configurations/FeatureDefines.xcconfig: Turned on ENABLE_CHANNEL_MESSAGING.
  • WebCore/WebCore.vcproj/WebCoreCommon.vsprops: ditto.
  • WebCore/WebCore.vcproj/build-generated-files.sh: ditto.
  • WebCore/page/DOMWindow.idl: touch the file to cause re-generation of headers.
  • WebCore/workers/WorkerContext.idl: ditto.

WebKit/mac:

2009-07-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.

  • Configurations/FeatureDefines.xcconfig:

WebKit/win:

2009-07-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.

  • WebKit.vcproj/WebKit.vcproj:

WebKitTools:

2009-07-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.

  • Scripts/build-webkit:

LayoutTests:

2009-07-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default, re-enabled the various tests, and updated expected results.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/constructors-cached-navigate-expected.txt:
  • fast/events/message-channel-gc-2.html: Renamed from LayoutTests/fast/events/message-channel-gc-2.html-disabled.
  • fast/events/message-channel-gc-3.html: Renamed from LayoutTests/fast/events/message-channel-gc-3.html-disabled.
  • fast/events/message-channel-gc-4.html: Renamed from LayoutTests/fast/events/message-channel-gc-4.html-disabled.
  • fast/events/message-channel-gc.html: Renamed from LayoutTests/fast/events/message-channel-gc.html-disabled.
  • fast/events/message-channel-listener-circular-ownership.html: Renamed from LayoutTests/fast/events/message-channel-listener-circular-ownership.html-disabled.
  • fast/events/message-port-clone.html: Renamed from LayoutTests/fast/events/message-port-clone.html-disabled.
  • fast/events/message-port-constructor-for-deleted-document.html: Renamed from LayoutTests/fast/events/message-port-constructor-for-deleted-document.html-disabled.
  • fast/events/message-port-deleted-document.html: Renamed from LayoutTests/fast/events/message-port-deleted-document.html-disabled.
  • fast/events/message-port-deleted-frame.html: Renamed from LayoutTests/fast/events/message-port-deleted-frame.html-disabled.
  • fast/events/message-port-inactive-document.html: Renamed from LayoutTests/fast/events/message-port-inactive-document.html-disabled.
  • fast/events/message-port-no-wrapper.html: Renamed from LayoutTests/fast/events/message-port-no-wrapper.html-disabled.
  • fast/events/message-port.html: Renamed from LayoutTests/fast/events/message-port.html-disabled.
  • fast/js/global-constructors-expected.txt:
  • fast/workers/worker-cloneport.html: Renamed from LayoutTests/fast/workers/worker-cloneport.html-disabled.
  • fast/workers/worker-messageport-gc.html: Renamed from LayoutTests/fast/workers/worker-messageport-gc.html-disabled.
  • fast/workers/worker-messageport.html: Renamed from LayoutTests/fast/workers/worker-messageport.html-disabled.
  • http/tests/security/MessagePort/event-listener-context.html: Renamed from LayoutTests/http/tests/security/MessagePort/event-listener-context.html-disabled
20:01 Changeset [45694] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

19:44 Changeset [45693] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 27016 - Interpreter crashes due to invalid array indexes
<https://bugs.webkit.org/show_bug.cgi?id=27016>

Reviewed by Darin Adler.

Unsigned vs signed conversions results in incorrect behaviour in
64bit interpreter builds.

19:15 Changeset [45692] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Jon Honeycutt <jhoneycutt@apple.com>

A more robust fix for <rdar://problem/6930280> Reproducible crash at
USA Today photo gallery

Reviewed by Steve Falkenburg.

  • plugins/win/PluginMessageThrottlerWin.cpp: (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired): Protect the PluginView from destruction before calling its window proc.
19:15 Changeset [45691] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Jon Honeycutt <jhoneycutt@apple.com>

<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)

Reviewed by Darin Adler.

  • plugins/PluginView.cpp: (WebCore::PluginView::bindingInstance): Protect the PluginView from destruction before calling NPN_GetValue. If the renderer for the PluginView was destroyed during the call, and the PluginView's ref count is now 1, return null.
19:15 Changeset [45690] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Jon Honeycutt <jhoneycutt@apple.com>

Speculative fix for <rdar://problem/6991251> WER #13: Crash in
WebKit!WebCore::PluginView::performRequest+203 (1311461169)

Reviewed by Darin Adler.

  • plugins/PluginView.cpp: (WebCore::PluginView::performRequest): Protect the PluginView from destruction before performing a load. Removed some trailing whitespace.
18:49 Changeset [45689] by bweinstein@apple.com
  • 2 edits in trunk/WebKit/win

2009-07-09 Brian Weinstein <bweinstein@apple.com>

Reviewed by Alice Liu.

Fix of <rdar://5712929> Add preferences key to remember if the Inspector was docked (14271)
https://bugs.webkit.org/show_bug.cgi?id=27140

Added a preference key to remember whether the user prefers the inspector detached or attached.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::showWindow): Pass both parameters into setWindowVisible (WebInspectorClient::closeWindow): Ditto (WebInspectorClient::attachWindow): Set preference to attached windows here (WebInspectorClient::detachWindow): Set preference to detached windows here (WebInspectorClient::showWindowWithoutNotifications): Read preference for attached vs. detached (WebInspectorClient::onClose): Pass both parameters into setWindowVisible
18:19 Changeset [45688] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-07-09 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson and Dan Bernstein.

<rdar://problem/7024972> Cannot set font to Helvetica Neue Light in Mail compose window

No regression test because this only affects the font panel.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _addToStyle:fontA:fontB:]): Fix code that detects whether the font would survive a round trip by using the weight corresponding to "bold" or "normal" rather than the actual weight number.
18:04 Changeset [45687] by pdherbemont@apple.com
  • 8 edits
    1 copy
    2 deletes in trunk

WebCore:

2009-07-09 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Full page zoom breaks remaining and elapsed time display in the <video> controller.
https://bugs.webkit.org/show_bug.cgi?id=27123

We are changing the size of the time remaining and time elapsed field, to
automatically hide them, when the controller is too short.

Because we toggle the size between 0 and the previous value of the
controller, we miss any width change that may occur during full page zoom,
and we fail to restore a correct width.

This change fixes that problem by using a cloned style on which we
set the width to 0, and restoring the previous style when going back to
the normal width.

We take care about properly using the cloned style or the pseudo style,
by overriding styleForElement().

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::styleForElement): (WebCore::MediaControlElement::attach): (WebCore::MediaControlElement::updateStyle): (WebCore::MediaControlInputElement::styleForElement): (WebCore::MediaControlInputElement::attach): (WebCore::MediaControlInputElement::updateStyle): (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement): (WebCore::MediaControlTimeDisplayElement::styleForElement): (WebCore::MediaControlTimeDisplayElement::setVisible):
  • rendering/MediaControlElements.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::shouldShowTimeDisplayControls): Make sure we take in account the zoom level when deciding if we should hide the ellapsed and remaining time.

LayoutTests:

2009-07-09 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Full page zoom breaks remaining and elapsed time display in the &lt;video&gt; controller.
https://bugs.webkit.org/show_bug.cgi?id=27123

  • media/video-zoom-controls.html: Remove duplicated code.
  • platform/mac-leopard/media/video-zoom-controls-expected.txt: Copied from LayoutTests/platform/mac/media/video-zoom-controls-expected.txt.
  • platform/mac-snowleopard/Skipped:
  • platform/mac/media/video-zoom-controls-expected.checksum: Removed. The test is not reliable for pixel test.
  • platform/mac/media/video-zoom-controls-expected.png: Removed.
  • platform/mac/media/video-zoom-controls-expected.txt: Updated
18:00 Changeset [45686] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/27114> bugzilla-tool: Parse short bug URL from commit log messages

Reviewed by Adam Roben.

  • Scripts/bugzilla-tool: (bug_id_from_commit_message): Check for the short bug URL before checking for the longer bugs.webkit.org URL.
17:55 Changeset [45685] by dimich@chromium.org
  • 3 edits in trunk/WebCore

2009-07-09 Michael Nordman <michaeln@google.com>

Reviewed by Darin Adler.

Fix chromium build bustage due to Widget being a RefCounted class.
https://bugs.webkit.org/show_bug.cgi?id=27139

  • platform/chromium/PopupMenuChromium.cpp:
  • platform/chromium/PopupMenuChromium.h:
17:41 Changeset [45684] by cfleizach@apple.com
  • 4 edits
    2 adds in trunk

Bug 27130 - Need to implement ARIA role="toolbar"
https://bugs.webkit.org/show_bug.cgi?id=27130

16:26 Changeset [45683] by dglazkov@chromium.org
  • 2 edits
    2 adds in trunk

JavaScriptCore:

2009-07-09 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Upstream JavaScriptCore.gypi, the project file for Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=27135

WebCore:

2009-07-09 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Upstream WebCore.gypi, the project file for Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=27135

  • WebCore.gypi: Added.
16:03 Changeset [45682] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Jon Honeycutt <jhoneycutt@apple.com>

Build fix.

  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
15:54 Changeset [45681] by ap@webkit.org
  • 7 edits in trunk/WebKit/win

Reviewed by Oliver Hunt.

<rdar://problem/6921671> Visit count shouldn't be incremented by redirects.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Do not increase visit count if there is a redirect source. As a result, only pages that were explicitly visited by the user (by typing a URL, choosing one from bookmarks, or clicking a link) will be counted.
  • Interfaces/IWebHistoryItemPrivate.idl:
  • WebHistory.cpp: (WebHistory::visitedURL):
  • WebHistory.h:
  • WebHistoryItem.cpp: (WebHistoryItem::visitedWithTitle):
  • WebHistoryItem.h: Marshal this new argument all the way down to WebCore.
15:33 Changeset [45680] by simon.fraser@apple.com
  • 4 edits in trunk/WebCore

2009-07-09 Simon Fraser <simon.fraser@apple.com>

Build fix for SnowLeopard.

Avoid using the contentsTransform methods if not on Leopard, because
we don't need to call them.

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::updateContentsTransform):
  • platform/graphics/mac/WebLayer.mm: (-[WebLayer setNeedsDisplayInRect:]):
  • platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer setNeedsDisplayInRect:]):
15:26 Changeset [45679] by bdakin@apple.com
  • 37 edits in trunk

WebCore:

2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix or make fixable:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::createPlugin): Changed to return PassRefPtr (WebCore::EmptyFrameLoaderClient::createJavaAppletWidget): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::loadPlugin): Make the widget variable a RefPtr. Use .get() when passing it to RenderPart::setWidget(). (WebCore::FrameLoader::createJavaAppletWidget): Make the widget variable a RefPtr.
  • loader/FrameLoader.h: Changed the return type of createJavaAppletWidget().
  • loader/FrameLoaderClient.h: Change the return types of createPlugin() and createJavaAppletWidget().
  • page/Frame.cpp: (WebCore::Frame::createView): No need to call .get() since setWidget() takes a RefPtr.
  • page/FrameView.cpp: (WebCore::FrameView::layoutIfNeededRecursive): children() now returns a HashSet of RefPtrs.
  • page/FrameView.h: Remove inheritance from RefCounted; we pick this up from ScrollView through Widget.
  • platform/ScrollView.cpp: (WebCore::ScrollView::addChild): addChild() now takes a PassRefPtr and m_children now keeps a HashSet of RefPtrs.
  • platform/ScrollView.h: ScrollView constructor is now protected. (WebCore::ScrollView::children): m_children is now a HashSet of RefPtrs.
  • platform/Scrollbar.h: Remove inheritance from RefCounted; we pick this up from ScrollView through Widget.
  • platform/Widget.h: Inherit from RefCounted. Cleaned up some whitespace. Make m_widget a RefPtr.
  • plugins/PluginView.cpp: (WebCore::PluginView::create): Adopt the PluginView when returning it.
  • plugins/PluginView.h: Changed create() to return a PassRefPtr.
  • rendering/RenderApplet.cpp: Receive result in a RefPtr when calling createJavaAppletWidget().
  • rendering/RenderPart.cpp: (WebCore::RenderPart::setWidget): setWidget() now takes a PassRefPtr. Also removed the manual ref of FrameViews. This is handled by having m_widget be a RefPtr. Removed deleteWidget().
  • rendering/RenderPart.h: Removed override of deleteWidget().
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): (WebCore::RenderWidget::setWidget): (WebCore::RenderWidget::paint): (WebCore::RenderWidget::setOverlapTestResult): (WebCore::RenderWidget::updateWidgetPosition): Use .get(). (WebCore::RenderWidget::clearWidget): Don't call deleteWidget(). It was removed.
  • rendering/RenderWidget.h: Removed deleteWidget(). Made m_widget a RefPtr. (WebCore::RenderWidget::widget): Use .get().

WebKit/gtk:

2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin): (WebKit::FrameLoaderClient::createJavaAppletWidget):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):

WebKit/qt:

2009-07-09 Beth Dakin <bdakin@apple.com>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin): (WebCore::FrameLoaderClientQt::createJavaAppletWidget):
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp: (WebFrame::createJavaAppletWidget):
  • WebFrame.h:

WebKit/wx:

2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::createPlugin): (WebCore::FrameLoaderClientWx::createJavaAppletWidget):
  • WebKitSupport/FrameLoaderClientWx.h:
15:17 Changeset [45678] by weinig@apple.com
  • 25 edits in trunk/WebKit

WebKit/mac:

2009-07-09 Sam Weinig <sam@webkit.org>

Reviewed by Steve Falkenburg.

Roll out r43848. The quirk is no longer necessary.

  • WebView/WebView.mm: (-[WebView WebCore::_userAgentForURL:WebCore::]):

WebKit/win:

2009-07-09 Sam Weinig <sam@webkit.org>

Reviewed by Steve Falkenburg.

Roll out r43848. The quirk is no longer necessary.

  • WebView.cpp: (WebView::userAgentForKURL):
15:11 Changeset [45677] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

Bug 27129 - AX: possible assertion for a non-native image in accessibility
https://bugs.webkit.org/show_bug.cgi?id=27129

14:57 Changeset [45676] by simon.fraser@apple.com
  • 8 edits in trunk/WebCore

2009-07-09 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

Improve the appearance of text in compositing layers when -[CALayer geometryFlipped]
is not available.
<rdar://problem/6120614>

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsOrientation): (WebCore::GraphicsLayer::contentsOrientation):
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer): Add a m_contentsOrientation member and getter/setter to control whether the contents of this layer have a transform applied to them before display.
  • platform/graphics/mac/GraphicsLayerCA.h: New method to return the default contents orientation.
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::flipTransform): Convenience method to return a transform with a Y flip.

(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setSize):
After the size changes we have to update the contentsTransform.

(WebCore::GraphicsLayerCA::setGeometryOrientation):
(WebCore::GraphicsLayerCA::geometryOrientation):
If -setGeometryFlipped: is not available, use a children transform.

(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
Tiled layers have issues with flipped contentsTransform, so just use
top-down drawing for them. Call updateContentsTransform() to set the
new contents transform after swapping layers.

(WebCore::GraphicsLayerCA::defaultContentsOrientation):
Use bottom-up when -geometryFlipped is not available, otherwise top-down.

(WebCore::GraphicsLayerCA::updateContentsTransform):
Set the layer contents transform based on contentsOrientation().

(WebCore::GraphicsLayerCA::setContentsLayer):
We have to manually flip contents layers if we're not using -geometryFlipped.

  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm: Do early return if layerContents is nil. Flip the CTM if the layer has bottom-up coordinates, so that CG sees a CTM with no flip. Do the CGContextRestoreGState() after drawing the debug indicator.

(-[WebLayer setNeedsDisplayInRect:]):

  • platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer setNeedsDisplayInRect:]): Need to map the dirty rect through the contentsTransform.
14:53 Changeset [45675] by ap@webkit.org
  • 10 edits in trunk

Reviewed by Geoff Garen.

<rdar://problem/6921671> Visit counter shouldn't be incremented by redirects.

Can't test this functionality with layout tests.

WebCore:

  • WebCore.base.exp:
  • history/HistoryItem.cpp: (WebCore::HistoryItem::recordVisitAtTime): (WebCore::HistoryItem::visited):
  • history/HistoryItem.h: Only increase visit count if explicitly told to. Now, some visits change last access time, but do not increase visit count.

WebKit:

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Do not increase visit count if there is a redirect source. As a result, only pages that were explicitly visited by the user (by typing a URL, choosing one from bookmarks, or clicking a link) will be counted.
  • History/WebHistory.mm: (-[WebHistoryPrivate visitedURL:withTitle:increaseVisitCount:]): (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
  • History/WebHistoryInternal.h:
  • History/WebHistoryItem.mm: (-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]):
  • History/WebHistoryItemInternal.h: Marshal this new argument all the way down to WebCore.
14:47 Changeset [45674] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7046098> MediaControllerThemeQT requires QuickTime 7.6.3

Require QuickTime 7.6.3 or higher to enable the new media controller UI.

  • rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):
13:57 Changeset [45673] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Sam Weinig <sam@webkit.org>

Reviewed by Beth Dakin.

Remove incorrect comment.

  • page/MouseEventWithHitTestResults.h:
13:49 Changeset [45672] by mrowe@apple.com
  • 1 edit in tags/Safari-6531.3/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Versioning.

13:42 Changeset [45671] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

13:40 Changeset [45670] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.3

New tag.

13:00 Changeset [45669] by ddkilzer@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-07-09 Joe Mason <joe.mason@torchmobile.com>

Reviewed by George Staikos.

Authors: Yong Li <yong.li@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>

https://bugs.webkit.org/show_bug.cgi?id=27031
Add an override for deleteOwnedPtr(HDC) on Windows

  • wtf/OwnPtrCommon.h:
  • wtf/OwnPtrWin.cpp: (WTF::deleteOwnedPtr):
12:20 Changeset [45668] by oliver@apple.com
  • 2 edits in trunk/WebKitSite

JavaScript section of http://webkit.org is excessively out of date.

Reviewed by Geoff Garen.

This removes old todo entries (like adding an API, which we've had since Leopard),
and adds an additional todo for a webkit-less Objective-C API.

12:11 Changeset [45667] by ddkilzer@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-07-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

Guard singal.h dependency with HAVE(SIGNAL_H) to enable building jsc
on SYMBIAN.

https://bugs.webkit.org/show_bug.cgi?id=27026

Based on Norbert Leser's work.

  • jsc.cpp: (printUsageStatement): (parseArguments):
  • wtf/Platform.h:
11:18 Changeset [45666] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2009-07-09 Mads Ager <ager@chromium.org>

Reviewed by Dimitri Glazkov.

Update the V8 bindings codegenerator to use the RGBColor::create
method to handle refcounts for RGBColor objects correctly.


  • bindings/scripts/CodeGeneratorV8.pm: Use RGBColor::create to create RGBColor objects.
10:41 Changeset [45665] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

Crash in RenderMedia::styleDidChange.
<rdar://problem/7044313> CrashTracer: quicklook crashed generating thumbnail for page with
media element (RenderMedia::styleDidChange + 115)

Speculative fix for crash in styleDidChange. Null check controller elements before tell
them to update style.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange):
10:37 Changeset [45664] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

2009-07-09 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Move V8DOMWrapper to its own file
https://bugs.webkit.org/show_bug.cgi?id=27121

  • bindings/v8/V8DOMWrapper.cpp: Added. (WebCore::GetToStringName): (WebCore::ConstructorToString): (WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object): (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::domObjectHasJSWrapper): (WebCore::V8DOMWrapper::setJSWrapperForDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForDOMNode): (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::setHiddenWindowReference): (WebCore::V8DOMWrapper::domWrapperType): (WebCore::V8DOMWrapper::convertToNativeObjectImpl): (WebCore::V8DOMWrapper::convertToSVGPODTypeImpl): (WebCore::V8DOMWrapper::lookupDOMWrapper): (WebCore::V8DOMWrapper::convertDOMWrapperToNodeHelper): (WebCore::V8DOMWrapper::wrapNativeNodeFilter): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::setDOMWrapper): (WebCore::V8DOMWrapper::maybeDOMWrapper): (WebCore::V8DOMWrapper::isDOMEventWrapper): (WebCore::V8DOMWrapper::isWrapperOfType): (WebCore::V8DOMWrapper::htmlElementType): (WebCore::V8DOMWrapper::svgElementType): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::convertDOMImplementationToV8Object): (WebCore::V8DOMWrapper::convertStyleSheetToV8Object): (WebCore::V8DOMWrapper::convertCSSValueToV8Object): (WebCore::V8DOMWrapper::convertCSSRuleToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object):
  • bindings/v8/V8DOMWrapper.h: Added. (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::wrapCPointer): (WebCore::V8DOMWrapper::extractCPointer): (WebCore::V8DOMWrapper::convertDOMWrapperToNode): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertToNativeObject): (WebCore::V8DOMWrapper::convertToNativeEvent): (WebCore::V8DOMWrapper::extractCPointerImpl): (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
10:20 Changeset [45663] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 David Hyatt <hyatt@apple.com>

Reviewed by Adele Peterson.

Crash in setFocusedFrame.
<rdar://7032869> Crashing in setFocusedFrame on blogger.com.

Speculative fix for crasher in setFocusedFrame. Make sure to ref both frames and fire
the events only after the local member has been updated.

  • page/FocusController.cpp: (WebCore::FocusController::setFocusedFrame):
10:05 Changeset [45662] by eric.carlson@apple.com
  • 8 edits
    8 adds in trunk

2009-07-09 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

Possible crashes when mouse clicks not dispatched because range input destroyed while
thumb is being dragged (e.g. scrub to end of movie)
<rdar://problem/7037494>
https://bugs.webkit.org/show_bug.cgi?id=27101

Some shadow nodes "capture" all mouse events from mouseDown to mouseUp so they continue to
get mouse events even when the mouse is moved outside of the node. This is done by putting
EventHandler into a mode where it sends all mouse events to the node regardless of the
actual mouse position. The mode is set on mouseDown and cleared on mouseUp but if the
node is deleted while in this mode, the mouseUp is never sent and EventHandler continues
to try to send events to the deleted node. This sometimes results in a crash, and sometimes
in a page that doesn't respond to click events.

Tests: fast/forms/search-delete-while-cancel-button-clicked.html

fast/forms/slider-delete-while-dragging-thumb.html
media/audio-delete-while-slider-thumb-clicked.html
media/audio-delete-while-step-button-clicked.html

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlSeekButtonElement::detach):

New, call setCapturingMouseEventsNode if capturing mouse events.

  • rendering/MediaControlElements.h:

Declare detach().

  • rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::detach):

New, call setCapturingMouseEventsNode if capturing mouse events.

  • rendering/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::detach):

New, call setCapturingMouseEventsNode if capturing mouse events.

  • rendering/TextControlInnerElements.h:

Declare detach().

2009-07-09 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

Possible crashes when mouse clicks not dispatched because range input destroyed while
thumb is being dragged (e.g. scrub to end of movie)
<rdar://problem/7037494>
https://bugs.webkit.org/show_bug.cgi?id=27101

Tests deleting a control while capturing mouse events.

  • fast/forms/search-delete-while-cancel-button-clicked-expected.txt: Added.
  • fast/forms/search-delete-while-cancel-button-clicked.html: Added.
  • fast/forms/slider-delete-while-dragging-thumb-expected.txt: Added.
  • fast/forms/slider-delete-while-dragging-thumb.html: Added.
  • media/audio-delete-while-slider-thumb-clicked-expected.txt: Added.
  • media/audio-delete-while-slider-thumb-clicked.html: Added.
  • media/audio-delete-while-step-button-clicked-expected.txt: Added.
  • media/audio-delete-while-step-button-clicked.html: Added.
  • platform/mac-snowleopard/Skipped:

Skip the new media controller tests until <rdar://problem/6502936> is fixed.

08:50 Changeset [45661] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-07-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Dimitri Glazkov.

Enter the Frame's context before creating new objects in setContextDebugId.

https://bugs.webkit.org/show_bug.cgi?id=27112

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setContextDebugId):
01:58 Changeset [45660] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-09 Simon Hausmann <hausmann@webkit.org>

Fix the Qt build.

  • WebCore.pro: Add new storage impl files to the build.
00:11 Changeset [45659] by abarth@webkit.org
  • 72 edits in trunk/WebCore

2009-07-08 Adam Barth <abarth@webkit.org>

Rubber stamped by Eric Seidel.

[V8] Move DOM wrapper functions in V8Proxy to V8DOMWrapper
https://bugs.webkit.org/show_bug.cgi?id=27107

This patch is just renaming. Code motion will occur next.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::createScriptObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent): (WebCore::V8AbstractEventListener::getReceiverObject):
  • bindings/v8/V8Collection.cpp: (WebCore::toOptionsCollectionSetter):
  • bindings/v8/V8Collection.h: (WebCore::getV8Object): (WebCore::getNamedPropertyOfCollection): (WebCore::nodeCollectionNamedPropertyGetter): (WebCore::getIndexedPropertyOfCollection): (WebCore::nodeCollectionIndexedPropertyGetter): (WebCore::nodeCollectionIndexedPropertyEnumerator): (WebCore::collectionIndexedPropertyEnumerator): (WebCore::collectionStringOrNullIndexedPropertyGetter):
  • bindings/v8/V8DOMMap.cpp: (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::removeObjectsFromWrapperMap):
  • bindings/v8/V8GCController.cpp: (WebCore::enumerateDOMObjectMap): (WebCore::DOMObjectVisitor::visitDOMWrapper): (WebCore::GCPrologueVisitor::visitDOMWrapper): (WebCore::GCEpilogueVisitor::visitDOMWrapper):
  • bindings/v8/V8Helpers.cpp: (WebCore::wrapNPObject):
  • bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object): (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::domObjectHasJSWrapper): (WebCore::V8DOMWrapper::setJSWrapperForDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForDOMNode): (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::getConstructor): (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8Proxy::retrieveWindow): (WebCore::V8Proxy::updateDocumentWrapperCache): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::installDOMWindow): (WebCore::setDOMExceptionHelper): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::setHiddenWindowReference): (WebCore::V8DOMWrapper::domWrapperType): (WebCore::V8DOMWrapper::convertToNativeObjectImpl): (WebCore::V8DOMWrapper::convertToSVGPODTypeImpl): (WebCore::V8DOMWrapper::lookupDOMWrapper): (WebCore::V8DOMWrapper::convertDOMWrapperToNodeHelper): (WebCore::V8DOMWrapper::wrapNativeNodeFilter): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::setDOMWrapper): (WebCore::V8DOMWrapper::maybeDOMWrapper): (WebCore::V8DOMWrapper::isDOMEventWrapper): (WebCore::V8DOMWrapper::isWrapperOfType): (WebCore::V8DOMWrapper::htmlElementType): (WebCore::V8DOMWrapper::svgElementType): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::convertDOMImplementationToV8Object): (WebCore::V8DOMWrapper::convertStyleSheetToV8Object): (WebCore::V8DOMWrapper::convertCSSValueToV8Object): (WebCore::V8DOMWrapper::convertCSSRuleToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object): (WebCore::V8Proxy::bindJsObjectToWindow):
  • bindings/v8/V8Proxy.h: (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::wrapCPointer): (WebCore::V8DOMWrapper::extractCPointer): (WebCore::V8DOMWrapper::convertDOMWrapperToNode): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertToNativeObject): (WebCore::V8DOMWrapper::convertToNativeEvent): (WebCore::V8DOMWrapper::extractCPointerImpl): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8Proxy::constructDOMObject): (WebCore::toV8):
  • bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::V8SVGPODTypeUtil::toSVGPODType):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::retrieve): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::GetConstructor): (WebCore::WorkerContextExecutionProxy::ToV8Object): (WebCore::WorkerContextExecutionProxy::EventToV8Object): (WebCore::WorkerContextExecutionProxy::toV8):
  • bindings/v8/custom/V8AttrCustom.cpp: (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_SETTER):
  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toV8): (WebCore::toCanvasStyle): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ClientRectListCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER):
  • bindings/v8/custom/V8ClipboardCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8CustomBinding.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::INDEXED_ACCESS_CHECK): (WebCore::NAMED_ACCESS_CHECK): (WebCore::V8Custom::GetTargetFrame):
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp: (WebCore::V8CustomSQLStatementCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: (WebCore::V8CustomSQLTransactionCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::V8Custom::ClearTimeoutImpl): (WebCore::NAMED_ACCESS_CHECK): (WebCore::INDEXED_ACCESS_CHECK):
  • bindings/v8/custom/V8DatabaseCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp: (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLInputElementCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_SETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::removeElement):
  • bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_ACCESS_CHECK): (WebCore::NAMED_ACCESS_CHECK):
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8NavigatorCustom.cpp: (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SQLTransactionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SVGElementInstanceCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SVGLengthCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8StorageCustom.cpp: (WebCore::V8Custom::v8StorageNamedPropertyEnumerator): (WebCore::storageGetter): (WebCore::storageSetter): (WebCore::storageDeleter):
  • bindings/v8/custom/V8StyleSheetListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::SetTimeoutOrInterval): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
Note: See TracTimeline for information about the timeline view.