Context Navigation

HTMLVideoElement is the only subclass to support fullscreen
(conditionnaly). HTMLAudioElement fullscreen is not supported
and is a different kind of fullscreen, if it comes to be wanted.

No test can be done currently given that none of the media
backends support fullscreen.

html/HTMLMediaElement.cpp:
html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::supportsFullscreen):

10:26 PM Changeset in webkit [45893] by Darin Adler

26 edits in trunk/WebCore

2009-07-14 Darin Adler <Darin Adler>

Reviewed by Dimitri Glazkov.

Next step in making DOM attribute getter/setters consistently use AtomicString
https://bugs.webkit.org/show_bug.cgi?id=25425

This covers eight DOM classes, and for each one of the classes:

Changes the IDL to use the Reflect syntax for all simple cases.
Removes unused functions in the classes, mainly newly unused ones that were used for reflection before.
Removes unneeded explicitly defined destructors.
Explicitly declares destructors as virtual.
Removes unneeded includes.
Makes members protected or private rather than public where possible.
Renames "doc" to "document".
Tweaks formatting to match our latest style in a few places.
Improves some FIXME comments.

Over time we'll want to do this for all HTML DOM classes.

html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement):
html/HTMLAnchorElement.h: (WebCore::HTMLAnchorElement::endTagRequirement): (WebCore::HTMLAnchorElement::tagPriority):
html/HTMLAnchorElement.idl:
html/HTMLAppletElement.cpp:
html/HTMLAppletElement.h:
html/HTMLAppletElement.idl:
html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute):
html/HTMLAreaElement.h: (WebCore::HTMLAreaElement::endTagRequirement): (WebCore::HTMLAreaElement::tagPriority):
html/HTMLAreaElement.idl:
html/HTMLBRElement.cpp: (WebCore::HTMLBRElement::parseMappedAttribute):
html/HTMLBRElement.h:
html/HTMLBRElement.idl:
html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::HTMLBaseElement): (WebCore::HTMLBaseElement::removedFromDocument): (WebCore::HTMLBaseElement::process):
html/HTMLBaseElement.h:
html/HTMLBaseElement.idl:
html/HTMLBaseFontElement.cpp: (WebCore::HTMLBaseFontElement::HTMLBaseFontElement):
html/HTMLBaseFontElement.h: (WebCore::HTMLBaseFontElement::endTagRequirement): (WebCore::HTMLBaseFontElement::tagPriority):
html/HTMLBaseFontElement.idl:
html/HTMLBlockquoteElement.cpp: (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
html/HTMLBlockquoteElement.h: (WebCore::HTMLBlockquoteElement::tagPriority):
html/HTMLBlockquoteElement.idl:
html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::HTMLBodyElement): (WebCore::HTMLBodyElement::addSubresourceAttributeURLs):
html/HTMLBodyElement.h: (WebCore::HTMLBodyElement::endTagRequirement): (WebCore::HTMLBodyElement::tagPriority):
html/HTMLBodyElement.idl: Made changes as described above.

loader/FrameLoader.cpp: Removed unneeded include of HTMLAnchorElement.h.

10:22 PM Changeset in webkit [45892] by sfalken@apple.com

15 edits in trunk

JavaScriptCore:

2009-07-14 Steve Falkenburg <sfalken@apple.com>

Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/

Reviewed by Darin Adler.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
JavaScriptCore.vcproj/testapi/testapi.vcproj:
JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:

WebCore:

2009-07-14 Steve Falkenburg <sfalken@apple.com>

Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/

Reviewed by Darin Adler.

WebCore.vcproj/QTMovieWin.vcproj:
WebCore.vcproj/WebCoreCommon.vsprops:
WebCore.vcproj/build-generated-files.sh:

WebKit/win:

2009-07-14 Steve Falkenburg <sfalken@apple.com>

Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/

Reviewed by Darin Adler.

WebKit.vcproj/WebKit.vcproj:

WebKitTools:

2009-07-14 Steve Falkenburg <sfalken@apple.com>

Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/

Reviewed by Darin Adler.

DumpRenderTree/win/DumpRenderTree.vcproj:
DumpRenderTree/win/ImageDiff.vcproj:

10:13 PM Changeset in webkit [45891] by bfulgham@webkit.org

113 edits in trunk

JavaScriptCore:

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225

Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).

bytecode/SamplingTool.h:
bytecompiler/RegisterID.h:
interpreter/CachedCall.h:
interpreter/RegisterFile.h:
parser/Lexer.h:
parser/Parser.h:
runtime/ArgList.h:
runtime/BatchedTransitionOptimizer.h:
runtime/Collector.h:
runtime/CommonIdentifiers.h:
runtime/JSCell.h:
runtime/JSGlobalObject.h:
runtime/JSLock.h:
runtime/JSONObject.cpp:
runtime/SmallStrings.cpp:
runtime/SmallStrings.h:
wtf/CrossThreadRefCounted.h:
wtf/GOwnPtr.h:
wtf/Locker.h:
wtf/MessageQueue.h:
wtf/OwnArrayPtr.h:
wtf/OwnFastMallocPtr.h:
wtf/OwnPtr.h:
wtf/RefCounted.h:
wtf/ThreadSpecific.h:
wtf/Threading.h:
wtf/Vector.h:
wtf/unicode/Collator.h:

WebCore:

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225

Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).

bindings/js/GCController.h:
bindings/js/WorkerScriptController.h:
bindings/v8/V8DOMMap.cpp: (WebCore::):
bridge/runtime.h:
css/CSSSelector.h:
css/CSSSelectorList.h:
css/CSSStyleSelector.h:
dom/ClassNames.h:
dom/MessagePortChannel.h:
dom/XMLTokenizerLibxml2.cpp:
dom/XMLTokenizerScope.h:
editing/ReplaceSelectionCommand.cpp:
editing/SelectionController.h:
editing/TextIterator.cpp:
history/PageCache.h:
html/CanvasRenderingContext2D.h:
html/HTMLParser.h:
html/HTMLParserQuirks.h:
html/PreloadScanner.h:
loader/Cache.h:
loader/CrossOriginPreflightResultCache.h:
loader/FrameLoader.h:
loader/ProgressTracker.h:
loader/ThreadableLoader.h:
loader/appcache/ApplicationCacheGroup.h:
loader/archive/ArchiveResourceCollection.h:
loader/icon/IconDatabase.h:
loader/icon/IconLoader.h:
loader/icon/PageURLRecord.h:
loader/loader.h:
page/ContextMenuController.h:
page/EventHandler.h:
page/FrameTree.h:
page/Page.h:
page/PageGroup.h:
page/PageGroupLoadDeferrer.h:
page/mac/EventHandlerMac.mm:
platform/AutodrainedPool.h:
platform/ContextMenu.h:
platform/EventLoop.h:
platform/HostWindow.h:
platform/Pasteboard.h:
platform/PurgeableBuffer.h:
platform/RunLoopTimer.h:
platform/ThreadGlobalData.h:
platform/ThreadTimers.h:
platform/Timer.h:
platform/TreeShared.h:
platform/graphics/FontData.h:
platform/graphics/GlyphWidthMap.h:
platform/graphics/GraphicsContext.h:
platform/graphics/ImageBuffer.h:
platform/graphics/ImageSource.h:
platform/graphics/MediaPlayer.h:
platform/graphics/skia/GraphicsContextPlatformPrivate.h:
platform/graphics/skia/PlatformContextSkia.h:
platform/graphics/win/QTMovieWin.cpp:
platform/mac/LocalCurrentGraphicsContext.h:
platform/network/FormDataBuilder.h:
platform/network/ResourceHandleInternal.h:
platform/network/soup/ResourceHandleSoup.cpp:
platform/text/StringBuffer.h:
platform/text/TextCodec.h:
platform/win/WindowMessageBroadcaster.h:
rendering/CounterNode.h:
rendering/LayoutState.h:
rendering/RenderFrameSet.h:
rendering/RenderView.h:
rendering/TransformState.h:
svg/SVGAnimatedProperty.h:
svg/SynchronizableTypeWrapper.h:
workers/WorkerMessagingProxy.h:
workers/WorkerRunLoop.cpp:
xml/XPathExpressionNode.h:
xml/XPathParser.h:
xml/XPathPredicate.h:
xml/XPathStep.h:

WebKit/gtk:

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225

Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).

webkit/webkitdownload.cpp:

WebKit/win:

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225

Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).

COMEnumVariant.h:
WebDatabaseManager.cpp:
WebInspector.h:
WebLocalizableStrings.cpp:

10:04 PM Changeset in webkit [45890] by darin@chromium.org

3 edits
2 adds in trunk

2009-07-14 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

Fails to save document state when navigating away from a page with a
reference fragment.
https://bugs.webkit.org/show_bug.cgi?id=27281

Test: fast/history/saves-state-after-fragment-nav.html

history/HistoryItem.cpp: (WebCore::HistoryItem::isCurrentDocument): Use equalIgnoringRef to compare URLs.

8:43 PM Changeset in webkit [45889] by bfulgham@webkit.org

5 edits in trunk/WebCore

2009-07-14 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Sam Weinig.

Inspector: Remove Unintended Global Variables
https://bugs.webkit.org/show_bug.cgi?id=27203

inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled):
inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):
inspector/front-end/inspector.js: (WebInspector.animateStyle):

7:03 PM Changeset in webkit [45888] by pkasting@chromium.org

19 edits
5 adds in trunk

WebCore:

2009-07-14 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=19562
Added build stuff and stub for the ValidityState class, part of HTML5
section Forms:
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#validitystate

Test: fast/forms/ValidityState-001.html

DerivedSources.cpp: Inclusion of ValidityState files
DerivedSources.make: ditto
GNUmakefile.am: ditto
WebCore.gypi: ditto
WebCore.pro: ditto
WebCore.vcproj/WebCore.vcproj: ditto
WebCore.xcodeproj/project.pbxproj: ditto
WebCoreSources.bkl: ditto
html/HTMLButtonElement.idl: validity attribute
html/HTMLFieldSetElement.idl: ditto
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::validity): ValidityState getter
html/HTMLFormControlElement.h: ditto
html/HTMLInputElement.idl: validity attribute
html/HTMLSelectElement.idl: ditto
html/HTMLTextAreaElement.idl: ditto
html/ValidityState.cpp: Added. (WebCore::ValidityState::ValidityState): (WebCore::ValidityState::valid): validation flag
html/ValidityState.h: Added. (WebCore::ValidityState::create): validation flag (WebCore::ValidityState::control): ditto (WebCore::ValidityState::valueMissing): ditto (WebCore::ValidityState::typeMismatch): ditto (WebCore::ValidityState::patternMismatch): ditto (WebCore::ValidityState::tooLong): ditto (WebCore::ValidityState::rangeUnderflow): ditto (WebCore::ValidityState::rangeOverflow): ditto (WebCore::ValidityState::stepMismatch): ditto (WebCore::ValidityState::customError): ditto
html/ValidityState.idl: Added.

LayoutTests:

2009-07-14 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=19562
Minimal test case for ValidityState; more tests are going to be added
along with specific validation routines.

fast/dom/domListEnumeration-expected.txt: increased expected value of 1 to match the new "validity" attribute
fast/dom/resources/domListEnumeration.js: ditto
fast/forms/ValidityState-001-expected.txt: Added.
fast/forms/ValidityState-001.html: Added.

6:11 PM Changeset in webkit [45887] by bfulgham@webkit.org

2 edits in trunk/JavaScriptCore

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change ParserArenaRefCounted's superclass to RefCountedCustomAllocated
https://bugs.webkit.org/show_bug.cgi?id=27249

ParserArenaDeletable customizes operator new, to avoid double inheritance
ParserArenaDeletable's superclass has been changed to RefCountedCustomAllocated.

parser/Nodes.h:

6:02 PM Changeset in webkit [45886] by jparent@chromium.org

6 edits
2 adds in trunk

WebCore:

2009-07-14 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

Outdenting a line inside a blockquote tag does nothing
https://bugs.webkit.org/show_bug.cgi?id=25316

The bug was caused by the code checking whether the blockquote is created by WebKit or not.
We simply remove this code to be consistent with Firefox and Internet Explorer.
Also, enclosingBlockFlow == enclosingNode in outdentParagraph isn't a sufficient condition to insert
the placeholder before the enclosingNode because there could be contents before the current paragraph.
Instead, we should split the enclosingNode (which is a blockquote) at the starting position of outdentation.
It turned out that this solves the bug 25315 also: https://bugs.webkit.org/show_bug.cgi?id=25315

Test: editing/execCommand/outdent-regular-blockquote.html

editing/IndentOutdentCommand.cpp: (WebCore::isIndentBlockquote): no longer checks whether a blockquote is created by WebKit or not. (WebCore::IndentOutdentCommand::outdentParagraph): takes care of the case enclosingBlockFlow == enclosingNode

LayoutTests:

2009-07-14 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

Outdenting a line inside a blockquote tag does nothing
https://bugs.webkit.org/show_bug.cgi?id=25315
https://bugs.webkit.org/show_bug.cgi?id=25316

The expected result for /editing/execCommand/outdent-selection-expected.html
was rebaselined since the original expected result was wrong (Bug 25315).
Namely, "ipsum" moved to the same paragraph as "more Lorem!"
("ipsum" was in the blockblock immediately below "more Lorem!")
and "Dolor" was moved above the list items "Foo", "Bar", and "Baz".

editing/execCommand/outdent-regular-blockquote-expected.txt: Added.
editing/execCommand/outdent-regular-blockquote.html: Added.
platform/mac/editing/execCommand/outdent-selection-expected.checksum:
platform/mac/editing/execCommand/outdent-selection-expected.png:
platform/mac/editing/execCommand/outdent-selection-expected.txt:

5:47 PM Changeset in webkit [45885] by bfulgham@webkit.org

2 edits in trunk/JavaScriptCore

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Add RefCountedCustomAllocated to RefCounted.h
https://bugs.webkit.org/show_bug.cgi?id=27232

Some class which are inherited from RefCounted customize
operator new, but RefCounted is inherited from Noncopyable
which will be inherited from FastAllocBase. To avoid
conflicts Noncopyable inheriting was moved down to RefCounted
and to avoid double inheritance this class has been added.

wtf/RefCounted.h: (WTF::RefCountedCustomAllocated::deref): (WTF::RefCountedCustomAllocated::~RefCountedCustomAllocated):

5:10 PM Changeset in webkit [45884] by abarth@webkit.org

3 edits in trunk/WebCore

2009-07-14 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Fix isolated world wrappers for Node prototypes
https://bugs.webkit.org/show_bug.cgi?id=27277

This change does two things:

1) We bypass the wrapper cache in the isolated world. This is because

the wrapper template cache has prototypes that lead to the main
world. We can add a template cache for the isolated world if
performance warrants.

2) We introduce a smarter way to grab the wrapper context for a frame

that is aware that proxy <-> context do not stand in one-to-one
correspondence. This generalizes our solution for the node wrapper
case to prototypes.

The net result is that Node wrappers get the right prototypes. As
before, tests to follow.

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setHiddenWindowReference): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object): (WebCore::V8DOMWrapper::getWrapperContext):
bindings/v8/V8DOMWrapper.h:

5:05 PM Changeset in webkit [45883] by bfulgham@webkit.org

2 edits in trunk/JavaScriptCore

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Add NoncopyableCustomAllocated to Noncopyable.h.
https://bugs.webkit.org/show_bug.cgi?id=27228

Some classes which inherited from Noncopyable overrides operator new
since Noncopyable'll be inherited from FastAllocBase, Noncopyable.h
needs to be extended with this new class to support the overriding.

wtf/Noncopyable.h: (WTFNoncopyable::NoncopyableCustomAllocated::NoncopyableCustomAllocated): (WTFNoncopyable::NoncopyableCustomAllocated::~NoncopyableCustomAllocated):

4:36 PM Changeset in webkit [45882] by abarth@webkit.org

3 edits in trunk/WebCore

2009-07-14 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Fix isolated world wrappers for Nodes
https://bugs.webkit.org/show_bug.cgi?id=27271

Previously, we keepy a pointer to the DOMMap on V8Proxy, but this
caused us to miss the branch in V8DOMMap.cpp for isolated worlds.

I have tests, but I can't land them until I get this feature under
control.

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertNodeToV8Object):
bindings/v8/V8Proxy.h: (WebCore::V8Proxy::V8Proxy):

4:16 PM Changeset in webkit [45881] by bfulgham@webkit.org

2 edits in trunk/JavaScriptCore

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's IdentifierTable class
https://bugs.webkit.org/show_bug.cgi?id=27260

Inherits IdentifierTable class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Identifier.cpp:70.

runtime/Identifier.cpp:

4:09 PM Changeset in webkit [45880] by abarth@webkit.org

3 edits in trunk/WebCore

2009-07-14 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Fix isolated world crash on getting window.location
https://bugs.webkit.org/show_bug.cgi?id=27268

I have a test for this locally, but it requires a compile-time hack to
run. Once I get the feature's stability under control, we can turn the
feature on and add the tests.

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setHiddenWindowReference):
bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::context):

4:02 PM Changeset in webkit [45879] by bfulgham@webkit.org

2 edits in trunk/WebCore

2009-07-14 Brent Fulgham <bfulgham@webkit.org>

Correct failing tests after r45875. The original patch did not
test the m_player member for null, causing crashes. This will
happen fairly frequently in real use. Was this original patch
ever tested?
https://bugs.webkit.org/show_bug.cgi?id=27246

Test via existing media tests.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::supportsFullscreen): Check for null pointer. (WebCore::HTMLMediaElement::supportsSave): Check for null pointer.

3:50 PM Changeset in webkit [45878] by darin@chromium.org

3 edits in trunk/WebCore

2009-07-14 Avi Drissman <avi@chromium.org>

Reviewed by Darin Fisher.

Explicitly mark the HTML generated for the Mac as being UTF-8 encoded.
The Windows clipboard format is explicitly documented as being UTF-8,
and all Linux apps assume UTF-8. On the Mac, though, unless otherwise
indicated, Windows-1252 is assumed, which is wrong.

Bug: https://bugs.webkit.org/show_bug.cgi?id=27262

No new tests.

platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeRange):
platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection):

3:43 PM Changeset in webkit [45877] by bfulgham@webkit.org

2 edits in trunk/JavaScriptCore

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's Profiler class
https://bugs.webkit.org/show_bug.cgi?id=27253

Inherits Profiler class from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/profiler/Profiler.cpp:56.

profiler/Profiler.h:

3:35 PM Changeset in webkit [45876] by Nate Chapin

3 edits
2 adds in trunk/WebCore

2009-07-14 Albert J. Wong <ajwong@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream V8NPObject.h and V8NPObject.cpp.
https://bugs.webkit.org/show_bug.cgi?id=27103

This just upstreams the files from the chromium code base. Only
minor changes to formatting and similar were done, so no testing
is required because nothing really changed. Code verified to compile.

3:20 PM Changeset in webkit [45875] by bfulgham@webkit.org

8 edits in trunk/WebCore

2009-07-14 Albert J. Wong <ajwong@chromium.org>

Reviewed by Darin Adler.

Add HTMLMediaElement::supportSave() and a
HitTestResult::absoluteMediaURL() functions
https://bugs.webkit.org/show_bug.cgi?id=27246

Added an implementation of supportsSave() into HTMLMediaElement
that delegates to MediaPlayerPrivateImpl so that the media engine
is able to signal whether or not a media source supports saving.

Also added a function to HitTestResult that allows for retrieval
of the currentSrc associated with the "hit" media element.

These functions are just pipeing with no visible UI change so there
are no related layout test changes.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::supportsFullscreen): (WebCore::HTMLMediaElement::supportsSave):
html/HTMLMediaElement.h:
platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::supportsSave):
platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsFullscreen): (WebCore::MediaPlayerPrivateInterface::supportsSave):
rendering/HitTestResult.cpp: (WebCore::HitTestResult::altDisplayString): (WebCore::HitTestResult::absoluteMediaURL):
rendering/HitTestResult.h:

3:00 PM Changeset in webkit [45874] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-07-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

[V8] Implement Reflect and ReflectURL attribute support.
https://bugs.webkit.org/show_bug.cgi?id=27273

bindings/scripts/CodeGeneratorV8.pm: Added support for Reflect and ReflectURL attributes.

2:28 PM Changeset in webkit [45873] by bfulgham@webkit.org

8 edits in trunk/WebCore

2009-07-14 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27266
Add hasCurrentPoint() to WebCore::Path.
This fixes Skia-based Chromium regression caused by the fix for
https://bugs.webkit.org/show_bug.cgi?id=27187.
For Skia, the new method always returns 'true', pending actual implementation.
This means Chromium still will differ from Gecko behavior, but at least its Canvas
will not be completely broken.

Existing Canvas Layout Tests should pass in Chromium after this change.

html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::lineTo): insteand of Path::isEmpty() test for hasCurrentPoint(). (WebCore::CanvasRenderingContext2D::quadraticCurveTo): ditto. (WebCore::CanvasRenderingContext2D::bezierCurveTo): ditto.

platform/graphics/Path.h:
platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::hasCurrentPoint):
platform/graphics/cg/PathCG.cpp: (WebCore::Path::isEmpty): (WebCore::Path::hasCurrentPoint):
platform/graphics/qt/PathQt.cpp: (WebCore::Path::hasCurrentPoint):
platform/graphics/skia/PathSkia.cpp: (WebCore::Path::hasCurrentPoint):
platform/graphics/wx/PathWx.cpp: (WebCore::Path::hasCurrentPoint): All these files add a Path::hasCurrentPoint() for various platforms.

2:15 PM Changeset in webkit [45872] by Nate Chapin

2 edits
2 adds in trunk/WebCore

2009-07-14 Nate Chapin <Nate Chapin>

Reviewed by Sam Weinig.

Upstream RGBColor from src.chromium.org.

https://bugs.webkit.org/show_bug.cgi?id=27133

2:05 PM Changeset in webkit [45871] by mpcomplete@chromium.org

4 edits in trunk/WebCore

2009-07-10 Matt Perry <mpcomplete@chromium.org>

Reviewed by Darin Fisher.

[V8] Rename the didCreate/DestroyScriptContext calls to make it
clear that that those refer to the frame's contxt. Add another
similar call for when creating contexts via evaluateInNewContext.
https://bugs.webkit.org/show_bug.cgi?id=27104

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::disposeContextHandles): (WebCore::V8Proxy::initContextIfNeeded):
loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didCreateScriptContextForFrame): (WebCore::EmptyFrameLoaderClient::didDestroyScriptContextForFrame): (WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):
loader/FrameLoaderClient.h:

1:45 PM Changeset in webkit [45870] by mrowe@apple.com

3 edits in branches/safari-4-branch/WebKit/mac

Merge r45834.

1:45 PM Changeset in webkit [45869] by mrowe@apple.com

3 edits
9 adds in branches/safari-4-branch

Merge r45850.

1:45 PM Changeset in webkit [45868] by mrowe@apple.com

3 edits
2 adds in branches/safari-4-branch

Merge r45836.

1:45 PM Changeset in webkit [45867] by mrowe@apple.com

3 edits in branches/safari-4-branch/WebCore

Merge r45832.

1:39 PM Changeset in webkit [45866] by bfulgham@webkit.org

18 edits in trunk/WebCore

2009-07-14 Brent Fulgham <bfulgham@webkit.org>

Revert http://trac.webkit.org/changeset/45864 after
breaking of Windows build.

storage/LocalStorageTask.cpp:
storage/LocalStorageTask.h:
storage/Storage.cpp:
storage/Storage.h:
storage/StorageArea.cpp:
storage/StorageArea.h:
storage/StorageAreaImpl.cpp:
storage/StorageAreaImpl.h:
storage/StorageAreaSync.cpp:
storage/StorageAreaSync.h:
storage/StorageEvent.cpp:
storage/StorageEvent.h: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent):
storage/StorageNamespace.h:
storage/StorageNamespaceImpl.cpp:
storage/StorageNamespaceImpl.h:
storage/StorageSyncManager.cpp:
storage/StorageSyncManager.h:

1:21 PM Changeset in webkit [45865] by treat@webkit.org

3 edits
2 adds in trunk/JavaScriptCore

2009-07-06 George Staikos <george.staikos@torchmobile.com>

Reviewed by Adam Treat.

Authors: George Staikos <george.staikos@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>, Makoto Matsumoto <matumoto@math.keio.ac.jp>, Takuji Nishimura

https://bugs.webkit.org/show_bug.cgi?id=27030
Implement custom RNG for WinCE using Mersenne Twister

wtf/RandomNumber.cpp: (WTF::randomNumber):
wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
wtf/wince/mt19937ar.c: Added. (init_genrand): (init_by_array): (genrand_int32): (genrand_int31): (genrand_real1): (genrand_real2): (genrand_real3): (genrand_res53):

12:36 PM Changeset in webkit [45864] by bfulgham@webkit.org

18 edits in trunk/WebCore

2009-07-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180

DOM Storage had several unnecessary (and probably unintended)
dependencies. This patch replaces many includes of header files with
forward declaration of classes, making some destructors explicit, and
taking some factories out of the header files.

This will allow things like StorageAreaSync to take a StorageAreaImpl*
(as it should) rather than a StorageArea* which previously weren't
possible because the dependencies were such a tangled mess.

storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::~LocalStorageTask):
storage/LocalStorageTask.h:
storage/Storage.cpp: (WebCore::Storage::~Storage):
storage/Storage.h:
storage/StorageArea.cpp:
storage/StorageArea.h:
storage/StorageAreaImpl.cpp:
storage/StorageAreaImpl.h:
storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::~StorageAreaSync):
storage/StorageAreaSync.h:
storage/StorageEvent.cpp: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent):
storage/StorageEvent.h:
storage/StorageNamespace.h:
storage/StorageNamespaceImpl.cpp:
storage/StorageNamespaceImpl.h:
storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::~StorageSyncManager):
storage/StorageSyncManager.h:

10:54 AM Changeset in webkit [45863] by treat@webkit.org

3 edits in trunk/WebCore

2009-07-14 Adam Treat <adam.treat@torchmobile.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=26983

Check to make sure the view is attached to a frame() in the visibleContentsResized()
method as it can be triggered before the view is attached by Frame::createView(...)
setting various values such as setScrollBarModes(...) for example. An ASSERT is
triggered when a view is layout before being attached to a frame().

page/FrameView.cpp: (WebCore::FrameView::visibleContentsResized):
page/FrameView.h:

9:56 AM Changeset in webkit [45862] by treat@webkit.org

2 edits in trunk/WebKit/qt

2009-07-14 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Zack Rusin.

https://bugs.webkit.org/show_bug.cgi?id=26983

The default constructed values for QSize and WebCore::IntSize are different. The former
produces an invalid size whereas the latter produces a size of zero. This was causing
a layout to be triggered when constructing a view and an assert to be hit. This patch fixes
the crash by taking care not to cause an unnecessary layout triggered by ScrollView::setFixedL

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

9:29 AM Changeset in webkit [45861] by pfeldman@chromium.org

5 edits in trunk/WebCore

2009-07-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: show last opened panel when invoking inspector.

https://bugs.webkit.org/show_bug.cgi?id=27263

inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::specialPanelForJSName):
inspector/InspectorController.h: (WebCore::InspectorController::Setting::Setting):
inspector/InspectorController.idl:
inspector/front-end/inspector.js: (WebInspector.set currentPanel): (WebInspector.loaded):

9:25 AM Changeset in webkit [45860] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-07-14 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Speed up access to NodeList length.
https://bugs.webkit.org/show_bug.cgi?id=27264

That's a minimal alternation of the code.

bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): 1) use AtomicString for comparison, 2) use v8::Integer::New instead of v8::Number::New.

9:16 AM Changeset in webkit [45859] by Dimitri Glazkov

10 edits in trunk/WebCore

2009-07-14 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Do not do unnecessary conversions from v8::Handle<v8::Value> to
v8::Handle<v8::Object> and accompanying changes.
https://bugs.webkit.org/show_bug.cgi?id=26953

Three things:

1) do not cast from v8::Value to v8::Object if unnecessary---casts are cheap,
but are not free (they check for emptiness of handle);
2) inline conversion from wrapper to node;
3) simplify case to an ASSERT.

This is just a refactoring, so no new tests are needed.

bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::convertToSVGPODTypeImpl):
bindings/v8/V8Proxy.h: (WebCore::V8Proxy::convertDOMWrapperToNative): (WebCore::V8Proxy::convertToNativeObject): (WebCore::V8Proxy::convertToNativeEvent):
bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toCanvasStyle): (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8CustomBinding.cpp: (WebCore::V8Custom::GetTargetFrame):
bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::V8Custom::ClearTimeoutImpl): (WebCore::NAMED_ACCESS_CHECK): (WebCore::INDEXED_ACCESS_CHECK):
bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8LocationCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

9:06 AM Changeset in webkit [45858] by Darin Adler

4 edits
1 copy
1 add in trunk

WebCore:

2009-07-14 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Straight quotes should match fancy quotes in in-page search
https://bugs.webkit.org/show_bug.cgi?id=27217

Tests: fast/text/find-quotes.html

editing/TextIterator.cpp: (WebCore::foldQuoteMark): Added. (WebCore::foldQuoteMarks): Added. (WebCore::SearchBuffer::SearchBuffer): Call foldQuoteMarks on the target string. (WebCore::SearchBuffer::append): Call foldQuoteMarks on characters as they are added to the search buffer.

platform/text/CharacterNames.h: Added more quotation mark character names. Sorted character names with the sort tool.

LayoutTests:

2009-07-14 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Straight quotes should match fancy quotes in in-page search
https://bugs.webkit.org/show_bug.cgi?id=27217

fast/text/find-quotes-expected.txt: Added.
fast/text/find-quotes.html: Copied from LayoutTests/fast/text/find-case-folding.html.

8:42 AM Changeset in webkit [45857] by levin@chromium.org

1 edit
2 adds in trunk/WebKitTools

2009-07-14 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Modifies cpplint (http://google-styleguide.googlecode.com/svn/trunk/cpplint/)
based on WebKit's style guide.

Scripts/cpplint.py: Added.
Scripts/cpplint_unittest.py: Added.

6:04 AM Changeset in webkit [45856] by Simon Hausmann

2 edits in trunk/WebKitTools

2009-07-14 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] DumpRenderTree no longer builds with Qt4.4
https://bugs.webkit.org/show_bug.cgi?id=27257

Flag Qt 4.5 dependency to allow building with Qt 4.4.

DumpRenderTree/qt/main.cpp: (main):

Jul 13, 2009:

11:06 PM BuildingCairoOnWindows edited by bfulgham@webkit.org

(diff)

11:05 PM BuildingCairoOnWindows edited by bfulgham@webkit.org

Remove instruction to include GIFLIB, as this is no longer necessary. (diff)

11:04 PM BuildingCairoOnWindows edited by bfulgham@webkit.org

Removed instructions to edit config.h, as this is no longer necessary! (diff)

10:35 PM Changeset in webkit [45855] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-07-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: handle debugger shortcuts while on source frame or on
script file selector.

https://bugs.webkit.org/show_bug.cgi?id=27224

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):

9:00 PM Changeset in webkit [45854] by weinig@apple.com

3 edits in trunk/WebCore

2009-07-13 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Use standard HashCountedSet instead of a hand rolled one
in HTMLDocument.

html/HTMLDocument.cpp: (WebCore::addItemToMap): (WebCore::removeItemFromMap):
html/HTMLDocument.h:

8:32 PM WebKit Team edited by tonikitoo@gmail.com

added indt folks (diff)

7:44 PM Changeset in webkit [45853] by beidson@apple.com

2 edits in trunk/LayoutTests

2009-07-13 Brady Eidson <beidson@apple.com>

Fix Leopard regression I just introduced.

platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:

7:01 PM Changeset in webkit [45852] by beidson@apple.com

4 edits
3 copies
1 add in trunk/LayoutTests

2009-07-13 Brady Eidson <beidson@apple.com>

Rubberstamped by Mark Rowe.

Add SnowLeopard specific results for differing MIME types that are (mostly) progressions.

platform/mac-leopard/platform/mac/fast/loader: Added.
platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-2-expected.txt.
platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-3-expected.txt.
platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-expected.txt.
platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
platform/mac/fast/loader/file-url-mimetypes-3-expected.txt:
platform/mac/fast/loader/file-url-mimetypes-expected.txt:

6:04 PM Changeset in webkit [45851] by Darin Adler

12 edits
5 adds in trunk

WebCore:

2009-07-13 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler and Maciej Stachowiak.

Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262

This adds support for the HTML5 draggable attribute and its DOM binding. It maps the draggable property
to the CSS properties -webkit-user-drag and -webkit-user-select respectively.

Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-draggable-attribute

Test: fast/html/draggable.html

css/html.css:
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::draggable):
html/HTMLAnchorElement.h:
html/HTMLAttributeNames.in:
html/HTMLElement.cpp: (WebCore::HTMLElement::draggable): (WebCore::HTMLElement::setDraggable):
html/HTMLElement.h:
html/HTMLElement.idl:
html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::draggable):
html/HTMLImageElement.h:

LayoutTests:

2009-07-13 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler and Maciej Stachowiak.

Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262

This adds support for the HTML5 draggable attribute and its DOM binding. It maps the draggable property
to the CSS properties -webkit-user-drag and -webkit-user-select respectively.

Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-draggable-attribute

fast/html/draggable-expected.txt: Added.
fast/html/draggable.html: Added.
fast/html/resources: Added.
fast/html/resources/images: Added.
fast/html/resources/images/lime.png: Added.

fast/dom/resources/domListEnumeration.js: Updated.
fast/dom/domListEnumeration-expected.txt: Updated.

5:47 PM Changeset in webkit [45850] by Simon Fraser

3 edits
9 adds in trunk

2009-07-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Image rendered as layer contents looks different from image rendered via CG.
<rdar://problem/7048830>

Fix a visible color profile difference between between images rendered via Core Graphics
and those rendered via a compositing layer, by assigning the GenericRGB profile to
untagged images (which come through as having the DeviceRGB profile) when they are set
as layer contents.

Test: compositing/color-matching/image-color-matching.html

platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToImage):

5:20 PM Changeset in webkit [45849] by Darin Adler

2 edits in trunk/WebCore

2009-07-13 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=27220
Assertion failure in createSearcher() (usearch_open() status is U_USING_DEFAULT_WARNING)

editing/TextIterator.cpp: (WebCore::createSearcher): Add U_USING_DEFAULT_WARNING as a possible status code in the assertion. Affects only the assertion.

5:07 PM Changeset in webkit [45848] by ap@webkit.org

6 edits
4 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26925
<rdar://problem/7027850> URL Fragment Breaks Application Cache Loads

Test: http/tests/appcache/main-resource-hash.html

loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::resourceForURL): (WebCore::ApplicationCache::resourceForRequest):
loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::cacheForMainRequest): (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didFail): (WebCore::ApplicationCacheGroup::addEntry): Remove URL fragment at appcache code borders.

loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::create):
loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::findOrCreateCacheGroup): (WebCore::ApplicationCacheStorage::cacheGroupForURL): (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Assert that there is no URL fragment in URL at key points in appcache code.

5:02 PM Changeset in webkit [45847] by Darin Adler

3 edits
1 copy
1 add in trunk

WebCore:

2009-07-13 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27166
rdar://problem/7015857
Find for strings composed entirely of spaces doesn't work

Test: fast/text/find-spaces.html

editing/TextIterator.cpp: (WebCore::findPlainText): Removed unneeded special case. The empty string case already works correctly.

LayoutTests:

2009-07-13 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27166
rdar://problem/7015857
Find for strings composed entirely of spaces doesn't work

fast/text/find-spaces-expected.txt: Added.
fast/text/find-spaces.html: Copied from LayoutTests/fast/text/find-case-folding.html.

4:42 PM Changeset in webkit [45846] by bfulgham@webkit.org

3 edits in trunk/WebKit/win

2009-07-13 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Refactor WebFrame::spoolPages for easier sharing with Windows Cairo.
https://bugs.webkit.org/show_bug.cgi?id=27240.

WebFrame.cpp: (WebFrame::printHeader): New shared method to print the header. (WebFrame::printFooter): New shared method to print the footer. (WebFrame::spoolPage): New conditionally-compiled method to print a page. (WebFrame::spoolPages): Revised to call the platform-specific spoolPage for each page.
WebFrame.h: Add new method prototypes.

4:23 PM Changeset in webkit [45845] by andersca@apple.com

2 edits in trunk/WebCore

2009-07-13 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Remove NPPVpluginPrivateModeBool, it was removed from the spec.

bridge/npapi.h:

4:08 PM Changeset in webkit [45844] by feng@chromium.org

2 edits in trunk/WebCore

2009-07-13 Feng Qian <feng@chromium.org>

Reviewed by Dimitri Glazkov.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27237

Make V8DOMMap.h compiling with gcc option -Werror=non=virtual-dtor.

bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::WeakReferenceMap): (WebCore::WeakReferenceMap::~WeakReferenceMap):

4:03 PM Changeset in webkit [45843] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-07-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

Remove an accidental add of bidi.(cpp|h) to WebCore.gypi.

WebCore.gypi: Removed bidi.cpp and bidi.h

3:46 PM Changeset in webkit [45842] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-07-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

Update WebCore.gyp in preparation to hooking it up.

WebCore.gypi: Added files that were mid-stream while switching over.

3:41 PM Changeset in webkit [45841] by mrowe@apple.com

1 edit
1 add in trunk/LayoutTests

Add Leopard-specific results for fast/text/international/khmer-selection.html.

platform/mac-leopard/fast/text/international/khmer-selection-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/khmer-selection-expected.txt.

3:08 PM Changeset in webkit [45840] by dimich@chromium.org

2 edits in trunk/WebCore

2009-07-13 Dmitry Titov <dimich@chromium.org>

Not reviewed, another small fix for Chromium build.

bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):

3:00 PM Changeset in webkit [45839] by dimich@chromium.org

4 edits in trunk/WebCore

2009-07-13 Dmitry Titov <dimich@chromium.org>

Not reviewed, fix Chromium build bustage.

bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
bindings/v8/V8Proxy.cpp: (WebCore::JavaScriptConsoleMessage::addToPage):
bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::handleConsoleMessage):

1:45 PM Changeset in webkit [45838] by mrowe@apple.com

1 edit
1 add in trunk/LayoutTests

Add a missing layout test result to improve the quality of life of the Mac buildbots.

platform/mac/fast/text/international/khmer-selection-expected.txt: Added.

1:32 PM Changeset in webkit [45837] by Simon Fraser

2 edits in trunk/WebKit/mac

2009-07-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein, Adam Roben.

"Unrecognized selector" console log when the Safari 4 Welcome page navigates to Top Sites.
<rdar://problem/6994893

attachRootGraphicsLayer() should not assume that the frameView's documentView
is a WebHTMLView.

WebCoreSupport/WebChromeClient.mm: (WebChromeClient::attachRootGraphicsLayer):

1:16 PM Changeset in webkit [45836] by weinig@apple.com

3 edits
2 adds in trunk

WebCore:

2009-07-13 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27234
<rdar://problem/7054356>

Add null page check in HTMLDocument::hasFocus.

Test: fast/dom/HTMLDocument/hasFocus-frameless-crash.html

html/HTMLDocument.cpp: (WebCore::HTMLDocument::hasFocus): Add page null check. (WebCore::HTMLDocument::createTokenizer): Cleanup page null check.

LayoutTests:

2009-07-13 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Test for https://bugs.webkit.org/show_bug.cgi?id=27234
<rdar://problem/7054356>

fast/dom/HTMLDocument/hasFocus-frameless-crash-expected.txt: Added.
fast/dom/HTMLDocument/hasFocus-frameless-crash.html: Added.

1:13 PM Changeset in webkit [45835] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler.

Disable continuous spell checking in the inspector
https://bugs.webkit.org/show_bug.cgi?id=27131

inspector/front-end/inspector.html: Added spellcheck="false" to the

main-panels and console-prompt containers.

12:38 PM Changeset in webkit [45834] by andersca@apple.com

3 edits in trunk/WebKit/mac

2009-07-13 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler and Kevin Decker.

<rdar://problem/7053687> Core Animation plug-ins continue to grow larger and larger when opening new tabs (32 bit-only)

Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView setLayer:]): Add a FIXME.

Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setLayer:]): Make sure to set the size of the layer before changing the autoresizing mask so it won't grow everytime it's inserted into the layer tree.

12:14 PM Changeset in webkit [45833] by agl@chromium.org

3 edits
1 add in trunk

2009-07-13 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium Linux: fix assertion when rendering google.com.kh

https://bugs.webkit.org/show_bug.cgi?id=26924

Some shapers (i.e. Khmer) will produce cluster logs which report that
/no/ code points contributed to certain glyphs. Because of this, we
take any code point which contributed to the glyph in question, or any
subsequent glyph. If we run off the end, then we take the last code
point.

Added LayoutTests/fast/text/international/khmar-selection.html

platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::offsetForPositionForComplexText):

12:05 PM Changeset in webkit [45832] by mitz@apple.com

3 edits in trunk/WebCore

Reviewed by Darin Adler.

spellcheck="false" is ignored
<rdar://problem/7054177>

editing/Editor.cpp: (WebCore::markMisspellingsOrBadGrammar): Moved code to check the

spellcheck attribute from here...

(WebCore::Editor::spellCheckingEnabledInFocusedNode): ...to here.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Bail out

if spell chcking is disabled by the spellcheck attribute.

editing/Editor.h:

11:34 AM Changeset in webkit [45831] by bfulgham@webkit.org

9 edits
1 add in trunk

WebCore:

2009-07-13 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087

WebCore.vcproj/WebCore.vcproj: Add new WinCairo.vsprops to Debug_Cairo and Release_Cairo builds.
config.h: Check for presence of WIN_CAIRO and select appropriate configuration. Defaults to standard Apple build.

WebKit/win:

2009-07-13 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087

WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to Debug_Cairo and Release_Cairo targets.

WebKitLibraries:

2009-07-13 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087

win/tools/vsprops/WinCairo.vsprops: Added. Defines the new WIN_CAIRO flag used to drive non-Apple Windows build.

WebKitTools:

2009-07-13 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087

DumpRenderTree/config.h: Check for presence of WIN_CAIRO and select appropriate configuration. Defaults to standard Apple build.
DumpRenderTree/win/DumpRenderTree.vcproj: Add new WinCairo.vsprops to Debug_Cairo and Release_Cairo targets.

11:15 AM Changeset in webkit [45830] by pkasting@chromium.org

17 edits
1 move
5 deletes in trunk

WebCore:

2009-07-13 Peter Kasting <pkasting@google.com>

https://bugs.webkit.org/show_bug.cgi?id=19562
Back out previous patch for this bug (too many problems).

DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
html/HTMLButtonElement.idl:
html/HTMLFieldSetElement.idl:
html/HTMLFormControlElement.cpp:
html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::form):
html/HTMLInputElement.idl:
html/HTMLSelectElement.idl:
html/HTMLTextAreaElement.idl:
html/ValidityState.cpp: Removed.
html/ValidityState.h: Removed.
html/ValidityState.idl: Removed.

LayoutTests:

2009-07-13 Peter Kasting <pkasting@google.com>

https://bugs.webkit.org/show_bug.cgi?id=19562
Back out previous patch for this bug (too many problems).
This also re-enables fast/dom/domListEnumeration.html.

fast/dom/domListEnumeration.html: Copied from LayoutTests/fast/dom/domListEnumeration.html-disabled.
fast/dom/domListEnumeration.html-disabled: Removed.
fast/forms/ValidityState-001-expected.txt: Removed.
fast/forms/ValidityState-001.html: Removed.

11:11 AM Changeset in webkit [45829] by Nate Chapin

2 edits in trunk/WebCore

2009-07-13 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Add HTMLAllCollection to WebCore.gypi.

https://bugs.webkit.org/show_bug.cgi?id=27223

10:08 AM Changeset in webkit [45828] by bolsinga@apple.com

2 edits in trunk/WebKit/mac

2009-07-13 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

Correct these delegate methods' declarations by adding parameter names.

WebView/WebUIDelegatePrivate.h:

9:44 AM Changeset in webkit [45827] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Late NEWS file for 1.1.11.

NEWS:

9:40 AM Changeset in webkit [45826] by Dimitri Glazkov

3 edits
2 adds in trunk

WebCore:

2009-07-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

[V8] Add a missing check for constructor call in WebKitCSSMatrixConstructor.
https://bugs.webkit.org/show_bug.cgi?id=27218

Test: fast/css/matrix-as-function-crash.html

bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Added a check for constructor call.

LayoutTests:

2009-07-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

Make sure that calling WebKitCSSMatrix as function does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=27218

fast/css/matrix-as-function-crash-expected.txt: Added.
fast/css/matrix-as-function-crash.html: Added.

8:53 AM Changeset in webkit [45825] by kov@webkit.org

1 copy in releases/WebKitGTK/webkit-1.1.11

Tagging 1.1.11.

8:29 AM Changeset in webkit [45824] by kov@webkit.org

3 edits in trunk/WebKit/gtk

2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Changes to the doc control files for 1.1.11.

docs/webkitgtk-docs.sgml:
docs/webkitgtk-sections.txt:

8:23 AM Changeset in webkit [45823] by kov@webkit.org

2 edits in trunk

2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed build fix. Require the correct libsoup version now that
it's released.

configure.ac:

7:55 AM Changeset in webkit [45822] by Simon Hausmann

2 adds in trunk/WebKitTools/DumpRenderTree/qt/TestNetscapePlugin

Added .pro file missing from r45813

7:54 AM Changeset in webkit [45821] by vestbo@webkit.org

2 edits in trunk

2009-07-13 Laszlo Gombos <Laszlo Gombos>

Reviewed by Tor Arne Vestbø.

[Qt] Build fix for QtWebKit on Win
https://bugs.webkit.org/show_bug.cgi?id=27205

WebKit.pri: Include the major version number in the QtWebKit library file for Win.

7:32 AM Changeset in webkit [45820] by Simon Hausmann

2 edits in trunk/WebKit/qt

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Fix qdoc warnings for QWebPage::shouldInterruptJavaScript() and mention
how to re-implement it.

Api/qwebpage.cpp:

7:20 AM Changeset in webkit [45819] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Holger Freyther.

Fix unit test to use the correct assumption that the SoupMessage
will be NULL when WebKitNetworkRequest is created from an URI.

tests/testnetworkrequest.c: (test_network_request_create_destroy):

6:58 AM WebKit Team edited by treat@kde.org

(diff)

6:15 AM Changeset in webkit [45818] by Simon Hausmann

2 edits in trunk/LayoutTests

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Ariya Hidayat.

Unskip three more fast/js tests that pass with the Qt DRT.

platform/qt/Skipped:

6:04 AM Changeset in webkit [45817] by Simon Hausmann

3 edits
1 delete in trunk

WebKitTools:

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Always run the Qt DRT with the raster graphicssystem on X11, for
increased stability in the image based tests, in particular canvas.

DumpRenderTree/qt/main.cpp: (main):

LayoutTests:

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Removed Qt DRT specific result for canvas-getImageData as we pass this
test with the raster graphicssystem.

platform/qt/fast/canvas/canvas-getImageData-expected.txt: Removed.

5:29 AM Changeset in webkit [45816] by kov@webkit.org

4 edits in trunk

Unreviewed make dist build fix.

5:27 AM Changeset in webkit [45815] by vestbo@webkit.org

2 edits in trunk/WebCore

2009-07-13 Cédric Luthi <cedric.luthi@gmail.com>

Reviewed by Tor Arne Vestbø.

Fix NPWindow clip rect in PluginViewMac

The rect should be in window-coordinates. This bug can be observed
with Flash 10 here: http://www.permadi.com/tutorial/cursorTracker/

plugins/mac/PluginViewMac.cpp:

3:55 AM Changeset in webkit [45814] by Simon Hausmann

2 edits in trunk/WebKit/qt

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Fix crash with plugins when the plugin stream is cancelled.

Similar to r26667 handle the case where didReceiveResponse on the
plugin view results in failure to set up the stream and
setMainDocumentError being called instead. This will set the
m_pluginView back to 0 and we need check for it before calling
didReceiveData.

This was triggered by consecutive execution of
LayoutTests/plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
followed by LayoutTests/scrollbars/scrollbar-crash-on-refresh.html

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::committedLoad):

3:55 AM Changeset in webkit [45813] by Simon Hausmann

7 edits in trunk

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Add the test netscape plugin for the Qt DRT to the build.

WebKit.pro:

WebKitTools:

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Fix test netscape plugin usage with the Qt DRT.

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): Enable plugins in the settings.
Scripts/run-webkit-tests: Set the QT_WEBKIT_PLUGIN path to the correct build directory to make Qt DRT find the test netscape plugin.

LayoutTests:

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Enable a bunch of plugin layout tests for the Qt DRT.

platform/qt/Skipped:

3:53 AM Changeset in webkit [45812] by Simon Hausmann

2 edits in trunk/WebKitTools

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Make sure to disable the fixed contents size when resetting the page/view
state between test runs, to avoid side-effects.

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open): Call setFixedContentsSize() with an invalid QSize to disable the fixed layout.

3:52 AM Changeset in webkit [45811] by Simon Hausmann

4 edits in trunk

WebKitTools:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

When creating new windows, don't forget to connect the new
page's main frame. This ensures that for example the layoutTestController
is also available there.

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::createWindow):

LayoutTests:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Removed two more storage tests from the Qt DRT skip list that relied on
layoutTestController to be accessible in newly opened windows.

platform/qt/Skipped:

3:50 AM Changeset in webkit [45810] by Simon Hausmann

5 edits in trunk

WebKitTools:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Added support for LayoutTestController.setPrivateBrowsingEnabled.

DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setPrivateBrowsingEnabled):
DumpRenderTree/qt/jsobjects.h:

LayoutTests:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Removed three tests from the Qt DRT Skip list that rely on
LayoutTestController.setPrivateBrowsingEnabled and pass now.

platform/qt/Skipped:

3:49 AM Changeset in webkit [45809] by Simon Hausmann

11 edits in trunk

WebKit/qt:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Added QWebDatabase::removeAllDatabases, as a way to delete all
databases from the offline storage path.

Used by the Qt DRT.

Api/qwebdatabase.cpp: (QWebDatabase::removeAllDatabases):
Api/qwebdatabase.h:

WebKitTools:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Added support for database callbacks, storage quota setting,
and clearing of all databases.

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::dumpDatabaseQuota):
DumpRenderTree/qt/DumpRenderTree.h:
DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setDatabaseQuota): (LayoutTestController::clearAllDatabases):
DumpRenderTree/qt/jsobjects.h: (LayoutTestController::shouldDumpDatabaseCallbacks): (LayoutTestController::dumpDatabaseCallbacks):
DumpRenderTree/qt/main.cpp: (main):

LayoutTests:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Enable a bunch of more storage layout tests for the Qt DRT, now that
they pass.

platform/qt/Skipped:

3:48 AM Changeset in webkit [45808] by Simon Hausmann

4 edits in trunk

WebKitTools:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Setup the path in the Qt DRT for HTML 5 Databases, to enable some of
the storage layout tests.

DumpRenderTree/qt/main.cpp: (main):

LayoutTests:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Enable some storage layout tests in the Qt DRT, as the pass now.

platform/qt/Skipped:

3:46 AM Changeset in webkit [45807] by Simon Hausmann

2 edits in trunk/WebCore

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Fix Qt implementation of WebCore::directoryName to return the absolute
directory name instead of the base file name.

platform/qt/FileSystemQt.cpp: (WebCore::directoryName):

3:45 AM Changeset in webkit [45806] by Simon Hausmann

8 edits in trunk

WebKit/qt:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Added loadStarted() and loadFinished() signals to QWebFrame,
to allow load tracking of individual frames, as opposed to
QWebPage's loadStarted/loadFinished signals that are emitted
whenever _any_ child frame loads/finishes.

Api/qwebframe.cpp: Document new signals.
Api/qwebframe.h: Add new signals.
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::setFrame): Connect new signals.

WebKitTools:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Make the test output more robust by dumping only when the main
frame finishes loading, instead of when _any_ frame finishes.

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): Connect to the main frame's loadFinished() signal instead of the page's one.

LayoutTests:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Removed 20 more frame tests from the Qt skip list as they pass now
after making sure we only dump after the main frame's loadFinished
signal.

platform/qt/Skipped:

3:40 AM Changeset in webkit [45805] by Simon Hausmann

9 edits in trunk

WebKit/qt:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Add hooks for the GCController JavaScript interface needed by the
Qt DRT.

Fixed sort order of includes in qwebframe.cpp.

Api/qwebframe.cpp: (qt_drt_javaScriptObjectsCount): (qt_drt_garbageCollector_collect): (qt_drt_garbageCollector_collectOnAlternateThread):

WebKitTools:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Implement the GCController DRT interface in the Qt DRT.

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): Allocate the GCController. (WebCore::DumpRenderTree::initJSObjects): Register the interface with the JS engine.
DumpRenderTree/qt/DumpRenderTree.h: Declare m_gcController.
DumpRenderTree/qt/jsobjects.cpp: Implement GCController. (GCController::GCController): (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
DumpRenderTree/qt/jsobjects.h: Declare GCController.

LayoutTests:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Remove fast/frames/removal-before-attach-crash.html and
fast/dom/StyleSheet/ownerNode-lifetime-2.html from the Qt DRT skip
list, as they pass now with support for the GCController.

platform/qt/Skipped:

3:34 AM Changeset in webkit [45804] by Simon Hausmann

2 edits in trunk/WebCore

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Fix WebCore::Path::isEmpty() for the Qt port to return true
if there is no element in the path.

QPainterPath::isEmpty() returns also true if there is one single
MoveTo element inside, which makes sense but doesn't patch Webcore's
is-empty definition.

platform/graphics/qt/PathQt.cpp: (WebCore::Path::isEmpty): Use elementCount() == 0.

3:22 AM Changeset in webkit [45803] by jmalonzo@webkit.org

1 edit
1 add in trunk/WebKit/gtk/po

2009-07-13 Reinout van Schouwen <reinouts@gnome.org>

<https://bugs.webkit.org/show_bug.cgi?id=26980> [Gtk] Updated Dutch translation

Rubber-stamped by Jan Alonzo.

nl.po: Added.

3:11 AM Changeset in webkit [45802] by jmalonzo@webkit.org

4 edits in trunk

2009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org>

<https://bugs.webkit.org/show_bug.cgi?id=27171> [Gtk]
REGRESSION (r45440): fails at fast/events/frame-programmatic-focus.html

Reviewed by Gustavo Noronha.

Unskip fast/events/frame-programmatic-focus.html

platform/gtk/Skipped:

focus-in and focus-out events only get triggered when there's user
interaction, hence setFocused(bool) never gets called when
focusEvent is triggered when running the layout tests. The
solution seems to be to implement grab-focus too so we can call
setFocused(bool) when a widget has focus.

webkit/webkitwebview.cpp: (webkit_web_view_grab_focus): (webkit_web_view_focus_in_event): (webkit_web_view_class_init):

2:57 AM Changeset in webkit [45801] by jmalonzo@webkit.org

12 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=26718 [Gtk] Add support for javascript windows for DRT

Reviewed by Gustavo Noronha and Xan Lopez.

Unskip tests that now pass due to support for JS windows in Gtk DRT.

platform/gtk/Skipped:

Add API to support opening and closing of JavaScript windows automatically.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
webkit/webkitprivate.h:
webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
webkit/webkitwebview.cpp: (webkit_web_view_real_close_web_view): (webkit_web_view_class_init): (webkit_web_view_update_settings): (webkit_web_view_settings_notify): (webkit_web_view_set_group_name):
webkit/webkitwebview.h:

Support running of tests that open and close JS windows automatically.

DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpFramesAsText): (dumpBackForwardListForAllWebViews): (resetWebViewToConsistentStateBeforeTesting): (dump): (runTest): (webViewClose): (createWebView): (webViewCreate): (main):
DumpRenderTree/gtk/DumpRenderTreeGtk.h:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::windowCount): (LayoutTestController::setPopupBlockingEnabled):

2:47 AM Changeset in webkit [45800] by Simon Hausmann

3 edits in trunk/LayoutTests

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Oliver Hunt.

Tweak mouseout-dead-subframe.html to be more robust.

The test calls notifyDone() and then dumpAsText(). The latter call has no effect
as notifyDone() performs the dump, but it passes in the mac DRT because the mime-type
of the .html file is detected as text/plain and therefore the text is dumped instead
of the render tree.

Changed the testcase to call dumpAsText() first and then notifyDone(), to make it
pass without relying on the mime type detection.

That also makes the test pass in the Qt DRT.

fast/events/mouseout-dead-subframe.html: Swapped notifyDone() and dumpAsText() calls to call the former before the latter.
platform/qt/Skipped: Removed skipped test.

2:36 AM Changeset in webkit [45799] by levin@chromium.org

2 edits in trunk/WebKitTools

2009-07-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Maciej Stachowiak.

prepare-ChangeLog should decode HTML entities in short description
https://bugs.webkit.org/show_bug.cgi?id=27122

Decode the short description by adding a function which decodes HTML
entities. It can decode &, <, >, ", and ' . They may be sufficient
as the description seems to be encoded by xml_quote in
http://mxr.mozilla.org/bugzilla/source/Bugzilla/Util.pm

Scripts/prepare-ChangeLog:

2:31 AM Changeset in webkit [45798] by levin@chromium.org

2 edits in trunk/WebCore

2009-07-13 Albert J. Wong <ajwong@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream fixes to NPV8Object.cpp that make ~30 layout tests pass.
https://bugs.webkit.org/show_bug.cgi?id=27127

There were a number of bugs introduced during the last upstreaming
effort that broke around 30 layout tests. This fixes those bugs.
It also has compile fixes to match the recent cutting apart of
V8Proxy.

bindings/v8/NPV8Object.cpp: (freeV8NPObject): (npCreateV8ScriptObject): (NPN_Invoke): (NPN_InvokeDefault): (NPN_EvaluateHelper): (NPN_SetException): (NPN_Construct):

2:31 AM Changeset in webkit [45797] by levin@chromium.org

2 edits in trunk/WebCore

2009-07-13 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

Fix memory leak in the V8 binding layer.
https://bugs.webkit.org/show_bug.cgi?id=27163

Reinitializing the context is not necessary when clearing the proxy for navigation
and it will lead us to hold on to an empty context for each frame.

Test for empty context instead of empty global object handle when
updating the document for a context.

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::updateDocument):

2:31 AM Changeset in webkit [45796] by levin@chromium.org

2 edits in trunk/WebCore

2009-07-13 John Gregg <johnnyg@google.com>

Reviewed by David Levin.

Correct the logic to determine if a V8 callback returns a value.
https://bugs.webkit.org/show_bug.cgi?id=27155

bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback):
Don't crash if result.IsEmpty().

1:58 AM Changeset in webkit [45795] by levin@chromium.org

25 edits
16 adds in trunk

2009-07-13 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Added ENABLE(SHARED_WORKERS) flag.

configure.ac:

JavaScriptCore:

Added ENABLE(SHARED_WORKERS) flag (off by default).

Configurations/FeatureDefines.xcconfig:

WebCore:

Initial IDL definition and bindings for SharedWorkers.

Configurations/FeatureDefines.xcconfig: Added new files for SharedWorker support.
DerivedSources.make: Added new files for SharedWorker support.
GNUmakefile.am: Added new files for SharedWorker support.
WebCore.gypi: Added new files for SharedWorker support.
WebCore.pro: Added new files for SharedWorker support.
WebCore.xcodeproj/project.pbxproj: Added new files for SharedWorker support.
bindings/js/JSAbstractWorkerCustom.cpp: Added. (WebCore::JSAbstractWorker::mark): Custom mark handler that marks the event listeners. (WebCore::JSAbstractWorker::addEventListener): (WebCore::JSAbstractWorker::removeEventListener): (WebCore::JSAbstractWorker::toJS): Custom toJS handler which differentiates between various subclasses.
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::sharedWorker): SharedWorker constructor (only enabled when SHARED_WORKERS is enabled).
bindings/js/JSEventTarget.cpp: (WebCore::toJS): (WebCore::toEventTarget): Added support for converting to/from SharedWorkers.
bindings/js/JSSharedWorkerConstructor.cpp: Added. (WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor): (WebCore::constructSharedWorker): (WebCore::JSSharedWorkerConstructor::getConstructData):
bindings/js/JSSharedWorkerConstructor.h: Added. (WebCore::JSSharedWorkerConstructor::classInfo):
bindings/js/JSSharedWorkerCustom.cpp: Added. (WebCore::JSSharedWorker::mark): Custom mark function that marks the internal MessagePort.
bindings/v8/DOMObjectsInclude.h: Updated to include new header files.
bindings/v8/V8Index.cpp:
bindings/v8/V8Index.h:
bindings/v8/custom/V8AbstractWorkerCustom.cpp: Added. (WebCore::getEventListener): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): V8 handlers for add/removeEventListener().
bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8SharedWorkerCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): Custom constructor for SharedWorker.
dom/EventTarget.cpp: (WebCore::EventTarget::toSharedWorker):
dom/EventTarget.h:
page/DOMWindow.idl:
workers/AbstractWorker.cpp: Added. (WebCore::AbstractWorker::AbstractWorker): Common base class for SharedWorker and (soon) Worker. The functions below were copied from Worker.cpp. This is the first step in refactoring Worker to derive from AbstractWorker to enable code sharing. (WebCore::AbstractWorker::~AbstractWorker): (WebCore::AbstractWorker::addEventListener): (WebCore::AbstractWorker::removeEventListener): (WebCore::AbstractWorker::dispatchEvent): (WebCore::AbstractWorker::dispatchLoadErrorEvent): (WebCore::AbstractWorker::dispatchScriptErrorEvent):
workers/AbstractWorker.h: Added. Definitions of functionality shared by Worker.h and SharedWorker.h. In a future patch, Worker will derive from AbstractWorker. (WebCore::AbstractWorker::scriptExecutionContext): (WebCore::AbstractWorker::setOnerror): (WebCore::AbstractWorker::onerror): (WebCore::AbstractWorker::eventListeners): (WebCore::AbstractWorker::refEventTarget): (WebCore::AbstractWorker::derefEventTarget):
workers/AbstractWorker.idl: Added.
workers/SharedWorker.cpp: Added. (WebCore::SharedWorker::SharedWorker): (WebCore::SharedWorker::~SharedWorker):
workers/SharedWorker.h: Added. (WebCore::SharedWorker::create): (WebCore::SharedWorker::port): (WebCore::SharedWorker::toSharedWorker):
workers/SharedWorker.idl: Added.

WebKit/mac:

Added ENABLE(SHARED_WORKERS) flag (disabled by default).

Configurations/FeatureDefines.xcconfig:

WebKitTools:

Added support for --shared-workers (turned off by default)

Scripts/build-webkit:

LayoutTests:

Unit tests for new SharedWorker APIs (disabled by default).

fast/workers/shared-worker-constructor-expected.txt: Added.
fast/workers/shared-worker-constructor.html-disabled: Added.
fast/workers/shared-worker-event-listener-expected.txt: Added.
fast/workers/shared-worker-event-listener.html-disabled: Added.

1:32 AM Changeset in webkit [45794] by Simon Hausmann

2 edits in trunk/WebCore

2009-07-13 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Cleanup - Remove prf install target
https://bugs.webkit.org/show_bug.cgi?id=27191

qtwebkit.prf has been removed; this cleans up the related
install target as well.

WebCore.pro: Remove prf install target

1:30 AM Changeset in webkit [45793] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2009-07-07 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Maciej Stachoviak.

https://bugs.webkit.org/show_bug.cgi?id=27058

Removed superfluous parenthesis around single expression.
Compilers on Symbian platform fail to properly parse and compile.

JavaScriptCore/wtf/Platform.h:

1:24 AM Changeset in webkit [45792] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2009-07-13 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Maciej Stachoviak.

https://bugs.webkit.org/show_bug.cgi?id=27054

Renamed Translator to HashTranslator

Codewarrior compiler (WINSCW) latest b482 cannot resolve typename
mismatch between template declaration and definition
(HashTranslator / Translator)

wtf/HashSet.h:

1:20 AM Changeset in webkit [45791] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2009-07-13 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27053

Ambiguity in LabelScope initialization

Codewarrior compiler (WINSCW) latest b482 on Symbian cannot resolve
type of "0" unambiguously. Set expression explicitly to
PassRefPtr<Label>::PassRefPtr()

bytecompiler/BytecodeGenerator.cpp

Jul 12, 2009:

11:12 PM Changeset in webkit [45790] by bfulgham@webkit.org

10 edits in trunk/WebKit

WebKit/gtk:

2009-07-12 Brent Fulgham <bfulgham@gmail.com>

Speculative build fix after http://trac.webkit.org/changeset/45786.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::addMessageToConsole):
WebCoreSupport/ChromeClientGtk.h:

WebKit/qt:

2009-07-12 Brent Fulgham <bfulgham@gmail.com>

Speculative build fix after http://trac.webkit.org/changeset/45786.

WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::addMessageToConsole):
WebCoreSupport/ChromeClientQt.h:

WebKit/wx:

2009-07-12 Brent Fulgham <bfulgham@gmail.com>

Speculative build fix after http://trac.webkit.org/changeset/45786.

WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::addMessageToConsole):
WebKitSupport/ChromeClientWx.h:

11:02 PM Changeset in webkit [45789] by bfulgham@webkit.org

2 edits in trunk/WebKit/win

2009-07-12 Brent Fulgham <bfulgham@gmail.com>

Speculative Windows build fix after http://trac.webkit.org/changeset/45786.

WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::addMessageToConsole):

10:38 PM Changeset in webkit [45788] by abarth@webkit.org

1 edit in trunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-script-src.pl

Fix executable bit. We should fix bugzilla-tool to understand executable bits.

10:36 PM Changeset in webkit [45787] by abarth@webkit.org

6 edits
7 adds in trunk

2009-07-12 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

Facebook Chat is broken due to XSS auditor
https://bugs.webkit.org/show_bug.cgi?id=27179

Instead of just using the script's URL as to detect an XSS attack, we
now use a bit of context before the URL. In particular, we use the
bytes from the beginning of the attribute name to the end of the
attribute value. In virtually all injection attacks, the attacker
would need to supply the attribute name as well as the attribute value.
However, in the Facebook false positive, the attribute name is not
present in the URL.

Tests: http/tests/security/xssAuditor/script-tag-src-redirect-safe.html

http/tests/security/xssAuditor/script-tag-with-source-double-quote.html
http/tests/security/xssAuditor/script-tag-with-source-no-quote.html

html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
html/HTMLTokenizer.h:
page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
page/XSSAuditor.h:

2009-07-12 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

Facebook Chat is broken due to XSS auditor
https://bugs.webkit.org/show_bug.cgi?id=27179

Add some more test coverage to our handling of script tags with src
attributes. Also, ensure that we don't raise the alarm when a URL
parameter is injected directly into the attribute value.

http/tests/security/xssAuditor/resources/echo-script-src.pl: Added.
http/tests/security/xssAuditor/script-tag-src-redirect-safe-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/base-href-safe-expected.txt.
http/tests/security/xssAuditor/script-tag-src-redirect-safe.html: Added.
http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt.
http/tests/security/xssAuditor/script-tag-with-source-double-quote.html: Added.
http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt.
http/tests/security/xssAuditor/script-tag-with-source-no-quote.html: Added.

10:08 PM Changeset in webkit [45786] by bfulgham@webkit.org

36 edits in trunk

WebCore:

2009-07-12 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Refactor ConsoleMessage to add MessageType attribute.
https://bugs.webkit.org/show_bug.cgi?id=20625

bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::printErrorMessage):
dom/Document.cpp: (WebCore::Document::reportException): (WebCore::Document::addMessage):
dom/Document.h:
dom/ScriptExecutionContext.h:
html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::isEqual):
inspector/ConsoleMessage.h:
inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::endGroup): (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole): (WebCore::InspectorController::count):
inspector/InspectorController.h:
inspector/front-end/Console.js: (WebInspector.Console.prototype.addMessage): (WebInspector.ConsoleMessage): Added type property. (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype.toString): (WebInspector.ConsoleMessage.prototype.isEqual): (WebInspector.ConsoleCommandResult): (WebInspector.ConsoleGroup.prototype.addMessage): (WebInspector.ConsoleGroup.prototype._titleClicked):
inspector/front-end/Resource.js: (WebInspector.Resource.prototype._addTip): (WebInspector.Resource.prototype._checkWarning):
inspector/front-end/inspector.css: Changed ".console-group-title-level" to ".console-group-title"
inspector/front-end/inspector.js: (WebInspector.addMessageToConsole):
loader/DocLoader.cpp: (WebCore::DocLoader::printAccessDeniedMessage):
loader/EmptyClients.h: (WebCore::EmptyChromeClient::addMessageToConsole):
loader/FrameLoader.cpp: (WebCore::FrameLoader::reportLocalLoadFailed): (WebCore::FrameLoader::shouldAllowNavigation):
page/ChromeClient.h:
page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix): (WebCore::Console::addMessage): (WebCore::Console::error): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::trace): (WebCore::Console::assertCondition): (WebCore::Console::timeEnd): (WebCore::Console::warn):
page/Console.h: Added MessageType enum. (WebCore::):
page/DOMWindow.cpp: (WebCore::DOMWindow::postMessageTimerFired):
page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject):
svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::reportWarning): (WebCore::SVGDocumentExtensions::reportError):
wml/WMLErrorHandling.cpp: (WebCore::reportWMLError):
workers/GenericWorkerTask.h: Added GenericWorkerTask8 for the extra argument. (WebCore::GenericWorkerTask8::create): (WebCore::GenericWorkerTask8::GenericWorkerTask8): (WebCore::GenericWorkerTask8::performTask): (WebCore::createCallbackTask):
workers/WorkerContext.cpp: (WebCore::WorkerContext::addMessage): (WebCore::WorkerContext::importScripts):
workers/WorkerContext.h:
workers/WorkerMessagingProxy.cpp: (WebCore::postConsoleMessageTask): (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
workers/WorkerMessagingProxy.h:
workers/WorkerObjectProxy.h:
xml/XMLHttpRequest.cpp: (WebCore::reportUnsafeUsage): (WebCore::XMLHttpRequest::didFinishLoading):
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::parseErrorFunc):

WebKit/mac:

2009-07-12 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Refactor ConsoleMessage to add MessageType attribute.
https://bugs.webkit.org/show_bug.cgi?id=20625

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addMessageToConsole):

9:07 PM Changeset in webkit [45785] by bfulgham@webkit.org

7 edits
1 add in trunk/WebCore

2009-07-12 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Upstream UndetectableHTMLCollection.idl as HTMLAllCollection.idl.

https://bugs.webkit.org/show_bug.cgi?id=27132

bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/DOMObjectsInclude.h:
bindings/v8/DerivedSourcesAllInOne.cpp:
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::instantiateV8Object):
bindings/v8/V8Index.cpp:
bindings/v8/V8Index.h:
dom/HTMLAllCollection.idl: Added.

8:55 PM Changeset in webkit [45784] by bfulgham@webkit.org

2 edits in trunk/WebCore

2009-07-12 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Maciej Stachowiak.

Inspector: Duplicate Computation in Autocompletion
https://bugs.webkit.org/show_bug.cgi?id=26778

inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._completionsReady):

6:43 PM Changeset in webkit [45783] by eric.carlson@apple.com

2 edits
2 adds in trunk/LayoutTests

2009-07-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27197
QuickTime supports data: urls, add a layout test.

media/audio-data-url-expected.txt: Added.
media/audio-data-url.html: Added.

New test.

platform/gtk/Skipped:

Skip the new test.

5:54 PM Changeset in webkit [45782] by mitz@apple.com

10 edits
1 move
1 delete in trunk

WebCore:

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=27196
Rename bidi.cpp to RenderBlockLineLayout.cpp and remove bidi.h

GNUmakefile.am: Updated.
WebCore.gypi: Updated.
WebCore.pro: Updated.
WebCore.vcproj/WebCore.vcproj: Updated.
WebCore.xcodeproj/project.pbxproj: Updated.
WebCoreSources.bkl: Updated.
rendering/RenderBlock.h: Removed unnecessary forward declaration and

updated comments.

rendering/RenderBlockLineLayout.cpp: Copied from WebCore/rendering/bidi.cpp.

Removed unnecessary #include statements.

(WebCore::BidiRun::BidiRun): Moved here from bidi.h.
(WebCore::RenderBlock::layoutInlineChildren): Removed outdated comment.

rendering/bidi.cpp: Removed.
rendering/bidi.h: Removed.

WebKitTools:

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=27196
Update check-for-global-initializers for the renaming for bidi.cpp to
RenderBlockLineLayout.cpp

Scripts/check-for-global-initializers:

4:48 PM Changeset in webkit [45781] by mitz@apple.com

2 edits in trunk/WebCore

Windows build fix

4:41 PM Changeset in webkit [45780] by mitz@apple.com

6 edits in trunk/WebCore

Reviewed by Sam Weinig.

Image cleanup

platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData): Use the data() accessor instead of the m_data member. (WebCore::BitmapImage::dataChanged): Ditto.
platform/graphics/Image.h: Re-ordered #includes and class declarations. Removed the drawPatternCallback() declaration. Made member variables private.
platform/graphics/cg/ImageCG.cpp: (WebCore::drawPatternCallback): Changed this from a member function to a static function.
platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged): Use the data() accessor instead of the m_data member.
svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Ditto.

2:49 PM Changeset in webkit [45779] by mrowe@apple.com

7 edits in branches/safari-4-branch

Merge r45758.

2:49 PM Changeset in webkit [45778] by mrowe@apple.com

2 edits in branches/safari-4-branch/WebCore

Merge r45755.

2:49 PM Changeset in webkit [45777] by mrowe@apple.com

3 edits in branches/safari-4-branch/WebKit/mac

Merge r45745.

2:49 PM Changeset in webkit [45776] by mrowe@apple.com

18 edits in branches/safari-4-branch

Merge r45744.

2:49 PM Changeset in webkit [45775] by mrowe@apple.com

3 edits in branches/safari-4-branch/JavaScriptCore

Merge r45736.

2:49 PM Changeset in webkit [45774] by mrowe@apple.com

3 edits in branches/safari-4-branch/JavaScriptCore

Merge r45735.

2:48 PM Changeset in webkit [45773] by mrowe@apple.com

2 edits in branches/safari-4-branch/WebCore

Merge r45734.

2:48 PM Changeset in webkit [45772] by mrowe@apple.com

7 edits in branches/safari-4-branch

Merge r45733.

2:48 PM Changeset in webkit [45771] by mrowe@apple.com

5 edits in branches/safari-4-branch/WebCore

Merge r45732.

2:48 PM Changeset in webkit [45770] by mrowe@apple.com

2 edits in branches/safari-4-branch/WebCore

Merge r45728.

2:48 PM Changeset in webkit [45769] by mrowe@apple.com

2 edits in branches/safari-4-branch/WebCore

Merge r45721.

2:48 PM Changeset in webkit [45768] by mrowe@apple.com

3 edits in branches/safari-4-branch/WebCore

Merge r45715.

2:48 PM Changeset in webkit [45767] by mrowe@apple.com

5 edits
2 adds in branches/safari-4-branch

Merge r45710.

2:48 PM Changeset in webkit [45766] by mrowe@apple.com

169 edits in branches/safari-4-branch

2009-07-10 Beth Dakin <Beth Dakin>

<rdar://problem/7045243> Roll text metrics change out

css/html.css:
platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
platform/graphics/SimpleFontData.h:
platform/graphics/mac/SimpleFontDataMac.mm:
platform/graphics/win/SimpleFontDataCGWin.cpp:
platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth):

2:47 PM Changeset in webkit [45765] by mrowe@apple.com

29 edits in branches/safari-4-branch

<rdar://problem/7047403> Disable channel messaging

2:47 PM Changeset in webkit [45764] by mrowe@apple.com

14 edits in branches/safari-4-branch

<rdar://problem/7048551> Disable datagrid

2:46 PM Changeset in webkit [45763] by abarth@webkit.org

3 edits
3 adds in trunk

2009-07-12 Daniel Bates <dbates@intudata.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27189

Fixes insufficient check in XSSAuditor::canSetBaseElementURL that caused
XSSAuditor to incorrectly block HTML Base elements whose base path coincided
with the URL of the page.

Test: http/tests/security/xssAuditor/base-href-safe3.html

page/XSSAuditor.cpp: (WebCore::XSSAuditor::canSetBaseElementURL): Changed conditional to only call XSSAuditor::findInRequest() if the host in the page URL disagrees with the host in the base element URL.

2009-07-12 Daniel Bates <dbates@intudata.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27189

Tests that XSSAuditor does not block HTML Base elements whose path has the
same host as the page.

http/tests/security/xssAuditor/base-href-safe3-expected.txt: Added.
http/tests/security/xssAuditor/base-href-safe3.html: Added.
http/tests/security/xssAuditor/resources/base-href/base-href-safe3.html: Added.

1:27 PM Changeset in webkit [45762] by Darin Adler

9 edits in trunk/WebCore

2009-07-12 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Text searching with ICU should take the user's default locale into account
https://bugs.webkit.org/show_bug.cgi?id=27184
rdar://problem/6812121

No simple way to test this since it's dependent on user locale.
After this, the user's default locale is used only on Mac.

editing/TextIterator.cpp: (WebCore::createSearcher): Pass result of the currentSearchLocaleID function as the locale.

platform/text/TextBreakIteratorInternalICU.h: Added declaration of currentSearchLocaleID function.

platform/text/android/TextBreakIteratorInternalICU.cpp: (WebCore::currentSearchLocaleID): Added. Returns the empty string.
platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: (WebCore::currentSearchLocaleID): Ditto.
platform/text/gtk/TextBreakIteratorInternalICUGtk.cpp: (WebCore::currentSearchLocaleID): Ditto.

platform/text/mac/TextBreakIteratorInternalICUMac.mm: (WebCore::textBreakLocalePreference): Added. Returns the value of the AppleTextBreakLocale preference. (WebCore::topLanguagePreference): Added. Returns the value of the first item in the AppleLanguages preference. (WebCore::canonicalLanguageIdentifier): Added. Cover for the CFLocaleCreateCanonicalLanguageIdentifierFromString function. (WebCore::getLocale): Added. Transfers the locale from a CFStringRef into a buffer. (WebCore::getSearchLocale): Added. Calls topLanguagePreference, canonicalLanguageIdentifier, and getLocale. (WebCore::currentSearchLocaleID): Added. Calls getSearchLocale once. (WebCore::getTextBreakLocale): Changed to call textBreakLocalePreference, topLanguagePreference, canonicalLanguageIdentifier, and getLocale.

platform/text/win/TextBreakIteratorInternalICUWin.cpp: (WebCore::currentSearchLocaleID): Added. Returns the empty string.
platform/wx/TemporaryLinkStubs.cpp: (WebCore::currentSearchLocaleID): Ditto.

11:42 AM Changeset in webkit [45761] by xan@webkit.org

2 edits in trunk

2009-07-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump version in preparation for 1.1.11 release.

configure.ac:

10:25 AM Changeset in webkit [45760] by xan@webkit.org

2 edits in trunk/WebCore

2009-07-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Create a PangoLayout that properly represents the visual
appearance of the text in the web page so that the line boundary
modes of getText{At,Before,After}Offset work correctly.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (UTF16ToUTF8): (g_substr): (convertUniCharToUTF8): (getPangoLayoutForAtk):

Jul 11, 2009:

10:17 PM Changeset in webkit [45759] by oliver@apple.com

3 edits
3 adds in trunk

Bug 27187 - Match Gecko behaviour for canvas path mutation APIs on an empty path
<https://bugs.webkit.org/show_bug.cgi?id=27187>

Reviewed by Simon Fraser

Simple API change, check for the empty path and add appropriate point if necessary.

Test: fast/canvas/canvas-modify-emptyPath.html

7:15 PM Changeset in webkit [45758] by eric.carlson@apple.com

7 edits in trunk

2009-07-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

HTMLMediaElement.canPlayType "maybe" and "probably" reversed
https://bugs.webkit.org/show_bug.cgi?id=27186

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::supportsType):

Return "probably" if type has codecs parameter.

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsType):

Ditto.

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::supportsType):

Ditto.

2009-07-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

HTMLMediaElement.canPlayType "maybe" and "probably" reversed
https://bugs.webkit.org/show_bug.cgi?id=27186

media/video-can-play-type-expected.txt:
media/video-can-play-type.html:

1:26 PM Changeset in webkit [45757] by mrowe@apple.com

5 edits in trunk

Versioning.

1:24 PM Changeset in webkit [45756] by mrowe@apple.com

1 copy in branches/safari-4-branch

New branch.

12:21 PM Changeset in webkit [45755] by beidson@apple.com

2 edits in trunk/WebCore

2009-07-11 Brady Eidson <beidson@apple.com>

Reviewed by Mark Rowe.

A worker-thread inspired follow-up for:
https://bugs.webkit.org/show_bug.cgi?id=26496 and <rdar://problem/7046520>
REGRESSION: XHR stream connection blocks iFrame loading and resource downloading

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously): Don't perform the XHR compensation when the XHR is running on a worker thread. Accessing the global Cache data structures from a non-main thread is not currently supported.

11:44 AM Changeset in webkit [45754] by Simon Fraser

10 edits
6 moves
35 adds in trunk

2009-07-11 Simon Fraser <Simon Fraser>

Enable support for accelerated compositing and 3d transforms on Leopard.
<https://bugs.webkit.org/show_bug.cgi?id=20166>
<rdar://problem/6120614>

Reviewed by Oliver Hunt.

3:18 AM Changeset in webkit [45753] by Simon Hausmann

3 edits in trunk/WebCore

2009-07-11 Simon Hausmann <Simon Hausmann>

Fix the Qt build after r45724.

bridge/qt/qt_instance.cpp: (JSC::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp):
bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):

Jul 10, 2009:

11:46 PM Changeset in webkit [45752] by abarth@webkit.org

4 edits
16 adds in trunk

WebCore:

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26921

Implements support for HTML entities, so XSSAuditor can protect against attacks
encoded with HTML entities.

Tests: http/tests/security/xssAuditor/inline-event-HTML-entities.html

http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char.html
http/tests/security/xssAuditor/javascript-link-HTML-entities-named.html
http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char.html
http/tests/security/xssAuditor/javascript-link-HTML-entities.html
http/tests/security/xssAuditor/link-onclick-entities.html
http/tests/security/xssAuditor/script-tag-entities.html
http/tests/security/xssAuditor/script-tag-with-source-entities.html

page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::decodeURL): Modified to call WebCore::XSSAuditor::decodeHTMLEntities to decode HTML entities. (WebCore::XSSAuditor::decodeHTMLEntities): Added method to decode HTML entities. (WebCore::XSSAuditor::findInRequest):
page/XSSAuditor.h:

LayoutTests:

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26921

Tests protection against HTML entities encoded attacks.

http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt: Added.
http/tests/security/xssAuditor/inline-event-HTML-entities.html: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char.html: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities-named.html: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char.html: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities.html: Added.
http/tests/security/xssAuditor/link-onclick-entities-expected.txt: Added.
http/tests/security/xssAuditor/link-onclick-entities.html: Added.
http/tests/security/xssAuditor/script-tag-entities-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-entities.html: Added.
http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-source-entities.html: Added.

11:25 PM Changeset in webkit [45751] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/27173> svn-apply: Fix typo in git command used to find deleted files

Reviewed by Eric Seidel.

Scripts/svn-apply: (scmWillDeleteFile): Changed 'head' to 'HEAD'.

11:16 PM Changeset in webkit [45750] by ddkilzer@apple.com

11 edits in trunk

Bug 27007: Build fixes when ICONDATABASE is disabled

<https://bugs.webkit.org/show_bug.cgi?id=27007>

Reviewed by Sam Weinig.

WebCore:

WebCore.xcodeproj/project.pbxproj: Added IconDatabaseNone.cpp to the project.
loader/icon/IconDatabase.cpp: Added #if ENABLE(ICONDATABASE)/#endif macro guard.
loader/icon/IconDatabase.h: Removed three public methods from #if ENABLE(ICONDATABASE)/#endif macro so that they may be stubbed out in IconDatabaseNone.cpp.
loader/icon/IconDatabaseNone.cpp: Added #if !ENABLE(ICONDATABASE)/#endif macro guard. (WebCore::IconDatabase::importIconURLForPageURL): Added. (WebCore::IconDatabase::importIconDataForIconURL): Added. (WebCore::IconDatabase::shouldStopThreadActivity): Added.

WebKit/mac:

Misc/WebIconDatabase.mm: (defaultClient): Return 0 if ICONDATABASE is disabled.
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveIcon): Commented out the body of the method if ICONDATABASE is disabled. (WebFrameLoaderClient::registerForIconNotification): Ditto.
WebCoreSupport/WebIconDatabaseClient.mm: Added #if ENABLE(ICONDATABASE)/#endif guard to source.
WebView/WebView.mm: (-[WebView setFrameLoadDelegate:]): Wrapped code that starts the icon database machinery in #if ENABLE(ICONDATABASE)/#endif. (-[WebView _registerForIconNotification:]): Wrapped method in #if ENABLE(ICONDATABASE)/#endif guard. (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Ditto.
WebView/WebViewInternal.h: Wrapped methods in #if ENABLE(ICONDATABASE)/#endif guard. (-[WebView _registerForIconNotification:]): (-[WebView _dispatchDidReceiveIconFromWebFrame:]):

11:02 PM Changeset in webkit [45749] by abarth@webkit.org

6 edits
7 copies in trunk

WebCore:

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27151

Fixes issue where JavaScript URLs that contain null- and non-null control characters can
bypass XSSAuditor.

Tests: http/tests/security/xssAuditor/javascript-link-control-char.html

http/tests/security/xssAuditor/javascript-link-null-char.html
http/tests/security/xssAuditor/javascript-link.html

bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): Separated out logic for JavaScript URLs from inline scripts. For JavaScript URLs, calls XSSAuditor::canEvaluateJavaScriptURL.
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): Made similar changes to evaluate() as in bindings/js/ScriptController.cpp.
page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Separated out logic for JavaScript URLs into its own method.
page/XSSAuditor.h:

LayoutTests:

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27151

Tests prevention of JavaScript URLs that contain null- and non-null control characters.

http/tests/security/xssAuditor/javascript-link-control-char-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-control-char.html: Added.
http/tests/security/xssAuditor/javascript-link-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-null-char-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-null-char.html: Added.
http/tests/security/xssAuditor/javascript-link.html: Added.
http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Added.

10:50 PM Changeset in webkit [45748] by jmalonzo@webkit.org

2 edits in trunk/LayoutTests

2009-07-10 Jan Michael Alonzo <jmalonzo@webkit.org>

Skip tests in the Gtk port that

are dependent on eventSender
require platform-specific results
regressed (with links to the regression bug report)
failing (due to missing/incomplete implementation)

platform/gtk/Skipped:

10:36 PM Changeset in webkit [45747] by ddkilzer@apple.com

141 edits in trunk/WebCore

2009-07-10 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Kilzer.

WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Fix bunch of style issues by autofix of cpplint.
This patch is created to demonstrate the autofix of cpplint.py.

No new testcases because it's a style fix

css/CSSParser.cpp: (WebCore::CSSParser::parseMediaQuery): (WebCore::CSSParser::validUnit): (WebCore::CSSParser::parseValue): (WebCore::skipCommaInDashboardRegion): (WebCore::CSSParser::parseDashboardRegions): (WebCore::ShadowParseContext::commitValue): (WebCore::ShadowParseContext::commitLength): (WebCore::ShadowParseContext::commitColor): (WebCore::BorderImageParseContext::commitNumber): (WebCore::BorderImageParseContext::commitWidth): (WebCore::BorderImageParseContext::commitRule): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::lex): (WebCore::CSSParser::text):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
css/MediaList.cpp: (WebCore::MediaList::deleteMedium):
css/MediaQuery.h:
css/MediaQueryEvaluator.cpp: (WebCore::parseAspectRatio):
css/MediaQueryEvaluator.h:
css/MediaQueryExp.h: (WebCore::MediaQueryExp::operator==):
css/WebKitCSSMatrix.h:
dom/Comment.h:
dom/Document.cpp: (WebCore::Document::setFocusedNode):
dom/Document.h: (WebCore::Document::setHasDashboardRegions):
dom/DocumentFragment.cpp: (WebCore::DocumentFragment::nodeName):
dom/DocumentFragment.h:
dom/DynamicNodeList.h:
dom/EditingText.h:
dom/Element.cpp: (WebCore::Element::dispatchAttrAdditionEvent):
dom/NamedAttrMap.cpp: (WebCore::NamedNodeMap::item):
dom/Node.cpp: (WebCore::Node::nodeValue): (WebCore::Node::nodeIndex):
dom/NodeRareData.h: (WebCore::NodeListsNodeData::create):
dom/Notation.h:
dom/ProcessingInstruction.h:
dom/Range.cpp: (WebCore::Range::processContents):
dom/StyledElement.cpp: (WebCore::toHex):
dom/XMLTokenizerLibxml2.cpp: (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::): (WebCore::OffsetBuffer::readOutBytes): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::attributesStartElementNsHandler):
dom/XMLTokenizerQt.cpp: (WebCore::attributesStartElementNsHandler): (WebCore::XMLTokenizer::parseStartElement):
editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle):
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode):
editing/Editor.cpp: (WebCore::Editor::pasteAsPlainText):
editing/SelectionController.cpp: (WebCore::SelectionController::directionOfEnclosingBlock):
editing/SmartReplaceICU.cpp: (WebCore::addAllCodePoints):
history/HistoryItem.cpp: (WebCore::HistoryItem::icon): (WebCore::HistoryItem::adoptVisitCounts):
html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyFillColor):
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setActive): (WebCore::HTMLAnchorElement::isLiveLink):
html/HTMLAppletElement.h:
html/HTMLAudioElement.h:
html/HTMLBRElement.h:
html/HTMLBaseElement.h:
html/HTMLBaseFontElement.h:
html/HTMLDListElement.h:
html/HTMLDirectoryElement.h:
html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::reset):
html/HTMLHRElement.cpp: (WebCore::HTMLHRElement::parseMappedAttribute):
html/HTMLHeadElement.h:
html/HTMLHtmlElement.h:
html/HTMLImageElement.h: (WebCore::HTMLImageElement::setLoadManually):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selection):
html/HTMLIsIndexElement.h:
html/HTMLMarqueeElement.cpp:
html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::):
html/HTMLMenuElement.h:
html/HTMLMetaElement.h:
html/HTMLModElement.h:
html/HTMLOListElement.h:
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::childrenChanged):
html/HTMLParamElement.h:
html/HTMLQuoteElement.h:
html/HTMLStyleElement.h:
html/HTMLTableCaptionElement.h:
html/HTMLTableCellElement.h:
html/HTMLTableColElement.h:
html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::deleteRow):
html/HTMLTitleElement.h:
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseNonHTMLText): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write):
html/HTMLUListElement.h:
html/HTMLVideoElement.h:
html/TimeRanges.h: (WebCore::TimeRanges::Range::Range):
inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking):
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::newInspectorJSONObject):
page/Console.cpp: (WebCore::Console::addMessage):
page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::defaultKeyboardEventHandler):
page/Frame.cpp: (WebCore::Frame::jsDefaultStatusBarText):
page/android/DragControllerAndroid.cpp: (WebCore::DragController::dragOperation):
page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::eventActivatedView):
page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
page/gtk/DragControllerGtk.cpp: (WebCore::DragController::dragOperation):
page/qt/DragControllerQt.cpp:
page/win/DragControllerWin.cpp: (WebCore::DragController::isCopyKeyDown):
page/win/FrameWin.h:
rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventOffsetToThumb):
rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setVerticalAlignLength): (WebCore::InheritedFlags::setUnicodeBidi): (WebCore::InheritedFlags::setCursor):
rendering/style/RenderStyleConstants.h: (WebCore::):
rendering/style/SVGRenderStyleDefs.h:
rendering/style/StyleInheritedData.h: (WebCore::StyleInheritedData::operator!=):
storage/DatabaseTask.h:
svg/GradientAttributes.h:
svg/LinearGradientAttributes.h:
svg/PatternAttributes.h:
svg/RadialGradientAttributes.h:
svg/SVGAnimatedPathData.h:
svg/SVGAnimatedPoints.h:
svg/SVGAnimationElement.h:
svg/SVGClipPathElement.h:
svg/SVGElementInstance.h:
svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::build):
svg/SVGFEBlendElement.h:
svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::build):
svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::build):
svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::build):
svg/SVGFEDistantLightElement.h:
svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
svg/SVGFEFloodElement.h:
svg/SVGFEFuncAElement.h:
svg/SVGFEFuncBElement.h:
svg/SVGFEFuncGElement.h:
svg/SVGFEFuncRElement.h:
svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::build):
svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build):
svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::build):
svg/SVGFEPointLightElement.h:
svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
svg/SVGFESpotLightElement.h:
svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::build):
svg/SVGLineElement.cpp: (WebCore::SVGLineElement::parseMappedAttribute):
svg/SVGList.h:
svg/SVGListTraits.h: (WebCore::):
svg/SVGMPathElement.h:
svg/SVGMetadataElement.h:
svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG): (WebCore::SVGPathParser::calculateArc):
svg/SVGPathElement.h:
svg/SVGPathSegClosePath.h:
svg/SVGSVGElement.h:
svg/SVGSetElement.h:
svg/SVGSwitchElement.h:
svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::parseMappedAttribute):
svg/SVGTextPathElement.h:
svg/SVGTitleElement.h:
svg/SVGTransformable.cpp: (WebCore::):
svg/SVGViewSpec.cpp: (WebCore::):
svg/animation/SMILTime.cpp: (WebCore::operator+): (WebCore::operator-): (WebCore::operator*):
svg/animation/SVGSMILElement.h:
svg/graphics/SVGResource.cpp: (WebCore::clientMap):
wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::value):
wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::value):
workers/WorkerRunLoop.cpp:
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection):
xml/XPathPath.h:

10:22 PM Changeset in webkit [45746] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/27167> bugzilla-tool: hide help for unsupported commands

Reviewed by Eric Seidel.

When bugzilla-tool -hhelp is invoked in an svn working

directory, don't print help for commands that are only supported
on git working directories.

Scripts/bugzilla-tool: (Command.init): Added requires_local_commits argument with a default of False. Set self.requires_local_commits attribute. (PostCommitsAsPatchesToBug.execute): Removed SCM.supports_local_commits() check since this is now handled by BugzillaTool.main(). (PostCommitsAsPatchesToBug.init): Added requires_local_commits=True argument to Command.init(). (BugzillaTool.commands_usage): Don't print help for commands if they require local commits and the current SCM doesn't support them. (BugzillaTool.main): If command_object requires local commits and the current SCM doesn't, exit with an error message.

9:20 PM Changeset in webkit [45745] by Simon Fraser

3 edits in trunk/WebKit/mac

2009-07-10 Simon Fraser <Simon Fraser>

Reviewed by John Sullivan.

Flashing as hardware layers are created and destroyed in some content
<rdar://problem/7032246>

There's a window of time between the end of one runloop cycle, after CA layers changes
have been committed, and the window display at the start of the next cycle when
CA may push updates to the screen before AppKit has drawn the view contents. If
we know that we need to do drawing synchronization (which we do when content moves
between a layer and the view), then we need to call -disableScreenUpdatesUntilFlush
from the existing runloop observer that is set up when layers need repainting to
ensure that layer updates don't reach the screen before view-based painting does.

WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]): Tweak the comments

WebView/WebView.mm: (viewUpdateRunLoopObserverCallBack): (-[WebView _scheduleViewUpdate]): Add a big comment to explain the timing of things. Call -disableScreenUpdatesUntilFlush when the view _needsOneShotDrawingSynchronization.

9:02 PM Changeset in webkit [45744] by eric.carlson@apple.com

18 edits in trunk

2009-07-10 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7049066>.
Update SnowLeopard media controller layout.

css/mediaControlsQT.css:

Update for new layout.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::movieLoadType):

Added to replace isStreaming.

html/HTMLMediaElement.h:

Declare movieLoadType, remove isStreaming.

rendering/MediaControlElements.cpp: (WebCore::MediaControlStatusDisplayElement::update):

Use movieLoadType instead of isStreaming.

(WebCore::MediaControlTimelineContainerElement::rendererIsNeeded):

MediaControlElement is the base class, not HTMLInputElement.

(WebCore::MediaControlStatusDisplayElement::rendererIsNeeded):

Ditto.

(WebCore::MediaControlRewindButtonElement::rendererIsNeeded):

Don't display rewind button for live streams.

(WebCore::MediaControlReturnToRealtimeButtonElement::rendererIsNeeded):

MediaControlInputElement is the base class, not HTMLInputElement.

rendering/MediaControlElements.h:

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::getMediaUIPartStateFlags):

New, return wkDrawMediaUIPart flags.

(WebCore::RenderThemeMac::paintMediaFullscreenButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):
(WebCore::RenderThemeMac::paintMediaSeekBackButton):
(WebCore::RenderThemeMac::paintMediaSeekForwardButton):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaSliderThumb):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaControlsBackground):
(WebCore::RenderThemeMac::paintMediaCurrentTime):
(WebCore::RenderThemeMac::paintMediaTimeRemaining):

Use getMediaUIPartStateFlags.

2009-07-10 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Update WebKitSystemInterface for <rdar://problem/7049066>.

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
libWebKitSystemInterfaceTiger.a:

2009-07-10 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7049066>.
Update media tests for new SnowLeopard controller layout.

platform/mac/media/controls-after-reload-expected.txt:
platform/mac/media/controls-styling-expected.txt:
platform/mac/media/video-empty-source-expected.txt:
platform/mac/media/video-zoom-controls-expected.txt:

7:02 PM Changeset in webkit [45743] by abarth@webkit.org

6 edits
7 deletes in trunk

Reverted 45741. Tests failed.

6:39 PM Changeset in webkit [45742] by pkasting@chromium.org

1 edit
1 move in trunk/LayoutTests

2009-07-10 Peter Kasting <pkasting@google.com>

https://bugs.webkit.org/show_bug.cgi?id=19562
Disable a failing layout test caused by the patch for this bug until
I have time to determine that the obvious fix is correct.

fast/dom/domListEnumeration.html: Removed.
fast/dom/domListEnumeration.html-disabled: Copied from LayoutTests/fast/dom/domListEnumeration.html.

6:31 PM Changeset in webkit [45741] by abarth@webkit.org

6 edits
7 adds in trunk

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27151

Fixes issue where JavaScript URLs that contain null- and non-null control characters can
bypass XSSAuditor.

Tests: http/tests/security/xssAuditor/javascript-link-control-char.html

http/tests/security/xssAuditor/javascript-link-null-char.html
http/tests/security/xssAuditor/javascript-link.html

bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): Separated out logic for JavaScript URLs from inline scripts. For JavaScript URLs, calls XSSAuditor::canEvaluateJavaScriptURL.
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): Made similar changes to evaluate() as in bindings/js/ScriptController.cpp.
page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Separated out logic for JavaScript URLs into its own method.
page/XSSAuditor.h:

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27151

Tests prevention of JavaScript URLs that contain null- and non-null control characters.

http/tests/security/xssAuditor/javascript-link-control-char-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-control-char.html: Added.
http/tests/security/xssAuditor/javascript-link-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-null-char-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-null-char.html: Added.
http/tests/security/xssAuditor/javascript-link.html: Added.
http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Added.

6:21 PM Changeset in webkit [45740] by abarth@webkit.org

4 edits in trunk/WebKit

WebKit/mac:

2009-07-10 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig with the power of Grayskull.

Enable XSSAuditor by default.

WebView/WebPreferences.mm: (+[WebPreferences initialize]):

WebKit/win:

2009-07-10 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig with the power of Grayskull.

Enable XSSAuditor by default.

WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):

5:57 PM Changeset in webkit [45739] by pkasting@chromium.org

17 edits
5 adds in trunk

WebCore:

2009-07-10 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=19562
Added build stuff and stub for the ValidityState class, part of HTML5
section Forms:
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#validitystate

Test: fast/forms/ValidityState-001.html

DerivedSources.cpp: Fix aimed to include ValidityState files
DerivedSources.make: ditto
GNUmakefile.am: ditto
WebCore.gypi: ditto
WebCore.pro: ditto
WebCore.vcproj/WebCore.vcproj: ditto
WebCore.xcodeproj/project.pbxproj: ditto
WebCoreSources.bkl: ditto
html/HTMLButtonElement.idl: "validity" attribute
html/HTMLFieldSetElement.idl: ditto
html/HTMLFormControlElement.cpp: object getter (WebCore::HTMLFormControlElement::validity):
html/HTMLFormControlElement.h: ditto
html/HTMLInputElement.idl: "validity" attribute
html/HTMLSelectElement.idl: ditto
html/HTMLTextAreaElement.idl: ditto
html/ValidityState.cpp: Added. (WebCore::ValidityState::ValidityState): (WebCore::ValidityState::valid): validation flag
html/ValidityState.h: Added. (WebCore::ValidityState::create): creation routine (WebCore::ValidityState::control): ValidityState's parent getter (WebCore::ValidityState::valueMissing): validation flag (WebCore::ValidityState::typeMismatch): ditto (WebCore::ValidityState::patternMismatch): ditto (WebCore::ValidityState::tooLong): ditto (WebCore::ValidityState::rangeUnderflow): ditto (WebCore::ValidityState::rangeOverflow): ditto (WebCore::ValidityState::stepMismatch): ditto (WebCore::ValidityState::customError): ditto
html/ValidityState.idl: Added.

LayoutTests:

2009-07-10 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=19562
Minimal test case for ValidityState; more tests are going to be added
along with specific validation routines.

fast/forms/ValidityState-001-expected.txt: Added.
fast/forms/ValidityState-001.html: Added.

4:55 PM Changeset in webkit [45738] by mrowe@apple.com

4 edits in trunk

Versioning.

4:54 PM Changeset in webkit [45737] by mrowe@apple.com

1 copy in tags/Safari-6531.4

New tag.

4:21 PM Changeset in webkit [45736] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

Second part of the "make Windows happier" dance.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

4:15 PM Changeset in webkit [45735] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

Try and make the Windows build happy.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

4:01 PM Changeset in webkit [45734] by beidson@apple.com

2 edits in trunk/WebCore

2009-07-10 Brady Eidson <beidson@apple.com>

Style cleanup over my last patch.

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::~XMLHttpRequest):

4:00 PM Changeset in webkit [45733] by kmccullough@apple.com

7 edits in trunk

JavaScriptCore:

2009-07-10 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoffrey Garen.

debugger/Debugger.h: Made this function virtual for use in WebCore's WebInspector.

WebCore:

2009-07-10 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoffrey Garen.

inspector/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::dynamicGlobalObject):
inspector/JavaScriptCallFrame.h: New helper method, used below.

inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::detach): In the special case where we detach from a window currently executing JavaScript, manually tear down our representation of the JavaScript call stack, since we won't get any more callbacks from JavaScriptCore to automatically tear it down. It's too bad that WebCore is responsible for this kind of tracking -- in the future, it would be nice if more of the breakpoint handling was inside of JavaScriptCore.

3:57 PM Changeset in webkit [45732] by beidson@apple.com

5 edits in trunk/WebCore

2009-07-10 Brady Eidson <beidson@apple.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=26496 and <rdar://problem/7046520>
REGRESSION: XHR stream connection blocks iFrame loading and resource downloading

With this test we ended up going over the maximum-connections-per-host limit that CFNetwork expected.
When that happened, the first request that was over the limit ended up in a bizarre state where it
wasn't fully serviced until after the long running XHR was complete.

Loader and Loader::Host work together to try to not exceed the max-connection limit but non-cache
resources - such as XHR - could still end up causing this limit to be exceeded.

This fix adds a workaround specifically for XHR while we hash out a more thorough solution that will
handle this at the resource handle level.

loader/loader.cpp: (WebCore::Loader::nonCacheRequestInFlight): (WebCore::Loader::nonCacheRequestComplete): (WebCore::Loader::Host::Host): (WebCore::Loader::Host::nonCacheRequestInFlight): (WebCore::Loader::Host::nonCacheRequestComplete): (WebCore::Loader::Host::servePendingRequests): Take nonCacheRequestsInFlight into account.
loader/loader.h: (WebCore::Loader::Host::processingResource): Take nonCacheRequestsInFlight into account.

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::loadRequestAsynchronously): Bump the nonCacheRequestInFlight count. (WebCore::XMLHttpRequest::didFail): Decrement that count if the Loader was notified. (WebCore::XMLHttpRequest::didFinishLoading): Ditto.

3:09 PM Changeset in webkit [45731] by yael.aharon@nokia.com

5 edits in trunk/WebKit/qt

2009-07-10 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=27136

Fix a bug where webkit hangs when executing infinite JavaScript loop.

Api/qwebpage.cpp:
Api/qwebpage.h:
WebCoreSupport/ChromeClientQt.cpp:
tests/qwebpage/tst_qwebpage.cpp:

2:53 PM Changeset in webkit [45730] by bfulgham@webkit.org

4 edits in trunk

2009-07-10 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

ParserArenaDeletable should override delete
https://bugs.webkit.org/show_bug.cgi?id=26790

ParserArenaDeletable overrides new, but it does not override delete.
ParserArenaDeletable must be freed by fastFree
because it is allocated by fastMalloc.

parser/NodeConstructors.h: (JSC::ParserArenaDeletable::operator delete):
parser/Nodes.h:

2:31 PM Changeset in webkit [45729] by Antti Koivisto

2 edits in trunk/WebCore

2009-07-10 Antti Koivisto <Antti Koivisto>

Try to unbreak non-Mac build.

page/ChromeClient.h: (WebCore::ChromeClient::formDidFocus): (WebCore::ChromeClient::formDidBlur):

2:28 PM Changeset in webkit [45728] by Beth Dakin

2 edits in trunk/WebCore

2009-07-10 Beth Dakin <Beth Dakin>

Reviewed by Anders Carlsson.

The rest of the fix for <rdar://problem/7038831> REGRESSION (TOT):
In Mail, a crash occurs at WebCore::Widget::afterMouseDown() after
clicking To Do's close box

Make the Widget* in passMouseDownEventToWidget() a RefPtr.

page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseDownEventToWidget):

2:19 PM Changeset in webkit [45727] by Simon Hausmann

2 edits in trunk/LayoutTests

2009-07-10 Simon Hausmann <Simon Hausmann>

No Review, just re-ordering Qt DRT skip list.

Moved skipped crash tests to the crash section.

platform/qt/Skipped:

2:10 PM Changeset in webkit [45726] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/27117> bugzilla-tool: use Mac OS X keychain for authentication

Reviewed by Eric Seidel.

Try reading credentials from git config first, then keychain if
running on Mac OS X, else prompt at the command-line.

Scripts/modules/bugzilla.py: Added "import platform". (credentials_from_git): Added. (credentials_from_keychain): Added. (is_mac_os_x): Added. (read_credentials): Added. (Bugzilla.init): Moved instance attribute bug_server to a static attribute named bug-server_url. (Bugzilla.bug_server_host): Added. Extracted host name from bug_server_url. (Bugzilla.bug_server_regex): Updated to be created using bug_server_host. (Bugzilla.bug_server_url): Renamed from bug_server. (Bugzilla.bug_url_for_bug_id): Updated for renaming of bug_server to bug_server_url. (Bugzilla.attachment_url_for_id): Ditto. (Bugzilla.fetch_bug_ids_from_commit_queue): Ditto. (Bugzilla.authenticate): Ditto. Updated to use read_credentials(). (Bugzilla.add_patch_to_bug): Ditto.

2:02 PM Changeset in webkit [45725] by ddkilzer@apple.com

4 edits
1 add in trunk/WebKitTools

<http://webkit.org/b/27115> bugzilla-tool: extract duplicate logging methods into a module

Reviewed by Adam Roben.

Scripts/bugzilla-tool: Removed error() and log() methods and added import of new logging module.
Scripts/modules/bugzilla.py: Ditto. Removed "import sys".
Scripts/modules/scm.py: Ditto.

Scripts/modules/logging.py: Added. (log): Added. (error): Added. Prefix error messages with "ERROR: ".

1:53 PM Changeset in webkit [45724] by eric@webkit.org

8 edits in trunk/WebCore

2009-07-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

rename getDOMStructure calls w/o JSGlobalObject* to deprecatedGetDOMStructure
https://bugs.webkit.org/show_bug.cgi?id=27157

This is the first step to fixing
https://bugs.webkit.org/show_bug.cgi?id=27088

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMBinding.h: (WebCore::deprecatedGetDOMStructure): (WebCore::createDOMObjectWrapper): (WebCore::createDOMNodeWrapper):
bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
bindings/js/JSRGBColor.cpp: (WebCore::JSRGBColor::JSRGBColor):
bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
bridge/runtime_array.cpp: (JSC::RuntimeArray::RuntimeArray):
bridge/runtime_method.cpp: (JSC::RuntimeMethod::RuntimeMethod):
bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::RuntimeObjectImp):

1:32 PM Changeset in webkit [45723] by bolsinga@apple.com

9 edits in trunk

WebCore:

2009-07-10 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Antti Koivisto.

Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153

Call the appropriate new ChromeClient methods for focus and blur.

html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::dispatchFocusEvent): (WebCore::HTMLFormControlElement::dispatchBlurEvent):
html/HTMLFormControlElement.h:
loader/EmptyClients.h: (WebCore::EmptyChromeClient::formDidFocus): (WebCore::EmptyChromeClient::formDidBlur):
page/ChromeClient.h:

WebKit/mac:

2009-07-10 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Antti Koivisto.

Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153

Call the appropriate private delegate methods from the ChromeClient.

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::formStateDidChange): (WebChromeClient::formDidFocus): (WebChromeClient::formDidBlur):
WebView/WebUIDelegatePrivate.h:

1:26 PM Changeset in webkit [45722] by Dimitri Glazkov

3 edits in trunk/LayoutTests

2009-07-10 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Adler.

Changing the test string from a platform-dependent file:/// to a more
generic http://.

https://bugs.webkit.org/show_bug.cgi?id=27138

fast/dom/anchor-toString-expected.txt:
fast/dom/anchor-toString.html:

1:25 PM Changeset in webkit [45721] by sfalken@apple.com

2 edits in trunk/WebCore

<rdar://problem/7048741> REGRESSION: Error about missing SwMenuX.dll opening pages with Shockwave

Use altered search path while loading plug-ins. This modifies the DLL search order
to look in the directory containing the plug-in even if a call to SetDllDirectory
was previously made. Use of SetDllDirectory removes the current directory from the search path,
breaking the previous strategy for locating any dependent DLLs of the plug-in.

Reviewed by Jon Honeycutt.

plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load): Use LoadLibraryEx with LOAD_WITH_ALTERED_SEARCH_PATH

1:15 PM Changeset in webkit [45720] by Simon Hausmann

2 edits in trunk/LayoutTests

2009-07-10 Simon Hausmann <Simon Hausmann>

No Review, just skipping a new test for Qt DRT.

Skip fast/forms/slider-delete-while-dragging-thumb.html due to missing eventSender
bits & pieces.

platform/qt/Skipped:

12:19 PM Changeset in webkit [45719] by Adam Roben

16 edits in trunk

Sort all our Xcode projects

Accomplished using sort-Xcode-project-file.

Requested by Dave Kilzer.

JavaScriptCore:

JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

WebCore.xcodeproj/project.pbxproj:

WebKit:

WebKit.xcodeproj/project.pbxproj:

WebKitExamplePlugins:

NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj:
NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj:
NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj/project.pbxproj:

WebKitTools:

DrawTest/DrawTest.xcodeproj/project.pbxproj:
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:

12:18 PM Changeset in webkit [45718] by Adam Roben

2 edits in trunk/WebKitTools

Print prepare-ChangeLog's reminders to STDERR so they don't end up in the diff output

Fixes REGRESSION (r45647): prepare-ChangeLog -d puts non-diff lines
into the diff
<https://bugs.webkit.org/show_bug.cgi?id=27150>

Reviewed by Maciej Stachowiak.

Scripts/prepare-ChangeLog:

12:18 PM Changeset in webkit [45717] by Adam Roben

2 edits in trunk/WebKitTools

Use case-insensitive comparisons when sorting Xcode project files

This matches the sorting used in Xcode's files list.

Fixes Bug 27079: sort-Xcode-project-file should sort
case-insensitively, to match Xcode's files list
<https://bugs.webkit.org/show_bug.cgi?id=27079>

Reviewed by Dave Kilzer.

Scripts/sort-Xcode-project-file: (sortChildrenByFileName): (sortFilesByFileName): Lowercase the strings before comparing them so that the comparison will be case-insensitive.

12:10 PM Changeset in webkit [45716] by agl@chromium.org

2 edits in trunk/WebCore

2009-07-10 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: use disabled images for disabled widgets.

https://bugs.webkit.org/show_bug.cgi?id=27106

Previously, checkboxes and radio controls rendered the same even if disabled.
The Chromium side of this change is r20224.

rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::paintRadio):

11:54 AM Changeset in webkit [45715] by Simon Fraser

3 edits in trunk/WebCore

2009-07-10 Simon Fraser <Simon Fraser>

Reviewed by John Sullivan.

Fix crash when changing the zoom level in http://iphone.akamai.com/
<rdar://problem/7029077>

RenderLayerBacking's paintIntoLayer() method called updateLayerListsIfNeeded(),
which could potentially destroy that compositing layer, causing a crash.
Prevent this from happening by not doing a compositing update from paintIntoLayer().

The existing updateLayerListsIfNeeded() was renamed to updateCompositingAndLayerListsIfNeeded(),
and still does the compositing update. The new updateLayerListsIfNeeded() does not touch
compositing layers, and is still called from paintIntoLayer().

rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::updateLayerListsIfNeeded): (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
rendering/RenderLayer.h:

11:46 AM Changeset in webkit [45714] by dimich@chromium.org

11 edits in trunk/WebCore

2009-07-10 Drew Wilson <atwilson@google.com>

Reviewed by Darin Adler.

Need to remove UsesManualToJSImplementation() in favor of CustomToJS.
https://bugs.webkit.org/show_bug.cgi?id=27010

Added support for CustomToJS IDL attribute to replace the hard-coded class list in UsesManualToJSImplementation().

This is just a cleanup of existing functionality, so existing LayoutTests adequately cover this patch.

bindings/scripts/CodeGeneratorJS.pm: Removed UsesManualToJSImplementation(), added support for CustomToJS attribute.
css/CSSRule.idl:
css/CSSValue.idl:
css/StyleSheet.idl:
dom/Document.idl:
dom/Event.idl:
dom/Node.idl:
html/ImageData.idl:
svg/SVGElementInstance.idl:
svg/SVGPathSeg.idl: Added CustomToJS attribute to all the above IDL files.

10:45 AM Changeset in webkit [45713] by mitz@apple.com

2 edits in trunk/WebCore

fix the build by reverting the ill-advised r45711

page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor):

10:41 AM Changeset in webkit [45712] by bweinstein@apple.com

4 edits in trunk

2009-07-09 Brian Weinstein <bweinstein@apple.com>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=27141

Updated WebInspectorClient to use Web Inspector Preferences to remember whether or not it should be
docked or a free window instead of NSUserDefaults it used to have.

WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]):

2009-07-09 Brian Weinstein <bweinstein@apple.com>

Reviewed by Tim Hatcher.

Updated WebCore.base.exp to add some needed functions.

WebCore.base.exp:

9:56 AM Changeset in webkit [45711] by mitz@apple.com

2 edits in trunk/WebCore

address a review comment from Simon Fraser which I forgot to include in the last check-in

page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor): Pass true to getRect() for maximum transform friendliness!

9:54 AM Changeset in webkit [45710] by mitz@apple.com

5 edits
2 adds in trunk

WebCore:

Reviewed by Simon Fraser.

fix https://bugs.webkit.org/show_bug.cgi?id=27137 <rdar://problem/7043124> REGRESSION (r44311): Reproducible crash due to infinite recursion into FrameLoader::gotoAnchor() -> FrameView::layout()

Test: fast/loader/goto-anchor-infinite-layout.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Moved the code to update layout, find the renderer to scroll to, and scroll from here to methods on FrameView, and replaced it with a call to FrameView::maintainScrollPositionAtAnchor(). (WebCore::FrameLoader::completed): Call maintainScrollPositionAtAnchor() instead of setLockedToAnchor().

page/FrameView.cpp: (WebCore::FrameView::FrameView): Removed initialization of m_lockedToAnchor. (WebCore::FrameView::reset): Reset m_maintainScrollPositionAnchor instead of m_lockedToAnchor. (WebCore::FrameView::layout): Removed the code related to scrolling to the anchor from here, because scrolling can trigger events which invalidate the layout, and as such, belongs with the post-layout tasks. (WebCore::FrameView::maintainScrollPositionAtAnchor): Added. When called with a node scrolls the view to the top of that node and maintains it scrolled to the top of the node during subsequent layouts, until this function is called with 0 or other things trigger scrolling. (WebCore::FrameView::scrollRectIntoViewRecursively): Reset m_maintainScrollPositionAnchor. (WebCore::FrameView::setScrollPosition): Ditto. (WebCore::FrameView::scrollToAnchor): Added. Scrolls to the top of m_maintainScrollPositionAnchor, if it is set. (WebCore::FrameView::performPostLayoutTasks): Call scrollToAnchor(). (WebCore::FrameView::setWasScrolledByUser): Reset m_maintainScrollPositionAnchor.

page/FrameView.h: Removed lockedToAnchor(), setLockedToAnchor(), and m_lockedToAnchor. Added maintainScrollPositionAtAnchor() and m_maintainScrollPositionAnchor.

LayoutTests:

Reviewed by Simon Fraser.

test for https://bugs.webkit.org/show_bug.cgi?id=27137 <rdar://problem/7043124> REGRESSION (r44311): Reproducible crash due to infinite recursion into FrameLoader::gotoAnchor() -> FrameView::layout()

fast/loader/goto-anchor-infinite-layout-expected.txt: Added.
fast/loader/goto-anchor-infinite-layout.html: Added.

8:39 AM Changeset in webkit [45709] by Simon Hausmann

2 edits
2 deletes in trunk/LayoutTests

2009-07-09 Simon Hausmann <Simon Hausmann>

Reviewed by Holger Freyther.

Re-enabled dom/xhtml/level2/html/HTMLBaseElement0{1,2} for the Qt DRT,
as there's now a cross-platform result and it passes.

platform/qt/Skipped:
platform/qt/dom/xhtml/level2/html/HTMLBaseElement01-expected.txt: Removed.
platform/qt/dom/xhtml/level2/html/HTMLBaseElement02-expected.txt: Removed.

8:30 AM Changeset in webkit [45708] by Simon Hausmann

7 edits in trunk

WebKit/qt:

2009-07-10 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=27108

Fix crash when in frame tree of a new frame before the new frame
has been installed in the frame tree, similar to r35088.

After calling Frame::init() the frame it may have been removed from the
frame tree again through JavaScript. Detect this by checking the page()
afterwards.

To make this check safe the Frame::init() code was moved into
QWebFrameData's constructor, where a RefPtr holds a reference to the frame.
After the check back in FrameLoaderClientQt we would hold the single
reference left and after release() the frame, its frame loader, its
client as well as the QWebFrame should have disappeared then.

Api/qwebframe.cpp: (QWebFramePrivate::init): Only call Frame::init here, the rest is done in QWebFrameData's constructor. (QWebFrame::QWebFrame):
Api/qwebframe_p.h: Adjust declaration. (QWebFrameData::QWebFrameData): Create the Frame here.
Api/qwebpage.cpp: (QWebPagePrivate::createMainFrame): Adjust and simplify to new QWebFrame constructor.
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame): Adjust to new QWebFrame construction using QWebFrameData and add the check like in r35088.

LayoutTests:

2009-07-08 Simon Hausmann <Simon Hausmann>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=27108

Remove fast/loader/frame-creation-removal.html from the skip list, it
passes now.

platform/qt/Skipped:

6:25 AM Changeset in webkit [45707] by Simon Hausmann

2 edits in trunk/WebCore

2009-07-04 Sriram Yadavalli <sriram.yadavalli@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=26439

QtWebKit fails in loading www.nytimes.com in Windows/Linux

QNetworkReplyHandler is ignoring content associated with 401 error.
This causes the XHR response handling to fail.

Simon: Added also ProxyAuthenticationRequiredError, to handle the same
case when going through proxies, as suggested by Prasanth.

platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):

5:47 AM Changeset in webkit [45706] by Simon Hausmann

6 edits in trunk

WebKitTools:

2009-07-08 Simon Hausmann <Simon Hausmann>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=27109

Fix side-effects in the Qt DRT with tests using application fonts.

Detect if a test used application fonts and re-initialize the fontconfig
application fontset accordingly.

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open): call initializeFonts and remove all application fonts after running a testcase. (WebCore::DumpRenderTree::initializeFonts): Moved fontconfig initialization code here from main.
DumpRenderTree/qt/DumpRenderTree.h: Declare initializeFonts.
DumpRenderTree/qt/main.cpp: (main): Moved fontconfig initialization code to DRT::initializeFonts.

LayoutTests:

2009-07-08 Simon Hausmann <Simon Hausmann>