Timeline


and

07/17/09:

23:13 Changeset [46086] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

2009-07-17 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27405

Tests that HTML entities that contain an invalid entity, such as an
unknown named entity, are properly handled.

  • http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt: Added.
  • http/tests/security/xssAuditor/link-onclick-ampersand.html: Added.
  • http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-ampersand.html: Added.

2009-07-17 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27405

Fixes an issue when decoding HTML entities with an unknown named entity that
caused null-characters to be inserted into the decoded result.

Test: http/tests/security/xssAuditor/link-onclick-ampersand.html

http/tests/security/xssAuditor/javascript-link-ampersand.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeHTMLEntities): Added check to conditional so that non-zero entity values are not inserted during decoding process.
22:42 Changeset [46085] by simon.fraser@apple.com
  • 2 edits in trunk/WebKitSite

2009-07-17 Simon Fraser <simon.fraser@apple.com>

Fix the font to match the rest of the blog site.

  • blog-files/3d-transforms/image-flip.html:
22:38 Changeset [46084] by simon.fraser@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

2009-07-17 Simon Fraser <simon.fraser@apple.com>

Move the image flip effect into an iframe to avoid the long
blog page tripping a bug on Leopard.

  • blog-files/3d-transforms/image-flip.html: Added.
22:32 Changeset [46083] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-07-17 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27403
Add test case for https://bugs.webkit.org/show_bug.cgi?id=27394:
properties on a window object should be accessible after the frame
of the window object has navigated to another site.

  • fast/dom/Window/window-access-after-navigation-expected.txt: Added.
  • fast/dom/Window/window-access-after-navigation.html: Added.
20:29 Changeset [46082] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-17 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

bugzilla-tool does not understand nested SVN repos
https://bugs.webkit.org/show_bug.cgi?id=27404

Determine the root of the working copy by looking at SVN's UUIDs.

  • Scripts/modules/scm.py:
20:12 Changeset [46081] by jmalonzo@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2009-07-17 Jan Michael Alonzo <jmalonzo@webkit.org>

<http://webkit.org/b/18363> [GTK] Combo boxes cannot be opened pressing space

Reviewed by Holger Freyther.

Add Gtk to platforms that want to open the menulist using the
spacebar.

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
19:57 Changeset [46080] by jmalonzo@webkit.org
  • 4 edits in trunk/WebCore

2009-07-17 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25523
[GTK] The text displayed by push buttons is not exposed to assistive technologies

Add new public method text() to RenderButton and use it from
AccessibilityRenderObject::stringValue().

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::text):
  • rendering/RenderButton.h:
19:14 Changeset [46079] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2009-07-17 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Restore proxy retrieval
https://bugs.webkit.org/show_bug.cgi?id=27369

No new tests are needed.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
19:08 Changeset [46078] by yael.aharon@nokia.com
  • 2 edits in trunk/WebCore

2009-07-17 Yael Aharon <yael.aharon@nokia.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=27351
Added platform "Symbian" to WEBCORE_NAVIGATOR_PLATFORM
Use uname to find the correct platform for Linux.

  • page/NavigatorBase.cpp:
18:42 Changeset [46077] by jorlow@chromium.org
  • 16 edits
    2 adds in trunk

WebCore:

2009-07-17 Jens Alfke <snej@chromium.org>

Reviewed by Dimitri Glazkov.

Hook up V8 bindings for DataGrid elements.
https://bugs.webkit.org/show_bug.cgi?id=27383
http://code.google.com/p/chromium/issues/detail?id=16730

Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.

  • WebCore.gypi: Added new source files.
  • bindings/scripts/CodeGeneratorV8.pm: Made GenerateBatchedAttributeData put #if's around conditional attributes.
  • bindings/v8/DOMObjectsInclude.h: #include DataGrid headers.
  • bindings/v8/V8DOMWrapper.cpp: Add bindings from HTML tags to datagrid templates. (WebCore::V8DOMWrapper::getTemplate): Customize datagrid template.
  • bindings/v8/V8DataGridDataSource.cpp: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::V8DataGridDataSource): (WebCore::V8DataGridDataSource::~V8DataGridDataSource):
  • bindings/v8/V8DataGridDataSource.h: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::create): (WebCore::V8DataGridDataSource::isJSDataGridDataSource): (WebCore::V8DataGridDataSource::jsDataSource): (WebCore::asV8DataGridDataSource):
  • bindings/v8/V8GCController.h: Added new handle type "DATASOURCE".
  • bindings/v8/V8Index.h: Conditionalize datagrid stuff.
  • bindings/v8/custom/V8CustomBinding.h: Declare more accessors. Conditionalize.
  • bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Fill in dataSource accessors. (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):

LayoutTests:

2009-07-17 Jens Alfke <snej@chromium.org>

Reviewed by Dimitri Glazkov.

Hook up V8 bindings for DataGrid elements.
https://bugs.webkit.org/show_bug.cgi?id=27383
http://code.google.com/p/chromium/issues/detail?id=16730

Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.

  • fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
18:36 Changeset [46076] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-17 David Levin <levin@chromium.org>

Reviewed by Mark Rowe.

webkit-tools-completion.sh has two typos and sorting issues.
https://bugs.webkit.org/show_bug.cgi?id=27401

  • Scripts/webkit-tools-completion.sh: Fix two typos "--dif" and "-clean". Also, sort all lists including items in the case statement and flags for the commands.
18:26 Changeset [46075] by jorlow@chromium.org
  • 13 edits in trunk/WebCore

2009-07-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

StorageArea should only contain methods we intend to proxy.
https://bugs.webkit.org/show_bug.cgi?id=27181

Right now, StorageAreaSync takes in a StorageArea* and calls methods
like importItem. Really, StorageAreaSync should be operating directly
on StorageAreaImpl* and those methods should be removed from StorageArea
since StorageAreaSync should never be attached to anything other than a
StorageAreaImpl.

This was pointed out in the review for
https://bugs.webkit.org/show_bug.cgi?id=27072

Also clean up StorageNamespaceImpl to operate directly on
StorageAreaImpl. Also, get rid of the factory for StorageArea
since nothing should ever create a StorageArea directly.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • storage/StorageArea.cpp: Removed.
  • storage/StorageArea.h: (WebCore::StorageArea::~StorageArea):
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::copy):
  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::create): (WebCore::StorageAreaSync::StorageAreaSync):
  • storage/StorageAreaSync.h:
  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea):
  • storage/StorageNamespaceImpl.h:
18:22 Changeset [46074] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2009-07-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Add v8 implementation for DOM Storage ScriptObjectQuarantine.
https://bugs.webkit.org/show_bug.cgi?id=27327

Wrap the storage object with a generic object as is done elsewhere in
the file (but continue to hit a NOTIMPLEMENTED if DOM_STORAGE is not
enabled.

  • bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
17:12 Changeset [46073] by eroman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-17 Mads Ager <ager@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=27394
Fix access to global object wrappers after navigation of their
frame in the V8 bindings. This fixes selenium test failures.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::updateDocument):
16:54 Changeset [46072] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the 32-bit build by removing implicit float <-> double conversions.

  • inspector/InspectorController.cpp:

(WebCore::constrainedAttachedWindowHeight):

16:27 Changeset [46071] by bweinstein@apple.com
  • 7 edits in trunk

2009-07-17 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
https://bugs.webkit.org/show_bug.cgi?id=14272


Implemented resizing of inspector window when it is in attached mode. Implemented setAttachedWindowHeight
to set window sizes and redraw the inspector and the inspected web view, and used stored preferences
in InspectorController.cpp to remember user's preferred height.

  • WebCoreSupport/WebInspectorClient.cpp:

2009-07-17 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
https://bugs.webkit.org/show_bug.cgi?id=14272


Moved preference setting for attached inspector height and inspector height calculation from
WebInspectorClient.mm into InspectorController.cpp, to make this code cross-platform and enable
Windows resizing of attached inspector.

  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:

2009-07-17 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
https://bugs.webkit.org/show_bug.cgi?id=14272


Removed size calculation code from [WebInspectorWindowController setInitialAttachedHeight] into
InspectorController.cpp to make it cross platform, and use InspectorController to store the
user's preferred size for an attached window, instead of NSUserDefaults.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController setAttachedWindowHeight:]):
16:25 Changeset [46070] by mitz@apple.com
  • 2 edits in trunk/WebCore

Another attempt at fixing the build after r46063

  • WebCore.xcodeproj/project.pbxproj: Made ExceptionCode.h a private

header, because it is now included from htmlediting.h, which is
a private header.

16:22 Changeset [46069] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27396
Moving cursor in Thai text sometimes jumps over two characters

Test: editing/text-iterator/thai-cursor-movement.html

  • platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Added a special case for five Thai characters, matching ICU/CLDR changes.
16:13 Changeset [46068] by eric@webkit.org
  • 19 edits
    3 adds in trunk

2009-07-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Some constructor objects exposed on Window have the wrong prototype chain
https://bugs.webkit.org/show_bug.cgi?id=27276

  • fast/dom/prototype-inheritance-expected.txt: Added.
  • fast/dom/prototype-inheritance.html: Added.
  • fast/dom/resources/prototype-inheritance.js: Added.

2009-07-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Some constructor objects exposed on Window have the wrong prototype chain
https://bugs.webkit.org/show_bug.cgi?id=27276

Several Constructor classes were already being passed a global object
during construction, but they were ignoring it for prototype lookup.
I've fixed those to use the passed global object instead.

Most of these Constructor classes should just be auto-generated, but I
refrained from changing them over to auto-gen in this patch.

Fixed CodeGeneratorJS to pass a global object to getDOMConstructor when
available, otherwise default to deprecatedGlobalObjectForPrototype(exec)
to match existing behavior.

Test: fast/dom/prototype-inheritance.html

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor): use the existing globalObject pointer for prototype lookup
  • bindings/js/JSDOMBinding.h: (WebCore::deprecatedGlobalObjectForPrototype): Make it easy to detect where the wrong global object is being used. (WebCore::deprecatedGetDOMStructure):
  • bindings/js/JSDOMGlobalObject.h: remove error-prone getDOMConstructor, require passing JSDOMGlobalObject*
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webKitPoint): pass "this" for the global object. (WebCore::JSDOMWindow::webKitCSSMatrix): pass "this" for the global object. (WebCore::JSDOMWindow::xsltProcessor): pass "this" for the global object. (WebCore::JSDOMWindow::worker): pass "this" for the global object.
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor): use the existing globalObject pointer for prototype lookup
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): use the existing globalObject pointer for prototype lookup
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor): use the existing globalObject pointer for prototype lookup
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor): add new globalObject parameter and use it
  • bindings/js/JSWebKitCSSMatrixConstructor.h:
  • bindings/js/JSWebKitPointConstructor.cpp: (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor): add new globalObject parameter and use it
  • bindings/js/JSWebKitPointConstructor.h:
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::JSWorkerConstructor::JSWorkerConstructor): add new globalObject parameter and use it
  • bindings/js/JSWorkerConstructor.h:
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): use the existing globalObject pointer for prototype lookup -- XMLHttpRequest constructor was also missing a length. Added one.
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
  • bindings/js/JSXSLTProcessorConstructor.h:
  • bindings/scripts/CodeGeneratorJS.pm:
16:11 Changeset [46067] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix

  • editing/htmlediting.cpp: (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
16:04 WebKit Team edited by jparent@chromium.org
(diff)
16:03 Changeset [46066] by ggaren@apple.com
  • 14 edits in branches/nitro-extreme/JavaScriptCore

2009-07-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Get the branch working on windows.
https://bugs.webkit.org/show_bug.cgi?id=27391


SunSpider says 0.3% faster.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Updated MSVC export lists to fix linker errors.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added / removed new / old project files.
  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): Used #pragma pack to tell MSVC that these structures represent actual memory layout, and should not be automatically aligned. Changed the return value load to load a 64bit quantity into the canonical registers.
  • jit/JIT.h: Moved OBJECT_OFFSETOF definition to StdLibExtras.h because it's needed by more than just the JIT, and it supplements a standard library macro (offsetof).
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): Fixed an incorrectly signed cast to resolve an MSVC warning.
  • jit/JITStubs.h: Used #pragma pack to tell MSVC that these structures represent actual memory layout, and should not be automatically aligned.
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): Replaced memset_pattern8 with a for loop, since memset_pattern8 is not portable. (I verified that this version of the loop gives the best performance / generated code in GCC.)
  • runtime/JSObject.h: (JSC::JSObject::JSObject): Removed accidental usage of FIELD_OFFSET -- OBJECT_OFFSETOF is our new macro name. (FIELD_OFFSET conflicts with a definition in winnt.h.)
  • runtime/JSValue.cpp: Added some headers needed by non-all-in-one builds.


  • runtime/JSValue.h: (JSC::JSValue::): Made the tag signed, to match MSVC's signed enum values. (GCC doesn't seem to care one way or the other.)
  • wtf/MainThread.cpp: Moved the StdLibExtras.h #include -- I did this a while ago to resolve a conflict with winnt.h. I can't remember if it's truly still needed, but what the heck.
  • wtf/StdLibExtras.h: Moved OBJECT_OFFSETOF definition here.
16:02 Changeset [46065] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-17 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix for symbol lookup error.

Move AbstractWorker from SHARED_WORKERS to WORKERS as Worker derives from it now
Changed in http://trac.webkit.org/changeset/46048

  • GNUmakefile.am:
16:01 Changeset [46064] by pkasting@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Tweak some regexes for correctness.

  • Scripts/prepare-ChangeLog: Allow 1-character filenames (my previous change here didn't quite get things right).
  • Scripts/update-webkit: Detect conflicting ChangeLogs correctly by not including any trailing whitespace in the name "ChangeLog", and by normalizing paths before calling basename() to avoid confusing it. (normalizePath() copied from prepare-ChangeLog.)
15:58 Changeset [46063] by jparent@chromium.org
  • 5 edits in trunk/WebCore

2009-07-17 Ryosuke Niwa <ryosuke.niwa@gmail.com>

Reviewed by Eric Seidel.

htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

In order to fix the bug 26816, we need several utility functions be added to htmlediting.cpp

No tests because functions haven't been used anywhere yet.

  • dom/Range.cpp: (WebCore::Range::create): (WebCore::Range::comparePoint): added const qualifier (WebCore::Range::compareNode): added const qualifier
  • dom/Range.h:
  • editing/htmlediting.cpp: (WebCore::unsplittableElementForPosition): find the enclosing unsplittable element (editing root & table cell) (WebCore::positionBeforeNode): added ASSERT(node) (WebCore::positionAfterNode): added ASSERT(node) (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode): (WebCore::createRange): create a range object from two visible positions (WebCore::extendRangeToWrappingNodes): extend range to include nodes that starts and ends at the boundaries (WebCore::canMergeLists): typo (WebCore::indexForVisiblePosition): added const qualifier (WebCore::isVisiblyAdjacent): typo (WebCore::isNodeVisiblyContainedWithin): determine if a node is inside a range or within the visible boundaries of the range
  • editing/htmlediting.h:
15:53 WebKit Team edited by darin@chromium.org
(diff)
15:37 Changeset [46062] by pkasting@chromium.org
  • 18 edits
    34 adds in trunk

LayoutTests:

2009-07-17 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25551
Test suite for the required attribute, the valueMissing flag and new
:required and :optional CSS pseudoclasses.
Part of the HTML5 sec. Forms.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-required

  • fast/css/pseudo-required-optional-001-expected.txt: Added.
  • fast/css/pseudo-required-optional-001.html: Added.
  • fast/css/pseudo-required-optional-002-expected.txt: Added.
  • fast/css/pseudo-required-optional-002.html: Added.
  • fast/css/pseudo-required-optional-003-expected.txt: Added.
  • fast/css/pseudo-required-optional-003.html: Added.
  • fast/css/pseudo-required-optional-004-expected.txt: Added.
  • fast/css/pseudo-required-optional-004.html: Added.
  • fast/css/pseudo-required-optional-005-expected.txt: Added.
  • fast/css/pseudo-required-optional-005.html: Added.
  • fast/css/pseudo-required-optional-006-expected.txt: Added.
  • fast/css/pseudo-required-optional-006.html: Added.
  • fast/forms/ValidityState-valueMissing-001-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-001.html: Added.
  • fast/forms/ValidityState-valueMissing-002-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-002.html: Added.
  • fast/forms/ValidityState-valueMissing-003-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-003.html: Added.
  • fast/forms/ValidityState-valueMissing-004-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-004.html: Added.
  • fast/forms/ValidityState-valueMissing-005-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-005.html: Added.
  • fast/forms/ValidityState-valueMissing-006-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-006.html: Added.
  • fast/forms/ValidityState-valueMissing-007-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-007.html: Added.
  • fast/forms/ValidityState-valueMissing-008-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-008.html: Added.
  • fast/forms/ValidityState-valueMissing-009-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-009.html: Added.
  • fast/forms/required-attribute-001-expected.txt: Added.
  • fast/forms/required-attribute-001.html: Added.
  • fast/forms/required-attribute-002-expected.txt: Added.
  • fast/forms/required-attribute-002.html: Added.

WebCore:

2009-07-17 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25551
Added support for the "required" attribute, the valueMissing flag
to the ValidityState object and :required/:optional CSS pseudoclasses.
Part of HTML5 sec. Forms specs.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-required

Tests: fast/css/pseudo-required-optional-001.html

fast/css/pseudo-required-optional-002.html
fast/css/pseudo-required-optional-003.html
fast/css/pseudo-required-optional-004.html
fast/css/pseudo-required-optional-005.html
fast/css/pseudo-required-optional-006.html
fast/forms/ValidityState-valueMissing-001.html
fast/forms/ValidityState-valueMissing-002.html
fast/forms/ValidityState-valueMissing-003.html
fast/forms/ValidityState-valueMissing-004.html
fast/forms/ValidityState-valueMissing-005.html
fast/forms/ValidityState-valueMissing-006.html
fast/forms/ValidityState-valueMissing-007.html
fast/forms/ValidityState-valueMissing-008.html
fast/forms/ValidityState-valueMissing-009.html
fast/forms/required-attribute-001.html
fast/forms/required-attribute-002.html

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): pseudoRequired/pseudoOptional
  • css/CSSSelector.h: (WebCore::CSSSelector::): ditto
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto
  • dom/Element.h: (WebCore::Element::isOptionalFormControl): check for optional controls (WebCore::Element::isRequiredFormControl): check for required controls
  • html/HTMLAttributeNames.in: required attribute
  • html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::isOptionalFormControl): ditto
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::required): requiredAttr getter (WebCore::HTMLFormControlElement::setRequired): requiredAttr setter
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::valueMissing): method definition
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueMissing): validation code (WebCore::HTMLInputElement::isRequiredFormControl): ditto
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isOptionalFormControl): ditto
  • html/HTMLInputElement.idl: required DOM attribute
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::isOptionalFormControl): ditto
  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::valueMissing): validation code (WebCore::HTMLTextAreaElement::isOptionalFormControl): ditto (WebCore::HTMLTextAreaElement::isRequiredFormControl): ditto
  • html/HTMLTextAreaElement.idl: required DOM attribute
  • html/ValidityState.cpp:
  • html/ValidityState.h: (WebCore::ValidityState::valueMissing): validation flag
15:30 Changeset [46061] by bdakin@apple.com
  • 3 edits in trunk/WebCore

2009-07-17 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27390 CSS custom
cursor hotspots should work in quirks mode

  • and corresponding <rdar://problem/6554340>

Enable hotspots in quirks mode.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):

Update this manual test to reflect the fact that hotspots are now
expected to work in quirks mode.

  • manual-tests/css3-cursor-fallback-quirks.html:
15:11 WikiStart edited by atwilson@chromium.org
Added link to IdlAttributes wiki page. (diff)
15:09 IdlAttributes edited by atwilson@chromium.org
(diff)
15:02 Changeset [46060] by pkasting@chromium.org
  • 19 edits in trunk

JavaScriptCore:

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

WebCore:

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/WebCoreGenerated.vcproj:

WebKit/win:

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/InterfacesGenerated.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

WebKitTools:

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
15:01 WebKit Team edited by japhet@chromium.org
(diff)
14:56 Changeset [46059] by barraclough@apple.com
  • 9 edits
    3 adds in trunk/JavaScriptCore

2009-07-17 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Add YARR support for generic ARM platforms (disabled by default).
https://bugs.webkit.org/show_bug.cgi?id=24986

Add generic ARM port for MacroAssembler. It supports the whole
MacroAssembler functionality except floating point.

The class JmpSrc is extended with a flag which enables to patch
the jump destination offset during execution. This feature is
required for generic ARM port.

Signed off by Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Signed off by Gabor Loki <loki@inf.u-szeged.hu>

  • JavaScriptCore.pri:
  • assembler/ARMAssembler.cpp: Added. (JSC::ARMAssembler::getLdrImmAddress): (JSC::ARMAssembler::linkBranch): (JSC::ARMAssembler::patchConstantPoolLoad): (JSC::ARMAssembler::getOp2): (JSC::ARMAssembler::genInt): (JSC::ARMAssembler::getImm): (JSC::ARMAssembler::moveImm): (JSC::ARMAssembler::dataTransfer32): (JSC::ARMAssembler::baseIndexTransfer32): (JSC::ARMAssembler::executableCopy):
  • assembler/ARMAssembler.h: Added. (JSC::ARM::): (JSC::ARMAssembler::ARMAssembler): (JSC::ARMAssembler::): (JSC::ARMAssembler::JmpSrc::JmpSrc): (JSC::ARMAssembler::JmpSrc::enableLatePatch): (JSC::ARMAssembler::JmpDst::JmpDst): (JSC::ARMAssembler::JmpDst::isUsed): (JSC::ARMAssembler::JmpDst::used): (JSC::ARMAssembler::emitInst): (JSC::ARMAssembler::and_r): (JSC::ARMAssembler::ands_r): (JSC::ARMAssembler::eor_r): (JSC::ARMAssembler::eors_r): (JSC::ARMAssembler::sub_r): (JSC::ARMAssembler::subs_r): (JSC::ARMAssembler::rsb_r): (JSC::ARMAssembler::rsbs_r): (JSC::ARMAssembler::add_r): (JSC::ARMAssembler::adds_r): (JSC::ARMAssembler::adc_r): (JSC::ARMAssembler::adcs_r): (JSC::ARMAssembler::sbc_r): (JSC::ARMAssembler::sbcs_r): (JSC::ARMAssembler::rsc_r): (JSC::ARMAssembler::rscs_r): (JSC::ARMAssembler::tst_r): (JSC::ARMAssembler::teq_r): (JSC::ARMAssembler::cmp_r): (JSC::ARMAssembler::orr_r): (JSC::ARMAssembler::orrs_r): (JSC::ARMAssembler::mov_r): (JSC::ARMAssembler::movs_r): (JSC::ARMAssembler::bic_r): (JSC::ARMAssembler::bics_r): (JSC::ARMAssembler::mvn_r): (JSC::ARMAssembler::mvns_r): (JSC::ARMAssembler::mul_r): (JSC::ARMAssembler::muls_r): (JSC::ARMAssembler::mull_r): (JSC::ARMAssembler::ldr_imm): (JSC::ARMAssembler::ldr_un_imm): (JSC::ARMAssembler::dtr_u): (JSC::ARMAssembler::dtr_ur): (JSC::ARMAssembler::dtr_d): (JSC::ARMAssembler::dtr_dr): (JSC::ARMAssembler::ldrh_r): (JSC::ARMAssembler::ldrh_d): (JSC::ARMAssembler::ldrh_u): (JSC::ARMAssembler::strh_r): (JSC::ARMAssembler::push_r): (JSC::ARMAssembler::pop_r): (JSC::ARMAssembler::poke_r): (JSC::ARMAssembler::peek_r): (JSC::ARMAssembler::clz_r): (JSC::ARMAssembler::bkpt): (JSC::ARMAssembler::lsl): (JSC::ARMAssembler::lsr): (JSC::ARMAssembler::asr): (JSC::ARMAssembler::lsl_r): (JSC::ARMAssembler::lsr_r): (JSC::ARMAssembler::asr_r): (JSC::ARMAssembler::size): (JSC::ARMAssembler::ensureSpace): (JSC::ARMAssembler::label): (JSC::ARMAssembler::align): (JSC::ARMAssembler::jmp): (JSC::ARMAssembler::patchPointerInternal): (JSC::ARMAssembler::patchConstantPoolLoad): (JSC::ARMAssembler::patchPointer): (JSC::ARMAssembler::repatchInt32): (JSC::ARMAssembler::repatchPointer): (JSC::ARMAssembler::repatchLoadPtrToLEA): (JSC::ARMAssembler::linkJump): (JSC::ARMAssembler::relinkJump): (JSC::ARMAssembler::linkCall): (JSC::ARMAssembler::relinkCall): (JSC::ARMAssembler::getRelocatedAddress): (JSC::ARMAssembler::getDifferenceBetweenLabels): (JSC::ARMAssembler::getCallReturnOffset): (JSC::ARMAssembler::getOp2Byte): (JSC::ARMAssembler::placeConstantPoolBarrier): (JSC::ARMAssembler::RM): (JSC::ARMAssembler::RS): (JSC::ARMAssembler::RD): (JSC::ARMAssembler::RN): (JSC::ARMAssembler::getConditionalField):
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::JmpSrc::enableLatePatch):
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Call::enableLatePatch): (JSC::AbstractMacroAssembler::Jump::enableLatePatch):
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM.h: Added. (JSC::MacroAssemblerARM::): (JSC::MacroAssemblerARM::add32): (JSC::MacroAssemblerARM::and32): (JSC::MacroAssemblerARM::lshift32): (JSC::MacroAssemblerARM::mul32): (JSC::MacroAssemblerARM::not32): (JSC::MacroAssemblerARM::or32): (JSC::MacroAssemblerARM::rshift32): (JSC::MacroAssemblerARM::sub32): (JSC::MacroAssemblerARM::xor32): (JSC::MacroAssemblerARM::load32): (JSC::MacroAssemblerARM::load32WithAddressOffsetPatch): (JSC::MacroAssemblerARM::loadPtrWithPatchToLEA): (JSC::MacroAssemblerARM::load16): (JSC::MacroAssemblerARM::store32WithAddressOffsetPatch): (JSC::MacroAssemblerARM::store32): (JSC::MacroAssemblerARM::pop): (JSC::MacroAssemblerARM::push): (JSC::MacroAssemblerARM::move): (JSC::MacroAssemblerARM::swap): (JSC::MacroAssemblerARM::signExtend32ToPtr): (JSC::MacroAssemblerARM::zeroExtend32ToPtr): (JSC::MacroAssemblerARM::branch32): (JSC::MacroAssemblerARM::branch16): (JSC::MacroAssemblerARM::branchTest32): (JSC::MacroAssemblerARM::jump): (JSC::MacroAssemblerARM::branchAdd32): (JSC::MacroAssemblerARM::mull32): (JSC::MacroAssemblerARM::branchMul32): (JSC::MacroAssemblerARM::branchSub32): (JSC::MacroAssemblerARM::breakpoint): (JSC::MacroAssemblerARM::nearCall): (JSC::MacroAssemblerARM::call): (JSC::MacroAssemblerARM::ret): (JSC::MacroAssemblerARM::set32): (JSC::MacroAssemblerARM::setTest32): (JSC::MacroAssemblerARM::tailRecursiveCall): (JSC::MacroAssemblerARM::makeTailRecursiveCall): (JSC::MacroAssemblerARM::moveWithPatch): (JSC::MacroAssemblerARM::branchPtrWithPatch): (JSC::MacroAssemblerARM::storePtrWithPatch): (JSC::MacroAssemblerARM::supportsFloatingPoint): (JSC::MacroAssemblerARM::supportsFloatingPointTruncate): (JSC::MacroAssemblerARM::loadDouble): (JSC::MacroAssemblerARM::storeDouble): (JSC::MacroAssemblerARM::addDouble): (JSC::MacroAssemblerARM::subDouble): (JSC::MacroAssemblerARM::mulDouble): (JSC::MacroAssemblerARM::convertInt32ToDouble): (JSC::MacroAssemblerARM::branchDouble): (JSC::MacroAssemblerARM::branchTruncateDoubleToInt32): (JSC::MacroAssemblerARM::ARMCondition): (JSC::MacroAssemblerARM::prepareCall): (JSC::MacroAssemblerARM::call32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::JmpSrc::enableLatePatch):
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
  • wtf/Platform.h:
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
14:51 WebKit Team edited by agl@chromium.org
(diff)
14:29 Changeset [46058] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=27384
Random crashes in appcache/update-cache.html test

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): Reorder code to avoid using a handle after canceling it.
14:28 WebKit Team edited by jorlow@chromium.org
(diff)
14:17 Changeset [46057] by barraclough@apple.com
  • 3 edits
    1 add in trunk/JavaScriptCore

2009-07-17 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Extend AssemblerBuffer with constant pool handling mechanism.
https://bugs.webkit.org/show_bug.cgi?id=24986

Add a platform independed constant pool framework.
This pool can store 32 or 64 bits values which is enough to hold
any integer, pointer or double constant.

  • assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::putIntUnchecked): (JSC::AssemblerBuffer::putInt64Unchecked): (JSC::AssemblerBuffer::append): (JSC::AssemblerBuffer::grow):
  • assembler/AssemblerBufferWithConstantPool.h: Added. (JSC::):
14:17 Changeset [46056] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

Revert "2009-07-17 Mario Sanchez Prada <msanchez@igalia.com>"

This reverts commit http://trac.webkit.org/changeset/46038 as it breaks two
accessibility/ tests in the mac builds.

14:16 Changeset [46055] by levin@chromium.org
  • 1 edit
    1 add in trunk/WebKitTools

2009-07-17 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

WebKit should have a bash completion script to aid with common commands.
https://bugs.webkit.org/show_bug.cgi?id=27374

  • Scripts/webkit-tools-completion.sh: The script which enables option completion for several WebKit command line scripts.
13:17 IdlAttributes created by atwilson@chromium.org
13:17 Changeset [46054] by pkasting@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Avoid error spew on Macs, and fix a few other tiny details.

  • Scripts/svn-create-patch:
13:13 Changeset [46053] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-17 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=27377
This makes cpplint complain about this for instance:

if (true)
{

int foo;

}

Add the appropriate unit tests.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
13:08 Changeset [46052] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-17 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=27377
Don't filter whitespace at the end of the line. This is not
explicitly a rule of webkit coding style, but there is no reason
not to warn of this common style problem.

Don't filter whitespace newline. Now, cpplint will complain
about the following situation:

if (true) {

doSomething();
doSomethingAgain();

}
else

doSomething();

Which is a webkit coding style rule violation.

  • Scripts/modules/cpplint.py:
13:05 Changeset [46051] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-17 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=27377
Move this comment to where it belongs.

  • Scripts/modules/cpplint_unittest.py:
12:37 Changeset [46050] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Correct crash in WinLauncher due to improper mixing of BSTR
and TCHAR types.
https://bugs.webkit.org/show_bug.cgi?id=27381

  • WinLauncher/WinLauncher.cpp: (loadURL): Perform SysReAllocString to update the BSTR with the contents of the TCHAR string.
12:27 Changeset [46049] by eroman@chromium.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Build fix for non-Darwin.
Add a guard for inclusion of RetainPtr.h which includes CoreFoundation.h

https://bugs.webkit.org/show_bug.cgi?id=27382

  • wtf/unicode/icu/CollatorICU.cpp:
12:11 Changeset [46048] by levin@chromium.org
  • 19 edits in trunk

WebCore:

2009-07-17 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Changed Worker to derive from AbstractWorker, which involved moving
AbstractWorker files from being wrapped by ENABLE_SHARED_WORKERS to
ENABLE_WORKERS.

Removed obsolete functionality from the JS/V8 bindings that is now
inherited from AbstractWorker.

  • WebCore.pro: Moved AbstractWorker files out of SHARED_WORKERS section and into WORKERS.
  • bindings/js/JSAbstractWorkerCustom.cpp: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
  • bindings/js/JSWorkerCustom.cpp: Removed obsolete event listener code (now in base class) (WebCore::JSWorker::mark): No longer need to explicitly mark event listeners (handled by base class).
  • bindings/v8/V8Index.h: Moved AbstractWorker lines out of SHARED_WORKERS section and into WORKERS.
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
  • bindings/v8/custom/V8CustomBinding.h: Moved AbstractWorker lines out of SHARED_WORKERS section and into WORKERS.
  • bindings/v8/custom/V8WorkerCustom.cpp: Removed obsolete event listener code that now lives in the base class. (WebCore::V8WorkerConstructor): Cleaned up legacy style nits.
  • workers/AbstractWorker.cpp: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
  • workers/AbstractWorker.h: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
  • workers/Worker.cpp: Removed event listener code (now in base class). (WebCore::Worker::Worker): Now derives from AbstractWorker. (WebCore::Worker::notifyFinished): Calls dispatchLoadErrorEvent on base class.
  • workers/Worker.h: Removed APIs that now live in the base class.
  • workers/Worker.idl: Now derives from AbstractWorker. Removed APIs that live in the base class, and added a GenerateToJS flag.

LayoutTests:

2009-07-17 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Added checks to make sure that Workers are properly constructed and Worker attributes
are visible on the resulting object.

  • fast/workers/worker-constructor-expected.txt:
  • fast/workers/worker-constructor.html: Added explicit check for correct construction/postMessage visibility.
12:11 Changeset [46047] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-17 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

cpplint should flag usages of NULL.
https://bugs.webkit.org/show_bug.cgi?id=27341

  • Scripts/modules/cpplint.py: Add the check for NULL test and call it. Make the collapse_strings method public.
  • Scripts/modules/cpplint_unittest.py: Add several tests to verify the check for NULL behavior. Adjust existing tests due to the new NULL check:
    1. Several had NULL removed (or were just removed completely).
    2. Two tests now do an assert that allows the caller to check that a particular error is one of several that was returned.
12:11 Changeset [46046] by levin@chromium.org
  • 1 edit
    2 adds in trunk/WebKitTools

2009-07-17 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

Add a parser of patches for linter.
https://bugs.webkit.org/show_bug.cgi?id=27363

Adds a simple parser for unified diff format.

  • Scripts/modules/diff_parser.py: Added.
  • Scripts/modules/diff_parser_unittest.py: Added.
11:41 Changeset [46045] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

11:36 Changeset [46044] by hyatt@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

2009-07-17 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27379
Absolutely-positioned elements with a scrollbar wrap prematurely. Make sure to include
the vertical scrollbar width for overflow:scroll elements.

Added fast/css/positioned-overflow-scroll.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcPrefWidths):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcPrefWidths):

LayoutTests:

2009-07-17 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27379
Absolutely-positioned elements with a scrollbar wrap prematurely. Make sure to include
the vertical scrollbar width for overflow:scroll elements.

  • fast/css/positioned-overflow-scroll.html: Added.
  • platform/mac/fast/css/positioned-overflow-scroll-expected.checksum: Added.
  • platform/mac/fast/css/positioned-overflow-scroll-expected.png: Added.
  • platform/mac/fast/css/positioned-overflow-scroll-expected.txt: Added.
11:32 Changeset [46043] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.6

New tag.

11:21 Changeset [46042] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

Get user default collation order via a CFLocale API when available.

  • wtf/unicode/icu/CollatorICU.cpp: (WTF::Collator::userDefault):
11:01 Changeset [46041] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-07-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Need a DOM_STORAGE guard in DerivedSroucesAllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=27375

In https://bugs.webkit.org/show_bug.cgi?id=27360 I added Storage.cpp
and StorageEvent.cpp. Unfortunately, until later this afternoon,
DOM_STORAGE is not turned on by default in Chromium, and so these two
files are never generated. This breaks the compile.

There are no other instances of guards in the file, which puzzles me...
but I think adding guards is the right way to go about this.

  • bindings/v8/DerivedSourcesAllInOne.cpp: Added the guard.
11:00 Changeset [46040] by treat@webkit.org
  • 8 edits in trunk/WebKit/qt

2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Adam Treat.

Coding style fixes.

  • Api/qcookiejar.cpp: (QCookieJarPrivate::QCookieJarPrivate): (qHash): (QCookieJar::cookieJar):
  • Api/qwebelement.cpp: (QWebElement::functions): (QWebElement::scriptableProperties):
  • Api/qwebframe.cpp: (QWebFrame::metaData): (QWebFrame::scrollBarValue): (QWebFrame::scroll): (QWebFrame::scrollPosition): (QWebFrame::print):
  • Api/qwebnetworkinterface.cpp: (decodePercentEncoding): (QWebNetworkRequestPrivate::init): (QWebNetworkRequestPrivate::setURL): (QWebNetworkRequest::QWebNetworkRequest): (QWebNetworkRequest::operator=): (QWebNetworkRequest::setUrl): (QWebNetworkRequest::setHttpHeader): (QWebNetworkRequest::httpHeaderField): (QWebNetworkRequest::setHttpHeaderField): (QWebNetworkRequest::setPostData): (QWebNetworkJob::setResponse): (QWebNetworkJob::frame): (QWebNetworkManager::add): (QWebNetworkManager::cancel): (QWebNetworkManager::started): (QWebNetworkManager::data): (QWebNetworkManager::finished): (QWebNetworkManager::addHttpJob): (QWebNetworkManager::cancelHttpJob): (QWebNetworkManager::httpConnectionClosed): (QWebNetworkInterfacePrivate::sendFileData): (QWebNetworkInterfacePrivate::parseDataUrl): (QWebNetworkManager::doWork): (QWebNetworkInterface::setDefaultInterface): (QWebNetworkInterface::defaultInterface): (QWebNetworkInterface::QWebNetworkInterface): (QWebNetworkInterface::addJob): (QWebNetworkInterface::cancelJob): (WebCoreHttp::WebCoreHttp): (WebCoreHttp::request): (WebCoreHttp::scheduleNextRequest): (WebCoreHttp::getConnection): (WebCoreHttp::onResponseHeaderReceived): (WebCoreHttp::onReadyRead): (WebCoreHttp::onRequestFinished): (WebCoreHttp::onAuthenticationRequired): (WebCoreHttp::onProxyAuthenticationRequired):
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::mouseReleaseEvent): (QWebPagePrivate::inputMethodEvent): (QWebPagePrivate::shortcutOverrideEvent): (QWebPage::inputMethodQuery): (QWebPage::javaScriptPrompt): (QWebPage::updatePositionDependentActions): (QWebPage::userAgentForUrl): (QWebPagePrivate::_q_onLoadProgressChanged): (QWebPage::totalBytes): (QWebPage::bytesReceived):
  • Api/qwebsettings.cpp: (QWebSettings::iconForUrl): (QWebSettings::setObjectCacheCapacities):
  • Api/qwebview.cpp: (QWebView::paintEvent): (QWebView::changeEvent):
10:53 Changeset [46039] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-07-17 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26496

Let WebCore always enforce the connection-per-host limit itself.

  • loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests):
09:48 Changeset [46038] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-07-17 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25524
[Gtk] Expose the title attribute to assistive technologies

Expose 'alt' attribute from images as accessible name.
Expose the 'title' core HTML attribute as accessible description.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::accessibilityDescription):
09:41 Changeset [46037] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

Some transitions don't work correctly on Leopard
https://bugs.webkit.org/show_bug.cgi?id=27356

We only have code to do component animation using valueFunction.
So on Leopard we always need to do matrix animation in hardware.
This fix ensures that.

This is currently not testable because it appears only in the
hardware animation and we can't yet do pixel tests while
hardware animating.

08:56 Changeset [46036] by zecke@webkit.org
  • 2 edits in trunk/WebKitTools

[GTK+] Make TestNescpaePlugin loadable in mozilla

https://bugs.webkit.org/show_bug.cgi?id=27345

Currently the NPNetscapeFuncs of WebKit contains two more
entries than the gecko version. This means comparing the
aMozillaVTable->size with the size of NPNetscpaeFuncs will
fail and the plugin will not be loaded.

For testing it is nice to be able to load the plugin into
gecko and currently we are not using the two extra methods.
Remove the test to be able to use the plugin in gecko.

07:48 Changeset [46035] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-07-17 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by NOBODY (OOPS!).

[GTK+] Crash in screenAvailable due a null Widget*

JSDOMWindow::open called screenAvailableRect(0). The other
Screen methods can be called with a null widget as well, fix the
crashing test by checking for null.

In screenRect and screenAvailableRect it is not tried to use
a default screen as the existing implementation didn't try either
in case of not having a toplevel widget.

LayoutTests/fast/frames/crash-removed-iframe.html caused a crash.

  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): New method to get a visual or return zero. (WebCore::screenDepth): Use getVisual. (WebCore::screenDepthPerComponent): Use getVisual. (WebCore::screenIsMonochrome): Use screenDepth which will do the null checking (WebCore::screenRect): Check for !widget. (WebCore::screenAvailableRect): Check for !widget.
07:44 Changeset [46034] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Remove tests from Qt Skipped list that are actually working.
https://bugs.webkit.org/show_bug.cgi?id=27316

  • platform/qt/Skipped:
07:09 Changeset [46033] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-17 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Simon Hausmann.

Something about having a single TAB in a style checking tool like this
is equivalent to nails on a chalk board to me...

  • Scripts/modules/cpplint.py:
06:56 Changeset [46032] by hausmann@webkit.org
  • 4 edits in trunk

JavaScriptCore:

2009-07-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix the include path for the Symbian port
https://bugs.webkit.org/show_bug.cgi?id=27358

WebCore:

2009-07-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix the include path for the Symbian port
https://bugs.webkit.org/show_bug.cgi?id=27358

  • WebCore.pro:
06:34 Changeset [46031] by hausmann@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix a small typo in the changelog

06:32 Changeset [46030] by hausmann@webkit.org
  • 7 edits in trunk

WebCore:

2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Make it possible to set the plugin directories from the DRT.
Part of https://bugs.webkit.org/show_bug.cgi?id=27215

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::installedPlugins): Now optionally takes a populate argument, so we can avoid loading system plugins from the DRT and thus avoid their strerr errors that can make tests fail. (WebCore::PluginDatabase::clear): Make is possible to clear the database. Called from setPluginDirectories.
  • plugins/PluginDatabase.h: (WebCore::PluginDatabase::setPluginDirectories): Make public

WebKit/qt:

2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Overwrite the plugin directories for the DRT.
Part of https://bugs.webkit.org/show_bug.cgi?id=27215

  • Api/qwebpage.cpp: (qt_drt_overwritePluginDirectories): Only set the plugin directories to the ones in the QTWEBKIT_PLUGIN_PATH environment variable.

WebKitTools:

2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Overwrite the plugin directories for the DRT.
Part of https://bugs.webkit.org/show_bug.cgi?id=27215

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
05:43 Changeset [46029] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

PluginViewMac: Stop the plugin when loading fails

Also, prevent event propagation when in the stopped state

  • plugins/mac/PluginViewMac.cpp:
05:40 Changeset [46028] by vestbo@webkit.org
  • 4 edits in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

PluginViewMac: Allow query and set of drawing and event models

We now support querying and setting of the drawing and event model,
but we still only support the CoreGraphics drawing model, and the
Carbon event model.

If unsupported drawing or event models are detected we show the
missing-plugin icon.

  • plugins/PluginView.cpp:
  • plugins/PluginView.h:
  • plugins/mac/PluginViewMac.cpp:
05:17 Changeset [46027] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Initialize two PluginView members using memset

m_npWindow is used on all platforms, not just for XP_UNIX,
so always initialize it. m_npCgContext on the other hand
is only used for XP_MACOSX.

  • plugins/PluginView.cpp:
04:46 Changeset [46026] by vestbo@webkit.org
  • 6 edits in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Add more debug logging in PluginView

  • plugins/PluginView.cpp: Add debug for setValue
  • plugins/gtk/PluginViewGtk.cpp: Add debug for getValue
  • plugins/mac/PluginViewMac.cpp: Add debug for getValue and more
  • plugins/qt/PluginViewQt.cpp: Add debug for getValue
  • plugins/win/PluginViewWin.cpp: Add debug for getValue
04:00 Changeset [46025] by levin@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-07-17 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by David Levin.

Build fix on platforms don't have MMAP.
https://bugs.webkit.org/show_bug.cgi?id=27365

  • interpreter/RegisterFile.h: Including stdio.h irrespectively of HAVE(MMAP)
03:52 Changeset [46024] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Holger Freyther.

Use same license in PluginDebug.cpp as in the original PluginDebug.h

  • plugins/PluginDebug.cpp: Use license from PluginDebug.h
03:35 Changeset [46023] by vestbo@webkit.org
  • 7 edits
    1 add in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Add more debugging functionality for the WebCore NPAPI layer

  • GNUmakefile.am: Add PluginDebug.cpp
  • WebCore.gypi: Add PluginDebug.cpp
  • WebCore.pro: Add PluginDebug.cpp
  • WebCore.vcproj/WebCore.vcproj: Add PluginDebug.cpp
  • WebCoreSources.bkl: Add PluginDebug.cpp
  • plugins/PluginDebug.h: Move errorStrings to PluginDebug.cpp
  • plugins/PluginDebug.cpp: New file
00:42 Changeset [46022] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by David Levin.

Fix Chromium build with DOM_STORAGE enabled.
https://bugs.webkit.org/show_bug.cgi?id=27360

2 minor changes as noted below:

  • bindings/v8/DerivedSourcesAllInOne.cpp: Add the generated .cpp files.
  • storage/StorageAreaImpl.cpp: #include "DOMWindow.h"
00:42 Changeset [46021] by levin@chromium.org
  • 15 edits in trunk

2009-07-16 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

Add --web-sockets flag and ENABLE_WEB_SOCKETS define.
https://bugs.webkit.org/show_bug.cgi?id=27206

.:

Add --enable-web-sockets in configure.ac

  • configure.ac:

JavaScriptCore:

Add ENABLE_WEB_SOCKETS

  • Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS

WebCore:

Add ENABLE_WEB_SOCKETS

  • Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS
  • GNUmakefile.am: add ENABLE_WEB_SOCKETS
  • WebCore.vcproj/WebCoreCommon.vsprops: add ENABLE_WEB_SOCKETS
  • WebCore.vcproj/build-generated-files.sh: add ENABLE_WEB_SOCKETS

WebKit/mac:

Add ENABLE_WEB_SOCKETS

  • Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS

WebKit/win:

Add ENABLE_WEB_SOCKETS

  • WebKit.vcproj/WebKit.vcproj: add ENABLE_WEB_SOCKETS

WebKitTools:

Add --web-sockets flag.

  • Scripts/build-webkit: add --web-sockets flag.

07/16/09:

23:41 Changeset [46020] by abarth@webkit.org
  • 1 edit
    5 adds in trunk/WebCore

2009-07-16 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Oliver Hunt.

Added a third bunch of Haiku-specific files for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=26952

Adding five files, EventLoopHaiku.cpp, FileChooserHaiku.cpp,
FileSystemHaiku.cpp, KeyboardCodes.h and MIMETypeRegistryHaiku.cpp

  • platform/haiku/EventLoopHaiku.cpp: Added. (WebCore::EventLoop::cycle):
  • platform/haiku/FileChooserHaiku.cpp: Added. (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::basenameForWidth):
  • platform/haiku/FileSystemHaiku.cpp: Added. (WebCore::fileSystemRepresentation): (WebCore::homeDirectoryPath): (WebCore::openTemporaryFile): (WebCore::closeFile): (WebCore::writeToFile): (WebCore::unloadModule): (WebCore::listDirectory):
  • platform/haiku/KeyboardCodes.h: Added.
  • platform/haiku/MIMETypeRegistryHaiku.cpp: Added. (WebCore::): (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
23:41 Changeset [46019] by abarth@webkit.org
  • 1 edit
    5 adds in trunk/WebCore

2009-07-16 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Oliver Hunt.

Added a second bunch of Haiku-specific files for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=26952

Adding four files, ContextMenuHaiku.cpp, ContextMenuItemHaiku.cpp,
DragDataHaiku.cpp and DragImageHaiku.cpp

  • platform/haiku/ContextMenuHaiku.cpp: Added. (WebCore::ContextMenuReceiver::ContextMenuReceiver): (WebCore::ContextMenuReceiver::HandleMessage): (WebCore::ContextMenuReceiver::Result): (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::platformDescription): (WebCore::ContextMenu::setPlatformDescription):
  • platform/haiku/ContextMenuItemHaiku.cpp: Added. (ContextMenuItem::ContextMenuItem): (ContextMenuItem::~ContextMenuItem): (ContextMenuItem::releasePlatformDescription): (ContextMenuItem::type): (ContextMenuItem::setType): (ContextMenuItem::action): (ContextMenuItem::setAction): (ContextMenuItem::title): (ContextMenuItem::setTitle): (ContextMenuItem::platformSubMenu): (ContextMenuItem::setSubMenu): (ContextMenuItem::setChecked): (ContextMenuItem::setEnabled): (ContextMenuItem::enabled):
  • platform/haiku/DragDataHaiku.cpp: Added. (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsColor): (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asColor): (WebCore::DragData::createClipboard): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::asFragment):
  • platform/haiku/DragImageHaiku.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
23:30 Changeset [46018] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/JavaScriptCore

2009-07-16 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

Added Haiku-specific files for JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=26620

  • wtf/haiku/MainThreadHaiku.cpp: Added. (WTF::initializeMainThreadPlatform): (WTF::scheduleDispatchFunctionsOnMainThread):
23:28 Changeset [46017] by darin@chromium.org
  • 11 edits in trunk/WebCore

2009-07-16 Stephen White <senorblanco@chromium.org>

Reviewed by Darin Fisher and Brett Wilson.

Refactor Skia implementation of gradients and patterns.

http://bugs.webkit.org/show_bug.cgi?id=26618

The following layout tests were breaking on Chromium/Linux:

LayoutTests/svg/custom/js-late-gradient-creation.svg (bad baseline PNG)
LayoutTests/svg/custom/js-late-gradient-and-object.creation.svg
LayoutTests/svg/custom/js-late-pattern-creation.svg (bad baseline PNG)
LayoutTests/svg/custom/js-late-pattern-and-object-creation.svg

I could've fixed these the easy way, by copying the same 5
lines of code we use everywhere we need patterns or gradients, but
I decided to fix it the hard way: by refactoring the code so that
PlatformContextSkia::setupPaintForFilling() and
PlatformContextSkia::setupPaintForStroking() do the right thing,
and also handle gradients and patterns.


This required pushing the gradients and patterns set in
(generic) GraphicsContext::setFillPattern() and friends down into
PlatformContextSkia. For this, I followed the setPlatformXXX()
pattern used elsewhere in GraphicsContext, and stubbed them out on
the other platforms with #if !PLATFORM(SKIA). This also required
pushing changes to the gradientSpaceTransform from the Gradient into
GradientSkia.

Since it's a Skia context, I decided to cache the values as
SkShaders. There were existing m_pattern and m_gradient SkShaders,
but they were unused, and whose use was ambiguous, so I
replaced them with one SkShader each for filling and stroking.

  • platform/graphics/Gradient.cpp: (WebCore::Gradient::setGradientSpaceTransform): (WebCore::Gradient::setPlatformGradientSpaceTransform):
  • platform/graphics/Gradient.h:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setStrokePattern): (WebCore::GraphicsContext::setFillPattern): (WebCore::GraphicsContext::setStrokeGradient): (WebCore::GraphicsContext::setFillGradient): (WebCore::GraphicsContext::setPlatformFillGradient): (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokeGradient): (WebCore::GraphicsContext::setPlatformStrokePattern):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::setPlatformGradientSpaceTransform):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformFillGradient): (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokeGradient): (WebCore::GraphicsContext::setPlatformStrokePattern): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): (PlatformContextSkia::State::~State): (PlatformContextSkia::drawRect): (PlatformContextSkia::setupPaintCommon): (PlatformContextSkia::setupPaintForFilling): (PlatformContextSkia::setupPaintForStroking): (PlatformContextSkia::setFillColor): (PlatformContextSkia::setStrokeColor): (PlatformContextSkia::setStrokeShader): (PlatformContextSkia::setFillShader):
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::skiaDrawText): (WebCore::paintSkiaText):
  • svg/graphics/SVGPaintServer.cpp: (WebCore::SVGPaintServer::teardown):
23:03 Changeset [46016] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2009-07-16 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

Added InspectorClient for Haiku WebCore support.
https://bugs.webkit.org/show_bug.cgi?id=26952

Adding two files, InspectorClientHaiku.h and InspectorClientHaiku.cpp

  • haiku/WebCoreSupport/InspectorClientHaiku.cpp: Added. (WebCore::InspectorClientHaiku::inspectorDestroyed): (WebCore::InspectorClientHaiku::createPage): (WebCore::InspectorClientHaiku::localizedStringsURL): (WebCore::InspectorClientHaiku::hiddenPanels): (WebCore::InspectorClientHaiku::showWindow): (WebCore::InspectorClientHaiku::closeWindow): (WebCore::InspectorClientHaiku::attachWindow): (WebCore::InspectorClientHaiku::detachWindow): (WebCore::InspectorClientHaiku::setAttachedWindowHeight): (WebCore::InspectorClientHaiku::highlight): (WebCore::InspectorClientHaiku::hideHighlight): (WebCore::InspectorClientHaiku::inspectedURLChanged): (WebCore::InspectorClientHaiku::populateSetting): (WebCore::InspectorClientHaiku::storeSetting): (WebCore::InspectorClientHaiku::removeSetting):
  • haiku/WebCoreSupport/InspectorClientHaiku.h: Added.
23:02 Changeset [46015] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2009-07-16 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Oliver Hunt.

Added EditorClient for Haiku WebCore support.
https://bugs.webkit.org/show_bug.cgi?id=26952

Adding two files, EditorClientHaiku.h and EditorClientHaiku.cpp

  • haiku/WebCoreSupport/EditorClientHaiku.cpp: Added. (WebCore::EditorClientHaiku::EditorClientHaiku): (WebCore::EditorClientHaiku::setPage): (WebCore::EditorClientHaiku::pageDestroyed): (WebCore::EditorClientHaiku::shouldDeleteRange): (WebCore::EditorClientHaiku::shouldShowDeleteInterface): (WebCore::EditorClientHaiku::smartInsertDeleteEnabled): (WebCore::EditorClientHaiku::isSelectTrailingWhitespaceEnabled): (WebCore::EditorClientHaiku::isContinuousSpellCheckingEnabled): (WebCore::EditorClientHaiku::toggleContinuousSpellChecking): (WebCore::EditorClientHaiku::isGrammarCheckingEnabled): (WebCore::EditorClientHaiku::toggleGrammarChecking): (WebCore::EditorClientHaiku::spellCheckerDocumentTag): (WebCore::EditorClientHaiku::isEditable): (WebCore::EditorClientHaiku::shouldBeginEditing): (WebCore::EditorClientHaiku::shouldEndEditing): (WebCore::EditorClientHaiku::shouldInsertNode): (WebCore::EditorClientHaiku::shouldInsertText): (WebCore::EditorClientHaiku::shouldChangeSelectedRange): (WebCore::EditorClientHaiku::shouldApplyStyle): (WebCore::EditorClientHaiku::shouldMoveRangeAfterDelete): (WebCore::EditorClientHaiku::didBeginEditing): (WebCore::EditorClientHaiku::respondToChangedContents): (WebCore::EditorClientHaiku::respondToChangedSelection): (WebCore::EditorClientHaiku::didEndEditing): (WebCore::EditorClientHaiku::didWriteSelectionToPasteboard): (WebCore::EditorClientHaiku::didSetSelectionTypesForPasteboard): (WebCore::EditorClientHaiku::registerCommandForUndo): (WebCore::EditorClientHaiku::registerCommandForRedo): (WebCore::EditorClientHaiku::clearUndoRedoOperations): (WebCore::EditorClientHaiku::canUndo): (WebCore::EditorClientHaiku::canRedo): (WebCore::EditorClientHaiku::undo): (WebCore::EditorClientHaiku::redo): (WebCore::EditorClientHaiku::handleKeyboardEvent): (WebCore::EditorClientHaiku::handleInputMethodKeydown): (WebCore::EditorClientHaiku::textFieldDidBeginEditing): (WebCore::EditorClientHaiku::textFieldDidEndEditing): (WebCore::EditorClientHaiku::textDidChangeInTextField): (WebCore::EditorClientHaiku::doTextFieldCommandFromEvent): (WebCore::EditorClientHaiku::textWillBeDeletedInTextField): (WebCore::EditorClientHaiku::textDidChangeInTextArea): (WebCore::EditorClientHaiku::ignoreWordInSpellDocument): (WebCore::EditorClientHaiku::learnWord): (WebCore::EditorClientHaiku::checkSpellingOfString): (WebCore::EditorClientHaiku::getAutoCorrectSuggestionForMisspelledWord): (WebCore::EditorClientHaiku::checkGrammarOfString): (WebCore::EditorClientHaiku::updateSpellingUIWithGrammarString): (WebCore::EditorClientHaiku::updateSpellingUIWithMisspelledWord): (WebCore::EditorClientHaiku::showSpellingUI): (WebCore::EditorClientHaiku::spellingUIIsShowing): (WebCore::EditorClientHaiku::getGuessesForWord): (WebCore::EditorClientHaiku::setInputMethodState): (WebCore::EditorClientHaiku::isEditing):
  • haiku/WebCoreSupport/EditorClientHaiku.h: Added.
23:02 Changeset [46014] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2009-07-16 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

Added DragClient for Haiku WebCore support.
https://bugs.webkit.org/show_bug.cgi?id=26952

Adding two files, DragClientHaiku.h and DragClientHaiku.cpp

  • haiku/WebCoreSupport/DragClientHaiku.cpp: Added. (WebCore::DragClientHaiku::actionMaskForDrag): (WebCore::DragClientHaiku::willPerformDragDestinationAction): (WebCore::DragClientHaiku::dragControllerDestroyed): (WebCore::DragClientHaiku::dragSourceActionMaskForPoint): (WebCore::DragClientHaiku::willPerformDragSourceAction): (WebCore::DragClientHaiku::startDrag): (WebCore::DragClientHaiku::createDragImageForLink):
  • haiku/WebCoreSupport/DragClientHaiku.h: Added.
23:02 Changeset [46013] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/WebKit

2009-07-16 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Oliver Hunt.

Added ContextMenuClient for Haiku WebCore support.
https://bugs.webkit.org/show_bug.cgi?id=26952

Adding two files, ContextMenuClientHaiku.h
and ContextMenuClientHaiku.cpp

  • haiku/WebCoreSupport/ContextMenuClientHaiku.cpp: Added. (WebCore::ContextMenuClientHaiku::contextMenuDestroyed): (WebCore::ContextMenuClientHaiku::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientHaiku::contextMenuItemSelected): (WebCore::ContextMenuClientHaiku::downloadURL): (WebCore::ContextMenuClientHaiku::lookUpInDictionary): (WebCore::ContextMenuClientHaiku::speak): (WebCore::ContextMenuClientHaiku::isSpeaking): (WebCore::ContextMenuClientHaiku::stopSpeaking): (WebCore::ContextMenuClientHaiku::searchWithGoogle):
  • haiku/WebCoreSupport/ContextMenuClientHaiku.h: Added.
22:47 Changeset [46012] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-07-16 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Oliver Hunt.

Added Haiku-specific files for WebCore/platform/image-decoders/.
https://bugs.webkit.org/show_bug.cgi?id=26949

Adding a new file, ImageDecoderHaiku.cpp.

  • platform/image-decoders/haiku/ImageDecoderHaiku.cpp: Added. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height):
22:47 Changeset [46011] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/WebCore

2009-07-16 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

Added Haiku-specific files for WebCore/page/.
https://bugs.webkit.org/show_bug.cgi?id=26949

Adding three new files, DragControllerHaiku.cpp, EventHandlerHaiku.cpp
and FrameHaiku.cpp

  • page/haiku/DragControllerHaiku.cpp: Added. (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::dragOperation): (WebCore::DragController::maxDragImageSize): (WebCore::DragController::cleanupAfterSystemDrag):
  • page/haiku/EventHandlerHaiku.cpp: Added. (WebCore::isKeyboardOptionTab): (WebCore::EventHandler::invertSenseOfTabsToLinks): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::createDraggingClipboard): (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::accessKeyModifiers):
  • page/haiku/FrameHaiku.cpp: Added. (WebCore::Frame::dragImageForSelection):
22:46 Changeset [46010] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-07-16 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

Added Haiku-specific files for WebCore/editing/.
https://bugs.webkit.org/show_bug.cgi?id=26949

Adding one new file, EditorHaiku.cpp

  • editing/haiku/EditorHaiku.cpp: Added. (WebCore::Editor::newGeneralClipboard):
22:46 Changeset [46009] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2009-07-16 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

Added Haiku-specific files for WebCore/bindings/js/.
https://bugs.webkit.org/show_bug.cgi?id=26949

Adding a new file, ScriptControllerHaiku.cpp

  • bindings/js/ScriptControllerHaiku.cpp: Added. (WebCore::ScriptController::createScriptInstanceForWidget):
22:46 Changeset [46008] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

2009-07-16 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

Added Haiku-specific files for WebCore/platform/text/.
https://bugs.webkit.org/show_bug.cgi?id=26949

Adding two new files, StringHaiku.cpp
and TextBreakIteratorInternalICUHaiku.cpp

  • platform/text/haiku/StringHaiku.cpp: Added. (WebCore::String::String): (WebCore::String::operator BString):
  • platform/text/haiku/TextBreakIteratorInternalICUHaiku.cpp: Added. (WebCore::currentTextBreakLocaleID):
22:29 Changeset [46007] by abarth@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-16 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Jan Alonzo.

[GTK+] Update the focus handling code.

Change focus-in to always call setActive(true), call
FocusController::setFocusedFrame when no focused frame exists
other SelectionController::setActive. This is matching Windows
and Qt.

On focus-out call FocusController::setActive(false) and
SelectionController::setFocued(false). This is matching Windows
and Qt as well.

  • webkit/webkitwebview.cpp: (webkit_web_view_focus_in_event): (webkit_web_view_focus_out_event):
21:36 Changeset [46006] by abarth@webkit.org
  • 6 edits
    2 adds in trunk

2009-07-16 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel and Adam Barth.

A test for for non-multipart file upload form submission.
This test is disabled for non-Mac platforms because of beginDragWithFiles().
<https://bugs.webkit.org/show_bug.cgi?id=26505>

  • fast/forms/get-file-upload-expected.txt: Added.
  • fast/forms/get-file-upload.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2009-07-16 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Sends the basename of a selected file for non-multipart form submission.
<https://bugs.webkit.org/show_bug.cgi?id=26505>

Test: fast/forms/get-file-upload.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData):
21:23 Changeset [46005] by abarth@webkit.org
  • 4 edits
    2 adds in trunk/WebCore

2009-07-16 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[V8] Centralize hidden property names
https://bugs.webkit.org/show_bug.cgi?id=27359

No behavior change. Just moving these names to a central location.
I'll move the rest of our hidden property names as I sweep though the
bindings.

  • WebCore.gypi:
  • bindings/v8/V8HiddenPropertyName.cpp: Added. (WebCore::V8HiddenPropertyName::objectPrototype): (WebCore::V8HiddenPropertyName::isolatedWorld):
  • bindings/v8/V8HiddenPropertyName.h: Added.
  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld): (WebCore::V8IsolatedWorld::getEntered):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::getHiddenObjectPrototype): (WebCore::V8Proxy::installHiddenObjectPrototype):
20:24 Changeset [46004] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-07-16 Gavin Barraclough <barraclough@apple.com>

RS by Oliver Hunt.

Revert r45969, this fix does not appear to be valid.
https://bugs.webkit.org/show_bug.cgi?id=27077

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::unlinkCallers):
  • jit/JIT.cpp:
  • jit/JIT.h:
19:55 Changeset [46003] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-16 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Dave Levin.

cpplint should check for one line control clauses that are surrounded
by braces
https://bugs.webkit.org/show_bug.cgi?id=27354

  • Scripts/modules/cpplint.py: Added the new lint check.
  • Scripts/modules/cpplint_unittest.py: Add tests for the new lint check and fix the other tests as they were not passing this new lint check.
17:47 Changeset [46002] by mitz@apple.com
  • 8 edits
    4 adds in trunk

WebCore:

Reviewed by Simon Fraser.

REGRESSION (r41238) Repainted portion of a scaled image does not line up with full image
https://bugs.webkit.org/show_bug.cgi?id=26747
rdar://problem/7009243

Test: fast/repaint/background-misaligned.html

  • platform/graphics/Image.cpp: (WebCore::Image::drawTiled): Moved a variable definition closer to where it is used.
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw): In the subimage code path, compute a pixel-aligned source rect, because the subiamge is always pixel-aligned in source space, and adjust the destination rect to preserve the source -> destination mapping. Clip to the (original) destination rect to prevent bleeding out.

LayoutTests:

Reviewed by Simon Fraser.

REGRESSION (r41238) Repainted portion of a scaled image does not line up with full image
https://bugs.webkit.org/show_bug.cgi?id=26747
rdar://problem/7009243

  • fast/repaint/background-misaligned.html: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/mac/fast/borders/border-image-rotate-transform-expected.checksum:
  • platform/mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/mac/fast/repaint/background-misaligned-expected.checksum: Added.
  • platform/mac/fast/repaint/background-misaligned-expected.png: Added.
  • platform/mac/fast/repaint/background-misaligned-expected.txt: Added.
17:41 Changeset [46001] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-07-16 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

Add a sessionStorageEnabled setting to the settings class.
https://bugs.webkit.org/show_bug.cgi?id=27318

Allow LocalStorage to be enabled without enabling SessionStorage at
runtime. There is a settings class setting for localStorage, but not
for sessionStorage. We want to be able to test one of these features
without necessarily enabling the other.

SessionStorage defaults to true so as to not change behavior and
because there really aren't any security concerns around SessionStorage
(unlike LocalsStorage). The flag is needed in Chromium only because
we want to enable the compile time flag in the default build, but don't
want it on by default until it's been thoroughly tested.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): Check the new flag (WebCore::DOMWindow::localStorage): A bit of cleanup
  • page/Settings.cpp: (WebCore::Settings::Settings): Default the flag to true (WebCore::Settings::setSessionStorageEnabled): Add the new flag
  • page/Settings.h: (WebCore::Settings::sessionStorageEnabled): Get the new flag
17:35 Changeset [46000] by mitz@apple.com
  • 5 edits in trunk/WebKit

../gtk:

2009-07-16 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

This is the 2nd part of fixing "RTL: tooltip does not get its directionlity from its element's."
https://bugs.webkit.org/show_bug.cgi?id=24187

Add one extra parameter to the callee of HitTestResult::title() due to the signature change.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement): Add direction as a parameter to the callee of HitTestResult::title().

../qt:

2009-07-16 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

This is the 2nd part of fixing "RTL: tooltip does not get its directionlity from its element's."
https://bugs.webkit.org/show_bug.cgi?id=24187

Add one extra parameter to the callee of HitTestResult::title() due to the signature change.

  • Api/qwebframe.cpp: (QWebHitTestResultPrivate::QWebHitTestResultPrivate): Add direction as a parameter to the callee of HitTestResult::title().
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::mouseDidMoveOverElement): Add direction as a parameter to the callee of HitTestResult::title().
17:16 Changeset [45999] by abarth@webkit.org
  • 3 edits
    2 deletes in trunk

WebCore:

2009-07-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Revert 45987. Tests did not pass on Windows.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData):

LayoutTests:

2009-07-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Revert 45987. Tests did not pass on Windows.

  • fast/forms/get-file-upload-expected.txt: Removed.
  • fast/forms/get-file-upload.html: Removed.
16:38 Changeset [45998] by pkasting@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-16 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Improve support for WebKit checkouts hosted inside other checkouts
(possible for some ports, e.g. Chromium).

  • Scripts/svn-create-patch: Determine SVN root by looking for Repository Root string and aborting when it's missing or different than what we've already seen.
16:29 Changeset [45997] by levin@chromium.org
  • 4 edits in trunk/WebCore

2009-07-16 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Added SHARED_WORKER flag to Windows build files, as well as associated .ccp/.h files.
Added missing V8 bindings to the AllInOne file

https://bugs.webkit.org/show_bug.cgi?id=27321

  • WebCore.vcproj/WebCore.vcproj: Added missing files to build.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Added missing V8 bindings (V8AbstractWorker.cpp and V8SharedWorker.cpp)
  • DerivedSources.cpp Added missing JS bindings (JSAbstractWorker.cpp and JSSharedWorker.cpp)
16:29 Changeset [45996] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-16 John Abd-El-Malek <jam@chromium.org>

Reviewed by David Levin.

Add a getter in MessagePortChannel for the PlatformMessagePortChannel.

https://bugs.webkit.org/show_bug.cgi?id=27337

  • dom/MessagePortChannel.h: (WebCore::MessagePortChannel::channel):
16:28 Changeset [45995] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-16 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Allow custom memory allocation control in ExceptionInfo and RareData struct
https://bugs.webkit.org/show_bug.cgi?id=27336

Inherits ExceptionInfo and RareData struct from FastAllocBase because these
have been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.cpp:1289 and
in JavaScriptCore/bytecode/CodeBlock.h:453.

Remove unnecessary WTF
namespace from CodeBlock inheritance.
  • bytecode/CodeBlock.h:
16:25 Changeset [45994] by pkasting@chromium.org
  • 1 edit in trunk/WebKitTools/ChangeLog

Fix accidentally blowing away a ChangeLog entry, plus a spurious comment
that no longer applied to the patch version I checked in.

15:55 Changeset [45993] by pkasting@chromium.org
  • 15 edits in trunk

2009-07-16 Peter Kasting <pkasting@google.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=27323
Improve support for non-Cygwin SVNs on Windows, as well as WebKit
checkouts hosted inside other checkouts.

  • Scripts/commit-log-editor: Modify regex so that trailing whitespace (e.g. \r) isn't included in filenames.
  • Scripts/prepare-ChangeLog: Fix a case of adding "\n" to the ChangeLog without normalizing. Normalize file paths early instead of late so all stages of the script work. Modify regexes so that trailing whitespace (e.g. \r) isn't included in filenames.
  • Scripts/svn-create-patch: Use a regex instead of chomp so we cut off line endings even if they don't match Perl's.
15:50 Changeset [45992] by abarth@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-07-16 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by Adam Treat.

Add new action to qwebpage to reload without cache.

  • Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPagePrivate::updateNavigationActions): (QWebPage::triggerAction):
  • Api/qwebpage.h:
15:43 Changeset [45991] by abarth@webkit.org
  • 25 edits in trunk

2009-07-16 Xiaomei Ji <xji@chromium.org>

Reviewed by Darin Adler.

Fix tooltip does not get its directionality from its element's directionality.
https://bugs.webkit.org/show_bug.cgi?id=24187

Per mitz's suggestion in comment #6, while getting the plain-text
title, we also get the directionality of the title. How to handle
the directionality is up to clients. Clients could ignore it,
or use attribute or unicode control characters to display the title
as what they want.

WARNING: NO TEST CASES ADDED OR CHANGED

  • WebCore.base.exp: Replace 2 names due to signature change.
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::setToolTip): Add direction as 2nd parameter.
  • page/Chrome.cpp: (WebCore::Chrome::setToolTip): Calculate tooltip direction as well and pass it to client to take care when display tooltip.
  • page/ChromeClient.h: Add direction as 2nd parameter to pure virtual function setToolTip().
  • page/chromium/ChromeClientChromium.h: (WebCore::ChromeClientChromium::setToolTip): Add setToolTip() temprarily to make chromium compile after pick up this webkit patch.
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): Besides getting the spelling tooltip, get its directionality as well. (WebCore::HitTestResult::title): Besides getting the title, get its directionality as well.
  • rendering/HitTestResult.h: Add 2 more methods.

2009-07-16 Xiaomei Ji <xji@chromium.org>

Reviewed by Darin Adler.

Fix tooltip does not get its directionality from its element's directionality.
https://bugs.webkit.org/show_bug.cgi?id=24187

Per mitz's suggestion in comment #6, while getting the plain-text
title, we also get the directionality of the title. How to handle
the directionality is up to clients. Clients could ignore it,
or use attribute or unicode control characters to display the title
as what they want.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
  • WebCoreSupport/ChromeClientGtk.h: Add directionality as 2nd parameter to setToolTip().

2009-07-16 Xiaomei Ji <xji@chromium.org>

Reviewed by Darin Adler.

Fix tooltip does not get its directionality from its element's directionality.
https://bugs.webkit.org/show_bug.cgi?id=24187

Per mitz's suggestion in comment #6, while getting the plain-text
title, we also get the directionality of the title. How to handle
the directionality is up to clients. Clients could ignore it,
or use attribute or unicode control characters to display the title
as what they want.

  • Misc/WebElementDictionary.mm: (-[WebElementDictionary _spellingToolTip]): Change spellingToolTip caller due to signature change. (-[WebElementDictionary _title]): Change title caller due to signature change.
  • WebCoreSupport/WebChromeClient.h: Add directionality as 2nd parameter to setToolTip().
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).

2009-07-16 Xiaomei Ji <xji@chromium.org>

Reviewed by Darin Adler.

Fix tooltip does not get its directionality from its element's directionality.
https://bugs.webkit.org/show_bug.cgi?id=24187

Per mitz's suggestion in comment #6, while getting the plain-text
title, we also get the directionality of the title. How to handle
the directionality is up to clients. Clients could ignore it,
or use attribute or unicode control characters to display the title
as what they want.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
  • WebCoreSupport/ChromeClientQt.h: Add directionality as 2nd parameter to setToolTip().

2009-07-16 Xiaomei Ji <xji@chromium.org>

Reviewed by Darin Adler.

Fix tooltip does not get its directionality from its element's directionality.
https://bugs.webkit.org/show_bug.cgi?id=24187

Per mitz's suggestion in comment #6, while getting the plain-text
title, we also get the directionality of the title. How to handle
the directionality is up to clients. Clients could ignore it,
or use attribute or unicode control characters to display the title
as what they want.

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
  • WebCoreSupport/WebChromeClient.h: Add directionality as 2nd parameter to setToolTip().
  • WebElementPropertyBag.cpp: (WebElementPropertyBag::Read): Change call of spellingToolTip() and title() due to signature change.

2009-07-16 Xiaomei Ji <xji@chromium.org>

Reviewed by Darin Adler.

Fix tooltip does not get its directionality from its element's directionality.
https://bugs.webkit.org/show_bug.cgi?id=24187

Per mitz's suggestion in comment #6, while getting the plain-text
title, we also get the directionality of the title. How to handle
the directionality is up to clients. Clients could ignore it,
or use attribute or unicode control characters to display the title
as what they want.

  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
  • WebKitSupport/ChromeClientWx.h: Add directionality as 2nd parameter to setToolTip().
15:36 Changeset [45990] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Rubber-stamped by Geoff Garen.

Fix FeatureDefines.xcconfig to not be out of sync with the rest of the world.

  • Configurations/FeatureDefines.xcconfig:
15:23 Changeset [45989] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2009-07-16 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Oliver Hunt.

[CAIRO] pattern of a canvas-element changes after modifications on canvas-element
https://bugs.webkit.org/show_bug.cgi?id=20578

Copy pixel image in ImageBuffer::image() just like CG and Skia glue.

  • fast/canvas/canvas-pattern-modify-expected.txt: Added.
  • fast/canvas/canvas-pattern-modify.html: Added.
  • fast/canvas/canvas-pattern-modify.js: Added. (dataToArray): (getPixel): (pixelShouldBe): (createCanvasImage):

2009-07-16 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Oliver Hunt.

[CAIRO] pattern of a canvas-element changes after modifications on canvas-element
https://bugs.webkit.org/show_bug.cgi?id=20578

Copy pixel image in ImageBuffer::image() just like CG and Skia glue.

Test: fast/canvas/canvas-pattern-modify.html

  • platform/graphics/cairo/ImageBufferCairo.cpp: (copySurface): (WebCore::ImageBuffer::image):
15:15 Changeset [45988] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2009-07-16 David Hyatt <hyatt@apple.com>

Reviewed by Beth Dakin.

https://bugs.webkit.org/show_bug.cgi?id=27353
Images mispositioned because of bug in percentage-based relative positioning.

Added fast/css/nested-floating-relative-position-percentages.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffsetX):

LayoutTests:

2009-07-16 David Hyatt <hyatt@apple.com>

Reviewed by Beth Dakin.

https://bugs.webkit.org/show_bug.cgi?id=27353
Images mispositioned because of bug in percentage-based relative positioning.

  • fast/css/nested-floating-relative-position-percentages.html: Added.
  • platform/mac/fast/css/nested-floating-relative-position-percentages-expected.checksum: Added.
  • platform/mac/fast/css/nested-floating-relative-position-percentages-expected.png: Added.
  • platform/mac/fast/css/nested-floating-relative-position-percentages-expected.txt: Added.
15:02 Changeset [45987] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2009-07-16 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

A test for for non-multipart file upload form submission.
<https://bugs.webkit.org/show_bug.cgi?id=26505>

  • fast/forms/get-file-upload-expected.txt: Added.
  • fast/forms/get-file-upload.html: Added.

2009-07-16 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Sends the basename of a selected file for non-multipart form submission.
<https://bugs.webkit.org/show_bug.cgi?id=26505>

Test: fast/forms/get-file-upload.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData):
14:52 Changeset [45986] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-07-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Video size sometimes jumps just after the video starts loading
https://bugs.webkit.org/show_bug.cgi?id=27352

Ensure that the media player is at or after the 'HaveMetadata' state so that
the instrinsic size is known before we create the layer for video. This avoids
a flash caused by computing the video rect using the default intrinsic size, and then
re-computing it when that size changes.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::isReadyForRendering): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
14:17 Changeset [45985] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-16 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Darin Adler.

WebKitTools/Scripts/svn-create-patch is broken
https://bugs.webkit.org/show_bug.cgi?id=27328

  • Scripts/svn-create-patch: one line fix for unusual perl behavior
13:57 Changeset [45984] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests/http/tests/security/isolatedWorld

Unreviewed typo fix in two tests.

13:26 Changeset [45983] by abarth@webkit.org
  • 5 edits
    31 adds in trunk/LayoutTests

2009-07-15 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Add tests for isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27331

These tests are currently disabled on JSC ports.

  • http/tests/security/isolatedWorld/all-window-properties-expected.txt: Added.
  • http/tests/security/isolatedWorld/all-window-properties.html: Added.
  • http/tests/security/isolatedWorld/all-window-prototypes-expected.txt: Added.
  • http/tests/security/isolatedWorld/all-window-prototypes.html: Added.
  • http/tests/security/isolatedWorld/body-properties-expected.txt: Added.
  • http/tests/security/isolatedWorld/body-properties.html: Added.
  • http/tests/security/isolatedWorld/body-prototype-expected.txt: Added.
  • http/tests/security/isolatedWorld/body-prototype.html: Added.
  • http/tests/security/isolatedWorld/document-properties-expected.txt: Added.
  • http/tests/security/isolatedWorld/document-properties.html: Added.
  • http/tests/security/isolatedWorld/document-prototype-expected.txt: Added.
  • http/tests/security/isolatedWorld/document-prototype.html: Added.
  • http/tests/security/isolatedWorld/global-variables-expected.txt: Added.
  • http/tests/security/isolatedWorld/global-variables.html: Added.
  • http/tests/security/isolatedWorld/image-properties-expected.txt: Added.
  • http/tests/security/isolatedWorld/image-properties.html: Added.
  • http/tests/security/isolatedWorld/image-prototype-expected.txt: Added.
  • http/tests/security/isolatedWorld/image-prototype.html: Added.
  • http/tests/security/isolatedWorld/location-properties-expected.txt: Added.
  • http/tests/security/isolatedWorld/location-properties.html: Added.
  • http/tests/security/isolatedWorld/location-prototype-expected.txt: Added.
  • http/tests/security/isolatedWorld/location-prototype.html: Added.
  • http/tests/security/isolatedWorld/number-prototype-expected.txt: Added.
  • http/tests/security/isolatedWorld/number-prototype.html: Added.
  • http/tests/security/isolatedWorld/object-prototype-expected.txt: Added.
  • http/tests/security/isolatedWorld/object-prototype.html: Added.
  • http/tests/security/isolatedWorld/string-prototype-expected.txt: Added.
  • http/tests/security/isolatedWorld/string-prototype.html: Added.
  • http/tests/security/isolatedWorld/window-properties-expected.txt: Added.
  • http/tests/security/isolatedWorld/window-properties.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
13:01 Changeset [45982] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r45979.

12:23 Changeset [45981] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-16 David Levin <levin@chromium.org>

Reviewed by David Kilzer.

cpplint should check for equality comparisons to 0/true/false
https://bugs.webkit.org/show_bug.cgi?id=27333

  • Scripts/modules/cpplint.py: Added the new lint check.
  • Scripts/modules/cpplint_unittest.py: Add tests for the new lint check and fix a regex that in another unit test that caused it to fail when you have a directory with a number in it (like WebKit-2)
11:36 Changeset [45980] by simon.fraser@apple.com
  • 1 edit
    7 adds in trunk/WebKitSite

2009-07-16 Simon Fraser <simon.fraser@apple.com>

New demo files for an up-coming blog post.

  • blog-files/3d-transforms/mighty-cubes.png: Added.
  • blog-files/3d-transforms/morphing-cubes.html: Added.
  • blog-files/3d-transforms/perspective-by-example.html: Added.
  • blog-files/3d-transforms/poster-circle.html: Added.
  • blog-files/3d-transforms/poster-circle.png: Added.
  • blog-files/3d-transforms/transform-style.html: Added.
11:35 Changeset [45979] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-07-16 Brady Eidson <beidson@apple.com>

Reviewed by Antti Koivisto.
Patch by Brady Eidson and Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=26496
<rdar://problem/7065391> Microsoft Outlook Web Access fails because XHR stream connection blocks script loading/revalidation

After refreshing a page and when all CachedResources on that page are in validation mode, they got an exemption
from the connection-per-host limit. Removing that exemption makes the test case load smoothly after reloads.

  • loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): Remove the resourceIsCacheValidator exemption to the connection-per-host limit.
10:26 Changeset [45978] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/27241> bugzilla-tool post-commits silently fails with bad args

Reviewed by Eric Seidel.

  • Scripts/bugzilla-tool: (PostCommitsAsPatchesToBug.execute): Added more error checking when consuming arguments.
10:21 Changeset [45977] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-16 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] V8IsolatedWorld::evaluate needs to call didCreateIsolatedScriptContext
https://bugs.webkit.org/show_bug.cgi?id=27335

evaluateInNewContext makes this delegate call. evaluateInNewWorld
needs to make the same call. This does not appear to be testable with
our current technology.

  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::evaluate):
10:19 Changeset [45976] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

TOOL FIX: scm.py: CommitMessage.message is ambiguous

Fixes this error when running bugzilla-tool apply-patches
--local-commit:

File "bugzilla-tool", line 188, in apply_patches

scm.commit_locally_with_message(commit_message.message() or patchname?)

TypeError: 'list' object is not callable

  • Scripts/modules/scm.py: After r45940 (and r45971), rename CommitMessage.message attribute to CommitMessage.message_lines. (CommitMessage.init): (CommitMessage.body): (CommitMessage.description): (CommitMessage.message): (CommitMessage.parse_bug_id):
09:43 Changeset [45975] by hausmann@webkit.org
  • 2 edits in trunk

2009-07-16 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Enable GNU compiler extensions to the ARM compiler
for all Qt ports using RVCT
https://bugs.webkit.org/show_bug.cgi?id=27348

  • WebKit.pri:
08:43 Changeset [45974] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-15 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

Fix a typo: application/atom=xml -> application/atom+xml.

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
08:10 Changeset [45973] by dglazkov@chromium.org
  • 6 edits in trunk

WebCore:

2009-07-16 Dean McNamee <deanm@chromium.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=27292
Improve handling of <canvas> path operations on an empty path.
Implement Skia's Path::hasCurrentPoint().

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::lineTo): (WebCore::CanvasRenderingContext2D::quadraticCurveTo): (WebCore::CanvasRenderingContext2D::bezierCurveTo):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::hasCurrentPoint):

LayoutTests:

2009-07-16 Dean McNamee <deanm@chromium.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=27292
Improve handling of <canvas> path operations on an empty path.
Implement Skia's Path::hasCurrentPoint().

  • fast/canvas/canvas-modify-emptyPath-expected.txt:
  • fast/canvas/resources/canvas-modify-emptyPath.js:
07:13 Changeset [45972] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-16 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=27320
_countof is only included in CE6; for CE5 we need to define it ourself

  • wtf/Platform.h:
06:43 Changeset [45971] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

TOOL FIX: bugzilla-tool: import CommitMessage class

  • Scripts/bugzilla-tool: After r45940, the CommitMessage class needs to be imported for commit_message_for_this_commit().
06:15 Changeset [45970] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-16 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Adam Treat.

Skip two tests for the Qt DRT to keep the results green.

fast/js/instanceof-operator.html because it requires XSLT support.

editing/selection/extend-selection-after-double-click.html needs
investigation for the Qt port after r45945

  • platform/qt/Skipped:
04:16 Changeset [45969] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-07-16 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Workers + garbage collector: weird crashes
https://bugs.webkit.org/show_bug.cgi?id=27077

We need to unlink cached method call sites when a function is destroyed.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::unlinkCallers):
  • jit/JIT.cpp: (JSC::JIT::unlinkMethodCall):
  • jit/JIT.h:
01:17 Changeset [45968] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-16 David Levin <levin@chromium.org>

Reviewed by Maciej Stachowiak.

prepare-ChangeLog should display the --bug option in its help text.
https://bugs.webkit.org/show_bug.cgi?id=27334

  • Scripts/prepare-ChangeLog: Added the help text.

07/15/09:

23:10 Changeset [45967] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

2009-07-15 David Levin <levin@chromium.org>

Rubber-stamped by Oliver Hunt.

Setting white-space and word-wrap via CSS in textarea doesn't override the wrap attribute
https://bugs.webkit.org/show_bug.cgi?id=26254

Change the expected Windows result (similar to the mac result change).

  • platform/win/fast/forms/basic-textareas-expected.txt:
22:32 Changeset [45966] by levin@chromium.org
  • 9 edits in trunk

2009-07-15 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Setting white-space and word-wrap via CSS in textarea doesn't override the wrap attribute
https://bugs.webkit.org/show_bug.cgi?id=26254

WebCore:

Make it so that setting white-space and word-wrap via CSS
overrides the wrap attribute.

This involves having the shadow div in the textarea inherit
the CSS from its parent instead of hard-coding it in
RenderTextControlMultiline.

Committer note: Earlier I reverted this change because I did it incorrectly
by leaving out css/html.css. In the patch, the filename was the old name
css/html4.css and that led to my error.

  • css/html.css:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):

LayoutTests:

Make it so that setting white-space and word-wrap via CSS
overrides the wrap attribute.

This involves having the shadow div in the textarea inherit
the CSS from its parent instead of hard-coding it in
RenderTextControlMultiline.

  • fast/forms/basic-textareas.html:
  • platform/mac/fast/forms/basic-textareas-expected.checksum:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
22:03 Changeset [45965] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-15 James Hawkins <jhawkins@google.com>

Reviewed by Adam Barth.

[V8] Remove a local variable that is shadowing a function parameter.
https://bugs.webkit.org/show_bug.cgi?id=27309

No test required as this modification does not change the current behavior.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
19:28 Changeset [45964] by agl@chromium.org
  • 3 edits
    2 deletes in trunk/WebCore

2009-07-15 Adam Langley <agl@google.com>

No review: reverting previous change.

Revert r45959:

2009-07-15 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.

Adding the Win SQLite VFS implementation for Chromium.

https://bugs.webkit.org/show_bug.cgi?id=26940

The Chromium side of this patch was landed in 20839, but broke the build. It
was reverted in r20840. Thus, I'm reverting this side of the patch too.

  • WebCore.gypi:
  • platform/chromium/ChromiumBridge.h:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: Removed.
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: Removed.
17:14 Changeset [45963] by levin@chromium.org
  • 8 edits in trunk

WebCore:

2009-07-15 David Levin <levin@chromium.org>

Layout test fix, reverting previous change.

Reverting r45962 as it caused several layout test failures.

  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):

LayoutTests:

2009-07-15 David Levin <levin@chromium.org>

Layout test fix, reverting previous change.

Reverting r45962 as it caused several layout test failures.

  • fast/forms/basic-textareas.html:
  • platform/mac/fast/forms/basic-textareas-expected.checksum:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
16:46 Changeset [45962] by levin@chromium.org
  • 8 edits in trunk

2009-06-08 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Setting white-space and word-wrap via CSS in textarea doesn't override the wrap attribute
https://bugs.webkit.org/show_bug.cgi?id=26254

WebCore:

Make it so that setting white-space and word-wrap via CSS
overrides the wrap attribute.

This involves having the shadow div in the textarea inherit
the CSS from its parent instead of hard-coding it in
RenderTextControlMultiline.

  • css/html4.css:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):

LayoutTests:

Make it so that setting white-space and word-wrap via CSS
overrides the wrap attribute.

This involves having the shadow div in the textarea inherit
the CSS from its parent instead of hard-coding it in
RenderTextControlMultiline.

  • fast/forms/basic-textareas.html:
  • platform/mac/fast/forms/basic-textareas-expected.checksum:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
16:35 Changeset [45961] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

16:34 Changeset [45960] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.5

New tag.

16:18 Changeset [45959] by japhet@chromium.org
  • 3 edits
    3 adds in trunk/WebCore

2009-07-15 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adding the Win SQLite VFS implementation for Chromium.

https://bugs.webkit.org/show_bug.cgi?id=26940

16:15 Changeset [45958] by jianli@chromium.org
  • 13 edits in trunk

WebCore:

2009-07-15 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Bug 25151 - workers that fail to load scripts not firing error event.
https://bugs.webkit.org/show_bug.cgi?id=25151

This fixes the problem that an error event is not fired when the worker
script fails to load. Some reasons this may occur are an invalid URL for
the worker script or a cross-origin redirect.

We also moves the code to complete the URL and check its origin from
Worker constructor to WorkerScriptLoader loading functions in order to
move the exception throwing logic out of the scope of Worker constructor.
Due to this change, we also remove the output ExceptionCode parameter
in the worker constructor. Corresponding JS/V8 binding codes have been
updated to reflect this change.

  • bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • workers/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::notifyFinished):
  • workers/Worker.h: (WebCore::Worker::create):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • workers/WorkerScriptLoader.cpp: (WebCore::toCrossOriginRedirectPolicy): (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously): (WebCore::notifyLoadErrorTask): (WebCore::WorkerScriptLoader::createResourceRequest): (WebCore::WorkerScriptLoader::didFail): (WebCore::WorkerScriptLoader::didFailRedirectCheck): (WebCore::WorkerScriptLoader::didReceiveAuthenticationCancellation): (WebCore::WorkerScriptLoader::notifyError):
  • workers/WorkerScriptLoader.h: (WebCore::): (WebCore::WorkerScriptLoader::url):

LayoutTests:

2009-07-15 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Bug 25151 - workers that fail to load scripts not firing error event.
https://bugs.webkit.org/show_bug.cgi?id=25151

Updates layout test cases for bug 25151.

  • fast/workers/worker-constructor-expected.txt:
  • fast/workers/worker-constructor.html:
  • http/tests/workers/worker-redirect-expected.txt:
  • http/tests/workers/worker-redirect.html:
16:11 Changeset [45957] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

16:11 Changeset [45956] by mitz@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

text-shadow is not drawn for text with transparent colour
https://bugs.webkit.org/show_bug.cgi?id=21374

Test: fast/text/shadow-translucent-fill.html

  • rendering/InlineTextBox.cpp: (WebCore::paintTextWithShadows): If the text fill color is not opaque, paint all shadows separately from the text, by casting them from clipped-out opaque text.

LayoutTests:

Reviewed by Dave Hyatt.

text-shadow is not drawn for text with transparent colour
https://bugs.webkit.org/show_bug.cgi?id=21374

  • fast/text/shadow-translucent-fill.html: Added.
  • platform/mac/fast/css/shadow-multiple-expected.checksum:
  • platform/mac/fast/css/shadow-multiple-expected.png:
  • platform/mac/fast/text/shadow-translucent-fill-expected.checksum: Added.
  • platform/mac/fast/text/shadow-translucent-fill-expected.png: Added.
  • platform/mac/fast/text/shadow-translucent-fill-expected.txt: Added.
16:02 Changeset [45955] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-07-15 Adam Treat <adam.treat@torchmobile.com>

Fix the Qt build.

  • html/HTMLAreaElement.cpp:
15:56 Changeset [45954] by darin@chromium.org
  • 18 edits in trunk/WebCore

2009-07-15 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180

DOM Storage had several unnecessary (and probably unintended)
dependencies. This patch replaces many includes of header files with
forward declaration of classes, making some destructors explicit, and
taking some factories out of the header files.

This will allow things like StorageAreaSync to take a StorageAreaImpl*
(as it should) rather than a StorageArea* which previously weren't
possible because the dependencies were such a tangled mess.

  • storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::~LocalStorageTask):
  • storage/LocalStorageTask.h:
  • storage/Storage.cpp: (WebCore::Storage::~Storage):
  • storage/Storage.h:
  • storage/StorageArea.cpp:
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp:
  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::~StorageAreaSync):
  • storage/StorageAreaSync.h:
  • storage/StorageEvent.cpp: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent):
  • storage/StorageEvent.h:
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:
  • storage/StorageNamespaceImpl.h:
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::~StorageSyncManager):
  • storage/StorageSyncManager.h:
15:33 Changeset [45953] by cmarrin@apple.com
  • 3 edits
    2 adds in trunk

Incorrect animation when trying to duplicate effect of transform-origin

https://bugs.webkit.org/show_bug.cgi?id=27310

The bug is that matrix animation is being used when animating
a list of transform functions that match in the from and to states.
This sometimes works. But because of the way CA does matrix animation
function lists like the one shown in the testcase animate incorrectly.

This fixes the bug by always doing component animation
as long as the function lists match. This allows CA
to animate the components and then recompose the result
into the correct matrix.

15:29 Changeset [45952] by jianli@chromium.org
  • 2 edits in trunk/WebCore

2009-07-15 Albert J. Wong <ajwong@chromium.org>

Reviewed by David Levin.

Upstream the V8NPObject and NPV8Object build changes for WebCore.gypi.

Add upstreamed V8 bindings files into WebCore.gypi so they can be seen
downstream
https://bugs.webkit.org/show_bug.cgi?id=27274

Changes the build file for chromium. Test built the chromium tree
to verify.

  • WebCore.gypi:
15:24 Changeset [45951] by mrowe@apple.com
  • 2 edits in trunk/WebCore

I like it when the code compiles.

  • WebCore.base.exp:
15:07 Changeset [45950] by sfalken@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge 45949.

15:02 Changeset [45949] by sfalken@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-07-15 Steve Falkenburg <sfalken@apple.com>

Windows Build fix.

Visual Studio reset our intermediate directory on us.
This sets it back.


14:56 Changeset [45948] by sfalken@apple.com
  • 16 edits in branches/safari-4-branch

Merge r45892.

14:50 Changeset [45947] by darin@apple.com
  • 40 edits in trunk

WebCore:

2009-07-15 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Renamed parseURL to deprecatedParseURL.

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue): Renamed.
  • bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL): Renamed.
  • bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL): Renamed.
  • bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc): Renamed.
  • bindings/objc/DOM.mm: (-[DOMElement _getURLAttribute:]): Renamed.
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): Renamed.
  • bindings/v8/custom/V8CustomBinding.cpp: (WebCore::allowSettingFrameSrcToJavascriptUrl): Renamed.
  • css/CSSHelper.cpp: (WebCore::deprecatedParseURL): Renamed.
  • css/CSSHelper.h: Renamed and updated comment.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Renamed. (WebCore::HTMLAnchorElement::parseMappedAttribute): Renamed.
  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::parseMappedAttribute): Renamed.
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Renamed.
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): Renamed.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::parseMappedAttribute): Renamed.
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute): Renamed.
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Renamed.
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::sourceURI): Renamed.
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute): Renamed.
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): Renamed.
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): Renamed.
  • html/HTMLTablePartElement.cpp: (WebCore::HTMLTablePartElement::parseMappedAttribute): Renamed.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Renamed.
  • html/PreloadScanner.cpp: (WebCore::PreloadScanner::processAttribute): Renamed. (WebCore::PreloadScanner::emitCSSRule): Renamed.
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::declareAndWriteDragImage): Renamed.
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage): Renamed.
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage): Renamed.
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::declareAndWriteDragImage): Renamed.
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): Renamed. (WebCore::HitTestResult::absoluteMediaURL): Renamed. (WebCore::HitTestResult::absoluteLinkURL): Renamed.
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): Renamed.
  • svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI): Renamed.
  • wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler): Renamed.
  • wml/WMLImageLoader.cpp: (WebCore::WMLImageLoader::sourceURI): Renamed.

WebKit/mac:

2009-07-15 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Renamed parseURL to deprecatedParseURL.

  • DOM/WebDOMOperations.mm: (-[DOMDocument URLWithAttributeString:]): Renamed.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Renamed.

WebKit/win:

2009-07-15 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Renamed parseURL to deprecatedParseURL.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Renamed.

WebKitTools:

2009-07-15 Darin Adler <darin@apple.com>

  • Scripts/do-webcore-rename: Check in the version used to rename parseURL to deprecatedParseURL.
14:44 Changeset [45946] by darin@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

2009-07-15 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

CSSHelper.h's parseURL is a function that no one should ever call
Part 1: Eliminate callers in the CSS parser.
https://bugs.webkit.org/show_bug.cgi?id=26599

Test: fast/css/uri-token-parsing.html

  • css/CSSHelper.h: Added a comment explaining why nobody should ever call this function. A FIXME suggests a next step, which would be to rename it deprecatedParseURL.
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Removed unneeded call to parseURL; CSSParser::text already takes care of parsing the URI token syntax, and the parseURL function does no good. (WebCore::CSSParser::parseContent): Ditto. (WebCore::CSSParser::parseFillImage): Ditto. (WebCore::CSSParser::parseFontFaceSrc): Ditto. (WebCore::CSSParser::parseBorderImage): Ditto. (WebCore::isCSSWhitespace): Added. Helper function that makes the text function easier to read. (WebCore::CSSParser::text): Tweak logic so that leading and trailing whitespace are both trimmed before removing the quote marks. Changed to use the isCSSWhitespace, isASCIIHexDigit, and toASCIIHexValue functions for clarity.
  • css/CSSParser.h: Removed stray "public:" in this header.
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::substring): Optimized the case where the substring covers the entire string, so we just share the StringImpl instead of making a new one. This case came up in earlier versions of the CSS parser changes above. (WebCore::StringImpl::substringCopy): Streamlined the logic here and made it not call substring any more. Before, this was relying on the substring function always making a copy of any non-empty substring.

LayoutTests:

2009-07-15 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

CSSHelper.h's parseURL is a function that no one should ever call
Part 1: Eliminate callers in the CSS parser.
https://bugs.webkit.org/show_bug.cgi?id=26599

  • fast/css/uri-token-parsing-expected.txt: Added.
  • fast/css/uri-token-parsing.html: Added. Tests URI token parsing cases, many of which were handled wrong before due to stripping quotes and URL() twice.
14:35 Changeset [45945] by darin@apple.com
  • 3 edits
    1 copy
    1 add in trunk

WebCore:

2009-07-15 Darin Adler <darin@apple.com>

Reviewed by John Sullivan.

After double-clicking a word, using Shift-arrow to select behaves unpredictably
https://bugs.webkit.org/show_bug.cgi?id=27177
rdar://problem/7034324

Test: editing/selection/extend-selection-after-double-click.html

The bug was due to the m_lastChangeWasHorizontalExtension flag, which was not
being cleared in many cases where it should have been.

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Set m_lastChangeWasHorizontalExtension to false. This catches all sorts of cases that don't flow through the modify function. Before, the flag would reflect the last call to the modify function, which was not necessarily the last selection change. (WebCore::SelectionController::willBeModified): Rearrange function for clarity. Remove code that sets m_lastChangeWasHorizontalExtension; that is now handled elsewhere. (WebCore::SelectionController::modify): Call setLastChangeWasHorizontalExtension after setSelection when setting up a trial selection controller, since setSelection now clears that flag. Also changed both trial selection controller cases to set the flag, although it's not strictly necessary in both cases. Added code to set m_lastChangeWasHorizontalExtension when extending the selection, which used to be handled in willBeModified. Now we need to do it after the selection change.

LayoutTests:

2009-07-15 Darin Adler <darin@apple.com>

Reviewed by John Sullivan.

After double-clicking a word, using Shift-arrow to select behaves unpredictably
https://bugs.webkit.org/show_bug.cgi?id=27177
rdar://problem/7034324

  • editing/selection/extend-selection-after-double-click-expected.txt: Added.
  • editing/selection/extend-selection-after-double-click.html: Copied from LayoutTests/editing/selection/word-granularity.html. Then turned it into a new test.
14:16 Changeset [45944] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-07-15 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Need to update DOM Storage files in GYPI file.
https://bugs.webkit.org/show_bug.cgi?id=27317

Need to update DOM Storage files in the GYPI file. They're pretty out
of date and we're on the path towards enabling them for everyone!

  • WebCore.gypi:
13:55 Changeset [45943] by bfulgham@webkit.org
  • 5 edits in trunk

JavaScriptCore:

2009-07-15 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26794
Make Yacc-generated parsers to use fastMalloc/fastFree.


Define YYMALLOC and YYFREE to fastMalloc and fastFree
respectively.

  • parser/Grammar.y:

WebCore:

2009-07-15 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26794
Make Yacc-generated parsers to use fastMalloc/fastFree.


Define YYMALLOC and YYFREE to fastMalloc and fastFree
respectively.

  • css/CSSGrammar.y:
  • xml/XPathGrammar.y:
13:49 Changeset [45942] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Jan Alonzo.

Fix enable-xss-auditor property documentation, and default value
to match the fact that it is now enabled by default.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
13:43 Changeset [45941] by hyatt@apple.com
  • 11 edits in trunk

WebCore:

2009-07-15 David Hyatt <hyatt@apple.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=27193
Don't run in to anonymous blocks. No other browsers do this, and our implementation of run-in
is effectively broken as a result.

No new tests. Changed fast/runin/001.html and fast/runin/generated.html to match new behavior.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):

LayoutTests:

2009-07-15 David Hyatt <hyatt@apple.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=27193
Don't let run-ins run in to anonymous blocks.

  • fast/runin/001.html:
  • fast/runin/generated.html:
  • platform/mac/fast/runin/001-expected.checksum:
  • platform/mac/fast/runin/001-expected.png:
  • platform/mac/fast/runin/001-expected.txt:
  • platform/mac/fast/runin/generated-expected.checksum:
  • platform/mac/fast/runin/generated-expected.png:
  • platform/mac/fast/runin/generated-expected.txt:
13:15 Changeset [45940] by bfulgham@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-10 David Kilzer <ddkilzer@apple.com>

bugzilla-tool: create CommitMessage class

Reviewed by Eric Seidel.

Create a CommitMessage class to encapsulate related code.

  • Scripts/bugzilla-tool: (bug_id_from_commit_message): Moved to CommitMessage.parse_bug_id(). (commit_message_for_this_commit): Return a CommitMessage. (ApplyPatchesFromBug.apply_patches): Use CommitMessage.message(). (LandPatchesFromBugs.build_and_commit): Ditto. (CommitMessageForCurrentDiff.execute): Ditto. (PostCommitsAsPatchesToBug.execute): Switched from Git.commit_message_for_commit() to Git.commit_message_for_local_commit(). Switched from bug_id_from_commit_message() to CommitMessage.parse_bug_id().
  • Scripts/modules/scm.py: (first_non_empty_line_after_index): Added. (CommitMessage.init): Added. (CommitMessage.body): Added. (CommitMessage.description): Added. (CommitMessage.message): Added. (CommitMessage.parse_bug_id): Added. Moved from bug_id_from_commit_message() in bugzilla-tool. (Git.commit_message_for_local_commit): Renamed from commit_message_for_commit(). Return a CommitMessage.
13:11 Changeset [45939] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-15 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by David Kilzer.

bugzilla-tool/svn-apply can't handle patches made from a non-root directory
https://bugs.webkit.org/show_bug.cgi?id=26999

  • Scripts/svn-create-patch:
13:08 Changeset [45938] by bfulgham@webkit.org
  • 21 edits
    4 adds in trunk

WebCore:

2009-07-15 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Test: fast/js/instanceof-operator.html

Fix for: Bug 25205 - XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205

In addition to for XMLHttpRequest, this also fixes for:

  • Audio
  • Image
  • MessageChannel
  • Option
  • WebKitCSSMatrix
  • WebKitPoint
  • Worker
  • XSLTProcessor
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSDOMBinding.h: (WebCore::DOMConstructorObject::createStructure): (WebCore::DOMConstructorObject::DOMConstructorObject):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
  • bindings/js/JSMessageChannelConstructor.h:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSOptionConstructor.h:
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
  • bindings/js/JSWebKitCSSMatrixConstructor.h:
  • bindings/js/JSWebKitPointConstructor.cpp: (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
  • bindings/js/JSWebKitPointConstructor.h:
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::JSWorkerConstructor::JSWorkerConstructor):
  • bindings/js/JSWorkerConstructor.h:
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  • bindings/js/JSXMLHttpRequestConstructor.h:
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
  • bindings/js/JSXSLTProcessorConstructor.h:

LayoutTests:

2009-07-15 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Fix for: Bug 25205 - XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205

In addition to for XMLHttpRequest, this also fixes for:

  • Audio
  • Image
  • MessageChannel
  • Option
  • WebKitCSSMatrix
  • WebKitPoint
  • Worker
  • XSLTProcessor
  • fast/js/instanceof-operator-expected.txt: Added.
  • fast/js/instanceof-operator.html: Added.
  • fast/js/resources/instanceof-operator-dummy-worker.js: Added.
  • fast/js/resources/instanceof-operator.js: Added.
12:51 Changeset [45937] by bfulgham@webkit.org
  • 5 edits
    4 adds in trunk

WebCore:

2009-07-15 Kai Bruning <kai@granus.net>

Reviewed by Dave Hyatt.

CSS21 attribute selectors not dynamic for xml.
https://bugs.webkit.org/show_bug.cgi?id=25072

Moved the relevant test in StyledElement::attributeChanged()
to a new function Element::recalcStyleIfNeededAfterAttributeChanged()
so it can be called from both StyledElement::attributeChanged()
and Element::attributeChanged().
Refactored Element::attributeChanged() into
Element::updateAfterAttributeChanged() and
Element::recalcStyleIfNeededAfterAttributeChanged(), which are called
separately from StyledElement::attributeChanged().

Test: fast/css/attribute-selector-dynamic.xml

  • dom/Element.cpp: (WebCore::Element::attributeChanged): (WebCore::Element::updateAfterAttributeChanged): (WebCore::Element::recalcStyleIfNeededAfterAttributeChanged):
  • dom/Element.h:
  • dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged):

LayoutTests:

2009-07-15 Kai Bruning <kai@granus.net>

Reviewed by Dave Hyatt.

CSS21 attribute selectors not dynamic for xml.
https://bugs.webkit.org/show_bug.cgi?id=25072

Test that CSS21 attribute selectors take effect when the attribute is
dynamically changed in an xml dom.

  • fast/css/attribute-selector-dynamic.xml: Added.
  • platform/mac/fast/css/attribute-selector-dynamic-expected.checksum: Added.
  • platform/mac/fast/css/attribute-selector-dynamic-expected.png: Added.
  • platform/mac/fast/css/attribute-selector-dynamic-expected.txt: Added.
12:27 Changeset [45936] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-15 Alpha Lam <hclam@chromium.org>

Reviewed by David Levin.

[V8] Layout test failures for drawImage in Canvas
https://bugs.webkit.org/show_bug.cgi?id=27311

Fixing several canvas layout tests failures due to a
missing return statement in CanvasRenderingContext2DDrawImage() which
was accidentally removed in r45929.

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
12:16 Changeset [45935] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-15 Robert Hogan <robert@roberthogan.net>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26969

If the httpMethod() of the request passed to SubresourceLoader::create is not
supported by the client we must expect to call didFail() while m_loader is still null.

  • loader/DocumentThreadableLoader.cpp: (DocumentThreadableLoader::didFail):Changed.
11:34 Changeset [45934] by abarth@webkit.org
  • 2 edits in trunk/WebKitSite

2009-07-15 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Sam Weinig.

Side bar linking to "DOM Interfaces" returns 404
https://bugs.webkit.org/show_bug.cgi?id=24000

  • nav.inc:
11:28 Changeset [45933] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-07-15 Darin Adler <darin@apple.com>

Fix a build for a particular Apple configuration.

  • wtf/FastAllocBase.h: Change include to use "" style for including another wtf header. This is the style we use for including other public headers in the same directory.
11:25 Changeset [45932] by levin@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Add bug link to changelog entry.

11:23 Changeset [45931] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-15 George Staikos <george.staikos@torchmobile.com>

Reviewed by Adam Treat.

https://bugs.webkit.org/show_bug.cgi?id=27303
Implement createThreadInternal for WinCE.
Contains changes by George Staikos <george.staikos@torchmobile.com> and Joe Mason <joe.mason@torchmobile.com>

  • wtf/ThreadingWin.cpp: (WTF::createThreadInternal):
11:22 Changeset [45930] by mrowe@apple.com
  • 6 edits in trunk/WebCore

Fix the Mac build.

  • WebCore.base.exp:
  • css/MediaQueryEvaluator.cpp:
  • rendering/SVGRenderTreeAsText.cpp:
  • rendering/style/SVGRenderStyle.cpp:
  • svg/graphics/SVGPaintServer.cpp:
11:21 Changeset [45929] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-15 Alpha Lam <hclam@chromium.org>

Reviewed by Dimitri Glazkov.

Changed CanvasRenderingContext2DDrawImage() to accept HTMLVideoElement
as a parameter of drawImage() for HTMLCanvasElement.

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
11:14 Changeset [45928] by abarth@webkit.org
  • 7 edits in trunk/WebCore

2009-07-15 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Fix isolated world constructors
https://bugs.webkit.org/show_bug.cgi?id=27287

Don't enter V8Proxy::m_context before creating DOM constructors.
Instead, use getWrapperContext to get the right context.

After this patch, all my tests pass. I'll enable the feature
downstream and land the tests.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor): (WebCore::V8DOMWrapper::lookupDOMWrapper):
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::evaluate):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createWrapperFromCache): (WebCore::V8Proxy::isContextInitialized): (WebCore::V8Proxy::disposeContextHandles): (WebCore::V8Proxy::installDOMWindow): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::getHiddenObjectPrototype): (WebCore::V8Proxy::installHiddenObjectPrototype):
  • bindings/v8/V8Proxy.h:
11:12 Changeset [45927] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-15 Joe Mason <joe.mason@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=27298
Platform defines for WINCE.
Contains changes by Yong Li <yong.li@torchmobile.com>,
George Staikos <george.staikos@torchmobile.com> and Joe Mason <joe.mason@torchmobile.com>

  • wtf/Platform.h:
11:07 Changeset [45926] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-15 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Darin Adler.

useless null-check statement in visible_units.cpp@logicalStartOfLine
https://bugs.webkit.org/show_bug.cgi?id=27154

Simple fix.

  • editing/visible_units.cpp: (WebCore::logicalStartOfLine): Doubled honorEditableBoundaryAtOrAfter() call removed.
10:44 Changeset [45925] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/WebCore.base.exp

Attempted Mac Build Fix.

10:34 Changeset [45924] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-15 Yong Li <yong.li@torchmobile.com>

Reviewed by Adam Treat.

https://bugs.webkit.org/show_bug.cgi?id=27306
Use RegisterClass instead of RegisterClassEx on WinCE.

  • wtf/win/MainThreadWin.cpp: (WTF::initializeMainThreadPlatform):
10:32 Changeset [45923] by beidson@apple.com
  • 12 edits in trunk

WebCore:

2009-07-15 Brady Eidson <beidson@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27304
WebKit should provide usage and eligibility information about the page cache.

  • WebCore.base.exp:
  • history/CachedFrame.cpp: (WebCore::CachedFrame::childFrameCount):
  • history/CachedFrame.h:
  • history/PageCache.cpp: (WebCore::PageCache::frameCount): (WebCore::PageCache::autoreleasedPageCount):
  • history/PageCache.h: (WebCore::PageCache::pageCount):

WebKit/mac:

2009-07-15 Brady Eidson <beidson@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27304
WebKit should provide usage and eligibility information about the page cache.

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics numberCachedPages]): (+[WebCoreStatistics numberCachedFrames]): (+[WebCoreStatistics numberAutoreleasedPages]):
  • WebKit.exp:
  • WebView/WebFrame.mm: (-[WebFrame _cacheabilityDictionary]): Returns a dictionary with all the data about why the frame is not cacheable. If the frame *is* cacheable, the dictionary is empty.
  • WebView/WebFramePrivate.h:
10:31 Changeset [45922] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-15 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

Chromium's canvas forgets its context after fillText again
https://bugs.webkit.org/show_bug.cgi?id=27293

No new tests because the test for this was already added in
https://bugs.webkit.org/show_bug.cgi?id=26436

  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::compositeTextComposite):
10:20 Changeset [45921] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-15 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=27301
Use OutputDebugStringW on WinCE since OutputDebugStringA is not supported
Originally written by Yong Li <yong.li@torchmobile.com> and refactored by
Joe Mason <joe.mason@torchmobile.com>

  • wtf/Assertions.cpp: vprintf_stderr_common
10:07 Changeset [45920] by levin@chromium.org
  • 1 edit
    2 moves in trunk/WebKitTools

2009-07-15 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

Move cpplint.py to module directory
https://bugs.webkit.org/show_bug.cgi?id=27302

  • Scripts/modules/cpplint.py: Renamed from WebKitTools/Scripts/cpplint.py.
  • Scripts/modules/cpplint_unittest.py: Renamed from WebKitTools/Scripts/cpplint_unittest.py.
10:02 Changeset [45919] by hyatt@apple.com
  • 19 edits
    10 adds in trunk

WebCore:

2009-07-14 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=27283

Implement the new 'rem' unit from CSS3.

Added some rem-* tests in fast/css.

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::validUnit): (WebCore::unitFromString): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::lex):
  • css/CSSParserValues.cpp: (WebCore::CSSParserValue::createCSSValue):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthInt): (WebCore::CSSPrimitiveValue::computeLengthIntForLength): (WebCore::CSSPrimitiveValue::computeLengthShort): (WebCore::CSSPrimitiveValue::computeLengthFloat): (WebCore::CSSPrimitiveValue::computeLengthDouble): (WebCore::CSSPrimitiveValue::cssText): (WebCore::CSSPrimitiveValue::parserValue):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::): (WebCore::CSSPrimitiveValue::isUnitTypeLength):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapFillSize): (WebCore::CSSStyleSelector::mapFillXPosition): (WebCore::CSSStyleSelector::mapFillYPosition): (WebCore::CSSStyleSelector::createTransformOperations):
  • css/CSSStyleSelector.h:
  • css/MediaQueryEvaluator.cpp: (WebCore::device_heightMediaFeatureEval): (WebCore::device_widthMediaFeatureEval): (WebCore::heightMediaFeatureEval): (WebCore::widthMediaFeatureEval):
  • css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::setMatrixValue):
  • css/tokenizer.flex:
  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h: (WebCore::Document::usesRemUnits): (WebCore::Document::setUsesRemUnits):
  • dom/Element.cpp: (WebCore::Element::recalcStyle):
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle):
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::cssPrimitiveToLength):
  • svg/graphics/SVGPaintServer.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::dashArrayFromRenderingStyle):
  • svg/graphics/SVGPaintServer.h:

LayoutTests:

2009-07-14 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

Add layout tests for the new CSS3 'rem' unit type.

  • fast/css/rem-dynamic-scaling.html: Added.
  • fast/css/rem-units-on-root.html: Added.
  • fast/css/remove-shorthand-expected.checksum: Added.
  • fast/css/remove-shorthand-expected.png: Added.
  • platform/mac/fast/css/rem-dynamic-scaling-expected.checksum: Added.
  • platform/mac/fast/css/rem-dynamic-scaling-expected.png: Added.
  • platform/mac/fast/css/rem-dynamic-scaling-expected.txt: Added.
  • platform/mac/fast/css/rem-units-on-root-expected.checksum: Added.
  • platform/mac/fast/css/rem-units-on-root-expected.png: Added.
  • platform/mac/fast/css/rem-units-on-root-expected.txt: Added.
09:58 Changeset [45918] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-15 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=27020
msToGregorianDateTime should set utcOffset to 0 when outputIsUTC is false

  • wtf/DateMath.cpp: (WTF::gregorianDateTimeToMS):
09:56 Changeset [45917] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-07-15 Brian Weinstein <bweinstein@apple.com>

Rubberstamped by Mark Rowe.

Add one more test to Windows Skipped List to hopefully get it to stay green.

  • platform/win/Skipped:
09:27 Changeset [45916] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-07-15 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

Remove extraneous qualifier, accidentally added in http://trac.webkit.org/changeset/45884.

  • bindings/v8/V8DOMWrapper.h: Removed extraneous qualifier.
09:17 Changeset [45915] by dglazkov@chromium.org
  • 5 edits in trunk/WebCore

2009-07-15 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

[V8] Update bindings for ValiditeState patch.
https://bugs.webkit.org/show_bug.cgi?id=19562

  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
08:49 Changeset [45914] by hausmann@webkit.org
  • 5 edits in trunk

JavaScriptCore:

2009-07-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Cleanup - Remove obsolete code from the make system
https://bugs.webkit.org/show_bug.cgi?id=27299

WebCore:

2009-07-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Cleanup - Remove obsolete code from the make system
https://bugs.webkit.org/show_bug.cgi?id=27299

  • WebCore.pro:
08:41 Changeset [45913] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-15 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=27285

When the user clicks a link with a target attribute, the newly created window should be visible.
Make new windows created in Qtlauncher visible.

  • QtLauncher/main.cpp: (WebPage::createWindow):
08:33 Changeset [45912] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-15 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Fix the build without media elements.

  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL): Add #if ENABLE(VIDEO) markers around the body of the method.
08:18 Changeset [45911] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-07 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=27056

Alternate bool operator for codewarrior compiler (WINSCW).
Compiler (latest b482) reports error for UnspecifiedBoolType construct:
"illegal explicit conversion from 'WTF::OwnArrayPtr<JSC::Register>' to 'bool'"

Same fix as in r38391.

08:14 Changeset [45910] by vestbo@webkit.org
  • 2 edits in trunk

2009-07-15 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Rubber-stamped by Simon Hausmann.

Fix the Qt/Mac build by disabling TestNetscapePlugin

We should fix and enable this once we run DRT for Qt/Mac

  • WebKit.pro:
08:14 Changeset [45909] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-15 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Darin Adler.

Qualify include path with wtf to fix compilation
on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=27055

  • interpreter/Interpreter.h:
07:18 Changeset [45908] by hausmann@webkit.org
  • 4 edits in trunk/JavaScriptCore

2009-07-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Dave Kilzer.

Turn off non-portable date manipulations for SYMBIAN
https://bugs.webkit.org/show_bug.cgi?id=27064

Introduce HAVE(TM_GMTOFF), HAVE(TM_ZONE) and HAVE(TIMEGM) guards
and place the rules for controlling the guards in Platform.h.
Turn off these newly introduced guards for SYMBIAN.

  • wtf/DateMath.cpp: (WTF::calculateUTCOffset):
  • wtf/DateMath.h: (WTF::GregorianDateTime::GregorianDateTime): (WTF::GregorianDateTime::operator tm):
  • wtf/Platform.h:
07:04 Changeset [45907] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-15 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Undef ASSERT on Symbian, to avoid excessive warnings
https://bugs.webkit.org/show_bug.cgi?id=27052

  • wtf/Assertions.h:
05:51 Changeset [45906] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-15 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Adam Treat.

https://bugs.webkit.org/show_bug.cgi?id=27295

Re-implement QWebPage::shouldInterruptJavaScript to disable
js interruption and avoid showing a messagebox during Qt DRT
runs when script execution takes a bit longer.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::shouldInterruptJavaScript): Return false in re-implemented slot.
05:49 Changeset [45905] by jmalonzo@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-07-15 Aron Xu <aronmalache@163.com>

Rubber-stamped by Jan Alonzo.

Simplified Chinese translation
https://bugs.webkit.org/show_bug.cgi?id=27252

  • zh_CN.po: Added.
05:16 Changeset [45904] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

REGRESSION: fast/js/postfix-syntax.html fails with interpreter
https://bugs.webkit.org/show_bug.cgi?id=27294

Reviewed by Simon Hausmann.

When postfix operators operating on locals assign to the same local
the order of operations has to be to store the incremented value, then
store the unmodified number. Rather than implementing this subtle
semantic in the interpreter I've just made the logic explicit in the
bytecode generator, so x=x++ effectively becomes x=ToNumber(x) (for a
local var x).

02:59 Changeset [45903] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

REGRESSION(43559): fast/js/kde/arguments-scope.html fails with interpreter
https://bugs.webkit.org/show_bug.cgi?id=27259

Reviewed by Simon Hausmann

The interpreter was incorrectly basing its need to create the arguments object
based on the presence of the callframe's argument reference rather than the local
arguments reference. Based on this it then overrode the local variable reference.

02:32 Changeset [45902] by jmalonzo@webkit.org
  • 1 edit in trunk/WebKit/gtk/po/ChangeLog

Fix ChangeLog attribution to Bruce Cowan

02:29 Changeset [45901] by jmalonzo@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-07-15 Jan Michael Alonzo <jmalonzo@webkit.org>

Rubber-stamped by Jan Alonzo.

[Gtk] en_GB translation
https://bugs.webkit.org/show_bug.cgi?id=27244

  • en_GB.po: Added.
02:12 Changeset [45900] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-15 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Jan Alonzo.

Fix the DumpRenderTree GTK+ build
https://bugs.webkit.org/show_bug.cgi?id=27290

Set USE_SYSTEM_MALLOC macro for the DumpRenderTree build to
disable using TCmalloc in DumpRenderTree.

  • GNUmakefile.am:
01:10 Changeset [45899] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-07-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Move storeLastActivePanel out of the
ifdef ENABLE_JAVASCRIPT_DEBUGGER section in IDL;
Add default panel for the first opening of the
WebInspector.

https://bugs.webkit.org/show_bug.cgi?id=27263

  • inspector/InspectorController.cpp: (InspectorController::setWindowVisible):
  • inspector/InspectorController.idl:

07/14/09:

23:44 Changeset [45898] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-07-14 Brian Weinstein <bweinstein@apple.com>

Rubberstamped by Mark Rowe.

Add tests to Windows Skip list to get it back in green.

  • platform/win/Skipped:
23:00 Changeset [45897] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-14 Steve Falkenburg <sfalken@apple.com>

Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/

Reviewed by Darin Adler.

22:58 Changeset [45896] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-07-14 Darin Adler <darin@apple.com>

Try to fix Windows build.

  • bindings/scripts/CodeGeneratorCOM.pm: Add Reflect and ReflectURL support.
22:40 Changeset [45895] by darin@apple.com
  • 38 edits in trunk

Clear stray executable bits that have crept in over time.

22:40 Changeset [45894] by pdherbemont@apple.com
  • 3 edits in trunk/WebCore

2009-07-14 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Oliver Hunt.

HTMLMediaElement::supportsFullscreen() should return false
https://bugs.webkit.org/show_bug.cgi?id=27284

(Reverting a part of 45875)

HTMLVideoElement::supportsFullscreen() will properly do the
job, and check if the backend supports fullscreen.

HTMLVideoElement is the only subclass to support fullscreen
(conditionnaly). HTMLAudioElement fullscreen is not supported
and is a different kind of fullscreen, if it comes to be wanted.

No test can be done currently given that none of the media
backends support fullscreen.

  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::supportsFullscreen):
22:26 Changeset [45893] by darin@apple.com
  • 26 edits in trunk/WebCore

2009-07-14 Darin Adler <darin@apple.com>

Reviewed by Dimitri Glazkov.

Next step in making DOM attribute getter/setters consistently use AtomicString
https://bugs.webkit.org/show_bug.cgi?id=25425

This covers eight DOM classes, and for each one of the classes:

  • Changes the IDL to use the Reflect syntax for all simple cases.
  • Removes unused functions in the classes, mainly newly unused ones that were used for reflection before.
  • Removes unneeded explicitly defined destructors.
  • Explicitly declares destructors as virtual.
  • Removes unneeded includes.
  • Makes members protected or private rather than public where possible.
  • Renames "doc" to "document".
  • Tweaks formatting to match our latest style in a few places.
  • Improves some FIXME comments.

Over time we'll want to do this for all HTML DOM classes.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement):
  • html/HTMLAnchorElement.h: (WebCore::HTMLAnchorElement::endTagRequirement): (WebCore::HTMLAnchorElement::tagPriority):
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.cpp:
  • html/HTMLAppletElement.h:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute):
  • html/HTMLAreaElement.h: (WebCore::HTMLAreaElement::endTagRequirement): (WebCore::HTMLAreaElement::tagPriority):
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.cpp: (WebCore::HTMLBRElement::parseMappedAttribute):
  • html/HTMLBRElement.h:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::HTMLBaseElement): (WebCore::HTMLBaseElement::removedFromDocument): (WebCore::HTMLBaseElement::process):
  • html/HTMLBaseElement.h:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.cpp: (WebCore::HTMLBaseFontElement::HTMLBaseFontElement):
  • html/HTMLBaseFontElement.h: (WebCore::HTMLBaseFontElement::endTagRequirement): (WebCore::HTMLBaseFontElement::tagPriority):
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.cpp: (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
  • html/HTMLBlockquoteElement.h: (WebCore::HTMLBlockquoteElement::tagPriority):
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::HTMLBodyElement): (WebCore::HTMLBodyElement::addSubresourceAttributeURLs):
  • html/HTMLBodyElement.h: (WebCore::HTMLBodyElement::endTagRequirement): (WebCore::HTMLBodyElement::tagPriority):
  • html/HTMLBodyElement.idl: Made changes as described above.
  • loader/FrameLoader.cpp: Removed unneeded include of HTMLAnchorElement.h.
22:22 Changeset [45892] by sfalken@apple.com
  • 15 edits in trunk

JavaScriptCore:

2009-07-14 Steve Falkenburg <sfalken@apple.com>

Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/

Reviewed by Darin Adler.

WebCore:

2009-07-14 Steve Falkenburg <sfalken@apple.com>

Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/

Reviewed by Darin Adler.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/build-generated-files.sh:

WebKit/win:

2009-07-14 Steve Falkenburg <sfalken@apple.com>

Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/

Reviewed by Darin Adler.

  • WebKit.vcproj/WebKit.vcproj:

WebKitTools:

2009-07-14 Steve Falkenburg <sfalken@apple.com>

Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/

Reviewed by Darin Adler.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
22:13 Changeset [45891] by bfulgham@webkit.org
  • 113 edits in trunk

JavaScriptCore:

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225

Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).

  • bytecode/SamplingTool.h:
  • bytecompiler/RegisterID.h:
  • interpreter/CachedCall.h:
  • interpreter/RegisterFile.h:
  • parser/Lexer.h:
  • parser/Parser.h:
  • runtime/ArgList.h:
  • runtime/BatchedTransitionOptimizer.h:
  • runtime/Collector.h:
  • runtime/CommonIdentifiers.h:
  • runtime/JSCell.h:
  • runtime/JSGlobalObject.h:
  • runtime/JSLock.h:
  • runtime/JSONObject.cpp:
  • runtime/SmallStrings.cpp:
  • runtime/SmallStrings.h:
  • wtf/CrossThreadRefCounted.h:
  • wtf/GOwnPtr.h:
  • wtf/Locker.h:
  • wtf/MessageQueue.h:
  • wtf/OwnArrayPtr.h:
  • wtf/OwnFastMallocPtr.h:
  • wtf/OwnPtr.h:
  • wtf/RefCounted.h:
  • wtf/ThreadSpecific.h:
  • wtf/Threading.h:
  • wtf/Vector.h:
  • wtf/unicode/Collator.h:

WebCore:

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225

Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).

  • bindings/js/GCController.h:
  • bindings/js/WorkerScriptController.h:
  • bindings/v8/V8DOMMap.cpp: (WebCore::):
  • bridge/runtime.h:
  • css/CSSSelector.h:
  • css/CSSSelectorList.h:
  • css/CSSStyleSelector.h:
  • dom/ClassNames.h:
  • dom/MessagePortChannel.h:
  • dom/XMLTokenizerLibxml2.cpp:
  • dom/XMLTokenizerScope.h:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/SelectionController.h:
  • editing/TextIterator.cpp:
  • history/PageCache.h:
  • html/CanvasRenderingContext2D.h:
  • html/HTMLParser.h:
  • html/HTMLParserQuirks.h:
  • html/PreloadScanner.h:
  • loader/Cache.h:
  • loader/CrossOriginPreflightResultCache.h:
  • loader/FrameLoader.h:
  • loader/ProgressTracker.h:
  • loader/ThreadableLoader.h:
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/archive/ArchiveResourceCollection.h:
  • loader/icon/IconDatabase.h:
  • loader/icon/IconLoader.h:
  • loader/icon/PageURLRecord.h:
  • loader/loader.h:
  • page/ContextMenuController.h:
  • page/EventHandler.h:
  • page/FrameTree.h:
  • page/Page.h:
  • page/PageGroup.h:
  • page/PageGroupLoadDeferrer.h:
  • page/mac/EventHandlerMac.mm:
  • platform/AutodrainedPool.h:
  • platform/ContextMenu.h:
  • platform/EventLoop.h:
  • platform/HostWindow.h:
  • platform/Pasteboard.h:
  • platform/PurgeableBuffer.h:
  • platform/RunLoopTimer.h:
  • platform/ThreadGlobalData.h:
  • platform/ThreadTimers.h:
  • platform/Timer.h:
  • platform/TreeShared.h:
  • platform/graphics/FontData.h:
  • platform/graphics/GlyphWidthMap.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/skia/GraphicsContextPlatformPrivate.h:
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/win/QTMovieWin.cpp:
  • platform/mac/LocalCurrentGraphicsContext.h:
  • platform/network/FormDataBuilder.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/text/StringBuffer.h:
  • platform/text/TextCodec.h:
  • platform/win/WindowMessageBroadcaster.h:
  • rendering/CounterNode.h:
  • rendering/LayoutState.h:
  • rendering/RenderFrameSet.h:
  • rendering/RenderView.h:
  • rendering/TransformState.h:
  • svg/SVGAnimatedProperty.h:
  • svg/SynchronizableTypeWrapper.h:
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerRunLoop.cpp:
  • xml/XPathExpressionNode.h:
  • xml/XPathParser.h:
  • xml/XPathPredicate.h:
  • xml/XPathStep.h:

WebKit/gtk:

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225

Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).

  • webkit/webkitdownload.cpp:

WebKit/win:

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225

Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).

  • COMEnumVariant.h:
  • WebDatabaseManager.cpp:
  • WebInspector.h:
  • WebLocalizableStrings.cpp:
22:04 Changeset [45890] by darin@chromium.org
  • 3 edits
    2 adds in trunk

2009-07-14 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

Fails to save document state when navigating away from a page with a
reference fragment.
https://bugs.webkit.org/show_bug.cgi?id=27281

Test: fast/history/saves-state-after-fragment-nav.html

  • history/HistoryItem.cpp: (WebCore::HistoryItem::isCurrentDocument): Use equalIgnoringRef to compare URLs.
20:43 Changeset [45889] by bfulgham@webkit.org
  • 5 edits in trunk/WebCore

2009-07-14 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Sam Weinig.

Inspector: Remove Unintended Global Variables
https://bugs.webkit.org/show_bug.cgi?id=27203

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled):
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):
  • inspector/front-end/inspector.js: (WebInspector.animateStyle):
19:03 Changeset [45888] by pkasting@chromium.org
  • 19 edits
    5 adds in trunk

WebCore:

2009-07-14 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=19562
Added build stuff and stub for the ValidityState class, part of HTML5
section Forms:
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#validitystate

Test: fast/forms/ValidityState-001.html

  • DerivedSources.cpp: Inclusion of ValidityState files
  • DerivedSources.make: ditto
  • GNUmakefile.am: ditto
  • WebCore.gypi: ditto
  • WebCore.pro: ditto
  • WebCore.vcproj/WebCore.vcproj: ditto
  • WebCore.xcodeproj/project.pbxproj: ditto
  • WebCoreSources.bkl: ditto
  • html/HTMLButtonElement.idl: validity attribute
  • html/HTMLFieldSetElement.idl: ditto
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::validity): ValidityState getter
  • html/HTMLFormControlElement.h: ditto
  • html/HTMLInputElement.idl: validity attribute
  • html/HTMLSelectElement.idl: ditto
  • html/HTMLTextAreaElement.idl: ditto
  • html/ValidityState.cpp: Added. (WebCore::ValidityState::ValidityState): (WebCore::ValidityState::valid): validation flag
  • html/ValidityState.h: Added. (WebCore::ValidityState::create): validation flag (WebCore::ValidityState::control): ditto (WebCore::ValidityState::valueMissing): ditto (WebCore::ValidityState::typeMismatch): ditto (WebCore::ValidityState::patternMismatch): ditto (WebCore::ValidityState::tooLong): ditto (WebCore::ValidityState::rangeUnderflow): ditto (WebCore::ValidityState::rangeOverflow): ditto (WebCore::ValidityState::stepMismatch): ditto (WebCore::ValidityState::customError): ditto
  • html/ValidityState.idl: Added.

LayoutTests:

2009-07-14 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=19562
Minimal test case for ValidityState; more tests are going to be added
along with specific validation routines.

  • fast/dom/domListEnumeration-expected.txt: increased expected value of 1 to match the new "validity" attribute
  • fast/dom/resources/domListEnumeration.js: ditto
  • fast/forms/ValidityState-001-expected.txt: Added.
  • fast/forms/ValidityState-001.html: Added.
18:11 Changeset [45887] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change ParserArenaRefCounted's superclass to RefCountedCustomAllocated
https://bugs.webkit.org/show_bug.cgi?id=27249

ParserArenaDeletable customizes operator new, to avoid double inheritance
ParserArenaDeletable's superclass has been changed to RefCountedCustomAllocated.

  • parser/Nodes.h:
18:02 Changeset [45886] by jparent@chromium.org
  • 6 edits
    2 adds in trunk

WebCore:

2009-07-14 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

Outdenting a line inside a blockquote tag does nothing
https://bugs.webkit.org/show_bug.cgi?id=25316

The bug was caused by the code checking whether the blockquote is created by WebKit or not.
We simply remove this code to be consistent with Firefox and Internet Explorer.
Also, enclosingBlockFlow == enclosingNode in outdentParagraph isn't a sufficient condition to insert
the placeholder before the enclosingNode because there could be contents before the current paragraph.
Instead, we should split the enclosingNode (which is a blockquote) at the starting position of outdentation.
It turned out that this solves the bug 25315 also: https://bugs.webkit.org/show_bug.cgi?id=25315

Test: editing/execCommand/outdent-regular-blockquote.html

  • editing/IndentOutdentCommand.cpp: (WebCore::isIndentBlockquote): no longer checks whether a blockquote is created by WebKit or not. (WebCore::IndentOutdentCommand::outdentParagraph): takes care of the case enclosingBlockFlow == enclosingNode

LayoutTests:

2009-07-14 Ryosuke Niwa <rniwa@google.com>

Reviewed by Eric Seidel.

Outdenting a line inside a blockquote tag does nothing
https://bugs.webkit.org/show_bug.cgi?id=25315
https://bugs.webkit.org/show_bug.cgi?id=25316

The expected result for /editing/execCommand/outdent-selection-expected.html
was rebaselined since the original expected result was wrong (Bug 25315).
Namely, "ipsum" moved to the same paragraph as "more Lorem!"
("ipsum" was in the blockblock immediately below "more Lorem!")
and "Dolor" was moved above the list items "Foo", "Bar", and "Baz".

  • editing/execCommand/outdent-regular-blockquote-expected.txt: Added.
  • editing/execCommand/outdent-regular-blockquote.html: Added.
  • platform/mac/editing/execCommand/outdent-selection-expected.checksum:
  • platform/mac/editing/execCommand/outdent-selection-expected.png:
  • platform/mac/editing/execCommand/outdent-selection-expected.txt:
17:47 Changeset [45885] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Add RefCountedCustomAllocated to RefCounted.h
https://bugs.webkit.org/show_bug.cgi?id=27232

Some class which are inherited from RefCounted customize
operator new, but RefCounted is inherited from Noncopyable
which will be inherited from FastAllocBase. To avoid
conflicts Noncopyable inheriting was moved down to RefCounted
and to avoid double inheritance this class has been added.

  • wtf/RefCounted.h: (WTF::RefCountedCustomAllocated::deref): (WTF::RefCountedCustomAllocated::~RefCountedCustomAllocated):
17:10 Changeset [45884] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-14 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Fix isolated world wrappers for Node prototypes
https://bugs.webkit.org/show_bug.cgi?id=27277

This change does two things:

1) We bypass the wrapper cache in the isolated world. This is because

the wrapper template cache has prototypes that lead to the main
world. We can add a template cache for the isolated world if
performance warrants.

2) We introduce a smarter way to grab the wrapper context for a frame

that is aware that proxy <-> context do not stand in one-to-one
correspondence. This generalizes our solution for the node wrapper
case to prototypes.

The net result is that Node wrappers get the right prototypes. As
before, tests to follow.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setHiddenWindowReference): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object): (WebCore::V8DOMWrapper::getWrapperContext):
  • bindings/v8/V8DOMWrapper.h:
17:05 Changeset [45883] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Add NoncopyableCustomAllocated to Noncopyable.h.
https://bugs.webkit.org/show_bug.cgi?id=27228


Some classes which inherited from Noncopyable overrides operator new
since Noncopyable'll be inherited from FastAllocBase, Noncopyable.h
needs to be extended with this new class to support the overriding.

  • wtf/Noncopyable.h: (WTFNoncopyable::NoncopyableCustomAllocated::NoncopyableCustomAllocated): (WTFNoncopyable::NoncopyableCustomAllocated::~NoncopyableCustomAllocated):
16:36 Changeset [45882] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-14 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Fix isolated world wrappers for Nodes
https://bugs.webkit.org/show_bug.cgi?id=27271

Previously, we keepy a pointer to the DOMMap on V8Proxy, but this
caused us to miss the branch in V8DOMMap.cpp for isolated worlds.

I have tests, but I can't land them until I get this feature under
control.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertNodeToV8Object):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::V8Proxy):
16:16 Changeset [45881] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's IdentifierTable class
https://bugs.webkit.org/show_bug.cgi?id=27260

Inherits IdentifierTable class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Identifier.cpp:70.

  • runtime/Identifier.cpp:
16:09 Changeset [45880] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-14 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Fix isolated world crash on getting window.location
https://bugs.webkit.org/show_bug.cgi?id=27268

I have a test for this locally, but it requires a compile-time hack to
run. Once I get the feature's stability under control, we can turn the
feature on and add the tests.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setHiddenWindowReference):
  • bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::context):
16:02 Changeset [45879] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-14 Brent Fulgham <bfulgham@webkit.org>

Correct failing tests after r45875. The original patch did not
test the m_player member for null, causing crashes. This will
happen fairly frequently in real use. Was this original patch
ever tested?
https://bugs.webkit.org/show_bug.cgi?id=27246

Test via existing media tests.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::supportsFullscreen): Check for null pointer. (WebCore::HTMLMediaElement::supportsSave): Check for null pointer.
15:50 Changeset [45878] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-14 Avi Drissman <avi@chromium.org>

Reviewed by Darin Fisher.

Explicitly mark the HTML generated for the Mac as being UTF-8 encoded.
The Windows clipboard format is explicitly documented as being UTF-8,
and all Linux apps assume UTF-8. On the Mac, though, unless otherwise
indicated, Windows-1252 is assumed, which is wrong.

Bug: https://bugs.webkit.org/show_bug.cgi?id=27262

No new tests.

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeRange):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection):
15:43 Changeset [45877] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's Profiler class
https://bugs.webkit.org/show_bug.cgi?id=27253

Inherits Profiler class from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/profiler/Profiler.cpp:56.

  • profiler/Profiler.h:
15:35 Changeset [45876] by japhet@chromium.org
  • 3 edits
    2 adds in trunk/WebCore

2009-07-14 Albert J. Wong <ajwong@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream V8NPObject.h and V8NPObject.cpp.
https://bugs.webkit.org/show_bug.cgi?id=27103

This just upstreams the files from the chromium code base. Only
minor changes to formatting and similar were done, so no testing
is required because nothing really changed. Code verified to compile.

15:20 Changeset [45875] by bfulgham@webkit.org
  • 8 edits in trunk/WebCore

2009-07-14 Albert J. Wong <ajwong@chromium.org>

Reviewed by Darin Adler.

Add HTMLMediaElement::supportSave() and a
HitTestResult::absoluteMediaURL() functions
https://bugs.webkit.org/show_bug.cgi?id=27246

Added an implementation of supportsSave() into HTMLMediaElement
that delegates to MediaPlayerPrivateImpl so that the media engine
is able to signal whether or not a media source supports saving.

Also added a function to HitTestResult that allows for retrieval
of the currentSrc associated with the "hit" media element.


These functions are just pipeing with no visible UI change so there
are no related layout test changes.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::supportsFullscreen): (WebCore::HTMLMediaElement::supportsSave):
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::supportsSave):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsFullscreen): (WebCore::MediaPlayerPrivateInterface::supportsSave):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::altDisplayString): (WebCore::HitTestResult::absoluteMediaURL):
  • rendering/HitTestResult.h:
15:00 Changeset [45874] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-07-14 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

[V8] Implement Reflect and ReflectURL attribute support.
https://bugs.webkit.org/show_bug.cgi?id=27273

  • bindings/scripts/CodeGeneratorV8.pm: Added support for Reflect and ReflectURL attributes.
14:28 Changeset [45873] by bfulgham@webkit.org
  • 8 edits in trunk/WebCore

2009-07-14 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27266
Add hasCurrentPoint() to WebCore::Path.
This fixes Skia-based Chromium regression caused by the fix for
https://bugs.webkit.org/show_bug.cgi?id=27187.
For Skia, the new method always returns 'true', pending actual implementation.
This means Chromium still will differ from Gecko behavior, but at least its Canvas
will not be completely broken.

Existing Canvas Layout Tests should pass in Chromium after this change.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::lineTo): insteand of Path::isEmpty() test for hasCurrentPoint(). (WebCore::CanvasRenderingContext2D::quadraticCurveTo): ditto. (WebCore::CanvasRenderingContext2D::bezierCurveTo): ditto.
  • platform/graphics/Path.h:
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::hasCurrentPoint):
  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::isEmpty): (WebCore::Path::hasCurrentPoint):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::hasCurrentPoint):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::hasCurrentPoint):
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::hasCurrentPoint): All these files add a Path::hasCurrentPoint() for various platforms.
14:15 Changeset [45872] by japhet@chromium.org
  • 2 edits
    2 adds in trunk/WebCore

2009-07-14 Nate Chapin <japhet@chromium.org>

Reviewed by Sam Weinig.

Upstream RGBColor from src.chromium.org.

https://bugs.webkit.org/show_bug.cgi?id=27133

14:05 Changeset [45871] by mpcomplete@chromium.org
  • 4 edits in trunk/WebCore

2009-07-10 Matt Perry <mpcomplete@chromium.org>

Reviewed by Darin Fisher.

[V8] Rename the didCreate/DestroyScriptContext calls to make it
clear that that those refer to the frame's contxt. Add another
similar call for when creating contexts via evaluateInNewContext.
https://bugs.webkit.org/show_bug.cgi?id=27104

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::disposeContextHandles): (WebCore::V8Proxy::initContextIfNeeded):
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didCreateScriptContextForFrame): (WebCore::EmptyFrameLoaderClient::didDestroyScriptContextForFrame): (WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):
  • loader/FrameLoaderClient.h:
13:45 Changeset [45870] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebKit/mac

Merge r45834.

13:45 Changeset [45869] by mrowe@apple.com
  • 3 edits
    9 adds in branches/safari-4-branch

Merge r45850.

13:45 Changeset [45868] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r45836.

13:45 Changeset [45867] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebCore

Merge r45832.

13:39 Changeset [45866] by bfulgham@webkit.org
  • 18 edits in trunk/WebCore

2009-07-14 Brent Fulgham <bfulgham@webkit.org>

Revert http://trac.webkit.org/changeset/45864 after
breaking of Windows build.

  • storage/LocalStorageTask.cpp:
  • storage/LocalStorageTask.h:
  • storage/Storage.cpp:
  • storage/Storage.h:
  • storage/StorageArea.cpp:
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp:
  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp:
  • storage/StorageAreaSync.h:
  • storage/StorageEvent.cpp:
  • storage/StorageEvent.h: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent):
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:
  • storage/StorageNamespaceImpl.h:
  • storage/StorageSyncManager.cpp:
  • storage/StorageSyncManager.h:
13:21 Changeset [45865] by treat@webkit.org
  • 3 edits
    2 adds in trunk/JavaScriptCore

2009-07-06 George Staikos <george.staikos@torchmobile.com>

Reviewed by Adam Treat.

Authors: George Staikos <george.staikos@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>, Makoto Matsumoto <matumoto@math.keio.ac.jp>, Takuji Nishimura

https://bugs.webkit.org/show_bug.cgi?id=27030
Implement custom RNG for WinCE using Mersenne Twister

  • wtf/RandomNumber.cpp: (WTF::randomNumber):
  • wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
  • wtf/wince/mt19937ar.c: Added. (init_genrand): (init_by_array): (genrand_int32): (genrand_int31): (genrand_real1): (genrand_real2): (genrand_real3): (genrand_res53):
12:36 Changeset [45864] by bfulgham@webkit.org
  • 18 edits in trunk/WebCore

2009-07-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180

DOM Storage had several unnecessary (and probably unintended)
dependencies. This patch replaces many includes of header files with
forward declaration of classes, making some destructors explicit, and
taking some factories out of the header files.

This will allow things like StorageAreaSync to take a StorageAreaImpl*
(as it should) rather than a StorageArea* which previously weren't
possible because the dependencies were such a tangled mess.

  • storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::~LocalStorageTask):
  • storage/LocalStorageTask.h:
  • storage/Storage.cpp: (WebCore::Storage::~Storage):
  • storage/Storage.h:
  • storage/StorageArea.cpp:
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp:
  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::~StorageAreaSync):
  • storage/StorageAreaSync.h:
  • storage/StorageEvent.cpp: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent):
  • storage/StorageEvent.h:
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:
  • storage/StorageNamespaceImpl.h:
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::~StorageSyncManager):
  • storage/StorageSyncManager.h:
10:54 Changeset [45863] by treat@webkit.org
  • 3 edits in trunk/WebCore

2009-07-14 Adam Treat <adam.treat@torchmobile.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=26983

Check to make sure the view is attached to a frame() in the visibleContentsResized()
method as it can be triggered before the view is attached by Frame::createView(...)
setting various values such as setScrollBarModes(...) for example. An ASSERT is
triggered when a view is layout before being attached to a frame().

  • page/FrameView.cpp: (WebCore::FrameView::visibleContentsResized):
  • page/FrameView.h:
09:56 Changeset [45862] by treat@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-14 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Zack Rusin.

https://bugs.webkit.org/show_bug.cgi?id=26983

The default constructed values for QSize and WebCore::IntSize are different. The former
produces an invalid size whereas the latter produces a size of zero. This was causing
a layout to be triggered when constructing a view and an assert to be hit. This patch fixes
the crash by taking care not to cause an unnecessary layout triggered by ScrollView::setFixedL

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
09:29 Changeset [45861] by pfeldman@chromium.org
  • 5 edits in trunk/WebCore

2009-07-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: show last opened panel when invoking inspector.

https://bugs.webkit.org/show_bug.cgi?id=27263

  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::specialPanelForJSName):
  • inspector/InspectorController.h: (WebCore::InspectorController::Setting::Setting):
  • inspector/InspectorController.idl:
  • inspector/front-end/inspector.js: (WebInspector.set currentPanel): (WebInspector.loaded):
09:25 Changeset [45860] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-07-14 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Speed up access to NodeList length.
https://bugs.webkit.org/show_bug.cgi?id=27264

That's a minimal alternation of the code.

  • bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): 1) use AtomicString for comparison, 2) use v8::Integer::New instead of v8::Number::New.
09:16 Changeset [45859] by dglazkov@chromium.org
  • 10 edits in trunk/WebCore

2009-07-14 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Do not do unnecessary conversions from v8::Handle<v8::Value> to
v8::Handle<v8::Object> and accompanying changes.
https://bugs.webkit.org/show_bug.cgi?id=26953

Three things:

1) do not cast from v8::Value to v8::Object if unnecessary---casts are cheap,
but are not free (they check for emptiness of handle);
2) inline conversion from wrapper to node;
3) simplify case to an ASSERT.

This is just a refactoring, so no new tests are needed.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::convertToSVGPODTypeImpl):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::convertDOMWrapperToNative): (WebCore::V8Proxy::convertToNativeObject): (WebCore::V8Proxy::convertToNativeEvent):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toCanvasStyle): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8CustomBinding.cpp: (WebCore::V8Custom::GetTargetFrame):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::V8Custom::ClearTimeoutImpl): (WebCore::NAMED_ACCESS_CHECK): (WebCore::INDEXED_ACCESS_CHECK):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
09:06 Changeset [45858] by darin@apple.com
  • 4 edits
    1 copy
    1 add in trunk

WebCore:

2009-07-14 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Straight quotes should match fancy quotes in in-page search
https://bugs.webkit.org/show_bug.cgi?id=27217

Tests: fast/text/find-quotes.html

  • editing/TextIterator.cpp: (WebCore::foldQuoteMark): Added. (WebCore::foldQuoteMarks): Added. (WebCore::SearchBuffer::SearchBuffer): Call foldQuoteMarks on the target string. (WebCore::SearchBuffer::append): Call foldQuoteMarks on characters as they are added to the search buffer.
  • platform/text/CharacterNames.h: Added more quotation mark character names. Sorted character names with the sort tool.

LayoutTests:

2009-07-14 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Straight quotes should match fancy quotes in in-page search
https://bugs.webkit.org/show_bug.cgi?id=27217

  • fast/text/find-quotes-expected.txt: Added.
  • fast/text/find-quotes.html: Copied from LayoutTests/fast/text/find-case-folding.html.
08:42 Changeset [45857] by levin@chromium.org
  • 1 edit
    2 adds in trunk/WebKitTools

2009-07-14 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Modifies cpplint (http://google-styleguide.googlecode.com/svn/trunk/cpplint/)
based on WebKit's style guide.

  • Scripts/cpplint.py: Added.
  • Scripts/cpplint_unittest.py: Added.
06:04 Changeset [45856] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] DumpRenderTree no longer builds with Qt4.4
https://bugs.webkit.org/show_bug.cgi?id=27257

Flag Qt 4.5 dependency to allow building with Qt 4.4.

  • DumpRenderTree/qt/main.cpp: (main):

07/13/09:

23:06 BuildingCairoOnWindows edited by bfulgham@webkit.org
(diff)
23:05 BuildingCairoOnWindows edited by bfulgham@webkit.org
Remove instruction to include GIFLIB, as this is no longer necessary. (diff)
23:04 BuildingCairoOnWindows edited by bfulgham@webkit.org
Removed instructions to edit config.h, as this is no longer necessary! (diff)
22:35 Changeset [45855] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-07-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: handle debugger shortcuts while on source frame or on
script file selector.

https://bugs.webkit.org/show_bug.cgi?id=27224

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
21:00 Changeset [45854] by weinig@apple.com
  • 3 edits in trunk/WebCore

2009-07-13 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Use standard HashCountedSet instead of a hand rolled one
in HTMLDocument.

  • html/HTMLDocument.cpp: (WebCore::addItemToMap): (WebCore::removeItemFromMap):
  • html/HTMLDocument.h:
20:32 WebKit Team edited by tonikitoo@gmail.com
added indt folks (diff)
19:44 Changeset [45853] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

2009-07-13 Brady Eidson <beidson@apple.com>

Fix Leopard regression I just introduced.

  • platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
19:01 Changeset [45852] by beidson@apple.com
  • 4 edits
    3 copies
    1 add in trunk/LayoutTests

2009-07-13 Brady Eidson <beidson@apple.com>

Rubberstamped by Mark Rowe.

Add SnowLeopard specific results for differing MIME types that are (mostly) progressions.

  • platform/mac-leopard/platform/mac/fast/loader: Added.
  • platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-2-expected.txt.
  • platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-3-expected.txt.
  • platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-expected.txt.
  • platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes-3-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes-expected.txt:
18:04 Changeset [45851] by darin@apple.com
  • 12 edits
    5 adds in trunk

WebCore:

2009-07-13 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler and Maciej Stachowiak.

Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262

This adds support for the HTML5 draggable attribute and its DOM binding. It maps the draggable property
to the CSS properties -webkit-user-drag and -webkit-user-select respectively.

Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-draggable-attribute

Test: fast/html/draggable.html

  • css/html.css:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::draggable):
  • html/HTMLAnchorElement.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::draggable): (WebCore::HTMLElement::setDraggable):
  • html/HTMLElement.h:
  • html/HTMLElement.idl:
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::draggable):
  • html/HTMLImageElement.h:

LayoutTests:

2009-07-13 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler and Maciej Stachowiak.

Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262

This adds support for the HTML5 draggable attribute and its DOM binding. It maps the draggable property
to the CSS properties -webkit-user-drag and -webkit-user-select respectively.

Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-draggable-attribute

  • fast/html/draggable-expected.txt: Added.
  • fast/html/draggable.html: Added.
  • fast/html/resources: Added.
  • fast/html/resources/images: Added.
  • fast/html/resources/images/lime.png: Added.
  • fast/dom/resources/domListEnumeration.js: Updated.
  • fast/dom/domListEnumeration-expected.txt: Updated.
17:47 Changeset [45850] by simon.fraser@apple.com
  • 3 edits
    9 adds in trunk

2009-07-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Image rendered as layer contents looks different from image rendered via CG.
<rdar://problem/7048830>

Fix a visible color profile difference between between images rendered via Core Graphics
and those rendered via a compositing layer, by assigning the GenericRGB profile to
untagged images (which come through as having the DeviceRGB profile) when they are set
as layer contents.

Test: compositing/color-matching/image-color-matching.html

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToImage):
17:20 Changeset [45849] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-07-13 Darin Adler <darin@apple.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=27220
Assertion failure in createSearcher() (usearch_open() status is U_USING_DEFAULT_WARNING)

  • editing/TextIterator.cpp: (WebCore::createSearcher): Add U_USING_DEFAULT_WARNING as a possible status code in the assertion. Affects only the assertion.
17:07 Changeset [45848] by ap@webkit.org
  • 6 edits
    4 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26925
<rdar://problem/7027850> URL Fragment Breaks Application Cache Loads

Test: http/tests/appcache/main-resource-hash.html

  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::resourceForURL): (WebCore::ApplicationCache::resourceForRequest):
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::cacheForMainRequest): (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didFail): (WebCore::ApplicationCacheGroup::addEntry): Remove URL fragment at appcache code borders.
  • loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::create):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::findOrCreateCacheGroup): (WebCore::ApplicationCacheStorage::cacheGroupForURL): (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Assert that there is no URL fragment in URL at key points in appcache code.
17:02 Changeset [45847] by darin@apple.com
  • 3 edits
    1 copy
    1 add in trunk

WebCore:

2009-07-13 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27166
rdar://problem/7015857
Find for strings composed entirely of spaces doesn't work

Test: fast/text/find-spaces.html

  • editing/TextIterator.cpp: (WebCore::findPlainText): Removed unneeded special case. The empty string case already works correctly.

LayoutTests:

2009-07-13 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27166
rdar://problem/7015857
Find for strings composed entirely of spaces doesn't work

  • fast/text/find-spaces-expected.txt: Added.
  • fast/text/find-spaces.html: Copied from LayoutTests/fast/text/find-case-folding.html.
16:42 Changeset [45846] by bfulgham@webkit.org
  • 3 edits in trunk/WebKit/win

2009-07-13 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Refactor WebFrame::spoolPages for easier sharing with Windows Cairo.
https://bugs.webkit.org/show_bug.cgi?id=27240.

  • WebFrame.cpp: (WebFrame::printHeader): New shared method to print the header. (WebFrame::printFooter): New shared method to print the footer. (WebFrame::spoolPage): New conditionally-compiled method to print a page. (WebFrame::spoolPages): Revised to call the platform-specific spoolPage for each page.
  • WebFrame.h: Add new method prototypes.
16:23 Changeset [45845] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-07-13 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Remove NPPVpluginPrivateModeBool, it was removed from the spec.


  • bridge/npapi.h:
16:08 Changeset [45844] by feng@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Feng Qian <feng@chromium.org>

Reviewed by Dimitri Glazkov.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27237

Make V8DOMMap.h compiling with gcc option -Werror=non=virtual-dtor.

  • bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::WeakReferenceMap): (WebCore::WeakReferenceMap::~WeakReferenceMap):
16:03 Changeset [45843] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

Remove an accidental add of bidi.(cpp|h) to WebCore.gypi.

  • WebCore.gypi: Removed bidi.cpp and bidi.h
15:46 Changeset [45842] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

Update WebCore.gyp in preparation to hooking it up.

  • WebCore.gypi: Added files that were mid-stream while switching over.
15:41 Changeset [45841] by mrowe@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add Leopard-specific results for fast/text/international/khmer-selection.html.

  • platform/mac-leopard/fast/text/international/khmer-selection-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/khmer-selection-expected.txt.
15:08 Changeset [45840] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Dmitry Titov <dimich@chromium.org>

Not reviewed, another small fix for Chromium build.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
15:00 Changeset [45839] by dimich@chromium.org
  • 4 edits in trunk/WebCore

2009-07-13 Dmitry Titov <dimich@chromium.org>

Not reviewed, fix Chromium build bustage.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/v8/V8Proxy.cpp: (WebCore::JavaScriptConsoleMessage::addToPage):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::handleConsoleMessage):
13:45 Changeset [45838] by mrowe@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add a missing layout test result to improve the quality of life of the Mac buildbots.

  • platform/mac/fast/text/international/khmer-selection-expected.txt: Added.
13:32 Changeset [45837] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-07-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein, Adam Roben.

"Unrecognized selector" console log when the Safari 4 Welcome page navigates to Top Sites.
<rdar://problem/6994893

attachRootGraphicsLayer() should not assume that the frameView's documentView
is a WebHTMLView.

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::attachRootGraphicsLayer):
13:16 Changeset [45836] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-07-13 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27234
<rdar://problem/7054356>

Add null page check in HTMLDocument::hasFocus.

Test: fast/dom/HTMLDocument/hasFocus-frameless-crash.html

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::hasFocus): Add page null check. (WebCore::HTMLDocument::createTokenizer): Cleanup page null check.

LayoutTests:

2009-07-13 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Test for https://bugs.webkit.org/show_bug.cgi?id=27234
<rdar://problem/7054356>

  • fast/dom/HTMLDocument/hasFocus-frameless-crash-expected.txt: Added.
  • fast/dom/HTMLDocument/hasFocus-frameless-crash.html: Added.
13:13 Changeset [45835] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Disable continuous spell checking in the inspector
https://bugs.webkit.org/show_bug.cgi?id=27131

  • inspector/front-end/inspector.html: Added spellcheck="false" to the

main-panels and console-prompt containers.

12:38 Changeset [45834] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-07-13 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler and Kevin Decker.

<rdar://problem/7053687> Core Animation plug-ins continue to grow larger and larger when opening new tabs (32 bit-only)

  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView setLayer:]): Add a FIXME.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setLayer:]): Make sure to set the size of the layer before changing the autoresizing mask so it won't grow everytime it's inserted into the layer tree.
12:14 Changeset [45833] by agl@chromium.org
  • 3 edits
    1 add in trunk

2009-07-13 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium Linux: fix assertion when rendering google.com.kh

https://bugs.webkit.org/show_bug.cgi?id=26924

Some shapers (i.e. Khmer) will produce cluster logs which report that
/no/ code points contributed to certain glyphs. Because of this, we
take any code point which contributed to the glyph in question, or any
subsequent glyph. If we run off the end, then we take the last code
point.

Added LayoutTests/fast/text/international/khmar-selection.html

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::offsetForPositionForComplexText):
12:05 Changeset [45832] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

spellcheck="false" is ignored
<rdar://problem/7054177>

  • editing/Editor.cpp: (WebCore::markMisspellingsOrBadGrammar): Moved code to check the

spellcheck attribute from here...

(WebCore::Editor::spellCheckingEnabledInFocusedNode): ...to here.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Bail out

if spell chcking is disabled by the spellcheck attribute.

  • editing/Editor.h:
11:34 Changeset [45831] by bfulgham@webkit.org
  • 9 edits
    1 add in trunk

WebCore:

2009-07-13 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087


  • WebCore.vcproj/WebCore.vcproj: Add new WinCairo.vsprops to Debug_Cairo and Release_Cairo builds.
  • config.h: Check for presence of WIN_CAIRO and select appropriate configuration. Defaults to standard Apple build.

WebKit/win:

2009-07-13 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087

  • WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to Debug_Cairo and Release_Cairo targets.

WebKitLibraries:

2009-07-13 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087


  • win/tools/vsprops/WinCairo.vsprops: Added. Defines the new WIN_CAIRO flag used to drive non-Apple Windows build.

WebKitTools:

2009-07-13 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087

  • DumpRenderTree/config.h: Check for presence of WIN_CAIRO and select appropriate configuration. Defaults to standard Apple build.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Add new WinCairo.vsprops to Debug_Cairo and Release_Cairo targets.
11:15 Changeset [45830] by pkasting@chromium.org
  • 17 edits
    1 move
    5 deletes in trunk

WebCore:

2009-07-13 Peter Kasting <pkasting@google.com>

https://bugs.webkit.org/show_bug.cgi?id=19562
Back out previous patch for this bug (too many problems).

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLButtonElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::form):
  • html/HTMLInputElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/ValidityState.cpp: Removed.
  • html/ValidityState.h: Removed.
  • html/ValidityState.idl: Removed.

LayoutTests:

2009-07-13 Peter Kasting <pkasting@google.com>

https://bugs.webkit.org/show_bug.cgi?id=19562
Back out previous patch for this bug (too many problems).
This also re-enables fast/dom/domListEnumeration.html.

  • fast/dom/domListEnumeration.html: Copied from LayoutTests/fast/dom/domListEnumeration.html-disabled.
  • fast/dom/domListEnumeration.html-disabled: Removed.
  • fast/forms/ValidityState-001-expected.txt: Removed.
  • fast/forms/ValidityState-001.html: Removed.
11:11 Changeset [45829] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Add HTMLAllCollection to WebCore.gypi.

https://bugs.webkit.org/show_bug.cgi?id=27223

10:08 Changeset [45828] by bolsinga@apple.com
  • 2 edits in trunk/WebKit/mac

2009-07-13 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

Correct these delegate methods' declarations by adding parameter names.

  • WebView/WebUIDelegatePrivate.h:
09:44 Changeset [45827] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Late NEWS file for 1.1.11.

  • NEWS:
09:40 Changeset [45826] by dglazkov@chromium.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-07-13 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

[V8] Add a missing check for constructor call in WebKitCSSMatrixConstructor.
https://bugs.webkit.org/show_bug.cgi?id=27218

Test: fast/css/matrix-as-function-crash.html

  • bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Added a check for constructor call.

LayoutTests:

2009-07-13 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

Make sure that calling WebKitCSSMatrix as function does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=27218

  • fast/css/matrix-as-function-crash-expected.txt: Added.
  • fast/css/matrix-as-function-crash.html: Added.
08:53 Changeset [45825] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.11

Tagging 1.1.11.

08:29 Changeset [45824] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Changes to the doc control files for 1.1.11.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
08:23 Changeset [45823] by kov@webkit.org
  • 2 edits in trunk

2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed build fix. Require the correct libsoup version now that
it's released.

  • configure.ac:
07:55 Changeset [45822] by hausmann@webkit.org
  • 2 adds in trunk/WebKitTools/DumpRenderTree/qt/TestNetscapePlugin

Added .pro file missing from r45813

07:54 Changeset [45821] by vestbo@webkit.org
  • 2 edits in trunk

2009-07-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Build fix for QtWebKit on Win
https://bugs.webkit.org/show_bug.cgi?id=27205

  • WebKit.pri: Include the major version number in the QtWebKit library file for Win.
07:32 Changeset [45820] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Fix qdoc warnings for QWebPage::shouldInterruptJavaScript() and mention
how to re-implement it.

  • Api/qwebpage.cpp:
07:20 Changeset [45819] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Holger Freyther.

Fix unit test to use the correct assumption that the SoupMessage
will be NULL when WebKitNetworkRequest is created from an URI.

  • tests/testnetworkrequest.c: (test_network_request_create_destroy):
06:58 WebKit Team edited by treat@kde.org
(diff)
06:15 Changeset [45818] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Ariya Hidayat.

Unskip three more fast/js tests that pass with the Qt DRT.

  • platform/qt/Skipped:
06:04 Changeset [45817] by hausmann@webkit.org
  • 3 edits
    1 delete in trunk

WebKitTools:

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Always run the Qt DRT with the raster graphicssystem on X11, for
increased stability in the image based tests, in particular canvas.

  • DumpRenderTree/qt/main.cpp: (main):

LayoutTests:

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Removed Qt DRT specific result for canvas-getImageData as we pass this
test with the raster graphicssystem.

  • platform/qt/fast/canvas/canvas-getImageData-expected.txt: Removed.
05:29 Changeset [45816] by kov@webkit.org
  • 4 edits in trunk

Unreviewed make dist build fix.

05:27 Changeset [45815] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-13 Cédric Luthi <cedric.luthi@gmail.com>

Reviewed by Tor Arne Vestbø.

Fix NPWindow clip rect in PluginViewMac

The rect should be in window-coordinates. This bug can be observed
with Flash 10 here: http://www.permadi.com/tutorial/cursorTracker/

  • plugins/mac/PluginViewMac.cpp:
03:55 Changeset [45814] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Fix crash with plugins when the plugin stream is cancelled.

Similar to r26667 handle the case where didReceiveResponse on the
plugin view results in failure to set up the stream and
setMainDocumentError being called instead. This will set the
m_pluginView back to 0 and we need check for it before calling
didReceiveData.

This was triggered by consecutive execution of
LayoutTests/plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
followed by LayoutTests/scrollbars/scrollbar-crash-on-refresh.html

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::committedLoad):
03:55 Changeset [45813] by hausmann@webkit.org
  • 7 edits in trunk

.:

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Add the test netscape plugin for the Qt DRT to the build.

  • WebKit.pro:

WebKitTools:

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Fix test netscape plugin usage with the Qt DRT.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): Enable plugins in the settings.
  • Scripts/run-webkit-tests: Set the QT_WEBKIT_PLUGIN path to the correct build directory to make Qt DRT find the test netscape plugin.

LayoutTests:

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Enable a bunch of plugin layout tests for the Qt DRT.

  • platform/qt/Skipped:
03:53 Changeset [45812] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Make sure to disable the fixed contents size when resetting the page/view
state between test runs, to avoid side-effects.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open): Call setFixedContentsSize() with an invalid QSize to disable the fixed layout.
03:52 Changeset [45811] by hausmann@webkit.org
  • 4 edits in trunk

WebKitTools:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

When creating new windows, don't forget to connect the new
page's main frame. This ensures that for example the layoutTestController
is also available there.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::createWindow):

LayoutTests:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Removed two more storage tests from the Qt DRT skip list that relied on
layoutTestController to be accessible in newly opened windows.

  • platform/qt/Skipped:
03:50 Changeset [45810] by hausmann@webkit.org
  • 5 edits in trunk

WebKitTools:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Added support for LayoutTestController.setPrivateBrowsingEnabled.

  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setPrivateBrowsingEnabled):
  • DumpRenderTree/qt/jsobjects.h:

LayoutTests:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Removed three tests from the Qt DRT Skip list that rely on
LayoutTestController.setPrivateBrowsingEnabled and pass now.

  • platform/qt/Skipped:
03:49 Changeset [45809] by hausmann@webkit.org
  • 11 edits in trunk

WebKit/qt:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Added QWebDatabase::removeAllDatabases, as a way to delete all
databases from the offline storage path.

Used by the Qt DRT.

  • Api/qwebdatabase.cpp: (QWebDatabase::removeAllDatabases):
  • Api/qwebdatabase.h:

WebKitTools:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Added support for database callbacks, storage quota setting,
and clearing of all databases.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::dumpDatabaseQuota):
  • DumpRenderTree/qt/DumpRenderTree.h:
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setDatabaseQuota): (LayoutTestController::clearAllDatabases):
  • DumpRenderTree/qt/jsobjects.h: (LayoutTestController::shouldDumpDatabaseCallbacks): (LayoutTestController::dumpDatabaseCallbacks):
  • DumpRenderTree/qt/main.cpp: (main):

LayoutTests:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Enable a bunch of more storage layout tests for the Qt DRT, now that
they pass.

  • platform/qt/Skipped:
03:48 Changeset [45808] by hausmann@webkit.org
  • 4 edits in trunk

WebKitTools:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Setup the path in the Qt DRT for HTML 5 Databases, to enable some of
the storage layout tests.

  • DumpRenderTree/qt/main.cpp: (main):

LayoutTests:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Enable some storage layout tests in the Qt DRT, as the pass now.

  • platform/qt/Skipped:
03:46 Changeset [45807] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Fix Qt implementation of WebCore::directoryName to return the absolute
directory name instead of the base file name.

  • platform/qt/FileSystemQt.cpp: (WebCore::directoryName):
03:45 Changeset [45806] by hausmann@webkit.org
  • 8 edits in trunk

WebKit/qt:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Added loadStarted() and loadFinished() signals to QWebFrame,
to allow load tracking of individual frames, as opposed to
QWebPage's loadStarted/loadFinished signals that are emitted
whenever _any_ child frame loads/finishes.

  • Api/qwebframe.cpp: Document new signals.
  • Api/qwebframe.h: Add new signals.
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::setFrame): Connect new signals.

WebKitTools:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Make the test output more robust by dumping only when the main
frame finishes loading, instead of when _any_ frame finishes.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): Connect to the main frame's loadFinished() signal instead of the page's one.

LayoutTests:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Removed 20 more frame tests from the Qt skip list as they pass now
after making sure we only dump after the main frame's loadFinished
signal.

  • platform/qt/Skipped:
03:40 Changeset [45805] by hausmann@webkit.org
  • 9 edits in trunk

WebKit/qt:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Add hooks for the GCController JavaScript interface needed by the
Qt DRT.

Fixed sort order of includes in qwebframe.cpp.

  • Api/qwebframe.cpp: (qt_drt_javaScriptObjectsCount): (qt_drt_garbageCollector_collect): (qt_drt_garbageCollector_collectOnAlternateThread):

WebKitTools:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Implement the GCController DRT interface in the Qt DRT.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): Allocate the GCController. (WebCore::DumpRenderTree::initJSObjects): Register the interface with the JS engine.
  • DumpRenderTree/qt/DumpRenderTree.h: Declare m_gcController.
  • DumpRenderTree/qt/jsobjects.cpp: Implement GCController. (GCController::GCController): (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
  • DumpRenderTree/qt/jsobjects.h: Declare GCController.

LayoutTests:

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Remove fast/frames/removal-before-attach-crash.html and
fast/dom/StyleSheet/ownerNode-lifetime-2.html from the Qt DRT skip
list, as they pass now with support for the GCController.

  • platform/qt/Skipped:
03:34 Changeset [45804] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Ariya Hidayat.

Fix WebCore::Path::isEmpty() for the Qt port to return true
if there is no element in the path.

QPainterPath::isEmpty() returns also true if there is one single
MoveTo element inside, which makes sense but doesn't patch Webcore's
is-empty definition.

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::isEmpty): Use elementCount() == 0.
03:22 Changeset [45803] by jmalonzo@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-07-13 Reinout van Schouwen <reinouts@gnome.org>

<https://bugs.webkit.org/show_bug.cgi?id=26980> [Gtk] Updated Dutch translation

Rubber-stamped by Jan Alonzo.

  • nl.po: Added.
03:11 Changeset [45802] by jmalonzo@webkit.org
  • 4 edits in trunk

2009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org>

<https://bugs.webkit.org/show_bug.cgi?id=27171> [Gtk]
REGRESSION (r45440): fails at fast/events/frame-programmatic-focus.html

Reviewed by Gustavo Noronha.

Unskip fast/events/frame-programmatic-focus.html

  • platform/gtk/Skipped:

focus-in and focus-out events only get triggered when there's user
interaction, hence setFocused(bool) never gets called when
focusEvent is triggered when running the layout tests. The
solution seems to be to implement grab-focus too so we can call
setFocused(bool) when a widget has focus.

  • webkit/webkitwebview.cpp: (webkit_web_view_grab_focus): (webkit_web_view_focus_in_event): (webkit_web_view_class_init):
02:57 Changeset [45801] by jmalonzo@webkit.org
  • 12 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=26718 [Gtk] Add support for javascript windows for DRT

Reviewed by Gustavo Noronha and Xan Lopez.

Unskip tests that now pass due to support for JS windows in Gtk DRT.

  • platform/gtk/Skipped:

Add API to support opening and closing of JavaScript windows automatically.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
  • webkit/webkitprivate.h:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_real_close_web_view): (webkit_web_view_class_init): (webkit_web_view_update_settings): (webkit_web_view_settings_notify): (webkit_web_view_set_group_name):
  • webkit/webkitwebview.h:

Support running of tests that open and close JS windows automatically.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpFramesAsText): (dumpBackForwardListForAllWebViews): (resetWebViewToConsistentStateBeforeTesting): (dump): (runTest): (webViewClose): (createWebView): (webViewCreate): (main):
  • DumpRenderTree/gtk/DumpRenderTreeGtk.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::windowCount): (LayoutTestController::setPopupBlockingEnabled):
02:47 Changeset [45800] by hausmann@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Oliver Hunt.

Tweak mouseout-dead-subframe.html to be more robust.

The test calls notifyDone() and then dumpAsText(). The latter call has no effect
as notifyDone() performs the dump, but it passes in the mac DRT because the mime-type
of the .html file is detected as text/plain and therefore the text is dumped instead
of the render tree.

Changed the testcase to call dumpAsText() first and then notifyDone(), to make it
pass without relying on the mime type detection.

That also makes the test pass in the Qt DRT.

  • fast/events/mouseout-dead-subframe.html: Swapped notifyDone() and dumpAsText() calls to call the former before the latter.
  • platform/qt/Skipped: Removed skipped test.
02:36 Changeset [45799] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Maciej Stachowiak.

prepare-ChangeLog should decode HTML entities in short description
https://bugs.webkit.org/show_bug.cgi?id=27122

Decode the short description by adding a function which decodes HTML
entities. It can decode &, <, >, ", and ' . They may be sufficient
as the description seems to be encoded by xml_quote in
http://mxr.mozilla.org/bugzilla/source/Bugzilla/Util.pm

  • Scripts/prepare-ChangeLog:
02:31 Changeset [45798] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Albert J. Wong <ajwong@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream fixes to NPV8Object.cpp that make ~30 layout tests pass.
https://bugs.webkit.org/show_bug.cgi?id=27127

There were a number of bugs introduced during the last upstreaming
effort that broke around 30 layout tests. This fixes those bugs.
It also has compile fixes to match the recent cutting apart of
V8Proxy.

  • bindings/v8/NPV8Object.cpp: (freeV8NPObject): (npCreateV8ScriptObject): (NPN_Invoke): (NPN_InvokeDefault): (NPN_EvaluateHelper): (NPN_SetException): (NPN_Construct):
02:31 Changeset [45797] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

Fix memory leak in the V8 binding layer.
https://bugs.webkit.org/show_bug.cgi?id=27163

Reinitializing the context is not necessary when clearing the proxy for navigation
and it will lead us to hold on to an empty context for each frame.

Test for empty context instead of empty global object handle when
updating the document for a context.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::updateDocument):
02:31 Changeset [45796] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 John Gregg <johnnyg@google.com>

Reviewed by David Levin.

Correct the logic to determine if a V8 callback returns a value.
https://bugs.webkit.org/show_bug.cgi?id=27155

  • bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback):
  • Don't crash if result.IsEmpty().
01:58 Changeset [45795] by levin@chromium.org
  • 25 edits
    16 adds in trunk

2009-07-13 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

.:

Added ENABLE(SHARED_WORKERS) flag.

  • configure.ac:

JavaScriptCore:

Added ENABLE(SHARED_WORKERS) flag (off by default).

  • Configurations/FeatureDefines.xcconfig:

WebCore:

Initial IDL definition and bindings for SharedWorkers.

  • Configurations/FeatureDefines.xcconfig: Added new files for SharedWorker support.
  • DerivedSources.make: Added new files for SharedWorker support.
  • GNUmakefile.am: Added new files for SharedWorker support.
  • WebCore.gypi: Added new files for SharedWorker support.
  • WebCore.pro: Added new files for SharedWorker support.
  • WebCore.xcodeproj/project.pbxproj: Added new files for SharedWorker support.
  • bindings/js/JSAbstractWorkerCustom.cpp: Added. (WebCore::JSAbstractWorker::mark): Custom mark handler that marks the event listeners. (WebCore::JSAbstractWorker::addEventListener): (WebCore::JSAbstractWorker::removeEventListener): (WebCore::JSAbstractWorker::toJS): Custom toJS handler which differentiates between various subclasses.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::sharedWorker): SharedWorker constructor (only enabled when SHARED_WORKERS is enabled).
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): (WebCore::toEventTarget): Added support for converting to/from SharedWorkers.
  • bindings/js/JSSharedWorkerConstructor.cpp: Added. (WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor): (WebCore::constructSharedWorker): (WebCore::JSSharedWorkerConstructor::getConstructData):
  • bindings/js/JSSharedWorkerConstructor.h: Added. (WebCore::JSSharedWorkerConstructor::classInfo):
  • bindings/js/JSSharedWorkerCustom.cpp: Added. (WebCore::JSSharedWorker::mark): Custom mark function that marks the internal MessagePort.
  • bindings/v8/DOMObjectsInclude.h: Updated to include new header files.
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp: Added. (WebCore::getEventListener): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): V8 handlers for add/removeEventListener().
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8SharedWorkerCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): Custom constructor for SharedWorker.
  • dom/EventTarget.cpp: (WebCore::EventTarget::toSharedWorker):
  • dom/EventTarget.h:
  • page/DOMWindow.idl:
  • workers/AbstractWorker.cpp: Added. (WebCore::AbstractWorker::AbstractWorker): Common base class for SharedWorker and (soon) Worker. The functions below were copied from Worker.cpp. This is the first step in refactoring Worker to derive from AbstractWorker to enable code sharing. (WebCore::AbstractWorker::~AbstractWorker): (WebCore::AbstractWorker::addEventListener): (WebCore::AbstractWorker::removeEventListener): (WebCore::AbstractWorker::dispatchEvent): (WebCore::AbstractWorker::dispatchLoadErrorEvent): (WebCore::AbstractWorker::dispatchScriptErrorEvent):
  • workers/AbstractWorker.h: Added. Definitions of functionality shared by Worker.h and SharedWorker.h. In a future patch, Worker will derive from AbstractWorker. (WebCore::AbstractWorker::scriptExecutionContext): (WebCore::AbstractWorker::setOnerror): (WebCore::AbstractWorker::onerror): (WebCore::AbstractWorker::eventListeners): (WebCore::AbstractWorker::refEventTarget): (WebCore::AbstractWorker::derefEventTarget):
  • workers/AbstractWorker.idl: Added.
  • workers/SharedWorker.cpp: Added. (WebCore::SharedWorker::SharedWorker): (WebCore::SharedWorker::~SharedWorker):
  • workers/SharedWorker.h: Added. (WebCore::SharedWorker::create): (WebCore::SharedWorker::port): (WebCore::SharedWorker::toSharedWorker):
  • workers/SharedWorker.idl: Added.

WebKit/mac:

Added ENABLE(SHARED_WORKERS) flag (disabled by default).

  • Configurations/FeatureDefines.xcconfig:

WebKitTools:

Added support for --shared-workers (turned off by default)

  • Scripts/build-webkit:

LayoutTests:

Unit tests for new SharedWorker APIs (disabled by default).

  • fast/workers/shared-worker-constructor-expected.txt: Added.
  • fast/workers/shared-worker-constructor.html-disabled: Added.
  • fast/workers/shared-worker-event-listener-expected.txt: Added.
  • fast/workers/shared-worker-event-listener.html-disabled: Added.
01:32 Changeset [45794] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Cleanup - Remove prf install target
https://bugs.webkit.org/show_bug.cgi?id=27191

qtwebkit.prf has been removed; this cleans up the related
install target as well.

  • WebCore.pro: Remove prf install target
01:30 Changeset [45793] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-07 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Maciej Stachoviak.

https://bugs.webkit.org/show_bug.cgi?id=27058

Removed superfluous parenthesis around single expression.
Compilers on Symbian platform fail to properly parse and compile.

01:24 Changeset [45792] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-13 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Maciej Stachoviak.

https://bugs.webkit.org/show_bug.cgi?id=27054

Renamed Translator to HashTranslator

Codewarrior compiler (WINSCW) latest b482 cannot resolve typename
mismatch between template declaration and definition
(HashTranslator / Translator)

  • wtf/HashSet.h:
01:20 Changeset [45791] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-13 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27053

Ambiguity in LabelScope initialization

Codewarrior compiler (WINSCW) latest b482 on Symbian cannot resolve
type of "0" unambiguously. Set expression explicitly to
PassRefPtr<Label>::PassRefPtr()

  • bytecompiler/BytecodeGenerator.cpp
Note: See TracTimeline for information about the timeline view.