Timeline


and

07/21/09:

23:54 Changeset [46217] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Qt build.

  • WebCore.pro: Add RGBColor.cpp to the build, remove JSRGBColor.
23:19 Changeset [46216] by abarth@webkit.org
  • 9 edits
    1 add in trunk/WebCore

2009-07-21 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27494

Fixes an issue that can cause a crash or unexpected behavior when calling
WebCore::ScriptSourceCode::source on a cached script.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/CachedScriptSourceProvider.h: Modified to inherit from WebCore::ScriptSourceCode. (WebCore::CachedScriptSourceProvider::source): (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): Separated out source provider and rewrote to use WebCore::ScriptSourceProvider. (WebCore::ScriptSourceCode::source):
  • bindings/js/ScriptSourceProvider.h: Added. (WebCore::ScriptSourceProvider::ScriptSourceProvider): (WebCore::ScriptSourceProvider::~ScriptSourceProvider):
  • bindings/js/StringSourceProvider.h: Modified to inherit from WebCore::ScriptSourceCode. (WebCore::StringSourceProvider::StringSourceProvider):
22:31 Changeset [46215] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-21 Sam Weinig <sam@webkit.org>

Another attempt to fix the Windows build.

  • WebCore.vcproj/WebCore.vcproj:
22:19 Changeset [46214] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-21 Sam Weinig <sam@webkit.org>

Attempt to fix the Windows build.

  • DerivedSources.cpp:
22:17 Changeset [46213] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-21 Sam Weinig <sam@webkit.org>

Attempt to fix the GTK build

  • GNUmakefile.am:
22:04 Changeset [46212] by weinig@apple.com
  • 4 edits
    1 delete in trunk/WebCore

2009-07-21 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Autogenerate Objective-C binding implementation for RGBColor.

No functionality change.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMRGBColor.mm: Removed.
  • bindings/scripts/CodeGeneratorObjC.pm: Add logic to convert from WebCore::Color to NSColor*.
  • css/RGBColor.idl:
21:27 Changeset [46211] by weinig@apple.com
  • 28 edits
    2 deletes in trunk

WebCore:

2009-07-21 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27242
JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor

Move the JSC and Objective-C bindings onto using the RGBColor object instead
of just an unsigned int. The JSC bindings are now completely autogenerated for
this class. (Also removes the last lut from WebCore).

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSRGBColor.cpp: Removed.
  • bindings/js/JSRGBColor.h: Removed.
  • bindings/objc/DOM.mm: (-[DOMRGBColor _color]):
  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor alpha]): (-[DOMRGBColor color]):
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseColor):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getRGBColorValue):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getRGBA32Value):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • css/RGBColor.cpp: (WebCore::RGBColor::alpha):
  • css/RGBColor.h: (WebCore::RGBColor::color): (WebCore::RGBColor::RGBColor):
  • css/RGBColor.idl:
  • page/DOMWindow.idl:
  • svg/SVGColor.cpp: (WebCore::SVGColor::rgbColor):
  • svg/SVGColor.h:

LayoutTests:

2009-07-21 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Changes for https://bugs.webkit.org/show_bug.cgi?id=27242
JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/wrapper-classes-expected.txt:
  • fast/js/global-constructors-expected.txt:
21:03 Changeset [46210] by barraclough@apple.com
  • 5 edits
    3 adds in trunk

JavaScriptCore:

2009-07-21 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Cache not only the structure of the method, but the
structure of its prototype as well.
https://bugs.webkit.org/show_bug.cgi?id=27077

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock):
  • bytecode/CodeBlock.h: (JSC::MethodCallLinkInfo::MethodCallLinkInfo):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::patchMethodCallProto):

LayoutTests:

2009-07-21 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Gavin Barraclough, RS olliej fix to make the test pass.

Check whether a crash happens after the string
prototype is overwritten twice. The JIT'ed code
may crash if one of its already cached method
called again. Note: This test is not necessary
crash on all systems, because they use different
memory allocators!
https://bugs.webkit.org/show_bug.cgi?id=27077

  • fast/js/method-check-expected.txt: Added.
  • fast/js/method-check.html: Added.
  • fast/js/resources/method-check.js: Added. (func2): (func.String.prototype.a): (func.String.prototype.b): (func):
20:24 Changeset [46209] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

2009-07-21 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Move call linking / repatching down from AbstractMacroAssembler into MacroAssemblerARCH classes.
( https://bugs.webkit.org/show_bug.cgi?id=27527 )

This allows the implementation to be defined per architecture. Specifically this addresses the
fact that x86-64 MacroAssembler implements far calls as a load to register, followed by a call
to register. Patching the call actually requires the pointer load to be patched, rather than
the call to be patched. This is implementation detail specific to MacroAssemblerX86_64, and as
such is best handled there.

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::linkCall): (JSC::MacroAssemblerARM::repatchCall):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::linkCall): (JSC::MacroAssemblerARMv7::repatchCall):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::linkCall): (JSC::MacroAssemblerX86::repatchCall):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::linkCall): (JSC::MacroAssemblerX86_64::repatchCall):
19:42 Changeset [46208] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Correct relative path in the test after moving it.

  • platform/mac/fast/loader/non-html-load-event.html:
19:39 Changeset [46207] by mitz@apple.com
  • 2 edits
    2 moves in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

Move fast/loader/non-html-load-event.html under platform/mac because
non-HTML views exist only on Mac.

  • fast/loader/non-html-load-event-expected.txt: Removed.
  • fast/loader/non-html-load-event.html: Removed.
  • platform/mac/fast/loader/non-html-load-event-expected.txt: Copied from LayoutTests/fast/loader/non-html-load-event-expected.txt.
  • platform/mac/fast/loader/non-html-load-event.html: Copied from LayoutTests/fast/loader/non-html-load-event.html.
  • platform/qt/Skipped:
19:08 Changeset [46206] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

19:07 Changeset [46205] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.7

New tag.

18:39 Changeset [46204] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-21 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos.

Every wtf file includes other wtf files with <> style includes
except this one. Fix the exception.

  • wtf/ByteArray.h:
17:43 Changeset [46203] by jianli@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Implement AbstractWorker::dispatchScriptErrorEvent by generating an ErrorEvent.
https://bugs.webkit.org/show_bug.cgi?id=27515

  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::dispatchScriptErrorEvent):
17:37 Changeset [46202] by barraclough@apple.com
  • 10 edits
    2 adds in trunk/JavaScriptCore

2009-07-21 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Move LinkBuffer/RepatchBuffer out of AbstractMacroAssembler.
( https://bugs.webkit.org/show_bug.cgi?id=27485 )

This change is the first step in a process to move code that should be in
the architecture-specific MacroAssembler classes up out of Assmbler and
AbstractMacroAssembler.


  • assembler/ARMAssembler.h: (JSC::ARMAssembler::linkPointer):
    • rename patchPointer to bring it in line with the current link/repatch naming scheme


  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::linkCall): (JSC::ARMv7Assembler::linkPointer): (JSC::ARMv7Assembler::relinkCall): (JSC::ARMv7Assembler::repatchInt32): (JSC::ARMv7Assembler::repatchPointer): (JSC::ARMv7Assembler::setInt32): (JSC::ARMv7Assembler::setPointer):
    • rename patchPointer to bring it in line with the current link/repatch naming scheme
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::linkJump): (JSC::AbstractMacroAssembler::linkCall): (JSC::AbstractMacroAssembler::linkPointer): (JSC::AbstractMacroAssembler::getLinkerAddress): (JSC::AbstractMacroAssembler::getLinkerCallReturnOffset): (JSC::AbstractMacroAssembler::repatchJump): (JSC::AbstractMacroAssembler::repatchCall): (JSC::AbstractMacroAssembler::repatchNearCall): (JSC::AbstractMacroAssembler::repatchInt32): (JSC::AbstractMacroAssembler::repatchPointer): (JSC::AbstractMacroAssembler::repatchLoadPtrToLEA):
    • remove the LinkBuffer/RepatchBuffer classes, but leave a set of (private, friended) methods to interface to the Assembler
  • assembler/LinkBuffer.h: Added. (JSC::LinkBuffer::LinkBuffer): (JSC::LinkBuffer::~LinkBuffer): (JSC::LinkBuffer::link): (JSC::LinkBuffer::patch): (JSC::LinkBuffer::locationOf): (JSC::LinkBuffer::locationOfNearCall): (JSC::LinkBuffer::returnAddressOffset): (JSC::LinkBuffer::finalizeCode): (JSC::LinkBuffer::finalizeCodeAddendum): (JSC::LinkBuffer::code): (JSC::LinkBuffer::performFinalization):
    • new file containing the LinkBuffer class, previously a member of AbstractMacroAssembler
  • assembler/RepatchBuffer.h: Added. (JSC::RepatchBuffer::RepatchBuffer): (JSC::RepatchBuffer::relink): (JSC::RepatchBuffer::repatch): (JSC::RepatchBuffer::repatchLoadPtrToLEA): (JSC::RepatchBuffer::relinkCallerToTrampoline): (JSC::RepatchBuffer::relinkCallerToFunction): (JSC::RepatchBuffer::relinkNearCallerToTrampoline):
    • new file containing the RepatchBuffer class, previously a member of AbstractMacroAssembler
  • assembler/X86Assembler.h: (JSC::X86Assembler::linkJump): (JSC::X86Assembler::linkCall): (JSC::X86Assembler::linkPointerForCall): (JSC::X86Assembler::linkPointer): (JSC::X86Assembler::relinkJump): (JSC::X86Assembler::relinkCall): (JSC::X86Assembler::repatchInt32): (JSC::X86Assembler::repatchPointer): (JSC::X86Assembler::setPointer): (JSC::X86Assembler::setInt32): (JSC::X86Assembler::setRel32):
    • rename patchPointer to bring it in line with the current link/repatch naming scheme
  • jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress):
    • include new headers
    • remove MacroAssembler:: specification from RepatchBuffer usage
  • jit/JITPropertyAccess.cpp:
  • yarr/RegexJIT.cpp:
    • include new headers
17:08 Changeset [46201] by eric@webkit.org
  • 7 edits
    1 add in trunk/WebCore

2009-07-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move m_context out of generator into a superclass
https://bugs.webkit.org/show_bug.cgi?id=27521

Mostly this is removing code from CodeGeneratorJS
and instead using a DOMObjectWithSVGContext superclass in JSDOMBinding.h.

DOMObjectWithSVGContext.h is its own file so that WebKit doesn't need to
know about SVGElement.h (WebKit includes JSDOMBinding.h for some reason).

I also removed context pointer from SVGZoomEvent since it was never used.

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/DOMObjectWithSVGContext.h: Added. (WebCore::DOMObjectWithSVGContext::context): (WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/scripts/CodeGeneratorJS.pm:
16:08 Changeset [46200] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (r46142): editing/execCommand/19087.html & editing/execCommand/19653-1.html fail in Windows build
https://bugs.webkit.org/show_bug.cgi?id=27480

Because m_anchorType : 2 is treated as a signed integer by cl.exe, anchorType() wasn't returning the correct value.
We made m_anchorType unsigned so that anchorType() returns the correct value.

  • dom/Position.h: (WebCore::Position::anchorType): statically cast to AnchorType
15:57 Changeset [46199] by jianli@chromium.org
  • 3 edits in trunk/WebCore

2009-07-21 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

[V8] Add V8 bindings for onerror in WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=27518

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
15:54 Changeset [46198] by jianli@chromium.org
  • 3 edits in trunk/WebCore

2009-07-21 Jian Li <jianli@chromium.org>

Fix the incorrect patch being landed for bug 27516 that has already been reviewed.
https://bugs.webkit.org/show_bug.cgi?id=27516

  • workers/WorkerContext.h: (WebCore::WorkerContext::setOnerror): (WebCore::WorkerContext::onerror):
  • workers/WorkerContext.idl:
15:44 Changeset [46197] by jianli@chromium.org
  • 4 edits in trunk/WebCore

2009-07-21 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Add onerror to WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=27516

  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark):
  • workers/WorkerContext.h: (WebCore::WorkerContext::setOnerror): (WebCore::WorkerContext::onerror):
  • workers/WorkerContext.idl:
15:42 Changeset [46196] by treat@webkit.org
  • 1 edit
    8 adds in trunk/WebCore

2009-07-21 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=27509
Add font-related files for the WinCE port.

Written by Yong Li <yong.li@torchmobile.com>

  • platform/graphics/wince/FontCacheWince.cpp: Added.
  • platform/graphics/wince/FontCustomPlatformData.cpp: Added.
  • platform/graphics/wince/FontCustomPlatformData.h: Added.
  • platform/graphics/wince/FontPlatformData.cpp: Added.
  • platform/graphics/wince/FontPlatformData.h: Added.
  • platform/graphics/wince/FontWince.cpp: Added.
  • platform/graphics/wince/GlyphPageTreeNodeWince.cpp: Added.
  • platform/graphics/wince/SimpleFontDataWince.cpp: Added.
14:11 Changeset [46195] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Fix the Windows build, and update the comment on top now that wx uses WebCorePrefix.h too.

13:55 Changeset [46194] by kevino@webkit.org
  • 2 edits in trunk/WebCore

WebCorePrefix.h build fixes for non-Mac and wx / CURL builds.

13:52 Changeset [46193] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. Missing header added.

13:45 Changeset [46192] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-21 Adam Treat <adam.treat@torchmobile.com>

Reviewed by David Levin.

We can't match implementation file and primary header exactly
since we have so many files in WebKit where the port suffix
is appended to the filename.

Example: FooQt.cpp and the primary header is Foo.h.

  • Scripts/modules/cpplint.py:
13:35 Changeset [46191] by eric@webkit.org
  • 16 edits in trunk/WebCore

2009-07-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

All DOMConstructorObjects should hold a pointer to the JSDOMGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=27478

This is just moving code.
I've added two new classes: DOMObjectWithGlobalPointer and DOMConstructorWithDocument.

DOMObjectWithGlobalPointer is a new baseclass for DOMConstructorObject.
(It's a baseclass because eventually all DOMObjects will have a global pointer, but
I'll be moving them onto DOMObjectWithGlobalPointer in stages.)

DOMConstructorWithDocument is a new baseclass for the 3 constructor objects
which require a backpointer to the Document to function. I made this a subclass of
DOMConstructorObject to make clear that most constructors can hold no-such assumptions
about having a back-pointer to the Document (since many constructors can be used from Workers).

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::globalObject): (WebCore::DOMObjectWithGlobalPointer::scriptExecutionContext): (WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer): (WebCore::DOMObjectWithGlobalPointer::mark): (WebCore::DOMConstructorObject::DOMConstructorObject): (WebCore::DOMConstructorWithDocument::document): (WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
  • bindings/js/JSMessageChannelConstructor.h:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSOptionConstructor.h:
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
  • bindings/js/JSWebKitPointConstructor.cpp: (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::JSWorkerConstructor::JSWorkerConstructor):
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  • bindings/js/JSXMLHttpRequestConstructor.h:
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
13:15 Changeset [46190] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Revert r46128.

13:06 Changeset [46189] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by David Levin.

Add checks for switch statement indentation to cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27508

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
12:43 Changeset [46188] by kenneth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Adam Treat.

Feature request: cpplint should check for braces - rule 2
https://bugs.webkit.org/show_bug.cgi?id=27497

Add the requested feature: Make sure { is on the same line
as the foreach "keyword".

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
12:18 Changeset [46187] by levin@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-07-21 Robert Agoston <Agoston.Robert@stud.u-szeged.hu>

Reviewed by David Levin.

Fixed #undef typo.
https://bugs.webkit.org/show_bug.cgi?id=27506

  • bytecode/Opcode.h:
12:18 Changeset [46186] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 James Hawkins <jhawkins@google.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=27453
Initialize isInt when creating a CSSParserValue for a function.

No change in behavior, so no tests.

  • css/CSSFunctionValue.cpp: (WebCore::CSSFunctionValue::parserValue):
12:18 Changeset [46185] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-20 Jens Alfke <snej@google.com>

Reviewed by David Levin.

Bug 27448: [Chromium] On Mac, arrow keys should cause Select to pop up its menu.
Mac build of Chromium doesn't follow Mac HI guidelines to pop up the menu when
an arrow key is pressed.
https://bugs.webkit.org/show_bug.cgi?id=27448

No new tests; affects only control response to user input.

  • dom/SelectElement.cpp: Changed definition of ARROW_KEYS_POP_MENU to make it true in Mac Chromium, so it will behave compatibly with Mac HI guidelines on pop-up menus. It's not possible to have PLATFORM(MAC) be true in the Mac build of Chromium.
12:18 Changeset [46184] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Paul Godavari <paul@chromium.org>

Reviewed by Eric Seidel.

[Chromium] popup menus can crash when the selected index is -1
https://bugs.webkit.org/show_bug.cgi?id=27275

Crash reports from users indicate a crash can occur when PopupListBox::isSelectableItem
is passed an index of less than 0 (which is possible under certain circumstances). This
change prevents such a value from causing a crash by enforcing valid index values passed
by all callers of isSelectableItem. isSelectableItem is now a private method of
PopupListBox, as there are no external callers.

Also cleaned up a small amount of code for style and grammar errors.

No automatic test is provided since we cannot send events to the child window used by
the popup menu.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::acceptIndex): (WebCore::PopupListBox::selectIndex): (WebCore::PopupListBox::isSelectableItem): (WebCore::PopupListBox::selectPreviousRow):
12:00 Changeset [46183] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Don't include winsock2.h on wx, it conflicts with wx's inclusion of winsock.

11:21 Changeset [46182] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-20 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by David Levin.

Add checks for namespace indentation to cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27461

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
11:16 Changeset [46181] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-20 Adam Treat <adam.treat@torchmobile.com>

Reviewed by David Levin.

Add cpplint check for proper include order
https://bugs.webkit.org/show_bug.cgi?id=27462

Add a new check to cpplint to flag cases where the include section of a file
does not match the mandated include order and style of the Webkit coding style
guidelines.

Add associated tests.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
11:13 Changeset [46180] by aroben@apple.com
  • 13 edits
    2 deletes in trunk

Roll out r46153, r46154, and r46155

These changes were causing build failures and assertion failures on
Windows.

JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSArray.cpp:
  • runtime/StringPrototype.cpp:
  • runtime/UString.cpp:
  • runtime/UString.h:
  • wtf/FastMalloc.cpp:
  • wtf/FastMalloc.h:
  • wtf/Platform.h:
  • wtf/PossiblyNull.h: Removed.

WebCore:

  • ForwardingHeaders/wtf/PossiblyNull.h: Removed.
  • platform/graphics/cg/ImageBufferCG.cpp:
10:34 Changeset [46179] by jianli@chromium.org
  • 12 edits
    3 adds in trunk/WebCore

2009-07-21 Jian Li <jianli@chromium.org>

Reviewed by Eric Seidel.

Implement ErrorEvent API.
https://bugs.webkit.org/show_bug.cgi?id=27387

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • dom/ErrorEvent.cpp: Added.
  • dom/ErrorEvent.h: Added.
  • dom/ErrorEvent.idl: Added.
  • dom/Event.cpp: (WebCore::Event::isErrorEvent):
  • dom/Event.h:
10:14 Changeset [46178] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Priit Laes <plaes@plaes.org>

Reviewed by Gustavo Noronha.

[Gtk] Searching in thepiratebay.org doesn't work with more than 1 word
https://bugs.webkit.org/show_bug.cgi?id=24602

Remove workaround required for <=libsoup-2.26.1

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
10:09 Changeset [46177] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397

Make a copy of the context handle before making it weak. We don't want
to make the original handle weak because we want it to survive for the
length of the V8IsolatedWorld::evaluate method.

  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
09:50 Changeset [46176] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add ability to evaluate selection while on break point.

https://bugs.webkit.org/show_bug.cgi?id=27502

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded): (WebInspector.SourceFrame.prototype._documentKeyDown):
09:42 Changeset [46175] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Special case ConsolePanel opening since
it is a 'fast view'.

https://bugs.webkit.org/show_bug.cgi?id=27493

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible):
08:13 Changeset [46174] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

wx build fix. Adding isSpeaking() to ContextMenuClientWx.

06:40 Changeset [46173] by hausmann@webkit.org
  • 5 edits in trunk/WebKit/qt

2009-07-21 Volker Hilsheimer <volker.hilsheimer@nokia.com>

Reviewed by Simon Hausmann.

Various improvements to the API documentation.

  • Updated link to W3c Database spec
  • Formatting fixes, cleanups
  • Add missing \since 4.6 tags to QWebPage::frameAt
  • Extend QWebDatabase and QWebSecurityOrigin docs.
  • Api/qwebdatabase.cpp:
  • Api/qwebpage.cpp:
  • Api/qwebsecurityorigin.cpp:
  • Api/qwebview.cpp:
06:10 Changeset [46172] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-21 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Rubber-stamped by Simon Hausmann.

Remove preliminary-tag from QWebElement

  • Api/qwebelement.cpp:
05:42 Changeset [46171] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-21 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Skip fast/loader/non-html-load-event.html for the Qt DRT as it requires
support for loading PDF documents.

  • platform/qt/Skipped:
05:02 Changeset [46170] by kenneth@webkit.org
  • 66 edits in trunk

WebCore:

2009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Eric Seidel.

Fix Qt code to follow the WebKit Coding Style.

  • platform/graphics/qt/FontQt.cpp: (WebCore::qstring): (WebCore::fixSpacing):
  • platform/graphics/qt/FontQt43.cpp: (WebCore::generateComponents): (WebCore::Font::offsetForPositionForComplexText): (WebCore::cursorToX):
  • platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtFillRule): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getWindowsContext):
  • platform/graphics/qt/IconQt.cpp: (WebCore::Icon::paint):
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::ReadContext::read): (WebCore::ImageDecoderQt::ReadContext::readImageLines): (WebCore::ImageDecoderQt::setData):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern): (WebCore::BitmapImage::draw):
  • platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameDurationAtIndex): (WebCore::ImageSource::frameHasAlphaAtIndex): (WebCore::ImageSource::frameIsCompleteAtIndex):
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::create): (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::updateStates):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo): (WebCore::Path::isEmpty):
  • platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::TransformationMatrix::operator QTransform):
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::clearData): (WebCore::ClipboardQt::clearAllData): (WebCore::ClipboardQt::getData): (WebCore::ClipboardQt::setData): (WebCore::ClipboardQt::setDragImage): (WebCore::getCachedImage): (WebCore::ClipboardQt::declareAndWriteDragImage): (WebCore::ClipboardQt::writeURL): (WebCore::ClipboardQt::writeRange): (WebCore::ClipboardQt::hasData):
  • platform/qt/ClipboardQt.h:
  • platform/qt/ContextMenuItemQt.cpp: (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title):
  • platform/qt/CursorQt.cpp: (WebCore::westPanningCursor): (WebCore::notAllowedCursor):
  • platform/qt/DragDataQt.cpp: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): (WebCore::DragData::asPlainText): (WebCore::DragData::asFragment):
  • platform/qt/DragImageQt.cpp: (WebCore::createDragImageIconForCachedImage):
  • platform/qt/FileSystemQt.cpp: (WebCore::getFileSize): (WebCore::unloadModule):
  • platform/qt/Localizations.cpp: (WebCore::contextMenuItemTagShowSpellingPanel):
  • platform/qt/MIMETypeRegistryQt.cpp: (WebCore::):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::plainText):
  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  • platform/qt/PlatformMouseEventQt.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::populate):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::fallbackStyle): (WebCore::inflateButtonRect): (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::applyTheme): (WebCore::WorldMatrixTransformer::WorldMatrixTransformer): (WebCore::RenderThemeQt::paintMediaBackground): (WebCore::RenderThemeQt::paintMediaFullscreenButton):
  • platform/qt/RenderThemeQt.h:
  • platform/qt/ScreenQt.cpp: (WebCore::screenRect): (WebCore::usableScreenRect):
  • platform/qt/ScrollbarQt.cpp: (WebCore::Scrollbar::contextMenu):
  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::scPart): (WebCore::scrollbarPart):
  • platform/qt/ScrollbarThemeQt.h:
  • platform/qt/SharedBufferQt.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
  • platform/qt/TemporaryLinkStubs.cpp: (PluginDatabase::defaultPluginDirectories): (PluginDatabase::getPluginPathsInDirectories): (PluginDatabase::isPreferredPluginDirectory): (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString): (WebCore::userIdleTime): (WebCore::prefetchDNS):
  • platform/text/qt/StringQt.cpp: (WebCore::String::String):
  • platform/text/qt/TextBoundaries.cpp:
  • platform/text/qt/TextBreakIteratorQt.cpp: (WebCore::TextBreakIterator::following): (WebCore::TextBreakIterator::preceding): (WebCore::WordBreakIteratorQt::first): (WebCore::WordBreakIteratorQt::next): (WebCore::WordBreakIteratorQt::previous): (WebCore::CharBreakIteratorQt::first): (WebCore::CharBreakIteratorQt::next): (WebCore::CharBreakIteratorQt::previous): (WebCore::characterBreakIterator):
  • plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::fetchInfo):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::userAgentStatic): (WebCore::PluginView::handlePostReadFile): (WebCore::PluginView::init):

WebKit/qt:

2009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Eric Seidel.

Fix Qt code to follow the WebKit Coding Style.

  • Api/qcookiejar.cpp: (QCookieJar::setCookieJar): (QCookieJar::cookieJar):
  • Api/qcookiejar.h:
  • Api/qwebdatabase.cpp: (QWebDatabase::QWebDatabase): (QWebDatabase::removeDatabase):
  • Api/qwebdatabase.h:
  • Api/qwebdatabase_p.h:
  • Api/qwebelement.h:
  • Api/qwebframe.cpp: (QWebFrame::title): (QWebFrame::print):
  • Api/qwebframe.h:
  • Api/qwebframe_p.h:
  • Api/qwebhistory.cpp: (QWebHistory::clear):
  • Api/qwebhistory.h:
  • Api/qwebhistory_p.h:
  • Api/qwebhistoryinterface.cpp: (gCleanupInterface): (QWebHistoryInterface::setDefaultInterface): (QWebHistoryInterface::defaultInterface): (QWebHistoryInterface::QWebHistoryInterface):
  • Api/qwebhistoryinterface.h:
  • Api/qwebnetworkinterface.cpp: (QWebNetworkManager::started): (QWebNetworkManager::finished): (QWebNetworkInterfacePrivate::parseDataUrl): (QWebNetworkInterface::addJob): (WebCoreHttp::onResponseHeaderReceived): (WebCoreHttp::onReadyRead):
  • Api/qwebnetworkinterface.h:
  • Api/qwebnetworkinterface_p.h:
  • Api/qwebpage.cpp: (QWebPagePrivate::editorCommandForWebActions): (QWebPagePrivate::createContextMenu): (QWebPagePrivate::focusInEvent): (QWebPage::fixedContentsSize): (QWebPage::setContentEditable): (QWebPage::swallowContextMenuEvent): (QWebPage::findText):
  • Api/qwebpage.h:
  • Api/qwebpage_p.h:
  • Api/qwebpluginfactory.h:
  • Api/qwebsecurityorigin.h:
  • Api/qwebsecurityorigin_p.h:
  • Api/qwebsettings.cpp: (QWebSettingsPrivate::QWebSettingsPrivate): (QWebSettingsPrivate::apply): (QWebSettings::globalSettings): (QWebSettings::QWebSettings): (QWebSettings::fontSize): (QWebSettings::setUserStyleSheetUrl): (QWebSettings::setDefaultTextEncoding): (QWebSettings::setIconDatabasePath): (QWebSettings::iconDatabasePath): (QWebSettings::iconForUrl): (QWebSettings::setWebGraphic): (QWebSettings::setFontFamily): (QWebSettings::fontFamily): (QWebSettings::testAttribute): (qt_websettings_setLocalStorageDatabasePath):
  • Api/qwebsettings.h:
  • Api/qwebview.cpp: (QWebView::setPage): (QWebView::event):
  • Api/qwebview.h:
04:05 Changeset [46169] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-21 Priit Laes <plaes@plaes.org>

Reviewed by Holger Freyther.

[GTK+] Missing accelerator in authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=25509

Add accelerator to checkbox text.

  • WebKit/gtk/webkit/webkitsoupauthdialog.c: (show_auth_dialog):
03:51 Changeset [46168] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-21 Priit Laes <plaes@plaes.org>

Reviewed by Holger Freyther.

[GTK] http auth dialog pops up twice after a cancelled atempt
https://bugs.webkit.org/show_bug.cgi?id=24818

Remove workaround required for libsoup versions <=2.26.2 as we depend
on 2.27.4 now.

  • webkit/webkitsoupauthdialog.c: (session_authenticate):
03:41 Changeset [46167] by levin@chromium.org
  • 1 edit
    4 adds in trunk/WebCore

2009-07-21 Maxime Simon <simon.maxime@gmail.com>

Reviewed by David Levin.

Added a first bunch of Haiku-specific files for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=26988

  • platform/haiku/ClipboardHaiku.cpp: Added. (WebCore::ClipboardHaiku::ClipboardHaiku): (WebCore::ClipboardHaiku::clearData): (WebCore::ClipboardHaiku::clearAllData): (WebCore::ClipboardHaiku::getData): (WebCore::ClipboardHaiku::setData): (WebCore::ClipboardHaiku::types): (WebCore::ClipboardHaiku::files): (WebCore::ClipboardHaiku::dragLocation): (WebCore::ClipboardHaiku::dragImage): (WebCore::ClipboardHaiku::setDragImage): (WebCore::ClipboardHaiku::dragImageElement): (WebCore::ClipboardHaiku::setDragImageElement): (WebCore::ClipboardHaiku::createDragImage): (WebCore::ClipboardHaiku::declareAndWriteDragImage): (WebCore::ClipboardHaiku::writeURL): (WebCore::ClipboardHaiku::writeRange): (WebCore::ClipboardHaiku::hasData):
  • platform/haiku/ClipboardHaiku.h: Added. (WebCore::ClipboardHaiku::create): (WebCore::ClipboardHaiku::~ClipboardHaiku):
  • platform/haiku/CookieJarHaiku.cpp: Added. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
  • platform/haiku/CursorHaiku.cpp: Added. (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::Cursor::operator=): (WebCore::pointerCursor): (WebCore::moveCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor): (WebCore::grabCursor): (WebCore::grabbingCursor):
03:35 Changeset [46166] by levin@chromium.org
  • 2 edits
    1 add in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

Support lint for patches
https://bugs.webkit.org/show_bug.cgi?id=27291

Add run-webkit-lint script, which lints recent changes in local
repository. Also, modified cpplint.py so that we don't need to
specify verbose level for process_file().

  • Scripts/modules/cpplint.py:
  • Scripts/run-webkit-lint: Added.
03:12 Changeset [46165] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Albert Astals Cid <aacid@kde.org>

Reviewed by Tor Arne Vestbø.

Change #error line not to have a ' (single quote)

  • DerivedSources.cpp:
03:12 Changeset [46164] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

diff_parser should accept lines without trailing \n
https://bugs.webkit.org/show_bug.cgi?id=27483

Normalize the input lines by removing a trailing newline.
Also, add a case for unittest for newly added files.

  • Scripts/modules/diff_parser.py:
  • Scripts/modules/diff_parser_unittest.py:
03:12 Changeset [46163] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

cpplint.py's process_file() should accept customized error function
https://bugs.webkit.org/show_bug.cgi?id=27487

  • Scripts/modules/cpplint.py:
02:53 Changeset [46162] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

cpplint.py should have an interface to get global error count
https://bugs.webkit.org/show_bug.cgi?id=27486

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
02:53 Changeset [46161] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

cpplint's parse_argument should not exit even if no files are specified
https://bugs.webkit.org/show_bug.cgi?id=27489

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
02:53 Changeset [46160] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

diff_parser: s/add_deleted_line/add_old_line/g
https://bugs.webkit.org/show_bug.cgi?id=27484

  • Scripts/modules/diff_parser.py:
02:53 Changeset [46159] by levin@chromium.org
  • 17 edits in trunk

.:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

  • configure.ac: Added flag ENABLE_RUBY.

JavaScriptCore:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

  • Configurations/FeatureDefines.xcconfig: Added flag ENABLE_RUBY.

WebCore:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

Added flag ENABLE_RUBY:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/build-generated-files.sh:

WebKit/mac:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

  • Configurations/FeatureDefines.xcconfig: Added flag ENABLE_RUBY.

WebKit/win:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

  • WebKit.vcproj/WebKit.vcproj: Added flag ENABLE_RUBY.

WebKitTools:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

  • Scripts/build-webkit: Added flag ENABLE_RUBY.
02:53 Changeset [46158] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 James Hawkins <jhawkins@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27467
Return an empty path in PlatformContextSkia::currentPathInLocalCoordinates
if matrix.invert() fails. This prevents the use of an uninitialized
value in inverseMatrix.

No new tests added. Run
LayoutTests/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html
under valgrind and notice there are no errors.

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::currentPathInLocalCoordinates):
02:53 Changeset [46157] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-21 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27388

Fix dotted and dashed borders on Chromium/skia. This follows
the logic in the Cg path, so results are much closer to Safari now
(some tests won't be exactly the same due to font layout differences).

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):

07/20/09:

23:41 Changeset [46156] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix <https://bugs.webkit.org/show_bug.cgi?id=27482>.
Bug 27482: svn-apply cannot apply patch generated by Windows SVN

Reviewed by David D. Kilzer.

A regexp in svn-apply was treating everything prior to a \n as part of the
file name. The native Windows SVN client uses \r\n for line endings which
meant that the \r was being included in the file name. This defeated the
special-case logic for ChangeLogs to apply them with an increased fuzz factor,
meaning that the ChangeLog portions of such patches would fail to apply.

Also updated two other regexps that look like they would hit similar problems
with line-endings so that they will correctly handle patches from Windows SVN.

  • Scripts/svn-apply:
21:35 Changeset [46155] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix attempt #2

21:22 Changeset [46154] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix attempt #1

21:02 Changeset [46153] by oliver@apple.com
  • 11 edits
    2 adds in trunk

Make it harder to misuse try* allocation routines
https://bugs.webkit.org/show_bug.cgi?id=27469

Reviewed Gavin Barraclough

Jump through a few hoops to make it much harder to accidentally
miss null-checking of values returned by the try-* allocation
routines.

20:33 Changeset [46152] by zecke@webkit.org
  • 2 edits
    3 adds in trunk/WebKit/qt

[Qt] Add test for loading webpages...

Performance test for loading webpages...

20:32 Changeset [46151] by zecke@webkit.org
  • 2 edits
    4 adds in trunk/WebKit/qt

[Qt] Add a test case for drawing a simple viewrect to a QPixmap

20:30 Changeset [46150] by agl@chromium.org
  • 3 edits
    3 adds in trunk

2009-07-20 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Guard access to installedMediaEngines()[0].

https://bugs.webkit.org/show_bug.cgi?id=27479
http://code.google.com/p/chromium/issues/detail?id=16541

Else where in the file, installedMediaEngines is always checked for
being empty because access. This patch adds a case which missed that
check.

This triggered a crash in Chromium:

http://www.yakeze.com/chat/example-chromium-crash/

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load):
20:27 Changeset [46149] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Gavin Barraclough <barraclough@apple.com>

RS Oliver Hunt.

Add ARM assembler files to xcodeproj, for convenience editing.

20:06 Changeset [46148] by agl@chromium.org
  • 2 edits in trunk/WebCore

2009-07-20 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Allow search entries to render with a CSS border if the RenderTheme
doesn't paint them.

https://bugs.webkit.org/show_bug.cgi?id=27466
http://code.google.com/p/chromium/issues/detail?id=16958

<input type="search"> is very much like a text entry except that,
currently, if the RenderTheme doesn't deal with it, nothing is
rendered. With this patch, the default CSS border is rendered if the
RenderTheme requests it.

This will affect many layout tests, but only for Chromium Linux and
those results are not currently in the WebKit tree.

  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paintBorderOnly):
19:58 Changeset [46147] by jberlin@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Jessie Berlin <jberlin@apple.com>

Fix an incorrect assertion in Vector::remove.


Reviewed by David Levin.


https://bugs.webkit.org/show_bug.cgi?id=27477

  • wtf/Vector.h: (WTF::::remove): Assert that the position at which to start removing elements + the length (the number of elements to remove) is less than or equal to the size of the entire Vector.
19:54 Changeset [46146] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Correct expected results from r46136, which accidentally included the
DumpRenderTree header and trailer

  • fast/loader/non-html-load-event-expected.txt:
19:19 Changeset [46145] by abarth@webkit.org
  • 14 edits in trunk/WebCore

2009-07-17 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Switch to faster methods to access internal fields.
https://bugs.webkit.org/show_bug.cgi?id=27372

Minor refactoring.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertToSVGPODTypeImpl): (WebCore::V8DOMWrapper::setDOMWrapper):
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::convertDOMWrapperToNode): (WebCore::V8DOMWrapper::convertToNativeObject): (WebCore::V8DOMWrapper::convertToNativeEvent):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ClipboardCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::removeElement):
  • bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
19:15 Changeset [46144] by agl@chromium.org
  • 4 edits
    1 add in trunk/WebCore

2009-07-20 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium Linux: cache Harfbuzz faces.

https://bugs.webkit.org/show_bug.cgi?id=27473

Previously, we recreated the Harfbuzz face for each script-run. With
this patch, we keep the Harfbuzz face in the FontPlatformData (created
as needed) and so they will persist for the duration of the
FontPlatformData.

Shouldn't affect any layout tests. Results in a significant win on the
intl2 page cycler time.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::~TextRunWalker): (WebCore::TextRunWalker::setupFontForScriptRun):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::RefCountedHarfbuzzFace::~RefCountedHarfbuzzFace): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::harfbuzzFace):
  • platform/graphics/chromium/FontPlatformDataLinux.h: (WebCore::FontPlatformData::RefCountedHarfbuzzFace::create): (WebCore::FontPlatformData::RefCountedHarfbuzzFace::face): (WebCore::FontPlatformData::RefCountedHarfbuzzFace::RefCountedHarfbuzzFace):
  • platform/graphics/chromium/HarfbuzzSkia.h: Added.
18:31 Changeset [46143] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Simon Fraser.

REGRESSION (r46142): Need to remove showTreeThisForThis
https://bugs.webkit.org/show_bug.cgi?id=27475

Removes showTreeThisForThis

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::appendParagraphIntoNode):
17:55 Changeset [46142] by rniwa@webkit.org
  • 16 edits
    8 adds in trunk

WebCore:

2009-07-19 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Refactoring of indentRegion to fix bugs 26816 and 25317
https://bugs.webkit.org/show_bug.cgi?id=26816
https://bugs.webkit.org/show_bug.cgi?id=25317
https://bugs.webkit.org/show_bug.cgi?id=23995 (partially)

This patch implements appendParagraphIntoNode, a simpler specialized version of moveParagraph
and replaces all calls inside indentRegion. The following is the new behavior of indentRegion.

  1. We try to indent as many wrapping nodes as possible. e.g. when indenting "hello" in <div>hello</div>, we try to indent div as well.
  2. We do not delete any wrapping elements With moveParagraph, we used to remove all wrapping nodes, and replaced with a blockquote. This was causing https://bugs.webkit.org/show_bug.cgi?id=23995 for indentation. With appendParagraphIntoNode, we can preserve all wrapping nodes.
  3. We only split the tree until the closest block node instead of until the root editable node. This behavioral change fixes the bug 25317.
  4. When multiple paragraphs are indented, we indent the highest common ancestor within the selection. e.g. when a list is a child node of a div, and the entire div is intended,

we enclose the div by a single blockquote.

Note that new behavior is more consistent with that of Internet Explorer and Firefox.
To demonstrate this, the following tests are added.

Tests: editing/execCommand/indent-div-inside-list.html

editing/execCommand/indent-nested-blockquotes.html
editing/execCommand/indent-nested-div.html
editing/execCommand/indent-second-paragraph-in-blockquote.html

  • editing/IndentOutdentCommand.cpp: prepareBlockquoteLevelForInsertion is removed (WebCore::IndentOutdentCommand::tryIndentingAsListItem): uses appendParagraphIntoNode now (WebCore::IndentOutdentCommand::indentIntoBlockquote): uses appendParagraphIntoNode now (WebCore::IndentOutdentCommand::appendParagraphIntoNode): removes a paragraph and appends it to a new node (WebCore::IndentOutdentCommand::removeUnnecessaryLineBreakAt): removes a break element at the specified position (WebCore::IndentOutdentCommand::indentRegion): exhibits the described behavior
  • editing/IndentOutdentCommand.h: updated prototype
  • editing/execCommand/19653-1-expected.txt: rebaselined (no longer removes wrapping div)
  • editing/execCommand/indent-div-inside-list-expected.txt: Added.
  • editing/execCommand/indent-div-inside-list.html: Added.
  • editing/execCommand/indent-nested-blockquotes-expected.txt: Added.
  • editing/execCommand/indent-nested-blockquotes.html: Added.
  • editing/execCommand/indent-nested-div-expected.txt: Added.
  • editing/execCommand/indent-nested-div.html: Added.
  • editing/execCommand/indent-nested-lists-2-expected.txt: rebaselined (selection corrected)
  • editing/execCommand/indent-nested-lists-3-expected.txt: rebaselined (selection corrected)
  • editing/execCommand/indent-nested-lists-4-expected.txt: rebaselined (selection corrected)
  • editing/execCommand/indent-nested-lists-5-expected.txt: rebaselined (selection corrected)
  • editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Added.
  • editing/execCommand/indent-second-paragraph-in-blockquote.html: Added.
  • platform/mac/editing/execCommand/4641880-2-expected.txt: rebaselined
  • platform/mac/editing/execCommand/4916541-expected.txt: rebaselined (no longer removes wrapping span)
  • platform/mac/editing/execCommand/5138441-expected.txt: rebaselined
  • platform/mac/editing/execCommand/5481523-expected.txt: rebaselined
  • platform/mac/editing/execCommand/indent-selection-expected.txt: rebaselined
16:59 Changeset [46141] by mitz@apple.com
  • 2 edits in trunk/WebCore

Try to fix release builds after r46136

  • dom/Element.cpp:
16:59 Changeset [46140] by pdherbemont@apple.com
  • 6 edits
    2 deletes in trunk

WebCore:

2009-07-17 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Eric Seidel.

Media Controls: We are specifying the text height, where it is unneeded and the slider is 2px off.
https://bugs.webkit.org/show_bug.cgi?id=27380

Adjust the margin of the slider and remove useless height specification to fix alignement of the media controls.

  • css/mediaControlsQT.css:

LayoutTests:

2009-07-17 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Eric Seidel.

Media Controls: We are specifying the text height, where it is unneeded and the slider is 2px off.
https://bugs.webkit.org/show_bug.cgi?id=27380

Adjust the margin of the slider and remove useless height specification to fix alignement of the media controls.

  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-styling-expected.checksum: Removed.
  • platform/mac/media/controls-styling-expected.png: Removed.
  • platform/mac/media/controls-styling-expected.txt:
  • platform/mac/media/video-zoom-controls-expected.txt:
16:56 Changeset [46139] by pkasting@chromium.org
  • 19 edits in trunk

JavaScriptCore:

2009-07-20 Peter Kasting <pkasting@google.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.

WebCore:

2009-07-20 Peter Kasting <pkasting@google.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/WebCoreGenerated.vcproj:

WebKit/win:

2009-07-20 Peter Kasting <pkasting@google.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/InterfacesGenerated.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

WebKitTools:

2009-07-20 Peter Kasting <pkasting@google.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
16:35 Changeset [46138] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-20 Eric Seidel <eric@webkit.org>

Reviewed by Sam Weinig.

Fix failures seen on the bots
https://bugs.webkit.org/show_bug.cgi?id=27463

Ignore more global variables added by DumpRenderTree.
Some platforms don't add all of the DRT controllers,
thus causing this test to fail for those platforms.

Also fix !value to value === null to handle not
skip the cases where value == 0.

  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/resources/prototype-inheritance.js:
16:15 Changeset [46137] by cmarrin@apple.com
  • 1 edit in trunk/LayoutTests/transitions/extra-transition.html

Fixed a transition LayoutTest which fails on slower machines

16:08 Changeset [46136] by mitz@apple.com
  • 11 edits
    4 adds in trunk

WebCore:

Reviewed by Anders Carlsson.

When loading a custom view into a frame, the old document is still
around
<rdar://problem/5145841>

Safari fires onload before PDF is loaded into the browser
<rdar://problem/6618869>

Test: fast/loader/non-html-load-event.html

  • GNUmakefile.am: Added PlaceholderDocument.{cpp,h}
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • dom/Document.h: (WebCore::Document::setStyleSelector): Added this protected accessor for

PlaceholderDocument to use.

  • dom/Element.cpp: (WebCore::Element::clientWidth): Check whether the document has a

renderer.

(WebCore::Element::clientHeight): Ditto.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a PlaceholderDocument for frames

that do not use an HTML view. Do not nullify the content size in
that case.

(WebCore::FrameLoader::transitionToCommitted): For frames that do not

use an HTML view, call receivedFirstData(), which sets up the
frame with a new PlaceHolderDocument.

  • loader/PlaceholderDocument.cpp: Added. (WebCore::PlaceholderDocument::attach): Sets up the style selector but

does not create a RenderView.

  • loader/PlaceholderDocument.h: Added. (WebCore::PlaceholderDocument::create): (WebCore::PlaceholderDocument::PlaceholderDocument):

LayoutTests:

Reviewed by Anders Carlsson.

Safari fires onload before PDF is loaded into the browser
<rdar://problem/6618869>

  • fast/loader/non-html-load-event-expected.txt: Added.
  • fast/loader/non-html-load-event.html: Added.
15:45 Changeset [46135] by cmarrin@apple.com
  • 5 edits in trunk/WebCore

Handle opacity and opacity animations on transform layers in Leopard
https://bugs.webkit.org/show_bug.cgi?id=27398

This makes two changes, and only for Leopard.

First, whenever opacity is changed on a layer I propagate the
change into the content layer and all the children if the layer
on which opacity is set is a transform layer (preserve3D is true).
The opacity set is the accumulated opacity from this layer
and all its direct ancestor transform layers. Second, I turn off all
hardware opacity animation.

15:16 Changeset [46134] by pkasting@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-20 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27323
Use shorter, more correct code for determining the current directory,
which works better with symbolic links on some systems. Also switch
from checking repository root to checking UUID, to match scm.py.

  • Scripts/svn-create-patch:
14:46 Changeset [46133] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Work around <rdar://problem/7075373> by ensuring that the URL is absolute before handing it off to CoreText.

Rubber-stamped by Dan Bernstein.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(activateFonts):

14:38 Changeset [46132] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-07-20 Geoffrey Garen <ggaren@apple.com>

Fixed a post-review typo in r46066 that caused tons of test failures.


SunSpider reports no change.

  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): Initialize the full vector capacity, to avoid uninitialized members at the end.
13:55 Changeset [46131] by bweinstein@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-07-20 Geoffrey Garen <ggaren@apple.com>

Windows WebKit build fix: Added some missing exports.

13:41 Changeset [46130] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-20 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

Enable filename completion for run-webkit-test (added "-o default").

  • Scripts/webkit-tools-completion.sh:
13:08 Changeset [46129] by treat@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-07-20 Yong Li <yong.li@torchmobile.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=27349
Add GraphicsContext implementation for the WinCE port.

Written by Yong Li <yong.li@torchmobile.com> and George Staikos <george.staikos@torchmobile.com>
with trivial style fixes by Adam Treat <adam.treat@torchmobile.com>

  • platform/graphics/wince/GraphicsContextWince.cpp: Added.
13:06 Changeset [46128] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r46058.

12:37 Changeset [46127] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r46039.

10:56 Changeset [46126] by eroman@chromium.org
  • 3 edits
    4 adds in trunk/WebCore

2009-07-20 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adding the Win SQLite VFS implementation for Chromium, and stubs
for the Mac and Linux VFSs.

https://bugs.webkit.org/show_bug.cgi?id=26940

  • WebCore.gypi:
  • platform/chromium/ChromiumBridge.h:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: Added.
  • platform/sql/chromium/SQLiteFileSystemChromiumLinux.cpp: Added.
  • platform/sql/chromium/SQLiteFileSystemChromiumMac.cpp: Added.
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: Added.
06:47 Changeset [46125] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=27097
[Gtk] Segfault when examining an object of ROLE_TABLE via at-spi

Check that an object is a RenderObject before trying to access its
renderer and related node.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
06:36 Changeset [46124] by hausmann@webkit.org
  • 5 edits in trunk/WebCore

2009-07-20 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] font cache reworking
https://bugs.webkit.org/show_bug.cgi?id=27265

Reimplemented Qt's FontCache in a way that follows the shared one.
Now we can release its elements when those became inactive.
FontFallbackList had been changed to be able to hold WebCore fonts in its list and to be able to release a FontData what is in the cache.

No change in behavior, so no tests.

  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue): (WebCore::FontPlatformDataCacheKey::): Key type for the cache of FontPlatformData objects. It can be constructed from a FontPlatformData or from a FontDescription. The keys have to be consistent with FontPlatformData::FontPlatformData(const FontDescription&) - if we create the same FontPlatformData from two FontDescription then we have to create the same key from them, and vica versa. (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::FontPlatformDataCacheKey::hash): (WebCore::FontPlatformDataCacheKey::computeHash): (WebCore::FontPlatformDataCacheKey::hashTableDeletedSize): (WebCore::FontPlatformDataCacheKeyHash::hash): (WebCore::FontPlatformDataCacheKeyHash::equal): (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): (WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue): (WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue): (WebCore::FontCache::getCachedFontPlatformData): Get a FontDescription and returns a FontPlatformData. (WebCore::FontCache::getCachedFontData): Get a FontPlatformData and returns a SimpleFontData. (WebCore::FontCache::releaseFontData): Get a SimpleFontData and releases it from the cache. Also releases the appropriate FontPlatformData. (WebCore::FontCache::purgeInactiveFontData): Frees inactive elements. (WebCore::FontCache::invalidate): Frees all inactive elements (call purgeInactiveFontData with default argument)
  • platform/graphics/qt/FontFallbackListQt.cpp: (WebCore::FontFallbackList::releaseFontData): (WebCore::FontFallbackList::fontDataAt):
  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::family): Getter. It is needed for FontPlatformDataCacheKey. (WebCore::FontPlatformData::bold): Ditto. (WebCore::FontPlatformData::italic): Ditto. (WebCore::FontPlatformData::smallCaps): Ditto. (WebCore::FontPlatformData::pixelSize): Ditto.
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): Set m_bold.
04:01 Changeset [46123] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-07-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

[GTK] Widget size negotiation
https://bugs.webkit.org/show_bug.cgi?id=17154

Implement proper size request for the WebView widget.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::contentsSizeChanged):
  • webkit/webkitwebview.cpp: (webkit_web_view_size_request): (webkit_web_view_class_init):
03:09 Changeset [46122] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>

No review, just adding Gavin Barraclough as reviewer.

  • Scripts/modules/bugzilla.py:
03:04 Changeset [46121] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Allow custom memory allocation control in NewThreadContext
https://bugs.webkit.org/show_bug.cgi?id=27338

Inherits NewThreadContext struct from FastAllocBase because it
has been instantiated by 'new' JavaScriptCore/wtf/Threading.cpp:76.

  • wtf/Threading.cpp:
03:04 Changeset [46120] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Allow custom memory allocation control in JavaScriptCore's JSClassRef.h
https://bugs.webkit.org/show_bug.cgi?id=27340

Inherit StaticValueEntry and StaticFunctionEntry struct from FastAllocBase because these
have been instantiated by 'new' in JavaScriptCore/API/JSClassRef.cpp:153
and in JavaScriptCore/API/JSClassRef.cpp:166.

  • API/JSClassRef.h:
03:03 Changeset [46119] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control in JavaScriptCore's RegexPattern.h
https://bugs.webkit.org/show_bug.cgi?id=27343

Inherits RegexPattern.h's structs (which have been instantiated by operator new) from FastAllocBase:

CharacterClass (new call: JavaScriptCore/yarr/RegexCompiler.cpp:144)
PatternAlternative (new call: JavaScriptCore/yarr/RegexPattern.h:221)
PatternDisjunction (new call: JavaScriptCore/yarr/RegexCompiler.cpp:446)

  • yarr/RegexPattern.h:
03:03 Changeset [46118] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's MatchFrame struct
https://bugs.webkit.org/show_bug.cgi?id=27344

Inherits MatchFrame struct from FastAllocBase because it has
been instantiated by 'new' JavaScriptCore/pcre/pcre_exec.cpp:359.

  • pcre/pcre_exec.cpp:
03:02 Changeset [46117] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=26716
[Gtk] Each XMLHttpRequest leaks memory.

Free the SoupURI we create to check the URI. Fix suggested by John
Kjellberg.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
02:52 Changeset [46116] by hausmann@webkit.org
  • 4 edits in trunk

.:

2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] Add an option for QtLauncher to build without QtUiTools dependency
https://bugs.webkit.org/show_bug.cgi?id=27438

Based on Norbert Leser's work.

  • WebKit.pri: Symbian does not have UiTools

WebKit/qt:

2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] Add an option for QtLauncher to build without QtUiTools dependency
https://bugs.webkit.org/show_bug.cgi?id=27438

Based on Norbert Leser's work.

  • QtLauncher/main.cpp: (WebPage::createPlugin):
02:50 Changeset [46115] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

Remove some outdated S60 platform specific code
https://bugs.webkit.org/show_bug.cgi?id=27423

  • wtf/Platform.h:
02:49 Changeset [46114] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

Qt build fix with MSVC and MinGW.

  • jsc.pro: Make sure jsc is a console application, and turn off exceptions and stl support to fix the build.
02:46 Changeset [46113] by hausmann@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by David Levin.

Add support for Qt's foreach to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27386

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
02:41 Changeset [46112] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] On Symbian link against system sqlite3
https://bugs.webkit.org/show_bug.cgi?id=27368

Add an option to force linking against system sqlite3
by adding system-sqlite to the CONFIG variable.

The Symbian specific part of this patch is contributed by
Norbert Leser.

  • WebCore.pro:
02:32 Changeset [46111] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by and done with Tor Arne Vestbø.

Fix fast/css/pseudo-required-optional-*.html in the Qt build
after r46062.

These tests triggered a bug in RenderThemeQt where we did not fall back
to the unstyled painting of text areas and input fields when they have
a styled background.

Our re-implementation of isControlStyled incorrectly only checked the
border for determining whether to style or not. The base-implementation
performs the same check, but also includes the background. Removing
our implementation fixes the appearance.

  • platform/qt/RenderThemeQt.cpp: Removed isControlStyled reimplementation.
  • platform/qt/RenderThemeQt.h: Ditto.
01:31 Changeset [46110] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not use C++-style comments in preprocessor directives.

GCC does not like this in some configurations, using C-style
comments is safer.

  • wtf/Platform.h:
01:31 Changeset [46109] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Change the glib version check to check for the first unstable
release with g_mapped_file_unref. Otherwise this would be useless
until 2.22 is released, a few months from now.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
00:51 Changeset [46108] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Tor Arne Vestbø.

Add missing (sorted) header files to the HEADERS variable in the qmake
.pro file for improved completion in IDEs.

  • WebCore.pro:
00:24 Changeset [46107] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-19 Simon Hausmann <hausmann@webkit.org>

Rubber-stamped by Xan Lopez.

Skip new fast/dom/prototype-inheritance.html test in the Qt DRT
due to missing features/properties in the window object.

  • platform/qt/Skipped:

07/19/09:

20:56 Changeset [46106] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

2009-07-19 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[V8] Factor V8ConsoleMessage out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27421

No behavior change.

  • WebCore.gypi:
  • bindings/v8/V8ConsoleMessage.cpp: Added. (WebCore::V8ConsoleMessage::V8ConsoleMessage): (WebCore::V8ConsoleMessage::dispatchNow): (WebCore::V8ConsoleMessage::dispatchLater): (WebCore::V8ConsoleMessage::processDelayed): (WebCore::V8ConsoleMessage::handler):
  • bindings/v8/V8ConsoleMessage.h: Added. (WebCore::V8ConsoleMessage::Scope::Scope): (WebCore::V8ConsoleMessage::Scope::~Scope):
  • bindings/v8/V8Proxy.cpp: (WebCore::logInfo): (WebCore::reportUnsafeAccessTo): (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::newInstance): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::processConsoleMessages):
11:50 Changeset [46105] by rwlbuis@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Adam Barth.

Remove unused member variable.

  • svg/SVGPolyElement.h:
11:16 Changeset [46104] by eric.carlson@apple.com
  • 3 edits
    2 adds in trunk

2009-07-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

HTMLAudioElement: constructor should set "autobuffer" attribute
https://bugs.webkit.org/show_bug.cgi?id=27422

Test: media/audio-constructor-autobuffer.html

  • bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):

Set 'autobuffer' attribute.

2009-07-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

HTMLAudioElement: constructor should set "autobuffer" attribute
https://bugs.webkit.org/show_bug.cgi?id=27422

  • media/audio-constructor-autobuffer-expected.txt: Added.
  • media/audio-constructor-autobuffer.html: Added.
02:47 Changeset [46103] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-19 Thierry Bastian <thierry.bastian@nokia.com>

Reviewed by Simon Hausmann.

Fix the Qt build with mingw.

  • WebCore.pro: Don't use MSVC commandline options to disable warnings with mingw.
00:39 Changeset [46102] by abarth@webkit.org
  • 14 edits in trunk/WebCore

2009-07-19 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[V8] Phase 2: Remove event listener methods from V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27415

No behavior change.

  • bindings/v8/V8ObjectEventListener.cpp: (WebCore::weakObjectEventListenerCallback): (WebCore::V8ObjectEventListener::~V8ObjectEventListener):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::disconnectEventListeners):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::eventListeners): (WebCore::V8Proxy::objectListeners):
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp: (WebCore::getEventListener):
  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::~V8EventListener):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SVGElementInstanceCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::getEventListener):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::getEventListener):
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):

07/18/09:

16:13 Changeset [46101] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[Gtk] soup/ResourceHandleSoup.cpp:533: error: 'g_mapped_file_free' was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=27230

Use g_mapped_file_unref for GLIB version 2.22 onwards.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
16:03 Changeset [46100] by jmalonzo@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-07-18 Jorge Gonzalez <aloriel@gmail.com>

Rubber-stamped by Jan Alonzo.

es translation
https://bugs.webkit.org/show_bug.cgi?id=26319

  • es.po: Added.
16:00 Changeset [46099] by darin@apple.com
  • 4 edits in trunk/LayoutTests/fast

Remove some stray executable flags.

15:59 Changeset [46098] by mitz@apple.com
  • 2 edits in trunk

Added Radar URLs

15:58 Changeset [46097] by mitz@apple.com
  • 18 edits
    4 adds in trunk

WebCore:

Reviewed by Anders Carlsson.

Add spread radius support to -webkit-box-shadow
https://bugs.webkit.org/show_bug.cgi?id=27417

Test: fast/box-shadow/spread.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): Added a property ID parameter and used it to

include the spread length for box-shadow but not for text-shadow.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

Pass the property ID to valueForShadow().

  • css/CSSParser.cpp: (WebCore::ShadowParseContext::ShadowParseContext): Added property,

spread, and allowSpread members. Added a property ID parameter to
the constructor. Initialize the property and allowSpread members.

(WebCore::ShadowParseContext::allowLength): Added allowSpread.
(WebCore::ShadowParseContext::commitValue): Pass the spread value to

the ShadowValue constructor. Reset allowSpread.

(WebCore::ShadowParseContext::commitLength): Allow spread after blur

for the box-shadow property.

(WebCore::ShadowParseContext::commitColor): Reset allowSpread.
(WebCore::CSSParser::parseShadow): Pass the property ID to

ShadowParseContext().

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Get the spread value from

the shadow value and pass it to the ShadowData constructor.

  • css/ShadowValue.cpp: (WebCore::ShadowValue::ShadowValue): Added spread. (WebCore::ShadowValue::cssText): Added spread.
  • css/ShadowValue.h: (WebCore::ShadowValue::create): Added spread.
  • page/animation/AnimationBase.cpp: (WebCore::blendFunc): Blend the spread value. (WebCore::PropertyWrapperShadow::blend): Added 0 spread to the default

shadow.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Account for spread in

the visual overflow calculations.

(WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
(WebCore::InlineFlowBox::paint): Ditto.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): Ditto. (WebCore::RenderBlock::overflowWidth): Ditto. (WebCore::RenderBlock::overflowLeft): Ditto. (WebCore::RenderBlock::overflowTop): Ditto. (WebCore::RenderBlock::overflowRect): Ditto. (WebCore::RenderBlock::layoutBlock): Ditto.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Inflate the shadow-

casting rect by the shadow spread value. Adjust border radii if
necessary.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Account for spread in the

visual overflow calculations.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateRects): Ditto.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Account for spread. (WebCore::RenderObject::adjustRectForOutlineAndShadow): Ditto.
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect): Ditto.
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow): Assert that text shadows do not

have spread.

  • rendering/style/ShadowData.cpp: (WebCore::ShadowData::ShadowData): Added spread. (WebCore::ShadowData::operator==): Compare spread.
  • rendering/style/ShadowData.h: (WebCore::ShadowData::ShadowData): Added spread.

LayoutTests:

Reviewed by Anders Carlsson.

Test box-shadow spread radius
https://bugs.webkit.org/show_bug.cgi?id=27417

  • fast/box-shadow/spread.html: Added.
  • platform/mac/fast/box-shadow/spread-expected.checksum: Added.
  • platform/mac/fast/box-shadow/spread-expected.png: Added.
  • platform/mac/fast/box-shadow/spread-expected.txt: Added.
15:53 Changeset [46096] by jmalonzo@webkit.org
  • 4 edits in trunk

2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>

https://bugs.webkit.org/show_bug.cgi?id=27145
[Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html fails after r45615

Reviewed by Gustavo Noronha.

  • platform/gtk/Skipped:

Normalize file URLs.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpHistoryItem):
11:50 Changeset [46095] by pkasting@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Further improve non-Cygwin SVN support.

  • Scripts/prepare-ChangeLog: Harmless change to be consistent with other places that consume whitespace at the end of svn output.
  • Scripts/resolve-ChangeLogs: Add support for SVN 1.6. Slightly optimize svn info parsing based on technique in svn-create-patch. Normalize paths and consume whitespace in the same way as prepare-ChangeLog, for Windows systems with a non-Cygwin SVN. Force diff and patch to run in binary mode so that they won't "intelligently" screw up line endings.
10:48 Changeset [46094] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-18 Adam Barth <abarth@webkit.org>

Reviewed by Jan Alonzo.

Minor FrameLoader.cpp cleanup
https://bugs.webkit.org/show_bug.cgi?id=27406

No behavior change.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::executeIfJavaScriptURL):
10:47 Changeset [46093] by simon.fraser@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-18 Simon Fraser <simon.fraser@apple.com>

Fix Tiger DRT build.

  • DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow):
  • DumpRenderTree/mac/PixelDumpSupportMac.mm:
09:59 Changeset [46092] by simon.fraser@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-17 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

DRT doesn't reliably snapshot composited layers
https://bugs.webkit.org/show_bug.cgi?id=27399

If we're doing an "onscreen" pixel capture, it means that we're snapshotting a view
with composited content. In that case we need to force the view to display so that
the composited layers are rendered to the screen.

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):
08:02 Changeset [46091] by abarth@webkit.org
  • 6 edits in trunk/WebCore

2009-07-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

[V8] Move event listener methods from V8Proxy to V8EventListenerList
https://bugs.webkit.org/show_bug.cgi?id=27408

Move some event listener code out of V8Proxy and into the event
listener list.

I'd like to remove these methods from V8Proxy entirely and just expose
getters for the lists themselves, but I'll do that in a follow up
patch.

  • bindings/v8/V8EventListenerList.cpp: (WebCore::V8EventListenerList::findWrapper):
  • bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper):
  • bindings/v8/V8ObjectEventListener.cpp:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::findV8EventListener): (WebCore::V8Proxy::findOrCreateV8EventListener): (WebCore::V8Proxy::removeV8EventListener): (WebCore::V8Proxy::findObjectEventListener): (WebCore::V8Proxy::findOrCreateObjectEventListener): (WebCore::V8Proxy::removeObjectEventListener):
  • bindings/v8/V8Proxy.h:
01:45 Changeset [46090] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>

[Gtk] Skip tests that require new expected results, eventSender
and editing callbacks DRT support. Unreviewed.

  • platform/gtk/Skipped:
01:37 Changeset [46089] by abarth@webkit.org
  • 2 edits in trunk/WebCore

Revert 46088.

01:31 Changeset [46088] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-18 Adam Barth <abarth@webkit.org>

Reviewed by Jan Alonzo.

Minor FrameLoader.cpp cleanup
https://bugs.webkit.org/show_bug.cgi?id=27406

No behavior change.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::executeIfJavaScriptURL):
00:44 Changeset [46087] by jorlow@chromium.org
  • 16 edits
    2 deletes in trunk

WebCore:

2009-07-18 Jeremy Orlow <jorlow@chromium.org>

Rubber stamped by Adam Barth.

Revert https://bugs.webkit.org/show_bug.cgi?id=27383
https://bugs.webkit.org/show_bug.cgi?id=27407

Revert Jens' patch. I believe he forgot to include a file.

  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
  • bindings/v8/V8DataGridDataSource.cpp: Removed.
  • bindings/v8/V8DataGridDataSource.h: Removed.
  • bindings/v8/V8GCController.h:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):

LayoutTests:

2009-07-18 Jeremy Orlow <jorlow@chromium.org>

Rubber stamped by Adam Barth.

Revert https://bugs.webkit.org/show_bug.cgi?id=27383
https://bugs.webkit.org/show_bug.cgi?id=27407

Revert Jens' patch. I believe he forgot to include a file.

  • fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:

07/17/09:

23:13 Changeset [46086] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

2009-07-17 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27405

Tests that HTML entities that contain an invalid entity, such as an
unknown named entity, are properly handled.

  • http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt: Added.
  • http/tests/security/xssAuditor/link-onclick-ampersand.html: Added.
  • http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-ampersand.html: Added.

2009-07-17 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27405

Fixes an issue when decoding HTML entities with an unknown named entity that
caused null-characters to be inserted into the decoded result.

Test: http/tests/security/xssAuditor/link-onclick-ampersand.html

http/tests/security/xssAuditor/javascript-link-ampersand.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeHTMLEntities): Added check to conditional so that non-zero entity values are not inserted during decoding process.
22:42 Changeset [46085] by simon.fraser@apple.com
  • 2 edits in trunk/WebKitSite

2009-07-17 Simon Fraser <simon.fraser@apple.com>

Fix the font to match the rest of the blog site.

  • blog-files/3d-transforms/image-flip.html:
22:38 Changeset [46084] by simon.fraser@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

2009-07-17 Simon Fraser <simon.fraser@apple.com>

Move the image flip effect into an iframe to avoid the long
blog page tripping a bug on Leopard.

  • blog-files/3d-transforms/image-flip.html: Added.
22:32 Changeset [46083] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-07-17 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27403
Add test case for https://bugs.webkit.org/show_bug.cgi?id=27394:
properties on a window object should be accessible after the frame
of the window object has navigated to another site.

  • fast/dom/Window/window-access-after-navigation-expected.txt: Added.
  • fast/dom/Window/window-access-after-navigation.html: Added.
20:29 Changeset [46082] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-17 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

bugzilla-tool does not understand nested SVN repos
https://bugs.webkit.org/show_bug.cgi?id=27404

Determine the root of the working copy by looking at SVN's UUIDs.

  • Scripts/modules/scm.py:
20:12 Changeset [46081] by jmalonzo@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2009-07-17 Jan Michael Alonzo <jmalonzo@webkit.org>

<http://webkit.org/b/18363> [GTK] Combo boxes cannot be opened pressing space

Reviewed by Holger Freyther.

Add Gtk to platforms that want to open the menulist using the
spacebar.

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
19:57 Changeset [46080] by jmalonzo@webkit.org
  • 4 edits in trunk/WebCore

2009-07-17 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25523
[GTK] The text displayed by push buttons is not exposed to assistive technologies

Add new public method text() to RenderButton and use it from
AccessibilityRenderObject::stringValue().

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::text):
  • rendering/RenderButton.h:
19:14 Changeset [46079] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2009-07-17 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Restore proxy retrieval
https://bugs.webkit.org/show_bug.cgi?id=27369

No new tests are needed.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
19:08 Changeset [46078] by yael.aharon@nokia.com
  • 2 edits in trunk/WebCore

2009-07-17 Yael Aharon <yael.aharon@nokia.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=27351
Added platform "Symbian" to WEBCORE_NAVIGATOR_PLATFORM
Use uname to find the correct platform for Linux.

  • page/NavigatorBase.cpp:
18:42 Changeset [46077] by jorlow@chromium.org
  • 16 edits
    2 adds in trunk

WebCore:

2009-07-17 Jens Alfke <snej@chromium.org>

Reviewed by Dimitri Glazkov.

Hook up V8 bindings for DataGrid elements.
https://bugs.webkit.org/show_bug.cgi?id=27383
http://code.google.com/p/chromium/issues/detail?id=16730

Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.

  • WebCore.gypi: Added new source files.
  • bindings/scripts/CodeGeneratorV8.pm: Made GenerateBatchedAttributeData put #if's around conditional attributes.
  • bindings/v8/DOMObjectsInclude.h: #include DataGrid headers.
  • bindings/v8/V8DOMWrapper.cpp: Add bindings from HTML tags to datagrid templates. (WebCore::V8DOMWrapper::getTemplate): Customize datagrid template.
  • bindings/v8/V8DataGridDataSource.cpp: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::V8DataGridDataSource): (WebCore::V8DataGridDataSource::~V8DataGridDataSource):
  • bindings/v8/V8DataGridDataSource.h: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::create): (WebCore::V8DataGridDataSource::isJSDataGridDataSource): (WebCore::V8DataGridDataSource::jsDataSource): (WebCore::asV8DataGridDataSource):
  • bindings/v8/V8GCController.h: Added new handle type "DATASOURCE".
  • bindings/v8/V8Index.h: Conditionalize datagrid stuff.
  • bindings/v8/custom/V8CustomBinding.h: Declare more accessors. Conditionalize.
  • bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Fill in dataSource accessors. (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):

LayoutTests:

2009-07-17 Jens Alfke <snej@chromium.org>

Reviewed by Dimitri Glazkov.

Hook up V8 bindings for DataGrid elements.
https://bugs.webkit.org/show_bug.cgi?id=27383
http://code.google.com/p/chromium/issues/detail?id=16730

Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.

  • fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
18:36 Changeset [46076] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-17 David Levin <levin@chromium.org>

Reviewed by Mark Rowe.

webkit-tools-completion.sh has two typos and sorting issues.
https://bugs.webkit.org/show_bug.cgi?id=27401

  • Scripts/webkit-tools-completion.sh: Fix two typos "--dif" and "-clean". Also, sort all lists including items in the case statement and flags for the commands.
18:26 Changeset [46075] by jorlow@chromium.org
  • 13 edits in trunk/WebCore

2009-07-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

StorageArea should only contain methods we intend to proxy.
https://bugs.webkit.org/show_bug.cgi?id=27181

Right now, StorageAreaSync takes in a StorageArea* and calls methods
like importItem. Really, StorageAreaSync should be operating directly
on StorageAreaImpl* and those methods should be removed from StorageArea
since StorageAreaSync should never be attached to anything other than a
StorageAreaImpl.

This was pointed out in the review for
https://bugs.webkit.org/show_bug.cgi?id=27072

Also clean up StorageNamespaceImpl to operate directly on
StorageAreaImpl. Also, get rid of the factory for StorageArea
since nothing should ever create a StorageArea directly.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • storage/StorageArea.cpp: Removed.
  • storage/StorageArea.h: (WebCore::StorageArea::~StorageArea):
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::copy):
  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::create): (WebCore::StorageAreaSync::StorageAreaSync):
  • storage/StorageAreaSync.h:
  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea):
  • storage/StorageNamespaceImpl.h:
18:22 Changeset [46074] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2009-07-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Add v8 implementation for DOM Storage ScriptObjectQuarantine.
https://bugs.webkit.org/show_bug.cgi?id=27327

Wrap the storage object with a generic object as is done elsewhere in
the file (but continue to hit a NOTIMPLEMENTED if DOM_STORAGE is not
enabled.

  • bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
17:12 Changeset [46073] by eroman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-17 Mads Ager <ager@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=27394
Fix access to global object wrappers after navigation of their
frame in the V8 bindings. This fixes selenium test failures.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::updateDocument):
16:54 Changeset [46072] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the 32-bit build by removing implicit float <-> double conversions.

  • inspector/InspectorController.cpp:

(WebCore::constrainedAttachedWindowHeight):

16:27 Changeset [46071] by bweinstein@apple.com
  • 7 edits in trunk

2009-07-17 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
https://bugs.webkit.org/show_bug.cgi?id=14272


Implemented resizing of inspector window when it is in attached mode. Implemented setAttachedWindowHeight
to set window sizes and redraw the inspector and the inspected web view, and used stored preferences
in InspectorController.cpp to remember user's preferred height.

  • WebCoreSupport/WebInspectorClient.cpp:

2009-07-17 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
https://bugs.webkit.org/show_bug.cgi?id=14272


Moved preference setting for attached inspector height and inspector height calculation from
WebInspectorClient.mm into InspectorController.cpp, to make this code cross-platform and enable
Windows resizing of attached inspector.

  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:

2009-07-17 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
https://bugs.webkit.org/show_bug.cgi?id=14272


Removed size calculation code from [WebInspectorWindowController setInitialAttachedHeight] into
InspectorController.cpp to make it cross platform, and use InspectorController to store the
user's preferred size for an attached window, instead of NSUserDefaults.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController setAttachedWindowHeight:]):
16:25 Changeset [46070] by mitz@apple.com
  • 2 edits in trunk/WebCore

Another attempt at fixing the build after r46063

  • WebCore.xcodeproj/project.pbxproj: Made ExceptionCode.h a private

header, because it is now included from htmlediting.h, which is
a private header.

16:22 Changeset [46069] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27396
Moving cursor in Thai text sometimes jumps over two characters

Test: editing/text-iterator/thai-cursor-movement.html

  • platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Added a special case for five Thai characters, matching ICU/CLDR changes.
16:13 Changeset [46068] by eric@webkit.org
  • 19 edits
    3 adds in trunk

2009-07-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Some constructor objects exposed on Window have the wrong prototype chain
https://bugs.webkit.org/show_bug.cgi?id=27276

  • fast/dom/prototype-inheritance-expected.txt: Added.
  • fast/dom/prototype-inheritance.html: Added.
  • fast/dom/resources/prototype-inheritance.js: Added.

2009-07-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Some constructor objects exposed on Window have the wrong prototype chain
https://bugs.webkit.org/show_bug.cgi?id=27276

Several Constructor classes were already being passed a global object
during construction, but they were ignoring it for prototype lookup.
I've fixed those to use the passed global object instead.

Most of these Constructor classes should just be auto-generated, but I
refrained from changing them over to auto-gen in this patch.

Fixed CodeGeneratorJS to pass a global object to getDOMConstructor when
available, otherwise default to deprecatedGlobalObjectForPrototype(exec)
to match existing behavior.

Test: fast/dom/prototype-inheritance.html

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor): use the existing globalObject pointer for prototype lookup
  • bindings/js/JSDOMBinding.h: (WebCore::deprecatedGlobalObjectForPrototype): Make it easy to detect where the wrong global object is being used. (WebCore::deprecatedGetDOMStructure):
  • bindings/js/JSDOMGlobalObject.h: remove error-prone getDOMConstructor, require passing JSDOMGlobalObject*
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webKitPoint): pass "this" for the global object. (WebCore::JSDOMWindow::webKitCSSMatrix): pass "this" for the global object. (WebCore::JSDOMWindow::xsltProcessor): pass "this" for the global object. (WebCore::JSDOMWindow::worker): pass "this" for the global object.
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor): use the existing globalObject pointer for prototype lookup
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): use the existing globalObject pointer for prototype lookup
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor): use the existing globalObject pointer for prototype lookup
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor): add new globalObject parameter and use it
  • bindings/js/JSWebKitCSSMatrixConstructor.h:
  • bindings/js/JSWebKitPointConstructor.cpp: (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor): add new globalObject parameter and use it
  • bindings/js/JSWebKitPointConstructor.h:
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::JSWorkerConstructor::JSWorkerConstructor): add new globalObject parameter and use it
  • bindings/js/JSWorkerConstructor.h:
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): use the existing globalObject pointer for prototype lookup -- XMLHttpRequest constructor was also missing a length. Added one.
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
  • bindings/js/JSXSLTProcessorConstructor.h:
  • bindings/scripts/CodeGeneratorJS.pm:
16:11 Changeset [46067] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix

  • editing/htmlediting.cpp: (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
16:04 WebKit Team edited by jparent@chromium.org
(diff)
16:03 Changeset [46066] by ggaren@apple.com
  • 14 edits in branches/nitro-extreme/JavaScriptCore

2009-07-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Get the branch working on windows.
https://bugs.webkit.org/show_bug.cgi?id=27391


SunSpider says 0.3% faster.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Updated MSVC export lists to fix linker errors.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added / removed new / old project files.
  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): Used #pragma pack to tell MSVC that these structures represent actual memory layout, and should not be automatically aligned. Changed the return value load to load a 64bit quantity into the canonical registers.
  • jit/JIT.h: Moved OBJECT_OFFSETOF definition to StdLibExtras.h because it's needed by more than just the JIT, and it supplements a standard library macro (offsetof).
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): Fixed an incorrectly signed cast to resolve an MSVC warning.
  • jit/JITStubs.h: Used #pragma pack to tell MSVC that these structures represent actual memory layout, and should not be automatically aligned.
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): Replaced memset_pattern8 with a for loop, since memset_pattern8 is not portable. (I verified that this version of the loop gives the best performance / generated code in GCC.)
  • runtime/JSObject.h: (JSC::JSObject::JSObject): Removed accidental usage of FIELD_OFFSET -- OBJECT_OFFSETOF is our new macro name. (FIELD_OFFSET conflicts with a definition in winnt.h.)
  • runtime/JSValue.cpp: Added some headers needed by non-all-in-one builds.


  • runtime/JSValue.h: (JSC::JSValue::): Made the tag signed, to match MSVC's signed enum values. (GCC doesn't seem to care one way or the other.)
  • wtf/MainThread.cpp: Moved the StdLibExtras.h #include -- I did this a while ago to resolve a conflict with winnt.h. I can't remember if it's truly still needed, but what the heck.
  • wtf/StdLibExtras.h: Moved OBJECT_OFFSETOF definition here.
16:02 Changeset [46065] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-17 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix for symbol lookup error.

Move AbstractWorker from SHARED_WORKERS to WORKERS as Worker derives from it now
Changed in http://trac.webkit.org/changeset/46048

  • GNUmakefile.am:
16:01 Changeset [46064] by pkasting@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Tweak some regexes for correctness.

  • Scripts/prepare-ChangeLog: Allow 1-character filenames (my previous change here didn't quite get things right).
  • Scripts/update-webkit: Detect conflicting ChangeLogs correctly by not including any trailing whitespace in the name "ChangeLog", and by normalizing paths before calling basename() to avoid confusing it. (normalizePath() copied from prepare-ChangeLog.)
15:58 Changeset [46063] by jparent@chromium.org
  • 5 edits in trunk/WebCore

2009-07-17 Ryosuke Niwa <ryosuke.niwa@gmail.com>

Reviewed by Eric Seidel.

htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

In order to fix the bug 26816, we need several utility functions be added to htmlediting.cpp

No tests because functions haven't been used anywhere yet.

  • dom/Range.cpp: (WebCore::Range::create): (WebCore::Range::comparePoint): added const qualifier (WebCore::Range::compareNode): added const qualifier
  • dom/Range.h:
  • editing/htmlediting.cpp: (WebCore::unsplittableElementForPosition): find the enclosing unsplittable element (editing root & table cell) (WebCore::positionBeforeNode): added ASSERT(node) (WebCore::positionAfterNode): added ASSERT(node) (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode): (WebCore::createRange): create a range object from two visible positions (WebCore::extendRangeToWrappingNodes): extend range to include nodes that starts and ends at the boundaries (WebCore::canMergeLists): typo (WebCore::indexForVisiblePosition): added const qualifier (WebCore::isVisiblyAdjacent): typo (WebCore::isNodeVisiblyContainedWithin): determine if a node is inside a range or within the visible boundaries of the range
  • editing/htmlediting.h:
15:53 WebKit Team edited by darin@chromium.org
(diff)
15:37 Changeset [46062] by pkasting@chromium.org
  • 18 edits
    34 adds in trunk

LayoutTests:

2009-07-17 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25551
Test suite for the required attribute, the valueMissing flag and new
:required and :optional CSS pseudoclasses.
Part of the HTML5 sec. Forms.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-required

  • fast/css/pseudo-required-optional-001-expected.txt: Added.
  • fast/css/pseudo-required-optional-001.html: Added.
  • fast/css/pseudo-required-optional-002-expected.txt: Added.
  • fast/css/pseudo-required-optional-002.html: Added.
  • fast/css/pseudo-required-optional-003-expected.txt: Added.
  • fast/css/pseudo-required-optional-003.html: Added.
  • fast/css/pseudo-required-optional-004-expected.txt: Added.
  • fast/css/pseudo-required-optional-004.html: Added.
  • fast/css/pseudo-required-optional-005-expected.txt: Added.
  • fast/css/pseudo-required-optional-005.html: Added.
  • fast/css/pseudo-required-optional-006-expected.txt: Added.
  • fast/css/pseudo-required-optional-006.html: Added.
  • fast/forms/ValidityState-valueMissing-001-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-001.html: Added.
  • fast/forms/ValidityState-valueMissing-002-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-002.html: Added.
  • fast/forms/ValidityState-valueMissing-003-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-003.html: Added.
  • fast/forms/ValidityState-valueMissing-004-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-004.html: Added.
  • fast/forms/ValidityState-valueMissing-005-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-005.html: Added.
  • fast/forms/ValidityState-valueMissing-006-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-006.html: Added.
  • fast/forms/ValidityState-valueMissing-007-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-007.html: Added.
  • fast/forms/ValidityState-valueMissing-008-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-008.html: Added.
  • fast/forms/ValidityState-valueMissing-009-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-009.html: Added.
  • fast/forms/required-attribute-001-expected.txt: Added.
  • fast/forms/required-attribute-001.html: Added.
  • fast/forms/required-attribute-002-expected.txt: Added.
  • fast/forms/required-attribute-002.html: Added.

WebCore:

2009-07-17 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25551
Added support for the "required" attribute, the valueMissing flag
to the ValidityState object and :required/:optional CSS pseudoclasses.
Part of HTML5 sec. Forms specs.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-required

Tests: fast/css/pseudo-required-optional-001.html

fast/css/pseudo-required-optional-002.html
fast/css/pseudo-required-optional-003.html
fast/css/pseudo-required-optional-004.html
fast/css/pseudo-required-optional-005.html
fast/css/pseudo-required-optional-006.html
fast/forms/ValidityState-valueMissing-001.html
fast/forms/ValidityState-valueMissing-002.html
fast/forms/ValidityState-valueMissing-003.html
fast/forms/ValidityState-valueMissing-004.html
fast/forms/ValidityState-valueMissing-005.html
fast/forms/ValidityState-valueMissing-006.html
fast/forms/ValidityState-valueMissing-007.html
fast/forms/ValidityState-valueMissing-008.html
fast/forms/ValidityState-valueMissing-009.html
fast/forms/required-attribute-001.html
fast/forms/required-attribute-002.html

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): pseudoRequired/pseudoOptional
  • css/CSSSelector.h: (WebCore::CSSSelector::): ditto
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto
  • dom/Element.h: (WebCore::Element::isOptionalFormControl): check for optional controls (WebCore::Element::isRequiredFormControl): check for required controls
  • html/HTMLAttributeNames.in: required attribute
  • html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::isOptionalFormControl): ditto
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::required): requiredAttr getter (WebCore::HTMLFormControlElement::setRequired): requiredAttr setter
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::valueMissing): method definition
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueMissing): validation code (WebCore::HTMLInputElement::isRequiredFormControl): ditto
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isOptionalFormControl): ditto
  • html/HTMLInputElement.idl: required DOM attribute
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::isOptionalFormControl): ditto
  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::valueMissing): validation code (WebCore::HTMLTextAreaElement::isOptionalFormControl): ditto (WebCore::HTMLTextAreaElement::isRequiredFormControl): ditto
  • html/HTMLTextAreaElement.idl: required DOM attribute
  • html/ValidityState.cpp:
  • html/ValidityState.h: (WebCore::ValidityState::valueMissing): validation flag
15:30 Changeset [46061] by bdakin@apple.com
  • 3 edits in trunk/WebCore

2009-07-17 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27390 CSS custom
cursor hotspots should work in quirks mode

  • and corresponding <rdar://problem/6554340>

Enable hotspots in quirks mode.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):

Update this manual test to reflect the fact that hotspots are now
expected to work in quirks mode.

  • manual-tests/css3-cursor-fallback-quirks.html:
15:11 WikiStart edited by atwilson@chromium.org
Added link to IdlAttributes wiki page. (diff)
15:09 IdlAttributes edited by atwilson@chromium.org
(diff)
15:02 Changeset [46060] by pkasting@chromium.org
  • 19 edits in trunk

JavaScriptCore:

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

WebCore:

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/WebCoreGenerated.vcproj:

WebKit/win:

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/InterfacesGenerated.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

WebKitTools:

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
15:01 WebKit Team edited by japhet@chromium.org
(diff)
14:56 Changeset [46059] by barraclough@apple.com
  • 9 edits
    3 adds in trunk/JavaScriptCore

2009-07-17 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Add YARR support for generic ARM platforms (disabled by default).
https://bugs.webkit.org/show_bug.cgi?id=24986

Add generic ARM port for MacroAssembler. It supports the whole
MacroAssembler functionality except floating point.

The class JmpSrc is extended with a flag which enables to patch
the jump destination offset during execution. This feature is
required for generic ARM port.

Signed off by Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Signed off by Gabor Loki <loki@inf.u-szeged.hu>

  • JavaScriptCore.pri:
  • assembler/ARMAssembler.cpp: Added. (JSC::ARMAssembler::getLdrImmAddress): (JSC::ARMAssembler::linkBranch): (JSC::ARMAssembler::patchConstantPoolLoad): (JSC::ARMAssembler::getOp2): (JSC::ARMAssembler::genInt): (JSC::ARMAssembler::getImm): (JSC::ARMAssembler::moveImm): (JSC::ARMAssembler::dataTransfer32): (JSC::ARMAssembler::baseIndexTransfer32): (JSC::ARMAssembler::executableCopy):
  • assembler/ARMAssembler.h: Added. (JSC::ARM::): (JSC::ARMAssembler::ARMAssembler): (JSC::ARMAssembler::): (JSC::ARMAssembler::JmpSrc::JmpSrc): (JSC::ARMAssembler::JmpSrc::enableLatePatch): (JSC::ARMAssembler::JmpDst::JmpDst): (JSC::ARMAssembler::JmpDst::isUsed): (JSC::ARMAssembler::JmpDst::used): (JSC::ARMAssembler::emitInst): (JSC::ARMAssembler::and_r): (JSC::ARMAssembler::ands_r): (JSC::ARMAssembler::eor_r): (JSC::ARMAssembler::eors_r): (JSC::ARMAssembler::sub_r): (JSC::ARMAssembler::subs_r): (JSC::ARMAssembler::rsb_r): (JSC::ARMAssembler::rsbs_r): (JSC::ARMAssembler::add_r): (JSC::ARMAssembler::adds_r): (JSC::ARMAssembler::adc_r): (JSC::ARMAssembler::adcs_r): (JSC::ARMAssembler::sbc_r): (JSC::ARMAssembler::sbcs_r): (JSC::ARMAssembler::rsc_r): (JSC::ARMAssembler::rscs_r): (JSC::ARMAssembler::tst_r): (JSC::ARMAssembler::teq_r): (JSC::ARMAssembler::cmp_r): (JSC::ARMAssembler::orr_r): (JSC::ARMAssembler::orrs_r): (JSC::ARMAssembler::mov_r): (JSC::ARMAssembler::movs_r): (JSC::ARMAssembler::bic_r): (JSC::ARMAssembler::bics_r): (JSC::ARMAssembler::mvn_r): (JSC::ARMAssembler::mvns_r): (JSC::ARMAssembler::mul_r): (JSC::ARMAssembler::muls_r): (JSC::ARMAssembler::mull_r): (JSC::ARMAssembler::ldr_imm): (JSC::ARMAssembler::ldr_un_imm): (JSC::ARMAssembler::dtr_u): (JSC::ARMAssembler::dtr_ur): (JSC::ARMAssembler::dtr_d): (JSC::ARMAssembler::dtr_dr): (JSC::ARMAssembler::ldrh_r): (JSC::ARMAssembler::ldrh_d): (JSC::ARMAssembler::ldrh_u): (JSC::ARMAssembler::strh_r): (JSC::ARMAssembler::push_r): (JSC::ARMAssembler::pop_r): (JSC::ARMAssembler::poke_r): (JSC::ARMAssembler::peek_r): (JSC::ARMAssembler::clz_r): (JSC::ARMAssembler::bkpt): (JSC::ARMAssembler::lsl): (JSC::ARMAssembler::lsr): (JSC::ARMAssembler::asr): (JSC::ARMAssembler::lsl_r): (JSC::ARMAssembler::lsr_r): (JSC::ARMAssembler::asr_r): (JSC::ARMAssembler::size): (JSC::ARMAssembler::ensureSpace): (JSC::ARMAssembler::label): (JSC::ARMAssembler::align): (JSC::ARMAssembler::jmp): (JSC::ARMAssembler::patchPointerInternal): (JSC::ARMAssembler::patchConstantPoolLoad): (JSC::ARMAssembler::patchPointer): (JSC::ARMAssembler::repatchInt32): (JSC::ARMAssembler::repatchPointer): (JSC::ARMAssembler::repatchLoadPtrToLEA): (JSC::ARMAssembler::linkJump): (JSC::ARMAssembler::relinkJump): (JSC::ARMAssembler::linkCall): (JSC::ARMAssembler::relinkCall): (JSC::ARMAssembler::getRelocatedAddress): (JSC::ARMAssembler::getDifferenceBetweenLabels): (JSC::ARMAssembler::getCallReturnOffset): (JSC::ARMAssembler::getOp2Byte): (JSC::ARMAssembler::placeConstantPoolBarrier): (JSC::ARMAssembler::RM): (JSC::ARMAssembler::RS): (JSC::ARMAssembler::RD): (JSC::ARMAssembler::RN): (JSC::ARMAssembler::getConditionalField):
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::JmpSrc::enableLatePatch):
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Call::enableLatePatch): (JSC::AbstractMacroAssembler::Jump::enableLatePatch):
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM.h: Added. (JSC::MacroAssemblerARM::): (JSC::MacroAssemblerARM::add32): (JSC::MacroAssemblerARM::and32): (JSC::MacroAssemblerARM::lshift32): (JSC::MacroAssemblerARM::mul32): (JSC::MacroAssemblerARM::not32): (JSC::MacroAssemblerARM::or32): (JSC::MacroAssemblerARM::rshift32): (JSC::MacroAssemblerARM::sub32): (JSC::MacroAssemblerARM::xor32): (JSC::MacroAssemblerARM::load32): (JSC::MacroAssemblerARM::load32WithAddressOffsetPatch): (JSC::MacroAssemblerARM::loadPtrWithPatchToLEA): (JSC::MacroAssemblerARM::load16): (JSC::MacroAssemblerARM::store32WithAddressOffsetPatch): (JSC::MacroAssemblerARM::store32): (JSC::MacroAssemblerARM::pop): (JSC::MacroAssemblerARM::push): (JSC::MacroAssemblerARM::move): (JSC::MacroAssemblerARM::swap): (JSC::MacroAssemblerARM::signExtend32ToPtr): (JSC::MacroAssemblerARM::zeroExtend32ToPtr): (JSC::MacroAssemblerARM::branch32): (JSC::MacroAssemblerARM::branch16): (JSC::MacroAssemblerARM::branchTest32): (JSC::MacroAssemblerARM::jump): (JSC::MacroAssemblerARM::branchAdd32): (JSC::MacroAssemblerARM::mull32): (JSC::MacroAssemblerARM::branchMul32): (JSC::MacroAssemblerARM::branchSub32): (JSC::MacroAssemblerARM::breakpoint): (JSC::MacroAssemblerARM::nearCall): (JSC::MacroAssemblerARM::call): (JSC::MacroAssemblerARM::ret): (JSC::MacroAssemblerARM::set32): (JSC::MacroAssemblerARM::setTest32): (JSC::MacroAssemblerARM::tailRecursiveCall): (JSC::MacroAssemblerARM::makeTailRecursiveCall): (JSC::MacroAssemblerARM::moveWithPatch): (JSC::MacroAssemblerARM::branchPtrWithPatch): (JSC::MacroAssemblerARM::storePtrWithPatch): (JSC::MacroAssemblerARM::supportsFloatingPoint): (JSC::MacroAssemblerARM::supportsFloatingPointTruncate): (JSC::MacroAssemblerARM::loadDouble): (JSC::MacroAssemblerARM::storeDouble): (JSC::MacroAssemblerARM::addDouble): (JSC::MacroAssemblerARM::subDouble): (JSC::MacroAssemblerARM::mulDouble): (JSC::MacroAssemblerARM::convertInt32ToDouble): (JSC::MacroAssemblerARM::branchDouble): (JSC::MacroAssemblerARM::branchTruncateDoubleToInt32): (JSC::MacroAssemblerARM::ARMCondition): (JSC::MacroAssemblerARM::prepareCall): (JSC::MacroAssemblerARM::call32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::JmpSrc::enableLatePatch):
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
  • wtf/Platform.h:
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
14:51 WebKit Team edited by agl@chromium.org
(diff)
14:29 Changeset [46058] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=27384
Random crashes in appcache/update-cache.html test

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): Reorder code to avoid using a handle after canceling it.
14:28 WebKit Team edited by jorlow@chromium.org
(diff)
14:17 Changeset [46057] by barraclough@apple.com
  • 3 edits
    1 add in trunk/JavaScriptCore

2009-07-17 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Extend AssemblerBuffer with constant pool handling mechanism.
https://bugs.webkit.org/show_bug.cgi?id=24986

Add a platform independed constant pool framework.
This pool can store 32 or 64 bits values which is enough to hold
any integer, pointer or double constant.

  • assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::putIntUnchecked): (JSC::AssemblerBuffer::putInt64Unchecked): (JSC::AssemblerBuffer::append): (JSC::AssemblerBuffer::grow):
  • assembler/AssemblerBufferWithConstantPool.h: Added. (JSC::):
14:17 Changeset [46056] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

Revert "2009-07-17 Mario Sanchez Prada <msanchez@igalia.com>"

This reverts commit http://trac.webkit.org/changeset/46038 as it breaks two
accessibility/ tests in the mac builds.

14:16 Changeset [46055] by levin@chromium.org
  • 1 edit
    1 add in trunk/WebKitTools

2009-07-17 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

WebKit should have a bash completion script to aid with common commands.
https://bugs.webkit.org/show_bug.cgi?id=27374

  • Scripts/webkit-tools-completion.sh: The script which enables option completion for several WebKit command line scripts.
13:17 IdlAttributes created by atwilson@chromium.org
13:17 Changeset [46054] by pkasting@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Avoid error spew on Macs, and fix a few other tiny details.

  • Scripts/svn-create-patch:
13:13 Changeset [46053] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-17 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=27377
This makes cpplint complain about this for instance:

if (true)
{

int foo;

}

Add the appropriate unit tests.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
13:08 Changeset [46052] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-17 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=27377
Don't filter whitespace at the end of the line. This is not
explicitly a rule of webkit coding style, but there is no reason
not to warn of this common style problem.

Don't filter whitespace newline. Now, cpplint will complain
about the following situation:

if (true) {

doSomething();
doSomethingAgain();

}
else

doSomething();

Which is a webkit coding style rule violation.

  • Scripts/modules/cpplint.py:
13:05 Changeset [46051] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-17 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=27377
Move this comment to where it belongs.

  • Scripts/modules/cpplint_unittest.py:
12:37 Changeset [46050] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Correct crash in WinLauncher due to improper mixing of BSTR
and TCHAR types.
https://bugs.webkit.org/show_bug.cgi?id=27381

  • WinLauncher/WinLauncher.cpp: (loadURL): Perform SysReAllocString to update the BSTR with the contents of the TCHAR string.
12:27 Changeset [46049] by eroman@chromium.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Build fix for non-Darwin.
Add a guard for inclusion of RetainPtr.h which includes CoreFoundation.h

https://bugs.webkit.org/show_bug.cgi?id=27382

  • wtf/unicode/icu/CollatorICU.cpp:
12:11 Changeset [46048] by levin@chromium.org
  • 19 edits in trunk

WebCore:

2009-07-17 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Changed Worker to derive from AbstractWorker, which involved moving
AbstractWorker files from being wrapped by ENABLE_SHARED_WORKERS to
ENABLE_WORKERS.

Removed obsolete functionality from the JS/V8 bindings that is now
inherited from AbstractWorker.

  • WebCore.pro: Moved AbstractWorker files out of SHARED_WORKERS section and into WORKERS.
  • bindings/js/JSAbstractWorkerCustom.cpp: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
  • bindings/js/JSWorkerCustom.cpp: Removed obsolete event listener code (now in base class) (WebCore::JSWorker::mark): No longer need to explicitly mark event listeners (handled by base class).
  • bindings/v8/V8Index.h: Moved AbstractWorker lines out of SHARED_WORKERS section and into WORKERS.
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
  • bindings/v8/custom/V8CustomBinding.h: Moved AbstractWorker lines out of SHARED_WORKERS section and into WORKERS.
  • bindings/v8/custom/V8WorkerCustom.cpp: Removed obsolete event listener code that now lives in the base class. (WebCore::V8WorkerConstructor): Cleaned up legacy style nits.
  • workers/AbstractWorker.cpp: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
  • workers/AbstractWorker.h: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
  • workers/Worker.cpp: Removed event listener code (now in base class). (WebCore::Worker::Worker): Now derives from AbstractWorker. (WebCore::Worker::notifyFinished): Calls dispatchLoadErrorEvent on base class.
  • workers/Worker.h: Removed APIs that now live in the base class.
  • workers/Worker.idl: Now derives from AbstractWorker. Removed APIs that live in the base class, and added a GenerateToJS flag.

LayoutTests:

2009-07-17 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Added checks to make sure that Workers are properly constructed and Worker attributes
are visible on the resulting object.

  • fast/workers/worker-constructor-expected.txt:
  • fast/workers/worker-constructor.html: Added explicit check for correct construction/postMessage visibility.
12:11 Changeset [46047] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-17 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

cpplint should flag usages of NULL.
https://bugs.webkit.org/show_bug.cgi?id=27341

  • Scripts/modules/cpplint.py: Add the check for NULL test and call it. Make the collapse_strings method public.
  • Scripts/modules/cpplint_unittest.py: Add several tests to verify the check for NULL behavior. Adjust existing tests due to the new NULL check:
    1. Several had NULL removed (or were just removed completely).
    2. Two tests now do an assert that allows the caller to check that a particular error is one of several that was returned.
12:11 Changeset [46046] by levin@chromium.org
  • 1 edit
    2 adds in trunk/WebKitTools

2009-07-17 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

Add a parser of patches for linter.
https://bugs.webkit.org/show_bug.cgi?id=27363

Adds a simple parser for unified diff format.

  • Scripts/modules/diff_parser.py: Added.
  • Scripts/modules/diff_parser_unittest.py: Added.
11:41 Changeset [46045] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

11:36 Changeset [46044] by hyatt@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

2009-07-17 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27379
Absolutely-positioned elements with a scrollbar wrap prematurely. Make sure to include
the vertical scrollbar width for overflow:scroll elements.

Added fast/css/positioned-overflow-scroll.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcPrefWidths):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcPrefWidths):

LayoutTests:

2009-07-17 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27379
Absolutely-positioned elements with a scrollbar wrap prematurely. Make sure to include
the vertical scrollbar width for overflow:scroll elements.

  • fast/css/positioned-overflow-scroll.html: Added.
  • platform/mac/fast/css/positioned-overflow-scroll-expected.checksum: Added.
  • platform/mac/fast/css/positioned-overflow-scroll-expected.png: Added.
  • platform/mac/fast/css/positioned-overflow-scroll-expected.txt: Added.
11:32 Changeset [46043] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.6

New tag.

11:21 Changeset [46042] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

Get user default collation order via a CFLocale API when available.

  • wtf/unicode/icu/CollatorICU.cpp: (WTF::Collator::userDefault):
11:01 Changeset [46041] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-07-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Need a DOM_STORAGE guard in DerivedSroucesAllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=27375

In https://bugs.webkit.org/show_bug.cgi?id=27360 I added Storage.cpp
and StorageEvent.cpp. Unfortunately, until later this afternoon,
DOM_STORAGE is not turned on by default in Chromium, and so these two
files are never generated. This breaks the compile.

There are no other instances of guards in the file, which puzzles me...
but I think adding guards is the right way to go about this.

  • bindings/v8/DerivedSourcesAllInOne.cpp: Added the guard.
11:00 Changeset [46040] by treat@webkit.org
  • 8 edits in trunk/WebKit/qt

2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Adam Treat.

Coding style fixes.

  • Api/qcookiejar.cpp: (QCookieJarPrivate::QCookieJarPrivate): (qHash): (QCookieJar::cookieJar):
  • Api/qwebelement.cpp: (QWebElement::functions): (QWebElement::scriptableProperties):
  • Api/qwebframe.cpp: (QWebFrame::metaData): (QWebFrame::scrollBarValue): (QWebFrame::scroll): (QWebFrame::scrollPosition): (QWebFrame::print):
  • Api/qwebnetworkinterface.cpp: (decodePercentEncoding): (QWebNetworkRequestPrivate::init): (QWebNetworkRequestPrivate::setURL): (QWebNetworkRequest::QWebNetworkRequest): (QWebNetworkRequest::operator=): (QWebNetworkRequest::setUrl): (QWebNetworkRequest::setHttpHeader): (QWebNetworkRequest::httpHeaderField): (QWebNetworkRequest::setHttpHeaderField): (QWebNetworkRequest::setPostData): (QWebNetworkJob::setResponse): (QWebNetworkJob::frame): (QWebNetworkManager::add): (QWebNetworkManager::cancel): (QWebNetworkManager::started): (QWebNetworkManager::data): (QWebNetworkManager::finished): (QWebNetworkManager::addHttpJob): (QWebNetworkManager::cancelHttpJob): (QWebNetworkManager::httpConnectionClosed): (QWebNetworkInterfacePrivate::sendFileData): (QWebNetworkInterfacePrivate::parseDataUrl): (QWebNetworkManager::doWork): (QWebNetworkInterface::setDefaultInterface): (QWebNetworkInterface::defaultInterface): (QWebNetworkInterface::QWebNetworkInterface): (QWebNetworkInterface::addJob): (QWebNetworkInterface::cancelJob): (WebCoreHttp::WebCoreHttp): (WebCoreHttp::request): (WebCoreHttp::scheduleNextRequest): (WebCoreHttp::getConnection): (WebCoreHttp::onResponseHeaderReceived): (WebCoreHttp::onReadyRead): (WebCoreHttp::onRequestFinished): (WebCoreHttp::onAuthenticationRequired): (WebCoreHttp::onProxyAuthenticationRequired):
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::mouseReleaseEvent): (QWebPagePrivate::inputMethodEvent): (QWebPagePrivate::shortcutOverrideEvent): (QWebPage::inputMethodQuery): (QWebPage::javaScriptPrompt): (QWebPage::updatePositionDependentActions): (QWebPage::userAgentForUrl): (QWebPagePrivate::_q_onLoadProgressChanged): (QWebPage::totalBytes): (QWebPage::bytesReceived):
  • Api/qwebsettings.cpp: (QWebSettings::iconForUrl): (QWebSettings::setObjectCacheCapacities):
  • Api/qwebview.cpp: (QWebView::paintEvent): (QWebView::changeEvent):
10:53 Changeset [46039] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-07-17 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26496

Let WebCore always enforce the connection-per-host limit itself.

  • loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests):
09:48 Changeset [46038] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-07-17 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25524
[Gtk] Expose the title attribute to assistive technologies

Expose 'alt' attribute from images as accessible name.
Expose the 'title' core HTML attribute as accessible description.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::accessibilityDescription):
09:41 Changeset [46037] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

Some transitions don't work correctly on Leopard
https://bugs.webkit.org/show_bug.cgi?id=27356

We only have code to do component animation using valueFunction.
So on Leopard we always need to do matrix animation in hardware.
This fix ensures that.

This is currently not testable because it appears only in the
hardware animation and we can't yet do pixel tests while
hardware animating.

08:56 Changeset [46036] by zecke@webkit.org
  • 2 edits in trunk/WebKitTools

[GTK+] Make TestNescpaePlugin loadable in mozilla

https://bugs.webkit.org/show_bug.cgi?id=27345

Currently the NPNetscapeFuncs of WebKit contains two more
entries than the gecko version. This means comparing the
aMozillaVTable->size with the size of NPNetscpaeFuncs will
fail and the plugin will not be loaded.

For testing it is nice to be able to load the plugin into
gecko and currently we are not using the two extra methods.
Remove the test to be able to use the plugin in gecko.

07:48 Changeset [46035] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-07-17 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by NOBODY (OOPS!).

[GTK+] Crash in screenAvailable due a null Widget*

JSDOMWindow::open called screenAvailableRect(0). The other
Screen methods can be called with a null widget as well, fix the
crashing test by checking for null.

In screenRect and screenAvailableRect it is not tried to use
a default screen as the existing implementation didn't try either
in case of not having a toplevel widget.

LayoutTests/fast/frames/crash-removed-iframe.html caused a crash.

  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): New method to get a visual or return zero. (WebCore::screenDepth): Use getVisual. (WebCore::screenDepthPerComponent): Use getVisual. (WebCore::screenIsMonochrome): Use screenDepth which will do the null checking (WebCore::screenRect): Check for !widget. (WebCore::screenAvailableRect): Check for !widget.
07:44 Changeset [46034] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Remove tests from Qt Skipped list that are actually working.
https://bugs.webkit.org/show_bug.cgi?id=27316

  • platform/qt/Skipped:
07:09 Changeset [46033] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-17 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Simon Hausmann.

Something about having a single TAB in a style checking tool like this
is equivalent to nails on a chalk board to me...

  • Scripts/modules/cpplint.py:
06:56 Changeset [46032] by hausmann@webkit.org
  • 4 edits in trunk

JavaScriptCore:

2009-07-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix the include path for the Symbian port
https://bugs.webkit.org/show_bug.cgi?id=27358

WebCore:

2009-07-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix the include path for the Symbian port
https://bugs.webkit.org/show_bug.cgi?id=27358

  • WebCore.pro:
06:34 Changeset [46031] by hausmann@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix a small typo in the changelog

06:32 Changeset [46030] by hausmann@webkit.org
  • 7 edits in trunk

WebCore:

2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Make it possible to set the plugin directories from the DRT.
Part of https://bugs.webkit.org/show_bug.cgi?id=27215

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::installedPlugins): Now optionally takes a populate argument, so we can avoid loading system plugins from the DRT and thus avoid their strerr errors that can make tests fail. (WebCore::PluginDatabase::clear): Make is possible to clear the database. Called from setPluginDirectories.
  • plugins/PluginDatabase.h: (WebCore::PluginDatabase::setPluginDirectories): Make public

WebKit/qt:

2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Overwrite the plugin directories for the DRT.
Part of https://bugs.webkit.org/show_bug.cgi?id=27215

  • Api/qwebpage.cpp: (qt_drt_overwritePluginDirectories): Only set the plugin directories to the ones in the QTWEBKIT_PLUGIN_PATH environment variable.

WebKitTools:

2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Overwrite the plugin directories for the DRT.
Part of https://bugs.webkit.org/show_bug.cgi?id=27215

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
05:43 Changeset [46029] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

PluginViewMac: Stop the plugin when loading fails

Also, prevent event propagation when in the stopped state

  • plugins/mac/PluginViewMac.cpp:
05:40 Changeset [46028] by vestbo@webkit.org
  • 4 edits in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

PluginViewMac: Allow query and set of drawing and event models

We now support querying and setting of the drawing and event model,
but we still only support the CoreGraphics drawing model, and the
Carbon event model.

If unsupported drawing or event models are detected we show the
missing-plugin icon.

  • plugins/PluginView.cpp:
  • plugins/PluginView.h:
  • plugins/mac/PluginViewMac.cpp:
05:17 Changeset [46027] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Initialize two PluginView members using memset

m_npWindow is used on all platforms, not just for XP_UNIX,
so always initialize it. m_npCgContext on the other hand
is only used for XP_MACOSX.

  • plugins/PluginView.cpp:
04:46 Changeset [46026] by vestbo@webkit.org
  • 6 edits in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Add more debug logging in PluginView

  • plugins/PluginView.cpp: Add debug for setValue
  • plugins/gtk/PluginViewGtk.cpp: Add debug for getValue
  • plugins/mac/PluginViewMac.cpp: Add debug for getValue and more
  • plugins/qt/PluginViewQt.cpp: Add debug for getValue
  • plugins/win/PluginViewWin.cpp: Add debug for getValue
04:00 Changeset [46025] by levin@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-07-17 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by David Levin.

Build fix on platforms don't have MMAP.
https://bugs.webkit.org/show_bug.cgi?id=27365

  • interpreter/RegisterFile.h: Including stdio.h irrespectively of HAVE(MMAP)
03:52 Changeset [46024] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Holger Freyther.

Use same license in PluginDebug.cpp as in the original PluginDebug.h

  • plugins/PluginDebug.cpp: Use license from PluginDebug.h
03:35 Changeset [46023] by vestbo@webkit.org
  • 7 edits
    1 add in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Add more debugging functionality for the WebCore NPAPI layer

  • GNUmakefile.am: Add PluginDebug.cpp
  • WebCore.gypi: Add PluginDebug.cpp
  • WebCore.pro: Add PluginDebug.cpp
  • WebCore.vcproj/WebCore.vcproj: Add PluginDebug.cpp
  • WebCoreSources.bkl: Add PluginDebug.cpp
  • plugins/PluginDebug.h: Move errorStrings to PluginDebug.cpp
  • plugins/PluginDebug.cpp: New file
00:42 Changeset [46022] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by David Levin.

Fix Chromium build with DOM_STORAGE enabled.
https://bugs.webkit.org/show_bug.cgi?id=27360

2 minor changes as noted below:

  • bindings/v8/DerivedSourcesAllInOne.cpp: Add the generated .cpp files.
  • storage/StorageAreaImpl.cpp: #include "DOMWindow.h"
00:42 Changeset [46021] by levin@chromium.org
  • 15 edits in trunk

2009-07-16 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

Add --web-sockets flag and ENABLE_WEB_SOCKETS define.
https://bugs.webkit.org/show_bug.cgi?id=27206

.:

Add --enable-web-sockets in configure.ac

  • configure.ac:

JavaScriptCore:

Add ENABLE_WEB_SOCKETS

  • Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS

WebCore:

Add ENABLE_WEB_SOCKETS

  • Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS
  • GNUmakefile.am: add ENABLE_WEB_SOCKETS
  • WebCore.vcproj/WebCoreCommon.vsprops: add ENABLE_WEB_SOCKETS
  • WebCore.vcproj/build-generated-files.sh: add ENABLE_WEB_SOCKETS

WebKit/mac:

Add ENABLE_WEB_SOCKETS

  • Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS

WebKit/win:

Add ENABLE_WEB_SOCKETS

  • WebKit.vcproj/WebKit.vcproj: add ENABLE_WEB_SOCKETS

WebKitTools:

Add --web-sockets flag.

  • Scripts/build-webkit: add --web-sockets flag.
Note: See TracTimeline for information about the timeline view.