Timeline


and

07/22/09:

23:45 WebDevelopers edited by dbates@berkeley.edu
Removed outdated links to Safari version matrix, and FAQ. (diff)
23:32 Changeset [46255] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-22 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[V8] Make Node wrappers go fast
https://bugs.webkit.org/show_bug.cgi?id=27597

Profiles indicate we're spending a lot of time asking whether we're on
the main thread when looking up DOM wrappers for Nodes, but there isn't
much point in doing that work because Nodes only exist on the main
thread. I've also added an assert to keep us honest in this regard.

  • bindings/v8/V8DOMMap.cpp: (WebCore::): (WebCore::getDOMNodeMap): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getCurrentMainThread):
22:39 Changeset [46254] by sfalken@apple.com
  • 1 edit
    6 adds in trunk/WebKitTools

Checkpoint new Windows nightly launcher.


Reviewed by Mark Rowe.

  • WebKitLauncherWin: Added.
  • WebKitLauncherWin/Resource.h: Added.
  • WebKitLauncherWin/WebKitLauncherWin.cpp: Added. (getStringValue): Retrieve a string registry value. (applePathFromRegistry): Get an Apple-related path out of the registry. (copyEnvironmentVariable): Copy an environment variable. (safariInstallDir): Helper function to get the install directory for Safari. (safariBrowserExe): Helper function to get the full path of the Safari executable. (_tWinMain): Locate Safari and launch it after setting up an environment variable.
  • WebKitLauncherWin/WebKitLauncherWin.h: Added.
  • WebKitLauncherWin/WebKitLauncherWin.rc: Added.
  • WebKitLauncherWin/WebKitLauncherWin.vcproj: Added.
  • WebKitLauncherWin/webkit.ico: Added.
19:52 Changeset [46253] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-22 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove unneeded virtual destructor from ScriptSourceProvider
https://bugs.webkit.org/show_bug.cgi?id=27563

  • bindings/js/ScriptSourceProvider.h:
19:29 Changeset [46252] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

REGRESSION (r46240): /fast/css/getComputedStyle/computed-style & computed-style-without-renderer needs rebaseline for Windows
https://bugs.webkit.org/show_bug.cgi?id=27591

Rebaselines the tests.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
19:01 Changeset [46251] by rniwa@webkit.org
  • 7 edits
    8 adds in trunk

WebCore:

2009-07-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
https://bugs.webkit.org/show_bug.cgi?id=27476

executeStrikethrough and executeUnderline were toggling between "line-through" / "underline" and "none".
This patch adds executeToggleStyleInList that toggles a style in CSSValueList instead of toggling the entire value.
It modifies CSSComputedStyleDeclaration to return CSSValueList instead of CSSPrimitiveValue for text decorations,
and adds removeAll member function to CSSValueList.

Tests: editing/execCommand/toggle-text-decorations.html

fast/css/getComputedStyle/getComputedStyle-text-decoration.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::renderTextDecorationFlagsToCSSValue): Creates a CSSValueList (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Returns a CSSValueList instead of CSSValue
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Text decorations are space separated instead of comma separated
  • css/CSSValueList.cpp: (WebCore::CSSValueList::removeAll): Removes all values that match the specified value
  • css/CSSValueList.h:
  • editing/EditorCommand.cpp: (WebCore::applyCommandToFrame): Apply style to a frame using specified command (WebCore::executeApplyStyle): Uses applyCommandToFrame (WebCore::executeToggleStyleInList): Uses applyCommandToFrame (WebCore::executeToggleStyle): Toggles a style in CSSValueList (WebCore::executeStrikethrough): Uses executeToggleStyleInList (WebCore::executeUnderline): Uses executeToggleStyleInList

LayoutTests:

2009-07-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
https://bugs.webkit.org/show_bug.cgi?id=27476

toggle-text-decorations checks whether we can toggle text decorations with multiple styles properly.
e.g. execCommand("underline") should modify "text-decoration: underline overline" to "text-decoration: overline"

getComputedStyle-text-decorations checks whether the CSS value of text decoration and its computed style are
both space-separated CSSValueList instead of CSSPrimitiveValue or comma-separated CSSValueList.

  • editing/execCommand/resources/toggle-text-decorations.js: Added. (testSingleToggle):
  • editing/execCommand/toggle-text-decorations-expected.txt: Added.
  • editing/execCommand/toggle-text-decorations.html: Added.
  • fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-text-decoration.html: Added.
  • fast/css/getComputedStyle/resources: Added.
  • fast/css/getComputedStyle/resources/TEMPLATE.html: Added.
  • fast/css/getComputedStyle/resources/getComputedStyle-text-decoration.js: Added. (expect):
16:27 Changeset [46250] by abarth@webkit.org
  • 4 edits
    9 adds in trunk

2009-07-22 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27174
And
https://bugs.webkit.org/show_bug.cgi?id=26938

Tests prevention of attacks transformed by PHP Magic Quotes/PHP addslashes().

  • http/tests/security/xssAuditor/resources/echo-intertag-addslashes.pl: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-backslash.html: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-null-char.html: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html: Added.

2009-07-22 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27174
And
https://bugs.webkit.org/show_bug.cgi?id=26938

Code cleanup. Implements support for detecting attacks transformed by
PHP Magic Quotes/PHP addslashes().

Tests: http/tests/security/xssAuditor/script-tag-addslashes-backslash.html

http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html
http/tests/security/xssAuditor/script-tag-addslashes-null-char.html
http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html

  • page/XSSAuditor.cpp: (WebCore::isInvalidCharacter): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::normalize): Decodes HTML entities, removes backslashes, and removes control characters that could otherwise cause a discrepancy between the source code of a script and the outgoing HTTP parameters. (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::decodeHTMLEntities): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h:
15:48 Changeset [46249] by levin@chromium.org
  • 1 edit
    1 move in trunk/WebKitTools

2009-07-22 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

run-webkit-lint should be named check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=27568

This name better reflects the fact that it is about checking the style of files.

  • Scripts/check-webkit-style: Renamed from WebKitTools/Scripts/run-webkit-lint.
15:31 Changeset [46248] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Fix false positives in namespace indentation checks.
https://bugs.webkit.org/show_bug.cgi?id=27567

The regular expression detecting goto labels (in order
to skip those) was too permissive, which caused other
code like "Foo::Bar()" to be treated as a label too,
thereby not stopping the processing loop as expected.

Now comes with a stricter regexp, and more demanding
test cases to check for these issues.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
15:17 Changeset [46247] by barraclough@apple.com
  • 15 edits in trunk/JavaScriptCore

2009-07-22 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

With ENABLE(ASSEMBLER_WX_EXCLUSIVE), only change permissions once per repatch event.
( https://bugs.webkit.org/show_bug.cgi?id=27564 )

Currently we change permissions forwards and backwards for each instruction modified,
instead we should only change permissions once per complete repatching event.

2.5% progression running with ENABLE(ASSEMBLER_WX_EXCLUSIVE) enabled,
which recoups 1/3 of the penalty of running with this mode enabled.

  • assembler/ARMAssembler.cpp: (JSC::ARMAssembler::linkBranch):
    • Replace usage of MakeWritable with cacheFlush.


  • assembler/ARMAssembler.h: (JSC::ARMAssembler::patchPointerInternal): (JSC::ARMAssembler::repatchLoadPtrToLEA):
    • Replace usage of MakeWritable with cacheFlush.
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::relinkJump): (JSC::ARMv7Assembler::relinkCall): (JSC::ARMv7Assembler::repatchInt32): (JSC::ARMv7Assembler::repatchPointer): (JSC::ARMv7Assembler::repatchLoadPtrToLEA): (JSC::ARMv7Assembler::setInt32):
    • Replace usage of MakeWritable with cacheFlush.
  • assembler/LinkBuffer.h: (JSC::LinkBuffer::performFinalization):
    • Make explicit call to cacheFlush.
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodeRef::MacroAssemblerCodeRef):
    • Make size always available.
  • assembler/RepatchBuffer.h: (JSC::RepatchBuffer::RepatchBuffer): (JSC::RepatchBuffer::~RepatchBuffer):
    • Add calls to MakeWritable & makeExecutable.
  • assembler/X86Assembler.h: (JSC::X86Assembler::relinkJump): (JSC::X86Assembler::relinkCall): (JSC::X86Assembler::repatchInt32): (JSC::X86Assembler::repatchPointer): (JSC::X86Assembler::repatchLoadPtrToLEA):
    • Remove usage of MakeWritable.
  • bytecode/CodeBlock.h: (JSC::CodeBlock::getJITCode):
    • Provide access to CodeBlock's JITCode.
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::makeExecutable): (JSC::ExecutableAllocator::cacheFlush):
    • Remove MakeWritable, make cacheFlush public.
  • jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress): (JSC::JIT::privateCompile): (JSC::JIT::unlinkCall): (JSC::JIT::linkCall):
    • Add CodeBlock argument to RepatchBuffer.
  • jit/JIT.h:
    • Pass CodeBlock argument for use by RepatchBuffer.
  • jit/JITCode.h: (JSC::JITCode::start): (JSC::JITCode::size):
    • Provide access to code start & size.
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchMethodCallProto): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
    • Add CodeBlock argument to RepatchBuffer.
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
    • Pass CodeBlock argument for use by RepatchBuffer.
15:12 Changeset [46246] by oliver@apple.com
  • 2 edits in trunk/WebCore

Null deref in JSObject::mark due to null xhr wrapper
https://bugs.webkit.org/show_bug.cgi?id=27565

Reviewed by Adele Peterson.

Make event target binding for appcache and xhr behave in the same way as
it does for all other events.

No test as I couldn't make a testcase which was remotely reliable.

15:10 Changeset [46245] by levin@chromium.org
  • 4 edits in trunk

2009-07-22 Takeshi Yoshino <tyoshino@google.com>

Reviewed by Darin Adler.

VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp
https://bugs.webkit.org/show_bug.cgi?id=26375

WebKit/win:

Replace a multiplication sign (U+00D7) encoded in UTF-8 (0xC3 0x97) in WebCoreLocalizedStrings.cpp
with hex escape sequences.

VC2005 failed to build due to this raw UTF-8 data in source code. Here's the warning message (
treated as an error and stopped build).

WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that cannot be
represented in the current code page (932). Save the file in Unicode format to prevent data loss

A change on WebKitTools/Scripts/extract-localizable-strings is attached to this change not to break
localized string generation process.

  • WebCoreLocalizedStrings.cpp: (WebCore::imageTitle):

WebKitTools:

Make it able to use hexadecimal escape sequences in .*UI_STRING(_KEY)? macros. Now,
the extract-localizable-strings script unescapes hexadecimal escape sequences in string literals
in the macros before writing out them into the file to update.

By this fix, we can eliminate raw UTF-8 strings in source code while using raw UTF-16 big endian
strings in the Localizable.strings file.

Bonus: There's no longer extract-webkit-localizable-strings script. Fix usage message to guide
users to update-webkit-localizable-strings.

  • Scripts/extract-localizable-strings:
15:09 Changeset [46244] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-22 Shinichiro Hamaji <hamaji@google.com>

Reviewed by David Levin.

Tiny typo fixes for cpplint.py
https://bugs.webkit.org/show_bug.cgi?id=27530

  • Scripts/modules/cpplint.py:
15:09 Changeset [46243] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-22 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

run-webkit-lint checks code which are not changed
https://bugs.webkit.org/show_bug.cgi?id=27529

Add check if the line is newly added.

  • Scripts/run-webkit-lint:
15:09 Changeset [46242] by levin@chromium.org
  • 4 edits in trunk/WebKitTools

2009-07-22 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

run-webkit-lint should have --git-commit option
https://bugs.webkit.org/show_bug.cgi?id=27528

  • Scripts/modules/cpplint.py:
  • Scripts/run-webkit-lint:
15:09 Changeset [46241] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-22 Mads Ager <ager@chromium.org>

Reviewed by David Levin.

Inform V8 of the amount of WebCore string memory it is keeping alive.
https://bugs.webkit.org/show_bug.cgi?id=27537

V8 uses external strings that are backed by WebCore strings. Since
the external strings themselves are small, V8 has no way of
knowing how much memory it is actually holding on to. With this
change, we inform V8 of the amount of WebCore string data it is
holding on to with external strings.

  • bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource):
14:59 Changeset [46240] by hyatt@apple.com
  • 15 edits
    12 adds in trunk

WebCore:

2009-07-22 David Hyatt <hyatt@apple.com>

Reviewed by Beth Dakin.

https://bugs.webkit.org/show_bug.cgi?id=27562
Add the finalized versions of background-clip and background-origin. Remove background-clip from
the background shorthand and have it be auto-set based off background-origin's value.

Three new tests added in fast/backgrounds/size

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::parseFillProperty):
  • css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSValueKeywords.in:

LayoutTests:

2009-07-22 David Hyatt <hyatt@apple.com>

Reviewed by Beth Dakin.

https://bugs.webkit.org/show_bug.cgi?id=27562
Add some new layout tests that drop the prefix from the background properties and use origin
in a shorthand. Update shorthand results and computed style results to account for new properties.

  • fast/backgrounds/size/backgroundSize20.html: Added.
  • fast/backgrounds/size/backgroundSize21.html: Added.
  • fast/backgrounds/size/backgroundSize22.html: Added.
  • fast/css/background-position-serialize-expected.txt:
  • fast/css/remove-shorthand-expected.txt:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt: Added.
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/inspector/style-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
14:47 Changeset [46239] by jorlow@chromium.org
  • 16 edits
    3 adds in trunk

WebCore:

2009-07-22 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

Hook up V8 bindings for DataGrid elements.
https://bugs.webkit.org/show_bug.cgi?id=27383
http://code.google.com/p/chromium/issues/detail?id=16730

Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.

  • WebCore.gypi: Added new source files.
  • bindings/scripts/CodeGeneratorV8.pm: Made GenerateBatchedAttributeData put #if's around conditional attributes.
  • bindings/v8/DOMObjectsInclude.h: #include DataGrid headers.
  • bindings/v8/V8DOMWrapper.cpp: Add bindings from HTML tags to datagrid templates. (WebCore::V8DOMWrapper::getTemplate): Customize datagrid template.
  • bindings/v8/V8DataGridDataSource.cpp: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::V8DataGridDataSource): (WebCore::V8DataGridDataSource::~V8DataGridDataSource):
  • bindings/v8/V8DataGridDataSource.h: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::create): (WebCore::V8DataGridDataSource::isJSDataGridDataSource): (WebCore::V8DataGridDataSource::jsDataSource): (WebCore::asV8DataGridDataSource):
  • bindings/v8/V8GCController.h: Added new handle type "DATASOURCE".
  • bindings/v8/V8Index.h: Conditionalize datagrid stuff.
  • bindings/v8/custom/V8CustomBinding.h: Declare more accessors. Conditionalize.
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Fill in dataSource accessors. (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):

LayoutTests:

2009-07-22 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

Hook up V8 bindings for DataGrid elements.
https://bugs.webkit.org/show_bug.cgi?id=27383
http://code.google.com/p/chromium/issues/detail?id=16730

Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.

  • fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
13:46 Changeset [46238] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2009-07-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

pushDownTextDecorationStyleAroundNode needs clean up
https://bugs.webkit.org/show_bug.cgi?id=27556

Cleaned up. pushDownTextDecorationStyleAroundNode traverses tree vertically from highestAncestor to targetNode
While traversing, it will apply the specified style to all nodes but targetNode.
i.e. the style is applies to all ancestor nodes and their siblings of targetNode.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Cleaned up and added comments
  • editing/ApplyStyleCommand.h: Updated prototype
13:35 Changeset [46237] by pkasting@chromium.org
  • 4 edits in trunk/WebCore

2009-07-22 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Handle any type of line endings in WebCore/css/*CSSPropertyNames.in.

  • DerivedSources.make:
  • css/makeprop.pl:
  • css/makevalues.pl:
13:32 Changeset [46236] by pkasting@chromium.org
  • 4 edits in trunk/WebKitTools

2009-07-22 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Factor svn-create-patch's "determineSvnRoot()" into a function in
VCSUtils.pm so commit-log-editor can use it too.

  • Scripts/VCSUtils.pm: Add determineSVNRoot().
  • Scripts/commit-log-editor: Use determineSVNRoot() instead of old code (which didn't work as well).
  • Scripts/svn-create-patch: Remove determineSvnRoot() (moved).
13:18 Changeset [46235] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

Revert bugfix for 27557 as this is invalid according to Darin Adler
who states that include order sorting should be case-sensitive.

13:06 Changeset [46234] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-22 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

expand prototype-inheritance test to cover constructors
https://bugs.webkit.org/show_bug.cgi?id=27547

  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/resources/prototype-inheritance.js:
13:05 Changeset [46233] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Case-insensitive comparison of include file order for cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27557

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
13:00 Changeset [46232] by ggaren@apple.com
  • 5 edits
    1 add in branches/nitro-extreme/WebCore

2009-07-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Removed some trivial differences between the branch and r45633, to
facilitate the merge.

  • bindings/js/ScriptEventListener.cpp:
  • bridge/c/c_instance.cpp:
  • inspector/front-end/Images/resourcesSilhouette.png: Added.
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::paintObject):
  • rendering/RenderDataGrid.h:
12:51 Changeset [46231] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Fix cpplint generating false positives for
"primary" includes in headers.
https://bugs.webkit.org/show_bug.cgi?id=27553

Doing so by only flagging includes in header files
as primary when the include filename exactly matches
the header filename.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
12:24 Changeset [46230] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

cpplint generates false positives for primary includes
https://bugs.webkit.org/show_bug.cgi?id=27544

Fix false positives for instances when cpplint would
normally classify multiple includes as primary: After
the first primary include, classify subsequent ones as
"other" includes even if they look like primary ones.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
11:55 Changeset [46229] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-22 Paul Godavari <paul@chromium.org>

Reviewed by Darin Fisher.

Chromium has a build break after removal of JSRGBColor bindings
https://bugs.webkit.org/show_bug.cgi?id=27548

Fix a build break in Chromium V8 after the JSRGBColor bindings change:
https://bugs.webkit.org/show_bug.cgi?id=27242

  • bindings/scripts/CodeGeneratorV8.pm:
11:46 Changeset [46228] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-22 Gabor Rapcsanyi <rapcsanyi.gabor@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Pass XAUTHORITY environment variable to $dumpTool as well.

  • Scripts/run-webkit-tests:
10:02 Changeset [46227] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-07-20 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r39185): Safari adds ".jpeg" extension to images that already have ".JPG" extension
https://bugs.webkit.org/show_bug.cgi?id=27472

  • WebView/WebHTMLView.mm: (matchesExtensionOrEquivalent): Changed category method into a C function. Made it require the leading dot when checking for the extension and do it in a non-case-sensitive way. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Changed to call the function.
09:56 Changeset [46226] by agl@chromium.org
  • 3 edits in trunk/WebCore

2009-07-22 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: add static functions to FontPlatformData which allow
for setting the global font rendering preferences.

https://bugs.webkit.org/show_bug.cgi?id=27513
http://code.google.com/p/chromium/issues/detail?id=12179

This should not affect any layout tests.

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setHinting): (WebCore::FontPlatformData::setAntiAlias): (WebCore::FontPlatformData::setSubpixelGlyphs): (WebCore::FontPlatformData::setupPaint):
  • platform/graphics/chromium/FontPlatformDataLinux.h:
08:20 Changeset [46225] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Add check for correct wtf includes to cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27524

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
08:15 Changeset [46224] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by David Levin.

Add checks for multi-line boolean operator placement.
https://bugs.webkit.org/show_bug.cgi?id=27496

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
07:13 Changeset [46223] by zecke@webkit.org
  • 2 edits in trunk/WebKitSite

2009-07-22 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam Treat.

Mention the new webkit-help and webkit-jobs mailinglist. Change
the description of webkit-dev to be more strict.

  • contact.html:
06:34 Changeset [46222] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-22 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Move Inspector panels creation into a function to make possible introducing
custom panels.

06:33 Changeset [46221] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Remove unused variables.

  • webkit/webkitwebview.cpp: (webkit_web_view_grab_focus): (webkit_web_view_focus_in_event):
06:30 Changeset [46220] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-07-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Print console command message upon evaluate
selection request; Handle errors in evaluation request
properly.

https://bugs.webkit.org/show_bug.cgi?id=27535

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
06:04 Changeset [46219] by kenneth@webkit.org
  • 2 edits in trunk/WebKitSite

2009-07-22 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Adam Treat.

Coding style - Clarify some cases with spacing
https://bugs.webkit.org/show_bug.cgi?id=27499

Add explicit rule about no space before comma or semicolon.

  • coding/coding-style.html:
00:47 WebKit Team edited by rniwa@webkit.org
(diff)
00:46 WebKit Team edited by rniwa@webkit.org
(diff)
00:17 Changeset [46218] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-22 Xan Lopez <xlopez@igalia.com>

Attempt to fix the GTK+ build.

  • GNUmakefile.am:

07/21/09:

23:54 Changeset [46217] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Qt build.

  • WebCore.pro: Add RGBColor.cpp to the build, remove JSRGBColor.
23:19 Changeset [46216] by abarth@webkit.org
  • 9 edits
    1 add in trunk/WebCore

2009-07-21 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27494

Fixes an issue that can cause a crash or unexpected behavior when calling
WebCore::ScriptSourceCode::source on a cached script.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/CachedScriptSourceProvider.h: Modified to inherit from WebCore::ScriptSourceCode. (WebCore::CachedScriptSourceProvider::source): (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): Separated out source provider and rewrote to use WebCore::ScriptSourceProvider. (WebCore::ScriptSourceCode::source):
  • bindings/js/ScriptSourceProvider.h: Added. (WebCore::ScriptSourceProvider::ScriptSourceProvider): (WebCore::ScriptSourceProvider::~ScriptSourceProvider):
  • bindings/js/StringSourceProvider.h: Modified to inherit from WebCore::ScriptSourceCode. (WebCore::StringSourceProvider::StringSourceProvider):
22:31 Changeset [46215] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-21 Sam Weinig <sam@webkit.org>

Another attempt to fix the Windows build.

  • WebCore.vcproj/WebCore.vcproj:
22:19 Changeset [46214] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-21 Sam Weinig <sam@webkit.org>

Attempt to fix the Windows build.

  • DerivedSources.cpp:
22:17 Changeset [46213] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-21 Sam Weinig <sam@webkit.org>

Attempt to fix the GTK build

  • GNUmakefile.am:
22:04 Changeset [46212] by weinig@apple.com
  • 4 edits
    1 delete in trunk/WebCore

2009-07-21 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Autogenerate Objective-C binding implementation for RGBColor.

No functionality change.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMRGBColor.mm: Removed.
  • bindings/scripts/CodeGeneratorObjC.pm: Add logic to convert from WebCore::Color to NSColor*.
  • css/RGBColor.idl:
21:27 Changeset [46211] by weinig@apple.com
  • 28 edits
    2 deletes in trunk

WebCore:

2009-07-21 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27242
JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor

Move the JSC and Objective-C bindings onto using the RGBColor object instead
of just an unsigned int. The JSC bindings are now completely autogenerated for
this class. (Also removes the last lut from WebCore).

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSRGBColor.cpp: Removed.
  • bindings/js/JSRGBColor.h: Removed.
  • bindings/objc/DOM.mm: (-[DOMRGBColor _color]):
  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor alpha]): (-[DOMRGBColor color]):
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseColor):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getRGBColorValue):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getRGBA32Value):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • css/RGBColor.cpp: (WebCore::RGBColor::alpha):
  • css/RGBColor.h: (WebCore::RGBColor::color): (WebCore::RGBColor::RGBColor):
  • css/RGBColor.idl:
  • page/DOMWindow.idl:
  • svg/SVGColor.cpp: (WebCore::SVGColor::rgbColor):
  • svg/SVGColor.h:

LayoutTests:

2009-07-21 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Changes for https://bugs.webkit.org/show_bug.cgi?id=27242
JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/wrapper-classes-expected.txt:
  • fast/js/global-constructors-expected.txt:
21:03 Changeset [46210] by barraclough@apple.com
  • 5 edits
    3 adds in trunk

JavaScriptCore:

2009-07-21 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Cache not only the structure of the method, but the
structure of its prototype as well.
https://bugs.webkit.org/show_bug.cgi?id=27077

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock):
  • bytecode/CodeBlock.h: (JSC::MethodCallLinkInfo::MethodCallLinkInfo):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::patchMethodCallProto):

LayoutTests:

2009-07-21 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Gavin Barraclough, RS olliej fix to make the test pass.

Check whether a crash happens after the string
prototype is overwritten twice. The JIT'ed code
may crash if one of its already cached method
called again. Note: This test is not necessary
crash on all systems, because they use different
memory allocators!
https://bugs.webkit.org/show_bug.cgi?id=27077

  • fast/js/method-check-expected.txt: Added.
  • fast/js/method-check.html: Added.
  • fast/js/resources/method-check.js: Added. (func2): (func.String.prototype.a): (func.String.prototype.b): (func):
20:24 Changeset [46209] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

2009-07-21 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Move call linking / repatching down from AbstractMacroAssembler into MacroAssemblerARCH classes.
( https://bugs.webkit.org/show_bug.cgi?id=27527 )

This allows the implementation to be defined per architecture. Specifically this addresses the
fact that x86-64 MacroAssembler implements far calls as a load to register, followed by a call
to register. Patching the call actually requires the pointer load to be patched, rather than
the call to be patched. This is implementation detail specific to MacroAssemblerX86_64, and as
such is best handled there.

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::linkCall): (JSC::MacroAssemblerARM::repatchCall):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::linkCall): (JSC::MacroAssemblerARMv7::repatchCall):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::linkCall): (JSC::MacroAssemblerX86::repatchCall):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::linkCall): (JSC::MacroAssemblerX86_64::repatchCall):
19:42 Changeset [46208] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Correct relative path in the test after moving it.

  • platform/mac/fast/loader/non-html-load-event.html:
19:39 Changeset [46207] by mitz@apple.com
  • 2 edits
    2 moves in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

Move fast/loader/non-html-load-event.html under platform/mac because
non-HTML views exist only on Mac.

  • fast/loader/non-html-load-event-expected.txt: Removed.
  • fast/loader/non-html-load-event.html: Removed.
  • platform/mac/fast/loader/non-html-load-event-expected.txt: Copied from LayoutTests/fast/loader/non-html-load-event-expected.txt.
  • platform/mac/fast/loader/non-html-load-event.html: Copied from LayoutTests/fast/loader/non-html-load-event.html.
  • platform/qt/Skipped:
19:08 Changeset [46206] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

19:07 Changeset [46205] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.7

New tag.

18:39 Changeset [46204] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-21 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos.

Every wtf file includes other wtf files with <> style includes
except this one. Fix the exception.

  • wtf/ByteArray.h:
17:43 Changeset [46203] by jianli@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Implement AbstractWorker::dispatchScriptErrorEvent by generating an ErrorEvent.
https://bugs.webkit.org/show_bug.cgi?id=27515

  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::dispatchScriptErrorEvent):
17:37 Changeset [46202] by barraclough@apple.com
  • 10 edits
    2 adds in trunk/JavaScriptCore

2009-07-21 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Move LinkBuffer/RepatchBuffer out of AbstractMacroAssembler.
( https://bugs.webkit.org/show_bug.cgi?id=27485 )

This change is the first step in a process to move code that should be in
the architecture-specific MacroAssembler classes up out of Assmbler and
AbstractMacroAssembler.


  • assembler/ARMAssembler.h: (JSC::ARMAssembler::linkPointer):
    • rename patchPointer to bring it in line with the current link/repatch naming scheme


  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::linkCall): (JSC::ARMv7Assembler::linkPointer): (JSC::ARMv7Assembler::relinkCall): (JSC::ARMv7Assembler::repatchInt32): (JSC::ARMv7Assembler::repatchPointer): (JSC::ARMv7Assembler::setInt32): (JSC::ARMv7Assembler::setPointer):
    • rename patchPointer to bring it in line with the current link/repatch naming scheme
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::linkJump): (JSC::AbstractMacroAssembler::linkCall): (JSC::AbstractMacroAssembler::linkPointer): (JSC::AbstractMacroAssembler::getLinkerAddress): (JSC::AbstractMacroAssembler::getLinkerCallReturnOffset): (JSC::AbstractMacroAssembler::repatchJump): (JSC::AbstractMacroAssembler::repatchCall): (JSC::AbstractMacroAssembler::repatchNearCall): (JSC::AbstractMacroAssembler::repatchInt32): (JSC::AbstractMacroAssembler::repatchPointer): (JSC::AbstractMacroAssembler::repatchLoadPtrToLEA):
    • remove the LinkBuffer/RepatchBuffer classes, but leave a set of (private, friended) methods to interface to the Assembler
  • assembler/LinkBuffer.h: Added. (JSC::LinkBuffer::LinkBuffer): (JSC::LinkBuffer::~LinkBuffer): (JSC::LinkBuffer::link): (JSC::LinkBuffer::patch): (JSC::LinkBuffer::locationOf): (JSC::LinkBuffer::locationOfNearCall): (JSC::LinkBuffer::returnAddressOffset): (JSC::LinkBuffer::finalizeCode): (JSC::LinkBuffer::finalizeCodeAddendum): (JSC::LinkBuffer::code): (JSC::LinkBuffer::performFinalization):
    • new file containing the LinkBuffer class, previously a member of AbstractMacroAssembler
  • assembler/RepatchBuffer.h: Added. (JSC::RepatchBuffer::RepatchBuffer): (JSC::RepatchBuffer::relink): (JSC::RepatchBuffer::repatch): (JSC::RepatchBuffer::repatchLoadPtrToLEA): (JSC::RepatchBuffer::relinkCallerToTrampoline): (JSC::RepatchBuffer::relinkCallerToFunction): (JSC::RepatchBuffer::relinkNearCallerToTrampoline):
    • new file containing the RepatchBuffer class, previously a member of AbstractMacroAssembler
  • assembler/X86Assembler.h: (JSC::X86Assembler::linkJump): (JSC::X86Assembler::linkCall): (JSC::X86Assembler::linkPointerForCall): (JSC::X86Assembler::linkPointer): (JSC::X86Assembler::relinkJump): (JSC::X86Assembler::relinkCall): (JSC::X86Assembler::repatchInt32): (JSC::X86Assembler::repatchPointer): (JSC::X86Assembler::setPointer): (JSC::X86Assembler::setInt32): (JSC::X86Assembler::setRel32):
    • rename patchPointer to bring it in line with the current link/repatch naming scheme
  • jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress):
    • include new headers
    • remove MacroAssembler:: specification from RepatchBuffer usage
  • jit/JITPropertyAccess.cpp:
  • yarr/RegexJIT.cpp:
    • include new headers
17:08 Changeset [46201] by eric@webkit.org
  • 7 edits
    1 add in trunk/WebCore

2009-07-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move m_context out of generator into a superclass
https://bugs.webkit.org/show_bug.cgi?id=27521

Mostly this is removing code from CodeGeneratorJS
and instead using a DOMObjectWithSVGContext superclass in JSDOMBinding.h.

DOMObjectWithSVGContext.h is its own file so that WebKit doesn't need to
know about SVGElement.h (WebKit includes JSDOMBinding.h for some reason).

I also removed context pointer from SVGZoomEvent since it was never used.

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/DOMObjectWithSVGContext.h: Added. (WebCore::DOMObjectWithSVGContext::context): (WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/scripts/CodeGeneratorJS.pm:
16:08 Changeset [46200] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (r46142): editing/execCommand/19087.html & editing/execCommand/19653-1.html fail in Windows build
https://bugs.webkit.org/show_bug.cgi?id=27480

Because m_anchorType : 2 is treated as a signed integer by cl.exe, anchorType() wasn't returning the correct value.
We made m_anchorType unsigned so that anchorType() returns the correct value.

  • dom/Position.h: (WebCore::Position::anchorType): statically cast to AnchorType
15:57 Changeset [46199] by jianli@chromium.org
  • 3 edits in trunk/WebCore

2009-07-21 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

[V8] Add V8 bindings for onerror in WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=27518

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
15:54 Changeset [46198] by jianli@chromium.org
  • 3 edits in trunk/WebCore

2009-07-21 Jian Li <jianli@chromium.org>

Fix the incorrect patch being landed for bug 27516 that has already been reviewed.
https://bugs.webkit.org/show_bug.cgi?id=27516

  • workers/WorkerContext.h: (WebCore::WorkerContext::setOnerror): (WebCore::WorkerContext::onerror):
  • workers/WorkerContext.idl:
15:44 Changeset [46197] by jianli@chromium.org
  • 4 edits in trunk/WebCore

2009-07-21 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Add onerror to WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=27516

  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark):
  • workers/WorkerContext.h: (WebCore::WorkerContext::setOnerror): (WebCore::WorkerContext::onerror):
  • workers/WorkerContext.idl:
15:42 Changeset [46196] by treat@webkit.org
  • 1 edit
    8 adds in trunk/WebCore

2009-07-21 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=27509
Add font-related files for the WinCE port.

Written by Yong Li <yong.li@torchmobile.com>

  • platform/graphics/wince/FontCacheWince.cpp: Added.
  • platform/graphics/wince/FontCustomPlatformData.cpp: Added.
  • platform/graphics/wince/FontCustomPlatformData.h: Added.
  • platform/graphics/wince/FontPlatformData.cpp: Added.
  • platform/graphics/wince/FontPlatformData.h: Added.
  • platform/graphics/wince/FontWince.cpp: Added.
  • platform/graphics/wince/GlyphPageTreeNodeWince.cpp: Added.
  • platform/graphics/wince/SimpleFontDataWince.cpp: Added.
14:11 Changeset [46195] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Fix the Windows build, and update the comment on top now that wx uses WebCorePrefix.h too.

13:55 Changeset [46194] by kevino@webkit.org
  • 2 edits in trunk/WebCore

WebCorePrefix.h build fixes for non-Mac and wx / CURL builds.

13:52 Changeset [46193] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. Missing header added.

13:45 Changeset [46192] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-21 Adam Treat <adam.treat@torchmobile.com>

Reviewed by David Levin.

We can't match implementation file and primary header exactly
since we have so many files in WebKit where the port suffix
is appended to the filename.

Example: FooQt.cpp and the primary header is Foo.h.

  • Scripts/modules/cpplint.py:
13:35 Changeset [46191] by eric@webkit.org
  • 16 edits in trunk/WebCore

2009-07-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

All DOMConstructorObjects should hold a pointer to the JSDOMGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=27478

This is just moving code.
I've added two new classes: DOMObjectWithGlobalPointer and DOMConstructorWithDocument.

DOMObjectWithGlobalPointer is a new baseclass for DOMConstructorObject.
(It's a baseclass because eventually all DOMObjects will have a global pointer, but
I'll be moving them onto DOMObjectWithGlobalPointer in stages.)

DOMConstructorWithDocument is a new baseclass for the 3 constructor objects
which require a backpointer to the Document to function. I made this a subclass of
DOMConstructorObject to make clear that most constructors can hold no-such assumptions
about having a back-pointer to the Document (since many constructors can be used from Workers).

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::globalObject): (WebCore::DOMObjectWithGlobalPointer::scriptExecutionContext): (WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer): (WebCore::DOMObjectWithGlobalPointer::mark): (WebCore::DOMConstructorObject::DOMConstructorObject): (WebCore::DOMConstructorWithDocument::document): (WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
  • bindings/js/JSMessageChannelConstructor.h:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSOptionConstructor.h:
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
  • bindings/js/JSWebKitPointConstructor.cpp: (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::JSWorkerConstructor::JSWorkerConstructor):
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  • bindings/js/JSXMLHttpRequestConstructor.h:
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
13:15 Changeset [46190] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Revert r46128.

13:06 Changeset [46189] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by David Levin.

Add checks for switch statement indentation to cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27508

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
12:43 Changeset [46188] by kenneth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Adam Treat.

Feature request: cpplint should check for braces - rule 2
https://bugs.webkit.org/show_bug.cgi?id=27497

Add the requested feature: Make sure { is on the same line
as the foreach "keyword".

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
12:18 Changeset [46187] by levin@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-07-21 Robert Agoston <Agoston.Robert@stud.u-szeged.hu>

Reviewed by David Levin.

Fixed #undef typo.
https://bugs.webkit.org/show_bug.cgi?id=27506

  • bytecode/Opcode.h:
12:18 Changeset [46186] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 James Hawkins <jhawkins@google.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=27453
Initialize isInt when creating a CSSParserValue for a function.

No change in behavior, so no tests.

  • css/CSSFunctionValue.cpp: (WebCore::CSSFunctionValue::parserValue):
12:18 Changeset [46185] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-20 Jens Alfke <snej@google.com>

Reviewed by David Levin.

Bug 27448: [Chromium] On Mac, arrow keys should cause Select to pop up its menu.
Mac build of Chromium doesn't follow Mac HI guidelines to pop up the menu when
an arrow key is pressed.
https://bugs.webkit.org/show_bug.cgi?id=27448

No new tests; affects only control response to user input.

  • dom/SelectElement.cpp: Changed definition of ARROW_KEYS_POP_MENU to make it true in Mac Chromium, so it will behave compatibly with Mac HI guidelines on pop-up menus. It's not possible to have PLATFORM(MAC) be true in the Mac build of Chromium.
12:18 Changeset [46184] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Paul Godavari <paul@chromium.org>

Reviewed by Eric Seidel.

[Chromium] popup menus can crash when the selected index is -1
https://bugs.webkit.org/show_bug.cgi?id=27275

Crash reports from users indicate a crash can occur when PopupListBox::isSelectableItem
is passed an index of less than 0 (which is possible under certain circumstances). This
change prevents such a value from causing a crash by enforcing valid index values passed
by all callers of isSelectableItem. isSelectableItem is now a private method of
PopupListBox, as there are no external callers.

Also cleaned up a small amount of code for style and grammar errors.

No automatic test is provided since we cannot send events to the child window used by
the popup menu.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::acceptIndex): (WebCore::PopupListBox::selectIndex): (WebCore::PopupListBox::isSelectableItem): (WebCore::PopupListBox::selectPreviousRow):
12:00 Changeset [46183] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Don't include winsock2.h on wx, it conflicts with wx's inclusion of winsock.

11:21 Changeset [46182] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-20 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by David Levin.

Add checks for namespace indentation to cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27461

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
11:16 Changeset [46181] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-20 Adam Treat <adam.treat@torchmobile.com>

Reviewed by David Levin.

Add cpplint check for proper include order
https://bugs.webkit.org/show_bug.cgi?id=27462

Add a new check to cpplint to flag cases where the include section of a file
does not match the mandated include order and style of the Webkit coding style
guidelines.

Add associated tests.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
11:13 Changeset [46180] by aroben@apple.com
  • 13 edits
    2 deletes in trunk

Roll out r46153, r46154, and r46155

These changes were causing build failures and assertion failures on
Windows.

JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSArray.cpp:
  • runtime/StringPrototype.cpp:
  • runtime/UString.cpp:
  • runtime/UString.h:
  • wtf/FastMalloc.cpp:
  • wtf/FastMalloc.h:
  • wtf/Platform.h:
  • wtf/PossiblyNull.h: Removed.

WebCore:

  • ForwardingHeaders/wtf/PossiblyNull.h: Removed.
  • platform/graphics/cg/ImageBufferCG.cpp:
10:34 Changeset [46179] by jianli@chromium.org
  • 12 edits
    3 adds in trunk/WebCore

2009-07-21 Jian Li <jianli@chromium.org>

Reviewed by Eric Seidel.

Implement ErrorEvent API.
https://bugs.webkit.org/show_bug.cgi?id=27387

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • dom/ErrorEvent.cpp: Added.
  • dom/ErrorEvent.h: Added.
  • dom/ErrorEvent.idl: Added.
  • dom/Event.cpp: (WebCore::Event::isErrorEvent):
  • dom/Event.h:
10:14 Changeset [46178] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Priit Laes <plaes@plaes.org>

Reviewed by Gustavo Noronha.

[Gtk] Searching in thepiratebay.org doesn't work with more than 1 word
https://bugs.webkit.org/show_bug.cgi?id=24602

Remove workaround required for <=libsoup-2.26.1

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
10:09 Changeset [46177] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397

Make a copy of the context handle before making it weak. We don't want
to make the original handle weak because we want it to survive for the
length of the V8IsolatedWorld::evaluate method.

  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
09:50 Changeset [46176] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add ability to evaluate selection while on break point.

https://bugs.webkit.org/show_bug.cgi?id=27502

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded): (WebInspector.SourceFrame.prototype._documentKeyDown):
09:42 Changeset [46175] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Special case ConsolePanel opening since
it is a 'fast view'.

https://bugs.webkit.org/show_bug.cgi?id=27493

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible):
08:13 Changeset [46174] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

wx build fix. Adding isSpeaking() to ContextMenuClientWx.

06:40 Changeset [46173] by hausmann@webkit.org
  • 5 edits in trunk/WebKit/qt

2009-07-21 Volker Hilsheimer <volker.hilsheimer@nokia.com>

Reviewed by Simon Hausmann.

Various improvements to the API documentation.

  • Updated link to W3c Database spec
  • Formatting fixes, cleanups
  • Add missing \since 4.6 tags to QWebPage::frameAt
  • Extend QWebDatabase and QWebSecurityOrigin docs.
  • Api/qwebdatabase.cpp:
  • Api/qwebpage.cpp:
  • Api/qwebsecurityorigin.cpp:
  • Api/qwebview.cpp:
06:10 Changeset [46172] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-21 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Rubber-stamped by Simon Hausmann.

Remove preliminary-tag from QWebElement

  • Api/qwebelement.cpp:
05:42 Changeset [46171] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-21 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Skip fast/loader/non-html-load-event.html for the Qt DRT as it requires
support for loading PDF documents.

  • platform/qt/Skipped:
05:02 Changeset [46170] by kenneth@webkit.org
  • 66 edits in trunk

WebCore:

2009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Eric Seidel.

Fix Qt code to follow the WebKit Coding Style.

  • platform/graphics/qt/FontQt.cpp: (WebCore::qstring): (WebCore::fixSpacing):
  • platform/graphics/qt/FontQt43.cpp: (WebCore::generateComponents): (WebCore::Font::offsetForPositionForComplexText): (WebCore::cursorToX):
  • platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtFillRule): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getWindowsContext):
  • platform/graphics/qt/IconQt.cpp: (WebCore::Icon::paint):
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::ReadContext::read): (WebCore::ImageDecoderQt::ReadContext::readImageLines): (WebCore::ImageDecoderQt::setData):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern): (WebCore::BitmapImage::draw):
  • platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameDurationAtIndex): (WebCore::ImageSource::frameHasAlphaAtIndex): (WebCore::ImageSource::frameIsCompleteAtIndex):
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::create): (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::updateStates):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo): (WebCore::Path::isEmpty):
  • platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::TransformationMatrix::operator QTransform):
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::clearData): (WebCore::ClipboardQt::clearAllData): (WebCore::ClipboardQt::getData): (WebCore::ClipboardQt::setData): (WebCore::ClipboardQt::setDragImage): (WebCore::getCachedImage): (WebCore::ClipboardQt::declareAndWriteDragImage): (WebCore::ClipboardQt::writeURL): (WebCore::ClipboardQt::writeRange): (WebCore::ClipboardQt::hasData):
  • platform/qt/ClipboardQt.h:
  • platform/qt/ContextMenuItemQt.cpp: (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title):
  • platform/qt/CursorQt.cpp: (WebCore::westPanningCursor): (WebCore::notAllowedCursor):
  • platform/qt/DragDataQt.cpp: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): (WebCore::DragData::asPlainText): (WebCore::DragData::asFragment):
  • platform/qt/DragImageQt.cpp: (WebCore::createDragImageIconForCachedImage):
  • platform/qt/FileSystemQt.cpp: (WebCore::getFileSize): (WebCore::unloadModule):
  • platform/qt/Localizations.cpp: (WebCore::contextMenuItemTagShowSpellingPanel):
  • platform/qt/MIMETypeRegistryQt.cpp: (WebCore::):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::plainText):
  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  • platform/qt/PlatformMouseEventQt.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::populate):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::fallbackStyle): (WebCore::inflateButtonRect): (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::applyTheme): (WebCore::WorldMatrixTransformer::WorldMatrixTransformer): (WebCore::RenderThemeQt::paintMediaBackground): (WebCore::RenderThemeQt::paintMediaFullscreenButton):
  • platform/qt/RenderThemeQt.h:
  • platform/qt/ScreenQt.cpp: (WebCore::screenRect): (WebCore::usableScreenRect):
  • platform/qt/ScrollbarQt.cpp: (WebCore::Scrollbar::contextMenu):
  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::scPart): (WebCore::scrollbarPart):
  • platform/qt/ScrollbarThemeQt.h:
  • platform/qt/SharedBufferQt.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
  • platform/qt/TemporaryLinkStubs.cpp: (PluginDatabase::defaultPluginDirectories): (PluginDatabase::getPluginPathsInDirectories): (PluginDatabase::isPreferredPluginDirectory): (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString): (WebCore::userIdleTime): (WebCore::prefetchDNS):
  • platform/text/qt/StringQt.cpp: (WebCore::String::String):
  • platform/text/qt/TextBoundaries.cpp:
  • platform/text/qt/TextBreakIteratorQt.cpp: (WebCore::TextBreakIterator::following): (WebCore::TextBreakIterator::preceding): (WebCore::WordBreakIteratorQt::first): (WebCore::WordBreakIteratorQt::next): (WebCore::WordBreakIteratorQt::previous): (WebCore::CharBreakIteratorQt::first): (WebCore::CharBreakIteratorQt::next): (WebCore::CharBreakIteratorQt::previous): (WebCore::characterBreakIterator):
  • plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::fetchInfo):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::userAgentStatic): (WebCore::PluginView::handlePostReadFile): (WebCore::PluginView::init):

WebKit/qt:

2009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Eric Seidel.

Fix Qt code to follow the WebKit Coding Style.

  • Api/qcookiejar.cpp: (QCookieJar::setCookieJar): (QCookieJar::cookieJar):
  • Api/qcookiejar.h:
  • Api/qwebdatabase.cpp: (QWebDatabase::QWebDatabase): (QWebDatabase::removeDatabase):
  • Api/qwebdatabase.h:
  • Api/qwebdatabase_p.h:
  • Api/qwebelement.h:
  • Api/qwebframe.cpp: (QWebFrame::title): (QWebFrame::print):
  • Api/qwebframe.h:
  • Api/qwebframe_p.h:
  • Api/qwebhistory.cpp: (QWebHistory::clear):
  • Api/qwebhistory.h:
  • Api/qwebhistory_p.h:
  • Api/qwebhistoryinterface.cpp: (gCleanupInterface): (QWebHistoryInterface::setDefaultInterface): (QWebHistoryInterface::defaultInterface): (QWebHistoryInterface::QWebHistoryInterface):
  • Api/qwebhistoryinterface.h:
  • Api/qwebnetworkinterface.cpp: (QWebNetworkManager::started): (QWebNetworkManager::finished): (QWebNetworkInterfacePrivate::parseDataUrl): (QWebNetworkInterface::addJob): (WebCoreHttp::onResponseHeaderReceived): (WebCoreHttp::onReadyRead):
  • Api/qwebnetworkinterface.h:
  • Api/qwebnetworkinterface_p.h:
  • Api/qwebpage.cpp: (QWebPagePrivate::editorCommandForWebActions): (QWebPagePrivate::createContextMenu): (QWebPagePrivate::focusInEvent): (QWebPage::fixedContentsSize): (QWebPage::setContentEditable): (QWebPage::swallowContextMenuEvent): (QWebPage::findText):
  • Api/qwebpage.h:
  • Api/qwebpage_p.h:
  • Api/qwebpluginfactory.h:
  • Api/qwebsecurityorigin.h:
  • Api/qwebsecurityorigin_p.h:
  • Api/qwebsettings.cpp: (QWebSettingsPrivate::QWebSettingsPrivate): (QWebSettingsPrivate::apply): (QWebSettings::globalSettings): (QWebSettings::QWebSettings): (QWebSettings::fontSize): (QWebSettings::setUserStyleSheetUrl): (QWebSettings::setDefaultTextEncoding): (QWebSettings::setIconDatabasePath): (QWebSettings::iconDatabasePath): (QWebSettings::iconForUrl): (QWebSettings::setWebGraphic): (QWebSettings::setFontFamily): (QWebSettings::fontFamily): (QWebSettings::testAttribute): (qt_websettings_setLocalStorageDatabasePath):
  • Api/qwebsettings.h:
  • Api/qwebview.cpp: (QWebView::setPage): (QWebView::event):
  • Api/qwebview.h:
04:05 Changeset [46169] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-21 Priit Laes <plaes@plaes.org>

Reviewed by Holger Freyther.

[GTK+] Missing accelerator in authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=25509

Add accelerator to checkbox text.

  • WebKit/gtk/webkit/webkitsoupauthdialog.c: (show_auth_dialog):
03:51 Changeset [46168] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-21 Priit Laes <plaes@plaes.org>

Reviewed by Holger Freyther.

[GTK] http auth dialog pops up twice after a cancelled atempt
https://bugs.webkit.org/show_bug.cgi?id=24818

Remove workaround required for libsoup versions <=2.26.2 as we depend
on 2.27.4 now.

  • webkit/webkitsoupauthdialog.c: (session_authenticate):
03:41 Changeset [46167] by levin@chromium.org
  • 1 edit
    4 adds in trunk/WebCore

2009-07-21 Maxime Simon <simon.maxime@gmail.com>

Reviewed by David Levin.

Added a first bunch of Haiku-specific files for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=26988

  • platform/haiku/ClipboardHaiku.cpp: Added. (WebCore::ClipboardHaiku::ClipboardHaiku): (WebCore::ClipboardHaiku::clearData): (WebCore::ClipboardHaiku::clearAllData): (WebCore::ClipboardHaiku::getData): (WebCore::ClipboardHaiku::setData): (WebCore::ClipboardHaiku::types): (WebCore::ClipboardHaiku::files): (WebCore::ClipboardHaiku::dragLocation): (WebCore::ClipboardHaiku::dragImage): (WebCore::ClipboardHaiku::setDragImage): (WebCore::ClipboardHaiku::dragImageElement): (WebCore::ClipboardHaiku::setDragImageElement): (WebCore::ClipboardHaiku::createDragImage): (WebCore::ClipboardHaiku::declareAndWriteDragImage): (WebCore::ClipboardHaiku::writeURL): (WebCore::ClipboardHaiku::writeRange): (WebCore::ClipboardHaiku::hasData):
  • platform/haiku/ClipboardHaiku.h: Added. (WebCore::ClipboardHaiku::create): (WebCore::ClipboardHaiku::~ClipboardHaiku):
  • platform/haiku/CookieJarHaiku.cpp: Added. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
  • platform/haiku/CursorHaiku.cpp: Added. (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::Cursor::operator=): (WebCore::pointerCursor): (WebCore::moveCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor): (WebCore::grabCursor): (WebCore::grabbingCursor):
03:35 Changeset [46166] by levin@chromium.org
  • 2 edits
    1 add in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

Support lint for patches
https://bugs.webkit.org/show_bug.cgi?id=27291

Add run-webkit-lint script, which lints recent changes in local
repository. Also, modified cpplint.py so that we don't need to
specify verbose level for process_file().

  • Scripts/modules/cpplint.py:
  • Scripts/run-webkit-lint: Added.
03:12 Changeset [46165] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Albert Astals Cid <aacid@kde.org>

Reviewed by Tor Arne Vestbø.

Change #error line not to have a ' (single quote)

  • DerivedSources.cpp:
03:12 Changeset [46164] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

diff_parser should accept lines without trailing \n
https://bugs.webkit.org/show_bug.cgi?id=27483

Normalize the input lines by removing a trailing newline.
Also, add a case for unittest for newly added files.

  • Scripts/modules/diff_parser.py:
  • Scripts/modules/diff_parser_unittest.py:
03:12 Changeset [46163] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

cpplint.py's process_file() should accept customized error function
https://bugs.webkit.org/show_bug.cgi?id=27487

  • Scripts/modules/cpplint.py:
02:53 Changeset [46162] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

cpplint.py should have an interface to get global error count
https://bugs.webkit.org/show_bug.cgi?id=27486

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
02:53 Changeset [46161] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

cpplint's parse_argument should not exit even if no files are specified
https://bugs.webkit.org/show_bug.cgi?id=27489

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
02:53 Changeset [46160] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

diff_parser: s/add_deleted_line/add_old_line/g
https://bugs.webkit.org/show_bug.cgi?id=27484

  • Scripts/modules/diff_parser.py:
02:53 Changeset [46159] by levin@chromium.org
  • 17 edits in trunk

.:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

  • configure.ac: Added flag ENABLE_RUBY.

JavaScriptCore:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

  • Configurations/FeatureDefines.xcconfig: Added flag ENABLE_RUBY.

WebCore:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

Added flag ENABLE_RUBY:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/build-generated-files.sh:

WebKit/mac:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

  • Configurations/FeatureDefines.xcconfig: Added flag ENABLE_RUBY.

WebKit/win:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

  • WebKit.vcproj/WebKit.vcproj: Added flag ENABLE_RUBY.

WebKitTools:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

  • Scripts/build-webkit: Added flag ENABLE_RUBY.
02:53 Changeset [46158] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 James Hawkins <jhawkins@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27467
Return an empty path in PlatformContextSkia::currentPathInLocalCoordinates
if matrix.invert() fails. This prevents the use of an uninitialized
value in inverseMatrix.

No new tests added. Run
LayoutTests/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html
under valgrind and notice there are no errors.

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::currentPathInLocalCoordinates):
02:53 Changeset [46157] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-21 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27388

Fix dotted and dashed borders on Chromium/skia. This follows
the logic in the Cg path, so results are much closer to Safari now
(some tests won't be exactly the same due to font layout differences).

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):

07/20/09:

23:41 Changeset [46156] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix <https://bugs.webkit.org/show_bug.cgi?id=27482>.
Bug 27482: svn-apply cannot apply patch generated by Windows SVN

Reviewed by David D. Kilzer.

A regexp in svn-apply was treating everything prior to a \n as part of the
file name. The native Windows SVN client uses \r\n for line endings which
meant that the \r was being included in the file name. This defeated the
special-case logic for ChangeLogs to apply them with an increased fuzz factor,
meaning that the ChangeLog portions of such patches would fail to apply.

Also updated two other regexps that look like they would hit similar problems
with line-endings so that they will correctly handle patches from Windows SVN.

  • Scripts/svn-apply:
21:35 Changeset [46155] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix attempt #2

21:22 Changeset [46154] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix attempt #1

21:02 Changeset [46153] by oliver@apple.com
  • 11 edits
    2 adds in trunk

Make it harder to misuse try* allocation routines
https://bugs.webkit.org/show_bug.cgi?id=27469

Reviewed Gavin Barraclough

Jump through a few hoops to make it much harder to accidentally
miss null-checking of values returned by the try-* allocation
routines.

20:33 Changeset [46152] by zecke@webkit.org
  • 2 edits
    3 adds in trunk/WebKit/qt

[Qt] Add test for loading webpages...

Performance test for loading webpages...

20:32 Changeset [46151] by zecke@webkit.org
  • 2 edits
    4 adds in trunk/WebKit/qt

[Qt] Add a test case for drawing a simple viewrect to a QPixmap

20:30 Changeset [46150] by agl@chromium.org
  • 3 edits
    3 adds in trunk

2009-07-20 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Guard access to installedMediaEngines()[0].

https://bugs.webkit.org/show_bug.cgi?id=27479
http://code.google.com/p/chromium/issues/detail?id=16541

Else where in the file, installedMediaEngines is always checked for
being empty because access. This patch adds a case which missed that
check.

This triggered a crash in Chromium:

http://www.yakeze.com/chat/example-chromium-crash/

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load):
20:27 Changeset [46149] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Gavin Barraclough <barraclough@apple.com>

RS Oliver Hunt.

Add ARM assembler files to xcodeproj, for convenience editing.

20:06 Changeset [46148] by agl@chromium.org
  • 2 edits in trunk/WebCore

2009-07-20 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Allow search entries to render with a CSS border if the RenderTheme
doesn't paint them.

https://bugs.webkit.org/show_bug.cgi?id=27466
http://code.google.com/p/chromium/issues/detail?id=16958

<input type="search"> is very much like a text entry except that,
currently, if the RenderTheme doesn't deal with it, nothing is
rendered. With this patch, the default CSS border is rendered if the
RenderTheme requests it.

This will affect many layout tests, but only for Chromium Linux and
those results are not currently in the WebKit tree.

  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paintBorderOnly):
19:58 Changeset [46147] by jberlin@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Jessie Berlin <jberlin@apple.com>

Fix an incorrect assertion in Vector::remove.


Reviewed by David Levin.


https://bugs.webkit.org/show_bug.cgi?id=27477

  • wtf/Vector.h: (WTF::::remove): Assert that the position at which to start removing elements + the length (the number of elements to remove) is less than or equal to the size of the entire Vector.
19:54 Changeset [46146] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Correct expected results from r46136, which accidentally included the
DumpRenderTree header and trailer

  • fast/loader/non-html-load-event-expected.txt:
19:19 Changeset [46145] by abarth@webkit.org
  • 14 edits in trunk/WebCore

2009-07-17 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Switch to faster methods to access internal fields.
https://bugs.webkit.org/show_bug.cgi?id=27372

Minor refactoring.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertToSVGPODTypeImpl): (WebCore::V8DOMWrapper::setDOMWrapper):
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::convertDOMWrapperToNode): (WebCore::V8DOMWrapper::convertToNativeObject): (WebCore::V8DOMWrapper::convertToNativeEvent):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ClipboardCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::removeElement):
  • bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
19:15 Changeset [46144] by agl@chromium.org
  • 4 edits
    1 add in trunk/WebCore

2009-07-20 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium Linux: cache Harfbuzz faces.

https://bugs.webkit.org/show_bug.cgi?id=27473

Previously, we recreated the Harfbuzz face for each script-run. With
this patch, we keep the Harfbuzz face in the FontPlatformData (created
as needed) and so they will persist for the duration of the
FontPlatformData.

Shouldn't affect any layout tests. Results in a significant win on the
intl2 page cycler time.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::~TextRunWalker): (WebCore::TextRunWalker::setupFontForScriptRun):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::RefCountedHarfbuzzFace::~RefCountedHarfbuzzFace): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::harfbuzzFace):
  • platform/graphics/chromium/FontPlatformDataLinux.h: (WebCore::FontPlatformData::RefCountedHarfbuzzFace::create): (WebCore::FontPlatformData::RefCountedHarfbuzzFace::face): (WebCore::FontPlatformData::RefCountedHarfbuzzFace::RefCountedHarfbuzzFace):
  • platform/graphics/chromium/HarfbuzzSkia.h: Added.
18:31 Changeset [46143] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Simon Fraser.

REGRESSION (r46142): Need to remove showTreeThisForThis
https://bugs.webkit.org/show_bug.cgi?id=27475

Removes showTreeThisForThis

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::appendParagraphIntoNode):
17:55 Changeset [46142] by rniwa@webkit.org
  • 16 edits
    8 adds in trunk

WebCore:

2009-07-19 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Refactoring of indentRegion to fix bugs 26816 and 25317
https://bugs.webkit.org/show_bug.cgi?id=26816
https://bugs.webkit.org/show_bug.cgi?id=25317
https://bugs.webkit.org/show_bug.cgi?id=23995 (partially)

This patch implements appendParagraphIntoNode, a simpler specialized version of moveParagraph
and replaces all calls inside indentRegion. The following is the new behavior of indentRegion.

  1. We try to indent as many wrapping nodes as possible. e.g. when indenting "hello" in <div>hello</div>, we try to indent div as well.
  2. We do not delete any wrapping elements With moveParagraph, we used to remove all wrapping nodes, and replaced with a blockquote. This was causing https://bugs.webkit.org/show_bug.cgi?id=23995 for indentation. With appendParagraphIntoNode, we can preserve all wrapping nodes.
  3. We only split the tree until the closest block node instead of until the root editable node. This behavioral change fixes the bug 25317.
  4. When multiple paragraphs are indented, we indent the highest common ancestor within the selection. e.g. when a list is a child node of a div, and the entire div is intended,

we enclose the div by a single blockquote.

Note that new behavior is more consistent with that of Internet Explorer and Firefox.
To demonstrate this, the following tests are added.

Tests: editing/execCommand/indent-div-inside-list.html

editing/execCommand/indent-nested-blockquotes.html
editing/execCommand/indent-nested-div.html
editing/execCommand/indent-second-paragraph-in-blockquote.html

  • editing/IndentOutdentCommand.cpp: prepareBlockquoteLevelForInsertion is removed (WebCore::IndentOutdentCommand::tryIndentingAsListItem): uses appendParagraphIntoNode now (WebCore::IndentOutdentCommand::indentIntoBlockquote): uses appendParagraphIntoNode now (WebCore::IndentOutdentCommand::appendParagraphIntoNode): removes a paragraph and appends it to a new node (WebCore::IndentOutdentCommand::removeUnnecessaryLineBreakAt): removes a break element at the specified position (WebCore::IndentOutdentCommand::indentRegion): exhibits the described behavior
  • editing/IndentOutdentCommand.h: updated prototype
  • editing/execCommand/19653-1-expected.txt: rebaselined (no longer removes wrapping div)
  • editing/execCommand/indent-div-inside-list-expected.txt: Added.
  • editing/execCommand/indent-div-inside-list.html: Added.
  • editing/execCommand/indent-nested-blockquotes-expected.txt: Added.
  • editing/execCommand/indent-nested-blockquotes.html: Added.
  • editing/execCommand/indent-nested-div-expected.txt: Added.
  • editing/execCommand/indent-nested-div.html: Added.
  • editing/execCommand/indent-nested-lists-2-expected.txt: rebaselined (selection corrected)
  • editing/execCommand/indent-nested-lists-3-expected.txt: rebaselined (selection corrected)
  • editing/execCommand/indent-nested-lists-4-expected.txt: rebaselined (selection corrected)
  • editing/execCommand/indent-nested-lists-5-expected.txt: rebaselined (selection corrected)
  • editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Added.
  • editing/execCommand/indent-second-paragraph-in-blockquote.html: Added.
  • platform/mac/editing/execCommand/4641880-2-expected.txt: rebaselined
  • platform/mac/editing/execCommand/4916541-expected.txt: rebaselined (no longer removes wrapping span)
  • platform/mac/editing/execCommand/5138441-expected.txt: rebaselined
  • platform/mac/editing/execCommand/5481523-expected.txt: rebaselined
  • platform/mac/editing/execCommand/indent-selection-expected.txt: rebaselined
16:59 Changeset [46141] by mitz@apple.com
  • 2 edits in trunk/WebCore

Try to fix release builds after r46136

  • dom/Element.cpp:
16:59 Changeset [46140] by pdherbemont@apple.com
  • 6 edits
    2 deletes in trunk

WebCore:

2009-07-17 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Eric Seidel.

Media Controls: We are specifying the text height, where it is unneeded and the slider is 2px off.
https://bugs.webkit.org/show_bug.cgi?id=27380

Adjust the margin of the slider and remove useless height specification to fix alignement of the media controls.

  • css/mediaControlsQT.css:

LayoutTests:

2009-07-17 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Eric Seidel.

Media Controls: We are specifying the text height, where it is unneeded and the slider is 2px off.
https://bugs.webkit.org/show_bug.cgi?id=27380

Adjust the margin of the slider and remove useless height specification to fix alignement of the media controls.

  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-styling-expected.checksum: Removed.
  • platform/mac/media/controls-styling-expected.png: Removed.
  • platform/mac/media/controls-styling-expected.txt:
  • platform/mac/media/video-zoom-controls-expected.txt:
16:56 Changeset [46139] by pkasting@chromium.org
  • 19 edits in trunk

JavaScriptCore:

2009-07-20 Peter Kasting <pkasting@google.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.

WebCore:

2009-07-20 Peter Kasting <pkasting@google.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/WebCoreGenerated.vcproj:

WebKit/win:

2009-07-20 Peter Kasting <pkasting@google.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/InterfacesGenerated.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

WebKitTools:

2009-07-20 Peter Kasting <pkasting@google.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
16:35 Changeset [46138] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-20 Eric Seidel <eric@webkit.org>

Reviewed by Sam Weinig.

Fix failures seen on the bots
https://bugs.webkit.org/show_bug.cgi?id=27463

Ignore more global variables added by DumpRenderTree.
Some platforms don't add all of the DRT controllers,
thus causing this test to fail for those platforms.

Also fix !value to value === null to handle not
skip the cases where value == 0.

  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/resources/prototype-inheritance.js:
16:15 Changeset [46137] by cmarrin@apple.com
  • 1 edit in trunk/LayoutTests/transitions/extra-transition.html

Fixed a transition LayoutTest which fails on slower machines

16:08 Changeset [46136] by mitz@apple.com
  • 11 edits
    4 adds in trunk

WebCore:

Reviewed by Anders Carlsson.

When loading a custom view into a frame, the old document is still
around
<rdar://problem/5145841>

Safari fires onload before PDF is loaded into the browser
<rdar://problem/6618869>

Test: fast/loader/non-html-load-event.html

  • GNUmakefile.am: Added PlaceholderDocument.{cpp,h}
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • dom/Document.h: (WebCore::Document::setStyleSelector): Added this protected accessor for

PlaceholderDocument to use.

  • dom/Element.cpp: (WebCore::Element::clientWidth): Check whether the document has a

renderer.

(WebCore::Element::clientHeight): Ditto.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a PlaceholderDocument for frames

that do not use an HTML view. Do not nullify the content size in
that case.

(WebCore::FrameLoader::transitionToCommitted): For frames that do not

use an HTML view, call receivedFirstData(), which sets up the
frame with a new PlaceHolderDocument.

  • loader/PlaceholderDocument.cpp: Added. (WebCore::PlaceholderDocument::attach): Sets up the style selector but

does not create a RenderView.

  • loader/PlaceholderDocument.h: Added. (WebCore::PlaceholderDocument::create): (WebCore::PlaceholderDocument::PlaceholderDocument):

LayoutTests:

Reviewed by Anders Carlsson.

Safari fires onload before PDF is loaded into the browser
<rdar://problem/6618869>

  • fast/loader/non-html-load-event-expected.txt: Added.
  • fast/loader/non-html-load-event.html: Added.
15:45 Changeset [46135] by cmarrin@apple.com
  • 5 edits in trunk/WebCore

Handle opacity and opacity animations on transform layers in Leopard
https://bugs.webkit.org/show_bug.cgi?id=27398

This makes two changes, and only for Leopard.

First, whenever opacity is changed on a layer I propagate the
change into the content layer and all the children if the layer
on which opacity is set is a transform layer (preserve3D is true).
The opacity set is the accumulated opacity from this layer
and all its direct ancestor transform layers. Second, I turn off all
hardware opacity animation.

15:16 Changeset [46134] by pkasting@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-20 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27323
Use shorter, more correct code for determining the current directory,
which works better with symbolic links on some systems. Also switch
from checking repository root to checking UUID, to match scm.py.

  • Scripts/svn-create-patch:
14:46 Changeset [46133] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Work around <rdar://problem/7075373> by ensuring that the URL is absolute before handing it off to CoreText.

Rubber-stamped by Dan Bernstein.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(activateFonts):

14:38 Changeset [46132] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-07-20 Geoffrey Garen <ggaren@apple.com>

Fixed a post-review typo in r46066 that caused tons of test failures.


SunSpider reports no change.

  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): Initialize the full vector capacity, to avoid uninitialized members at the end.
13:55 Changeset [46131] by bweinstein@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-07-20 Geoffrey Garen <ggaren@apple.com>

Windows WebKit build fix: Added some missing exports.

13:41 Changeset [46130] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-20 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

Enable filename completion for run-webkit-test (added "-o default").

  • Scripts/webkit-tools-completion.sh:
13:08 Changeset [46129] by treat@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-07-20 Yong Li <yong.li@torchmobile.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=27349
Add GraphicsContext implementation for the WinCE port.

Written by Yong Li <yong.li@torchmobile.com> and George Staikos <george.staikos@torchmobile.com>
with trivial style fixes by Adam Treat <adam.treat@torchmobile.com>

  • platform/graphics/wince/GraphicsContextWince.cpp: Added.
13:06 Changeset [46128] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r46058.

12:37 Changeset [46127] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r46039.

10:56 Changeset [46126] by eroman@chromium.org
  • 3 edits
    4 adds in trunk/WebCore

2009-07-20 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adding the Win SQLite VFS implementation for Chromium, and stubs
for the Mac and Linux VFSs.

https://bugs.webkit.org/show_bug.cgi?id=26940

  • WebCore.gypi:
  • platform/chromium/ChromiumBridge.h:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: Added.
  • platform/sql/chromium/SQLiteFileSystemChromiumLinux.cpp: Added.
  • platform/sql/chromium/SQLiteFileSystemChromiumMac.cpp: Added.
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: Added.
06:47 Changeset [46125] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=27097
[Gtk] Segfault when examining an object of ROLE_TABLE via at-spi

Check that an object is a RenderObject before trying to access its
renderer and related node.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
06:36 Changeset [46124] by hausmann@webkit.org
  • 5 edits in trunk/WebCore

2009-07-20 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] font cache reworking
https://bugs.webkit.org/show_bug.cgi?id=27265

Reimplemented Qt's FontCache in a way that follows the shared one.
Now we can release its elements when those became inactive.
FontFallbackList had been changed to be able to hold WebCore fonts in its list and to be able to release a FontData what is in the cache.

No change in behavior, so no tests.

  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue): (WebCore::FontPlatformDataCacheKey::): Key type for the cache of FontPlatformData objects. It can be constructed from a FontPlatformData or from a FontDescription. The keys have to be consistent with FontPlatformData::FontPlatformData(const FontDescription&) - if we create the same FontPlatformData from two FontDescription then we have to create the same key from them, and vica versa. (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::FontPlatformDataCacheKey::hash): (WebCore::FontPlatformDataCacheKey::computeHash): (WebCore::FontPlatformDataCacheKey::hashTableDeletedSize): (WebCore::FontPlatformDataCacheKeyHash::hash): (WebCore::FontPlatformDataCacheKeyHash::equal): (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): (WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue): (WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue): (WebCore::FontCache::getCachedFontPlatformData): Get a FontDescription and returns a FontPlatformData. (WebCore::FontCache::getCachedFontData): Get a FontPlatformData and returns a SimpleFontData. (WebCore::FontCache::releaseFontData): Get a SimpleFontData and releases it from the cache. Also releases the appropriate FontPlatformData. (WebCore::FontCache::purgeInactiveFontData): Frees inactive elements. (WebCore::FontCache::invalidate): Frees all inactive elements (call purgeInactiveFontData with default argument)
  • platform/graphics/qt/FontFallbackListQt.cpp: (WebCore::FontFallbackList::releaseFontData): (WebCore::FontFallbackList::fontDataAt):
  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::family): Getter. It is needed for FontPlatformDataCacheKey. (WebCore::FontPlatformData::bold): Ditto. (WebCore::FontPlatformData::italic): Ditto. (WebCore::FontPlatformData::smallCaps): Ditto. (WebCore::FontPlatformData::pixelSize): Ditto.
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): Set m_bold.
04:01 Changeset [46123] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-07-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

[GTK] Widget size negotiation
https://bugs.webkit.org/show_bug.cgi?id=17154

Implement proper size request for the WebView widget.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::contentsSizeChanged):
  • webkit/webkitwebview.cpp: (webkit_web_view_size_request): (webkit_web_view_class_init):
03:09 Changeset [46122] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>

No review, just adding Gavin Barraclough as reviewer.

  • Scripts/modules/bugzilla.py:
03:04 Changeset [46121] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Allow custom memory allocation control in NewThreadContext
https://bugs.webkit.org/show_bug.cgi?id=27338

Inherits NewThreadContext struct from FastAllocBase because it
has been instantiated by 'new' JavaScriptCore/wtf/Threading.cpp:76.

  • wtf/Threading.cpp:
03:04 Changeset [46120] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Allow custom memory allocation control in JavaScriptCore's JSClassRef.h
https://bugs.webkit.org/show_bug.cgi?id=27340

Inherit StaticValueEntry and StaticFunctionEntry struct from FastAllocBase because these
have been instantiated by 'new' in JavaScriptCore/API/JSClassRef.cpp:153
and in JavaScriptCore/API/JSClassRef.cpp:166.

  • API/JSClassRef.h:
03:03 Changeset [46119] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control in JavaScriptCore's RegexPattern.h
https://bugs.webkit.org/show_bug.cgi?id=27343

Inherits RegexPattern.h's structs (which have been instantiated by operator new) from FastAllocBase:

CharacterClass (new call: JavaScriptCore/yarr/RegexCompiler.cpp:144)
PatternAlternative (new call: JavaScriptCore/yarr/RegexPattern.h:221)
PatternDisjunction (new call: JavaScriptCore/yarr/RegexCompiler.cpp:446)

  • yarr/RegexPattern.h:
03:03 Changeset [46118] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's MatchFrame struct
https://bugs.webkit.org/show_bug.cgi?id=27344

Inherits MatchFrame struct from FastAllocBase because it has
been instantiated by 'new' JavaScriptCore/pcre/pcre_exec.cpp:359.

  • pcre/pcre_exec.cpp:
03:02 Changeset [46117] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=26716
[Gtk] Each XMLHttpRequest leaks memory.

Free the SoupURI we create to check the URI. Fix suggested by John
Kjellberg.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
02:52 Changeset [46116] by hausmann@webkit.org
  • 4 edits in trunk

.:

2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] Add an option for QtLauncher to build without QtUiTools dependency
https://bugs.webkit.org/show_bug.cgi?id=27438

Based on Norbert Leser's work.

  • WebKit.pri: Symbian does not have UiTools

WebKit/qt:

2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] Add an option for QtLauncher to build without QtUiTools dependency
https://bugs.webkit.org/show_bug.cgi?id=27438

Based on Norbert Leser's work.

  • QtLauncher/main.cpp: (WebPage::createPlugin):
02:50 Changeset [46115] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

Remove some outdated S60 platform specific code
https://bugs.webkit.org/show_bug.cgi?id=27423

  • wtf/Platform.h:
02:49 Changeset [46114] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

Qt build fix with MSVC and MinGW.

  • jsc.pro: Make sure jsc is a console application, and turn off exceptions and stl support to fix the build.
02:46 Changeset [46113] by hausmann@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by David Levin.

Add support for Qt's foreach to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27386

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
02:41 Changeset [46112] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] On Symbian link against system sqlite3
https://bugs.webkit.org/show_bug.cgi?id=27368

Add an option to force linking against system sqlite3
by adding system-sqlite to the CONFIG variable.

The Symbian specific part of this patch is contributed by
Norbert Leser.

  • WebCore.pro:
02:32 Changeset [46111] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by and done with Tor Arne Vestbø.

Fix fast/css/pseudo-required-optional-*.html in the Qt build
after r46062.

These tests triggered a bug in RenderThemeQt where we did not fall back
to the unstyled painting of text areas and input fields when they have
a styled background.

Our re-implementation of isControlStyled incorrectly only checked the
border for determining whether to style or not. The base-implementation
performs the same check, but also includes the background. Removing
our implementation fixes the appearance.

  • platform/qt/RenderThemeQt.cpp: Removed isControlStyled reimplementation.
  • platform/qt/RenderThemeQt.h: Ditto.
01:31 Changeset [46110] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not use C++-style comments in preprocessor directives.

GCC does not like this in some configurations, using C-style
comments is safer.

  • wtf/Platform.h:
01:31 Changeset [46109] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Change the glib version check to check for the first unstable
release with g_mapped_file_unref. Otherwise this would be useless
until 2.22 is released, a few months from now.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
00:51 Changeset [46108] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Tor Arne Vestbø.

Add missing (sorted) header files to the HEADERS variable in the qmake
.pro file for improved completion in IDEs.

  • WebCore.pro:
00:24 Changeset [46107] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-19 Simon Hausmann <hausmann@webkit.org>

Rubber-stamped by Xan Lopez.

Skip new fast/dom/prototype-inheritance.html test in the Qt DRT
due to missing features/properties in the window object.

  • platform/qt/Skipped:

07/19/09:

20:56 Changeset [46106] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

2009-07-19 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[V8] Factor V8ConsoleMessage out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27421

No behavior change.

  • WebCore.gypi:
  • bindings/v8/V8ConsoleMessage.cpp: Added. (WebCore::V8ConsoleMessage::V8ConsoleMessage): (WebCore::V8ConsoleMessage::dispatchNow): (WebCore::V8ConsoleMessage::dispatchLater): (WebCore::V8ConsoleMessage::processDelayed): (WebCore::V8ConsoleMessage::handler):
  • bindings/v8/V8ConsoleMessage.h: Added. (WebCore::V8ConsoleMessage::Scope::Scope): (WebCore::V8ConsoleMessage::Scope::~Scope):
  • bindings/v8/V8Proxy.cpp: (WebCore::logInfo): (WebCore::reportUnsafeAccessTo): (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::newInstance): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::processConsoleMessages):
11:50 Changeset [46105] by rwlbuis@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Adam Barth.

Remove unused member variable.

  • svg/SVGPolyElement.h:
11:16 Changeset [46104] by eric.carlson@apple.com
  • 3 edits
    2 adds in trunk

2009-07-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

HTMLAudioElement: constructor should set "autobuffer" attribute
https://bugs.webkit.org/show_bug.cgi?id=27422

Test: media/audio-constructor-autobuffer.html

  • bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):

Set 'autobuffer' attribute.

2009-07-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

HTMLAudioElement: constructor should set "autobuffer" attribute
https://bugs.webkit.org/show_bug.cgi?id=27422

  • media/audio-constructor-autobuffer-expected.txt: Added.
  • media/audio-constructor-autobuffer.html: Added.
02:47 Changeset [46103] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-19 Thierry Bastian <thierry.bastian@nokia.com>

Reviewed by Simon Hausmann.

Fix the Qt build with mingw.

  • WebCore.pro: Don't use MSVC commandline options to disable warnings with mingw.
00:39 Changeset [46102] by abarth@webkit.org
  • 14 edits in trunk/WebCore

2009-07-19 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[V8] Phase 2: Remove event listener methods from V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27415

No behavior change.

  • bindings/v8/V8ObjectEventListener.cpp: (WebCore::weakObjectEventListenerCallback): (WebCore::V8ObjectEventListener::~V8ObjectEventListener):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::disconnectEventListeners):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::eventListeners): (WebCore::V8Proxy::objectListeners):
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp: (WebCore::getEventListener):
  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::~V8EventListener):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SVGElementInstanceCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::getEventListener):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::getEventListener):
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):

07/18/09:

16:13 Changeset [46101] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[Gtk] soup/ResourceHandleSoup.cpp:533: error: 'g_mapped_file_free' was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=27230

Use g_mapped_file_unref for GLIB version 2.22 onwards.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
16:03 Changeset [46100] by jmalonzo@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-07-18 Jorge Gonzalez <aloriel@gmail.com>

Rubber-stamped by Jan Alonzo.

es translation
https://bugs.webkit.org/show_bug.cgi?id=26319

  • es.po: Added.
16:00 Changeset [46099] by darin@apple.com
  • 4 edits in trunk/LayoutTests/fast

Remove some stray executable flags.

15:59 Changeset [46098] by mitz@apple.com
  • 2 edits in trunk

Added Radar URLs

15:58 Changeset [46097] by mitz@apple.com
  • 18 edits
    4 adds in trunk

WebCore:

Reviewed by Anders Carlsson.

Add spread radius support to -webkit-box-shadow
https://bugs.webkit.org/show_bug.cgi?id=27417

Test: fast/box-shadow/spread.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): Added a property ID parameter and used it to

include the spread length for box-shadow but not for text-shadow.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

Pass the property ID to valueForShadow().

  • css/CSSParser.cpp: (WebCore::ShadowParseContext::ShadowParseContext): Added property,

spread, and allowSpread members. Added a property ID parameter to
the constructor. Initialize the property and allowSpread members.

(WebCore::ShadowParseContext::allowLength): Added allowSpread.
(WebCore::ShadowParseContext::commitValue): Pass the spread value to

the ShadowValue constructor. Reset allowSpread.

(WebCore::ShadowParseContext::commitLength): Allow spread after blur

for the box-shadow property.

(WebCore::ShadowParseContext::commitColor): Reset allowSpread.
(WebCore::CSSParser::parseShadow): Pass the property ID to

ShadowParseContext().

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Get the spread value from

the shadow value and pass it to the ShadowData constructor.

  • css/ShadowValue.cpp: (WebCore::ShadowValue::ShadowValue): Added spread. (WebCore::ShadowValue::cssText): Added spread.
  • css/ShadowValue.h: (WebCore::ShadowValue::create): Added spread.
  • page/animation/AnimationBase.cpp: (WebCore::blendFunc): Blend the spread value. (WebCore::PropertyWrapperShadow::blend): Added 0 spread to the default

shadow.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Account for spread in

the visual overflow calculations.

(WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
(WebCore::InlineFlowBox::paint): Ditto.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): Ditto. (WebCore::RenderBlock::overflowWidth): Ditto. (WebCore::RenderBlock::overflowLeft): Ditto. (WebCore::RenderBlock::overflowTop): Ditto. (WebCore::RenderBlock::overflowRect): Ditto. (WebCore::RenderBlock::layoutBlock): Ditto.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Inflate the shadow-

casting rect by the shadow spread value. Adjust border radii if
necessary.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Account for spread in the

visual overflow calculations.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateRects): Ditto.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Account for spread. (WebCore::RenderObject::adjustRectForOutlineAndShadow): Ditto.
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect): Ditto.
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow): Assert that text shadows do not

have spread.

  • rendering/style/ShadowData.cpp: (WebCore::ShadowData::ShadowData): Added spread. (WebCore::ShadowData::operator==): Compare spread.
  • rendering/style/ShadowData.h: (WebCore::ShadowData::ShadowData): Added spread.

LayoutTests:

Reviewed by Anders Carlsson.

Test box-shadow spread radius
https://bugs.webkit.org/show_bug.cgi?id=27417

  • fast/box-shadow/spread.html: Added.
  • platform/mac/fast/box-shadow/spread-expected.checksum: Added.
  • platform/mac/fast/box-shadow/spread-expected.png: Added.
  • platform/mac/fast/box-shadow/spread-expected.txt: Added.
15:53 Changeset [46096] by jmalonzo@webkit.org
  • 4 edits in trunk

2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>

https://bugs.webkit.org/show_bug.cgi?id=27145
[Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html fails after r45615

Reviewed by Gustavo Noronha.

  • platform/gtk/Skipped:

Normalize file URLs.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpHistoryItem):
11:50 Changeset [46095] by pkasting@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Further improve non-Cygwin SVN support.

  • Scripts/prepare-ChangeLog: Harmless change to be consistent with other places that consume whitespace at the end of svn output.
  • Scripts/resolve-ChangeLogs: Add support for SVN 1.6. Slightly optimize svn info parsing based on technique in svn-create-patch. Normalize paths and consume whitespace in the same way as prepare-ChangeLog, for Windows systems with a non-Cygwin SVN. Force diff and patch to run in binary mode so that they won't "intelligently" screw up line endings.
10:48 Changeset [46094] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-18 Adam Barth <abarth@webkit.org>

Reviewed by Jan Alonzo.

Minor FrameLoader.cpp cleanup
https://bugs.webkit.org/show_bug.cgi?id=27406

No behavior change.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::executeIfJavaScriptURL):
10:47 Changeset [46093] by simon.fraser@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-18 Simon Fraser <simon.fraser@apple.com>

Fix Tiger DRT build.

  • DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow):
  • DumpRenderTree/mac/PixelDumpSupportMac.mm:
09:59 Changeset [46092] by simon.fraser@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-17 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

DRT doesn't reliably snapshot composited layers
https://bugs.webkit.org/show_bug.cgi?id=27399

If we're doing an "onscreen" pixel capture, it means that we're snapshotting a view
with composited content. In that case we need to force the view to display so that
the composited layers are rendered to the screen.

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):
08:02 Changeset [46091] by abarth@webkit.org
  • 6 edits in trunk/WebCore

2009-07-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

[V8] Move event listener methods from V8Proxy to V8EventListenerList
https://bugs.webkit.org/show_bug.cgi?id=27408

Move some event listener code out of V8Proxy and into the event
listener list.

I'd like to remove these methods from V8Proxy entirely and just expose
getters for the lists themselves, but I'll do that in a follow up
patch.

  • bindings/v8/V8EventListenerList.cpp: (WebCore::V8EventListenerList::findWrapper):
  • bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper):
  • bindings/v8/V8ObjectEventListener.cpp:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::findV8EventListener): (WebCore::V8Proxy::findOrCreateV8EventListener): (WebCore::V8Proxy::removeV8EventListener): (WebCore::V8Proxy::findObjectEventListener): (WebCore::V8Proxy::findOrCreateObjectEventListener): (WebCore::V8Proxy::removeObjectEventListener):
  • bindings/v8/V8Proxy.h:
01:45 Changeset [46090] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>

[Gtk] Skip tests that require new expected results, eventSender
and editing callbacks DRT support. Unreviewed.

  • platform/gtk/Skipped:
01:37 Changeset [46089] by abarth@webkit.org
  • 2 edits in trunk/WebCore

Revert 46088.

01:31 Changeset [46088] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-18 Adam Barth <abarth@webkit.org>

Reviewed by Jan Alonzo.

Minor FrameLoader.cpp cleanup
https://bugs.webkit.org/show_bug.cgi?id=27406

No behavior change.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::executeIfJavaScriptURL):
00:44 Changeset [46087] by jorlow@chromium.org
  • 16 edits
    2 deletes in trunk

WebCore:

2009-07-18 Jeremy Orlow <jorlow@chromium.org>

Rubber stamped by Adam Barth.

Revert https://bugs.webkit.org/show_bug.cgi?id=27383
https://bugs.webkit.org/show_bug.cgi?id=27407

Revert Jens' patch. I believe he forgot to include a file.

  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
  • bindings/v8/V8DataGridDataSource.cpp: Removed.
  • bindings/v8/V8DataGridDataSource.h: Removed.
  • bindings/v8/V8GCController.h:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):

LayoutTests:

2009-07-18 Jeremy Orlow <jorlow@chromium.org>

Rubber stamped by Adam Barth.

Revert https://bugs.webkit.org/show_bug.cgi?id=27383
https://bugs.webkit.org/show_bug.cgi?id=27407

Revert Jens' patch. I believe he forgot to include a file.

  • fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
Note: See TracTimeline for information about the timeline view.