Timeline


and

07/24/09:

20:50 Changeset [46388] by mitz@apple.com
  • 21 edits in trunk/WebCore

Reviewed by Darin Adler.

Add functions to print the glyph page trees for debugging
https://bugs.webkit.org/show_bug.cgi?id=27671

  • platform/graphics/FontData.h: Defined a description() method.
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::showSubtree): Added. Prints the node and

its descendants.

(showGlyphPageTrees): Added. Prints all glyph page trees.
(showGlyphPageTree): Added. Prints the glyph page tree for a given page.

  • platform/graphics/GlyphPageTreeNode.h:
  • platform/graphics/SegmentedFontData.cpp: (WebCore::SegmentedFontData::description): Added.
  • platform/graphics/SegmentedFontData.h:
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::description): Added. Uses the platform data

as the description for non-svg, non-custom fonts.

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/gtk/FontPlatformData.h:
  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/mac/FontPlatformData.h:
  • platform/graphics/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::description): Added. Returns the

description of the CGFont, the size and the synthetic style flags,
if set.

  • platform/graphics/qt/FontPlatformData.h:
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/win/FontPlatformData.h:
  • platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/wince/FontPlatformData.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/wince/FontPlatformData.h:
  • platform/graphics/wx/FontPlatformData.h:
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
18:49 Changeset [46387] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

In preparation for https://bugs.webkit.org/show_bug.cgi?id=27236:
Remove TCMALLOC_TRACK_DECOMMITED_SPANS. We'll always track decommitted spans.
We have tested this and show it has little impact on performance.

Reviewed by Mark Rowe.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::New): (WTF::TCMalloc_PageHeap::AllocLarge): (WTF::propagateDecommittedState): (WTF::mergeDecommittedStates): (WTF::TCMalloc_PageHeap::Delete): (WTF::TCMalloc_PageHeap::IncrementalScavenge):
18:13 Changeset [46386] by zimmermann@webkit.org
  • 2 edits in trunk/WebKitTools

Not reviewed. Add Kevin McCullough as reviewer in bugzilla.py

17:57 Changeset [46385] by darin@apple.com
  • 1 edit in trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm

Dorument?

17:56 Changeset [46384] by darin@apple.com
  • 3 edits in trunk/WebKit/mac

2009-07-24 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

REGRESSION (r46298): Exception after clicking on Bookmarks button in the Bookmarks Bar
https://bugs.webkit.org/show_bug.cgi?id=27667

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Moved the code to set the title here. This is late enough that both the view and representation exist.
  • WebView/WebDataSource.mm: (-[WebDataSource _makeRepresentation]): Removed the code to set the title from here. It's a bit too early.
16:46 Changeset [46383] by abarth@webkit.org
  • 23 edits in trunk/WebCore

2009-07-24 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

SVG and XPath memory leaks in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=27488

Add proper 'create' methods to SVGPodTypeWrappers and
XPathNSResolvers in the V8 bindings to avoid memory leaks.

Introduce convertToV8Object methods that accept PassRefPtrs and
clean up the use of get() and release() on RefPtrs.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object):
  • bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::V8SVGPODTypeWrapperCreatorForList::create): (WebCore::V8SVGPODTypeWrapperCreatorForList::V8SVGPODTypeWrapperCreatorForList): (WebCore::V8SVGStaticPODTypeWrapper::create): (WebCore::V8SVGStaticPODTypeWrapper::V8SVGStaticPODTypeWrapper): (WebCore::V8SVGStaticPODTypeWrapperWithPODTypeParent::create): (WebCore::V8SVGStaticPODTypeWrapperWithPODTypeParent::V8SVGStaticPODTypeWrapperWithPODTypeParent): (WebCore::V8SVGStaticPODTypeWrapperWithParent::create): (WebCore::V8SVGStaticPODTypeWrapperWithParent::V8SVGStaticPODTypeWrapperWithParent): (WebCore::V8SVGDynamicPODTypeWrapper::create): (WebCore::V8SVGDynamicPODTypeWrapper::V8SVGDynamicPODTypeWrapper): (WebCore::V8SVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ClientRectListCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER):
  • bindings/v8/custom/V8CustomXPathNSResolver.cpp: (WebCore::V8CustomXPathNSResolver::create):
  • bindings/v8/custom/V8CustomXPathNSResolver.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER):
  • bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
16:35 Changeset [46382] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip a test that is failing intermittently on the Windows build bot.

  • platform/win/Skipped:
16:26 Changeset [46381] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip a plug-in test that fails an assertion around 50% of the time.

  • platform/mac-snowleopard/Skipped:
16:02 Changeset [46380] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip two SVG tests that are giving unexpected results.

  • platform/mac-snowleopard/Skipped:
15:45 UsingGitWithWebKit edited by treat@kde.org
(diff)
15:45 Changeset [46379] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip two plug-in tests that are failing.

  • platform/mac-snowleopard/Skipped:
15:31 BuildingQtOnWindows edited by jpetso@gmx.at
Fix inconsistent instruction vs. corresponding explanation (paths were … (diff)
15:28 BuildingQtOnWindows edited by jpetso@gmx.at
I followed the guidelines here, and it seems make isn't shipped by Qt so … (diff)
15:20 Changeset [46378] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Land correct results for a SnowLeopard-only accessibility test.

  • platform/mac/accessibility/table-multi-bodies-expected.txt:
14:57 Changeset [46377] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

2009-07-24 Brian Weinstein <bweinstein@apple.com>

Reviewed by Jon Honeycutt.

Fix of <rdar://6310538> Middle-click panning should be springloaded while dragging
https://bugs.webkit.org/show_bug.cgi?id=21794

Create two new booleans to determine whether we have done a springloaded pan scroll, and update
the name of setPanScrollCursor to updatePanScrollState to more accurately describe what the function
does.

  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): Initialized two new booleans. (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::updatePanScrollState): Renamed from setPanScrollCursor. (WebCore::EventHandler::stopAutoscrollTimer): Clear the pan scrolling in progress flag. (WebCore::EventHandler::handleMouseReleaseEvent): Clear the pan scrolling button pressed flag.
  • page/EventHandler.h:
14:33 UsingGitWithWebKit edited by eli.fidler@torchmobile.com
(diff)
14:31 Changeset [46376] by dimich@chromium.org
  • 3 edits in trunk/WebCore

2009-07-24 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Changed WorkerContext destructor to not access possibly-freed WorkerThread.

Failed assertion in WorkerContext::~WorkerContext().
https://bugs.webkit.org/show_bug.cgi?id=27665

  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext):
    • workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Removed assertion that relies on WorkerThread still being alive (moved to DedicatedWorkerContext destructor).
14:18 Changeset [46375] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-24 Eli Fidler <eli.fidler@torchmobile.com>

Reviewed by Adam Treat.

Improve git workflow by populating commit messages with ChangeLog entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

If the user doesn't manually modify the ChangeLog files, use
prepare-ChangeLog to populate the git commit message. This behaviour
can be disabled by the 'webkitGenerateCommitMessage' git configuration option.

  • Scripts/commit-log-editor:
14:13 Changeset [46374] by treat@webkit.org
  • 1 edit
    11 adds in trunk/WebCore

2009-07-24 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=27657
Add more wince port files to WebCore

Written by Yong Li <yong.li@torchmobile.com> and Lyon Chen <lyon.chen@torchmobile.com>

  • loader/icon/wince/IconDatabaseWince.cpp: Added.
  • rendering/RenderThemeWince.cpp: Added.
  • rendering/RenderThemeWince.h: Added.
  • storage/wince/DatabaseThreadWince.cpp: Added.
  • storage/wince/DatabaseThreadWince.h: Added.
  • storage/wince/LocalStorageThreadWince.cpp: Added.
  • storage/wince/LocalStorageThreadWince.h: Added.
  • svg/graphics/wince/SVGResourceFilterWince.cpp: Added.
14:12 Changeset [46373] by rniwa@webkit.org
  • 3 edits
    4 adds in trunk

WebCore:

2009-07-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

execCommand('underline') can modify DOM outside of the contentEditable area
https://bugs.webkit.org/show_bug.cgi?id=24333

highestAncestorWithTextDecoration stops at the closest unsplittable element so that if text-decoration is applied
outside of it, we don't accidently modify the style attribute.

Tests: editing/style/textdecoration-outside-of-rooteditable.html

editing/style/textdecoration-outside-of-unsplittable-element.html

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): (WebCore::highestAncestorWithTextDecoration):

LayoutTests:

2009-07-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

execCommand('underline') can modify DOM outside of the contentEditable area
https://bugs.webkit.org/show_bug.cgi?id=24333

Tests to make sure we are not removing underline applied outside of root editable node or unsplittable element.

  • editing/style/textdecoration-outside-of-rooteditable-expected.txt: Added.
  • editing/style/textdecoration-outside-of-rooteditable.html: Added.
  • editing/style/textdecoration-outside-of-unsplittable-element-expected.txt: Added.
  • editing/style/textdecoration-outside-of-unsplittable-element.html: Added.
13:59 Changeset [46372] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2009-07-24 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27639

Tests that XSSAuditor does not prevent evaluation of scripts that only contain
non-canonical characters.

  • http/tests/security/xssAuditor/script-tag-safe-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-safe.html: Added.

2009-07-24 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27639

Fixes false positives when evaluating certain strings that only contain
non-canonical characters.

Test: http/tests/security/xssAuditor/script-tag-safe.html

  • page/XSSAuditor.cpp: (WebCore::isNonCanonicalCharacter): (WebCore::XSSAuditor::findInRequest):
12:54 Changeset [46371] by dimich@chromium.org
  • 5 edits
    3 adds in trunk

WebCore:

2009-07-24 Drew Wilson <atwilson@google.com>

Reviewed by Adam Barth.

Updated code generator to properly generate bindings for WorkerContext exposed functions.

Storing a reference to WorkerContext.postMessage() and calling it later yields a TypeError
https://bugs.webkit.org/show_bug.cgi?id=27419

Test: fast/workers/worker-call.html

  • bindings/js/JSWorkerContextBase.cpp: (WebCore::toJSDedicatedWorkerContext): (WebCore::toJSWorkerContext): Functions that convert from JSValue to the appropriate WorkerContext/DedicatedWorkerContext object.
  • bindings/js/JSWorkerContextBase.h: Added toJS*WorkerContext APIs.
  • bindings/scripts/CodeGeneratorJS.pm: Added code to appropriately check the passed-in this object when invoking functions at global scope.

LayoutTests:

2009-07-24 Drew Wilson <atwilson@google.com>

Reviewed by Adam Barth.

Added layout tests to exercise various use cases for calling functions defined on Worker global scope.

Storing a reference to WorkerContext.postMessage() and calling it later yields a TypeError
https://bugs.webkit.org/show_bug.cgi?id=27419

  • fast/workers/resources/worker-call.js: Added.
  • fast/workers/worker-call-expected.txt: Added.
  • fast/workers/worker-call.html: Added.
12:28 Changeset [46370] by eric@webkit.org
  • 9 edits in trunk/WebCore

2009-07-24 Drew Wilson <atwilson@google.com>

Reviewed by Adam Barth.

Refactor WorkerContext to move DedicatedWorker-specific APIs into DedicatedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27420

No new tests as the existing tests already provide sufficient coverage (this is just a refactoring with no new functionality).

  • DerivedSources.cpp: Added JSDerivedWorkerContext.cpp
  • DerivedSources.make: Added DerivedWorkerContext files
  • GNUmakefile.am: Added DerivedWorkerContext files
  • WebCore.gypi: Added DerivedWorkerContext files
  • WebCore.pro: Added DerivedWorkerContext files
  • WebCore.vcproj/WebCore.vcproj: Added DerivedWorkerContext files
  • WebCore.xcodeproj/project.pbxproj: Added DerivedWorkerContext files
  • bindings/js/JSDedicatedWorkerContextCustom.cpp: Added. (WebCore::JSDedicatedWorkerContext::mark): Custom mark function for onmessage event handler.
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): Supports conversion to JSDedicatedWorkerContext. (WebCore::toEventTarget):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark): Moved onmessage mark handling into DedicatedWorkerContext.
  • bindings/js/WorkerScriptController.cpp: Added appropriate casts to DedicatedWorkerContext for postMessage(). (WebCore::WorkerScriptController::initScript): Manually sets up the prototype chain for the worker context.
  • bindings/scripts/CodeGeneratorJS.pm: Changed special case code for WorkerContext to be triggered by new IsWorkerContext attribute.
  • bindings/scripts/CodeGeneratorV8.pm: Changed hard-coded tests for WorkerContext to support DedicatedWorkerContext.
  • bindings/v8/DOMObjectsInclude.h: Added DedicatedWorkerContext.h
  • bindings/v8/DerivedSourcesAllInOne.cpp: Added V8DedicatedWorkerContext.cpp
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Added code to reserve extra fields for V8DedicatedWorkerContext.
  • bindings/v8/V8Index.cpp: Now includes V8DedicatedWorkerContext.h in addition to V8WorkerContext.h
  • bindings/v8/V8Index.h: Added DedicatedWorkerContext as a non-node wrapper type. Removed WORKERCONTEXT as a valid template type.
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Creates DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): Returns DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::retrieve): Refactored to deal with DedicatedWorkerContext.
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: Added. Moved onmessage code from V8WorkerContextCustom.cpp (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: Moved onmessage code to V8DedicatedWorkerContextCustom.cpp
  • dom/EventTarget.cpp: (WebCore::EventTarget::toDedicatedWorkerContext):
  • dom/EventTarget.h:
  • workers/DedicatedWorkerContext.cpp: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::reportException): (WebCore::DedicatedWorkerContext::postMessage): (WebCore::DedicatedWorkerContext::dispatchMessage):
  • workers/DedicatedWorkerContext.h: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::create): (WebCore::DedicatedWorkerContext::toDedicatedWorkerContext): (WebCore::DedicatedWorkerContext::setOnmessage): (WebCore::DedicatedWorkerContext::onmessage):
  • workers/DedicatedWorkerContext.idl: Added.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Moved code that notifies parent that worker is closing down into DedicatedWorkerContext.
  • workers/WorkerContext.h: (WebCore::WorkerContext::isClosing): Exposed closing flag as an API so derived classes can access it.
  • workers/WorkerContext.idl:
  • workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): Calls into DedicatedWorkerContext to handle message.
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Creates a DedicatedWorkerContext when the thread starts up.
12:23 Changeset [46369] by dimich@chromium.org
  • 28 edits
    5 adds in trunk/WebCore

2009-07-24 Drew Wilson <atwilson@google.com>

Reviewed by Adam Barth.

Refactor WorkerContext to move DedicatedWorker-specific APIs into DedicatedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27420

No new tests as the existing tests already provide sufficient coverage (this is just a refactoring with no new functionality).

  • DerivedSources.cpp: Added JSDerivedWorkerContext.cpp
  • DerivedSources.make: Added DerivedWorkerContext files
  • GNUmakefile.am: Added DerivedWorkerContext files
  • WebCore.gypi: Added DerivedWorkerContext files
  • WebCore.pro: Added DerivedWorkerContext files
  • WebCore.vcproj/WebCore.vcproj: Added DerivedWorkerContext files
  • WebCore.xcodeproj/project.pbxproj: Added DerivedWorkerContext files
  • bindings/js/JSDedicatedWorkerContextCustom.cpp: Added. (WebCore::JSDedicatedWorkerContext::mark): Custom mark function for onmessage event handler.
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): Supports conversion to JSDedicatedWorkerContext. (WebCore::toEventTarget):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark): Moved onmessage mark handling into DedicatedWorkerContext.
  • bindings/js/WorkerScriptController.cpp: Added appropriate casts to DedicatedWorkerContext for postMessage(). (WebCore::WorkerScriptController::initScript): Manually sets up the prototype chain for the worker context.
  • bindings/scripts/CodeGeneratorJS.pm: Changed special case code for WorkerContext to be triggered by new IsWorkerContext attribute.
  • bindings/scripts/CodeGeneratorV8.pm: Changed hard-coded tests for WorkerContext to support DedicatedWorkerContext.
  • bindings/v8/DOMObjectsInclude.h: Added DedicatedWorkerContext.h
  • bindings/v8/DerivedSourcesAllInOne.cpp: Added V8DedicatedWorkerContext.cpp
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Added code to reserve extra fields for V8DedicatedWorkerContext.
  • bindings/v8/V8Index.cpp: Now includes V8DedicatedWorkerContext.h in addition to V8WorkerContext.h
  • bindings/v8/V8Index.h: Added DedicatedWorkerContext as a non-node wrapper type. Removed WORKERCONTEXT as a valid template type.
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Creates DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): Returns DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::retrieve): Refactored to deal with DedicatedWorkerContext.
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: Added. Moved onmessage code from V8WorkerContextCustom.cpp (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: Moved onmessage code to V8DedicatedWorkerContextCustom.cpp
  • dom/EventTarget.cpp: (WebCore::EventTarget::toDedicatedWorkerContext):
  • dom/EventTarget.h:
  • workers/DedicatedWorkerContext.cpp: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::reportException): (WebCore::DedicatedWorkerContext::postMessage): (WebCore::DedicatedWorkerContext::dispatchMessage):
  • workers/DedicatedWorkerContext.h: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::create): (WebCore::DedicatedWorkerContext::toDedicatedWorkerContext): (WebCore::DedicatedWorkerContext::setOnmessage): (WebCore::DedicatedWorkerContext::onmessage):
  • workers/DedicatedWorkerContext.idl: Added.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Moved code that notifies parent that worker is closing down into DedicatedWorkerContext.
  • workers/WorkerContext.h: (WebCore::WorkerContext::isClosing): Exposed closing flag as an API so derived classes can access it.
  • workers/WorkerContext.idl:
  • workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): Calls into DedicatedWorkerContext to handle message.
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Creates a DedicatedWorkerContext when the thread starts up.
12:01 Changeset [46368] by eric@webkit.org
  • 10 edits in trunk

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix the last of the x-frame constructor calls to have the right prototype chains
https://bugs.webkit.org/show_bug.cgi?id=27645

I also had to add support for passing arguments to constructors
in order to test the Worker constructor.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/resources/constructed-objects-prototypes.js:

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix the last of the x-frame constructor calls to have the right prototype chains
https://bugs.webkit.org/show_bug.cgi?id=27645

Fix the last few constructors to use their stored globalObject pointer when
constructing objects instead of the lexicalGlobalObject().

  • bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
  • bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::construct):
  • bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
  • bindings/js/JSWebKitPointConstructor.cpp: (WebCore::constructWebKitPoint):
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
11:05 Changeset [46367] by kenneth@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-07-24 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Adam Treat.

As per discussion on IRC, changed originalUrl by requestedUrl.

  • Api/qwebframe.cpp: (QWebFrame::requestedUrl):
  • Api/qwebframe.h:
  • tests/qwebframe/tst_qwebframe.cpp:
10:57 Changeset [46366] by kenneth@webkit.org
  • 5 edits in trunk/WebKit/qt

2009-07-24 Andre Pedralho <andre.pedralho@openbossa.org>

Reviewed by Adam Treat.

Removed void QWebFrame::renderContents(...) and added the Q_PROPERTY
clipRenderToViewport to control whether QWebFrame::render would call
FrameView::paintContents rather than FrameView::paint and do not clip
the frame content to viewport.
https://bugs.webkit.org/show_bug.cgi?id=26352

  • Api/qwebframe.cpp: (QWebFramePrivate::renderPrivate): (QWebFrame::clipRenderToViewport): (QWebFrame::setClipRenderToViewport):
  • Api/qwebframe.h:
  • Api/qwebframe_p.h: (QWebFramePrivate::QWebFramePrivate):
  • tests/qwebframe/tst_qwebframe.cpp:
10:56 Changeset [46365] by jianli@chromium.org
  • 4 edits in trunk/WebCore

2009-07-24 Jian Li <jianli@chromium.org>

Reviewed by Adam Barth.

[V8] Cleanup exception handling in worker evaluation code.
https://bugs.webkit.org/show_bug.cgi?id=27282

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::evaluate):
  • bindings/v8/WorkerContextExecutionProxy.h: (WebCore::WorkerContextExecutionState::WorkerContextExecutionState):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): (WebCore::WorkerScriptController::setException):
10:55 Changeset [46364] by kenneth@webkit.org
  • 5 edits
    2 adds in trunk/WebKit/qt

2009-07-24 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

[QT] Implement originalUrl getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867

  • Api/qwebframe.cpp: (QWebFrame::originalUrl):
  • Api/qwebframe.h:
  • tests/qwebframe/qwebframe.qrc:
  • tests/qwebframe/test1.html: Added.
  • tests/qwebframe/test2.html: Added.
  • tests/qwebframe/tst_qwebframe.cpp:
10:44 Changeset [46363] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-24 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

Reverting r46157, since it may be causing problems with Chromium
reliability (see http://crbug.com/17569).

https://bugs.webkit.org/show_bug.cgi?id=27388

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
10:39 Changeset [46362] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

REGRESSION: inspector seems broken in ToT WebKit
https://bugs.webkit.org/show_bug.cgi?id=27646

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled):
10:34 Changeset [46361] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

Add the shadow style member to the ShadowData constructor and ==
operator

  • rendering/style/ShadowData.cpp: (WebCore::ShadowData::ShadowData): (WebCore::ShadowData::operator==):
10:30 Changeset [46360] by jianli@chromium.org
  • 6 edits in trunk/WebCore

2009-07-24 Jian Li <jianli@chromium.org>

Reviewed by Eric Seidel.

[V8] More V8 bindings changes to use ErrorEvent.
https://bugs.webkit.org/show_bug.cgi?id=27630

  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object):
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
10:26 EFLWebKit edited by tonikitoo@gmail.com
(diff)
09:53 Changeset [46359] by bfulgham@webkit.org
  • 6 edits in trunk

WebCore:

2009-07-24 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Dave Hyatt.

Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.

  • platform/graphics/win/SimpleFontDataWin.cpp: Conditionalize references to ApplicationServices.h and WebKitSystemInterface.h

WebKit/win:

2009-07-24 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Dave Hyatt.

Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.

  • DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
  • WebDownload.h: Conditionalize include of CFNetwork.h
  • WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h
09:28 Changeset [46358] by mitz@apple.com
  • 2 edits in trunk/WebCore

Another attempted build fix

  • bindings/js/JSAbstractWorkerCustom.cpp:
09:28 Changeset [46357] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-24 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

cpplint crash when there is a duplicate header followed by another header.
https://bugs.webkit.org/show_bug.cgi?id=27625

  • Scripts/modules/cpplint.py: Ensure that include_state.header_types is updated even there is a duplicate header, which resulted in some code rearrangement. Also, changed some if's in this function to return early. This avoids having nearly the whole function content being indented.
  • Scripts/modules/cpplint_unittest.py: Added a test which would have exposed the crash.
09:27 Changeset [46356] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::toJS):
08:37 Changeset [46355] by treat@webkit.org
  • 4 edits in trunk/WebKitTools

2009-07-24 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Filetype support changes for cpplint and check_webkit_style
https://bugs.webkit.org/show_bug.cgi?id=27653

Introduce .c support for check_webkit_style, and remove support for
.cc files in favor of .cpp.

  • Scripts/check-webkit-style:
  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
07:26 Changeset [46354] by xan@webkit.org
  • 2 edits in trunk

2009-07-24 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Remove unneeded commas from PKG_CHECK_MODULES.

  • configure.ac:
06:44 Changeset [46353] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Kenneth Rohde Christiansen <kenneth@webkit.org>

Build fix for 64 bit Linux.

int64_t is long on Linux 64 bit and not long long, thus
getFileSize with a int64_t out value fails to build.

Use a temporary to work around the problem.

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::spaceNeeded):
06:44 Changeset [46352] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-24 Kenneth Rohde Christiansen <kenneth@webkit.org>

Build fix for Qt.

Fix build issue introduced in 46344
([Bug 22700] ApplicationCache should have size limit)

Remove method only added to the Qt ChromeClient.

  • WebCoreSupport/ChromeClientQt.h:
05:55 Changeset [46351] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-24 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

ApplicationCache Layout test failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=27648

Add http/tests/appcache/max-size.html to the Skipped file for now.

  • platform/gtk/Skipped:
05:37 BuildingQtOnWindows edited by mails2jaffar@hotmail.com
(diff)
05:31 Changeset [46350] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-24 Priit Laes <plaes@plaes.org>

Reviewed by Xan Lopez.

[Gtk] Password is saved into gnome-keyring even if auth. fails
https://bugs.webkit.org/show_bug.cgi?id=27560

Check authentication result and save password only when authentication
succeeds.

  • webkit/webkitsoupauthdialog.c: (free_authData): (response_callback): (save_password_callback):
03:50 Changeset [46349] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-24 Eli Fidler <eli.fidler@torchmobile.com>

Reviewed by David Levin.

Improve git workflow by populating commit messages with ChangeLog entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

add --[no-]write prepare-ChangeLog options to bash completion

  • Scripts/webkit-tools-completion.sh:
03:03 Changeset [46348] by eric@webkit.org
  • 21 edits in trunk

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Update all CREATE_DOM_*_WRAPPER callers to pass globalObject
https://bugs.webkit.org/show_bug.cgi?id=27644

Make a bunch more tests pass. Still not all of them.
The rest will pass when the last bits of bug 27634 land.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Update all CREATE_DOM_*_WRAPPER callers to pass globalObject
https://bugs.webkit.org/show_bug.cgi?id=27644

This is another attempt at making the change for bug 27634 smaller.
I included the changes to make_names.pl as well as any file which
used CREATE_DOM_*_WRAPPER macros.

The changes to the construct* functions are what fix the cases in
fast/dom/constructed-objects-prototypes.html

The changes to passing globalObject through CREATE_* are what fix
fast/dom/prototype-inheritance-2.html

  • bindings/js/JSCDATASectionCustom.cpp: (WebCore::toJSNewlyCreated): pass globalObject.
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSDOMBinding.h: updated macros to pass globalObject.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttributeNode): use globalObject() for wrapping return value. (WebCore::JSElement::setAttributeNodeNS): use globalObject() for wrapping return value. (WebCore::toJSNewlyCreated): pass globalObject.
  • bindings/js/JSEventCustom.cpp: (WebCore::JSEvent::clipboardData): pass globalObject. (WebCore::toJS): pass globalObject.
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::getNamedItems): use globalObject() for wrapping returned collection items. (WebCore::callHTMLCollection): use globalObject() for wrapping returned collection items. (WebCore::JSHTMLCollection::item): use globalObject() for wrapping returned collection items. (WebCore::toJS): pass globalObject.
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapper): pass globalObject.
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSTextCustom.cpp: (WebCore::toJSNewlyCreated): pass globalObject.
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::constructWebKitCSSMatrix): use constructors globalObject when constructing
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): use constructors globalObject when constructing
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::constructXSLTProcessor): use constructors globalObject when constructing
  • dom/make_names.pl:

Pass globalObject through CREATE_* macros and various support functions.

02:50 Changeset [46347] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Darin Adler and Adam Barth.

Build fix for x86 platforms.
https://bugs.webkit.org/show_bug.cgi?id=27602

  • jit/JIT.cpp:
02:15 Changeset [46346] by eric@webkit.org
  • 31 edits in trunk

2009-07-24 Andrei Popescu <andreip@google.com>

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Adds a unit test that ensures that the mechanism that
enforces the maximum size of the application cache is
working correctly.

  • http/tests/appcache/max-size-expected.txt: Added.
  • http/tests/appcache/max-size.html: Added.
  • http/tests/appcache/resources/maxsize.manifest: Added.

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Update CodeGeneratorJS.pm to support passing JSDOMGlobalObject* to toJS calls
https://bugs.webkit.org/show_bug.cgi?id=27643

This is an attempt to make this change as small as possible.
I started by including all changes to CodeGeneratorJS.pm from bug 27634,
and then made the minimal amount of other changes needed to support that change.

Most toJS implementations ignore their passed JSDOMGlobalObject.
There are stub 2-argument toJS, toJSNewlyCreated implementations to help compiling.
All places where it is not clear what we should pass as the global object
(or where the global object is simply not available, like for some SVG bindings)
we pass deprecatedGlobalObjectForPrototype instead.

  • bindings/js/JSCDATASectionCustom.cpp: (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException): pass the wrong globalObject for now
  • bindings/js/JSDOMBinding.h:

Pass the wrong global object to the CREATE_ macros for now.
In the next change we'll come back and pass the correct one.
That will require changes to make_names.pl.

(WebCore::DOMObjectWithGlobalPointer::scriptExecutionContext):
(WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
(WebCore::DOMObjectWithGlobalPointer::~DOMObjectWithGlobalPointer):
(WebCore::createDOMObjectWrapper):
(WebCore::getDOMObjectWrapper):
(WebCore::createDOMNodeWrapper):
(WebCore::getDOMNodeWrapper):
(WebCore::toJS): added to convert 2 arg calls to 3 arg calls to limit the scope of this change.
(WebCore::toJSNewlyCreated):

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::toJS): DOMWindow always uses its own prototype chain.
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSEventTarget.h:
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapper): pass globalObject to toJS(Document*) to avoid recursion (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject* (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::toJS): pass globalObject along
  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::inverse): pass wrong globalObject for now. (WebCore::JSSVGMatrix::rotateFromVector): pass wrong globalObject for now.
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
  • bindings/js/JSSVGPathSegListCustom.cpp:

All of these methods need a globalObject, but most SVG binding don't have
space for one, so we just pass the lexicalGlobalObject for now.

(WebCore::JSSVGPathSegList::initialize):
(WebCore::JSSVGPathSegList::getItem):
(WebCore::JSSVGPathSegList::insertItemBefore):
(WebCore::JSSVGPathSegList::replaceItem):
(WebCore::JSSVGPathSegList::removeItem):
(WebCore::JSSVGPathSegList::appendItem):

  • bindings/js/JSSVGPointListCustom.cpp: (WebCore::finishGetter): pass wrong globalObject for now. (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult):
  • bindings/js/JSSVGTransformListCustom.cpp: (WebCore::finishGetter): pass wrong globalObject for now. (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSTextCustom.cpp: (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
  • bindings/js/JSWorkerContextBase.cpp: (WebCore::toJS): WorkerContext always uses its own prototype chain since it's a GlobalObject subclass.
  • bindings/js/JSWorkerContextBase.h:
  • bindings/scripts/CodeGeneratorJS.pm:

All generated toJS calls now pass a globalObject.
All generated toJS implementations now expect a globalObject.
Simplified all the slot casts by using a "castedThis" local.
SVG bindings which don't have a globalObject() accessor pass the deprecated lexicalGlobalObject instead.
Simplified printing of constructor objects using a $constructorClassName variable.
All generated constructor functions follow the construct$className form to match the custom constructors.

02:14 Changeset [46345] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

typing "document.proto" in inspector throws exception
https://bugs.webkit.org/show_bug.cgi?id=27169

  • inspector/front-end/utilities.js: (Object.type):
02:12 Changeset [46344] by abarth@webkit.org
  • 40 edits
    5 adds in trunk

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Adds the WebApplicationCache class that is
used by the DumpRenderTree test application to
configure the Application Cache maximum size.

  • WebCoreSupport/WebApplicationCache.h: Added.
  • WebCoreSupport/WebApplicationCache.mm: Added.
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebKit.exp:

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebCoreSupport/ChromeClientQt.h:

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::reachedMaxAppCacheSize): Adds empty implementation of reachedMaxAppCacheSize.
  • WebCoreSupport/ChromeClientGtk.h:

2009-07-24 Andrei Popescu <andreip@google.com>

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700


Updated the project after adding WebApplicationCache.h/mm

  • WebKit.xcodeproj/project.pbxproj:

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebCoreSupport/WebChromeClient.h:

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700


  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebKitSupport/ChromeClientWx.h:

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

https://lists.webkit.org/pipermail/webkit-dev/2009-May/007560.html

This change implements a mechanism for limiting the maximum size of
the application cache file. When this size is reached, a ChromeClient
callback is invoked asynchronously and the saving of the last (failed)
cache is retried automatically.


This change also extends the ApplicationCacheStorage API by allowing
a client to query or modify the application cache without having to
load any resources into memory.

Test: http/tests/appcache/max-size.html

  • WebCore.base.exp: Exports the symbols required by the DumpRenderTree test application.
  • loader/EmptyClients.h: Adds empty implementation of the new ChromeClient methods.
  • loader/appcache/ApplicationCache.cpp:
  • loader/appcache/ApplicationCache.h: Adds the ability to calculate the approximate size of an ApplicationCache object.
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheGroup.h: Invokes the ChromeClient callback when the storage layer runs out of space. After the callback is invoked, we re-attempt to store the newest cache, in case the ChromeClient has freed some space.
  • loader/appcache/ApplicationCacheResource.cpp:
  • loader/appcache/ApplicationCacheResource.h: Adds the ability to calculate the approximate size of an ApplicationCacheResource object.
  • loader/appcache/ApplicationCacheStorage.cpp:
  • loader/appcache/ApplicationCacheStorage.h: Enforces a maximum size for the application cache file.
  • page/ChromeClient.h: Adds a new callback, invoked when the ApplicationCacheStorage reports that it has reached the maximum size for its database file.
  • platform/sql/SQLiteDatabase.cpp:
  • platform/sql/SQLiteDatabase.h: Adds a new method that allows querying for the amount of unused space inside the application cache database file.

2009-07-24 Andrei Popescu <andreip@google.com>

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Adds a unit test that ensures that the mechanism that
enforces the maximum size of the application cache is
working correctly.

  • http/tests/appcache/max-size-expected.txt: Added.
  • http/tests/appcache/max-size.html: Added.
  • http/tests/appcache/resources/maxsize.manifest: Added.

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Adds a new method on the LayoutTestController that
allows a JS unit test to configure the maximum size
of the Application Cache.

  • DumpRenderTree/LayoutTestController.cpp: (setAppCacheMaximumSizeCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAppCacheMaximumSize):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAppCacheMaximumSize):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAppCacheMaximumSize):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAppCacheMaximumSize):
01:42 Changeset [46343] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Use TextEncoding facilities to convert between UTF16 and UTF8
instead of rolling our own solution.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (convertUniCharToUTF8):
01:42 Changeset [46342] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Fix confusion in g_substr between length in bytes and length in
characters. Was causing crashes in some situations when dealing
with non-ASCII text encoded as UTF8.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (g_substr):
01:39 Changeset [46341] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-24 Adam Barth <abarth@webkit.org>

Rubber stamped by Eric Seidel.

Added andersca to list of reviewers.

  • Scripts/modules/bugzilla.py:
01:33 Changeset [46340] by mrowe@apple.com
  • 26 edits
    1 add in trunk/WebKitTools

Fix dozens of "Deallocation of a pointer not malloced" messages seen while running layout tests on the build bot.

Reviewed by Xan Lopez.

Memory allocated via FastMalloc was being deleted via the system memory allocator
due to an inconsistent including of FastMalloc.h. We address this by including it
from config.h and including config.h from every implementation file, as in our other
projects.

  • DumpRenderTree/ForwardingHeaders/wtf/FastMalloc.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h.
  • DumpRenderTree/config.h:
  • DumpRenderTree/mac/AccessibilityControllerMac.mm:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  • DumpRenderTree/mac/AppleScriptController.m:
  • DumpRenderTree/mac/CheckedMalloc.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
  • DumpRenderTree/mac/DumpRenderTreePasteboard.m:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:
  • DumpRenderTree/mac/EditingDelegate.mm:
  • DumpRenderTree/mac/EventSendingController.mm:
  • DumpRenderTree/mac/FrameLoadDelegate.mm:
  • DumpRenderTree/mac/GCControllerMac.mm:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/mac/NavigationController.m:
  • DumpRenderTree/mac/ObjCController.m:
  • DumpRenderTree/mac/ObjCPlugin.m:
  • DumpRenderTree/mac/ObjCPluginFunction.m:
  • DumpRenderTree/mac/PixelDumpSupportMac.mm:
  • DumpRenderTree/mac/PlainTextController.mm:
  • DumpRenderTree/mac/PolicyDelegate.mm:
  • DumpRenderTree/mac/ResourceLoadDelegate.mm:
  • DumpRenderTree/mac/TextInputController.m:
  • DumpRenderTree/mac/UIDelegate.mm:
  • DumpRenderTree/mac/WorkQueueItemMac.mm:
01:33 Changeset [46339] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Impossible to add an attribute to a node without attributes
https://bugs.webkit.org/show_bug.cgi?id=21108

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.set hovered): (WebInspector.ElementsTreeElement.prototype.toggleNewButton): (WebInspector.ElementsTreeElement.prototype.ondblclick): (WebInspector.ElementsTreeElement.prototype._startEditing): (WebInspector.ElementsTreeElement.prototype._addNewAttribute): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
  • inspector/front-end/inspector.css:
01:31 Changeset [46338] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-24 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Adds support for Firebug's magic $0 variable to access inspected node
https://bugs.webkit.org/show_bug.cgi?id=17907

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled): Added _inspectorCommandLineAPI.{

_inspectedNodes, _addInspectedNode, $0, $1, $n}

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): Stores the inspected node history

in _inspectorCommandLineAPI._inspectedNodes

(WebInspector.ElementsPanel):

01:22 Changeset [46337] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Dragging a resource in the sidebar should drag it's URL
https://bugs.webkit.org/show_bug.cgi?id=14410

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
01:21 Changeset [46336] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Double click on a resource in the sidebar should open that resource in Safari
https://bugs.webkit.org/show_bug.cgi?id=14409

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick): open a resource url
01:05 Changeset [46335] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

Revert "2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>"

This reverts commit 6a8ef1983c1dbfaebc636ba70a046d28b12b4aab.

00:59 Changeset [46334] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Darin Adler.

Build fix for x86 platforms.
https://bugs.webkit.org/show_bug.cgi?id=27602

  • jit/JIT.cpp:
00:55 Changeset [46333] by jmalonzo@webkit.org
  • 6 edits in trunk

2009-07-24 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

Bump pango version requirement to 1.12 and remove unnecessary #ifdefs.

  • platform/graphics/gtk/FontGtk.cpp: (WebCore::getDefaultPangoLayout):
  • platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/gtk/Language.cpp:

Bump pango version requirement to 1.12 which is the version that
came with Gtk 2.10.

  • configure.ac:
00:52 Changeset [46332] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Missing UIString and other localizedString.js fixes
https://bugs.webkit.org/show_bug.cgi?id=27288

  • English.lproj/localizedStrings.js:
00:51 Changeset [46331] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Should Syntax Highlight JSON
https://bugs.webkit.org/show_bug.cgi?id=27503

  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded):
00:44 Changeset [46330] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/DOMTimer.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27624

  • page/DragController.cpp: (WebCore::DragController::~DragController): (WebCore::documentFragmentFromDragData): (WebCore::DragController::dragEnded): (WebCore::DragController::dragEntered): (WebCore::DragController::dragExited): (WebCore::DragController::dragUpdated): (WebCore::DragController::performDrag): (WebCore::asFileInput): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::delegateDragSourceAction): (WebCore::DragController::concludeEditDrag): (WebCore::DragController::canProcessDrag): (WebCore::DragController::tryDHTMLDrag): (WebCore::DragController::mayStartDragAtEventLocation): (WebCore::getCachedImage): (WebCore::getImage): (WebCore::prepareClipboardForImageDrag): (WebCore::dragLocForDHTMLDrag): (WebCore::DragController::startDrag): (WebCore::DragController::doImageDrag): (WebCore::DragController::doSystemDrag): (WebCore::DragController::placeDragCaret):
00:44 Changeset [46329] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/Chrome.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27608

  • page/Chrome.cpp: (WebCore::Chrome::runBeforeUnloadConfirmPanel): (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::Chrome::shouldInterruptJavaScript): (WebCore::Chrome::setToolTip): (WebCore::Chrome::requestGeolocationPermissionForFrame): (WebCore::ChromeClient::generateReplacementFile): (WebCore::ChromeClient::paintCustomScrollbar):
00:43 Changeset [46328] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/Coordinates.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27614

  • page/Coordinates.cpp: (WebCore::Coordinates::toString):
00:42 Changeset [46327] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/DOMSelection.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27614

  • page/DOMSelection.cpp: (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::modify): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::deleteFromDocument):
  • page/DOMSelection.h:
00:42 Changeset [46326] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

x-frame constructor calls are instantiated with the wrong prototype chain
https://bugs.webkit.org/show_bug.cgi?id=27566

Add the test. Soon to be fixed by bug 27634.

  • fast/dom/constructed-objects-prototypes-expected.txt: Added.
  • fast/dom/constructed-objects-prototypes.html: Added.
  • fast/dom/resources/constructed-objects-prototypes.js: Added. (classNameForObject): (constructorPropertiesOnWindow):
00:31 Changeset [46325] by mrowe@apple.com
  • 6 edits in trunk

Roll out r46321 as it broke the Windows build.

00:28 Changeset [46324] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/DOMTimer.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27618

  • page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::~DOMTimer): (WebCore::DOMTimer::fired): (WebCore::DOMTimer::suspend): (WebCore::DOMTimer::resume): (WebCore::DOMTimer::canSuspend):
  • page/DOMTimer.h: (WebCore::DOMTimer::minTimerInterval): (WebCore::DOMTimer::setMinTimerInterval):
00:15 Changeset [46323] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

Add a command line option to run-javascriptcore-tests to explicitly opt out of attempting to rebuild JavaScriptCore.

Reviewed by Simon Hausmann.

This is primarily useful to speed up the build bots where one machine builds JavaScriptCore and a second runs the tests,
leading to situations where the build system unnecessarily feels that the need to recompile.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/run-javascriptcore-tests:
00:14 Changeset [46322] by eric@webkit.org
  • 11 edits in trunk/WebCore

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Classes call DOMObject::mark() explicitly, should call DOMObjectWithGlobal::mark() instead
https://bugs.webkit.org/show_bug.cgi?id=27641

Nothing uses globalObject() yet, but this was causing crashes
in the patch for bug 27634. This is covered by fast/dom/gc-6.html.

I decided to change these to Base
instead of DOMObjectWithGlobal:: for future-proofing. All autogenerated classes use a typedef Base
to avoid bugs like these. Sadly C++ does not have a built-in super
we could use.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::JSAbstractWorker::mark):
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::mark):
  • bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::mark):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
  • bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::getOwnPropertySlot):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::mark):
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::mark):
  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::mark):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::mark):
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::mark):
00:04 Changeset [46321] by bfulgham@webkit.org
  • 6 edits in trunk

WebCore:

2009-07-23 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.

  • platform/graphics/win/SimpleFontDataWin.cpp: Conditionalize references to ApplicationServices.h and WebKitSystemInterface.h

WebKit/win:

2009-07-23 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.

  • DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
  • WebDownload.h: Conditionalize include of CFNetwork.h
  • WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h

07/23/09:

23:58 Changeset [46320] by eric@webkit.org
  • 17 edits in trunk

2009-07-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make most DOMObjects hold onto a JSDOMGlobalObject*
https://bugs.webkit.org/show_bug.cgi?id=27588

inner.document.constructor is fixed because all properties on the window
object are created with the correct globalObject (instead of the lexical one).
Since all objects now carry a globalObject pointer, when document creates
HTMLDocumentConstructor it now has the right globalObject to use.

  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:

2009-07-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make most DOMObjects hold onto a JSDOMGlobalObject*
https://bugs.webkit.org/show_bug.cgi?id=27588

This change is almost entirely plumbing. Only one functional
change as part of this all (window.document.constructor has the correct prototype)
Changes are detailed below.

inner.document.constructor is fixed because all properties on the window
object are created with the correct globalObject (instead of the lexical one).
Since all objects now carry a globalObject pointer, when document creates
HTMLDocumentConstructor it now has the right globalObject to use.

Tests:

fast/dom/prototype-inheritance.html
fast/dom/prototype-inheritance-2.html

  • bindings/js/DOMObjectWithSVGContext.h: (WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):

Update the comment and add an ignored globalObject argument.

  • bindings/js/JSDOMBinding.h:

Pass a globalObject to all DOMObjects during creation. Currently it's the wrong global object.
Once toJS is passed a globalObject it will be the right one.

(WebCore::createDOMObjectWrapper):
(WebCore::createDOMNodeWrapper):

  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::globalObject): Makes binding generation easier.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::history): JSHistory is now passed a globalObject, but since it has no custom constructor it doesn't use it. (WebCore::JSDOMWindow::location): JSLocation is now passed a globalObject, but since it has no custom constructor it doesn't use it.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): JSLocation is now passed a globalObject, but since it has no custom constructor it doesn't use it.
  • bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
  • bindings/js/JSHTMLCollectionCustom.cpp: Re-factoring needed to pass globalObject to JSNamedNodesCollection constructor. (WebCore::getNamedItems): (WebCore::callHTMLCollection): (WebCore::JSHTMLCollection::canGetItemsForName): (WebCore::JSHTMLCollection::nameGetter): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem):
  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
  • bindings/js/JSNamedNodesCollection.cpp:

Now passed globalObject. This is tested by inner.document.forms.testForm.
The passed globalObject is still wrong until toJS is fixed.

(WebCore::JSNamedNodesCollection::JSNamedNodesCollection):

  • bindings/js/JSNamedNodesCollection.h:
  • bindings/js/JSSharedWorkerConstructor.cpp:

Add DOMConstructorObject missed by http://trac.webkit.org/changeset/45938
This class is not compiled by default, so not testable.

(WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor):

  • bindings/js/JSSharedWorkerConstructor.h:
  • bindings/scripts/CodeGeneratorJS.pm:

Make all bindings objects carry a globalObject pointer using DOMObjectWithGlobalPointer.
SVG bindings which need a context() pointer do not have enough space for globalObject() too.
WorkerContext does not need a globalObject (it is one), so special case it.
Make all .constructor calls use the stored globalObject(). This is what fixes window.document.constructor.
Make all constructors inherit from DOMConstructorObject for consistency. Since the auto-bound constructors
override createStructure anyway, there is no functional change here. Just completing work started in r45938.

23:50 Changeset [46319] by jmalonzo@webkit.org
  • 8 edits in trunk

2009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Eric Seidel.

[Gtk] Add implementation of GCController for DRT
https://bugs.webkit.org/show_bug.cgi?id=27636

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): (main):
  • DumpRenderTree/gtk/GCControllerGtk.cpp: (GCController::collect): (GCController::collectOnAlternateThread):

Enable tests that are now passing.

  • platform/gtk/Skipped:

Add SPI for GCController to use.

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_gc_collect_javascript_objects): (webkit_gc_collect_javascript_objects_on_alternate_thread): (webkit_gc_count_javascript_objects):
23:37 Changeset [46318] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-07-23 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Add new test to cover more prototype/constructor inheritance cases
https://bugs.webkit.org/show_bug.cgi?id=27622

This new test tries hard not to duplicate testing done
by other tests and instead test new objects and prototype chains
which will be fixed as soon as toJS is passed through the globalObject.

This test crawls the object tree under the inner window, finding
one of each type of JavaScript object. It depends on all objects having
a valid prototype chain with a unique name (which is not always the case).
The test tries to stress the cases where the objects would be lazily
creating other objects or their prototypes or constructors which would
require these objects to have a back-pointer to the globalObject to be
able to correctly wire up the prototype chains.

  • fast/dom/prototype-inheritance-2-expected.txt: Added.
  • fast/dom/prototype-inheritance-2.html: Added.
  • fast/dom/resources/prototype-inheritance-2.js: Added. (propertiesOnObject): (): (constructorNamesForWindow): (makeCrawlObject): (evalToCrawlObject): (pushPropertyValuesWithUnseenTypes): (crawl):
23:03 Changeset [46317] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Skip transitions/change-values-during-transition.html which
pass/fails intermittently

  • platform/gtk/Skipped:
22:49 Changeset [46316] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Skip tests that require expected outputs. Also skip failing tests,
with bugs raised against the failures.

  • platform/gtk/Skipped:
22:26 Changeset [46315] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip two new tests for GTK that use eventSender.

  • platform/gtk/Skipped:
22:10 Changeset [46314] by mrowe@apple.com
  • 39 edits in trunk/LayoutTests

Fix layout tests that incorrectly attempt to detect whether they're running inside DumpRenderTree using "if (layoutTestController)".

Rubber-stamped by Brady Eidson.

  • editing/execCommand/25256.html:
  • editing/execCommand/25320.html:
  • fast/canvas/arc-crash.html:
  • fast/css/emptyStyleTag.html:
  • fast/events/js-keyboard-event-creation.html:
  • fast/events/scrollbar-double-click.html:
  • fast/forms/select-no-name.html:
  • fast/history/window-open.html:
  • platform/mac/fast/events/objc-event-api.html:
  • platform/mac/fast/events/objc-keyboard-event-creation.html:
  • scrollbars/scrollbar-miss-mousemove-disabled.html:
  • scrollbars/scrollbar-miss-mousemove.html:
  • storage/domstorage/localstorage/clear.html:
  • storage/domstorage/localstorage/delete-removal.html:
  • storage/domstorage/localstorage/enumerate-storage.html:
  • storage/domstorage/localstorage/index-get-and-set.html:
  • storage/domstorage/localstorage/onstorage-attribute-markup.html:
  • storage/domstorage/localstorage/onstorage-attribute-setattribute.html:
  • storage/domstorage/localstorage/private-browsing-affects-storage.html:
  • storage/domstorage/localstorage/resources/window-open-second.html:
  • storage/domstorage/localstorage/simple-events.html:
  • storage/domstorage/localstorage/simple-usage.html:
  • storage/domstorage/localstorage/string-conversion.html:
  • storage/domstorage/localstorage/window-open.html:
  • storage/domstorage/sessionstorage/clear.html:
  • storage/domstorage/sessionstorage/delete-removal.html:
  • storage/domstorage/sessionstorage/enumerate-storage.html:
  • storage/domstorage/sessionstorage/index-get-and-set.html:
  • storage/domstorage/sessionstorage/onstorage-attribute-markup.html:
  • storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html:
  • storage/domstorage/sessionstorage/private-browsing-affects-storage.html:
  • storage/domstorage/sessionstorage/resources/window-open-second.html:
  • storage/domstorage/sessionstorage/simple-events.html:
  • storage/domstorage/sessionstorage/simple-usage.html:
  • storage/domstorage/sessionstorage/string-conversion.html:
  • storage/domstorage/sessionstorage/window-open.html:
  • storage/domstorage/window-attributes-exist.html:
  • svg/custom/stop-crash.svg:
21:59 Changeset [46313] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

And now with some valid JavaScript syntax!

  • http/tests/misc/redirect-to-about-blank.html:
21:51 Changeset [46312] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Remove unnecessary check for eventSender in an attempt to please the GTK build bot.

  • fast/css/getComputedStyle/getComputedStyle-text-overflow.html:
21:35 Changeset [46311] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Update build.webkit.org config for new machine.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
21:32 Changeset [46310] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Add a workaround for <rdar://problem/6925892> to the test that it affects.

Reviewed by Brady Eidson.

  • http/tests/misc/redirect-to-about-blank.html:
20:56 Changeset [46309] by beidson@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-23 Brady Eidson <beidson@apple.com>

Remove accidentally checked in code.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (waitUntilDoneWatchdogFired): (LayoutTestController::setWaitToDump):
20:00 Changeset [46308] by beidson@apple.com
  • 14 edits
    3 adds in trunk

WebCore:

2009-07-23 Brady Eidson <beidson@apple.com>

Reviewed by Geoff Garen.

WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=27595

Test: http/tests/misc/will-send-request-returns-null-on-redirect.html


  • inspector/InspectorController.cpp: (WebCore::InspectorController::removeResource): Null-check the request URL.


  • platform/network/cf/ResourceHandleCFNet.cpp: Ditto, and return null instead of creating an empty one. (WebCore::willSendRequest):

WebKit/win:

2009-07-23 Brady Eidson <beidson@apple.com>

Reviewed by Geoff Garen.

WebFrameLoaderClient on Windows doesn't gracefully handle a null request returned from willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=27595

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchWillSendRequest):

WebKitTools:

2009-07-23 Brady Eidson <beidson@apple.com>

Reviewed by Geoff Garen.

WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=27595

Add the ability to tell the LayoutTestController to return a null request for willSendRequest
redirect callbacks.


  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (setWillSendRequestReturnsNullOnRedirectCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::willSendRequestReturnsNullOnRedirect): (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::willSendRequest):

LayoutTests:

2009-07-23 Brady Eidson <beidson@apple.com>

Reviewed by Geoff Garen.

WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=27595

  • http/tests/misc/resources/redirect-to-http-url.php: Added.
  • http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
  • http/tests/misc/will-send-request-returns-null-on-redirect.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
19:54 Changeset [46307] by pdherbemont@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

2009-07-23 Pierre d'Herbemont <pdherbemont@apple.com>

Fix layout tests, no review.

Actually add the video-layer tests results for leopard, that were
forgotten in r46302. Also add test results for windows.

  • platform/mac-leopard/fast/layers/video-layer-expected.png: Added.
  • platform/mac-leopard/fast/layers/video-layer-expected.txt: Added.
  • platform/win/fast/layers/video-layer-expected.txt: Added.
19:38 Changeset [46306] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

19:38 Changeset [46305] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.8

New tag.

19:14 Changeset [46304] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix DumpRenderTree to not fail an assertion on launch on a new machine.

Reviewed Oliver Hunt.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(setDefaultsToConsistentValuesForTesting): Disable the XSS auditor. It being enabled
breaks all of the JavaScript tests within testStringByEvaluatingJavaScriptFromString,
which causes us to exit due to an assertion failure. It's not clear why the XSS auditor
decides to interfere with these tests.

18:40 Changeset [46303] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r46246.

17:55 Changeset [46302] by pdherbemont@apple.com
  • 4 edits
    1 copy
    1 add in trunk/LayoutTests

2009-07-23 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Following changes on the video controls, video-layer tests results need to
be updated in order to fix the layout tests.

  • platform/mac-leopard/fast/layers/video-layer-expected.checksum: Copied from LayoutTests/platform/mac/fast/layers/video-layer-expected.checksum.
  • platform/mac-leopard/fast/layers/video-layer-expected.png: Copied from LayoutTests/platform/mac/fast/layers/video-layer-expected.png.
  • platform/mac-leopard/fast/layers/video-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/layers/video-layer-expected.txt.
  • platform/mac/fast/layers/video-layer-expected.checksum: Removed.
  • platform/mac/fast/layers/video-layer-expected.png: Removed.
  • platform/mac/fast/layers/video-layer-expected.txt: Updated.
17:35 Changeset [46301] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

Bug 27633 - AXLoadComplete can be fired off to frequently
https://bugs.webkit.org/show_bug.cgi?id=27633

17:11 Changeset [46300] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-07-23 Darin Adler <darin@apple.com>

  • WebView/WebDataSource.mm: (-[WebDataSource _makeRepresentation]): Landed a comment I forgot last time.
17:09 Changeset [46299] by mrowe@apple.com
  • 3 edits
    1 copy
    1 move in trunk/LayoutTests

Update layout test results for three tests related to text fields as their metrics
have changed slightly since the results were last updated.

Rubber-stamped by Dan Bernstein.

  • platform/mac-leopard/fast/forms/text-control-intrinsic-widths-expected.txt: Copied from LayoutTests/fast/forms/text-control-intrinsic-widths-expected.txt.
  • platform/mac/fast/forms/input-text-maxlength-expected.txt:
  • platform/mac/fast/forms/input-text-paste-maxlength-expected.txt:
  • platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt: Renamed from LayoutTests/fast/forms/text-control-intrinsic-widths-expected.txt.
17:09 Changeset [46298] by darin@apple.com
  • 5 edits in trunk

WebCore:

2009-07-23 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

URL appears in back/forward button menu instead of title for items with custom representation
https://bugs.webkit.org/show_bug.cgi?id=27586
rdar://problem/5060337

  • WebCore.base.exp: Exported DocumentLoader::setTitle for use by Mac WebKit.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didChangeTitle): Tightened code to check if the document loader is the correct one; previously this would never happen because we'd commit the load before any title changes could be registered, but now we can encounter a case where we get a title during a provisional load.

WebKit/mac:

2009-07-23 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

URL appears in back/forward button menu instead of title for items with custom representation
https://bugs.webkit.org/show_bug.cgi?id=27586
rdar://problem/5060337

The problem is that DocumentLoader expects to store a title, but for custom representations
it is never passed to the document loader.

  • WebView/WebDataSource.mm: (-[WebDataSource _makeRepresentation]): Added a call to DocumentLoader::setTitle. Works as long as the title does not change during the document's lifetime, which is good enough for the simple cases in Safari.
16:44 Changeset [46297] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Update default state of the XSS auditor in GTK DumpRenderTree to match Mac and Windows
in hopes of fixing some layout test failures seen on the build bot.

Reviewed by Oliver Hunt.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

16:08 Changeset [46296] by mrowe@apple.com
  • 1 edit
    2 copies in trunk/LayoutTests

Windows appears to match the Leopard results for the CSS 2.1 counter tests that were failing.

  • platform/win/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt.
  • platform/win/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt.
16:00 Changeset [46295] by mitz@apple.com
  • 17 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

[CSS3 Backgrounds and Borders] Add support for inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=27582

Test: fast/box-shadow/inset.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): Set the ShadowValue’s shadow style to 'inset'

as needed.

  • css/CSSParser.cpp: (WebCore::ShadowParseContext::ShadowParseContext): Added style and allowStyle

members. Initialize the allowStyle member.

(WebCore::ShadowParseContext::commitValue): Pass the style value to the

ShadowValue constructor. Reset allowStyle.

(WebCore::ShadowParseContext::commitLength): Update allowStyle.
(WebCore::ShadowParseContext::commitColor): Ditto.
(WebCore::ShadowParseContext::commitStyle): Added. Sets the style member and

updates the state.

(WebCore::CSSParser::parseShadow): Parse the 'inset' keyword.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Get the style value from the

shadow value and pass it to the ShadowData constructor.

  • css/ShadowValue.cpp: (WebCore::ShadowValue::ShadowValue): Added style. (WebCore::ShadowValue::cssText): Added style.
  • css/ShadowValue.h: (WebCore::ShadowValue::create): Added style.
  • page/animation/AnimationBase.cpp: (WebCore::blendFunc): Added a blend function for shadow styles. When blending

between normal and inset shadows, all intermediate values map to normal.

(WebCore::PropertyWrapperShadow::blend): Added normal style to the default

shadow.


  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBoxShadow): Added a shadow style parameter,

which is passed through to RenderBoxModelObject::paintBoxShadow().

(WebCore::InlineFlowBox::paintBoxDecorations): Paint inset shadows on top of

the background.

  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations): Paint inset shadows on top of the

background.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Added a shadow style

parameter, and code to paint inset shadows.

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): Paint inset shadows on top of

the background.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations): Ditto.
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations): Ditto.
  • rendering/style/ShadowData.h: Added a ShadowStyle enum. (WebCore::ShadowData::ShadowData): Add and initialize a style member.

LayoutTests:

Reviewed by Dave Hyatt.

[CSS3 Backgrounds and Borders] Add support for inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=27582

  • fast/box-shadow/inset.html: Added.
  • platform/mac/fast/box-shadow/inset-expected.checksum: Added.
  • platform/mac/fast/box-shadow/inset-expected.png: Added.
  • platform/mac/fast/box-shadow/inset-expected.txt: Added.
15:53 Changeset [46294] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Fix false positives for switch statement indentation check in cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27615

Makes one-line case statements (e.g. "case foo: bar();") work.
Also a few general improvements to the robustness and readability of
the check, and more test cases.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
15:52 Changeset [46293] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-07-23 Simon Fraser <simon.fraser@apple.com>

Fix the build with UNUSED_PARAM(frame) for when ENABLE(3D_RENDERING) is not defined.

  • css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval):
15:49 Changeset [46292] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Add check for line-breaking rule #3 to cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27610

"An else if statement should be written as an if statement when
the prior if concludes with a return statement."

Implemented by a multi-line (kind of back-tracking) algorithm.
Comes with loads of unit tests. Fixes the check for label indentation
to be not so overzealous, as it didn't allow for completely unindented
goto labels (at the very start of a line).

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
15:37 Changeset [46291] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-07-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adele Peterson.

3d-transforms media query needs to look check that accelerated compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=27621

When evaluating a media query with '-webkit-transform-3d', we need to check the
runtime switch that toggles accererated compositing, and therefore 3D.

No test because we can't disable the pref dynamically in DRT.

  • css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval):
15:31 Changeset [46290] by mrowe@apple.com
  • 3 edits
    1 copy
    2 moves in trunk/LayoutTests

Update layout test results for two international text tests that are failing due to font differences.

Rubber-stamped by Dan Bernstein.

  • platform/mac-leopard/fast/text/international/thai-baht-space-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.checksum.
  • platform/mac-leopard/fast/text/international/thai-baht-space-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.png.
  • platform/mac-leopard/fast/text/international/thai-baht-space-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.txt.
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
  • platform/mac/fast/text/international/thai-baht-space-expected.txt:
15:13 Changeset [46289] by mrowe@apple.com
  • 3 edits
    2 copies in trunk/LayoutTests

Update layout test results for two CSS 2.1 counter tests that are failing due to font differences.

Rubber-stamped by Dan Bernstein.

  • platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.txt.
  • platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.txt.
  • platform/mac/css2.1/t1202-counter-04-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-04-b-expected.txt:
15:03 Changeset [46288] by pdherbemont@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2009-07-23 Pierre d'Herbemont <pdherbemont@apple.com>

Layout test fix so no review.

Add audio-controls-rendering layout test results for windows and leopard.

  • platform/mac-leopard/media/audio-controls-rendering-expected.txt: Added.
  • platform/win/media/audio-controls-rendering-expected.txt: Added.
14:40 Changeset [46287] by mrowe@apple.com
  • 10 edits in trunk/LayoutTests

Update layout test results for the addition of a new computed style property in r46285.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
14:17 Changeset [46286] by rniwa@webkit.org
  • 6 edits
    3 adds in trunk

WebCore:

2009-07-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand('underline') can't remove <U> underlines
https://bugs.webkit.org/show_bug.cgi?id=20215

This patch adds support for u, s, and strike to implicitlyStyledElementShouldBeRemovedWhenApplyingStyle so that
WebKit can remove those presentational tags when necessary.
It also modifies StyleChange::init not to add "text-decoration: none". Not only is this style meaningless
(does not override inherited styles) but it was also causing WebKit to generate extra spans with this style.

  • css/CSSValueList.cpp: (WebCore::CSSValueList::hasValue): True if the property contains the specified value
  • css/CSSValueList.h: Updated prototype
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): No longer adds "text-decoration: none" (WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): Supports text-decoration-related elements

LayoutTests:

2009-07-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand('underline') can't remove <U> underlines
https://bugs.webkit.org/show_bug.cgi?id=20215

This patch rebaselines toggle-styles.html because WebKit now passes three tests it used to fail.
toggle-style-2.html is added to test cases in which multiple styles are specified with tags.
We still fail some tests because WebKit doesn't properly support non-CSS mode but they are visually correct.

  • editing/execCommand/resources/toggle-style-2.js: Added. (testSingleToggle): (testDoubleToggle):
  • editing/execCommand/toggle-style-2-expected.txt: Added.
  • editing/execCommand/toggle-style-2.html: Added.
  • editing/execCommand/toggle-styles-expected.txt: Passes all the tests
14:03 Changeset [46285] by jberlin@apple.com
  • 3 edits
    2 adds in trunk

2009-07-23 Jessie Berlin <jberlin@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=27554
Expose the value of text-overflow in getComputedStyle.


Reviewed by Dan Bernstein.

Test: fast/css/getComputedStyle/getComputedStyle-text-overflow.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): Add text-overflow to the list of computedProperties. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return the value of the text-overflow property.
  • fast/css/getComputedStyle/getComputedStyle-text-overflow-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-text-overflow.html: Added.
13:48 Changeset [46284] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-23 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=27510

[S60 QtWebKit] Don't put some intermediate generated files into the final mmp project
file for linking. This is a temporary workaround for qmake bug in Symbian port, should
be reverted after qmake is fixed.

  • WebCore.pro:
13:37 Changeset [46283] by jianli@chromium.org
  • 2 edits in trunk/WebCore

2009-07-23 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

[V8] Fix an assert in running workers in Chrome.
https://bugs.webkit.org/show_bug.cgi?id=27620

The fix is to change V8DOMMap::removeAllDOMObjectsInCurrentThreadHelper
to do not call removeObjectsFromWrapperMap for certain types of DOM
objects that exist only in main thread.

  • bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjectsInCurrentThreadHelper):
12:24 Changeset [46282] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by David Hyatt.

Rebaseline for http://trac.webkit.org/changeset/46274
(The changeset rebaselined the expected results for mac but not for windows)

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
12:06 Changeset [46281] by hyatt@apple.com
  • 11 edits
    5 adds in trunk

WebCore:

2009-07-23 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27572
Implement support for background-attachment:local.

Added new test fast/overflow/overflow-with-local-attachment.html.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseFillProperty):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EFillAttachment):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapFillAttachment):
  • css/CSSValueKeywords.in:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
  • rendering/style/FillLayer.h: (WebCore::FillLayer::attachment): (WebCore::FillLayer::setAttachment): (WebCore::FillLayer::hasFixedImage): (WebCore::FillLayer::initialFillAttachment):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::backgroundAttachment): (WebCore::InheritedFlags::maskAttachment):
  • rendering/style/RenderStyleConstants.h: (WebCore::):

LayoutTests:

2009-07-23 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27572
Implement support for background-attachment:local.

Added new test fast/overflow/overflow-with-local-attachment.html.

  • fast/overflow/overflow-with-local-background-attachment.html: Added.
  • platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.checksum: Added.
  • platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.
  • platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.txt: Added.
11:55 Changeset [46280] by rniwa@webkit.org
  • 8 edits in trunk/WebCore

2009-07-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

copyInheritableProperties and removeComputedInheritablePropertiesFrom should be deprecated
https://bugs.webkit.org/show_bug.cgi?id=27325

This patch deprecates copyInheritableProperties because it has been used for two different purposes:

  1. Calculating the typing style.
  2. Moving HTML subtrees and seeking to remove redundant styles. These tasks should be broken out into two separate functions. New code should not use this function.

It deletes removeComputedInheritablePropertiesFrom because it hasn't been used anywhere.

There is no test since the patch does not change any behavior.

  • css/CSSComputedStyleDeclaration.cpp: removeComputedInheritablePropertiesFrom has been removed (WebCore::CSSComputedStyleDeclaration::deprecatedCopyInheritableProperties): has been renamed from copyInheritableProperties
  • css/CSSComputedStyleDeclaration.h: ditto
  • editing/DeleteSelectionCommand.cpp: ditto (WebCore::removeEnclosingAnchorStyle): ditto (WebCore::DeleteSelectionCommand::saveTypingStyleState): ditto
  • editing/EditCommand.cpp: ditto (WebCore::EditCommand::styleAtPosition): ditto
  • editing/RemoveFormatCommand.cpp: ditto (WebCore::RemoveFormatCommand::doApply): ditto
  • editing/ReplaceSelectionCommand.cpp: ditto (WebCore::handleStyleSpansBeforeInsertion): ditto (WebCore::ReplaceSelectionCommand::handleStyleSpans): ditto
  • editing/markup.cpp: ditto (WebCore::removeEnclosingMailBlockquoteStyle): ditto (WebCore::removeDefaultStyles): ditto (WebCore::createMarkup): ditto
11:42 Changeset [46279] by pdherbemont@apple.com
  • 7 edits in trunk

WebCore:

2009-07-22 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Audio element at default width shouldn't have time field.
https://bugs.webkit.org/show_bug.cgi?id=27589

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimeDisplayElement::setVisible): Make sure we don't forget to remember the visibility if there is no renderer.

LayoutTests:

2009-07-22 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Audio element at default width shouldn't have time field.
https://bugs.webkit.org/show_bug.cgi?id=27589

  • platform/mac-snowleopard/Skipped: Enables back audio-controls-rendering.
  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
11:29 Changeset [46278] by kenneth@webkit.org
  • 1 edit
    18 adds in trunk/LayoutTests

2009-07-23 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Adam Treat.

Added expected results for tests that we pass.

  • platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt: Added.
  • platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Added.
  • platform/qt/fast/box-shadow/transform-fringing-expected.txt: Added.
  • platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.txt: Added.
  • platform/qt/fast/css/attribute-selector-dynamic-expected.txt: Added.
  • platform/qt/fast/css/nth-child-dynamic-expected.txt: Added.
  • platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.
  • platform/qt/fast/dynamic/anchor-lock-expected.txt: Added.
  • platform/qt/fast/frames/frameset-style-recalc-expected.txt: Added.
  • platform/qt/fast/frames/iframe-text-contents-expected.txt: Added, equal to mac.
  • platform/qt/fast/frames/viewsource-on-image-file-expected.txt: Added.
  • platform/qt/fast/repaint/background-generated-expected.txt: Added, equal to mac.
  • platform/qt/fast/repaint/background-misaligned-expected.txt: Added, equal to mac.
  • platform/qt/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Added, equal to mac.
  • platform/qt/fast/text/international/hindi-whitespace-expected.txt: Added.
  • platform/qt/fast/transforms/bounding-rect-zoom-expected.txt: Added.
11:21 Changeset [46277] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

wx build fix, adding missing header.

11:10 Changeset [46276] by bdakin@apple.com
  • 3 edits in trunk/WebCore

2009-07-23 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27598 Clean up the
AccessibilityObject class

Mostly this is just moving empty stubs into the header rather than
muddying the cpp file with them. A few functions were made pure
virtual.

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isARIAControl): (WebCore::AccessibilityObject::clickPoint): (WebCore::AccessibilityObject::documentFrameView): (WebCore::AccessibilityObject::actionVerb):
  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::intValue): (WebCore::AccessibilityObject::layoutCount): (WebCore::AccessibilityObject::doAccessibilityHitTest): (WebCore::AccessibilityObject::focusedUIElement): (WebCore::AccessibilityObject::firstChild): (WebCore::AccessibilityObject::lastChild): (WebCore::AccessibilityObject::previousSibling): (WebCore::AccessibilityObject::nextSibling): (WebCore::AccessibilityObject::parentObjectIfExists): (WebCore::AccessibilityObject::observableObject): (WebCore::AccessibilityObject::linkedUIElements): (WebCore::AccessibilityObject::titleUIElement): (WebCore::AccessibilityObject::ariaRoleAttribute): (WebCore::AccessibilityObject::isPresentationalChildOfAriaRole): (WebCore::AccessibilityObject::ariaRoleHasPresentationalChildren): (WebCore::AccessibilityObject::roleValue): (WebCore::AccessibilityObject::ariaAccessiblityName): (WebCore::AccessibilityObject::ariaLabeledByAttribute): (WebCore::AccessibilityObject::ariaDescribedByAttribute): (WebCore::AccessibilityObject::accessibilityDescription): (WebCore::AccessibilityObject::ariaSelectedTextDOMRange): (WebCore::AccessibilityObject::axObjectCache): (WebCore::AccessibilityObject::axObjectID): (WebCore::AccessibilityObject::setAXObjectID): (WebCore::AccessibilityObject::anchorElement): (WebCore::AccessibilityObject::actionElement): (WebCore::AccessibilityObject::boundingBoxRect): (WebCore::AccessibilityObject::selectedTextRange): (WebCore::AccessibilityObject::selectionStart): (WebCore::AccessibilityObject::selectionEnd): (WebCore::AccessibilityObject::url): (WebCore::AccessibilityObject::selection): (WebCore::AccessibilityObject::stringValue): (WebCore::AccessibilityObject::title): (WebCore::AccessibilityObject::helpText): (WebCore::AccessibilityObject::textUnderElement): (WebCore::AccessibilityObject::text): (WebCore::AccessibilityObject::textLength): (WebCore::AccessibilityObject::selectedText): (WebCore::AccessibilityObject::accessKey): (WebCore::AccessibilityObject::widget): (WebCore::AccessibilityObject::widgetForAttachmentView): (WebCore::AccessibilityObject::setFocused): (WebCore::AccessibilityObject::setSelectedText): (WebCore::AccessibilityObject::setSelectedTextRange): (WebCore::AccessibilityObject::setValue): (WebCore::AccessibilityObject::setSelected): (WebCore::AccessibilityObject::makeRangeVisible): (WebCore::AccessibilityObject::childrenChanged): (WebCore::AccessibilityObject::addChildren): (WebCore::AccessibilityObject::hasChildren): (WebCore::AccessibilityObject::selectedChildren): (WebCore::AccessibilityObject::visibleChildren): (WebCore::AccessibilityObject::visiblePositionRange): (WebCore::AccessibilityObject::visiblePositionRangeForLine): (WebCore::AccessibilityObject::boundsForVisiblePositionRange): (WebCore::AccessibilityObject::setSelectedVisiblePositionRange): (WebCore::AccessibilityObject::visiblePositionForPoint): (WebCore::AccessibilityObject::nextVisiblePosition): (WebCore::AccessibilityObject::previousVisiblePosition): (WebCore::AccessibilityObject::visiblePositionForIndex): (WebCore::AccessibilityObject::indexForVisiblePosition): (WebCore::AccessibilityObject::index): (WebCore::AccessibilityObject::doAXRangeForLine): (WebCore::AccessibilityObject::doAXRangeForIndex): (WebCore::AccessibilityObject::doAXStringForRange): (WebCore::AccessibilityObject::doAXBoundsForRange): (WebCore::AccessibilityObject::updateBackingStore):
11:05 Changeset [46275] by bweinstein@apple.com
  • 4 edits in trunk/WebCore

Fix of <rdar://4877658> Dragging from the area between the horizontal/vertical scrollbars when status bar is showing starts a selection and autoscroll.

10:20 Changeset [46274] by hyatt@apple.com
  • 10 edits in trunk

WebCore:

2009-07-23 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27581
Drop the prefix from the box-shadow property.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::ShadowParseContext::commitLength): (WebCore::cssPropertyID):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):

LayoutTests:

2009-07-23 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.


https://bugs.webkit.org/show_bug.cgi?id=27581
Drop the prefix from the box-shadow property.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
09:55 Changeset [46273] by treat@webkit.org
  • 4 edits
    4 adds in trunk

WebCore:
2009-07-22 Viet-Trung Luu <viettrungluu@gmail.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=27289
When a mouse click occurs on a scrollbar without a preceding mouse move
onto it, the release isn't handled correctly (since
EventHandler::m_lastScrollbarUnderMouse isn't set on mouse down, but
only on mouse move). (Side comment: That scrollbar-handling code
in EventHandler is ugly. It should be fixed properly.)

Tests: scrollbars/scrollbar-miss-mousemove.html

scrollbars/scrollbar-miss-mousemove-disabled.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::updateLastScrollbarUnderMouse):
  • page/EventHandler.h:

LayoutTests:
2009-07-22 Viet-Trung Luu <viettrungluu@gmail.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=27289
Tests that mouse clicks/releases are handled properly on scrollbars
even when there is no mouse move onto the scrollbar (two cases: enabled
and disabled controls).

  • scrollbars/scrollbar-miss-mousemove-disabled-expected.txt: Added.
  • scrollbars/scrollbar-miss-mousemove-disabled.html: Added.
  • scrollbars/scrollbar-miss-mousemove-expected.txt: Added.
  • scrollbars/scrollbar-miss-mousemove.html: Added.
09:52 Changeset [46272] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-23 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by David Levin.

Update WebCore/page/BarInfo.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27606

  • page/BarInfo.cpp: (WebCore::BarInfo::visible):
09:52 Changeset [46271] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-23 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by David Levin.

Update WebCore/page/Console.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27606

  • page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix): (WebCore::Console::profile): (WebCore::Console::time):
09:32 Changeset [46270] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-23 Eli Fidler <eli.fidler@torchmobile.com>

Reviewed by Adam Treat.

Improve git workflow by populating commit messages with ChangeLog entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

add --[no-]write option to optionally output new ChangeLog entries to
stdout instead of modifying ChangeLog files

fix Torch Mobile copyright

  • Scripts/prepare-ChangeLog:
09:13 Changeset [46269] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Enable cpplint for .c files.
https://bugs.webkit.org/show_bug.cgi?id=27604

Also make sure that the check for NULL does not apply to .c files.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
08:51 Changeset [46268] by treat@webkit.org
  • 1 edit
    3 adds in trunk/JavaScriptCore

2009-07-22 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

Add wince specific memory files into wtf/wince
https://bugs.webkit.org/show_bug.cgi?id=27550

  • wtf/wince/FastMallocWince.h: Added.
  • wtf/wince/MemoryManager.cpp: Added.
  • wtf/wince/MemoryManager.h: Added.
07:31 Changeset [46267] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-07-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Add simple proxy support for QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=27495

Picks up proxy settings from the http_proxy environment
variable.

  • QtLauncher/QtLauncher.pro: Add QtNetwork dependency for all platforms.
  • QtLauncher/main.cpp: (MainWindow::MainWindow):
07:28 Changeset [46266] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-23 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Fix for missing mmap features in Symbian
https://bugs.webkit.org/show_bug.cgi?id=24540

Fix, conditionally for PLATFORM(SYMBIAN), as an alternative
to missing support for the MAP_ANON property flag in mmap.
It utilizes Symbian specific memory allocation features.

  • runtime/Collector.cpp
06:34 Changeset [46265] by hausmann@webkit.org
  • 6 edits in trunk

WebCore:

2009-07-23 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

Fix crashes with the QObject bindings after garbage collection.

There is one QtInstance per wrapped QObject, and that QtInstance keeps
references to cached JSObjects for slots. When those objects get
deleted due to GC, then they becoming dangling pointers.

When a cached member dies, it is now removed from the QtInstance's
cache.

As we cannot track the lifetime of the children, we have to remove
them from QtInstance alltogether. They are not cached and were
only used for mark(), but we _want_ them to be subject to gc.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::~QtInstance): Minor coding style cleanup, use qDeleteAll(). (JSC::Bindings::QtInstance::removeCachedMethod): New function, to clean m_methods and m_defaultMethod. (JSC::Bindings::QtInstance::mark): Avoid marking already marked objects. (JSC::Bindings::QtField::valueFromInstance): Don't save children for marking.
  • bridge/qt/qt_instance.h: Declare removeCachedMethod.
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod): Call removeCachedMethod with this on the instance.

WebKit/qt:

2009-07-23 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

Added a testcase to verify that cached methods in the QOBject bindings
remain alife even after garbage collection.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::protectBindingsRuntimeObjectsFromCollector):
03:24 Changeset [46264] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-23 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

Fixing two issues related to QtLauncher

  • MainWindow objects are not always freed after close
  • JavaScript window.close() sometimes crashes

https://bugs.webkit.org/show_bug.cgi?id=27601

  • QtLauncher/main.cpp: (MainWindow::MainWindow): (main):
03:20 Changeset [46263] by hausmann@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-23 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Rebaseline the Qt results for computed-style.html and
computed-style-without-rendered.html after r46240, similar to r46252.

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
02:57 Changeset [46262] by levin@chromium.org
  • 5 edits in trunk/LayoutTests

2009-07-23 David Levin <levin@chromium.org>

Rubber-stamped by Oliver Hunt.

Improve keyboard navigation of Select elements.
Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
on non-Mac platforms.
https://bugs.webkit.org/show_bug.cgi?id=22784

One more round of speculative fixes:

  • Really fix the general and win expected results. (They were missing a return.)
  • Disable the test for gtk (and remove the attempted workaround for that platform).
  • fast/forms/select-popup-pagekeys-expected.txt:
  • fast/forms/select-popup-pagekeys.html:
  • platform/gtk/Skipped:
  • platform/win/fast/forms/select-popup-pagekeys-expected.txt:
02:09 Changeset [46261] by levin@chromium.org
  • 3 edits
    1 copy in trunk/LayoutTests

2009-07-23 David Levin <levin@chromium.org>

Rubber-stamped by Oliver Hunt.

3 (speculative) fixes for the new layout test: select-popup-pagekeys

  • Help Windows to pass by adding platform results.
  • Fix the general expected results.
  • Fix select-popup-pagekeys on gtk which doesn't seem to implement eventSender.
  • fast/forms/select-popup-pagekeys-expected.txt:
  • fast/forms/select-popup-pagekeys.html:
  • platform/win/fast/forms/select-popup-pagekeys-expected.txt: Added.
01:01 Changeset [46260] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-23 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27599
'const unsigned' in return value

Remove const modifier from unsigned return value, as it does not
make sense.

  • dom/ErrorEvent.h:
00:52 Changeset [46259] by levin@chromium.org
  • 3 edits
    3 adds in trunk

2009-07-22 Jens Alfke <snej@chromium.org>

Reviewed by David Levin.

Bug 22784: Improve keyboard navigation of Select elements.
Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
on non-Mac platforms.
https://bugs.webkit.org/show_bug.cgi?id=22784
http://code.google.com/p/chromium/issues/detail?id=4576

WebCore:

New test: LayoutTests/fast/forms/select-popup-pagekeys.html

  • dom/SelectElement.cpp: (WebCore::nextValidIndex): New utility fn for traversing items of a select's list. (WebCore::SelectElement::menuListDefaultEventHandler): Added code to handle Home/End and PageUp/PageDn when ARROW_KEYS_POP_MENU is false.

LayoutTests:

  • LayoutTests/fast/forms/select-popup-pagekeys.html: Added.
  • LayoutTests/fast/forms/select-popup-pagekeys-expected.txt: Added
  • LayoutTests/platform/mac/fast/forms/select-popup-pagekeys-expected.txt: Added.
00:36 Changeset [46258] by xan@webkit.org
  • 3 edits in trunk/WebCore

2009-07-23 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

Fix a couple of compiler warnings.

  • platform/graphics/cairo/ImageBufferCairo.cpp: (copySurface):
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::containsCharacters):
00:19 Changeset [46257] by hausmann@webkit.org
  • 4 edits in trunk

WebCore:

2009-07-22 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by David Levin.

Enable HTML5 Datagrid defines for the Qt build.

  • WebCore.pro:

LayoutTests:

2009-07-22 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by David Levin.

Unskip HTML 5 Datagrid tests for the Qt DRT, as they pass.

  • platform/qt/Skipped:
00:00 Changeset [46256] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

Fix compiler warning.

  • tests/testwebsettings.c: (test_webkit_web_settings_user_agent):

07/22/09:

23:45 WebDevelopers edited by dbates@berkeley.edu
Removed outdated links to Safari version matrix, and FAQ. (diff)
23:32 Changeset [46255] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-22 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[V8] Make Node wrappers go fast
https://bugs.webkit.org/show_bug.cgi?id=27597

Profiles indicate we're spending a lot of time asking whether we're on
the main thread when looking up DOM wrappers for Nodes, but there isn't
much point in doing that work because Nodes only exist on the main
thread. I've also added an assert to keep us honest in this regard.

  • bindings/v8/V8DOMMap.cpp: (WebCore::): (WebCore::getDOMNodeMap): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getCurrentMainThread):
22:39 Changeset [46254] by sfalken@apple.com
  • 1 edit
    6 adds in trunk/WebKitTools

Checkpoint new Windows nightly launcher.


Reviewed by Mark Rowe.

  • WebKitLauncherWin: Added.
  • WebKitLauncherWin/Resource.h: Added.
  • WebKitLauncherWin/WebKitLauncherWin.cpp: Added. (getStringValue): Retrieve a string registry value. (applePathFromRegistry): Get an Apple-related path out of the registry. (copyEnvironmentVariable): Copy an environment variable. (safariInstallDir): Helper function to get the install directory for Safari. (safariBrowserExe): Helper function to get the full path of the Safari executable. (_tWinMain): Locate Safari and launch it after setting up an environment variable.
  • WebKitLauncherWin/WebKitLauncherWin.h: Added.
  • WebKitLauncherWin/WebKitLauncherWin.rc: Added.
  • WebKitLauncherWin/WebKitLauncherWin.vcproj: Added.
  • WebKitLauncherWin/webkit.ico: Added.
19:52 Changeset [46253] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-22 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove unneeded virtual destructor from ScriptSourceProvider
https://bugs.webkit.org/show_bug.cgi?id=27563

  • bindings/js/ScriptSourceProvider.h:
19:29 Changeset [46252] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

REGRESSION (r46240): /fast/css/getComputedStyle/computed-style & computed-style-without-renderer needs rebaseline for Windows
https://bugs.webkit.org/show_bug.cgi?id=27591

Rebaselines the tests.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
19:01 Changeset [46251] by rniwa@webkit.org
  • 7 edits
    8 adds in trunk

WebCore:

2009-07-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
https://bugs.webkit.org/show_bug.cgi?id=27476

executeStrikethrough and executeUnderline were toggling between "line-through" / "underline" and "none".
This patch adds executeToggleStyleInList that toggles a style in CSSValueList instead of toggling the entire value.
It modifies CSSComputedStyleDeclaration to return CSSValueList instead of CSSPrimitiveValue for text decorations,
and adds removeAll member function to CSSValueList.

Tests: editing/execCommand/toggle-text-decorations.html

fast/css/getComputedStyle/getComputedStyle-text-decoration.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::renderTextDecorationFlagsToCSSValue): Creates a CSSValueList (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Returns a CSSValueList instead of CSSValue
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Text decorations are space separated instead of comma separated
  • css/CSSValueList.cpp: (WebCore::CSSValueList::removeAll): Removes all values that match the specified value
  • css/CSSValueList.h:
  • editing/EditorCommand.cpp: (WebCore::applyCommandToFrame): Apply style to a frame using specified command (WebCore::executeApplyStyle): Uses applyCommandToFrame (WebCore::executeToggleStyleInList): Uses applyCommandToFrame (WebCore::executeToggleStyle): Toggles a style in CSSValueList (WebCore::executeStrikethrough): Uses executeToggleStyleInList (WebCore::executeUnderline): Uses executeToggleStyleInList

LayoutTests:

2009-07-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
https://bugs.webkit.org/show_bug.cgi?id=27476

toggle-text-decorations checks whether we can toggle text decorations with multiple styles properly.
e.g. execCommand("underline") should modify "text-decoration: underline overline" to "text-decoration: overline"

getComputedStyle-text-decorations checks whether the CSS value of text decoration and its computed style are
both space-separated CSSValueList instead of CSSPrimitiveValue or comma-separated CSSValueList.

  • editing/execCommand/resources/toggle-text-decorations.js: Added. (testSingleToggle):
  • editing/execCommand/toggle-text-decorations-expected.txt: Added.
  • editing/execCommand/toggle-text-decorations.html: Added.
  • fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-text-decoration.html: Added.
  • fast/css/getComputedStyle/resources: Added.
  • fast/css/getComputedStyle/resources/TEMPLATE.html: Added.
  • fast/css/getComputedStyle/resources/getComputedStyle-text-decoration.js: Added. (expect):
16:27 Changeset [46250] by abarth@webkit.org
  • 4 edits
    9 adds in trunk

2009-07-22 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27174
And
https://bugs.webkit.org/show_bug.cgi?id=26938

Tests prevention of attacks transformed by PHP Magic Quotes/PHP addslashes().

  • http/tests/security/xssAuditor/resources/echo-intertag-addslashes.pl: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-backslash.html: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-null-char.html: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html: Added.

2009-07-22 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27174
And
https://bugs.webkit.org/show_bug.cgi?id=26938

Code cleanup. Implements support for detecting attacks transformed by
PHP Magic Quotes/PHP addslashes().

Tests: http/tests/security/xssAuditor/script-tag-addslashes-backslash.html

http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html
http/tests/security/xssAuditor/script-tag-addslashes-null-char.html
http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html

  • page/XSSAuditor.cpp: (WebCore::isInvalidCharacter): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::normalize): Decodes HTML entities, removes backslashes, and removes control characters that could otherwise cause a discrepancy between the source code of a script and the outgoing HTTP parameters. (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::decodeHTMLEntities): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h:
15:48 Changeset [46249] by levin@chromium.org
  • 1 edit
    1 move in trunk/WebKitTools

2009-07-22 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

run-webkit-lint should be named check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=27568

This name better reflects the fact that it is about checking the style of files.

  • Scripts/check-webkit-style: Renamed from WebKitTools/Scripts/run-webkit-lint.
15:31 Changeset [46248] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Fix false positives in namespace indentation checks.
https://bugs.webkit.org/show_bug.cgi?id=27567

The regular expression detecting goto labels (in order
to skip those) was too permissive, which caused other
code like "Foo::Bar()" to be treated as a label too,
thereby not stopping the processing loop as expected.

Now comes with a stricter regexp, and more demanding
test cases to check for these issues.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
15:17 Changeset [46247] by barraclough@apple.com
  • 15 edits in trunk/JavaScriptCore

2009-07-22 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

With ENABLE(ASSEMBLER_WX_EXCLUSIVE), only change permissions once per repatch event.
( https://bugs.webkit.org/show_bug.cgi?id=27564 )

Currently we change permissions forwards and backwards for each instruction modified,
instead we should only change permissions once per complete repatching event.

2.5% progression running with ENABLE(ASSEMBLER_WX_EXCLUSIVE) enabled,
which recoups 1/3 of the penalty of running with this mode enabled.

  • assembler/ARMAssembler.cpp: (JSC::ARMAssembler::linkBranch):
    • Replace usage of MakeWritable with cacheFlush.


  • assembler/ARMAssembler.h: (JSC::ARMAssembler::patchPointerInternal): (JSC::ARMAssembler::repatchLoadPtrToLEA):
    • Replace usage of MakeWritable with cacheFlush.
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::relinkJump): (JSC::ARMv7Assembler::relinkCall): (JSC::ARMv7Assembler::repatchInt32): (JSC::ARMv7Assembler::repatchPointer): (JSC::ARMv7Assembler::repatchLoadPtrToLEA): (JSC::ARMv7Assembler::setInt32):
    • Replace usage of MakeWritable with cacheFlush.
  • assembler/LinkBuffer.h: (JSC::LinkBuffer::performFinalization):
    • Make explicit call to cacheFlush.
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodeRef::MacroAssemblerCodeRef):
    • Make size always available.
  • assembler/RepatchBuffer.h: (JSC::RepatchBuffer::RepatchBuffer): (JSC::RepatchBuffer::~RepatchBuffer):
    • Add calls to MakeWritable & makeExecutable.
  • assembler/X86Assembler.h: (JSC::X86Assembler::relinkJump): (JSC::X86Assembler::relinkCall): (JSC::X86Assembler::repatchInt32): (JSC::X86Assembler::repatchPointer): (JSC::X86Assembler::repatchLoadPtrToLEA):
    • Remove usage of MakeWritable.
  • bytecode/CodeBlock.h: (JSC::CodeBlock::getJITCode):
    • Provide access to CodeBlock's JITCode.
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::makeExecutable): (JSC::ExecutableAllocator::cacheFlush):
    • Remove MakeWritable, make cacheFlush public.
  • jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress): (JSC::JIT::privateCompile): (JSC::JIT::unlinkCall): (JSC::JIT::linkCall):
    • Add CodeBlock argument to RepatchBuffer.
  • jit/JIT.h:
    • Pass CodeBlock argument for use by RepatchBuffer.
  • jit/JITCode.h: (JSC::JITCode::start): (JSC::JITCode::size):
    • Provide access to code start & size.
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchMethodCallProto): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
    • Add CodeBlock argument to RepatchBuffer.
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
    • Pass CodeBlock argument for use by RepatchBuffer.
15:12 Changeset [46246] by oliver@apple.com
  • 2 edits in trunk/WebCore

Null deref in JSObject::mark due to null xhr wrapper
https://bugs.webkit.org/show_bug.cgi?id=27565

Reviewed by Adele Peterson.

Make event target binding for appcache and xhr behave in the same way as
it does for all other events.

No test as I couldn't make a testcase which was remotely reliable.

15:10 Changeset [46245] by levin@chromium.org
  • 4 edits in trunk

2009-07-22 Takeshi Yoshino <tyoshino@google.com>

Reviewed by Darin Adler.

VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp
https://bugs.webkit.org/show_bug.cgi?id=26375

WebKit/win:

Replace a multiplication sign (U+00D7) encoded in UTF-8 (0xC3 0x97) in WebCoreLocalizedStrings.cpp
with hex escape sequences.

VC2005 failed to build due to this raw UTF-8 data in source code. Here's the warning message (
treated as an error and stopped build).

WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that cannot be
represented in the current code page (932). Save the file in Unicode format to prevent data loss

A change on WebKitTools/Scripts/extract-localizable-strings is attached to this change not to break
localized string generation process.

  • WebCoreLocalizedStrings.cpp: (WebCore::imageTitle):

WebKitTools:

Make it able to use hexadecimal escape sequences in .*UI_STRING(_KEY)? macros. Now,
the extract-localizable-strings script unescapes hexadecimal escape sequences in string literals
in the macros before writing out them into the file to update.

By this fix, we can eliminate raw UTF-8 strings in source code while using raw UTF-16 big endian
strings in the Localizable.strings file.

Bonus: There's no longer extract-webkit-localizable-strings script. Fix usage message to guide
users to update-webkit-localizable-strings.

  • Scripts/extract-localizable-strings:
15:09 Changeset [46244] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-22 Shinichiro Hamaji <hamaji@google.com>

Reviewed by David Levin.

Tiny typo fixes for cpplint.py
https://bugs.webkit.org/show_bug.cgi?id=27530

  • Scripts/modules/cpplint.py:
15:09 Changeset [46243] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-22 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

run-webkit-lint checks code which are not changed
https://bugs.webkit.org/show_bug.cgi?id=27529

Add check if the line is newly added.

  • Scripts/run-webkit-lint:
15:09 Changeset [46242] by levin@chromium.org
  • 4 edits in trunk/WebKitTools

2009-07-22 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

run-webkit-lint should have --git-commit option
https://bugs.webkit.org/show_bug.cgi?id=27528

  • Scripts/modules/cpplint.py:
  • Scripts/run-webkit-lint:
15:09 Changeset [46241] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-22 Mads Ager <ager@chromium.org>

Reviewed by David Levin.

Inform V8 of the amount of WebCore string memory it is keeping alive.
https://bugs.webkit.org/show_bug.cgi?id=27537

V8 uses external strings that are backed by WebCore strings. Since
the external strings themselves are small, V8 has no way of
knowing how much memory it is actually holding on to. With this
change, we inform V8 of the amount of WebCore string data it is
holding on to with external strings.

  • bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource):
14:59 Changeset [46240] by hyatt@apple.com
  • 15 edits
    12 adds in trunk

WebCore:

2009-07-22 David Hyatt <hyatt@apple.com>

Reviewed by Beth Dakin.

https://bugs.webkit.org/show_bug.cgi?id=27562
Add the finalized versions of background-clip and background-origin. Remove background-clip from
the background shorthand and have it be auto-set based off background-origin's value.

Three new tests added in fast/backgrounds/size

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::parseFillProperty):
  • css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSValueKeywords.in:

LayoutTests:

2009-07-22 David Hyatt <hyatt@apple.com>

Reviewed by Beth Dakin.

https://bugs.webkit.org/show_bug.cgi?id=27562
Add some new layout tests that drop the prefix from the background properties and use origin
in a shorthand. Update shorthand results and computed style results to account for new properties.

  • fast/backgrounds/size/backgroundSize20.html: Added.
  • fast/backgrounds/size/backgroundSize21.html: Added.
  • fast/backgrounds/size/backgroundSize22.html: Added.
  • fast/css/background-position-serialize-expected.txt:
  • fast/css/remove-shorthand-expected.txt:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt: Added.
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/inspector/style-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
14:47 Changeset [46239] by jorlow@chromium.org
  • 16 edits
    3 adds in trunk

WebCore:

2009-07-22 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

Hook up V8 bindings for DataGrid elements.
https://bugs.webkit.org/show_bug.cgi?id=27383
http://code.google.com/p/chromium/issues/detail?id=16730

Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.

  • WebCore.gypi: Added new source files.
  • bindings/scripts/CodeGeneratorV8.pm: Made GenerateBatchedAttributeData put #if's around conditional attributes.
  • bindings/v8/DOMObjectsInclude.h: #include DataGrid headers.
  • bindings/v8/V8DOMWrapper.cpp: Add bindings from HTML tags to datagrid templates. (WebCore::V8DOMWrapper::getTemplate): Customize datagrid template.
  • bindings/v8/V8DataGridDataSource.cpp: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::V8DataGridDataSource): (WebCore::V8DataGridDataSource::~V8DataGridDataSource):
  • bindings/v8/V8DataGridDataSource.h: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::create): (WebCore::V8DataGridDataSource::isJSDataGridDataSource): (WebCore::V8DataGridDataSource::jsDataSource): (WebCore::asV8DataGridDataSource):
  • bindings/v8/V8GCController.h: Added new handle type "DATASOURCE".
  • bindings/v8/V8Index.h: Conditionalize datagrid stuff.
  • bindings/v8/custom/V8CustomBinding.h: Declare more accessors. Conditionalize.
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Fill in dataSource accessors. (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):

LayoutTests:

2009-07-22 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

Hook up V8 bindings for DataGrid elements.
https://bugs.webkit.org/show_bug.cgi?id=27383
http://code.google.com/p/chromium/issues/detail?id=16730

Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.

  • fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
13:46 Changeset [46238] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2009-07-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

pushDownTextDecorationStyleAroundNode needs clean up
https://bugs.webkit.org/show_bug.cgi?id=27556

Cleaned up. pushDownTextDecorationStyleAroundNode traverses tree vertically from highestAncestor to targetNode
While traversing, it will apply the specified style to all nodes but targetNode.
i.e. the style is applies to all ancestor nodes and their siblings of targetNode.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Cleaned up and added comments
  • editing/ApplyStyleCommand.h: Updated prototype
13:35 Changeset [46237] by pkasting@chromium.org
  • 4 edits in trunk/WebCore

2009-07-22 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Handle any type of line endings in WebCore/css/*CSSPropertyNames.in.

  • DerivedSources.make:
  • css/makeprop.pl:
  • css/makevalues.pl:
13:32 Changeset [46236] by pkasting@chromium.org
  • 4 edits in trunk/WebKitTools

2009-07-22 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Factor svn-create-patch's "determineSvnRoot()" into a function in
VCSUtils.pm so commit-log-editor can use it too.

  • Scripts/VCSUtils.pm: Add determineSVNRoot().
  • Scripts/commit-log-editor: Use determineSVNRoot() instead of old code (which didn't work as well).
  • Scripts/svn-create-patch: Remove determineSvnRoot() (moved).
13:18 Changeset [46235] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

Revert bugfix for 27557 as this is invalid according to Darin Adler
who states that include order sorting should be case-sensitive.

13:06 Changeset [46234] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-22 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

expand prototype-inheritance test to cover constructors
https://bugs.webkit.org/show_bug.cgi?id=27547

  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/resources/prototype-inheritance.js:
13:05 Changeset [46233] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Case-insensitive comparison of include file order for cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27557

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
13:00 Changeset [46232] by ggaren@apple.com
  • 5 edits
    1 add in branches/nitro-extreme/WebCore

2009-07-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Removed some trivial differences between the branch and r45633, to
facilitate the merge.

  • bindings/js/ScriptEventListener.cpp:
  • bridge/c/c_instance.cpp:
  • inspector/front-end/Images/resourcesSilhouette.png: Added.
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::paintObject):
  • rendering/RenderDataGrid.h:
12:51 Changeset [46231] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Fix cpplint generating false positives for
"primary" includes in headers.
https://bugs.webkit.org/show_bug.cgi?id=27553

Doing so by only flagging includes in header files
as primary when the include filename exactly matches
the header filename.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
12:24 Changeset [46230] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

cpplint generates false positives for primary includes
https://bugs.webkit.org/show_bug.cgi?id=27544

Fix false positives for instances when cpplint would
normally classify multiple includes as primary: After
the first primary include, classify subsequent ones as
"other" includes even if they look like primary ones.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
11:55 Changeset [46229] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-22 Paul Godavari <paul@chromium.org>

Reviewed by Darin Fisher.

Chromium has a build break after removal of JSRGBColor bindings
https://bugs.webkit.org/show_bug.cgi?id=27548

Fix a build break in Chromium V8 after the JSRGBColor bindings change:
https://bugs.webkit.org/show_bug.cgi?id=27242

  • bindings/scripts/CodeGeneratorV8.pm:
11:46 Changeset [46228] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-22 Gabor Rapcsanyi <rapcsanyi.gabor@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Pass XAUTHORITY environment variable to $dumpTool as well.

  • Scripts/run-webkit-tests:
10:02 Changeset [46227] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-07-20 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r39185): Safari adds ".jpeg" extension to images that already have ".JPG" extension
https://bugs.webkit.org/show_bug.cgi?id=27472

  • WebView/WebHTMLView.mm: (matchesExtensionOrEquivalent): Changed category method into a C function. Made it require the leading dot when checking for the extension and do it in a non-case-sensitive way. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Changed to call the function.
09:56 Changeset [46226] by agl@chromium.org
  • 3 edits in trunk/WebCore

2009-07-22 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: add static functions to FontPlatformData which allow
for setting the global font rendering preferences.

https://bugs.webkit.org/show_bug.cgi?id=27513
http://code.google.com/p/chromium/issues/detail?id=12179

This should not affect any layout tests.

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setHinting): (WebCore::FontPlatformData::setAntiAlias): (WebCore::FontPlatformData::setSubpixelGlyphs): (WebCore::FontPlatformData::setupPaint):
  • platform/graphics/chromium/FontPlatformDataLinux.h:
08:20 Changeset [46225] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Add check for correct wtf includes to cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27524

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
08:15 Changeset [46224] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by David Levin.

Add checks for multi-line boolean operator placement.
https://bugs.webkit.org/show_bug.cgi?id=27496

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
07:13 Changeset [46223] by zecke@webkit.org
  • 2 edits in trunk/WebKitSite

2009-07-22 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam Treat.

Mention the new webkit-help and webkit-jobs mailinglist. Change
the description of webkit-dev to be more strict.

  • contact.html:
06:34 Changeset [46222] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-22 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Move Inspector panels creation into a function to make possible introducing
custom panels.

06:33 Changeset [46221] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Remove unused variables.

  • webkit/webkitwebview.cpp: (webkit_web_view_grab_focus): (webkit_web_view_focus_in_event):
06:30 Changeset [46220] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-07-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Print console command message upon evaluate
selection request; Handle errors in evaluation request
properly.

https://bugs.webkit.org/show_bug.cgi?id=27535

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
06:04 Changeset [46219] by kenneth@webkit.org
  • 2 edits in trunk/WebKitSite

2009-07-22 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Adam Treat.

Coding style - Clarify some cases with spacing
https://bugs.webkit.org/show_bug.cgi?id=27499

Add explicit rule about no space before comma or semicolon.

  • coding/coding-style.html:
00:47 WebKit Team edited by rniwa@webkit.org
(diff)
00:46 WebKit Team edited by rniwa@webkit.org
(diff)
00:17 Changeset [46218] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-22 Xan Lopez <xlopez@igalia.com>

Attempt to fix the GTK+ build.

  • GNUmakefile.am:

07/21/09:

23:54 Changeset [46217] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Qt build.

  • WebCore.pro: Add RGBColor.cpp to the build, remove JSRGBColor.
23:19 Changeset [46216] by abarth@webkit.org
  • 9 edits
    1 add in trunk/WebCore

2009-07-21 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27494

Fixes an issue that can cause a crash or unexpected behavior when calling
WebCore::ScriptSourceCode::source on a cached script.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/CachedScriptSourceProvider.h: Modified to inherit from WebCore::ScriptSourceCode. (WebCore::CachedScriptSourceProvider::source): (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): Separated out source provider and rewrote to use WebCore::ScriptSourceProvider. (WebCore::ScriptSourceCode::source):
  • bindings/js/ScriptSourceProvider.h: Added. (WebCore::ScriptSourceProvider::ScriptSourceProvider): (WebCore::ScriptSourceProvider::~ScriptSourceProvider):
  • bindings/js/StringSourceProvider.h: Modified to inherit from WebCore::ScriptSourceCode. (WebCore::StringSourceProvider::StringSourceProvider):
22:31 Changeset [46215] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-21 Sam Weinig <sam@webkit.org>

Another attempt to fix the Windows build.

  • WebCore.vcproj/WebCore.vcproj:
22:19 Changeset [46214] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-21 Sam Weinig <sam@webkit.org>

Attempt to fix the Windows build.

  • DerivedSources.cpp:
22:17 Changeset [46213] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-21 Sam Weinig <sam@webkit.org>

Attempt to fix the GTK build

  • GNUmakefile.am:
22:04 Changeset [46212] by weinig@apple.com
  • 4 edits
    1 delete in trunk/WebCore

2009-07-21 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Autogenerate Objective-C binding implementation for RGBColor.

No functionality change.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMRGBColor.mm: Removed.
  • bindings/scripts/CodeGeneratorObjC.pm: Add logic to convert from WebCore::Color to NSColor*.
  • css/RGBColor.idl:
21:27 Changeset [46211] by weinig@apple.com
  • 28 edits
    2 deletes in trunk

WebCore:

2009-07-21 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27242
JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor

Move the JSC and Objective-C bindings onto using the RGBColor object instead
of just an unsigned int. The JSC bindings are now completely autogenerated for
this class. (Also removes the last lut from WebCore).

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSRGBColor.cpp: Removed.
  • bindings/js/JSRGBColor.h: Removed.
  • bindings/objc/DOM.mm: (-[DOMRGBColor _color]):
  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor alpha]): (-[DOMRGBColor color]):
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseColor):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getRGBColorValue):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getRGBA32Value):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • css/RGBColor.cpp: (WebCore::RGBColor::alpha):
  • css/RGBColor.h: (WebCore::RGBColor::color): (WebCore::RGBColor::RGBColor):
  • css/RGBColor.idl:
  • page/DOMWindow.idl:
  • svg/SVGColor.cpp: (WebCore::SVGColor::rgbColor):
  • svg/SVGColor.h:

LayoutTests:

2009-07-21 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Changes for https://bugs.webkit.org/show_bug.cgi?id=27242
JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/wrapper-classes-expected.txt:
  • fast/js/global-constructors-expected.txt:
21:03 Changeset [46210] by barraclough@apple.com
  • 5 edits
    3 adds in trunk

JavaScriptCore:

2009-07-21 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Cache not only the structure of the method, but the
structure of its prototype as well.
https://bugs.webkit.org/show_bug.cgi?id=27077

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock):
  • bytecode/CodeBlock.h: (JSC::MethodCallLinkInfo::MethodCallLinkInfo):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::patchMethodCallProto):

LayoutTests:

2009-07-21 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Gavin Barraclough, RS olliej fix to make the test pass.

Check whether a crash happens after the string
prototype is overwritten twice. The JIT'ed code
may crash if one of its already cached method
called again. Note: This test is not necessary
crash on all systems, because they use different
memory allocators!
https://bugs.webkit.org/show_bug.cgi?id=27077

  • fast/js/method-check-expected.txt: Added.
  • fast/js/method-check.html: Added.
  • fast/js/resources/method-check.js: Added. (func2): (func.String.prototype.a): (func.String.prototype.b): (func):
20:24 Changeset [46209] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

2009-07-21 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Move call linking / repatching down from AbstractMacroAssembler into MacroAssemblerARCH classes.
( https://bugs.webkit.org/show_bug.cgi?id=27527 )

This allows the implementation to be defined per architecture. Specifically this addresses the
fact that x86-64 MacroAssembler implements far calls as a load to register, followed by a call
to register. Patching the call actually requires the pointer load to be patched, rather than
the call to be patched. This is implementation detail specific to MacroAssemblerX86_64, and as
such is best handled there.

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::linkCall): (JSC::MacroAssemblerARM::repatchCall):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::linkCall): (JSC::MacroAssemblerARMv7::repatchCall):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::linkCall): (JSC::MacroAssemblerX86::repatchCall):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::linkCall): (JSC::MacroAssemblerX86_64::repatchCall):
19:42 Changeset [46208] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Correct relative path in the test after moving it.

  • platform/mac/fast/loader/non-html-load-event.html:
19:39 Changeset [46207] by mitz@apple.com
  • 2 edits
    2 moves in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

Move fast/loader/non-html-load-event.html under platform/mac because
non-HTML views exist only on Mac.

  • fast/loader/non-html-load-event-expected.txt: Removed.
  • fast/loader/non-html-load-event.html: Removed.
  • platform/mac/fast/loader/non-html-load-event-expected.txt: Copied from LayoutTests/fast/loader/non-html-load-event-expected.txt.
  • platform/mac/fast/loader/non-html-load-event.html: Copied from LayoutTests/fast/loader/non-html-load-event.html.
  • platform/qt/Skipped:
19:08 Changeset [46206] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

19:07 Changeset [46205] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.7

New tag.

18:39 Changeset [46204] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-21 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos.

Every wtf file includes other wtf files with <> style includes
except this one. Fix the exception.

  • wtf/ByteArray.h:
17:43 Changeset [46203] by jianli@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Implement AbstractWorker::dispatchScriptErrorEvent by generating an ErrorEvent.
https://bugs.webkit.org/show_bug.cgi?id=27515

  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::dispatchScriptErrorEvent):
17:37 Changeset [46202] by barraclough@apple.com
  • 10 edits
    2 adds in trunk/JavaScriptCore

2009-07-21 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Move LinkBuffer/RepatchBuffer out of AbstractMacroAssembler.
( https://bugs.webkit.org/show_bug.cgi?id=27485 )

This change is the first step in a process to move code that should be in
the architecture-specific MacroAssembler classes up out of Assmbler and
AbstractMacroAssembler.


  • assembler/ARMAssembler.h: (JSC::ARMAssembler::linkPointer):
    • rename patchPointer to bring it in line with the current link/repatch naming scheme


  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::linkCall): (JSC::ARMv7Assembler::linkPointer): (JSC::ARMv7Assembler::relinkCall): (JSC::ARMv7Assembler::repatchInt32): (JSC::ARMv7Assembler::repatchPointer): (JSC::ARMv7Assembler::setInt32): (JSC::ARMv7Assembler::setPointer):
    • rename patchPointer to bring it in line with the current link/repatch naming scheme
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::linkJump): (JSC::AbstractMacroAssembler::linkCall): (JSC::AbstractMacroAssembler::linkPointer): (JSC::AbstractMacroAssembler::getLinkerAddress): (JSC::AbstractMacroAssembler::getLinkerCallReturnOffset): (JSC::AbstractMacroAssembler::repatchJump): (JSC::AbstractMacroAssembler::repatchCall): (JSC::AbstractMacroAssembler::repatchNearCall): (JSC::AbstractMacroAssembler::repatchInt32): (JSC::AbstractMacroAssembler::repatchPointer): (JSC::AbstractMacroAssembler::repatchLoadPtrToLEA):
    • remove the LinkBuffer/RepatchBuffer classes, but leave a set of (private, friended) methods to interface to the Assembler
  • assembler/LinkBuffer.h: Added. (JSC::LinkBuffer::LinkBuffer): (JSC::LinkBuffer::~LinkBuffer): (JSC::LinkBuffer::link): (JSC::LinkBuffer::patch): (JSC::LinkBuffer::locationOf): (JSC::LinkBuffer::locationOfNearCall): (JSC::LinkBuffer::returnAddressOffset): (JSC::LinkBuffer::finalizeCode): (JSC::LinkBuffer::finalizeCodeAddendum): (JSC::LinkBuffer::code): (JSC::LinkBuffer::performFinalization):
    • new file containing the LinkBuffer class, previously a member of AbstractMacroAssembler
  • assembler/RepatchBuffer.h: Added. (JSC::RepatchBuffer::RepatchBuffer): (JSC::RepatchBuffer::relink): (JSC::RepatchBuffer::repatch): (JSC::RepatchBuffer::repatchLoadPtrToLEA): (JSC::RepatchBuffer::relinkCallerToTrampoline): (JSC::RepatchBuffer::relinkCallerToFunction): (JSC::RepatchBuffer::relinkNearCallerToTrampoline):
    • new file containing the RepatchBuffer class, previously a member of AbstractMacroAssembler
  • assembler/X86Assembler.h: (JSC::X86Assembler::linkJump): (JSC::X86Assembler::linkCall): (JSC::X86Assembler::linkPointerForCall): (JSC::X86Assembler::linkPointer): (JSC::X86Assembler::relinkJump): (JSC::X86Assembler::relinkCall): (JSC::X86Assembler::repatchInt32): (JSC::X86Assembler::repatchPointer): (JSC::X86Assembler::setPointer): (JSC::X86Assembler::setInt32): (JSC::X86Assembler::setRel32):
    • rename patchPointer to bring it in line with the current link/repatch naming scheme
  • jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress):
    • include new headers
    • remove MacroAssembler:: specification from RepatchBuffer usage
  • jit/JITPropertyAccess.cpp:
  • yarr/RegexJIT.cpp:
    • include new headers
17:08 Changeset [46201] by eric@webkit.org
  • 7 edits
    1 add in trunk/WebCore

2009-07-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move m_context out of generator into a superclass
https://bugs.webkit.org/show_bug.cgi?id=27521

Mostly this is removing code from CodeGeneratorJS
and instead using a DOMObjectWithSVGContext superclass in JSDOMBinding.h.

DOMObjectWithSVGContext.h is its own file so that WebKit doesn't need to
know about SVGElement.h (WebKit includes JSDOMBinding.h for some reason).

I also removed context pointer from SVGZoomEvent since it was never used.

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/DOMObjectWithSVGContext.h: Added. (WebCore::DOMObjectWithSVGContext::context): (WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/scripts/CodeGeneratorJS.pm:
16:08 Changeset [46200] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (r46142): editing/execCommand/19087.html & editing/execCommand/19653-1.html fail in Windows build
https://bugs.webkit.org/show_bug.cgi?id=27480

Because m_anchorType : 2 is treated as a signed integer by cl.exe, anchorType() wasn't returning the correct value.
We made m_anchorType unsigned so that anchorType() returns the correct value.

  • dom/Position.h: (WebCore::Position::anchorType): statically cast to AnchorType
15:57 Changeset [46199] by jianli@chromium.org
  • 3 edits in trunk/WebCore

2009-07-21 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

[V8] Add V8 bindings for onerror in WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=27518

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
15:54 Changeset [46198] by jianli@chromium.org
  • 3 edits in trunk/WebCore

2009-07-21 Jian Li <jianli@chromium.org>

Fix the incorrect patch being landed for bug 27516 that has already been reviewed.
https://bugs.webkit.org/show_bug.cgi?id=27516

  • workers/WorkerContext.h: (WebCore::WorkerContext::setOnerror): (WebCore::WorkerContext::onerror):
  • workers/WorkerContext.idl:
15:44 Changeset [46197] by jianli@chromium.org
  • 4 edits in trunk/WebCore

2009-07-21 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Add onerror to WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=27516

  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark):
  • workers/WorkerContext.h: (WebCore::WorkerContext::setOnerror): (WebCore::WorkerContext::onerror):
  • workers/WorkerContext.idl:
15:42 Changeset [46196] by treat@webkit.org
  • 1 edit
    8 adds in trunk/WebCore

2009-07-21 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=27509
Add font-related files for the WinCE port.

Written by Yong Li <yong.li@torchmobile.com>

  • platform/graphics/wince/FontCacheWince.cpp: Added.
  • platform/graphics/wince/FontCustomPlatformData.cpp: Added.
  • platform/graphics/wince/FontCustomPlatformData.h: Added.
  • platform/graphics/wince/FontPlatformData.cpp: Added.
  • platform/graphics/wince/FontPlatformData.h: Added.
  • platform/graphics/wince/FontWince.cpp: Added.
  • platform/graphics/wince/GlyphPageTreeNodeWince.cpp: Added.
  • platform/graphics/wince/SimpleFontDataWince.cpp: Added.
14:11 Changeset [46195] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Fix the Windows build, and update the comment on top now that wx uses WebCorePrefix.h too.

13:55 Changeset [46194] by kevino@webkit.org
  • 2 edits in trunk/WebCore

WebCorePrefix.h build fixes for non-Mac and wx / CURL builds.

13:52 Changeset [46193] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. Missing header added.

13:45 Changeset [46192] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-21 Adam Treat <adam.treat@torchmobile.com>

Reviewed by David Levin.

We can't match implementation file and primary header exactly
since we have so many files in WebKit where the port suffix
is appended to the filename.

Example: FooQt.cpp and the primary header is Foo.h.

  • Scripts/modules/cpplint.py:
13:35 Changeset [46191] by eric@webkit.org
  • 16 edits in trunk/WebCore

2009-07-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

All DOMConstructorObjects should hold a pointer to the JSDOMGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=27478

This is just moving code.
I've added two new classes: DOMObjectWithGlobalPointer and DOMConstructorWithDocument.

DOMObjectWithGlobalPointer is a new baseclass for DOMConstructorObject.
(It's a baseclass because eventually all DOMObjects will have a global pointer, but
I'll be moving them onto DOMObjectWithGlobalPointer in stages.)

DOMConstructorWithDocument is a new baseclass for the 3 constructor objects
which require a backpointer to the Document to function. I made this a subclass of
DOMConstructorObject to make clear that most constructors can hold no-such assumptions
about having a back-pointer to the Document (since many constructors can be used from Workers).

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::globalObject): (WebCore::DOMObjectWithGlobalPointer::scriptExecutionContext): (WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer): (WebCore::DOMObjectWithGlobalPointer::mark): (WebCore::DOMConstructorObject::DOMConstructorObject): (WebCore::DOMConstructorWithDocument::document): (WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
  • bindings/js/JSMessageChannelConstructor.h:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSOptionConstructor.h:
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
  • bindings/js/JSWebKitPointConstructor.cpp: (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::JSWorkerConstructor::JSWorkerConstructor):
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  • bindings/js/JSXMLHttpRequestConstructor.h:
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
13:15 Changeset [46190] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Revert r46128.

13:06 Changeset [46189] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by David Levin.

Add checks for switch statement indentation to cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27508

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
12:43 Changeset [46188] by kenneth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Adam Treat.

Feature request: cpplint should check for braces - rule 2
https://bugs.webkit.org/show_bug.cgi?id=27497

Add the requested feature: Make sure { is on the same line
as the foreach "keyword".

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
12:18 Changeset [46187] by levin@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-07-21 Robert Agoston <Agoston.Robert@stud.u-szeged.hu>

Reviewed by David Levin.

Fixed #undef typo.
https://bugs.webkit.org/show_bug.cgi?id=27506

  • bytecode/Opcode.h:
12:18 Changeset [46186] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 James Hawkins <jhawkins@google.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=27453
Initialize isInt when creating a CSSParserValue for a function.

No change in behavior, so no tests.

  • css/CSSFunctionValue.cpp: (WebCore::CSSFunctionValue::parserValue):
12:18 Changeset [46185] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-20 Jens Alfke <snej@google.com>

Reviewed by David Levin.

Bug 27448: [Chromium] On Mac, arrow keys should cause Select to pop up its menu.
Mac build of Chromium doesn't follow Mac HI guidelines to pop up the menu when
an arrow key is pressed.
https://bugs.webkit.org/show_bug.cgi?id=27448

No new tests; affects only control response to user input.

  • dom/SelectElement.cpp: Changed definition of ARROW_KEYS_POP_MENU to make it true in Mac Chromium, so it will behave compatibly with Mac HI guidelines on pop-up menus. It's not possible to have PLATFORM(MAC) be true in the Mac build of Chromium.
12:18 Changeset [46184] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Paul Godavari <paul@chromium.org>

Reviewed by Eric Seidel.

[Chromium] popup menus can crash when the selected index is -1
https://bugs.webkit.org/show_bug.cgi?id=27275

Crash reports from users indicate a crash can occur when PopupListBox::isSelectableItem
is passed an index of less than 0 (which is possible under certain circumstances). This
change prevents such a value from causing a crash by enforcing valid index values passed
by all callers of isSelectableItem. isSelectableItem is now a private method of
PopupListBox, as there are no external callers.

Also cleaned up a small amount of code for style and grammar errors.

No automatic test is provided since we cannot send events to the child window used by
the popup menu.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::acceptIndex): (WebCore::PopupListBox::selectIndex): (WebCore::PopupListBox::isSelectableItem): (WebCore::PopupListBox::selectPreviousRow):
12:00 Changeset [46183] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Don't include winsock2.h on wx, it conflicts with wx's inclusion of winsock.

11:21 Changeset [46182] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-20 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by David Levin.

Add checks for namespace indentation to cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27461

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
11:16 Changeset [46181] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-20 Adam Treat <adam.treat@torchmobile.com>

Reviewed by David Levin.

Add cpplint check for proper include order
https://bugs.webkit.org/show_bug.cgi?id=27462

Add a new check to cpplint to flag cases where the include section of a file
does not match the mandated include order and style of the Webkit coding style
guidelines.

Add associated tests.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
11:13 Changeset [46180] by aroben@apple.com
  • 13 edits
    2 deletes in trunk

Roll out r46153, r46154, and r46155

These changes were causing build failures and assertion failures on
Windows.

JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSArray.cpp:
  • runtime/StringPrototype.cpp:
  • runtime/UString.cpp:
  • runtime/UString.h:
  • wtf/FastMalloc.cpp:
  • wtf/FastMalloc.h:
  • wtf/Platform.h:
  • wtf/PossiblyNull.h: Removed.

WebCore:

  • ForwardingHeaders/wtf/PossiblyNull.h: Removed.
  • platform/graphics/cg/ImageBufferCG.cpp:
10:34 Changeset [46179] by jianli@chromium.org
  • 12 edits
    3 adds in trunk/WebCore

2009-07-21 Jian Li <jianli@chromium.org>

Reviewed by Eric Seidel.

Implement ErrorEvent API.
https://bugs.webkit.org/show_bug.cgi?id=27387

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • dom/ErrorEvent.cpp: Added.
  • dom/ErrorEvent.h: Added.
  • dom/ErrorEvent.idl: Added.
  • dom/Event.cpp: (WebCore::Event::isErrorEvent):
  • dom/Event.h:
10:14 Changeset [46178] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Priit Laes <plaes@plaes.org>

Reviewed by Gustavo Noronha.

[Gtk] Searching in thepiratebay.org doesn't work with more than 1 word
https://bugs.webkit.org/show_bug.cgi?id=24602

Remove workaround required for <=libsoup-2.26.1

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
10:09 Changeset [46177] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397

Make a copy of the context handle before making it weak. We don't want
to make the original handle weak because we want it to survive for the
length of the V8IsolatedWorld::evaluate method.

  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
09:50 Changeset [46176] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add ability to evaluate selection while on break point.

https://bugs.webkit.org/show_bug.cgi?id=27502

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded): (WebInspector.SourceFrame.prototype._documentKeyDown):
09:42 Changeset [46175] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Special case ConsolePanel opening since
it is a 'fast view'.

https://bugs.webkit.org/show_bug.cgi?id=27493

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible):
08:13 Changeset [46174] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

wx build fix. Adding isSpeaking() to ContextMenuClientWx.

06:40 Changeset [46173] by hausmann@webkit.org
  • 5 edits in trunk/WebKit/qt

2009-07-21 Volker Hilsheimer <volker.hilsheimer@nokia.com>

Reviewed by Simon Hausmann.

Various improvements to the API documentation.

  • Updated link to W3c Database spec
  • Formatting fixes, cleanups
  • Add missing \since 4.6 tags to QWebPage::frameAt
  • Extend QWebDatabase and QWebSecurityOrigin docs.
  • Api/qwebdatabase.cpp:
  • Api/qwebpage.cpp:
  • Api/qwebsecurityorigin.cpp:
  • Api/qwebview.cpp:
06:10 Changeset [46172] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-21 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Rubber-stamped by Simon Hausmann.

Remove preliminary-tag from QWebElement

  • Api/qwebelement.cpp:
05:42 Changeset [46171] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-21 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Skip fast/loader/non-html-load-event.html for the Qt DRT as it requires
support for loading PDF documents.

  • platform/qt/Skipped:
05:02 Changeset [46170] by kenneth@webkit.org
  • 66 edits in trunk

WebCore:

2009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Eric Seidel.

Fix Qt code to follow the WebKit Coding Style.

  • platform/graphics/qt/FontQt.cpp: (WebCore::qstring): (WebCore::fixSpacing):
  • platform/graphics/qt/FontQt43.cpp: (WebCore::generateComponents): (WebCore::Font::offsetForPositionForComplexText): (WebCore::cursorToX):
  • platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtFillRule): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getWindowsContext):
  • platform/graphics/qt/IconQt.cpp: (WebCore::Icon::paint):
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::ReadContext::read): (WebCore::ImageDecoderQt::ReadContext::readImageLines): (WebCore::ImageDecoderQt::setData):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern): (WebCore::BitmapImage::draw):
  • platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameDurationAtIndex): (WebCore::ImageSource::frameHasAlphaAtIndex): (WebCore::ImageSource::frameIsCompleteAtIndex):
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::create): (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::updateStates):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo): (WebCore::Path::isEmpty):
  • platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::TransformationMatrix::operator QTransform):
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::clearData): (WebCore::ClipboardQt::clearAllData): (WebCore::ClipboardQt::getData): (WebCore::ClipboardQt::setData): (WebCore::ClipboardQt::setDragImage): (WebCore::getCachedImage): (WebCore::ClipboardQt::declareAndWriteDragImage): (WebCore::ClipboardQt::writeURL): (WebCore::ClipboardQt::writeRange): (WebCore::ClipboardQt::hasData):
  • platform/qt/ClipboardQt.h:
  • platform/qt/ContextMenuItemQt.cpp: (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title):
  • platform/qt/CursorQt.cpp: (WebCore::westPanningCursor): (WebCore::notAllowedCursor):
  • platform/qt/DragDataQt.cpp: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): (WebCore::DragData::asPlainText): (WebCore::DragData::asFragment):
  • platform/qt/DragImageQt.cpp: (WebCore::createDragImageIconForCachedImage):
  • platform/qt/FileSystemQt.cpp: (WebCore::getFileSize): (WebCore::unloadModule):
  • platform/qt/Localizations.cpp: (WebCore::contextMenuItemTagShowSpellingPanel):
  • platform/qt/MIMETypeRegistryQt.cpp: (WebCore::):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::plainText):
  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  • platform/qt/PlatformMouseEventQt.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::populate):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::fallbackStyle): (WebCore::inflateButtonRect): (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::applyTheme): (WebCore::WorldMatrixTransformer::WorldMatrixTransformer): (WebCore::RenderThemeQt::paintMediaBackground): (WebCore::RenderThemeQt::paintMediaFullscreenButton):
  • platform/qt/RenderThemeQt.h:
  • platform/qt/ScreenQt.cpp: (WebCore::screenRect): (WebCore::usableScreenRect):
  • platform/qt/ScrollbarQt.cpp: (WebCore::Scrollbar::contextMenu):
  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::scPart): (WebCore::scrollbarPart):
  • platform/qt/ScrollbarThemeQt.h:
  • platform/qt/SharedBufferQt.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
  • platform/qt/TemporaryLinkStubs.cpp: (PluginDatabase::defaultPluginDirectories): (PluginDatabase::getPluginPathsInDirectories): (PluginDatabase::isPreferredPluginDirectory): (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString): (WebCore::userIdleTime): (WebCore::prefetchDNS):
  • platform/text/qt/StringQt.cpp: (WebCore::String::String):
  • platform/text/qt/TextBoundaries.cpp:
  • platform/text/qt/TextBreakIteratorQt.cpp: (WebCore::TextBreakIterator::following): (WebCore::TextBreakIterator::preceding): (WebCore::WordBreakIteratorQt::first): (WebCore::WordBreakIteratorQt::next): (WebCore::WordBreakIteratorQt::previous): (WebCore::CharBreakIteratorQt::first): (WebCore::CharBreakIteratorQt::next): (WebCore::CharBreakIteratorQt::previous): (WebCore::characterBreakIterator):
  • plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::fetchInfo):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::userAgentStatic): (WebCore::PluginView::handlePostReadFile): (WebCore::PluginView::init):

WebKit/qt:

2009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Eric Seidel.

Fix Qt code to follow the WebKit Coding Style.

  • Api/qcookiejar.cpp: (QCookieJar::setCookieJar): (QCookieJar::cookieJar):
  • Api/qcookiejar.h:
  • Api/qwebdatabase.cpp: (QWebDatabase::QWebDatabase): (QWebDatabase::removeDatabase):
  • Api/qwebdatabase.h:
  • Api/qwebdatabase_p.h:
  • Api/qwebelement.h:
  • Api/qwebframe.cpp: (QWebFrame::title): (QWebFrame::print):
  • Api/qwebframe.h:
  • Api/qwebframe_p.h:
  • Api/qwebhistory.cpp: (QWebHistory::clear):
  • Api/qwebhistory.h:
  • Api/qwebhistory_p.h:
  • Api/qwebhistoryinterface.cpp: (gCleanupInterface): (QWebHistoryInterface::setDefaultInterface): (QWebHistoryInterface::defaultInterface): (QWebHistoryInterface::QWebHistoryInterface):
  • Api/qwebhistoryinterface.h:
  • Api/qwebnetworkinterface.cpp: (QWebNetworkManager::started): (QWebNetworkManager::finished): (QWebNetworkInterfacePrivate::parseDataUrl): (QWebNetworkInterface::addJob): (WebCoreHttp::onResponseHeaderReceived): (WebCoreHttp::onReadyRead):
  • Api/qwebnetworkinterface.h:
  • Api/qwebnetworkinterface_p.h:
  • Api/qwebpage.cpp: (QWebPagePrivate::editorCommandForWebActions): (QWebPagePrivate::createContextMenu): (QWebPagePrivate::focusInEvent): (QWebPage::fixedContentsSize): (QWebPage::setContentEditable): (QWebPage::swallowContextMenuEvent): (QWebPage::findText):
  • Api/qwebpage.h:
  • Api/qwebpage_p.h:
  • Api/qwebpluginfactory.h:
  • Api/qwebsecurityorigin.h:
  • Api/qwebsecurityorigin_p.h:
  • Api/qwebsettings.cpp: (QWebSettingsPrivate::QWebSettingsPrivate): (QWebSettingsPrivate::apply): (QWebSettings::globalSettings): (QWebSettings::QWebSettings): (QWebSettings::fontSize): (QWebSettings::setUserStyleSheetUrl): (QWebSettings::setDefaultTextEncoding): (QWebSettings::setIconDatabasePath): (QWebSettings::iconDatabasePath): (QWebSettings::iconForUrl): (QWebSettings::setWebGraphic): (QWebSettings::setFontFamily): (QWebSettings::fontFamily): (QWebSettings::testAttribute): (qt_websettings_setLocalStorageDatabasePath):
  • Api/qwebsettings.h:
  • Api/qwebview.cpp: (QWebView::setPage): (QWebView::event):
  • Api/qwebview.h:
04:05 Changeset [46169] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-21 Priit Laes <plaes@plaes.org>

Reviewed by Holger Freyther.

[GTK+] Missing accelerator in authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=25509

Add accelerator to checkbox text.

  • WebKit/gtk/webkit/webkitsoupauthdialog.c: (show_auth_dialog):
03:51 Changeset [46168] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-21 Priit Laes <plaes@plaes.org>

Reviewed by Holger Freyther.

[GTK] http auth dialog pops up twice after a cancelled atempt
https://bugs.webkit.org/show_bug.cgi?id=24818

Remove workaround required for libsoup versions <=2.26.2 as we depend
on 2.27.4 now.

  • webkit/webkitsoupauthdialog.c: (session_authenticate):
03:41 Changeset [46167] by levin@chromium.org
  • 1 edit
    4 adds in trunk/WebCore

2009-07-21 Maxime Simon <simon.maxime@gmail.com>

Reviewed by David Levin.

Added a first bunch of Haiku-specific files for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=26988

  • platform/haiku/ClipboardHaiku.cpp: Added. (WebCore::ClipboardHaiku::ClipboardHaiku): (WebCore::ClipboardHaiku::clearData): (WebCore::ClipboardHaiku::clearAllData): (WebCore::ClipboardHaiku::getData): (WebCore::ClipboardHaiku::setData): (WebCore::ClipboardHaiku::types): (WebCore::ClipboardHaiku::files): (WebCore::ClipboardHaiku::dragLocation): (WebCore::ClipboardHaiku::dragImage): (WebCore::ClipboardHaiku::setDragImage): (WebCore::ClipboardHaiku::dragImageElement): (WebCore::ClipboardHaiku::setDragImageElement): (WebCore::ClipboardHaiku::createDragImage): (WebCore::ClipboardHaiku::declareAndWriteDragImage): (WebCore::ClipboardHaiku::writeURL): (WebCore::ClipboardHaiku::writeRange): (WebCore::ClipboardHaiku::hasData):
  • platform/haiku/ClipboardHaiku.h: Added. (WebCore::ClipboardHaiku::create): (WebCore::ClipboardHaiku::~ClipboardHaiku):
  • platform/haiku/CookieJarHaiku.cpp: Added. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
  • platform/haiku/CursorHaiku.cpp: Added. (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::Cursor::operator=): (WebCore::pointerCursor): (WebCore::moveCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor): (WebCore::grabCursor): (WebCore::grabbingCursor):
03:35 Changeset [46166] by levin@chromium.org
  • 2 edits
    1 add in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

Support lint for patches
https://bugs.webkit.org/show_bug.cgi?id=27291

Add run-webkit-lint script, which lints recent changes in local
repository. Also, modified cpplint.py so that we don't need to
specify verbose level for process_file().

  • Scripts/modules/cpplint.py:
  • Scripts/run-webkit-lint: Added.
03:12 Changeset [46165] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Albert Astals Cid <aacid@kde.org>

Reviewed by Tor Arne Vestbø.

Change #error line not to have a ' (single quote)

  • DerivedSources.cpp:
03:12 Changeset [46164] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

diff_parser should accept lines without trailing \n
https://bugs.webkit.org/show_bug.cgi?id=27483

Normalize the input lines by removing a trailing newline.
Also, add a case for unittest for newly added files.

  • Scripts/modules/diff_parser.py:
  • Scripts/modules/diff_parser_unittest.py:
03:12 Changeset [46163] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

cpplint.py's process_file() should accept customized error function
https://bugs.webkit.org/show_bug.cgi?id=27487

  • Scripts/modules/cpplint.py:
02:53 Changeset [46162] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

cpplint.py should have an interface to get global error count
https://bugs.webkit.org/show_bug.cgi?id=27486

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
02:53 Changeset [46161] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

cpplint's parse_argument should not exit even if no files are specified
https://bugs.webkit.org/show_bug.cgi?id=27489

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
02:53 Changeset [46160] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

diff_parser: s/add_deleted_line/add_old_line/g
https://bugs.webkit.org/show_bug.cgi?id=27484

  • Scripts/modules/diff_parser.py:
02:53 Changeset [46159] by levin@chromium.org
  • 17 edits in trunk

.:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

  • configure.ac: Added flag ENABLE_RUBY.

JavaScriptCore:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

  • Configurations/FeatureDefines.xcconfig: Added flag ENABLE_RUBY.

WebCore:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

Added flag ENABLE_RUBY:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/build-generated-files.sh:

WebKit/mac:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

  • Configurations/FeatureDefines.xcconfig: Added flag ENABLE_RUBY.

WebKit/win:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

  • WebKit.vcproj/WebKit.vcproj: Added flag ENABLE_RUBY.

WebKitTools:

2009-07-21 Roland Steiner <rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

  • Scripts/build-webkit: Added flag ENABLE_RUBY.
02:53 Changeset [46158] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 James Hawkins <jhawkins@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27467
Return an empty path in PlatformContextSkia::currentPathInLocalCoordinates
if matrix.invert() fails. This prevents the use of an uninitialized
value in inverseMatrix.

No new tests added. Run
LayoutTests/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html
under valgrind and notice there are no errors.

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::currentPathInLocalCoordinates):
02:53 Changeset [46157] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-21 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27388

Fix dotted and dashed borders on Chromium/skia. This follows
the logic in the Cg path, so results are much closer to Safari now
(some tests won't be exactly the same due to font layout differences).

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):

07/20/09:

23:41 Changeset [46156] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix <https://bugs.webkit.org/show_bug.cgi?id=27482>.
Bug 27482: svn-apply cannot apply patch generated by Windows SVN

Reviewed by David D. Kilzer.

A regexp in svn-apply was treating everything prior to a \n as part of the
file name. The native Windows SVN client uses \r\n for line endings which
meant that the \r was being included in the file name. This defeated the
special-case logic for ChangeLogs to apply them with an increased fuzz factor,
meaning that the ChangeLog portions of such patches would fail to apply.

Also updated two other regexps that look like they would hit similar problems
with line-endings so that they will correctly handle patches from Windows SVN.

  • Scripts/svn-apply:
21:35 Changeset [46155] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix attempt #2

21:22 Changeset [46154] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix attempt #1

21:02 Changeset [46153] by oliver@apple.com
  • 11 edits
    2 adds in trunk

Make it harder to misuse try* allocation routines
https://bugs.webkit.org/show_bug.cgi?id=27469

Reviewed Gavin Barraclough

Jump through a few hoops to make it much harder to accidentally
miss null-checking of values returned by the try-* allocation
routines.

20:33 Changeset [46152] by zecke@webkit.org
  • 2 edits
    3 adds in trunk/WebKit/qt

[Qt] Add test for loading webpages...

Performance test for loading webpages...

20:32 Changeset [46151] by zecke@webkit.org
  • 2 edits
    4 adds in trunk/WebKit/qt

[Qt] Add a test case for drawing a simple viewrect to a QPixmap

20:30 Changeset [46150] by agl@chromium.org
  • 3 edits
    3 adds in trunk

2009-07-20 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Guard access to installedMediaEngines()[0].

https://bugs.webkit.org/show_bug.cgi?id=27479
http://code.google.com/p/chromium/issues/detail?id=16541

Else where in the file, installedMediaEngines is always checked for
being empty because access. This patch adds a case which missed that
check.

This triggered a crash in Chromium:

http://www.yakeze.com/chat/example-chromium-crash/

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load):
20:27 Changeset [46149] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Gavin Barraclough <barraclough@apple.com>

RS Oliver Hunt.

Add ARM assembler files to xcodeproj, for convenience editing.

20:06 Changeset [46148] by agl@chromium.org
  • 2 edits in trunk/WebCore

2009-07-20 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Allow search entries to render with a CSS border if the RenderTheme
doesn't paint them.

https://bugs.webkit.org/show_bug.cgi?id=27466
http://code.google.com/p/chromium/issues/detail?id=16958

<input type="search"> is very much like a text entry except that,
currently, if the RenderTheme doesn't deal with it, nothing is
rendered. With this patch, the default CSS border is rendered if the
RenderTheme requests it.

This will affect many layout tests, but only for Chromium Linux and
those results are not currently in the WebKit tree.

  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paintBorderOnly):
19:58 Changeset [46147] by jberlin@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Jessie Berlin <jberlin@apple.com>

Fix an incorrect assertion in Vector::remove.


Reviewed by David Levin.


https://bugs.webkit.org/show_bug.cgi?id=27477

  • wtf/Vector.h: (WTF::::remove): Assert that the position at which to start removing elements + the length (the number of elements to remove) is less than or equal to the size of the entire Vector.
19:54 Changeset [46146] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Correct expected results from r46136, which accidentally included the
DumpRenderTree header and trailer

  • fast/loader/non-html-load-event-expected.txt:
19:19 Changeset [46145] by abarth@webkit.org
  • 14 edits in trunk/WebCore

2009-07-17 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Switch to faster methods to access internal fields.
https://bugs.webkit.org/show_bug.cgi?id=27372

Minor refactoring.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertToSVGPODTypeImpl): (WebCore::V8DOMWrapper::setDOMWrapper):
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::convertDOMWrapperToNode): (WebCore::V8DOMWrapper::convertToNativeObject): (WebCore::V8DOMWrapper::convertToNativeEvent):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ClipboardCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::removeElement):
  • bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
19:15 Changeset [46144] by agl@chromium.org
  • 4 edits
    1 add in trunk/WebCore

2009-07-20 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium Linux: cache Harfbuzz faces.

https://bugs.webkit.org/show_bug.cgi?id=27473

Previously, we recreated the Harfbuzz face for each script-run. With
this patch, we keep the Harfbuzz face in the FontPlatformData (created
as needed) and so they will persist for the duration of the
FontPlatformData.

Shouldn't affect any layout tests. Results in a significant win on the
intl2 page cycler time.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::~TextRunWalker): (WebCore::TextRunWalker::setupFontForScriptRun):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::RefCountedHarfbuzzFace::~RefCountedHarfbuzzFace): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::harfbuzzFace):
  • platform/graphics/chromium/FontPlatformDataLinux.h: (WebCore::FontPlatformData::RefCountedHarfbuzzFace::create): (WebCore::FontPlatformData::RefCountedHarfbuzzFace::face): (WebCore::FontPlatformData::RefCountedHarfbuzzFace::RefCountedHarfbuzzFace):
  • platform/graphics/chromium/HarfbuzzSkia.h: Added.
18:31 Changeset [46143] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Simon Fraser.

REGRESSION (r46142): Need to remove showTreeThisForThis
https://bugs.webkit.org/show_bug.cgi?id=27475

Removes showTreeThisForThis

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::appendParagraphIntoNode):
17:55 Changeset [46142] by rniwa@webkit.org
  • 16 edits
    8 adds in trunk

WebCore:

2009-07-19 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Refactoring of indentRegion to fix bugs 26816 and 25317
https://bugs.webkit.org/show_bug.cgi?id=26816
https://bugs.webkit.org/show_bug.cgi?id=25317
https://bugs.webkit.org/show_bug.cgi?id=23995 (partially)

This patch implements appendParagraphIntoNode, a simpler specialized version of moveParagraph
and replaces all calls inside indentRegion. The following is the new behavior of indentRegion.

  1. We try to indent as many wrapping nodes as possible. e.g. when indenting "hello" in <div>hello</div>, we try to indent div as well.
  2. We do not delete any wrapping elements With moveParagraph, we used to remove all wrapping nodes, and replaced with a blockquote. This was causing https://bugs.webkit.org/show_bug.cgi?id=23995 for indentation. With appendParagraphIntoNode, we can preserve all wrapping nodes.
  3. We only split the tree until the closest block node instead of until the root editable node. This behavioral change fixes the bug 25317.
  4. When multiple paragraphs are indented, we indent the highest common ancestor within the selection. e.g. when a list is a child node of a div, and the entire div is intended,

we enclose the div by a single blockquote.

Note that new behavior is more consistent with that of Internet Explorer and Firefox.
To demonstrate this, the following tests are added.

Tests: editing/execCommand/indent-div-inside-list.html

editing/execCommand/indent-nested-blockquotes.html
editing/execCommand/indent-nested-div.html
editing/execCommand/indent-second-paragraph-in-blockquote.html

  • editing/IndentOutdentCommand.cpp: prepareBlockquoteLevelForInsertion is removed (WebCore::IndentOutdentCommand::tryIndentingAsListItem): uses appendParagraphIntoNode now (WebCore::IndentOutdentCommand::indentIntoBlockquote): uses appendParagraphIntoNode now (WebCore::IndentOutdentCommand::appendParagraphIntoNode): removes a paragraph and appends it to a new node (WebCore::IndentOutdentCommand::removeUnnecessaryLineBreakAt): removes a break element at the specified position (WebCore::IndentOutdentCommand::indentRegion): exhibits the described behavior
  • editing/IndentOutdentCommand.h: updated prototype
  • editing/execCommand/19653-1-expected.txt: rebaselined (no longer removes wrapping div)
  • editing/execCommand/indent-div-inside-list-expected.txt: Added.
  • editing/execCommand/indent-div-inside-list.html: Added.
  • editing/execCommand/indent-nested-blockquotes-expected.txt: Added.
  • editing/execCommand/indent-nested-blockquotes.html: Added.
  • editing/execCommand/indent-nested-div-expected.txt: Added.
  • editing/execCommand/indent-nested-div.html: Added.
  • editing/execCommand/indent-nested-lists-2-expected.txt: rebaselined (selection corrected)
  • editing/execCommand/indent-nested-lists-3-expected.txt: rebaselined (selection corrected)
  • editing/execCommand/indent-nested-lists-4-expected.txt: rebaselined (selection corrected)
  • editing/execCommand/indent-nested-lists-5-expected.txt: rebaselined (selection corrected)
  • editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Added.
  • editing/execCommand/indent-second-paragraph-in-blockquote.html: Added.
  • platform/mac/editing/execCommand/4641880-2-expected.txt: rebaselined
  • platform/mac/editing/execCommand/4916541-expected.txt: rebaselined (no longer removes wrapping span)
  • platform/mac/editing/execCommand/5138441-expected.txt: rebaselined
  • platform/mac/editing/execCommand/5481523-expected.txt: rebaselined
  • platform/mac/editing/execCommand/indent-selection-expected.txt: rebaselined
16:59 Changeset [46141] by mitz@apple.com
  • 2 edits in trunk/WebCore

Try to fix release builds after r46136

  • dom/Element.cpp:
16:59 Changeset [46140] by pdherbemont@apple.com
  • 6 edits
    2 deletes in trunk

WebCore:

2009-07-17 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Eric Seidel.

Media Controls: We are specifying the text height, where it is unneeded and the slider is 2px off.
https://bugs.webkit.org/show_bug.cgi?id=27380

Adjust the margin of the slider and remove useless height specification to fix alignement of the media controls.

  • css/mediaControlsQT.css:

LayoutTests:

2009-07-17 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Eric Seidel.

Media Controls: We are specifying the text height, where it is unneeded and the slider is 2px off.
https://bugs.webkit.org/show_bug.cgi?id=27380

Adjust the margin of the slider and remove useless height specification to fix alignement of the media controls.

  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-styling-expected.checksum: Removed.
  • platform/mac/media/controls-styling-expected.png: Removed.
  • platform/mac/media/controls-styling-expected.txt:
  • platform/mac/media/video-zoom-controls-expected.txt:
16:56 Changeset [46139] by pkasting@chromium.org
  • 19 edits in trunk

JavaScriptCore:

2009-07-20 Peter Kasting <pkasting@google.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.

WebCore:

2009-07-20 Peter Kasting <pkasting@google.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/WebCoreGenerated.vcproj:

WebKit/win:

2009-07-20 Peter Kasting <pkasting@google.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/InterfacesGenerated.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

WebKitTools:

2009-07-20 Peter Kasting <pkasting@google.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
16:35 Changeset [46138] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-20 Eric Seidel <eric@webkit.org>

Reviewed by Sam Weinig.

Fix failures seen on the bots
https://bugs.webkit.org/show_bug.cgi?id=27463

Ignore more global variables added by DumpRenderTree.
Some platforms don't add all of the DRT controllers,
thus causing this test to fail for those platforms.

Also fix !value to value === null to handle not
skip the cases where value == 0.

  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/resources/prototype-inheritance.js:
16:15 Changeset [46137] by cmarrin@apple.com
  • 1 edit in trunk/LayoutTests/transitions/extra-transition.html

Fixed a transition LayoutTest which fails on slower machines

16:08 Changeset [46136] by mitz@apple.com
  • 11 edits
    4 adds in trunk

WebCore:

Reviewed by Anders Carlsson.

When loading a custom view into a frame, the old document is still
around
<rdar://problem/5145841>

Safari fires onload before PDF is loaded into the browser
<rdar://problem/6618869>

Test: fast/loader/non-html-load-event.html

  • GNUmakefile.am: Added PlaceholderDocument.{cpp,h}
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • dom/Document.h: (WebCore::Document::setStyleSelector): Added this protected accessor for

PlaceholderDocument to use.

  • dom/Element.cpp: (WebCore::Element::clientWidth): Check whether the document has a

renderer.

(WebCore::Element::clientHeight): Ditto.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a PlaceholderDocument for frames

that do not use an HTML view. Do not nullify the content size in
that case.

(WebCore::FrameLoader::transitionToCommitted): For frames that do not

use an HTML view, call receivedFirstData(), which sets up the
frame with a new PlaceHolderDocument.

  • loader/PlaceholderDocument.cpp: Added. (WebCore::PlaceholderDocument::attach): Sets up the style selector but

does not create a RenderView.

  • loader/PlaceholderDocument.h: Added. (WebCore::PlaceholderDocument::create): (WebCore::PlaceholderDocument::PlaceholderDocument):

LayoutTests:

Reviewed by Anders Carlsson.

Safari fires onload before PDF is loaded into the browser
<rdar://problem/6618869>

  • fast/loader/non-html-load-event-expected.txt: Added.
  • fast/loader/non-html-load-event.html: Added.
15:45 Changeset [46135] by cmarrin@apple.com
  • 5 edits in trunk/WebCore

Handle opacity and opacity animations on transform layers in Leopard
https://bugs.webkit.org/show_bug.cgi?id=27398

This makes two changes, and only for Leopard.

First, whenever opacity is changed on a layer I propagate the
change into the content layer and all the children if the layer
on which opacity is set is a transform layer (preserve3D is true).
The opacity set is the accumulated opacity from this layer
and all its direct ancestor transform layers. Second, I turn off all
hardware opacity animation.

15:16 Changeset [46134] by pkasting@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-20 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27323
Use shorter, more correct code for determining the current directory,
which works better with symbolic links on some systems. Also switch
from checking repository root to checking UUID, to match scm.py.

  • Scripts/svn-create-patch:
14:46 Changeset [46133] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Work around <rdar://problem/7075373> by ensuring that the URL is absolute before handing it off to CoreText.

Rubber-stamped by Dan Bernstein.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(activateFonts):

14:38 Changeset [46132] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-07-20 Geoffrey Garen <ggaren@apple.com>

Fixed a post-review typo in r46066 that caused tons of test failures.


SunSpider reports no change.

  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): Initialize the full vector capacity, to avoid uninitialized members at the end.
13:55 Changeset [46131] by bweinstein@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-07-20 Geoffrey Garen <ggaren@apple.com>

Windows WebKit build fix: Added some missing exports.

13:41 Changeset [46130] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-20 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

Enable filename completion for run-webkit-test (added "-o default").

  • Scripts/webkit-tools-completion.sh:
13:08 Changeset [46129] by treat@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-07-20 Yong Li <yong.li@torchmobile.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=27349
Add GraphicsContext implementation for the WinCE port.

Written by Yong Li <yong.li@torchmobile.com> and George Staikos <george.staikos@torchmobile.com>
with trivial style fixes by Adam Treat <adam.treat@torchmobile.com>

  • platform/graphics/wince/GraphicsContextWince.cpp: Added.
13:06 Changeset [46128] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r46058.

12:37 Changeset [46127] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r46039.

10:56 Changeset [46126] by eroman@chromium.org
  • 3 edits
    4 adds in trunk/WebCore

2009-07-20 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adding the Win SQLite VFS implementation for Chromium, and stubs
for the Mac and Linux VFSs.

https://bugs.webkit.org/show_bug.cgi?id=26940

  • WebCore.gypi:
  • platform/chromium/ChromiumBridge.h:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: Added.
  • platform/sql/chromium/SQLiteFileSystemChromiumLinux.cpp: Added.
  • platform/sql/chromium/SQLiteFileSystemChromiumMac.cpp: Added.
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: Added.
06:47 Changeset [46125] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=27097
[Gtk] Segfault when examining an object of ROLE_TABLE via at-spi

Check that an object is a RenderObject before trying to access its
renderer and related node.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
06:36 Changeset [46124] by hausmann@webkit.org
  • 5 edits in trunk/WebCore

2009-07-20 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] font cache reworking
https://bugs.webkit.org/show_bug.cgi?id=27265

Reimplemented Qt's FontCache in a way that follows the shared one.
Now we can release its elements when those became inactive.
FontFallbackList had been changed to be able to hold WebCore fonts in its list and to be able to release a FontData what is in the cache.

No change in behavior, so no tests.

  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue): (WebCore::FontPlatformDataCacheKey::): Key type for the cache of FontPlatformData objects. It can be constructed from a FontPlatformData or from a FontDescription. The keys have to be consistent with FontPlatformData::FontPlatformData(const FontDescription&) - if we create the same FontPlatformData from two FontDescription then we have to create the same key from them, and vica versa. (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::FontPlatformDataCacheKey::hash): (WebCore::FontPlatformDataCacheKey::computeHash): (WebCore::FontPlatformDataCacheKey::hashTableDeletedSize): (WebCore::FontPlatformDataCacheKeyHash::hash): (WebCore::FontPlatformDataCacheKeyHash::equal): (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): (WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue): (WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue): (WebCore::FontCache::getCachedFontPlatformData): Get a FontDescription and returns a FontPlatformData. (WebCore::FontCache::getCachedFontData): Get a FontPlatformData and returns a SimpleFontData. (WebCore::FontCache::releaseFontData): Get a SimpleFontData and releases it from the cache. Also releases the appropriate FontPlatformData. (WebCore::FontCache::purgeInactiveFontData): Frees inactive elements. (WebCore::FontCache::invalidate): Frees all inactive elements (call purgeInactiveFontData with default argument)
  • platform/graphics/qt/FontFallbackListQt.cpp: (WebCore::FontFallbackList::releaseFontData): (WebCore::FontFallbackList::fontDataAt):
  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::family): Getter. It is needed for FontPlatformDataCacheKey. (WebCore::FontPlatformData::bold): Ditto. (WebCore::FontPlatformData::italic): Ditto. (WebCore::FontPlatformData::smallCaps): Ditto. (WebCore::FontPlatformData::pixelSize): Ditto.
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): Set m_bold.
04:01 Changeset [46123] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-07-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

[GTK] Widget size negotiation
https://bugs.webkit.org/show_bug.cgi?id=17154

Implement proper size request for the WebView widget.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::contentsSizeChanged):
  • webkit/webkitwebview.cpp: (webkit_web_view_size_request): (webkit_web_view_class_init):
03:09 Changeset [46122] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>

No review, just adding Gavin Barraclough as reviewer.

  • Scripts/modules/bugzilla.py:
03:04 Changeset [46121] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Allow custom memory allocation control in NewThreadContext
https://bugs.webkit.org/show_bug.cgi?id=27338

Inherits NewThreadContext struct from FastAllocBase because it
has been instantiated by 'new' JavaScriptCore/wtf/Threading.cpp:76.

  • wtf/Threading.cpp:
03:04 Changeset [46120] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Allow custom memory allocation control in JavaScriptCore's JSClassRef.h
https://bugs.webkit.org/show_bug.cgi?id=27340

Inherit StaticValueEntry and StaticFunctionEntry struct from FastAllocBase because these
have been instantiated by 'new' in JavaScriptCore/API/JSClassRef.cpp:153
and in JavaScriptCore/API/JSClassRef.cpp:166.

  • API/JSClassRef.h:
03:03 Changeset [46119] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control in JavaScriptCore's RegexPattern.h
https://bugs.webkit.org/show_bug.cgi?id=27343

Inherits RegexPattern.h's structs (which have been instantiated by operator new) from FastAllocBase:

CharacterClass (new call: JavaScriptCore/yarr/RegexCompiler.cpp:144)
PatternAlternative (new call: JavaScriptCore/yarr/RegexPattern.h:221)
PatternDisjunction (new call: JavaScriptCore/yarr/RegexCompiler.cpp:446)

  • yarr/RegexPattern.h:
03:03 Changeset [46118] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's MatchFrame struct
https://bugs.webkit.org/show_bug.cgi?id=27344

Inherits MatchFrame struct from FastAllocBase because it has
been instantiated by 'new' JavaScriptCore/pcre/pcre_exec.cpp:359.

  • pcre/pcre_exec.cpp:
03:02 Changeset [46117] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=26716
[Gtk] Each XMLHttpRequest leaks memory.

Free the SoupURI we create to check the URI. Fix suggested by John
Kjellberg.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
02:52 Changeset [46116] by hausmann@webkit.org
  • 4 edits in trunk

.:

2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] Add an option for QtLauncher to build without QtUiTools dependency
https://bugs.webkit.org/show_bug.cgi?id=27438

Based on Norbert Leser's work.

  • WebKit.pri: Symbian does not have UiTools

WebKit/qt:

2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] Add an option for QtLauncher to build without QtUiTools dependency
https://bugs.webkit.org/show_bug.cgi?id=27438

Based on Norbert Leser's work.

  • QtLauncher/main.cpp: (WebPage::createPlugin):
02:50 Changeset [46115] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

Remove some outdated S60 platform specific code
https://bugs.webkit.org/show_bug.cgi?id=27423

  • wtf/Platform.h:
02:49 Changeset [46114] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

Qt build fix with MSVC and MinGW.

  • jsc.pro: Make sure jsc is a console application, and turn off exceptions and stl support to fix the build.
02:46 Changeset [46113] by hausmann@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by David Levin.

Add support for Qt's foreach to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27386

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
02:41 Changeset [46112] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] On Symbian link against system sqlite3
https://bugs.webkit.org/show_bug.cgi?id=27368

Add an option to force linking against system sqlite3
by adding system-sqlite to the CONFIG variable.

The Symbian specific part of this patch is contributed by
Norbert Leser.

  • WebCore.pro:
02:32 Changeset [46111] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by and done with Tor Arne Vestbø.

Fix fast/css/pseudo-required-optional-*.html in the Qt build
after r46062.

These tests triggered a bug in RenderThemeQt where we did not fall back
to the unstyled painting of text areas and input fields when they have
a styled background.

Our re-implementation of isControlStyled incorrectly only checked the
border for determining whether to style or not. The base-implementation
performs the same check, but also includes the background. Removing
our implementation fixes the appearance.

  • platform/qt/RenderThemeQt.cpp: Removed isControlStyled reimplementation.
  • platform/qt/RenderThemeQt.h: Ditto.
01:31 Changeset [46110] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not use C++-style comments in preprocessor directives.

GCC does not like this in some configurations, using C-style
comments is safer.

  • wtf/Platform.h:
01:31 Changeset [46109] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Change the glib version check to check for the first unstable
release with g_mapped_file_unref. Otherwise this would be useless
until 2.22 is released, a few months from now.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
00:51 Changeset [46108] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Tor Arne Vestbø.

Add missing (sorted) header files to the HEADERS variable in the qmake
.pro file for improved completion in IDEs.

  • WebCore.pro:
00:24 Changeset [46107] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-19 Simon Hausmann <hausmann@webkit.org>

Rubber-stamped by Xan Lopez.

Skip new fast/dom/prototype-inheritance.html test in the Qt DRT
due to missing features/properties in the window object.

  • platform/qt/Skipped:
Note: See TracTimeline for information about the timeline view.