Timeline


and

07/27/09:

23:05 Changeset [46459] by abarth@webkit.org
  • 5 edits
    12 adds in trunk/WebCore

2009-07-25 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[V8] Split up V8DOMMap.cpp by class
https://bugs.webkit.org/show_bug.cgi?id=27685

No behavior change. Just copy-and-paste.

  • WebCore.gypi:
  • bindings/v8/ChildThreadDOMData.cpp: Added. (WebCore::ChildThreadDOMData::ChildThreadDOMData): (WebCore::ChildThreadDOMData::getStore):
  • bindings/v8/ChildThreadDOMData.h: Added.
  • bindings/v8/DOMData.cpp: Added. (WebCore::DOMData::DOMData): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getCurrentMainThread): (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::ensureDeref): (WebCore::DOMData::derefObject): (WebCore::DOMData::derefDelayedObjects): (WebCore::DOMData::derefDelayedObjectsInCurrentThread): (WebCore::DOMData::removeObjectsFromWrapperMap):
  • bindings/v8/DOMData.h: Added. (WebCore::):
  • bindings/v8/DOMDataStore.cpp: Added. (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStore::allStores): (WebCore::DOMDataStore::allStoresMutex): (WebCore::DOMDataStore::getDOMWrapperMap): (WebCore::forget): (WebCore::DOMDataStore::weakDOMObjectCallback): (WebCore::DOMDataStore::weakActiveDOMObjectCallback): (WebCore::DOMDataStore::weakNodeCallback): (WebCore::DOMDataStore::weakSVGElementInstanceCallback): (WebCore::DOMDataStore::weakSVGObjectWithContextCallback):
  • bindings/v8/DOMDataStore.h: Added. (WebCore::DOMDataStore::): (WebCore::DOMDataStore::InternalDOMWrapperMap::InternalDOMWrapperMap): (WebCore::DOMDataStore::InternalDOMWrapperMap::forgetOnly): (WebCore::DOMDataStore::domData): (WebCore::DOMDataStore::domNodeMap): (WebCore::DOMDataStore::domObjectMap): (WebCore::DOMDataStore::activeDomObjectMap): (WebCore::DOMDataStore::domSvgElementInstanceMap): (WebCore::DOMDataStore::domSvgObjectWithContextMap):
  • bindings/v8/MainThreadDOMData.cpp: Added. (WebCore::MainThreadDOMData::MainThreadDOMData): (WebCore::MainThreadDOMData::getStore):
  • bindings/v8/MainThreadDOMData.h: Added.
  • bindings/v8/ScopedDOMDataStore.cpp: Added. (WebCore::ScopedDOMDataStore::ScopedDOMDataStore): (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
  • bindings/v8/ScopedDOMDataStore.h: Added.
  • bindings/v8/StaticDOMDataStore.cpp: Added. (WebCore::StaticDOMDataStore::StaticDOMDataStore):
  • bindings/v8/StaticDOMDataStore.h: Added.
  • bindings/v8/V8DOMMap.cpp:
22:24 Changeset [46458] by beidson@apple.com
  • 8 edits in trunk/LayoutTests

2009-07-27 Brady Eidson <beidson@apple.com>

Update Tiger specific results for these 7 tests.

  • platform/mac-tiger/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/mac-tiger/security/block-test-expected.txt:
  • platform/mac-tiger/security/block-test-no-port-expected.txt:
21:53 Changeset [46457] by beidson@apple.com
  • 6 edits in trunk/LayoutTests

2009-07-27 Brady Eidson <beidson@apple.com>

Update Windows specific results for these 5 tests.

  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt:
21:50 Changeset [46456] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

2009-07-27 Brady Eidson <beidson@apple.com>

Didn't mean to check this guy in.

  • http/tests/appcache/max-size-expected.txt:
21:29 Changeset [46455] by beidson@apple.com
  • 21 edits in trunk

WebKitTools:

2009-07-27 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=27755
Layout tests that dump resource load delegate calls should dump the request method and the response status code.

  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURLResponse _drt_descriptionSuitableForTestResult]): (-[NSURLRequest _drt_descriptionSuitableForTestResult]):
  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (descriptionSuitableForTestResult):

LayoutTests:

2009-07-27 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=27755
Layout tests that dump resource load delegate calls should dump the request method and the response status code.

Update test results for the new info.

  • fast/loader/main-document-url-for-non-http-loads-expected.txt:
  • http/tests/appcache/max-size-expected.txt:
  • http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
  • http/tests/misc/window-dot-stop-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt:
  • platform/mac/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • platform/mac/security/block-test-expected.txt:
  • platform/mac/security/block-test-no-port-expected.txt:
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:
19:50 UsingGitWithWebKit edited by pdherbemont@apple.com
--regenerate-log (diff)
19:29 Changeset [46454] by pdherbemont@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-27 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by David Levin.

"bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load.
https://bugs.webkit.org/show_bug.cgi?id=27747

modules.bugzilla is not found because not included.

  • Scripts/modules/scm.py: Properly import modules.bugzilla.
19:28 Changeset [46453] by pdherbemont@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-24 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by David Kilzer.

commit-log-editor should allow git commit --amend to regenerate the commit log based on the modifed ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=27664

  • Scripts/commit-log-editor: Add --regenerate-log option. The user is asked if he wants to suppress previous ChangeLog and regenerate it, if this option is enabled.
19:25 Changeset [46452] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

19:24 Changeset [46451] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.9

New tag.

18:57 Changeset [46450] by mrowe@apple.com
  • 6 edits in branches/safari-4-branch

Merge r46449.

18:49 Changeset [46449] by mrowe@apple.com
  • 6 edits in trunk

<rdar://problem/7091036> REGRESSION: Microsoft Messenger crashes during file send/receive due to use of WebKit on non-main thread

Reviewed by Darin Adler.

In some situations Microsoft Messenger can attempt to manipulate the DOM from a secondary thread while
updating its file transfer progress bar. This results in corruption of WebCore data structures that is
quickly followed by a crash. We can work around this by having -[WebFrame DOMDocument] return nil when
called from a secondary thread by Microsoft Messenger, which has the effect of turning its attempts at
DOM manipulation in to no-ops.

  • WebView/WebFrame.mm:

(needsMicrosoftMessengerDOMDocumentWorkaround):
(-[WebFrame DOMDocument]):

Add a method for detecting if we're being used within Microsoft Messenger.

  • WebCore.base.exp: Export applicationIsMicrosoftMessenger and sort existing entries.
  • platform/mac/RuntimeApplicationChecks.h:
  • platform/mac/RuntimeApplicationChecks.mm:

(WebCore::applicationIsMicrosoftMessenger):

18:11 Changeset [46448] by jianli@chromium.org
  • 3 edits in trunk/WebCore

2009-07-27 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

[V8] Implement EventListener::reportError for V8 event listeners in worker context.
https://bugs.webkit.org/show_bug.cgi?id=27731

  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::reportError):
  • bindings/v8/V8WorkerContextEventListener.h:
17:50 Changeset [46447] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-27 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel and David Levin.

Re-apply chromium/skia border fix (originally landed in r46157,
reverted in r46363), since it was not the cause of the reliability
failures in Chromium.

http://bugs.webkit.org/show_bug.cgi?id=27388

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
17:47 Changeset [46446] by rniwa@webkit.org
  • 7 edits
    3 adds in trunk

WebCore:

2009-07-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

createMarkup does not handle CSS properly
https://bugs.webkit.org/show_bug.cgi?id=27660

This patch isolates code that creates markup for styles in addStyleMarkup
It also makes all presentational elements (u, s, strike, i, em, b, strong) special ancestor in createMarkup
so that we can assume no text decoration style is passed to addStyleMarkup.

  • editing/markup.cpp: (WebCore::propertyMissingOrEqualToNone): Changed the first argument from CSSMutableStyleDecleration to CSSStyleDeclaration (WebCore::isElementPresentational): Used to be elementHasTextDecorationProperty, now supports presentational tags (WebCore::addStyleMarkup): Adds markup for style span and div (WebCore::createMarkup): Uses isElementPresentational and addStyleMarkup

LayoutTests:

2009-07-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

createMarkup does not handle CSS properly
https://bugs.webkit.org/show_bug.cgi?id=27660


inline-style-after-indentoutdent tests whether the original inline style is preserved after outdentation
immediately after indentation.

  • editing/deleting/pruning-after-merge-2.html: Replaced b that contains div with a div with font-weight
  • editing/execCommand/inline-style-after-indentoutdent-expected.txt: Added.
  • editing/execCommand/inline-style-after-indentoutdent.html: Added.
  • editing/execCommand/resources/inline-style-after-indentoutdent.js: Added. (testCreateMarkup): (shouldBeSameAfterCreateMarkup):
  • platform/mac/editing/deleting/delete-3857753-fix-expected.txt: extra i tag is added (still passes pixel tests)
  • platform/mac/editing/deleting/pruning-after-merge-2-expected.txt: extra div as explained above
  • platform/mac/editing/pasteboard/display-block-on-spans-expected.txt: bug 26483 appearing
17:35 Changeset [46445] by zimmermann@webkit.org
  • 7 edits in trunk/LayoutTests

Rubber-stamped by George Staikos.
Forgot to update pixel test results a while ago.

17:21 Changeset [46444] by eric@webkit.org
  • 13 edits in trunk/WebCore

2009-07-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

fix more obvious global object lookups
https://bugs.webkit.org/show_bug.cgi?id=27745

No new tests for these changes. I believe in many cases
testing to be impossible. Lack of testing justification next to
each change below. The remaining pieces of bug 27634 will all
need tests.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::updateDocument): not testable.
  • bindings/js/JSDataGridColumnListCustom.cpp: (WebCore::JSDataGridColumnList::nameGetter): no testing for this incomplete feature.
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent): would require outer frame to trigger an event in the inner frame
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): covered by other tests, always correct to pass the globalObject through.
  • bindings/js/JSHTMLElementCustom.cpp: (WebCore::JSHTMLElement::pushEventHandlerScope): unclear when this could be triggered.
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::remove): toJS seems superfluous here to begin with.
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): would require outer frame to trigger inner frame event.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::jsObjectForPluginElement): only used for NPAPI binding, unclear how to test.
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): unclear how to test.
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set): unclear how to test/inspector only.
  • bindings/js/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject): unclear how to test.
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]): unclear how to test.
17:16 Changeset [46443] by zimmermann@webkit.org
  • 9 edits in trunk/WebCore

2009-07-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] 'title' attribute handling not correct for <a> / <anchor> elements
https://bugs.webkit.org/show_bug.cgi?id=27720

Unify title() implementation in WMLElement instead of several copies of the same logic.
We forgot WMLAnchorElement/WMLAElement, that lead to bugs. Fixes hovering links in the
WML manual-test suite.

  • wml/WMLCardElement.cpp:
  • wml/WMLCardElement.h:
  • wml/WMLElement.cpp: (WebCore::WMLElement::title):
  • wml/WMLElement.h:
  • wml/WMLOptGroupElement.cpp:
  • wml/WMLOptGroupElement.h:
  • wml/WMLSelectElement.cpp:
  • wml/WMLSelectElement.h:
16:28 Changeset [46442] by bweinstein@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix for Windows.

16:21 Changeset [46441] by bweinstein@apple.com
  • 5 edits in trunk

Build fix for Windows for JSC recent breakage.

16:21 Changeset [46440] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

prototypes-inheritance-2.html should crawl more types
https://bugs.webkit.org/show_bug.cgi?id=27741

Now we evaluate the crawl targets lazily so as not to skew any JS binding caching with our test ordering.
We could get around all caching by always instantiating a new copy of the frame
but that would be super-slow. :)

We're now crawling a bunch more types, all of which we pass.

  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/resources/prototype-inheritance-2.js: (evalToCrawlObject.LazyEvalCrawlObject): (evalToCrawlObject): (pushPropertyValuesWithUnseenTypes): (crawl):
16:19 Changeset [46439] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Adam Treat <adam.treat@torchmobile.com>

Speculative build fix for Windows and WinCE.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
15:56 Changeset [46438] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

2009-07-27 Gavin Barraclough <barraclough@apple.com>

Rubber stamped by Oliver Hunt.

Fix tyop in JIT, renamed preverveReturnAddressAfterCall -> preserveReturnAddressAfterCall.

  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::preserveReturnAddressAfterCall):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
15:45 Changeset [46437] by ojan@chromium.org
  • 8 edits
    2 adds in trunk

2009-07-27 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27474
Tests crashes when calling select, setSelectionRange or setting
selectionStart/selectionEnd on a textarea/input immediately after
setting display:none.

  • fast/dom/text-control-crash-on-select-expected.txt: Added.
  • fast/dom/text-control-crash-on-select.html: Added.

2009-07-27 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27474
Fixes crashes due to renderer getting destroyed in updateLayout.
We need to call updateLayout before we call into the renderer.
Removed the updateLayout call from RenderTextControl and moved it
into the calling sites.

Also changes updateLayout to updateLayoutIgnorePendingStylesheets so
this works with pending stylesheets. Unfortunately, this seems to be
untestable. Loading an external stylesheet and then having an inline
script hit this code did not result in an pending stylesheets.

The are other cases of this bug in the rendering code. I'll file a
followup bug to audit the calls to updateLayout.

Test: fast/dom/text-control-crash-on-select.html

  • dom/Document.h: (WebCore::Document::inStyleRecalc): Added so the ASSERTs in updateFocusAppearance

and setSelectionRange could deal with cases of reentrancy into updateLayout
calls. This happens in a couple layout tests.

  • dom/InputElement.cpp: (WebCore::InputElement::updateSelectionRange):
  • html/HTMLInputElement.cpp: (WebCore::isTextFieldWithRendererAfterUpdateLayout): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select):
  • html/HTMLTextAreaElement.cpp: (WebCore::rendererAfterUpdateLayout): (WebCore::HTMLTextAreaElement::setSelectionStart): (WebCore::HTMLTextAreaElement::setSelectionEnd): (WebCore::HTMLTextAreaElement::select): (WebCore::HTMLTextAreaElement::setSelectionRange): (WebCore::HTMLTextAreaElement::updateFocusAppearance):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setSelectionRange):
15:43 Changeset [46436] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Gtk build fix.

  • runtime/JSLock.cpp: (JSC::JSLock::JSLock): Fix "no threading" case.
15:40 Changeset [46435] by dglazkov@chromium.org
  • 13 edits in trunk/WebCore

2009-07-27 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Dave Levin.

[V8] Remove parameterless frame/window retrieval methods from V8Proxy.
https://bugs.webkit.org/show_bug.cgi?id=27737

Refactoring, no new behavior, covered by existing tests.

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/V8NPUtils.cpp: (convertV8ObjectToNPVariant): Ditto.
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieve): Ditto. (WebCore::V8Proxy::canAccessPrivate): Ditto.
  • bindings/v8/V8Proxy.h: Removed parameterless retrieveWindow/retrieveProxy decls.
  • bindings/v8/custom/V8DatabaseCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Changed to use V8Proxy::retrieveFrameForCurrentContext().
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8SQLTransactionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
15:36 Changeset [46434] by ap@webkit.org
  • 2 edits in trunk/WebKit/gtk

Gtk build fix.

  • webkit/webkitwebframe.cpp: (webkit_gc_count_javascript_objects): Added a namespace to SilenceAssertionsOnly.
15:26 Changeset [46433] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Release build fix.

  • runtime/JSLock.h: (JSC::JSLock::~JSLock):
15:18 Changeset [46432] by zimmermann@webkit.org
  • 3 edits
    3 adds in trunk

WebCore:

2009-07-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] 'onpick' intrinsic event handling missing
https://bugs.webkit.org/show_bug.cgi?id=27723

Trigger 'onpick' intrinsic events from WMLOptionElement::setSelectedState().
All was in place, just forgot to enable the relevant code.

Fixes manual-tests/wml/select-onpick-event.wml
Test: wml/option-element-onpick.html

  • wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::setSelectedState):

LayoutTests:

2009-07-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] 'onpick' intrinsic event handling missing
https://bugs.webkit.org/show_bug.cgi?id=27723

Add a new WML layout test covering 'onpick' support.

  • wml/option-element-onpick-expected.txt: Added.
  • wml/option-element-onpick.html: Added.
  • wml/resources/option-element-onpick.js: Added. (setupTestDocument): (prepareTest): (executeTest):
15:07 Changeset [46431] by ap@webkit.org
  • 84 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27735
Give a helpful name to JSLock constructor argument

15:00 Changeset [46430] by treat@webkit.org
  • 4 edits in trunk/WebCore

2009-07-27 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

WINCE PORT: Make plugin work for WINCE
https://bugs.webkit.org/show_bug.cgi?id=27713

  • plugins/win/PluginDatabaseWin.cpp: (SHGetValue): (PathRemoveFileSpec): (WebCore::addWindowsMediaPlayerPluginDirectory): (WebCore::addMacromediaPluginDirectories):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
  • plugins/win/PluginViewWin.cpp: (WebCore::registerPluginView): (WebCore::PluginView::wndProc): (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paintWindowedPluginIntoContext): (WebCore::PluginView::paint): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::stop): (WebCore::PluginView::init):
14:58 Changeset [46429] by timothy@apple.com
  • 4 edits in trunk/WebCore

Adds support to the Web Inspector for tabbing through element attributes and CSS properties when editing.

2009-07-27 Joseph Pecoraro <joepeck02@gmail.com>

Inspector: Tab Through Element Attributes and CSS Properties When Editing

https://bugs.webkit.org/show_bug.cgi?id=27673

Reviewed by Timothy Hatcher.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._startEditing): refactored parameter (WebInspector.ElementsTreeElement.prototype._addNewAttribute): refactored to remove excess (WebInspector.ElementsTreeElement.prototype._triggerEditAttribute): provide an attribute name and this will start editing it (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded): move between attributes (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.StylePropertiesSection.prototype.findTreeElementWithName): search through treeElements for a style property name (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): initialize a blank property for adding new properties (WebInspector.StylePropertyTreeElement.prototype.updateTitle): add references to the name and value elements (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.js: (WebInspector.startEditing.editingCommitted): include the move direction as a parameter to the commit callback (WebInspector.startEditing.element.handleKeyEvent): handle the tab key to specify the move direction (WebInspector.startEditing):
14:31 Changeset [46428] by treat@webkit.org
  • 4 edits in trunk/WebCore

2009-07-27 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add mapping FontWeight to QFont::Weight values as requested via FIXME.
https://bugs.webkit.org/show_bug.cgi?id=27663

  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::toQFontWeight):
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
14:21 WebKit Team edited by abarth@webkit.org
(diff)
14:21 Changeset [46427] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Treat.

When clearing the plugin database, clear also the timestamp map.

https://bugs.webkit.org/show_bug.cgi?id=27651

Currently, if we clear the database, it will still think that it is up
to date with the plugin directories so refreshing the database again
after changing the search paths may not work.

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::clear):
14:17 Changeset [46426] by jianli@chromium.org
  • 3 edits in trunk/WebCore

2009-07-27 Albert J. Wong <ajwong@chromium.org>

Reviewed by David Levin.

Add in trivial implementation of FontPlatformData::description() for
linux to fix build bustage in chromium.

Fix chromium linux build by adding missing function implementation.
https://bugs.webkit.org/show_bug.cgi?id=27732

Tested with a build of chromium on linux.

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::description):
  • platform/graphics/chromium/FontPlatformDataLinux.h:
12:45 QtWebKitTodo edited by andre.pedralho@openbossa.org
(diff)
12:09 Changeset [46425] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Brent Fulgham <bfulgham@webkit.org>

Build correct, no review.

Final correction for WinCairo builds.
CoreServices only exists in Apple builds, but
some of its internal includes (e.g., <windows.h>) are needed
for other Windows targets.

  • WebCorePrefix.h: When building for WinCairo, make sure to include <windows.h>, <stdio.h>, and <ConditionalMacros.h>
11:54 Changeset [46424] by pkasting@chromium.org
  • 2 edits in trunk/WebKitLibraries

2009-07-27 Peter Kasting <pkasting@google.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=27323
Correctly parse command output, even when the line endings are not LF,
so that we don't create an autoversion.h that MSVC chokes on.

  • win/tools/scripts/auto-version.sh:
11:32 Changeset [46423] by pkasting@chromium.org
  • 8 edits
    22 adds in trunk

WebCore:

2009-07-27 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25552
Added new "pattern" attribute to HTMLInputElement and validation code
(validity.patternMismatch) as per HTML5 specs.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-pattern

Tests: fast/forms/ValidityState-002.html

fast/forms/ValidityState-patternMismatch-001.html
fast/forms/ValidityState-patternMismatch-002.html
fast/forms/ValidityState-patternMismatch-003.html
fast/forms/ValidityState-patternMismatch-004.html
fast/forms/ValidityState-patternMismatch-005.html
fast/forms/ValidityState-patternMismatch-006.html
fast/forms/ValidityState-patternMismatch-007.html
fast/forms/pattern-attribute-001.html
fast/forms/pattern-attribute-002.html
fast/forms/pattern-attribute-003.html

  • html/HTMLAttributeNames.in: pattern attribute
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::patternMismatch): method definition
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::patternMismatch): validation method
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • html/ValidityState.h: (WebCore::ValidityState::patternMismatch): validation flag

LayoutTests:

2009-07-27 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25552
First series of tests for the "pattern" attribute and related validation
code

  • fast/forms/ValidityState-002-expected.txt: Copied from LayoutTests/fast/forms/willvalidate-001-expected.txt.
  • fast/forms/ValidityState-002.html: Added.
  • fast/forms/ValidityState-patternMismatch-001-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-001.html: Added.
  • fast/forms/ValidityState-patternMismatch-002-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-002.html: Added.
  • fast/forms/ValidityState-patternMismatch-003-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-003.html: Added.
  • fast/forms/ValidityState-patternMismatch-004-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-004.html: Added.
  • fast/forms/ValidityState-patternMismatch-005-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-005.html: Added.
  • fast/forms/ValidityState-patternMismatch-006-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-006.html: Added.
  • fast/forms/ValidityState-patternMismatch-007-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-007.html: Added.
  • fast/forms/pattern-attribute-001-expected.txt: Added.
  • fast/forms/pattern-attribute-001.html: Added.
  • fast/forms/pattern-attribute-002-expected.txt: Added.
  • fast/forms/pattern-attribute-002.html: Added.
  • fast/forms/pattern-attribute-003-expected.txt: Added.
  • fast/forms/pattern-attribute-003.html: Added.
11:22 Changeset [46422] by zimmermann@webkit.org
  • 31 edits
    3 adds
    7 deletes in trunk/WebCore

Reviewed by George Staikos.

[WML] Manual WML tests aren't properly working
https://bugs.webkit.org/show_bug.cgi?id=27718

Fix file paths in the manual WML layout tests, remove unneeded tests (already covered by DRT tests).
Add missing resources directory and test image. Reformat all testcases to a common style.
Add new StartTests.wml file, which should be used as starting point to crawl through the manual tests.

Filing bugs soon for all tests exposing bugs (7 in total).

11:17 Changeset [46421] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2009-07-27 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a regression introduced in r42671, which caused the js event
object to be hidden (some websites depend on being able to access it).

https://bugs.webkit.org/show_bug.cgi?id=27719

11:08 Changeset [46420] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-07-27 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Removing a no-op block of code in DatabaseTracker.cpp that
should've been removed in the patch for bug 26054.

https://bugs.webkit.org/show_bug.cgi?id=27666

All tests in WebCore/storage pass.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): Removed a no-op block of code that was moved to SQLiteFileSystem.cpp and should have been removed from DatabaseTracker.cpp
10:45 Changeset [46419] by jianli@chromium.org
  • 13 edits
    7 adds in trunk

WebCore:

2009-07-27 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Fix error handling in dedicated worker and worker context.
https://bugs.webkit.org/show_bug.cgi?id=27525

The following problems have been fixed:
1) The uncaught runtime script error is not reported using the
WorkerGlobalScope object's onerror attribute.
2) If the error is still not handled afterwards (onerror attribute
is not defined as a function or it returns true), the error should
be reported back to the associated Worker object by firing an
ErrorEvent.
3) If the error is still not handled by the associated Worker
object, the error should be reported to the user.

Test: fast/workers/worker-script-error.html

  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::reportError):
  • bindings/js/JSEventListener.h:
  • dom/EventListener.h: (WebCore::EventListener::reportError): adds a function to call EventListener as a function with 3 arguments to report an error.
  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::dispatchScriptErrorEvent):
  • workers/AbstractWorker.h:
  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::reportException):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::reportException):
  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerExceptionTask::performTask):
  • workers/WorkerMessagingProxy.h:

LayoutTests:

2009-07-27 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Layout tests for fixing error handling in dedicated worker and worker
context.
https://bugs.webkit.org/show_bug.cgi?id=27525

  • fast/workers/resources/worker-error-in-handling-script-error.js: Added
  • fast/workers/resources/worker-invalid-syntax.js: Added.
  • fast/workers/resources/worker-script-error-bubbled.js: Added.
  • fast/workers/resources/worker-script-error-handled.js: Added.
  • fast/workers/resources/worker-script-error-unhandled.js: Added.
  • fast/workers/worker-constructor.html:
  • fast/workers/worker-script-error-expected.txt: Added.
  • fast/workers/worker-script-error.html: Added. Add test cases to cover different script error handling scenarios.
10:04 Changeset [46418] by zimmermann@webkit.org
  • 13 edits
    8 adds in trunk

[WML] History handling / page cache / loading is buggy and depends on several hacks
https://bugs.webkit.org/show_bug.cgi?id=27707

Redesign WML history/loading handling. See ChangeLog for details.

08:09 Changeset [46417] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-07-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Adam Roben.

Fix Chromium build breakage introduced in 46388.

https://bugs.webkit.org/show_bug.cgi?id=27705

  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::description):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h:
06:41 Changeset [46416] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-27 Gabor Rapcsanyi <rapcsanyi.gabor@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Generating remote links causes a lot of unnecessary spew on Qt build bot too

  • Scripts/run-webkit-tests:
04:34 Changeset [46415] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-07-27 Volker Hilsheimer <volker.hilsheimer@nokia.com>

Reviewed by Simon Hausmann.

QWebView's "enabled" parameter should default to true, as with QGraphicsView and
QPainter.

  • Api/qwebview.cpp: Add reference to QPainter::renderHints().
  • Api/qwebview.h: Add default for enabled argument.
04:29 Changeset [46414] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Add some more debug logging to PluginViewMac.

  • plugins/mac/PluginViewMac.cpp:
04:27 Changeset [46413] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Jan Michael Alonzo.

Remove dead code from the GTK NPAPI implementation.

  • plugins/gtk/PluginViewGtk.cpp:
04:06 Changeset [46412] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Add fast/canvas/image-pattern-rotate.html to Skipped as it needs
platform-specific expected results.

  • platform/gtk/Skipped:
03:39 Changeset [46411] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Buildfix on Windows.
https://bugs.webkit.org/show_bug.cgi?id=27702

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::hookedEndPaint):

Constraint of (*endPaint) operand modified from "g" to "m" (memory) in inline
assembly, because with "g" constraint, wrong assembly code generated.

02:06 Changeset [46410] by pfeldman@chromium.org
  • 6 edits
    4 adds in trunk/WebCore

2009-07-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebCore bindings: Implement ScriptArray bindings.

https://bugs.webkit.org/show_bug.cgi?id=27691

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptArray.cpp: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::handleException): (WebCore::ScriptArray::set): (WebCore::length): (WebCore::ScriptArray::createNew):
  • bindings/js/ScriptArray.h: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::jsArray):
  • bindings/v8/ScriptArray.cpp: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::set): (WebCore::ScriptArray::length): (WebCore::ScriptArray::createNew):
  • bindings/v8/ScriptArray.h: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::~ScriptArray):
00:17 Changeset [46409] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Brent Fulgham <bfulgham@webkit.org>

Build correct, no review.

Change in r46407 broke Apple Windows build.
Switch to WinCairo-only test, to avoid any
other platform break.

  • WebCorePrefix.h:
00:02 Changeset [46408] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-26 Brent Fulgham <bfulgham@webkit.org>

Build correct, no review.

Change in r46407 broke Apple Windows build.

  • WebCorePrefix.h: Use WTF_PLATFORM_CG to decide if CoreServices.h should be included.

07/26/09:

23:39 Changeset [46407] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-26 Brent Fulgham <bfulgham@webkit.org>

Build correction, no review.

Change in r46195 broke WinCairo build.

  • WebCorePrefix.h: CoreServices should be ignored for non-Apple build.
12:47 Changeset [46406] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

More documentation cleanups in the QWebElement class overview.

  • Api/qwebelement.cpp:
12:47 Changeset [46405] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

Clean up documentation of QWebElement's findFirst and findAll functions,
as well as their QWebFrame counterparts.

  • Api/qwebelement.cpp:
  • Api/qwebframe.cpp:
12:47 Changeset [46404] by hausmann@webkit.org
  • 5 edits in trunk/WebKit/qt

2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

Various documentation cleanups

  • Fixed qdoc warnings
  • Hide QWebNetworkInterface from the class overview
  • Mention QWebElement in the module overview
  • More cleanups
  • Api/qwebframe.cpp:
  • Api/qwebnetworkinterface.cpp:
  • Api/qwebview.cpp:
  • docs/qtwebkit.qdoc:
12:47 Changeset [46403] by hausmann@webkit.org
  • 2 edits
    1 add in trunk/WebKit/qt

2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

Added missing class diagram referenced from the docs, taken from the Qt
documentation.

  • docs/qtwebkit.qdocconf: Register the image directory with qdoc.
  • docs/qwebview-diagram.png: Added.
08:36 Changeset [46402] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2009-07-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement the breakpoints sidebar pane.
This change adds simple UI support into the existing
BreakpointSidebarPane.

https://bugs.webkit.org/show_bug.cgi?id=11175

  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set enabled): (WebInspector.Breakpoint.prototype.get label): (WebInspector.Breakpoint.prototype.get id):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane): (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.labelClicked): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.scriptOrResourceForID):
  • inspector/front-end/inspector.css:

07/25/09:

15:14 Changeset [46401] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-25 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Eric Seidel.

Allow custom memory allocation control for OpaqueJSPropertyNameArray struct
https://bugs.webkit.org/show_bug.cgi?id=27342

Inherits OpaqueJSPropertyNameArray struct from FastAllocBase because it has been
instantiated by 'new' JavaScriptCore/API/JSObjectRef.cpp:473.

  • API/JSObjectRef.cpp:
15:11 Changeset [46400] by abarth@webkit.org
  • 2 edits in trunk

Fixup ChangeLog.

15:00 Changeset [46399] by abarth@webkit.org
  • 5 edits
    4 adds in trunk

2009-07-16 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Oliver Hunt.

Canvas: rotation of 'no-repeat' pattern still has small error
https://bugs.webkit.org/show_bug.cgi?id=26749

Use (1<<23)/2 as steps of no-repeat pattern to make the error less
than 0.5. The previous value may cause 1 pixel errors.

Add another test to show this bug clearly.
Also add png expected image which was missing in the previous patch.

  • fast/canvas/image-pattern-rotate.html: Added.
  • platform/mac/fast/canvas/image-object-in-canvas-expected.checksum:
  • platform/mac/fast/canvas/image-object-in-canvas-expected.png:
  • platform/mac/fast/canvas/image-pattern-rotate-expected.checksum: Added.
  • platform/mac/fast/canvas/image-pattern-rotate-expected.png: Added.
  • platform/mac/fast/canvas/image-pattern-rotate-expected.txt: Added.

2009-07-16 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Oliver Hunt.

Canvas: rotation of 'no-repeat' pattern still has small error
https://bugs.webkit.org/show_bug.cgi?id=26749

Use (1<<23)/2 as steps of no-repeat pattern to make the error less
than 0.5. The previous value may cause 1 pixel errors.

Add another test to show this bug clearly.
Also add png expected image which was missing in the previous patch.

Test: fast/canvas/image-pattern-rotate.html

  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
14:36 Changeset [46398] by abarth@webkit.org
  • 7 edits in trunk

2009-07-25 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Windows build break due to warning C4819
https://bugs.webkit.org/show_bug.cgi?id=27416

Disable C4819 warning to fix build.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCore.vcproj:

2009-07-25 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Windows build break due to warning C4819
https://bugs.webkit.org/show_bug.cgi?id=27416

Disable C4819 warning to fix build.

  • WebKit.vcproj/WebKit.vcproj:

2009-07-25 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Windows build break due to warning C4819
https://bugs.webkit.org/show_bug.cgi?id=27416

Disable C4819 warning to fix build.

  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
14:34 Changeset [46397] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-25 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Kevin McCullough.

Inspector: Keyboard Shortcuts to Switch Panels
https://bugs.webkit.org/show_bug.cgi?id=27286

  • inspector/front-end/inspector.js: (WebInspector.loaded): save a list of the order of the panels (WebInspector.documentKeyDown): handle the keyboard shortcuts to traverse the panels
14:29 Changeset [46396] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-25 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by George Staikos.

[Qt] Fix build break after r46369
https://bugs.webkit.org/show_bug.cgi?id=27680

  • WebCore.pro:
09:43 Changeset [46395] by zimmermann@webkit.org
  • 8 edits
    4 adds in trunk

2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Variable substitution is buggy
https://bugs.webkit.org/show_bug.cgi?id=27677

Substitute variables upon attach() time instead of insertedIntoDocument(). Otherwhise variable substitution
won't work during inter-deck jumps (same URL, different fragment). Covered by new test fast/wml/newcontext-same-deck.html.

  • dom/Text.cpp: (WebCore::Text::attach):
  • dom/Text.h:

2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Variable substitution is buggy
https://bugs.webkit.org/show_bug.cgi?id=27677

Always substitute variables regardless of their existance. If a variable doesn't exist, expand it to an empty string.
Correct several testcases, relying on the old buggy behaviour.

  • wml/newcontext-same-deck-expected.txt: Added.
  • wml/newcontext-same-deck.html: Added.
  • wml/resources/WMLTestCase.js: (createWMLTestCase.iframeElement.onload): (createWMLTestCase): (assureLayout): (startTest): (triggerMouseEvent):
  • wml/resources/newcontext-same-deck.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/newcontext-same-deck.wml: Added.
  • wml/resources/select-element-variables.js: (prepareTest):
  • wml/select-element-variables-expected.txt:
  • wml/variable-reference-invalid-character-expected.txt:
09:35 Changeset [46394] by zimmermann@webkit.org
  • 10 edits in trunk

2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] WMLDoElement doesn't update its RenderButton object upon attach()
https://bugs.webkit.org/show_bug.cgi?id=27676

WMLDoElement needs to implement attach() and call updateFromElement() on its associated RenderButton.
Mimics HTMLButtonElement/HTMLFormControlElement behaviour and fixes several painting/styling issues covered by existing tests in fast/wml.

  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::attach):
  • wml/WMLDoElement.h:

2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] WMLDoElement doesn't update its RenderButton object upon attach()
https://bugs.webkit.org/show_bug.cgi?id=27676

Update layout test results after fixing WMLDoElement::attach() not calling updateFromElement().

  • platform/mac/fast/wml/do-element-optional-attr-expected.txt:
  • platform/mac/fast/wml/do-shadow-expected.txt:
  • platform/mac/fast/wml/do-template-expected.txt:
  • platform/mac/fast/wml/err-invalid-location-for-varref-expected.txt:
  • platform/mac/fast/wml/err-invalid-variable-name-expected.txt:
  • platform/mac/fast/wml/err-samename-do-expected.txt:
09:23 Changeset [46393] by zimmermann@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Make http/tests/wml/post-data-to-server.* more understable
https://bugs.webkit.org/show_bug.cgi?id=27675

Slightly cleanup this patch so it's easier to figure out what the expected result for <select> element is.

  • http/tests/wml/post-data-to-server-expected.txt:
  • http/tests/wml/resources/post-data-to-server.js: (setupTestDocument): (prepareTest):
02:51 Changeset [46392] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-25 Pavel Feldman <pfeldman@chromium.org>

Fix Windows build breakage introduced in 46390.

  • WebCore.vcproj/WebCore.vcproj:
02:44 Changeset [46391] by oliver@apple.com
  • 3 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Oliver Hunt.

Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update): use the displaySort when showing properties (WebInspector.ObjectPropertiesSection.prototype._displaySort): alphaNumerical sort (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): use the displaySort when showing properties
  • inspector/front-end/utilities.js: (Object.sortedProperties): allow for an optional sorting function in Object.sortedProperties
02:22 Changeset [46390] by pfeldman@chromium.org
  • 22 edits
    3 moves
    2 adds in trunk/WebCore

2009-07-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Split InspectorController into InspectorController
and InspectorBackend. Everything frontend needs from InspectorController
will slowly migrate into the InspectorBackend.

https://bugs.webkit.org/show_bug.cgi?id=27541

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSInspectorBackendCustom.cpp: Added. (WebCore::JSInspectorBackend::highlightDOMNode): (WebCore::JSInspectorBackend::search): (WebCore::JSInspectorBackend::databaseTableNames): (WebCore::JSInspectorBackend::inspectedWindow): (WebCore::JSInspectorBackend::setting): (WebCore::JSInspectorBackend::setSetting): (WebCore::JSInspectorBackend::wrapCallback): (WebCore::JSInspectorBackend::currentCallFrame): (WebCore::JSInspectorBackend::profiles):
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/js/JSInspectorControllerCustom.cpp: Removed.
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/js/ScriptObject.h:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/v8/ScriptObject.h:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8InspectorControllerCustom.cpp: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::windowScriptObjectAvailable):
  • inspector/InspectorController.h: (WebCore::InspectorController::inspectorBackend):
  • inspector/InspectorBackend.cpp: Added.
  • inspector/InspectorBackend.h: Added. (WebCore::InspectorBackend::create): (WebCore::InspectorBackend::inspectorController):
  • inspector/InspectorBackend.idl: Added.
  • inspector/InspectorController.idl: Removed.
  • inspector/front-end/Resource.js:
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h:
00:47 Changeset [46389] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-25 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by George Staikos.

Update WebCore/page/Frame.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27654

  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::setDocument): (WebCore::Frame::firstRectForRange): (WebCore::createRegExpForLabels): (WebCore::Frame::searchForLabelsBeforeElement): (WebCore::Frame::matchLabelsAgainstElement): (WebCore::Frame::selectionLayoutChanged): (WebCore::Frame::setZoomFactor): (WebCore::Frame::reapplyStyles): (WebCore::Frame::isContentEditable): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::selectionStartStylePropertyValue): (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::applyEditingStyleToBodyElement): (WebCore::Frame::removeEditingStyleFromBodyElement): (WebCore::Frame::applyEditingStyleToElement): (WebCore::Frame::selectionBounds): (WebCore::Frame::currentForm): (WebCore::Frame::revealSelection): (WebCore::Frame::styleForSelectionStart): (WebCore::Frame::setSelectionFromNone): (WebCore::Frame::findString): (WebCore::Frame::markAllMatchesForText): (WebCore::Frame::setMarkedTextMatchesAreHighlighted): (WebCore::Frame::clearFormerDOMWindow): (WebCore::Frame::unfocusWindow): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::documentAtPoint):
  • page/Frame.h: (WebCore::Frame::create): (WebCore::Frame::displayStringModifiedByEncoding): (WebCore::Frame::pageZoomFactor): (WebCore::Frame::textZoomFactor):

07/24/09:

20:50 Changeset [46388] by mitz@apple.com
  • 21 edits in trunk/WebCore

Reviewed by Darin Adler.

Add functions to print the glyph page trees for debugging
https://bugs.webkit.org/show_bug.cgi?id=27671

  • platform/graphics/FontData.h: Defined a description() method.
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::showSubtree): Added. Prints the node and

its descendants.

(showGlyphPageTrees): Added. Prints all glyph page trees.
(showGlyphPageTree): Added. Prints the glyph page tree for a given page.

  • platform/graphics/GlyphPageTreeNode.h:
  • platform/graphics/SegmentedFontData.cpp: (WebCore::SegmentedFontData::description): Added.
  • platform/graphics/SegmentedFontData.h:
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::description): Added. Uses the platform data

as the description for non-svg, non-custom fonts.

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/gtk/FontPlatformData.h:
  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/mac/FontPlatformData.h:
  • platform/graphics/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::description): Added. Returns the

description of the CGFont, the size and the synthetic style flags,
if set.

  • platform/graphics/qt/FontPlatformData.h:
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/win/FontPlatformData.h:
  • platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/wince/FontPlatformData.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/wince/FontPlatformData.h:
  • platform/graphics/wx/FontPlatformData.h:
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
18:49 Changeset [46387] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

In preparation for https://bugs.webkit.org/show_bug.cgi?id=27236:
Remove TCMALLOC_TRACK_DECOMMITED_SPANS. We'll always track decommitted spans.
We have tested this and show it has little impact on performance.

Reviewed by Mark Rowe.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::New): (WTF::TCMalloc_PageHeap::AllocLarge): (WTF::propagateDecommittedState): (WTF::mergeDecommittedStates): (WTF::TCMalloc_PageHeap::Delete): (WTF::TCMalloc_PageHeap::IncrementalScavenge):
18:13 Changeset [46386] by zimmermann@webkit.org
  • 2 edits in trunk/WebKitTools

Not reviewed. Add Kevin McCullough as reviewer in bugzilla.py

17:57 Changeset [46385] by darin@apple.com
  • 1 edit in trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm

Dorument?

17:56 Changeset [46384] by darin@apple.com
  • 3 edits in trunk/WebKit/mac

2009-07-24 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

REGRESSION (r46298): Exception after clicking on Bookmarks button in the Bookmarks Bar
https://bugs.webkit.org/show_bug.cgi?id=27667

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Moved the code to set the title here. This is late enough that both the view and representation exist.
  • WebView/WebDataSource.mm: (-[WebDataSource _makeRepresentation]): Removed the code to set the title from here. It's a bit too early.
16:46 Changeset [46383] by abarth@webkit.org
  • 23 edits in trunk/WebCore

2009-07-24 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

SVG and XPath memory leaks in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=27488

Add proper 'create' methods to SVGPodTypeWrappers and
XPathNSResolvers in the V8 bindings to avoid memory leaks.

Introduce convertToV8Object methods that accept PassRefPtrs and
clean up the use of get() and release() on RefPtrs.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object):
  • bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::V8SVGPODTypeWrapperCreatorForList::create): (WebCore::V8SVGPODTypeWrapperCreatorForList::V8SVGPODTypeWrapperCreatorForList): (WebCore::V8SVGStaticPODTypeWrapper::create): (WebCore::V8SVGStaticPODTypeWrapper::V8SVGStaticPODTypeWrapper): (WebCore::V8SVGStaticPODTypeWrapperWithPODTypeParent::create): (WebCore::V8SVGStaticPODTypeWrapperWithPODTypeParent::V8SVGStaticPODTypeWrapperWithPODTypeParent): (WebCore::V8SVGStaticPODTypeWrapperWithParent::create): (WebCore::V8SVGStaticPODTypeWrapperWithParent::V8SVGStaticPODTypeWrapperWithParent): (WebCore::V8SVGDynamicPODTypeWrapper::create): (WebCore::V8SVGDynamicPODTypeWrapper::V8SVGDynamicPODTypeWrapper): (WebCore::V8SVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ClientRectListCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER):
  • bindings/v8/custom/V8CustomXPathNSResolver.cpp: (WebCore::V8CustomXPathNSResolver::create):
  • bindings/v8/custom/V8CustomXPathNSResolver.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER):
  • bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
16:35 Changeset [46382] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip a test that is failing intermittently on the Windows build bot.

  • platform/win/Skipped:
16:26 Changeset [46381] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip a plug-in test that fails an assertion around 50% of the time.

  • platform/mac-snowleopard/Skipped:
16:02 Changeset [46380] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip two SVG tests that are giving unexpected results.

  • platform/mac-snowleopard/Skipped:
15:45 UsingGitWithWebKit edited by treat@kde.org
(diff)
15:45 Changeset [46379] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip two plug-in tests that are failing.

  • platform/mac-snowleopard/Skipped:
15:31 BuildingQtOnWindows edited by jpetso@gmx.at
Fix inconsistent instruction vs. corresponding explanation (paths were … (diff)
15:28 BuildingQtOnWindows edited by jpetso@gmx.at
I followed the guidelines here, and it seems make isn't shipped by Qt so … (diff)
15:20 Changeset [46378] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Land correct results for a SnowLeopard-only accessibility test.

  • platform/mac/accessibility/table-multi-bodies-expected.txt:
14:57 Changeset [46377] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

2009-07-24 Brian Weinstein <bweinstein@apple.com>

Reviewed by Jon Honeycutt.

Fix of <rdar://6310538> Middle-click panning should be springloaded while dragging
https://bugs.webkit.org/show_bug.cgi?id=21794

Create two new booleans to determine whether we have done a springloaded pan scroll, and update
the name of setPanScrollCursor to updatePanScrollState to more accurately describe what the function
does.

  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): Initialized two new booleans. (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::updatePanScrollState): Renamed from setPanScrollCursor. (WebCore::EventHandler::stopAutoscrollTimer): Clear the pan scrolling in progress flag. (WebCore::EventHandler::handleMouseReleaseEvent): Clear the pan scrolling button pressed flag.
  • page/EventHandler.h:
14:33 UsingGitWithWebKit edited by eli.fidler@torchmobile.com
(diff)
14:31 Changeset [46376] by dimich@chromium.org
  • 3 edits in trunk/WebCore

2009-07-24 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Changed WorkerContext destructor to not access possibly-freed WorkerThread.

Failed assertion in WorkerContext::~WorkerContext().
https://bugs.webkit.org/show_bug.cgi?id=27665

  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext):
    • workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Removed assertion that relies on WorkerThread still being alive (moved to DedicatedWorkerContext destructor).
14:18 Changeset [46375] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-24 Eli Fidler <eli.fidler@torchmobile.com>

Reviewed by Adam Treat.

Improve git workflow by populating commit messages with ChangeLog entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

If the user doesn't manually modify the ChangeLog files, use
prepare-ChangeLog to populate the git commit message. This behaviour
can be disabled by the 'webkitGenerateCommitMessage' git configuration option.

  • Scripts/commit-log-editor:
14:13 Changeset [46374] by treat@webkit.org
  • 1 edit
    11 adds in trunk/WebCore

2009-07-24 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=27657
Add more wince port files to WebCore

Written by Yong Li <yong.li@torchmobile.com> and Lyon Chen <lyon.chen@torchmobile.com>

  • loader/icon/wince/IconDatabaseWince.cpp: Added.
  • rendering/RenderThemeWince.cpp: Added.
  • rendering/RenderThemeWince.h: Added.
  • storage/wince/DatabaseThreadWince.cpp: Added.
  • storage/wince/DatabaseThreadWince.h: Added.
  • storage/wince/LocalStorageThreadWince.cpp: Added.
  • storage/wince/LocalStorageThreadWince.h: Added.
  • svg/graphics/wince/SVGResourceFilterWince.cpp: Added.
14:12 Changeset [46373] by rniwa@webkit.org
  • 3 edits
    4 adds in trunk

WebCore:

2009-07-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

execCommand('underline') can modify DOM outside of the contentEditable area
https://bugs.webkit.org/show_bug.cgi?id=24333

highestAncestorWithTextDecoration stops at the closest unsplittable element so that if text-decoration is applied
outside of it, we don't accidently modify the style attribute.

Tests: editing/style/textdecoration-outside-of-rooteditable.html

editing/style/textdecoration-outside-of-unsplittable-element.html

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): (WebCore::highestAncestorWithTextDecoration):

LayoutTests:

2009-07-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

execCommand('underline') can modify DOM outside of the contentEditable area
https://bugs.webkit.org/show_bug.cgi?id=24333

Tests to make sure we are not removing underline applied outside of root editable node or unsplittable element.

  • editing/style/textdecoration-outside-of-rooteditable-expected.txt: Added.
  • editing/style/textdecoration-outside-of-rooteditable.html: Added.
  • editing/style/textdecoration-outside-of-unsplittable-element-expected.txt: Added.
  • editing/style/textdecoration-outside-of-unsplittable-element.html: Added.
13:59 Changeset [46372] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2009-07-24 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27639

Tests that XSSAuditor does not prevent evaluation of scripts that only contain
non-canonical characters.

  • http/tests/security/xssAuditor/script-tag-safe-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-safe.html: Added.

2009-07-24 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27639

Fixes false positives when evaluating certain strings that only contain
non-canonical characters.

Test: http/tests/security/xssAuditor/script-tag-safe.html

  • page/XSSAuditor.cpp: (WebCore::isNonCanonicalCharacter): (WebCore::XSSAuditor::findInRequest):
12:54 Changeset [46371] by dimich@chromium.org
  • 5 edits
    3 adds in trunk

WebCore:

2009-07-24 Drew Wilson <atwilson@google.com>

Reviewed by Adam Barth.

Updated code generator to properly generate bindings for WorkerContext exposed functions.

Storing a reference to WorkerContext.postMessage() and calling it later yields a TypeError
https://bugs.webkit.org/show_bug.cgi?id=27419

Test: fast/workers/worker-call.html

  • bindings/js/JSWorkerContextBase.cpp: (WebCore::toJSDedicatedWorkerContext): (WebCore::toJSWorkerContext): Functions that convert from JSValue to the appropriate WorkerContext/DedicatedWorkerContext object.
  • bindings/js/JSWorkerContextBase.h: Added toJS*WorkerContext APIs.
  • bindings/scripts/CodeGeneratorJS.pm: Added code to appropriately check the passed-in this object when invoking functions at global scope.

LayoutTests:

2009-07-24 Drew Wilson <atwilson@google.com>

Reviewed by Adam Barth.

Added layout tests to exercise various use cases for calling functions defined on Worker global scope.

Storing a reference to WorkerContext.postMessage() and calling it later yields a TypeError
https://bugs.webkit.org/show_bug.cgi?id=27419

  • fast/workers/resources/worker-call.js: Added.
  • fast/workers/worker-call-expected.txt: Added.
  • fast/workers/worker-call.html: Added.
12:28 Changeset [46370] by eric@webkit.org
  • 9 edits in trunk/WebCore

2009-07-24 Drew Wilson <atwilson@google.com>

Reviewed by Adam Barth.

Refactor WorkerContext to move DedicatedWorker-specific APIs into DedicatedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27420

No new tests as the existing tests already provide sufficient coverage (this is just a refactoring with no new functionality).

  • DerivedSources.cpp: Added JSDerivedWorkerContext.cpp
  • DerivedSources.make: Added DerivedWorkerContext files
  • GNUmakefile.am: Added DerivedWorkerContext files
  • WebCore.gypi: Added DerivedWorkerContext files
  • WebCore.pro: Added DerivedWorkerContext files
  • WebCore.vcproj/WebCore.vcproj: Added DerivedWorkerContext files
  • WebCore.xcodeproj/project.pbxproj: Added DerivedWorkerContext files
  • bindings/js/JSDedicatedWorkerContextCustom.cpp: Added. (WebCore::JSDedicatedWorkerContext::mark): Custom mark function for onmessage event handler.
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): Supports conversion to JSDedicatedWorkerContext. (WebCore::toEventTarget):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark): Moved onmessage mark handling into DedicatedWorkerContext.
  • bindings/js/WorkerScriptController.cpp: Added appropriate casts to DedicatedWorkerContext for postMessage(). (WebCore::WorkerScriptController::initScript): Manually sets up the prototype chain for the worker context.
  • bindings/scripts/CodeGeneratorJS.pm: Changed special case code for WorkerContext to be triggered by new IsWorkerContext attribute.
  • bindings/scripts/CodeGeneratorV8.pm: Changed hard-coded tests for WorkerContext to support DedicatedWorkerContext.
  • bindings/v8/DOMObjectsInclude.h: Added DedicatedWorkerContext.h
  • bindings/v8/DerivedSourcesAllInOne.cpp: Added V8DedicatedWorkerContext.cpp
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Added code to reserve extra fields for V8DedicatedWorkerContext.
  • bindings/v8/V8Index.cpp: Now includes V8DedicatedWorkerContext.h in addition to V8WorkerContext.h
  • bindings/v8/V8Index.h: Added DedicatedWorkerContext as a non-node wrapper type. Removed WORKERCONTEXT as a valid template type.
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Creates DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): Returns DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::retrieve): Refactored to deal with DedicatedWorkerContext.
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: Added. Moved onmessage code from V8WorkerContextCustom.cpp (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: Moved onmessage code to V8DedicatedWorkerContextCustom.cpp
  • dom/EventTarget.cpp: (WebCore::EventTarget::toDedicatedWorkerContext):
  • dom/EventTarget.h:
  • workers/DedicatedWorkerContext.cpp: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::reportException): (WebCore::DedicatedWorkerContext::postMessage): (WebCore::DedicatedWorkerContext::dispatchMessage):
  • workers/DedicatedWorkerContext.h: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::create): (WebCore::DedicatedWorkerContext::toDedicatedWorkerContext): (WebCore::DedicatedWorkerContext::setOnmessage): (WebCore::DedicatedWorkerContext::onmessage):
  • workers/DedicatedWorkerContext.idl: Added.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Moved code that notifies parent that worker is closing down into DedicatedWorkerContext.
  • workers/WorkerContext.h: (WebCore::WorkerContext::isClosing): Exposed closing flag as an API so derived classes can access it.
  • workers/WorkerContext.idl:
  • workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): Calls into DedicatedWorkerContext to handle message.
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Creates a DedicatedWorkerContext when the thread starts up.
12:23 Changeset [46369] by dimich@chromium.org
  • 28 edits
    5 adds in trunk/WebCore

2009-07-24 Drew Wilson <atwilson@google.com>

Reviewed by Adam Barth.

Refactor WorkerContext to move DedicatedWorker-specific APIs into DedicatedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27420

No new tests as the existing tests already provide sufficient coverage (this is just a refactoring with no new functionality).

  • DerivedSources.cpp: Added JSDerivedWorkerContext.cpp
  • DerivedSources.make: Added DerivedWorkerContext files
  • GNUmakefile.am: Added DerivedWorkerContext files
  • WebCore.gypi: Added DerivedWorkerContext files
  • WebCore.pro: Added DerivedWorkerContext files
  • WebCore.vcproj/WebCore.vcproj: Added DerivedWorkerContext files
  • WebCore.xcodeproj/project.pbxproj: Added DerivedWorkerContext files
  • bindings/js/JSDedicatedWorkerContextCustom.cpp: Added. (WebCore::JSDedicatedWorkerContext::mark): Custom mark function for onmessage event handler.
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): Supports conversion to JSDedicatedWorkerContext. (WebCore::toEventTarget):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark): Moved onmessage mark handling into DedicatedWorkerContext.
  • bindings/js/WorkerScriptController.cpp: Added appropriate casts to DedicatedWorkerContext for postMessage(). (WebCore::WorkerScriptController::initScript): Manually sets up the prototype chain for the worker context.
  • bindings/scripts/CodeGeneratorJS.pm: Changed special case code for WorkerContext to be triggered by new IsWorkerContext attribute.
  • bindings/scripts/CodeGeneratorV8.pm: Changed hard-coded tests for WorkerContext to support DedicatedWorkerContext.
  • bindings/v8/DOMObjectsInclude.h: Added DedicatedWorkerContext.h
  • bindings/v8/DerivedSourcesAllInOne.cpp: Added V8DedicatedWorkerContext.cpp
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Added code to reserve extra fields for V8DedicatedWorkerContext.
  • bindings/v8/V8Index.cpp: Now includes V8DedicatedWorkerContext.h in addition to V8WorkerContext.h
  • bindings/v8/V8Index.h: Added DedicatedWorkerContext as a non-node wrapper type. Removed WORKERCONTEXT as a valid template type.
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Creates DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): Returns DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::retrieve): Refactored to deal with DedicatedWorkerContext.
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: Added. Moved onmessage code from V8WorkerContextCustom.cpp (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: Moved onmessage code to V8DedicatedWorkerContextCustom.cpp
  • dom/EventTarget.cpp: (WebCore::EventTarget::toDedicatedWorkerContext):
  • dom/EventTarget.h:
  • workers/DedicatedWorkerContext.cpp: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::reportException): (WebCore::DedicatedWorkerContext::postMessage): (WebCore::DedicatedWorkerContext::dispatchMessage):
  • workers/DedicatedWorkerContext.h: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::create): (WebCore::DedicatedWorkerContext::toDedicatedWorkerContext): (WebCore::DedicatedWorkerContext::setOnmessage): (WebCore::DedicatedWorkerContext::onmessage):
  • workers/DedicatedWorkerContext.idl: Added.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Moved code that notifies parent that worker is closing down into DedicatedWorkerContext.
  • workers/WorkerContext.h: (WebCore::WorkerContext::isClosing): Exposed closing flag as an API so derived classes can access it.
  • workers/WorkerContext.idl:
  • workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): Calls into DedicatedWorkerContext to handle message.
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Creates a DedicatedWorkerContext when the thread starts up.
12:01 Changeset [46368] by eric@webkit.org
  • 10 edits in trunk

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix the last of the x-frame constructor calls to have the right prototype chains
https://bugs.webkit.org/show_bug.cgi?id=27645

I also had to add support for passing arguments to constructors
in order to test the Worker constructor.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/resources/constructed-objects-prototypes.js:

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix the last of the x-frame constructor calls to have the right prototype chains
https://bugs.webkit.org/show_bug.cgi?id=27645

Fix the last few constructors to use their stored globalObject pointer when
constructing objects instead of the lexicalGlobalObject().

  • bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
  • bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::construct):
  • bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
  • bindings/js/JSWebKitPointConstructor.cpp: (WebCore::constructWebKitPoint):
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
11:05 Changeset [46367] by kenneth@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-07-24 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Adam Treat.

As per discussion on IRC, changed originalUrl by requestedUrl.

  • Api/qwebframe.cpp: (QWebFrame::requestedUrl):
  • Api/qwebframe.h:
  • tests/qwebframe/tst_qwebframe.cpp:
10:57 Changeset [46366] by kenneth@webkit.org
  • 5 edits in trunk/WebKit/qt

2009-07-24 Andre Pedralho <andre.pedralho@openbossa.org>

Reviewed by Adam Treat.

Removed void QWebFrame::renderContents(...) and added the Q_PROPERTY
clipRenderToViewport to control whether QWebFrame::render would call
FrameView::paintContents rather than FrameView::paint and do not clip
the frame content to viewport.
https://bugs.webkit.org/show_bug.cgi?id=26352

  • Api/qwebframe.cpp: (QWebFramePrivate::renderPrivate): (QWebFrame::clipRenderToViewport): (QWebFrame::setClipRenderToViewport):
  • Api/qwebframe.h:
  • Api/qwebframe_p.h: (QWebFramePrivate::QWebFramePrivate):
  • tests/qwebframe/tst_qwebframe.cpp:
10:56 Changeset [46365] by jianli@chromium.org
  • 4 edits in trunk/WebCore

2009-07-24 Jian Li <jianli@chromium.org>

Reviewed by Adam Barth.

[V8] Cleanup exception handling in worker evaluation code.
https://bugs.webkit.org/show_bug.cgi?id=27282

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::evaluate):
  • bindings/v8/WorkerContextExecutionProxy.h: (WebCore::WorkerContextExecutionState::WorkerContextExecutionState):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): (WebCore::WorkerScriptController::setException):
10:55 Changeset [46364] by kenneth@webkit.org
  • 5 edits
    2 adds in trunk/WebKit/qt

2009-07-24 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

[QT] Implement originalUrl getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867

  • Api/qwebframe.cpp: (QWebFrame::originalUrl):
  • Api/qwebframe.h:
  • tests/qwebframe/qwebframe.qrc:
  • tests/qwebframe/test1.html: Added.
  • tests/qwebframe/test2.html: Added.
  • tests/qwebframe/tst_qwebframe.cpp:
10:44 Changeset [46363] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-24 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

Reverting r46157, since it may be causing problems with Chromium
reliability (see http://crbug.com/17569).

https://bugs.webkit.org/show_bug.cgi?id=27388

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
10:39 Changeset [46362] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

REGRESSION: inspector seems broken in ToT WebKit
https://bugs.webkit.org/show_bug.cgi?id=27646

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled):
10:34 Changeset [46361] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

Add the shadow style member to the ShadowData constructor and ==
operator

  • rendering/style/ShadowData.cpp: (WebCore::ShadowData::ShadowData): (WebCore::ShadowData::operator==):
10:30 Changeset [46360] by jianli@chromium.org
  • 6 edits in trunk/WebCore

2009-07-24 Jian Li <jianli@chromium.org>

Reviewed by Eric Seidel.

[V8] More V8 bindings changes to use ErrorEvent.
https://bugs.webkit.org/show_bug.cgi?id=27630

  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object):
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
10:26 EFLWebKit edited by tonikitoo@gmail.com
(diff)
09:53 Changeset [46359] by bfulgham@webkit.org
  • 6 edits in trunk

WebCore:

2009-07-24 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Dave Hyatt.

Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.

  • platform/graphics/win/SimpleFontDataWin.cpp: Conditionalize references to ApplicationServices.h and WebKitSystemInterface.h

WebKit/win:

2009-07-24 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Dave Hyatt.

Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.

  • DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
  • WebDownload.h: Conditionalize include of CFNetwork.h
  • WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h
09:28 Changeset [46358] by mitz@apple.com
  • 2 edits in trunk/WebCore

Another attempted build fix

  • bindings/js/JSAbstractWorkerCustom.cpp:
09:28 Changeset [46357] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-24 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

cpplint crash when there is a duplicate header followed by another header.
https://bugs.webkit.org/show_bug.cgi?id=27625

  • Scripts/modules/cpplint.py: Ensure that include_state.header_types is updated even there is a duplicate header, which resulted in some code rearrangement. Also, changed some if's in this function to return early. This avoids having nearly the whole function content being indented.
  • Scripts/modules/cpplint_unittest.py: Added a test which would have exposed the crash.
09:27 Changeset [46356] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::toJS):
08:37 Changeset [46355] by treat@webkit.org
  • 4 edits in trunk/WebKitTools

2009-07-24 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Filetype support changes for cpplint and check_webkit_style
https://bugs.webkit.org/show_bug.cgi?id=27653

Introduce .c support for check_webkit_style, and remove support for
.cc files in favor of .cpp.

  • Scripts/check-webkit-style:
  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
07:26 Changeset [46354] by xan@webkit.org
  • 2 edits in trunk

2009-07-24 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Remove unneeded commas from PKG_CHECK_MODULES.

  • configure.ac:
06:44 Changeset [46353] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Kenneth Rohde Christiansen <kenneth@webkit.org>

Build fix for 64 bit Linux.

int64_t is long on Linux 64 bit and not long long, thus
getFileSize with a int64_t out value fails to build.

Use a temporary to work around the problem.

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::spaceNeeded):
06:44 Changeset [46352] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-24 Kenneth Rohde Christiansen <kenneth@webkit.org>

Build fix for Qt.

Fix build issue introduced in 46344
([Bug 22700] ApplicationCache should have size limit)

Remove method only added to the Qt ChromeClient.

  • WebCoreSupport/ChromeClientQt.h:
05:55 Changeset [46351] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-24 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

ApplicationCache Layout test failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=27648

Add http/tests/appcache/max-size.html to the Skipped file for now.

  • platform/gtk/Skipped:
05:37 BuildingQtOnWindows edited by mails2jaffar@hotmail.com
(diff)
05:31 Changeset [46350] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-24 Priit Laes <plaes@plaes.org>

Reviewed by Xan Lopez.

[Gtk] Password is saved into gnome-keyring even if auth. fails
https://bugs.webkit.org/show_bug.cgi?id=27560

Check authentication result and save password only when authentication
succeeds.

  • webkit/webkitsoupauthdialog.c: (free_authData): (response_callback): (save_password_callback):
03:50 Changeset [46349] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-24 Eli Fidler <eli.fidler@torchmobile.com>

Reviewed by David Levin.

Improve git workflow by populating commit messages with ChangeLog entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

add --[no-]write prepare-ChangeLog options to bash completion

  • Scripts/webkit-tools-completion.sh:
03:03 Changeset [46348] by eric@webkit.org
  • 21 edits in trunk

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Update all CREATE_DOM_*_WRAPPER callers to pass globalObject
https://bugs.webkit.org/show_bug.cgi?id=27644

Make a bunch more tests pass. Still not all of them.
The rest will pass when the last bits of bug 27634 land.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Update all CREATE_DOM_*_WRAPPER callers to pass globalObject
https://bugs.webkit.org/show_bug.cgi?id=27644

This is another attempt at making the change for bug 27634 smaller.
I included the changes to make_names.pl as well as any file which
used CREATE_DOM_*_WRAPPER macros.

The changes to the construct* functions are what fix the cases in
fast/dom/constructed-objects-prototypes.html

The changes to passing globalObject through CREATE_* are what fix
fast/dom/prototype-inheritance-2.html

  • bindings/js/JSCDATASectionCustom.cpp: (WebCore::toJSNewlyCreated): pass globalObject.
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSDOMBinding.h: updated macros to pass globalObject.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttributeNode): use globalObject() for wrapping return value. (WebCore::JSElement::setAttributeNodeNS): use globalObject() for wrapping return value. (WebCore::toJSNewlyCreated): pass globalObject.
  • bindings/js/JSEventCustom.cpp: (WebCore::JSEvent::clipboardData): pass globalObject. (WebCore::toJS): pass globalObject.
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::getNamedItems): use globalObject() for wrapping returned collection items. (WebCore::callHTMLCollection): use globalObject() for wrapping returned collection items. (WebCore::JSHTMLCollection::item): use globalObject() for wrapping returned collection items. (WebCore::toJS): pass globalObject.
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapper): pass globalObject.
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSTextCustom.cpp: (WebCore::toJSNewlyCreated): pass globalObject.
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::constructWebKitCSSMatrix): use constructors globalObject when constructing
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): use constructors globalObject when constructing
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::constructXSLTProcessor): use constructors globalObject when constructing
  • dom/make_names.pl:

Pass globalObject through CREATE_* macros and various support functions.

02:50 Changeset [46347] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Darin Adler and Adam Barth.

Build fix for x86 platforms.
https://bugs.webkit.org/show_bug.cgi?id=27602

  • jit/JIT.cpp:
02:15 Changeset [46346] by eric@webkit.org
  • 31 edits in trunk

2009-07-24 Andrei Popescu <andreip@google.com>

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Adds a unit test that ensures that the mechanism that
enforces the maximum size of the application cache is
working correctly.

  • http/tests/appcache/max-size-expected.txt: Added.
  • http/tests/appcache/max-size.html: Added.
  • http/tests/appcache/resources/maxsize.manifest: Added.

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Update CodeGeneratorJS.pm to support passing JSDOMGlobalObject* to toJS calls
https://bugs.webkit.org/show_bug.cgi?id=27643

This is an attempt to make this change as small as possible.
I started by including all changes to CodeGeneratorJS.pm from bug 27634,
and then made the minimal amount of other changes needed to support that change.

Most toJS implementations ignore their passed JSDOMGlobalObject.
There are stub 2-argument toJS, toJSNewlyCreated implementations to help compiling.
All places where it is not clear what we should pass as the global object
(or where the global object is simply not available, like for some SVG bindings)
we pass deprecatedGlobalObjectForPrototype instead.

  • bindings/js/JSCDATASectionCustom.cpp: (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException): pass the wrong globalObject for now
  • bindings/js/JSDOMBinding.h:

Pass the wrong global object to the CREATE_ macros for now.
In the next change we'll come back and pass the correct one.
That will require changes to make_names.pl.

(WebCore::DOMObjectWithGlobalPointer::scriptExecutionContext):
(WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
(WebCore::DOMObjectWithGlobalPointer::~DOMObjectWithGlobalPointer):
(WebCore::createDOMObjectWrapper):
(WebCore::getDOMObjectWrapper):
(WebCore::createDOMNodeWrapper):
(WebCore::getDOMNodeWrapper):
(WebCore::toJS): added to convert 2 arg calls to 3 arg calls to limit the scope of this change.
(WebCore::toJSNewlyCreated):

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::toJS): DOMWindow always uses its own prototype chain.
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSEventTarget.h:
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapper): pass globalObject to toJS(Document*) to avoid recursion (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject* (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::toJS): pass globalObject along
  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::inverse): pass wrong globalObject for now. (WebCore::JSSVGMatrix::rotateFromVector): pass wrong globalObject for now.
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
  • bindings/js/JSSVGPathSegListCustom.cpp:

All of these methods need a globalObject, but most SVG binding don't have
space for one, so we just pass the lexicalGlobalObject for now.

(WebCore::JSSVGPathSegList::initialize):
(WebCore::JSSVGPathSegList::getItem):
(WebCore::JSSVGPathSegList::insertItemBefore):
(WebCore::JSSVGPathSegList::replaceItem):
(WebCore::JSSVGPathSegList::removeItem):
(WebCore::JSSVGPathSegList::appendItem):

  • bindings/js/JSSVGPointListCustom.cpp: (WebCore::finishGetter): pass wrong globalObject for now. (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult):
  • bindings/js/JSSVGTransformListCustom.cpp: (WebCore::finishGetter): pass wrong globalObject for now. (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSTextCustom.cpp: (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
  • bindings/js/JSWorkerContextBase.cpp: (WebCore::toJS): WorkerContext always uses its own prototype chain since it's a GlobalObject subclass.
  • bindings/js/JSWorkerContextBase.h:
  • bindings/scripts/CodeGeneratorJS.pm:

All generated toJS calls now pass a globalObject.
All generated toJS implementations now expect a globalObject.
Simplified all the slot casts by using a "castedThis" local.
SVG bindings which don't have a globalObject() accessor pass the deprecated lexicalGlobalObject instead.
Simplified printing of constructor objects using a $constructorClassName variable.
All generated constructor functions follow the construct$className form to match the custom constructors.

02:14 Changeset [46345] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

typing "document.proto" in inspector throws exception
https://bugs.webkit.org/show_bug.cgi?id=27169

  • inspector/front-end/utilities.js: (Object.type):
02:12 Changeset [46344] by abarth@webkit.org
  • 40 edits
    5 adds in trunk

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Adds the WebApplicationCache class that is
used by the DumpRenderTree test application to
configure the Application Cache maximum size.

  • WebCoreSupport/WebApplicationCache.h: Added.
  • WebCoreSupport/WebApplicationCache.mm: Added.
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebKit.exp:

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebCoreSupport/ChromeClientQt.h:

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::reachedMaxAppCacheSize): Adds empty implementation of reachedMaxAppCacheSize.
  • WebCoreSupport/ChromeClientGtk.h:

2009-07-24 Andrei Popescu <andreip@google.com>

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700


Updated the project after adding WebApplicationCache.h/mm

  • WebKit.xcodeproj/project.pbxproj:

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebCoreSupport/WebChromeClient.h:

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700


  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebKitSupport/ChromeClientWx.h:

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

https://lists.webkit.org/pipermail/webkit-dev/2009-May/007560.html

This change implements a mechanism for limiting the maximum size of
the application cache file. When this size is reached, a ChromeClient
callback is invoked asynchronously and the saving of the last (failed)
cache is retried automatically.


This change also extends the ApplicationCacheStorage API by allowing
a client to query or modify the application cache without having to
load any resources into memory.

Test: http/tests/appcache/max-size.html

  • WebCore.base.exp: Exports the symbols required by the DumpRenderTree test application.
  • loader/EmptyClients.h: Adds empty implementation of the new ChromeClient methods.
  • loader/appcache/ApplicationCache.cpp:
  • loader/appcache/ApplicationCache.h: Adds the ability to calculate the approximate size of an ApplicationCache object.
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheGroup.h: Invokes the ChromeClient callback when the storage layer runs out of space. After the callback is invoked, we re-attempt to store the newest cache, in case the ChromeClient has freed some space.
  • loader/appcache/ApplicationCacheResource.cpp:
  • loader/appcache/ApplicationCacheResource.h: Adds the ability to calculate the approximate size of an ApplicationCacheResource object.
  • loader/appcache/ApplicationCacheStorage.cpp:
  • loader/appcache/ApplicationCacheStorage.h: Enforces a maximum size for the application cache file.
  • page/ChromeClient.h: Adds a new callback, invoked when the ApplicationCacheStorage reports that it has reached the maximum size for its database file.
  • platform/sql/SQLiteDatabase.cpp:
  • platform/sql/SQLiteDatabase.h: Adds a new method that allows querying for the amount of unused space inside the application cache database file.

2009-07-24 Andrei Popescu <andreip@google.com>

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Adds a unit test that ensures that the mechanism that
enforces the maximum size of the application cache is
working correctly.

  • http/tests/appcache/max-size-expected.txt: Added.
  • http/tests/appcache/max-size.html: Added.
  • http/tests/appcache/resources/maxsize.manifest: Added.

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Adds a new method on the LayoutTestController that
allows a JS unit test to configure the maximum size
of the Application Cache.

  • DumpRenderTree/LayoutTestController.cpp: (setAppCacheMaximumSizeCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAppCacheMaximumSize):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAppCacheMaximumSize):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAppCacheMaximumSize):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAppCacheMaximumSize):
01:42 Changeset [46343] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Use TextEncoding facilities to convert between UTF16 and UTF8
instead of rolling our own solution.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (convertUniCharToUTF8):
01:42 Changeset [46342] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Fix confusion in g_substr between length in bytes and length in
characters. Was causing crashes in some situations when dealing
with non-ASCII text encoded as UTF8.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (g_substr):
01:39 Changeset [46341] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-24 Adam Barth <abarth@webkit.org>

Rubber stamped by Eric Seidel.

Added andersca to list of reviewers.

  • Scripts/modules/bugzilla.py:
01:33 Changeset [46340] by mrowe@apple.com
  • 26 edits
    1 add in trunk/WebKitTools

Fix dozens of "Deallocation of a pointer not malloced" messages seen while running layout tests on the build bot.

Reviewed by Xan Lopez.

Memory allocated via FastMalloc was being deleted via the system memory allocator
due to an inconsistent including of FastMalloc.h. We address this by including it
from config.h and including config.h from every implementation file, as in our other
projects.

  • DumpRenderTree/ForwardingHeaders/wtf/FastMalloc.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h.
  • DumpRenderTree/config.h:
  • DumpRenderTree/mac/AccessibilityControllerMac.mm:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  • DumpRenderTree/mac/AppleScriptController.m:
  • DumpRenderTree/mac/CheckedMalloc.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
  • DumpRenderTree/mac/DumpRenderTreePasteboard.m:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:
  • DumpRenderTree/mac/EditingDelegate.mm:
  • DumpRenderTree/mac/EventSendingController.mm:
  • DumpRenderTree/mac/FrameLoadDelegate.mm:
  • DumpRenderTree/mac/GCControllerMac.mm:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/mac/NavigationController.m:
  • DumpRenderTree/mac/ObjCController.m:
  • DumpRenderTree/mac/ObjCPlugin.m:
  • DumpRenderTree/mac/ObjCPluginFunction.m:
  • DumpRenderTree/mac/PixelDumpSupportMac.mm:
  • DumpRenderTree/mac/PlainTextController.mm:
  • DumpRenderTree/mac/PolicyDelegate.mm:
  • DumpRenderTree/mac/ResourceLoadDelegate.mm:
  • DumpRenderTree/mac/TextInputController.m:
  • DumpRenderTree/mac/UIDelegate.mm:
  • DumpRenderTree/mac/WorkQueueItemMac.mm:
01:33 Changeset [46339] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Impossible to add an attribute to a node without attributes
https://bugs.webkit.org/show_bug.cgi?id=21108

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.set hovered): (WebInspector.ElementsTreeElement.prototype.toggleNewButton): (WebInspector.ElementsTreeElement.prototype.ondblclick): (WebInspector.ElementsTreeElement.prototype._startEditing): (WebInspector.ElementsTreeElement.prototype._addNewAttribute): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
  • inspector/front-end/inspector.css:
01:31 Changeset [46338] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-24 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Adds support for Firebug's magic $0 variable to access inspected node
https://bugs.webkit.org/show_bug.cgi?id=17907

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled): Added _inspectorCommandLineAPI.{

_inspectedNodes, _addInspectedNode, $0, $1, $n}

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): Stores the inspected node history

in _inspectorCommandLineAPI._inspectedNodes

(WebInspector.ElementsPanel):

01:22 Changeset [46337] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Dragging a resource in the sidebar should drag it's URL
https://bugs.webkit.org/show_bug.cgi?id=14410

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
01:21 Changeset [46336] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Double click on a resource in the sidebar should open that resource in Safari
https://bugs.webkit.org/show_bug.cgi?id=14409

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick): open a resource url
01:05 Changeset [46335] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

Revert "2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>"

This reverts commit 6a8ef1983c1dbfaebc636ba70a046d28b12b4aab.

00:59 Changeset [46334] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Darin Adler.

Build fix for x86 platforms.
https://bugs.webkit.org/show_bug.cgi?id=27602

  • jit/JIT.cpp:
00:55 Changeset [46333] by jmalonzo@webkit.org
  • 6 edits in trunk

2009-07-24 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

Bump pango version requirement to 1.12 and remove unnecessary #ifdefs.

  • platform/graphics/gtk/FontGtk.cpp: (WebCore::getDefaultPangoLayout):
  • platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/gtk/Language.cpp:

Bump pango version requirement to 1.12 which is the version that
came with Gtk 2.10.

  • configure.ac:
00:52 Changeset [46332] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Missing UIString and other localizedString.js fixes
https://bugs.webkit.org/show_bug.cgi?id=27288

  • English.lproj/localizedStrings.js:
00:51 Changeset [46331] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Should Syntax Highlight JSON
https://bugs.webkit.org/show_bug.cgi?id=27503

  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded):
00:44 Changeset [46330] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/DOMTimer.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27624

  • page/DragController.cpp: (WebCore::DragController::~DragController): (WebCore::documentFragmentFromDragData): (WebCore::DragController::dragEnded): (WebCore::DragController::dragEntered): (WebCore::DragController::dragExited): (WebCore::DragController::dragUpdated): (WebCore::DragController::performDrag): (WebCore::asFileInput): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::delegateDragSourceAction): (WebCore::DragController::concludeEditDrag): (WebCore::DragController::canProcessDrag): (WebCore::DragController::tryDHTMLDrag): (WebCore::DragController::mayStartDragAtEventLocation): (WebCore::getCachedImage): (WebCore::getImage): (WebCore::prepareClipboardForImageDrag): (WebCore::dragLocForDHTMLDrag): (WebCore::DragController::startDrag): (WebCore::DragController::doImageDrag): (WebCore::DragController::doSystemDrag): (WebCore::DragController::placeDragCaret):
00:44 Changeset [46329] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/Chrome.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27608

  • page/Chrome.cpp: (WebCore::Chrome::runBeforeUnloadConfirmPanel): (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::Chrome::shouldInterruptJavaScript): (WebCore::Chrome::setToolTip): (WebCore::Chrome::requestGeolocationPermissionForFrame): (WebCore::ChromeClient::generateReplacementFile): (WebCore::ChromeClient::paintCustomScrollbar):
00:43 Changeset [46328] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/Coordinates.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27614

  • page/Coordinates.cpp: (WebCore::Coordinates::toString):
00:42 Changeset [46327] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/DOMSelection.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27614

  • page/DOMSelection.cpp: (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::modify): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::deleteFromDocument):
  • page/DOMSelection.h:
00:42 Changeset [46326] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

x-frame constructor calls are instantiated with the wrong prototype chain
https://bugs.webkit.org/show_bug.cgi?id=27566

Add the test. Soon to be fixed by bug 27634.

  • fast/dom/constructed-objects-prototypes-expected.txt: Added.
  • fast/dom/constructed-objects-prototypes.html: Added.
  • fast/dom/resources/constructed-objects-prototypes.js: Added. (classNameForObject): (constructorPropertiesOnWindow):
00:31 Changeset [46325] by mrowe@apple.com
  • 6 edits in trunk

Roll out r46321 as it broke the Windows build.

00:28 Changeset [46324] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/DOMTimer.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27618

  • page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::~DOMTimer): (WebCore::DOMTimer::fired): (WebCore::DOMTimer::suspend): (WebCore::DOMTimer::resume): (WebCore::DOMTimer::canSuspend):
  • page/DOMTimer.h: (WebCore::DOMTimer::minTimerInterval): (WebCore::DOMTimer::setMinTimerInterval):
00:15 Changeset [46323] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

Add a command line option to run-javascriptcore-tests to explicitly opt out of attempting to rebuild JavaScriptCore.

Reviewed by Simon Hausmann.

This is primarily useful to speed up the build bots where one machine builds JavaScriptCore and a second runs the tests,
leading to situations where the build system unnecessarily feels that the need to recompile.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/run-javascriptcore-tests:
00:14 Changeset [46322] by eric@webkit.org
  • 11 edits in trunk/WebCore

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Classes call DOMObject::mark() explicitly, should call DOMObjectWithGlobal::mark() instead
https://bugs.webkit.org/show_bug.cgi?id=27641

Nothing uses globalObject() yet, but this was causing crashes
in the patch for bug 27634. This is covered by fast/dom/gc-6.html.

I decided to change these to Base
instead of DOMObjectWithGlobal:: for future-proofing. All autogenerated classes use a typedef Base
to avoid bugs like these. Sadly C++ does not have a built-in super
we could use.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::JSAbstractWorker::mark):
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::mark):
  • bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::mark):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
  • bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::getOwnPropertySlot):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::mark):
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::mark):
  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::mark):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::mark):
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::mark):
00:04 Changeset [46321] by bfulgham@webkit.org
  • 6 edits in trunk

WebCore:

2009-07-23 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.

  • platform/graphics/win/SimpleFontDataWin.cpp: Conditionalize references to ApplicationServices.h and WebKitSystemInterface.h

WebKit/win:

2009-07-23 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.

  • DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
  • WebDownload.h: Conditionalize include of CFNetwork.h
  • WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h

07/23/09:

23:58 Changeset [46320] by eric@webkit.org
  • 17 edits in trunk

2009-07-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make most DOMObjects hold onto a JSDOMGlobalObject*
https://bugs.webkit.org/show_bug.cgi?id=27588

inner.document.constructor is fixed because all properties on the window
object are created with the correct globalObject (instead of the lexical one).
Since all objects now carry a globalObject pointer, when document creates
HTMLDocumentConstructor it now has the right globalObject to use.

  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:

2009-07-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make most DOMObjects hold onto a JSDOMGlobalObject*
https://bugs.webkit.org/show_bug.cgi?id=27588

This change is almost entirely plumbing. Only one functional
change as part of this all (window.document.constructor has the correct prototype)
Changes are detailed below.

inner.document.constructor is fixed because all properties on the window
object are created with the correct globalObject (instead of the lexical one).
Since all objects now carry a globalObject pointer, when document creates
HTMLDocumentConstructor it now has the right globalObject to use.

Tests:

fast/dom/prototype-inheritance.html
fast/dom/prototype-inheritance-2.html

  • bindings/js/DOMObjectWithSVGContext.h: (WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):

Update the comment and add an ignored globalObject argument.

  • bindings/js/JSDOMBinding.h:

Pass a globalObject to all DOMObjects during creation. Currently it's the wrong global object.
Once toJS is passed a globalObject it will be the right one.

(WebCore::createDOMObjectWrapper):
(WebCore::createDOMNodeWrapper):

  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::globalObject): Makes binding generation easier.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::history): JSHistory is now passed a globalObject, but since it has no custom constructor it doesn't use it. (WebCore::JSDOMWindow::location): JSLocation is now passed a globalObject, but since it has no custom constructor it doesn't use it.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): JSLocation is now passed a globalObject, but since it has no custom constructor it doesn't use it.
  • bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
  • bindings/js/JSHTMLCollectionCustom.cpp: Re-factoring needed to pass globalObject to JSNamedNodesCollection constructor. (WebCore::getNamedItems): (WebCore::callHTMLCollection): (WebCore::JSHTMLCollection::canGetItemsForName): (WebCore::JSHTMLCollection::nameGetter): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem):
  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
  • bindings/js/JSNamedNodesCollection.cpp:

Now passed globalObject. This is tested by inner.document.forms.testForm.
The passed globalObject is still wrong until toJS is fixed.

(WebCore::JSNamedNodesCollection::JSNamedNodesCollection):

  • bindings/js/JSNamedNodesCollection.h:
  • bindings/js/JSSharedWorkerConstructor.cpp:

Add DOMConstructorObject missed by http://trac.webkit.org/changeset/45938
This class is not compiled by default, so not testable.

(WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor):

  • bindings/js/JSSharedWorkerConstructor.h:
  • bindings/scripts/CodeGeneratorJS.pm:

Make all bindings objects carry a globalObject pointer using DOMObjectWithGlobalPointer.
SVG bindings which need a context() pointer do not have enough space for globalObject() too.
WorkerContext does not need a globalObject (it is one), so special case it.
Make all .constructor calls use the stored globalObject(). This is what fixes window.document.constructor.
Make all constructors inherit from DOMConstructorObject for consistency. Since the auto-bound constructors
override createStructure anyway, there is no functional change here. Just completing work started in r45938.

23:50 Changeset [46319] by jmalonzo@webkit.org
  • 8 edits in trunk

2009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Eric Seidel.

[Gtk] Add implementation of GCController for DRT
https://bugs.webkit.org/show_bug.cgi?id=27636

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): (main):
  • DumpRenderTree/gtk/GCControllerGtk.cpp: (GCController::collect): (GCController::collectOnAlternateThread):

Enable tests that are now passing.

  • platform/gtk/Skipped:

Add SPI for GCController to use.

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_gc_collect_javascript_objects): (webkit_gc_collect_javascript_objects_on_alternate_thread): (webkit_gc_count_javascript_objects):
23:37 Changeset [46318] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-07-23 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Add new test to cover more prototype/constructor inheritance cases
https://bugs.webkit.org/show_bug.cgi?id=27622

This new test tries hard not to duplicate testing done
by other tests and instead test new objects and prototype chains
which will be fixed as soon as toJS is passed through the globalObject.

This test crawls the object tree under the inner window, finding
one of each type of JavaScript object. It depends on all objects having
a valid prototype chain with a unique name (which is not always the case).
The test tries to stress the cases where the objects would be lazily
creating other objects or their prototypes or constructors which would
require these objects to have a back-pointer to the globalObject to be
able to correctly wire up the prototype chains.

  • fast/dom/prototype-inheritance-2-expected.txt: Added.
  • fast/dom/prototype-inheritance-2.html: Added.
  • fast/dom/resources/prototype-inheritance-2.js: Added. (propertiesOnObject): (): (constructorNamesForWindow): (makeCrawlObject): (evalToCrawlObject): (pushPropertyValuesWithUnseenTypes): (crawl):
23:03 Changeset [46317] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Skip transitions/change-values-during-transition.html which
pass/fails intermittently

  • platform/gtk/Skipped:
22:49 Changeset [46316] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Skip tests that require expected outputs. Also skip failing tests,
with bugs raised against the failures.

  • platform/gtk/Skipped:
22:26 Changeset [46315] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip two new tests for GTK that use eventSender.

  • platform/gtk/Skipped:
22:10 Changeset [46314] by mrowe@apple.com
  • 39 edits in trunk/LayoutTests

Fix layout tests that incorrectly attempt to detect whether they're running inside DumpRenderTree using "if (layoutTestController)".

Rubber-stamped by Brady Eidson.

  • editing/execCommand/25256.html:
  • editing/execCommand/25320.html:
  • fast/canvas/arc-crash.html:
  • fast/css/emptyStyleTag.html:
  • fast/events/js-keyboard-event-creation.html:
  • fast/events/scrollbar-double-click.html:
  • fast/forms/select-no-name.html:
  • fast/history/window-open.html:
  • platform/mac/fast/events/objc-event-api.html:
  • platform/mac/fast/events/objc-keyboard-event-creation.html:
  • scrollbars/scrollbar-miss-mousemove-disabled.html:
  • scrollbars/scrollbar-miss-mousemove.html:
  • storage/domstorage/localstorage/clear.html:
  • storage/domstorage/localstorage/delete-removal.html:
  • storage/domstorage/localstorage/enumerate-storage.html:
  • storage/domstorage/localstorage/index-get-and-set.html:
  • storage/domstorage/localstorage/onstorage-attribute-markup.html:
  • storage/domstorage/localstorage/onstorage-attribute-setattribute.html:
  • storage/domstorage/localstorage/private-browsing-affects-storage.html:
  • storage/domstorage/localstorage/resources/window-open-second.html:
  • storage/domstorage/localstorage/simple-events.html:
  • storage/domstorage/localstorage/simple-usage.html:
  • storage/domstorage/localstorage/string-conversion.html:
  • storage/domstorage/localstorage/window-open.html:
  • storage/domstorage/sessionstorage/clear.html:
  • storage/domstorage/sessionstorage/delete-removal.html:
  • storage/domstorage/sessionstorage/enumerate-storage.html:
  • storage/domstorage/sessionstorage/index-get-and-set.html:
  • storage/domstorage/sessionstorage/onstorage-attribute-markup.html:
  • storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html:
  • storage/domstorage/sessionstorage/private-browsing-affects-storage.html:
  • storage/domstorage/sessionstorage/resources/window-open-second.html:
  • storage/domstorage/sessionstorage/simple-events.html:
  • storage/domstorage/sessionstorage/simple-usage.html:
  • storage/domstorage/sessionstorage/string-conversion.html:
  • storage/domstorage/sessionstorage/window-open.html:
  • storage/domstorage/window-attributes-exist.html:
  • svg/custom/stop-crash.svg:
21:59 Changeset [46313] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

And now with some valid JavaScript syntax!

  • http/tests/misc/redirect-to-about-blank.html:
21:51 Changeset [46312] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Remove unnecessary check for eventSender in an attempt to please the GTK build bot.

  • fast/css/getComputedStyle/getComputedStyle-text-overflow.html:
21:35 Changeset [46311] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Update build.webkit.org config for new machine.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
21:32 Changeset [46310] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Add a workaround for <rdar://problem/6925892> to the test that it affects.

Reviewed by Brady Eidson.

  • http/tests/misc/redirect-to-about-blank.html:
20:56 Changeset [46309] by beidson@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-23 Brady Eidson <beidson@apple.com>

Remove accidentally checked in code.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (waitUntilDoneWatchdogFired): (LayoutTestController::setWaitToDump):
20:00 Changeset [46308] by beidson@apple.com
  • 14 edits
    3 adds in trunk

WebCore:

2009-07-23 Brady Eidson <beidson@apple.com>

Reviewed by Geoff Garen.

WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=27595

Test: http/tests/misc/will-send-request-returns-null-on-redirect.html


  • inspector/InspectorController.cpp: (WebCore::InspectorController::removeResource): Null-check the request URL.


  • platform/network/cf/ResourceHandleCFNet.cpp: Ditto, and return null instead of creating an empty one. (WebCore::willSendRequest):

WebKit/win:

2009-07-23 Brady Eidson <beidson@apple.com>

Reviewed by Geoff Garen.

WebFrameLoaderClient on Windows doesn't gracefully handle a null request returned from willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=27595

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchWillSendRequest):

WebKitTools:

2009-07-23 Brady Eidson <beidson@apple.com>

Reviewed by Geoff Garen.

WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=27595

Add the ability to tell the LayoutTestController to return a null request for willSendRequest
redirect callbacks.


  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (setWillSendRequestReturnsNullOnRedirectCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::willSendRequestReturnsNullOnRedirect): (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::willSendRequest):

LayoutTests:

2009-07-23 Brady Eidson <beidson@apple.com>

Reviewed by Geoff Garen.

WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=27595

  • http/tests/misc/resources/redirect-to-http-url.php: Added.
  • http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
  • http/tests/misc/will-send-request-returns-null-on-redirect.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
19:54 Changeset [46307] by pdherbemont@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

2009-07-23 Pierre d'Herbemont <pdherbemont@apple.com>

Fix layout tests, no review.

Actually add the video-layer tests results for leopard, that were
forgotten in r46302. Also add test results for windows.

  • platform/mac-leopard/fast/layers/video-layer-expected.png: Added.
  • platform/mac-leopard/fast/layers/video-layer-expected.txt: Added.
  • platform/win/fast/layers/video-layer-expected.txt: Added.
19:38 Changeset [46306] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

19:38 Changeset [46305] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.8

New tag.

19:14 Changeset [46304] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix DumpRenderTree to not fail an assertion on launch on a new machine.

Reviewed Oliver Hunt.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(setDefaultsToConsistentValuesForTesting): Disable the XSS auditor. It being enabled
breaks all of the JavaScript tests within testStringByEvaluatingJavaScriptFromString,
which causes us to exit due to an assertion failure. It's not clear why the XSS auditor
decides to interfere with these tests.

18:40 Changeset [46303] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r46246.

17:55 Changeset [46302] by pdherbemont@apple.com
  • 4 edits
    1 copy
    1 add in trunk/LayoutTests

2009-07-23 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Following changes on the video controls, video-layer tests results need to
be updated in order to fix the layout tests.

  • platform/mac-leopard/fast/layers/video-layer-expected.checksum: Copied from LayoutTests/platform/mac/fast/layers/video-layer-expected.checksum.
  • platform/mac-leopard/fast/layers/video-layer-expected.png: Copied from LayoutTests/platform/mac/fast/layers/video-layer-expected.png.
  • platform/mac-leopard/fast/layers/video-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/layers/video-layer-expected.txt.
  • platform/mac/fast/layers/video-layer-expected.checksum: Removed.
  • platform/mac/fast/layers/video-layer-expected.png: Removed.
  • platform/mac/fast/layers/video-layer-expected.txt: Updated.
17:35 Changeset [46301] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

Bug 27633 - AXLoadComplete can be fired off to frequently
https://bugs.webkit.org/show_bug.cgi?id=27633

17:11 Changeset [46300] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-07-23 Darin Adler <darin@apple.com>

  • WebView/WebDataSource.mm: (-[WebDataSource _makeRepresentation]): Landed a comment I forgot last time.
17:09 Changeset [46299] by mrowe@apple.com
  • 3 edits
    1 copy
    1 move in trunk/LayoutTests

Update layout test results for three tests related to text fields as their metrics
have changed slightly since the results were last updated.

Rubber-stamped by Dan Bernstein.

  • platform/mac-leopard/fast/forms/text-control-intrinsic-widths-expected.txt: Copied from LayoutTests/fast/forms/text-control-intrinsic-widths-expected.txt.
  • platform/mac/fast/forms/input-text-maxlength-expected.txt:
  • platform/mac/fast/forms/input-text-paste-maxlength-expected.txt:
  • platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt: Renamed from LayoutTests/fast/forms/text-control-intrinsic-widths-expected.txt.
17:09 Changeset [46298] by darin@apple.com
  • 5 edits in trunk

WebCore:

2009-07-23 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

URL appears in back/forward button menu instead of title for items with custom representation
https://bugs.webkit.org/show_bug.cgi?id=27586
rdar://problem/5060337

  • WebCore.base.exp: Exported DocumentLoader::setTitle for use by Mac WebKit.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didChangeTitle): Tightened code to check if the document loader is the correct one; previously this would never happen because we'd commit the load before any title changes could be registered, but now we can encounter a case where we get a title during a provisional load.

WebKit/mac:

2009-07-23 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

URL appears in back/forward button menu instead of title for items with custom representation
https://bugs.webkit.org/show_bug.cgi?id=27586
rdar://problem/5060337

The problem is that DocumentLoader expects to store a title, but for custom representations
it is never passed to the document loader.

  • WebView/WebDataSource.mm: (-[WebDataSource _makeRepresentation]): Added a call to DocumentLoader::setTitle. Works as long as the title does not change during the document's lifetime, which is good enough for the simple cases in Safari.
16:44 Changeset [46297] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Update default state of the XSS auditor in GTK DumpRenderTree to match Mac and Windows
in hopes of fixing some layout test failures seen on the build bot.

Reviewed by Oliver Hunt.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

16:08 Changeset [46296] by mrowe@apple.com
  • 1 edit
    2 copies in trunk/LayoutTests

Windows appears to match the Leopard results for the CSS 2.1 counter tests that were failing.

  • platform/win/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt.
  • platform/win/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt.
16:00 Changeset [46295] by mitz@apple.com
  • 17 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

[CSS3 Backgrounds and Borders] Add support for inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=27582

Test: fast/box-shadow/inset.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): Set the ShadowValue’s shadow style to 'inset'

as needed.

  • css/CSSParser.cpp: (WebCore::ShadowParseContext::ShadowParseContext): Added style and allowStyle

members. Initialize the allowStyle member.

(WebCore::ShadowParseContext::commitValue): Pass the style value to the

ShadowValue constructor. Reset allowStyle.

(WebCore::ShadowParseContext::commitLength): Update allowStyle.
(WebCore::ShadowParseContext::commitColor): Ditto.
(WebCore::ShadowParseContext::commitStyle): Added. Sets the style member and

updates the state.

(WebCore::CSSParser::parseShadow): Parse the 'inset' keyword.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Get the style value from the

shadow value and pass it to the ShadowData constructor.

  • css/ShadowValue.cpp: (WebCore::ShadowValue::ShadowValue): Added style. (WebCore::ShadowValue::cssText): Added style.
  • css/ShadowValue.h: (WebCore::ShadowValue::create): Added style.
  • page/animation/AnimationBase.cpp: (WebCore::blendFunc): Added a blend function for shadow styles. When blending

between normal and inset shadows, all intermediate values map to normal.

(WebCore::PropertyWrapperShadow::blend): Added normal style to the default

shadow.


  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBoxShadow): Added a shadow style parameter,

which is passed through to RenderBoxModelObject::paintBoxShadow().

(WebCore::InlineFlowBox::paintBoxDecorations): Paint inset shadows on top of

the background.

  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations): Paint inset shadows on top of the

background.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Added a shadow style

parameter, and code to paint inset shadows.

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): Paint inset shadows on top of

the background.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations): Ditto.
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations): Ditto.
  • rendering/style/ShadowData.h: Added a ShadowStyle enum. (WebCore::ShadowData::ShadowData): Add and initialize a style member.

LayoutTests:

Reviewed by Dave Hyatt.

[CSS3 Backgrounds and Borders] Add support for inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=27582

  • fast/box-shadow/inset.html: Added.
  • platform/mac/fast/box-shadow/inset-expected.checksum: Added.
  • platform/mac/fast/box-shadow/inset-expected.png: Added.
  • platform/mac/fast/box-shadow/inset-expected.txt: Added.
15:53 Changeset [46294] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Fix false positives for switch statement indentation check in cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27615

Makes one-line case statements (e.g. "case foo: bar();") work.
Also a few general improvements to the robustness and readability of
the check, and more test cases.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
15:52 Changeset [46293] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-07-23 Simon Fraser <simon.fraser@apple.com>

Fix the build with UNUSED_PARAM(frame) for when ENABLE(3D_RENDERING) is not defined.

  • css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval):
15:49 Changeset [46292] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Add check for line-breaking rule #3 to cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27610

"An else if statement should be written as an if statement when
the prior if concludes with a return statement."

Implemented by a multi-line (kind of back-tracking) algorithm.
Comes with loads of unit tests. Fixes the check for label indentation
to be not so overzealous, as it didn't allow for completely unindented
goto labels (at the very start of a line).

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
15:37 Changeset [46291] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-07-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adele Peterson.

3d-transforms media query needs to look check that accelerated compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=27621

When evaluating a media query with '-webkit-transform-3d', we need to check the
runtime switch that toggles accererated compositing, and therefore 3D.

No test because we can't disable the pref dynamically in DRT.

  • css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval):
15:31 Changeset [46290] by mrowe@apple.com
  • 3 edits
    1 copy
    2 moves in trunk/LayoutTests

Update layout test results for two international text tests that are failing due to font differences.

Rubber-stamped by Dan Bernstein.

  • platform/mac-leopard/fast/text/international/thai-baht-space-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.checksum.
  • platform/mac-leopard/fast/text/international/thai-baht-space-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.png.
  • platform/mac-leopard/fast/text/international/thai-baht-space-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.txt.
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
  • platform/mac/fast/text/international/thai-baht-space-expected.txt:
15:13 Changeset [46289] by mrowe@apple.com
  • 3 edits
    2 copies in trunk/LayoutTests

Update layout test results for two CSS 2.1 counter tests that are failing due to font differences.

Rubber-stamped by Dan Bernstein.

  • platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.txt.
  • platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.txt.
  • platform/mac/css2.1/t1202-counter-04-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-04-b-expected.txt:
15:03 Changeset [46288] by pdherbemont@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2009-07-23 Pierre d'Herbemont <pdherbemont@apple.com>

Layout test fix so no review.

Add audio-controls-rendering layout test results for windows and leopard.

  • platform/mac-leopard/media/audio-controls-rendering-expected.txt: Added.
  • platform/win/media/audio-controls-rendering-expected.txt: Added.
14:40 Changeset [46287] by mrowe@apple.com
  • 10 edits in trunk/LayoutTests

Update layout test results for the addition of a new computed style property in r46285.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
14:17 Changeset [46286] by rniwa@webkit.org
  • 6 edits
    3 adds in trunk

WebCore:

2009-07-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand('underline') can't remove <U> underlines
https://bugs.webkit.org/show_bug.cgi?id=20215

This patch adds support for u, s, and strike to implicitlyStyledElementShouldBeRemovedWhenApplyingStyle so that
WebKit can remove those presentational tags when necessary.
It also modifies StyleChange::init not to add "text-decoration: none". Not only is this style meaningless
(does not override inherited styles) but it was also causing WebKit to generate extra spans with this style.

  • css/CSSValueList.cpp: (WebCore::CSSValueList::hasValue): True if the property contains the specified value
  • css/CSSValueList.h: Updated prototype
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): No longer adds "text-decoration: none" (WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): Supports text-decoration-related elements

LayoutTests:

2009-07-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand('underline') can't remove <U> underlines
https://bugs.webkit.org/show_bug.cgi?id=20215

This patch rebaselines toggle-styles.html because WebKit now passes three tests it used to fail.
toggle-style-2.html is added to test cases in which multiple styles are specified with tags.
We still fail some tests because WebKit doesn't properly support non-CSS mode but they are visually correct.

  • editing/execCommand/resources/toggle-style-2.js: Added. (testSingleToggle): (testDoubleToggle):
  • editing/execCommand/toggle-style-2-expected.txt: Added.
  • editing/execCommand/toggle-style-2.html: Added.
  • editing/execCommand/toggle-styles-expected.txt: Passes all the tests
14:03 Changeset [46285] by jberlin@apple.com
  • 3 edits
    2 adds in trunk

2009-07-23 Jessie Berlin <jberlin@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=27554
Expose the value of text-overflow in getComputedStyle.


Reviewed by Dan Bernstein.

Test: fast/css/getComputedStyle/getComputedStyle-text-overflow.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): Add text-overflow to the list of computedProperties. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return the value of the text-overflow property.
  • fast/css/getComputedStyle/getComputedStyle-text-overflow-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-text-overflow.html: Added.
13:48 Changeset [46284] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-07-23 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=27510

[S60 QtWebKit] Don't put some intermediate generated files into the final mmp project
file for linking. This is a temporary workaround for qmake bug in Symbian port, should
be reverted after qmake is fixed.

  • WebCore.pro:
13:37 Changeset [46283] by jianli@chromium.org
  • 2 edits in trunk/WebCore

2009-07-23 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

[V8] Fix an assert in running workers in Chrome.
https://bugs.webkit.org/show_bug.cgi?id=27620

The fix is to change V8DOMMap::removeAllDOMObjectsInCurrentThreadHelper
to do not call removeObjectsFromWrapperMap for certain types of DOM
objects that exist only in main thread.

  • bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjectsInCurrentThreadHelper):
12:24 Changeset [46282] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by David Hyatt.

Rebaseline for http://trac.webkit.org/changeset/46274
(The changeset rebaselined the expected results for mac but not for windows)

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
12:06 Changeset [46281] by hyatt@apple.com
  • 11 edits
    5 adds in trunk

WebCore:

2009-07-23 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27572
Implement support for background-attachment:local.

Added new test fast/overflow/overflow-with-local-attachment.html.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseFillProperty):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EFillAttachment):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapFillAttachment):
  • css/CSSValueKeywords.in:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
  • rendering/style/FillLayer.h: (WebCore::FillLayer::attachment): (WebCore::FillLayer::setAttachment): (WebCore::FillLayer::hasFixedImage): (WebCore::FillLayer::initialFillAttachment):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::backgroundAttachment): (WebCore::InheritedFlags::maskAttachment):
  • rendering/style/RenderStyleConstants.h: (WebCore::):

LayoutTests:

2009-07-23 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27572
Implement support for background-attachment:local.

Added new test fast/overflow/overflow-with-local-attachment.html.

  • fast/overflow/overflow-with-local-background-attachment.html: Added.
  • platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.checksum: Added.
  • platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.
  • platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.txt: Added.
11:55 Changeset [46280] by rniwa@webkit.org
  • 8 edits in trunk/WebCore

2009-07-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

copyInheritableProperties and removeComputedInheritablePropertiesFrom should be deprecated
https://bugs.webkit.org/show_bug.cgi?id=27325

This patch deprecates copyInheritableProperties because it has been used for two different purposes:

  1. Calculating the typing style.
  2. Moving HTML subtrees and seeking to remove redundant styles. These tasks should be broken out into two separate functions. New code should not use this function.

It deletes removeComputedInheritablePropertiesFrom because it hasn't been used anywhere.

There is no test since the patch does not change any behavior.

  • css/CSSComputedStyleDeclaration.cpp: removeComputedInheritablePropertiesFrom has been removed (WebCore::CSSComputedStyleDeclaration::deprecatedCopyInheritableProperties): has been renamed from copyInheritableProperties
  • css/CSSComputedStyleDeclaration.h: ditto
  • editing/DeleteSelectionCommand.cpp: ditto (WebCore::removeEnclosingAnchorStyle): ditto (WebCore::DeleteSelectionCommand::saveTypingStyleState): ditto
  • editing/EditCommand.cpp: ditto (WebCore::EditCommand::styleAtPosition): ditto
  • editing/RemoveFormatCommand.cpp: ditto (WebCore::RemoveFormatCommand::doApply): ditto
  • editing/ReplaceSelectionCommand.cpp: ditto (WebCore::handleStyleSpansBeforeInsertion): ditto (WebCore::ReplaceSelectionCommand::handleStyleSpans): ditto
  • editing/markup.cpp: ditto (WebCore::removeEnclosingMailBlockquoteStyle): ditto (WebCore::removeDefaultStyles): ditto (WebCore::createMarkup): ditto
11:42 Changeset [46279] by pdherbemont@apple.com
  • 7 edits in trunk

WebCore:

2009-07-22 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Audio element at default width shouldn't have time field.
https://bugs.webkit.org/show_bug.cgi?id=27589

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimeDisplayElement::setVisible): Make sure we don't forget to remember the visibility if there is no renderer.

LayoutTests:

2009-07-22 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Audio element at default width shouldn't have time field.
https://bugs.webkit.org/show_bug.cgi?id=27589

  • platform/mac-snowleopard/Skipped: Enables back audio-controls-rendering.
  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
11:29 Changeset [46278] by kenneth@webkit.org
  • 1 edit
    18 adds in trunk/LayoutTests

2009-07-23 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Adam Treat.

Added expected results for tests that we pass.

  • platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt: Added.
  • platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Added.
  • platform/qt/fast/box-shadow/transform-fringing-expected.txt: Added.
  • platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.txt: Added.
  • platform/qt/fast/css/attribute-selector-dynamic-expected.txt: Added.
  • platform/qt/fast/css/nth-child-dynamic-expected.txt: Added.
  • platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.
  • platform/qt/fast/dynamic/anchor-lock-expected.txt: Added.
  • platform/qt/fast/frames/frameset-style-recalc-expected.txt: Added.
  • platform/qt/fast/frames/iframe-text-contents-expected.txt: Added, equal to mac.
  • platform/qt/fast/frames/viewsource-on-image-file-expected.txt: Added.
  • platform/qt/fast/repaint/background-generated-expected.txt: Added, equal to mac.
  • platform/qt/fast/repaint/background-misaligned-expected.txt: Added, equal to mac.
  • platform/qt/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Added, equal to mac.
  • platform/qt/fast/text/international/hindi-whitespace-expected.txt: Added.
  • platform/qt/fast/transforms/bounding-rect-zoom-expected.txt: Added.
11:21 Changeset [46277] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

wx build fix, adding missing header.

11:10 Changeset [46276] by bdakin@apple.com
  • 3 edits in trunk/WebCore

2009-07-23 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27598 Clean up the
AccessibilityObject class

Mostly this is just moving empty stubs into the header rather than
muddying the cpp file with them. A few functions were made pure
virtual.

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isARIAControl): (WebCore::AccessibilityObject::clickPoint): (WebCore::AccessibilityObject::documentFrameView): (WebCore::AccessibilityObject::actionVerb):
  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::intValue): (WebCore::AccessibilityObject::layoutCount): (WebCore::AccessibilityObject::doAccessibilityHitTest): (WebCore::AccessibilityObject::focusedUIElement): (WebCore::AccessibilityObject::firstChild): (WebCore::AccessibilityObject::lastChild): (WebCore::AccessibilityObject::previousSibling): (WebCore::AccessibilityObject::nextSibling): (WebCore::AccessibilityObject::parentObjectIfExists): (WebCore::AccessibilityObject::observableObject): (WebCore::AccessibilityObject::linkedUIElements): (WebCore::AccessibilityObject::titleUIElement): (WebCore::AccessibilityObject::ariaRoleAttribute): (WebCore::AccessibilityObject::isPresentationalChildOfAriaRole): (WebCore::AccessibilityObject::ariaRoleHasPresentationalChildren): (WebCore::AccessibilityObject::roleValue): (WebCore::AccessibilityObject::ariaAccessiblityName): (WebCore::AccessibilityObject::ariaLabeledByAttribute): (WebCore::AccessibilityObject::ariaDescribedByAttribute): (WebCore::AccessibilityObject::accessibilityDescription): (WebCore::AccessibilityObject::ariaSelectedTextDOMRange): (WebCore::AccessibilityObject::axObjectCache): (WebCore::AccessibilityObject::axObjectID): (WebCore::AccessibilityObject::setAXObjectID): (WebCore::AccessibilityObject::anchorElement): (WebCore::AccessibilityObject::actionElement): (WebCore::AccessibilityObject::boundingBoxRect): (WebCore::AccessibilityObject::selectedTextRange): (WebCore::AccessibilityObject::selectionStart): (WebCore::AccessibilityObject::selectionEnd): (WebCore::AccessibilityObject::url): (WebCore::AccessibilityObject::selection): (WebCore::AccessibilityObject::stringValue): (WebCore::AccessibilityObject::title): (WebCore::AccessibilityObject::helpText): (WebCore::AccessibilityObject::textUnderElement): (WebCore::AccessibilityObject::text): (WebCore::AccessibilityObject::textLength): (WebCore::AccessibilityObject::selectedText): (WebCore::AccessibilityObject::accessKey): (WebCore::AccessibilityObject::widget): (WebCore::AccessibilityObject::widgetForAttachmentView): (WebCore::AccessibilityObject::setFocused): (WebCore::AccessibilityObject::setSelectedText): (WebCore::AccessibilityObject::setSelectedTextRange): (WebCore::AccessibilityObject::setValue): (WebCore::AccessibilityObject::setSelected): (WebCore::AccessibilityObject::makeRangeVisible): (WebCore::AccessibilityObject::childrenChanged): (WebCore::AccessibilityObject::addChildren): (WebCore::AccessibilityObject::hasChildren): (WebCore::AccessibilityObject::selectedChildren): (WebCore::AccessibilityObject::visibleChildren): (WebCore::AccessibilityObject::visiblePositionRange): (WebCore::AccessibilityObject::visiblePositionRangeForLine): (WebCore::AccessibilityObject::boundsForVisiblePositionRange): (WebCore::AccessibilityObject::setSelectedVisiblePositionRange): (WebCore::AccessibilityObject::visiblePositionForPoint): (WebCore::AccessibilityObject::nextVisiblePosition): (WebCore::AccessibilityObject::previousVisiblePosition): (WebCore::AccessibilityObject::visiblePositionForIndex): (WebCore::AccessibilityObject::indexForVisiblePosition): (WebCore::AccessibilityObject::index): (WebCore::AccessibilityObject::doAXRangeForLine): (WebCore::AccessibilityObject::doAXRangeForIndex): (WebCore::AccessibilityObject::doAXStringForRange): (WebCore::AccessibilityObject::doAXBoundsForRange): (WebCore::AccessibilityObject::updateBackingStore):
11:05 Changeset [46275] by bweinstein@apple.com
  • 4 edits in trunk/WebCore

Fix of <rdar://4877658> Dragging from the area between the horizontal/vertical scrollbars when status bar is showing starts a selection and autoscroll.

10:20 Changeset [46274] by hyatt@apple.com
  • 10 edits in trunk

WebCore:

2009-07-23 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27581
Drop the prefix from the box-shadow property.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::ShadowParseContext::commitLength): (WebCore::cssPropertyID):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):

LayoutTests:

2009-07-23 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.


https://bugs.webkit.org/show_bug.cgi?id=27581
Drop the prefix from the box-shadow property.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
09:55 Changeset [46273] by treat@webkit.org
  • 4 edits
    4 adds in trunk

WebCore:
2009-07-22 Viet-Trung Luu <viettrungluu@gmail.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=27289
When a mouse click occurs on a scrollbar without a preceding mouse move
onto it, the release isn't handled correctly (since
EventHandler::m_lastScrollbarUnderMouse isn't set on mouse down, but
only on mouse move). (Side comment: That scrollbar-handling code
in EventHandler is ugly. It should be fixed properly.)

Tests: scrollbars/scrollbar-miss-mousemove.html

scrollbars/scrollbar-miss-mousemove-disabled.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::updateLastScrollbarUnderMouse):
  • page/EventHandler.h:

LayoutTests:
2009-07-22 Viet-Trung Luu <viettrungluu@gmail.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=27289
Tests that mouse clicks/releases are handled properly on scrollbars
even when there is no mouse move onto the scrollbar (two cases: enabled
and disabled controls).

  • scrollbars/scrollbar-miss-mousemove-disabled-expected.txt: Added.
  • scrollbars/scrollbar-miss-mousemove-disabled.html: Added.
  • scrollbars/scrollbar-miss-mousemove-expected.txt: Added.
  • scrollbars/scrollbar-miss-mousemove.html: Added.
09:52 Changeset [46272] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-23 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by David Levin.

Update WebCore/page/BarInfo.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27606

  • page/BarInfo.cpp: (WebCore::BarInfo::visible):
09:52 Changeset [46271] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-23 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by David Levin.

Update WebCore/page/Console.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27606

  • page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix): (WebCore::Console::profile): (WebCore::Console::time):
09:32 Changeset [46270] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-23 Eli Fidler <eli.fidler@torchmobile.com>

Reviewed by Adam Treat.

Improve git workflow by populating commit messages with ChangeLog entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

add --[no-]write option to optionally output new ChangeLog entries to
stdout instead of modifying ChangeLog files

fix Torch Mobile copyright

  • Scripts/prepare-ChangeLog:
09:13 Changeset [46269] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Enable cpplint for .c files.
https://bugs.webkit.org/show_bug.cgi?id=27604

Also make sure that the check for NULL does not apply to .c files.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
08:51 Changeset [46268] by treat@webkit.org
  • 1 edit
    3 adds in trunk/JavaScriptCore

2009-07-22 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

Add wince specific memory files into wtf/wince
https://bugs.webkit.org/show_bug.cgi?id=27550

  • wtf/wince/FastMallocWince.h: Added.
  • wtf/wince/MemoryManager.cpp: Added.
  • wtf/wince/MemoryManager.h: Added.
07:31 Changeset [46267] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-07-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Add simple proxy support for QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=27495

Picks up proxy settings from the http_proxy environment
variable.

  • QtLauncher/QtLauncher.pro: Add QtNetwork dependency for all platforms.
  • QtLauncher/main.cpp: (MainWindow::MainWindow):
07:28 Changeset [46266] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-23 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Fix for missing mmap features in Symbian
https://bugs.webkit.org/show_bug.cgi?id=24540

Fix, conditionally for PLATFORM(SYMBIAN), as an alternative
to missing support for the MAP_ANON property flag in mmap.
It utilizes Symbian specific memory allocation features.

  • runtime/Collector.cpp
06:34 Changeset [46265] by hausmann@webkit.org
  • 6 edits in trunk

WebCore:

2009-07-23 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

Fix crashes with the QObject bindings after garbage collection.

There is one QtInstance per wrapped QObject, and that QtInstance keeps
references to cached JSObjects for slots. When those objects get
deleted due to GC, then they becoming dangling pointers.

When a cached member dies, it is now removed from the QtInstance's
cache.

As we cannot track the lifetime of the children, we have to remove
them from QtInstance alltogether. They are not cached and were
only used for mark(), but we _want_ them to be subject to gc.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::~QtInstance): Minor coding style cleanup, use qDeleteAll(). (JSC::Bindings::QtInstance::removeCachedMethod): New function, to clean m_methods and m_defaultMethod. (JSC::Bindings::QtInstance::mark): Avoid marking already marked objects. (JSC::Bindings::QtField::valueFromInstance): Don't save children for marking.
  • bridge/qt/qt_instance.h: Declare removeCachedMethod.
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod): Call removeCachedMethod with this on the instance.

WebKit/qt:

2009-07-23 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

Added a testcase to verify that cached methods in the QOBject bindings
remain alife even after garbage collection.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::protectBindingsRuntimeObjectsFromCollector):
03:24 Changeset [46264] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-23 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

Fixing two issues related to QtLauncher

  • MainWindow objects are not always freed after close
  • JavaScript window.close() sometimes crashes

https://bugs.webkit.org/show_bug.cgi?id=27601

  • QtLauncher/main.cpp: (MainWindow::MainWindow): (main):
03:20 Changeset [46263] by hausmann@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-23 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Rebaseline the Qt results for computed-style.html and
computed-style-without-rendered.html after r46240, similar to r46252.

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
02:57 Changeset [46262] by levin@chromium.org
  • 5 edits in trunk/LayoutTests

2009-07-23 David Levin <levin@chromium.org>

Rubber-stamped by Oliver Hunt.

Improve keyboard navigation of Select elements.
Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
on non-Mac platforms.
https://bugs.webkit.org/show_bug.cgi?id=22784

One more round of speculative fixes:

  • Really fix the general and win expected results. (They were missing a return.)
  • Disable the test for gtk (and remove the attempted workaround for that platform).
  • fast/forms/select-popup-pagekeys-expected.txt:
  • fast/forms/select-popup-pagekeys.html:
  • platform/gtk/Skipped:
  • platform/win/fast/forms/select-popup-pagekeys-expected.txt:
02:09 Changeset [46261] by levin@chromium.org
  • 3 edits
    1 copy in trunk/LayoutTests

2009-07-23 David Levin <levin@chromium.org>

Rubber-stamped by Oliver Hunt.

3 (speculative) fixes for the new layout test: select-popup-pagekeys

  • Help Windows to pass by adding platform results.
  • Fix the general expected results.
  • Fix select-popup-pagekeys on gtk which doesn't seem to implement eventSender.
  • fast/forms/select-popup-pagekeys-expected.txt:
  • fast/forms/select-popup-pagekeys.html:
  • platform/win/fast/forms/select-popup-pagekeys-expected.txt: Added.
01:01 Changeset [46260] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-23 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=27599
'const unsigned' in return value

Remove const modifier from unsigned return value, as it does not
make sense.

  • dom/ErrorEvent.h:
00:52 Changeset [46259] by levin@chromium.org
  • 3 edits
    3 adds in trunk

2009-07-22 Jens Alfke <snej@chromium.org>

Reviewed by David Levin.

Bug 22784: Improve keyboard navigation of Select elements.
Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
on non-Mac platforms.
https://bugs.webkit.org/show_bug.cgi?id=22784
http://code.google.com/p/chromium/issues/detail?id=4576

WebCore:

New test: LayoutTests/fast/forms/select-popup-pagekeys.html

  • dom/SelectElement.cpp: (WebCore::nextValidIndex): New utility fn for traversing items of a select's list. (WebCore::SelectElement::menuListDefaultEventHandler): Added code to handle Home/End and PageUp/PageDn when ARROW_KEYS_POP_MENU is false.

LayoutTests:

  • LayoutTests/fast/forms/select-popup-pagekeys.html: Added.
  • LayoutTests/fast/forms/select-popup-pagekeys-expected.txt: Added
  • LayoutTests/platform/mac/fast/forms/select-popup-pagekeys-expected.txt: Added.
00:36 Changeset [46258] by xan@webkit.org
  • 3 edits in trunk/WebCore

2009-07-23 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

Fix a couple of compiler warnings.

  • platform/graphics/cairo/ImageBufferCairo.cpp: (copySurface):
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::containsCharacters):
00:19 Changeset [46257] by hausmann@webkit.org
  • 4 edits in trunk

WebCore:

2009-07-22 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by David Levin.

Enable HTML5 Datagrid defines for the Qt build.

  • WebCore.pro:

LayoutTests:

2009-07-22 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by David Levin.

Unskip HTML 5 Datagrid tests for the Qt DRT, as they pass.

  • platform/qt/Skipped:
00:00 Changeset [46256] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

Fix compiler warning.

  • tests/testwebsettings.c: (test_webkit_web_settings_user_agent):
Note: See TracTimeline for information about the timeline view.