Timeline


and

07/28/09:

21:54 Changeset [46520] by timothy@apple.com

Allow tabbing through the Web Inspector DOM Storage grid cells when editing.

2009-07-28 Joseph Pecoraro <joepeck02@gmail.com>

Inspector: Tab Through the DOM Storage DataGrid when Editing

https://bugs.webkit.org/show_bug.cgi?id=27746

Reviewed by Timothy Hatcher.

  • inspector/front-end/DOMStorageDataGrid.js: (WebInspector.DOMStorageDataGrid.prototype._startEditingColumnOfDataGridNode): refactored to directly edit and select a column (WebInspector.DOMStorageDataGrid.prototype._startEditing): (WebInspector.DOMStorageDataGrid.prototype._editingCommitted.moveToNextIfNeeded): handles moveDirection on a commit (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): uses moveToNext to traverse appropriately
21:54 Changeset [46519] by timothy@apple.com

Allow creating new DOM Storage items in the Web Inspector.

2009-07-28 Joseph Pecoraro <joepeck02@gmail.com>

Inspector: Create New DOM Storage Items via DataGrid

https://bugs.webkit.org/show_bug.cgi?id=27322

Reviewed by Timothy Hatcher.

  • inspector/front-end/DOMStorageDataGrid.js: (WebInspector.DOMStorageDataGrid.prototype._startEditing): click anyway means creationNode (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): fix unintended globals (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow): creationNode is special case
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.addCreationNode): maintain a quick ref to the single creationNode (WebInspector.CreationDataGridNode): new type of node (WebInspector.CreationDataGridNode.prototype.makeNormal): convert to a normal node
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage): add a creationNode to the GridData
21:53 Changeset [46518] by timothy@apple.com

Automatically refresh DOM Storage grids in the Web Inspector.

2009-07-28 Joseph Pecoraro <joepeck02@gmail.com>

Inspector: Automatically Refresh DOM Storage Grids on "storage" event

https://bugs.webkit.org/show_bug.cgi?id=27400

Reviewed by Timothy Hatcher.

  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.show): trigger adding the listener (WebInspector.DatabasesPanel.prototype.reset): trigger removing the listener (WebInspector.DatabasesPanel.prototype._registerStorageEventListener): register the listener on the inspected window (WebInspector.DatabasesPanel.prototype._unregisterStorageEventListener): unregister the listener on the inspected window (WebInspector.DatabasesPanel.prototype._storageEvent): handle the storage event
21:53 Changeset [46517] by timothy@apple.com

Added support for inspect() in the Web Inspector command line.

2009-07-28 Keishi Hattori <casey.hattori@gmail.com>

Inspector should support inspect() in the command line.

https://bugs.webkit.org/show_bug.cgi?id=19874
rdar://problem/6070225

Reviewed by Timothy Hatcher.

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled.inspectObject): (WebInspector.Console.prototype._ensureCommandLineAPIInstalled):
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.revealAndSelectDomStorage): Added. (WebInspector.DatabasesPanel.prototype.revealAndSelectDatabase): Added. (WebInspector.DatabasesPanel.prototype.showDatabase):
21:53 Changeset [46516] by timothy@apple.com

The rest of: Web Inspector: Add inspected node using public console API.

2009-07-28 Keishi Hattori <casey.hattori@gmail.com>

The rest of: Web Inspector: Add inspected node using public console API.

https://bugs.webkit.org/show_bug.cgi?id=27758

Reviewed by Timothy Hatcher.

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled): Removed _inspectorCommandLineAPI._addInspectedNode. (WebInspector.Console.prototype.addInspectedNode): Added.
21:40 Changeset [46515] by pfeldman@chromium.org

2009-07-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Accept autocomplete on 'End' key pressed.

https://bugs.webkit.org/show_bug.cgi?id=27447.

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.handleKeyEvent):
19:27 Changeset [46514] by levin@chromium.org

2009-07-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by David Levin.

[Qt] Build fix after r46502
https://bugs.webkit.org/show_bug.cgi?id=27789

  • WebCore.pro: Remove StorageArea.cpp
19:14 Applications using WebKit edited by desamo@apple.com
Adding Cha-Ching. (diff)
18:42 Changeset [46513] by mrowe@apple.com

Follow-on fix to r35582. Replace main thread assertions with WebCoreObjCScheduleDeallocateOnMainThread in -dealloc overrides in DOMObject subclasses.

Reviewed by Darin Adler.

  • bindings/scripts/CodeGeneratorObjC.pm:
18:23 Changeset [46512] by mitz@apple.com

Update Window-specific results with the non-prefixed border-radius
properties

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
18:09 Changeset [46511] by adachan@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27236

  • Implement TCMalloc_SystemRelease and TCMalloc_SystemCommit for Windows.
  • Use a background thread to periodically scavenge memory to release back to the system.
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::init): (WTF::TCMalloc_PageHeap::runScavengerThread): (WTF::TCMalloc_PageHeap::scavenge): (WTF::TCMalloc_PageHeap::shouldContinueScavenging): (WTF::TCMalloc_PageHeap::New): (WTF::TCMalloc_PageHeap::AllocLarge): (WTF::TCMalloc_PageHeap::Delete): (WTF::TCMalloc_PageHeap::GrowHeap): (WTF::sleep): (WTF::TCMalloc_PageHeap::scavengerThread):
  • wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease): (TCMalloc_SystemCommit):
  • wtf/TCSystemAlloc.h:
17:49 Changeset [46510] by zimmermann@webkit.org

2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by Adam Treat.

[WML] WML*Element classes mostly implement insertedIntoDocument(), not removedFromDocument()
https://bugs.webkit.org/show_bug.cgi?id=27786

WML*Element classes mostly implement insertedIntoDocument(), not removedFromDocument().
The only case where this is relevant in WML is error handling. The parsed WML
tree fragment is inserted in an XHTML compound error document. This requires
removedFromDocument() to be correctly implemented otherwhise we run into
trouble (visible when using run-webkit-tests fast/wml --random).

  • wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::registerTask): (WebCore::WMLAnchorElement::deregisterTask):
  • wml/WMLAnchorElement.h:
  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::removedFromDocument): (WebCore::WMLDoElement::registerTask): (WebCore::WMLDoElement::deregisterTask):
  • wml/WMLDoElement.h:
  • wml/WMLEventHandlingElement.cpp: (WebCore::WMLEventHandlingElement::registerDoElement): (WebCore::WMLEventHandlingElement::deregisterDoElement):
  • wml/WMLEventHandlingElement.h:
  • wml/WMLFieldSetElement.cpp: (WebCore::WMLFieldSetElement::removedFromDocument):
  • wml/WMLGoElement.cpp: (WebCore::WMLGoElement::registerPostfieldElement): (WebCore::WMLGoElement::deregisterPostfieldElement):
  • wml/WMLGoElement.h:
  • wml/WMLIntrinsicEventHandler.cpp: (WebCore::WMLIntrinsicEventHandler::deregisterIntrinsicEvent):
  • wml/WMLIntrinsicEventHandler.h:
  • wml/WMLOnEventElement.cpp: (WebCore::eventHandlingParent): (WebCore::WMLOnEventElement::registerTask): (WebCore::WMLOnEventElement::deregisterTask):
  • wml/WMLOnEventElement.h:
  • wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::removedFromDocument):
  • wml/WMLPostfieldElement.h:
  • wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::removedFromDocument):
  • wml/WMLSetvarElement.h:
  • wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::removedFromDocument): (WebCore::WMLTaskElement::registerVariableSetter): (WebCore::WMLTaskElement::deregisterVariableSetter): (WebCore::WMLTaskElement::storeVariableState):
  • wml/WMLTaskElement.h:
  • wml/WMLTimerElement.cpp: (WebCore::WMLTimerElement::removedFromDocument):
  • wml/WMLTimerElement.h:
17:33 Changeset [46509] by levin@chromium.org

2009-07-28 David Levin <levin@chromium.org>

Suggested by Drew Wilson.

Speculative gtk build fix, follow up to:
https://bugs.webkit.org/show_bug.cgi?id=27697

  • GNUmakefile.am:
17:16 Changeset [46508] by mitz@apple.com

WebCore:

Reviewed by Simon Fraser.

[CSS3 Backgrounds and Borders] Drop the prefix from the border-radius
properties
https://bugs.webkit.org/show_bug.cgi?id=27578

[CSS3 Backgrounds and Borders] Handle the / and 4 values in
border-radius
https://bugs.webkit.org/show_bug.cgi?id=27584

Test: fast/borders/border-radius-parsing.html

Dropped the -webkit- prefix from the individual corner border-radius
properties. Added border-radius with the / and 4-value syntax, and
maintained -webkit-border-radius with legacy 2-value syntax.

  • css/CSSComputedStyleDeclaration.cpp: (computedProperties): Removed Webkit prefix. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Removed Webkit prefix from the

single-corner properties. Call out to parseBorderRadius() to parse
border-radius and -webkit-border-radius.

(WebCore::completeBorderRadii): Added this helper function that

completes the values for all four corners when fewer than four are
specified.

(WebCore::CSSParser::parseBorderRadius): Added.
(WebCore::cssPropertyID): Map -webkit-border-*-*-radius to the

unprefixed property.

  • css/CSSParser.h:
  • css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap): Removed the Webkit prefix. Added an entry

for border-radius. Kept the entry for -webkit-border-radius.

  • css/CSSPropertyNames.in: Removed the -webkit- prefix from the

single-corenr properties. Added border-radius. Kept
-webkit-border-radius because of its conflicting syntax.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Removed the Webkit prefix.
  • page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap): Ditto.

LayoutTests:

Reviewed by Simon Fraser.

New test, updated test, and updated test results for:

[CSS3 Backgrounds and Borders] Drop the prefix from the border-radius
properties
https://bugs.webkit.org/show_bug.cgi?id=27578

[CSS3 Backgrounds and Borders] Handle the / and 4 values in
border-radius
https://bugs.webkit.org/show_bug.cgi?id=27584

  • fast/borders/border-radius-parsing-expected.txt: Added.
  • fast/borders/border-radius-parsing.html: Added.
  • fast/css/remove-shorthand-expected.txt:
  • fast/css/remove-shorthand.html: Added a test for border-radius.
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
17:08 Changeset [46507] by levin@chromium.org

2009-07-28 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Refactored dedicated-worker-specific code from WorkerThread into DedicatedWorkerThread class.

WorkerThread needs to be refactored to separate out dedicated-worker functionality.
https://bugs.webkit.org/show_bug.cgi?id=27697

This is just a refactoring, so existing tests suffice.

  • GNUmakefile.am: Added DedicatedWorkerThread.h/.cpp
  • WebCore.gypi: Added DedicatedWorkerThread.h/.cpp
  • WebCore.pro: Added DedicatedWorkerThread.h/.cpp
  • WebCore.vcproj/WebCore.vcproj: Added DedicatedWorkerThread.h/.cpp
  • WebCore.xcodeproj/project.pbxproj: Added DedicatedWorkerThread.h/.cpp
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): Removed code to track pending activity - this is handled by DedicatedWorkerContext::importScripts() now.
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): Removed code to track pending activity - this is handled by DedicatedWorkerContext::importScripts() now.
  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::addMessage): Forwards console messages to parent document. (WebCore::DedicatedWorkerContext::importScripts): Now sends the updated pending activity status after importing scripts. (WebCore::DedicatedWorkerContext::thread): Helper routine that casts WorkerThread to DedicatedWorkerThread.
  • workers/DedicatedWorkerContext.h: (WebCore::DedicatedWorkerContext::create):
  • workers/DedicatedWorkerThread.cpp: Added. (WebCore::DedicatedWorkerThread::create): (WebCore::DedicatedWorkerThread::DedicatedWorkerThread): (WebCore::DedicatedWorkerThread::~DedicatedWorkerThread): (WebCore::DedicatedWorkerThread::createWorkerContext): Implementation of the base class factory method to create the appropriate worker context. (WebCore::DedicatedWorkerThread::runEventLoop): Reports pending activity before running the event loop.
  • workers/DedicatedWorkerThread.h: Added. (WebCore::DedicatedWorkerThread::workerObjectProxy): Moved from base class.
  • workers/WorkerContext.cpp:
  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::startWorkerContext): Now creates DedicatedWorkerThread. (WebCore::WorkerMessagingProxy::workerThreadCreated): Now is passed a DedicatedWorkerThread.
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::WorkerThread): Moved workerObjectProxy param into derived class constructor. (WebCore::WorkerThread::workerThread): (WebCore::WorkerThread::runEventLoop): Moved the event loop execution into a virtual function so DedicatedWorkerThread could report pending activity first.
  • workers/WorkerThread.h: (WebCore::WorkerThread::workerContext):
16:29 Changeset [46506] by bweinstein@apple.com

2009-07-28 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Adam Roben.

Add two tests that failed on release (not debug) back to skipped list.

  • platform/win/Skipped:
16:15 Changeset [46505] by mrowe@apple.com

Prevent nightly builds of WebKit from launching against old Safari versions that we no longer work with.

Reviewed by Oliver Hunt.

  • WebKitLauncher/main.m:

(checkSafariVersion): Add a minimum required Safari version of 4.0. This matches the requirement on Windows.
(main): If the minimum version requirement is not met, display an alert and bail out.

16:12 Changeset [46504] by japhet@chromium.org

2009-07-28 Nate Chapin <japhet@chromium.org>

Reviewed by Darin Fisher.

Fix V8NPUtils' handling of UTF8 identifiers.

https://bugs.webkit.org/show_bug.cgi?id=27782

15:38 Changeset [46503] by bweinstein@apple.com

2009-07-28 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Steve Falkenburg.

Remove a lot of tests from Windows Skip list which now pass. Will watch buildbot
to make sure there are no regressions/this commit doesn't cause failures.

  • platform/win/Skipped:
15:26 Changeset [46502] by jorlow@chromium.org

2009-07-28 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Eric Seidel.

Misc cleanup in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=27517

The StorageAreaImpl changes are all for Chromium. Because the DOM Storage implementation
runs in a different process from where the Frame object lives, Chromium passes in NULL
for the sourceFrame. This affects events and handling privateBrowsing. Chromium's
incognito mode does not use the private browsing setting, so that's not a concern. As for
events, I've decided to simply disable them for now.

The StorageNamespaceImpl changes get rid of a stale comment (path is .copy'ed for thread-
safety) and to add an assert that .copy is only ever called on a SessionStorage namespace.

Also cleaned up tailing whitespace in several parts of StorageAreaImpl.cpp

  • storage/StorageArea.cpp: Removed. (It was empty anyway.)
  • storage/StorageAreaImpl.cpp: (WebCore::privateBrowsingEnabled): Factored out the check. (WebCore::StorageAreaImpl::setItem): Make frame optional. (WebCore::StorageAreaImpl::removeItem): ditto (WebCore::StorageAreaImpl::clear): ditto (WebCore::StorageAreaImpl::dispatchStorageEvent): Disable in Chromium for now.
  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): Remove stale comment. (WebCore::StorageNamespaceImpl::copy): Add assert that it's SessionStorage.
14:57 Changeset [46501] by levin@chromium.org

2009-07-28 Alpha Lam <hclam@google.com>

Reviewed by David Levin.

[chromium] Default UI controls for <video> has rendering problems
https://bugs.webkit.org/show_bug.cgi?id=27669

Fixes the bug that <video> in MediaDocument is 1 pixel tall if
it is playing an audio file by changing the style to be 32px
tall.

Also fixes a problem of default styled audio tag that hides the
all the time digits by expanding the width to 300px.

Changed the size and position of the current time and remaining
display to give enough space for the hour digit to be shown.

There are no new tests provided because this is already covered
by existing tests.

  • css/mediaControlsChromium.css:
13:53 Changeset [46500] by jorlow@chromium.org

2009-07-28 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

Add some checks to existing SessionStorage LayoutTests.
https://bugs.webkit.org/show_bug.cgi?id=27776

This is a mixed bag of tweaks to existing tests. This is the sessionStorage
side of https://bugs.webkit.org/show_bug.cgi?id=27695

  • storage/domstorage/sessionstorage/delete-removal-expected.txt:
  • storage/domstorage/sessionstorage/delete-removal.html:

Made output more readable, added redundant deletes, added deletes to
keys with the same name in different case.

  • storage/domstorage/sessionstorage/enumerate-storage.html:

Removed dead code.

  • storage/domstorage/sessionstorage/enumerate-with-length-and-key-expected.txt: Copied from LayoutTests/storage/domstorage/sessionstorage/enumerate-storage-expected.txt.
  • storage/domstorage/sessionstorage/enumerate-with-length-and-key.html: Copied from LayoutTests/storage/domstorage/sessionstorage/enumerate-storage.html.

Test enumerating by hand (with length+key).

  • storage/domstorage/sessionstorage/iframe-events-expected.txt:
  • storage/domstorage/sessionstorage/iframe-events.html:

Test removeItem and clear in addition to setItem.

  • storage/domstorage/sessionstorage/onstorage-attribute-setwindow-expected.txt: Copied from LayoutTests/storage/domstorage/sessionstorage/onstorage-attribute-setattribute-expected.txt.
  • storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html: Copied from LayoutTests/storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html.

Test using window.onstorage.

13:29 Changeset [46499] by kenneth@webkit.org

2009-07-28 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

Fix style in PluginPackage and PluginDatabase.
Part of https://bugs.webkit.org/show_bug.cgi?id=27651

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::refresh): (WebCore::PluginDatabase::findPlugin):
  • plugins/PluginDatabase.h:
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::~PluginPackage): (WebCore::PluginPackage::freeLibrarySoon): (WebCore::PluginPackage::freeLibraryTimerFired): (WebCore::PluginPackage::unloadWithoutShutdown): (WebCore::PluginPackage::initializeBrowserFuncs):
  • plugins/PluginPackage.h:
13:28 Changeset [46498] by jorlow@chromium.org

2009-07-28 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

Add some checks to existing DOM Storage LayoutTests.
https://bugs.webkit.org/show_bug.cgi?id=27695

This is really a mixed bag of tweaks to existing tests.

  • storage/domstorage/localstorage/delete-removal-expected.txt:
  • storage/domstorage/localstorage/delete-removal.html:

Made output more readable, added redundant deletes, added deletes to
keys with the same name in different case.

  • storage/domstorage/localstorage/enumerate-storage.html:

Removed dead code.

  • storage/domstorage/localstorage/enumerate-with-length-and-key-expected.txt: Added.
  • storage/domstorage/localstorage/enumerate-with-length-and-key.html: Copied from LayoutTests/storage/domstorage/localstorage/enumerate-storage.html.

Test enumerating by hand (with length+key).

  • storage/domstorage/localstorage/iframe-events-expected.txt:
  • storage/domstorage/localstorage/iframe-events.html:

Test removeItem and clear in addition to setItem.

  • storage/domstorage/localstorage/onstorage-attribute-setwindow-expected.txt: Copied from LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setattribute-expected.txt.
  • storage/domstorage/localstorage/onstorage-attribute-setwindow.html: Copied from LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setattribute.html.

Test using window.onstorage.

  • storage/domstorage/window-attributes-exist-expected.txt:
  • storage/domstorage/window-attributes-exist.html:

Verify that two consecutive calls to window.Storage will equal each other.

12:46 Changeset [46497] by kenneth@webkit.org

2009-07-28 Kenneth Rohde Christiansen <kenneth@webkit.org>

Fix the Qt build by adapting to the changes of ScriptObject.

  • Api/qwebelement.cpp: (setupScriptObject):
12:33 Changeset [46496] by dglazkov@chromium.org

2009-07-28 Anantanarayanan Iyengar <ananta@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=27769
The V8 bindings function V8Proxy::createNewContext can be
called during frame shutdown where the activeDocumentLoader
function in FrameLoader can return NULL. Added a check for the
same.

No new tests added as this is an edge case where the V8
bindings code is reentered via NPAPI during shutdown. It is
difficult to write a consistently reproducible test for this.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createNewContext):
12:28 WebKit Team edited by jeremy@chromium.org
(diff)
12:25 Changeset [46495] by dglazkov@chromium.org

2009-07-28 Ivan Posva <iposva@chromium.org>

Reviewed by Dimitri Glazkov.

Associate the CanvasPixelData backing store with the
indexed properties of the wrapper object.

https://bugs.webkit.org/show_bug.cgi?id=27773

No new tests: Relying on existing Canvas tests.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertToV8Object):
11:58 Changeset [46494] by levin@chromium.org

2009-07-28 Maxime Simon <simon.maxime@gmail.com>

Reviewed by David Levin.

Added FrameLoaderClient for Haiku WebCore support.
https://bugs.webkit.org/show_bug.cgi?id=26952

  • haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp: Added. (WebCore::FrameLoaderClientHaiku::FrameLoaderClientHaiku): (WebCore::FrameLoaderClientHaiku::setFrame): (WebCore::FrameLoaderClientHaiku::setWebView): (WebCore::FrameLoaderClientHaiku::detachFrameLoader): (WebCore::FrameLoaderClientHaiku::hasWebView): (WebCore::FrameLoaderClientHaiku::hasBackForwardList): (WebCore::FrameLoaderClientHaiku::resetBackForwardList): (WebCore::FrameLoaderClientHaiku::provisionalItemIsTarget): (WebCore::FrameLoaderClientHaiku::makeRepresentation): (WebCore::FrameLoaderClientHaiku::forceLayout): (WebCore::FrameLoaderClientHaiku::forceLayoutForNonHTML): (WebCore::FrameLoaderClientHaiku::updateHistoryForCommit): (WebCore::FrameLoaderClientHaiku::updateHistoryForBackForwardNavigation): (WebCore::FrameLoaderClientHaiku::updateHistoryForReload): (WebCore::FrameLoaderClientHaiku::updateHistoryForStandardLoad): (WebCore::FrameLoaderClientHaiku::updateHistoryForInternalLoad): (WebCore::FrameLoaderClientHaiku::updateHistoryAfterClientRedirect): (WebCore::FrameLoaderClientHaiku::setCopiesOnScroll): (WebCore::FrameLoaderClientHaiku::tokenForLoadErrorReset): (WebCore::FrameLoaderClientHaiku::resetAfterLoadError): (WebCore::FrameLoaderClientHaiku::doNotResetAfterLoadError): (WebCore::FrameLoaderClientHaiku::willCloseDocument): (WebCore::FrameLoaderClientHaiku::detachedFromParent2): (WebCore::FrameLoaderClientHaiku::detachedFromParent3): (WebCore::FrameLoaderClientHaiku::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientHaiku::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientHaiku::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientHaiku::dispatchWillClose): (WebCore::FrameLoaderClientHaiku::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientHaiku::dispatchDidCommitLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidFinishLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidFirstLayout): (WebCore::FrameLoaderClientHaiku::dispatchDidFirstVisuallyNonEmptyLayout): (WebCore::FrameLoaderClientHaiku::dispatchShow): (WebCore::FrameLoaderClientHaiku::cancelPolicyCheck): (WebCore::FrameLoaderClientHaiku::dispatchWillSubmitForm): (WebCore::FrameLoaderClientHaiku::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientHaiku::revertToProvisionalState): (WebCore::FrameLoaderClientHaiku::postProgressStartedNotification): (WebCore::FrameLoaderClientHaiku::postProgressEstimateChangedNotification): (WebCore::FrameLoaderClientHaiku::postProgressFinishedNotification): (WebCore::FrameLoaderClientHaiku::progressStarted): (WebCore::FrameLoaderClientHaiku::progressCompleted): (WebCore::FrameLoaderClientHaiku::setMainFrameDocumentReady): (WebCore::FrameLoaderClientHaiku::willChangeTitle): (WebCore::FrameLoaderClientHaiku::didChangeTitle): (WebCore::FrameLoaderClientHaiku::finishedLoading): (WebCore::FrameLoaderClientHaiku::canShowMIMEType): (WebCore::FrameLoaderClientHaiku::representationExistsForURLScheme): (WebCore::FrameLoaderClientHaiku::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientHaiku::frameLoadCompleted): (WebCore::FrameLoaderClientHaiku::saveViewStateToItem): (WebCore::FrameLoaderClientHaiku::restoreViewState): (WebCore::FrameLoaderClientHaiku::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientHaiku::provisionalLoadStarted): (WebCore::FrameLoaderClientHaiku::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoaderClientHaiku::addHistoryItemForFragmentScroll): (WebCore::FrameLoaderClientHaiku::didFinishLoad): (WebCore::FrameLoaderClientHaiku::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientHaiku::setTitle): (WebCore::FrameLoaderClientHaiku::userAgent): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientHaiku::frameLoaderDestroyed): (WebCore::FrameLoaderClientHaiku::canHandleRequest): (WebCore::FrameLoaderClientHaiku::partClearedInBegin): (WebCore::FrameLoaderClientHaiku::updateGlobalHistory): (WebCore::FrameLoaderClientHaiku::updateGlobalHistoryRedirectLinks): (WebCore::FrameLoaderClientHaiku::shouldGoToHistoryItem): (WebCore::FrameLoaderClientHaiku::saveScrollPositionAndViewStateToItem): (WebCore::FrameLoaderClientHaiku::canCachePage): (WebCore::FrameLoaderClientHaiku::setMainDocumentError): (WebCore::FrameLoaderClientHaiku::committedLoad): (WebCore::FrameLoaderClientHaiku::cancelledError): (WebCore::FrameLoaderClientHaiku::blockedError): (WebCore::FrameLoaderClientHaiku::cannotShowURLError): (WebCore::FrameLoaderClientHaiku::interruptForPolicyChangeError): (WebCore::FrameLoaderClientHaiku::cannotShowMIMETypeError): (WebCore::FrameLoaderClientHaiku::fileDoesNotExistError): (WebCore::FrameLoaderClientHaiku::shouldFallBack): (WebCore::FrameLoaderClientHaiku::createDocumentLoader): (WebCore::FrameLoaderClientHaiku::download): (WebCore::FrameLoaderClientHaiku::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientHaiku::dispatchWillSendRequest): (WebCore::FrameLoaderClientHaiku::shouldUseCredentialStorage): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientHaiku::dispatchDidCancelAuthenticationChallenge): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveContentLength): (WebCore::FrameLoaderClientHaiku::dispatchDidFinishLoading): (WebCore::FrameLoaderClientHaiku::dispatchDidFailLoading): (WebCore::FrameLoaderClientHaiku::dispatchDidLoadResourceFromMemoryCache): (WebCore::FrameLoaderClientHaiku::dispatchDidLoadResourceByXMLHttpRequest): (WebCore::FrameLoaderClientHaiku::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidFailLoad): (WebCore::FrameLoaderClientHaiku::dispatchCreatePage): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForMIMEType): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientHaiku::dispatchUnableToImplementPolicy): (WebCore::FrameLoaderClientHaiku::startDownload): (WebCore::FrameLoaderClientHaiku::createFrame): (WebCore::FrameLoaderClientHaiku::objectContentType): (WebCore::FrameLoaderClientHaiku::createPlugin): (WebCore::FrameLoaderClientHaiku::redirectDataToPlugin): (WebCore::FrameLoaderClientHaiku::pluginWillHandleLoadError): (WebCore::FrameLoaderClientHaiku::createJavaAppletWidget): (WebCore::FrameLoaderClientHaiku::overrideMediaType): (WebCore::FrameLoaderClientHaiku::windowObjectCleared): (WebCore::FrameLoaderClientHaiku::documentElementAvailable): (WebCore::FrameLoaderClientHaiku::didPerformFirstNavigation): (WebCore::FrameLoaderClientHaiku::registerForIconNotification): (WebCore::FrameLoaderClientHaiku::savePlatformDataToCachedFrame): (WebCore::FrameLoaderClientHaiku::transitionToCommittedFromCachedFrame): (WebCore::FrameLoaderClientHaiku::transitionToCommittedForNewPage):
  • haiku/WebCoreSupport/FrameLoaderClientHaiku.h: Added. (WebCore::FrameLoaderClientHaiku::~FrameLoaderClientHaiku):
11:58 Changeset [46493] by levin@chromium.org

2009-07-28 Maxime Simon <simon.maxime@gmail.com>

Reviewed by David Levin.

Added ChromeClient for Haiku WebCore support.
https://bugs.webkit.org/show_bug.cgi?id=26952

  • haiku/WebCoreSupport/ChromeClientHaiku.cpp: Added. (WebCore::ChromeClientHaiku::ChromeClientHaiku): (WebCore::ChromeClientHaiku::~ChromeClientHaiku): (WebCore::ChromeClientHaiku::chromeDestroyed): (WebCore::ChromeClientHaiku::setWindowRect): (WebCore::ChromeClientHaiku::windowRect): (WebCore::ChromeClientHaiku::pageRect): (WebCore::ChromeClientHaiku::scaleFactor): (WebCore::ChromeClientHaiku::focus): (WebCore::ChromeClientHaiku::unfocus): (WebCore::ChromeClientHaiku::canTakeFocus): (WebCore::ChromeClientHaiku::takeFocus): (WebCore::ChromeClientHaiku::createWindow): (WebCore::ChromeClientHaiku::createModalDialog): (WebCore::ChromeClientHaiku::show): (WebCore::ChromeClientHaiku::canRunModal): (WebCore::ChromeClientHaiku::runModal): (WebCore::ChromeClientHaiku::setToolbarsVisible): (WebCore::ChromeClientHaiku::toolbarsVisible): (WebCore::ChromeClientHaiku::setStatusbarVisible): (WebCore::ChromeClientHaiku::statusbarVisible): (WebCore::ChromeClientHaiku::setScrollbarsVisible): (WebCore::ChromeClientHaiku::scrollbarsVisible): (WebCore::ChromeClientHaiku::setMenubarVisible): (WebCore::ChromeClientHaiku::menubarVisible): (WebCore::ChromeClientHaiku::setResizable): (WebCore::ChromeClientHaiku::addMessageToConsole): (WebCore::ChromeClientHaiku::canRunBeforeUnloadConfirmPanel): (WebCore::ChromeClientHaiku::runBeforeUnloadConfirmPanel): (WebCore::ChromeClientHaiku::closeWindowSoon): (WebCore::ChromeClientHaiku::runJavaScriptAlert): (WebCore::ChromeClientHaiku::runJavaScriptConfirm): (WebCore::ChromeClientHaiku::runJavaScriptPrompt): (WebCore::ChromeClientHaiku::setStatusbarText): (WebCore::ChromeClientHaiku::shouldInterruptJavaScript): (WebCore::ChromeClientHaiku::tabsToLinks): (WebCore::ChromeClientHaiku::windowResizerRect): (WebCore::ChromeClientHaiku::repaint): (WebCore::ChromeClientHaiku::scroll): (WebCore::ChromeClientHaiku::screenToWindow): (WebCore::ChromeClientHaiku::windowToScreen): (WebCore::ChromeClientHaiku::platformWindow): (WebCore::ChromeClientHaiku::contentsSizeChanged): (WebCore::ChromeClientHaiku::scrollRectIntoView): (WebCore::ChromeClientHaiku::addToDirtyRegion): (WebCore::ChromeClientHaiku::scrollBackingStore): (WebCore::ChromeClientHaiku::updateBackingStore): (WebCore::ChromeClientHaiku::mouseDidMoveOverElement): (WebCore::ChromeClientHaiku::setToolTip): (WebCore::ChromeClientHaiku::print): (WebCore::ChromeClientHaiku::exceededDatabaseQuota): (WebCore::ChromeClientWx::reachedMaxAppCacheSize): (WebCore::ChromeClientHaiku::requestGeolocationPermissionForFrame): (WebCore::ChromeClientHaiku::runOpenPanel): (WebCore::ChromeClientHaiku::setCursor): (WebCore::ChromeClientHaiku::formStateDidChange): (WebCore::ChromeClientHaiku::createHTMLParserQuirks):
  • haiku/WebCoreSupport/ChromeClientHaiku.h: Added.
10:34 Changeset [46492] by xan@webkit.org

2009-07-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Nuke all references to JSWorkerContextBase.lut.h, it was removed
back in April.

  • GNUmakefile.am:
09:52 Changeset [46491] by hausmann@webkit.org

2009-07-28 Robert Agoston <Agoston.Robert@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Fixed references to script generate-webkitversion.pl, and
removed duplicated generate-webkitversion.pl

https://bugs.webkit.org/show_bug.cgi?id=27158

  • WebCore.pro:
  • platform/generate-webkitversion.pl: Removed.
09:04 Changeset [46490] by pfeldman@chromium.org

2009-07-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dmitry Glazkov.

Web Inspector: encapsulate ScriptState into the ScriptObject, get rid of
InspectorJSONObject.

https://bugs.webkit.org/show_bug.cgi?id=27766

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/ScriptArray.cpp: (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::set): (WebCore::ScriptArray::length): (WebCore::ScriptArray::createNew):
  • bindings/js/ScriptArray.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::construct):
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::ScriptObject): (WebCore::ScriptObject::set): (WebCore::ScriptObject::createNew): (WebCore::ScriptGlobalObject::get):
  • bindings/js/ScriptObject.h:
  • bindings/js/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
  • bindings/v8/ScriptArray.cpp: (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::set): (WebCore::ScriptArray::length): (WebCore::ScriptArray::createNew):
  • bindings/v8/ScriptArray.h:
  • bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::construct):
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::ScriptObject): (WebCore::ScriptObject::set): (WebCore::ScriptObject::createNew): (WebCore::ScriptGlobalObject::get):
  • bindings/v8/ScriptObject.h: (WebCore::ScriptObject::ScriptObject):
  • bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole):
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::newScriptArray): (WebCore::InspectorFrontend::newScriptObject): (WebCore::InspectorFrontend::addMessageToConsole): (WebCore::InspectorFrontend::addResource): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::addDOMStorage):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorJSONObject.cpp: Removed.
  • inspector/InspectorJSONObject.h: Removed.
  • inspector/InspectorResource.cpp: (WebCore::populateHeadersObject): (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject):
08:41 Changeset [46489] by kov@webkit.org

Tagging 1.1.12.

08:35 Changeset [46488] by levin@chromium.org

2009-07-28 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

cpplint* should be named cpp_style*
https://bugs.webkit.org/show_bug.cgi?id=27752

The files were renamed. A few renames were done:

CppLint -> CppStyle
cpplint -> cpp_style

  • Scripts/check-webkit-style:
  • Scripts/modules/cpp_style.py: Copied from cpplint.py and did name fix ups.
  • Scripts/modules/cpp_style_unittest.py: Copied from cpplint_unittest.py and did name fix ups.
  • Scripts/modules/cpplint.py: Removed.
  • Scripts/modules/cpplint_unittest.py: Removed.
08:34 Changeset [46487] by zimmermann@webkit.org

2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Variable substitution recursion seems to have bugs
https://bugs.webkit.org/show_bug.cgi?id=27726

Allow <setvar> elements to depend on the value specified by preceeding <setvar> elements.
Required by the specification - assure it only works in linear order. A setvar element may
not depend on the variable state of a following setvar element, only the previous ones.

Extend wml/variable-reference-valid.html layout test to cover these cases.

  • wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::storeVariableState):

2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Variable substitution recursion seems to have bugs
https://bugs.webkit.org/show_bug.cgi?id=27726

Extend variable-reference-valid.html to test <setvar> attribute values depending on each other.

  • wml/resources/variable-reference-valid.js: (setupTestDocument): (prepareTest): (executeTest):
  • wml/variable-reference-valid-expected.txt:
08:03 Changeset [46486] by zimmermann@webkit.org

2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Page title doesn't update after variable substitution, if it contained variables
https://bugs.webkit.org/show_bug.cgi?id=27725

Fix bug in containsVariableReference() function, we we're decreasing the nameEndPosition
too much, leading to a bug with 1-char variable names, which were not detected properly.

Extend wml/variable-reference-valid.html layout test to cover 1-char variable names.
Also fixes manual-tests/wml/task-refresh-in-anchor.wml, which happened to use 1-char variable names.

  • wml/WMLVariables.cpp: (WebCore::containsVariableReference):

2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Page title doesn't update after variable substitution, if it contained variables
https://bugs.webkit.org/show_bug.cgi?id=27725

Extend variable-reference-valid.html test to include one-character variable tests.

  • wml/resources/variable-reference-valid.js: (setupTestDocument): (prepareTest): (executeTest):
  • wml/variable-reference-valid-expected.txt:
07:58 Changeset [46485] by hausmann@webkit.org

WebCore:

2009-07-28 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

Add WebKit version API to Qt.

Get the current version of WebKit from WebKit/mac/Configurations/Version.xcconfig
at compile time and make it available to webkit ports through WebKitVersion.h.

https://bugs.webkit.org/show_bug.cgi?id=27158

  • WebCore.pro: Call generate-webkitversion.pl

WebKit:

2009-07-28 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

Add WebKit version API to Qt.

Get the current version of WebKit from WebKit/mac/Configurations/Version.xcconfig
at compile time and make it available to webkit ports through WebKitVersion.h.

https://bugs.webkit.org/show_bug.cgi?id=27158

  • scripts/generate-webkitversion.pl: Added

WebKit/qt:

2009-07-28 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

Add WebKit version API to Qt.

Get the current version of WebKit from WebKit/mac/Configurations/Version.xcconfig
at compile time and make it available to Qt applications through
qWebKitVersion().

Also amend the User Agent string to place the Safari clause outside
the final bracket and to the end of the UA string.

https://bugs.webkit.org/show_bug.cgi?id=27158

Minor build tweak by Simon Hausmann (adding export macros to new functions).

  • Api/headers.pri:
  • Api/qwebkitversion.cpp: Added. (webKitVersion): (webKitMajorVersion): (webKitMinorVersion):
  • Api/qwebkitversion.h: Added.
  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::getWebKitVersion):
07:57 Changeset [46484] by kov@webkit.org

2009-07-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed make dist build fix.

  • GNUmakefile.am:
07:41 Changeset [46483] by treat@webkit.org

2009-07-28 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Replace hardcoded separator text with proper separator.
Also adjusts include order as per style guidelines.

https://bugs.webkit.org/show_bug.cgi?id=27763

  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::populate):
07:26 Changeset [46482] by hausmann@webkit.org

2009-07-28 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Ariya Hidayat.

Fix compilation with the precompiled header.

  • WebKit_pch.h: Don't include JSDOMBinding.h and MathObject.h, as they include AtomicString.h. AtomicString.cpp needs to enable a #define before including AtomicString.h, which breaks if the PCH forces the inclusion beforehand.
06:53 EFLWebKit edited by tonikitoo@gmail.com
(diff)
06:34 Changeset [46481] by xan@webkit.org

2009-07-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Use automake 1.11 SILENT_RULES when present, for cleaner build
output. You can disable it by passing --disable-silent-rules to
configure or V=1 to make.

  • autotools/dolt.m4:
  • configure.ac:
06:33 Changeset [46480] by vestbo@webkit.org

2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Steve Falkenburg.

Add output directory for VS pre-build steps to enable out-of-tree builds

https://bugs.webkit.org/show_bug.cgi?id=27700

The tmp.obj file is now placed in the intermediate build directory.

  • WebCore.vcproj/WebCoreCommon.vsprops:

2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Steve Falkenburg.

Add output directory for VS pre-build steps to enable out-of-tree builds

https://bugs.webkit.org/show_bug.cgi?id=27700

The tmp.obj file is now placed in the intermediate build directory.

  • WebKit.vcproj/WebKit.vcproj:
06:30 Changeset [46479] by pfeldman@chromium.org

2009-07-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add inspected node using public console API.

https://bugs.webkit.org/show_bug.cgi?id=27758

  • inspector/front-end/Console.js: (WebInspector.Console.prototype.addInspectedNode):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel):
06:26 Changeset [46478] by ariya@webkit.org

2009-07-28 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

Added tests to ensure that scroll position can be changed
programmatically, even when the scroll bar policy is set to off.

  • tests/qwebframe/tst_qwebframe.cpp:
06:23 Changeset [46477] by vestbo@webkit.org

2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Rubber-stamped by Holger Freyther.

Add Steve Falkenburg to bugzilla-tools' reviewers list

  • Scripts/modules/bugzilla.py:
06:12 Changeset [46476] by vestbo@webkit.org

2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Fix a few compilation warnings in the QWebFrame tests.

  • tests/qwebframe/tst_qwebframe.cpp:
06:04 Changeset [46475] by hausmann@webkit.org

2009-07-28 Andre Pedralho <andre.pedralho@openbossa.org>

Reviewed by Simon Hausmann.

Fixed tst_QWebFrame::hasSetFocus test which was using
an undefined resource.
https://bugs.webkit.org/show_bug.cgi?id=27512

  • tests/qwebframe/tst_qwebframe.cpp:
05:47 Changeset [46474] by zimmermann@webkit.org

2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] <do> elements with a <noop> task shouldn't be exposed to the user
https://bugs.webkit.org/show_bug.cgi?id=27724

Fix WMLNoopElement to disable it's parent WMLDoElement, as required by the spec.
Moved manual-tests/wml/task-noop-in-do.wml to LayoutTests/fast/wml/task-noop-in-do.wml.

  • manual-tests/wml/task-noop-in-do.wml: Removed.
  • wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::insertedIntoDocument):

2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] <do> elements with a <noop> task shouldn't be exposed to the user
https://bugs.webkit.org/show_bug.cgi?id=27724

Add new layout test covering noop elements in do elements.

  • fast/wml/task-noop-in-do.wml: Copied from WebCore/manual-tests/wml/task-noop-in-do.wml.
  • platform/mac/fast/wml/task-noop-in-do-expected.checksum: Added.
  • platform/mac/fast/wml/task-noop-in-do-expected.png: Added.
  • platform/mac/fast/wml/task-noop-in-do-expected.txt: Added.
05:40 Changeset [46473] by xan@webkit.org

2009-07-28 Xan Lopez <xlopez@igalia.com>

Add new files, fixes distcheck.

  • GNUmakefile.am:
05:35 Changeset [46472] by hausmann@webkit.org

2009-07-28 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Determining whether to use JIT or interpreter
moved from JavaScriptCore.pri to Platform.h

05:27 Changeset [46471] by hausmann@webkit.org

.:

2009-07-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Disable some compiler warnings for the win build
https://bugs.webkit.org/show_bug.cgi?id=27709

  • WebKit.pri:

WebCore:

2009-07-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Disable some compiler warnings for the win build
https://bugs.webkit.org/show_bug.cgi?id=27709

  • WebCore.pro: Move the msvc options to WebKit.pri
04:48 Changeset [46470] by hausmann@webkit.org

2009-07-28 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

Implement test result archive support for the Qt port.

  • BuildSlaveSupport/test-result-archive:
04:12 Changeset [46469] by kov@webkit.org

WebCore

2009-07-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Tor Arne Vestbø

Make equality checks for logging channel names ignore casing.

  • platform/Logging.cpp: (WebCore::getChannelFromName):

WebKit/gtk

2009-07-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Add information about the regression fix for WEBKIT_DEBUG.

  • NEWS:
04:02 Changeset [46468] by jmalonzo@webkit.org

2009-07-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Refactor ResourceHandleSoup - make start* functions static
https://bugs.webkit.org/show_bug.cgi?id=27687

  • platform/network/ResourceHandle.h:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startData): (WebCore::startHttp): (WebCore::):
03:58 Changeset [46467] by xan@webkit.org

2009-07-28 Priit Laes <plaes@plaes.org>

Reviewed by Xan Lopez.

Fix mnemonics in the soup authentication dialog.

  • webkit/webkitsoupauthdialog.c: (show_auth_dialog):
03:52 Changeset [46466] by xan@webkit.org

2009-07-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Do not cache the pango layout in the object, since the layout of
the page can change between calls.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
03:39 Changeset [46465] by xan@webkit.org

2009-07-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

  • configure.ac: bump version for 1.1.12 release.

WebKit/gtk:

2009-07-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

  • NEWS: update for 1.1.12 release.
02:20 Changeset [46464] by hausmann@webkit.org

2009-07-28 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Make it possible to pass relative file names to QtLauncher.

  • QtLauncher/main.cpp: (MainWindow::MainWindow):
02:00 Changeset [46463] by hausmann@webkit.org

2009-07-27 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Adam Treat.

update qt expefic expected files for fast/css/getComputedStyle/ tests after r46274
https://bugs.webkit.org/show_bug.cgi?id=27714

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
01:27 Changeset [46462] by abarth@webkit.org

2009-07-23 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Simplify management of Nodes in weak handles callbacks.
https://bugs.webkit.org/show_bug.cgi?id=27628

  • bindings/v8/V8DOMMap.cpp: (WebCore::weakNodeCallback):
01:14 Changeset [46461] by bweinstein@apple.com

2009-07-28 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by David Levin.

Fix error handling of GetIconInfo (returns a bool).

  • platform/win/DragImageWin.cpp: (WebCore::createDragImageIconForCachedImage):
00:11 Changeset [46460] by bweinstein@apple.com

2009-07-27 Brian Weinstein <bweinstein@apple.com>

Reviewed by Jon Honeycutt.

Fix of <rdar://5015949> Drag Icon is not produced for over sized images.

Implemented the createDragImageIconForCachedImage function by using the Windows
SHFILEINFO structure.

  • platform/win/DragImageWin.cpp: (WebCore::createDragImageIconForCachedImage):

07/27/09:

23:05 Changeset [46459] by abarth@webkit.org

2009-07-25 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[V8] Split up V8DOMMap.cpp by class
https://bugs.webkit.org/show_bug.cgi?id=27685

No behavior change. Just copy-and-paste.

  • WebCore.gypi:
  • bindings/v8/ChildThreadDOMData.cpp: Added. (WebCore::ChildThreadDOMData::ChildThreadDOMData): (WebCore::ChildThreadDOMData::getStore):
  • bindings/v8/ChildThreadDOMData.h: Added.
  • bindings/v8/DOMData.cpp: Added. (WebCore::DOMData::DOMData): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getCurrentMainThread): (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::ensureDeref): (WebCore::DOMData::derefObject): (WebCore::DOMData::derefDelayedObjects): (WebCore::DOMData::derefDelayedObjectsInCurrentThread): (WebCore::DOMData::removeObjectsFromWrapperMap):
  • bindings/v8/DOMData.h: Added. (WebCore::):
  • bindings/v8/DOMDataStore.cpp: Added. (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStore::allStores): (WebCore::DOMDataStore::allStoresMutex): (WebCore::DOMDataStore::getDOMWrapperMap): (WebCore::forget): (WebCore::DOMDataStore::weakDOMObjectCallback): (WebCore::DOMDataStore::weakActiveDOMObjectCallback): (WebCore::DOMDataStore::weakNodeCallback): (WebCore::DOMDataStore::weakSVGElementInstanceCallback): (WebCore::DOMDataStore::weakSVGObjectWithContextCallback):
  • bindings/v8/DOMDataStore.h: Added. (WebCore::DOMDataStore::): (WebCore::DOMDataStore::InternalDOMWrapperMap::InternalDOMWrapperMap): (WebCore::DOMDataStore::InternalDOMWrapperMap::forgetOnly): (WebCore::DOMDataStore::domData): (WebCore::DOMDataStore::domNodeMap): (WebCore::DOMDataStore::domObjectMap): (WebCore::DOMDataStore::activeDomObjectMap): (WebCore::DOMDataStore::domSvgElementInstanceMap): (WebCore::DOMDataStore::domSvgObjectWithContextMap):
  • bindings/v8/MainThreadDOMData.cpp: Added. (WebCore::MainThreadDOMData::MainThreadDOMData): (WebCore::MainThreadDOMData::getStore):
  • bindings/v8/MainThreadDOMData.h: Added.
  • bindings/v8/ScopedDOMDataStore.cpp: Added. (WebCore::ScopedDOMDataStore::ScopedDOMDataStore): (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
  • bindings/v8/ScopedDOMDataStore.h: Added.
  • bindings/v8/StaticDOMDataStore.cpp: Added. (WebCore::StaticDOMDataStore::StaticDOMDataStore):
  • bindings/v8/StaticDOMDataStore.h: Added.
  • bindings/v8/V8DOMMap.cpp:
22:24 Changeset [46458] by beidson@apple.com

2009-07-27 Brady Eidson <beidson@apple.com>

Update Tiger specific results for these 7 tests.

  • platform/mac-tiger/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/mac-tiger/security/block-test-expected.txt:
  • platform/mac-tiger/security/block-test-no-port-expected.txt:
21:53 Changeset [46457] by beidson@apple.com

2009-07-27 Brady Eidson <beidson@apple.com>

Update Windows specific results for these 5 tests.

  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt:
21:50 Changeset [46456] by beidson@apple.com

2009-07-27 Brady Eidson <beidson@apple.com>

Didn't mean to check this guy in.

  • http/tests/appcache/max-size-expected.txt:
21:29 Changeset [46455] by beidson@apple.com

WebKitTools:

2009-07-27 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=27755
Layout tests that dump resource load delegate calls should dump the request method and the response status code.

  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURLResponse _drt_descriptionSuitableForTestResult]): (-[NSURLRequest _drt_descriptionSuitableForTestResult]):
  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (descriptionSuitableForTestResult):

LayoutTests:

2009-07-27 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=27755
Layout tests that dump resource load delegate calls should dump the request method and the response status code.

Update test results for the new info.

  • fast/loader/main-document-url-for-non-http-loads-expected.txt:
  • http/tests/appcache/max-size-expected.txt:
  • http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
  • http/tests/misc/window-dot-stop-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt:
  • platform/mac/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • platform/mac/security/block-test-expected.txt:
  • platform/mac/security/block-test-no-port-expected.txt:
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:
19:50 UsingGitWithWebKit edited by pdherbemont@apple.com
--regenerate-log (diff)
19:29 Changeset [46454] by pdherbemont@apple.com

2009-07-27 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by David Levin.

"bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load.
https://bugs.webkit.org/show_bug.cgi?id=27747

modules.bugzilla is not found because not included.

  • Scripts/modules/scm.py: Properly import modules.bugzilla.
19:28 Changeset [46453] by pdherbemont@apple.com

2009-07-24 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by David Kilzer.

commit-log-editor should allow git commit --amend to regenerate the commit log based on the modifed ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=27664

  • Scripts/commit-log-editor: Add --regenerate-log option. The user is asked if he wants to suppress previous ChangeLog and regenerate it, if this option is enabled.
19:25 Changeset [46452] by mrowe@apple.com

Versioning.

19:24 Changeset [46451] by mrowe@apple.com

New tag.

18:57 Changeset [46450] by mrowe@apple.com

Merge r46449.

18:49 Changeset [46449] by mrowe@apple.com

<rdar://problem/7091036> REGRESSION: Microsoft Messenger crashes during file send/receive due to use of WebKit on non-main thread

Reviewed by Darin Adler.

In some situations Microsoft Messenger can attempt to manipulate the DOM from a secondary thread while
updating its file transfer progress bar. This results in corruption of WebCore data structures that is
quickly followed by a crash. We can work around this by having -[WebFrame DOMDocument] return nil when
called from a secondary thread by Microsoft Messenger, which has the effect of turning its attempts at
DOM manipulation in to no-ops.

  • WebView/WebFrame.mm:

(needsMicrosoftMessengerDOMDocumentWorkaround):
(-[WebFrame DOMDocument]):

Add a method for detecting if we're being used within Microsoft Messenger.

  • WebCore.base.exp: Export applicationIsMicrosoftMessenger and sort existing entries.
  • platform/mac/RuntimeApplicationChecks.h:
  • platform/mac/RuntimeApplicationChecks.mm:

(WebCore::applicationIsMicrosoftMessenger):

18:11 Changeset [46448] by jianli@chromium.org

2009-07-27 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

[V8] Implement EventListener::reportError for V8 event listeners in worker context.
https://bugs.webkit.org/show_bug.cgi?id=27731

  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::reportError):
  • bindings/v8/V8WorkerContextEventListener.h:
17:50 Changeset [46447] by levin@chromium.org

2009-07-27 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel and David Levin.

Re-apply chromium/skia border fix (originally landed in r46157,
reverted in r46363), since it was not the cause of the reliability
failures in Chromium.

http://bugs.webkit.org/show_bug.cgi?id=27388

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
17:47 Changeset [46446] by rniwa@webkit.org

WebCore:

2009-07-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

createMarkup does not handle CSS properly
https://bugs.webkit.org/show_bug.cgi?id=27660

This patch isolates code that creates markup for styles in addStyleMarkup
It also makes all presentational elements (u, s, strike, i, em, b, strong) special ancestor in createMarkup
so that we can assume no text decoration style is passed to addStyleMarkup.

  • editing/markup.cpp: (WebCore::propertyMissingOrEqualToNone): Changed the first argument from CSSMutableStyleDecleration to CSSStyleDeclaration (WebCore::isElementPresentational): Used to be elementHasTextDecorationProperty, now supports presentational tags (WebCore::addStyleMarkup): Adds markup for style span and div (WebCore::createMarkup): Uses isElementPresentational and addStyleMarkup

LayoutTests:

2009-07-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

createMarkup does not handle CSS properly
https://bugs.webkit.org/show_bug.cgi?id=27660


inline-style-after-indentoutdent tests whether the original inline style is preserved after outdentation
immediately after indentation.

  • editing/deleting/pruning-after-merge-2.html: Replaced b that contains div with a div with font-weight
  • editing/execCommand/inline-style-after-indentoutdent-expected.txt: Added.
  • editing/execCommand/inline-style-after-indentoutdent.html: Added.
  • editing/execCommand/resources/inline-style-after-indentoutdent.js: Added. (testCreateMarkup): (shouldBeSameAfterCreateMarkup):
  • platform/mac/editing/deleting/delete-3857753-fix-expected.txt: extra i tag is added (still passes pixel tests)
  • platform/mac/editing/deleting/pruning-after-merge-2-expected.txt: extra div as explained above
  • platform/mac/editing/pasteboard/display-block-on-spans-expected.txt: bug 26483 appearing
17:35 Changeset [46445] by zimmermann@webkit.org

Rubber-stamped by George Staikos.
Forgot to update pixel test results a while ago.

17:21 Changeset [46444] by eric@webkit.org

2009-07-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

fix more obvious global object lookups
https://bugs.webkit.org/show_bug.cgi?id=27745

No new tests for these changes. I believe in many cases
testing to be impossible. Lack of testing justification next to
each change below. The remaining pieces of bug 27634 will all
need tests.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::updateDocument): not testable.
  • bindings/js/JSDataGridColumnListCustom.cpp: (WebCore::JSDataGridColumnList::nameGetter): no testing for this incomplete feature.
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent): would require outer frame to trigger an event in the inner frame
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): covered by other tests, always correct to pass the globalObject through.
  • bindings/js/JSHTMLElementCustom.cpp: (WebCore::JSHTMLElement::pushEventHandlerScope): unclear when this could be triggered.
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::remove): toJS seems superfluous here to begin with.
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): would require outer frame to trigger inner frame event.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::jsObjectForPluginElement): only used for NPAPI binding, unclear how to test.
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): unclear how to test.
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set): unclear how to test/inspector only.
  • bindings/js/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject): unclear how to test.
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]): unclear how to test.
17:16 Changeset [46443] by zimmermann@webkit.org

2009-07-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] 'title' attribute handling not correct for <a> / <anchor> elements
https://bugs.webkit.org/show_bug.cgi?id=27720

Unify title() implementation in WMLElement instead of several copies of the same logic.
We forgot WMLAnchorElement/WMLAElement, that lead to bugs. Fixes hovering links in the
WML manual-test suite.

  • wml/WMLCardElement.cpp:
  • wml/WMLCardElement.h:
  • wml/WMLElement.cpp: (WebCore::WMLElement::title):
  • wml/WMLElement.h:
  • wml/WMLOptGroupElement.cpp:
  • wml/WMLOptGroupElement.h:
  • wml/WMLSelectElement.cpp:
  • wml/WMLSelectElement.h:
16:28 Changeset [46442] by bweinstein@apple.com

Build fix for Windows.

16:21 Changeset [46441] by bweinstein@apple.com

Build fix for Windows for JSC recent breakage.

16:21 Changeset [46440] by eric@webkit.org

2009-07-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

prototypes-inheritance-2.html should crawl more types
https://bugs.webkit.org/show_bug.cgi?id=27741

Now we evaluate the crawl targets lazily so as not to skew any JS binding caching with our test ordering.
We could get around all caching by always instantiating a new copy of the frame
but that would be super-slow. :)

We're now crawling a bunch more types, all of which we pass.

  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/resources/prototype-inheritance-2.js: (evalToCrawlObject.LazyEvalCrawlObject): (evalToCrawlObject): (pushPropertyValuesWithUnseenTypes): (crawl):
16:19 Changeset [46439] by treat@webkit.org

2009-07-27 Adam Treat <adam.treat@torchmobile.com>

Speculative build fix for Windows and WinCE.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
15:56 Changeset [46438] by barraclough@apple.com

2009-07-27 Gavin Barraclough <barraclough@apple.com>

Rubber stamped by Oliver Hunt.

Fix tyop in JIT, renamed preverveReturnAddressAfterCall -> preserveReturnAddressAfterCall.

  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::preserveReturnAddressAfterCall):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
15:45 Changeset [46437] by ojan@chromium.org

2009-07-27 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27474
Tests crashes when calling select, setSelectionRange or setting
selectionStart/selectionEnd on a textarea/input immediately after
setting display:none.

  • fast/dom/text-control-crash-on-select-expected.txt: Added.
  • fast/dom/text-control-crash-on-select.html: Added.

2009-07-27 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27474
Fixes crashes due to renderer getting destroyed in updateLayout.
We need to call updateLayout before we call into the renderer.
Removed the updateLayout call from RenderTextControl and moved it
into the calling sites.

Also changes updateLayout to updateLayoutIgnorePendingStylesheets so
this works with pending stylesheets. Unfortunately, this seems to be
untestable. Loading an external stylesheet and then having an inline
script hit this code did not result in an pending stylesheets.

The are other cases of this bug in the rendering code. I'll file a
followup bug to audit the calls to updateLayout.

Test: fast/dom/text-control-crash-on-select.html

  • dom/Document.h: (WebCore::Document::inStyleRecalc): Added so the ASSERTs in updateFocusAppearance

and setSelectionRange could deal with cases of reentrancy into updateLayout
calls. This happens in a couple layout tests.

  • dom/InputElement.cpp: (WebCore::InputElement::updateSelectionRange):
  • html/HTMLInputElement.cpp: (WebCore::isTextFieldWithRendererAfterUpdateLayout): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select):
  • html/HTMLTextAreaElement.cpp: (WebCore::rendererAfterUpdateLayout): (WebCore::HTMLTextAreaElement::setSelectionStart): (WebCore::HTMLTextAreaElement::setSelectionEnd): (WebCore::HTMLTextAreaElement::select): (WebCore::HTMLTextAreaElement::setSelectionRange): (WebCore::HTMLTextAreaElement::updateFocusAppearance):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setSelectionRange):
15:43 Changeset [46436] by ap@webkit.org

Gtk build fix.

  • runtime/JSLock.cpp: (JSC::JSLock::JSLock): Fix "no threading" case.
15:40 Changeset [46435] by dglazkov@chromium.org

2009-07-27 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Dave Levin.

[V8] Remove parameterless frame/window retrieval methods from V8Proxy.
https://bugs.webkit.org/show_bug.cgi?id=27737

Refactoring, no new behavior, covered by existing tests.

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/V8NPUtils.cpp: (convertV8ObjectToNPVariant): Ditto.
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieve): Ditto. (WebCore::V8Proxy::canAccessPrivate): Ditto.
  • bindings/v8/V8Proxy.h: Removed parameterless retrieveWindow/retrieveProxy decls.
  • bindings/v8/custom/V8DatabaseCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Changed to use V8Proxy::retrieveFrameForCurrentContext().
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8SQLTransactionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
15:36 Changeset [46434] by ap@webkit.org

Gtk build fix.

  • webkit/webkitwebframe.cpp: (webkit_gc_count_javascript_objects): Added a namespace to SilenceAssertionsOnly.
15:26 Changeset [46433] by ap@webkit.org

Release build fix.

  • runtime/JSLock.h: (JSC::JSLock::~JSLock):
15:18 Changeset [46432] by zimmermann@webkit.org

WebCore:

2009-07-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] 'onpick' intrinsic event handling missing
https://bugs.webkit.org/show_bug.cgi?id=27723

Trigger 'onpick' intrinsic events from WMLOptionElement::setSelectedState().
All was in place, just forgot to enable the relevant code.

Fixes manual-tests/wml/select-onpick-event.wml
Test: wml/option-element-onpick.html

  • wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::setSelectedState):

LayoutTests:

2009-07-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] 'onpick' intrinsic event handling missing
https://bugs.webkit.org/show_bug.cgi?id=27723

Add a new WML layout test covering 'onpick' support.

  • wml/option-element-onpick-expected.txt: Added.
  • wml/option-element-onpick.html: Added.
  • wml/resources/option-element-onpick.js: Added. (setupTestDocument): (prepareTest): (executeTest):
15:07 Changeset [46431] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27735
Give a helpful name to JSLock constructor argument

15:00 Changeset [46430] by treat@webkit.org

2009-07-27 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

WINCE PORT: Make plugin work for WINCE
https://bugs.webkit.org/show_bug.cgi?id=27713

  • plugins/win/PluginDatabaseWin.cpp: (SHGetValue): (PathRemoveFileSpec): (WebCore::addWindowsMediaPlayerPluginDirectory): (WebCore::addMacromediaPluginDirectories):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
  • plugins/win/PluginViewWin.cpp: (WebCore::registerPluginView): (WebCore::PluginView::wndProc): (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paintWindowedPluginIntoContext): (WebCore::PluginView::paint): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::stop): (WebCore::PluginView::init):
14:58 Changeset [46429] by timothy@apple.com

Adds support to the Web Inspector for tabbing through element attributes and CSS properties when editing.

2009-07-27 Joseph Pecoraro <joepeck02@gmail.com>

Inspector: Tab Through Element Attributes and CSS Properties When Editing

https://bugs.webkit.org/show_bug.cgi?id=27673

Reviewed by Timothy Hatcher.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._startEditing): refactored parameter (WebInspector.ElementsTreeElement.prototype._addNewAttribute): refactored to remove excess (WebInspector.ElementsTreeElement.prototype._triggerEditAttribute): provide an attribute name and this will start editing it (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded): move between attributes (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.StylePropertiesSection.prototype.findTreeElementWithName): search through treeElements for a style property name (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): initialize a blank property for adding new properties (WebInspector.StylePropertyTreeElement.prototype.updateTitle): add references to the name and value elements (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.js: (WebInspector.startEditing.editingCommitted): include the move direction as a parameter to the commit callback (WebInspector.startEditing.element.handleKeyEvent): handle the tab key to specify the move direction (WebInspector.startEditing):
14:31 Changeset [46428] by treat@webkit.org

2009-07-27 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add mapping FontWeight to QFont::Weight values as requested via FIXME.
https://bugs.webkit.org/show_bug.cgi?id=27663

  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::toQFontWeight):
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
14:21 WebKit Team edited by abarth@webkit.org
(diff)
14:21 Changeset [46427] by treat@webkit.org

2009-07-27 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Treat.

When clearing the plugin database, clear also the timestamp map.

https://bugs.webkit.org/show_bug.cgi?id=27651

Currently, if we clear the database, it will still think that it is up
to date with the plugin directories so refreshing the database again
after changing the search paths may not work.

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::clear):
14:17 Changeset [46426] by jianli@chromium.org

2009-07-27 Albert J. Wong <ajwong@chromium.org>

Reviewed by David Levin.

Add in trivial implementation of FontPlatformData::description() for
linux to fix build bustage in chromium.

Fix chromium linux build by adding missing function implementation.
https://bugs.webkit.org/show_bug.cgi?id=27732

Tested with a build of chromium on linux.

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::description):
  • platform/graphics/chromium/FontPlatformDataLinux.h:
12:45 QtWebKitTodo edited by andre.pedralho@openbossa.org
(diff)
12:09 Changeset [46425] by bfulgham@webkit.org

2009-07-27 Brent Fulgham <bfulgham@webkit.org>

Build correct, no review.

Final correction for WinCairo builds.
CoreServices only exists in Apple builds, but
some of its internal includes (e.g., <windows.h>) are needed
for other Windows targets.

  • WebCorePrefix.h: When building for WinCairo, make sure to include <windows.h>, <stdio.h>, and <ConditionalMacros.h>
11:54 Changeset [46424] by pkasting@chromium.org

2009-07-27 Peter Kasting <pkasting@google.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=27323
Correctly parse command output, even when the line endings are not LF,
so that we don't create an autoversion.h that MSVC chokes on.

  • win/tools/scripts/auto-version.sh:
11:32 Changeset [46423] by pkasting@chromium.org

WebCore:

2009-07-27 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25552
Added new "pattern" attribute to HTMLInputElement and validation code
(validity.patternMismatch) as per HTML5 specs.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-pattern

Tests: fast/forms/ValidityState-002.html

fast/forms/ValidityState-patternMismatch-001.html
fast/forms/ValidityState-patternMismatch-002.html
fast/forms/ValidityState-patternMismatch-003.html
fast/forms/ValidityState-patternMismatch-004.html
fast/forms/ValidityState-patternMismatch-005.html
fast/forms/ValidityState-patternMismatch-006.html
fast/forms/ValidityState-patternMismatch-007.html
fast/forms/pattern-attribute-001.html
fast/forms/pattern-attribute-002.html
fast/forms/pattern-attribute-003.html

  • html/HTMLAttributeNames.in: pattern attribute
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::patternMismatch): method definition
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::patternMismatch): validation method
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • html/ValidityState.h: (WebCore::ValidityState::patternMismatch): validation flag

LayoutTests:

2009-07-27 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25552
First series of tests for the "pattern" attribute and related validation
code

  • fast/forms/ValidityState-002-expected.txt: Copied from LayoutTests/fast/forms/willvalidate-001-expected.txt.
  • fast/forms/ValidityState-002.html: Added.
  • fast/forms/ValidityState-patternMismatch-001-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-001.html: Added.
  • fast/forms/ValidityState-patternMismatch-002-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-002.html: Added.
  • fast/forms/ValidityState-patternMismatch-003-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-003.html: Added.
  • fast/forms/ValidityState-patternMismatch-004-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-004.html: Added.
  • fast/forms/ValidityState-patternMismatch-005-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-005.html: Added.
  • fast/forms/ValidityState-patternMismatch-006-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-006.html: Added.
  • fast/forms/ValidityState-patternMismatch-007-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-007.html: Added.
  • fast/forms/pattern-attribute-001-expected.txt: Added.
  • fast/forms/pattern-attribute-001.html: Added.
  • fast/forms/pattern-attribute-002-expected.txt: Added.
  • fast/forms/pattern-attribute-002.html: Added.
  • fast/forms/pattern-attribute-003-expected.txt: Added.
  • fast/forms/pattern-attribute-003.html: Added.
11:22 Changeset [46422] by zimmermann@webkit.org

Reviewed by George Staikos.

[WML] Manual WML tests aren't properly working
https://bugs.webkit.org/show_bug.cgi?id=27718

Fix file paths in the manual WML layout tests, remove unneeded tests (already covered by DRT tests).
Add missing resources directory and test image. Reformat all testcases to a common style.
Add new StartTests.wml file, which should be used as starting point to crawl through the manual tests.

Filing bugs soon for all tests exposing bugs (7 in total).

11:17 Changeset [46421] by japhet@chromium.org

2009-07-27 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a regression introduced in r42671, which caused the js event
object to be hidden (some websites depend on being able to access it).

https://bugs.webkit.org/show_bug.cgi?id=27719

11:08 Changeset [46420] by dglazkov@chromium.org

2009-07-27 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Removing a no-op block of code in DatabaseTracker.cpp that
should've been removed in the patch for bug 26054.

https://bugs.webkit.org/show_bug.cgi?id=27666

All tests in WebCore/storage pass.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): Removed a no-op block of code that was moved to SQLiteFileSystem.cpp and should have been removed from DatabaseTracker.cpp
10:45 Changeset [46419] by jianli@chromium.org

WebCore:

2009-07-27 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Fix error handling in dedicated worker and worker context.
https://bugs.webkit.org/show_bug.cgi?id=27525

The following problems have been fixed:
1) The uncaught runtime script error is not reported using the
WorkerGlobalScope object's onerror attribute.
2) If the error is still not handled afterwards (onerror attribute
is not defined as a function or it returns true), the error should
be reported back to the associated Worker object by firing an
ErrorEvent.
3) If the error is still not handled by the associated Worker
object, the error should be reported to the user.

Test: fast/workers/worker-script-error.html

  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::reportError):
  • bindings/js/JSEventListener.h:
  • dom/EventListener.h: (WebCore::EventListener::reportError): adds a function to call EventListener as a function with 3 arguments to report an error.
  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::dispatchScriptErrorEvent):
  • workers/AbstractWorker.h:
  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::reportException):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::reportException):
  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerExceptionTask::performTask):
  • workers/WorkerMessagingProxy.h:

LayoutTests:

2009-07-27 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Layout tests for fixing error handling in dedicated worker and worker
context.
https://bugs.webkit.org/show_bug.cgi?id=27525

  • fast/workers/resources/worker-error-in-handling-script-error.js: Added
  • fast/workers/resources/worker-invalid-syntax.js: Added.
  • fast/workers/resources/worker-script-error-bubbled.js: Added.
  • fast/workers/resources/worker-script-error-handled.js: Added.
  • fast/workers/resources/worker-script-error-unhandled.js: Added.
  • fast/workers/worker-constructor.html:
  • fast/workers/worker-script-error-expected.txt: Added.
  • fast/workers/worker-script-error.html: Added. Add test cases to cover different script error handling scenarios.
10:04 Changeset [46418] by zimmermann@webkit.org

[WML] History handling / page cache / loading is buggy and depends on several hacks
https://bugs.webkit.org/show_bug.cgi?id=27707

Redesign WML history/loading handling. See ChangeLog for details.

08:09 Changeset [46417] by pfeldman@chromium.org

2009-07-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Adam Roben.

Fix Chromium build breakage introduced in 46388.

https://bugs.webkit.org/show_bug.cgi?id=27705

  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::description):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h:
06:41 Changeset [46416] by hausmann@webkit.org

2009-07-27 Gabor Rapcsanyi <rapcsanyi.gabor@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Generating remote links causes a lot of unnecessary spew on Qt build bot too

  • Scripts/run-webkit-tests:
04:34 Changeset [46415] by hausmann@webkit.org

2009-07-27 Volker Hilsheimer <volker.hilsheimer@nokia.com>

Reviewed by Simon Hausmann.

QWebView's "enabled" parameter should default to true, as with QGraphicsView and
QPainter.

  • Api/qwebview.cpp: Add reference to QPainter::renderHints().
  • Api/qwebview.h: Add default for enabled argument.
04:29 Changeset [46414] by vestbo@webkit.org

2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Add some more debug logging to PluginViewMac.

  • plugins/mac/PluginViewMac.cpp:
04:27 Changeset [46413] by vestbo@webkit.org

2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Jan Michael Alonzo.

Remove dead code from the GTK NPAPI implementation.

  • plugins/gtk/PluginViewGtk.cpp:
04:06 Changeset [46412] by jmalonzo@webkit.org

2009-07-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Add fast/canvas/image-pattern-rotate.html to Skipped as it needs
platform-specific expected results.

  • platform/gtk/Skipped:
03:39 Changeset [46411] by hausmann@webkit.org

2009-07-27 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Buildfix on Windows.
https://bugs.webkit.org/show_bug.cgi?id=27702

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::hookedEndPaint):

Constraint of (*endPaint) operand modified from "g" to "m" (memory) in inline
assembly, because with "g" constraint, wrong assembly code generated.

02:06 Changeset [46410] by pfeldman@chromium.org

2009-07-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebCore bindings: Implement ScriptArray bindings.

https://bugs.webkit.org/show_bug.cgi?id=27691

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptArray.cpp: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::handleException): (WebCore::ScriptArray::set): (WebCore::length): (WebCore::ScriptArray::createNew):
  • bindings/js/ScriptArray.h: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::jsArray):
  • bindings/v8/ScriptArray.cpp: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::set): (WebCore::ScriptArray::length): (WebCore::ScriptArray::createNew):
  • bindings/v8/ScriptArray.h: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::~ScriptArray):
00:17 Changeset [46409] by bfulgham@webkit.org

2009-07-27 Brent Fulgham <bfulgham@webkit.org>

Build correct, no review.

Change in r46407 broke Apple Windows build.
Switch to WinCairo-only test, to avoid any
other platform break.

  • WebCorePrefix.h:
00:02 Changeset [46408] by bfulgham@webkit.org

2009-07-26 Brent Fulgham <bfulgham@webkit.org>

Build correct, no review.

Change in r46407 broke Apple Windows build.

  • WebCorePrefix.h: Use WTF_PLATFORM_CG to decide if CoreServices.h should be included.

07/26/09:

23:39 Changeset [46407] by bfulgham@webkit.org

2009-07-26 Brent Fulgham <bfulgham@webkit.org>

Build correction, no review.

Change in r46195 broke WinCairo build.

  • WebCorePrefix.h: CoreServices should be ignored for non-Apple build.
12:47 Changeset [46406] by hausmann@webkit.org

2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

More documentation cleanups in the QWebElement class overview.

  • Api/qwebelement.cpp:
12:47 Changeset [46405] by hausmann@webkit.org

2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

Clean up documentation of QWebElement's findFirst and findAll functions,
as well as their QWebFrame counterparts.

  • Api/qwebelement.cpp:
  • Api/qwebframe.cpp:
12:47 Changeset [46404] by hausmann@webkit.org

2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

Various documentation cleanups

  • Fixed qdoc warnings
  • Hide QWebNetworkInterface from the class overview
  • Mention QWebElement in the module overview
  • More cleanups
  • Api/qwebframe.cpp:
  • Api/qwebnetworkinterface.cpp:
  • Api/qwebview.cpp:
  • docs/qtwebkit.qdoc:
12:47 Changeset [46403] by hausmann@webkit.org

2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

Added missing class diagram referenced from the docs, taken from the Qt
documentation.

  • docs/qtwebkit.qdocconf: Register the image directory with qdoc.
  • docs/qwebview-diagram.png: Added.
08:36 Changeset [46402] by pfeldman@chromium.org

2009-07-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement the breakpoints sidebar pane.
This change adds simple UI support into the existing
BreakpointSidebarPane.

https://bugs.webkit.org/show_bug.cgi?id=11175

  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set enabled): (WebInspector.Breakpoint.prototype.get label): (WebInspector.Breakpoint.prototype.get id):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane): (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.labelClicked): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.scriptOrResourceForID):
  • inspector/front-end/inspector.css:

07/25/09:

15:14 Changeset [46401] by abarth@webkit.org

2009-07-25 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Eric Seidel.

Allow custom memory allocation control for OpaqueJSPropertyNameArray struct
https://bugs.webkit.org/show_bug.cgi?id=27342

Inherits OpaqueJSPropertyNameArray struct from FastAllocBase because it has been
instantiated by 'new' JavaScriptCore/API/JSObjectRef.cpp:473.

  • API/JSObjectRef.cpp:
15:11 Changeset [46400] by abarth@webkit.org

Fixup ChangeLog.

15:00 Changeset [46399] by abarth@webkit.org

2009-07-16 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Oliver Hunt.

Canvas: rotation of 'no-repeat' pattern still has small error
https://bugs.webkit.org/show_bug.cgi?id=26749

Use (1<<23)/2 as steps of no-repeat pattern to make the error less
than 0.5. The previous value may cause 1 pixel errors.

Add another test to show this bug clearly.
Also add png expected image which was missing in the previous patch.

  • fast/canvas/image-pattern-rotate.html: Added.
  • platform/mac/fast/canvas/image-object-in-canvas-expected.checksum:
  • platform/mac/fast/canvas/image-object-in-canvas-expected.png:
  • platform/mac/fast/canvas/image-pattern-rotate-expected.checksum: Added.
  • platform/mac/fast/canvas/image-pattern-rotate-expected.png: Added.
  • platform/mac/fast/canvas/image-pattern-rotate-expected.txt: Added.

2009-07-16 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Oliver Hunt.

Canvas: rotation of 'no-repeat' pattern still has small error
https://bugs.webkit.org/show_bug.cgi?id=26749

Use (1<<23)/2 as steps of no-repeat pattern to make the error less
than 0.5. The previous value may cause 1 pixel errors.

Add another test to show this bug clearly.
Also add png expected image which was missing in the previous patch.

Test: fast/canvas/image-pattern-rotate.html

  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
14:36 Changeset [46398] by abarth@webkit.org

2009-07-25 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Windows build break due to warning C4819
https://bugs.webkit.org/show_bug.cgi?id=27416

Disable C4819 warning to fix build.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCore.vcproj:

2009-07-25 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Windows build break due to warning C4819
https://bugs.webkit.org/show_bug.cgi?id=27416

Disable C4819 warning to fix build.

  • WebKit.vcproj/WebKit.vcproj:

2009-07-25 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Windows build break due to warning C4819
https://bugs.webkit.org/show_bug.cgi?id=27416

Disable C4819 warning to fix build.

  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
14:34 Changeset [46397] by abarth@webkit.org

2009-07-25 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Kevin McCullough.

Inspector: Keyboard Shortcuts to Switch Panels
https://bugs.webkit.org/show_bug.cgi?id=27286

  • inspector/front-end/inspector.js: (WebInspector.loaded): save a list of the order of the panels (WebInspector.documentKeyDown): handle the keyboard shortcuts to traverse the panels
14:29 Changeset [46396] by abarth@webkit.org

2009-07-25 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by George Staikos.

[Qt] Fix build break after r46369
https://bugs.webkit.org/show_bug.cgi?id=27680

  • WebCore.pro:
09:43 Changeset [46395] by zimmermann@webkit.org

2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Variable substitution is buggy
https://bugs.webkit.org/show_bug.cgi?id=27677

Substitute variables upon attach() time instead of insertedIntoDocument(). Otherwhise variable substitution
won't work during inter-deck jumps (same URL, different fragment). Covered by new test fast/wml/newcontext-same-deck.html.

  • dom/Text.cpp: (WebCore::Text::attach):
  • dom/Text.h:

2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Variable substitution is buggy
https://bugs.webkit.org/show_bug.cgi?id=27677

Always substitute variables regardless of their existance. If a variable doesn't exist, expand it to an empty string.
Correct several testcases, relying on the old buggy behaviour.

  • wml/newcontext-same-deck-expected.txt: Added.
  • wml/newcontext-same-deck.html: Added.
  • wml/resources/WMLTestCase.js: (createWMLTestCase.iframeElement.onload): (createWMLTestCase): (assureLayout): (startTest): (triggerMouseEvent):
  • wml/resources/newcontext-same-deck.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/newcontext-same-deck.wml: Added.
  • wml/resources/select-element-variables.js: (prepareTest):
  • wml/select-element-variables-expected.txt:
  • wml/variable-reference-invalid-character-expected.txt:
09:35 Changeset [46394] by zimmermann@webkit.org

2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] WMLDoElement doesn't update its RenderButton object upon attach()
https://bugs.webkit.org/show_bug.cgi?id=27676

WMLDoElement needs to implement attach() and call updateFromElement() on its associated RenderButton.
Mimics HTMLButtonElement/HTMLFormControlElement behaviour and fixes several painting/styling issues covered by existing tests in fast/wml.

  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::attach):
  • wml/WMLDoElement.h:

2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] WMLDoElement doesn't update its RenderButton object upon attach()
https://bugs.webkit.org/show_bug.cgi?id=27676

Update layout test results after fixing WMLDoElement::attach() not calling updateFromElement().

  • platform/mac/fast/wml/do-element-optional-attr-expected.txt:
  • platform/mac/fast/wml/do-shadow-expected.txt:
  • platform/mac/fast/wml/do-template-expected.txt:
  • platform/mac/fast/wml/err-invalid-location-for-varref-expected.txt:
  • platform/mac/fast/wml/err-invalid-variable-name-expected.txt:
  • platform/mac/fast/wml/err-samename-do-expected.txt:
09:23 Changeset [46393] by zimmermann@webkit.org

2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Make http/tests/wml/post-data-to-server.* more understable
https://bugs.webkit.org/show_bug.cgi?id=27675

Slightly cleanup this patch so it's easier to figure out what the expected result for <select> element is.

  • http/tests/wml/post-data-to-server-expected.txt:
  • http/tests/wml/resources/post-data-to-server.js: (setupTestDocument): (prepareTest):
02:51 Changeset [46392] by pfeldman@chromium.org

2009-07-25 Pavel Feldman <pfeldman@chromium.org>

Fix Windows build breakage introduced in 46390.

  • WebCore.vcproj/WebCore.vcproj:
02:44 Changeset [46391] by oliver@apple.com

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Oliver Hunt.

Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update): use the displaySort when showing properties (WebInspector.ObjectPropertiesSection.prototype._displaySort): alphaNumerical sort (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): use the displaySort when showing properties
  • inspector/front-end/utilities.js: (Object.sortedProperties): allow for an optional sorting function in Object.sortedProperties
02:22 Changeset [46390] by pfeldman@chromium.org

2009-07-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Split InspectorController into InspectorController
and InspectorBackend. Everything frontend needs from InspectorController
will slowly migrate into the InspectorBackend.

https://bugs.webkit.org/show_bug.cgi?id=27541

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSInspectorBackendCustom.cpp: Added. (WebCore::JSInspectorBackend::highlightDOMNode): (WebCore::JSInspectorBackend::search): (WebCore::JSInspectorBackend::databaseTableNames): (WebCore::JSInspectorBackend::inspectedWindow): (WebCore::JSInspectorBackend::setting): (WebCore::JSInspectorBackend::setSetting): (WebCore::JSInspectorBackend::wrapCallback): (WebCore::JSInspectorBackend::currentCallFrame): (WebCore::JSInspectorBackend::profiles):
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/js/JSInspectorControllerCustom.cpp: Removed.
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/js/ScriptObject.h:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/v8/ScriptObject.h:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8InspectorControllerCustom.cpp: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::windowScriptObjectAvailable):
  • inspector/InspectorController.h: (WebCore::InspectorController::inspectorBackend):
  • inspector/InspectorBackend.cpp: Added.
  • inspector/InspectorBackend.h: Added. (WebCore::InspectorBackend::create): (WebCore::InspectorBackend::inspectorController):
  • inspector/InspectorBackend.idl: Added.
  • inspector/InspectorController.idl: Removed.
  • inspector/front-end/Resource.js:
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h:
00:47 Changeset [46389] by abarth@webkit.org

2009-07-25 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by George Staikos.

Update WebCore/page/Frame.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27654

  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::setDocument): (WebCore::Frame::firstRectForRange): (WebCore::createRegExpForLabels): (WebCore::Frame::searchForLabelsBeforeElement): (WebCore::Frame::matchLabelsAgainstElement): (WebCore::Frame::selectionLayoutChanged): (WebCore::Frame::setZoomFactor): (WebCore::Frame::reapplyStyles): (WebCore::Frame::isContentEditable): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::selectionStartStylePropertyValue): (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::applyEditingStyleToBodyElement): (WebCore::Frame::removeEditingStyleFromBodyElement): (WebCore::Frame::applyEditingStyleToElement): (WebCore::Frame::selectionBounds): (WebCore::Frame::currentForm): (WebCore::Frame::revealSelection): (WebCore::Frame::styleForSelectionStart): (WebCore::Frame::setSelectionFromNone): (WebCore::Frame::findString): (WebCore::Frame::markAllMatchesForText): (WebCore::Frame::setMarkedTextMatchesAreHighlighted): (WebCore::Frame::clearFormerDOMWindow): (WebCore::Frame::unfocusWindow): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::documentAtPoint):
  • page/Frame.h: (WebCore::Frame::create): (WebCore::Frame::displayStringModifiedByEncoding): (WebCore::Frame::pageZoomFactor): (WebCore::Frame::textZoomFactor):

07/24/09:

20:50 Changeset [46388] by mitz@apple.com

Reviewed by Darin Adler.

Add functions to print the glyph page trees for debugging
https://bugs.webkit.org/show_bug.cgi?id=27671

  • platform/graphics/FontData.h: Defined a description() method.
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::showSubtree): Added. Prints the node and

its descendants.

(showGlyphPageTrees): Added. Prints all glyph page trees.
(showGlyphPageTree): Added. Prints the glyph page tree for a given page.

  • platform/graphics/GlyphPageTreeNode.h:
  • platform/graphics/SegmentedFontData.cpp: (WebCore::SegmentedFontData::description): Added.
  • platform/graphics/SegmentedFontData.h:
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::description): Added. Uses the platform data

as the description for non-svg, non-custom fonts.

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/gtk/FontPlatformData.h:
  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/mac/FontPlatformData.h:
  • platform/graphics/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::description): Added. Returns the

description of the CGFont, the size and the synthetic style flags,
if set.

  • platform/graphics/qt/FontPlatformData.h:
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/win/FontPlatformData.h:
  • platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/wince/FontPlatformData.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/wince/FontPlatformData.h:
  • platform/graphics/wx/FontPlatformData.h:
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
18:49 Changeset [46387] by adachan@apple.com

In preparation for https://bugs.webkit.org/show_bug.cgi?id=27236:
Remove TCMALLOC_TRACK_DECOMMITED_SPANS. We'll always track decommitted spans.
We have tested this and show it has little impact on performance.

Reviewed by Mark Rowe.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::New): (WTF::TCMalloc_PageHeap::AllocLarge): (WTF::propagateDecommittedState): (WTF::mergeDecommittedStates): (WTF::TCMalloc_PageHeap::Delete): (WTF::TCMalloc_PageHeap::IncrementalScavenge):
18:13 Changeset [46386] by zimmermann@webkit.org

Not reviewed. Add Kevin McCullough as reviewer in bugzilla.py

17:57 Changeset [46385] by darin@apple.com

Dorument?

17:56 Changeset [46384] by darin@apple.com

2009-07-24 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

REGRESSION (r46298): Exception after clicking on Bookmarks button in the Bookmarks Bar
https://bugs.webkit.org/show_bug.cgi?id=27667

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Moved the code to set the title here. This is late enough that both the view and representation exist.
  • WebView/WebDataSource.mm: (-[WebDataSource _makeRepresentation]): Removed the code to set the title from here. It's a bit too early.
16:46 Changeset [46383] by abarth@webkit.org

2009-07-24 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

SVG and XPath memory leaks in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=27488

Add proper 'create' methods to SVGPodTypeWrappers and
XPathNSResolvers in the V8 bindings to avoid memory leaks.

Introduce convertToV8Object methods that accept PassRefPtrs and
clean up the use of get() and release() on RefPtrs.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object):
  • bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::V8SVGPODTypeWrapperCreatorForList::create): (WebCore::V8SVGPODTypeWrapperCreatorForList::V8SVGPODTypeWrapperCreatorForList): (WebCore::V8SVGStaticPODTypeWrapper::create): (WebCore::V8SVGStaticPODTypeWrapper::V8SVGStaticPODTypeWrapper): (WebCore::V8SVGStaticPODTypeWrapperWithPODTypeParent::create): (WebCore::V8SVGStaticPODTypeWrapperWithPODTypeParent::V8SVGStaticPODTypeWrapperWithPODTypeParent): (WebCore::V8SVGStaticPODTypeWrapperWithParent::create): (WebCore::V8SVGStaticPODTypeWrapperWithParent::V8SVGStaticPODTypeWrapperWithParent): (WebCore::V8SVGDynamicPODTypeWrapper::create): (WebCore::V8SVGDynamicPODTypeWrapper::V8SVGDynamicPODTypeWrapper): (WebCore::V8SVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ClientRectListCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER):
  • bindings/v8/custom/V8CustomXPathNSResolver.cpp: (WebCore::V8CustomXPathNSResolver::create):
  • bindings/v8/custom/V8CustomXPathNSResolver.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER):
  • bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
16:35 Changeset [46382] by mrowe@apple.com

Skip a test that is failing intermittently on the Windows build bot.

  • platform/win/Skipped:
16:26 Changeset [46381] by mrowe@apple.com

Skip a plug-in test that fails an assertion around 50% of the time.

  • platform/mac-snowleopard/Skipped:
16:02 Changeset [46380] by mrowe@apple.com

Skip two SVG tests that are giving unexpected results.

  • platform/mac-snowleopard/Skipped:
15:45 UsingGitWithWebKit edited by treat@kde.org
(diff)
15:45 Changeset [46379] by mrowe@apple.com

Skip two plug-in tests that are failing.

  • platform/mac-snowleopard/Skipped:
15:31 BuildingQtOnWindows edited by jpetso@gmx.at
Fix inconsistent instruction vs. corresponding explanation (paths were … (diff)
15:28 BuildingQtOnWindows edited by jpetso@gmx.at
I followed the guidelines here, and it seems make isn't shipped by Qt so … (diff)
15:20 Changeset [46378] by mrowe@apple.com

Land correct results for a SnowLeopard-only accessibility test.

  • platform/mac/accessibility/table-multi-bodies-expected.txt:
14:57 Changeset [46377] by bweinstein@apple.com

2009-07-24 Brian Weinstein <bweinstein@apple.com>

Reviewed by Jon Honeycutt.

Fix of <rdar://6310538> Middle-click panning should be springloaded while dragging
https://bugs.webkit.org/show_bug.cgi?id=21794

Create two new booleans to determine whether we have done a springloaded pan scroll, and update
the name of setPanScrollCursor to updatePanScrollState to more accurately describe what the function
does.

  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): Initialized two new booleans. (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::updatePanScrollState): Renamed from setPanScrollCursor. (WebCore::EventHandler::stopAutoscrollTimer): Clear the pan scrolling in progress flag. (WebCore::EventHandler::handleMouseReleaseEvent): Clear the pan scrolling button pressed flag.
  • page/EventHandler.h:
14:33 UsingGitWithWebKit edited by eli.fidler@torchmobile.com
(diff)
14:31 Changeset [46376] by dimich@chromium.org

2009-07-24 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Changed WorkerContext destructor to not access possibly-freed WorkerThread.

Failed assertion in WorkerContext::~WorkerContext().
https://bugs.webkit.org/show_bug.cgi?id=27665

  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext):
    • workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Removed assertion that relies on WorkerThread still being alive (moved to DedicatedWorkerContext destructor).
14:18 Changeset [46375] by treat@webkit.org

2009-07-24 Eli Fidler <eli.fidler@torchmobile.com>

Reviewed by Adam Treat.

Improve git workflow by populating commit messages with ChangeLog entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

If the user doesn't manually modify the ChangeLog files, use
prepare-ChangeLog to populate the git commit message. This behaviour
can be disabled by the 'webkitGenerateCommitMessage' git configuration option.

  • Scripts/commit-log-editor:
14:13 Changeset [46374] by treat@webkit.org

2009-07-24 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=27657
Add more wince port files to WebCore

Written by Yong Li <yong.li@torchmobile.com> and Lyon Chen <lyon.chen@torchmobile.com>

  • loader/icon/wince/IconDatabaseWince.cpp: Added.
  • rendering/RenderThemeWince.cpp: Added.
  • rendering/RenderThemeWince.h: Added.
  • storage/wince/DatabaseThreadWince.cpp: Added.
  • storage/wince/DatabaseThreadWince.h: Added.
  • storage/wince/LocalStorageThreadWince.cpp: Added.
  • storage/wince/LocalStorageThreadWince.h: Added.
  • svg/graphics/wince/SVGResourceFilterWince.cpp: Added.
14:12 Changeset [46373] by rniwa@webkit.org

WebCore:

2009-07-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

execCommand('underline') can modify DOM outside of the contentEditable area
https://bugs.webkit.org/show_bug.cgi?id=24333

highestAncestorWithTextDecoration stops at the closest unsplittable element so that if text-decoration is applied
outside of it, we don't accidently modify the style attribute.

Tests: editing/style/textdecoration-outside-of-rooteditable.html

editing/style/textdecoration-outside-of-unsplittable-element.html

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): (WebCore::highestAncestorWithTextDecoration):

LayoutTests:

2009-07-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

execCommand('underline') can modify DOM outside of the contentEditable area
https://bugs.webkit.org/show_bug.cgi?id=24333

Tests to make sure we are not removing underline applied outside of root editable node or unsplittable element.

  • editing/style/textdecoration-outside-of-rooteditable-expected.txt: Added.
  • editing/style/textdecoration-outside-of-rooteditable.html: Added.
  • editing/style/textdecoration-outside-of-unsplittable-element-expected.txt: Added.
  • editing/style/textdecoration-outside-of-unsplittable-element.html: Added.
13:59 Changeset [46372] by abarth@webkit.org

2009-07-24 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27639

Tests that XSSAuditor does not prevent evaluation of scripts that only contain
non-canonical characters.

  • http/tests/security/xssAuditor/script-tag-safe-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-safe.html: Added.

2009-07-24 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27639

Fixes false positives when evaluating certain strings that only contain
non-canonical characters.

Test: http/tests/security/xssAuditor/script-tag-safe.html

  • page/XSSAuditor.cpp: (WebCore::isNonCanonicalCharacter): (WebCore::XSSAuditor::findInRequest):
12:54 Changeset [46371] by dimich@chromium.org

WebCore:

2009-07-24 Drew Wilson <atwilson@google.com>

Reviewed by Adam Barth.

Updated code generator to properly generate bindings for WorkerContext exposed functions.

Storing a reference to WorkerContext.postMessage() and calling it later yields a TypeError
https://bugs.webkit.org/show_bug.cgi?id=27419

Test: fast/workers/worker-call.html

  • bindings/js/JSWorkerContextBase.cpp: (WebCore::toJSDedicatedWorkerContext): (WebCore::toJSWorkerContext): Functions that convert from JSValue to the appropriate WorkerContext/DedicatedWorkerContext object.
  • bindings/js/JSWorkerContextBase.h: Added toJS*WorkerContext APIs.
  • bindings/scripts/CodeGeneratorJS.pm: Added code to appropriately check the passed-in this object when invoking functions at global scope.

LayoutTests:

2009-07-24 Drew Wilson <atwilson@google.com>

Reviewed by Adam Barth.

Added layout tests to exercise various use cases for calling functions defined on Worker global scope.

Storing a reference to WorkerContext.postMessage() and calling it later yields a TypeError
https://bugs.webkit.org/show_bug.cgi?id=27419

  • fast/workers/resources/worker-call.js: Added.
  • fast/workers/worker-call-expected.txt: Added.
  • fast/workers/worker-call.html: Added.
12:28 Changeset [46370] by eric@webkit.org

2009-07-24 Drew Wilson <atwilson@google.com>

Reviewed by Adam Barth.

Refactor WorkerContext to move DedicatedWorker-specific APIs into DedicatedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27420

No new tests as the existing tests already provide sufficient coverage (this is just a refactoring with no new functionality).

  • DerivedSources.cpp: Added JSDerivedWorkerContext.cpp
  • DerivedSources.make: Added DerivedWorkerContext files
  • GNUmakefile.am: Added DerivedWorkerContext files
  • WebCore.gypi: Added DerivedWorkerContext files
  • WebCore.pro: Added DerivedWorkerContext files
  • WebCore.vcproj/WebCore.vcproj: Added DerivedWorkerContext files
  • WebCore.xcodeproj/project.pbxproj: Added DerivedWorkerContext files
  • bindings/js/JSDedicatedWorkerContextCustom.cpp: Added. (WebCore::JSDedicatedWorkerContext::mark): Custom mark function for onmessage event handler.
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): Supports conversion to JSDedicatedWorkerContext. (WebCore::toEventTarget):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark): Moved onmessage mark handling into DedicatedWorkerContext.
  • bindings/js/WorkerScriptController.cpp: Added appropriate casts to DedicatedWorkerContext for postMessage(). (WebCore::WorkerScriptController::initScript): Manually sets up the prototype chain for the worker context.
  • bindings/scripts/CodeGeneratorJS.pm: Changed special case code for WorkerContext to be triggered by new IsWorkerContext attribute.
  • bindings/scripts/CodeGeneratorV8.pm: Changed hard-coded tests for WorkerContext to support DedicatedWorkerContext.
  • bindings/v8/DOMObjectsInclude.h: Added DedicatedWorkerContext.h
  • bindings/v8/DerivedSourcesAllInOne.cpp: Added V8DedicatedWorkerContext.cpp
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Added code to reserve extra fields for V8DedicatedWorkerContext.
  • bindings/v8/V8Index.cpp: Now includes V8DedicatedWorkerContext.h in addition to V8WorkerContext.h
  • bindings/v8/V8Index.h: Added DedicatedWorkerContext as a non-node wrapper type. Removed WORKERCONTEXT as a valid template type.
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Creates DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): Returns DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::retrieve): Refactored to deal with DedicatedWorkerContext.
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: Added. Moved onmessage code from V8WorkerContextCustom.cpp (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: Moved onmessage code to V8DedicatedWorkerContextCustom.cpp
  • dom/EventTarget.cpp: (WebCore::EventTarget::toDedicatedWorkerContext):
  • dom/EventTarget.h:
  • workers/DedicatedWorkerContext.cpp: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::reportException): (WebCore::DedicatedWorkerContext::postMessage): (WebCore::DedicatedWorkerContext::dispatchMessage):
  • workers/DedicatedWorkerContext.h: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::create): (WebCore::DedicatedWorkerContext::toDedicatedWorkerContext): (WebCore::DedicatedWorkerContext::setOnmessage): (WebCore::DedicatedWorkerContext::onmessage):
  • workers/DedicatedWorkerContext.idl: Added.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Moved code that notifies parent that worker is closing down into DedicatedWorkerContext.
  • workers/WorkerContext.h: (WebCore::WorkerContext::isClosing): Exposed closing flag as an API so derived classes can access it.
  • workers/WorkerContext.idl:
  • workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): Calls into DedicatedWorkerContext to handle message.
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Creates a DedicatedWorkerContext when the thread starts up.
12:23 Changeset [46369] by dimich@chromium.org

2009-07-24 Drew Wilson <atwilson@google.com>

Reviewed by Adam Barth.

Refactor WorkerContext to move DedicatedWorker-specific APIs into DedicatedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27420

No new tests as the existing tests already provide sufficient coverage (this is just a refactoring with no new functionality).

  • DerivedSources.cpp: Added JSDerivedWorkerContext.cpp
  • DerivedSources.make: Added DerivedWorkerContext files
  • GNUmakefile.am: Added DerivedWorkerContext files
  • WebCore.gypi: Added DerivedWorkerContext files
  • WebCore.pro: Added DerivedWorkerContext files
  • WebCore.vcproj/WebCore.vcproj: Added DerivedWorkerContext files
  • WebCore.xcodeproj/project.pbxproj: Added DerivedWorkerContext files
  • bindings/js/JSDedicatedWorkerContextCustom.cpp: Added. (WebCore::JSDedicatedWorkerContext::mark): Custom mark function for onmessage event handler.
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): Supports conversion to JSDedicatedWorkerContext. (WebCore::toEventTarget):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark): Moved onmessage mark handling into DedicatedWorkerContext.
  • bindings/js/WorkerScriptController.cpp: Added appropriate casts to DedicatedWorkerContext for postMessage(). (WebCore::WorkerScriptController::initScript): Manually sets up the prototype chain for the worker context.
  • bindings/scripts/CodeGeneratorJS.pm: Changed special case code for WorkerContext to be triggered by new IsWorkerContext attribute.
  • bindings/scripts/CodeGeneratorV8.pm: Changed hard-coded tests for WorkerContext to support DedicatedWorkerContext.
  • bindings/v8/DOMObjectsInclude.h: Added DedicatedWorkerContext.h
  • bindings/v8/DerivedSourcesAllInOne.cpp: Added V8DedicatedWorkerContext.cpp
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Added code to reserve extra fields for V8DedicatedWorkerContext.
  • bindings/v8/V8Index.cpp: Now includes V8DedicatedWorkerContext.h in addition to V8WorkerContext.h
  • bindings/v8/V8Index.h: Added DedicatedWorkerContext as a non-node wrapper type. Removed WORKERCONTEXT as a valid template type.
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Creates DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): Returns DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::retrieve): Refactored to deal with DedicatedWorkerContext.
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: Added. Moved onmessage code from V8WorkerContextCustom.cpp (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: Moved onmessage code to V8DedicatedWorkerContextCustom.cpp
  • dom/EventTarget.cpp: (WebCore::EventTarget::toDedicatedWorkerContext):
  • dom/EventTarget.h:
  • workers/DedicatedWorkerContext.cpp: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::reportException): (WebCore::DedicatedWorkerContext::postMessage): (WebCore::DedicatedWorkerContext::dispatchMessage):
  • workers/DedicatedWorkerContext.h: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::create): (WebCore::DedicatedWorkerContext::toDedicatedWorkerContext): (WebCore::DedicatedWorkerContext::setOnmessage): (WebCore::DedicatedWorkerContext::onmessage):
  • workers/DedicatedWorkerContext.idl: Added.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Moved code that notifies parent that worker is closing down into DedicatedWorkerContext.
  • workers/WorkerContext.h: (WebCore::WorkerContext::isClosing): Exposed closing flag as an API so derived classes can access it.
  • workers/WorkerContext.idl:
  • workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): Calls into DedicatedWorkerContext to handle message.
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Creates a DedicatedWorkerContext when the thread starts up.
12:01 Changeset [46368] by eric@webkit.org

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix the last of the x-frame constructor calls to have the right prototype chains
https://bugs.webkit.org/show_bug.cgi?id=27645

I also had to add support for passing arguments to constructors
in order to test the Worker constructor.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/resources/constructed-objects-prototypes.js:

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix the last of the x-frame constructor calls to have the right prototype chains
https://bugs.webkit.org/show_bug.cgi?id=27645

Fix the last few constructors to use their stored globalObject pointer when
constructing objects instead of the lexicalGlobalObject().

  • bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
  • bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::construct):
  • bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
  • bindings/js/JSWebKitPointConstructor.cpp: (WebCore::constructWebKitPoint):
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
11:05 Changeset [46367] by kenneth@webkit.org

2009-07-24 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Adam Treat.

As per discussion on IRC, changed originalUrl by requestedUrl.

  • Api/qwebframe.cpp: (QWebFrame::requestedUrl):
  • Api/qwebframe.h:
  • tests/qwebframe/tst_qwebframe.cpp:
10:57 Changeset [46366] by kenneth@webkit.org

2009-07-24 Andre Pedralho <andre.pedralho@openbossa.org>

Reviewed by Adam Treat.

Removed void QWebFrame::renderContents(...) and added the Q_PROPERTY
clipRenderToViewport to control whether QWebFrame::render would call
FrameView::paintContents rather than FrameView::paint and do not clip
the frame content to viewport.
https://bugs.webkit.org/show_bug.cgi?id=26352

  • Api/qwebframe.cpp: (QWebFramePrivate::renderPrivate): (QWebFrame::clipRenderToViewport): (QWebFrame::setClipRenderToViewport):
  • Api/qwebframe.h:
  • Api/qwebframe_p.h: (QWebFramePrivate::QWebFramePrivate):
  • tests/qwebframe/tst_qwebframe.cpp:
10:56 Changeset [46365] by jianli@chromium.org

2009-07-24 Jian Li <jianli@chromium.org>

Reviewed by Adam Barth.

[V8] Cleanup exception handling in worker evaluation code.
https://bugs.webkit.org/show_bug.cgi?id=27282

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::evaluate):
  • bindings/v8/WorkerContextExecutionProxy.h: (WebCore::WorkerContextExecutionState::WorkerContextExecutionState):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): (WebCore::WorkerScriptController::setException):
10:55 Changeset [46364] by kenneth@webkit.org

2009-07-24 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

[QT] Implement originalUrl getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867

  • Api/qwebframe.cpp: (QWebFrame::originalUrl):
  • Api/qwebframe.h:
  • tests/qwebframe/qwebframe.qrc:
  • tests/qwebframe/test1.html: Added.
  • tests/qwebframe/test2.html: Added.
  • tests/qwebframe/tst_qwebframe.cpp:
10:44 Changeset [46363] by darin@chromium.org

2009-07-24 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

Reverting r46157, since it may be causing problems with Chromium
reliability (see http://crbug.com/17569).

https://bugs.webkit.org/show_bug.cgi?id=27388

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
10:39 Changeset [46362] by abarth@webkit.org

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

REGRESSION: inspector seems broken in ToT WebKit
https://bugs.webkit.org/show_bug.cgi?id=27646

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled):
10:34 Changeset [46361] by mitz@apple.com

Reviewed by Anders Carlsson.

Add the shadow style member to the ShadowData constructor and ==
operator

  • rendering/style/ShadowData.cpp: (WebCore::ShadowData::ShadowData): (WebCore::ShadowData::operator==):
10:30 Changeset [46360] by jianli@chromium.org

2009-07-24 Jian Li <jianli@chromium.org>

Reviewed by Eric Seidel.

[V8] More V8 bindings changes to use ErrorEvent.
https://bugs.webkit.org/show_bug.cgi?id=27630

  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object):
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
10:26 EFLWebKit edited by tonikitoo@gmail.com
(diff)
09:53 Changeset [46359] by bfulgham@webkit.org

WebCore:

2009-07-24 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Dave Hyatt.

Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.

  • platform/graphics/win/SimpleFontDataWin.cpp: Conditionalize references to ApplicationServices.h and WebKitSystemInterface.h

WebKit/win:

2009-07-24 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Dave Hyatt.

Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.

  • DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
  • WebDownload.h: Conditionalize include of CFNetwork.h
  • WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h
09:28 Changeset [46358] by mitz@apple.com

Another attempted build fix

  • bindings/js/JSAbstractWorkerCustom.cpp:
09:28 Changeset [46357] by levin@chromium.org

2009-07-24 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

cpplint crash when there is a duplicate header followed by another header.
https://bugs.webkit.org/show_bug.cgi?id=27625

  • Scripts/modules/cpplint.py: Ensure that include_state.header_types is updated even there is a duplicate header, which resulted in some code rearrangement. Also, changed some if's in this function to return early. This avoids having nearly the whole function content being indented.
  • Scripts/modules/cpplint_unittest.py: Added a test which would have exposed the crash.
09:27 Changeset [46356] by mitz@apple.com

Build fix.

  • bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::toJS):
08:37 Changeset [46355] by treat@webkit.org

2009-07-24 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Filetype support changes for cpplint and check_webkit_style
https://bugs.webkit.org/show_bug.cgi?id=27653

Introduce .c support for check_webkit_style, and remove support for
.cc files in favor of .cpp.

  • Scripts/check-webkit-style:
  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
07:26 Changeset [46354] by xan@webkit.org

2009-07-24 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Remove unneeded commas from PKG_CHECK_MODULES.

  • configure.ac:
06:44 Changeset [46353] by kenneth@webkit.org

2009-07-24 Kenneth Rohde Christiansen <kenneth@webkit.org>

Build fix for 64 bit Linux.

int64_t is long on Linux 64 bit and not long long, thus
getFileSize with a int64_t out value fails to build.

Use a temporary to work around the problem.

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::spaceNeeded):
06:44 Changeset [46352] by kenneth@webkit.org

2009-07-24 Kenneth Rohde Christiansen <kenneth@webkit.org>

Build fix for Qt.

Fix build issue introduced in 46344
([Bug 22700] ApplicationCache should have size limit)

Remove method only added to the Qt ChromeClient.

  • WebCoreSupport/ChromeClientQt.h:
05:55 Changeset [46351] by jmalonzo@webkit.org

2009-07-24 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

ApplicationCache Layout test failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=27648

Add http/tests/appcache/max-size.html to the Skipped file for now.

  • platform/gtk/Skipped:
05:37 BuildingQtOnWindows edited by mails2jaffar@hotmail.com
(diff)
05:31 Changeset [46350] by xan@webkit.org

2009-07-24 Priit Laes <plaes@plaes.org>

Reviewed by Xan Lopez.

[Gtk] Password is saved into gnome-keyring even if auth. fails
https://bugs.webkit.org/show_bug.cgi?id=27560

Check authentication result and save password only when authentication
succeeds.

  • webkit/webkitsoupauthdialog.c: (free_authData): (response_callback): (save_password_callback):
03:50 Changeset [46349] by levin@chromium.org

2009-07-24 Eli Fidler <eli.fidler@torchmobile.com>

Reviewed by David Levin.

Improve git workflow by populating commit messages with ChangeLog entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

add --[no-]write prepare-ChangeLog options to bash completion

  • Scripts/webkit-tools-completion.sh:
03:03 Changeset [46348] by eric@webkit.org

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Update all CREATE_DOM_*_WRAPPER callers to pass globalObject
https://bugs.webkit.org/show_bug.cgi?id=27644

Make a bunch more tests pass. Still not all of them.
The rest will pass when the last bits of bug 27634 land.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Update all CREATE_DOM_*_WRAPPER callers to pass globalObject
https://bugs.webkit.org/show_bug.cgi?id=27644

This is another attempt at making the change for bug 27634 smaller.
I included the changes to make_names.pl as well as any file which
used CREATE_DOM_*_WRAPPER macros.

The changes to the construct* functions are what fix the cases in
fast/dom/constructed-objects-prototypes.html

The changes to passing globalObject through CREATE_* are what fix
fast/dom/prototype-inheritance-2.html

  • bindings/js/JSCDATASectionCustom.cpp: (WebCore::toJSNewlyCreated): pass globalObject.
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSDOMBinding.h: updated macros to pass globalObject.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttributeNode): use globalObject() for wrapping return value. (WebCore::JSElement::setAttributeNodeNS): use globalObject() for wrapping return value. (WebCore::toJSNewlyCreated): pass globalObject.
  • bindings/js/JSEventCustom.cpp: (WebCore::JSEvent::clipboardData): pass globalObject. (WebCore::toJS): pass globalObject.
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::getNamedItems): use globalObject() for wrapping returned collection items. (WebCore::callHTMLCollection): use globalObject() for wrapping returned collection items. (WebCore::JSHTMLCollection::item): use globalObject() for wrapping returned collection items. (WebCore::toJS): pass globalObject.
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapper): pass globalObject.
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSTextCustom.cpp: (WebCore::toJSNewlyCreated): pass globalObject.
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::constructWebKitCSSMatrix): use constructors globalObject when constructing
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): use constructors globalObject when constructing
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::constructXSLTProcessor): use constructors globalObject when constructing
  • dom/make_names.pl:

Pass globalObject through CREATE_* macros and various support functions.

02:50 Changeset [46347] by abarth@webkit.org

2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Darin Adler and Adam Barth.

Build fix for x86 platforms.
https://bugs.webkit.org/show_bug.cgi?id=27602

  • jit/JIT.cpp:
02:15 Changeset [46346] by eric@webkit.org

2009-07-24 Andrei Popescu <andreip@google.com>

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Adds a unit test that ensures that the mechanism that
enforces the maximum size of the application cache is
working correctly.

  • http/tests/appcache/max-size-expected.txt: Added.
  • http/tests/appcache/max-size.html: Added.
  • http/tests/appcache/resources/maxsize.manifest: Added.

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Update CodeGeneratorJS.pm to support passing JSDOMGlobalObject* to toJS calls
https://bugs.webkit.org/show_bug.cgi?id=27643

This is an attempt to make this change as small as possible.
I started by including all changes to CodeGeneratorJS.pm from bug 27634,
and then made the minimal amount of other changes needed to support that change.

Most toJS implementations ignore their passed JSDOMGlobalObject.
There are stub 2-argument toJS, toJSNewlyCreated implementations to help compiling.
All places where it is not clear what we should pass as the global object
(or where the global object is simply not available, like for some SVG bindings)
we pass deprecatedGlobalObjectForPrototype instead.

  • bindings/js/JSCDATASectionCustom.cpp: (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException): pass the wrong globalObject for now
  • bindings/js/JSDOMBinding.h:

Pass the wrong global object to the CREATE_ macros for now.
In the next change we'll come back and pass the correct one.
That will require changes to make_names.pl.

(WebCore::DOMObjectWithGlobalPointer::scriptExecutionContext):
(WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
(WebCore::DOMObjectWithGlobalPointer::~DOMObjectWithGlobalPointer):
(WebCore::createDOMObjectWrapper):
(WebCore::getDOMObjectWrapper):
(WebCore::createDOMNodeWrapper):
(WebCore::getDOMNodeWrapper):
(WebCore::toJS): added to convert 2 arg calls to 3 arg calls to limit the scope of this change.
(WebCore::toJSNewlyCreated):

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::toJS): DOMWindow always uses its own prototype chain.
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSEventTarget.h:
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapper): pass globalObject to toJS(Document*) to avoid recursion (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject* (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::toJS): pass globalObject along
  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::inverse): pass wrong globalObject for now. (WebCore::JSSVGMatrix::rotateFromVector): pass wrong globalObject for now.
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
  • bindings/js/JSSVGPathSegListCustom.cpp:

All of these methods need a globalObject, but most SVG binding don't have
space for one, so we just pass the lexicalGlobalObject for now.

(WebCore::JSSVGPathSegList::initialize):
(WebCore::JSSVGPathSegList::getItem):
(WebCore::JSSVGPathSegList::insertItemBefore):
(WebCore::JSSVGPathSegList::replaceItem):
(WebCore::JSSVGPathSegList::removeItem):
(WebCore::JSSVGPathSegList::appendItem):

  • bindings/js/JSSVGPointListCustom.cpp: (WebCore::finishGetter): pass wrong globalObject for now. (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult):
  • bindings/js/JSSVGTransformListCustom.cpp: (WebCore::finishGetter): pass wrong globalObject for now. (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSTextCustom.cpp: (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
  • bindings/js/JSWorkerContextBase.cpp: (WebCore::toJS): WorkerContext always uses its own prototype chain since it's a GlobalObject subclass.
  • bindings/js/JSWorkerContextBase.h:
  • bindings/scripts/CodeGeneratorJS.pm:

All generated toJS calls now pass a globalObject.
All generated toJS implementations now expect a globalObject.
Simplified all the slot casts by using a "castedThis" local.
SVG bindings which don't have a globalObject() accessor pass the deprecated lexicalGlobalObject instead.
Simplified printing of constructor objects using a $constructorClassName variable.
All generated constructor functions follow the construct$className form to match the custom constructors.

02:14 Changeset [46345] by abarth@webkit.org

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

typing "document.proto" in inspector throws exception
https://bugs.webkit.org/show_bug.cgi?id=27169

  • inspector/front-end/utilities.js: (Object.type):
02:12 Changeset [46344] by abarth@webkit.org

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Adds the WebApplicationCache class that is
used by the DumpRenderTree test application to
configure the Application Cache maximum size.

  • WebCoreSupport/WebApplicationCache.h: Added.
  • WebCoreSupport/WebApplicationCache.mm: Added.
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebKit.exp:

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebCoreSupport/ChromeClientQt.h:

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::reachedMaxAppCacheSize): Adds empty implementation of reachedMaxAppCacheSize.
  • WebCoreSupport/ChromeClientGtk.h:

2009-07-24 Andrei Popescu <andreip@google.com>

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700


Updated the project after adding WebApplicationCache.h/mm

  • WebKit.xcodeproj/project.pbxproj:

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebCoreSupport/WebChromeClient.h:

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700


  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebKitSupport/ChromeClientWx.h:

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

https://lists.webkit.org/pipermail/webkit-dev/2009-May/007560.html

This change implements a mechanism for limiting the maximum size of
the application cache file. When this size is reached, a ChromeClient
callback is invoked asynchronously and the saving of the last (failed)
cache is retried automatically.


This change also extends the ApplicationCacheStorage API by allowing
a client to query or modify the application cache without having to
load any resources into memory.

Test: http/tests/appcache/max-size.html

  • WebCore.base.exp: Exports the symbols required by the DumpRenderTree test application.
  • loader/EmptyClients.h: Adds empty implementation of the new ChromeClient methods.
  • loader/appcache/ApplicationCache.cpp:
  • loader/appcache/ApplicationCache.h: Adds the ability to calculate the approximate size of an ApplicationCache object.
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheGroup.h: Invokes the ChromeClient callback when the storage layer runs out of space. After the callback is invoked, we re-attempt to store the newest cache, in case the ChromeClient has freed some space.
  • loader/appcache/ApplicationCacheResource.cpp:
  • loader/appcache/ApplicationCacheResource.h: Adds the ability to calculate the approximate size of an ApplicationCacheResource object.
  • loader/appcache/ApplicationCacheStorage.cpp:
  • loader/appcache/ApplicationCacheStorage.h: Enforces a maximum size for the application cache file.
  • page/ChromeClient.h: Adds a new callback, invoked when the ApplicationCacheStorage reports that it has reached the maximum size for its database file.
  • platform/sql/SQLiteDatabase.cpp:
  • platform/sql/SQLiteDatabase.h: Adds a new method that allows querying for the amount of unused space inside the application cache database file.

2009-07-24 Andrei Popescu <andreip@google.com>

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Adds a unit test that ensures that the mechanism that
enforces the maximum size of the application cache is
working correctly.

  • http/tests/appcache/max-size-expected.txt: Added.
  • http/tests/appcache/max-size.html: Added.
  • http/tests/appcache/resources/maxsize.manifest: Added.

2009-07-24 Andrei Popescu <andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Adds a new method on the LayoutTestController that
allows a JS unit test to configure the maximum size
of the Application Cache.

  • DumpRenderTree/LayoutTestController.cpp: (setAppCacheMaximumSizeCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAppCacheMaximumSize):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAppCacheMaximumSize):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAppCacheMaximumSize):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAppCacheMaximumSize):
01:42 Changeset [46343] by xan@webkit.org

2009-07-24 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Use TextEncoding facilities to convert between UTF16 and UTF8
instead of rolling our own solution.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (convertUniCharToUTF8):
01:42 Changeset [46342] by xan@webkit.org

2009-07-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Fix confusion in g_substr between length in bytes and length in
characters. Was causing crashes in some situations when dealing
with non-ASCII text encoded as UTF8.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (g_substr):
01:39 Changeset [46341] by abarth@webkit.org

2009-07-24 Adam Barth <abarth@webkit.org>

Rubber stamped by Eric Seidel.

Added andersca to list of reviewers.

  • Scripts/modules/bugzilla.py:
01:33 Changeset [46340] by mrowe@apple.com

Fix dozens of "Deallocation of a pointer not malloced" messages seen while running layout tests on the build bot.

Reviewed by Xan Lopez.

Memory allocated via FastMalloc was being deleted via the system memory allocator
due to an inconsistent including of FastMalloc.h. We address this by including it
from config.h and including config.h from every implementation file, as in our other
projects.

  • DumpRenderTree/ForwardingHeaders/wtf/FastMalloc.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h.
  • DumpRenderTree/config.h:
  • DumpRenderTree/mac/AccessibilityControllerMac.mm:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  • DumpRenderTree/mac/AppleScriptController.m:
  • DumpRenderTree/mac/CheckedMalloc.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
  • DumpRenderTree/mac/DumpRenderTreePasteboard.m:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:
  • DumpRenderTree/mac/EditingDelegate.mm:
  • DumpRenderTree/mac/EventSendingController.mm:
  • DumpRenderTree/mac/FrameLoadDelegate.mm:
  • DumpRenderTree/mac/GCControllerMac.mm:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/mac/NavigationController.m:
  • DumpRenderTree/mac/ObjCController.m:
  • DumpRenderTree/mac/ObjCPlugin.m:
  • DumpRenderTree/mac/ObjCPluginFunction.m:
  • DumpRenderTree/mac/PixelDumpSupportMac.mm:
  • DumpRenderTree/mac/PlainTextController.mm:
  • DumpRenderTree/mac/PolicyDelegate.mm:
  • DumpRenderTree/mac/ResourceLoadDelegate.mm:
  • DumpRenderTree/mac/TextInputController.m:
  • DumpRenderTree/mac/UIDelegate.mm:
  • DumpRenderTree/mac/WorkQueueItemMac.mm:
01:33 Changeset [46339] by abarth@webkit.org

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Impossible to add an attribute to a node without attributes
https://bugs.webkit.org/show_bug.cgi?id=21108

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.set hovered): (WebInspector.ElementsTreeElement.prototype.toggleNewButton): (WebInspector.ElementsTreeElement.prototype.ondblclick): (WebInspector.ElementsTreeElement.prototype._startEditing): (WebInspector.ElementsTreeElement.prototype._addNewAttribute): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
  • inspector/front-end/inspector.css:
01:31 Changeset [46338] by abarth@webkit.org

2009-07-24 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Adds support for Firebug's magic $0 variable to access inspected node
https://bugs.webkit.org/show_bug.cgi?id=17907

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled): Added _inspectorCommandLineAPI.{

_inspectedNodes, _addInspectedNode, $0, $1, $n}

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): Stores the inspected node history

in _inspectorCommandLineAPI._inspectedNodes

(WebInspector.ElementsPanel):

01:22 Changeset [46337] by abarth@webkit.org

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Dragging a resource in the sidebar should drag it's URL
https://bugs.webkit.org/show_bug.cgi?id=14410

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
01:21 Changeset [46336] by abarth@webkit.org

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Double click on a resource in the sidebar should open that resource in Safari
https://bugs.webkit.org/show_bug.cgi?id=14409

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick): open a resource url
01:05 Changeset [46335] by abarth@webkit.org

Revert "2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>"

This reverts commit 6a8ef1983c1dbfaebc636ba70a046d28b12b4aab.

00:59 Changeset [46334] by abarth@webkit.org

2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Darin Adler.

Build fix for x86 platforms.
https://bugs.webkit.org/show_bug.cgi?id=27602

  • jit/JIT.cpp:
00:55 Changeset [46333] by jmalonzo@webkit.org

2009-07-24 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

Bump pango version requirement to 1.12 and remove unnecessary #ifdefs.

  • platform/graphics/gtk/FontGtk.cpp: (WebCore::getDefaultPangoLayout):
  • platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/gtk/Language.cpp:

Bump pango version requirement to 1.12 which is the version that
came with Gtk 2.10.

  • configure.ac:
00:52 Changeset [46332] by abarth@webkit.org

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Missing UIString and other localizedString.js fixes
https://bugs.webkit.org/show_bug.cgi?id=27288

  • English.lproj/localizedStrings.js:
00:51 Changeset [46331] by abarth@webkit.org

2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Should Syntax Highlight JSON
https://bugs.webkit.org/show_bug.cgi?id=27503

  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded):
00:44 Changeset [46330] by abarth@webkit.org

2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/DOMTimer.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27624

  • page/DragController.cpp: (WebCore::DragController::~DragController): (WebCore::documentFragmentFromDragData): (WebCore::DragController::dragEnded): (WebCore::DragController::dragEntered): (WebCore::DragController::dragExited): (WebCore::DragController::dragUpdated): (WebCore::DragController::performDrag): (WebCore::asFileInput): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::delegateDragSourceAction): (WebCore::DragController::concludeEditDrag): (WebCore::DragController::canProcessDrag): (WebCore::DragController::tryDHTMLDrag): (WebCore::DragController::mayStartDragAtEventLocation): (WebCore::getCachedImage): (WebCore::getImage): (WebCore::prepareClipboardForImageDrag): (WebCore::dragLocForDHTMLDrag): (WebCore::DragController::startDrag): (WebCore::DragController::doImageDrag): (WebCore::DragController::doSystemDrag): (WebCore::DragController::placeDragCaret):
00:44 Changeset [46329] by abarth@webkit.org

2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/Chrome.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27608

  • page/Chrome.cpp: (WebCore::Chrome::runBeforeUnloadConfirmPanel): (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::Chrome::shouldInterruptJavaScript): (WebCore::Chrome::setToolTip): (WebCore::Chrome::requestGeolocationPermissionForFrame): (WebCore::ChromeClient::generateReplacementFile): (WebCore::ChromeClient::paintCustomScrollbar):
00:43 Changeset [46328] by abarth@webkit.org

2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/Coordinates.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27614

  • page/Coordinates.cpp: (WebCore::Coordinates::toString):
00:42 Changeset [46327] by abarth@webkit.org

2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/DOMSelection.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27614

  • page/DOMSelection.cpp: (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::modify): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::deleteFromDocument):
  • page/DOMSelection.h:
00:42 Changeset [46326] by eric@webkit.org

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

x-frame constructor calls are instantiated with the wrong prototype chain
https://bugs.webkit.org/show_bug.cgi?id=27566

Add the test. Soon to be fixed by bug 27634.

  • fast/dom/constructed-objects-prototypes-expected.txt: Added.
  • fast/dom/constructed-objects-prototypes.html: Added.
  • fast/dom/resources/constructed-objects-prototypes.js: Added. (classNameForObject): (constructorPropertiesOnWindow):
00:31 Changeset [46325] by mrowe@apple.com

Roll out r46321 as it broke the Windows build.

00:28 Changeset [46324] by abarth@webkit.org

2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/DOMTimer.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27618

  • page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::~DOMTimer): (WebCore::DOMTimer::fired): (WebCore::DOMTimer::suspend): (WebCore::DOMTimer::resume): (WebCore::DOMTimer::canSuspend):
  • page/DOMTimer.h: (WebCore::DOMTimer::minTimerInterval): (WebCore::DOMTimer::setMinTimerInterval):
00:15 Changeset [46323] by mrowe@apple.com

Add a command line option to run-javascriptcore-tests to explicitly opt out of attempting to rebuild JavaScriptCore.

Reviewed by Simon Hausmann.

This is primarily useful to speed up the build bots where one machine builds JavaScriptCore and a second runs the tests,
leading to situations where the build system unnecessarily feels that the need to recompile.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/run-javascriptcore-tests:
00:14 Changeset [46322] by eric@webkit.org

2009-07-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Classes call DOMObject::mark() explicitly, should call DOMObjectWithGlobal::mark() instead
https://bugs.webkit.org/show_bug.cgi?id=27641

Nothing uses globalObject() yet, but this was causing crashes
in the patch for bug 27634. This is covered by fast/dom/gc-6.html.

I decided to change these to Base
instead of DOMObjectWithGlobal:: for future-proofing. All autogenerated classes use a typedef Base
to avoid bugs like these. Sadly C++ does not have a built-in super
we could use.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::JSAbstractWorker::mark):
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::mark):
  • bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::mark):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
  • bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::getOwnPropertySlot):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::mark):
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::mark):
  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::mark):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::mark):
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::mark):
00:04 Changeset [46321] by bfulgham@webkit.org

WebCore:

2009-07-23 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.

  • platform/graphics/win/SimpleFontDataWin.cpp: Conditionalize references to ApplicationServices.h and WebKitSystemInterface.h

WebKit/win:

2009-07-23 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Eric Seidel.

Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.

  • DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
  • WebDownload.h: Conditionalize include of CFNetwork.h
  • WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h
Note: See TracTimeline for information about the timeline view.