Timeline


and

07/31/09:

23:56 Changeset [46664] by abarth@webkit.org

2009-07-31 Daniel Bates <dbates@intudata.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27757

Resolves Perl redefinition warnings about functions tmpfile and tmpnam which are
defined in both File::Temp and POSIX.

This stops the warnings by preventing the "import" method of File::Temp from being called,
which would otherwise add these functions into the primary namespace. Note, "use POSIX"
will import these functions into the primary namespace anyway. We only need one instance
of these functions in our namespace (or we get redefinition warnings), so lets use the
one's in the POSIX package.

  • Scripts/update-webkit-auxiliary-libs: Changed "use File::Temp" to "use File::Temp ()".
  • Scripts/update-webkit-support-libs: ditto
23:43 Changeset [46663] by abarth@webkit.org

2009-07-31 Yong Li <yong.li@torchmobile.com>

Reviewed by Adam Barth.

Fix Geolocation permission problem
https://bugs.webkit.org/show_bug.cgi?id=26993

  • page/Geolocation.cpp: (WebCore::Geolocation::requestPermission):
23:29 Changeset [46662] by abarth@webkit.org

2009-07-31 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Add a top level build option to control datagrid support
https://bugs.webkit.org/show_bug.cgi?id=27915

  • Scripts/build-webkit:
23:09 Changeset [46661] by abarth@webkit.org

2009-07-31 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Eric Seidel.

Added project properties as needed by symbian platform

  • WebCore.pro:
22:26 Changeset [46660] by abarth@webkit.org

2009-07-31 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

Resurrect the old GetTickCount implementation of currentTime, controlled by WTF_USE_QUERY_PERFORMANCE_COUNTER
currentSystemTime taken from older WebKit; currentTime written by Yong Li <yong.li@torchmobile.com>; cleanup by Joe Mason <joe.mason@torchmobile.com>
https://bugs.webkit.org/show_bug.cgi?id=27848

  • wtf/CurrentTime.cpp: (WTF::currentSystemTime): get current time with GetCurrentFT (WTF::currentTime): track msec elapsed since first currentSystemTime call using GetTickCount
  • wtf/Platform.h:
21:07 Changeset [46659] by xan@webkit.org

2009-07-31 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

Fix compiler warning.

Initialize member variables in the correct order.

  • plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
21:07 Changeset [46658] by treat@webkit.org

2009-07-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Holger Hans Peter Freyther.

The reason these four tests fail is a mystery to me right, but placing
them in the Skipped file and the Qt port is... for the first time ever,
finally green!

https://bugs.webkit.org/show_bug.cgi?id=27914

  • platform/qt/Skipped:
20:43 Changeset [46657] by treat@webkit.org

2009-07-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

Printing related test needs to go in Skipped for now so we can
get Qt buildbot green for first time.

https://bugs.webkit.org/show_bug.cgi?id=27913

  • platform/qt/Skipped:
20:43 Changeset [46656] by treat@webkit.org

2009-07-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

Sometimes they pass, sometimes they fail. In attempt to get Qt buildbot
completely green for first time I'm placing these two in the Skipped file.

https://bugs.webkit.org/show_bug.cgi?id=27912

  • platform/qt/Skipped:
20:43 Changeset [46655] by treat@webkit.org

2009-07-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos and Eric Seidel.

Place some audio related tests into the Skipped list in
attempt to get Qt buildbot finally green.

https://bugs.webkit.org/show_bug.cgi?id=27910

  • platform/qt/Skipped:
19:58 Changeset [46654] by jhoneycutt@apple.com

2009-07-31 Jon Honeycutt <jhoneycutt@apple.com>

Windows build fix!

Unreviewed.

  • page/win/PageWin.cpp:
19:38 Changeset [46653] by jhoneycutt@apple.com

2009-07-31 Jon Honeycutt <jhoneycutt@apple.com>

Mac build fix.

Unreviewed.

  • page/Page.cpp: Move setCanStartPlugins() from here...
  • page/win/PageWin.cpp: (WebCore::Page::setCanStartPlugins): ... to here.
19:33 Changeset [46652] by levin@chromium.org

2009-07-31 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

check-webkit-style --git-commit has bugs if you select a commit in the past
https://bugs.webkit.org/show_bug.cgi?id=27908

  • Scripts/check-webkit-style: (main): Made the git-commit command only select the first commit if a range is given (and print a warning).
  • Scripts/modules/scm.py: (SCM::create_patch_from_local_commit): (SCM::create_patch_since_local_commit): (SCM::commit_locally_with_message): (SCM::discard_local_commits): Added an error messages in case these aren't overriden.

(Git::create_patch_since_local_commit):
Added this command to allow doing a diff of everything after a given commit.

18:40 Changeset [46651] by jmalonzo@webkit.org

2009-07-31 Jan Michael Alonzo <jmalonzo@webkit.org>

Speculative Qt build fix. Not reviewed.

Add LayoutTestController::disableImageLoading() in jsobjects.h.

  • DumpRenderTree/qt/jsobjects.h:
18:34 Changeset [46650] by jmalonzo@webkit.org

2009-07-31 Jan Michael Alonzo <jmalonzo@webkit.org>

Skip http/tests/misc/favicon-loads-with-images-disabled.html as
this requires resource load callbacks in Gtk DRT. I've raised bug
#27905 to track this.

  • platform/gtk/Skipped:
18:13 Changeset [46649] by jhoneycutt@apple.com

WebCore:

2009-07-29 Jon Honeycutt <jhoneycutt@apple.com>

<rdar://problem/5698113> Safari shouldn't auto-activate plug-ins in
background tabs (make Win consistent with Mac)

https://bugs.webkit.org/show_bug.cgi?id=27855

Reviewed by Anders Carlsson.

  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::dispatchDidFailToStartPlugin): Declare a new function to dispatch failures to start plug-ins.
  • page/Page.cpp: (WebCore::Page::Page): Initialize new member variable. (WebCore::Page::addUnstartedPlugin): Add the PluginView to the set of unstarted plug-ins. (WebCore::Page::removeUnstartedPlugin): Remove the PluginView from the set of unstarted plug-ins. (WebCore::Page::setCanStartPlugins): If we can now start plug-ins, iterate the set of unstarted plug-ins, starting them. If a plug-in fails to start, dispatch a failed-to-start- plug-in error. Clear the list of unstarted plug-ins.
  • page/Page.h: Added m_canStartPlugins to track whether we can currently start plug-ins. Added m_unstartedPlugins to keep track of plug-ins in the page that are waiting to be started. (WebCore::Page::canStartPlugins):
  • plugins/PluginView.cpp: (WebCore::PluginView::start): m_mimeType is now a WebCore::String, so we call .utf8(). If NPP_New() fails, set m_status to reflect this; this used to be set by init(), but start() will not be called by init() if we are delaying start(). If NPP_New() succeeds, set m_status to reflect this, and call platformStart(). (WebCore::PluginView::startOrAddToUnstartedList): If we cannot start plug-ins, add this view to the Page's list of unstarted plug-ins and return true. Otherwise, call start() and return the result. (WebCore::PluginView::removeFromUnstartedListIfNecessary): If we've been started or we don't have a Page, return early. Remove ourselves from the Page's list of unstarted plug-ins. (WebCore::PluginView::bindingInstance): If we haven't been started yet, return 0. This matches the Mac behavior. (WebCore::PluginView::setParameters): If we find the "plug-ins page" parameter, record it; it may be used if we fail to start the plug-in. (WebCore::PluginView::PluginView): Initialize new members m_haveUpdatedPluginWidget. Initialize m_mimeType with mimeType directly; m_mimeType is now a WebCore::String.
  • plugins/PluginView.h: Made start() public, so Page can call it when we start unstarted plug-ins. Changed m_mimeType from CString to String and added m_pluginsPage; these are needed by dispatchDidFailToStartPlugin(). (WebCore::PluginView::pluginsPage): Added for dispatchDidFailToStartPlugin(). (WebCore::PluginView::mimeType): Ditto. (WebCore::PluginView::url): Ditto.
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart): Stubbed.
  • plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::platformStart): Stubbed.
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::platformStart): Stubbed.
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updatePluginWidget): Use m_haveUpdatedPluginWidget to ensure that we will call MoveWindow() and SetWindowRgn() to position the plug-in and set its clip rect if an earlier call to updatePluginWidget() was made before setPlatformPluginWidget() was called to set the plug-in's HWND. (WebCore::PluginView::~PluginView): Call removeFromUnstartedListIfNecessary() to remove the plug-in from the unstarted list if the plug-in is destroyed before it is started. (WebCore::PluginView::init): Call startOrAddtoUnstartedList to start the plug-in or, if plug-ins cannot be started, to add it to the list of plug-ins waiting to be started. Set m_status to indicate success; this is also set by start(), but that may be delayed, and we don't want the loader to dispatch a failed-to-start-plug-in error when we return from init(). (WebCore::PluginView::platformStart): Added; code moved from init(). This is now called by start() to perform any platform-specific tasks that need to take place after the plug-in has started. Added a call to updatePluginWidget() to ensure we position the plug-in and set its clip rect after the plug-in has started. Removed the setting of m_status; start() does this before calling this function (and we assert this at the head of the function).

WebKit/win:

2009-07-29 Jon Honeycutt <jhoneycutt@apple.com>

Part of <rdar://problem/5698113> Safari shouldn't auto-activate
plug-ins in background tabs (make Win consistent with Mac)

https://bugs.webkit.org/show_bug.cgi?id=27855

Reviewed by Adam Roben and Anders Carlsson.

  • Interfaces/IWebViewPrivate.idl: Add setCanStartPlugins().
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidFailToStartPlugin): Added; code moved from createPlugin(). Modified to obtain the plug-in's page URL, the plug-ins "plug-ins page" parameter value, and the plug-in's MIME type by calling getter functions on the passed PluginView. (WebFrameLoaderClient::createPlugin): If the plug-in status is not "success," call dispatchDidFailToStartPlugin().
  • WebCoreSupport/WebFrameLoaderClient.h: Declare an override of dispatchDidFailToStartPlugin().
  • WebView.cpp: (WebViewWndProc): Add a missing ) to a comment. (WebView::setCanStartPlugins): Call the Page's setCanStartPlugins() function.
  • WebView.h:
17:50 Changeset [46648] by adachan@apple.com

Fixes the Windows release-PGO build.

Reviewed by Jon Honeycutt.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Suppresses the warning about unreachable code that we get by adding "return 0" to WTF::TCMalloc_PageHeap::runScavengerThread().
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::runScavengerThread): Fixes the error about the method not returning a value in the release-PGO build.
17:40 Changeset [46647] by darin@apple.com

WebCore:

2009-07-30 Darin Adler <darin@apple.com>

Reviewed by David Levin.

Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

Next step: Add casts for all the RenderTable classes and use them everywhere.

Also added a few uses in places that were still using static_cast.
Also made some virtual member functions private.
Also changed RenderTable::m_tableLayout to use OwnPtr.

  • accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::isTableExposableThroughAccessibility): (WebCore::AccessibilityTable::addChildren): (WebCore::AccessibilityTable::cellForColumnAndRow):
  • accessibility/AccessibilityTableCell.cpp: (WebCore::AccessibilityTableCell::parentTable): (WebCore::AccessibilityTableCell::rowIndexRange): (WebCore::AccessibilityTableCell::columnIndexRange): (WebCore::AccessibilityTableCell::titleUIElement):
  • accessibility/AccessibilityTableColumn.cpp: (WebCore::AccessibilityTableColumn::headerObject):
  • accessibility/AccessibilityTableRow.cpp: (WebCore::AccessibilityTableRow::parentTable):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode):
  • editing/TextIterator.cpp: (WebCore::shouldEmitTabBeforeNode): (WebCore::shouldEmitNewlinesBeforeAndAfterNode):
  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::parseMappedAttribute):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::parseMappedAttribute):
  • page/Frame.cpp: (WebCore::Frame::searchForLabelsAboveCell):
  • page/mac/FrameMac.mm: (WebCore::Frame::searchForNSLabelsAboveCell):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::shouldScaleColumns):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcPrefWidths):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcPercentageHeight):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addChild): (WebCore::RenderObject::containingBlock):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedBottomBorder):
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::table):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): (WebCore::RenderTableRow::layout): (WebCore::RenderTableRow::paint):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition): (WebCore::RenderTableSection::paintObject): (WebCore::RenderTableSection::recalcCells):
  • rendering/RenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeTextRun): Use checked casts.
  • rendering/RenderTable.cpp: (WebCore::RenderTable::styleDidChange): Updated to use OwnPtr. (WebCore::RenderTable::addChild): Use checked cast. (WebCore::RenderTable::layout): Ditto. (WebCore::RenderTable::setCellWidths): Ditto. (WebCore::RenderTable::paintObject): Ditto. (WebCore::RenderTable::splitColumn): Ditto. (WebCore::RenderTable::appendColumn): Ditto. (WebCore::RenderTable::colElement): Ditto. (WebCore::RenderTable::recalcSections): Ditto. (WebCore::RenderTable::outerBorderBottom): Ditto. (WebCore::RenderTable::outerBorderLeft): Ditto. (WebCore::RenderTable::outerBorderRight): Ditto. (WebCore::RenderTable::sectionAbove): Ditto. (WebCore::RenderTable::sectionBelow): Ditto.
  • rendering/RenderTable.h: Added checked cast. Made virtual functions private. Changed m_tableLayout to be a OwnPtr.
  • rendering/RenderTableCell.h: Added checked cast.
  • rendering/RenderTableCol.h: Ditto. Made virtual functions private.
  • rendering/RenderTableRow.h: Ditto.
  • rendering/RenderTableSection.h: Ditto.

WebKit/mac:

2009-07-30 Darin Adler <darin@apple.com>

Reviewed by David Levin.

Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

  • Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):
  • Misc/WebNSPasteboardExtras.mm: (imageFromElement): (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
  • WebView/WebFrame.mm: (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): (-[WebFrame _accessibilityTree]):
  • WebView/WebRenderNode.mm: (copyRenderNode): Use checked casts.

WebKit/win:

2009-07-30 Darin Adler <darin@apple.com>

Reviewed by David Levin.

Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

  • DOMHTMLClasses.cpp: (DOMHTMLInputElement::isUserEdited): (DOMHTMLTextAreaElement::isUserEdited): Use checked casts.
16:27 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
16:27 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
16:22 Changeset [46646] by beidson@apple.com

WebCore:

2009-07-31 Brady Eidson <beidson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896
Favicons are still loaded when automatic image loading is disabled.

People who want to avoid loading images generally want to avoid loading all images.

Test: http/tests/misc/favicon-loads-with-images-disabled.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::startIconLoader): After committing the URL mapping, don't actually perform the load if images shouldn't be loading.

WebKitTools:

2009-07-31 Brady Eidson <beidson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896
Favicons are still loaded when automatic image loading is disabled.

  • DumpRenderTree/LayoutTestController.cpp: (disableImageLoadingCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::disableImageLoading):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::disableImageLoading):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::disableImageLoading): Stubbed for now.
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::disableImageLoading): Ditto.

LayoutTests:

2009-07-31 Brady Eidson <beidson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896
Favicons are still loaded when automatic image loading is disabled.

  • http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
  • http/tests/misc/favicon-loads-with-images-disabled.html: Added.
16:12 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
16:03 Changeset [46645] by simon.fraser@apple.com

2009-07-31 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Accelerated animations stutter on pages with lots of animations and 3d transforms
https://bugs.webkit.org/show_bug.cgi?id=27884

This patch changes the strategy for synchronizing painting view the view,
and compositing layer updates. Previously the strategy was to disable screen
updates between the time we updated the layer tree, and painted the view. That
left screen updates disabled for too long (hundreds of milliseconds) in some
cases, causing animation stutter.

The new strategy is to batch up changes to the CA layer tree, and commit them
all at once just before painting happens (referred to as a "sync" in the code).
GraphicsLayerCA now keeps a bitmask of changed properties, and then migrates
the values stored in GraphicsLayer into the CA layer tree at commit time.

Compositing layers are then synced in FrameView::paintContents(). However, not
all style/layout changes will result in painting; to deal with style changes that
touch only compositing properties, we set up a runloop observer that takes care
of comitting layer changes when no painting happens.

  • WebCore.base.exp: Export FrameView::syncCompositingStateRecursive()
  • loader/EmptyClients.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive()
  • page/ChromeClient.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive()
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateRecursive): syncCompositingState() on the view and all subviews. Like layoutIfNeededRecursive(). If layout is pending, does not sync and returns false, since we only want to sync when layout is done.

(WebCore::FrameView::paintContents): syncCompositingState() before painting.

  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::endAnimation): Call animationPaused() to notify the graphics layers about animation pausing.
  • platform/graphics/FloatPoint3D.h: (WebCore::operator==): (WebCore::operator!=): Add missing comparison operators.
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setOpacity): (WebCore::GraphicsLayer::setBackgroundColor): Simple setters no longer care about animation info.

(WebCore::GraphicsLayer::paintGraphicsLayerContents): Null-check client.

  • platform/graphics/GraphicsLayer.h: (WebCore::AnimationValue:): (WebCore::TransformAnimationValue:): (WebCore::KeyframeValueList:): (WebCore::KeyframeValueList::insert): Cleaned up versions of FloatValue and TransformValue, used to store information about keyframes values.

(WebCore::GraphicsLayer::contentsRect):
(WebCore::GraphicsLayer::setContentsRect):
ContentsRect is now a simple setter.

(WebCore::GraphicsLayer::addAnimation):
(WebCore::GraphicsLayer::removeAnimationsForProperty):
(WebCore::GraphicsLayer::removeAnimationsForKeyframes):
(WebCore::GraphicsLayer::pauseAnimation):
Simplified animation api.

(WebCore::GraphicsLayer::setGeometryOrientation):
(WebCore::GraphicsLayer::geometryOrientation):
setGeometryOrientation is now just a normal member variable.

(WebCore::GraphicsLayer::contentsOrientation): add a getter.
(WebCore::GraphicsLayer::syncCompositingState): Entry into the layer sync code.

  • platform/graphics/GraphicsLayerClient.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive)
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: Lots of cleanup and refactoring. Main points:
  • Layer changes are all batched, and only committed to the CA layer on syncCompositingState().
  • Bitmask is used to store which properties have changed. More efficient than before.
  • Simpler animation interface; simple setters are no longer confounded with animations.
  • Refactored code that creates CA animations, and stores which animations are running.
  • platform/graphics/transforms/TransformOperations.h: (WebCore::TransformOperations::size): (WebCore::TransformOperations::at): Useful accessors for size and indexed access.
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerBacking.cpp: Renamed 'contentsLayer' to 'foregroundLayer' to avoid confusion with GraphicsLayer's contentsLayer. Adapt to GraphicsLayer's simpler animation API. Pass animation pausing through to the graphics layers. contentsBox() is no longer a callback via GraphicsLayerClient.
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::setCompositingLayersNeedRebuild): (WebCore::RenderLayerCompositor::scheduleSync): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): scheduleViewUpdate() is no longer required. Instead, we plumb through "compositingLayerSync" notifications, which travel up to WebKit and set up a runloop observer.
15:59 UpdatingBugzilla created by ddkilzer@apple.com
Initial contents
15:58 WikiStart edited by ddkilzer@apple.com
(diff)
15:46 Changeset [46644] by eric@webkit.org

2009-07-30 Eric Seidel <eric@webkit.org>

Reviewed by David Kilzer.

bugzilla-tool post-commits trunk..head errors out
https://bugs.webkit.org/show_bug.cgi?id=27847

Rename commit_ids_from_range_arguments to commit_ids_from_commitish_arguments
and make it handle the new arguments format proposed in the bug.

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
15:29 Changeset [46643] by eric@webkit.org

2009-07-31 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Change malloc to fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp
https://bugs.webkit.org/show_bug.cgi?id=27874

Use fastMalloc and fastFree instead of malloc and free in RegexInterpreter.cpp's methods.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::allocDisjunctionContext): (JSC::Yarr::Interpreter::freeDisjunctionContext): (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
14:57 Changeset [46642] by bolsinga@apple.com

2009-07-31 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Eric Seidel.

Geolocation clean up when no longer updating
https://bugs.webkit.org/show_bug.cgi?id=27888

When Geolocation::disconnectFrame() is called, need to call
Document::setUsingGeolocation(false) to mirror the true call
when it is set up.

When handling an error, and there are no more listeners, call
GeolocationService::stopUpdating().

  • page/Geolocation.cpp: (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::handleError):
14:14 Changeset [46641] by eric@webkit.org

2009-07-30 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

clean up build-webkit to use less copy/paste code and remove unneeded SVG warning
https://bugs.webkit.org/show_bug.cgi?id=27857

  • Scripts/build-webkit:
14:02 Changeset [46640] by ddkilzer@apple.com

<http://webkit.org/b/27894> bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with ClientForm-0.2.10 and python-2.5

Reviewed by Eric Seidel.

  • Scripts/modules/bugzilla.py: (Bugzilla.clear_attachment_review_flag): Specify which 'comment' form field to use when setting its value.
13:29 Changeset [46639] by jorlow@chromium.org

2009-07-31 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

Add new LocalStorage layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27778

These test behavior that I don't think was very well verified earlier.

  • storage/domstorage/localstorage/complex-keys-expected.txt: Added.
  • storage/domstorage/localstorage/complex-keys.html: Added.

A bunch of corner cases related to keys.

  • storage/domstorage/localstorage/complex-values-expected.txt: Added.
  • storage/domstorage/localstorage/complex-values.html: Added.

A bunch of corner cases related to values.

  • storage/domstorage/localstorage/remove-item-expected.txt: Added.
  • storage/domstorage/localstorage/remove-item.html: Added.

Test basic removeItem functionality.

13:21 Changeset [46638] by andersca@apple.com

2009-07-31 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

-Fix <rdar://problem/7104097>

Make EmbeddedWidget::create return a PassRefPtr so it will have the correct ref count.


  • WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::create):
  • WebCoreSupport/EmbeddedWidget.h:
13:12 Changeset [46637] by ddkilzer@apple.com

2009-07-31 Eric Seidel <eric@webkit.org>

Reviewed by David Kilzer.

bugzilla-tool post-commits obsoletes its own work :(
https://bugs.webkit.org/show_bug.cgi?id=27849

Simple fix. Use .add() instead of .update()

  • Scripts/bugzilla-tool:
11:40 Changeset [46636] by jorlow@chromium.org

2009-07-30 Jeremy Orlow <jorlow@chromium.org>

Reviewed by David Levin.

Guard needs 's between #endif and ENABLE(DATAGRID)
https://bugs.webkit.org/show_bug.cgi?id=27862

Compiling this file causes a build break without this change.

  • bindings/v8/custom/V8DataGridColumnListCustom.cpp:
11:16 Changeset [46635] by treat@webkit.org

2009-07-31 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Re-Enable tests from Skipped that are passing correctly.

https://bugs.webkit.org/show_bug.cgi?id=27890

  • platform/qt/Skipped:
10:07 Changeset [46634] by kenneth@webkit.org

2009-07-31 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add LayoutTest results from BuildBot output for tests that currently lack results under Qt.

https://bugs.webkit.org/show_bug.cgi?id=27882

  • platform/qt/fast/backgrounds/size/backgroundSize20-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt.
  • platform/qt/fast/backgrounds/size/backgroundSize21-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt.
  • platform/qt/fast/backgrounds/size/backgroundSize22-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt.
  • platform/qt/fast/borders/border-radius-constraints-expected.txt: Added.
  • platform/qt/fast/box-shadow/inset-expected.txt: Added.
  • platform/qt/fast/box-shadow/spread-expected.txt: Copied from LayoutTests/platform/mac/fast/box-shadow/spread-expected.txt.
  • platform/qt/fast/canvas/image-pattern-rotate-expected.txt: Added.
  • platform/qt/fast/css/nested-floating-relative-position-percentages-expected.txt: Added.
  • platform/qt/fast/css/pseudo-cache-stale-expected.txt: Added.
  • platform/qt/fast/css/rem-dynamic-scaling-expected.txt: Added.
  • platform/qt/fast/css/rem-units-on-root-expected.txt: Added.
  • platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.txt: Added.
  • platform/qt/fast/dynamic/window-scrollbars-test-expected.txt: Added.
  • platform/qt/fast/forms/isindex-placeholder-expected.txt: Added.
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt: Added.
  • platform/qt/fast/frames/content-opacity-1-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/content-opacity-1-expected.txt.
  • platform/qt/fast/frames/content-opacity-2-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/content-opacity-2-expected.txt.
  • platform/qt/fast/frames/frame-navigation-expected.txt: Added.
  • platform/qt/fast/frames/frame-scrolling-attribute-expected.txt: Added.
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt: Added.
  • platform/qt/fast/gradients/crash-on-zero-radius-expected.txt: Added.
  • platform/qt/fast/lists/ol-start-parsing-expected.txt: Added.
  • platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.txt: Added.
  • platform/qt/fast/repaint/float-new-in-block-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/float-new-in-block-expected.txt.
  • platform/qt/fast/text/international/khmer-selection-expected.txt: Added.
  • platform/qt/fast/text/shadow-translucent-fill-expected.txt: Added.
  • platform/qt/fast/text/text-letter-spacing-expected.txt: Added.
  • platform/qt/plugins/netscape-dom-access-expected.txt: Added.
  • platform/qt/svg/batik/filters/feTile-expected.txt: Added.
  • platform/qt/svg/custom/createImageElement-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/createImageElement-expected.txt.
  • platform/qt/svg/custom/createImageElement2-expected.txt: Added.
  • platform/qt/svg/custom/js-update-image-and-display-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-update-image-and-display-expected.txt.
  • platform/qt/svg/custom/js-update-image-and-display2-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-update-image-and-display2-expected.txt.
  • platform/qt/svg/custom/js-update-image-and-display3-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-update-image-and-display3-expected.txt.
  • platform/qt/svg/custom/outer-svg-unknown-feature-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/outer-svg-unknown-feature-expected.txt.
  • platform/qt/svg/filters/feMerge-expected.txt: Added.
  • platform/qt/svg/filters/feOffset-expected.txt: Added.
  • platform/qt/svg/filters/feTile-expected.txt: Added.
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt: Added.
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt: Added.
10:04 Changeset [46633] by bolsinga@apple.com

2009-07-30 Greg Bolsinga <bolsinga@apple.com>

Reviewed by George Staikos.

Consolidate GeoLocation code to send positions and errors
https://bugs.webkit.org/show_bug.cgi?id=27863

Create helper methods that will send positions and errors to either
one shots or watchers.

  • page/Geolocation.cpp: (WebCore::Geolocation::sendError): (WebCore::Geolocation::sendErrorToOneShots): (WebCore::Geolocation::sendErrorToWatchers): (WebCore::Geolocation::sendPosition): (WebCore::Geolocation::sendPositionToOneShots): (WebCore::Geolocation::sendPositionToWatchers):
  • page/Geolocation.h:
09:52 Changeset [46632] by kenneth@webkit.org

2009-07-31 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Build QtWebKit without benchmark tests for Qt < 4.5.
https://bugs.webkit.org/show_bug.cgi?id=27886

The QBENCHMARK macro is only available from 4.5 on,
so builds for Qt < 4.5 shouldn't try to build those.

  • tests/tests.pro:
07:56 Changeset [46631] by vestbo@webkit.org

2009-07-31 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Anders Carlsson.

Improve platform-detection in run-webkit-tests

This prevents miss-detection of mac-* over Qt/Mac.

  • Scripts/run-webkit-tests:
07:37 Changeset [46630] by kenneth@webkit.org

2009-07-31 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Adam Treat.

Fix warning by migrating use of QString.sprintf(...) to
QString.arg().arg()...

  • WebCoreSupport/EditorClientQt.cpp: (dumpRange):
06:51 Changeset [46629] by treat@webkit.org

2009-07-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Tor Arne Vestbo.

Adding -webkit-animation-play-state back in following r46547.

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
06:29 Changeset [46628] by kenneth@webkit.org

2009-07-31 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Tor Arne Vestbø.

Expose the Offline Web Application Cache in the Qt API.

  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings): (QWebSettings::setOfflineWebApplicationCachePath): (QWebSettings::offlineWebApplicationCachePath): (QWebSettings::setOfflineWebApplicationCacheQuota): (QWebSettings::offlineWebApplicationCacheQuota):
  • Api/qwebsettings.h:
05:43 Changeset [46627] by xan@webkit.org

2009-07-31 Xan Lopez <xlopez@igalia.com>

Roll out previous change as it might be causing some weirdness in
the bots.

  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::processFileHeader):
05:06 Changeset [46626] by xan@webkit.org

2009-07-31 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

Fix compiler warning.
https://bugs.webkit.org/show_bug.cgi?id=27851

GCC does not like multi-character character constants, so use the
explicit numerical value of 'BM' in the enum.

  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::processFileHeader):
00:21 Changeset [46625] by mrowe@apple.com

Fix the test case that was landed in r46624.

  • http/tests/misc/meta-refresh-stray-single-quote.html:

07/30/09:

23:54 Changeset [46624] by beidson@apple.com

WebCore:

2009-07-30 Brady Eidson <beidson@apple.com>

Reviewed by Mark Rowe, but Dan Bernstein also reviewed and asked thoughtful questions.

<rdar://problem/7106968> and https://bugs.webkit.org/show_bug.cgi?id=27868
http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit, works in others.


Test: http/tests/misc/meta-refresh-stray-single-quote.html

  • platform/network/HTTPParsers.cpp: (WebCore::parseHTTPRefresh): Allow for a stray quote character at the start of the URL string.

LayoutTests:

2009-07-30 Brady Eidson <beidson@apple.com>

Reviewed by Mark Rowe, but Dan Bernstein also reviewed and asked thoughtful questions.

<rdar://problem/7106968> and https://bugs.webkit.org/show_bug.cgi?id=27868
http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit, works in others.

  • http/tests/misc/meta-refresh-stray-single-quote-expected.txt: Added.
  • http/tests/misc/meta-refresh-stray-single-quote.html: Added.
  • http/tests/misc/resources/success-notify-done.html: Added.
23:37 Changeset [46623] by xan@webkit.org

2009-07-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

Fix compiler warning.

GCC does not like C++-style comments in preprocessor directives.

  • wtf/Platform.h:
23:15 Changeset [46622] by jmalonzo@webkit.org

2009-07-30 Martin Robinson <mrobinson@appcelerator.com>

Reviewed by Xan Lopez, Gustavo Noronha and Jan Alonzo.

[GTK] new-window-policy-decision-requested provides no information about the target frame
https://bugs.webkit.org/show_bug.cgi?id=27792

Add frameName property to the WebKitWebNavigation object.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::getNavigationAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
  • webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_get_property): (webkit_web_navigation_action_set_property): (webkit_web_navigation_action_class_init): (webkit_web_navigation_action_get_target_frame): (webkit_web_navigation_action_set_target_frame):
  • webkit/webkitwebnavigationaction.h:
22:38 Changeset [46621] by barraclough@apple.com

2009-07-30 John McCall <rjmccall@apple.com>

Reviewed by Gavin Barraclough.

Optimize the X86_64 trampolines: avoid the need for filler arguments
and move the stub-args area closer to the stack pointer.

  • jit/JIT.h: adjust patch offsets because of slight code-size change
  • jit/JITCode.h: (JSC::JITCode::execute): don't pass filler args
  • jit/JITStubs.cpp: (ctiTrampoline): (X86_64): push args onto stack, use args directly (ctiVMThrowTrampoline): (X86_64): adjust %rsp by correct displacement (ctiOpThrowNotCaught): (X86_64): adjust %rsp by correct displacement
  • jit/JITStubs.h: (JITStackFrame): (X86_64): move args area earlier (ctiTrampoline): remove filler args from prototype
19:57 Changeset [46620] by barraclough@apple.com

2009-07-30 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY (build fix).

Temporarily revert r46618 since this is b0rking on Linux.

19:29 Changeset [46619] by mrowe@apple.com

Teach buildbot to detect test cases that are missing results.

Reviewed by Cameron Zwarich.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
19:20 Changeset [46618] by barraclough@apple.com

2009-07-23 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Make get_by_id/put_by_id/method_check/call defer optimization using a data flag rather than a code modification.
( https://bugs.webkit.org/show_bug.cgi?id=27635 )

This improves performance of ENABLE(ASSEMBLER_WX_EXCLUSIVE) builds by 2-2.5%, reducing the overhead to about 2.5%.
(No performance impact with ASSEMBLER_WX_EXCLUSIVE disabled).

  • bytecode/CodeBlock.cpp: (JSC::printStructureStubInfo):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
  • bytecode/CodeBlock.h: (JSC::): (JSC::CallLinkInfo::seenOnce): (JSC::CallLinkInfo::setSeen): (JSC::MethodCallLinkInfo::seenOnce): (JSC::MethodCallLinkInfo::setSeen):
    • Change a pointer in CallLinkInfo/MethodCallLinkInfo to use a PtrAndFlags, use a flag to track when an op has been executed once.
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
  • bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::StructureStubInfo): (JSC::StructureStubInfo::initGetByIdSelf): (JSC::StructureStubInfo::initGetByIdProto): (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::initGetByIdSelfList): (JSC::StructureStubInfo::initGetByIdProtoList): (JSC::StructureStubInfo::initPutByIdTransition): (JSC::StructureStubInfo::initPutByIdReplace): (JSC::StructureStubInfo::seenOnce): (JSC::StructureStubInfo::setSeen):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID, add a flag to track when an op has been executed once.
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitGetById): (JSC::BytecodeGenerator::emitPutById):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::unlinkCall):
    • Remove the "don't lazy link" stage of calls.
  • jit/JIT.h: (JSC::JIT::compileCTIMachineTrampolines):
    • Remove the "don't lazy link" stage of calls.
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase):
    • Remove the "don't lazy link" stage of calls.
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks): (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::JITStubs::DEFINE_STUB_FUNCTION): (JSC::JITStubs::getPolymorphicAccessStructureListSlot):
    • Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
  • jit/JITStubs.h: (JSC::JITThunks::ctiStringLengthTrampoline): (JSC::JITStubs::):
    • Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
  • wtf/PtrAndFlags.h: (WTF::PtrAndFlags::PtrAndFlags): (WTF::PtrAndFlags::operator!): (WTF::PtrAndFlags::operator->):
    • Add ! and -> operators, add constuctor with pointer argument.
18:28 Changeset [46617] by mrowe@apple.com

Bug 27828: Title attribute is not respected on option elements
Fix <https://bugs.webkit.org/show_bug.cgi?id=27828> for Mac.

Reviewed by Adele Peterson and Jon Honeycutt.

No tests added as it is not clear how to test a tool tip from DumpRenderTree.

  • platform/PopupMenuClient.h: Add a method for retrieving the tool tip of an item.
  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenu::populate): Set the tool tip of the menu item to that of the represented item.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemToolTip): Expose the title attribute of the element as the tool tip.

  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.h:

(WebCore::RenderTextControlSingleLine::itemToolTip): Return an empty string, indicating no tool tip, for
the popup menu in RenderTextControlSingleLine.

17:52 Changeset [46616] by mrowe@apple.com

Things work better when you create the correct directories.

  • Scripts/run-webkit-tests:
17:22 Changeset [46615] by mrowe@apple.com

Include some information about the error when we die.

  • Scripts/run-webkit-tests:
16:51 Changeset [46614] by treat@webkit.org

2009-07-30 Adam Treat <adam.treat@torchmobile.com>

Add expected results file for new test.

  • platform/gtk/fast/forms/button-style-color-expected.txt: Added.
16:41 Changeset [46613] by mrowe@apple.com

Ensure that the path exists before writing results to it.
Hopefully this will make the Windows build bot happy.

  • Scripts/run-webkit-tests:
16:32 Changeset [46612] by treat@webkit.org

2009-07-30 Adam Treat <adam.treat@torchmobile.com>

Add expected results file for new test.

  • platform/mac/fast/forms/button-style-color-expected.txt: Added.
16:21 Changeset [46611] by darin@chromium.org

2009-07-30 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Remove ChromeClientChromium::setToolTip().
https://bugs.webkit.org/show_bug.cgi?id=27861

This patch is just to remove a temporarily introduced overloaded empty
virtual function. No test is needed.

  • page/chromium/ChromeClientChromium.h:
16:11 Changeset [46610] by ggaren@apple.com

2009-07-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.

Fixed failing tests seen on Windows buildbot.

  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h: (JSC::): Use "int" instead of "bool" to guarantee a 32-bit result, regardless of compiler. gcc on mac uses 32-bit values for bool, but gcc on linux and MSVC on Windows use 8-bit values.
16:08 Changeset [46609] by darin@chromium.org

2009-07-30 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=27821

ApplicationCacheHost refactoring.


1) Better encapsulate the interfaces between webcore common code
and the appcache system within a new class ApplicationCacheHost.

2) Use that interface throughout the loader system, replacing inline appcache logic.

3) Implement the interface in terms of webcore's appcache system.

4) Add the new files to various makefiles.

5) Implement protocolHostAndPortAreEqual() in KURLGoogle.cpp

No new features, no new tests. The existing layout tests all pass.

  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedIntoDocument):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::mainReceivedError): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::setPrimaryLoadComplete):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::applicationCacheHost):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::load):
  • loader/MainResourceLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didFail):
  • loader/ResourceLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::failedLoadingMainResource): (WebCore::ApplicationCacheGroup::disassociateDocumentLoader): (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::manifestNotFound): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): (WebCore::ApplicationCacheGroup::startLoadingEntry): (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): (WebCore::CallCacheListenerTask::create): (WebCore::CallCacheListenerTask::performTask): (WebCore::CallCacheListenerTask::CallCacheListenerTask): (WebCore::ApplicationCacheGroup::postListenerTask):
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheHost.cpp: Added.
  • loader/appcache/ApplicationCacheHost.h: Added.
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::transferApplicationCache):
  • loader/appcache/ApplicationCacheStorage.h:
  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::DOMApplicationCache): (WebCore::DOMApplicationCache::disconnectFrame): (WebCore::DOMApplicationCache::applicationCacheHost): (WebCore::DOMApplicationCache::status): (WebCore::DOMApplicationCache::update): (WebCore::DOMApplicationCache::swapCache): (WebCore::DOMApplicationCache::addEventListener): (WebCore::DOMApplicationCache::removeEventListener): (WebCore::DOMApplicationCache::dispatchEvent): (WebCore::DOMApplicationCache::callListener): (WebCore::DOMApplicationCache::toEventName): (WebCore::DOMApplicationCache::toEventType):
  • loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::): (WebCore::DOMApplicationCache::setAttributeEventListener): (WebCore::DOMApplicationCache::getAttributeEventListener): (WebCore::DOMApplicationCache::clearAttributeEventListener): (WebCore::DOMApplicationCache::callEventListener): (WebCore::DOMApplicationCache::setOnchecking): (WebCore::DOMApplicationCache::onchecking): (WebCore::DOMApplicationCache::setOnerror): (WebCore::DOMApplicationCache::onerror): (WebCore::DOMApplicationCache::setOnnoupdate): (WebCore::DOMApplicationCache::onnoupdate): (WebCore::DOMApplicationCache::setOndownloading): (WebCore::DOMApplicationCache::ondownloading): (WebCore::DOMApplicationCache::setOnprogress): (WebCore::DOMApplicationCache::onprogress): (WebCore::DOMApplicationCache::setOnupdateready): (WebCore::DOMApplicationCache::onupdateready): (WebCore::DOMApplicationCache::setOncached): (WebCore::DOMApplicationCache::oncached): (WebCore::DOMApplicationCache::setOnobsolete): (WebCore::DOMApplicationCache::onobsolete): (WebCore::DOMApplicationCache::~DOMApplicationCache):
  • platform/KURLGoogle.cpp: (WebCore::protocolHostAndPortAreEqual):
16:05 Changeset [46608] by treat@webkit.org

2009-07-30 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Mark Rowe.

Revert previous commit to test out new functionality of buildbots and
run-webkit-tests made possible by r46607.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
15:54 Changeset [46607] by mrowe@apple.com

Teach run-webkit-tests to always store the actual results in the results directory for new tests.

Reviewed by Adam Treat and Jon Honeycutt.

This allows us to give a working link to the results from the result summary page, even if we're
not generating new results in to the tree.

  • Scripts/run-webkit-tests:
15:44 Changeset [46606] by simon.fraser@apple.com

2009-07-30 Simon Fraser <simon.fraser@apple.com>

Minor change to earlier commit suggested by Darin Adler.
Use the variable rather than dereferencing 'it' again.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
15:28 Changeset [46605] by treat@webkit.org

2009-07-30 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos.

Add new test with platform specific results to the Skipped files of ports
that haven't generated them yet. This is to make the buildbot green again.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
14:50 Changeset [46604] by cfleizach@apple.com

Bug 27854 - crash at WebCore::AXObjectCache::notificationPostTimerFired
https://bugs.webkit.org/show_bug.cgi?id=27854

14:47 Changeset [46603] by simon.fraser@apple.com

2009-07-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Animation with a timing function property in a keyframe eats CPU
https://bugs.webkit.org/show_bug.cgi?id=27856
<rdar://problem/7104476> Animation demo uses lots of CPU

Don't include animation-timing-function in the list of properties to
animate in a keyframe animation, because this property is not animated;
instead, it describes the timing function to apply to this keyframe.

This prevents the animation code from thinking that there's a property
that it has to software-animate, and thus firing the animation timer frequently.

Not testable because there is no visible impact.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation): Don't add CSSPropertyWebkitAnimationTimingFunction to the list of properties to animate.
  • page/animation/KeyframeAnimation.cpp (WebCore::KeyframeAnimation::getKeyframeAnimationInterval): Add a comment
14:37 Changeset [46602] by mrowe@apple.com

Add a Qt Linux build bot.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
14:18 Changeset [46601] by ggaren@apple.com

2009-07-30 Geoffrey Garen <ggaren@apple.com>

Windows build fix: added missing symbols on Windows.

14:16 Changeset [46600] by treat@webkit.org

WebCore:
2009-07-30 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Apply colour style to buttons that use Theme settings in Qt.

https://bugs.webkit.org/show_bug.cgi?id=27814

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustButtonStyle):

LayoutTests:
2009-07-30 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add Button Colour style test and results for Qt based upon fix for bug.
Unskip tables/mozilla/bugs/bug92647-2.html which passes with bug fix.
Update expected results for qt for test fast/dom/HTMLTableColElement/resize-table-using-col-width-expected
which also passes with the the bug fix.

https://bugs.webkit.org/show_bug.cgi?id=27814

  • fast/forms/button-style-color.html: Added.
  • platform/qt/Skipped:
  • platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/qt/fast/forms/button-style-color-expected.txt: Added.
14:05 Changeset [46599] by ggaren@apple.com

2009-07-30 Geoffrey Garen <ggaren@apple.com>

Windows build fix: removed stale symbols on Windows.

13:57 Changeset [46598] by ggaren@apple.com

Merged nitro-extreme branch into trunk.

13:57 Changeset [46597] by treat@webkit.org

2009-07-30 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Roben.

Add --minimal option to webkit-build.
https://bugs.webkit.org/show_bug.cgi?id=27852

This option disables all optional build features unless
they are explicitly enabled.

  • Scripts/build-webkit:
12:31 Changeset [46596] by dglazkov@chromium.org

2009-07-30 Dean McNamee <deanm@chromium.org>

Reviewed by Dimitri Glazkov.

Don't try to hash member function pointers, instead use a precomputed value based on the field.
https://bugs.webkit.org/show_bug.cgi?id=27843

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::PODTypeWrapperCacheInfo::PODTypeWrapperCacheInfo): (WebCore::PODTypeWrapperCacheInfo::operator==): (WebCore::PODTypeWrapperCacheInfoHash::hash): (WebCore::V8SVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
12:30 Changeset [46595] by xan@webkit.org

2009-07-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Simon Fraser.

Fix compiler warning.

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
12:20 Changeset [46594] by mpcomplete@chromium.org

2009-07-29 Matt Perry <mpcomplete@chromium.org>

Reviewed by Adam Barth.

Add a way to register V8 extensions for Isolated Worlds only.
https://bugs.webkit.org/show_bug.cgi?id=27785

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluateInNewWorld): (WebCore::ScriptController::evaluateInNewContext):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::evaluate):
  • bindings/v8/V8IsolatedWorld.h:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewWorld): (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::createNewContext): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::registerExtensionWithV8): (WebCore::V8Proxy::registerExtension):
  • bindings/v8/V8Proxy.h:
12:07 Changeset [46593] by treat@webkit.org

2009-07-30 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add previously defined out support to PopupMenuQt for marking entries as
disabled and for selecting the desired item.

https://bugs.webkit.org/show_bug.cgi?id=27772

  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::populate):
11:44 Changeset [46592] by darin@apple.com

2009-07-30 Darin Adler <darin@apple.com>

Reviewed by David Levin.

Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

Next step: Add new toRenderWidget cast and use it everywhere.

Use checked casts in all the places that were using static_cast
but there is a checked cast available.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::widget): (WebCore::AccessibilityRenderObject::widgetForAttachmentView): (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getPangoLayoutForAtk):
  • dom/Document.cpp: (WebCore::widgetForNode): (WebCore::Document::setFocusedNode):
  • html/HTMLEmbedElement.cpp: (WebCore::findWidgetRenderer):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::defaultEventHandler):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderWidgetForJSBindings):
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::defaultEventHandler):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe):
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData):
  • page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::subframeForTargetNode): (WebCore::EventHandler::handleWheelEvent):
  • page/Frame.cpp: (WebCore::isFrameElement):
  • page/PrintContext.cpp: (WebCore::PrintContext::computePageRects):
  • page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/chromium/FrameChromium.cpp: (WebCore::computePageRectsForFrame):
  • page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passSubframeEventToSubframe):
  • page/win/FrameWin.cpp: (WebCore::computePageRectsForFrame):
  • page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::getCachedImage):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage):
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage):
  • platform/qt/ClipboardQt.cpp: (WebCore::getCachedImage):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage):
  • platform/win/ClipboardWin.cpp: (WebCore::getCachedImage):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
  • rendering/InlineBox.h: (WebCore::InlineBox::boxModelObject):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::addChildToContinuation):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateImageContents):
  • rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::positionForPoint): Use checked cast instead of static_cast.


  • rendering/RenderWidget.h: Added toRenderWidget.
11:25 Changeset [46591] by staikos@webkit.org

2009-07-30 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

WINCE PORT: some files modified to build for WINCE
https://bugs.webkit.org/show_bug.cgi?id=27816

11:08 Changeset [46590] by staikos@webkit.org

2009-07-30 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

WINCE PORT: modified graphics files
https://bugs.webkit.org/show_bug.cgi?id=27779

10:52 Changeset [46589] by kenneth@webkit.org

2009-07-30 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Ariya Hidayat.

Improve efficiency by rewriting code doing three hash table
lookups, which can be replaced by just one as pointed out
by Darin Adler.

Though being slightly less clear, this should be considerable
faster.

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::remove):
10:50 Changeset [46588] by kov@webkit.org

2009-07-30 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Gustavo Noronha.

[Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=27651

Removed unneeded includes (gdk.h and gtk.h) and added glib.h and cairo.h instead.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
10:38 Changeset [46587] by kov@webkit.org

2009-07-30 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Gustavo Noronha.

[Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=27651

Fixed many code style issues pointed by WebKitTools/Scripts/modules/cpplint.py
No functionality change at all.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gtk/VideoSinkGStreamer.cpp:
  • platform/graphics/gtk/VideoSinkGStreamer.h:
09:43 Changeset [46586] by kenneth@webkit.org

Allow to explicitly choose a preferred plugin for a mimetype.

https://bugs.webkit.org/show_bug.cgi?id=27651

When the preferred plugin is set for a specific MIME type, it will be
always picked up, regardless of its version, quirks etc.

Client applications may want to use that API to resolve mimetype
ambiguity in a custom way, rather than in the default way that is
currently used in WebKit.

09:32 Changeset [46585] by kenneth@webkit.org

[Qt] Fix build with GCC 4.4.

09:31 Changeset [46584] by kenneth@webkit.org

[Qt] Fix build with Qt 4.4 after r46535.

09:31 Changeset [46583] by kenneth@webkit.org

2009-07-30 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Adam Treat.

Add missing Q_OBJECT to class inheriting from QObject.

  • tests/qwebframe/tst_qwebframe.cpp:
09:31 Changeset [46582] by kenneth@webkit.org

2009-07-30 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Adam Treat.

Fix indentation.

  • tests/qwebframe/tst_qwebframe.cpp:
09:05 Changeset [46581] by eric.carlson@apple.com

2009-07-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Video elements fires another "load" event when attached to DOM
https://bugs.webkit.org/show_bug.cgi?id=27623

Test: media/media-load-event.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::insertedIntoDocument):

Only schedule load when element's network state is NETWORK_EMPTY.

2009-07-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Video elements fires another "load" event when attached to DOM
https://bugs.webkit.org/show_bug.cgi?id=27623

  • media/media-load-event-expected.txt: Added.
  • media/media-load-event.html: Added.
07:41 SpecSupport edited by tony@gonk.net
Added entries for XSLT 2.0 and XPath 2.0. Although each spec's v1.0 is … (diff)
07:07 Changeset [46580] by levin@chromium.org

2009-07-30 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

Cache v8 strings when converting from WebCore::String to v8 string.
https://bugs.webkit.org/show_bug.cgi?id=27655

  • bindings/v8/V8Binding.cpp: (WebCore::v8String): now just immediately calls v8ExternalString (WebCore::enableStringImplCache): enables caching of conversions from WebCore::StringImpl to v8::String (WebCore::makeExternalString): utilty function to create external v8::String out of WebCore::String (WebCore::getStringCache): static function to access string cache (WebCore::cachedStringCallback): callback for weak handles of v8::Strings stored in the cache (WebCore::v8ExternalString): if caching enabled, checks if there is already v8::String for the given WebCore::StringImpl. If present, returns it, otherwise creates a new v8 external string.
  • bindings/v8/V8Binding.h:
06:11 Changeset [46579] by ariya@webkit.org

2009-07-29 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=27813

[Qt] Support pixel tests in DumpRenderTree for the Qt port.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::setDumpPixels): (WebCore::DumpRenderTree::dump):
  • DumpRenderTree/qt/DumpRenderTree.h:
  • DumpRenderTree/qt/main.cpp: (main):
06:01 Changeset [46578] by hausmann@webkit.org

2009-07-30 Volker Hilsheimer <volker.hilsheimer@nokia.com>

Reviewed by Simon Hausmann.

Fix documentation links to examples.

  • Api/qwebview.cpp:
05:59 Changeset [46577] by ariya@webkit.org

ChangeLog:

2009-07-29 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

Adding ImageDiff project file.

https://bugs.webkit.org/show_bug.cgi?id=27813

  • WebKit.pro: Added ImageDiff.pro.

WebKitTools/ChangeLog:

2009-07-29 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=27813

[Qt] Implement ImageDiff.

  • DumpRenderTree/qt/ImageDiff.cpp: Added.
  • DumpRenderTree/qt/ImageDiff.pro: Added.
05:48 Changeset [46576] by hausmann@webkit.org

2009-07-30 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Allocate MainWindow on heap in robotized QtLauncher as well.

  • QtLauncher/main.cpp: (main):
04:24 Changeset [46575] by vestbo@webkit.org

2009-07-30 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Eric Seidel.

build-webkit: Reorder logic for determining the baseProductDir

https://bugs.webkit.org/show_bug.cgi?id=27699

We now do port-spesific probing for the product dir first, and then
fall back to either the generic WEBKITOUTPUTDIR (which now also works
on Mac), or WebKitBuild.

Then we add the git branch if the git branch build option is enabled.

Finally we massage the product dir based on the port. For example the
Mac port will now always set the SYMROOT and OBJROOT configuration for
XCode.

Note that isAppleWinWebkit() and isCygwin() is not mutually exclusive,
hence the normal if and not elsif in the last two blocks.

  • Scripts/webkitdirs.pm:
00:52 Changeset [46574] by xan@webkit.org

2009-07-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=25535
[GTK] object:state-changed:checked events missing for radio buttons and checkboxes

Implement state-changed:checked for radio buttons and checkboxes.

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked):
00:13 Changeset [46573] by xan@webkit.org

2009-07-30 Xan Lopez <xlopez@igalia.com>

Forgot the 'break'.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
00:06 Changeset [46572] by xan@webkit.org

2009-07-30 Xan Lopez <xlopez@igalia.com>

Try to fix Mac build.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
00:00 Changeset [46571] by xan@webkit.org

2009-07-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Adam Barth.

Add missing enumeration value to switch.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):

07/29/09:

18:10 Changeset [46570] by jianli@chromium.org

WebCore:

2009-07-29 Jian Li <jianli@chromium.org>

Reviewed by Darin Adler.

Workers need to throw an exception when presented with invalid URLs.
https://bugs.webkit.org/show_bug.cgi?id=27770

Tests covered by worker-constructor.html and worker-redirect.html.

  • bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • workers/Worker.cpp: (WebCore::Worker::Worker):
  • workers/Worker.h: (WebCore::Worker::create):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously): (WebCore::WorkerScriptLoader::createResourceRequest):
  • workers/WorkerScriptLoader.h:

LayoutTests:

2009-07-29 Jian Li <jianli@chromium.org>

Reviewed by Darin Adler.

Workers need to throw an exception when presented with invalid URLs.
https://bugs.webkit.org/show_bug.cgi?id=27770

Update worker-constructor.html and worker-redirect.html per the behavior change.

  • fast/workers/worker-constructor-expected.txt:
  • fast/workers/worker-constructor.html:
  • http/tests/workers/worker-redirect-expected.txt:
  • http/tests/workers/worker-redirect.html:
17:33 Changeset [46569] by beidson@apple.com

2009-07-29 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

(REGRESSION: r46039) Should restore previous connections-per-host limit for non-http(s) hosts
https://bugs.webkit.org/show_bug.cgi?id=27822 and <rdar://problem/7091659>

  • loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): For non-http(s) hosts, restore the previous behavior of only limiting connections while parsing and still trying to figure out stylesheet urls.
17:17 Changeset [46568] by staikos@webkit.org

2009-07-29 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.


WINCE PORT: Add WebCore/page/wince/FrameWince.cpp
https://bugs.webkit.org/show_bug.cgi?id=27729

17:13 Changeset [46567] by rniwa@webkit.org

WebCore:

2009-07-29 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

REGRESSION(r46370-46426): /editing/style/remove-underline-from-stylesheet.html fails
https://bugs.webkit.org/show_bug.cgi?id=27809

The patch primarily rebaselines the tests but also fixes the bug in currentlyHasStyle.
To determine that a particular text decoration is present, currentlyHasStyle should refer to
-webkit-text-decorations-in-effect to take care of styles set by u, s, strike tags and ancestors' CSS.
We also need to update layout to accommodate the changes made within ApplyStyleCommand.

  • editing/ApplyStyleCommand.cpp: ditto (WebCore::StyleChange::currentlyHasStyle): ditto

LayoutTests:

2009-07-29 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

REGRESSION(r46370-46426): /editing/style/remove-underline-from-stylesheet.html fails
https://bugs.webkit.org/show_bug.cgi?id=27809

Since new behavior is consistent with Firefox, we rebaseline the test cases.
The patch converts remove-underline-from-stylesheet and remove-underline-in-bold to dumpAsText tests
with markup printed explicitly because pixel tests did not detect the disappearance of underline.

  • editing/style/remove-underline-from-stylesheet-expected.txt: Added.
  • editing/style/remove-underline-from-stylesheet.html:
  • editing/style/remove-underline-in-bold-expected.txt: Added.
  • editing/style/remove-underline-in-bold.html:
  • platform/mac/editing/style/remove-underline-from-stylesheet-expected.checksum: Removed.
  • platform/mac/editing/style/remove-underline-from-stylesheet-expected.png: Removed.
  • platform/mac/editing/style/remove-underline-from-stylesheet-expected.txt: Removed.
  • platform/mac/editing/style/remove-underline-in-bold-expected.checksum: Removed.
  • platform/mac/editing/style/remove-underline-in-bold-expected.png: Removed.
  • platform/mac/editing/style/remove-underline-in-bold-expected.txt: Removed.
  • platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt: Removed.
  • platform/qt/editing/style/remove-underline-in-bold-expected.txt: Removed.
17:08 Changeset [46566] by staikos@webkit.org

2009-07-29 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

WINCE PORT: changes to platform/text files
https://bugs.webkit.org/show_bug.cgi?id=27715

17:08 Changeset [46565] by ddkilzer@apple.com

<http://webkit.org/b/27788> Don't export WebPluginController.h as a private header

Reviewed by Mark Rowe.

WebKit:

WebPluginController.h includes WebPluginContainerCheck.h, which
is not a private header. Since WebPluginController.h doesn't
appear to be used anywhere, remove its private header status.

  • WebKit.xcodeproj/project.pbxproj: Remove private header attribute from WebPluginController.h.

WebKit/mac:

  • Plugins/WebPluginController.h: Changed #import of WebPluginContainerCheck.h to use a framework-style include in case other platforms wish to export WebPluginController.h as a private header.
16:48 Changeset [46564] by staikos@webkit.org

2009-07-29 Yong Li <yong.li@torchmobile.com>

Reviewed by Adam Roben.

FIX: HDC leaks in PopupMenuWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=27817

16:48 Changeset [46563] by ddkilzer@apple.com

<http://webkit.org/b/27082> bugzilla-tool: Add --no-close switch to land-patches

Reviewed by David Levin.

  • Scripts/bugzilla-tool: (LandPatchesFromBugs.init): Added --no-close switch. (LandPatchesFromBugs.land_patches): Don't close the bug if the --no-close switch was used. Always clear the review+ flag on every landed patch using the commit_text message when cleared. This prevents patches from showing up in the commit queue if reopened and provides consistency with all landed patches.
  • Scripts/modules/bugzilla.py: (Bugzilla.clear_attachment_review_flag): Added.
16:42 Changeset [46562] by darin@apple.com

2009-07-29 Darin Adler <darin@apple.com>

  • platform/gtk/Skipped: Added ol-start-parsing.html since it has no result yet.
16:29 Changeset [46561] by darin@apple.com

2009-07-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Illegal values for <ol start> cause list numbering start at 0 (should start at 1)
https://bugs.webkit.org/show_bug.cgi?id=27810

Test: fast/lists/ol-start-parsing.html

  • html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::parseMappedAttribute): Check the result of toInt and use the value 1 if it failed to parse. Before we were getting toInt's default behavior, which is to return 0.

2009-07-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Illegal values for <ol start> cause list numbering start at 0 (should start at 1)
https://bugs.webkit.org/show_bug.cgi?id=27810

Couldn't make a text-only test because list numbers do not show up in
text dumps. This matches the other fast/lists tests.

  • fast/lists/ol-start-parsing.html: Added.
  • platform/mac/fast/lists/ol-start-parsing-expected.checksum: Added.
  • platform/mac/fast/lists/ol-start-parsing-expected.png: Added.
  • platform/mac/fast/lists/ol-start-parsing-expected.txt: Added.
15:49 Changeset [46560] by bweinstein@apple.com

Was doing the build fix wrong, NotImplemented.h is in WebCore.

15:32 Changeset [46559] by bweinstein@apple.com

Windows build fix.

15:12 Changeset [46558] by kmccullough@apple.com

WebCore:

2009-07-29 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin Adler.

Added foundation work to allow a testing infrastructure for the Web
Inspector.

  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::scriptObjectReady): Tell the testing harness that the window object is ready.
  • loader/EmptyClients.h: Empty class support for SVG. (WebCore::EmptyInspectorClient::inspectorWindowObjectCleared):

WebKit/gtk:

2009-07-29 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin Adler.

Added foundation work to allow a testing infrastructure for the Web
Inspector.


  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::inspectorWindowObjectCleared):
  • WebCoreSupport/InspectorClientGtk.h:

WebKit/mac:

2009-07-29 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin Adler.

Added foundation work to allow a testing infrastructure for the Web
Inspector.

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::inspectorWindowObjectCleared): Send the delegate callback.
  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebView.mm: (-[WebView _cacheFrameLoadDelegateImplementations]):
  • WebView/WebViewPrivate.h: The delegate SPI.

WebKit/qt:

2009-07-29 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin Adler.

Added foundation work to allow a testing infrastructure for the Web
Inspector.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::inspectorWindowObjectCleared):
  • WebCoreSupport/InspectorClientQt.h:

WebKit/win:

2009-07-29 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin Adler.

Added foundation work to allow a testing infrastructure for the Web
Inspector.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::inspectorWindowObjectCleared): Empty definition to let Windows compile but we should implement this at some point so that the tests can be run on Windows too.
  • WebCoreSupport/WebInspectorClient.h:
14:45 Changeset [46557] by cfleizach@apple.com

Fix Windows build breakage.

14:44 Changeset [46556] by bweinstein@apple.com

2009-07-29 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Adam Roben.

Update getComputedStyle expected results on Windows to match updated Mac results.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
14:35 Changeset [46555] by cfleizach@apple.com

Bug 27807 - AX: move re-usable code into more common areas for other platforms
https://bugs.webkit.org/show_bug.cgi?id=27807

13:53 Changeset [46554] by ddkilzer@apple.com

<http://webkit.org/b/27815> bugzilla-tool: add -m/--description to post-commits command

Reviewed by Eric Seidel.

  • Scripts/bugzilla-tool: (PostDiffAsPatchToBug.execute): Changed default patch name from "patch" to "Patch v1". (PostCommitsAsPatchesToBug.init): Added -m/--description switch. (PostCommitsAsPatchesToBug.execute): Use description provided by -m/--description switch first, else fall back to the commit message.
13:35 Changeset [46553] by mitz@apple.com

Reviewed by Simon Fraser.

Inset box shadows are incorrectly accounted for in visual overflow
computations
https://bugs.webkit.org/show_bug.cgi?id=27811

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Use

getBoxShadowHorizontalExtent().

(WebCore::InlineFlowBox::placeBoxesVertically): Use

getBoxShadowVerticalExtent(). Removed duplicate code to get the
text-shadow overflow.

(WebCore::InlineFlowBox::paint): Use getBoxShadowHorizontalExtent().

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): Use

getBoxShadowVerticalExtent().

(WebCore::RenderBlock::overflowWidth): Use

getBoxShadowHorizontalExtent().

(WebCore::RenderBlock::overflowLeft): Ditto.
(WebCore::RenderBlock::overflowTop): Use getBoxShadowVerticalExtent().
(WebCore::RenderBlock::overflowRect): Use getBoxShadowExtent().
(WebCore::RenderBlock::layoutBlock): Ditto.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateRects): Exclude inset shadows.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Use

getBoxShadowHorizontalExtent() and getBoxShadowVerticalExtent().

(WebCore::RenderObject::adjustRectForOutlineAndShadow): Exclude inset

shadows.

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect): Ditto.
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow): Also assert that text-shadows are

not inset.

(WebCore::RenderStyle::getBoxShadowExtent): Added. Excludes inset

shadows.

(WebCore::RenderStyle::getBoxShadowHorizontalExtent): Ditto.
(WebCore::RenderStyle::getBoxShadowVerticalExtent): Ditto.

  • rendering/style/RenderStyle.h:
13:26 Changeset [46552] by beidson@apple.com

2009-07-29 Brady Eidson <beidson@apple.com>

Rubber-stamped by Mark Rowe

  • platform/gtk/Skipped: Disable the new test on GTK, as they don't dump resource load callbacks in their DumpRenderTree.
13:13 Changeset [46551] by beidson@apple.com

2009-07-29 Brady Eidson <beidson@apple.com>

Rubber-stamped by Jon Honeycutt

Check in Tiger-specific results for the new test, as it is known they send willCacheResponse
callbacks in a different order.

  • platform/mac-tiger/http/tests/loading: Added.
  • platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt: Added.
13:07 Changeset [46550] by beidson@apple.com

2009-07-29 Brady Eidson <beidson@apple.com>

Adding my new test to the Windows skipped list until I can figure out what's going on.

  • platform/win/Skipped:
12:48 Changeset [46549] by simon.fraser@apple.com

2009-07-29 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Fix crash when an element with display: table-row is composited (e.g. via a 3d-transform)
https://bugs.webkit.org/show_bug.cgi?id=27796

Avoid repainting when a layer becomes composited if the renderer is not parented
yet, because it makes no sense to do so.

If the table row is a repaint container, default to the RenderBox implementation
of clippedOverflowRectForRepaint(), because we cannot hand off the repaint rect
computation to something that is above the repaint container.

Test: fast/table/table-row-compositing-repaint-crash.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::repaintOnCompositingChange):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
11:22 Changeset [46548] by beidson@apple.com

WebCore:

2009-07-29 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=27791
307 redirects of POSTs should use POST, not GET

Test: http/tests/loading/redirect-methods.html

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):

LayoutTests:

2009-07-29 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=27791
307 redirects of POSTs should use POST, not GET

  • http/tests/loading/redirect-methods-expected.txt: Added.
  • http/tests/loading/redirect-methods.html: Added.
  • http/tests/loading/resources/redirect-methods-form.html: Added.
  • http/tests/loading/resources/redirect-methods-result.php: Added.
11:03 Changeset [46547] by cmarrin@apple.com

Adding -webkit-animation-play-state back in
https://bugs.webkit.org/show_bug.cgi?id=26867

We've decided to keep -webkit-animation-play-state. So this
just adds back in the code from https://bugs.webkit.org/show_bug.cgi?id=22907.

10:02 Changeset [46546] by kenneth@webkit.org

2009-07-29 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

Expose the default plugin directories and the current directory set of
the plugin database as public API.

https://bugs.webkit.org/show_bug.cgi?id=27651

  • plugins/PluginDatabase.h: (WebCore::PluginDatabase::pluginDirectories):
09:30 Changeset [46545] by levin@chromium.org

2009-07-29 Alpha Lam <hclam@chromium.org>

Reviewed by David Levin.

[chromium] Font size for current time display in media controls panel
is affected by body font size.
https://bugs.webkit.org/show_bug.cgi?id=27799

Fixing the problem of rendering by explicitly setting the font size
for the time displays.

No new tests since this is covered by existing media tests.

  • css/mediaControlsChromium.css:
09:30 Changeset [46544] by levin@chromium.org

2009-07-29 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by David Levin.

Update WebCore/page/ContextMenuController.cpp to conform to WebKit
Style Guidelines as identified by cpp_style.py.
https://bugs.webkit.org/show_bug.cgi?id=27613

  • page/ContextMenuController.cpp: (WebCore::openNewWindow): (WebCore::ContextMenuController::contextMenuItemSelected):
09:17 Changeset [46543] by dglazkov@chromium.org

2009-07-29 Dean McNamee <deanm@chromium.org>

Reviewed by Dimitri Glazkov.

Removed unused wrapCPointer/extractCPointer from the v8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=27805

  • bindings/v8/V8DOMWrapper.h:
08:13 Changeset [46542] by kenneth@webkit.org

2009-07-29 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Dave Levin.

Make check-webkit-style support files as arguments.
https://bugs.webkit.org/show_bug.cgi?id=27549

  • Scripts/check-webkit-style: Support files as argument. Change documentation and use basename on the binary name when used in the documentation. Also do not die when printing something containing non-ASCII characters.
07:54 Changeset [46541] by kenneth@webkit.org

2009-07-29 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

Expose the PluginDatabase::pluginForMIMEType() function as public API.
https://bugs.webkit.org/show_bug.cgi?id=27651

It can be used to determine the appropriate plugin for a mime type,
without guessing the mimetype from the extension.

  • plugins/PluginDatabase.h:
07:36 Changeset [46540] by kenneth@webkit.org

2009-07-29 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Treat.

Allow to enable/disable particular plugin packages.
https://bugs.webkit.org/show_bug.cgi?id=27651

Disabled plugins will not be picked up when looking for a plugin
supporting the requested mimetypes.

Client applications may want to use that API to disable specific
plugins.

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::pluginForMIMEType): (WebCore::PluginDatabase::MIMETypeForExtension):
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::PluginPackage): (WebCore::PluginPackage::setEnabled):
  • plugins/PluginPackage.h: (WebCore::PluginPackage::isEnabled):
06:18 Changeset [46539] by zimmermann@webkit.org

2009-07-29 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by Adam Treat.

[WML] Running WML tests in random order multiple times exposes subtle bugs
https://bugs.webkit.org/show_bug.cgi?id=27801

Some changes to fix random order WML tests, simplilfy WMLTestCase.js and reset testDocument
properly in enter-first-card-with-events.js. fast/wml/err-multi-access.wml still creates a layout
test difference on consecutive runs, though that's related to bug 27721, which has to be fixed first.

  • wml/resources/WMLTestCase.js:
  • wml/resources/enter-first-card-with-events.js: (setupTestDocument): (prepareTest): (executeTest):

2009-07-29 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by Adam Treat.

[WML] Running WML tests in random order multiple times exposes subtle bugs
https://bugs.webkit.org/show_bug.cgi?id=27801

Remove superflous assertions regarding the parent node. Under certain circumstances
these can even fire (related to garbage collection while destructing). Fixes random order
WML tests (run-webkit-tests fast/wml wml http/tests/wml fast/wml ... --random)

The wml/enter-first-card-with-events.html test relied on a bug in our implementation of
WMLPageState::reset() - the history stack should still contain the current card afterwards.
Fix that bug by preserving the first item in BackForwardList::clearWMLPageHistory().

  • history/BackForwardList.cpp: Preserve first item in history stack, as demanded by the spec. (WebCore::BackForwardList::clearWMLPageHistory):
  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::insertedIntoDocument): (WebCore::WMLDoElement::removedFromDocument):
  • wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::insertedIntoDocument):
  • wml/WMLOnEventElement.cpp: (WebCore::eventHandlingParent):
  • wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::insertedIntoDocument): (WebCore::WMLPostfieldElement::removedFromDocument):
  • wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::insertedIntoDocument): (WebCore::WMLSetvarElement::removedFromDocument):
  • wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::insertedIntoDocument): (WebCore::WMLTaskElement::removedFromDocument):
  • wml/WMLTimerElement.cpp: (WebCore::WMLTimerElement::insertedIntoDocument): (WebCore::WMLTimerElement::removedFromDocument):
04:35 Changeset [46538] by ddkilzer@apple.com

<http://webkit.org/b/27119> bugzilla-tool: Add create-bug command

Reviewed by David Levin.

Implement "create-bug" command for bugzilla-tool.

  • Scripts/bugzilla-tool: Added CreateBug class. (CreateBug.init): Added. (CreateBug.create_bug_from_commit): Added. (CreateBug.create_bug_from_patch): Added. (CreateBug.prompt_for_bug_title_and_comment): Added. (CreateBug.execute): Added. (BugzillaTool.init): Added create-bug command.
  • Scripts/modules/bugzilla.py: (Bugzilla.prompt_for_component): Added. (Bugzilla.check_create_bug_response_returning_bug_id_on_success): Added. (Bugzilla.create_bug_with_patch): Added.
04:18 Changeset [46537] by jmalonzo@webkit.org

2009-07-29 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Eric Seidel and Xan Lopez.

[Gtk] Enable http/tests/appcache tests
https://bugs.webkit.org/show_bug.cgi?id=27674

  • GNUmakefile.am: Add webkit/webkitapplicationcache.cpp

Enable passing http/tests/appcache tests.

  • platform/gtk/Skipped:

Add 'enable-offline-web-application-cache' WebSetting to enable
or disable the appcache. Also, Add appcache SPI for DRT to use.

  • webkit/webkitapplicationcache.cpp: Added. (webkit_application_cache_set_maximum_size):
  • webkit/webkitprivate.cpp: (webkit_init):
  • webkit/webkitprivate.h:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):

Add support for testing http/tests/appcache tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAppCacheMaximumSize):
03:50 Changeset [46536] by hausmann@webkit.org

2009-07-29 Simon Hausmann <simon.hausmann@nokia.com>

Update Qt-specific results for computed-style tests, like in r46512.

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
03:33 Changeset [46535] by hausmann@webkit.org

2009-07-29 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=26848
[Qt] ResourceHandle::willLoadFromCache needs to be implemented QtWebKit.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::willLoadFromCache):
  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::willLoadFromCache):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willLoadFromCache):
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::willLoadFromCache):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
02:53 Changeset [46534] by levin@chromium.org

2009-07-29 Alpha Lam <hclam@chromium.org>

Reviewed by David Levin.

Media control panel for <video> in MediaDocument is mis-placed
https://bugs.webkit.org/show_bug.cgi?id=27798

Fixing a rendering problem: When <video> is displayed in MediaDocument,
the media control panel overlaps with the video by 16 pixels.

No new tests as this is covered by existing media tests.

  • css/mediaControlsChromium.css:
02:48 Changeset [46533] by vestbo@webkit.org

Revert r46532 (build-webkit: Reorder logic for determining the baseProductDir)

Broke the Windows build.

02:37 Changeset [46532] by vestbo@webkit.org

2009-07-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Eric Seidel.

build-webkit: Reorder logic for determining the baseProductDir

https://bugs.webkit.org/show_bug.cgi?id=27699

We now do port-spesific probing for the product dir first, and then
fall back to either the generic WEBKITOUTPUTDIR (which now also works
on Mac), or WebKitBuild.

Then we add the git branch if the git branch build option is enabled.

Finally we massage the product dir based on the port. For example the
Mac port will now always set the SYMROOT and OBJROOT configuration for
XCode.

  • Scripts/webkitdirs.pm:
01:36 Changeset [46531] by abarth@webkit.org

2009-07-29 Adam Barth <abarth@webkit.org>

Unreviewed build fix for Chromium. Those last two patches weren't
independent despite the clean merge.

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener):
01:34 Changeset [46530] by hausmann@webkit.org

2009-07-29 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] In debug mode, this fix frees cached resources
and other unreferenced objects (by calling the
garbage collector) to remove the LEAK messages.
https://bugs.webkit.org/show_bug.cgi?id=27767

  • Api/qwebframe.cpp: (qt_drt_cache_clear):
  • QtLauncher/main.cpp: (main):
01:11 Changeset [46529] by abarth@webkit.org

2009-07-29 Avi Drissman <avi@chromium.org>

Reviewed by Darin Adler.

ImageSourceCG makes bad data refs (race condition causes blank images)
https://bugs.webkit.org/show_bug.cgi?id=27777

Make ImageSourceCG guarantee that the lifetime of the SharedBuffer that
backs the CFDataRef will be long enough.

No new tests, as this fixes a bug with a race condition that is
difficult to trigger.

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData):

2009-07-29 Kent Tamura <tkent@chromium.org>

Reviewed by Nikolas Zimmermann.

Fix a bug that HTMLOptionElement::value() returns an incorrect
value in a case that the element has a label attribute and no
value attribute.
https://bugs.webkit.org/show_bug.cgi?id=27760

  • fast/forms/option-value-and-label-expected.txt: Added.
  • fast/forms/option-value-and-label.html: Added.
01:04 Changeset [46528] by levin@chromium.org

2009-07-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by George Staikos.

Resolve class/struct mixup in forward declarations
https://bugs.webkit.org/show_bug.cgi?id=27708

  • API/JSClassRef.h:
  • bytecode/SamplingTool.h:
  • interpreter/Interpreter.h:
  • jit/JIT.h:
  • profiler/ProfileGenerator.h:
  • profiler/Profiler.h:
  • runtime/ClassInfo.h:
  • runtime/ExceptionHelpers.h:
  • runtime/JSByteArray.h:
  • runtime/JSCell.h:
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:
01:04 Changeset [46527] by levin@chromium.org

2009-07-29 Avi Drissman <avi@chromium.org>

Reviewed by Darin Adler.

ImageSourceCG makes bad data refs (race condition causes blank images)
https://bugs.webkit.org/show_bug.cgi?id=27777

Make ImageSourceCG guarantee that the lifetime of the SharedBuffer that
backs the CFDataRef will be long enough.

No new tests, as this fixes a bug with a race condition that is
difficult to trigger.

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData):
01:04 Changeset [46526] by levin@chromium.org

2009-07-29 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Console should show completions for the command line APIs
https://bugs.webkit.org/show_bug.cgi?id=27696

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._reportCompletions): Adds properties from _inspectorCommandLineAPI to completions when available.
  • inspector/front-end/utilities.js: (Object.properties): Added. (Object.sortedProperties):
01:03 Changeset [46525] by levin@chromium.org

2009-07-29 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Refactor the first step of layout in RenderFlexibleBox.cpp
https://bugs.webkit.org/show_bug.cgi?id=27704

No new tests as this change is just a refactoring.

  • rendering/RenderFlexibleBox.cpp: (WebCore::gatherFlexChildrenInfo): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
01:03 Changeset [46524] by levin@chromium.org

2009-07-29 Kent Tamura <tkent@chromium.org>

Reviewed by Nikolas Zimmermann.

Fix a bug that HTMLOptionElement::value() returns an incorrect
value in a case that the element has a label attribute and no
value attribute.
https://bugs.webkit.org/show_bug.cgi?id=27760

WebCore:

Test: fast/forms/option-value-and-label.html

  • dom/OptionElement.cpp: (WebCore::OptionElement::collectOptionLabelOrText): (WebCore::OptionElement::collectOptionInnerText): (WebCore::OptionElement::normalizeText): (WebCore::OptionElement::collectOptionTextRespectingGroupLabel): (WebCore::OptionElement::collectOptionValue):
  • dom/OptionElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::text):
  • wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::text):

LayoutTests:

  • fast/forms/option-value-and-label-expected.txt: Added.
  • fast/forms/option-value-and-label.html: Added.
00:59 Changeset [46523] by abarth@webkit.org

2009-07-29 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Teach V8Proxy::context about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27701

Change V8Proxy::context(Frame*) to understand isolated worlds. Audit
all callers of this method to make sure they want isolated worlds. In
cases where we really want the main world, I've changed the call to
V8Proxy::mainWorldContext(Frame*).


The main visible change is to the document.open method when called with
more than two arguments. This design seems more likely to lead to
future correct code.

Test: http/tests/security/isolatedWorld/document-open.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::ScriptController::evaluate): (WebCore::ScriptController::bindToWindowObject): (WebCore::ScriptController::collectGarbage): (WebCore::createScriptObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
  • bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor): (WebCore::V8DOMWrapper::setHiddenWindowReference): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object):
  • bindings/v8/V8Helpers.cpp: (WebCore::toV8Context):
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListener::getWrappedListenerFunction):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::context): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::bindJsObjectToWindow):
  • bindings/v8/V8Proxy.h:

2009-07-29 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Teach V8Proxy::context about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27701

Test that calling document.open with more than two arguments calls the
window.open method from the correct world.

  • http/tests/security/isolatedWorld/document-open-expected.txt: Added.
  • http/tests/security/isolatedWorld/document-open.html: Added.
00:25 Changeset [46522] by hausmann@webkit.org

2009-07-29 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Fix the Qt build, add missing file.

  • WebCore.pro:
00:13 Changeset [46521] by jhoneycutt@apple.com

2009-07-28 Jon Honeycutt <jhoneycutt@apple.com>

Speculative fix for <rdar://problem/7005077> WER: Crash in
WebCore::PluginStream::destroyStream+279 (1310510882)

Reviewed by Oliver Hunt.

  • plugins/PluginStream.cpp: (WebCore::PluginStream::destroyStream): Move the "protector" RefPtr out of the block that dispatches notifications and into the function level; if NPN_DestroyStream were called from NPP_NewStream as the comment warns, we would be deleted at the end of the block.

07/28/09:

21:54 Changeset [46520] by timothy@apple.com

Allow tabbing through the Web Inspector DOM Storage grid cells when editing.

2009-07-28 Joseph Pecoraro <joepeck02@gmail.com>

Inspector: Tab Through the DOM Storage DataGrid when Editing

https://bugs.webkit.org/show_bug.cgi?id=27746

Reviewed by Timothy Hatcher.

  • inspector/front-end/DOMStorageDataGrid.js: (WebInspector.DOMStorageDataGrid.prototype._startEditingColumnOfDataGridNode): refactored to directly edit and select a column (WebInspector.DOMStorageDataGrid.prototype._startEditing): (WebInspector.DOMStorageDataGrid.prototype._editingCommitted.moveToNextIfNeeded): handles moveDirection on a commit (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): uses moveToNext to traverse appropriately
21:54 Changeset [46519] by timothy@apple.com

Allow creating new DOM Storage items in the Web Inspector.

2009-07-28 Joseph Pecoraro <joepeck02@gmail.com>

Inspector: Create New DOM Storage Items via DataGrid

https://bugs.webkit.org/show_bug.cgi?id=27322

Reviewed by Timothy Hatcher.

  • inspector/front-end/DOMStorageDataGrid.js: (WebInspector.DOMStorageDataGrid.prototype._startEditing): click anyway means creationNode (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): fix unintended globals (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow): creationNode is special case
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.addCreationNode): maintain a quick ref to the single creationNode (WebInspector.CreationDataGridNode): new type of node (WebInspector.CreationDataGridNode.prototype.makeNormal): convert to a normal node
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage): add a creationNode to the GridData
21:53 Changeset [46518] by timothy@apple.com

Automatically refresh DOM Storage grids in the Web Inspector.

2009-07-28 Joseph Pecoraro <joepeck02@gmail.com>

Inspector: Automatically Refresh DOM Storage Grids on "storage" event

https://bugs.webkit.org/show_bug.cgi?id=27400

Reviewed by Timothy Hatcher.

  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.show): trigger adding the listener (WebInspector.DatabasesPanel.prototype.reset): trigger removing the listener (WebInspector.DatabasesPanel.prototype._registerStorageEventListener): register the listener on the inspected window (WebInspector.DatabasesPanel.prototype._unregisterStorageEventListener): unregister the listener on the inspected window (WebInspector.DatabasesPanel.prototype._storageEvent): handle the storage event
21:53 Changeset [46517] by timothy@apple.com

Added support for inspect() in the Web Inspector command line.

2009-07-28 Keishi Hattori <casey.hattori@gmail.com>

Inspector should support inspect() in the command line.

https://bugs.webkit.org/show_bug.cgi?id=19874
rdar://problem/6070225

Reviewed by Timothy Hatcher.

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled.inspectObject): (WebInspector.Console.prototype._ensureCommandLineAPIInstalled):
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.revealAndSelectDomStorage): Added. (WebInspector.DatabasesPanel.prototype.revealAndSelectDatabase): Added. (WebInspector.DatabasesPanel.prototype.showDatabase):
21:53 Changeset [46516] by timothy@apple.com

The rest of: Web Inspector: Add inspected node using public console API.

2009-07-28 Keishi Hattori <casey.hattori@gmail.com>

The rest of: Web Inspector: Add inspected node using public console API.

https://bugs.webkit.org/show_bug.cgi?id=27758

Reviewed by Timothy Hatcher.

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled): Removed _inspectorCommandLineAPI._addInspectedNode. (WebInspector.Console.prototype.addInspectedNode): Added.
21:40 Changeset [46515] by pfeldman@chromium.org

2009-07-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Accept autocomplete on 'End' key pressed.

https://bugs.webkit.org/show_bug.cgi?id=27447.

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.handleKeyEvent):
19:27 Changeset [46514] by levin@chromium.org

2009-07-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by David Levin.

[Qt] Build fix after r46502
https://bugs.webkit.org/show_bug.cgi?id=27789

  • WebCore.pro: Remove StorageArea.cpp
19:14 Applications using WebKit edited by desamo@apple.com
Adding Cha-Ching. (diff)
18:42 Changeset [46513] by mrowe@apple.com

Follow-on fix to r35582. Replace main thread assertions with WebCoreObjCScheduleDeallocateOnMainThread in -dealloc overrides in DOMObject subclasses.

Reviewed by Darin Adler.

  • bindings/scripts/CodeGeneratorObjC.pm:
18:23 Changeset [46512] by mitz@apple.com

Update Window-specific results with the non-prefixed border-radius
properties

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
18:09 Changeset [46511] by adachan@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27236

  • Implement TCMalloc_SystemRelease and TCMalloc_SystemCommit for Windows.
  • Use a background thread to periodically scavenge memory to release back to the system.
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::init): (WTF::TCMalloc_PageHeap::runScavengerThread): (WTF::TCMalloc_PageHeap::scavenge): (WTF::TCMalloc_PageHeap::shouldContinueScavenging): (WTF::TCMalloc_PageHeap::New): (WTF::TCMalloc_PageHeap::AllocLarge): (WTF::TCMalloc_PageHeap::Delete): (WTF::TCMalloc_PageHeap::GrowHeap): (WTF::sleep): (WTF::TCMalloc_PageHeap::scavengerThread):
  • wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease): (TCMalloc_SystemCommit):
  • wtf/TCSystemAlloc.h:
17:49 Changeset [46510] by zimmermann@webkit.org

2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by Adam Treat.

[WML] WML*Element classes mostly implement insertedIntoDocument(), not removedFromDocument()
https://bugs.webkit.org/show_bug.cgi?id=27786

WML*Element classes mostly implement insertedIntoDocument(), not removedFromDocument().
The only case where this is relevant in WML is error handling. The parsed WML
tree fragment is inserted in an XHTML compound error document. This requires
removedFromDocument() to be correctly implemented otherwhise we run into
trouble (visible when using run-webkit-tests fast/wml --random).

  • wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::registerTask): (WebCore::WMLAnchorElement::deregisterTask):
  • wml/WMLAnchorElement.h:
  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::removedFromDocument): (WebCore::WMLDoElement::registerTask): (WebCore::WMLDoElement::deregisterTask):
  • wml/WMLDoElement.h:
  • wml/WMLEventHandlingElement.cpp: (WebCore::WMLEventHandlingElement::registerDoElement): (WebCore::WMLEventHandlingElement::deregisterDoElement):
  • wml/WMLEventHandlingElement.h:
  • wml/WMLFieldSetElement.cpp: (WebCore::WMLFieldSetElement::removedFromDocument):
  • wml/WMLGoElement.cpp: (WebCore::WMLGoElement::registerPostfieldElement): (WebCore::WMLGoElement::deregisterPostfieldElement):
  • wml/WMLGoElement.h:
  • wml/WMLIntrinsicEventHandler.cpp: (WebCore::WMLIntrinsicEventHandler::deregisterIntrinsicEvent):
  • wml/WMLIntrinsicEventHandler.h:
  • wml/WMLOnEventElement.cpp: (WebCore::eventHandlingParent): (WebCore::WMLOnEventElement::registerTask): (WebCore::WMLOnEventElement::deregisterTask):
  • wml/WMLOnEventElement.h:
  • wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::removedFromDocument):
  • wml/WMLPostfieldElement.h:
  • wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::removedFromDocument):
  • wml/WMLSetvarElement.h:
  • wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::removedFromDocument): (WebCore::WMLTaskElement::registerVariableSetter): (WebCore::WMLTaskElement::deregisterVariableSetter): (WebCore::WMLTaskElement::storeVariableState):
  • wml/WMLTaskElement.h:
  • wml/WMLTimerElement.cpp: (WebCore::WMLTimerElement::removedFromDocument):
  • wml/WMLTimerElement.h:
17:33 Changeset [46509] by levin@chromium.org

2009-07-28 David Levin <levin@chromium.org>

Suggested by Drew Wilson.

Speculative gtk build fix, follow up to:
https://bugs.webkit.org/show_bug.cgi?id=27697

  • GNUmakefile.am:
17:16 Changeset [46508] by mitz@apple.com

WebCore:

Reviewed by Simon Fraser.

[CSS3 Backgrounds and Borders] Drop the prefix from the border-radius
properties
https://bugs.webkit.org/show_bug.cgi?id=27578

[CSS3 Backgrounds and Borders] Handle the / and 4 values in
border-radius
https://bugs.webkit.org/show_bug.cgi?id=27584

Test: fast/borders/border-radius-parsing.html

Dropped the -webkit- prefix from the individual corner border-radius
properties. Added border-radius with the / and 4-value syntax, and
maintained -webkit-border-radius with legacy 2-value syntax.

  • css/CSSComputedStyleDeclaration.cpp: (computedProperties): Removed Webkit prefix. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Removed Webkit prefix from the

single-corner properties. Call out to parseBorderRadius() to parse
border-radius and -webkit-border-radius.

(WebCore::completeBorderRadii): Added this helper function that

completes the values for all four corners when fewer than four are
specified.

(WebCore::CSSParser::parseBorderRadius): Added.
(WebCore::cssPropertyID): Map -webkit-border-*-*-radius to the

unprefixed property.

  • css/CSSParser.h:
  • css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap): Removed the Webkit prefix. Added an entry

for border-radius. Kept the entry for -webkit-border-radius.

  • css/CSSPropertyNames.in: Removed the -webkit- prefix from the

single-corenr properties. Added border-radius. Kept
-webkit-border-radius because of its conflicting syntax.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Removed the Webkit prefix.
  • page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap): Ditto.

LayoutTests:

Reviewed by Simon Fraser.

New test, updated test, and updated test results for:

[CSS3 Backgrounds and Borders] Drop the prefix from the border-radius
properties
https://bugs.webkit.org/show_bug.cgi?id=27578

[CSS3 Backgrounds and Borders] Handle the / and 4 values in
border-radius
https://bugs.webkit.org/show_bug.cgi?id=27584

  • fast/borders/border-radius-parsing-expected.txt: Added.
  • fast/borders/border-radius-parsing.html: Added.
  • fast/css/remove-shorthand-expected.txt:
  • fast/css/remove-shorthand.html: Added a test for border-radius.
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
17:08 Changeset [46507] by levin@chromium.org

2009-07-28 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Refactored dedicated-worker-specific code from WorkerThread into DedicatedWorkerThread class.

WorkerThread needs to be refactored to separate out dedicated-worker functionality.
https://bugs.webkit.org/show_bug.cgi?id=27697

This is just a refactoring, so existing tests suffice.

  • GNUmakefile.am: Added DedicatedWorkerThread.h/.cpp
  • WebCore.gypi: Added DedicatedWorkerThread.h/.cpp
  • WebCore.pro: Added DedicatedWorkerThread.h/.cpp
  • WebCore.vcproj/WebCore.vcproj: Added DedicatedWorkerThread.h/.cpp
  • WebCore.xcodeproj/project.pbxproj: Added DedicatedWorkerThread.h/.cpp
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): Removed code to track pending activity - this is handled by DedicatedWorkerContext::importScripts() now.
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): Removed code to track pending activity - this is handled by DedicatedWorkerContext::importScripts() now.
  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::addMessage): Forwards console messages to parent document. (WebCore::DedicatedWorkerContext::importScripts): Now sends the updated pending activity status after importing scripts. (WebCore::DedicatedWorkerContext::thread): Helper routine that casts WorkerThread to DedicatedWorkerThread.
  • workers/DedicatedWorkerContext.h: (WebCore::DedicatedWorkerContext::create):
  • workers/DedicatedWorkerThread.cpp: Added. (WebCore::DedicatedWorkerThread::create): (WebCore::DedicatedWorkerThread::DedicatedWorkerThread): (WebCore::DedicatedWorkerThread::~DedicatedWorkerThread): (WebCore::DedicatedWorkerThread::createWorkerContext): Implementation of the base class factory method to create the appropriate worker context. (WebCore::DedicatedWorkerThread::runEventLoop): Reports pending activity before running the event loop.
  • workers/DedicatedWorkerThread.h: Added. (WebCore::DedicatedWorkerThread::workerObjectProxy): Moved from base class.
  • workers/WorkerContext.cpp:
  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::startWorkerContext): Now creates DedicatedWorkerThread. (WebCore::WorkerMessagingProxy::workerThreadCreated): Now is passed a DedicatedWorkerThread.
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::WorkerThread): Moved workerObjectProxy param into derived class constructor. (WebCore::WorkerThread::workerThread): (WebCore::WorkerThread::runEventLoop): Moved the event loop execution into a virtual function so DedicatedWorkerThread could report pending activity first.
  • workers/WorkerThread.h: (WebCore::WorkerThread::workerContext):
16:29 Changeset [46506] by bweinstein@apple.com

2009-07-28 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Adam Roben.

Add two tests that failed on release (not debug) back to skipped list.

  • platform/win/Skipped:
16:15 Changeset [46505] by mrowe@apple.com

Prevent nightly builds of WebKit from launching against old Safari versions that we no longer work with.

Reviewed by Oliver Hunt.

  • WebKitLauncher/main.m:

(checkSafariVersion): Add a minimum required Safari version of 4.0. This matches the requirement on Windows.
(main): If the minimum version requirement is not met, display an alert and bail out.

16:12 Changeset [46504] by japhet@chromium.org

2009-07-28 Nate Chapin <japhet@chromium.org>

Reviewed by Darin Fisher.

Fix V8NPUtils' handling of UTF8 identifiers.

https://bugs.webkit.org/show_bug.cgi?id=27782

15:38 Changeset [46503] by bweinstein@apple.com

2009-07-28 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Steve Falkenburg.

Remove a lot of tests from Windows Skip list which now pass. Will watch buildbot
to make sure there are no regressions/this commit doesn't cause failures.

  • platform/win/Skipped:
15:26 Changeset [46502] by jorlow@chromium.org

2009-07-28 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Eric Seidel.

Misc cleanup in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=27517

The StorageAreaImpl changes are all for Chromium. Because the DOM Storage implementation
runs in a different process from where the Frame object lives, Chromium passes in NULL
for the sourceFrame. This affects events and handling privateBrowsing. Chromium's
incognito mode does not use the private browsing setting, so that's not a concern. As for
events, I've decided to simply disable them for now.

The StorageNamespaceImpl changes get rid of a stale comment (path is .copy'ed for thread-
safety) and to add an assert that .copy is only ever called on a SessionStorage namespace.

Also cleaned up tailing whitespace in several parts of StorageAreaImpl.cpp

  • storage/StorageArea.cpp: Removed. (It was empty anyway.)
  • storage/StorageAreaImpl.cpp: (WebCore::privateBrowsingEnabled): Factored out the check. (WebCore::StorageAreaImpl::setItem): Make frame optional. (WebCore::StorageAreaImpl::removeItem): ditto (WebCore::StorageAreaImpl::clear): ditto (WebCore::StorageAreaImpl::dispatchStorageEvent): Disable in Chromium for now.
  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): Remove stale comment. (WebCore::StorageNamespaceImpl::copy): Add assert that it's SessionStorage.
14:57 Changeset [46501] by levin@chromium.org

2009-07-28 Alpha Lam <hclam@google.com>

Reviewed by David Levin.

[chromium] Default UI controls for <video> has rendering problems
https://bugs.webkit.org/show_bug.cgi?id=27669

Fixes the bug that <video> in MediaDocument is 1 pixel tall if
it is playing an audio file by changing the style to be 32px
tall.

Also fixes a problem of default styled audio tag that hides the
all the time digits by expanding the width to 300px.

Changed the size and position of the current time and remaining
display to give enough space for the hour digit to be shown.

There are no new tests provided because this is already covered
by existing tests.

  • css/mediaControlsChromium.css:
13:53 Changeset [46500] by jorlow@chromium.org

2009-07-28 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

Add some checks to existing SessionStorage LayoutTests.
https://bugs.webkit.org/show_bug.cgi?id=27776

This is a mixed bag of tweaks to existing tests. This is the sessionStorage
side of https://bugs.webkit.org/show_bug.cgi?id=27695

  • storage/domstorage/sessionstorage/delete-removal-expected.txt:
  • storage/domstorage/sessionstorage/delete-removal.html:

Made output more readable, added redundant deletes, added deletes to
keys with the same name in different case.

  • storage/domstorage/sessionstorage/enumerate-storage.html:

Removed dead code.

  • storage/domstorage/sessionstorage/enumerate-with-length-and-key-expected.txt: Copied from LayoutTests/storage/domstorage/sessionstorage/enumerate-storage-expected.txt.
  • storage/domstorage/sessionstorage/enumerate-with-length-and-key.html: Copied from LayoutTests/storage/domstorage/sessionstorage/enumerate-storage.html.

Test enumerating by hand (with length+key).

  • storage/domstorage/sessionstorage/iframe-events-expected.txt:
  • storage/domstorage/sessionstorage/iframe-events.html:

Test removeItem and clear in addition to setItem.

  • storage/domstorage/sessionstorage/onstorage-attribute-setwindow-expected.txt: Copied from LayoutTests/storage/domstorage/sessionstorage/onstorage-attribute-setattribute-expected.txt.
  • storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html: Copied from LayoutTests/storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html.

Test using window.onstorage.

13:29 Changeset [46499] by kenneth@webkit.org

2009-07-28 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

Fix style in PluginPackage and PluginDatabase.
Part of https://bugs.webkit.org/show_bug.cgi?id=27651

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::refresh): (WebCore::PluginDatabase::findPlugin):
  • plugins/PluginDatabase.h:
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::~PluginPackage): (WebCore::PluginPackage::freeLibrarySoon): (WebCore::PluginPackage::freeLibraryTimerFired): (WebCore::PluginPackage::unloadWithoutShutdown): (WebCore::PluginPackage::initializeBrowserFuncs):
  • plugins/PluginPackage.h:
13:28 Changeset [46498] by jorlow@chromium.org

2009-07-28 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

Add some checks to existing DOM Storage LayoutTests.
https://bugs.webkit.org/show_bug.cgi?id=27695

This is really a mixed bag of tweaks to existing tests.

  • storage/domstorage/localstorage/delete-removal-expected.txt:
  • storage/domstorage/localstorage/delete-removal.html:

Made output more readable, added redundant deletes, added deletes to
keys with the same name in different case.

  • storage/domstorage/localstorage/enumerate-storage.html:

Removed dead code.

  • storage/domstorage/localstorage/enumerate-with-length-and-key-expected.txt: Added.
  • storage/domstorage/localstorage/enumerate-with-length-and-key.html: Copied from LayoutTests/storage/domstorage/localstorage/enumerate-storage.html.

Test enumerating by hand (with length+key).

  • storage/domstorage/localstorage/iframe-events-expected.txt:
  • storage/domstorage/localstorage/iframe-events.html:

Test removeItem and clear in addition to setItem.

  • storage/domstorage/localstorage/onstorage-attribute-setwindow-expected.txt: Copied from LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setattribute-expected.txt.
  • storage/domstorage/localstorage/onstorage-attribute-setwindow.html: Copied from LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setattribute.html.

Test using window.onstorage.

  • storage/domstorage/window-attributes-exist-expected.txt:
  • storage/domstorage/window-attributes-exist.html:

Verify that two consecutive calls to window.Storage will equal each other.

12:46 Changeset [46497] by kenneth@webkit.org

2009-07-28 Kenneth Rohde Christiansen <kenneth@webkit.org>

Fix the Qt build by adapting to the changes of ScriptObject.

  • Api/qwebelement.cpp: (setupScriptObject):
12:33 Changeset [46496] by dglazkov@chromium.org

2009-07-28 Anantanarayanan Iyengar <ananta@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=27769
The V8 bindings function V8Proxy::createNewContext can be
called during frame shutdown where the activeDocumentLoader
function in FrameLoader can return NULL. Added a check for the
same.

No new tests added as this is an edge case where the V8
bindings code is reentered via NPAPI during shutdown. It is
difficult to write a consistently reproducible test for this.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createNewContext):
12:28 WebKit Team edited by jeremy@chromium.org
(diff)
12:25 Changeset [46495] by dglazkov@chromium.org

2009-07-28 Ivan Posva <iposva@chromium.org>

Reviewed by Dimitri Glazkov.

Associate the CanvasPixelData backing store with the
indexed properties of the wrapper object.

https://bugs.webkit.org/show_bug.cgi?id=27773

No new tests: Relying on existing Canvas tests.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertToV8Object):
11:58 Changeset [46494] by levin@chromium.org

2009-07-28 Maxime Simon <simon.maxime@gmail.com>

Reviewed by David Levin.

Added FrameLoaderClient for Haiku WebCore support.
https://bugs.webkit.org/show_bug.cgi?id=26952

  • haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp: Added. (WebCore::FrameLoaderClientHaiku::FrameLoaderClientHaiku): (WebCore::FrameLoaderClientHaiku::setFrame): (WebCore::FrameLoaderClientHaiku::setWebView): (WebCore::FrameLoaderClientHaiku::detachFrameLoader): (WebCore::FrameLoaderClientHaiku::hasWebView): (WebCore::FrameLoaderClientHaiku::hasBackForwardList): (WebCore::FrameLoaderClientHaiku::resetBackForwardList): (WebCore::FrameLoaderClientHaiku::provisionalItemIsTarget): (WebCore::FrameLoaderClientHaiku::makeRepresentation): (WebCore::FrameLoaderClientHaiku::forceLayout): (WebCore::FrameLoaderClientHaiku::forceLayoutForNonHTML): (WebCore::FrameLoaderClientHaiku::updateHistoryForCommit): (WebCore::FrameLoaderClientHaiku::updateHistoryForBackForwardNavigation): (WebCore::FrameLoaderClientHaiku::updateHistoryForReload): (WebCore::FrameLoaderClientHaiku::updateHistoryForStandardLoad): (WebCore::FrameLoaderClientHaiku::updateHistoryForInternalLoad): (WebCore::FrameLoaderClientHaiku::updateHistoryAfterClientRedirect): (WebCore::FrameLoaderClientHaiku::setCopiesOnScroll): (WebCore::FrameLoaderClientHaiku::tokenForLoadErrorReset): (WebCore::FrameLoaderClientHaiku::resetAfterLoadError): (WebCore::FrameLoaderClientHaiku::doNotResetAfterLoadError): (WebCore::FrameLoaderClientHaiku::willCloseDocument): (WebCore::FrameLoaderClientHaiku::detachedFromParent2): (WebCore::FrameLoaderClientHaiku::detachedFromParent3): (WebCore::FrameLoaderClientHaiku::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientHaiku::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientHaiku::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientHaiku::dispatchWillClose): (WebCore::FrameLoaderClientHaiku::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientHaiku::dispatchDidCommitLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidFinishLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidFirstLayout): (WebCore::FrameLoaderClientHaiku::dispatchDidFirstVisuallyNonEmptyLayout): (WebCore::FrameLoaderClientHaiku::dispatchShow): (WebCore::FrameLoaderClientHaiku::cancelPolicyCheck): (WebCore::FrameLoaderClientHaiku::dispatchWillSubmitForm): (WebCore::FrameLoaderClientHaiku::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientHaiku::revertToProvisionalState): (WebCore::FrameLoaderClientHaiku::postProgressStartedNotification): (WebCore::FrameLoaderClientHaiku::postProgressEstimateChangedNotification): (WebCore::FrameLoaderClientHaiku::postProgressFinishedNotification): (WebCore::FrameLoaderClientHaiku::progressStarted): (WebCore::FrameLoaderClientHaiku::progressCompleted): (WebCore::FrameLoaderClientHaiku::setMainFrameDocumentReady): (WebCore::FrameLoaderClientHaiku::willChangeTitle): (WebCore::FrameLoaderClientHaiku::didChangeTitle): (WebCore::FrameLoaderClientHaiku::finishedLoading): (WebCore::FrameLoaderClientHaiku::canShowMIMEType): (WebCore::FrameLoaderClientHaiku::representationExistsForURLScheme): (WebCore::FrameLoaderClientHaiku::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientHaiku::frameLoadCompleted): (WebCore::FrameLoaderClientHaiku::saveViewStateToItem): (WebCore::FrameLoaderClientHaiku::restoreViewState): (WebCore::FrameLoaderClientHaiku::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientHaiku::provisionalLoadStarted): (WebCore::FrameLoaderClientHaiku::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoaderClientHaiku::addHistoryItemForFragmentScroll): (WebCore::FrameLoaderClientHaiku::didFinishLoad): (WebCore::FrameLoaderClientHaiku::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientHaiku::setTitle): (WebCore::FrameLoaderClientHaiku::userAgent): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientHaiku::frameLoaderDestroyed): (WebCore::FrameLoaderClientHaiku::canHandleRequest): (WebCore::FrameLoaderClientHaiku::partClearedInBegin): (WebCore::FrameLoaderClientHaiku::updateGlobalHistory): (WebCore::FrameLoaderClientHaiku::updateGlobalHistoryRedirectLinks): (WebCore::FrameLoaderClientHaiku::shouldGoToHistoryItem): (WebCore::FrameLoaderClientHaiku::saveScrollPositionAndViewStateToItem): (WebCore::FrameLoaderClientHaiku::canCachePage): (WebCore::FrameLoaderClientHaiku::setMainDocumentError): (WebCore::FrameLoaderClientHaiku::committedLoad): (WebCore::FrameLoaderClientHaiku::cancelledError): (WebCore::FrameLoaderClientHaiku::blockedError): (WebCore::FrameLoaderClientHaiku::cannotShowURLError): (WebCore::FrameLoaderClientHaiku::interruptForPolicyChangeError): (WebCore::FrameLoaderClientHaiku::cannotShowMIMETypeError): (WebCore::FrameLoaderClientHaiku::fileDoesNotExistError): (WebCore::FrameLoaderClientHaiku::shouldFallBack): (WebCore::FrameLoaderClientHaiku::createDocumentLoader): (WebCore::FrameLoaderClientHaiku::download): (WebCore::FrameLoaderClientHaiku::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientHaiku::dispatchWillSendRequest): (WebCore::FrameLoaderClientHaiku::shouldUseCredentialStorage): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientHaiku::dispatchDidCancelAuthenticationChallenge): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveContentLength): (WebCore::FrameLoaderClientHaiku::dispatchDidFinishLoading): (WebCore::FrameLoaderClientHaiku::dispatchDidFailLoading): (WebCore::FrameLoaderClientHaiku::dispatchDidLoadResourceFromMemoryCache): (WebCore::FrameLoaderClientHaiku::dispatchDidLoadResourceByXMLHttpRequest): (WebCore::FrameLoaderClientHaiku::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientHaiku::dispatchDidFailLoad): (WebCore::FrameLoaderClientHaiku::dispatchCreatePage): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForMIMEType): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientHaiku::dispatchUnableToImplementPolicy): (WebCore::FrameLoaderClientHaiku::startDownload): (WebCore::FrameLoaderClientHaiku::createFrame): (WebCore::FrameLoaderClientHaiku::objectContentType): (WebCore::FrameLoaderClientHaiku::createPlugin): (WebCore::FrameLoaderClientHaiku::redirectDataToPlugin): (WebCore::FrameLoaderClientHaiku::pluginWillHandleLoadError): (WebCore::FrameLoaderClientHaiku::createJavaAppletWidget): (WebCore::FrameLoaderClientHaiku::overrideMediaType): (WebCore::FrameLoaderClientHaiku::windowObjectCleared): (WebCore::FrameLoaderClientHaiku::documentElementAvailable): (WebCore::FrameLoaderClientHaiku::didPerformFirstNavigation): (WebCore::FrameLoaderClientHaiku::registerForIconNotification): (WebCore::FrameLoaderClientHaiku::savePlatformDataToCachedFrame): (WebCore::FrameLoaderClientHaiku::transitionToCommittedFromCachedFrame): (WebCore::FrameLoaderClientHaiku::transitionToCommittedForNewPage):
  • haiku/WebCoreSupport/FrameLoaderClientHaiku.h: Added. (WebCore::FrameLoaderClientHaiku::~FrameLoaderClientHaiku):
11:58 Changeset [46493] by levin@chromium.org

2009-07-28 Maxime Simon <simon.maxime@gmail.com>

Reviewed by David Levin.

Added ChromeClient for Haiku WebCore support.
https://bugs.webkit.org/show_bug.cgi?id=26952

  • haiku/WebCoreSupport/ChromeClientHaiku.cpp: Added. (WebCore::ChromeClientHaiku::ChromeClientHaiku): (WebCore::ChromeClientHaiku::~ChromeClientHaiku): (WebCore::ChromeClientHaiku::chromeDestroyed): (WebCore::ChromeClientHaiku::setWindowRect): (WebCore::ChromeClientHaiku::windowRect): (WebCore::ChromeClientHaiku::pageRect): (WebCore::ChromeClientHaiku::scaleFactor): (WebCore::ChromeClientHaiku::focus): (WebCore::ChromeClientHaiku::unfocus): (WebCore::ChromeClientHaiku::canTakeFocus): (WebCore::ChromeClientHaiku::takeFocus): (WebCore::ChromeClientHaiku::createWindow): (WebCore::ChromeClientHaiku::createModalDialog): (WebCore::ChromeClientHaiku::show): (WebCore::ChromeClientHaiku::canRunModal): (WebCore::ChromeClientHaiku::runModal): (WebCore::ChromeClientHaiku::setToolbarsVisible): (WebCore::ChromeClientHaiku::toolbarsVisible): (WebCore::ChromeClientHaiku::setStatusbarVisible): (WebCore::ChromeClientHaiku::statusbarVisible): (WebCore::ChromeClientHaiku::setScrollbarsVisible): (WebCore::ChromeClientHaiku::scrollbarsVisible): (WebCore::ChromeClientHaiku::setMenubarVisible): (WebCore::ChromeClientHaiku::menubarVisible): (WebCore::ChromeClientHaiku::setResizable): (WebCore::ChromeClientHaiku::addMessageToConsole): (WebCore::ChromeClientHaiku::canRunBeforeUnloadConfirmPanel): (WebCore::ChromeClientHaiku::runBeforeUnloadConfirmPanel): (WebCore::ChromeClientHaiku::closeWindowSoon): (WebCore::ChromeClientHaiku::runJavaScriptAlert): (WebCore::ChromeClientHaiku::runJavaScriptConfirm): (WebCore::ChromeClientHaiku::runJavaScriptPrompt): (WebCore::ChromeClientHaiku::setStatusbarText): (WebCore::ChromeClientHaiku::shouldInterruptJavaScript): (WebCore::ChromeClientHaiku::tabsToLinks): (WebCore::ChromeClientHaiku::windowResizerRect): (WebCore::ChromeClientHaiku::repaint): (WebCore::ChromeClientHaiku::scroll): (WebCore::ChromeClientHaiku::screenToWindow): (WebCore::ChromeClientHaiku::windowToScreen): (WebCore::ChromeClientHaiku::platformWindow): (WebCore::ChromeClientHaiku::contentsSizeChanged): (WebCore::ChromeClientHaiku::scrollRectIntoView): (WebCore::ChromeClientHaiku::addToDirtyRegion): (WebCore::ChromeClientHaiku::scrollBackingStore): (WebCore::ChromeClientHaiku::updateBackingStore): (WebCore::ChromeClientHaiku::mouseDidMoveOverElement): (WebCore::ChromeClientHaiku::setToolTip): (WebCore::ChromeClientHaiku::print): (WebCore::ChromeClientHaiku::exceededDatabaseQuota): (WebCore::ChromeClientWx::reachedMaxAppCacheSize): (WebCore::ChromeClientHaiku::requestGeolocationPermissionForFrame): (WebCore::ChromeClientHaiku::runOpenPanel): (WebCore::ChromeClientHaiku::setCursor): (WebCore::ChromeClientHaiku::formStateDidChange): (WebCore::ChromeClientHaiku::createHTMLParserQuirks):
  • haiku/WebCoreSupport/ChromeClientHaiku.h: Added.
10:34 Changeset [46492] by xan@webkit.org

2009-07-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Nuke all references to JSWorkerContextBase.lut.h, it was removed
back in April.

  • GNUmakefile.am:
09:52 Changeset [46491] by hausmann@webkit.org

2009-07-28 Robert Agoston <Agoston.Robert@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Fixed references to script generate-webkitversion.pl, and
removed duplicated generate-webkitversion.pl

https://bugs.webkit.org/show_bug.cgi?id=27158

  • WebCore.pro:
  • platform/generate-webkitversion.pl: Removed.
09:04 Changeset [46490] by pfeldman@chromium.org

2009-07-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dmitry Glazkov.

Web Inspector: encapsulate ScriptState into the ScriptObject, get rid of
InspectorJSONObject.

https://bugs.webkit.org/show_bug.cgi?id=27766

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/ScriptArray.cpp: (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::set): (WebCore::ScriptArray::length): (WebCore::ScriptArray::createNew):
  • bindings/js/ScriptArray.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::construct):
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::ScriptObject): (WebCore::ScriptObject::set): (WebCore::ScriptObject::createNew): (WebCore::ScriptGlobalObject::get):
  • bindings/js/ScriptObject.h:
  • bindings/js/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
  • bindings/v8/ScriptArray.cpp: (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::set): (WebCore::ScriptArray::length): (WebCore::ScriptArray::createNew):
  • bindings/v8/ScriptArray.h:
  • bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::construct):
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::ScriptObject): (WebCore::ScriptObject::set): (WebCore::ScriptObject::createNew): (WebCore::ScriptGlobalObject::get):
  • bindings/v8/ScriptObject.h: (WebCore::ScriptObject::ScriptObject):
  • bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole):
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::newScriptArray): (WebCore::InspectorFrontend::newScriptObject): (WebCore::InspectorFrontend::addMessageToConsole): (WebCore::InspectorFrontend::addResource): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::addDOMStorage):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorJSONObject.cpp: Removed.
  • inspector/InspectorJSONObject.h: Removed.
  • inspector/InspectorResource.cpp: (WebCore::populateHeadersObject): (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject):
08:41 Changeset [46489] by kov@webkit.org

Tagging 1.1.12.

08:35 Changeset [46488] by levin@chromium.org

2009-07-28 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

cpplint* should be named cpp_style*
https://bugs.webkit.org/show_bug.cgi?id=27752

The files were renamed. A few renames were done:

CppLint -> CppStyle
cpplint -> cpp_style

  • Scripts/check-webkit-style:
  • Scripts/modules/cpp_style.py: Copied from cpplint.py and did name fix ups.
  • Scripts/modules/cpp_style_unittest.py: Copied from cpplint_unittest.py and did name fix ups.
  • Scripts/modules/cpplint.py: Removed.
  • Scripts/modules/cpplint_unittest.py: Removed.
08:34 Changeset [46487] by zimmermann@webkit.org

2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Variable substitution recursion seems to have bugs
https://bugs.webkit.org/show_bug.cgi?id=27726

Allow <setvar> elements to depend on the value specified by preceeding <setvar> elements.
Required by the specification - assure it only works in linear order. A setvar element may
not depend on the variable state of a following setvar element, only the previous ones.

Extend wml/variable-reference-valid.html layout test to cover these cases.

  • wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::storeVariableState):

2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Variable substitution recursion seems to have bugs
https://bugs.webkit.org/show_bug.cgi?id=27726

Extend variable-reference-valid.html to test <setvar> attribute values depending on each other.

  • wml/resources/variable-reference-valid.js: (setupTestDocument): (prepareTest): (executeTest):
  • wml/variable-reference-valid-expected.txt:
08:03 Changeset [46486] by zimmermann@webkit.org

2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Page title doesn't update after variable substitution, if it contained variables
https://bugs.webkit.org/show_bug.cgi?id=27725

Fix bug in containsVariableReference() function, we we're decreasing the nameEndPosition
too much, leading to a bug with 1-char variable names, which were not detected properly.

Extend wml/variable-reference-valid.html layout test to cover 1-char variable names.
Also fixes manual-tests/wml/task-refresh-in-anchor.wml, which happened to use 1-char variable names.

  • wml/WMLVariables.cpp: (WebCore::containsVariableReference):

2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Page title doesn't update after variable substitution, if it contained variables
https://bugs.webkit.org/show_bug.cgi?id=27725

Extend variable-reference-valid.html test to include one-character variable tests.

  • wml/resources/variable-reference-valid.js: (setupTestDocument): (prepareTest): (executeTest):
  • wml/variable-reference-valid-expected.txt:
07:58 Changeset [46485] by hausmann@webkit.org

WebCore:

2009-07-28 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

Add WebKit version API to Qt.

Get the current version of WebKit from WebKit/mac/Configurations/Version.xcconfig
at compile time and make it available to webkit ports through WebKitVersion.h.

https://bugs.webkit.org/show_bug.cgi?id=27158

  • WebCore.pro: Call generate-webkitversion.pl

WebKit:

2009-07-28 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

Add WebKit version API to Qt.

Get the current version of WebKit from WebKit/mac/Configurations/Version.xcconfig
at compile time and make it available to webkit ports through WebKitVersion.h.

https://bugs.webkit.org/show_bug.cgi?id=27158

  • scripts/generate-webkitversion.pl: Added

WebKit/qt:

2009-07-28 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

Add WebKit version API to Qt.

Get the current version of WebKit from WebKit/mac/Configurations/Version.xcconfig
at compile time and make it available to Qt applications through
qWebKitVersion().

Also amend the User Agent string to place the Safari clause outside
the final bracket and to the end of the UA string.

https://bugs.webkit.org/show_bug.cgi?id=27158

Minor build tweak by Simon Hausmann (adding export macros to new functions).

  • Api/headers.pri:
  • Api/qwebkitversion.cpp: Added. (webKitVersion): (webKitMajorVersion): (webKitMinorVersion):
  • Api/qwebkitversion.h: Added.
  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::getWebKitVersion):
07:57 Changeset [46484] by kov@webkit.org

2009-07-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed make dist build fix.

  • GNUmakefile.am:
07:41 Changeset [46483] by treat@webkit.org

2009-07-28 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Replace hardcoded separator text with proper separator.
Also adjusts include order as per style guidelines.

https://bugs.webkit.org/show_bug.cgi?id=27763

  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::populate):
07:26 Changeset [46482] by hausmann@webkit.org

2009-07-28 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Ariya Hidayat.

Fix compilation with the precompiled header.

  • WebKit_pch.h: Don't include JSDOMBinding.h and MathObject.h, as they include AtomicString.h. AtomicString.cpp needs to enable a #define before including AtomicString.h, which breaks if the PCH forces the inclusion beforehand.
06:53 EFLWebKit edited by tonikitoo@gmail.com
(diff)
06:34 Changeset [46481] by xan@webkit.org

2009-07-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Use automake 1.11 SILENT_RULES when present, for cleaner build
output. You can disable it by passing --disable-silent-rules to
configure or V=1 to make.

  • autotools/dolt.m4:
  • configure.ac:
06:33 Changeset [46480] by vestbo@webkit.org

2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Steve Falkenburg.

Add output directory for VS pre-build steps to enable out-of-tree builds

https://bugs.webkit.org/show_bug.cgi?id=27700

The tmp.obj file is now placed in the intermediate build directory.

  • WebCore.vcproj/WebCoreCommon.vsprops:

2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Steve Falkenburg.

Add output directory for VS pre-build steps to enable out-of-tree builds

https://bugs.webkit.org/show_bug.cgi?id=27700

The tmp.obj file is now placed in the intermediate build directory.

  • WebKit.vcproj/WebKit.vcproj:
06:30 Changeset [46479] by pfeldman@chromium.org

2009-07-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add inspected node using public console API.

https://bugs.webkit.org/show_bug.cgi?id=27758

  • inspector/front-end/Console.js: (WebInspector.Console.prototype.addInspectedNode):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel):
06:26 Changeset [46478] by ariya@webkit.org

2009-07-28 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

Added tests to ensure that scroll position can be changed
programmatically, even when the scroll bar policy is set to off.

  • tests/qwebframe/tst_qwebframe.cpp:
06:23 Changeset [46477] by vestbo@webkit.org

2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Rubber-stamped by Holger Freyther.

Add Steve Falkenburg to bugzilla-tools' reviewers list

  • Scripts/modules/bugzilla.py:
06:12 Changeset [46476] by vestbo@webkit.org

2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Fix a few compilation warnings in the QWebFrame tests.

  • tests/qwebframe/tst_qwebframe.cpp:
06:04 Changeset [46475] by hausmann@webkit.org

2009-07-28 Andre Pedralho <andre.pedralho@openbossa.org>

Reviewed by Simon Hausmann.

Fixed tst_QWebFrame::hasSetFocus test which was using
an undefined resource.
https://bugs.webkit.org/show_bug.cgi?id=27512

  • tests/qwebframe/tst_qwebframe.cpp:
05:47 Changeset [46474] by zimmermann@webkit.org

2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] <do> elements with a <noop> task shouldn't be exposed to the user
https://bugs.webkit.org/show_bug.cgi?id=27724

Fix WMLNoopElement to disable it's parent WMLDoElement, as required by the spec.
Moved manual-tests/wml/task-noop-in-do.wml to LayoutTests/fast/wml/task-noop-in-do.wml.

  • manual-tests/wml/task-noop-in-do.wml: Removed.
  • wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::insertedIntoDocument):

2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] <do> elements with a <noop> task shouldn't be exposed to the user
https://bugs.webkit.org/show_bug.cgi?id=27724

Add new layout test covering noop elements in do elements.

  • fast/wml/task-noop-in-do.wml: Copied from WebCore/manual-tests/wml/task-noop-in-do.wml.
  • platform/mac/fast/wml/task-noop-in-do-expected.checksum: Added.
  • platform/mac/fast/wml/task-noop-in-do-expected.png: Added.
  • platform/mac/fast/wml/task-noop-in-do-expected.txt: Added.
05:40 Changeset [46473] by xan@webkit.org

2009-07-28 Xan Lopez <xlopez@igalia.com>

Add new files, fixes distcheck.

  • GNUmakefile.am:
05:35 Changeset [46472] by hausmann@webkit.org

2009-07-28 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Determining whether to use JIT or interpreter
moved from JavaScriptCore.pri to Platform.h

05:27 Changeset [46471] by hausmann@webkit.org

.:

2009-07-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Disable some compiler warnings for the win build
https://bugs.webkit.org/show_bug.cgi?id=27709

  • WebKit.pri:

WebCore:

2009-07-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Disable some compiler warnings for the win build
https://bugs.webkit.org/show_bug.cgi?id=27709

  • WebCore.pro: Move the msvc options to WebKit.pri
04:48 Changeset [46470] by hausmann@webkit.org

2009-07-28 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

Implement test result archive support for the Qt port.

  • BuildSlaveSupport/test-result-archive:
04:12 Changeset [46469] by kov@webkit.org

WebCore

2009-07-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Tor Arne Vestbø

Make equality checks for logging channel names ignore casing.

  • platform/Logging.cpp: (WebCore::getChannelFromName):

WebKit/gtk

2009-07-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Add information about the regression fix for WEBKIT_DEBUG.

  • NEWS:
04:02 Changeset [46468] by jmalonzo@webkit.org

2009-07-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Refactor ResourceHandleSoup - make start* functions static
https://bugs.webkit.org/show_bug.cgi?id=27687

  • platform/network/ResourceHandle.h:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startData): (WebCore::startHttp): (WebCore::):
03:58 Changeset [46467] by xan@webkit.org

2009-07-28 Priit Laes <plaes@plaes.org>

Reviewed by Xan Lopez.

Fix mnemonics in the soup authentication dialog.

  • webkit/webkitsoupauthdialog.c: (show_auth_dialog):
03:52 Changeset [46466] by xan@webkit.org

2009-07-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Do not cache the pango layout in the object, since the layout of
the page can change between calls.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
03:39 Changeset [46465] by xan@webkit.org

2009-07-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

  • configure.ac: bump version for 1.1.12 release.

WebKit/gtk:

2009-07-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

  • NEWS: update for 1.1.12 release.
02:20 Changeset [46464] by hausmann@webkit.org

2009-07-28 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Make it possible to pass relative file names to QtLauncher.

  • QtLauncher/main.cpp: (MainWindow::MainWindow):
02:00 Changeset [46463] by hausmann@webkit.org

2009-07-27 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Adam Treat.

update qt expefic expected files for fast/css/getComputedStyle/ tests after r46274
https://bugs.webkit.org/show_bug.cgi?id=27714

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
01:27 Changeset [46462] by abarth@webkit.org

2009-07-23 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Simplify management of Nodes in weak handles callbacks.
https://bugs.webkit.org/show_bug.cgi?id=27628

  • bindings/v8/V8DOMMap.cpp: (WebCore::weakNodeCallback):
01:14 Changeset [46461] by bweinstein@apple.com

2009-07-28 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by David Levin.

Fix error handling of GetIconInfo (returns a bool).

  • platform/win/DragImageWin.cpp: (WebCore::createDragImageIconForCachedImage):
00:11 Changeset [46460] by bweinstein@apple.com

2009-07-27 Brian Weinstein <bweinstein@apple.com>

Reviewed by Jon Honeycutt.

Fix of <rdar://5015949> Drag Icon is not produced for over sized images.

Implemented the createDragImageIconForCachedImage function by using the Windows
SHFILEINFO structure.

  • platform/win/DragImageWin.cpp: (WebCore::createDragImageIconForCachedImage):

07/27/09:

23:05 Changeset [46459] by abarth@webkit.org

2009-07-25 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[V8] Split up V8DOMMap.cpp by class
https://bugs.webkit.org/show_bug.cgi?id=27685

No behavior change. Just copy-and-paste.

  • WebCore.gypi:
  • bindings/v8/ChildThreadDOMData.cpp: Added. (WebCore::ChildThreadDOMData::ChildThreadDOMData): (WebCore::ChildThreadDOMData::getStore):
  • bindings/v8/ChildThreadDOMData.h: Added.
  • bindings/v8/DOMData.cpp: Added. (WebCore::DOMData::DOMData): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getCurrentMainThread): (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::ensureDeref): (WebCore::DOMData::derefObject): (WebCore::DOMData::derefDelayedObjects): (WebCore::DOMData::derefDelayedObjectsInCurrentThread): (WebCore::DOMData::removeObjectsFromWrapperMap):
  • bindings/v8/DOMData.h: Added. (WebCore::):
  • bindings/v8/DOMDataStore.cpp: Added. (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStore::allStores): (WebCore::DOMDataStore::allStoresMutex): (WebCore::DOMDataStore::getDOMWrapperMap): (WebCore::forget): (WebCore::DOMDataStore::weakDOMObjectCallback): (WebCore::DOMDataStore::weakActiveDOMObjectCallback): (WebCore::DOMDataStore::weakNodeCallback): (WebCore::DOMDataStore::weakSVGElementInstanceCallback): (WebCore::DOMDataStore::weakSVGObjectWithContextCallback):
  • bindings/v8/DOMDataStore.h: Added. (WebCore::DOMDataStore::): (WebCore::DOMDataStore::InternalDOMWrapperMap::InternalDOMWrapperMap): (WebCore::DOMDataStore::InternalDOMWrapperMap::forgetOnly): (WebCore::DOMDataStore::domData): (WebCore::DOMDataStore::domNodeMap): (WebCore::DOMDataStore::domObjectMap): (WebCore::DOMDataStore::activeDomObjectMap): (WebCore::DOMDataStore::domSvgElementInstanceMap): (WebCore::DOMDataStore::domSvgObjectWithContextMap):
  • bindings/v8/MainThreadDOMData.cpp: Added. (WebCore::MainThreadDOMData::MainThreadDOMData): (WebCore::MainThreadDOMData::getStore):
  • bindings/v8/MainThreadDOMData.h: Added.
  • bindings/v8/ScopedDOMDataStore.cpp: Added. (WebCore::ScopedDOMDataStore::ScopedDOMDataStore): (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
  • bindings/v8/ScopedDOMDataStore.h: Added.
  • bindings/v8/StaticDOMDataStore.cpp: Added. (WebCore::StaticDOMDataStore::StaticDOMDataStore):
  • bindings/v8/StaticDOMDataStore.h: Added.
  • bindings/v8/V8DOMMap.cpp:
22:24 Changeset [46458] by beidson@apple.com

2009-07-27 Brady Eidson <beidson@apple.com>

Update Tiger specific results for these 7 tests.

  • platform/mac-tiger/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/mac-tiger/security/block-test-expected.txt:
  • platform/mac-tiger/security/block-test-no-port-expected.txt:
21:53 Changeset [46457] by beidson@apple.com

2009-07-27 Brady Eidson <beidson@apple.com>

Update Windows specific results for these 5 tests.

  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt:
21:50 Changeset [46456] by beidson@apple.com

2009-07-27 Brady Eidson <beidson@apple.com>

Didn't mean to check this guy in.

  • http/tests/appcache/max-size-expected.txt:
21:29 Changeset [46455] by beidson@apple.com

WebKitTools:

2009-07-27 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=27755
Layout tests that dump resource load delegate calls should dump the request method and the response status code.

  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURLResponse _drt_descriptionSuitableForTestResult]): (-[NSURLRequest _drt_descriptionSuitableForTestResult]):
  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (descriptionSuitableForTestResult):

LayoutTests:

2009-07-27 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=27755
Layout tests that dump resource load delegate calls should dump the request method and the response status code.

Update test results for the new info.

  • fast/loader/main-document-url-for-non-http-loads-expected.txt:
  • http/tests/appcache/max-size-expected.txt:
  • http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
  • http/tests/misc/window-dot-stop-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt:
  • platform/mac/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • platform/mac/security/block-test-expected.txt:
  • platform/mac/security/block-test-no-port-expected.txt:
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:
19:50 UsingGitWithWebKit edited by pdherbemont@apple.com
--regenerate-log (diff)
19:29 Changeset [46454] by pdherbemont@apple.com

2009-07-27 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by David Levin.

"bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load.
https://bugs.webkit.org/show_bug.cgi?id=27747

modules.bugzilla is not found because not included.

  • Scripts/modules/scm.py: Properly import modules.bugzilla.
19:28 Changeset [46453] by pdherbemont@apple.com

2009-07-24 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by David Kilzer.

commit-log-editor should allow git commit --amend to regenerate the commit log based on the modifed ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=27664

  • Scripts/commit-log-editor: Add --regenerate-log option. The user is asked if he wants to suppress previous ChangeLog and regenerate it, if this option is enabled.
19:25 Changeset [46452] by mrowe@apple.com

Versioning.

19:24 Changeset [46451] by mrowe@apple.com

New tag.

18:57 Changeset [46450] by mrowe@apple.com

Merge r46449.

18:49 Changeset [46449] by mrowe@apple.com

<rdar://problem/7091036> REGRESSION: Microsoft Messenger crashes during file send/receive due to use of WebKit on non-main thread

Reviewed by Darin Adler.

In some situations Microsoft Messenger can attempt to manipulate the DOM from a secondary thread while
updating its file transfer progress bar. This results in corruption of WebCore data structures that is
quickly followed by a crash. We can work around this by having -[WebFrame DOMDocument] return nil when
called from a secondary thread by Microsoft Messenger, which has the effect of turning its attempts at
DOM manipulation in to no-ops.

  • WebView/WebFrame.mm:

(needsMicrosoftMessengerDOMDocumentWorkaround):
(-[WebFrame DOMDocument]):

Add a method for detecting if we're being used within Microsoft Messenger.

  • WebCore.base.exp: Export applicationIsMicrosoftMessenger and sort existing entries.
  • platform/mac/RuntimeApplicationChecks.h:
  • platform/mac/RuntimeApplicationChecks.mm:

(WebCore::applicationIsMicrosoftMessenger):

18:11 Changeset [46448] by jianli@chromium.org

2009-07-27 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

[V8] Implement EventListener::reportError for V8 event listeners in worker context.
https://bugs.webkit.org/show_bug.cgi?id=27731

  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::reportError):
  • bindings/v8/V8WorkerContextEventListener.h:
17:50 Changeset [46447] by levin@chromium.org

2009-07-27 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel and David Levin.

Re-apply chromium/skia border fix (originally landed in r46157,
reverted in r46363), since it was not the cause of the reliability
failures in Chromium.

http://bugs.webkit.org/show_bug.cgi?id=27388

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
17:47 Changeset [46446] by rniwa@webkit.org

WebCore:

2009-07-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

createMarkup does not handle CSS properly
https://bugs.webkit.org/show_bug.cgi?id=27660

This patch isolates code that creates markup for styles in addStyleMarkup
It also makes all presentational elements (u, s, strike, i, em, b, strong) special ancestor in createMarkup
so that we can assume no text decoration style is passed to addStyleMarkup.

  • editing/markup.cpp: (WebCore::propertyMissingOrEqualToNone): Changed the first argument from CSSMutableStyleDecleration to CSSStyleDeclaration (WebCore::isElementPresentational): Used to be elementHasTextDecorationProperty, now supports presentational tags (WebCore::addStyleMarkup): Adds markup for style span and div (WebCore::createMarkup): Uses isElementPresentational and addStyleMarkup

LayoutTests:

2009-07-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

createMarkup does not handle CSS properly
https://bugs.webkit.org/show_bug.cgi?id=27660


inline-style-after-indentoutdent tests whether the original inline style is preserved after outdentation
immediately after indentation.

  • editing/deleting/pruning-after-merge-2.html: Replaced b that contains div with a div with font-weight
  • editing/execCommand/inline-style-after-indentoutdent-expected.txt: Added.
  • editing/execCommand/inline-style-after-indentoutdent.html: Added.
  • editing/execCommand/resources/inline-style-after-indentoutdent.js: Added. (testCreateMarkup): (shouldBeSameAfterCreateMarkup):
  • platform/mac/editing/deleting/delete-3857753-fix-expected.txt: extra i tag is added (still passes pixel tests)
  • platform/mac/editing/deleting/pruning-after-merge-2-expected.txt: extra div as explained above
  • platform/mac/editing/pasteboard/display-block-on-spans-expected.txt: bug 26483 appearing
17:35 Changeset [46445] by zimmermann@webkit.org

Rubber-stamped by George Staikos.
Forgot to update pixel test results a while ago.

17:21 Changeset [46444] by eric@webkit.org

2009-07-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

fix more obvious global object lookups
https://bugs.webkit.org/show_bug.cgi?id=27745

No new tests for these changes. I believe in many cases
testing to be impossible. Lack of testing justification next to
each change below. The remaining pieces of bug 27634 will all
need tests.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::updateDocument): not testable.
  • bindings/js/JSDataGridColumnListCustom.cpp: (WebCore::JSDataGridColumnList::nameGetter): no testing for this incomplete feature.
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent): would require outer frame to trigger an event in the inner frame
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): covered by other tests, always correct to pass the globalObject through.
  • bindings/js/JSHTMLElementCustom.cpp: (WebCore::JSHTMLElement::pushEventHandlerScope): unclear when this could be triggered.
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::remove): toJS seems superfluous here to begin with.
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): would require outer frame to trigger inner frame event.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::jsObjectForPluginElement): only used for NPAPI binding, unclear how to test.
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): unclear how to test.
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set): unclear how to test/inspector only.
  • bindings/js/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject): unclear how to test.
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]): unclear how to test.
17:16 Changeset [46443] by zimmermann@webkit.org

2009-07-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] 'title' attribute handling not correct for <a> / <anchor> elements
https://bugs.webkit.org/show_bug.cgi?id=27720

Unify title() implementation in WMLElement instead of several copies of the same logic.
We forgot WMLAnchorElement/WMLAElement, that lead to bugs. Fixes hovering links in the
WML manual-test suite.

  • wml/WMLCardElement.cpp:
  • wml/WMLCardElement.h:
  • wml/WMLElement.cpp: (WebCore::WMLElement::title):
  • wml/WMLElement.h:
  • wml/WMLOptGroupElement.cpp:
  • wml/WMLOptGroupElement.h:
  • wml/WMLSelectElement.cpp:
  • wml/WMLSelectElement.h:
16:28 Changeset [46442] by bweinstein@apple.com

Build fix for Windows.

16:21 Changeset [46441] by bweinstein@apple.com

Build fix for Windows for JSC recent breakage.

16:21 Changeset [46440] by eric@webkit.org

2009-07-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

prototypes-inheritance-2.html should crawl more types
https://bugs.webkit.org/show_bug.cgi?id=27741

Now we evaluate the crawl targets lazily so as not to skew any JS binding caching with our test ordering.
We could get around all caching by always instantiating a new copy of the frame
but that would be super-slow. :)

We're now crawling a bunch more types, all of which we pass.

  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/resources/prototype-inheritance-2.js: (evalToCrawlObject.LazyEvalCrawlObject): (evalToCrawlObject): (pushPropertyValuesWithUnseenTypes): (crawl):
16:19 Changeset [46439] by treat@webkit.org

2009-07-27 Adam Treat <adam.treat@torchmobile.com>

Speculative build fix for Windows and WinCE.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
15:56 Changeset [46438] by barraclough@apple.com

2009-07-27 Gavin Barraclough <barraclough@apple.com>

Rubber stamped by Oliver Hunt.

Fix tyop in JIT, renamed preverveReturnAddressAfterCall -> preserveReturnAddressAfterCall.

  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::preserveReturnAddressAfterCall):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
15:45 Changeset [46437] by ojan@chromium.org

2009-07-27 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27474
Tests crashes when calling select, setSelectionRange or setting
selectionStart/selectionEnd on a textarea/input immediately after
setting display:none.

  • fast/dom/text-control-crash-on-select-expected.txt: Added.
  • fast/dom/text-control-crash-on-select.html: Added.

2009-07-27 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27474
Fixes crashes due to renderer getting destroyed in updateLayout.
We need to call updateLayout before we call into the renderer.
Removed the updateLayout call from RenderTextControl and moved it
into the calling sites.

Also changes updateLayout to updateLayoutIgnorePendingStylesheets so
this works with pending stylesheets. Unfortunately, this seems to be
untestable. Loading an external stylesheet and then having an inline
script hit this code did not result in an pending stylesheets.

The are other cases of this bug in the rendering code. I'll file a
followup bug to audit the calls to updateLayout.

Test: fast/dom/text-control-crash-on-select.html

  • dom/Document.h: (WebCore::Document::inStyleRecalc): Added so the ASSERTs in updateFocusAppearance

and setSelectionRange could deal with cases of reentrancy into updateLayout
calls. This happens in a couple layout tests.

  • dom/InputElement.cpp: (WebCore::InputElement::updateSelectionRange):
  • html/HTMLInputElement.cpp: (WebCore::isTextFieldWithRendererAfterUpdateLayout): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select):
  • html/HTMLTextAreaElement.cpp: (WebCore::rendererAfterUpdateLayout): (WebCore::HTMLTextAreaElement::setSelectionStart): (WebCore::HTMLTextAreaElement::setSelectionEnd): (WebCore::HTMLTextAreaElement::select): (WebCore::HTMLTextAreaElement::setSelectionRange): (WebCore::HTMLTextAreaElement::updateFocusAppearance):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setSelectionRange):
15:43 Changeset [46436] by ap@webkit.org

Gtk build fix.

  • runtime/JSLock.cpp: (JSC::JSLock::JSLock): Fix "no threading" case.
15:40 Changeset [46435] by dglazkov@chromium.org

2009-07-27 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Dave Levin.

[V8] Remove parameterless frame/window retrieval methods from V8Proxy.
https://bugs.webkit.org/show_bug.cgi?id=27737

Refactoring, no new behavior, covered by existing tests.

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/V8NPUtils.cpp: (convertV8ObjectToNPVariant): Ditto.
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieve): Ditto. (WebCore::V8Proxy::canAccessPrivate): Ditto.
  • bindings/v8/V8Proxy.h: Removed parameterless retrieveWindow/retrieveProxy decls.
  • bindings/v8/custom/V8DatabaseCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Changed to use V8Proxy::retrieveFrameForCurrentContext().
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8SQLTransactionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
15:36 Changeset [46434] by ap@webkit.org

Gtk build fix.

  • webkit/webkitwebframe.cpp: (webkit_gc_count_javascript_objects): Added a namespace to SilenceAssertionsOnly.
15:26 Changeset [46433] by ap@webkit.org

Release build fix.

  • runtime/JSLock.h: (JSC::JSLock::~JSLock):
15:18 Changeset [46432] by zimmermann@webkit.org

WebCore:

2009-07-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] 'onpick' intrinsic event handling missing
https://bugs.webkit.org/show_bug.cgi?id=27723

Trigger 'onpick' intrinsic events from WMLOptionElement::setSelectedState().
All was in place, just forgot to enable the relevant code.

Fixes manual-tests/wml/select-onpick-event.wml
Test: wml/option-element-onpick.html

  • wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::setSelectedState):

LayoutTests:

2009-07-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] 'onpick' intrinsic event handling missing
https://bugs.webkit.org/show_bug.cgi?id=27723

Add a new WML layout test covering 'onpick' support.

  • wml/option-element-onpick-expected.txt: Added.
  • wml/option-element-onpick.html: Added.
  • wml/resources/option-element-onpick.js: Added. (setupTestDocument): (prepareTest): (executeTest):
15:07 Changeset [46431] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27735
Give a helpful name to JSLock constructor argument

15:00 Changeset [46430] by treat@webkit.org

2009-07-27 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

WINCE PORT: Make plugin work for WINCE
https://bugs.webkit.org/show_bug.cgi?id=27713

  • plugins/win/PluginDatabaseWin.cpp: (SHGetValue): (PathRemoveFileSpec): (WebCore::addWindowsMediaPlayerPluginDirectory): (WebCore::addMacromediaPluginDirectories):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
  • plugins/win/PluginViewWin.cpp: (WebCore::registerPluginView): (WebCore::PluginView::wndProc): (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paintWindowedPluginIntoContext): (WebCore::PluginView::paint): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::stop): (WebCore::PluginView::init):
14:58 Changeset [46429] by timothy@apple.com

Adds support to the Web Inspector for tabbing through element attributes and CSS properties when editing.

2009-07-27 Joseph Pecoraro <joepeck02@gmail.com>

Inspector: Tab Through Element Attributes and CSS Properties When Editing

https://bugs.webkit.org/show_bug.cgi?id=27673

Reviewed by Timothy Hatcher.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._startEditing): refactored parameter (WebInspector.ElementsTreeElement.prototype._addNewAttribute): refactored to remove excess (WebInspector.ElementsTreeElement.prototype._triggerEditAttribute): provide an attribute name and this will start editing it (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded): move between attributes (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.StylePropertiesSection.prototype.findTreeElementWithName): search through treeElements for a style property name (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): initialize a blank property for adding new properties (WebInspector.StylePropertyTreeElement.prototype.updateTitle): add references to the name and value elements (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.js: (WebInspector.startEditing.editingCommitted): include the move direction as a parameter to the commit callback (WebInspector.startEditing.element.handleKeyEvent): handle the tab key to specify the move direction (WebInspector.startEditing):
14:31 Changeset [46428] by treat@webkit.org

2009-07-27 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add mapping FontWeight to QFont::Weight values as requested via FIXME.
https://bugs.webkit.org/show_bug.cgi?id=27663

  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::toQFontWeight):
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
14:21 WebKit Team edited by abarth@webkit.org
(diff)
14:21 Changeset [46427] by treat@webkit.org

2009-07-27 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Treat.

When clearing the plugin database, clear also the timestamp map.

https://bugs.webkit.org/show_bug.cgi?id=27651

Currently, if we clear the database, it will still think that it is up
to date with the plugin directories so refreshing the database again
after changing the search paths may not work.

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::clear):
14:17 Changeset [46426] by jianli@chromium.org

2009-07-27 Albert J. Wong <ajwong@chromium.org>

Reviewed by David Levin.

Add in trivial implementation of FontPlatformData::description() for
linux to fix build bustage in chromium.

Fix chromium linux build by adding missing function implementation.
https://bugs.webkit.org/show_bug.cgi?id=27732

Tested with a build of chromium on linux.

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::description):
  • platform/graphics/chromium/FontPlatformDataLinux.h:
12:45 QtWebKitTodo edited by andre.pedralho@openbossa.org
(diff)
12:09 Changeset [46425] by bfulgham@webkit.org

2009-07-27 Brent Fulgham <bfulgham@webkit.org>

Build correct, no review.

Final correction for WinCairo builds.
CoreServices only exists in Apple builds, but
some of its internal includes (e.g., <windows.h>) are needed
for other Windows targets.

  • WebCorePrefix.h: When building for WinCairo, make sure to include <windows.h>, <stdio.h>, and <ConditionalMacros.h>
11:54 Changeset [46424] by pkasting@chromium.org

2009-07-27 Peter Kasting <pkasting@google.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=27323
Correctly parse command output, even when the line endings are not LF,
so that we don't create an autoversion.h that MSVC chokes on.

  • win/tools/scripts/auto-version.sh:
11:32 Changeset [46423] by pkasting@chromium.org

WebCore:

2009-07-27 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25552
Added new "pattern" attribute to HTMLInputElement and validation code
(validity.patternMismatch) as per HTML5 specs.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-pattern

Tests: fast/forms/ValidityState-002.html

fast/forms/ValidityState-patternMismatch-001.html
fast/forms/ValidityState-patternMismatch-002.html
fast/forms/ValidityState-patternMismatch-003.html
fast/forms/ValidityState-patternMismatch-004.html
fast/forms/ValidityState-patternMismatch-005.html
fast/forms/ValidityState-patternMismatch-006.html
fast/forms/ValidityState-patternMismatch-007.html
fast/forms/pattern-attribute-001.html
fast/forms/pattern-attribute-002.html
fast/forms/pattern-attribute-003.html

  • html/HTMLAttributeNames.in: pattern attribute
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::patternMismatch): method definition
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::patternMismatch): validation method
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • html/ValidityState.h: (WebCore::ValidityState::patternMismatch): validation flag

LayoutTests:

2009-07-27 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25552
First series of tests for the "pattern" attribute and related validation
code

  • fast/forms/ValidityState-002-expected.txt: Copied from LayoutTests/fast/forms/willvalidate-001-expected.txt.
  • fast/forms/ValidityState-002.html: Added.
  • fast/forms/ValidityState-patternMismatch-001-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-001.html: Added.
  • fast/forms/ValidityState-patternMismatch-002-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-002.html: Added.
  • fast/forms/ValidityState-patternMismatch-003-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-003.html: Added.
  • fast/forms/ValidityState-patternMismatch-004-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-004.html: Added.
  • fast/forms/ValidityState-patternMismatch-005-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-005.html: Added.
  • fast/forms/ValidityState-patternMismatch-006-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-006.html: Added.
  • fast/forms/ValidityState-patternMismatch-007-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-007.html: Added.
  • fast/forms/pattern-attribute-001-expected.txt: Added.
  • fast/forms/pattern-attribute-001.html: Added.
  • fast/forms/pattern-attribute-002-expected.txt: Added.
  • fast/forms/pattern-attribute-002.html: Added.
  • fast/forms/pattern-attribute-003-expected.txt: Added.
  • fast/forms/pattern-attribute-003.html: Added.
11:22 Changeset [46422] by zimmermann@webkit.org

Reviewed by George Staikos.

[WML] Manual WML tests aren't properly working
https://bugs.webkit.org/show_bug.cgi?id=27718

Fix file paths in the manual WML layout tests, remove unneeded tests (already covered by DRT tests).
Add missing resources directory and test image. Reformat all testcases to a common style.
Add new StartTests.wml file, which should be used as starting point to crawl through the manual tests.

Filing bugs soon for all tests exposing bugs (7 in total).

11:17 Changeset [46421] by japhet@chromium.org

2009-07-27 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a regression introduced in r42671, which caused the js event
object to be hidden (some websites depend on being able to access it).

https://bugs.webkit.org/show_bug.cgi?id=27719

11:08 Changeset [46420] by dglazkov@chromium.org

2009-07-27 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Removing a no-op block of code in DatabaseTracker.cpp that
should've been removed in the patch for bug 26054.

https://bugs.webkit.org/show_bug.cgi?id=27666

All tests in WebCore/storage pass.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): Removed a no-op block of code that was moved to SQLiteFileSystem.cpp and should have been removed from DatabaseTracker.cpp
10:45 Changeset [46419] by jianli@chromium.org

WebCore:

2009-07-27 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Fix error handling in dedicated worker and worker context.
https://bugs.webkit.org/show_bug.cgi?id=27525

The following problems have been fixed:
1) The uncaught runtime script error is not reported using the
WorkerGlobalScope object's onerror attribute.
2) If the error is still not handled afterwards (onerror attribute
is not defined as a function or it returns true), the error should
be reported back to the associated Worker object by firing an
ErrorEvent.
3) If the error is still not handled by the associated Worker
object, the error should be reported to the user.

Test: fast/workers/worker-script-error.html

  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::reportError):
  • bindings/js/JSEventListener.h:
  • dom/EventListener.h: (WebCore::EventListener::reportError): adds a function to call EventListener as a function with 3 arguments to report an error.
  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::dispatchScriptErrorEvent):
  • workers/AbstractWorker.h:
  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::reportException):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::reportException):
  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerExceptionTask::performTask):
  • workers/WorkerMessagingProxy.h:

LayoutTests:

2009-07-27 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

Layout tests for fixing error handling in dedicated worker and worker
context.
https://bugs.webkit.org/show_bug.cgi?id=27525

  • fast/workers/resources/worker-error-in-handling-script-error.js: Added
  • fast/workers/resources/worker-invalid-syntax.js: Added.
  • fast/workers/resources/worker-script-error-bubbled.js: Added.
  • fast/workers/resources/worker-script-error-handled.js: Added.
  • fast/workers/resources/worker-script-error-unhandled.js: Added.
  • fast/workers/worker-constructor.html:
  • fast/workers/worker-script-error-expected.txt: Added.
  • fast/workers/worker-script-error.html: Added. Add test cases to cover different script error handling scenarios.
10:04 Changeset [46418] by zimmermann@webkit.org

[WML] History handling / page cache / loading is buggy and depends on several hacks
https://bugs.webkit.org/show_bug.cgi?id=27707

Redesign WML history/loading handling. See ChangeLog for details.

08:09 Changeset [46417] by pfeldman@chromium.org

2009-07-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Adam Roben.

Fix Chromium build breakage introduced in 46388.

https://bugs.webkit.org/show_bug.cgi?id=27705

  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::description):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h:
06:41 Changeset [46416] by hausmann@webkit.org

2009-07-27 Gabor Rapcsanyi <rapcsanyi.gabor@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Generating remote links causes a lot of unnecessary spew on Qt build bot too

  • Scripts/run-webkit-tests:
04:34 Changeset [46415] by hausmann@webkit.org

2009-07-27 Volker Hilsheimer <volker.hilsheimer@nokia.com>

Reviewed by Simon Hausmann.

QWebView's "enabled" parameter should default to true, as with QGraphicsView and
QPainter.

  • Api/qwebview.cpp: Add reference to QPainter::renderHints().
  • Api/qwebview.h: Add default for enabled argument.
04:29 Changeset [46414] by vestbo@webkit.org

2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Add some more debug logging to PluginViewMac.

  • plugins/mac/PluginViewMac.cpp:
04:27 Changeset [46413] by vestbo@webkit.org

2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Jan Michael Alonzo.

Remove dead code from the GTK NPAPI implementation.

  • plugins/gtk/PluginViewGtk.cpp:
04:06 Changeset [46412] by jmalonzo@webkit.org

2009-07-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Add fast/canvas/image-pattern-rotate.html to Skipped as it needs
platform-specific expected results.

  • platform/gtk/Skipped:
03:39 Changeset [46411] by hausmann@webkit.org

2009-07-27 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Buildfix on Windows.
https://bugs.webkit.org/show_bug.cgi?id=27702

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::hookedEndPaint):

Constraint of (*endPaint) operand modified from "g" to "m" (memory) in inline
assembly, because with "g" constraint, wrong assembly code generated.

02:06 Changeset [46410] by pfeldman@chromium.org

2009-07-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebCore bindings: Implement ScriptArray bindings.

https://bugs.webkit.org/show_bug.cgi?id=27691

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptArray.cpp: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::handleException): (WebCore::ScriptArray::set): (WebCore::length): (WebCore::ScriptArray::createNew):
  • bindings/js/ScriptArray.h: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::jsArray):
  • bindings/v8/ScriptArray.cpp: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::set): (WebCore::ScriptArray::length): (WebCore::ScriptArray::createNew):
  • bindings/v8/ScriptArray.h: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::~ScriptArray):
00:17 Changeset [46409] by bfulgham@webkit.org

2009-07-27 Brent Fulgham <bfulgham@webkit.org>

Build correct, no review.

Change in r46407 broke Apple Windows build.
Switch to WinCairo-only test, to avoid any
other platform break.

  • WebCorePrefix.h:
00:02 Changeset [46408] by bfulgham@webkit.org

2009-07-26 Brent Fulgham <bfulgham@webkit.org>

Build correct, no review.

Change in r46407 broke Apple Windows build.

  • WebCorePrefix.h: Use WTF_PLATFORM_CG to decide if CoreServices.h should be included.
Note: See TracTimeline for information about the timeline view.