Timeline


and

08/03/09:

23:34 Changeset [46747] by abarth@webkit.org
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixup ChangeLog

23:14 Changeset [46746] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-03 Harald Fernengel <harald.fernengel@nokia.com>

Reviewed by NOBODY

Fix ambiguity in abs(long int) call by calling labs() instead

  • wtf/DateMath.cpp: replace call to abs() with labs()
22:39 Changeset [46745] by levin@chromium.org
  • 5 edits in trunk/WebCore

2009-08-03 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>

Reviewed by David Levin.

[V8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource): (WebCore::WebCoreStringResource::data): (WebCore::WebCoreStringResource::length): (WebCore::WebCoreStringResource::webcoreString): (WebCore::WebCoreStringResource::atomicString): (WebCore::WebCoreStringResource::toStringResource): (WebCore::v8StringToWebCoreString): (WebCore::v8StringToAtomicWebCoreString): (WebCore::v8ValueToWebCoreString): (WebCore::v8ValueToAtomicWebCoreString):
  • bindings/v8/V8Binding.h: (WebCore::):
  • dom/Document.idl:
19:24 UsingGitWithWebKit edited by joepeck02@gmail.com
Added Section on Ignores (diff)
19:21 Changeset [46744] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-08-03 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: DOM Storage Live Updating Should Not Affect Tabbing
https://bugs.webkit.org/show_bug.cgi?id=27957

  • inspector/front-end/DOMStorageDataGrid.js: (WebInspector.DOMStorageDataGrid.prototype._startEditingColumnOfDataGridNode): disable storage event listener (WebInspector.DOMStorageDataGrid.prototype._startEditing): disable storage event listener (WebInspector.DOMStorageDataGrid.prototype._editingCancelled): enable storage event listener
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype._unregisterStorageEventListener): quick return if no listener
19:14 Changeset [46743] by abarth@webkit.org
  • 6 edits in trunk

2009-08-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Consolidate common gcc flags to WebKit.pri
https://bugs.webkit.org/show_bug.cgi?id=27934

2009-08-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Consolidate common gcc flags to WebKit.pri
https://bugs.webkit.org/show_bug.cgi?id=27934

  • WebCore.pro:

2009-08-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Consolidate common gcc flags to WebKit.pri
https://bugs.webkit.org/show_bug.cgi?id=27934

  • WebKit.pri:
18:29 Changeset [46742] by pkasting@chromium.org
  • 3 edits in trunk/WebKitTools

2009-08-03 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Handle any kind of line endings in svn-apply and svn-unapply, instead
of assuming LF.

  • Scripts/svn-apply:
  • Scripts/svn-unapply:
18:08 Changeset [46741] by jorlow@chromium.org
  • 7 edits in trunk/WebCore

2009-08-03 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Chromium code sometimes isn't sandboxed and needs to access the FS.
https://bugs.webkit.org/show_bug.cgi?id=27954

These changes are the WebKit side of http://codereview.chromium.org/159778 which
aims to make LocalStorage persistent.

This change runs all FileSystem routines through the ChromiumBridge so that
WebKitClients can handle them if they choose to. For now, the only such client
will be the one running in the browser process.

It also adds a method called sandboxEnabled to the Chromium bridge so that the
SQLite file system code can shift its behavior depending on whether we're
inside a sandbox or not.

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileModificationTime): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists):
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::openDatabase):
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):
17:43 Changeset [46740] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2009-08-03 Alpha Lam <hclam@chromium.org>

Reviewed by David Levin.

[chromium] Implement media slider for chromium
https://bugs.webkit.org/show_bug.cgi?id=27859

Implemented the media slider for chromium port. The implementation
is using Skia for drawing the thumb and buffered region instead of
using any native system controls so different platforms would have
the same look and feel.

No new tests because this is covered by existing tests.

  • css/mediaControlsChromium.css:
  • rendering/RenderThemeChromiumSkia.cpp:
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeChromiumWin.cpp:
17:28 Changeset [46739] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-08-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool land-patches needs --queue mode
https://bugs.webkit.org/show_bug.cgi?id=27961

Add a --commit-queue command line option to suppress user interaction.

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
16:48 Changeset [46738] by pkasting@chromium.org
  • 12 edits in trunk/WebCore

2009-07-27 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26460
Plumbing and cleanup in advance of returning multiple frames from the
ICOImageDecoder:

  • Make ImageDecoder::frameCount() return a size_t like ImageSource::frameCount() and BitmapImage::frameCount() already do.
  • Add ImageDecoder::frameSizeAtIndex() alongside size(), to report the size of a particular frame. Hook all the ImageSource::frameSizeAtIndex() implementations to this. No ImageDecoder implements this yet; that will come in my next change.
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::frameCount): returns size_t.
  • platform/graphics/qt/ImageDecoderQt.h: frameCount() returns size_t.
  • platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/graphics/win/ImageCGWin.cpp: (WebCore::BitmapImage::drawFrameMatchingSourceSize): frameCount() returns size_t.
  • platform/graphics/win/ImageCairoWin.cpp: (WebCore::BitmapImage::drawFrameMatchingSourceSize): frameCount() returns size_t.
  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::size): Clarify comment. (WebCore::ImageDecoder::frameSizeAtIndex): Add. (WebCore::ImageDecoder::frameCount): returns size_t. (WebCore::ImageDecoder::frameBufferAtIndex): Remove unneeded param name.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameCount): returns size_t. (WebCore::GIFImageDecoder::frameBufferAtIndex): frameCount() returns size_t.
  • platform/image-decoders/gif/GIFImageDecoder.h: frameCount() returns size_t.
16:42 Changeset [46737] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Build fix. Add installsrc, installhdrs and install targets.

  • DumpRenderTree/mac/PerlSupport/Makefile:
15:59 Changeset [46736] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-08-03 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Darin Adler.

Fix a bug that could cause an ASSERT to fail incorrectly, leading
to a renderer crash in Chromium.

https://bugs.webkit.org/show_bug.cgi?id=27947

All tests in storage/ pass.

  • platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::~SQLiteTransaction): (WebCore::SQLiteTransaction::begin):
15:05 Changeset [46735] by mrowe@apple.com
  • 4 edits in trunk/WebKitSite

Update two WordPress plug-ins that we use.

  • blog/wp-content/plugins/akismet/akismet.php:
  • blog/wp-content/plugins/akismet/readme.txt:
  • blog/wp-content/plugins/commentcontrol.php:
15:02 Changeset [46734] by mrowe@apple.com
  • 1 edit
    2 copies
    15 moves
    114 adds
    129 deletes in trunk/WebKitSite

Add some missing files and delete some obsolete files.

  • blog:
14:55 Changeset [46733] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-03 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

Based on work by Yael Aharon.

Implement keyboard event forwarding for windowless plugins
for the Qt port.

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::dispatchNPEvent): (WebCore::setSharedXEventFields): (WebCore::setXKeyEventSpecificFields): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
  • xml/NativeXPathNSResolver.cpp:
14:28 Changeset [46732] by timothy@apple.com
  • 8 edits
    1 move
    2 adds in trunk/WebCore

Make the bottom "drawer" of the Web Inspector more extensible to support other views.

2009-08-03 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Make Bottom "Drawer" More Extensible To Support Other Views
https://bugs.webkit.org/show_bug.cgi?id=27928

  • English.lproj/localizedStrings.js:

"Show changes view", "Hide changes view", "Clear changes log", "%d style change", "%d style changes"

To be a new view to show Changes made via the inspector. DOM, CSS, or otherwise.

  • inspector/front-end/Console.js: Removed.

Sliding View aspect moved to Drawer.js. The "console" itself has moved to ConsoleView.js

  • inspector/front-end/ConsoleView.js: Added.

Little has changed from its move from Console.js other then support for working with the Drawer.

Allow for multiple views inside the Sliding Drawer.

Starting work on the "Changes" Panel. The ability to generate a Stylesheet from Styles added via the Inspector.

  • inspector/front-end/Images/styleIcon.png: Added.
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.isInspectorStylesheet): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.makeNormal): (WebInspector.StylePropertyTreeElement.prototype):

Interface with ElementsPanel for generating a Stylesheet of Changes.

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: Refactored to allow for multiple views in the drawer.
  • inspector/front-end/inspector.html: Refactored to allow for multiple views in the drawer.

Support for the drawer and "styles changed icon" similar to the "errors and warnings" icons.

14:24 Changeset [46731] by mrowe@apple.com
  • 338 edits
    18 copies
    1 move
    133 adds
    14 deletes in trunk/WebKitSite

Update WordPress to the latest version.

  • blog:
14:00 Changeset [46730] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-03 Dean McNamee <deanm@chromium.org>

Reviewed by Adam Barth.

Correct an assert on a PassRefPtr in the v8 svg bindings.
https://bugs.webkit.org/show_bug.cgi?id=27951

  • bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::V8SVGDynamicPODTypeWrapper::V8SVGDynamicPODTypeWrapper):
13:23 Changeset [46729] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-03 Jan Michael Alonzo <jmalonzo@webkit.org>

[Gtk] Skip accessibility/input-slider.html as it needs
Accessibility support in DRT which the Gtk do not have an
implementation at the moment.

  • platform/gtk/Skipped:
13:00 Changeset [46728] by weinig@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2009-08-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Sam Weinig.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27748
crash w/ stack overflow when same CSS file loaded repeatedly

Fix crash caused by a stack overflow when repeatedly loading very large
CSS files. CSSRuleData in CSSStyleSelector.h destroyed itself
recursively rather than iteratively.

Test: fast/css/large-list-of-rules-crash.html

  • css/CSSStyleSelector.h: (WebCore::CSSRuleData::~CSSRuleData): (WebCore::CSSRuleDataList::~CSSRuleDataList):

LayoutTests:

2009-08-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Sam Weinig.

Test for https://bugs.webkit.org/show_bug.cgi?id=27748
crash w/ stack overflow when same CSS file loaded repeatedly

Fix crash caused by a stack overflow when repeatedly loading very large
CSS files. CSSRuleData in CSSStyleSelector.h destroyed itself
recursively rather than iteratively.

  • fast/css/large-list-of-rules-crash-expected.txt: Added.
  • fast/css/large-list-of-rules-crash.html: Added.
  • fast/css/resources/large-list-of-rules-crash.css: Added.
12:40 Changeset [46727] by simon.fraser@apple.com
  • 20 edits in trunk

2009-08-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Make the DRT APIs to pause transitions and animations work for accelerated animations
<https://bugs.webkit.org/show_bug.cgi?id=27627>
<rdar://problem/6442932>

Fix the 'pauseAnimationAtTimeOnElementWithId' and 'pauseTransitionAtTimeOnElementWithId' APIs
available to LayoutTests to work with accelerated animations and transitions. Done by sending
the pause time down to the GraphicsLayer, and using it to stop time on the layer.

I also added an assertion to check that the animation has actually started when we
try to pause it, to check that the pause time we compute is valid. This revealed a number
of tests that tried to pause before animations started, required some amount of test fixing.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::freezeAtTime):
  • page/animation/AnimationBase.h:
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::pauseTransitionAtTime):
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::suspendAnimations):
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::suspendAnimations):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::suspendAnimations):
  • rendering/RenderLayerBacking.h:
11:47 Changeset [46726] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-03 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

Fix Chromium build by removing PluginView.h from Page.cpp.
Chromium doesn't use PluginView and the pointer is never
dereferenced so the header doesn't need to be included.
https://bugs.webkit.org/show_bug.cgi?id=27946

No new tests because this is a build fix.

  • page/Page.cpp:
11:46 Changeset [46725] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed the Tiger build.

  • wtf/FastMalloc.cpp:
11:34 Changeset [46724] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Don't use background thread to scavenge memory on Tiger until we figure out why it causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=27900

  • wtf/FastMalloc.cpp:
11:00 Changeset [46723] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-08-03 Eric Carlson <eric.carlson@apple.com>

One more build fix after https://bugs.webkit.org/show_bug.cgi?id=46720.

Unreviewed.

  • WebCoreSources.bkl:
10:34 Changeset [46722] by eric.carlson@apple.com
  • 5 edits in trunk/WebCore

2009-08-03 Eric Carlson <eric.carlson@apple.com>

Build fix after https://bugs.webkit.org/show_bug.cgi?id=46720.

Unreviewed.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
10:13 Changeset [46721] by cfleizach@apple.com
  • 6 edits
    2 adds in trunk

Bug 27943 - Need to implement ARIA role="radiogroup"
https://bugs.webkit.org/show_bug.cgi?id=27943

10:07 Changeset [46720] by eric.carlson@apple.com
  • 14 edits
    4 adds in trunk

2009-08-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

HTMLInputElement is not controllable by assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=27941

Test: accessibility/input-slider.html

  • WebCore.xcodeproj/project.pbxproj:

Add AccessibilitySlider.cpp/.h

  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate):

Create AccessibilitySlider and AccessibilitySliderThumb.

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::increment): (WebCore::AccessibilityObject::decrement):

Add default, do nothing, base class methods.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::canSetFocusAttribute):

Correct typo.

  • accessibility/AccessibilitySlider.cpp: Added. (WebCore::AccessibilitySlider::AccessibilitySlider): (WebCore::AccessibilitySlider::create): (WebCore::AccessibilitySlider::children): (WebCore::AccessibilitySlider::addChildren): (WebCore::AccessibilitySlider::getAttribute): (WebCore::AccessibilitySlider::valueForRange): (WebCore::AccessibilitySlider::maxValueForRange): (WebCore::AccessibilitySlider::minValueForRange): (WebCore::AccessibilitySlider::changeValue): (WebCore::AccessibilitySlider::setValue): (WebCore::AccessibilitySlider::increment): (WebCore::AccessibilitySlider::decrement): (WebCore::AccessibilitySlider::element): (WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::create): (WebCore::AccessibilitySliderThumb::elementRect): (WebCore::AccessibilitySliderThumb::size):
  • accessibility/AccessibilitySlider.h: Added. (WebCore::AccessibilitySlider::~AccessibilitySlider): (WebCore::AccessibilitySlider::roleValue): (WebCore::AccessibilitySlider::accessibilityIsIgnored): (WebCore::AccessibilitySlider::isSlider): (WebCore::AccessibilitySlider::canSetValueAttribute): (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::roleValue): (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored): (WebCore::AccessibilitySliderThumb::setParentObject): (WebCore::AccessibilitySliderThumb::parentObject):
  • accessibility/mac/AccessibilityObjectWrapper.mm: (RoleEntry::):

SliderThumbRole -> NSAccessibilityValueIndicatorRole

(-[AccessibilityObjectWrapper roleDescription]):

Return role description for NSAccessibilitySliderRole and NSAccessibilityValueIndicatorRole.

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

Minor coding style correction.

(-[AccessibilityObjectWrapper accessibilityPerformPressAction]):

If attachement view handles press action, don't also call object wrapper.

(-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):

New, call object's increment() method.

(-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):

New, call object's decrement() method.

(-[AccessibilityObjectWrapper accessibilityPerformAction:]):

Respond to NSAccessibilityIncrementAction and NSAccessibilityDecrementAction.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::thumbRect):

Factor logic out of layout so AccessibilitySliderThumb can get thumb location/size.

(WebCore::RenderSlider::layout):

Move code to thumbRect().

  • rendering/RenderSlider.h:

2009-08-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

HTMLInputElement is not controllable by assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=27941

Accessibility control of a slider required adding increment() and decrement()
methods to AccessibilityObject, so expose thos methods on AccessibilityUIElement.

  • DumpRenderTree/AccessibilityUIElement.cpp: (incrementCallback): New, call UI element increment method. (decrementCallback): New, call UI element decrement method. (AccessibilityUIElement::getJSClass): Expose increment and decrement methods.
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::increment): New, send NSAccessibilityIncrementAction to Mac wrapper. (AccessibilityUIElement::decrement): New, send NSAccessibilityDecrementAction to Mac wrapper.
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::increment): New, do nothing. (AccessibilityUIElement::decrement): New, do nothing.

2009-08-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

HTMLInputElement is not controllable by assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=27941


Add test for <input type=range> accessibility .

  • accessibility/input-slider.html: Added.
  • platform/mac/accessibility/input-slider-expected.txt: Added.
10:00 Changeset [46719] by kenneth@webkit.org
  • 3 edits in trunk/WebCore

2009-08-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Build fix if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=27940

  • plugins/PluginView.cpp: (WebCore::PluginView::stop): Do not call NPN_MemFree if NPAPI is disabled
  • plugins/PluginViewNone.cpp: (WebCore::PluginView::platformStart): Empty stub.
09:12 Changeset [46718] by ben@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Joe Mason <joe.mason@torchmobile.com>

Reviewed by George Staikos.

WINCE port: LOAD_WITH_ALTERED_SEARCH_PATH param of
LoadLibraryEx not supported on WINCE
https://bugs.webkit.org/show_bug.cgi?id=27917

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):use LoadLibrary instead of LoadLibraryEx
07:50 Changeset [46717] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-08-03 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Do memory cleanup when running robotized QtLauncher in debug as well.

  • QtLauncher/main.cpp: (launcherMain): (main):
05:03 Changeset [46716] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Jan Alonzo.

Fix build break on Gtk/x86_64.
https://bugs.webkit.org/show_bug.cgi?id=27936

Use JSVALUE64 for X86_64 LINUX, except Qt.

  • wtf/Platform.h:
03:27 Changeset [46715] by jmalonzo@webkit.org
  • 1 edit in trunk/ChangeLog

Fix ChangeLog - r46714 was rubber-stamped by Eric

03:23 Changeset [46714] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-08-03 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Eric Seidel.

[Gtk] macros in webkit.m4 should be defined once only
https://bugs.webkit.org/show_bug.cgi?id=27929

The macros in webkit.m4 are not meant to be called multiple times
so we'll make them AC_DEFUN_ONCE. Also make AC_HEADER_STDC and AC_PROG_CXX
AC_REQUIRE to remove the automake warnings when doing autogen.sh.

  • autotools/webkit.m4:
02:14 Changeset [46713] by vestbo@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Remove extra linebreaks in WebCore/ChangeLog introduced in r46711

08/02/09:

23:33 Changeset [46712] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Xan Lopez <xlopez@igalia.com>

Fix the GTK+ build.

  • wtf/Platform.h:
21:12 Changeset [46711] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-02 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

SVGElementInstance::scriptExecutionContext should call document() instead of scriptExecutionContext()

https://bugs.webkit.org/show_bug.cgi?id=27932

There's no reason to pay for a virtual function call in this case. We

can just call document() directly because we know that element is a

Node*.

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::scriptExecutionContext):

20:49 Changeset [46710] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-08-02 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

JSNodeCustom should call document() instead of scriptExecutionContext()
https://bugs.webkit.org/show_bug.cgi?id=27931

We want to call document() because it's in inline function, instead of
scriptExecutionContext() because it's a virtual function. If we have a
Node*, then we know that the virtual function will always return the
document anyway.

There are more instance of this bug, but I'd like to start with a small
patch and work up.

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::toJSDOMGlobalObject):
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
16:10 Changeset [46709] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Disabled JSVALUE32_64 on Qt builds, since all layout tests mysteriously
crash with it enabled.

  • wtf/Platform.h:
16:08 Changeset [46708] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-02 Sam Weinig <sam@webkit.org>

Land updated expected result.

  • fast/js/array-filter-expected.txt:
15:48 Changeset [46707] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-02 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Speed up fast/js/array-filter.html by 10x in debug builds by not using an
unnecessarily large sparse array.

  • fast/js/resources/array-filter.js:
15:10 Changeset [46706] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <ggaren@apple.com>

Qt build fix.

Added JSAPIValueWrapper.cpp to the build.

15:00 Changeset [46705] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <ggaren@apple.com>

Windows build fix.

Exported symbols for JSAPIValueWrapper.

14:56 Changeset [46704] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <ggaren@apple.com>

GTK build fix.

  • jit/JITStubs.cpp: #include <stdarg.h>, for a definition of va_start.
14:52 Changeset [46703] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <ggaren@apple.com>

Qt build fix.


  • runtime/Collector.cpp: #include <limits.h>, for a definition of ULONG_MAX.
14:45 Changeset [46702] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <ggaren@apple.com>

Windows build fix: Nixed JSImmediate::prototype, JSImmediate::toObject,
and JSImmediate::toThisObject, and removed their exported symbols.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
  • runtime/JSImmediate.cpp:
  • runtime/JSImmediate.h:
14:33 Changeset [46701] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Mark Rowe.

Enabled JSVALUE32_64 by default on all platforms other than x86_64 (which uses JSVALUE64).

  • wtf/Platform.h:
07:26 Changeset [46700] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

2009-08-02 David D. Kilzer <ddkilzer@webkit.org>

<http://webkit.org/b/27930> bugzilla-tool hates Tor Arne Vestbø

Reviewed by Tor Arne Vestbø.

  • Scripts/bugzilla-tool: (set_reviewer_in_changelog): Made sure reviewer is properly encoded when calling replace().
07:09 Changeset [46699] by vestbo@webkit.org
  • 7 edits in trunk/WebCore

2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Anders Carlsson.

Share implementation of PluginView::userAgent() and userAgentStatic()

https://bugs.webkit.org/show_bug.cgi?id=27706

Differences to the original implementation are as follows:

  • The Win port used to return 0 for userAgentStatic, but now returns the quirk mode MozillaUserAgent as the other ports.
  • plugins/PluginView.cpp: (WebCore::PluginView::userAgent): (WebCore::PluginView::userAgentStatic):
  • plugins/PluginViewNone.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/mac/PluginViewMac.cpp:
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp:
07:00 Changeset [46698] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Anders Carlsson.

Unregister plugin from PluginMainThreadScheduler if NPP_New fails

https://bugs.webkit.org/show_bug.cgi?id=27706

Since the plugin has not been started yet (m_isStarted is not set),
calling stop() will not have any affect, so we manually unregister
in start() before returning.

  • plugins/PluginView.cpp: (WebCore::PluginView::start):
06:47 Changeset [46697] by vestbo@webkit.org
  • 7 edits in trunk/WebCore

2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Anders Calsson.

Join the various versions of PluginView::stop() into one shared implementation

https://bugs.webkit.org/show_bug.cgi?id=27706

The platform-dependent bits are now ifdef'ed in the shared implementation,
using the XP_ defines (XP_WIN, XP_MACOSX, XP_UNIX) from npapi.h

Differences to the original implementation are as follows:

  • The Qt port unregistered the plugin before calling NP_SetWindow with a 0 window handle. Now it's done after (similar to Win)
  • The GTK and Qt ports unregistered the plugin before clearing the m_npWindow.ws_info struct. Now it's done after.
  • The Win port constructed the DropAllLocks after unsubclassing the window. Now it's done before.
  • The Mac, Qt, and GTK ports did not pass a NPSavedData struct to NP_Destroy (like the Win port). Now all ports do.
  • The Win port did not call PluginView::setCurrentPluginView() before calling to NP-functions. Now it does.
  • plugins/PluginView.cpp: (WebCore::PluginView::start): (WebCore::PluginView::~PluginView): (WebCore::PluginView::stop):
  • plugins/PluginViewNone.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::getValueStatic):
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handlePostReadFile):
01:54 Changeset [46696] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2009-08-02 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by David Levin.

Script for building the wxBrowser sample app for wx.
https://bugs.webkit.org/show_bug.cgi?id=27619

  • wx/browser/wscript: Added.
01:54 Changeset [46695] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKit/wx

2009-08-02 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Jan Alonzo.

Script for building the WebKit library for wx.
https://bugs.webkit.org/show_bug.cgi?id=27619

  • wscript: Added.
01:54 Changeset [46694] by abarth@webkit.org
  • 1 edit
    1 add in trunk/JavaScriptCore

2009-08-02 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Jan Alonzo.

Script for building the JavaScriptCore library for wx.
https://bugs.webkit.org/show_bug.cgi?id=27619

  • wscript: Added.
01:54 Changeset [46693] by abarth@webkit.org
  • 1 edit
    5 adds in trunk/WebKitTools

2009-08-02 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Jan Alonzo.

Scripts needed for the waf build.
https://bugs.webkit.org/show_bug.cgi?id=27619

  • wx/build: Added.
  • wx/build/build_utils.py: Added.
  • wx/build/settings.py: Added.
  • wx/build/waf_extensions.py: Added.
  • wx/build/wxpresets.py: Added.
01:05 Changeset [46692] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

DateMath depends on strftime and localtime, which need to be imported manually on WinCE
https://bugs.webkit.org/show_bug.cgi?id=26558

  • wtf/DateMath.cpp:
00:58 Changeset [46691] by abarth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Initialize HTML5 Application Cache for QtWebKit to a sensible default
https://bugs.webkit.org/show_bug.cgi?id=27866

  • Api/qwebpage.cpp: (initializeApplicationCachePathIfNecessary): (QWebPagePrivate::QWebPagePrivate):
00:41 Changeset [46690] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2009-07-30 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: let me *edit* css styles in the web inspector.
https://bugs.webkit.org/show_bug.cgi?id=27124

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): added property stylesheet pointing to 1 stylesheet added to the page if needed
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): handle blank sections (WebInspector.StylesSidebarPane.prototype.addBlankSection): blank section in the correct position (WebInspector.StylesSidebarPane.prototype.appropriateSelectorForNode): helper to get a nice selector for the selectd node (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype.expand): (WebInspector.StylePropertiesSection.prototype.isPropertyInherited): (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded): (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.StylePropertiesSection.prototype._dblclickEmptySpace): easily create new properties (WebInspector.StylePropertiesSection.prototype._dblclickSelector): (WebInspector.StylePropertiesSection.prototype.startEditingSelector): allow for editing selectors (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled): (WebInspector.StylePropertiesSection.prototype._doesSelectorAffectSelectedNode): helper to check if a selector applies to the selected node (WebInspector.BlankStylePropertiesSection.prototype._dblclick): (WebInspector.BlankStylePropertiesSection.prototype.startEditing): (WebInspector.BlankStylePropertiesSection.prototype.editingCancelled): (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted): (WebInspector.BlankStylePropertiesSection.prototype.makeNormal): morph into a StylePropertiesSection (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):
  • inspector/front-end/inspector.css:
00:33 Changeset [46689] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] check if proxy is present before invoking a handler
https://bugs.webkit.org/show_bug.cgi?id=27883

Do not invoke handler function if proxy is null pointer (that would lead to access violation
anyway)

  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::callListenerFunction):

08/01/09:

23:05 Changeset [46688] by mitz@apple.com
  • 3 edits in trunk/WebKitTools

Reviewed by Darin Adler.

Make pixel test results more consistent across Mac OS X versions

  • DumpRenderTree/cg/ImageDiffCG.cpp: (createDifferenceImage): Avoid color correction when rendering the

images into graphics contexts, so that the actual color values are
compared, regardless of how the images are tagged.

  • DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Set the window’s color space to the

main screen’s color space, even though the window is off-screen.

22:18 Changeset [46687] by abarth@webkit.org
  • 18 edits
    4 adds in trunk/WebCore

2009-08-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Reimplement Elements Panel so that its
interaction with DOM is serialized.

This is a first cut wuth read support for DOM elements
tree as well as some limited editing. No properties, no
styles, no search capabilities are implemented yet.
Set Preferences.useDOMAgent to true in order to try it
out, otherwise disabled by default.

https://bugs.webkit.org/show_bug.cgi?id=27771

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getChildNodes): (WebCore::InspectorBackend::setAttribute): (WebCore::InspectorBackend::removeAttribute): (WebCore::InspectorBackend::setTextNodeValue):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h: (WebCore::InspectorController::domAgent):
  • inspector/InspectorDOMAgent.cpp: Added.
  • inspector/InspectorDOMAgent.h: Added.
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/front-end/Callback.js: Added.
  • inspector/front-end/DOMAgent.js: Added.
  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded):
19:31 Changeset [46686] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Try again to make the Qt build bot happy.

  • BuildSlaveSupport/test-result-archive: Create a placeholder file inside the newly-created

directory to prevent 'zip' from failing due to the directory containing no files.

19:18 Changeset [46685] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Try and make the Qt build bot happy.

  • BuildSlaveSupport/test-result-archive: Handle the case where run-webkit-tests generates

no output files at all and thus does not create the layout-test-results directory.

18:59 Changeset [46684] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Move the include of DumpRenderTreeSupport to after DumpRenderTree has been built.

  • Scripts/run-webkit-tests:
18:41 Changeset [46683] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

wtf/Threading.h: added include of Platform.h

Reviewed by Mark Rowe.

  • wtf/Threading.h: Added #include "Platform.h" since this header uses PLATFORM() and other macros.
18:40 Changeset [46682] by mrowe@apple.com
  • 3 edits
    3 adds in trunk/WebKitTools

Bug 27923: run-webkit-tests should not invoke "ps" repeatedly on Mac OS X
Fix <https://bugs.webkit.org/show_bug.cgi?id=27923>.

Reviewed by Sam Weinig and David D. Kilzer.

run-webkit-tests invokes "ps" after each test on Mac OS X to determine whether DumpRenderTree is
in the process of crashing. We can do the same test more efficiently with a simple call to sysctl.
I couldn't find any built-in way of doing this directly from perl, so we do it from a simple C module
instead. This speeds up run-webkit-tests by around 8%.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Added.

(processIsCrashing):

  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm: Added. Tiger does not have the SWIG tool

that is used to generate the Perl binding to the C code, so we fall back to the old implementation on Tiger.

  • DumpRenderTree/mac/PerlSupport/Makefile: Added.
  • Scripts/run-webkit-tests:
18:04 Changeset [46681] by rniwa@webkit.org
  • 6 edits in trunk/WebCore

2009-08-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adele Peterson.

isContentEditable function in htmlediting.* must be removed
https://bugs.webkit.org/show_bug.cgi?id=27870

This patch removes isContentEditable function in htmlediting.cpp and
replaces all usage by calling Node::isContentEditable or its derivatives.

  • editing/AppendNodeCommand.cpp: ditto (WebCore::AppendNodeCommand::AppendNodeCommand): ditto
  • editing/IndentOutdentCommand.cpp: ditto (WebCore::IndentOutdentCommand::outdentParagraph): ditto
  • editing/InsertNodeBeforeCommand.cpp: ditto (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): ditto
  • editing/htmlediting.cpp: ditto (WebCore::enclosingNodeWithTag): ditto (WebCore::enclosingNodeOfType): ditto (WebCore::canMergeLists): ditto
  • editing/htmlediting.h: Updated prototype
17:24 Changeset [46680] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Display the reminder once rather than once per ChangeLog.

Reviewed by David D. Kilzer.

  • Scripts/prepare-ChangeLog:
16:00 Changeset [46679] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Roll out r46668 as it was misinformed. ScopeChain is only used with placement new.

Rubber-stamped by Oliver Hunt.

  • runtime/ScopeChain.h:
15:52 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
15:49 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
15:48 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
15:48 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
15:22 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
15:08 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
15:01 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
14:57 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
14:57 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
14:55 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
13:13 Changeset [46678] by mrowe@apple.com
  • 3 edits
    2 deletes in trunk/WebKitTools

Roll out r46676. Tiger is why we can't have nice things :-(

13:09 Changeset [46677] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-01 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Mark Rowe.

Remove a non-existent test from the Windows Skipped List.

  • platform/win/Skipped:
13:05 Changeset [46676] by mrowe@apple.com
  • 3 edits
    3 adds in trunk/WebKitTools

Bug 27923: run-webkit-tests should not invoke "ps" repeatedly on Mac OS X
Fix <https://bugs.webkit.org/show_bug.cgi?id=27923>.

Reviewed by Sam Weinig.

run-webkit-tests invokes "ps" after each test on Mac OS X to determine whether DumpRenderTree is
in the process of crashing. We can do the same test more efficiently with a simple call to sysctl.
I couldn't find any built-in way of doing this directly from perl, so we do it from a simple C module
instead. This speeds up run-webkit-tests by around 8%.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Added.

(processIsCrashing):

  • DumpRenderTree/mac/PerlSupport/Makefile: Added.
  • Scripts/run-webkit-tests:
11:35 Changeset [46675] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-01 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Allow custom memory allocation control for JavaScriptCore's HashMap class
http://bugs.webkit.org/show_bug.cgi?id=27871

Inherits HashMap class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/API/JSClassRef.cpp:148.

  • wtf/RefPtrHashMap.h: (WTF::):
11:17 Changeset [46674] by beidson@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

2009-08-01 Brady Eidson <beidson@apple.com>

For my new test I landed last night, check in Tiger-specific results, and skip on Windows.

  • platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
  • platform/win/Skipped: Add to the skipped list because the failure needs exploration.
10:58 Changeset [46673] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-01 John Abd-El-Malek <jam@chromium.org>

Reviewed by Eric Seidel.

Update test to work with multi-process message ports.

https://bugs.webkit.org/show_bug.cgi?id=27819

  • fast/events/message-channel-gc.html:
07:29 Changeset [46672] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

resolve-ChangeLogs: add error checking to git ls-files command on close()

Reviewed by Eric Seidel.

Item 2 of <https://bugs.webkit.org/show_bug.cgi?id=18599#c0>.

  • Scripts/resolve-ChangeLogs: Added error checking to close() after running git ls-files. Added error checking to all system() calls by checking for a non-zero WEXITSTATUS($?).
Changed "
die;" expressions to "or die $!;".
07:29 Changeset [46671] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

Reviewed by Eric Seidel.

  • Scripts/resolve-ChangeLogs: Used chdirReturningRelativePath() and determineVCSRoot() to change directories to the root of the project before running the command and to provide a path for removeChangeLogArguments() to make sure any ChangeLog arguments on the command line are still found. (canonicalRelativePath): Added. Returns a canonical path (e.g., stripping 'dir/../' from the path) relative to the current directory. (removeChangeLogArguments): Added argument which contains a relative path that must be prepended to any ChangeLog arguments. Used canonicalRelativePath() and File::Spec->catfile() to construct a normalized, relative path to each file.
07:29 Changeset [46670] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

Implement VCSUtils::chdirReturningRelativePath()

Reviewed by Eric Seidel.

Step 2 to fix:
<http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

  • Scripts/VCSUtils.pm: (VCSUtils::chdirReturningRelativePath): Moved here from chdirAndGetDifference() in svn-create-patch.
  • Scripts/svn-create-patch: Switched to use chdirReturningRelativePath() instead of chdirAndGetDifference(). (chdirAndGetDifference): Removed.
07:23 Changeset [46669] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

Implement VCSUtils::determineVCSRoot()

Reviewed by Eric Seidel.

Step 1 to fix:
<http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

  • Scripts/VCSUtils.pm: Removed reference to webkitdirs module. (VCSUtils::EXPORT): Added &determineVCSRoot. Realphabetized. (VCSUtils::determineGitRoot): Added. Based on code in commit-log-editor. (VCSUtils::determineVCSRoot): Implemented using determineGitRoot() and determineSVNRoot().
  • Scripts/commit-log-editor: Replaced use of topLevelSourceDirectory() with determineVCSRoot(). Resorted use statements. (topLevelSourceDirectory): Removed.
01:19 Changeset [46668] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-01 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Allow custom memory allocation control for JavaScriptCore's ScopeChain class
https://bugs.webkit.org/show_bug.cgi?id=27834

Inherits ScopeChain class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/JSFunction.h:109.

  • runtime/ScopeChain.h:
00:51 Changeset [46667] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-01 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's RegExpConstructorPrivate struct
https://bugs.webkit.org/show_bug.cgi?id=27833

Inherits RegExpConstructorPrivate class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/RegExpConstructor.cpp:152.

  • runtime/RegExpConstructor.cpp:
00:37 Changeset [46666] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-01 John Abd-El-Malek <jam@chromium.org>

Reviewed by Adam Barth.

Fix a message port handle always getting marked as reachable once it gets entangled.

https://bugs.webkit.org/show_bug.cgi?id=27824

No tests since this only arises with the Chromium multi-process message port implementation
which isn't in this repostiory.

  • bindings/v8/V8GCController.cpp: (WebCore::GCEpilogueVisitor::visitDOMWrapper):
00:23 Changeset [46665] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-08-01 Evan Martin <evan@chromium.org>

Reviewed by Adam Barth.

Add a regression test for a crash when a page has smart quotes in a
mime type.

  • fast/parser/smart-quotes-in-tag-expected.txt: Added.
  • fast/parser/smart-quotes-in-tag.html: Added.

07/31/09:

23:56 Changeset [46664] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-31 Daniel Bates <dbates@intudata.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27757

Resolves Perl redefinition warnings about functions tmpfile and tmpnam which are
defined in both File::Temp and POSIX.

This stops the warnings by preventing the "import" method of File::Temp from being called,
which would otherwise add these functions into the primary namespace. Note, "use POSIX"
will import these functions into the primary namespace anyway. We only need one instance
of these functions in our namespace (or we get redefinition warnings), so lets use the
one's in the POSIX package.

  • Scripts/update-webkit-auxiliary-libs: Changed "use File::Temp" to "use File::Temp ()".
  • Scripts/update-webkit-support-libs: ditto
23:43 Changeset [46663] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Yong Li <yong.li@torchmobile.com>

Reviewed by Adam Barth.

Fix Geolocation permission problem
https://bugs.webkit.org/show_bug.cgi?id=26993

  • page/Geolocation.cpp: (WebCore::Geolocation::requestPermission):
23:29 Changeset [46662] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-31 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Add a top level build option to control datagrid support
https://bugs.webkit.org/show_bug.cgi?id=27915

  • Scripts/build-webkit:
23:09 Changeset [46661] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Eric Seidel.

Added project properties as needed by symbian platform

  • WebCore.pro:
22:26 Changeset [46660] by abarth@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-07-31 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

Resurrect the old GetTickCount implementation of currentTime, controlled by WTF_USE_QUERY_PERFORMANCE_COUNTER
currentSystemTime taken from older WebKit; currentTime written by Yong Li <yong.li@torchmobile.com>; cleanup by Joe Mason <joe.mason@torchmobile.com>
https://bugs.webkit.org/show_bug.cgi?id=27848

  • wtf/CurrentTime.cpp: (WTF::currentSystemTime): get current time with GetCurrentFT (WTF::currentTime): track msec elapsed since first currentSystemTime call using GetTickCount
  • wtf/Platform.h:
21:07 Changeset [46659] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

Fix compiler warning.

Initialize member variables in the correct order.

  • plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
21:07 Changeset [46658] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Holger Hans Peter Freyther.

The reason these four tests fail is a mystery to me right, but placing
them in the Skipped file and the Qt port is... for the first time ever,
finally green!

https://bugs.webkit.org/show_bug.cgi?id=27914

  • platform/qt/Skipped:
20:43 Changeset [46657] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

Printing related test needs to go in Skipped for now so we can
get Qt buildbot green for first time.

https://bugs.webkit.org/show_bug.cgi?id=27913

  • platform/qt/Skipped:
20:43 Changeset [46656] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

Sometimes they pass, sometimes they fail. In attempt to get Qt buildbot
completely green for first time I'm placing these two in the Skipped file.

https://bugs.webkit.org/show_bug.cgi?id=27912

  • platform/qt/Skipped:
20:43 Changeset [46655] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos and Eric Seidel.

Place some audio related tests into the Skipped list in
attempt to get Qt buildbot finally green.

https://bugs.webkit.org/show_bug.cgi?id=27910

  • platform/qt/Skipped:
19:58 Changeset [46654] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-07-31 Jon Honeycutt <jhoneycutt@apple.com>

Windows build fix!

Unreviewed.

  • page/win/PageWin.cpp:
19:38 Changeset [46653] by jhoneycutt@apple.com
  • 3 edits in trunk/WebCore

2009-07-31 Jon Honeycutt <jhoneycutt@apple.com>

Mac build fix.

Unreviewed.

  • page/Page.cpp: Move setCanStartPlugins() from here...
  • page/win/PageWin.cpp: (WebCore::Page::setCanStartPlugins): ... to here.
19:33 Changeset [46652] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-31 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

check-webkit-style --git-commit has bugs if you select a commit in the past
https://bugs.webkit.org/show_bug.cgi?id=27908

  • Scripts/check-webkit-style: (main): Made the git-commit command only select the first commit if a range is given (and print a warning).
  • Scripts/modules/scm.py: (SCM::create_patch_from_local_commit): (SCM::create_patch_since_local_commit): (SCM::commit_locally_with_message): (SCM::discard_local_commits): Added an error messages in case these aren't overriden.

(Git::create_patch_since_local_commit):
Added this command to allow doing a diff of everything after a given commit.

18:40 Changeset [46651] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-31 Jan Michael Alonzo <jmalonzo@webkit.org>

Speculative Qt build fix. Not reviewed.

Add LayoutTestController::disableImageLoading() in jsobjects.h.

  • DumpRenderTree/qt/jsobjects.h:
18:34 Changeset [46650] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-31 Jan Michael Alonzo <jmalonzo@webkit.org>

Skip http/tests/misc/favicon-loads-with-images-disabled.html as
this requires resource load callbacks in Gtk DRT. I've raised bug
#27905 to track this.

  • platform/gtk/Skipped:
18:13 Changeset [46649] by jhoneycutt@apple.com
  • 16 edits in trunk

WebCore:

2009-07-29 Jon Honeycutt <jhoneycutt@apple.com>

<rdar://problem/5698113> Safari shouldn't auto-activate plug-ins in
background tabs (make Win consistent with Mac)

https://bugs.webkit.org/show_bug.cgi?id=27855

Reviewed by Anders Carlsson.

  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::dispatchDidFailToStartPlugin): Declare a new function to dispatch failures to start plug-ins.
  • page/Page.cpp: (WebCore::Page::Page): Initialize new member variable. (WebCore::Page::addUnstartedPlugin): Add the PluginView to the set of unstarted plug-ins. (WebCore::Page::removeUnstartedPlugin): Remove the PluginView from the set of unstarted plug-ins. (WebCore::Page::setCanStartPlugins): If we can now start plug-ins, iterate the set of unstarted plug-ins, starting them. If a plug-in fails to start, dispatch a failed-to-start- plug-in error. Clear the list of unstarted plug-ins.
  • page/Page.h: Added m_canStartPlugins to track whether we can currently start plug-ins. Added m_unstartedPlugins to keep track of plug-ins in the page that are waiting to be started. (WebCore::Page::canStartPlugins):
  • plugins/PluginView.cpp: (WebCore::PluginView::start): m_mimeType is now a WebCore::String, so we call .utf8(). If NPP_New() fails, set m_status to reflect this; this used to be set by init(), but start() will not be called by init() if we are delaying start(). If NPP_New() succeeds, set m_status to reflect this, and call platformStart(). (WebCore::PluginView::startOrAddToUnstartedList): If we cannot start plug-ins, add this view to the Page's list of unstarted plug-ins and return true. Otherwise, call start() and return the result. (WebCore::PluginView::removeFromUnstartedListIfNecessary): If we've been started or we don't have a Page, return early. Remove ourselves from the Page's list of unstarted plug-ins. (WebCore::PluginView::bindingInstance): If we haven't been started yet, return 0. This matches the Mac behavior. (WebCore::PluginView::setParameters): If we find the "plug-ins page" parameter, record it; it may be used if we fail to start the plug-in. (WebCore::PluginView::PluginView): Initialize new members m_haveUpdatedPluginWidget. Initialize m_mimeType with mimeType directly; m_mimeType is now a WebCore::String.
  • plugins/PluginView.h: Made start() public, so Page can call it when we start unstarted plug-ins. Changed m_mimeType from CString to String and added m_pluginsPage; these are needed by dispatchDidFailToStartPlugin(). (WebCore::PluginView::pluginsPage): Added for dispatchDidFailToStartPlugin(). (WebCore::PluginView::mimeType): Ditto. (WebCore::PluginView::url): Ditto.
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart): Stubbed.
  • plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::platformStart): Stubbed.
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::platformStart): Stubbed.
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updatePluginWidget): Use m_haveUpdatedPluginWidget to ensure that we will call MoveWindow() and SetWindowRgn() to position the plug-in and set its clip rect if an earlier call to updatePluginWidget() was made before setPlatformPluginWidget() was called to set the plug-in's HWND. (WebCore::PluginView::~PluginView): Call removeFromUnstartedListIfNecessary() to remove the plug-in from the unstarted list if the plug-in is destroyed before it is started. (WebCore::PluginView::init): Call startOrAddtoUnstartedList to start the plug-in or, if plug-ins cannot be started, to add it to the list of plug-ins waiting to be started. Set m_status to indicate success; this is also set by start(), but that may be delayed, and we don't want the loader to dispatch a failed-to-start-plug-in error when we return from init(). (WebCore::PluginView::platformStart): Added; code moved from init(). This is now called by start() to perform any platform-specific tasks that need to take place after the plug-in has started. Added a call to updatePluginWidget() to ensure we position the plug-in and set its clip rect after the plug-in has started. Removed the setting of m_status; start() does this before calling this function (and we assert this at the head of the function).

WebKit/win:

2009-07-29 Jon Honeycutt <jhoneycutt@apple.com>

Part of <rdar://problem/5698113> Safari shouldn't auto-activate
plug-ins in background tabs (make Win consistent with Mac)

https://bugs.webkit.org/show_bug.cgi?id=27855

Reviewed by Adam Roben and Anders Carlsson.

  • Interfaces/IWebViewPrivate.idl: Add setCanStartPlugins().
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidFailToStartPlugin): Added; code moved from createPlugin(). Modified to obtain the plug-in's page URL, the plug-ins "plug-ins page" parameter value, and the plug-in's MIME type by calling getter functions on the passed PluginView. (WebFrameLoaderClient::createPlugin): If the plug-in status is not "success," call dispatchDidFailToStartPlugin().
  • WebCoreSupport/WebFrameLoaderClient.h: Declare an override of dispatchDidFailToStartPlugin().
  • WebView.cpp: (WebViewWndProc): Add a missing ) to a comment. (WebView::setCanStartPlugins): Call the Page's setCanStartPlugins() function.
  • WebView.h:
17:50 Changeset [46648] by adachan@apple.com
  • 3 edits in trunk/JavaScriptCore

Fixes the Windows release-PGO build.

Reviewed by Jon Honeycutt.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Suppresses the warning about unreachable code that we get by adding "return 0" to WTF::TCMalloc_PageHeap::runScavengerThread().
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::runScavengerThread): Fixes the error about the method not returning a value in the release-PGO build.
17:40 Changeset [46647] by darin@apple.com
  • 42 edits in trunk

WebCore:

2009-07-30 Darin Adler <darin@apple.com>

Reviewed by David Levin.

Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

Next step: Add casts for all the RenderTable classes and use them everywhere.

Also added a few uses in places that were still using static_cast.
Also made some virtual member functions private.
Also changed RenderTable::m_tableLayout to use OwnPtr.

  • accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::isTableExposableThroughAccessibility): (WebCore::AccessibilityTable::addChildren): (WebCore::AccessibilityTable::cellForColumnAndRow):
  • accessibility/AccessibilityTableCell.cpp: (WebCore::AccessibilityTableCell::parentTable): (WebCore::AccessibilityTableCell::rowIndexRange): (WebCore::AccessibilityTableCell::columnIndexRange): (WebCore::AccessibilityTableCell::titleUIElement):
  • accessibility/AccessibilityTableColumn.cpp: (WebCore::AccessibilityTableColumn::headerObject):
  • accessibility/AccessibilityTableRow.cpp: (WebCore::AccessibilityTableRow::parentTable):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode):
  • editing/TextIterator.cpp: (WebCore::shouldEmitTabBeforeNode): (WebCore::shouldEmitNewlinesBeforeAndAfterNode):
  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::parseMappedAttribute):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::parseMappedAttribute):
  • page/Frame.cpp: (WebCore::Frame::searchForLabelsAboveCell):
  • page/mac/FrameMac.mm: (WebCore::Frame::searchForNSLabelsAboveCell):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::shouldScaleColumns):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcPrefWidths):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcPercentageHeight):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addChild): (WebCore::RenderObject::containingBlock):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedBottomBorder):
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::table):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): (WebCore::RenderTableRow::layout): (WebCore::RenderTableRow::paint):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition): (WebCore::RenderTableSection::paintObject): (WebCore::RenderTableSection::recalcCells):
  • rendering/RenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeTextRun): Use checked casts.
  • rendering/RenderTable.cpp: (WebCore::RenderTable::styleDidChange): Updated to use OwnPtr. (WebCore::RenderTable::addChild): Use checked cast. (WebCore::RenderTable::layout): Ditto. (WebCore::RenderTable::setCellWidths): Ditto. (WebCore::RenderTable::paintObject): Ditto. (WebCore::RenderTable::splitColumn): Ditto. (WebCore::RenderTable::appendColumn): Ditto. (WebCore::RenderTable::colElement): Ditto. (WebCore::RenderTable::recalcSections): Ditto. (WebCore::RenderTable::outerBorderBottom): Ditto. (WebCore::RenderTable::outerBorderLeft): Ditto. (WebCore::RenderTable::outerBorderRight): Ditto. (WebCore::RenderTable::sectionAbove): Ditto. (WebCore::RenderTable::sectionBelow): Ditto.
  • rendering/RenderTable.h: Added checked cast. Made virtual functions private. Changed m_tableLayout to be a OwnPtr.
  • rendering/RenderTableCell.h: Added checked cast.
  • rendering/RenderTableCol.h: Ditto. Made virtual functions private.
  • rendering/RenderTableRow.h: Ditto.
  • rendering/RenderTableSection.h: Ditto.

WebKit/mac:

2009-07-30 Darin Adler <darin@apple.com>

Reviewed by David Levin.

Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

  • Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):
  • Misc/WebNSPasteboardExtras.mm: (imageFromElement): (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
  • WebView/WebFrame.mm: (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): (-[WebFrame _accessibilityTree]):
  • WebView/WebRenderNode.mm: (copyRenderNode): Use checked casts.

WebKit/win:

2009-07-30 Darin Adler <darin@apple.com>

Reviewed by David Levin.

Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

  • DOMHTMLClasses.cpp: (DOMHTMLInputElement::isUserEdited): (DOMHTMLTextAreaElement::isUserEdited): Use checked casts.
16:27 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
16:27 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
16:22 Changeset [46646] by beidson@apple.com
  • 12 edits
    2 adds in trunk

WebCore:

2009-07-31 Brady Eidson <beidson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896
Favicons are still loaded when automatic image loading is disabled.

People who want to avoid loading images generally want to avoid loading all images.

Test: http/tests/misc/favicon-loads-with-images-disabled.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::startIconLoader): After committing the URL mapping, don't actually perform the load if images shouldn't be loading.

WebKitTools:

2009-07-31 Brady Eidson <beidson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896
Favicons are still loaded when automatic image loading is disabled.

  • DumpRenderTree/LayoutTestController.cpp: (disableImageLoadingCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::disableImageLoading):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::disableImageLoading):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::disableImageLoading): Stubbed for now.
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::disableImageLoading): Ditto.

LayoutTests:

2009-07-31 Brady Eidson <beidson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896
Favicons are still loaded when automatic image loading is disabled.

  • http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
  • http/tests/misc/favicon-loads-with-images-disabled.html: Added.
16:12 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
16:03 Changeset [46645] by simon.fraser@apple.com
  • 24 edits in trunk

2009-07-31 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Accelerated animations stutter on pages with lots of animations and 3d transforms
https://bugs.webkit.org/show_bug.cgi?id=27884

This patch changes the strategy for synchronizing painting view the view,
and compositing layer updates. Previously the strategy was to disable screen
updates between the time we updated the layer tree, and painted the view. That
left screen updates disabled for too long (hundreds of milliseconds) in some
cases, causing animation stutter.

The new strategy is to batch up changes to the CA layer tree, and commit them
all at once just before painting happens (referred to as a "sync" in the code).
GraphicsLayerCA now keeps a bitmask of changed properties, and then migrates
the values stored in GraphicsLayer into the CA layer tree at commit time.

Compositing layers are then synced in FrameView::paintContents(). However, not
all style/layout changes will result in painting; to deal with style changes that
touch only compositing properties, we set up a runloop observer that takes care
of comitting layer changes when no painting happens.

  • WebCore.base.exp: Export FrameView::syncCompositingStateRecursive()
  • loader/EmptyClients.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive()
  • page/ChromeClient.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive()
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateRecursive): syncCompositingState() on the view and all subviews. Like layoutIfNeededRecursive(). If layout is pending, does not sync and returns false, since we only want to sync when layout is done.

(WebCore::FrameView::paintContents): syncCompositingState() before painting.

  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::endAnimation): Call animationPaused() to notify the graphics layers about animation pausing.
  • platform/graphics/FloatPoint3D.h: (WebCore::operator==): (WebCore::operator!=): Add missing comparison operators.
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setOpacity): (WebCore::GraphicsLayer::setBackgroundColor): Simple setters no longer care about animation info.

(WebCore::GraphicsLayer::paintGraphicsLayerContents): Null-check client.

  • platform/graphics/GraphicsLayer.h: (WebCore::AnimationValue:): (WebCore::TransformAnimationValue:): (WebCore::KeyframeValueList:): (WebCore::KeyframeValueList::insert): Cleaned up versions of FloatValue and TransformValue, used to store information about keyframes values.

(WebCore::GraphicsLayer::contentsRect):
(WebCore::GraphicsLayer::setContentsRect):
ContentsRect is now a simple setter.

(WebCore::GraphicsLayer::addAnimation):
(WebCore::GraphicsLayer::removeAnimationsForProperty):
(WebCore::GraphicsLayer::removeAnimationsForKeyframes):
(WebCore::GraphicsLayer::pauseAnimation):
Simplified animation api.

(WebCore::GraphicsLayer::setGeometryOrientation):
(WebCore::GraphicsLayer::geometryOrientation):
setGeometryOrientation is now just a normal member variable.

(WebCore::GraphicsLayer::contentsOrientation): add a getter.
(WebCore::GraphicsLayer::syncCompositingState): Entry into the layer sync code.

  • platform/graphics/GraphicsLayerClient.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive)
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: Lots of cleanup and refactoring. Main points:
  • Layer changes are all batched, and only committed to the CA layer on syncCompositingState().
  • Bitmask is used to store which properties have changed. More efficient than before.
  • Simpler animation interface; simple setters are no longer confounded with animations.
  • Refactored code that creates CA animations, and stores which animations are running.
  • platform/graphics/transforms/TransformOperations.h: (WebCore::TransformOperations::size): (WebCore::TransformOperations::at): Useful accessors for size and indexed access.
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerBacking.cpp: Renamed 'contentsLayer' to 'foregroundLayer' to avoid confusion with GraphicsLayer's contentsLayer. Adapt to GraphicsLayer's simpler animation API. Pass animation pausing through to the graphics layers. contentsBox() is no longer a callback via GraphicsLayerClient.
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::setCompositingLayersNeedRebuild): (WebCore::RenderLayerCompositor::scheduleSync): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): scheduleViewUpdate() is no longer required. Instead, we plumb through "compositingLayerSync" notifications, which travel up to WebKit and set up a runloop observer.
15:59 UpdatingBugzilla created by ddkilzer@apple.com
Initial contents
15:58 WikiStart edited by ddkilzer@apple.com
(diff)
15:46 Changeset [46644] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-30 Eric Seidel <eric@webkit.org>

Reviewed by David Kilzer.

bugzilla-tool post-commits trunk..head errors out
https://bugs.webkit.org/show_bug.cgi?id=27847

Rename commit_ids_from_range_arguments to commit_ids_from_commitish_arguments
and make it handle the new arguments format proposed in the bug.

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
15:29 Changeset [46643] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-31 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Change malloc to fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp
https://bugs.webkit.org/show_bug.cgi?id=27874

Use fastMalloc and fastFree instead of malloc and free in RegexInterpreter.cpp's methods.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::allocDisjunctionContext): (JSC::Yarr::Interpreter::freeDisjunctionContext): (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
14:57 Changeset [46642] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-07-31 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Eric Seidel.

Geolocation clean up when no longer updating
https://bugs.webkit.org/show_bug.cgi?id=27888

When Geolocation::disconnectFrame() is called, need to call
Document::setUsingGeolocation(false) to mirror the true call
when it is set up.

When handling an error, and there are no more listeners, call
GeolocationService::stopUpdating().

  • page/Geolocation.cpp: (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::handleError):
14:14 Changeset [46641] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-30 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

clean up build-webkit to use less copy/paste code and remove unneeded SVG warning
https://bugs.webkit.org/show_bug.cgi?id=27857

  • Scripts/build-webkit:
14:02 Changeset [46640] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/27894> bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with ClientForm-0.2.10 and python-2.5

Reviewed by Eric Seidel.

  • Scripts/modules/bugzilla.py: (Bugzilla.clear_attachment_review_flag): Specify which 'comment' form field to use when setting its value.
13:29 Changeset [46639] by jorlow@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2009-07-31 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

Add new LocalStorage layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27778

These test behavior that I don't think was very well verified earlier.

  • storage/domstorage/localstorage/complex-keys-expected.txt: Added.
  • storage/domstorage/localstorage/complex-keys.html: Added.

A bunch of corner cases related to keys.

  • storage/domstorage/localstorage/complex-values-expected.txt: Added.
  • storage/domstorage/localstorage/complex-values.html: Added.

A bunch of corner cases related to values.

  • storage/domstorage/localstorage/remove-item-expected.txt: Added.
  • storage/domstorage/localstorage/remove-item.html: Added.

Test basic removeItem functionality.

13:21 Changeset [46638] by andersca@apple.com
  • 3 edits in trunk/WebKit/win

2009-07-31 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

-Fix <rdar://problem/7104097>

Make EmbeddedWidget::create return a PassRefPtr so it will have the correct ref count.


  • WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::create):
  • WebCoreSupport/EmbeddedWidget.h:
13:12 Changeset [46637] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-31 Eric Seidel <eric@webkit.org>

Reviewed by David Kilzer.

bugzilla-tool post-commits obsoletes its own work :(
https://bugs.webkit.org/show_bug.cgi?id=27849

Simple fix. Use .add() instead of .update()

  • Scripts/bugzilla-tool:
11:40 Changeset [46636] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2009-07-30 Jeremy Orlow <jorlow@chromium.org>

Reviewed by David Levin.

Guard needs 's between #endif and ENABLE(DATAGRID)
https://bugs.webkit.org/show_bug.cgi?id=27862

Compiling this file causes a build break without this change.

  • bindings/v8/custom/V8DataGridColumnListCustom.cpp:
11:16 Changeset [46635] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-31 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Re-Enable tests from Skipped that are passing correctly.

https://bugs.webkit.org/show_bug.cgi?id=27890

  • platform/qt/Skipped:
10:07 Changeset [46634] by kenneth@webkit.org
  • 1 edit
    45 adds in trunk/LayoutTests

2009-07-31 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add LayoutTest results from BuildBot output for tests that currently lack results under Qt.

https://bugs.webkit.org/show_bug.cgi?id=27882

  • platform/qt/fast/backgrounds/size/backgroundSize20-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt.
  • platform/qt/fast/backgrounds/size/backgroundSize21-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt.
  • platform/qt/fast/backgrounds/size/backgroundSize22-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt.
  • platform/qt/fast/borders/border-radius-constraints-expected.txt: Added.
  • platform/qt/fast/box-shadow/inset-expected.txt: Added.
  • platform/qt/fast/box-shadow/spread-expected.txt: Copied from LayoutTests/platform/mac/fast/box-shadow/spread-expected.txt.
  • platform/qt/fast/canvas/image-pattern-rotate-expected.txt: Added.
  • platform/qt/fast/css/nested-floating-relative-position-percentages-expected.txt: Added.
  • platform/qt/fast/css/pseudo-cache-stale-expected.txt: Added.
  • platform/qt/fast/css/rem-dynamic-scaling-expected.txt: Added.
  • platform/qt/fast/css/rem-units-on-root-expected.txt: Added.
  • platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.txt: Added.
  • platform/qt/fast/dynamic/window-scrollbars-test-expected.txt: Added.
  • platform/qt/fast/forms/isindex-placeholder-expected.txt: Added.
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt: Added.
  • platform/qt/fast/frames/content-opacity-1-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/content-opacity-1-expected.txt.
  • platform/qt/fast/frames/content-opacity-2-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/content-opacity-2-expected.txt.
  • platform/qt/fast/frames/frame-navigation-expected.txt: Added.
  • platform/qt/fast/frames/frame-scrolling-attribute-expected.txt: Added.
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt: Added.
  • platform/qt/fast/gradients/crash-on-zero-radius-expected.txt: Added.
  • platform/qt/fast/lists/ol-start-parsing-expected.txt: Added.
  • platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.txt: Added.
  • platform/qt/fast/repaint/float-new-in-block-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/float-new-in-block-expected.txt.
  • platform/qt/fast/text/international/khmer-selection-expected.txt: Added.
  • platform/qt/fast/text/shadow-translucent-fill-expected.txt: Added.
  • platform/qt/fast/text/text-letter-spacing-expected.txt: Added.
  • platform/qt/plugins/netscape-dom-access-expected.txt: Added.
  • platform/qt/svg/batik/filters/feTile-expected.txt: Added.
  • platform/qt/svg/custom/createImageElement-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/createImageElement-expected.txt.
  • platform/qt/svg/custom/createImageElement2-expected.txt: Added.
  • platform/qt/svg/custom/js-update-image-and-display-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-update-image-and-display-expected.txt.
  • platform/qt/svg/custom/js-update-image-and-display2-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-update-image-and-display2-expected.txt.
  • platform/qt/svg/custom/js-update-image-and-display3-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-update-image-and-display3-expected.txt.
  • platform/qt/svg/custom/outer-svg-unknown-feature-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/outer-svg-unknown-feature-expected.txt.
  • platform/qt/svg/filters/feMerge-expected.txt: Added.
  • platform/qt/svg/filters/feOffset-expected.txt: Added.
  • platform/qt/svg/filters/feTile-expected.txt: Added.
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt: Added.
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt: Added.
10:04 Changeset [46633] by bolsinga@apple.com
  • 3 edits in trunk/WebCore

2009-07-30 Greg Bolsinga <bolsinga@apple.com>

Reviewed by George Staikos.

Consolidate GeoLocation code to send positions and errors
https://bugs.webkit.org/show_bug.cgi?id=27863

Create helper methods that will send positions and errors to either
one shots or watchers.

  • page/Geolocation.cpp: (WebCore::Geolocation::sendError): (WebCore::Geolocation::sendErrorToOneShots): (WebCore::Geolocation::sendErrorToWatchers): (WebCore::Geolocation::sendPosition): (WebCore::Geolocation::sendPositionToOneShots): (WebCore::Geolocation::sendPositionToWatchers):
  • page/Geolocation.h:
09:52 Changeset [46632] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-31 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Build QtWebKit without benchmark tests for Qt < 4.5.
https://bugs.webkit.org/show_bug.cgi?id=27886

The QBENCHMARK macro is only available from 4.5 on,
so builds for Qt < 4.5 shouldn't try to build those.

  • tests/tests.pro:
07:56 Changeset [46631] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-31 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Anders Carlsson.

Improve platform-detection in run-webkit-tests

This prevents miss-detection of mac-* over Qt/Mac.

  • Scripts/run-webkit-tests:
07:37 Changeset [46630] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-31 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Adam Treat.

Fix warning by migrating use of QString.sprintf(...) to
QString.arg().arg()...

  • WebCoreSupport/EditorClientQt.cpp: (dumpRange):
06:51 Changeset [46629] by treat@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Tor Arne Vestbo.

Adding -webkit-animation-play-state back in following r46547.

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
06:29 Changeset [46628] by kenneth@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-07-31 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Tor Arne Vestbø.

Expose the Offline Web Application Cache in the Qt API.

  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings): (QWebSettings::setOfflineWebApplicationCachePath): (QWebSettings::offlineWebApplicationCachePath): (QWebSettings::setOfflineWebApplicationCacheQuota): (QWebSettings::offlineWebApplicationCacheQuota):
  • Api/qwebsettings.h:
05:43 Changeset [46627] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Xan Lopez <xlopez@igalia.com>

Roll out previous change as it might be causing some weirdness in
the bots.

  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::processFileHeader):
05:06 Changeset [46626] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

Fix compiler warning.
https://bugs.webkit.org/show_bug.cgi?id=27851

GCC does not like multi-character character constants, so use the
explicit numerical value of 'BM' in the enum.

  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::processFileHeader):
00:21 Changeset [46625] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Fix the test case that was landed in r46624.

  • http/tests/misc/meta-refresh-stray-single-quote.html:

07/30/09:

23:54 Changeset [46624] by beidson@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2009-07-30 Brady Eidson <beidson@apple.com>

Reviewed by Mark Rowe, but Dan Bernstein also reviewed and asked thoughtful questions.

<rdar://problem/7106968> and https://bugs.webkit.org/show_bug.cgi?id=27868
http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit, works in others.


Test: http/tests/misc/meta-refresh-stray-single-quote.html

  • platform/network/HTTPParsers.cpp: (WebCore::parseHTTPRefresh): Allow for a stray quote character at the start of the URL string.

LayoutTests:

2009-07-30 Brady Eidson <beidson@apple.com>

Reviewed by Mark Rowe, but Dan Bernstein also reviewed and asked thoughtful questions.

<rdar://problem/7106968> and https://bugs.webkit.org/show_bug.cgi?id=27868
http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit, works in others.

  • http/tests/misc/meta-refresh-stray-single-quote-expected.txt: Added.
  • http/tests/misc/meta-refresh-stray-single-quote.html: Added.
  • http/tests/misc/resources/success-notify-done.html: Added.
23:37 Changeset [46623] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

Fix compiler warning.

GCC does not like C++-style comments in preprocessor directives.

  • wtf/Platform.h:
23:15 Changeset [46622] by jmalonzo@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-07-30 Martin Robinson <mrobinson@appcelerator.com>

Reviewed by Xan Lopez, Gustavo Noronha and Jan Alonzo.

[GTK] new-window-policy-decision-requested provides no information about the target frame
https://bugs.webkit.org/show_bug.cgi?id=27792

Add frameName property to the WebKitWebNavigation object.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::getNavigationAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
  • webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_get_property): (webkit_web_navigation_action_set_property): (webkit_web_navigation_action_class_init): (webkit_web_navigation_action_get_target_frame): (webkit_web_navigation_action_set_target_frame):
  • webkit/webkitwebnavigationaction.h:
22:38 Changeset [46621] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

2009-07-30 John McCall <rjmccall@apple.com>

Reviewed by Gavin Barraclough.

Optimize the X86_64 trampolines: avoid the need for filler arguments
and move the stub-args area closer to the stack pointer.

  • jit/JIT.h: adjust patch offsets because of slight code-size change
  • jit/JITCode.h: (JSC::JITCode::execute): don't pass filler args
  • jit/JITStubs.cpp: (ctiTrampoline): (X86_64): push args onto stack, use args directly (ctiVMThrowTrampoline): (X86_64): adjust %rsp by correct displacement (ctiOpThrowNotCaught): (X86_64): adjust %rsp by correct displacement
  • jit/JITStubs.h: (JITStackFrame): (X86_64): move args area earlier (ctiTrampoline): remove filler args from prototype
19:57 Changeset [46620] by barraclough@apple.com
  • 13 edits in trunk/JavaScriptCore

2009-07-30 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY (build fix).

Temporarily revert r46618 since this is b0rking on Linux.

19:29 Changeset [46619] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Teach buildbot to detect test cases that are missing results.

Reviewed by Cameron Zwarich.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
19:20 Changeset [46618] by barraclough@apple.com
  • 13 edits in trunk/JavaScriptCore

2009-07-23 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Make get_by_id/put_by_id/method_check/call defer optimization using a data flag rather than a code modification.
( https://bugs.webkit.org/show_bug.cgi?id=27635 )

This improves performance of ENABLE(ASSEMBLER_WX_EXCLUSIVE) builds by 2-2.5%, reducing the overhead to about 2.5%.
(No performance impact with ASSEMBLER_WX_EXCLUSIVE disabled).

  • bytecode/CodeBlock.cpp: (JSC::printStructureStubInfo):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
  • bytecode/CodeBlock.h: (JSC::): (JSC::CallLinkInfo::seenOnce): (JSC::CallLinkInfo::setSeen): (JSC::MethodCallLinkInfo::seenOnce): (JSC::MethodCallLinkInfo::setSeen):
    • Change a pointer in CallLinkInfo/MethodCallLinkInfo to use a PtrAndFlags, use a flag to track when an op has been executed once.
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
  • bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::StructureStubInfo): (JSC::StructureStubInfo::initGetByIdSelf): (JSC::StructureStubInfo::initGetByIdProto): (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::initGetByIdSelfList): (JSC::StructureStubInfo::initGetByIdProtoList): (JSC::StructureStubInfo::initPutByIdTransition): (JSC::StructureStubInfo::initPutByIdReplace): (JSC::StructureStubInfo::seenOnce): (JSC::StructureStubInfo::setSeen):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID, add a flag to track when an op has been executed once.
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitGetById): (JSC::BytecodeGenerator::emitPutById):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::unlinkCall):
    • Remove the "don't lazy link" stage of calls.
  • jit/JIT.h: (JSC::JIT::compileCTIMachineTrampolines):
    • Remove the "don't lazy link" stage of calls.
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase):
    • Remove the "don't lazy link" stage of calls.
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks): (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::JITStubs::DEFINE_STUB_FUNCTION): (JSC::JITStubs::getPolymorphicAccessStructureListSlot):
    • Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
  • jit/JITStubs.h: (JSC::JITThunks::ctiStringLengthTrampoline): (JSC::JITStubs::):
    • Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
  • wtf/PtrAndFlags.h: (WTF::PtrAndFlags::PtrAndFlags): (WTF::PtrAndFlags::operator!): (WTF::PtrAndFlags::operator->):
    • Add ! and -> operators, add constuctor with pointer argument.
18:28 Changeset [46617] by mrowe@apple.com
  • 6 edits in trunk/WebCore

Bug 27828: Title attribute is not respected on option elements
Fix <https://bugs.webkit.org/show_bug.cgi?id=27828> for Mac.

Reviewed by Adele Peterson and Jon Honeycutt.

No tests added as it is not clear how to test a tool tip from DumpRenderTree.

  • platform/PopupMenuClient.h: Add a method for retrieving the tool tip of an item.
  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenu::populate): Set the tool tip of the menu item to that of the represented item.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemToolTip): Expose the title attribute of the element as the tool tip.

  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.h:

(WebCore::RenderTextControlSingleLine::itemToolTip): Return an empty string, indicating no tool tip, for
the popup menu in RenderTextControlSingleLine.

17:52 Changeset [46616] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Things work better when you create the correct directories.

  • Scripts/run-webkit-tests:
17:22 Changeset [46615] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Include some information about the error when we die.

  • Scripts/run-webkit-tests:
16:51 Changeset [46614] by treat@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-07-30 Adam Treat <adam.treat@torchmobile.com>

Add expected results file for new test.

  • platform/gtk/fast/forms/button-style-color-expected.txt: Added.
16:41 Changeset [46613] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Ensure that the path exists before writing results to it.
Hopefully this will make the Windows build bot happy.

  • Scripts/run-webkit-tests:
16:32 Changeset [46612] by treat@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2009-07-30 Adam Treat <adam.treat@torchmobile.com>

Add expected results file for new test.

  • platform/mac/fast/forms/button-style-color-expected.txt: Added.
16:21 Changeset [46611] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-30 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Remove ChromeClientChromium::setToolTip().
https://bugs.webkit.org/show_bug.cgi?id=27861

This patch is just to remove a temporarily introduced overloaded empty
virtual function. No test is needed.

  • page/chromium/ChromeClientChromium.h:
16:11 Changeset [46610] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-07-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.

Fixed failing tests seen on Windows buildbot.

  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h: (JSC::): Use "int" instead of "bool" to guarantee a 32-bit result, regardless of compiler. gcc on mac uses 32-bit values for bool, but gcc on linux and MSVC on Windows use 8-bit values.
16:08 Changeset [46609] by darin@chromium.org
  • 25 edits
    2 adds in trunk

2009-07-30 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=27821

ApplicationCacheHost refactoring.


1) Better encapsulate the interfaces between webcore common code
and the appcache system within a new class ApplicationCacheHost.

2) Use that interface throughout the loader system, replacing inline appcache logic.

3) Implement the interface in terms of webcore's appcache system.

4) Add the new files to various makefiles.

5) Implement protocolHostAndPortAreEqual() in KURLGoogle.cpp

No new features, no new tests. The existing layout tests all pass.

  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedIntoDocument):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::mainReceivedError): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::setPrimaryLoadComplete):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::applicationCacheHost):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::load):
  • loader/MainResourceLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didFail):
  • loader/ResourceLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::failedLoadingMainResource): (WebCore::ApplicationCacheGroup::disassociateDocumentLoader): (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::manifestNotFound): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): (WebCore::ApplicationCacheGroup::startLoadingEntry): (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): (WebCore::CallCacheListenerTask::create): (WebCore::CallCacheListenerTask::performTask): (WebCore::CallCacheListenerTask::CallCacheListenerTask): (WebCore::ApplicationCacheGroup::postListenerTask):
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheHost.cpp: Added.
  • loader/appcache/ApplicationCacheHost.h: Added.
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::transferApplicationCache):
  • loader/appcache/ApplicationCacheStorage.h:
  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::DOMApplicationCache): (WebCore::DOMApplicationCache::disconnectFrame): (WebCore::DOMApplicationCache::applicationCacheHost): (WebCore::DOMApplicationCache::status): (WebCore::DOMApplicationCache::update): (WebCore::DOMApplicationCache::swapCache): (WebCore::DOMApplicationCache::addEventListener): (WebCore::DOMApplicationCache::removeEventListener): (WebCore::DOMApplicationCache::dispatchEvent): (WebCore::DOMApplicationCache::callListener): (WebCore::DOMApplicationCache::toEventName): (WebCore::DOMApplicationCache::toEventType):
  • loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::): (WebCore::DOMApplicationCache::setAttributeEventListener): (WebCore::DOMApplicationCache::getAttributeEventListener): (WebCore::DOMApplicationCache::clearAttributeEventListener): (WebCore::DOMApplicationCache::callEventListener): (WebCore::DOMApplicationCache::setOnchecking): (WebCore::DOMApplicationCache::onchecking): (WebCore::DOMApplicationCache::setOnerror): (WebCore::DOMApplicationCache::onerror): (WebCore::DOMApplicationCache::setOnnoupdate): (WebCore::DOMApplicationCache::onnoupdate): (WebCore::DOMApplicationCache::setOndownloading): (WebCore::DOMApplicationCache::ondownloading): (WebCore::DOMApplicationCache::setOnprogress): (WebCore::DOMApplicationCache::onprogress): (WebCore::DOMApplicationCache::setOnupdateready): (WebCore::DOMApplicationCache::onupdateready): (WebCore::DOMApplicationCache::setOncached): (WebCore::DOMApplicationCache::oncached): (WebCore::DOMApplicationCache::setOnobsolete): (WebCore::DOMApplicationCache::onobsolete): (WebCore::DOMApplicationCache::~DOMApplicationCache):
  • platform/KURLGoogle.cpp: (WebCore::protocolHostAndPortAreEqual):
16:05 Changeset [46608] by treat@webkit.org
  • 4 edits in trunk/LayoutTests

2009-07-30 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Mark Rowe.

Revert previous commit to test out new functionality of buildbots and
run-webkit-tests made possible by r46607.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
15:54 Changeset [46607] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Teach run-webkit-tests to always store the actual results in the results directory for new tests.

Reviewed by Adam Treat and Jon Honeycutt.

This allows us to give a working link to the results from the result summary page, even if we're
not generating new results in to the tree.

  • Scripts/run-webkit-tests:
15:44 Changeset [46606] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-07-30 Simon Fraser <simon.fraser@apple.com>

Minor change to earlier commit suggested by Darin Adler.
Use the variable rather than dereferencing 'it' again.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
15:28 Changeset [46605] by treat@webkit.org
  • 4 edits in trunk/LayoutTests

2009-07-30 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos.

Add new test with platform specific results to the Skipped files of ports
that haven't generated them yet. This is to make the buildbot green again.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
14:50 Changeset [46604] by cfleizach@apple.com
  • 3 edits in trunk/WebCore

Bug 27854 - crash at WebCore::AXObjectCache::notificationPostTimerFired
https://bugs.webkit.org/show_bug.cgi?id=27854

14:47 Changeset [46603] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-07-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Animation with a timing function property in a keyframe eats CPU
https://bugs.webkit.org/show_bug.cgi?id=27856
<rdar://problem/7104476> Animation demo uses lots of CPU

Don't include animation-timing-function in the list of properties to
animate in a keyframe animation, because this property is not animated;
instead, it describes the timing function to apply to this keyframe.

This prevents the animation code from thinking that there's a property
that it has to software-animate, and thus firing the animation timer frequently.

Not testable because there is no visible impact.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation): Don't add CSSPropertyWebkitAnimationTimingFunction to the list of properties to animate.
  • page/animation/KeyframeAnimation.cpp (WebCore::KeyframeAnimation::getKeyframeAnimationInterval): Add a comment
14:37 Changeset [46602] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Add a Qt Linux build bot.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
14:18 Changeset [46601] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-07-30 Geoffrey Garen <ggaren@apple.com>

Windows build fix: added missing symbols on Windows.

14:16 Changeset [46600] by treat@webkit.org
  • 5 edits
    2 adds in trunk

WebCore:
2009-07-30 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Apply colour style to buttons that use Theme settings in Qt.

https://bugs.webkit.org/show_bug.cgi?id=27814

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustButtonStyle):

LayoutTests:
2009-07-30 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add Button Colour style test and results for Qt based upon fix for bug.
Unskip tables/mozilla/bugs/bug92647-2.html which passes with bug fix.
Update expected results for qt for test fast/dom/HTMLTableColElement/resize-table-using-col-width-expected
which also passes with the the bug fix.

https://bugs.webkit.org/show_bug.cgi?id=27814

  • fast/forms/button-style-color.html: Added.
  • platform/qt/Skipped:
  • platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/qt/fast/forms/button-style-color-expected.txt: Added.
14:05 Changeset [46599] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-07-30 Geoffrey Garen <ggaren@apple.com>

Windows build fix: removed stale symbols on Windows.

13:57 Changeset [46598] by ggaren@apple.com
  • 63 edits
    3 adds in trunk

Merged nitro-extreme branch into trunk.

13:57 Changeset [46597] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-30 Jakob Petsovits <jakob.petsovits@torchmobile.com>

Reviewed by Adam Roben.

Add --minimal option to webkit-build.
https://bugs.webkit.org/show_bug.cgi?id=27852

This option disables all optional build features unless
they are explicitly enabled.

  • Scripts/build-webkit:
12:31 Changeset [46596] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-07-30 Dean McNamee <deanm@chromium.org>

Reviewed by Dimitri Glazkov.

Don't try to hash member function pointers, instead use a precomputed value based on the field.
https://bugs.webkit.org/show_bug.cgi?id=27843

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::PODTypeWrapperCacheInfo::PODTypeWrapperCacheInfo): (WebCore::PODTypeWrapperCacheInfo::operator==): (WebCore::PODTypeWrapperCacheInfoHash::hash): (WebCore::V8SVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
12:30 Changeset [46595] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Simon Fraser.

Fix compiler warning.

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
12:20 Changeset [46594] by mpcomplete@chromium.org
  • 7 edits in trunk/WebCore

2009-07-29 Matt Perry <mpcomplete@chromium.org>

Reviewed by Adam Barth.

Add a way to register V8 extensions for Isolated Worlds only.
https://bugs.webkit.org/show_bug.cgi?id=27785

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluateInNewWorld): (WebCore::ScriptController::evaluateInNewContext):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::evaluate):
  • bindings/v8/V8IsolatedWorld.h:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewWorld): (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::createNewContext): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::registerExtensionWithV8): (WebCore::V8Proxy::registerExtension):
  • bindings/v8/V8Proxy.h:
12:07 Changeset [46593] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-07-30 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add previously defined out support to PopupMenuQt for marking entries as
disabled and for selecting the desired item.

https://bugs.webkit.org/show_bug.cgi?id=27772

  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::populate):
11:44 Changeset [46592] by darin@apple.com
  • 34 edits in trunk/WebCore

2009-07-30 Darin Adler <darin@apple.com>

Reviewed by David Levin.

Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

Next step: Add new toRenderWidget cast and use it everywhere.

Use checked casts in all the places that were using static_cast
but there is a checked cast available.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::widget): (WebCore::AccessibilityRenderObject::widgetForAttachmentView): (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getPangoLayoutForAtk):
  • dom/Document.cpp: (WebCore::widgetForNode): (WebCore::Document::setFocusedNode):
  • html/HTMLEmbedElement.cpp: (WebCore::findWidgetRenderer):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::defaultEventHandler):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderWidgetForJSBindings):
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::defaultEventHandler):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe):
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData):
  • page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::subframeForTargetNode): (WebCore::EventHandler::handleWheelEvent):
  • page/Frame.cpp: (WebCore::isFrameElement):
  • page/PrintContext.cpp: (WebCore::PrintContext::computePageRects):
  • page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/chromium/FrameChromium.cpp: (WebCore::computePageRectsForFrame):
  • page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passSubframeEventToSubframe):
  • page/win/FrameWin.cpp: (WebCore::computePageRectsForFrame):
  • page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::getCachedImage):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage):
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage):
  • platform/qt/ClipboardQt.cpp: (WebCore::getCachedImage):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage):
  • platform/win/ClipboardWin.cpp: (WebCore::getCachedImage):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
  • rendering/InlineBox.h: (WebCore::InlineBox::boxModelObject):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::addChildToContinuation):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateImageContents):
  • rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::positionForPoint): Use checked cast instead of static_cast.


  • rendering/RenderWidget.h: Added toRenderWidget.
11:25 Changeset [46591] by staikos@webkit.org
  • 6 edits in trunk/WebCore

2009-07-30 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

WINCE PORT: some files modified to build for WINCE
https://bugs.webkit.org/show_bug.cgi?id=27816

11:08 Changeset [46590] by staikos@webkit.org
  • 13 edits in trunk/WebCore

2009-07-30 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

WINCE PORT: modified graphics files
https://bugs.webkit.org/show_bug.cgi?id=27779

10:52 Changeset [46589] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-30 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Ariya Hidayat.

Improve efficiency by rewriting code doing three hash table
lookups, which can be replaced by just one as pointed out
by Darin Adler.

Though being slightly less clear, this should be considerable
faster.

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::remove):
10:50 Changeset [46588] by kov@webkit.org
  • 3 edits in trunk/WebCore

2009-07-30 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Gustavo Noronha.

[Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=27651

Removed unneeded includes (gdk.h and gtk.h) and added glib.h and cairo.h instead.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
10:38 Changeset [46587] by kov@webkit.org
  • 5 edits in trunk/WebCore

2009-07-30 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Gustavo Noronha.

[Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=27651

Fixed many code style issues pointed by WebKitTools/Scripts/modules/cpplint.py
No functionality change at all.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gtk/VideoSinkGStreamer.cpp:
  • platform/graphics/gtk/VideoSinkGStreamer.h:
09:43 Changeset [46586] by kenneth@webkit.org
  • 3 edits in trunk/WebCore

Allow to explicitly choose a preferred plugin for a mimetype.

https://bugs.webkit.org/show_bug.cgi?id=27651

When the preferred plugin is set for a specific MIME type, it will be
always picked up, regardless of its version, quirks etc.

Client applications may want to use that API to resolve mimetype
ambiguity in a custom way, rather than in the default way that is
currently used in WebKit.

09:32 Changeset [46585] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

[Qt] Fix build with GCC 4.4.

09:31 Changeset [46584] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix build with Qt 4.4 after r46535.

09:31 Changeset [46583] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-30 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Adam Treat.

Add missing Q_OBJECT to class inheriting from QObject.

  • tests/qwebframe/tst_qwebframe.cpp:
09:31 Changeset [46582] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-30 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Adam Treat.

Fix indentation.

  • tests/qwebframe/tst_qwebframe.cpp:
09:05 Changeset [46581] by eric.carlson@apple.com
  • 3 edits
    2 adds in trunk

2009-07-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Video elements fires another "load" event when attached to DOM
https://bugs.webkit.org/show_bug.cgi?id=27623

Test: media/media-load-event.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::insertedIntoDocument):

Only schedule load when element's network state is NETWORK_EMPTY.

2009-07-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Video elements fires another "load" event when attached to DOM
https://bugs.webkit.org/show_bug.cgi?id=27623

  • media/media-load-event-expected.txt: Added.
  • media/media-load-event.html: Added.
07:41 SpecSupport edited by tony@gonk.net
Added entries for XSLT 2.0 and XPath 2.0. Although each spec's v1.0 is … (diff)
07:07 Changeset [46580] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-30 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

Cache v8 strings when converting from WebCore::String to v8 string.
https://bugs.webkit.org/show_bug.cgi?id=27655

  • bindings/v8/V8Binding.cpp: (WebCore::v8String): now just immediately calls v8ExternalString (WebCore::enableStringImplCache): enables caching of conversions from WebCore::StringImpl to v8::String (WebCore::makeExternalString): utilty function to create external v8::String out of WebCore::String (WebCore::getStringCache): static function to access string cache (WebCore::cachedStringCallback): callback for weak handles of v8::Strings stored in the cache (WebCore::v8ExternalString): if caching enabled, checks if there is already v8::String for the given WebCore::StringImpl. If present, returns it, otherwise creates a new v8 external string.
  • bindings/v8/V8Binding.h:
06:11 Changeset [46579] by ariya@webkit.org
  • 4 edits in trunk/WebKitTools

2009-07-29 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=27813

[Qt] Support pixel tests in DumpRenderTree for the Qt port.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::setDumpPixels): (WebCore::DumpRenderTree::dump):
  • DumpRenderTree/qt/DumpRenderTree.h:
  • DumpRenderTree/qt/main.cpp: (main):
06:01 Changeset [46578] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-30 Volker Hilsheimer <volker.hilsheimer@nokia.com>

Reviewed by Simon Hausmann.

Fix documentation links to examples.

  • Api/qwebview.cpp:
05:59 Changeset [46577] by ariya@webkit.org
  • 3 edits
    2 adds in trunk

ChangeLog:

2009-07-29 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

Adding ImageDiff project file.

https://bugs.webkit.org/show_bug.cgi?id=27813

  • WebKit.pro: Added ImageDiff.pro.

WebKitTools/ChangeLog:

2009-07-29 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=27813

[Qt] Implement ImageDiff.

  • DumpRenderTree/qt/ImageDiff.cpp: Added.
  • DumpRenderTree/qt/ImageDiff.pro: Added.
05:48 Changeset [46576] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-30 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Allocate MainWindow on heap in robotized QtLauncher as well.

  • QtLauncher/main.cpp: (main):
04:24 Changeset [46575] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-30 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Eric Seidel.

build-webkit: Reorder logic for determining the baseProductDir

https://bugs.webkit.org/show_bug.cgi?id=27699

We now do port-spesific probing for the product dir first, and then
fall back to either the generic WEBKITOUTPUTDIR (which now also works
on Mac), or WebKitBuild.

Then we add the git branch if the git branch build option is enabled.

Finally we massage the product dir based on the port. For example the
Mac port will now always set the SYMROOT and OBJROOT configuration for
XCode.

Note that isAppleWinWebkit() and isCygwin() is not mutually exclusive,
hence the normal if and not elsif in the last two blocks.

  • Scripts/webkitdirs.pm:
00:52 Changeset [46574] by xan@webkit.org
  • 3 edits in trunk/WebCore

2009-07-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=25535
[GTK] object:state-changed:checked events missing for radio buttons and checkboxes

Implement state-changed:checked for radio buttons and checkboxes.

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked):
00:13 Changeset [46573] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-30 Xan Lopez <xlopez@igalia.com>

Forgot the 'break'.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
00:06 Changeset [46572] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-30 Xan Lopez <xlopez@igalia.com>

Try to fix Mac build.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
00:00 Changeset [46571] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Adam Barth.

Add missing enumeration value to switch.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
Note: See TracTimeline for information about the timeline view.