Timeline


and

08/05/09:

23:57 Changeset [46837] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-05 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's ScopeNodeData struct
https://bugs.webkit.org/show_bug.cgi?id=27875

Inherits ScopeNodeData struct from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/parser/Nodes.cpp:1848.

  • parser/Nodes.h:
23:53 Changeset [46836] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-05 Xan Lopez <xlopez@igalia.com>

Skip new test using eventSender, since the GTK+ port does not have
it yet.

  • platform/gtk/Skipped:
23:10 Changeset [46835] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

23:10 Changeset [46834] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.10

New tag.

23:08 Changeset [46833] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebKit/win

Merge r46638.

22:33 Changeset [46832] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

2009-08-05 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Add floating point support for generic ARM port.
https://bugs.webkit.org/show_bug.cgi?id=24986

  • assembler/ARMAssembler.cpp: (JSC::ARMAssembler::doubleTransfer):
  • assembler/ARMAssembler.h: (JSC::ARM::): (JSC::ARMAssembler::): (JSC::ARMAssembler::faddd_r): (JSC::ARMAssembler::fsubd_r): (JSC::ARMAssembler::fmuld_r): (JSC::ARMAssembler::fcmpd_r): (JSC::ARMAssembler::fdtr_u): (JSC::ARMAssembler::fdtr_d): (JSC::ARMAssembler::fmsr_r): (JSC::ARMAssembler::fsitod_r): (JSC::ARMAssembler::fmstat):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::): (JSC::MacroAssemblerARM::supportsFloatingPoint): (JSC::MacroAssemblerARM::loadDouble): (JSC::MacroAssemblerARM::storeDouble): (JSC::MacroAssemblerARM::addDouble): (JSC::MacroAssemblerARM::subDouble): (JSC::MacroAssemblerARM::mulDouble): (JSC::MacroAssemblerARM::convertInt32ToDouble): (JSC::MacroAssemblerARM::branchDouble):
  • jit/JIT.h:
22:22 Changeset [46831] by barraclough@apple.com
  • 11 edits in trunk/JavaScriptCore

2009-08-05 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Add JIT support for generic ARM port without optimizations.
https://bugs.webkit.org/show_bug.cgi?id=24986

All JIT optimizations are disabled.

Signed off by Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Signed off by Gabor Loki <loki@inf.u-szeged.hu>

  • assembler/ARMAssembler.cpp: (JSC::ARMAssembler::baseIndexTransfer32):
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::store32): (JSC::MacroAssemblerARM::move): (JSC::MacroAssemblerARM::branch32): (JSC::MacroAssemblerARM::add32): (JSC::MacroAssemblerARM::sub32): (JSC::MacroAssemblerARM::load32):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::getBytecodeIndex):
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
  • jit/JITOpcodes.cpp:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h: (JSC::JITStackFrame::returnAddressSlot):
  • wtf/Platform.h:
22:19 Changeset [46830] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

2009-08-05 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Need to test throwing exceptions from Workers after calling close().
https://bugs.webkit.org/show_bug.cgi?id=27924

  • fast/workers/resources/worker-close.js:
  • fast/workers/worker-close-expected.txt:
  • fast/workers/worker-close.html:
20:50 Changeset [46829] by dglazkov@chromium.org
  • 5 edits in trunk/WebCore

2009-08-05 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[V8] Revert http://trac.webkit.org/changeset/46821, which was
landed to supplement http://trac.webkit.org/changeset/46816, but
now that the latter is reverted, the former needs the same.

  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
20:27 Changeset [46828] by abarth@webkit.org
  • 4 edits
    1 add in trunk/WebCore

2009-08-05 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Color is only reported in rgb() format; should toggle between rgb() and hex
https://bugs.webkit.org/show_bug.cgi?id=13516

New Class to Parse and Change Between Color Representations:

Representations of Colors in Raw Form. (May be Lazy Loaded):

(WebInspector.Color.prototype.get shorthex):
(WebInspector.Color.prototype.get hex):
(WebInspector.Color.prototype.set hex):
(WebInspector.Color.prototype.get rgb):
(WebInspector.Color.prototype.set rgb):
(WebInspector.Color.prototype.get hsl):
(WebInspector.Color.prototype.set hsl):
(WebInspector.Color.prototype.get nickname):
(WebInspector.Color.prototype.set nickname):
(WebInspector.Color.prototype.get rgba):
(WebInspector.Color.prototype.set rgba):
(WebInspector.Color.prototype.get hsla):
(WebInspector.Color.prototype.set hsla):

Helpers and Standard String Representations:

(WebInspector.Color.prototype.hasShortHex):
(WebInspector.Color.prototype.toRgb):
(WebInspector.Color.prototype.toHsl):
(WebInspector.Color.prototype.toShortHex):
(WebInspector.Color.prototype.toHex):
(WebInspector.Color.prototype.toRgba):
(WebInspector.Color.prototype.toHsla):
(WebInspector.Color.prototype.toNickname):

Conversion Functions to Determine Other Representations:
My Sources for all algorithms and sample data:
Wikipedia: http://en.wikipedia.org/wiki/HSV_color_space
CSS Specification: http://www.w3.org/TR/css3-color/#hsla-color

(WebInspector.Color.prototype.rgbToHex):
(WebInspector.Color.prototype.hexToRgb):
(WebInspector.Color.prototype.rgbToHsl):
(WebInspector.Color.prototype.hslToRgb.hueToRgb):
(WebInspector.Color.prototype.hslToRgb):
(WebInspector.Color.prototype.rgbaToHsla):
(WebInspector.Color.prototype.hslaToRgba):

Called from the constructor, attempts to parse and will throw an error
if it cannot parse. If simple then the "hex" value is guarenteed.
If advanced then both the "rgba" and "hsla" are guarenteed. If it is
a nickname in any way (e.g. "transparent", "black") then this is
guarenteed to be set as well.

(WebInspector.Color.prototype.parse):

Clicking on the swatch will rotate through Color Representations.

Simple: rgb -> hsl -> nickname? -> shorthex? -> hex -> (loop around)
Advanced: rgba -> hsla -> nickname? -> (loop around)

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.value.): (WebInspector.StylePropertyTreeElement.prototype.updateTitle):

Load Color.js:

  • inspector/front-end/inspector.html:
20:05 Changeset [46827] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-08-05 John Abd-El-Malek <jam@chromium.org>

Reviewed by Dimitri Glazkov.

Support setting event listeners for message ports in the worker process.

https://bugs.webkit.org/show_bug.cgi?id=28004

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::retrieve): (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object):
  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
19:39 Changeset [46826] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-05 Stephen White <senorblanco@chromium.org>

Reviewed by Dimitri Glazkov.

http://bugs.webkit.org/show_bug.cgi?id=28022

Minor fix for media code on chromium/skia.

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintMediaSliderTrack):
18:37 Changeset [46825] by darin@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-08-05 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Client side image maps did not handle zoom correctly.
Client side image maps did not handle border and padding correctly.

Test: fast/images/image-map-zoom.html

  • rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint): Compute the values to pass in to the map element using the content box and the effective zoom.

LayoutTests:

2009-08-05 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Client side image maps did not handle zoom correctly.
Client side image maps did not handle border and padding correctly.

  • fast/images/image-map-zoom-expected.txt: Added.
  • fast/images/image-map-zoom.html: Added.
18:30 Changeset [46824] by beidson@apple.com
  • 5 edits in trunk

Add more missing ResourceLoadDelegate methods for WinDRT, and remove another test from the skipped list.

17:52 WebKit Team edited by atwilson@chromium.org
(diff)
17:12 Changeset [46823] by mrowe@apple.com
  • 14 edits
    5 deletes in trunk

Roll out r46816 as it broke many tests.

17:11 Changeset [46822] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=28027
<rdar://7064428> Files with accents in names are submitted incorrectly due to use of
precomposed Unicode

  • platform/network/mac/FormDataStreamMac.mm: (WebCore::setHTTPBody): Use getFileSize() from FileSystem.h instead of custom code for getting file size. This adds path normalization necessary with some file systems on Mac. This also loses a S_IFMT check, which didn't seem important anyway.
16:47 Changeset [46821] by dglazkov@chromium.org
  • 5 edits in trunk/WebCore

2009-08-05 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[V8] Include Media into V8 bindings.

  • bindings/v8/DOMObjectsInclude.h: Added Media include.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Added V8Media include.
  • bindings/v8/V8Index.cpp: Added decl for V8Media.
  • bindings/v8/V8Index.h: Added V8Media include.
16:41 Changeset [46820] by beidson@apple.com
  • 5 edits
    1 delete in trunk

WebKitTools:
2009-08-05 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

Win DRT's resource load delegate is missing didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=28033

  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveResponse):
  • DumpRenderTree/win/ResourceLoadDelegate.h:

LayoutTests:
2009-08-05 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

Win DRT's resource load delegate is missing didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=28033

  • platform/win/Skipped: Remove a test that now passes


Remove platform specific results for the XFrameOptions suite which now matches cross platform results:

  • platform/win/http/tests/security: Removed.
  • platform/win/http/tests/security/XFrameOptions: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Removed.
16:18 Changeset [46819] by jhoneycutt@apple.com
  • 4 edits in trunk/WebCore

2009-08-04 Jon Honeycutt <jhoneycutt@apple.com>

Fix Windows layout test crashes.

PluginView::removeFromUnstartedListIfNecessary() would try to remove
any unstarted PluginView from the Page's set of unstarted plug-ins,
regardless of why the PluginView wasn't started. If we tried to start a
plug-in, but it failed to start, we would hit an assertion in
Page::removeUnstartedPlugin() that asserts that we would only modify the
unstarted plug-ins set if we were not currently starting plug-ins.

Fix this by having PluginView track whether it's waiting to be started,
and to check this before trying to remove itself from the Page's
unstarted plug-ins set.

Reviewed by Darin Adler.

  • page/Page.cpp: (WebCore::Page::removeUnstartedPlugin): Assert that the passed PluginView is in the unstarted set.
  • plugins/PluginView.cpp: (WebCore::PluginView::start): Set that we are not waiting to be started. (WebCore::PluginView::startOrAddtoUnstartedList): Set that we are waiting to be started. (WebCore::PluginView::removeFromUnstartedListIfNecessary): Check not whether we are started, but whether we are waiting to be started. (WebCore::PluginView::PluginView):
  • plugins/PluginView.h:
15:48 Changeset [46818] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2009-08-05 Jeremy Orlow <jorlow@chromium.org>

Fix DOM Storage memory leak
https://bugs.webkit.org/show_bug.cgi?id=28029

Forgot to use adoptRef in one place. This caused the = operator to
increment the ref count when it shouldn't have, so StorageAreaImpl's were
never freed.

  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::storageArea):
14:51 Changeset [46817] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-08-05 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[Chromium] Let CodeGeneratorV8.pm know that Media is ref-counted.

  • bindings/scripts/CodeGeneratorV8.pm: Added Media check to IsRefPtrType.
14:26 Changeset [46816] by simon.fraser@apple.com
  • 14 edits
    2 copies
    3 adds in trunk

2009-08-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Implement the matchMedium method on the Media interface described in the CSSOM View Module.
https://bugs.webkit.org/show_bug.cgi?id=22495

Add a new Media interface, obtainable via the AbstractView, that can
evaluate queries via its matchesMedium() method.

Test: fast/media/matchmedium-query-api.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Add Media.* files to the build.
  • css/Media.cpp: Added. (WebCore::Media::Media): (WebCore::Media::type): (WebCore::Media::matchMedium):
  • css/Media.h: Added. (WebCore::Media::create): (WebCore::Media::document):
  • css/Media.idl: Added. Media::matchMedium() uses a MediaQueryEvaluator() to test the query.
  • page/AbstractView.idl:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::media):
  • page/DOMWindow.h:
  • page/DOMWindow.idl: Add a readonly attribute for Media.
14:25 Changeset [46815] by darin@apple.com
  • 96 edits in trunk/WebCore

2009-08-05 Darin Adler <darin@apple.com>

Reviewed by David Levin.

Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

Last patch. Makes all the casts of RenderObject use checked
casts instead of using static_cast directly.

  • accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::visibleChildren): (WebCore::AccessibilityListBox::doAccessibilityHitTest):
  • accessibility/AccessibilityListBoxOption.cpp: (WebCore::AccessibilityListBoxOption::elementRect):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::textUnderElement): (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::titleUIElement): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  • accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySliderThumb::elementRect):
  • dom/InputElement.cpp: (WebCore::InputElement::updatePlaceholderVisibility):
  • dom/SelectElement.cpp: (WebCore::SelectElement::scrollToSelection): (WebCore::SelectElement::recalcStyle): (WebCore::SelectElement::setRecalcListItems): (WebCore::SelectElement::menuListDefaultEventHandler): (WebCore::SelectElement::listBoxDefaultEventHandler):
  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::attach):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::defaultEventHandler):
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::addSearchResult): (WebCore::HTMLInputElement::onSearch):
  • html/HTMLLIElement.cpp: (WebCore::HTMLLIElement::parseMappedAttribute): (WebCore::HTMLLIElement::attach):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): (WebCore::HTMLMediaElement::mediaPlayerSizeChanged): (WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated): (WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer): (WebCore::HTMLMediaElement::defaultEventHandler): (WebCore::HTMLMediaElement::finishParsingChildren):
  • html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::parseMappedAttribute):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::defaultEventHandler):
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag):
  • page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::capsLockStateMayHaveChanged):
  • page/Frame.cpp: (WebCore::Frame::ownerRenderer):
  • page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars):
  • page/wince/FrameWince.cpp: (WebCore::computePageRectsForFrame):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
  • rendering/RenderCounter.cpp: (WebCore::planCounter):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::computeEdgeInfo): (WebCore::RenderFrameSet::setIsResizing):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::contentsBox):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
  • rendering/RenderListItem.cpp: (WebCore::previousListItem): (WebCore::RenderListItem::explicitValueChanged):
  • rendering/RenderObject.cpp: (WebCore::updateListMarkerNumbers):
  • rendering/RenderObjectChildList.cpp: (WebCore::updateListMarkerNumbers): (WebCore::invalidateCountersInContainer):
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::minimumThumbLength): (WebCore::RenderScrollbarTheme::backButtonRect): (WebCore::RenderScrollbarTheme::forwardButtonRect): (WebCore::RenderScrollbarTheme::trackRect): (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces): (WebCore::RenderScrollbarTheme::paintScrollbarBackground): (WebCore::RenderScrollbarTheme::paintTrackBackground): (WebCore::RenderScrollbarTheme::paintTrackPiece): (WebCore::RenderScrollbarTheme::paintButton): (WebCore::RenderScrollbarTheme::paintThumb):
  • rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::defaultEventHandler):
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintSliderThumb):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::determineSliderThumbState):
  • rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
  • rendering/SVGRootInlineBox.cpp: (WebCore::findSVGRootObject):
  • rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::nodeAtPoint): (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::attach):
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
  • svg/SVGTextContentElement.cpp: (WebCore::rootInlineBoxForTextContentElement):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler): Use checked casts.
  • rendering/RenderApplet.h:
  • rendering/RenderCounter.h:
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.h:
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderListBox.h:
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.h:
  • rendering/RenderMedia.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderPart.h:
  • rendering/RenderPartObject.h:
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGTextPath.h:
  • rendering/RenderSVGViewportContainer.h:
  • rendering/RenderScrollbar.h:
  • rendering/RenderSlider.h:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderVideo.h: Added a checked cast. Also made most members protected or private.
  • rendering/RenderBlock.h:
  • rendering/RenderInline.h:
  • rendering/RenderReplaced.h:
  • rendering/RenderSVGBlock.h:
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderSVGText.h:
  • rendering/RenderTextControl.h: Made most members protected or private.
  • rendering/RenderInline.cpp:
  • rendering/RenderSVGContainer.cpp:
  • rendering/RenderSVGHiddenContainer.cpp:
  • rendering/RenderSVGImage.cpp:
  • rendering/RenderSVGRoot.cpp: Removed unneeded destructor.
  • rendering/RenderSVGHiddenContainer.h: Removed unneeded virtual function overrides that did the same as the default and base class.
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::paint): Updated to use m_viewport directly instead of using a function call. (WebCore::RenderSVGViewportContainer::applyViewportClip): Ditto. (WebCore::RenderSVGViewportContainer::viewportTransform): Ditto. (WebCore::RenderSVGViewportContainer::localToParentTransform): Ditto. (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Ditto.
  • rendering/RenderScrollbar.cpp: (WebCore::pseudoForScrollbarPart): Changed switch statement to use cases for all values instead of using a default case.
  • rendering/RenderTreeAsText.cpp: (WebCore::operator<<): Removed dependency on casting to types that don't have any public members we need to get at. Instead, use function names to identify the type rather than doing so much overloading. Changed to use checked casts. (WebCore::write): Ditto.
  • rendering/SVGRenderSupport.cpp: (WebCore::renderSubtreeToImage): Changed to use a checked cast and also added a comment about the fact that the code does not do sufficient type checking before doing the cast.
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeRenderSVGTextBox): Renamed this from operator<<. (WebCore::writeSVGInlineTextBoxes): Renamed this from writeSVGInlineText. (WebCore::writeSVGText): Renamed this from write. (WebCore::writeSVGInlineText): Ditto. (WebCore::writeSVGImage): Ditto.
  • rendering/SVGRenderTreeAsText.h: Updated for name changes. Removed unneeded default arguments.
14:14 Changeset [46814] by pkasting@chromium.org
  • 3 edits in trunk/WebCore

2009-08-05 Peter Kasting <pkasting@google.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=27851
Fix a pair of compiler warnings on the GTK Linux buildbot.

  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::processFileHeader): Don't use multi-character constants, they're not portable.
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::setSize): Simpler code that also doesn't compare signed with unsigned.
14:00 Changeset [46813] by beidson@apple.com
  • 1 edit
    4 copies in trunk/LayoutTests

2009-08-05 Brady Eidson <beidson@apple.com>

Rubberstamped by Mark Rowe.

As a followup to http://trac.webkit.org/changeset/46811, Windows-specific results *did* have some differences, so restoring those results.

  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt.
13:46 Changeset [46812] by beidson@apple.com
  • 1 edit
    6 deletes in trunk/LayoutTests

2009-08-05 Brady Eidson <beidson@apple.com>

Rubberstamped by Mark Rowe.

Actually, for all 6 of these tests Tiger now matches the cross-platform results, so removing all the Tiger results.

  • platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt: Removed.
  • platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Removed.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
13:31 Changeset [46811] by beidson@apple.com
  • 1 edit
    4 deletes in trunk/LayoutTests

2009-08-05 Brady Eidson <beidson@apple.com>

Rubberstamped by Mark Rowe.

As a followup to http://trac.webkit.org/changeset/46809, Windows-specific results now match the cross-platform results,
so I'm removing them.

  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
13:26 Changeset [46810] by beidson@apple.com
  • 3 edits in trunk/LayoutTests

2009-08-05 Brady Eidson <beidson@apple.com>

Rubberstamped by Mark Rowe.

As a followup to http://trac.webkit.org/changeset/46809, update Tiger platform specific results for these tests.

  • platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt:
  • platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt:
13:16 Changeset [46809] by darin@chromium.org
  • 12 edits in trunk

2009-08-05 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

Add layoutTestController.dumpWillCacheResponse
https://bugs.webkit.org/show_bug.cgi?id=28010

willCacheResponse is only interesting for embedders of mainline WebKit on Mac.
Splitting off a new dumpWillCacheResponse allows a number of existings tests
to run across platforms.

The test that was specifically verifying willCacheResponse now calls
dumpWillCacheResponse.

  • DumpRenderTree/LayoutTestController.cpp: Add dumpWillCacheResponse (LayoutTestController::LayoutTestController): (dumpWillCacheResponseCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpWillCacheResponse): (LayoutTestController::setDumpWillCacheResponse):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: Inspect dumpWillCacheResponse instead of dumpResourceLoadCallbacks. (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
12:56 Changeset [46808] by mrowe@apple.com
  • 4 edits in trunk/LayoutTests

Fix two tests to not load a resource that takes five seconds to load.

Reviewed by Brady Eidson.

We achieve this by making the delay in slow-resource.pl configurable in a query parameter.
This drops the run time of each of the tests from over five seconds to less than a third
of a second.

  • http/tests/misc/DOMContentLoaded-event.html:
  • http/tests/navigation/multiple-back-forward-entries.html:
  • http/tests/navigation/resources/slow-resource.pl:
12:36 Changeset [46807] by pkasting@chromium.org
  • 7 edits
    1 delete in trunk/WebCore

2009-08-05 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26460
Return multiple icon entries from the ICO decoder as separate frames,
sorted by decreasing quality (much like the CG ICO decoder does).

As a result of this change, we can eliminate the Skia-specific setData()
hack that the Chromium port used to select the desired icon size -- now
callers can just enumerate the frames and ask for the data from the one
they like.


Under the hood, the ICO decoder now keeps vectors for a number of things
(including directory entries and image decoders) where it used to have
single members. However, callers (that I have seen) will only request
one frame from the icon, so practically there aren't going to be lots of
instantiated image decoders.

  • platform/graphics/ImageSource.h: Move |m_decoder| back to private now that Skia no longer needs to access it.
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::createDecoder): Remove size argument from ICO decoder instantiation.
  • platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::createDecoder): Remove size argument from ICO decoder instantiation. (WebCore::ImageSource::setData): Remove function to ask for a particular icon size.
  • platform/graphics/skia/ImageSourceSkia.h: Removed.
  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::createDecoder): Remove size argument from ICO decoder instantiation.
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::~ICOImageDecoder): Delete all instantiated per-frame decoders. (WebCore::ICOImageDecoder::setData): Send data to all instantiated per-frame decoders. (WebCore::ICOImageDecoder::isSizeAvailable): Use size from icon directory instead of PNG decoder (if applicable) so we can report it without decoding the PNG frames. (WebCore::ICOImageDecoder::size): Report frame-specific size if BMP decoder is calling. Otherwise, use size from icon directory instead of PNG decoder (if applicable). (WebCore::ICOImageDecoder::frameSizeAtIndex): Implement. (WebCore::ICOImageDecoder::setSize): Sanity check value if BMP decoder is calling. (WebCore::ICOImageDecoder::frameCount): Implement. (WebCore::ICOImageDecoder::frameBufferAtIndex): Sanity check size for PNG frames. (WebCore::ICOImageDecoder::compareEntries): Add utility function for sorting entries. (WebCore::ICOImageDecoder::setDataForPNGDecoderAtIndex): Factor out utility function for passing correct data blob to a PNG decoder. (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded): Split decode() into two pieces. (WebCore::ICOImageDecoder::decodeDirectory): The first part of the old decode(). (WebCore::ICOImageDecoder::decodeAtIndex): The second part of the old decode(), split off so we avoid decoding an entry until it's requested. (WebCore::ICOImageDecoder::processDirectory): Add resizing of internal data structures based on directory contents. (WebCore::ICOImageDecoder::processDirectoryEntries): Sort entries by quality. (WebCore::ICOImageDecoder::imageTypeAtIndex): Return type to caller instead of setting a member.
  • platform/image-decoders/ico/ICOImageDecoder.h:
11:38 Changeset [46806] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2009-08-05 Szabo Carol <carol.szabo@nokia.com>

Reviewed by Darin Adler.

Test for https://bugs.webkit.org/show_bug.cgi?id=27942
Form Reset does not work per w3c standard when single selection
SELECT element has more than one option marked as selected.

  • fast/forms/select-reset-multiple-selections-4-single-selection-expected.txt: Added.
  • fast/forms/select-reset-multiple-selections-4-single-selection.html: Added.

2009-08-05 Szabo Carol <carol.szabo@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27942

Test: fast/forms/select-reset-multiple-selections-4-single-selection.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::reset):

Added HTML 4.01 compliant handling of broken webpages that
specify more than one selected option for single selection SELECT
element, in a manner that emulates Firefox and is similar to IE 7

11:22 Changeset [46805] by jorlow@chromium.org
  • 2 edits in trunk/WebKitTools

2009-08-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

Add my name to committers.py
https://bugs.webkit.org/show_bug.cgi?id=28013

Add my name to committers.py.

  • Scripts/modules/committers.py:
08:17 Changeset [46804] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-08-05 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

WebCore.pro bugfix

Fix the gperf lines to properly include the string.h header at compilation with gperf version 3.0.3 and newer.

  • WebCore.pro:
08:14 Changeset [46803] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-08-05 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Fix build error caused by http://trac.webkit.org/changeset/46763

  • Api/qwebpluginfactory.h: Export macro added.
07:56 Changeset [46802] by kenneth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

A minor refactoring of the Qt DRT to be a bit more similar to
the other DRTs, as well as more understandable.

Splitting up resetJSObjects into a LayoutTestController->reset()
plus a new closeRemainingWindows() method.

Added a resetToConsistentStateBeforeTesting() method to keep
the code in one place, making it easier to verify that we are
doing things properly.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::closeRemainingWindows):
  • DumpRenderTree/qt/DumpRenderTree.h:
07:51 Changeset [46801] by kenneth@webkit.org
  • 5 edits in trunk/WebKitTools

2009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

Make the Qt DRT WorkQueue work similarily to the cross platform
one. This means that all items return true if they started
loading.

This change paves the way for unforking the WorkQueue, if we [Qt]
would like that.

  • DumpRenderTree/qt/WorkQueue.cpp: (WorkQueue::processWork):
  • DumpRenderTree/qt/WorkQueue.h:
  • DumpRenderTree/qt/WorkQueueItem.h:
  • DumpRenderTree/qt/jsobjects.cpp: (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke): (LayoutTestController::processWork): (LayoutTestController::maybeDump):
07:48 Changeset [46800] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

If load of a test fails, don't dump as it will be dumped
in the preceding test, resulting in a invalid incorrect layout.

  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::maybeDump):
07:46 Changeset [46799] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

Make the Qt DumpRenderTree more similar to the mac one.

Changes include:
1) Reset zoom factor before each test
2) Only dump the backforward list when we got other dump result
3) When we dump the render tree, and got zero result print out:

[mainFrame renderTreeAsExternalRepresentation]
and not:
[frame renderTreeAsExternalRepresentation]

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open): (WebCore::methodNameStringForFailedTest): (WebCore::DumpRenderTree::dump):
07:39 Changeset [46798] by cfleizach@apple.com
  • 4 edits in trunk

WebCore:

2009-08-05 Chris Fleizach <cfleizach@apple.com>

Fix Tiger build breakage.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

WebKitTools:

2009-08-05 chris fleizach <cfleizach@apple.com>

Fix Tiger build breakage.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
05:40 EFLWebKit edited by tonikitoo@gmail.com
(diff)
04:40 Changeset [46797] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-08-05 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] macros in webkit.m4 should be defined once only
https://bugs.webkit.org/show_bug.cgi?id=27929

The macros in webkit.m4 are not meant to be called multiple times
so we'll make them AC_DEFUN_ONCE. Also make AC_HEADER_STDC and AC_PROG_CXX
AC_REQUIRE to remove the automake warnings when doing autogen.sh.

Lastly, make sure CXXFLAGS and CFLAGS are defined before
AC_PROG_CXX gets expanded so it doesn't add "-g -O2" on Release builds.

  • autotools/webkit.m4:
01:13 Changeset [46796] by xan@webkit.org
  • 2 edits in trunk

2009-08-05 Xan Lopez <xlopez@igalia.com>

Revert r46714, it was making us build debug images by default.

  • autotools/webkit.m4:

08/04/09:

22:50 Changeset [46795] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-08-04 Simon Hausmann <hausmann@webkit.org>

Prospective build fix for Qt build bot: Fix dependency of HTMLNames.cpp
to both source files, HTMLTagNames.in and HTMLAttributeNames.in

  • WebCore.pro:
22:40 Changeset [46794] by abarth@webkit.org
  • 18 edits in trunk/LayoutTests

2009-08-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703

Rename queueScriptInIsolatedWorld to evaluateScriptInIsolatedWorld
because I've changed this API to be synchronous instead of asynchronous
to work around some strange behavior in the work_queue_. Turns out we
don't need the complexity of an asynchronous API to test this feature.

  • http/tests/security/isolatedWorld/all-window-properties.html:
  • http/tests/security/isolatedWorld/all-window-prototypes.html:
  • http/tests/security/isolatedWorld/body-properties.html:
  • http/tests/security/isolatedWorld/body-prototype.html:
  • http/tests/security/isolatedWorld/click-event.html:
  • http/tests/security/isolatedWorld/document-open.html:
  • http/tests/security/isolatedWorld/document-properties.html:
  • http/tests/security/isolatedWorld/document-prototype.html:
  • http/tests/security/isolatedWorld/global-variables.html:
  • http/tests/security/isolatedWorld/image-properties.html:
  • http/tests/security/isolatedWorld/image-prototype.html:
  • http/tests/security/isolatedWorld/location-properties.html:
  • http/tests/security/isolatedWorld/location-prototype.html:
  • http/tests/security/isolatedWorld/number-prototype.html:
  • http/tests/security/isolatedWorld/object-prototype.html:
  • http/tests/security/isolatedWorld/string-prototype.html:
  • http/tests/security/isolatedWorld/window-properties.html:
22:20 Changeset [46793] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

2009-08-04 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adele Peterson.

Keypress should exit from pan scrolling mode.
https://bugs.webkit.org/show_bug.cgi?id=28005

Change the logic from only exiting pan scrolling on escape to exiting on any key press,
making it easier for users to back out of an accidental pan scroll.

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
21:36 Changeset [46792] by eric@webkit.org
  • 5 edits
    1 add in trunk

2009-08-04 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION (r45064): Drop caret remains in text control after the mouse exits
https://bugs.webkit.org/show_bug.cgi?id=26787

Fix some bogus comments noticed during testing.

  • fast/forms/drag-into-textarea.html:
  • fast/forms/drag-out-of-textarea.html:

2009-08-04 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION (r45064): Drop caret remains in text control after the mouse exits
https://bugs.webkit.org/show_bug.cgi?id=26787

Add back missing dragController()->clear() call.

  • manual-tests/drag-caret.html: Added.
  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):
19:22 Changeset [46791] by alice.liu@apple.com
  • 2 edits in trunk/WebKit/win

2009-08-04 Alice Liu <alice.liu@apple.com>

"Shift + Enter" should behave like "Enter" in editable fields.
Affects backward search in find-in-page in Safari for Windows

Reviewed by Jon Honeycutt.

  • WebView.cpp: Register shift+enter as InsertNewline command, similar to other modifier+Enter combinations.
18:34 Changeset [46790] by eric@webkit.org
  • 2 edits
    1 add
    5 deletes in trunk/LayoutTests

2009-08-04 Chris Fleizach <cfleizach@apple.com>

Reviewed by Darin Adler.

Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27994

  • platform/mac/accessibility/aria-valuetext-expected.txt: Added.
  • platform/mac/accessibility/aria-valuetext.html: Added.
17:32 Changeset [46789] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

2009-08-04 Chris Fleizach <cfleizach@apple.com>

Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27994

Forgot to commit attribute names.

  • html/HTMLAttributeNames.in:
17:29 Changeset [46788] by cfleizach@apple.com
  • 11 edits
    2 adds in trunk

WebCore:

2009-08-04 Chris Fleizach <cfleizach@apple.com>

Reviewed by Darin Adler.

Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27994

Test: platform/mac/accessibility/aria-valuetext.html

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::valueDescription):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::valueDescription):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
  • html/HTMLAttributeNames.in:

WebKitTools:

2009-08-04 Chris Fleizach <cfleizach@apple.com>

Reviewed by Darin Adler.

Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27994

Expose valueDescription for accessibility.

  • DumpRenderTree/AccessibilityUIElement.cpp: (getValueDescriptionCallback): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::valueDescription):
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::valueDescription):

LayoutTests:

2009-08-04 Chris Fleizach <cfleizach@apple.com>

Reviewed by Darin Adler.

Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27994

  • platform/mac/accessibility/aria-valuetext-expected.txt: Added.
  • platform/mac/accessibility/aria-valuetext.html: Added.
17:21 Changeset [46787] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH
https://bugs.webkit.org/show_bug.cgi?id=28006

Hard-code perl to /usr/bin/perl and swig to /usr/bin/swig

  • DumpRenderTree/mac/PerlSupport/Makefile:
17:18 Changeset [46786] by darin@chromium.org
  • 19 edits in trunk

2009-08-04 Michael Nordman <michaeln@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=27821

No new features, no new tests. Existing layout tests pass.

  • WebCore.base.exp:

Export AppliationCacheGroup::storeCopyOfCache

  • WebCore.xcodeproj/project.pbxproj:

Restore DOMApplicationCache.h and ApplicationCacheHost.h to 'project' headers
instead of 'private' headers since they're no longer in the DocumentLoader.h
include graph.

  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedIntoDocument):

Reinstate the test for manifest.isNull instead of .isEmtpty().
Added a FIXME to revisit once the spec gets clarified.


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::mainReceivedError): (WebCore::DocumentLoader::detachFromFrame):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::applicationCacheHost):

ApplicationCacheHost is held in an OwnPtr<> by DocumentLoader. This was done
for compile time friendliness, it results in a smaller include graph for files
dependent on DocumentLoader.h.

  • loader/FrameLoader.cpp:
  • loader/MainResourceLoader.cpp:
  • loader/ResourceLoader.cpp:

Cleanup ussage of ENABLE(xxx) around includes, generally remove those guards.
This was done for readability at the include site. The included files contain appropriate guards,
so they're not needed at the include site.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::failedLoadingMainResource): (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::manifestNotFound): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): (WebCore::ApplicationCacheGroup::startLoadingEntry): (WebCore::CallCacheListenerTask::create): (WebCore::CallCacheListenerTask::performTask): (WebCore::CallCacheListenerTask::CallCacheListenerTask): (WebCore::ApplicationCacheGroup::postListenerTask):
  • loader/appcache/ApplicationCacheGroup.h:

Use ApplicationCachHost defined constants, no longer depends on DOMApplicationCache.

  • loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::ApplicationCacheHost): (WebCore::ApplicationCacheHost::setDOMApplicationCache): (WebCore::ApplicationCacheHost::notifyEventListener): (WebCore::ApplicationCacheHost::status):
  • loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeCopyOfCache):
  • loader/appcache/ApplicationCacheStorage.h:

Merge recently added transferApplicationCache and pre-existing storeCopyOfCache methods.

  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::status): (WebCore::DOMApplicationCache::addEventListener): (WebCore::DOMApplicationCache::removeEventListener): (WebCore::DOMApplicationCache::callListener): (WebCore::DOMApplicationCache::toEventType): (WebCore::DOMApplicationCache::toEventID):
  • loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::setAttributeEventListener): (WebCore::DOMApplicationCache::getAttributeEventListener): (WebCore::DOMApplicationCache::clearAttributeEventListener): (WebCore::DOMApplicationCache::callEventListener): (WebCore::DOMApplicationCache::setOnchecking): (WebCore::DOMApplicationCache::onchecking): (WebCore::DOMApplicationCache::setOnerror): (WebCore::DOMApplicationCache::onerror): (WebCore::DOMApplicationCache::setOnnoupdate): (WebCore::DOMApplicationCache::onnoupdate): (WebCore::DOMApplicationCache::setOndownloading): (WebCore::DOMApplicationCache::ondownloading): (WebCore::DOMApplicationCache::setOnprogress): (WebCore::DOMApplicationCache::onprogress): (WebCore::DOMApplicationCache::setOnupdateready): (WebCore::DOMApplicationCache::onupdateready): (WebCore::DOMApplicationCache::setOncached): (WebCore::DOMApplicationCache::oncached): (WebCore::DOMApplicationCache::setOnobsolete): (WebCore::DOMApplicationCache::onobsolete):

Use ApplicationCachHost defined constants for Status and EventIDs.

16:31 Changeset [46785] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Add pkasting to bugzilla-tool as a committer
https://bugs.webkit.org/show_bug.cgi?id=28002

  • Scripts/modules/committers.py:
16:20 Changeset [46784] by japhet@chromium.org
  • 3 edits in trunk/WebCore

2009-08-04 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Revert r46421 and r46769, which appear to have totally hosed the v8 bindings.

https://bugs.webkit.org/show_bug.cgi?id=27719

16:04 Changeset [46783] by cfleizach@apple.com
  • 15 edits
    2 adds in trunk

WebCore:

2009-08-04 Chris Fleizach <cfleizach@apple.com>

Reviewed by Darin Adler.

Bug 27993 - AXSliders are missing required attributes and actions
https://bugs.webkit.org/show_bug.cgi?id=27993

Expose appropriate actions and attributes for sliders.

Test: platform/mac/accessibility/slider-supports-actions.html

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::orientation):
  • accessibility/AccessibilityObject.h: (WebCore::):
  • accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation):
  • accessibility/AccessibilitySlider.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityActionNames]): (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

WebKitTools:

2009-08-04 Chris Fleizach <cfleizach@apple.com>

Reviewed by Darin Adler.

Bug 27993 - AXSliders are missing required attributes and actions
https://bugs.webkit.org/show_bug.cgi?id=27993

Add ability to check if any arbitrary action is supported.

  • DumpRenderTree/AccessibilityUIElement.cpp: (isActionSupportedCallback): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isActionSupported):
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isActionSupported):

LayoutTests:

2009-08-04 Chris Fleizach <cfleizach@apple.com>

Reviewed by Darin Adler.

Bug 27993 - AXSliders are missing required attributes and actions
https://bugs.webkit.org/show_bug.cgi?id=27993

Update tests to use more generic isActionSupported.

  • accessibility/aria-link-supports-press.html:
  • accessibility/button-press-action.html:
  • accessibility/onclick-handlers.html:
  • platform/mac/accessibility/slider-supports-actions-expected.txt: Added.
  • platform/mac/accessibility/slider-supports-actions.html: Added.
15:52 Changeset [46782] by jianli@chromium.org
  • 2 edits in trunk/WebCore

2009-08-04 Jian Li <jianli@chromium.org>

Reviewed by David Levin.

[V8] Fix an assert in WebCoreStringResource that causes worker script
evaluation failed.
https://bugs.webkit.org/show_bug.cgi?id=27996

The fix is to check for the same thread, instead of the main thread.
This is because Chromium's workers use v8 in a single thread that is
not the main thread.

  • bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource): (WebCore::WebCoreStringResource::atomicString):
15:46 Changeset [46781] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2009-08-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool unit tests need a test harness
https://bugs.webkit.org/show_bug.cgi?id=27977

  • Scripts/run-webkit-unittests: Added.
15:19 Changeset [46780] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

wx build fix after InspectorClient API change.

14:43 Changeset [46779] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-04 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

LayoutTests are too slow
https://bugs.webkit.org/show_bug.cgi?id=27995

Shave 5 seconds off of run-webkit-tests.

  • fast/events/click-count.html: use eventSender.leapForward instead of setTimeout
14:35 Changeset [46778] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-04 Gavin Barraclough <barraclough@apple.com>

Rubber Stamped by Oiver Hunt.

Revert r46643 since this breaks the Yarr::Interpreter running the v8 tests.
https://bugs.webkit.org/show_bug.cgi?id=27874

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::allocDisjunctionContext): (JSC::Yarr::Interpreter::freeDisjunctionContext): (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
13:59 BuildingOnWindows edited by jessieberlin@gmail.com
Move the information about setting the WebKitLibrariesDir out of the … (diff)
13:54 Changeset [46777] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

PPC64 Build fix

12:57 Changeset [46776] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2009-08-04 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Add support for transitions/animations of text-indent.

Test: transitions/text-indent-transition.html

  • page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):
12:52 Changeset [46775] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Ensure that DumpRenderTreeSupport is regenerated when switching between OS versions
by listing the DumpRenderTree binary as a dependency. Xcode has the smarts to rebuild
DumpRenderTree itself when switching OS versions so this dependency removes the need
for any smarts in the Makefile.

Rubber-stamped by Gavin "Gavvy" Barraclough.

  • DumpRenderTree/mac/PerlSupport/Makefile:
12:46 Changeset [46774] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Update test results after addition of AXRequired in r46768.

  • platform/mac/accessibility/lists-expected.txt:
12:38 Changeset [46773] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2009-08-04 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Add support for transitions of min- and max-width, and min- and max-height.
https://bugs.webkit.org/show_bug.cgi?id=27990

Test: transitions/min-max-width-height-transitions.html

  • page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):
12:17 Changeset [46772] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2009-08-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool needs unit tests
https://bugs.webkit.org/show_bug.cgi?id=26916

Add some basic unit testing for scm.py.

  • Scripts/modules/scm.py:
  • Scripts/modules/scm_unittest.py: Added.
12:06 Changeset [46771] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Fix --skipped=only mode to honor flags such as --no-http and platform ignored directories by checking
to make sure the Skipped entries are not in the $ignoredDirectories array. Directories commonly included
are (http, media, compositing, wml, wcss).

https://bugs.webkit.org/show_bug.cgi?id=27893

  • Scripts/run-webkit-tests:
11:15 Changeset [46770] by cfleizach@apple.com
  • 8 edits
    2 adds in trunk

Bug 27964 - WAI-ARIA: radio button does not determine its label from text content
https://bugs.webkit.org/show_bug.cgi?id=27964

10:28 Changeset [46769] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2009-08-04 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Missed a place that expects window.event to be hidden when it shouldn't be.

https://bugs.webkit.org/show_bug.cgi?id=27719

09:15 Changeset [46768] by cfleizach@apple.com
  • 16 edits
    2 adds in trunk

Bug 27958 - WAI-ARIA: Implement 'aria-required' attribute.
https://bugs.webkit.org/show_bug.cgi?id=27958

08:20 Changeset [46767] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-08-04 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] QWebFrame::requestedUrl method can mis-behave in case of unhandled sslErrors.
https://bugs.webkit.org/show_bug.cgi?id=27804

  • Api/qwebframe.cpp: (QWebFrame::requestedUrl):
  • tests/qwebframe/tst_qwebframe.cpp:
07:58 Changeset [46766] by ben@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-04 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by Adam Treat

Explicitly include limits.h header when using INT_MAX and INT_MIN

  • interpreter/Interpreter.cpp
07:51 Changeset [46765] by ariya@webkit.org
  • 2 edits
    8 adds in trunk/LayoutTests

2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] Add passed test results, with pixel tests.

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvas-composite-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-composite-expected.png: Added.
  • platform/qt/fast/canvas/canvas-composite-expected.txt: Added.
  • platform/qt/fast/canvas/drawImage-expected.checksum: Added.
  • platform/qt/fast/canvas/drawImage-expected.png: Added.
  • platform/qt/fast/canvas/drawImage-expected.txt: Added.
  • platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.checksum: Added.
  • platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
07:50 Changeset [46764] by hausmann@webkit.org
  • 5 edits in trunk/WebKit/qt

2009-08-04 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Rename QWebPlugin to QWebPluginInfo, as discussed on IRC.

  • Api/qwebplugindatabase.cpp: (QWebPluginInfoPrivate::QWebPluginInfoPrivate): (QWebPluginInfo::QWebPluginInfo): (QWebPluginInfo::~QWebPluginInfo): (QWebPluginInfo::name): (QWebPluginInfo::description): (QWebPluginInfo::mimeTypes): (QWebPluginInfo::supportsMimeType): (QWebPluginInfo::path): (QWebPluginInfo::isNull): (QWebPluginInfo::setEnabled): (QWebPluginInfo::isEnabled): (QWebPluginInfo::operator==): (QWebPluginInfo::operator!=): (QWebPluginInfo::operator=): (QWebPluginDatabase::plugins): (QWebPluginDatabase::pluginForMimeType): (QWebPluginDatabase::setPreferredPluginForMimeType):
  • Api/qwebplugindatabase.h:
  • Api/qwebplugindatabase_p.h:
  • tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: (tst_QWebPluginDatabase::installedPlugins): (tst_QWebPluginDatabase::searchPaths): (tst_QWebPluginDatabase::null_data): (tst_QWebPluginDatabase::null): (tst_QWebPluginDatabase::pluginForMimeType): (tst_QWebPluginDatabase::enabled): (tst_QWebPluginDatabase::operatorequal_data): (tst_QWebPluginDatabase::operatorequal): (tst_QWebPluginDatabase::preferredPlugin):
07:50 Changeset [46763] by hausmann@webkit.org
  • 5 edits in trunk/WebKit/qt

2009-08-04 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Adam Treat.

Replace QWebPlugin::MimeType with a typedef to
QWebPluginFactory::MimeType.

  • Api/qwebplugindatabase.cpp:
  • Api/qwebplugindatabase.h:
  • Api/qwebpluginfactory.cpp: (QWebPluginFactory::MimeType::operator==):
  • Api/qwebpluginfactory.h:
07:50 Changeset [46762] by hausmann@webkit.org
  • 7 edits
    6 adds in trunk

WebCore:

2009-08-04 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

Add QWebPluginDatabase API to the Qt API.

https://bugs.webkit.org/show_bug.cgi?id=27651

  • WebCore.pro:

WebKit/qt:

2009-08-04 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

Add QWebPluginDatabase API to the Qt API.

https://bugs.webkit.org/show_bug.cgi?id=27651

  • Api/headers.pri:
  • Api/qwebplugindatabase.cpp: Added. (QWebPluginPrivate::QWebPluginPrivate): (QWebPluginDatabasePrivate::QWebPluginDatabasePrivate): (QWebPlugin::MimeType::operator==): (QWebPlugin::QWebPlugin): (QWebPlugin::~QWebPlugin): (QWebPlugin::name): (QWebPlugin::description): (QWebPlugin::mimeTypes): (QWebPlugin::supportsMimeType): (QWebPlugin::path): (QWebPlugin::isNull): (QWebPlugin::setEnabled): (QWebPlugin::isEnabled): (QWebPlugin::operator==): (QWebPlugin::operator!=): (QWebPlugin::operator=): (QWebPluginDatabase::QWebPluginDatabase): (QWebPluginDatabase::~QWebPluginDatabase): (QWebPluginDatabase::plugins): (QWebPluginDatabase::defaultSearchPaths): (QWebPluginDatabase::searchPaths): (QWebPluginDatabase::setSearchPaths): (QWebPluginDatabase::addSearchPath): (QWebPluginDatabase::refresh): (QWebPluginDatabase::pluginForMimeType): (QWebPluginDatabase::setPreferredPluginForMimeType):
  • Api/qwebplugindatabase.h: Added.
  • Api/qwebplugindatabase_p.h: Added.
  • Api/qwebsettings.cpp: (QWebSettings::pluginDatabase):
  • Api/qwebsettings.h:
  • tests/qwebplugindatabase/qwebplugindatabase.pro: Added.
  • tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: Added. (tst_QWebPluginDatabase::installedPlugins): (tst_QWebPluginDatabase::searchPaths): (tst_QWebPluginDatabase::null_data): (tst_QWebPluginDatabase::null): (tst_QWebPluginDatabase::pluginForMimeType): (tst_QWebPluginDatabase::enabled): (tst_QWebPluginDatabase::operatorequal_data): (tst_QWebPluginDatabase::operatorequal): (tst_QWebPluginDatabase::preferredPlugin):
  • tests/tests.pro:
07:34 Changeset [46761] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Adam Treat.

[Qt] PlusDarker is not supported. Fall back to CompositionMode_Darken
(as it is the closest match) instead of CompositionMode_SourceOver.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode):
07:24 Changeset [46760] by ariya@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Adam Treat.

[Qt] Fix the metrics.

  • platform/qt/fast/canvas/canvas-before-css-expected.txt:
06:30 Changeset [46759] by ariya@webkit.org
  • 3 edits
    14 adds in trunk/LayoutTests

2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Add pixel tests result.

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvas-as-image-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-as-image-expected.png: Added.
  • platform/qt/fast/canvas/canvas-as-image-expected.txt: Added.
  • platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
  • platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Added.
  • platform/qt/fast/canvas/canvas-before-css-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-before-css-expected.png: Added.
  • platform/qt/fast/canvas/canvas-before-css-expected.txt:
  • platform/qt/fast/canvas/canvas-bg-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-bg-expected.png: Added.
  • platform/qt/fast/canvas/canvas-bg-expected.txt: Added.
  • platform/qt/fast/canvas/canvas-bg-zoom-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-bg-zoom-expected.png: Added.
  • platform/qt/fast/canvas/canvas-bg-zoom-expected.txt: Added.
06:26 Changeset [46758] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-04 Adam Treat <adam.treat@torchmobile.com>

Fix buildbot. This was supposed to be part of the last commit r46757, but the hunk never made it in.

  • platform/qt/fast/block/float/033-expected.txt:
05:45 EFLWebKit edited by tonikitoo@gmail.com
(diff)
05:22 Changeset [46757] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-04 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Remove LayoutTests/fast/block/float/033.html from the Qt Skipped list

The expected value was incorrect and it has been modified. The new expected value is similar to the MAC version as well.

  • platform/qt/Skipped:
  • platform/qt/fast/block/float/033-expected.txt:
02:28 Changeset [46756] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-04 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>

Reviewed by Adam Barth.

[v8] Fix crash when converting empty v8 string to atomic webkit string.
https://bugs.webkit.org/show_bug.cgi?id=27975

collection-null-like-arguments.html tests for this.

  • bindings/v8/V8Binding.cpp: (WebCore::v8StringToAtomicWebCoreString):
02:26 Changeset [46755] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-08-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool --commit-queue should validate commit-queue setter is a committer
https://bugs.webkit.org/show_bug.cgi?id=27974

With a test!

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/bugzilla_unittest.py:
01:59 Changeset [46754] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(r46700): bugzilla-tool land-diff double-spaces ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=27973

The trailing comma (suppresses newlines) was lost in r46700.

  • Scripts/bugzilla-tool:
01:54 Changeset [46753] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2009-08-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool has too many fatal errors
https://bugs.webkit.org/show_bug.cgi?id=27969

Replace several fatal errors with ScriptError exceptions.

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
  • Scripts/modules/scm.py:
01:34 Changeset [46752] by eric@webkit.org
  • 1 edit in trunk/WebKitTools/ChangeLog

2009-08-04 Eric Seidel <eric@webkit.org>

No review, ChangeLog fix only.

Fix a ChangeLog line-spacing disaster caused by:
https://bugs.webkit.org/show_bug.cgi?id=27973

Still unsure what the fix for bugzilla-tool will be.

01:18 Changeset [46751] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-08-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool --commit-queue should only land commit-queue+ patches
https://bugs.webkit.org/show_bug.cgi?id=27970

commit-queue mode for bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=27918

Make bugzilla tool smart enough to find the commit-queue+ flags and
land those patches.
When we call land-patches with --commit-queue, we should filter the
patches we land to only those that have the commit-queue+ flag set.
That way, when we call bugzilla-tool from a main commit queue process,
we won't land the wrong patches.

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
01:14 Changeset [46750] by eric@webkit.org
  • 2 edits
    3 adds in trunk/WebKitTools

2009-08-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

committer logic should be split out of bugzilla.py into its own module

https://bugs.webkit.org/show_bug.cgi?id=27972

I also added unit tests for the functionality I added.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/bugzilla_unittest.py: Added.
  • Scripts/modules/commiters_unittest.py: Added.
  • Scripts/modules/committers.py: Added.
00:13 Changeset [46749] by rniwa@webkit.org
  • 4 edits in trunk/WebCore

2009-08-04 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

selectionHasStyle needs clean up to fix Bug 27858
https://bugs.webkit.org/show_bug.cgi?id=27865

This patch cleans up selectionStartHasStyle and selectionHasStyle.
No test is added because the patch does not change any behavior.

  • editing/ApplyStyleCommand.cpp: (WebCore::getPropertiesNotInComputedStyle): Used in triStateOfStyleInComputedStyle but will be used here as well
  • editing/ApplyStyleCommand.h: Added the prototype of getPropertiesNotInComputedStyle
  • editing/Editor.cpp: (WebCore::triStateOfStyleInComputedStyle): Determines if the specified style is present in the specified computed style. (WebCore::Editor::selectionStartHasStyle): Uses triStateOfStyleInComputedStyle (WebCore::Editor::selectionHasStyle): Uses triStateOfStyleInComputedStyle instead of updateState
00:06 Changeset [46748] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-08-03 John Abd-El-Malek <jam@chromium.org>

Reviewed by David Levin.

Fix MessagePort construction in worker process. Also make the other object constructions match this.

https://bugs.webkit.org/show_bug.cgi?id=27906

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertToV8Object):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object):

08/03/09:

23:34 Changeset [46747] by abarth@webkit.org
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixup ChangeLog

23:14 Changeset [46746] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-03 Harald Fernengel <harald.fernengel@nokia.com>

Reviewed by NOBODY

Fix ambiguity in abs(long int) call by calling labs() instead

  • wtf/DateMath.cpp: replace call to abs() with labs()
22:39 Changeset [46745] by levin@chromium.org
  • 5 edits in trunk/WebCore

2009-08-03 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>

Reviewed by David Levin.

[V8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource): (WebCore::WebCoreStringResource::data): (WebCore::WebCoreStringResource::length): (WebCore::WebCoreStringResource::webcoreString): (WebCore::WebCoreStringResource::atomicString): (WebCore::WebCoreStringResource::toStringResource): (WebCore::v8StringToWebCoreString): (WebCore::v8StringToAtomicWebCoreString): (WebCore::v8ValueToWebCoreString): (WebCore::v8ValueToAtomicWebCoreString):
  • bindings/v8/V8Binding.h: (WebCore::):
  • dom/Document.idl:
19:24 UsingGitWithWebKit edited by joepeck02@gmail.com
Added Section on Ignores (diff)
19:21 Changeset [46744] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-08-03 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: DOM Storage Live Updating Should Not Affect Tabbing
https://bugs.webkit.org/show_bug.cgi?id=27957

  • inspector/front-end/DOMStorageDataGrid.js: (WebInspector.DOMStorageDataGrid.prototype._startEditingColumnOfDataGridNode): disable storage event listener (WebInspector.DOMStorageDataGrid.prototype._startEditing): disable storage event listener (WebInspector.DOMStorageDataGrid.prototype._editingCancelled): enable storage event listener
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype._unregisterStorageEventListener): quick return if no listener
19:14 Changeset [46743] by abarth@webkit.org
  • 6 edits in trunk

2009-08-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Consolidate common gcc flags to WebKit.pri
https://bugs.webkit.org/show_bug.cgi?id=27934

2009-08-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Consolidate common gcc flags to WebKit.pri
https://bugs.webkit.org/show_bug.cgi?id=27934

  • WebCore.pro:

2009-08-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Consolidate common gcc flags to WebKit.pri
https://bugs.webkit.org/show_bug.cgi?id=27934

  • WebKit.pri:
18:29 Changeset [46742] by pkasting@chromium.org
  • 3 edits in trunk/WebKitTools

2009-08-03 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Handle any kind of line endings in svn-apply and svn-unapply, instead
of assuming LF.

  • Scripts/svn-apply:
  • Scripts/svn-unapply:
18:08 Changeset [46741] by jorlow@chromium.org
  • 7 edits in trunk/WebCore

2009-08-03 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Chromium code sometimes isn't sandboxed and needs to access the FS.
https://bugs.webkit.org/show_bug.cgi?id=27954

These changes are the WebKit side of http://codereview.chromium.org/159778 which
aims to make LocalStorage persistent.

This change runs all FileSystem routines through the ChromiumBridge so that
WebKitClients can handle them if they choose to. For now, the only such client
will be the one running in the browser process.

It also adds a method called sandboxEnabled to the Chromium bridge so that the
SQLite file system code can shift its behavior depending on whether we're
inside a sandbox or not.

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileModificationTime): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists):
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::openDatabase):
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):
17:43 Changeset [46740] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2009-08-03 Alpha Lam <hclam@chromium.org>

Reviewed by David Levin.

[chromium] Implement media slider for chromium
https://bugs.webkit.org/show_bug.cgi?id=27859

Implemented the media slider for chromium port. The implementation
is using Skia for drawing the thumb and buffered region instead of
using any native system controls so different platforms would have
the same look and feel.

No new tests because this is covered by existing tests.

  • css/mediaControlsChromium.css:
  • rendering/RenderThemeChromiumSkia.cpp:
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeChromiumWin.cpp:
17:28 Changeset [46739] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-08-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool land-patches needs --queue mode
https://bugs.webkit.org/show_bug.cgi?id=27961

Add a --commit-queue command line option to suppress user interaction.

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
16:48 Changeset [46738] by pkasting@chromium.org
  • 12 edits in trunk/WebCore

2009-07-27 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26460
Plumbing and cleanup in advance of returning multiple frames from the
ICOImageDecoder:

  • Make ImageDecoder::frameCount() return a size_t like ImageSource::frameCount() and BitmapImage::frameCount() already do.
  • Add ImageDecoder::frameSizeAtIndex() alongside size(), to report the size of a particular frame. Hook all the ImageSource::frameSizeAtIndex() implementations to this. No ImageDecoder implements this yet; that will come in my next change.
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::frameCount): returns size_t.
  • platform/graphics/qt/ImageDecoderQt.h: frameCount() returns size_t.
  • platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/graphics/win/ImageCGWin.cpp: (WebCore::BitmapImage::drawFrameMatchingSourceSize): frameCount() returns size_t.
  • platform/graphics/win/ImageCairoWin.cpp: (WebCore::BitmapImage::drawFrameMatchingSourceSize): frameCount() returns size_t.
  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::size): Clarify comment. (WebCore::ImageDecoder::frameSizeAtIndex): Add. (WebCore::ImageDecoder::frameCount): returns size_t. (WebCore::ImageDecoder::frameBufferAtIndex): Remove unneeded param name.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameCount): returns size_t. (WebCore::GIFImageDecoder::frameBufferAtIndex): frameCount() returns size_t.
  • platform/image-decoders/gif/GIFImageDecoder.h: frameCount() returns size_t.
16:42 Changeset [46737] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Build fix. Add installsrc, installhdrs and install targets.

  • DumpRenderTree/mac/PerlSupport/Makefile:
15:59 Changeset [46736] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-08-03 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Darin Adler.

Fix a bug that could cause an ASSERT to fail incorrectly, leading
to a renderer crash in Chromium.

https://bugs.webkit.org/show_bug.cgi?id=27947

All tests in storage/ pass.

  • platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::~SQLiteTransaction): (WebCore::SQLiteTransaction::begin):
15:05 Changeset [46735] by mrowe@apple.com
  • 4 edits in trunk/WebKitSite

Update two WordPress plug-ins that we use.

  • blog/wp-content/plugins/akismet/akismet.php:
  • blog/wp-content/plugins/akismet/readme.txt:
  • blog/wp-content/plugins/commentcontrol.php:
15:02 Changeset [46734] by mrowe@apple.com
  • 1 edit
    2 copies
    15 moves
    114 adds
    129 deletes in trunk/WebKitSite

Add some missing files and delete some obsolete files.

  • blog:
14:55 Changeset [46733] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-03 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

Based on work by Yael Aharon.

Implement keyboard event forwarding for windowless plugins
for the Qt port.

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::dispatchNPEvent): (WebCore::setSharedXEventFields): (WebCore::setXKeyEventSpecificFields): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
  • xml/NativeXPathNSResolver.cpp:
14:28 Changeset [46732] by timothy@apple.com
  • 8 edits
    1 move
    2 adds in trunk/WebCore

Make the bottom "drawer" of the Web Inspector more extensible to support other views.

2009-08-03 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Make Bottom "Drawer" More Extensible To Support Other Views
https://bugs.webkit.org/show_bug.cgi?id=27928

  • English.lproj/localizedStrings.js:

"Show changes view", "Hide changes view", "Clear changes log", "%d style change", "%d style changes"

To be a new view to show Changes made via the inspector. DOM, CSS, or otherwise.

  • inspector/front-end/Console.js: Removed.

Sliding View aspect moved to Drawer.js. The "console" itself has moved to ConsoleView.js

  • inspector/front-end/ConsoleView.js: Added.

Little has changed from its move from Console.js other then support for working with the Drawer.

Allow for multiple views inside the Sliding Drawer.

Starting work on the "Changes" Panel. The ability to generate a Stylesheet from Styles added via the Inspector.

  • inspector/front-end/Images/styleIcon.png: Added.
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.isInspectorStylesheet): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.makeNormal): (WebInspector.StylePropertyTreeElement.prototype):

Interface with ElementsPanel for generating a Stylesheet of Changes.

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: Refactored to allow for multiple views in the drawer.
  • inspector/front-end/inspector.html: Refactored to allow for multiple views in the drawer.

Support for the drawer and "styles changed icon" similar to the "errors and warnings" icons.

14:24 Changeset [46731] by mrowe@apple.com
  • 338 edits
    18 copies
    1 move
    133 adds
    14 deletes in trunk/WebKitSite

Update WordPress to the latest version.

  • blog:
14:00 Changeset [46730] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-03 Dean McNamee <deanm@chromium.org>

Reviewed by Adam Barth.

Correct an assert on a PassRefPtr in the v8 svg bindings.
https://bugs.webkit.org/show_bug.cgi?id=27951

  • bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::V8SVGDynamicPODTypeWrapper::V8SVGDynamicPODTypeWrapper):
13:23 Changeset [46729] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-03 Jan Michael Alonzo <jmalonzo@webkit.org>

[Gtk] Skip accessibility/input-slider.html as it needs
Accessibility support in DRT which the Gtk do not have an
implementation at the moment.

  • platform/gtk/Skipped:
13:00 Changeset [46728] by weinig@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2009-08-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Sam Weinig.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27748
crash w/ stack overflow when same CSS file loaded repeatedly

Fix crash caused by a stack overflow when repeatedly loading very large
CSS files. CSSRuleData in CSSStyleSelector.h destroyed itself
recursively rather than iteratively.

Test: fast/css/large-list-of-rules-crash.html

  • css/CSSStyleSelector.h: (WebCore::CSSRuleData::~CSSRuleData): (WebCore::CSSRuleDataList::~CSSRuleDataList):

LayoutTests:

2009-08-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Sam Weinig.

Test for https://bugs.webkit.org/show_bug.cgi?id=27748
crash w/ stack overflow when same CSS file loaded repeatedly

Fix crash caused by a stack overflow when repeatedly loading very large
CSS files. CSSRuleData in CSSStyleSelector.h destroyed itself
recursively rather than iteratively.

  • fast/css/large-list-of-rules-crash-expected.txt: Added.
  • fast/css/large-list-of-rules-crash.html: Added.
  • fast/css/resources/large-list-of-rules-crash.css: Added.
12:40 Changeset [46727] by simon.fraser@apple.com
  • 20 edits in trunk

2009-08-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Make the DRT APIs to pause transitions and animations work for accelerated animations
<https://bugs.webkit.org/show_bug.cgi?id=27627>
<rdar://problem/6442932>

Fix the 'pauseAnimationAtTimeOnElementWithId' and 'pauseTransitionAtTimeOnElementWithId' APIs
available to LayoutTests to work with accelerated animations and transitions. Done by sending
the pause time down to the GraphicsLayer, and using it to stop time on the layer.

I also added an assertion to check that the animation has actually started when we
try to pause it, to check that the pause time we compute is valid. This revealed a number
of tests that tried to pause before animations started, required some amount of test fixing.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::freezeAtTime):
  • page/animation/AnimationBase.h:
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::pauseTransitionAtTime):
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::suspendAnimations):
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::suspendAnimations):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::suspendAnimations):
  • rendering/RenderLayerBacking.h:
11:47 Changeset [46726] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-03 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

Fix Chromium build by removing PluginView.h from Page.cpp.
Chromium doesn't use PluginView and the pointer is never
dereferenced so the header doesn't need to be included.
https://bugs.webkit.org/show_bug.cgi?id=27946

No new tests because this is a build fix.

  • page/Page.cpp:
11:46 Changeset [46725] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed the Tiger build.

  • wtf/FastMalloc.cpp:
11:34 Changeset [46724] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Don't use background thread to scavenge memory on Tiger until we figure out why it causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=27900

  • wtf/FastMalloc.cpp:
11:00 Changeset [46723] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-08-03 Eric Carlson <eric.carlson@apple.com>

One more build fix after https://bugs.webkit.org/show_bug.cgi?id=46720.

Unreviewed.

  • WebCoreSources.bkl:
10:34 Changeset [46722] by eric.carlson@apple.com
  • 5 edits in trunk/WebCore

2009-08-03 Eric Carlson <eric.carlson@apple.com>

Build fix after https://bugs.webkit.org/show_bug.cgi?id=46720.

Unreviewed.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
10:13 Changeset [46721] by cfleizach@apple.com
  • 6 edits
    2 adds in trunk

Bug 27943 - Need to implement ARIA role="radiogroup"
https://bugs.webkit.org/show_bug.cgi?id=27943

10:07 Changeset [46720] by eric.carlson@apple.com
  • 14 edits
    4 adds in trunk

2009-08-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

HTMLInputElement is not controllable by assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=27941

Test: accessibility/input-slider.html

  • WebCore.xcodeproj/project.pbxproj:

Add AccessibilitySlider.cpp/.h

  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate):

Create AccessibilitySlider and AccessibilitySliderThumb.

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::increment): (WebCore::AccessibilityObject::decrement):

Add default, do nothing, base class methods.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::canSetFocusAttribute):

Correct typo.

  • accessibility/AccessibilitySlider.cpp: Added. (WebCore::AccessibilitySlider::AccessibilitySlider): (WebCore::AccessibilitySlider::create): (WebCore::AccessibilitySlider::children): (WebCore::AccessibilitySlider::addChildren): (WebCore::AccessibilitySlider::getAttribute): (WebCore::AccessibilitySlider::valueForRange): (WebCore::AccessibilitySlider::maxValueForRange): (WebCore::AccessibilitySlider::minValueForRange): (WebCore::AccessibilitySlider::changeValue): (WebCore::AccessibilitySlider::setValue): (WebCore::AccessibilitySlider::increment): (WebCore::AccessibilitySlider::decrement): (WebCore::AccessibilitySlider::element): (WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::create): (WebCore::AccessibilitySliderThumb::elementRect): (WebCore::AccessibilitySliderThumb::size):
  • accessibility/AccessibilitySlider.h: Added. (WebCore::AccessibilitySlider::~AccessibilitySlider): (WebCore::AccessibilitySlider::roleValue): (WebCore::AccessibilitySlider::accessibilityIsIgnored): (WebCore::AccessibilitySlider::isSlider): (WebCore::AccessibilitySlider::canSetValueAttribute): (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::roleValue): (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored): (WebCore::AccessibilitySliderThumb::setParentObject): (WebCore::AccessibilitySliderThumb::parentObject):
  • accessibility/mac/AccessibilityObjectWrapper.mm: (RoleEntry::):

SliderThumbRole -> NSAccessibilityValueIndicatorRole

(-[AccessibilityObjectWrapper roleDescription]):

Return role description for NSAccessibilitySliderRole and NSAccessibilityValueIndicatorRole.

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

Minor coding style correction.

(-[AccessibilityObjectWrapper accessibilityPerformPressAction]):

If attachement view handles press action, don't also call object wrapper.

(-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):

New, call object's increment() method.

(-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):

New, call object's decrement() method.

(-[AccessibilityObjectWrapper accessibilityPerformAction:]):

Respond to NSAccessibilityIncrementAction and NSAccessibilityDecrementAction.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::thumbRect):

Factor logic out of layout so AccessibilitySliderThumb can get thumb location/size.

(WebCore::RenderSlider::layout):

Move code to thumbRect().

  • rendering/RenderSlider.h:

2009-08-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

HTMLInputElement is not controllable by assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=27941

Accessibility control of a slider required adding increment() and decrement()
methods to AccessibilityObject, so expose thos methods on AccessibilityUIElement.

  • DumpRenderTree/AccessibilityUIElement.cpp: (incrementCallback): New, call UI element increment method. (decrementCallback): New, call UI element decrement method. (AccessibilityUIElement::getJSClass): Expose increment and decrement methods.
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::increment): New, send NSAccessibilityIncrementAction to Mac wrapper. (AccessibilityUIElement::decrement): New, send NSAccessibilityDecrementAction to Mac wrapper.
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::increment): New, do nothing. (AccessibilityUIElement::decrement): New, do nothing.

2009-08-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

HTMLInputElement is not controllable by assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=27941


Add test for <input type=range> accessibility .

  • accessibility/input-slider.html: Added.
  • platform/mac/accessibility/input-slider-expected.txt: Added.
10:00 Changeset [46719] by kenneth@webkit.org
  • 3 edits in trunk/WebCore

2009-08-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Build fix if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=27940

  • plugins/PluginView.cpp: (WebCore::PluginView::stop): Do not call NPN_MemFree if NPAPI is disabled
  • plugins/PluginViewNone.cpp: (WebCore::PluginView::platformStart): Empty stub.
09:12 Changeset [46718] by ben@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Joe Mason <joe.mason@torchmobile.com>

Reviewed by George Staikos.

WINCE port: LOAD_WITH_ALTERED_SEARCH_PATH param of
LoadLibraryEx not supported on WINCE
https://bugs.webkit.org/show_bug.cgi?id=27917

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):use LoadLibrary instead of LoadLibraryEx
07:50 Changeset [46717] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-08-03 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Do memory cleanup when running robotized QtLauncher in debug as well.

  • QtLauncher/main.cpp: (launcherMain): (main):
05:03 Changeset [46716] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Jan Alonzo.

Fix build break on Gtk/x86_64.
https://bugs.webkit.org/show_bug.cgi?id=27936

Use JSVALUE64 for X86_64 LINUX, except Qt.

  • wtf/Platform.h:
03:27 Changeset [46715] by jmalonzo@webkit.org
  • 1 edit in trunk/ChangeLog

Fix ChangeLog - r46714 was rubber-stamped by Eric

03:23 Changeset [46714] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-08-03 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Eric Seidel.

[Gtk] macros in webkit.m4 should be defined once only
https://bugs.webkit.org/show_bug.cgi?id=27929

The macros in webkit.m4 are not meant to be called multiple times
so we'll make them AC_DEFUN_ONCE. Also make AC_HEADER_STDC and AC_PROG_CXX
AC_REQUIRE to remove the automake warnings when doing autogen.sh.

  • autotools/webkit.m4:
02:14 Changeset [46713] by vestbo@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Remove extra linebreaks in WebCore/ChangeLog introduced in r46711

08/02/09:

23:33 Changeset [46712] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Xan Lopez <xlopez@igalia.com>

Fix the GTK+ build.

  • wtf/Platform.h:
21:12 Changeset [46711] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-02 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

SVGElementInstance::scriptExecutionContext should call document() instead of scriptExecutionContext()

https://bugs.webkit.org/show_bug.cgi?id=27932

There's no reason to pay for a virtual function call in this case. We

can just call document() directly because we know that element is a

Node*.

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::scriptExecutionContext):

20:49 Changeset [46710] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-08-02 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

JSNodeCustom should call document() instead of scriptExecutionContext()
https://bugs.webkit.org/show_bug.cgi?id=27931

We want to call document() because it's in inline function, instead of
scriptExecutionContext() because it's a virtual function. If we have a
Node*, then we know that the virtual function will always return the
document anyway.

There are more instance of this bug, but I'd like to start with a small
patch and work up.

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::toJSDOMGlobalObject):
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
16:10 Changeset [46709] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Disabled JSVALUE32_64 on Qt builds, since all layout tests mysteriously
crash with it enabled.

  • wtf/Platform.h:
16:08 Changeset [46708] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-02 Sam Weinig <sam@webkit.org>

Land updated expected result.

  • fast/js/array-filter-expected.txt:
15:48 Changeset [46707] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-02 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Speed up fast/js/array-filter.html by 10x in debug builds by not using an
unnecessarily large sparse array.

  • fast/js/resources/array-filter.js:
15:10 Changeset [46706] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <ggaren@apple.com>

Qt build fix.

Added JSAPIValueWrapper.cpp to the build.

15:00 Changeset [46705] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <ggaren@apple.com>

Windows build fix.

Exported symbols for JSAPIValueWrapper.

14:56 Changeset [46704] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <ggaren@apple.com>

GTK build fix.

  • jit/JITStubs.cpp: #include <stdarg.h>, for a definition of va_start.
14:52 Changeset [46703] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <ggaren@apple.com>

Qt build fix.


  • runtime/Collector.cpp: #include <limits.h>, for a definition of ULONG_MAX.
14:45 Changeset [46702] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <ggaren@apple.com>

Windows build fix: Nixed JSImmediate::prototype, JSImmediate::toObject,
and JSImmediate::toThisObject, and removed their exported symbols.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
  • runtime/JSImmediate.cpp:
  • runtime/JSImmediate.h:
14:33 Changeset [46701] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Mark Rowe.

Enabled JSVALUE32_64 by default on all platforms other than x86_64 (which uses JSVALUE64).

  • wtf/Platform.h:
07:26 Changeset [46700] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

2009-08-02 David D. Kilzer <ddkilzer@webkit.org>

<http://webkit.org/b/27930> bugzilla-tool hates Tor Arne Vestbø

Reviewed by Tor Arne Vestbø.

  • Scripts/bugzilla-tool: (set_reviewer_in_changelog): Made sure reviewer is properly encoded when calling replace().
07:09 Changeset [46699] by vestbo@webkit.org
  • 7 edits in trunk/WebCore

2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Anders Carlsson.

Share implementation of PluginView::userAgent() and userAgentStatic()

https://bugs.webkit.org/show_bug.cgi?id=27706

Differences to the original implementation are as follows:

  • The Win port used to return 0 for userAgentStatic, but now returns the quirk mode MozillaUserAgent as the other ports.
  • plugins/PluginView.cpp: (WebCore::PluginView::userAgent): (WebCore::PluginView::userAgentStatic):
  • plugins/PluginViewNone.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/mac/PluginViewMac.cpp:
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp:
07:00 Changeset [46698] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Anders Carlsson.

Unregister plugin from PluginMainThreadScheduler if NPP_New fails

https://bugs.webkit.org/show_bug.cgi?id=27706

Since the plugin has not been started yet (m_isStarted is not set),
calling stop() will not have any affect, so we manually unregister
in start() before returning.

  • plugins/PluginView.cpp: (WebCore::PluginView::start):
06:47 Changeset [46697] by vestbo@webkit.org
  • 7 edits in trunk/WebCore

2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Anders Calsson.

Join the various versions of PluginView::stop() into one shared implementation

https://bugs.webkit.org/show_bug.cgi?id=27706

The platform-dependent bits are now ifdef'ed in the shared implementation,
using the XP_ defines (XP_WIN, XP_MACOSX, XP_UNIX) from npapi.h

Differences to the original implementation are as follows:

  • The Qt port unregistered the plugin before calling NP_SetWindow with a 0 window handle. Now it's done after (similar to Win)
  • The GTK and Qt ports unregistered the plugin before clearing the m_npWindow.ws_info struct. Now it's done after.
  • The Win port constructed the DropAllLocks after unsubclassing the window. Now it's done before.
  • The Mac, Qt, and GTK ports did not pass a NPSavedData struct to NP_Destroy (like the Win port). Now all ports do.
  • The Win port did not call PluginView::setCurrentPluginView() before calling to NP-functions. Now it does.
  • plugins/PluginView.cpp: (WebCore::PluginView::start): (WebCore::PluginView::~PluginView): (WebCore::PluginView::stop):
  • plugins/PluginViewNone.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::getValueStatic):
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handlePostReadFile):
01:54 Changeset [46696] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2009-08-02 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by David Levin.

Script for building the wxBrowser sample app for wx.
https://bugs.webkit.org/show_bug.cgi?id=27619

  • wx/browser/wscript: Added.
01:54 Changeset [46695] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKit/wx

2009-08-02 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Jan Alonzo.

Script for building the WebKit library for wx.
https://bugs.webkit.org/show_bug.cgi?id=27619

  • wscript: Added.
01:54 Changeset [46694] by abarth@webkit.org
  • 1 edit
    1 add in trunk/JavaScriptCore

2009-08-02 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Jan Alonzo.

Script for building the JavaScriptCore library for wx.
https://bugs.webkit.org/show_bug.cgi?id=27619

  • wscript: Added.
01:54 Changeset [46693] by abarth@webkit.org
  • 1 edit
    5 adds in trunk/WebKitTools

2009-08-02 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Jan Alonzo.

Scripts needed for the waf build.
https://bugs.webkit.org/show_bug.cgi?id=27619

  • wx/build: Added.
  • wx/build/build_utils.py: Added.
  • wx/build/settings.py: Added.
  • wx/build/waf_extensions.py: Added.
  • wx/build/wxpresets.py: Added.
01:05 Changeset [46692] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Yong Li <yong.li@torchmobile.com>

Reviewed by George Staikos.

DateMath depends on strftime and localtime, which need to be imported manually on WinCE
https://bugs.webkit.org/show_bug.cgi?id=26558

  • wtf/DateMath.cpp:
00:58 Changeset [46691] by abarth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Initialize HTML5 Application Cache for QtWebKit to a sensible default
https://bugs.webkit.org/show_bug.cgi?id=27866

  • Api/qwebpage.cpp: (initializeApplicationCachePathIfNecessary): (QWebPagePrivate::QWebPagePrivate):
00:41 Changeset [46690] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2009-07-30 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: let me *edit* css styles in the web inspector.
https://bugs.webkit.org/show_bug.cgi?id=27124

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): added property stylesheet pointing to 1 stylesheet added to the page if needed
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): handle blank sections (WebInspector.StylesSidebarPane.prototype.addBlankSection): blank section in the correct position (WebInspector.StylesSidebarPane.prototype.appropriateSelectorForNode): helper to get a nice selector for the selectd node (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype.expand): (WebInspector.StylePropertiesSection.prototype.isPropertyInherited): (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded): (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.StylePropertiesSection.prototype._dblclickEmptySpace): easily create new properties (WebInspector.StylePropertiesSection.prototype._dblclickSelector): (WebInspector.StylePropertiesSection.prototype.startEditingSelector): allow for editing selectors (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled): (WebInspector.StylePropertiesSection.prototype._doesSelectorAffectSelectedNode): helper to check if a selector applies to the selected node (WebInspector.BlankStylePropertiesSection.prototype._dblclick): (WebInspector.BlankStylePropertiesSection.prototype.startEditing): (WebInspector.BlankStylePropertiesSection.prototype.editingCancelled): (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted): (WebInspector.BlankStylePropertiesSection.prototype.makeNormal): morph into a StylePropertiesSection (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):
  • inspector/front-end/inspector.css:
00:33 Changeset [46689] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] check if proxy is present before invoking a handler
https://bugs.webkit.org/show_bug.cgi?id=27883

Do not invoke handler function if proxy is null pointer (that would lead to access violation
anyway)

  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::callListenerFunction):

08/01/09:

23:05 Changeset [46688] by mitz@apple.com
  • 3 edits in trunk/WebKitTools

Reviewed by Darin Adler.

Make pixel test results more consistent across Mac OS X versions

  • DumpRenderTree/cg/ImageDiffCG.cpp: (createDifferenceImage): Avoid color correction when rendering the

images into graphics contexts, so that the actual color values are
compared, regardless of how the images are tagged.

  • DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Set the window’s color space to the

main screen’s color space, even though the window is off-screen.

22:18 Changeset [46687] by abarth@webkit.org
  • 18 edits
    4 adds in trunk/WebCore

2009-08-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Reimplement Elements Panel so that its
interaction with DOM is serialized.

This is a first cut wuth read support for DOM elements
tree as well as some limited editing. No properties, no
styles, no search capabilities are implemented yet.
Set Preferences.useDOMAgent to true in order to try it
out, otherwise disabled by default.

https://bugs.webkit.org/show_bug.cgi?id=27771

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getChildNodes): (WebCore::InspectorBackend::setAttribute): (WebCore::InspectorBackend::removeAttribute): (WebCore::InspectorBackend::setTextNodeValue):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h: (WebCore::InspectorController::domAgent):
  • inspector/InspectorDOMAgent.cpp: Added.
  • inspector/InspectorDOMAgent.h: Added.
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/front-end/Callback.js: Added.
  • inspector/front-end/DOMAgent.js: Added.
  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded):
19:31 Changeset [46686] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Try again to make the Qt build bot happy.

  • BuildSlaveSupport/test-result-archive: Create a placeholder file inside the newly-created

directory to prevent 'zip' from failing due to the directory containing no files.

19:18 Changeset [46685] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Try and make the Qt build bot happy.

  • BuildSlaveSupport/test-result-archive: Handle the case where run-webkit-tests generates

no output files at all and thus does not create the layout-test-results directory.

18:59 Changeset [46684] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Move the include of DumpRenderTreeSupport to after DumpRenderTree has been built.

  • Scripts/run-webkit-tests:
18:41 Changeset [46683] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

wtf/Threading.h: added include of Platform.h

Reviewed by Mark Rowe.

  • wtf/Threading.h: Added #include "Platform.h" since this header uses PLATFORM() and other macros.
18:40 Changeset [46682] by mrowe@apple.com
  • 3 edits
    3 adds in trunk/WebKitTools

Bug 27923: run-webkit-tests should not invoke "ps" repeatedly on Mac OS X
Fix <https://bugs.webkit.org/show_bug.cgi?id=27923>.

Reviewed by Sam Weinig and David D. Kilzer.

run-webkit-tests invokes "ps" after each test on Mac OS X to determine whether DumpRenderTree is
in the process of crashing. We can do the same test more efficiently with a simple call to sysctl.
I couldn't find any built-in way of doing this directly from perl, so we do it from a simple C module
instead. This speeds up run-webkit-tests by around 8%.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Added.

(processIsCrashing):

  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm: Added. Tiger does not have the SWIG tool

that is used to generate the Perl binding to the C code, so we fall back to the old implementation on Tiger.

  • DumpRenderTree/mac/PerlSupport/Makefile: Added.
  • Scripts/run-webkit-tests:
18:04 Changeset [46681] by rniwa@webkit.org
  • 6 edits in trunk/WebCore

2009-08-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adele Peterson.

isContentEditable function in htmlediting.* must be removed
https://bugs.webkit.org/show_bug.cgi?id=27870

This patch removes isContentEditable function in htmlediting.cpp and
replaces all usage by calling Node::isContentEditable or its derivatives.

  • editing/AppendNodeCommand.cpp: ditto (WebCore::AppendNodeCommand::AppendNodeCommand): ditto
  • editing/IndentOutdentCommand.cpp: ditto (WebCore::IndentOutdentCommand::outdentParagraph): ditto
  • editing/InsertNodeBeforeCommand.cpp: ditto (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): ditto
  • editing/htmlediting.cpp: ditto (WebCore::enclosingNodeWithTag): ditto (WebCore::enclosingNodeOfType): ditto (WebCore::canMergeLists): ditto
  • editing/htmlediting.h: Updated prototype
17:24 Changeset [46680] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Display the reminder once rather than once per ChangeLog.

Reviewed by David D. Kilzer.

  • Scripts/prepare-ChangeLog:
16:00 Changeset [46679] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Roll out r46668 as it was misinformed. ScopeChain is only used with placement new.

Rubber-stamped by Oliver Hunt.

  • runtime/ScopeChain.h:
15:52 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
15:49 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
15:48 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
15:48 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
15:22 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
15:08 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
15:01 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
14:57 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
14:57 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
14:55 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
13:13 Changeset [46678] by mrowe@apple.com
  • 3 edits
    2 deletes in trunk/WebKitTools

Roll out r46676. Tiger is why we can't have nice things :-(

13:09 Changeset [46677] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-01 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Mark Rowe.

Remove a non-existent test from the Windows Skipped List.

  • platform/win/Skipped:
13:05 Changeset [46676] by mrowe@apple.com
  • 3 edits
    3 adds in trunk/WebKitTools

Bug 27923: run-webkit-tests should not invoke "ps" repeatedly on Mac OS X
Fix <https://bugs.webkit.org/show_bug.cgi?id=27923>.

Reviewed by Sam Weinig.

run-webkit-tests invokes "ps" after each test on Mac OS X to determine whether DumpRenderTree is
in the process of crashing. We can do the same test more efficiently with a simple call to sysctl.
I couldn't find any built-in way of doing this directly from perl, so we do it from a simple C module
instead. This speeds up run-webkit-tests by around 8%.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Added.

(processIsCrashing):

  • DumpRenderTree/mac/PerlSupport/Makefile: Added.
  • Scripts/run-webkit-tests:
11:35 Changeset [46675] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-01 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Allow custom memory allocation control for JavaScriptCore's HashMap class
http://bugs.webkit.org/show_bug.cgi?id=27871

Inherits HashMap class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/API/JSClassRef.cpp:148.

  • wtf/RefPtrHashMap.h: (WTF::):
11:17 Changeset [46674] by beidson@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

2009-08-01 Brady Eidson <beidson@apple.com>

For my new test I landed last night, check in Tiger-specific results, and skip on Windows.

  • platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
  • platform/win/Skipped: Add to the skipped list because the failure needs exploration.
10:58 Changeset [46673] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-01 John Abd-El-Malek <jam@chromium.org>

Reviewed by Eric Seidel.

Update test to work with multi-process message ports.

https://bugs.webkit.org/show_bug.cgi?id=27819

  • fast/events/message-channel-gc.html:
07:29 Changeset [46672] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

resolve-ChangeLogs: add error checking to git ls-files command on close()

Reviewed by Eric Seidel.

Item 2 of <https://bugs.webkit.org/show_bug.cgi?id=18599#c0>.

  • Scripts/resolve-ChangeLogs: Added error checking to close() after running git ls-files. Added error checking to all system() calls by checking for a non-zero WEXITSTATUS($?).
Changed "
die;" expressions to "or die $!;".
07:29 Changeset [46671] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

Reviewed by Eric Seidel.

  • Scripts/resolve-ChangeLogs: Used chdirReturningRelativePath() and determineVCSRoot() to change directories to the root of the project before running the command and to provide a path for removeChangeLogArguments() to make sure any ChangeLog arguments on the command line are still found. (canonicalRelativePath): Added. Returns a canonical path (e.g., stripping 'dir/../' from the path) relative to the current directory. (removeChangeLogArguments): Added argument which contains a relative path that must be prepended to any ChangeLog arguments. Used canonicalRelativePath() and File::Spec->catfile() to construct a normalized, relative path to each file.
07:29 Changeset [46670] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

Implement VCSUtils::chdirReturningRelativePath()

Reviewed by Eric Seidel.

Step 2 to fix:
<http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

  • Scripts/VCSUtils.pm: (VCSUtils::chdirReturningRelativePath): Moved here from chdirAndGetDifference() in svn-create-patch.
  • Scripts/svn-create-patch: Switched to use chdirReturningRelativePath() instead of chdirAndGetDifference(). (chdirAndGetDifference): Removed.
07:23 Changeset [46669] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

Implement VCSUtils::determineVCSRoot()

Reviewed by Eric Seidel.

Step 1 to fix:
<http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

  • Scripts/VCSUtils.pm: Removed reference to webkitdirs module. (VCSUtils::EXPORT): Added &determineVCSRoot. Realphabetized. (VCSUtils::determineGitRoot): Added. Based on code in commit-log-editor. (VCSUtils::determineVCSRoot): Implemented using determineGitRoot() and determineSVNRoot().
  • Scripts/commit-log-editor: Replaced use of topLevelSourceDirectory() with determineVCSRoot(). Resorted use statements. (topLevelSourceDirectory): Removed.
01:19 Changeset [46668] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-01 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Allow custom memory allocation control for JavaScriptCore's ScopeChain class
https://bugs.webkit.org/show_bug.cgi?id=27834

Inherits ScopeChain class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/JSFunction.h:109.

  • runtime/ScopeChain.h:
00:51 Changeset [46667] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-01 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's RegExpConstructorPrivate struct
https://bugs.webkit.org/show_bug.cgi?id=27833

Inherits RegExpConstructorPrivate class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/RegExpConstructor.cpp:152.

  • runtime/RegExpConstructor.cpp:
00:37 Changeset [46666] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-01 John Abd-El-Malek <jam@chromium.org>

Reviewed by Adam Barth.

Fix a message port handle always getting marked as reachable once it gets entangled.

https://bugs.webkit.org/show_bug.cgi?id=27824

No tests since this only arises with the Chromium multi-process message port implementation
which isn't in this repostiory.

  • bindings/v8/V8GCController.cpp: (WebCore::GCEpilogueVisitor::visitDOMWrapper):
00:23 Changeset [46665] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-08-01 Evan Martin <evan@chromium.org>

Reviewed by Adam Barth.

Add a regression test for a crash when a page has smart quotes in a
mime type.

  • fast/parser/smart-quotes-in-tag-expected.txt: Added.
  • fast/parser/smart-quotes-in-tag.html: Added.
Note: See TracTimeline for information about the timeline view.