Timeline


and

08/12/09:

22:58 Changeset [47186] by barraclough@apple.com
  • 12 edits in trunk/JavaScriptCore

Add optimize call and property access support for ARM JIT.
https://bugs.webkit.org/show_bug.cgi?id=24986

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-12
Reviewed by Gavin Barraclough.

For tightly coupled sequences the BEGIN_UNINTERRUPTED_SEQUENCE and
END_UNINTERRUPTED_SEQUENCE macros have been introduced which ensure
space for instructions and constants of the named sequence. This
method is vital for those architecture which are using constant pool.

The 'latePatch' method - which was linked to JmpSrc - is replaced with
a port specific solution (each calls are marked to place their address
on the constant pool).

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::linkBranch):
(JSC::ARMAssembler::executableCopy): Add extra align for constant pool.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::JmpSrc::JmpSrc):
(JSC::ARMAssembler::sizeOfConstantPool):
(JSC::ARMAssembler::jmp):
(JSC::ARMAssembler::linkCall):

  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h:
  • assembler/AssemblerBufferWithConstantPool.h:

(JSC::AssemblerBufferWithConstantPool::flushIfNoSpaceFor): Fix the
computation of the remaining space.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::nearCall):
(JSC::MacroAssemblerARM::call):
(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::ensureSpace):
(JSC::MacroAssemblerARM::sizeOfConstantPool):
(JSC::MacroAssemblerARM::prepareCall):

  • assembler/X86Assembler.h:
  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITInlineMethods.h:

(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::endUninterruptedSequence):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):

22:58 Changeset [47185] by eric@webkit.org
  • 13 edits
    1 copy in trunk/WebCore

2009-08-12 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Show Hidden Cookie Data
https://bugs.webkit.org/show_bug.cgi?id=28185

Added new file Cookie.h to the WebCore XCode

  • WebCore.xcodeproj/project.pbxproj:

InspectorController.cookies() binding

  • bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::cookies):
  • inspector/InspectorBackend.idl:

Struct for static Cookie information
(name, value, path, domain, expires, httpOnly, secure, session)

  • platform/Cookie.h: Added. (WebCore::Cookie::Cookie):

Getter for the a list of raw Cookies
getRawCookies(., ., out Vector<Cookie>)

  • platform/CookieJar.h:

Implementation of getRawCookies for the mac platform.

  • platform/mac/CookieJar.mm: (WebCore::getRawCookies):

Stub other CookieJar implementations to satisfy the interface.

  • platform/haiku/CookieJarHaiku.cpp: (WebCore::getRawCookies):
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::getRawCookies):
  • platform/network/curl/CookieJarCurl.cpp: (WebCore::getRawCookies):
  • platform/network/soup/CookieJarSoup.cpp: (WebCore::getRawCookies):
  • platform/network/win/CookieJarCFNetWin.cpp: (WebCore::getRawCookies):
  • platform/network/win/CookieJarWin.cpp: (WebCore::getRawCookies):
  • platform/qt/CookieJarQt.cpp: (WebCore::getRawCookies):
22:26 Changeset [47184] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Rubber Stamped by Dave Kilzer.

Disable WTF_USE_JSVALUE32_64 on iPhone for now (support not yet added for ARMv7).

  • wtf/Platform.h:
22:21 Changeset [47183] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Ooops - moved code that had been accidentally added to op_new_func instead of
op_new_func_exp, to where it shoulds be.

Reviewed by Maciej Stachoviak.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • wtf/Platform.h:
22:00 Changeset [47182] by abarth@webkit.org
  • 2 edits in trunk/WebKitSite

2009-08-12 Joe Mason <joe.mason@torchmobile.com>

Reviewed by Adam Barth.

Better explanation of "Null after navigation" in object diagram
https://bugs.webkit.org/show_bug.cgi?id=28232

  • coding/major-objects.html:
21:51 Changeset [47181] by abarth@webkit.org
  • 5 edits
    3 adds in trunk/WebCore

2009-08-08 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Cookies in Storage Panel
https://bugs.webkit.org/show_bug.cgi?id=27202

Data Structure for a Cookie. Just Key/Value for Now:

A Storage View for Cookies. Allows for Refresh/Delete:

  • inspector/front-end/CookieItemsView.js: Added. (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.get statusBarItems): refresh and delete buttons (WebInspector.CookieItemsView.prototype.show): (WebInspector.CookieItemsView.prototype.hide): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype.buildCookies): parses the inspected window's document.cookie string (WebInspector.CookieItemsView.prototype.dataGridForCookies): creates a datagrid for cookies (WebInspector.CookieItemsView.prototype._deleteButtonClicked): attempt at deleting the cookie (not flawless) (WebInspector.CookieItemsView.prototype._refreshButtonClicked): rebuild the datagrid

Include a SidebarSection Section in the Databases Panel:

  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel): (WebInspector.DatabasesPanel.prototype.show): calls populateInterface (WebInspector.DatabasesPanel.prototype.populateInterface): adds cookies if they don't exist (WebInspector.DatabasesPanel.prototype.reset): remove cookie specific parts (WebInspector.DatabasesPanel.prototype.addCookies): add cookies sidebar tree element (WebInspector.DatabasesPanel.prototype.showCookies): sets the visible view to a CookiesItemView (WebInspector.CookieSidebarTreeElement): (WebInspector.CookieSidebarTreeElement.prototype.onselect): (WebInspector.CookieSidebarTreeElement.prototype.get mainTitle): just "Cookies" at the moment (WebInspector.CookieSidebarTreeElement.prototype.set mainTitle): (WebInspector.CookieSidebarTreeElement.prototype.get subtitle): no subtitle yet (WebInspector.CookieSidebarTreeElement.prototype.set subtitle):

New "Cookies" Image for the Sidebar:

  • inspector/front-end/Images/cookie.png: Added.
  • inspector/front-end/inspector.css:

Include the Added Files where appropriate:

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
21:46 Changeset [47180] by staikos@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 George Wright <george.wright@torchmobile.com>

Reviewed by George Staikos.

Add SQLTransactionCoordinator.[h,cpp] to WebCore.pro.

https://bugs.webkit.org/show_bug.cgi?id=28246

  • WebCore.pro:
21:38 Changeset [47179] by staikos@webkit.org
  • 2 edits in trunk

Fix double-fail of bug url. Not reviewed.

19:55 Changeset [47178] by staikos@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-12 George Staikos <george.staikos@torchmobile.com>

Reviewed by Adam Treat.

Enable WCSS and XHTML-MP flags for build-webkit.

  • Scripts/build-webkit:
19:48 Changeset [47177] by staikos@webkit.org
  • 3 edits in trunk/WebCore

2009-08-12 George Staikos <george.staikos@torchmobile.com>

Reviewed by Adam Treat.

Mark unused variables to avoid compile failures in -Werror.

19:47 Changeset [47176] by staikos@webkit.org
  • 9 edits
    2 adds in trunk/WebCore

2009-08-12 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by Niko Zimmermann.

This is to add WCSS marquee support , which is defined by OMA and is an extension for CSS2,
It extends CSS display with "display:-wap-marquee;-wap-marquee-dir:xxx;-wap-marquee-speed:xxx;-wap-marquee-style:xxx"
Minor fixes by Eric Seidel and George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=23727

No new tests, the tests have already been landed at LayoutTests/fast/wcss/

19:18 Changeset [47175] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

run-webkit-tests: document --nthly flag in help message

Reviewed by Simon Fraser.

  • Scripts/run-webkit-tests: Added --nthly flag to $usage string.
Also noted that -1singly implies --nthly 1.
18:37 Changeset [47174] by dimich@chromium.org
  • 1 edit
    1 copy
    1 move in trunk/LayoutTests

2009-08-12 Alpha Lam < hclam@chromium.org>

Not reviewed, Windows test fix after http://trac.webkit.org/changeset/47171.
This splits the expected result file into mac and Windows
versions since the result is different on Windows.

  • platform/mac/media/controls-drag-timebar-expected.txt: Renamed from LayoutTests/media/controls-drag-timebar-expected.txt.
  • platform/win/media/controls-drag-timebar-expected.txt: Added.
18:31 Changeset [47173] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-08-12 Eric Seidel <eric@webkit.org>

No review, just adding missing results.

<canvas> without CSS width/height is unaffected by full page zoom
https://bugs.webkit.org/show_bug.cgi?id=26908

Adding missing test results. Unsure why run-webkit-tests didn't fail.

  • fast/canvas/canvas-zoom-expected.checksum: Added.
  • fast/canvas/canvas-zoom-expected.png: Added.
  • fast/canvas/canvas-zoom-expected.txt: Added.
18:07 Changeset [47172] by eric@webkit.org
  • 4 edits
    1 add in trunk

2009-08-12 George Wright <george.wright@torchmobile.com>

Reviewed by David Hyatt.

Test the four cases of width and height being declared or not for a
canvas element with CSS zooming enabled.

https://bugs.webkit.org/show_bug.cgi?id=26908

  • fast/canvas/canvas-zoom.html: Added.

2009-08-12 George Wright <george.wright@torchmobile.com>

Reviewed by David Hyatt.

Update the canvas renderer's intrinsic size with the zoomed
lengths and ensure the intrinsic size is correct when setting
an initial style.

https://bugs.webkit.org/show_bug.cgi?id=26908

Test: fast/canvas/canvas-zoom.html

  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::canvasSizeChanged):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::styleDidChange):
18:00 Changeset [47171] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-08-12 Alpha Lam <hclam@chromium.org>

Reviewed by Simon Fraser.

Fix regression for dragging the media controller thumb.
https://bugs.webkit.org/show_bug.cgi?id=28211

Add a layout test to make sure dragging the timebar thumb of media
controls causes seeks.

  • media/controls-drag-timebar-expected.txt: Added.
  • media/controls-drag-timebar.html: Added.

2009-08-12 Alpha Lam <hclam@chromium.org>

Reviewed by Simon Fraser.

Fix regression for dragging the media controller thumb.
https://bugs.webkit.org/show_bug.cgi?id=28211

Modified the conditions for rejecting events on the media controller
to only rejecting mouse events not from the left button.

Test: media/controls-drag-timebar.html

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler):
17:52 Changeset [47170] by eric@webkit.org
  • 12 edits
    4 adds in trunk

2009-08-12 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Eric Seidel.

Regression test. Tests that two transactions that run on two
different handles for the same DB do not cause a deadlock.

https://bugs.webkit.org/show_bug?id=27966

  • storage/multiple-transactions-on-different-handles-expected.txt: Added.
  • storage/multiple-transactions-on-different-handles.html: Added.

2009-08-12 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Eric Seidel.

Fixing a deadlock caused by two transactions that run on two
different database handles for the same DB. Adding a per-DB thread
transaction coordinator that allows the DB thread to run only one
transaction per DB file at any given time.

Adding a regression test for this bug.

Test: storage/multiple-transactions-on-different-handles.html

https://bugs.webkit.org/show_bug.cgi?id=27996

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/Database.cpp: (WebCore::Database::transactionCoordinator):
  • storage/Database.h:
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread):
  • storage/DatabaseThread.h: (WebCore::DatabaseThread::transactionCoordinator):
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::debugStepName): (WebCore::SQLTransaction::performNextStep): (WebCore::SQLTransaction::aquireLock): (WebCore::SQLTransaction::lockAquired): (WebCore::SQLTransaction::cleanupAfterSuccessCallback): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
  • storage/SQLTransaction.h:
  • storage/SQLTransactionCoordinator.cpp: Added.
  • storage/SQLTransactionCoordinator.h: Added.
17:40 Changeset [47169] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2009-08-12 Eric Seidel <eric@webkit.org>

No review, finishing previous commit.

Add Geolocation layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27716

Add changes missed in http://trac.webkit.org/changeset/47168

  • platform/qt/Skipped:
  • platform/win/Skipped:
17:23 Changeset [47168] by eric@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

2009-08-12 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

Bug 27716: Add Geolocation layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27716

Adds the first, basic Geolocation layout test. This simply tests that
navigator.geolocation is present when it should be.

  • fast/dom/Geolocation: Added. Directory for Geolocation layout tests.
  • fast/dom/Geolocation/enabled.html: Added. HTML wrapper for enabled.js test.
  • fast/dom/Geolocation/resources: Added. Directory for Geolocation layout tests JS source.
  • fast/dom/Geolocation/resources/enabled.js: Added. Tests that navigator.geolocation is present.
  • fast/dom/Geolocation/resources/TEMPLATE.html: Added. Template for creating HTML wrapper files for JS tests with make-js-test-wrappers.
  • fast/dom/Geolocation/enabled-expected.txt: Added. Expected result for above test.
  • platform/mac/Skipped: Modified. Skip Geolocation tests.
  • platform/qt/Skipped: Modified. Skip Geolocation tests.
  • platform/win/Skipped: Modified. Skip Geolocation tests.
17:07 Changeset [47167] by eric@webkit.org
  • 1 edit in trunk/WebKitTools/ChangeLog

2009-08-12 Eric Seidel <eric@webkit.org>

No review, just fixing mismerged ChangeLogs.

17:03 Changeset [47166] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-08-11 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

bugzilla-tool : various improvements for running the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=28199

Make run_and_throw_if_fail silence STDERR as well as STDIN.
I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the output (per abarth's suggestion).
Change a few "print" statements to "log" so they appear in the output.
Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non-string objects).
Added a little more logging so that --quiet mode is easier to understand.
Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
Made curl call (downloading patch files) quieter.

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
  • Scripts/modules/scm.py:

<<<<<<< HEAD:WebKitTools/ChangeLog

16:40 Changeset [47165] by darin@apple.com
  • 24 edits
    2 adds in trunk

WebCore: Custom properties on DOM objects are lost after GC (as demonstrated by the gc-9.html test)
https://bugs.webkit.org/show_bug.cgi?id=28194

Patch by Darin Adler <darin@apple.com> on 2009-08-12
Reviewed by Geoff Garen.

  • GNUmakefile.am: Added the two new source files.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • bindings/js/JSCSSRuleListCustom.cpp: Added.

(WebCore::JSCSSRuleList::markChildren): Call markDOMObjectWrapper
on rules in the list.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::markChildren): Added. Call
markDOMObjectWrapper on the CSSValue objects that are owned by the
declaration as values of the properties.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::isObservableThroughDOM): Added code to handle some
cases where nodes are observable because they own objects that
in turn have custom properties.

  • bindings/js/JSDOMBinding.h: Fix a typo in the header.
  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::markChildren): Added call to markDOMObjectWrapper
for implementation and styleSheets.

  • bindings/js/JSElementCustom.cpp:

(WebCore::JSElement::markChildren): Added. Calls markDOMObjectWrapper
for attributes and style.

  • bindings/js/JSHTMLCanvasElementCustom.cpp: Added.

(WebCore::JSHTMLCanvasElement::markChildren): Call markDOMObjectWrapper
on the rendering context.

  • bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::markChildren): Call markDOMObjectWrapper on
items in the stylesheet.

  • bindings/js/JSStyleSheetListCustom.cpp:

(WebCore::JSStyleSheetList::markChildren): Added. Calls
markDOMObjectWrapper on stylesheets in the list.

  • css/CSSRuleList.idl: Added CustomMarkFunction.
  • css/CSSStyleDeclaration.idl: Ditto.
  • css/StyleSheetList.idl: Ditto.
  • dom/Element.idl: Ditto.
  • html/HTMLCanvasElement.idl: Ditto.
  • dom/Element.h: Made everything private that could be.

Added access to the attributeMap that does returns
the existing map without doing any of the lazy-updating work. This
is needed to get at the existing attributes during garbage collection
without having side effects.

  • html/HTMLCanvasElement.h: Cleaned up the header a bit, making

members private. Added renderingContext2D function for use in
JSHTMLCanvasElement::markChildren.

LayoutTests: Custom properties on DOM objects are lost after GC (as demonstrated by the gc-9.html test)
https://bugs.webkit.org/show_bug.cgi?id=28194

Patch by Darin Adler <darin@apple.com> on 2009-08-12
Reviewed by Geoff Garen.

  • fast/dom/gc-9-expected.txt: Regenerated.
  • fast/dom/gc-9.html: Updated to expect correct behavior instead of failures.
16:35 Changeset [47164] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/WebView.cpp

Build fix for Windows Debug.

16:24 Changeset [47163] by bweinstein@apple.com
  • 6 edits
    2 adds in trunk

2009-08-12 Brian Weinstein <bweinstein@apple.com>

Reviewed by Eric Seidel.

Fixes two bugs about Pan Scrolling - Scrolling with middle mouse button doesn't
work in Expanded view on reader.google.com, and Can enter auto scroll from a non-scrollable area.
https://bugs.webkit.org/show_bug.cgi?id=28023
https://bugs.webkit.org/show_bug.cgi?id=24794

Added a new method to RenderBox seeing if the Box can be scrolled and actually has something to
scroll, and use that for pan scrolling.

Test: platform/win/fast/events/panScroll-nested-divs.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::updateAutoscrollRenderer): (WebCore::EventHandler::handleMousePressEvent):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::canBeScrolledAndHasScrollableArea):
  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively):

2009-08-12 Brian Weinstein <bweinstein@apple.com>

Reviewed by Eric Seidel.

Added a Windows test for https://bugs.webkit.org/show_bug.cgi?id=28023.

  • platform/win/fast/events/panScroll-nested-divs-expected.txt: Added.
  • platform/win/fast/events/panScroll-nested-divs.html: Added.
16:19 Changeset [47162] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/6017913> Replace use of HISearchWindowShow in -[WebView _searchWithSpotlightFromMenu].

Reviewed by Kevin Decker.

  • WebView/WebView.mm:

(-[WebView _searchWithSpotlightFromMenu:]): Use -[NSWorkspace showSearchResultsForQueryString:] post-Leopard.

16:12 Changeset [47161] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/ChangeLog

Fix missing "by" in ChangeLog.

16:10 Changeset [47160] by bweinstein@apple.com
  • 5 edits in trunk

2009-08-12 Brian Weinstein <bweinstein@apple.com>

Reviewed Adam Roben.

Fix of <rdar://6728361> Mouse wheel scrolling on a page with expanded drop down
list detaches drop down.

Added a check in mouseWheel to see if our focus is currently in a popup, if so, close
the popup (matches other browser behavior).

  • WebView.cpp: (WebView::mouseWheel):

2009-08-12 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

Fix of <rdar://6728361> Mouse wheel scrolling on a page with expanded drop down
list detaches drop down.

Added a function for Windows PopupMenu's to return their class name.

  • platform/PopupMenu.h:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::popupClassName):
16:07 Changeset [47159] by adachan@apple.com
  • 3 edits in trunk/JavaScriptCore

Added workaround for the limitation that VirtualFree with MEM_RELEASE
can only accept the base address returned by VirtualAlloc when the region
was reserved and it can only free the entire region, and not a part of it.

Reviewed by Oliver Hunt.

  • runtime/MarkStack.h: (JSC::MarkStack::MarkStackArray::shrinkAllocation):
  • runtime/MarkStackWin.cpp: (JSC::MarkStack::releaseStack):
16:03 Changeset [47158] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-08-12 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dan Bernstein.

WINCE PORT: Color and Gradient
https://bugs.webkit.org/show_bug.cgi?id=27511

  • platform/graphics/wince/ColorWince.cpp: Added.
  • platform/graphics/wince/GradientWince.cpp: Added.
15:55 Changeset [47157] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dan Bernstein.

fix a typo in platform/graphics/skia/PlatformContextSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=28172

No new tests because it's a just typo fix.

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintCommon):
15:49 Changeset [47156] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-08-12 George Wright <george.wright@torchmobile.com>

Reviewed by Adam Treat.

Initialise zoom levels independent of whether a URL is valid or not to
fix https://bugs.webkit.org/show_bug.cgi?id=28162

  • QtLauncher/main.cpp: (MainWindow::MainWindow):
15:21 Changeset [47155] by pkasting@chromium.org
  • 10 edits
    8 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=27458
Support for the :default CSS pseudoclass, as per HTML5 spec.
http://www.whatwg.org/specs/web-apps/current-work/multipage/interactive-elements.html#selector-default

Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-12
Reviewed by Darin Adler.

Tests: fast/css/pseudo-default-001.html

fast/css/pseudo-default-002.html
fast/css/pseudo-default-003.html
fast/css/pseudo-default-004.html

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::extractPseudoType): pseudoDefault

  • css/CSSSelector.h:

(WebCore::CSSSelector::):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement): sharing stuff is
aware that only one default button can be present in a form
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): applies
the :default CSS pseudoclass

  • dom/Element.h:

(WebCore::Element::isDefaultButtonForForm): new method to determine
whether a FormControl is a default button for a given form

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isDefaultButtonForForm): ditto

  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::defaultButton): extracts the default button
from the form

  • html/HTMLFormElement.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=27458
Test suite for the :default CSS pseudoclass.

Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-12
Reviewed by Darin Adler.

  • fast/css/pseudo-default-001-expected.txt: Added.
  • fast/css/pseudo-default-001.html: Added.
  • fast/css/pseudo-default-002-expected.txt: Added.
  • fast/css/pseudo-default-002.html: Added.
  • fast/css/pseudo-default-003-expected.txt: Added.
  • fast/css/pseudo-default-003.html: Added.
  • fast/css/pseudo-default-004-expected.txt: Added.
  • fast/css/pseudo-default-004.html: Added.
15:15 Changeset [47154] by pkasting@chromium.org
  • 7 edits in trunk

WebKitLibraries: https://bugs.webkit.org/show_bug.cgi?id=27323
Change pattern that strips all trailing whitespace to just remove EOL
chars (\r, \n), to make it clear that varying EOL chars is the primary
problem being solved.

Reviewed by Darin Adler.

  • win/tools/scripts/auto-version.sh:

WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=27323
Change pattern that strips all trailing whitespace to just remove EOL
chars (\r, \n), to make it clear that varying EOL chars is the primary
problem being solved.

Reviewed by Darin Adler.

  • Scripts/prepare-ChangeLog:
  • Scripts/resolve-ChangeLogs:
  • Scripts/svn-create-patch:
  • Scripts/update-webkit:
15:10 Changeset [47153] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-08-12 David Levin <levin@chromium.org>

No review, rolling out r47106.
https://bugs.webkit.org/show_bug.cgi?id=28215

This patch relied on a new version of v8 which is not available
in chromium yet.

  • bindings/v8/V8Binding.cpp: (WebCore::v8StringToAtomicWebCoreString):
15:08 Changeset [47152] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-08-12 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

Bug 26993 : Geolocation::requestPermission()
https://bugs.webkit.org/show_bug.cgi?id=26993

Second patch to allow the Geolocation permission request to chrome to be asynchronous
or synchronous. Fixes a bug where callbacks were called twice when permissions
are granted synchronously.

No new tests required.

  • page/Geolocation.cpp: (WebCore::Geolocation::setIsAllowed): Modified. Calls makeSuccessCallbacks() rather than geolocationServicePositionChanged(). (WebCore::Geolocation::geolocationServicePositionChanged): Modified. Updated logic to avoid repeated callbacks when permissions are granted synchronously. (WebCore::Geolocation::makeSuccessCallbacks): Added. Calls success callbacks.
  • page/Geolocation.h: Modified. Adds makeSuccessCallbacks().
15:03 Changeset [47151] by andersca@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6952336>
CrashTracer: [USER] 3 crashes in Safari at com.apple.WebCore • WebCore::SecurityOrigin::canAccess const + 27

Reviewed by Sam Weinig.

Make sure to set the security origin before calling dispatchWindowObjectAvailable.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::begin):

14:49 Changeset [47150] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2009-08-12 Xiaomei Ji <xji@chromium.org>

Reviewed by Eric Seidel.

Fix [Chromium] drop down menu letter selection, skip selections
https://bugs.webkit.org/show_bug.cgi?id=28205

Not auto-testable since it is chromim platform specific code, and it involves sending a keyboard
event to the popup, which is not possible (eventSender sends the key
events through webview, we want to go through the webwidget).

  • manual-tests/keyboard_select_elements_with_same_beginning.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::isCharacterTypeEvent): style change. (WebCore::PopupListBox::handleKeyEvent): typeAheadFind should be called only when the event is a character type event to avoid calling twice for English. (WebCore::PopupListBox::typeAheadFind): remove unnecessary checking of isCharacterTypeEvent() since the whole function is only called under that condition.
14:22 Changeset [47149] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed build fix.

Last-minute change on the new soup API to use the keyring was not
reflected in our usage - the documentation says we should use
g_slist_free, and soup_auth_free_saved_users doesn't exist.

  • webkit/webkitsoupauthdialog.c: (session_authenticate):
14:08 Changeset [47148] by aroben@apple.com
  • 3 edits in trunk/WebKit/win

Make WebPreferenceKeysPrivate.h available for client use

Reviewed by Dave Hyatt.

Fixes <http://webkit.org/b/28227>.

  • WebKit.vcproj/WebKit.vcproj: Copy WebPreferenceKeysPrivate.h to

$WebKitOutputDir, just like we do for a few other headers. Also let VS
reorder some XML attributes.

  • WebPreferenceKeysPrivate.h: Touched this file to force a build.
14:02 Changeset [47147] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2009-08-12 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Adding GraphicsContext to WebCore/platform/graphics/haiku.
https://bugs.webkit.org/show_bug.cgi?id=28130

  • platform/graphics/haiku/GraphicsContextHaiku.cpp: Added. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::platformContext): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::setPlatformShouldAntialias): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::setURLForRect): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::getHaikuStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::clearPlatformShadow): (WebCore::GraphicsContext::setPlatformShadow):
13:55 Changeset [47146] by eric@webkit.org
  • 15 edits in trunk/WebCore

2009-08-12 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Modifying WebCore/platform/graphics files to allow Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=28128

  • platform/graphics/BitmapImage.h: Adding getBBitmap() function.
  • platform/graphics/Color.h: rgb_color is the Color struct in Haiku.
  • platform/graphics/FloatPoint.h: BPoint is the Point class in Haiku.
  • platform/graphics/FloatRect.h: BRect is the Rect class in Haiku.
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h: BView is the PlatformGraphicsContext class for Haiku. Adding getHaikuStrokeStyle() function.
  • platform/graphics/Icon.h: Adding an empty Icon() constructor because this class isn't implemented for the moment.
  • platform/graphics/ImageSource.h: BBitmap is the native bitmap class for Haiku.
  • platform/graphics/IntPoint.h: BPoint is the Point class in Haiku.
  • platform/graphics/IntRect.h: BRect is the Rect class in Haiku.
  • platform/graphics/IntSize.h: BSize is the Size class in Haiku.
  • platform/graphics/Path.h: BRegion is the Path class in Haiku.
  • platform/graphics/Pattern.h: Adding the GraphicsDef.h header and the native pattern type.
  • platform/graphics/SimpleFontData.h: Adding Haiku's Font.h header.
13:44 Changeset [47145] by eric@webkit.org
  • 11 edits in trunk/WebCore

2009-08-12 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Adding modification to the WebCore/platform/ files to allow
the Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=28128

  • platform/ContextMenuItem.h: BMenu is the PlatformMenuItemDescription class of Haiku.
  • platform/Cursor.h: BCursor is the Cursor class of Haiku.
  • platform/DragData.h: Use a BMessage as DragDataRef.
  • platform/DragImage.h: Use a BBitmap as DragImageRef.
  • platform/PlatformKeyboardEvent.h: Use BMessage as event vehicle.
  • platform/PlatformMenuDescription.h: BMenu is the PlatformMenuDescription class of Haiku.
  • platform/PlatformMouseEvent.h: Use BMessage as event vehicle.
  • platform/PlatformWheelEvent.h: Use BMessage as event vehicle.
  • platform/PopupMenu.h: Adding a m_menu attribute for Haiku.
  • platform/Widget.h: BView is the PlatformWidget class of Haiku.
13:35 Changeset [47144] by eric@webkit.org
  • 9 edits in trunk/WebCore

2009-08-12 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Tiny modifications on WebCore files to allow Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=28128

  • bindings/js/ScriptControllerHaiku.cpp: Style cleanup.
  • loader/CachedFont.cpp: Haiku behaves like Qt, Gtk, or Chromium, so many PLATFORM(HAIKU) were added to these functions. (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allClientsRemoved):
  • page/EventHandler.cpp: Like the mac and Qt port, Haiku doesn't need the invertSenseOfTabsToLinks() function.
  • page/haiku/DragControllerHaiku.cpp: Style cleanup.
  • platform/image-decoders/ImageDecoder.h: For image decoding Haiku behaves like Cairo or Wx, (not like Skia). (WebCore::RGBA32Buffer::getAddr):
  • platform/text/PlatformString.h: Adding the String(BString&) and BString() methods specific to Haiku.
  • platform/text/UnicodeRange.h: Haiku needs to include stdint.h.
  • platform/text/haiku/TextBreakIteratorInternalICUHaiku.cpp: (WebCore::currentSearchLocaleID): Missing function.
13:23 Changeset [47143] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-08-12 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Adding the ScrollbarTheme files.
https://bugs.webkit.org/show_bug.cgi?id=28125

  • platform/haiku/ScrollbarThemeHaiku.cpp: Added. (buttonWidth): (WebCore::ScrollbarTheme::nativeTheme): (WebCore::ScrollbarThemeHaiku::ScrollbarThemeHaiku): (WebCore::ScrollbarThemeHaiku::~ScrollbarThemeHaiku): (WebCore::ScrollbarThemeHaiku::scrollbarThickness): (WebCore::ScrollbarThemeHaiku::hasButtons): (WebCore::ScrollbarThemeHaiku::hasThumb): (WebCore::ScrollbarThemeHaiku::backButtonRect): (WebCore::ScrollbarThemeHaiku::forwardButtonRect): (WebCore::ScrollbarThemeHaiku::trackRect): (WebCore::ScrollbarThemeHaiku::paintScrollbarBackground): (WebCore::ScrollbarThemeHaiku::paintButton): (WebCore::ScrollbarThemeHaiku::paintThumb):
  • platform/haiku/ScrollbarThemeHaiku.h: Added.
13:16 Changeset [47142] by eric@webkit.org
  • 1 edit
    9 adds in trunk/WebCore

2009-08-12 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Adding eight simple files to WebCore/platform/graphics/haiku.
https://bugs.webkit.org/show_bug.cgi?id=28122

  • platform/graphics/haiku/ColorHaiku.cpp: Added. (WebCore::Color::Color): (WebCore::Color::operator rgb_color): (WebCore::focusRingColor):
  • platform/graphics/haiku/FloatPointHaiku.cpp: Added. (WebCore::FloatPoint::FloatPoint): (WebCore::FloatPoint::operator BPoint):
  • platform/graphics/haiku/FloatRectHaiku.cpp: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator BRect):
  • platform/graphics/haiku/GradientHaiku.cpp: Added. (WebCore::Gradient::platformDestroy): (WebCore::Gradient::platformGradient): (WebCore::Gradient::fill):
  • platform/graphics/haiku/IntPointHaiku.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator BPoint):
  • platform/graphics/haiku/IntRectHaiku.cpp: Added. (WebCore::IntRect::IntRect): (WebCore::IntRect::operator BRect):
  • platform/graphics/haiku/IntSizeHaiku.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator BSize):
  • platform/graphics/haiku/PathHaiku.cpp: Added. (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::hasCurrentPoint): (WebCore::Path::contains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::clear): (WebCore::Path::isEmpty): (WebCore::Path::debugString): (WebCore::Path::apply): (WebCore::Path::transform): (WebCore::Path::strokeBoundingRect):
13:03 Changeset [47141] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-08-12 Eric Seidel <eric@webkit.org>

No review, just fixing line-endings.

Change from DOS to unix line endings on tests from
http://trac.webkit.org/changeset/47130

  • fast/events/set-event-in-another-frame-expected.txt:
  • fast/events/set-event-to-null-expected.txt:
12:51 Changeset [47140] by andersca@apple.com
  • 41 edits
    6 deletes in trunk

As per Eric Carlson's request, revert r47110 (and the follow-up fixes r47113 and r47117) since it causes ~3000 Qt tests to fail.

12:45 Changeset [47139] by treat@webkit.org
  • 1 edit
    1 add in trunk/WebCore

WINCE PORT: Implement Keygen for WINCE
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Lyon Chen <lyon.chen@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.

  • platform/wince/KeygenWince.cpp: Added.
12:41 Changeset [47138] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Rubber-stamped by Kevin Ollivier.

Handle crash in wx due to null value passed to strlen in
the CString constructor.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::certificatePath): Check for null return from getenv
and use default CString constructor instead.

12:41 Changeset [47137] by treat@webkit.org
  • 1 edit
    4 adds in trunk/WebCore

WINCE PORT: simple stubs to make it build for WINCE
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by Eric Seidel.

  • platform/wince/DragDataWince.cpp: Added.
  • platform/wince/DragImageWince.cpp: Added.
  • platform/wince/EditorWince.cpp: Added.
  • platform/wince/KURLWince.cpp: Added.
12:38 Changeset [47136] by treat@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

WINCEPORT: FileSystem and FileChooser
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.

  • platform/wince/FileChooserWince.cpp: Added.
  • platform/wince/FileSystemWince.cpp: Added.
12:35 Changeset [47135] by treat@webkit.org
  • 1 edit
    1 add in trunk/WebCore

WINCE PORT: implement Cursor for WINCE. There's no real cursor on most
WinMob devices. We pass the cursor info to application, which so that
can determine what to do.
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by Eric Seidel.

  • platform/wince/CursorWince.cpp: Added.
12:32 Changeset [47134] by treat@webkit.org
  • 1 edit
    1 add in trunk/WebCore

WINCE PORT: MIMETypeRegistry
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.

  • platform/wince/MIMETypeRegistryWince.cpp: Added.
12:28 Changeset [47133] by treat@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

WINCE PORT: Pasteboard and SearchPopupMenu
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Joe Mason <joe.mason@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.

  • platform/wince/PasteboardWince.cpp: Added.
  • platform/wince/SearchPopupMenuWince.cpp: Added.
12:24 Changeset [47132] by treat@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

WINCE PORT: Add SharedTimerWince.cpp and SystemTimeWince.cpp
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.

  • platform/wince/SharedTimerWince.cpp: Added.
  • platform/wince/SystemTimeWince.cpp: Added.
12:18 CreatingLayoutTests edited by mike.fenton@torchmobile.com
Add link to writing a good test case. (diff)
12:11 CreatingLayoutTests edited by mike.fenton@torchmobile.com
Re-Organization and update. (diff)
12:05 Changeset [47131] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 Mark Mentovai <mark@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=28204
Allow C++ exceptions to be disabled in WebCore's V8 Mac build.

  • WebCorePrefix.h: Only undefine |try| and |catch| when building Objective-C[++], leaving the C++ library definitions intact for C++.
11:43 Changeset [47130] by japhet@chromium.org
  • 6 edits
    4 adds in trunk

2009-08-12 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Add a Custom Setter for DOMWindowEvent in the V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=27719

Tests: fast/events/set-event-in-another-frame.html

fast/events/set-event-to-null.html

11:37 Changeset [47129] by xan@webkit.org
  • 5 edits in trunk

2009-08-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Remove keyring optional features
https://bugs.webkit.org/show_bug.cgi?id=28173

Remove keyring support, we now do authentication storage through
libsoup. We depend on libsoup master now, will bump the dependency
when there's a new release.

  • GNUmakefile.am:
  • configure.ac:

WebKit/gtk:

2009-08-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Remove keyring optional features
https://bugs.webkit.org/show_bug.cgi?id=28173

Remove keyring support from our code and rely on libsoup to store
the authentication data if the user requests that support in their
application/library.

  • webkit/webkitsoupauthdialog.c: (response_callback): (show_auth_dialog): (session_authenticate):
11:33 Changeset [47128] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-12 Eric Seidel <eric@webkit.org>

No review, just skipping tests to make the bots green.

REGRESSION (r47110): 4 media regressions on the bots
https://bugs.webkit.org/show_bug.cgi?id=28221

Skipping these until Eric Carlson has a fix.

  • platform/mac/Skipped:
11:27 Changeset [47127] by pkasting@chromium.org
  • 4 edits
    1 delete in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=27965
Merge wx/ImageSourceWx.cpp into ImageSource.cpp. No changes to
ImageSource.cpp were needed, so this just deletes ImageSourceWx.cpp.

Reviewed by Adam Treat.

  • WebCore.gypi:
  • WebCoreSources.bkl:
  • platform/graphics/wx/ImageSourceWx.cpp: Removed.
  • webcore-wx.bkl:
11:23 Changeset [47126] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=27933
Build fix after r47099.

Reviewed by Dave Levin.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

11:18 Changeset [47125] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx waf build fix, add new directories to the build.

11:11 Changeset [47124] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wxPython build fix, the SWIG defines must also be available when compiling.

10:56 Changeset [47123] by cfleizach@apple.com
  • 3 edits in trunk/LayoutTests

Bug 28219: platform/mac/accessibility/string-range-contains-listmarker.html fails on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=28219

Reviewed by Eric Seidel.

  • platform/mac-snowleopard/Skipped:
  • platform/mac/accessibility/string-range-contains-listmarker.html:
10:23 Changeset [47122] by aroben@apple.com
  • 7 edits in trunk

Remove support for a window resizer within the WebView

WebKit/win:

Starting with Safari 4, there is never a window resizer inside the
WebView, so we no longer need to support that functionality.

Fixes <http://webkit.org/b/28190> Remove support for a window resizer
within the WebView

Reviewed by Dave Hyatt.

  • Interfaces/IWebUIDelegatePrivate.idl: Replaced the delegate

functions related to the window resizer with unused*() functions. We
can't remove them entirely because we need to keep the vtable
unchanged so new versions of WebKit will work with old versions of
Safari (e.g., for nightlies and WebKit development).

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::windowResizerRect): Now always returns an empty
rect.

  • WebView.cpp:

(WebView::paint):
(WebView::handleMouseEvent):

  • WebView.h:

Removed window-resizer-related code.

WebKitTools:

Update DumpRenderTree for IWebUIDelegatePrivate changes

Reviewed by Dave Hyatt.

  • DumpRenderTree/win/UIDelegate.h: Updated to match

IWebUIDelegatePrivate.

10:18 Changeset [47121] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Don't try to seek to the end of stdin on Cygwin

Doing so seems to always cause an exception (for unknown reasons).

Fixes <http://webkit.org/b/28159> create-bug throws an exception in
Cygwin

Reviewed by Dave Kilzer.

  • Scripts/bugzilla-tool:

(CreateBug.prompt_for_bug_title_and_comments): Ignore IOErrors
generated by calling sys.stdin.seek, since these seem to be generated
for no good reason on Cygwin.

10:17 Changeset [47120] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Don't raise an exception when --cc is not passed to create-bug

Fixes <http://webkit.org/b/28158> create-bug throws an exception if
--cc is not specified

Reviewed by Dave Kilzer.

  • Scripts/modules/bugzilla.py:

(Bugzilla.create_bug_with_patch): Only set the "cc" field if a CC
string was specified. Otherwise we'll generate an exception about the
"cc" variable not being a string.

09:55 Changeset [47119] by bolsinga@apple.com
  • 3 edits in trunk/WebKit/mac

Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153

Reviewed by Eric Seidel.

Have ObjC delegate methods match C++ method names in the ChromeClient.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::formDidFocus):
(WebChromeClient::formDidBlur):

  • WebView/WebUIDelegatePrivate.h:
09:50 Changeset [47118] by treat@webkit.org
  • 1 edit
    4 adds in trunk/WebCore

WINCE PORT: Implement Path for WINCE. Most code can be
reused for other ports that don't have native path support
https://bugs.webkit.org/show_bug.cgi?id=28188

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-08
Reviewed by Adam Treat.

Written also by George Staikos (including quadCurve() and bezier())

  • platform/graphics/wince/PathWince.cpp: Added.
  • platform/graphics/wince/PlatformPathWince.cpp: Added.
  • platform/graphics/wince/PlatformPathWince.h: Added.
  • platform/graphics/wince/WinceGraphicsExtras.h: Added.
09:49 Changeset [47117] by eric.carlson@apple.com
  • 2 edits in trunk/WebKit/win

2009-08-12 Eric Carlson <eric.carlson@apple.com>

Windows build fix.

  • WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaTimeDescription):
09:43 Changeset [47116] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 Joseph Pecoraro <joepeck02@gmail.com>

"Double-click to add" new style button does not always show up [quick fix]
https://bugs.webkit.org/show_bug.cgi?id=28187

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
09:42 Changeset [47115] by eric@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

2009-08-12 Crystal Zhang <crystal.zhang@torchmobile.com>

Reviewed by George Staikos.

WINCE PORT: MediaPlayerProxy and MediaPlayerPrivate
https://bugs.webkit.org/show_bug.cgi?id=28178

  • platform/graphics/wince/MediaPlayerPrivateWince.h: Added.
  • platform/graphics/wince/MediaPlayerProxy.cpp: Added.
  • platform/graphics/wince/MediaPlayerProxy.h: Added.
09:41 Changeset [47114] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=28175

Call QDir::toNativeSeparators() before the path is passed to the OS.

Based on work by David Leong.

  • platform/qt/FileSystemQt.cpp: (WebCore::pathByAppendingComponent):
09:41 Changeset [47113] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-08-12 Eric Carlson <eric.carlson@apple.com>

Tiger build fix.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

Define NSAccessibilityTimelineSubrole for Tiger.

09:35 Changeset [47112] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 Dirk Schulze <krit@webkit.org>

Reviewed by Ariya Hidayat.

Minor build-fix for SVG Filter. Use getUnmultipliedImageData instead
of getImageData. This changed since r47099.

  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
09:26 Changeset [47111] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-08-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool : various improvements for running the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=28199

Make run_and_throw_if_fail silence STDERR as well as STDIN.
I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the out
Change a few "print" statements to "log" so they appear in the output.
Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non
Added a little more logging so that --quiet mode is easier to understand.
Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
Made curl call (downloading patch files) quieter.

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
  • Scripts/modules/scm.py:
09:20 Changeset [47110] by eric.carlson@apple.com
  • 41 edits
    6 adds in trunk

2009-08-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

Test: accessibility/media-element.html

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

Add AccessibilityMediaControls.cpp/.h

  • accessibility/AXObjectCache.cpp:
  • accessibility/AXObjectCache.h: (WebCore::AXObjectCache::getOrCreate):

Create AccessibilityMediaControl. Update Copyright

  • accessibility/AccessibilityMediaControls.cpp:
  • accessibility/AccessibilityMediaControls.h:

Added.

  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityObject.h:

Add isMediaTimeline. Update Copyright.

  • accessibility/AccessibilitySlider.h:

Make constructor protected instead of private so AccessibilityMediaTimeline can
call it.

  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeNames]):

Add NSAccessibilityValueDescriptionAttribute to range attributes.

(-[AccessibilityObjectWrapper subrole]):

Return NSAccessibilityTimelineSubrole for AccessibilityMediaTimeline.

  • dom/Node.h:

add isMediaControlElement.

  • page/mac/WebCoreViewFactory.h:
  • platform/LocalizedStrings.h:
  • platform/mac/LocalizedStringsMac.mm: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):

New, return localized media controller strings.

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::MediaControlElement):

Initialize m_displayType.

(WebCore::MediaControlElement::MediaControlElement):
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):

Fix style.

(WebCore::MediaControlInputElement::MediaControlInputElement):

Set m_displayType based on pseudo style ID.

(WebCore::MediaControlInputElement::MediaControlInputElement):

rename local "o" to "object".

(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):

Update for MediaControlInputElement constructor change.

(WebCore::MediaControlTimeDisplayElement::formatTime):

New, moved here from RenderMedia so AccessibilityMediaTimeDisplay can use it.

(WebCore::MediaControlTimeDisplayElement::setCurrentValue):

New, set text to current time.

  • rendering/MediaControlElements.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):

Create controls in tab order.

(WebCore::RenderMedia::formatTime):

Moved to MediaControlTimeDisplayElement::formatTime.

(WebCore::RenderMedia::updateTimeDisplay):

Call MediaControlTimeDisplayElement::setCurrentValue.

  • rendering/RenderMedia.h:

2009-08-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

Add localized strings for media controller accessiblility.

  • English.lproj/Localizable.strings:

2009-08-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory localizedMediaControlElementString:]): (-[WebViewFactory localizedMediaControlElementHelpText:]): (-[WebViewFactory localizedMediaTimeDescription:]):

New.

2009-08-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

  • WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):

New.

2009-08-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

  • accessibility/media-element.html: Added.
  • platform/mac-leopard/accessibility/media-element-expected.txt:
  • platform/mac-leopard/media/controls-strict-expected.txt:
  • platform/mac/accessibility/media-element-expected.txt:

Added.

  • platform/mac-leopard/media/controls-after-reload-expected.txt:
  • platform/mac-leopard/media/controls-styling-expected.txt:
  • platform/mac-leopard/media/video-empty-source-expected.txt:
  • platform/mac-leopard/media/video-zoom-controls-expected.txt:
  • media/video-controls-visible-audio-only.html:
  • platform/mac-leopard/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-styling-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-empty-source-expected.txt:
  • platform/mac/media/video-zoom-controls-expected.txt:

Update for controller element tab order change.

09:17 Changeset [47109] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-11 Eric Seidel <eric@webkit.org>

No review, script regression fix only.

run-webkit-tests --quiet hangs
https://bugs.webkit.org/show_bug.cgi?id=28202

Do a huge dance to get open3 to pipe to /dev/null w/o blocking.
This was what I came up with after discussions in #perl.

  • Scripts/run-webkit-tests:
09:00 Changeset [47108] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-08-12 Viet-Trung Luu <viettrungluu@gmail.com>

Reviewed by Dimitri Glazkov.

Explicitly set control tints for Chromium/Mac, since the controls'
NSCell(s) lack an NSView and hence their tint isn't updated
automatically when the application is activated/deactivated.
https://bugs.webkit.org/show_bug.cgi?id=28108
http://crbug.com/18199

  • rendering/RenderThemeChromiumMac.mm: (WebCore::updateNSCellControlTint): (WebCore::RenderThemeChromiumMac::paintCheckbox): (WebCore::RenderThemeChromiumMac::paintRadio): (WebCore::RenderThemeChromiumMac::paintButton): (WebCore::RenderThemeChromiumMac::paintMenuList): (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintSearchField): (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton):
08:59 Changeset [47107] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

(no review) Disabling a failing test.

<rdar://problem/7136851> platform/mac/accessibility/string-range-contains-listmarker.html fails.

  • platform/mac-snowleopard/Skipped:
08:53 Changeset [47106] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-08-12 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>

Reviewed by Dimitri Glazkov.

[V8] Fix atomic string externalization crash.
Atomic string externalization assumes that all non-empty strings
can be externalized which is untrue on 64-bit. This change fixed
that.

https://bugs.webkit.org/show_bug.cgi?id=28215

This bug causes loads of test crashes, no need to add new tests
specifically for this.

  • bindings/v8/V8Binding.cpp: (WebCore::v8StringToAtomicWebCoreString):
07:16 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:55 Changeset [47105] by ariya@webkit.org
  • 5 edits in trunk

WebCore/ChangeLog:

2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Holger Freyther.

[Qt] Fix box-shadow painting in r47103. The edge should not be blurry.
Also optimize by not having to save and restore painter state.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::fillRect):

LayoutTests/ChangeLog:

2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Holger Hans Peter Freyther.

[Qt] Update the pixel tests for shadow edge fix.

  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
06:02 Changeset [47104] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Adam Treat.

[Qt] Fix coding style in GraphicsContextQt.cpp

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): (WebCore::toQtLineCap): (WebCore::toQtLineJoin): (WebCore::GraphicsContextPlatformPrivate::p): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness):
05:19 Changeset [47103] by ariya@webkit.org
  • 5 edits
    2 adds in trunk

WebCore/ChangeLog:

2009-08-12 Szabo Carol <carol.szabo@nokia.com>

Reviewed by Simon Hausmann and Ariya Hidayat.

https://bugs.webkit.org/show_bug.cgi?id=23291

[Qt] Partial support for -webkit-box-shadow. Blur is not support and
the shadow still does not go well with border radius.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::fillRect):

LayoutTests/ChangeLog:

2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Pixel tests for (partial) -webkit-box-shadow support.

  • platform/qt/Skipped: Include basic-shadows.
  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum: Added.
  • platform/qt/fast/box-shadow/basic-shadows-expected.png: Added.
  • platform/qt/fast/box-shadow/basic-shadows-expected.txt: Adjusted.
04:42 Changeset [47102] by ariya@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-12 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

Build fix: use std::numeric_limits<long long>::min() instead of LLONG_MIN
since LLONG_MIN is not defined in standard c++.

  • runtime/UString.cpp: (JSC::UString::from):
04:30 Changeset [47101] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

QtWebKit compile fix for Windows CE

Patch by Joerg Bornemann <joerg.bornemann@trolltech.com> on 2009-08-12
Reviewed by Simon Hausmann.

There's no getenv on Windows CE, use qgetenv instead.

  • Api/qwebpage.cpp:

(qt_drt_overwritePluginDirectories):

03:12 Changeset [47100] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

Use AM_V_GEN in a few more places, for less noisy builds.

  • GNUmakefile.am:
03:11 Changeset [47099] by krit@webkit.org
  • 9 edits in trunk/WebCore

2009-08-12 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

SVG Filter premultiplied color support for getImageDate/putImageData
https://bugs.webkit.org/show_bug.cgi?id=27933

Some SVG Filters need premultiplied ImageData for the calculation. Therefore getImageData
and putImageData of ImageBuffer need support for premultiplied colors.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData): (WebCore::CanvasRenderingContext2D::putImageData):
  • platform/graphics/ImageBuffer.h: (WebCore::):
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
02:58 Changeset [47098] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-12 Benjamin Otte <otte@gnome.org>

Reviewed by Jan Alonzo.

Buildfix for Gtk platforms debug builds.

  • GNUmakefile.am: Choose MarkStackPosix.cpp or MarkStackWin.cpp depending on platform.
02:13 Changeset [47097] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

Prospective build fix for Mac and 32-bit Windows.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-12

  • runtime/UString.cpp: Include wtf/StringExtras.h for snprintf.

(JSC::UString::from): Use %lld instead of %I64d for snprintf
on non-windows platforms.

01:58 Changeset [47096] by hausmann@webkit.org
  • 3 edits in trunk/JavaScriptCore

Fix compile error on 64Bit Windows, when UString::from
is called with an intptr_t.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-08-12
Reviewed by Simon Hausmann.

Added new UString::From overload with long long parameter.

Thanks to Holger for the long long idea.

  • runtime/UString.cpp:

(JSC::UString::from):

  • runtime/UString.h:
01:18 QtWebKitJournal edited by hausmann@webkit.org
(diff)
01:04 QtWebKitFeatures46 edited by hausmann@webkit.org
(diff)
00:59 Changeset [47095] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-08-12 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Changed Number.bytesToString to support low-resolution output.

https://bugs.webkit.org/show_bug.cgi?id=28146

  • inspector/front-end/utilities.js: (Number.bytesToString):
00:53 Changeset [47094] by hausmann@webkit.org
  • 3 edits
    1 add in trunk/WebCore

Add support for hooking BeginPaint/EndPaint on 64Bit Windows

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-08-12
Reviewed by Simon Hausmann.

Webkit uses the runtime patching trick explained by "Feng Yuan" for
hooking these paint functions. It currently supports only 32bit assembly
code. This patch adds support for 64Bit version. Since inline-assemblies
are not supported for 64Bit, we have use a seperate .asm file.

  • WebCore.pro:
  • plugins/win/PaintHooks.asm: Added.
  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::hookedBeginPaint):
(WebCore::PluginView::hookedEndPaint):
(WebCore::hook):

08/11/09:

23:50 Changeset [47093] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Minor style fixes in previous patch and changelog correction.

Reviewed by Mark Rowe

23:22 Changeset [47092] by oliver@apple.com
  • 13 edits
    2 adds in trunk

Make it harder to misuse try* allocation routines
https://bugs.webkit.org/show_bug.cgi?id=27469

Reviewed by Gavin Barraclough

Jump through a few hoops to make it much harder to accidentally
miss null-checking of values returned by the try-* allocation
routines.

22:59 Changeset [47091] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by NOBODY (build fix part deux).

22:29 Changeset [47090] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by NOBODY (build fix).

22:22 Changeset [47089] by barraclough@apple.com
  • 18 edits in trunk

JavaScriptCore: Restrict use of FuncDeclNode & FuncExprNode to the parser.
https://bugs.webkit.org/show_bug.cgi?id=28209

Reviewed by Oliver Hunt.

These objects were also being referenced from the CodeBlock. By changing this
to just retain pointers to FunctionBodyNodes these classes can be restricted to
use during parsing.

No performance impact (or sub-percent progression).

Update symbols.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::mark):
(JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addFunction):
(JSC::CodeBlock::function):

Unify m_functions & m_functionExpressions into a single Vector<RefPtr<FuncExprNode> >.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):

  • bytecompiler/BytecodeGenerator.h:

FunctionStacks now contain FunctionBodyNodes not FuncDeclNodes.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):

Update to reflect chnages in CodeBlock.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_func_exp):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:

(JSC::):

Update to reflect chnages in CodeBlock.

  • parser/Grammar.y:

FunctionStacks now contain FunctionBodyNodes not FuncDeclNodes.

  • parser/NodeConstructors.h:

(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):

  • parser/Nodes.cpp:

(JSC::ScopeNodeData::mark):
(JSC::FunctionBodyNode::finishParsing):

  • parser/Nodes.h:

(JSC::FunctionBodyNode::ident):

Move m_ident & make methods from FuncDeclNode & FuncExprNode to FunctionBodyNode.

  • runtime/JSFunction.h:

(JSC::FunctionBodyNode::make):

Make this method inline (was FuncDeclNode::makeFunction).

WebCore: Restrict use of FuncDeclNode & FuncExprNode to the parser.
https://bugs.webkit.org/show_bug.cgi?id=28209

Reviewed by Oliver Hunt.

  • inspector/JavaScriptDebugServer.cpp:

(WebCore::JavaScriptDebugServer::recompileAllJSFunctions):

Function signature change.

22:05 Changeset [47088] by abarth@webkit.org
  • 1 edit in trunk/WebKitSite/coding/major-objects.html

Hopefully the last tweak to major-objects.html

22:01 Changeset [47087] by abarth@webkit.org
  • 2 edits in trunk/WebKitSite

Unreviewed.

Patch by Adam Barth <abarth@webkit.org> on 2009-08-11
Remove a few characters from the ASCII art to make it fit better in the
template.

  • coding/major-objects.html:
21:56 Changeset [47086] by oliver@apple.com
  • 7 edits in trunk

Native JSON.stringify does not omit functions
https://bugs.webkit.org/show_bug.cgi?id=28117

Reviewed by Gavin Barraclough

Objects that are callable should be treated as undefined when
serialising to JSON.

21:55 Changeset [47085] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKitSite

2009-08-11 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

Document relation between major objects in WebCore
https://bugs.webkit.org/show_bug.cgi?id=28210

Added a diagram showing the relation between major objects.

  • coding/major-objects.html: Added.
20:30 Changeset [47084] by mrowe@apple.com
  • 7 edits
    1 copy in trunk

2009-08-11 John Gregg <johnnyg@google.com>

Reviewed by Maciej Stachowiak.

WebCore:
Move the accessor for notifications presenter from WebUIDelegate
to WebUIDelegate2 which extends it. When making this call from
WebCoreSupport, check using QueryInterface before calling.

https://bugs.webkit.org/show_bug.cgi?id=28198

  • Interfaces/IWebUIDelegate.idl:
  • Interfaces/IWebUIDelegate2.idl: Added.
  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp:

(WebDesktopNotificationsDelegate::show):
(WebDesktopNotificationsDelegate::cancel):
(WebDesktopNotificationsDelegate::notificationObjectDestroyed):
(WebDesktopNotificationsDelegate::requestPermission):
(WebDesktopNotificationsDelegate::checkPermission):
(WebDesktopNotificationsDelegate::hasNotificationDelegate):
(WebDesktopNotificationsDelegate::notificationDelegate):

  • WebCoreSupport/WebDesktopNotificationsDelegate.h:

DumpRenderTree:
Switch DumpRenderTree to contain a WebUIDelegate2, which extends
WebUIDelegate, so that the notifications tests will still work.
https://bugs.webkit.org/show_bug.cgi?id=28198

  • DumpRenderTree/win/UIDelegate.h:
20:12 Changeset [47083] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Rubberstamped by Mark Rowe.

<rdar://problem/7135864> fast/dom/frame-loading-via-document-write.html fails intermittently.

  • platform/mac-snowleopard/Skipped: Skip for now.
19:18 Changeset [47082] by staikos@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Not reviewed: repair email address

18:30 Changeset [47081] by pkasting@chromium.org
  • 3 edits
    1 delete in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=27965
Merge skia/ImageSourceSkia.cpp into ImageSource.cpp.

Reviewed by Adam Treat.

  • WebCore.gypi: Remove deleted file, plus a file that was deleted a while back.
  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::setData): Use slightly shorter syntax.
(WebCore::ImageSource::filenameExtension): Use shorter syntax.
(WebCore::ImageSource::createFrameAtIndex): Remove redundant call, clarify comments, reject all empty images.
(WebCore::ImageSource::frameHasAlphaAtIndex): Clarify comments, use shorter syntax.

  • platform/graphics/skia/ImageSourceSkia.cpp: Removed.
18:15 Changeset [47080] by darin@apple.com
  • 2 edits in trunk/WebKitTools

Try to fix GTK build.

Patch by Darin Adler <darin@apple.com> on 2009-08-11

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::stringForRange): Added.

18:09 Changeset [47079] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

Remove tests from Skipped that now pass correctly after the addition
of keyDown named event handling to Qt's DumpRenderTree.

Patch by Mike Fenton <mike.fenton@torchmobile.com> on 2009-08-11
Reviewed by Adam Treat.

https://bugs.webkit.org/show_bug.cgi?id=28161

  • platform/qt/Skipped:
18:05 Changeset [47078] by atwilson@chromium.org
  • 11 edits in trunk

WebCore: SharedWorkers do not exit when the last parent document exits
https://bugs.webkit.org/show_bug.cgi?id=28170

Reviewed by David Levin.

Prevents Documents from being suspended/placed in the page cache if they are associated with shared workers.

Added vector cache instead of nested hash tables for SharedWorker repository.

Added SharedWorkerRepository::documentDetached API.

  • dom/Document.cpp:

(WebCore::Document::detach):
Notifies SharedWorkerRepository when the document is closing.

  • loader/FrameLoader.cpp:

Updated FrameLoader to not cache the Document if it is associated with a SharedWorker (since we can't suspend workers yet, we need to shut them down).
(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::create):
(WebCore::SharedWorkerProxy::isClosing):
Renamed from closing().
(WebCore::SharedWorkerProxy::matches):
Added manual equality function to replace old hash lookup.
(WebCore::SharedWorkerProxy::isDocumentInWorkerDocuments):
Checks to see if a document is in the worker's list of documents. Used to determine if page is suspendable.
(WebCore::SharedWorkerProxy::SharedWorkerProxy):
(WebCore::SharedWorkerProxy::addToWorkerDocuments):
Added tracking of the worker's list of documents for lifecycle purposes.
(WebCore::SharedWorkerProxy::documentDetached):
Shuts down the proxy when the last associated document is detached.
(WebCore::SharedWorkerProxy::close):
Marks the proxy as closed so it is no longer shared with new instances.
(WebCore::SharedWorkerProxy::workerContextDestroyed):
Removes the proxy from the repository/frees the proxy when the associated SharedWorkerContext is destroyed.
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
closing()->isClosing()
(WebCore::SharedWorkerRepository::documentDetached):
(WebCore::SharedWorkerRepository::hasSharedWorkers):
Used by FrameLoader to determine if a page has shared workers and so cannot be suspended/cached.
(WebCore::DefaultSharedWorkerRepository::hasSharedWorkers):
(WebCore::DefaultSharedWorkerRepository::removeProxy):
Invoked by workerContextDestroyed() to remove a SharedWorkerProxy from the repository.
(WebCore::DefaultSharedWorkerRepository::documentDetached):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):
(WebCore::DefaultSharedWorkerRepository::getProxy):

  • workers/DefaultSharedWorkerRepository.h:
  • workers/SharedWorkerRepository.h:

LayoutTests: SharedWorkers do not exit when the last parent document exits.
https://bugs.webkit.org/show_bug.cgi?id=28170

Reviewed by David Levin.

Added more tests to check that previous incarnations of the SharedWorker "name" are shut down.

  • fast/workers/shared-worker-replace-global-constructor.html-disabled:

Fixed incorrect path to common script.

  • fast/workers/shared-worker-shared-expected.txt:
  • fast/workers/shared-worker-shared.html-disabled:

Added more tests for sharing, including initial test to make sure previous incarnations of shared worker were closed.

  • fast/workers/worker-replace-global-constructor.html:

Removed extraneous closing HTML tag.

18:04 Changeset [47077] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

Add processing for string constants used by the tests to trigger
common actions like up, down, left, right, etc. for the Qt
implementation of DumpRenderTree.

Patch by Mike Fenton <mike.fenton@torchmobile.com> on 2009-08-10
Reviewed by Adam Treat.

Note this allows fast/forms/textarea-arrow-navigation.html to pass
correctly.

https://bugs.webkit.org/show_bug.cgi?id=28161

  • DumpRenderTree/qt/jsobjects.cpp:

(EventSender::keyDown):

17:58 Changeset [47076] by cfleizach@apple.com
  • 12 edits
    2 adds in trunk

WebCore: Bug 28200 - ListMarker should be included as part of the text value to parse
https://bugs.webkit.org/show_bug.cgi?id=28200

Reviewed by Darin Adler.

When returning text through the marker range attributes, the list marker text should
also be included. It isn't included by default because a TextIterator is used which
only looks at Nodes for text. A list marker does not have a corresponding node,
so its text is not returned through accessibility. That is, until now.

Test: platform/mac/accessibility/string-range-contains-listmarker.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::listMarkerTextForRange):
(WebCore::AccessibilityObject::stringForVisiblePositionRange):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

  • rendering/RenderListItem.h:

Make markerText() public so that accessibility code can access it.

WebKitTools: Bug 28200 - ListMarker should be included as part of the text value to parse
https://bugs.webkit.org/show_bug.cgi?id=28200

Reviewed by Darin Adler.

Add the ability to retrieve a string given a plain NSRange.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(stringForRangeCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::valueDescription):
(AccessibilityUIElement::stringForRange):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::stringForRange):

LayoutTests: Bug 28200 - ListMarker should be included as part of the text value to parse
https://bugs.webkit.org/show_bug.cgi?id=28200

Reviewed by Darin Adler.

Tests for checking that the list marker text is included when asking for text
through accessibility.

  • platform/mac/accessibility/bounds-for-range-expected.txt.
  • platform/mac/accessibility/string-range-contains-listmarker-expected.txt: Added.
  • platform/mac/accessibility/string-range-contains-listmarker.html: Added.
17:35 Changeset [47075] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Rubberstamped by Mark Rowe.

<rdar://problem/7135553> plugins/root-object-premature-delete-crash.html crashes intermittently.

  • platform/mac-snowleopard/Skipped: Skip for now.
17:08 Changeset [47074] by dimich@chromium.org
  • 2 edits in trunk/WebKitTools

Fix fast/dom/prototype-inheritance.html
and fast/dom/prototype-inheritance-2.html
broken on Windows by http://trac.webkit.org/changeset/47018

Reviewed by NOBODY (Speculative fix for the layout test failure).

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues): enable app cache in Windows DRT.

16:20 Changeset [47073] by pkasting@chromium.org
  • 4 edits
    1 move in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=27965
Move cairo/ImageSourceCairo.cpp to ImageSource.cpp in preparation for
merging most of the other ImageSource*.cpp files with it.

Reviewed by Adam Treat.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/ImageSource.cpp: Copied from WebCore/platform/graphics/cairo/ImageSourceCairo.cpp.
  • platform/graphics/cairo/ImageSourceCairo.cpp: Removed.
16:12 Changeset [47072] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Updated data/params parameter

  • data/params: Updated 'loginnetmask' parameter to allow users to choose whether their cookies are restricted to a single IP address or not.
16:09 Changeset [47071] by bfulgham@webkit.org
  • 4 edits in trunk/WebCore

Cairo-based Windows port does not handle the https protocol.
https://bugs.webkit.org/show_bug.cgi?id=28171.

Reviewed by Adam Roben.

No new tests needed. Existing https tests show this failure
for WinCairo builds.

  • WebCore.vcproj/WebCoreCURL.vsprops: Add a few preprocessor definitions for SSL support in cURL.
  • platform/network/curl/ResourceHandleManager.h: Add new certificate path member variable.
  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::certificateBundlePath): New method to retrieve the

proper certificate resource bundle path.

(WebCore::ResourceHandleManager::initializeHandle): Check for

the resource bundle and use if available to activate SSL
support.

15:44 Changeset [47070] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-08-11 Eric Seidel <eric@webkit.org>

No review, just adding results.

Cross-platform ICO decoder gets wrong bit depth for icons w/o color count
https://bugs.webkit.org/show_bug.cgi?id=28073

Land test results (as pkasting asked me to do hours ago, sorry).

  • fast/images/icon-0colors-expected.checksum: Added.
  • fast/images/icon-0colors-expected.png: Added.
  • fast/images/icon-0colors-expected.txt: Added.
15:33 Changeset [47069] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool: Re-factor shared landing logic into helper class to share more code
https://bugs.webkit.org/show_bug.cgi?id=28193

Added new WebKitLandingScripts class to hold this shared logic.
Also added a view_source_url function to move more webkit-specific urls out of bugzilla-tool core.

  • Scripts/bugzilla-tool:
15:25 Changeset [47068] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-08-11 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Use Clipboard::create() instead of the constructor of Clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28127

  • editing/haiku/EditorHaiku.cpp: (WebCore::Editor::newGeneralClipboard):
  • page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::createDraggingClipboard):
  • platform/haiku/ClipboardHaiku.cpp: Style cleanup. There were many whitespace end of lines. (WebCore::ClipboardHaiku::ClipboardHaiku): (WebCore::ClipboardHaiku::clearAllData): (WebCore::ClipboardHaiku::getData): (WebCore::ClipboardHaiku::setData): (WebCore::ClipboardHaiku::types): (WebCore::ClipboardHaiku::dragLocation): (WebCore::ClipboardHaiku::dragImage): (WebCore::ClipboardHaiku::setDragImage): (WebCore::ClipboardHaiku::dragImageElement): (WebCore::ClipboardHaiku::createDragImage): (WebCore::ClipboardHaiku::declareAndWriteDragImage): (WebCore::ClipboardHaiku::writeURL): (WebCore::ClipboardHaiku::writeRange): (WebCore::ClipboardHaiku::hasData):
  • platform/haiku/DragDataHaiku.cpp: (WebCore::DragData::createClipboard):
15:15 Changeset [47067] by atwilson@chromium.org
  • 2 edits in trunk/WebCore

Speculative fix for GTK build break.

Reviewed by NOBODY (Build break).

  • WebKit.pro:
15:05 Changeset [47066] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-11 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Adam Treat.

Fix the current failures on the buildbot.

As Qt hooks up the maybeDump to loadFinished, we need to make
sure that calling dump() will not call maybeDump on loadFinished.

As dump is called my emitting done() which calls dump() and then
setting m_isLoading to false. So in the case m_isLoading is false,
do not dump again.

The current code is confusing, and should be made more clear
in another commit.

  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::maybeDump): (LayoutTestController::notifyDone):
14:35 Changeset [47065] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

Fix the current failures on the buildbot.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-08-11
Reviewed by Adam Treat.

As Qt hooks up the maybeDump to loadFinished, we need to make
sure that calling dump() will not call maybeDump on loadFinished.

As dump is called my emitting done() which calls dump() and then
setting m_isLoading to false. So in the case m_isLoading is false,
do not dump again.

The current code is confusing, and should be made more clear
in another commit.

  • DumpRenderTree/qt/jsobjects.cpp:

(LayoutTestController::maybeDump):
(LayoutTestController::notifyDone):

14:31 Changeset [47064] by atwilson@chromium.org
  • 2 edits in trunk

WebCore: Speculative Windows build fix

Reviewed by NOBODY (build break).

  • WebCore.vcproj/WebCore.vcproj:

Added missing build steps for non-debug targets.

WebKit/win: Speculative Windows build fix - undo previous unnecessary change.

Reviewed by NOBODY (build break).

  • WebCoreSupport/WebDesktopNotificationsDelegate.h:
14:31 Changeset [47063] by atwilson@chromium.org
  • 2 edits in trunk

Speculative build fix for Qt build.

Reviewed by NOBODY (build break)

  • WebCore.pro: Added /notifications to include path
14:30 Changeset [47062] by oliver@apple.com
  • 7 edits in trunk

REGRESSION: Hang/crash in BytecodeGenerator::constRegisterFor loading simple page
https://bugs.webkit.org/show_bug.cgi?id=28169

Reviewed by Geoff Garen.

Handle the case where someone has attempted to shadow a property
on the global object with a constant.

14:13 Changeset [47061] by pkasting@chromium.org
  • 2 edits in trunk/WebKitTools

https://bugs.webkit.org/show_bug.cgi?id=27323
Handle arbitrary line endings when manufacturing patches for additions
with history.

Reviewed by Darin Adler.

  • Scripts/svn-create-patch:
14:04 Changeset [47060] by bweinstein@apple.com
  • 5 edits in trunk/WebKit/win

2009-08-11 Brian Weinstein <bweinstein@apple.com>

Reviewed by Steve Falkenburg.

Refactored MIMETypeforExtension to be a member of IWebViewPrivate
instead of IWebView.

  • Interfaces/IWebView.idl:
  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::MIMETypeForExtension):
  • WebView.h:
14:01 Changeset [47059] by atwilson@chromium.org
  • 2 edits in trunk/WebCore

Speculative build fix for Qt build.

Reviewed by NOBODY (build break)

  • WebCore.pro: Added /notifications to include path
13:45 Changeset [47058] by atwilson@chromium.org
  • 2 edits in trunk/WebKit/win

Speculative fix for windows build break.

Reviewed by NOBODY (build break)

  • WebKitSupport/WebDesktopNotificationsDelegate.h:

WebCore/Notification*.h => WebCore/notifications/Notification*.h

13:37 Changeset [47057] by atwilson@chromium.org
  • 2 edits in trunk

Speculative fix for GTK build break.

Reviewed by NOBODY (Build break).

  • WebKit.pro:
13:21 Changeset [47056] by atwilson@chromium.org
  • 45 edits
    32 adds in trunk

JavaScriptCore: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463

Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.

Adds ENABLE_NOTIFICATION flag.

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

WebCore: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463

Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.

Adds an implementation of desktop notifications, behind the compile-time
flag ENABLE(NOTIFICATIONS). This code simply relays calls on the JavaScript
API through a NotificationProvider interface, which must provide the services
to actually notify the user and manage the desktop. This provider is injected
into WebKit through the ChromeClient for normal page contexts and through the
WorkerThread for worker contexts.

A permissions API is defined on a per-origin basis, which allows a web page
to check if its origin is allowed to show desktop notifications, and to request
permission for its origin.

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDesktopNotificationsCustom.cpp: Added.

(WebCore::JSNotificationCenter::requestPermission):
(WebCore::JSNotification::addEventListener):
(WebCore::JSNotification::removeEventListener):

  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):
(WebCore::toEventTarget):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::toNotification):

  • dom/EventTarget.h:
  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::notificationPresenter):

  • notifications: Added.
  • notifications/Notification.cpp: Added.

(WebCore::Notification::Notification):
(WebCore::Notification::~Notification):
(WebCore::Notification::show):
(WebCore::Notification::cancel):
(WebCore::Notification::ondisplay):
(WebCore::Notification::setOndisplay):
(WebCore::Notification::onerror):
(WebCore::Notification::setOnerror):
(WebCore::Notification::onclose):
(WebCore::Notification::setOnclose):
(WebCore::Notification::getAttributeEventListener):
(WebCore::Notification::setAttributeEventListener):
(WebCore::Notification::clearAttributeEventListener):
(WebCore::Notification::dispatchDisplayEvent):
(WebCore::Notification::dispatchErrorEvent):
(WebCore::Notification::dispatchCloseEvent):
(WebCore::Notification::addEventListener):
(WebCore::Notification::removeEventListener):
(WebCore::Notification::handleEvent):
(WebCore::Notification::dispatchEvent):

  • notifications/Notification.h: Added.

(WebCore::Notification::create):
(WebCore::Notification::isHTML):
(WebCore::Notification::url):
(WebCore::Notification::contents):
(WebCore::Notification::scriptExecutionContext):
(WebCore::Notification::toNotification):
(WebCore::Notification::refEventTarget):
(WebCore::Notification::derefEventTarget):

  • notifications/Notification.idl: Added.
  • notifications/NotificationCenter.cpp: Added.

(WebCore::NotificationCenter::NotificationCenter):
(WebCore::NotificationCenter::checkPermission):
(WebCore::NotificationCenter::requestPermission):

  • notifications/NotificationCenter.h: Added.

(WebCore::NotificationCenter::create):
(WebCore::NotificationCenter::createHTMLNotification):
(WebCore::NotificationCenter::createNotification):
(WebCore::NotificationCenter::context):
(WebCore::NotificationCenter::presenter):

  • notifications/NotificationCenter.idl: Added.
  • notifications/NotificationContents.h: Added.

(WebCore::NotificationContents::NotificationContents):
(WebCore::NotificationContents::icon):
(WebCore::NotificationContents::title):
(WebCore::NotificationContents::body):

  • notifications/NotificationPresenter.h: Added.

(WebCore::NotificationPresenter::):
(WebCore::NotificationPresenter::~NotificationPresenter):

  • page/Chrome.cpp:

(WebCore::Chrome::notificationPresenter):

  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::clear):
(WebCore::DOMWindow::webkitNotifications):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/Page.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::~WorkerContext):
(WebCore::WorkerContext::webkitNotifications):

  • workers/WorkerContext.h:
  • workers/WorkerContext.idl:
  • workers/WorkerThread.h:

(WebCore::WorkerThread::getNotificationPresenter):
(WebCore::WorkerThread::setNotificationPresenter):

WebKit/mac: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25643

Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.

Adds ENABLE_NOTIFICATION flag.

  • Configurations/FeatureDefines.xcconfig:

WebKit/win: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25643

Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.

Adds test hooks for notification features to WebCoreSupport for
use in DumpRenderTree.

  • Interfaces/IWebDesktopNotificationsDelegate.idl: Added.
  • Interfaces/IWebUIDelegate.idl:
  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::WebChromeClient):

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::notificationPresenter):

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added.

(NotificationCOMWrapper::create):
(NotificationCOMWrapper::NotificationCOMWrapper):
(NotificationCOMWrapper::QueryInterface):
(NotificationCOMWrapper::AddRef):
(NotificationCOMWrapper::Release):
(NotificationCOMWrapper::isHTML):
(NotificationCOMWrapper::contentsURL):
(NotificationCOMWrapper::iconURL):
(NotificationCOMWrapper::title):
(NotificationCOMWrapper::text):
(NotificationCOMWrapper::notifyDisplay):
(NotificationCOMWrapper::notifyError):
(NotificationCOMWrapper::notifyClose):
(WebDesktopNotificationsDelegate::WebDesktopNotificationsDelegate):
(WebDesktopNotificationsDelegate::show):
(WebDesktopNotificationsDelegate::cancel):
(WebDesktopNotificationsDelegate::notificationObjectDestroyed):
(WebDesktopNotificationsDelegate::requestPermission):
(WebDesktopNotificationsDelegate::checkPermission):
(WebDesktopNotificationsDelegate::notificationDelegate):

  • WebCoreSupport/WebDesktopNotificationsDelegate.h: Added.
  • WebCoreSupport/WebInspectorDelegate.h:

(WebInspectorDelegate::desktopNotificationsDelegate):

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj:

WebKitTools: Add support for desktop notifications API to DumpRenderTree,
and support for ENABLE_NOTIFICATIONS flag to build-webkit.

Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.

  • DumpRenderTree/LayoutTestController.cpp:

(grantDesktopNotificationPermissionCallback):
(LayoutTestController::staticFunctions):
(LayoutTestController::grantDesktopNotificationPermission):
(LayoutTestController::checkDesktopNotificationPermission):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: Added.

(DRTDesktopNotificationPresenter::DRTDesktopNotificationPresenter):
(DRTDesktopNotificationPresenter::QueryInterface):
(DRTDesktopNotificationPresenter::AddRef):
(DRTDesktopNotificationPresenter::Release):
(DRTDesktopNotificationPresenter::showDesktopNotification):
(DRTDesktopNotificationPresenter::cancelDesktopNotification):
(DRTDesktopNotificationPresenter::notificationDestroyed):
(DRTDesktopNotificationPresenter::checkNotificationPermission):
(DRTDesktopNotificationPresenter::requestNotificationPermission):

  • DumpRenderTree/win/DRTDesktopNotificationPresenter.h: Added.
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::UIDelegate):
(UIDelegate::desktopNotificationsDelegate):

  • DumpRenderTree/win/UIDelegate.h:
  • Scripts/build-webkit:

LayoutTests: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463

Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.

Adding layout tests for desktop notifications. Currently these
are all disabled because the flag for this feature is set to 0.

  • fast/notifications: Added.
  • fast/notifications/notifications-check-permission-expected.txt: Added.
  • fast/notifications/notifications-check-permission.html-disabled: Added.
    • Validates that checking permission for notifications works correctly.
  • fast/notifications/notifications-display-close-events-expected.txt: Added.
  • fast/notifications/notifications-display-close-events.html-disabled: Added.
    • Validates that the display and close events are fired correctly.
  • fast/notifications/notifications-double-show-expected.txt: Added.
  • fast/notifications/notifications-double-show.html-disabled: Added.
    • Validates that the same notification object cannot be shown twice.
  • fast/notifications/notifications-request-permission-expected.txt: Added.
  • fast/notifications/notifications-request-permission.html-disabled: Added.
    • Validates that requesting permission works correctly.
  • fast/notifications/notifications-with-permission-expected.txt: Added.
  • fast/notifications/notifications-with-permission.html-disabled: Added.
    • Validates that, with permission, showing a notification works correctly.
  • fast/notifications/notifications-without-permission-expected.txt: Added.
  • fast/notifications/notifications-without-permission.html-disabled: Added.
    • Validates that, without permission, showing a notification fails.
13:19 Changeset [47055] by mrowe@apple.com
  • 4 copies
    1 add in releases/Apple/Safari 4.0.3

Tag the Safari 4.0.3 release.

This release consists of JavaScriptCore-x531.5, JavaScriptGlue-x531.5, WebCore-x531.9 and WebKit-x531.9.

13:19 Changeset [47054] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Remove dead declarations.

Reviewed by Sam Weinig.

  • WebView/WebViewInternal.h:
13:17 Changeset [47053] by mrowe@apple.com
  • 4 copies
    1 add in releases/Apple/Safari 4.0.2

Tag the Safari 4.0.2 release.

This release consists of JavaScriptCore-x530.19, WebCore-x530.19 and WebKit-x530.19.2. JavaScriptGlue remains unchanged from Safari 4.0.1.

13:14 Changeset [47052] by beidson@apple.com
  • 2 edits
    3 copies
    3 adds in trunk/LayoutTests

Rubberstamped by Mark Rowe.

-Stop skipping platform/mac/fast/text/myanmar-shaping.html on SnowLeopard.
-Move the previous results aside for Tiger and Leopard only.
-Generate new results for SnowLeopard.

  • platform/mac-snowleopard/Skipped: Remove platform/mac/fast/text/myanmar-shaping.html
  • platform/mac-leopard/fast/text/myanmar-shaping-expected.checksum: Copied from platform/mac/fast/text/myanmar-shaping-expected.checksum.
  • platform/mac-leopard/fast/text/myanmar-shaping-expected.png: Copied from platform/mac/fast/text/myanmar-shaping-expected.png.
  • platform/mac-leopard/fast/text/myanmar-shaping-expected.txt: Copied from platform/mac/fast/text/myanmar-shaping-expected.txt.
  • platform/mac/fast/text/myanmar-shaping-expected.checksum: Replaced.
  • platform/mac/fast/text/myanmar-shaping-expected.png: Replaced.
  • platform/mac/fast/text/myanmar-shaping-expected.txt: Replaced.
12:52 Changeset [47051] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Anders Carlsson.

Resolve <rdar://problem/6733642>.

  • platform/mac-snowleopard/Skipped: Re-enable plugins/netscape-plugin-setwindow-size.html and plugins/netscape-plugin-setwindow-size-2.html, as they now reliably pass.
12:51 Changeset [47050] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

2009-08-11 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

Modifications on JavaScriptCore to allow Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=28121

  • runtime/Collector.cpp: Haiku doesn't have sys/mman.h, using OS.h instead. (JSC::currentThreadStackBase): Haiku uses its own threading system.
  • wtf/Platform.h: Defining all Haiku platform values.
  • wtf/haiku/MainThreadHaiku.cpp: Adding a missing header (NotImplemented.h).
12:37 Changeset [47049] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-08-11 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Console Drawer is Toggling instead of Staying Open
https://bugs.webkit.org/show_bug.cgi?id=28115

  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.showView): ensures the drawer will be open and showing the provided view
  • inspector/front-end/inspector.js: (WebInspector.showConsole): usees the new showView to guarantee the Drawer will be open (WebInspector.showChanges): uses the new showView guarantee the Drawer will be open
12:29 Changeset [47048] by zimmermann@webkit.org
  • 10 edits
    1 add in trunk/WebCore

2009-08-11 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] WMLPageState is not allowed to store the active card, it needs to be done per document
https://bugs.webkit.org/show_bug.cgi?id=28180

Don't store the active WMLCardElement in WMLPageState, but in WMLDocument.
Otherwhise this may lead to crashes related to intrinsic event exeuction.

Unfortunately select elements aren't testable by the layout tests, so adding
a new manual test reproducing the crash.

  • manual-tests/wml/select-onpick-event-crash.wml: Added.
  • wml/WMLCardElement.cpp: (WebCore::WMLCardElement::determineActiveCard):
  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::defaultEventHandler):
  • wml/WMLDocument.cpp: (WebCore::WMLDocument::finishedParsing):
  • wml/WMLDocument.h: (WebCore::WMLDocument::activeCard):
  • wml/WMLGoElement.cpp: (WebCore::WMLGoElement::executeTask):
  • wml/WMLPageState.cpp: (WebCore::WMLPageState::WMLPageState):
  • wml/WMLPageState.h:
  • wml/WMLPrevElement.cpp: (WebCore::WMLPrevElement::executeTask):
  • wml/WMLRefreshElement.cpp: (WebCore::WMLRefreshElement::executeTask):
12:28 Changeset [47047] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

Resolve <rdar://problem/6877291>.

  • platform/mac-snowleopard/Skipped: media/video-size-intrinsic-scale.html no longer fails - stop skipping it!
12:19 Changeset [47046] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Rubberstamped by Mark Rowe.

  • platform/mac-snowleopard/Skipped: Remove http/tests/navigation/post-goback-repost-policy.html, as it has already been disabled globally, and re-enabling is tracked by <rdar://problem/6778137>
12:13 Changeset [47045] by pkasting@chromium.org
  • 3 edits in trunk/WebKitTools

https://bugs.webkit.org/show_bug.cgi?id=28183
Support VS2008 as well as VS2005 in a few scripts.

Reviewed by Darin Adler.

  • Scripts/pdevenv: Check both $VS80COMNTOOLS and $VS90COMNTOOLS.
  • Scripts/webkitdirs.pm: Use $VSINSTALLDIR if available instead of hardcoding the VS2005 dir.
12:10 Changeset [47044] by bweinstein@apple.com
  • 4 edits in trunk/WebKit/win

2009-08-11 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

Fix of <rdar://5016504> SVG file cannot be dragged to webview,
but can be opened via Open File.

Added a new function to IWebView that gets the MIME type for a given
extension from the MIMETypeRegistry.

  • Interfaces/IWebView.idl:
  • WebView.cpp: (WebView::MIMETypeForExtension):
  • WebView.h:
12:09 Changeset [47043] by dimich@chromium.org
  • 2 edits in trunk/WebKitTools

Fix for layout tests failures. Need to initialize some preferences early
because WebView on Windows uses them during create time.

Reviewed by NOBODY (Windows layout tests fix).

  • DumpRenderTree/win/DumpRenderTree.cpp:

(main):

12:00 Changeset [47042] by pkasting@chromium.org
  • 3 edits
    2 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=28073
Treat icons with no bit count and no color count as 256-color for
purposes of quality ranking. Also fix a couple cases of a style
violation.

Reviewed by Eric Seidel.

Test: fast/images/icon-0colors.html

  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::processDirectory):
(WebCore::ICOImageDecoder::readDirectoryEntry):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=28073
Treat icons with no bit count and no color count as 256-color for
purposes of quality ranking.

Reviewed by Eric Seidel.

  • fast/images/icon-0colors.html: Added.
  • fast/images/resources/0colors.ico: Added.
11:29 Changeset [47041] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-08-11 Benjamin Otte <otte@gnome.org>

Reviewed by Xan Lopez.

When instructed to print an out-of-range page, print an empty page
instead of crashing.

  • webkit/webkitwebframe.cpp: (draw_page_callback):
11:27 Changeset [47040] by eric@webkit.org
  • 3 edits
    1 copy in trunk/WebKitTools

2009-08-11 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Exception in land-patches
https://bugs.webkit.org/show_bug.cgi?id=27962

Use ("%s" % object) instead of ("" + object).
Added unit tests for logging.py.

  • Scripts/modules/logging.py:
  • Scripts/modules/logging_unittest.py: Added.
  • Scripts/run-webkit-unittests:
10:42 Changeset [47039] by dimich@chromium.org
  • 19 edits
    6 adds in trunk

Re-land the patch for https://bugs.webkit.org/show_bug.cgi?id=20534.
Previously reverted since incorrect merge on landing has caused Layout Tests failures on Windows.

WebKit/mac: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added new methods for overriding default WebPreference values
and for resetting preferences to their defaults.
See https://bugs.webkit.org/show_bug.cgi?id=20534

  • WebView/WebPreferences.mm:

(-[WebPreferences _setPreferenceForTestWithValue:withKey:]): added.

  • WebView/WebPreferencesPrivate.h: same.

WebKit/win: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added support for overriding default preferences per-test.
See https://bugs.webkit.org/show_bug.cgi?id=20534

  • Interfaces/IWebPreferencesPrivate.idl: added new method setPreferenceForTest
  • WebPreferences.cpp: same.
  • WebPreferences.h: same.

WebKitTools: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added support for overriding default preferences per-test.
See https://bugs.webkit.org/show_bug.cgi?id=20534

  • DumpRenderTree/LayoutTestController.cpp:

(overridePreferenceCallback): add wiring for layoutTestController.overridePreference.
(LayoutTestController::staticFunctions): same.

  • DumpRenderTree/LayoutTestController.h: same.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::overridePreference): added empty overridePreference method.

  • DumpRenderTree/mac/DumpRenderTree.mm: implemented preference override.

(resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
(setDefaultsToConsistentValuesForTesting): new method, sets other details of testing environment, every time DRT starts.
(resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::overridePreference):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
(resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().
(createWebViewAndOffscreenWindow): same.
(main): same.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::overridePreference):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::overridePreference):

LayoutTests: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added tests to verify that default preferences can be overridden per-test
and that overridden values are reset between each test.
See https://bugs.webkit.org/show_bug.cgi?id=20534

  • fast/harness/override-preferences-2-expected.txt: Added.
  • fast/harness/override-preferences-2.html: Added. Verifies overridePreverence("WebKitDefaultFontSize", "24").
  • fast/harness/override-preferences-expected.txt: Added.
  • fast/harness/override-preferences.html: Added. Verifies overridePreference("WebKitJavaScriptEnabled", false).
  • fast/harness/override-zzz-reset-expected.txt: Added.
  • fast/harness/override-zzz-reset.html: Added. Because of 'zzz' this test will run after the tests above and

verify that override of preferences does not 'spill' to the subsequent tests in a batch.

  • platform/gtk/Skipped: Tests above disabled for GTK until GTK DRT implements preference override.
10:26 QtWebKitJournal edited by ben@webkit.org
(diff)
09:58 Changeset [47038] by bweinstein@apple.com
  • 2 edits in trunk/WebKitTools

2009-08-11 Brian Weinstein <bweinstein@apple.com>

Reviewed by Sam Weinig.

Added support for DRT to support arguments for eventSender.mouseDown and eventSender.mouseUp for Windows.
https://bugs.webkit.org/show_bug.cgi?id=28166.

This is a step towards fixing fast/events/mouse-click-events.html on Windows.

  • DumpRenderTree/win/EventSender.cpp: (mouseDownCallback): (mouseUpCallback): (replaySavedEvents):
09:48 SuccessfulPortHowTo edited by eric@webkit.org
Added some recommended porting steps. (diff)
09:39 Changeset [47037] by jberlin@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-11 Jessie Berlin <jberlin@apple.com>

Fix windows build.


Reviewed by Adam Roben.

09:33 Changeset [47036] by atwilson@chromium.org
  • 18 edits
    1 copy in trunk/WebCore

Need to refactor WorkerObjectProxy.
https://bugs.webkit.org/show_bug.cgi?id=28136

Reviewed by David Levin.

Added WorkerReportingProxy for reporting worker state (exceptions, console messages, thread exited) to the parent.

Existing tests are sufficient, as this is only a refactoring.

  • GNUmakefile.am:

Added WorkerReportingProxy.h to build.

  • WebCore.gypi:

Added WorkerReportingProxy.h to build.

  • WebCore.vcproj/WebCore.vcproj:

Added WorkerReportingProxy.h to build.

  • WebCore.xcodeproj/project.pbxproj:

Added WorkerReportingProxy.h to build.

  • workers/DedicatedWorkerContext.cpp:
  • workers/DedicatedWorkerContext.h:

Removed addMessage/forwardException() APIs - now handled by WorkerReportingProxy.

  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
Changed constructor to pass WorkerReportingProxy to base class.

  • workers/DefaultSharedWorkerRepository.cpp:

Updated SharedWorkerProxy to implement WorkerReportingProxy interface.
(WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
(WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
(WebCore::SharedWorkerProxy::workerContextClosed):
(WebCore::SharedWorkerProxy::workerContextDestroyed):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
Now passes in WorkerReportingProxy when creating SharedWorkerThread.

  • workers/SharedWorkerContext.cpp:
  • workers/SharedWorkerContext.h:

Removed addMessage/forwardException() APIs - now handled by WorkerReportingProxy.

  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
Passes WorkerReportingProxy to base class constructor.

  • workers/SharedWorkerThread.h:

Constructor now takes a WorkerReportingProxy.

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::~WorkerContext):
Moved code that calls workerContextDestroyed() into base class so shared workers share this functionality.
(WebCore::WorkerContext::close):
Now notifies WorkerReportingProxy when the thread is closing.
(WebCore::WorkerContext::reportException):
Reports exceptions via WorkerReportingProxy.
(WebCore::WorkerContext::addMessage):
Reports console messages via WorkerReportingProxy.

  • workers/WorkerContext.h:
  • workers/WorkerObjectProxy.h:

(WebCore::WorkerObjectProxy::workerContextClosed):
Default empty implementation for dedicated workers.

  • workers/WorkerReportingProxy.h: Added.

Base interface that contains APIs moved from WorkerObjectProxy.
(WebCore::WorkerReportingProxy::~WorkerReportingProxy):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::WorkerThread):
Updated constructor to accept a WorkerReportingProxy.

  • workers/WorkerThread.h:

(WebCore::WorkerThread::workerReportingProxy):

08:39 Changeset [47035] by vestbo@webkit.org
  • 2 edits in trunk/JavaScriptCore

Buildfix for Qt-win platforms.

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-08-11
Reviewed by Tor Arne Vestbø.

  • JavaScriptCore.pri: Choose MarkStackPosix.cpp or MarkStackWin.cpp depend on platform.
08:16 Changeset [47034] by kenneth@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2009-08-11 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add results for fast/borders/border-radius-split-inline and remove from platform/qt/Skipped
Note: Results will wrap to 4 lines even though it indicates 3 lines. This is due to font
size differences in Qt, and matches the output of FireFox.

https://bugs.webkit.org/show_bug.cgi?id=28147

  • platform/qt/Skipped:
  • platform/qt/fast/borders/border-radius-split-inline-expected.txt: Added.
07:56 Changeset [47033] by vestbo@webkit.org
  • 4 edits in trunk

Build the TestNetscapePlugin on Qt/Mac

Reviewed by Simon Hausmann.

  • WebKit.pro:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
07:56 Changeset [47032] by vestbo@webkit.org
  • 3 edits in trunk/WebKitTools

Fix a bunch of build warnings in TestNetscapePlugin

Reviewed by Simon Hausmann.

  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
  • DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
03:37 Changeset [47031] by xan@webkit.org
  • 2 edits in trunk

2009-08-11 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

Prefix lengthy commands with AM_V_GEN so that they produce an
output like 'GEN <filename>' when in silent mode.

  • GNUmakefile.am:
02:40 Changeset [47030] by hausmann@webkit.org
  • 5 edits in trunk/WebCore

Fix the Qt build after r47022.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-11
Reviewed by NOBODY (build fix).

Use the new markChildren() pattern for marking aggregate/child objects.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObjectImp::markChildren):
(JSC::Bindings::QtInstance::markAggregate):

  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::markChildren):

  • bridge/qt/qt_runtime.h:
01:14 Changeset [47029] by dimich@chromium.org
  • 2 edits in trunk/WebKitTools

2009-08-11 Dmitry Titov <dimich@chromium.org>

Reviewed by NOBODY (build fix).

Attempt to fix the Windows test bot. Reverted r47015 caused one of the Windows
bots that runs Layout Tests to save "JS disabled" and "default font 24pt"
preferences permanently. Since these preferences are not initialized explicitly in DRT,
almost all Layout tests are failing. Attempt to fix by explicit
initialization of these into defaults (enabled, 16pt) at the beginning of the DRT.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main): see above.
00:26 Changeset [47028] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Fix the build on the Qt build bot by making the generated JS bindings
files depend on the code generator itself.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-11
Reviewed by Holger Freyther.

  • WebCore.pro:

08/10/09:

22:43 Changeset [47027] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Add new exports for MSVC

22:27 Changeset [47026] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Remove obsolete entries from MSVC exports file

22:18 Changeset [47025] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Add includes needed for non-allinonefile builds

22:15 Changeset [47024] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix export file for last build fix

22:07 Changeset [47023] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

Build fix

Hoist page size initialization into platform specific code.

21:35 Changeset [47022] by oliver@apple.com
  • 103 edits
    3 copies
    4 adds in trunk

Stack overflow crash in JavaScript garbage collector mark pass
https://bugs.webkit.org/show_bug.cgi?id=12216

Reviewed by Gavin Barraclough and Sam Weinig

Make the GC mark phase iterative by using an explicit mark stack.
To do this marking any single object is performed in multiple stages

  • The object is appended to the MarkStack, this sets the marked bit for the object using the new markDirect() function, and then returns
  • When the MarkStack is drain()ed the object is popped off the stack and markChildren(MarkStack&) is called on the object to collect all of its children. drain() then repeats until the stack is empty.

Additionally I renamed a number of methods from 'mark' to 'markAggregate'
in order to make it more clear that marking of those object was not
going to result in an actual recursive mark.

21:17 Changeset [47021] by jorlow@chromium.org
  • 7 edits in trunk/WebCore

2009-08-10 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Eric Seidel.

Renamed all V8 NPN_ functions to _NPN_ to match JSC and make them "private".
https://bugs.webkit.org/show_bug.cgi?id=28089

Rename all the NPN_foo functions to _NPN_foo so that they can't directly be
called by mistake. This roughly matches the way JSC does it, which is an
additional advantage.

  • bindings/v8/NPV8Object.cpp: (npCreateV8ScriptObject): (_NPN_Invoke): (_NPN_InvokeDefault): (_NPN_Evaluate): (_NPN_EvaluateHelper): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException): (_NPN_Enumerate): (_NPN_Construct):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::clearScriptObjects): (WebCore::ScriptController::createScriptInstanceForWidget): (WebCore::ScriptController::cleanupScriptObjectsForPlugin):
  • bindings/v8/V8NPObject.cpp: (npObjectInvokeImpl): (npObjectGetProperty): (npObjectIndexedPropertyGetter): (npObjectGetIndexedProperty): (npObjectSetProperty): (npObjectIndexedPropertySetter): (npObjectSetIndexedProperty): (weakNPObjectCallback): (createV8ObjectForNPObject): (forgetV8ObjectForNPObject):
  • bindings/v8/V8NPUtils.cpp: (getStringIdentifier):
  • bindings/v8/npruntime.cpp:
  • bindings/v8/npruntime_impl.h:
21:02 Changeset [47020] by jorlow@chromium.org
  • 16 edits in trunk

2009-08-10 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Brady Eidson.

Change _Storage.key() to match current spec behavior.
https://bugs.webkit.org/show_bug.cgi?id=28112

The current WebStorage spec says that _Storage.key() should return null when
the index is out of bounds, rather than an exception. A bunch of logic can be
simplified after this change.

  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::getPropertyNames):
  • bindings/v8/custom/V8StorageCustom.cpp: (WebCore::V8Custom::v8StorageNamedPropertyEnumerator):
  • storage/Storage.cpp: (WebCore::Storage::key):
  • storage/Storage.h:
  • storage/Storage.idl:
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::key):
  • storage/StorageAreaImpl.h:
  • storage/StorageMap.cpp: (WebCore::StorageMap::key):
  • storage/StorageMap.h:

2009-08-10 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Brady Eidson.

_Storage.key() changed to match new spec behavior; update layout tests.
https://bugs.webkit.org/show_bug.cgi?id=28112

The current WebStorage spec says that _Storage.key() should return null when
the index is out of bounds, rather than an exception. Change the one layout
test that verified this behavior.

  • storage/domstorage/localstorage/simple-usage-expected.txt:
  • storage/domstorage/localstorage/simple-usage.html:
  • storage/domstorage/sessionstorage/simple-usage-expected.txt:
  • storage/domstorage/sessionstorage/simple-usage.html:
20:59 Changeset [47019] by jorlow@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix silly change log bustage.

20:49 Changeset [47018] by jorlow@chromium.org
  • 4 edits in trunk/WebCore

2009-08-07 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=28087

Mods for a chrome specific impl of ApplicationCacheHost.

  • The public section of the interface is the same, but we use PLATFORM(CHROMIUM) to identify which parts of the private section are shared. The chrome specific internals are encapsulated in a seperate ApplicationCacheHostInternal class. WebCore common code only contains a forward reference to this class.
  • Cleanup a couple of stale comments.
  • Have window.applicationCache return null to script when the feature is disabled in the preferences.


No new tests.

  • loader/appcache/ApplicationCacheHost.cpp:
  • loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::documentLoader):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::applicationCache):

<<<<<<< .mine

19:55 Changeset [47017] by dimich@chromium.org
  • 19 edits
    6 deletes in trunk

Revert r47015 "Added support for overriding default preferences per-test."
https://bugs.webkit.org/show_bug.cgi?id=20534

Ir broke too many Windows tests and I don't have a simple fix right now.

19:53 Changeset [47016] by ben@webkit.org
  • 3 edits in trunk/WebCore

2009-08-10 Crystal Zhang <crystal.zhang@staikos.net>

Reviewed by George Staikos.

Implement GraphicsContext::fillRoundRect() for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27842

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::rectCenterPoint): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::drawRoundCorner):
19:18 Changeset [47015] by dimich@chromium.org
  • 19 edits
    7 adds in trunk

WebKit/mac: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added new methods for overriding default WebPreference values
and for resetting preferences to their defaults.
https://bugs.webkit.org/show_bug.cgi?id=20534

  • WebView/WebPreferences.mm:

(-[WebPreferences _setPreferenceForTestWithValue:withKey:]): added.

  • WebView/WebPreferencesPrivate.h: same.

WebKit/win: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added support for overriding default preferences per-test.
https://bugs.webkit.org/show_bug.cgi?id=20534

  • Interfaces/IWebPreferencesPrivate.idl: added new method setPreferenceForTest
  • WebPreferences.cpp: same.
  • WebPreferences.h: same.

WebKitTools: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added support for overriding default preferences per-test.
https://bugs.webkit.org/show_bug.cgi?id=20534

  • DumpRenderTree/LayoutTestController.cpp:

(overridePreferenceCallback): add wiring for layoutTestController.overridePreference.
(LayoutTestController::staticFunctions): same.

  • DumpRenderTree/LayoutTestController.h: same.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::overridePreference): added empty overridePreference method.

  • DumpRenderTree/mac/DumpRenderTree.mm: implemented preference override.

(resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
(setDefaultsToConsistentValuesForTesting): new method, sets other details of testing environment, every time DRT starts.
(resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::overridePreference):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
(resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().
(createWebViewAndOffscreenWindow): same.
(main): same.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::overridePreference):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::overridePreference):

LayoutTests: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added tests to verify that default preferences can be overridden per-test
and that overridden values are reset between each test.
https://bugs.webkit.org/show_bug.cgi?id=20534

  • fast/harness/override-preferences-2-expected.txt: Added.
  • fast/harness/override-preferences-2.html: Added. Verifies overridePreverence("WebKitDefaultFontSize", "24").
  • fast/harness/override-preferences-expected.txt: Added.
  • fast/harness/override-preferences.html: Added. Verifies overridePreference("WebKitJavaScriptEnabled", false).
  • fast/harness/override-zzz-reset-expected.txt: Added.
  • fast/harness/override-zzz-reset.html: Added. Because of 'zzz' this test will run after the tests above and

verify that override of preferences does not 'spill' to the subsequent tests in a batch.

  • platform/gtk/Skipped: Tests above disabled for GTK until GTK DRT implements preference override.
  • platform/qt/Skipped: same for QT.
18:11 Coding Style Guidelines edited by atwilson@chromium.org
(diff)
17:34 Changeset [47014] by mitz@apple.com
  • 2 edits in trunk/WebKit/win

Link drag images specify Lucida Grande on Windows and end up using Times
New Roman
<rdar://problem/7117835>

Reviewed by Darin Adler.

  • WebCoreSupport/WebDragClient.cpp:

(dragLabelFont): Added a RenderingMode parameter and changed to use the

same typeface as the Windows small caption font.

(WebDragClient::createDragImageForLink): Changed to respect the

page’s rendering mode.

17:15 Changeset [47013] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Windows nightly fix.

Reviewed by Ada Chan.

  • FindSafari/FindSafari.cpp:

(_tmain): Copy Safari.dll if it exists.

16:47 Changeset [47012] by pkasting@chromium.org
  • 2 edits in trunk/WebKitLibraries

https://bugs.webkit.org/show_bug.cgi?id=27323
Even more line ending-stripping for auto-version.sh, based on output
provided by Jessie Berlin.

Reviewed by George Staikos.

  • win/tools/scripts/auto-version.sh:
16:29 Changeset [47011] by rik@webkit.org
  • 5 edits in trunk/WebCore

Inspector Resources / Graphs should support filtering
https://bugs.webkit.org/show_bug.cgi?id=20629

Patch by Anthony Ricaud <rik@webkit.org> on 2009-08-10
Reviewed by Timothy Hatcher.

Introduces a filter bar for resources.

Thanks to Matt Lilek for the CSS scope bar.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.createFilterElement):
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.toolbarItemClass.categoryOrder.filter):
(WebInspector.ResourcesPanel.prototype._updateFilter):
(WebInspector.ResourcesPanel.prototype._updateSummaryGraph):

  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js:

(WebInspector.loaded):

16:17 Changeset [47010] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix hundreds of "pointer being freed was not allocated" errors seen on the build bot.

Reviewed by Darin Adler.

  • wtf/FastMalloc.h: Implement nothrow variants of the delete and delete[] operators since

we implement the nothrow variants of new and new[]. The nothrow variant of delete is called
explicitly in the implementation of std::sort which was resulting in FastMalloc-allocated
memory being passed to the system allocator to free.

15:37 Changeset [47009] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed build correction after http://trac.webkit.org/changeset/46978

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle): Correct

deprecated removeRef to new removeFragmentIdentifier.

15:27 Changeset [47008] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

WebCore: Background color formatting lost on enter
https://bugs.webkit.org/show_bug.cgi?id=20348

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.

This patch makes background color be preserved during editing.
In particular, editingStyleAtPosition would include the background color when obtaining styles.

  • editing/ApplyStyleCommand.cpp:

(WebCore::): Added CSSPropertyBackgroundColor to editingStyleProperties

LayoutTests: Background color formatting lost on enter
https://bugs.webkit.org/show_bug.cgi?id=20348

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.

This patch adds a test to make sure WebKit preserves background color when inserting a new paragraph.

  • editing/inserting/5994480-2-expected.txt: Because input element has explicit white background and the enclosing div has

transparent background, WebKit adds white background color in DeleteSelectionCommand::calculateTypingStyleAfterDelete upon deletion.

  • editing/style/highlight-insert-paragraph-expected.txt: Added.
  • editing/style/highlight-insert-paragraph.html: Added.
  • platform/mac/editing/pasteboard/select-element-1-expected.txt: Because select element has explicit white background color

and div has transparent background, WebKit adds white background color in calculateTypingStyleAfterDelete upon cut.

15:14 Changeset [47007] by zimmermann@webkit.org
  • 3 edits in trunk/LayoutTests

Rubber-stamped by George Staikos.
Forgot to update pixel test result in my last commit.

15:13 Changeset [47006] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-08-10 David Levin <levin@chromium.org>

Reviewed by David Kilzer.

check-webkit-style doesn't catch braces around single line statements when followed by else.
https://bugs.webkit.org/show_bug.cgi?id=28164

  • Scripts/modules/cpp_style.py: Added else to the regex that finds ending }'s when checking the no braces for "single lines" rule.
  • Scripts/modules/cpp_style_unittest.py: Added test case.
14:53 Changeset [47005] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

<http://webkit.org/b/28163> bugzilla-tool: scm module should not import bugzilla module

Reviewed by David Levin.

  • Scripts/bugzilla-tool: (parse_bug_id): Added. Moved from CommitMessage.parse_bug_id() in scm module.
  • Scripts/modules/scm.py: Removed import of bugzilla module. (CommitMessage.parse_bug_id): Deleted.
14:17 Changeset [47004] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Stop sending QEvent::CursorChange to Qt for mouse move.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-08-10
Reviewed by Simon Hausmann.

Verify if the cursor didn't change in WidgetQt::setCursor,
just like the mac port does.

Thanks to Adriano Rezendo for spotting and debugging the
issue.

  • platform/qt/WidgetQt.cpp:

(WebCore::Widget::setCursor):

14:04 Changeset [47003] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-10 Jan Michael Alonzo <jmalonzo@webkit.org>

[Gtk] Unreviewed build fix. Move JSAPIValueWrapper.cpp/.h in the debug
section. This file is already part of AllInOneFile in Release builds.

  • GNUmakefile.am:
13:58 BuildingOnWindows edited by jberlin@apple.com
Add information about not being able to find debugging symbols (diff)
13:51 Changeset [47002] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=28165
Application cache maximum size cannot be set before the database is opened

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::vacuumDatabaseFile): Open appcache database if it isn't open yet.
13:37 Changeset [47001] by dglazkov@chromium.org
  • 11 edits in trunk/WebCore

2009-08-10 Vitaly Repeshko <vitalyr@quad.spb.corp.google.com>

Reviewed by Dimitri Glazkov.

[V8] Fix memory leak in node event listeners. See http://crbug.com/17400.
https://bugs.webkit.org/show_bug.cgi?id=28156

  • bindings/scripts/CodeGeneratorV8.pm: Custom event handler accessors now apply to all Node descendants.
  • bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::isObjectListener): Added virtual method to detect listeners that have weak references to JS objects.
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
  • bindings/v8/V8ObjectEventListener.cpp:
  • bindings/v8/V8ObjectEventListener.h: (WebCore::V8ObjectEventListener::isObjectListener):
  • bindings/v8/V8Utilities.cpp: (WebCore::removeHiddenDependency):
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8NodeCustom.cpp: Moved custom accessors from V8ElementCustom.cpp. (WebCore::toEventType): (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::getEventListener): Made static.
12:46 Changeset [47000] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore
  • wtf/FastMalloc.h: Fix build.
12:42 Changeset [46999] by darin@apple.com
  • 3 edits in trunk/JavaScriptCore

FastMalloc.h has cross-platform code but marked as WinCE-only
https://bugs.webkit.org/show_bug.cgi?id=28160

Patch by Darin Adler <darin@apple.com> on 2009-08-10
Reviewed by Mark Rowe.

1) The support for nothrow was inside #if PLATFORM(WINCE) even though it is

not platform-specific.

2) The code tried to override operator delete nothrow, which does not exist.
3) The code in the header checks the value of USE_SYSTEM_MALLOC, but the code

in FastMalloc.cpp checks only if the macro is defined.

  • wtf/FastMalloc.h: See above.
  • wtf/FastMalloc.cpp: Ditto.
12:37 Changeset [46998] by jorlow@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix date in ChangeLog

12:34 Changeset [46997] by jorlow@chromium.org
  • 5 edits in trunk/WebCore

2009-08-08 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Cleanup DOM Storage namespace shutdown code + usage of security origin.
https://bugs.webkit.org/show_bug.cgi?id=28094

If a storage namespace is not explicitly closed, be sure to do so on
destruction of the object. In addition, the close call should wait
on the background thread finishing its syncing. (Not doing so is actually
a regression from the original LocalStorage code.)

There's no point to passing in the SecurityOrigin when copying a storage
area since what was passed in is exactly what is stored within each
storage area. In addition, the non-copy constructor should take in a
PassRefPtr rather than a pointer since that pointer was only passed into
the constuctor for RefPtr's anyway.

  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::copy):
  • storage/StorageAreaImpl.h:
  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::~StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::close):
  • storage/StorageNamespaceImpl.h:
12:30 Changeset [46996] by zimmermann@webkit.org
  • 4 edits in trunk/WebCore

Not reviewed, build fix.
Rename ref() to fragmentIdentifier() in the wml/ subdirectory.

12:15 Changeset [46995] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

Exclude JSMedia.cpp from build since it is included in DerivedSources.cpp.
Fixes linker warnings.

Corrected spelling of JSInspectorBackend.cpp.

Other changes related to actually using a Visual Studio to open/save the vcproj file.

  • WebCore.vcproj/WebCore.vcproj:
11:39 Changeset [46994] by weinig@apple.com
  • 2 edits in trunk/WebCore

Remove a dead #define.

Reviewed by Anders Carlsson.

  • bindings/js/JSDOMBinding.cpp:
11:36 Changeset [46993] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-08-10 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[Chromium] Update KURLGoogle for ref* method renames in
http://trac.webkit.org/changeset/46978.
https://bugs.webkit.org/show_bug.cgi?id=28084

  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_SETTER): Renamed ref and setRef to fragmentIdentifier and

setFragmentIdentifier, respectively.

  • platform/KURLGoogle.cpp: Ditto, plus all other ref* method names.
11:30 Changeset [46992] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix an annoying indentation issue.

Reviewed by Anders Carlsson.

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

11:26 Changeset [46991] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

[Gtk] Unreviewed. Fix the nit as suggested by Darin in bug #28144 for r46989.

11:22 Changeset [46990] by bfulgham@webkit.org
  • 4 edits
    1 add in trunk

WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=28048.
Move various WinCairo build settings into *.vsprops file.

Reviewed by Adam Roben.

  • WebKit.vcproj/WebKit.vcproj: Add new cURL.vsprops property sheet (which contains link settings for cURL and its dependencies), and remove the corresponding entries from the vcproj file. Remove png, jpeg, cairo library linking flags from vcproj, now that they are in the WinCairo.vsprops file.

WebKitLibraries: https://bugs.webkit.org/show_bug.cgi?id=28048.
Move various WinCairo build settings into *.vsprops file.

Reviewed by Adam Roben.

  • win/tools/vsprops/cURL.vsprops: Added.
11:20 Changeset [46989] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-08-10 John Kjellberg <john.kjellberg@power.alstom.com>

Reviewed by Darin Adler.

Memory leak in error handling code for SOUP interface
https://bugs.webkit.org/show_bug.cgi?id=28144

Freed memory leaked in error handling code for soup requests.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::finishedCallback): (WebCore::):
11:18 Changeset [46988] by pkasting@chromium.org
  • 2 edits in trunk/WebKitTools

https://bugs.webkit.org/show_bug.cgi?id=18599
Work around apparent bug in abs2rel() with symlinked directories.

Reviewed by David Kilzer.

  • Scripts/resolve-ChangeLogs:
11:10 Changeset [46987] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-08-10 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Provide graceful handling of the situation when an embedder invokes
visited link update methods before a Page constructor has been called.
https://bugs.webkit.org/show_bug.cgi?id=28149

  • page/Page.cpp: (WebCore::Page::allVisitedStateChanged): Added a null-check for allPages. (WebCore::Page::visitedStateChanged): Ditto.
11:03 Changeset [46986] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-08-10 Xan Lopez <xlopez@igalia.com>

Fix GTK+ build.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
10:56 Changeset [46985] by mitz@apple.com
  • 3 edits in trunk/WebCore

Remove the redundant, Windows CE-only GlyphBuffer::advnaceData()

Reviewed by Anders Carlsson.

  • platform/graphics/GlyphBuffer.h: Removed advanceData().
  • platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::drawText): Changed to use advances(from)

instead of advanceData() + from.

10:37 Changeset [46984] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-08-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Remove workaround for older libsoup versions.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
10:37 Changeset [46983] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-08-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Let startHttp validate the URI instead of doing it, with potential
crashes, in ::start.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp):
10:28 Changeset [46982] by darin@apple.com
  • 6 edits
    3 adds in trunk

WebCore: When empty <input> is focused, getSelection() exposes shadow tree nodes
https://bugs.webkit.org/show_bug.cgi?id=15903

Patch by Darin Adler <darin@apple.com> on 2009-08-10
Reviewed by Dan Bernstein.

Test: fast/forms/shadow-tree-exposure.html

  • page/DOMSelection.cpp:

(WebCore::selectionShadowAncestor): Added.
(WebCore::DOMSelection::anchorNode): Return the parent of the shadow
ancestor if the selection is in a shadow tree. Matches Firefox.
(WebCore::DOMSelection::anchorOffset): Return the index of the shadow
ancestor if the selection is in a shadow tree. Matches Firefox.
(WebCore::DOMSelection::focusNode): Ditto.
(WebCore::DOMSelection::focusOffset): Ditto.
(WebCore::DOMSelection::baseNode): More of the same, but since this
is a WebKit-invented property, it does not match Firefox.
(WebCore::DOMSelection::baseOffset): Ditto.
(WebCore::DOMSelection::extentNode): Ditto.
(WebCore::DOMSelection::extentOffset): Ditto.
(WebCore::DOMSelection::isCollapsed): Return true even when the
selection is a range, if the selection is in the shadow tree.
Matches Firefox. Also changed behavior when called and the frame
is gone to return true instead of false which makes more sense.
(WebCore::DOMSelection::empty): Use clear() just like the other
selection-clearing function in this file does.
(WebCore::DOMSelection::getRangeAt): Return a range that starts
and ends before the shadow ancestor. Matches Firefox.

LayoutTests: When empty <input> is focused, getSelection() exposes shadow tree nodes
https://bugs.webkit.org/show_bug.cgi?id=15903

Patch by Darin Adler <darin@apple.com> on 2009-08-07
Reviewed by Dan Bernstein.

Also updated a recently introduced non-standard test to work in a more
standard way.

  • fast/forms/resources/shadow-tree-exposure.js: Added.
  • fast/forms/shadow-tree-exposure-expected.txt: Added.
  • fast/forms/shadow-tree-exposure.html: Added.
  • fast/js/method-check-expected.txt: Updated.
  • fast/js/method-check.html: Regenerated using the make-js-test-wrappers script.
  • fast/js/resources/method-check.js: Replaced a comment talking about the lack

of a gc() function with a call to GCController.collect(). Also removed the
shouldBeTrue call at the end of the fiel that wasn't needed.

10:25 Changeset [46981] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Build fix

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:

(NPP_New):

10:07 Changeset [46980] by beidson@apple.com
  • 2 edits in trunk/WebKit/gtk

GTK build fix.

  • webkit/webkitdownload.cpp:

(webkit_download_get_suggested_filename):

09:53 Changeset [46979] by pfeldman@chromium.org
  • 10 edits
    15 adds
    12 deletes in trunk/WebCore

2009-08-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Make all status bar button images glyph-based.

https://bugs.webkit.org/show_bug.cgi?id=28124

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
  • inspector/front-end/Images/clearConsoleButtonGlyph.png: Added.
  • inspector/front-end/Images/clearConsoleButtons.png: Removed.
  • inspector/front-end/Images/consoleButtonGlyph.png: Added.
  • inspector/front-end/Images/consoleButtons.png: Removed.
  • inspector/front-end/Images/dockButtonGlyph.png: Added.
  • inspector/front-end/Images/dockButtons.png: Removed.
  • inspector/front-end/Images/enableButtons.png: Removed.
  • inspector/front-end/Images/enableOutlineButtonGlyph.png: Added.
  • inspector/front-end/Images/enableSolidButtonGlyph.png: Added.
  • inspector/front-end/Images/excludeButtonGlyph.png: Added.
  • inspector/front-end/Images/excludeButtons.png: Removed.
  • inspector/front-end/Images/focusButtonGlyph.png: Added.
  • inspector/front-end/Images/focusButtons.png: Removed.
  • inspector/front-end/Images/largerResourcesButtonGlyph.png: Added.
  • inspector/front-end/Images/largerResourcesButtons.png: Removed.
  • inspector/front-end/Images/nodeSearchButtonGlyph.png: Added.
  • inspector/front-end/Images/nodeSearchButtons.png: Removed.
  • inspector/front-end/Images/pauseOnExceptionButtonGlyph.png: Added.
  • inspector/front-end/Images/pauseOnExceptionButtons.png: Removed.
  • inspector/front-end/Images/percentButtonGlyph.png: Added.
  • inspector/front-end/Images/percentButtons.png: Removed.
  • inspector/front-end/Images/recordButtonGlyph.png: Added.
  • inspector/front-end/Images/recordButtons.png: Removed.
  • inspector/front-end/Images/recordToggledButtonGlyph.png: Added.
  • inspector/front-end/Images/reloadButtonGlyph.png: Added.
  • inspector/front-end/Images/reloadButtons.png: Removed.
  • inspector/front-end/Images/undockButtonGlyph.png: Added.
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.createStatusBarButton):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
09:49 QtWebKitFeatures46 edited by kenneth@webkit.org
(diff)
09:35 Changeset [46978] by beidson@apple.com
  • 19 edits in trunk/WebCore

KURL ref() methods should be fragmentIdentifier() methods
https://bugs.webkit.org/show_bug.cgi?id=28084

Reviewed by Darin Adler.

In addition to the renames, also took the chance to replace all use of:
setRef(String());
with:
removeFragmentIdentifier();

  • platform/KURL.cpp:

(WebCore::KURL::fragmentIdentifier):
(WebCore::KURL::hasFragmentIdentifier):
(WebCore::KURL::setFragmentIdentifier):
(WebCore::KURL::removeFragmentIdentifier):
(WebCore::KURL::prettyURL):
(WebCore::equalIgnoringFragmentIdentifier):

  • platform/KURL.h:
  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::setHash): Rework with new names, and to use the new equalIgnoringNullity() method.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::internalLinkElement):

  • css/CSSCursorImageValue.cpp:

(WebCore::isSVGCursorIdentifier):

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::isCurrentDocument):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::hash):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isURLAllowed):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::begin):
(WebCore::FrameLoader::gotoAnchor):
(WebCore::FrameLoader::scheduleLocationChange):
(WebCore::FrameLoader::scrollToAnchor):
(WebCore::FrameLoader::shouldReload):
(WebCore::FrameLoader::urlsMatchItem):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::resourceForURL):
(WebCore::ApplicationCache::resourceForRequest):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::cacheForMainRequest):
(WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest):
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::finishedLoadingMainResource):
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFail):
(WebCore::ApplicationCacheGroup::addEntry):

  • loader/appcache/ApplicationCacheResource.h:

(WebCore::ApplicationCacheResource::create):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):

  • loader/appcache/ManifestParser.cpp:

(WebCore::parseManifest):

  • page/Location.cpp:

(WebCore::Location::hash):

  • page/Page.cpp:

(WebCore::Page::goToItem):

  • rendering/RenderPartObject.cpp:

(WebCore::isURLAllowed):

  • workers/WorkerLocation.cpp:

(WebCore::WorkerLocation::hash):

09:19 Changeset [46977] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Adam Roben.

Allow TestNetscapePlugIn to fall back to the Carbon event model

Previously the plugin would fail, even though the Carbon event
model was available. The only way to get the Carbon event model
was to pass the "forcecarbon" argument in the test markup, but no
tests were using this.

Now the plugin uses carbon either if it's forced, or if the Cocoa
event model is not supported.

This helps us run most of the plugin tests on Qt/Mac, which still
does not support the Cocoa event model.

08:45 QtWebKitFeatures46 edited by ben@webkit.org
(diff)
08:27 QtWebKitJournal edited by hausmann@webkit.org
(diff)
08:26 QtWebKitFeatures46 created by hausmann@webkit.org
08:22 QtWebKitJournal edited by hausmann@webkit.org
(diff)
08:07 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:51 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:47 Changeset [46976] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-10 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Add new files to makefile.

  • GNUmakefile.am:
07:29 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:10 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:05 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:39 Changeset [46975] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

Various fixes and improvements to the QWebPluginInfo, QWebPluginDatabase and QWebSettings documentation.

Patch by Kavindra Palaraja <kavindra.palaraja@nokia.com> on 2009-08-10
Reviewed by Simon Hausmann.

  • Api/qwebplugindatabase.cpp:
  • Api/qwebsettings.cpp:
05:49 QtWebKit edited by hausmann@webkit.org
(diff)
05:46 Changeset [46974] by hausmann@webkit.org
  • 12 edits
    1 add in trunk/LayoutTests

[Qt] After ChangeSet https://bugs.webkit.org/show_bug.cgi?id=26896, the
DefaultFontSize was changed in Qt DumpRenderTree from 14 to 13. But
any expected file works with the original value. The expected values
should follow this change. This patch contains the new expected
files.

Patch by Renata Hodovan <hodovan.renata@stud.u-szeged.hu> on 2009-08-10
Reviewed by Simon Hausmann.

  • platform/qt/Skipped:
  • platform/qt/editing/pasteboard/5780697-2-expected.txt: Add.
  • platform/qt/fast/block/float/009-expected.txt:
  • platform/qt/fast/dynamic/genContentDestroyChildren-expected.txt:
  • platform/qt/fast/images/image-in-map-expected.txt:
  • platform/qt/fast/inline-block/004-expected.txt:
  • platform/qt/fast/inline-block/005-expected.txt:
  • platform/qt/fast/table/giantRowspan-expected.txt:
  • platform/qt/fast/table/height-percent-test-expected.txt:
  • platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug50695-2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
05:36 Changeset [46973] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Fix endless loop when the application is quit by a secondary thread during a sync xml http request.

Patch by Andy Shaw <andy.shaw@nokia.com> on 2009-08-10
Reviewed by Simon Hausmann.

Replace the m_finished state variable and the call to QCoreApplication::processEvents() with
a dedicated QEventLoop, that can be terminated from within WebCoreSynchronousLoader as well
as from Qt through its knowledge of globally registered eventloops.

There is no unit test for this bug as it would require exporting additional symbols and
introduce the synchronous loader as global variable just for the test.

  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::WebCoreSynchronousLoader::waitForCompletion):

03:02 Changeset [46972] by pfeldman@chromium.org
  • 10 edits
    1 add in trunk/WebCore

2009-08-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Make properties inspection serialized.

https://bugs.webkit.org/show_bug.cgi?id=28078

  • inspector/front-end/DOMAgent.js: (InspectorController.getPrototypes): (InspectorController.getProperties):
  • inspector/front-end/InjectedScript.js: (InjectedScript.getPrototypes): (InjectedScript.getProperties): (InjectedScript.setPropertyValue):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectRef): (WebInspector.ObjectPropertyRef): (WebInspector.ObjectPropertiesSection.prototype.onpopulate): (WebInspector.ObjectPropertiesSection.prototype.update.callback): (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertiesSection.prototype._update): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.onattach): (WebInspector.ObjectPropertyTreeElement.prototype.update):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback): (WebInspector.PropertiesSidebarPane.prototype.update):
01:16 Changeset [46971] by hausmann@webkit.org
  • 2 edits in trunk/LayoutTests

Rebase Qt letter spacing DRT result after r46936

Reviewed by Ariya Hidayat.

  • platform/qt/fast/text/text-letter-spacing-expected.txt:
01:01 Changeset [46970] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

Fix compilation with the interpreter instead of the JIT by including
PrototypeFunction.h as forward-declared through NativeFunctionWrapper.h.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-10

  • runtime/ObjectConstructor.cpp:

08/09/09:

17:47 Changeset [46969] by zimmermann@webkit.org
  • 5 edits in trunk

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] wml.css lacks <pre> support
https://bugs.webkit.org/show_bug.cgi?id=28135

Add <pre> support for WML.
Extended fast/wml/text-emphasis.wml to cover <pre> support.

  • css/wml.css: <pre> section copied from html.css

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] wml.css lacks <pre> support
https://bugs.webkit.org/show_bug.cgi?id=28135

Extend fast/wml/text-emphasis.wml test, to cover <pre> formatting.

  • fast/wml/text-emphasis.wml:
  • platform/mac/fast/wml/text-emphasis-expected.txt:
17:01 Changeset [46968] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.
Fix non-WML enabled builds. Remove ENABLE(WML) guards around the switch cases 'FrameLoadTypeBackWMLDeckNotAccessible'.

16:55 Changeset [46967] by oliver@apple.com
  • 4 edits
    3 adds in trunk

JSON.stringify replacer returning undefined does not omit object properties
https://bugs.webkit.org/show_bug.cgi?id=28118

Reviewed by George Staikos

Correct behaviour of stringify when using a replacer function that returns
undefined. This is a simple change to move the undefined value check to
after the replacer function is called. This means that the replacer function
is now called for properties with the value undefined, however i've confirmed
that this behaviour is correct.

In addition I've made the cyclic object exception have a more useful error
message.

16:33 Changeset [46966] by zimmermann@webkit.org
  • 21 edits
    24 adds in trunk

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'.

  • WebView/WebFramePrivate.h:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'.

  • Interfaces/IWebFramePrivate.idl:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Rewrite WML deck access control, actually works now standalone and within LayoutTests.
Added several new layout tests covering local & remote access support.

In order to detect WML task execution failures from within the WML layout tests a new
method Console::lastWMLErrorMessage() has been added, returning the last recorded WML
error message. Change WML log messages to dump to InspectorClient, just like it's done
for HTML - we used to behave like JSMessageSource, which is wrong.

Tests: http/tests/wml/access-target-domain-deny.html

http/tests/wml/access-target-path-deny.html
http/tests/wml/access-target.html
wml/access-target-deny.html
wml/access-target.html

  • inspector/ConsoleMessage.h: (WebCore::ConsoleMessage::source): Added public method to fetch the message source type. (WebCore::ConsoleMessage::message): Added public method to access the error message.
  • inspector/InspectorController.h: (WebCore::InspectorController::consoleMessages): Added for Console::lastWMLErrorMessage(), to be able to crawl through the list of dumped messages.
  • loader/FrameLoader.cpp: Recognize 'FrameLoadTypeBackWMLDeckNotAccessible', all guarded by ENABLE(WML). (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::loadItem):
  • loader/FrameLoaderTypes.h: (WebCore::): Add new load type 'FrameLoadTypeBackWMLDeckNotAccessible', behaving like FrameLoadTypeBack plus WML specific information.
  • page/Console.cpp: (WebCore::Console::addMessage): Don't dump WML messages using ChromeClient (as it's done for JSMessageSource), but go through InspectorController. (WebCore::Console::lastWMLErrorMessage): Crawl InspectorController::consoleMssages() to look up the last WML error message, if present.
  • page/Console.h:
  • page/Console.idl: Add "[DontEnum] DOMString lastWMLErrorMessage()".
  • wml/WMLAccessElement.cpp: Store path/domain as member variables and pass them to WMLPageState once in insertedIntoDocument(). (WebCore::WMLAccessElement::parseMappedAttribute): (WebCore::WMLAccessElement::insertedIntoDocument):
  • wml/WMLAccessElement.h:
  • wml/WMLCardElement.cpp: Handle 'FrameLoadTypeBackWMLDeckNotAccessible' as deck-entry method. Report WML error in current deck. (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
  • wml/WMLDocument.cpp: Enable deck-access control in finishedParsing. Take care of method name changes in WMLPageState. (WebCore::WMLDocument::finishedParsing): (WebCore::WMLDocument::initialize):
  • wml/WMLErrorHandling.cpp: Never report 'WMLErrorDeckNotAccessible' messages through the tokenizer, that would alter the page into error state. (WebCore::reportWMLError):
  • wml/WMLPageState.cpp: Completly rewrote access path/domain parsing & deck-access control, strictly following the WML spec. All covered by tests. (WebCore::WMLPageState::WMLPageState): (WebCore::normalizedHostName): (WebCore::hostFromURL): (WebCore::urlForHistoryItem): (WebCore::tryAccessHistoryURLs): (WebCore::WMLPageState::processAccessControlData): (WebCore::WMLPageState::resetAccessControlData): (WebCore::WMLPageState::canAccessDeck): (WebCore::WMLPageState::hostIsAllowedToAccess): (WebCore::WMLPageState::pathIsAllowedToAccess):
  • wml/WMLPageState.h:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Add several new tests covering WML deck-access control.
Update variable-reference-invalid-character.html result, as console messages aren't dump to the results anymore.

  • http/tests/wml/access-target-domain-deny-expected.txt: Added.
  • http/tests/wml/access-target-domain-deny.html: Added.
  • http/tests/wml/access-target-expected.txt: Added.
  • http/tests/wml/access-target-path-deny-expected.txt: Added.
  • http/tests/wml/access-target-path-deny.html: Added.
  • http/tests/wml/access-target.html: Added.
  • http/tests/wml/resources/access-target-domain-deny.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • http/tests/wml/resources/access-target-domain-deny.wml: Added.
  • http/tests/wml/resources/access-target-path-deny.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • http/tests/wml/resources/access-target-path-deny.wml: Added.
  • http/tests/wml/resources/access-target.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • http/tests/wml/resources/access-target.wml: Added.
  • http/tests/wml/resources/locked-deck.wml: Added.
  • http/tests/wml/resources/unreachable-domain.wml: Added.
  • http/tests/wml/resources/unreachable-path.wml: Added.
  • wml/access-target-deny-expected.txt: Added.
  • wml/access-target-deny.html: Added.
  • wml/access-target-expected.txt: Added.
  • wml/access-target.html: Added.
  • wml/resources/access-target-deny.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/access-target-deny.wml: Added.
  • wml/resources/access-target.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/access-target.wml: Added.
  • wml/resources/locked-deck.wml: Added.
  • wml/variable-reference-invalid-character-expected.txt:
15:04 Changeset [46965] by zimmermann@webkit.org
  • 4 edits in trunk

Reviewed by Maciej Stachowiak.

FrameLoadType / WebFrameLoadType enums are out of sync
https://bugs.webkit.org/show_bug.cgi?id=28132

Modify FrameLoadType enum to match the order of WebFrameLoadType in WebFramePrivate.h / IWebFramePrivate.idl.
The mac/win public API exposes the old 'FrameLoadTypeReloadAllowingStaleData' value, which resides between
'FrameLoadTypeReload' and 'FrameLoadTypeSame'. Work around this problem, by assigning 'FrameLoadTypeSame = FrameLoadTypeReload + 2'.

Add a note to the FrameLoadType enum to keep it in sync with WebFramePrivate.h & IWebFramePrivate.idl.

08:41 Changeset [46964] by zimmermann@webkit.org
  • 25 edits in trunk

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] manual-tests/wml/onevent-prev.wml crashes
https://bugs.webkit.org/show_bug.cgi?id=27722

Fix intrinsic event execution, leading to crashes.
First finish parsing the document, then execute the events. Not the other way round.
-> exposes bugs all over the WML layout tests, which relied on that quirk.

Fixes manual-tests/wml/onevent-prev.wml.

  • wml/WMLDocument.cpp: (WebCore::WMLDocument::WMLDocument): (WebCore::WMLDocument::finishedParsing): (WebCore::WMLDocument::initialize):
  • wml/WMLDocument.h:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] manual-tests/wml/onevent-prev.wml crashes
https://bugs.webkit.org/show_bug.cgi?id=27722

Reorganize WML testcases to not rely on the fact that intrinsic events are executed before the document finished parsing.

  • http/tests/wml/resources/go-task-get-method-accept-charset.js:
  • http/tests/wml/resources/go-task-get-method.js:
  • http/tests/wml/resources/go-task-post-method-accept-charset.js:
  • http/tests/wml/resources/go-task-post-method.js:
  • http/tests/wml/resources/post-data-to-server.js:
  • wml/resources/WMLTestCase.js: (onloadHandler): (createStaticWMLTestCase): (createDynamicWMLTestCase): (createWMLTestCase.iframeElement.onload): (createWMLTestCase):
  • wml/resources/enter-card-with-events.js: (executeTest):
  • wml/resources/enter-first-card-with-events.js: (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/go-task-get-method-external-deck-with-href.js:
  • wml/resources/go-task-get-method-external-deck.js:
  • wml/resources/go-task-get-method-same-deck.js:
  • wml/resources/input-format.js:
  • wml/resources/newcontext-same-deck.js: (setupTestDocument): (executeTest):
  • wml/resources/onenterforward-event.js: (executeTest):
  • wml/resources/onenterforward-inline-event.js:
  • wml/resources/ontimer-event.js: (executeTest):
  • wml/resources/ontimer-inline-event.js: (executeTest):
  • wml/resources/option-element-onpick.js:
  • wml/resources/select-element-variables.js:
  • wml/resources/variable-reference-invalid-character.js:
  • wml/resources/variable-reference-valid.js:
03:33 Changeset [46963] by oliver@apple.com
  • 8 edits in trunk

[ES5] Implement Object.getPrototypeOf
https://bugs.webkit.org/show_bug.cgi?id=28114

Reviewed by Eric Seidel and Sam Weinig.

Implement getPrototypeOf

08/08/09:

18:36 Changeset [46962] by dglazkov@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Updated ChangeLog with bug URLs.

18:31 Changeset [46961] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-08-08 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[Chromium] Update WebCore.gyp to add ImageBuffer.cpp,
introduced by http://trac.webkit.org/changeset/46956.

  • WebCore.gypi: Added ImageBuffer.cpp.
16:28 Changeset [46960] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org>

[Gtk] Skip media/controls-right-click-on-timebar.html as it needs
eventSender which we don't have at the moment.

  • platform/gtk/Skipped:
15:39 Changeset [46959] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

Rubber-stamped by Jan Michael Alonzo.

Add [DontEnum] to WML specific initializeWMLPageState/resetWMLPageState methods, to assure
fast/dom/Window/window-properties.html doesn't show any differences when WML is enabled.

13:34 Changeset [46958] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-08-08 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVG Filter need feColorMatrix implementation
https://bugs.webkit.org/show_bug.cgi?id=27711

Adds the filter effect feColorMatrix to SVG filters.

There is already a test in the w3c directory.
Test: svg/W3C-SVG-1.1/filters-color-01-b.svg

  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::matrix): (WebCore::saturate): (WebCore::huerotate): (WebCore::luminance): (WebCore::FEColorMatrix::apply):
12:32 Changeset [46957] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-08-08 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Build fix for Tiger.

  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):
12:11 Changeset [46956] by krit@webkit.org
  • 27 edits
    1 add in trunk/WebCore

2009-08-08 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

This is an initial implementation for linearRGB and sRGB support for all
platforms. Some platforms like Cg support different color spaces
natively, others like Qt, Cairo and Skia do not. This patch uses the
native implementation of platforms if possible and offers a common version
if not.

Different color spaces are used in SVG Filters. Nearly every Filter test
case is a test for this patch and will be enabled, once Filters are enabled.

  • GNUmakefile.am:
  • WebCore.pro:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
  • platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
  • platform/graphics/ImageBuffer.cpp: Added. (WebCore::ImageBuffer::transformColorSpace):
  • platform/graphics/ImageBuffer.h: (WebCore::): (WebCore::ImageBuffer::create):
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::platformTransformColorSpace):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::getEffectContext):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::platformTransformColorSpace):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains): (WebCore::Path::strokeBoundingRect):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::platformTransformColorSpace):
  • platform/graphics/skia/SkiaUtils.cpp: (WebCore::scratchContext):
  • platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
  • svg/graphics/SVGPaintServerGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient):
  • svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
  • svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
10:13 Changeset [46955] by xan@webkit.org
  • 2 edits
    3 deletes in trunk

WebCore:

2009-08-08 Xan Lopez <xlopez@igalia.com>

Roll out r46928, since it wasn't done in accordance with the
agreed naming.

  • bindings/gdom/GdomDOMObject.cpp: Removed.

WebKit/gtk:

2009-08-08 Xan Lopez <xlopez@igalia.com>

Roll out r46928, since it wasn't done in accordance with the
agreed naming.

  • ChangeLog:

Remove the ChangeLog entry, since it was added at the bottom of
the file.

  • gdom/GdomDOMObject.h: Removed.
  • gdom/GdomDOMObjectPrivate.h: Removed.
09:01 Changeset [46954] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool needs a --quiet option
https://bugs.webkit.org/show_bug.cgi?id=28060

A first pass at a --quiet option. This doesn't do all the excting
things we might want, but it addresses 80% of the use case.

  • Scripts/bugzilla-tool:
02:29 Changeset [46953] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Doc: there is no group of explicitly shared classes, only one class uses this.

Patch by Volker Hilsheimer <volker.hilsheimer@nokia.com> on 2009-08-08
Reviewed by Simon Hausmann.

Explain the implications in the QWebHistoryItem documentation, and get rid
of the "group".

  • Api/qwebhistory.cpp:
00:39 Changeset [46952] by jmalonzo@webkit.org
  • 12 edits
    2 adds in trunk

2009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Enable accessibility in Gtk DRT
https://bugs.webkit.org/show_bug.cgi?id=25989

Add SPI to get the focused accessible element to be used by DRT.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_focused_element):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.h:
  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_focused_accessible_element):

Remove passing accessibility tests from the Skipped list

  • platform/gtk/Skipped:

Add Accessibility support to the GTK DRT.

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Added. (AccessibilityController::AccessibilityController): (AccessibilityController::~AccessibilityController): (AccessibilityController::focusedElement): (AccessibilityController::rootElement):
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Added. (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::~AccessibilityUIElement): (AccessibilityUIElement::getLinkedUIElements): (AccessibilityUIElement::getDocumentLinks): (AccessibilityUIElement::getChildren): (AccessibilityUIElement::getChildrenWithRange): (AccessibilityUIElement::childrenCount): (AccessibilityUIElement::elementAtPoint): (AccessibilityUIElement::getChildAtIndex): (AccessibilityUIElement::allAttributes): (AccessibilityUIElement::attributesOfLinkedUIElements): (AccessibilityUIElement::attributesOfDocumentLinks): (AccessibilityUIElement::titleUIElement): (AccessibilityUIElement::parentElement): (AccessibilityUIElement::attributesOfChildren): (AccessibilityUIElement::parameterizedAttributeNames): (AccessibilityUIElement::role): (AccessibilityUIElement::title): (AccessibilityUIElement::description): (AccessibilityUIElement::language): (AccessibilityUIElement::x): (AccessibilityUIElement::y): (AccessibilityUIElement::width): (AccessibilityUIElement::height): (AccessibilityUIElement::clickPointX): (AccessibilityUIElement::clickPointY): (AccessibilityUIElement::intValue): (AccessibilityUIElement::minValue): (AccessibilityUIElement::maxValue): (AccessibilityUIElement::valueDescription): (AccessibilityUIElement::isEnabled): (AccessibilityUIElement::insertionPointLineNumber): (AccessibilityUIElement::isActionSupported): (AccessibilityUIElement::isRequired): (AccessibilityUIElement::attributesOfColumnHeaders): (AccessibilityUIElement::attributesOfRowHeaders): (AccessibilityUIElement::attributesOfColumns): (AccessibilityUIElement::attributesOfRows): (AccessibilityUIElement::attributesOfVisibleCells): (AccessibilityUIElement::attributesOfHeader): (AccessibilityUIElement::indexInTable): (AccessibilityUIElement::rowIndexRange): (AccessibilityUIElement::columnIndexRange): (AccessibilityUIElement::lineForIndex): (AccessibilityUIElement::boundsForRange): (AccessibilityUIElement::cellForColumnAndRow): (AccessibilityUIElement::selectedTextRange): (AccessibilityUIElement::setSelectedTextRange): (AccessibilityUIElement::attributeValue): (AccessibilityUIElement::isAttributeSettable): (AccessibilityUIElement::increment): (AccessibilityUIElement::decrement):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): (main):
  • GNUmakefile.am:
Note: See TracTimeline for information about the timeline view.