Timeline


and

08/16/09:

22:26 Changeset [47350] by darin@apple.com
  • 2 edits in trunk/WebCore

StyledElement should use ASCIICType instead of having its own toHex function
https://bugs.webkit.org/show_bug.cgi?id=28377

Patch by Darin Adler <darin@apple.com> on 2009-08-16
Reviewed by Dan Bernstein.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::addCSSColor): Use isASCIIHexDigit and toASCIIHexValue.

22:24 Changeset [47349] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

<http://webkit.org/b/28366> WebHTMLViewInternal.h: add @class CALayer declaration

Reviewed by Simon Fraser.

Without WebKitPrefix.h, the missing @class CALayer declaration
causes a compile-time error.

  • WebView/WebHTMLViewInternal.h: Added @class CALayer declaration with USE(ACCELERATED_COMPOSITING).
22:24 Changeset [47348] by darin@apple.com
  • 5 edits in trunk

WebCore: execCommand("InsertHorizontalRule") inserts a broken <hr> element
https://bugs.webkit.org/show_bug.cgi?id=28375

Patch by Darin Adler <darin@apple.com> on 2009-08-16
Reviewed by Dan Bernstein.

  • editing/EditorCommand.cpp:

(WebCore::executeInsertHorizontalRule): Create an HTMLHRElement
instead of just an HTMLElement.

LayoutTests: execCommand("InsertHorizontalRule") inserts a broken <hr> element
https://bugs.webkit.org/show_bug.cgi?id=28375

Patch by Darin Adler <darin@apple.com> on 2009-08-16
Reviewed by Dan Bernstein.

  • editing/execCommand/arguments-combinations-expected.txt: Updated.
  • editing/execCommand/arguments-combinations.html: Updated to expect

the <hr> element to be self-closing rather than having a separate
</hr> in the markup.

17:45 Changeset [47347] by zimmermann@webkit.org
  • 7 edits
    4 adds in trunk

2009-08-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] <option> element & 'onpick' events - history navigation is broken
https://bugs.webkit.org/show_bug.cgi?id=28371

After selecting an option element with an 'onpick' event associated with a 'go' task,
the navigation is executed. When going back in history, the same 'onpick' event is fired
again. Fix that problem, add wml/option-element-onpick-recursion.html covering the bug.

Test: wml/option-element-onpick-recursion.html

  • wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::handleIntrinsicEventIfNeeded):
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::WMLSelectElement): (WebCore::WMLSelectElement::selectInitialOptions):
  • wml/WMLSelectElement.h: (WebCore::WMLSelectElement::initialized):

2009-08-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] <option> element & 'onpick' events - history navigation is broken
https://bugs.webkit.org/show_bug.cgi?id=28371

Add new test covering history navigation & 'onpick' event handling.

  • wml/option-element-onpick-recursion-expected.txt: Added.
  • wml/option-element-onpick-recursion.html: Added.
  • wml/resources/WMLTestCase.js: (createStaticWMLTestCase): (createDynamicWMLTestCase):
  • wml/resources/option-element-onpick-recursion.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/option-element-onpick-recursion.wml: Added.
  • wml/resources/option-element-onpick.js: (prepareTest):
17:44 Changeset [47346] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

<http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements

Reviewed by David Levin.

In <http://webkit.org/b/28355#c1>, it was noted that new source
files use 'using namespace std;' instead of individual
'using std::foo;' statements. This adds a level 4 check for
such statements.

  • Scripts/modules/cpp_style.py: (_ERROR_CATEGORIES): Added 'build/using_std'. (check_using_std): Added. (check_style): Added call to check_using_std().
  • Scripts/modules/cpp_style_unittest.py: (WebKitStyleTest.test_using_std): Added unit test.
17:32 Changeset [47345] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

Backed out r47343 which was mistakenly committed

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
17:30 Changeset [47344] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class

Reviewed by David Levin.

The ScriptError class doesn't exist in bugzilla.py, so any
errors print error messages about ScriptError instead of the
actual error:

NameError: global name 'ScriptError' is not defined

  • Scripts/modules/bugzilla.py: (BugzillaError): Added class. Modeled after ScriptError class in scm.py. (Bugzilla.authenticate): Changed to use BugzillaError instead of ScriptError. (Bugzilla._check_create_bug_response): Ditto.
17:30 Changeset [47343] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools/Scripts

WIP: bugzilla-tool: add land-commits command

16:24 Changeset [47342] by rik@webkit.org
  • 2 edits in trunk/WebCore

Inspector Resource filtering: keyboard Navigation always uses ALL resources
https://bugs.webkit.org/show_bug.cgi?id=28231

Patch by Anthony Ricaud <rik@webkit.org> on 2009-08-16
Reviewed by Timothy Hatcher.

Determine if a resource is selectable on user action.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourceSidebarTreeElement.prototype.get selectable):

15:57 Changeset [47341] by ddkilzer@apple.com
  • 10 edits in trunk

<http://webkit.org/b/28355> Replace MAX()/MIN() macros with type-safe std::max()/min() templates

Reviewed by Dan Bernstein.

WebCore:

  • accessibility/mac/AccessibilityObjectWrapper.mm: (AXAttributeStringSetSpelling): Changed MIN() to min().
  • platform/graphics/mac/FontMacATSUI.mm: (WebCore::Font::selectionRectForComplexText): Changed MAX() to max() and MIN() to min(). (WebCore::Font::floatWidthForComplexText): Ditto.
  • platform/graphics/mac/SimpleFontDataMac.mm: Added using std::max statement. (WebCore::SimpleFontData::platformInit): Changed MAX() to max().
  • platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::decode): Changed MIN() to min().

WebKit/mac:

  • Plugins/WebBaseNetscapePluginStream.mm: Added using std::min statement. (WebNetscapePluginStream::deliverData): Changed MIN() to min(). Changed C-style cast to a static_cast.
  • Plugins/WebNetscapePluginView.mm: Added using std::min statement. (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]): Changed MIN() to min(). Changed C-style cast to a static_cast.
  • WebView/WebHTMLView.mm: Added using std::max statement. (-[WebHTMLView _dragImageForURL:withLabel:]): Changed MAX() to max(). (-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.
  • WebView/WebTextCompletionController.mm: Added using std::max and using std::min statements. (-[WebTextCompletionController _placePopupWindow:]): Changed type of maxWidth variable from float to CGFloat to prevent a type mismatch on x86_64. Changed MAX() to max() and MIN() to min(). Added static_cast for a constant value since CGFloat is defined as a float on i386 and as a double on x86_64.
12:27 Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:27 HowToSubmitPatch.png attached to Creating and Submitting Layout Tests and Patches by rniwa@webkit.org
Flow chart on how to submit a patch
12:25 Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:25 Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:25 Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:24 Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:23 Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:22 Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:21 Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:20 Flow chart edited by rniwa@webkit.org
(diff)
12:18 Flow chart edited by rniwa@webkit.org
(diff)
12:16 Flow chart edited by rniwa@webkit.org
adding picture (diff)
12:16 flowchart5.png attached to Flow chart by rniwa@webkit.org
Flow chart on how to submit a patch
12:15 Flow chart created by rniwa@webkit.org
initial creation
10:35 Changeset [47340] by zimmermann@webkit.org
  • 11 edits in trunk/WebCore

2009-08-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Cleanup WMLIntrinsicEventHandling code
https://bugs.webkit.org/show_bug.cgi?id=28358

Remove superflous "Event* evt" parameter from executeTask() methods. It's a leftover from the initial WML merge.

  • wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::defaultEventHandler):
  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::defaultEventHandler):
  • wml/WMLGoElement.cpp: (WebCore::WMLGoElement::executeTask):
  • wml/WMLGoElement.h:
  • wml/WMLIntrinsicEventHandler.cpp: (WebCore::WMLIntrinsicEventHandler::triggerIntrinsicEvent):
  • wml/WMLPrevElement.cpp: (WebCore::WMLPrevElement::executeTask):
  • wml/WMLPrevElement.h:
  • wml/WMLRefreshElement.cpp: (WebCore::WMLRefreshElement::executeTask):
  • wml/WMLRefreshElement.h:
  • wml/WMLTaskElement.h:
09:15 Changeset [47339] by pfeldman@chromium.org
  • 21 edits in trunk/WebCore

2009-08-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: A handful of DOMAgent-related fixes and cleanups.

  • renamed elementId to nodeId in operations on nodes.
  • added load listeners to frame owners in InspectorDOMAgent.
  • removed InspectorController::inspectedWindowScriptObjectCleared event.
  • preserved isViaInspector flag for 'via inspector' marker to survive styles update.
  • removed contentDocument-related logic from ElementsPanel since it is handled in

the InspectorDOMAgent.

  • removed DOM listeners unregistration and corresponding events from InspectorController.
  • made this.styles 'private' in ElementsPanel.
  • added TODO for the handleCopy processing.

https://bugs.webkit.org/show_bug.cgi?id=28356

  • WebCore.order:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getChildNodes): (WebCore::InspectorBackend::setTextNodeValue):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::handleEvent): (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): (WebCore::InspectorDOMAgent::setTextNodeValue): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren): (WebCore::InspectorDOMAgent::innerParentNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMDocument.prototype.addEventListener): (WebInspector.DOMDocument.prototype.removeEventListener): (WebInspector.DOMDocument.prototype._fireDomEvent): (WebInspector.DOMAgent.prototype.getChildNodesAsync.mycallback): (WebInspector.DOMAgent.prototype.getChildNodesAsync): (WebInspector.DOMAgent.prototype._setChildNodes): (WebInspector.CSSStyleDeclaration.parseRule): (WebInspector.childNodeInserted): (WebInspector.childNodeRemoved):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.addStyleChange): (WebInspector.ElementsPanel.prototype.removeStyleChange): (WebInspector.ElementsPanel.prototype._updateModifiedNodes): (WebInspector.ElementsPanel.prototype.updateBreadcrumb): (WebInspector.ElementsPanel.prototype.handleCopyEvent):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode): (WebInspector.ElementsTreeOutline.prototype.findTreeElement): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype.onexpand):
  • inspector/front-end/InjectedScript.js: (InjectedScript.addStyleSelector): (InjectedScript._serializeRule):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection):
  • inspector/front-end/inspector.js: (WebInspector.set hoveredDOMNode):
  • inspector/front-end/treeoutline.js: (TreeOutline.prototype.findTreeElement):
  • inspector/front-end/utilities.js: (Node.prototype.enclosingNodeOrSelfWithNodeNameInArray): (Node.prototype.enclosingNodeOrSelfWithClass): (isAncestorNode): (firstCommonNodeAncestor): (traverseNextNode): (traversePreviousNode): ():
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchWindowObjectAvailable):
  • page/android/InspectorControllerAndroid.cpp:
06:14 Changeset [47338] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-16 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

Fix crash on ./ecma_2/RegExp/exec-002.js.
https://bugs.webkit.org/show_bug.cgi?id=28353

Change the order of freeParenthesesDisjunctionContext and
popParenthesesDisjunctionContext on all call sites as the pop
method is accessing backTrack->lastContext which is the context
that is about to be freed.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::parenthesesDoBacktrack): (JSC::Yarr::Interpreter::backtrackParentheses):
06:14 Changeset [47337] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-16 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=28352

Fix coding style violations. Use m_ for C++ class members. Remove
trailing whitespace on empty lines.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::tryConsumeCharacter): (JSC::Yarr::Interpreter::tryConsumeBackReference): (JSC::Yarr::Interpreter::parenthesesDoBacktrack): (JSC::Yarr::Interpreter::backtrackParentheses): (JSC::Yarr::ByteCompiler::ByteCompiler): (JSC::Yarr::ByteCompiler::compile): (JSC::Yarr::ByteCompiler::checkInput): (JSC::Yarr::ByteCompiler::assertionBOL): (JSC::Yarr::ByteCompiler::assertionEOL): (JSC::Yarr::ByteCompiler::assertionWordBoundary): (JSC::Yarr::ByteCompiler::atomPatternCharacter): (JSC::Yarr::ByteCompiler::atomCharacterClass): (JSC::Yarr::ByteCompiler::atomBackReference): (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin): (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin): (JSC::Yarr::ByteCompiler::popParenthesesStack): (JSC::Yarr::ByteCompiler::closeAlternative): (JSC::Yarr::ByteCompiler::closeBodyAlternative): (JSC::Yarr::ByteCompiler::atomParenthesesEnd): (JSC::Yarr::ByteCompiler::regexBegin): (JSC::Yarr::ByteCompiler::alterantiveBodyDisjunction): (JSC::Yarr::ByteCompiler::alterantiveDisjunction): (JSC::Yarr::ByteCompiler::emitDisjunction):
05:33 Changeset [47336] by zimmermann@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Not reviewed. Add missing WML specific layout test result.

08/15/09:

23:49 Changeset [47335] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Make Mark Rowe a bit less grumpy.

  • http/tests/history/back-to-post.php:
23:43 Changeset [47334] by weinig@apple.com
  • 3 edits in trunk/LayoutTests

Make http/tests/history/back-to-post.php's output a bit more reliable.

  • http/tests/history/back-to-post-expected.txt:
  • http/tests/history/back-to-post.php:
21:40 Changeset [47333] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-08-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

Optimize updateFillImages() to not add/remove clients every time
https://bugs.webkit.org/show_bug.cgi?id=28334

Optimize the case where old and new just have a single layer pointing to the same (or no)
image.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::updateFillImages):
18:32 Changeset [47332] by simon.fraser@apple.com
  • 4 edits
    2 adds in trunk

2009-08-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Implement animations of multiple text-shadows and -webkit-box-shadows.
https://bugs.webkit.org/show_bug.cgi?id=28266

Test: transitions/multiple-shadow-transitions.html

  • page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperShadow::equals): (WebCore::PropertyWrapperShadow::blend):
18:32 Changeset [47331] by simon.fraser@apple.com
  • 4 edits
    6 adds in trunk

2009-08-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Make transitions work for position and size of multiple backgrounds and masks.
https://bugs.webkit.org/show_bug.cgi?id=28266

Make background-position, background-size, -webkit-mask-position and -webkit-mask-size
properties animatable with multiple backgrounds, rather than just animating the first one.

Tests: transitions/multiple-background-size-transitions.html

transitions/multiple-background-transitions.html
transitions/multiple-mask-transitions.html

  • page/animation/AnimationBase.cpp: (WebCore::FillLayerPropertyWrapperBase::FillLayerPropertyWrapperBase): (WebCore::FillLayerPropertyWrapperBase::~FillLayerPropertyWrapperBase): (WebCore::FillLayerPropertyWrapperGetter::FillLayerPropertyWrapperGetter): (WebCore::FillLayerPropertyWrapperGetter::equals): (WebCore::FillLayerPropertyWrapper::FillLayerPropertyWrapper): (WebCore::FillLayerPropertyWrapper::blend): (WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper): (WebCore::FillLayersPropertyWrapper::equals): (WebCore::FillLayersPropertyWrapper::blend): (WebCore::ensurePropertyMap):
  • rendering/style/FillLayer.h: (WebCore::FillLayer::setXPosition): (WebCore::FillLayer::setYPosition): (WebCore::FillLayer::setSize):
17:23 Changeset [47330] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix the build with JIT disabled.

  • runtime/Arguments.h: Only compile the jitCode method when the JIT is enabled.
  • runtime/Executable.h: Include PrototypeFunction.h so the compiler knows what

NativeFunctionWrapper is when the JIT is disabled.

17:16 Changeset [47329] by staikos@webkit.org
  • 3 edits
    1 add in trunk

2009-08-15 George Staikos <george.staikos@torchmobile.com>

Reviewed by Jan Alonzo.

Don't crash in fieldset code when WML is enabled.
https://bugs.webkit.org/show_bug.cgi?id=28012

Test: fast/wml/html-fieldset-crash.html

  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::findLegend): ++brackets
16:01 Changeset [47328] by weinig@apple.com
  • 3 edits in trunk/WebCore

Try and enable EventSource on Windows.

  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/build-generated-files.sh:
15:54 Changeset [47327] by weinig@apple.com
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove no longer correct and now failing test. document.body.onunload
has now been spec'ed in HTML5.

  • fast/events/onunload-body-property-expected.txt: Removed.
  • fast/events/onunload-body-property.html: Removed.
15:14 Changeset [47326] by weinig@apple.com
  • 4 edits
    6 adds in trunk

WebCore: Setting attribute event listeners to the body does not set them on the window
https://bugs.webkit.org/show_bug.cgi?id=28343

Reviewed by Dan Bernstein.

Tests: fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html

fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::setOnblur): Use setWindowAttributeEventListener instead of setAttributeEventListener.
(WebCore::HTMLBodyElement::setOnerror): Ditto.
(WebCore::HTMLBodyElement::setOnfocus): Ditto.
(WebCore::HTMLBodyElement::setOnload): Ditto.
(WebCore::HTMLBodyElement::setOnbeforeunload): Ditto.
(WebCore::HTMLBodyElement::setOnmessage): Ditto.
(WebCore::HTMLBodyElement::setOnoffline): Ditto.
(WebCore::HTMLBodyElement::setOnonline): Ditto.
(WebCore::HTMLBodyElement::setOnresize): Ditto.
(WebCore::HTMLBodyElement::setOnstorage): Ditto.
(WebCore::HTMLBodyElement::setOnunload): Ditto.

  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::setOnblur): Ditto.
(WebCore::HTMLFrameSetElement::setOnerror): Ditto.
(WebCore::HTMLFrameSetElement::setOnfocus): Ditto.
(WebCore::HTMLFrameSetElement::setOnload): Ditto.
(WebCore::HTMLFrameSetElement::setOnbeforeunload): Ditto.
(WebCore::HTMLFrameSetElement::setOnmessage): Ditto.
(WebCore::HTMLFrameSetElement::setOnoffline): Ditto.
(WebCore::HTMLFrameSetElement::setOnonline): Ditto.
(WebCore::HTMLFrameSetElement::setOnresize): Ditto.
(WebCore::HTMLFrameSetElement::setOnstorage): Ditto.
(WebCore::HTMLFrameSetElement::setOnunload): Ditto.

LayoutTests: Setting attribute event listeners to the body does not set them on the window
https://bugs.webkit.org/show_bug.cgi?id=28343

Reviewed by Dan Bernstein.

  • fast/dom/Window/HTMLBodyElement-window-eventListener-attributes-expected.txt: Added.
  • fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html: Added.
  • fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes-expected.txt: Added.
  • fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html: Added.
  • fast/dom/Window/resources/HTMLBodyElement-window-eventListener-attributes.js: Added.
  • fast/dom/Window/resources/HTMLFrameSetElement-window-eventListener-attributes.js: Added.
14:35 Changeset [47325] by weinig@apple.com
  • 3 edits in trunk/WebCore

Fix up some IDL comments.

Reviewed by Dan Bernstein.

  • html/HTMLBodyElement.idl:
  • html/HTMLFrameSetElement.idl:
14:25 Changeset [47324] by weinig@apple.com
  • 2 edits in trunk

[GTK] Added EventSource to the build (default on).
https://bugs.webkit.org/show_bug.cgi?id=14997

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-14
Reviewed by Sam Weinig.

  • configure.ac:
14:04 Changeset [47323] by weinig@apple.com
  • 27 edits
    31 adds in trunk

JavaScriptCore: Added ENABLE_EVENTSOURCE flag.
https://bugs.webkit.org/show_bug.cgi?id=14997

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-15
Reviewed by Sam Weinig.

  • Configurations/FeatureDefines.xcconfig:

WebCore: Added implementation of the EventSource object that enables
server-sent events from HTML5.
http://dev.w3.org/html5/eventsource/
https://bugs.webkit.org/show_bug.cgi?id=14997

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-15
Reviewed by Sam Weinig.

Tests: fast/eventsource/eventsource-attribute-listeners.html

fast/eventsource/eventsource-constructor.html
http/tests/eventsource/eventsource-bad-mime-type.html
http/tests/eventsource/eventsource-parse-event-stream.html
http/tests/eventsource/eventsource-reconnect.html
http/tests/eventsource/eventsource-status-code-states.html
http/tests/eventsource/workers/eventsource-simple.html

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::eventSource):

  • bindings/js/JSEventSourceConstructor.cpp: Added.

(WebCore::):
(WebCore::JSEventSourceConstructor::JSEventSourceConstructor):
(WebCore::constructEventSource):
(WebCore::JSEventSourceConstructor::getConstructData):

  • bindings/js/JSEventSourceConstructor.h: Added.

(WebCore::JSEventSourceConstructor::classInfo):

  • bindings/js/JSEventSourceCustom.cpp: Added.

(WebCore::JSEventSource::markChildren):
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):

  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):
(WebCore::toEventTarget):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::eventSource):

  • dom/EventNames.h:
  • dom/EventTarget.cpp:

(WebCore::EventTarget::toEventSource):

  • dom/EventTarget.h:
  • page/DOMWindow.idl:
  • page/EventSource.cpp: Added.

(WebCore::EventSource::EventSource):
(WebCore::EventSource::~EventSource):
(WebCore::EventSource::connect):
(WebCore::EventSource::endRequest):
(WebCore::EventSource::scheduleReconnect):
(WebCore::EventSource::reconnectTimerFired):
(WebCore::EventSource::url):
(WebCore::EventSource::readyState):
(WebCore::EventSource::close):
(WebCore::EventSource::scriptExecutionContext):
(WebCore::EventSource::addEventListener):
(WebCore::EventSource::removeEventListener):
(WebCore::EventSource::dispatchEvent):
(WebCore::EventSource::didReceiveResponse):
(WebCore::EventSource::didReceiveData):
(WebCore::EventSource::didFinishLoading):
(WebCore::EventSource::didFail):
(WebCore::EventSource::didFailRedirectCheck):
(WebCore::EventSource::parseEventStream):
(WebCore::EventSource::parseEventStreamLine):
(WebCore::EventSource::dispatchGenericEvent):
(WebCore::EventSource::dispatchMessageEvent):
(WebCore::EventSource::stop):

  • page/EventSource.h: Added.

(WebCore::EventSource::create):
(WebCore::EventSource::):
(WebCore::EventSource::setOnopen):
(WebCore::EventSource::onopen):
(WebCore::EventSource::setOnmessage):
(WebCore::EventSource::onmessage):
(WebCore::EventSource::setOnerror):
(WebCore::EventSource::onerror):
(WebCore::EventSource::toEventSource):
(WebCore::EventSource::eventListeners):
(WebCore::EventSource::refEventTarget):
(WebCore::EventSource::derefEventTarget):

  • page/EventSource.idl: Added.
  • workers/WorkerContext.idl:

WebKit/mac: Added ENABLE_EVENTSOURCE flag.
https://bugs.webkit.org/show_bug.cgi?id=14997

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-15
Reviewed by Sam Weinig.

  • Configurations/FeatureDefines.xcconfig:

WebKitTools: Added EventSource to the build script (default on).
https://bugs.webkit.org/show_bug.cgi?id=14997

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-14
Reviewed by Sam Weinig.

  • Scripts/build-webkit:

LayoutTests: Tests for EventSource.
https://bugs.webkit.org/show_bug.cgi?id=14997

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-14
Reviewed by Sam Weinig.

  • fast/eventsource: Added.
  • fast/eventsource/eventsource-attribute-listeners-expected.txt: Added.
  • fast/eventsource/eventsource-attribute-listeners.html: Added.
  • fast/eventsource/eventsource-constructor-expected.txt: Added.
  • fast/eventsource/eventsource-constructor.html: Added.
  • http/tests/eventsource: Added.
  • http/tests/eventsource/eventsource-bad-mime-type-expected.txt: Added.
  • http/tests/eventsource/eventsource-bad-mime-type.html: Added.
  • http/tests/eventsource/eventsource-parse-event-stream-expected.txt: Added.
  • http/tests/eventsource/eventsource-parse-event-stream.html: Added.
  • http/tests/eventsource/eventsource-reconnect-expected.txt: Added.
  • http/tests/eventsource/eventsource-reconnect.html: Added.
  • http/tests/eventsource/eventsource-status-code-states-expected.txt: Added.
  • http/tests/eventsource/eventsource-status-code-states.html: Added.
  • http/tests/eventsource/resources: Added.
  • http/tests/eventsource/resources/bad-mime-type.asis: Added.
  • http/tests/eventsource/resources/event-stream.php: Added.
  • http/tests/eventsource/resources/reconnect.php: Added.
  • http/tests/eventsource/resources/simple-event-stream.asis: Added.
  • http/tests/eventsource/resources/status-codes.php: Added.
  • http/tests/eventsource/workers: Added.
  • http/tests/eventsource/workers/eventsource-simple-expected.txt: Added.
  • http/tests/eventsource/workers/eventsource-simple.html: Added.
  • http/tests/eventsource/workers/resources: Added.
  • http/tests/eventsource/workers/resources/simple-worker.js: Added.

(es.onmessage):
(es.onerror):

13:53 Changeset [47322] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-08-15 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Xan Lopez.

Fix compiler warnings.

  • webkit/webkitwebview.cpp: (clipboard_contents_received): (webkit_web_view_drag_data_get):
11:30 Changeset [47321] by rniwa@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-15
Add myself to list of committers.

  • Scripts/modules/committers.py:
04:25 Changeset [47320] by jhoneycutt@apple.com
  • 12 edits in trunk/WebKitTools

WebKitTools: Fix layout test failures after r47312.

Reviewed by Cameron Zwarich.

  • DumpRenderTree/AccessibilityController.h:

Replaced logFocusEvents() with setLogFocusEvents(), which takes a
boolean argument to turn logging of focus events on or off.
Added a function to reset the AccessibilityController to a consistent
state.

  • DumpRenderTree/AccessibilityController.cpp:

(logFocusEventsCallback):
Call setLogFocusEvents() to enable logging.
(AccessibilityController::resetToConsistentState):
Call setLogFocusEvents() to disable logging.

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::setLogFocusEvents):
Update stub.

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::setLogFocusEvents):
Update stub.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):
Call the FrameLoadDelegate's resetToConsistentState method.

  • DumpRenderTree/mac/FrameLoadDelegate.h:

Declare the resetToConsistentState method.

  • DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate resetToConsistentState]):
Call the AccessibilityController's resetToConsistentState() function.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::~AccessibilityController):
Turn off focus event logging when the controller is destroyed.
(AccessibilityController::setLogFocusEvents):
If the caller passes false, unhook the focus event, and clear
m_focusEventHook.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):
Call the FrameLoadDelegate's resetToConsistentState function.

  • DumpRenderTree/win/FrameLoadDelegate.h:

Declare the resetToConsistentState() function.

  • DumpRenderTree/win/FrameLoadDelegate.cpp:

(FrameLoadDelegate::resetToConsistentState):
Call the AccessibilityController's resetToConsistentState() function.

02:02 Changeset [47319] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-08-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Minor DOMAgent bugfixes.

https://bugs.webkit.org/show_bug.cgi?id=28177

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::nodeForId):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
01:56 Changeset [47318] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-08-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Evaluating objects while on a breakpoint dumps string
representation instead of live object.

https://bugs.webkit.org/show_bug.cgi?id=28280

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.this._evalInInspectedWindow): (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._reportCompletions):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame.delayedEvaluation): (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame): (WebInspector.ScriptsPanel.prototype.variablesInSelectedCallFrame):
00:31 Changeset [47317] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-08-15 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Adding two new files to WebCore/platform/haiku:
LocalizedStringsHaiku.cpp and LoggingHaiku.cpp
https://bugs.webkit.org/show_bug.cgi?id=28129

  • platform/haiku/LocalizedStringsHaiku.cpp: Added. (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::defaultLanguage): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::unknownFileSizeText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText): (WebCore::imageTitle): (WebCore::contextMenuItemTagTextDirectionMenu): (WebCore::AXButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::AXDefinitionListTermText): (WebCore::AXDefinitionListDefinitionText):
  • platform/haiku/LoggingHaiku.cpp: Added. (WebCore::InitializeLoggingChannelsIfNecessary):
00:27 Changeset [47316] by darin@apple.com
  • 2 edits in trunk/WebCore

Fix GTK build.

Patch by Darin Adler <darin@apple.com> on 2009-08-15

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(fallbackObject): Pass 0 for document. Should be OK at least for now.

00:09 Changeset [47315] by darin@apple.com
  • 2 edits in trunk/WebCore

Fix Qt build.

Patch by Darin Adler <darin@apple.com> on 2009-08-15

  • dom/XMLTokenizerQt.cpp: Use create functions instead of calling new

directly to make CDATASection and Comment nodes.

08/14/09:

23:29 Changeset [47314] by jhoneycutt@apple.com
  • 2 edits in trunk/LayoutTests

Remove two tests from the skipped list that don't exist.

Rubber-stamped by Mark Rowe.

  • platform/win/Skipped:
23:25 Changeset [47313] by darin@apple.com
  • 68 edits
    1 delete in trunk/WebCore

Make DOM classes start with a reference count of 1, like all other RefCounted
https://bugs.webkit.org/show_bug.cgi?id=28068

Patch by Darin Adler <darin@apple.com> on 2009-08-14
Reviewed by Sam Weinig.

First half, everything except for element classes.

  • GNUmakefile.am: Removed DocPtr.h.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Attr.cpp:

(WebCore::Attr::Attr): Added a call to createTextChild here so callers don't
have to call it explicitly.
(WebCore::Attr::create): Added.
(WebCore::Attr::setValue): Changed to take AtomicString.
(WebCore::Attr::cloneNode): Use create.

  • dom/Attr.h: Added a create function. Made the constructor private,

and a lot of other functions private as well.

  • dom/Attribute.cpp:

(WebCore::Attribute::createAttrIfNeeded): Use Attr::create.

  • dom/CDATASection.cpp:

(WebCore::CDATASection::create): Added.
(WebCore::CDATASection::cloneNode): Use create.
(WebCore::CDATASection::virtualCreate): Ditto.

  • dom/CDATASection.h: Added a create function. Made everything private.

Removed unneeded destructor declaration.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::CharacterData): Replaced the multiple constructors
with a single one that takes ConstructionType.

  • dom/CharacterData.h: Made more functions be protected and private.

Made m_data be private.

  • dom/Comment.cpp:

(WebCore::Comment::Comment): Got rid of an extra constructor.
(WebCore::Comment::create): Added.
(WebCore::Comment::cloneNode): Call create.

  • dom/Comment.h: Added a create function. Made everything private.
  • dom/ContainerNode.cpp:

(WebCore::dispatchChildInsertionEvents): Use RefPtr instead of DocPtr.
(WebCore::dispatchChildRemovalEvents): Ditto.

  • dom/ContainerNode.h: Made the constructor protected and passed

ConstructionType instead of an isElement boolean.

  • dom/DocPtr.h: Removed.
  • dom/Document.cpp:

(WebCore::Document::Document): Simplified the code that sets m_document
since it's no longer a smart pointer.
(WebCore::Document::removedLastRef): Use explicit calls to selfOnlyRef
and selfOnlyDeref instead of a DocPtr in here.
(WebCore::Document::~Document): Simplified the code that sets m_document
since it's no longer a smart pointer.
(WebCore::Document::createDocumentFragment): Call create.
(WebCore::Document::createTextNode): Ditto.
(WebCore::Document::createComment): Ditto.
(WebCore::Document::createCDATASection): Ditto.
(WebCore::Document::createProcessingInstruction): Ditto.
(WebCore::Document::createEntityReference): Ditto.
(WebCore::Document::createEditingTextNode): Ditto.
(WebCore::Document::importNode): Call Attr::create.
(WebCore::Document::createAttributeNS): Ditto.

  • dom/Document.h: Call adoptRef. Made a lot of functions private and

protected and sorted them so public functions come first.

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::create): Added.
(WebCore::DocumentFragment::cloneNode): Call create.

  • dom/DocumentFragment.h: Added create.
  • dom/DocumentType.cpp:

(WebCore::DocumentType::DocumentType): Pass type to Node constructor.
(WebCore::DocumentType::cloneNode): Use create.

  • dom/DocumentType.h:

(WebCore::DocumentType::create): Call adoptRef.

  • dom/EditingText.cpp:

(WebCore::EditingText::create): Added.

  • dom/EditingText.h: Added a create function. Made everything private.
  • dom/Element.cpp:

(WebCore::Element::Element): Pass CreateElementZeroRefCount to preserve
the zero reference count behavior for classes derived from Element.

  • dom/EntityReference.cpp:

(WebCore::EntityReference::create): Added.
(WebCore::EntityReference::cloneNode): Call create.

  • dom/EntityReference.h: Added create. Made everything private.
  • dom/Node.cpp:

(WebCore::Node::initialRefCount): Added. Inline helper function for
the constructor.
(WebCore::Node::isContainer): Ditto.
(WebCore::Node::isElement): Ditto.
(WebCore::Node::isText): Ditto.
(WebCore::Node::Node): Changed to take a construction type argument.
Since m_document is now a normal pointer, added a call to selfOnlyRef.
(WebCore::Node::~Node): Ditto, but selfOnlyDeref.
(WebCore::Node::setDocument): Added selfOnlyRef/Deref calls.
(WebCore::Node::appendTextContent): Use the data function instead of
calling nodeValue functions, which do the same thing in a roundabout way.

  • dom/Node.h: Made the constructor protected and replaced the multiple

arguments iwth a single ConstructionType argument. Sorted the public
things first.

  • dom/Notation.h: Made most things private.
  • dom/Notation.cpp: Removed extra constructor.
  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::create): Added.
(WebCore::ProcessingInstruction::cloneNode): Call create.

  • dom/ProcessingInstruction.h: Added create function. Made many other

members private.

  • dom/Range.cpp:

(WebCore::Range::processContents): Use DocumentFragment::create.

  • dom/Text.cpp:

(WebCore::Text::Text): Updated for base class change.
(WebCore::Text::create): Added.
(WebCore::Text::splitText): Changed to not require access to m_data.
(WebCore::Text::cloneNode): Call create.
(WebCore::Text::createRenderer): Call dataImpl.
(WebCore::Text::attach): Call data.
(WebCore::Text::recalcStyle): Call dataImpl.
(WebCore::Text::virtualCreate): Call create.
(WebCore::Text::createWithLengthLimit): Call create.
(WebCore::Text::formatForDebugger): Call data.

  • dom/Text.h: Added a create function. Made many other members private.

Renamed createNew to virtualCreate.

  • dom/XMLTokenizer.cpp:

(WebCore::XMLTokenizer::enterText): Call Text::create.

  • dom/XMLTokenizerLibxml2.cpp:

(WebCore::XMLTokenizer::cdataBlock): Call CDATASection::create.
(WebCore::XMLTokenizer::comment): Call Comment::create.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):
Call data instead of string.

  • editing/CreateLinkCommand.cpp:

(WebCore::CreateLinkCommand::doApply): Call Text::create.

  • editing/EditorCommand.cpp:

(WebCore::executeInsertNode): Call DocumentFragment::create.

  • editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::doApply): Call Text::create.

  • editing/markup.cpp:

(WebCore::appendStartMarkup): Call data instead of nodeValue.

  • html/HTMLDocument.h:

(WebCore::HTMLDocument::create): Call adoptRef.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::createContextualFragment): Call DocumentFragment::create.
(WebCore::replaceChildrenWithFragment): Call data instead of string.
(WebCore::replaceChildrenWithText): Call Text::create.
(WebCore::HTMLElement::setInnerText): Call DocumentFragment::create and
Text::create.
(WebCore::HTMLElement::setOuterText): Call Text::create.

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement): Call Text::create.

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setText): Call Text::create.

  • html/HTMLParser.cpp:

(WebCore::HTMLParser::textCreateErrorCheck): Call Text::create.
(WebCore::HTMLParser::commentCreateErrorCheck): Call Comment::create.
(WebCore::HTMLParser::handleIsindex): Call Text::create.

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::addText): Call Text::create.

  • html/HTMLViewSourceDocument.h:

(WebCore::HTMLViewSourceDocument::create): Call adoptRef.

  • loader/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryTokenizer::appendEntry): Call Text::create.
(WebCore::FTPDirectoryTokenizer::createTDForFilename): Call Text::create.

  • loader/FTPDirectoryDocument.h:

(WebCore::FTPDirectoryDocument::create): Call adoptRef.

  • loader/ImageDocument.h:

(WebCore::ImageDocument::create): Ditto.

  • loader/MediaDocument.h:

(WebCore::MediaDocument::create): Ditto.

  • loader/PlaceholderDocument.h:

(WebCore::PlaceholderDocument::create): Ditto.

  • loader/PluginDocument.h:

(WebCore::PluginDocument::create): Ditto.

  • loader/TextDocument.h:

(WebCore::TextDocument::create): Ditto.

  • loader/loader.cpp:

(WebCore::Loader::Host::didFinishLoading): Use RefPtr instead of DocPtr.
(WebCore::Loader::Host::didFail): Ditto.

  • platform/TreeShared.h:

(WebCore::TreeShared::TreeShared): Added an initialRefCount argument,
defaulting to 1. Node still sometimes initializes it to 0 instead for now.

  • rendering/RenderText.cpp:

(WebCore::RenderText::originalText): Use dataImpl instead of string.

  • rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::originalText): Use dataImpl instead of string.
(WebCore::RenderTextFragment::previousCharacter): Ditto.

  • svg/SVGDocument.h:

(WebCore::SVGDocument::create): Use adoptRef.

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::SVGElementInstance): Updated to take a
PassRefPtr.

  • svg/SVGElementInstance.h: Made everything private.
  • wml/WMLDocument.h:

(WebCore::WMLDocument::create): Called adoptRef.

  • xml/XPathNamespace.cpp:

(WebCore::XPathNamespace::XPathNamespace): Take AtomicString arguments.

  • xml/XPathNamespace.h: Made everything private.
  • xml/XSLTProcessor.cpp:

(WebCore::createFragmentFromSource): Use DocumentFragment::create and
Text::create.

23:15 Changeset [47312] by jhoneycutt@apple.com
  • 8 edits
    2 adds in trunk

WebKitTools: Add a mechanism for logging MSAA focus events.

Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
nightly (20866)

https://bugs.webkit.org/show_bug.cgi?id=20866

Reviewed by Oliver Hunt.

  • DumpRenderTree/AccessibilityController.cpp:

(logFocusEventsCallback):
Call the AccessibilityController's logFocusEvents() function.
(AccessibilityController::getJSClass):
Add a "logFocusEvents" function to the AccessibilityController's JS
class definition.

  • DumpRenderTree/AccessibilityController.h:

On Windows, include windows.h, and add a member variable to hold the
handle to the event hook for focus events. Add a declaration for a
function that enables logging of focus events.

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::logFocusEvents):
Stubbed.

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::logFocusEvents):
Stubbed.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
(AccessibilityController::~AccessibilityController):
If we hooked the focus event, unhook it.
(logFocusEventProc):
When we receive a focus event, get the accessible object for the event,
and log its name to stdout.
(AccessibilityController::logFocusEvents):
Setup the focus event hook to listen for events in the current process.

LayoutTests: Add a layout test for <rdar://problem/6218721> No MSAA focus events
fired for Webkit nightly (20866)

https://bugs.webkit.org/show_bug.cgi?id=20866

Reviewed by Oliver Hunt.

  • platform/win/Skipped:

Remove the blanket skipping of accessibility/, and add the individual
tests.

  • platform/win/accessibility/focus-events-expected.txt: Added.
  • platform/win/accessibility/focus-events.html: Added.
23:14 Changeset [47311] by jhoneycutt@apple.com
  • 9 edits in trunk

WebCore:

2009-08-13 Jon Honeycutt <jhoneycutt@apple.com>

Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
nightly (20866)

https://bugs.webkit.org/show_bug.cgi?id=20866

Reviewed by Oliver Hunt.

  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::AXObjectCache): Changed to take a pointer to its owner document. This is used by AXObjectCache::handleFocusedUIElementChanged(). (WebCore::AXObjectCache::focusedUIElementForPage): Code moved from AccessibilityRenderObject::focusedUIElement(). Modified to be a static function and to take a pointer to a Page. (WebCore::AXObjectCache::platformGenerateAXID): Moved the code to generate the next AXID from getAXID() to here. Added a #if to make this non-WIN only, because Windows has its own implementation. (WebCore::AXObjectCache::getAXID): Ensure that we generate a positive AXID, ranging from 1 to LONG_MAX.
  • accessibility/AXObjectCache.h: Add a declaration for Document and Page. Removed the declaration of AccessibilityObject, because we include the header. Reordered the declaration of Node alphabetically. Moved the typedef for AXID to AccessibilityObject. Removed some trailing whitespace. Added a member variable to hold a pointer to the owner Document. (WebCore::AXObjectCache::AXObjectCache): Changed to take a pointer to its owner Document. (WebCore::AXObjectCache::focusedUIElementForPage): Added; code moved from AccessiblityRenderObject::focusedUIElement(). Returns the focused element with respect to accessibility. (WebCore::AXObjectCache::platformGenerateAXID): Declare a function to generate an AXID. (WebCore::AXObjectCache::objectFromAXID): Return the AccessibilityObject with the given AXID.
  • accessibility/AccessibilityObject.h: Moved the typedef for AXID from AXObjectCache to here. Made the m_id member use the typedef. (WebCore::AccessibilityObject::axObjectID): Changed the return type to use the typedef. (WebCore::AccessibilityObject::setAXObjectID): Changed the argument type to use the typedef.
  • accessibility/AccessibilityRenderObject.cpp: Removed some unneeded #includes. (WebCore::AccessibilityRenderObject::focusedUIElement): Moved the code to AXObjectCache::focusedUIElementForPage(), which we now call.
  • accessibility/win/AXObjectCacheWin.cpp: (WebCore::AXObjectCache::platformGenerateAXID): Ensure that we generate an AXID that is in the range 1 to LONG_MAX. (WebCore::AXObjectCache::handleFocusedUIElementChanged): If the Document has no Page, return. If the Page has not focused element (respecting accessibility), return. Assert that the accessibility of the focused element is not ignored, and that the object's AXID will be negative and fit into a LONG when negated. Broadcast a focus event for the object.
  • dom/Document.cpp: (WebCore::Document::axObjectCache): Pass this when creating the AXObjectCache. (WebCore::Document::setFocusedNode): Call AXObjectCache::handleFocusedUIElementChanged() on Windows.

WebKit/win:

2009-08-13 Jon Honeycutt <jhoneycutt@apple.com>

Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
nightly (20866)

https://bugs.webkit.org/show_bug.cgi?id=20866

Reviewed by Oliver Hunt.

  • AccessibleBase.cpp: (AccessibleBase::getAccessibilityObjectForChild): If the child ID is negative, negate it and treat it as an AXID.
23:08 Changeset [47310] by jmalonzo@webkit.org
  • 7 edits
    1 add in trunk

2009-08-14 Jiahua Huang <jhuangjiahua@gmail.com>

Reviewed by Jan Alonzo.

[gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028

Remove the improper set of enum WebKitWebViewTargetInfo
by grabbing the target infos via m_helper.

  • manual-tests/gtk/copy-htmltext.html: Added.
  • platform/Pasteboard.h:
  • platform/gtk/PasteboardGtk.cpp: (WebCore::clipboard_get_contents_cb):
  • platform/gtk/PasteboardHelper.h:

Add a function in WebKit::PasteboardHelperGtk that will return the
value of WEBKIT_WEB_VIEW_TARGET_INFO_HTML,
and WebCore::clipboard_get_contents_cb will use that.

  • WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::getWebViewTargetInfoHtml):
  • WebCoreSupport/PasteboardHelperGtk.h:
22:19 Changeset [47309] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>

Rubber-stamped by Gustavo Noronha.

Initialize CFLAGS and CXXFLAGS before the main body of the
WEBKIT_INIT macro so C files don't get built with "-g -O2".

  • autotools/webkit.m4:
19:53 Changeset [47308] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

Not reviewed, adding new test to Skipped on gtk and Qt.
DRT on these ports does not yet support layoutTestController.overridePreference.

  • platform/gtk/Skipped: skip LayoutTests/fast/harness/use-page-cache.html
  • platform/qt/Skipped: ditto.
18:36 Changeset [47307] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore
  • parser/Parser.h:

(JSC::EvalExecutable::parse):
(JSC::ProgramExecutable::parse):

  • runtime/Executable.h:

Reviewed by NOBODY (build fix).

18:20 Changeset [47306] by dimich@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=28324
First ever test using page cache!
The test verifies that override setting that enables page cache works correctly.
It navigates forward and then back and checks that onload is not fired again
but the timer continues firing.

Reviewed by Eric Seidel.

  • fast/harness/resources/cached-page-1.html: Added.
  • fast/harness/resources/cached-page-2.html: Added.
  • fast/harness/use-page-cache-expected.txt: Added.
  • fast/harness/use-page-cache.html: Added.
18:14 Changeset [47305] by simon.fraser@apple.com
  • 4 edits in trunk/WebCore

2009-08-14 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Fix an assertion when bringing up the Inspector.
https://bugs.webkit.org/show_bug.cgi?id=28318

The fix for bug 28295 assumed that image clients count the number of times
addClient/removeClient is called. That was true for CachedResource clients,
but not StyleGeneratedImage clients, which pass the call onto CSSImageGeneratorValue.

Fix by making CSSImageGeneratorValue count the number of times a client is
added/removed.

  • css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::canvasChanged): (WebCore::CSSCanvasValue::canvasResized):
  • css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::addClient): (WebCore::CSSImageGeneratorValue::removeClient): (WebCore::CSSImageGeneratorValue::getImage):
  • css/CSSImageGeneratorValue.h:
18:14 Changeset [47304] by barraclough@apple.com
  • 19 edits
    1 add in trunk/JavaScriptCore

Remove AST nodes from use within the Runtime (outside of parsing), stage 1
https://bugs.webkit.org/show_bug.cgi?id=28330

Reviewed by Oliver Hunt.

Remove the EvalNode and ProgramNode from use in the runtime. They still exist
after this patch, but are hidden behind EvalExecutable and FunctionExecutable,
and are also still reachable behind CodeBlock::m_ownerNode.

The next step will be to beat back FunctionBodyNode in the same fashion.
Then remove the usage via CodeBlock, then only construct these nodes only on
demand during bytecode generation.

(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::GlobalCodeBlock::~GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::NativeCodeBlock::NativeCodeBlock):

  • bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::get):

  • debugger/Debugger.cpp:

(JSC::evaluateInGlobalCallFrame):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluate):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):

  • interpreter/Interpreter.h:
  • parser/Nodes.cpp:

(JSC::FunctionBodyNode::createNativeThunk):
(JSC::FunctionBodyNode::generateBytecode):
(JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):

  • parser/Parser.h:

(JSC::Parser::parse):
(JSC::Parser::reparse):
(JSC::Parser::parseFunctionFromGlobalCode):
(JSC::::parse):

  • runtime/Completion.cpp:

(JSC::checkSyntax):
(JSC::evaluate):

  • runtime/Error.cpp:

(JSC::throwError):

  • runtime/Error.h:
  • runtime/Executable.h: Added.

(JSC::TemplateExecutable::TemplateExecutable):
(JSC::TemplateExecutable::markAggregate):
(JSC::TemplateExecutable::sourceURL):
(JSC::TemplateExecutable::lineNo):
(JSC::TemplateExecutable::bytecode):
(JSC::TemplateExecutable::jitCode):
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

  • runtime/FunctionConstructor.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::numericCompareFunction):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::markChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::codeBlocks):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

16:25 Changeset [47303] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Build fix.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::enumerate): Add the necessary .get() calls.

16:21 Changeset [47302] by beidson@apple.com
  • 4 edits in trunk

WebKit/mac: <rdar://problem/7091546> - Assertion failure in plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream.html
on 64-bit SnowLeopard

Reviewed by Anders Carlsson.

  • Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::cancelLoad): Since this might be called while the FrameLoader is switching DocumentLoaders

during the brief moment where there is no activeDocumentLoader(), accept and handle a validly null DocumentLoader.

LayoutTests: <rdar://problem/7091546> - Re-enable 3 plugins tests that now won't crash

Reviewed by Anders Carlsson.

  • platform/mac-snowleopard/Skipped:
16:18 Changeset [47301] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix leaks of NSNumber and NSMutableArray objects seen during layout tests.

Reviewed by Brady Eidson.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::enumerate): Don't leak an NSMutableArray that we allocate.

16:18 Changeset [47300] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix leaks of HostedNetscapePluginStream and NetscapePlugInStreamLoader objects seen during layout tests.

Reviewed by Anders Carlsson.

  • Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::didFail): Disconnect the stream from the plug-in instance proxy
when the load fails.

15:06 Changeset [47299] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Correct libcurl crash when downloading local files.
https://bugs.webkit.org/show_bug.cgi?id=28312

Reviewed by Kevin Ollivier.

No new tests. Test is covered by fast/encoding/char-encoding-mac.html.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::handleLocalReceiveResponse): New static function that

performs the local setting of valid URL and firing didReceiveResponse.
This code was moved from writeCallback.

(WebCore::writeCallback): Move local file handling to static function

(above) and use the function instead.

(WebCore::readCallback): Add check

for responseFired, and handle as a local file if it was not.

14:54 Changeset [47298] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Adding two more to the skipped list.
Radars 7144571 and 7144583 track exploring them.

  • platform/mac-snowleopard/Skipped:
13:54 Changeset [47297] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Disable media/controls-drag-timebar.html on SnowLeopard.
<rdar://problem/7144385> tracks exploring the failure.

  • platform/mac-snowleopard/Skipped:
13:52 Changeset [47296] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-08-14 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Oliver Hunt.

[Haiku] Fix RenderThemeHaiku build.
https://bugs.webkit.org/show_bug.cgi?id=28307

  • platform/haiku/RenderThemeHaiku.cpp: Included RenderThemeHaiku.h instead of RenderTheme.h. (WebCore::RenderThemeHaiku::paintCheckbox): Removed the wrong 'virtual' before the function. (WebCore::RenderThemeHaiku::paintRadio): Removed the wrong 'virtual' before the function.
  • platform/haiku/RenderThemeHaiku.h: Corrected wrong function definitions.
13:35 Changeset [47295] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2009-08-14 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Oliver Hunt.

[Haiku] Adding SharedBufferHaiku to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=28309

  • platform/haiku/SharedBufferHaiku.cpp: Added. (WebCore::SharedBuffer::createWithContentsOfFile):
  • platform/haiku/TemporaryLinkStubs.cpp: Removed unnecessary headers and functions. (WebCore::signedPublicKeyAndChallengeString): (WebCore::getSupportedKeySizes):
13:29 Changeset [47294] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-14 Eric Seidel <eric@webkit.org>

No review. Fix 5-space indent to be 4-spaces.

  • Scripts/bugzilla-tool:
13:20 Changeset [47293] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2009-08-14 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Ensure we're getting the right v8 context in the V8 DOMWindowEvent custom getter.

https://bugs.webkit.org/show_bug.cgi?id=28311

This should fix Chromium failing LayoutTests/fast/events/set-event-in-another-frame.html.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER):
13:18 Changeset [47292] by oliver@apple.com
  • 10 edits in trunk

[ES5] Arguments object should inherit from Array
https://bugs.webkit.org/show_bug.cgi?id=28298

Reviewed by Gavin Barraclough

Make the Arguments object conform to the behaviour specified in ES5.
The simple portion of this is to make Arguments use Array.prototype
as its prototype rather than Object.prototype.

The spec then requires us to set instance.constructor to the pristine
Object constructor, and instance.toString and instance.toLocaleString
to the pristine versions from Object.prototype. To do this we now
make the ObjectPrototype constructor return its toString and
toLocaleString functions (similar to the call and apply functions
from FunctionPrototype).

Oddly enough this reports itself as a slight win, but given the code
isn't hit in the tests that claim to have improved I put this down to
code motion.

12:25 Changeset [47291] by eric@webkit.org
  • 11 edits in trunk/WebCore

2009-08-14 Aaron Boodman <aa@chromium.org>

Reviewed by Alexey Proskuryakov.

BUG 28134: Move the remaining parts of Access Control from XMLHttpRequest to ThreadableDocumentLoader.
https://bugs.webkit.org/show_bug.cgi?id=28134

No new tests added since Access Control was already well tested and this is a pure refactor.

  • loader/DocumentThreadableLoader.cpp: Move a lot of the access control code from XHR in, preserving its basic strategy. Also, modify the synchronous path to not be a special case, but reuse more of the async path.

(WebCore::DocumentThreadableLoader::loadResourceSynchronously): Go through the async path and pass additional flags.
(WebCore::DocumentThreadableLoader::create): Group enum params into an options struct.
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Ditto.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Brought mostly from XHR.
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight): Ditto.
(WebCore::DocumentThreadableLoader::willSendRequest): Handle preflight case.
(WebCore::DocumentThreadableLoader::didReceiveResponse): Ditto.
(WebCore::DocumentThreadableLoader::didFinishLoading): Ditto.
(WebCore::DocumentThreadableLoader::getShouldUseCredentialStorage): Ditto.
(WebCore::DocumentThreadableLoader::preflightSuccess): Preflight handling.
(WebCore::DocumentThreadableLoader::preflightFailure): Ditto.
(WebCore::DocumentThreadableLoader::loadRequest): Common request function that handles async/sync.

  • loader/DocumentThreadableLoader.h: Group enum params into an options struct.
  • loader/ThreadableLoader.cpp: Ditto. (WebCore::ThreadableLoader::create): Ditto. (WebCore::ThreadableLoader::loadResourceSynchronously): Ditto.
  • loader/ThreadableLoader.h: Ditto. (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Ditto.
  • loader/WorkerThreadableLoader.cpp: Ditto. (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):Ditto. (WebCore::WorkerThreadableLoader::loadResourceSynchronously): Ditto. (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Ditto. (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): Ditto.
  • loader/WorkerThreadableLoader.h: Ditto. (WebCore::WorkerThreadableLoader::create): Ditto.
  • platform/CrossThreadCopier.h: Allow ThreadableLoaderOptions to be copied across threads. (WebCore::):
  • workers/WorkerScriptLoader.cpp: More enum->struct grouping. (WebCore::WorkerScriptLoader::loadSynchronously): More enum->struct grouping. (WebCore::WorkerScriptLoader::loadAsynchronously): More enum->struct grouping.
  • xml/XMLHttpRequest.cpp: Remove all the access control code and some supporting state. (WebCore::XMLHttpRequest::XMLHttpRequest): Ditto. (WebCore::XMLHttpRequest::createRequest): Ditto. (WebCore::XMLHttpRequest::didFinishLoading): Ditto. (WebCore::XMLHttpRequest::didReceiveResponse): Ditto. (WebCore::XMLHttpRequest::didReceiveData): Ditto.
  • xml/XMLHttpRequest.h: Ditto.
11:49 Changeset [47290] by darin@apple.com
  • 2 edits in trunk/JavaScriptGlue

Rename the confusing isObject(<class>) to inherits(<class>).
It still works on non-objects, returning false.

Patch by Darin Adler <darin@apple.com> on 2009-08-14
Reviewed by Sam Weinig.

  • JSUtils.cpp:

(KJSValueToJSObject):
(KJSValueToCFTypeInternal):
Changed from isObject to inherits.

11:25 Changeset [47289] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

Remove media/video-played.html from the Windows skipped list, fixed
as part of https://bugs.webkit.org/show_bug.cgi?id=28275. Add
media/video-played-collapse.html for now.


https://bugs.webkit.org/show_bug.cgi?id=28275

  • platform/win/Skipped:
11:12 Changeset [47288] by darin@apple.com
  • 26 edits in trunk

JavaScriptCore: Rename the confusing isObject(<class>) to inherits(<class>).
It still works on non-objects, returning false.

Patch by Darin Adler <darin@apple.com> on 2009-08-14
Reviewed by Sam Weinig.

  • runtime/ArrayConstructor.cpp:

(JSC::arrayConstructorIsArray): Removed unneeded isObject call
and updated remaining isObject call to new name, inherits.

  • runtime/JSCell.h: Renamed isObject(<class>) to inherits(<class>)

but more importantly, made it non-virtual (it was already inline)
so it is now as fast as JSObject::inherits was.

  • runtime/JSObject.h: Removed inherits function since the one

in the base class is fine as-is. Also made various JSCell functions
that should not be called on JSObject uncallable by making them
both private and not implemented.
(JSC::JSCell::inherits): Updated name.
(JSC::JSValue::inherits): Ditto.

  • debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncConcat):

  • runtime/BooleanPrototype.cpp:

(JSC::booleanProtoFuncToString):
(JSC::booleanProtoFuncValueOf):

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToLocaleString):
(JSC::dateProtoFuncToLocaleDateString):
(JSC::dateProtoFuncToLocaleTimeString):
(JSC::dateProtoFuncGetTime):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetMilliSeconds):
(JSC::dateProtoFuncGetUTCMilliseconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::dateProtoFuncSetTime):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::argumentsGetter):

  • runtime/JSValue.h:
  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncTest):
(JSC::regExpProtoFuncExec):
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):

  • runtime/ScopeChain.cpp:

(JSC::ScopeChain::localDepth):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncToString):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSplit):
Updated to new name, inherits, from old name, isObject.

WebCore: Rename the confusing isObject(<class>) to inherits(<class>).
It still works on non-objects, returning false.

Patch by Darin Adler <darin@apple.com> on 2009-08-14
Reviewed by Sam Weinig.

  • bindings/js/JSEventTarget.cpp:

(WebCore::toEventTarget):

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::createPositionCallback):
(WebCore::createPositionErrorCallback):

  • bindings/js/JSNodeFilterCustom.cpp:

(WebCore::toNodeFilter):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessor::importStylesheet):
(WebCore::JSXSLTProcessor::transformToFragment):
(WebCore::JSXSLTProcessor::transformToDocument):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::callObjCFallbackObject):

  • bridge/runtime_method.cpp:

(JSC::callRuntimeMethod):
Updated to new name, inherits, from old name, isObject.

10:58 Changeset [47287] by eric.carlson@apple.com
  • 4 edits
    2 moves in trunk/LayoutTests

2009-08-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

media/video-played.html always times out on Windows
https://bugs.webkit.org/show_bug.cgi?id=28275

  • media/video-played-collapse.html:

Make sub-test assumptions obvious for someone reading this later.

  • media/video-played.html: Removed.
  • media/video-played-expected.txt: Removed.
  • media/video-played-ranges-1-expected.txt: Copied from LayoutTests/media/video-played-expected.txt.
  • media/video-played-ranges-1.html: Copied from LayoutTests/media/video-played.html.

Split video-played.html into video-played-ranges-1.html and video-played-ranges-2.html.

  • media/video-played-reset.html:

Make sub-test assumptions obvious for someone reading this later.

  • media/video-played.js: (logRanges):

New but not currently called. Allows all ranges to be logged for debugging.

(testRanges):

Log ranges and the amount of time each test takes when logTestTiming != 0.

(nextTest):

Record test start time when logTestTiming is true;

(startPlaying):

Run each sub-test for 100ms instead of 250ms to decrease overall test time.

(playForMillisecs.callPauseIfTimeIsReached):
(playForMillisecs):

Make error conditions trigger immediate failure instead of just logging.

08:51 Changeset [47286] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-08-14 Benjamin Otte <otte@gnome.org>

Reviewed by Gustavo Noronha.

Fix webkit_web_view_set_highlight_text_matches() so that highlighting
works properly in documents with frames.

  • webkit/webkitwebview.cpp: (webkit_web_view_set_highlight_text_matches):
07:50 Changeset [47285] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

RVCT elftran fails to resolve QPainter::staticMetaObject coming with
QWebView::RenderHints property.

Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-08-14
Reviewed by Simon Hausmann.

This is a temporary fix and will be revereted when the right symbols
exported from Qt lib in S60.

https://bugs.webkit.org/show_bug.cgi?id=28181

  • Api/qwebview.h:
07:44 Changeset [47284] by hausmann@webkit.org
  • 4 edits in trunk

Adding QNX as a platform. Currently only tested with Qt.

Patch by Harald Fernengel <harald.fernengel@nokia.com> on 2009-07-31
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=27885

  • JavaScriptCore/runtime/Collector.cpp: Added retrieving of stack base since QNX doesn't have the pthread _nt functions
  • JavaScriptCore/wtf/Platform.h: Added WTF_PLATFORM_QNX and corresponding defines
  • WebCore/bridge/npapi.h: Build fix for missing typedefs on QNX
07:21 Changeset [47283] by hausmann@webkit.org
  • 8 edits in trunk

WebKit/qt: [Qt] Public API to configure the storage path for HTML5 localStorage
https://bugs.webkit.org/show_bug.cgi?id=28036

Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2009-08-14
Reviewed by Simon Hausmann.

Disables LocalStorage for QtWebKit by default by setting
QWebSettings::LocalStorageEnabled to false.

Sets up a default for the LocalStorage path so that clients would only
need to enable the LocalStorageEnabled setting to turn on LocalStoragre
support.

Turn on LocalStorage support for QtLauncher and the relevant test
since LocalStorage is now disabled by default for QtWebkit.

  • Api/qwebpage.cpp:

(defaultCachePath):
(initializeApplicationCachePathIfNecessary):
(QWebPagePrivate::QWebPagePrivate):

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
(QWebSettings::setLocalStoragePath):
(QWebSettings::localStoragePath):

  • Api/qwebsettings.h:
  • QtLauncher/main.cpp:

(main):

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::multiplePageGroupsAndLocalStorage):

WebKitTools: [Qt] Public API to configure the storage path for HTML5 localStorage
https://bugs.webkit.org/show_bug.cgi?id=28036

Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2009-08-14
Reviewed by Simon Hausmann.

Turn on LocalStorage support for Qt DumpRenderTree since
LocalStorage is now disabled by defult for QtWebkit.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::WebPage):

07:19 Changeset [47282] by yael.aharon@nokia.com
  • 7 edits in trunk

WebCore: Allow Qt API to list and to remove URL schemes that were registered as
local URL schemes.
[Qt] Allow applications to register their own local URL scheme.
https://bugs.webkit.org/show_bug.cgi?id=28240

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-08-14
Reviewed by Simon Hausmann.

05:54 Changeset [47281] by hausmann@webkit.org
  • 2 edits in trunk/PlanetWebKit

Add the blog of University of Szeged.
https://bugs.webkit.org/show_bug.cgi?id=28301

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.

  • config.ini:
05:05 Changeset [47280] by xan@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-14 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

Do not unref the main webview, it's owned by its parent
container. Instead destroy the container, which should take care
of everything (not terribly important since we exit right after
that, but still).

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (main):
05:01 Changeset [47279] by ariya@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-08-14 Ariya Hidayat <ariya.hidayat@nokia.com>

Rubber-stamped by Tor Arne Vestbø.

[Qt] Add test result after r47255.

  • platform/qt/fast/block/float/avoidance-percent-width-compat-expected.txt: Added.
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt: Added.
04:49 Changeset [47278] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

Currently generic ARM and ARMv7 platforms work only with JSVALUE32
https://bugs.webkit.org/show_bug.cgi?id=28300

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.

  • wtf/Platform.h:
04:39 Changeset [47277] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2009-08-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Wrap console objects late (in the frontend) so that injected
script was already in place.

https://bugs.webkit.org/show_bug.cgi?id=28297

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::setFrontendProxyObject):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend): (WebCore::InspectorFrontend::addMessageToConsole):
  • inspector/InspectorFrontend.h:
03:56 Changeset [47276] by vestbo@webkit.org
  • 1 edit in trunk/JavaScriptCore/runtime/ArrayConstructor.cpp

Try to fix the build when !JIT_OPTIMIZE_NATIVE_CALL

03:12 Changeset [47275] by ariya@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2009-08-14 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Update test result after r47255.
Also while I am at it, add pixel test result.

  • platform/qt/fast/block/float/035-expected.checksum: Added.
  • platform/qt/fast/block/float/035-expected.png: Added.
  • platform/qt/fast/block/float/035-expected.txt: Adjusted.
02:17 Changeset [47274] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

Enable JIT on ARM for QT by default
https://bugs.webkit.org/show_bug.cgi?id=28259

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.

  • wtf/Platform.h:
02:17 Changeset [47273] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

Enable YARR_JIT on ARM for QT by default
https://bugs.webkit.org/show_bug.cgi?id=28259

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.

  • wtf/Platform.h:
00:09 Changeset [47272] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Remove MarkStack::drain from the JSC exports file

MarkStack::drain is now marked inline, the including it in the exports file
produces an ld warning

00:00 Changeset [47271] by oliver@apple.com
  • 6 edits
    3 adds in trunk

[ES5] Implement Array.isArray
https://bugs.webkit.org/show_bug.cgi?id=28296

Reviewed by Maciej Stachowiak

Add support for Array.isArray to the Array constructor

08/13/09:

23:22 Changeset [47270] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2009-08-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Fix logic in RenderObject::updateFillImages() that led to incorrect client
counts if an image was used twice in the background-image property.
https://bugs.webkit.org/show_bug.cgi?id=28295

Test: fast/backgrounds/multiple-backgrounds-assert.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::updateFillImages): Simplify the logic to call addClient()/removeClient() for every background image, but go through the new layers first to avoid removing all the clients of an image.
23:11 Changeset [47269] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Remove accidentally left in debugging statement.

Reviewed by Oliver Hunt.

  • runtime/JSArray.h:

(JSC::MarkStack::drain):

22:41 Changeset [47268] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Attempt to fix windows build

22:35 Changeset [47267] by oliver@apple.com
  • 31 edits in trunk

Devirtualise marking
https://bugs.webkit.org/show_bug.cgi?id=28294

Reviewed by Maciej Stachowiak.

Add a bit to TypeInfo to indicate that an object uses the standard
JSObject::markChildren method. This allows us to devirtualise marking
of most objects (though a branch is still needed). We also add a branch
to identify arrays thus devirtualising marking in that case as well.

In order to make the best use of this devirtualisation I've also reworked
the MarkStack::drain() logic to make the iteration more efficient.

21:31 Changeset [47266] by jmalonzo@webkit.org
  • 4 edits in trunk

Revert "2009-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>"

Revert http://trac.webkit.org/changeset/47203 as it makes the http/XHR tests fail.

18:15 Changeset [47265] by darin@apple.com
  • 8 edits
    1 delete in trunk

JavaScriptCore: Some small bits of housekeeping.

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by Mark Rowe.

project instead of private. Remove JSONObject.lut.h.

  • assembler/ARMAssembler.h: Remove unneeded WTF prefix.
  • assembler/AssemblerBufferWithConstantPool.h: Ditto.
  • bytecompiler/BytecodeGenerator.h: Ditto.
  • wtf/SegmentedVector.h: Add a "using" statement as we do

with the other WTF headers.

WebCore: Follow-up to earlier work to remove dependencies on JavaScriptCore.

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by Mark Rowe.

  • ForwardingHeaders/parser/Parser.h: Removed.
  • inspector/JavaScriptDebugServer.cpp: Removed now-unneeded includes

of Parser.h.

18:11 Changeset [47264] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix Tiger build.

Patch by Darin Adler <darin@apple.com> on 2009-08-13

  • parser/Grammar.y: Use a template function so we can compile

setStatementLocation even if it comes before YYLTYPE is defined.

17:58 Changeset [47263] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

Too much use of void* in Grammar.y
https://bugs.webkit.org/show_bug.cgi?id=28287

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by George Staikos.

  • parser/Grammar.y: Changed all the helper functions to

take a JSGlobalData* instead of a void*. A couple formatting
tweaks that I missed when breaking this into pieces.

17:56 Changeset [47262] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

Another part of https://bugs.webkit.org/show_bug.cgi?id=28287

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by George Staikos.

  • parser/Grammar.y: Reduced and sorted includes. Tweaked comment

format. Marked a few more functions inline.

17:52 Changeset [47261] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore: 'box-orient: block-axis' behaves like 'box-orient: horizontal', causes
an assertion failure in debug builds
https://bugs.webkit.org/show_bug.cgi?id=28279

Reviewed by Eric Seidel.

Test: fast/flexbox/block-axis.html

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator EBoxOrient): Map block-axis to
vertical.

LayoutTests: 2009-08-13 Dan Bernstein <mitz@apple.com>

Reviewed by Eric Seidel.

'box-orient: block-axis' behaves like 'box-orient: horizontal', causes
an assertion failure in debug builds
https://bugs.webkit.org/show_bug.cgi?id=28279

  • fast/flexbox/block-axis-expected.checksum: Added.
  • fast/flexbox/block-axis-expected.png: Added.
  • fast/flexbox/block-axis-expected.txt: Added.
  • fast/flexbox/block-axis.html: Added.
17:51 Changeset [47260] by simon.fraser@apple.com
  • 4 edits
    2 adds in trunk

2009-08-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Fix crash when removing reflection on an absolutely-positioned image.
https://bugs.webkit.org/show_bug.cgi?id=28289

Make sure we clean up the reflection layer when removing the reflection,
so that the RenderLayer tree does not contain pointers to deleted layers.

Test: fast/reflections/reflected-img-crash.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::styleChanged): (WebCore::RenderLayer::removeReflection):
  • rendering/RenderLayer.h:
17:49 Changeset [47259] by darin@apple.com
  • 4 edits in trunk/JavaScriptCore

Another part of https://bugs.webkit.org/show_bug.cgi?id=28287

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by George Staikos.

  • parser/Grammar.y: Pass the number to the PropertyNode instead of

first turning it into an Identifier.

  • parser/NodeConstructors.h:

(JSC::PropertyNode::PropertyNode): Add an overload that takes a double
so the code to convert to a string can be here instead of Grammar.y.

  • parser/Nodes.h: Ditto.
17:47 Changeset [47258] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

Another part of https://bugs.webkit.org/show_bug.cgi?id=28287

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by George Staikos.

  • parser/Grammar.y: Eliminate the DBG macro.
17:46 Changeset [47257] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

Another part of https://bugs.webkit.org/show_bug.cgi?id=28287

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by George Staikos.

  • parser/Grammar.y: Eliminate the SET_EXCEPTION_LOCATION macro.
17:44 Changeset [47256] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

George asked me to break the patch from
https://bugs.webkit.org/show_bug.cgi?id=28287
into smaller pieces and land it in stages.

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by George Staikos.

  • parser/Grammar.y: Eliminate the LEXER macro.
17:40 Changeset [47255] by mitz@apple.com
  • 18 edits
    8 adds in trunk

WebCore: misalignment because of float:left of <div> tag
https://bugs.webkit.org/show_bug.cgi?id=15869

Reviewed by Simon Fraser.

One section of http://edgar.sec.gov site draws to the right of the rest
of the content
<rdar://problem/7135951>

Tests: fast/block/float/avoidance-percent-width-compat.html

fast/block/float/avoidance-percent-width-strict.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::getClearDelta): Changed to apply the same float

avoidance logic in strict mode and in compatibility mode, which
matches Firefox and IE. Changed to compute and use the computed
width of the child, instead of ignoring non-fixed widths.

LayoutTests: misalignment because of float:left of <div> tag
https://bugs.webkit.org/show_bug.cgi?id=15869

Reviewed by Simon Fraser.

One section of http://edgar.sec.gov site draws to the right of the rest
of the content
<rdar://problem/7135951>

  • fast/block/float/avoidance-percent-width-compat.html: Added.
  • fast/block/float/avoidance-percent-width-strict.html: Added.
  • platform/mac/fast/block/float/035-expected.checksum:
  • platform/mac/fast/block/float/035-expected.png:
  • platform/mac/fast/block/float/035-expected.txt:
  • platform/mac/fast/block/float/avoidance-percent-width-compat-expected.checksum: Added.
  • platform/mac/fast/block/float/avoidance-percent-width-compat-expected.png: Added.
  • platform/mac/fast/block/float/avoidance-percent-width-compat-expected.txt: Added.
  • platform/mac/fast/block/float/avoidance-percent-width-strict-expected.checksum: Added.
  • platform/mac/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
  • platform/mac/fast/block/float/avoidance-percent-width-strict-expected.txt: Added.
  • platform/mac/fast/block/float/float-avoidance-expected.checksum:
  • platform/mac/fast/block/float/float-avoidance-expected.png:
  • platform/mac/fast/block/float/float-avoidance-expected.txt:
  • platform/mac/fast/overflow/004-expected.checksum:
  • platform/mac/fast/overflow/004-expected.png:
  • platform/mac/fast/overflow/004-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug106158-1-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug106158-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug106158-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug106158-2-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug106158-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug106158-2-expected.txt:
17:14 Changeset [47254] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-13 Eric Seidel <eric@webkit.org>

No review, only skipping tests.

Qt: Font Sizes are wrong for font families including monospace
https://bugs.webkit.org/show_bug.cgi?id=28288

  • platform/qt/Skipped:
16:34 Changeset [47253] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-13 Eric Seidel <eric@webkit.org>

No review, correcting obvious python error seen in the commit queue.

args can be a string or an array. Assuming args is always an array results in
double-spaced text in error logs.

  • Scripts/bugzilla-tool:
16:34 Changeset [47252] by darin@apple.com
  • 5 edits
    3 adds in trunk

WebCore: Geolocation PositionOptions does not use correct default values.
https://bugs.webkit.org/show_bug.cgi?id=27254

Patch by Steve Block <steveblock@google.com> on 2009-08-13
Reviewed by Darin Adler.

Sets the correct default values for the properties of the PositionOptions object
passed to Geolocation methods. See http://www.w3.org/TR/geolocation-API/.

Also adds checking to throw an exception if arguments of the incorrect type are
passed to Geolocation methods. Adds a layout test to test this. This test should
pass on all platforms where Geolocation is implemented.

Test: fast/dom/Geolocation/argument-types.html

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::createPositionCallback): Added. Creates the callback.
(WebCore::createPositionErrorCallback): Added. Creates the calback.
(WebCore::createPositionOptions): Added. Creates the PositionOptions object, setting defaults where required.
(WebCore::JSGeolocation::getCurrentPosition): Modified. Now uses above helper functions.
(WebCore::JSGeolocation::watchPosition): Modified. Now uses above helper functions.

  • page/Geolocation.cpp:

(WebCore::Geolocation::GeoNotifier::GeoNotifier): Modified. Asserts that PositionOptions object is present.
(WebCore::Geolocation::GeoNotifier::startTimer): Modified. Only starts timer if timeout has been set.

  • page/PositionOptions.h:

(WebCore::PositionOptions::create): Modified. Creates object with default values.
(WebCore::PositionOptions::timeout): Modified. Uses correct type.
(WebCore::PositionOptions::hasTimeout): Added. Determines whether a timeout has been set.
(WebCore::PositionOptions::setTimeout): Modified. Uses correct type.
(WebCore::PositionOptions::maximumAge): Modified. Uses correct type.
(WebCore::PositionOptions::setMaximumAge): Modified. Uses correct type.
(WebCore::PositionOptions::PositionOptions): Modified. Creates object with default values.

LayoutTests: Geolocation PositionOptions does not use correct default values.
https://bugs.webkit.org/show_bug.cgi?id=27254

Patch by Steve Block <steveblock@google.com> on 2009-08-13
Reviewed by Darin Adler.

Adds a layout test to check the acceptable types for arguments to Geolocation methods.

  • fast/dom/Geolocation/resources/argument-types.js: Added. Tests the types of the arguments that can be passed to Geolocation methods.
  • fast/dom/Geolocation/argument-types.html: Added. HTML wrapper for above JS test.
  • fast/dom/Geolocation/argument-types-expected.txt: Added. Expected output for above test.
16:31 Changeset [47251] by eric@webkit.org
  • 1 edit
    3 deletes in trunk/LayoutTests

2009-08-13 Eric Seidel <eric@webkit.org>

Rubber-stamped by Mark Rowe.

wrong font size when css font-family includes monospace
https://bugs.webkit.org/show_bug.cgi?id=19161

Removing results which are expected to change, but that I have no way to update.

  • platform/mac-tiger/fast/text/monospace-width-cache-expected.checksum: Removed.
  • platform/mac-tiger/fast/text/monospace-width-cache-expected.png: Removed.
  • platform/qt/fast/text/monospace-width-cache-expected.txt: Removed.
16:28 Changeset [47250] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-13 Eric Seidel <eric@webkit.org>

No review, it is expected that this would change.

wrong font size when css font-family includes monospace
https://bugs.webkit.org/show_bug.cgi?id=19161

Update Tiger results from the bot. I have no way to update the pixel results.

  • platform/mac-tiger/fast/text/monospace-width-cache-expected.txt:
16:24 Changeset [47249] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-08-13 David Levin <levin@chromium.org>

Unreviewed chromium build fix.

[Chromium] Let CodeGeneratorV8.pm know that RGBColor is ref-counted.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
16:23 CommitQueue edited by eric@webkit.org
(diff)
16:18 CommitQueue edited by eric@webkit.org
(diff)
16:08 CommitQueue edited by eric@webkit.org
(diff)
16:05 CommitQueue edited by eric@webkit.org
(diff)
16:04 CommitQueue edited by eric@webkit.org
(diff)
16:01 CommitQueue edited by eric@webkit.org
(diff)
15:59 CommitQueue created by eric@webkit.org
15:55 Changeset [47248] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-13 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Merge error in SharedWorker code
https://bugs.webkit.org/show_bug.cgi?id=28277

Fixed merge error that prevents WebKit from compiling with SHARED_WORKERS enabled.
No new tests needed.

  • workers/DefaultSharedWorkerRepository.cpp: Removed duplicated functions.
15:54 WikiStart edited by eric@webkit.org
Add a link to the new commit queue page. (diff)
15:48 Changeset [47247] by ajwong@chromium.org
  • 2 edits in trunk/WebCore

Chromium: Show a "Playback Disabled" button on media error.
https://bugs.webkit.org/show_bug.cgi?id=28196
Use a disabled play button when the media file cannot be played.

Patch by Kyle Prete <kylep@chromium.org> on 2009-08-13
Reviewed by Dave Levin.

No new tests needed. Covered by LayoutTests/media/video-empty-source.html

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintMediaPlayButton):

15:46 Changeset [47246] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Try some more to fix the Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export a new symbol.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Ditto.
15:45 Changeset [47245] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed build fix. Include stdio.h for using stdout, stderr,
and fprintf.

  • DumpRenderTree/LayoutTestController.cpp:
15:42 Changeset [47244] by mrowe@apple.com
  • 4 edits in trunk

Try and fix the Qt build.

15:38 Changeset [47243] by eric@webkit.org
  • 5 edits in trunk/WebKit/gtk

2009-08-13 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642

Adds support for drag actions in WebKitWebView and DragClient.

Defines a support structure that can hold additional drag and drop data,
such as selection data or target IDs (infos) and can be passed through
clipboard requests.

Implements DragClient functions that gather start position of the drag
and start the GTK drag.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::DragClient): (WebKit::DragClient::willPerformDragSourceAction): (WebKit::DragClient::startDrag): (WebKit::DragClient::createDragImageForLink): A small style fix.
  • WebCoreSupport/DragClientGtk.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_drag_end): (clipboard_contents_received): GtkClipboard callback. (webkit_web_view_drag_data_get): (webkit_web_view_class_init): (webkit_web_view_init):
  • webkit/webkitwebview.h: Add GTK selection targets.
15:38 Changeset [47242] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Try and fix the Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export a new symbol.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Ditto.
15:31 Changeset [47241] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-08-13 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642

Utilizes functions that are being called upon drag and drop actions.
Uses different GTK clipboards that hold different types
of drag data - images, HTML markup, text, URL, URL label.
Also clears each clipboard before setting new data to it.

No new tests - despite some implementations, no new functionality
is added until implementations of the GTK drag and drop protocol
in WebKit part.

  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::ClipboardGtk): (WebCore::ClipboardGtk::~ClipboardGtk): (WebCore::getCachedImage): (WebCore::ClipboardGtk::declareAndWriteDragImage): (WebCore::ClipboardGtk::writeURL): (WebCore::ClipboardGtk::writeRange):
  • platform/gtk/ClipboardGtk.h: ClipboardGdk -> ClipboardGtk
15:27 Changeset [47240] by mrowe@apple.com
  • 9 edits in trunk

Roll out r47237 as it was mistakenly landed.

15:22 Changeset [47239] by bweinstein@apple.com
  • 9 edits in trunk/JavaScriptCore

Build fix so JavaScriptCore builds, might fail linking WebCore or WebKit. Added includes and removed a missing function from JavaScriptCore_debug.def and JavascriptCore.def.

15:22 Changeset [47238] by eric@webkit.org
  • 1 edit
    1 move in trunk/WebKitTools

2009-08-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

rename make-js-test-wrappers to make-script-test-wrappers
https://bugs.webkit.org/show_bug.cgi?id=28212

  • Scripts/make-script-test-wrappers: Renamed from WebKitTools/Scripts/make-js-test-wrappers.
15:17 Changeset [47237] by bweinstein@apple.com
  • 9 edits in trunk

DRT improvements for Database stuff.

14:51 Changeset [47236] by darin@apple.com
  • 43 edits
    1 delete in trunk

JavaScriptCore: JavaScriptCore tweaks to get ready for the parser arena
https://bugs.webkit.org/show_bug.cgi?id=28243

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by David Levin.

Eliminate dependencies on Nodes.h outside JavaScriptCore,
and cut down on them inside JavaScriptCore.

Change regular expression parsing to use identifiers as
with other strings we parse.

Fix a couple things that are needed to use const Identifier
more, which will be part of the parser arena work.

CollectorHeapIterator.h to be project-internal.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitPushNewScope): Added const.

  • bytecompiler/BytecodeGenerator.h: Ditto.
  • debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions): Moved this function
here from WebCore. Here is better since it uses so many internals.
Removed unimportant optimization for the no listener case.

  • debugger/Debugger.h: Ditto. Also removed unneeded include

and tweaked formatting and comments.

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::functionName): Call asFunction instead
of doing the unchecked static_cast.
(JSC::DebuggerCallFrame::calculatedFunctionName): Ditto.

  • jit/JITStubs.cpp:

(JSC::op_call_JSFunction): Call isHostFunction on the body rather
than on the JSFunction.
(JSC::vm_lazyLinkCall): Ditto.
(JSC::op_construct_JSConstruct): Ditto.

  • parser/Grammar.y: Changed callers to use new scanRegExp with

out arguments instead of relying on state in the Lexer. And
callers that just want to skip a regular expression to use
skipRegExp.

  • parser/Lexer.cpp:

(JSC::Lexer::scanRegExp): Changed to use out arguments, and to
add a prefix argument so we can add in the "=" character as needed.
Also rewrote to streamline the logic a bit inspired by suggestions
by David Levin.
(JSC::Lexer::skipRegExp): Added. Version of the function above that
does not actually put the regular expression into a string.
(JSC::Lexer::clear): Removed code to clear m_pattern and m_flags.

  • parser/Lexer.h: Changed scanRegExp to have out arguments. Added

skipRegExp. Eliminated pattern, flags, m_pattern, and m_flags.

  • parser/NodeConstructors.h:

(JSC::RegExpNode::RegExpNode): Changed to take const Identifier&.

  • parser/Nodes.cpp:

(JSC::RegExpNode::emitBytecode): Changed since m_pattern and
m_flags are now Identifier instead of UString.
(JSC::FunctionBodyNode::make): Moved this function here instead
of putting it in the JSFunction.h header.

  • parser/Nodes.h: Changed RegExpNode to use Identifier.
  • profiler/Profiler.cpp:

(JSC::Profiler::createCallIdentifier): Changed to use isHostFunction
on the body instead of on the JSFunction object.

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString): Ditto.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::isHostFunction): Moved here from header.
(JSC::JSFunction::isHostFunctionNonInline): Added.
(JSC::JSFunction::JSFunction): Removed unneeded initialization of
m_body to 0.
(JSC::JSFunction::setBody): Moved here from header.

  • runtime/JSFunction.h: Removed unneeded includes. Moved private

constructor down to the private section. Made virtual functions
private. Removed unneeded overload of setBody and moved the body
of the function into the .cpp file. Changed assertions to use
the non-inline version of isHostFunction.

  • runtime/PropertySlot.cpp:

(JSC::PropertySlot::functionGetter): Use asFunction instead
of doing the unchecked static_cast.

  • wtf/SegmentedVector.h:

(WTF::SegmentedVector::isEmpty): Added.

WebCore: JavaScriptCore tweaks to get ready for the parser arena
https://bugs.webkit.org/show_bug.cgi?id=28243

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by David Levin.

  • ForwardingHeaders/runtime/CollectorHeapIterator.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Exposed a couple header

files as Private that are now needed to compile Mac WebKit.

  • bindings/js/JSAudioConstructor.cpp:
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSHTMLInputElementCustom.cpp:
  • bindings/js/JSHistoryCustom.cpp:
  • bindings/js/JSImageConstructor.cpp:
  • bindings/js/JSLazyEventListener.cpp:
  • bindings/js/JSLocationCustom.cpp:
  • bindings/js/JSMessageChannelConstructor.cpp:
  • bindings/js/JSOptionConstructor.cpp:
  • bindings/js/JSWebSocketConstructor.cpp:
  • bindings/js/JSWebSocketCustom.cpp:
  • bindings/js/JSWorkerConstructor.cpp:
  • bindings/js/JSXMLHttpRequestConstructor.cpp:
  • bridge/jni/jni_jsobject.mm:

Updated includes.

  • inspector/JavaScriptDebugServer.cpp:

(WebCore::JavaScriptDebugServer::sourceParsed):
Change to not assert if this is called with no listeners.
I don't think this was guaranteed before, and we now use
this code path when recompiling. Slightly less efficient,
but this is a one-time cost when turning on the debugger.
(WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
Change to call Debugger::recompileAllJSFunctions.

WebKit/mac: * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Updated includes.

  • WebView/WebScriptDebugger.mm: Ditto.
14:38 Changeset [47235] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-13 Eric Seidel <eric@webkit.org>

Rubber-stamped by Adam Roben.

REGRESSION: 6 media tests regressed while the windows bot was broken
https://bugs.webkit.org/show_bug.cgi?id=28281

  • platform/win/Skipped:
14:36 Changeset [47234] by atwilson@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Patch by Drew Wilson <atwilson@chromium.org> on 2009-08-13
Add myself to list of committers.

  • Scripts/modules/committers.py:
14:35 Changeset [47233] by beidson@apple.com
  • 12 edits
    2 adds in trunk

WebCore: <rdar://problem/7138591> and https://bugs.webkit.org/show_bug.cgi?id=28260
onhashchange property cannot be set from javascript.

Reviewed by Eric Seidel.

Test: fast/loader/onhashchange-attribute-listeners.html

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::onhashchange):
(WebCore::HTMLBodyElement::setOnhashchange):

  • html/HTMLBodyElement.h:
  • html/HTMLBodyElement.idl:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::onhashchange):
(WebCore::HTMLFrameSetElement::setOnhashchange):

  • html/HTMLFrameSetElement.h:
  • html/HTMLFrameSetElement.idl:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::onhashchange):
(WebCore::DOMWindow::setOnhashchange):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests: <rdar://problem/7138591> and https://bugs.webkit.org/show_bug.cgi?id=28260
onhashchange property cannot be set from javascript.

Reviewed by Eric Seidel.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/loader/onhashchange-attribute-listeners-expected.txt: Added.
  • fast/loader/onhashchange-attribute-listeners.html: Added.
14:27 Changeset [47232] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Fix leaks of RGBColor instances from below SVGColor::rgbColor.

Reviewed by Geoff Garen.

  • svg/SVGColor.cpp:

(WebCore::SVGColor::rgbColor): Return a PassRefPtr to ensure that the newly-allocated
RGBColor is cleaned up by the caller.

  • svg/SVGColor.h:
14:12 Changeset [47231] by pfeldman@chromium.org
  • 35 edits in trunk/WebCore

2009-08-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Migrate to DOMAgent (serialized access to DOM).

https://bugs.webkit.org/show_bug.cgi?id=28177

  • bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::highlightDOMNode): (WebCore::JSInspectorBackend::nodeForId): (WebCore::JSInspectorBackend::idForNode): (WebCore::JSInspectorBackend::wrapObject): (WebCore::JSInspectorBackend::unwrapObject): (WebCore::JSInspectorBackend::pushNodePathToFrontend): (WebCore::JSInspectorBackend::selectDatabase): (WebCore::JSInspectorBackend::selectDOMStorage):
  • bindings/js/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
  • bindings/js/ScriptObjectQuarantine.h:
  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isObject):
  • bindings/js/ScriptValue.h:
  • bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
  • bindings/v8/ScriptObjectQuarantine.h:
  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::isObject):
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::clearMessages): (WebCore::InspectorBackend::loaded): (WebCore::InspectorBackend::highlight): (WebCore::InspectorBackend::nodeForId): (WebCore::InspectorBackend::idForNode): (WebCore::InspectorBackend::wrapObject): (WebCore::InspectorBackend::unwrapObject): (WebCore::InspectorBackend::pushNodePathToFrontend): (WebCore::InspectorBackend::addNodesToSearchResult): (WebCore::InspectorBackend::selectDatabase): (WebCore::InspectorBackend::selectDOMStorage):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::focusNode): (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::wrapObject): (WebCore::InspectorController::unwrapObject):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument): (WebCore::InspectorDOMAgent::handleEvent): (WebCore::InspectorDOMAgent::pushDocumentToFrontend): (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::nodeForId): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren): (WebCore::InspectorDOMAgent::innerParentElement):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::clearConsoleMessages): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setDocument): (WebCore::InspectorFrontend::selectDatabase): (WebCore::InspectorFrontend::selectDOMStorage): (WebCore::InspectorFrontend::addNodesToSearchResult):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.clearMessages): (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._reportCompletions): (WebInspector.ConsoleView.prototype._messagesClicked): (WebInspector.ConsoleView.prototype.doEvalInWindow.evalCallback): (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._format): (WebInspector.ConsoleView.prototype._formatfunction): (WebInspector.ConsoleView.prototype._formatdate): (WebInspector.ConsoleView.prototype._formatregexp): (WebInspector.ConsoleView.prototype._formatnode): (WebInspector.ConsoleView.prototype._formatobject):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMDocument): (WebInspector.DOMAgent): (WebInspector.DOMAgent.prototype.getChildNodesAsync): (WebInspector.DOMAgent.prototype.setAttributeAsync): (WebInspector.DOMAgent.prototype.removeAttributeAsync): (WebInspector.DOMAgent.prototype.setTextNodeValueAsync): (WebInspector.DOMAgent.prototype.nodeForId): (WebInspector.DOMAgent.prototype._setDocument): (WebInspector.DOMAgent.prototype._setChildNodes): (WebInspector.DOMAgent.prototype._bindNodes): (WebInspector.DOMAgent.prototype._childNodeInserted): (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.parseRule): (WebInspector.setDocument): (InspectorController.getStyles): (InspectorController.getComputedStyle): (InspectorController.getInlineStyle): (InspectorController.applyStyleText): (InspectorController.setStyleText): (InspectorController.toggleStyleEnabled): (InspectorController.applyStyleRuleText): (InspectorController.addStyleSelector): (InspectorController.setStyleProperty): (InspectorController.getPrototypes): (InspectorController.getProperties): (InspectorController.setPropertyValue): (InspectorController.evaluate): (InspectorController.addInspectedNode): (InspectorController.performSearch): (InspectorController.searchCanceled):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype._updateMatchesCount): (WebInspector.ElementsPanel.prototype._updateMatchesCountSoon): (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode.restoreHighlightToHoveredNode): (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode): (WebInspector.ElementsTreeElement.prototype.updateChildren): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
  • inspector/front-end/InjectedScript.js: (InjectedScript.applyStyleRuleText): (InjectedScript.addStyleSelector): (InjectedScript._doesSelectorAffectNode): (InjectedScript._serializeRule): (InjectedScript._serializeStyle): (InjectedScript.getProperties): (InjectedScript.evaluate): (InjectedScript.addInspectedNode): (InjectedScript.performSearch.addNodesToResults): (InjectedScript.performSearch.matchExactItems): (InjectedScript.performSearch.matchExactId.addNodesToResults.call): (InjectedScript.performSearch.matchExactId): (InjectedScript.performSearch): (InjectedScript.performSearch.matchExactTagNames): (InjectedScript.performSearch.matchExactAttributeNames): (InjectedScript.performSearch.matchPartialTagNames): (InjectedScript.performSearch.matchStartOfTagNames): (InjectedScript.performSearch.matchPartialTagNamesAndAttributeValues): (InjectedScript.performSearch.matchPartialAttributeValues): (InjectedScript.performSearch.matchStyleSelector): (InjectedScript.performSearch.matchPlainText): (InjectedScript.performSearch.matchXPathQuery): (InjectedScript.performSearch.finishedSearching): (InjectedScript.performSearch.processChunk): (InjectedScript.searchCanceled): (InjectedScript._ensureCommandLineAPIInstalled.inspectObject): (InjectedScript._ensureCommandLineAPIInstalled): (InjectedScript._resolveObject): (InjectedScript._nodeForId): (InjectedScript._objectForId): (InjectedScript._createProxyObject):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.update):
  • inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy): (WebInspector.ObjectPropertyProxy):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback): (WebInspector.PropertiesSidebarPane.prototype.update):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.callback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled): (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted.callback): (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.js: (WebInspector._updateHoverHighlight): (WebInspector.loaded): (WebInspector.clearConsoleMessages): (WebInspector.selectDatabase): (WebInspector.selectDOMStorage): (WebInspector.updateFocusedNode): (WebInspector.addNodesToSearchResult):
  • inspector/front-end/utilities.js: (Object.proxyType):
  • storage/Storage.h: (WebCore::Storage::frame):
13:57 Changeset [47230] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Fix leaks of RGBColor instances from below CSSPrimitiveValue::getRGBColorValue.

Reviewed by Geoff Garen.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::getRGBColorValue): Return a PassRefPtr to ensure that the
newly-allocated RGBColor is cleaned up by the caller.

  • css/CSSPrimitiveValue.h:
13:56 Changeset [47229] by eric@webkit.org
  • 8 edits
    6 adds in trunk

2009-08-13 Eric Seidel <eric@webkit.org>

Reviewed by David Hyatt.

wrong font size when css font-family includes monospace
https://bugs.webkit.org/show_bug.cgi?id=19161

Update test results now that only "font-family: monospace" is 13px.
All other combinations of font-family are 16px default size.

Add two tests:
font-family-fallback-reset: catches a bug in inheriting font-family fallback.
computed-style-font-family-monospace: tests this bug, that only "font-family: monospace" is 13px.

  • fast/css/getComputedStyle/computed-style-font-family-expected.txt:
  • fast/css/getComputedStyle/computed-style-font-family-monospace-expected.txt: Added.
  • fast/css/getComputedStyle/computed-style-font-family-monospace.html: Added.
  • fast/css/getComputedStyle/font-family-fallback-reset-expected.txt: Added.
  • fast/css/getComputedStyle/font-family-fallback-reset.html: Added.
  • fast/css/getComputedStyle/resources/computed-style-font-family-monospace.js: Added. (fontSizeForFamilies):
  • fast/css/getComputedStyle/resources/font-family-fallback-reset.js: Added.
  • fast/js/method-check.html:
  • platform/mac/css1/font_properties/font_family-expected.txt:
  • platform/mac/css2.1/t1503-c522-font-family-00-b-expected.txt:
  • platform/mac/fast/text/monospace-width-cache-expected.txt:

2009-08-13 Eric Seidel <eric@webkit.org>

Reviewed by David Hyatt.

wrong font size when css font-family includes monospace
https://bugs.webkit.org/show_bug.cgi?id=19161

Firefox only uses fixed-width default size for exactly "font-family: monospace;".
WebKit has historically used fixed-width default size any time a
font-family includes monospace in the fallback list.

This patch corrects WebKit's behavior to match Firefox.
I also had to fix a bug in WebKit's font-family fallback behavior where
child elements would inherit parts of their parents fallback lists.

This patch is mostly just replacing all cases where we used to check for:
fontDescription.genericFontFamily() == MonospaceFamily
with:
fontDescription.useFixedDefaultSize()

Tests: fast/css/getComputedStyle/computed-style-font-family-monospace.html

fast/css/getComputedStyle/font-family-fallback-reset.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):

Deploy useFixedDefaultSize(). Also fix the bug where child
FontDescriptions would carry part of the parent font-family fallback list.

(WebCore::CSSStyleSelector::checkForGenericFamilyChange):

It's no longer alright to just check genericFontFamily(),
we have to check to make sure the changed style has a matching useFixedDefaultSize().

  • platform/graphics/FontDescription.h: (WebCore::FontDescription::useFixedDefaultSize):

Only use the fixed default size if we have one font family and it is "monospace".
"-webkit-monospace" is the internal representation of the CSS identifier "monospace".

13:48 Changeset [47228] by sullivan@apple.com
  • 2 edits in trunk/WebKitTools

Unreviewed.

Add myself to list of committers.

  • Scripts/modules/committers.py:
13:18 Changeset [47227] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-13 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>

Reviewed by Dimitri Glazkov.

[v8] Fix atomic string externalization crash.
Atomic string externalization assumes that all non-empty strings
can be externalized which is untrue on 64-bit. This change fixed
that.

https://bugs.webkit.org/show_bug.cgi?id=28215

This bug causes loads of test crashes, no need to add new tests
specifically for this.

  • bindings/v8/V8Binding.cpp: (WebCore::v8StringToAtomicWebCoreString):
12:49 Changeset [47226] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Doc - Some cleanup on the documentation of QWebElement

Patch by Kavindra Devi Palaraja <kavindra.palaraja@nokia.com> on 2009-08-13
Reviewed by Simon Hausmann.

  • Api/qwebelement.cpp:
12:39 Changeset [47225] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Use the version of operator new that takes a JSGlobalData when allocating FuncDeclNode and FuncExprNode
from within the grammar to prevent these nodes from being leaked.

Rubber-stamped by Darin Adler.

  • parser/Grammar.y:
12:01 Changeset [47224] by eric@webkit.org
  • 2 edits
    1 move in trunk/WebKitTools

2009-08-13 Eric Seidel <eric@webkit.org>

Correct spelling error in file name. No review.

  • Scripts/modules/committers_unittest.py: Renamed from WebKitTools/Scripts/modules/commiters_unittest.py.
  • Scripts/run-webkit-unittests:
11:34 Changeset [47223] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-13 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION(r47175): error running run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=28261

Fix "Use of uninitialized value in concatenation (.) or string at
WebKitTools/Scripts/run-webkit-tests line 191." by setting
$testsPerDumpTool to 1000 by default.

  • Scripts/run-webkit-tests:
11:32 UsingGitWithWebKit edited by yong.li@torchmobile.com
(diff)
11:32 Changeset [47222] by staikos@webkit.org
  • 3 edits in trunk/WebCore

2009-08-13 George Staikos <george.staikos@torchmobile.com>

Rubberstamped by Darin Adler.

Use ASSERT_UNUSED instead of UNUSED_PARAM

11:21 Changeset [47221] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-13 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Fixes a couple of bugs in SecurityOrigin::createFromDatabaseIdentifier.
https://bugs.webkit.org/show_bug.cgi?id=28262

No new tests possible.

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
11:19 WebKit Team edited by dbates@webkit.org
Added myself to the wiki. (diff)
11:11 Changeset [47220] by japhet@chromium.org
  • 2 edits in trunk/WebKitTools

2009-08-13 Nate Chapin <japhet@chromium.org>

Unreviewed.

Add myself to list of committers.

  • Scripts/modules/committers.py:
11:09 Changeset [47219] by dbates@webkit.org
  • 1 edit in trunk/WebKitTools/Scripts/modules/committers.py

2009-08-13 Daniel Bates <dbates@webkit.org>

Unreviewed.


Added 'Daniel Bates' (myself) to the list of committers.


  • Scripts/modules/committers.py:
11:07 WebKit Team edited by joe.mason@torchmobile.com
(diff)
11:06 Changeset [47218] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Add 'Brent Fulgham' to the committers list.

  • Scripts/modules/committers.py:
11:04 Changeset [47217] by yong.li@torchmobile.com
  • 1 edit in trunk/WebKitTools/Scripts/modules/committers.py

2009-08-13 Yong Li <yong.li@torchmobile.com>

Unreviewed.
Added 'Yong Li' to the committers list.

  • Scripts/modules/committers.py
11:03 Changeset [47216] by agl@chromium.org
  • 2 edits in trunk/WebKitTools

2009-08-13 Adam Langley <agl@chromium.org>

Review not required.

  • Scripts/modules/committers.py: Adding myself to this list because Eric told me to.
11:01 Changeset [47215] by bolsinga@apple.com
  • 2 edits in trunk/WebKitTools

Unreviewed.

Add 'Greg Bolsinga' to the committers list.

  • Scripts/modules/committers.py:
10:59 Changeset [47214] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Remove media/video-test.js's redundant hang timer

DRT already has a timer that does the same thing.

Reviewed by Mark Rowe.

  • media/video-test.js: Remove the hang timer, since DRT does the same

thing.

10:58 Changeset [47213] by aroben@apple.com
  • 6 edits in trunk/WebKitTools

Fix off-by-one result comparisons in media tests on Windows Debug builds

media/video-played.html seems always to time out in Windows Debug
builds. A race condition between media/video-test.js's "hang" timer and
DumpRenderTree's built-in "watchdog" timer was causing results for
media/video-played.html to be printed twice, causing all future media
tests to be compared to the previous test's results.

The fix is to make the watchdog timer got through the same code path
as calling notifyDone manually, so that the results will only get
printed once. A subsequent patch will remove video-test.js's hang
timer entirely, since it is redundant.

Fixes <http://webkit.org/b/28265>.

Reviewed by Mark Rowe.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::waitToDumpWatchdogTimerFired): Added. Code came
from Gtk/Mac/Win's watchdog timer handlers, but we now call
notifyDone() instead of dump() so that a subsequent call to
notifyDone() won't print the results out again.

  • DumpRenderTree/LayoutTestController.h: Added

waitToDumpWatchdogTimerFired.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(waitToDumpWatchdogFired):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(waitUntilDoneWatchdogFired):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(waitUntilDoneWatchdogFired):
Changed to call waitToDumpWatchdogTimerFired.

10:55 Changeset [47212] by eric.carlson@apple.com
  • 2 edits in trunk/WebKitTools

Unreviewed.

Added 'Eric Carlson' to the committers list.

10:52 Changeset [47211] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-13 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

[CAIRO] getImageData fails on a given rect bigger than the image rect

The destination image and the source image was mixed up on creating the
imageData.

This is just a clean up and doesn't affect the current behavior. It's not
possible to test this failure in a LayoutTest. Only canvas uses getImageData
at the moment and returns before calling getImageData, if the image rect does
not contain the requested rect.

  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::getImageData):
10:43 WebKit Team edited by treat@kde.org
(diff)
10:42 WebKit Team edited by rik@webkit.org
(diff)
10:40 WebKit Team edited by mrowe@apple.com
(diff)
10:38 Changeset [47210] by krit@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-13 Dirk Schulze <krit@webkit.org>

Unreviewed.
Added 'Dirk Schulze' to the committers list.

  • Scripts/modules/committers.py
10:37 WebKit Team edited by mrowe@apple.com
(diff)
10:34 WebKit Team edited by yong.li@torchmobile.com
(diff)
10:18 Changeset [47209] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-13 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Adam Roben.

Due to fixes in http://trac.webkit.org/changeset/47038 and http://trac.webkit.org/changeset/47163,
fast/events/mouse-click-events.html now passes, removing it from Skipped List.

  • platform/win/Skipped:
10:14 Changeset [47208] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-08-13 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Adding RenderTheme to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=28258

  • platform/haiku/RenderThemeHaiku.cpp: Added. (WebCore::RenderThemeHaiku::create): (WebCore::RenderTheme::themeForPage): (WebCore::RenderThemeHaiku::RenderThemeHaiku): (WebCore::RenderThemeHaiku::~RenderThemeHaiku): (WebCore::supportsFocus): (WebCore::RenderThemeHaiku::supportsFocusRing): (WebCore::RenderThemeHaiku::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeHaiku::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeHaiku::platformActiveSelectionForegroundColor): (WebCore::RenderThemeHaiku::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeHaiku::platformTextSearchHighlightColor): (WebCore::RenderThemeHaiku::systemFont): (WebCore::RenderThemeHaiku::paintCheckbox): (WebCore::RenderThemeHaiku::setCheckboxSize): (WebCore::RenderThemeHaiku::paintRadio): (WebCore::RenderThemeHaiku::setRadioSize): (WebCore::RenderThemeHaiku::adjustMenuListStyle): (WebCore::RenderThemeHaiku::paintMenuList):
  • platform/haiku/RenderThemeHaiku.h: Added. (WebCore::RenderThemeHaiku::supportsHover):
10:13 Changeset [47207] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. Make sure that the wxWebKit dynamic library is rebuilt whenever webcore or jscore libs change.

10:08 Changeset [47206] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-13 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Remove the "m_point" code from ContextMenuHaiku.cpp
https://bugs.webkit.org/show_bug.cgi?id=28256

  • platform/haiku/ContextMenuHaiku.cpp: (WebCore::ContextMenuReceiver::ContextMenuReceiver): (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::insertItem):
09:51 Changeset [47205] by eric@webkit.org
  • 13 edits
    1 copy in trunk/WebCore

2009-08-13 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Darin Adler.

Inspector: Show Hidden Cookie Data
https://bugs.webkit.org/show_bug.cgi?id=28185

Added new file Cookie.h to the WebCore XCode

  • WebCore.xcodeproj/project.pbxproj:

InspectorController.cookies() binding

  • bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::cookies):
  • inspector/InspectorBackend.idl:

Struct for static Cookie information
(name, value, path, domain, expires, httpOnly, secure, session)

  • platform/Cookie.h: Added. (WebCore::Cookie::Cookie):

Getter for the a list of raw Cookies
getRawCookies(., ., out Vector<Cookie>)

  • platform/CookieJar.h:

Implementation of getRawCookies for the mac platform.

  • platform/mac/CookieJar.mm: (WebCore::getRawCookies):

Stub other CookieJar implementations to satisfy the interface.

  • platform/haiku/CookieJarHaiku.cpp: (WebCore::getRawCookies):
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::getRawCookies):
  • platform/network/curl/CookieJarCurl.cpp: (WebCore::getRawCookies):
  • platform/network/soup/CookieJarSoup.cpp: (WebCore::getRawCookies):
  • platform/network/win/CookieJarCFNetWin.cpp: (WebCore::getRawCookies):
  • platform/network/win/CookieJarWin.cpp: (WebCore::getRawCookies):
  • platform/qt/CookieJarQt.cpp: (WebCore::getRawCookies):
09:43 Changeset [47204] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-13 Steve Block <steveblock@google.com>

Reviewed by David Levin.

Disables Geolocation 'enabled' test for GTK port, as the GTK Geolocation implementation is incomplete.
https://bugs.webkit.org/show_bug.cgi?id=27716

  • platform/gtk/Skipped: Modified. Disables Geolocation 'enabled' test.
09:36 Changeset [47203] by eric@webkit.org
  • 4 edits in trunk

2009-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[Gtk][REGRESSION] XHR test failures after r45558
https://bugs.webkit.org/show_bug.cgi?id=27143

Reenable the test that is fixed by this changeset.

  • platform/gtk/Skipped:

2009-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[Gtk][REGRESSION] XHR test failures after r45558
https://bugs.webkit.org/show_bug.cgi?id=27143

Fix one of the regressions caused by the new sniffing code -
disable sniffing when that behavior is explicitly requested.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp):
09:29 Changeset [47202] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-13 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Add a new gesture in Web Inspector to remove breakpoints
https://bugs.webkit.org/show_bug.cgi?id=19131

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._documentMouseDown):
09:23 Changeset [47201] by eric@webkit.org
  • 10 edits in trunk

2009-08-13 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Symbian target components (library and executable files)
require Unique Identifiers (i.e., UID3).
These identifiers are defined in the respective project
file, conditionally for "symbian" platform.

  • WebCore.pro:

2009-08-13 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Symbian target components (library and executable files)
require Unique Identifiers (i.e., UID3).
These identifiers are defined in the respective project
files, conditionally for "symbian" platform.

  • QtLauncher/QtLauncher.pro:
  • tests/qwebelement/qwebelement.pro:
  • tests/qwebframe/qwebframe.pro:
  • tests/qwebhistory/qwebhistory.pro:
  • tests/qwebhistoryinterface/qwebhistoryinterface.pro:
  • tests/qwebpage/qwebpage.pro:
  • tests/qwebview/qwebview.pro:
09:16 Changeset [47200] by eric@webkit.org
  • 9 edits in trunk

2009-08-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

wrong calculation of overflow size for flexbox and table
https://bugs.webkit.org/show_bug.cgi?id=28064

RenderFlexibleBox and RenderTable were using the width of overflow
to update height of overflow, so height became wrong value and
width was not updated. As the corresponding code of RenderBlock
was sane, I factored it out and used from RenderFlexibleBox and
RenderTable.

  • fast/reflections/reflection-overflow-scroll-expected.txt:
  • fast/reflections/reflection-overflow-scroll.html:
  • fast/reflections/resources/reflection-overflow-scroll.js:

2009-08-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

wrong calculation of overflow size for flexbox and table
https://bugs.webkit.org/show_bug.cgi?id=28064

RenderFlexibleBox and RenderTable were using the width of overflow
to update height of overflow, so height became wrong value and
width was not updated. As the corresponding code of RenderBlock
was sane, I factored it out and used from RenderFlexibleBox and
RenderTable.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateOverflowWithShadowAndReflection): created from code of layoutBlock (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderBlock.h:
  • rendering/RenderFlexibleBox.cpp: use updateOverflowWithShadowAndReflection (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): use updateOverflowWithShadowAndReflection
09:01 Changeset [47199] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Enable running testapi in run-javascriptcore-tests on Windows

Fixes <http://webkit.org/b/24856> run-javascriptcore-tests should run
testapi on Windows

Reviewed by Mark Rowe.

  • Scripts/run-javascriptcore-tests: Allow testapi to run if we're in

the AppleWinWebKit configuration.

09:00 Changeset [47198] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Re-enable testapi in run-javascriptcore-tests on Mac

This seems to have been mistakenly disabled in r47089.

Rubber-stamped by Mark Rowe.

  • Scripts/run-javascriptcore-tests: Removed comment markers that were

preventing running testapi.

08:25 UsingGitWithWebKit edited by treat@kde.org
(diff)
08:18 Companies and Organizations that have contributed to WebKit edited by kov@webkit.org
(diff)
07:54 Changeset [47197] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

Remove the special-case for Qt wrt JSVALUE_32 introduced in
r46709. It must've been a dependency issue on the bot, as
after a manual build all the tests pass on amd64 and ia32.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-13
Reviewed by Ariya Hidayat.

  • wtf/Platform.h:
07:29 Changeset [47196] by ariya@webkit.org
  • 9 edits in trunk/LayoutTests

2009-08-13 Ariya Hidayat <ariya.hidayat@nokia.com>

Rubber-stamped by George Staikos.

[Qt] These tests pass, update the metrics and exclude from Skipped.

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvas-transform-identity-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-infinity-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-multiply-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-nan-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-non-invertible-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-skewed-expected.txt:
  • platform/qt/fast/canvas/canvas-transforms-during-path-expected.txt:
05:53 Changeset [47195] by mrowe@apple.com
  • 13 edits
    1 delete in trunk/WebCore

Revert r47185, the fix for <https://bugs.webkit.org/show_bug.cgi?id=28185>, as it broke the
Windows build in a non-obvious manner.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInspectorBackendCustom.cpp:
  • inspector/InspectorBackend.idl:
  • platform/Cookie.h: Removed.
  • platform/CookieJar.h:
  • platform/haiku/CookieJarHaiku.cpp:

(WebCore::setCookies):
(WebCore::cookies):

  • platform/mac/CookieJar.mm:
  • platform/network/chromium/CookieJarChromium.cpp:
  • platform/network/curl/CookieJarCurl.cpp:
  • platform/network/soup/CookieJarSoup.cpp:
  • platform/network/win/CookieJarCFNetWin.cpp:
  • platform/network/win/CookieJarWin.cpp:
  • platform/qt/CookieJarQt.cpp:
05:44 Changeset [47194] by ariya@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2009-08-13 Ariya Hidayat <ariya.hidayat@nokia.com>

Not reviewed: build fix (for r47192), adding new file from
https://bugs.webkit.org/show_bug.cgi?id=28174

  • inspector/front-end/StatusBarButton.js: Added.
05:36 Changeset [47193] by ariya@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

2009-08-13 Ariya Hidayat <ariya.hidayat@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] Test result for quadraticCurveTo.

  • platform/qt/Skipped: Exclude quadraticCurveTo test.
  • platform/qt/fast/canvas/quadraticCurveTo-expected.checksum: Added.
  • platform/qt/fast/canvas/quadraticCurveTo-expected.png: Added.
  • platform/qt/fast/canvas/quadraticCurveTo-expected.txt: Added.
05:16 Changeset [47192] by pfeldman@chromium.org
  • 14 edits in trunk/WebCore

2009-08-13 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Introduced StatusBarButton class that encapsulates glyphs support.
Views updated accordingly.

https://bugs.webkit.org/show_bug.cgi?id=28174

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.get statusBarItems): Updated to retrieve DOM element from StatusBarButton instance (here and in similar getters below.) (WebInspector.CookieItemsView.prototype.hide): (WebInspector.CookieItemsView.prototype.update):
  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView): (WebInspector.DOMStorageItemsView.prototype.get statusBarItems): (WebInspector.DOMStorageItemsView.prototype.hide): (WebInspector.DOMStorageItemsView.prototype.update):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.get statusBarItems): (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
  • inspector/front-end/Panel.js:
  • inspector/front-end/ProfileView.js: (WebInspector.ProfileView): (WebInspector.ProfileView.prototype.get statusBarItems): (WebInspector.ProfileView.prototype._updatePercentButton): (WebInspector.ProfileView.prototype._focusClicked): (WebInspector.ProfileView.prototype._excludeClicked): (WebInspector.ProfileView.prototype._resetClicked):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.get statusBarItems): (WebInspector.ProfilesPanel.prototype.setRecordingProfile): (WebInspector.ProfilesPanel.prototype._updateInterface):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get statusBarItems): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get statusBarItems): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
  • inspector/front-end/StatusBarButton.js: Added. (WebInspector.StatusBarButton): (WebInspector.StatusBarButton.prototype._clicked): (WebInspector.StatusBarButton.prototype.get disabled): (WebInspector.StatusBarButton.prototype.set disabled): (WebInspector.StatusBarButton.prototype.get title): (WebInspector.StatusBarButton.prototype.set title): (WebInspector.StatusBarButton.prototype.get toggled): (WebInspector.StatusBarButton.prototype.set toggled): (WebInspector.StatusBarButton.prototype.get visible): (WebInspector.StatusBarButton.prototype.set visible):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: For uniformity, class names are always used to identify status bar buttons. Also, fixed "Reload" button style to use glyphs.
  • inspector/front-end/inspector.html:
05:15 Changeset [47191] by ariya@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-08-13 Ariya Hidayat <ariya.hidayat@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] Fix test result and add pixel test.

  • platform/qt/fast/canvas/canvas-zoom-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-zoom-expected.png: Added.
  • platform/qt/fast/canvas/canvas-zoom-expected.txt: Added.
04:45 Changeset [47190] by ariya@webkit.org
  • 4 edits
    21 adds in trunk

WebCore/ChangeLog

2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Add shadow support in GraphicsContext::fillRect().

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRect): Paint shadow if necessary. (WebCore::GraphicsContext::setPlatformShadow): Inverse y offset.

LayoutTests/ChangeLog

2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Add pixel tests result for canvas shadow support.

  • platform/qt/Skipped: Exclude new passing tests.
  • platform/qt/fast/canvas/shadow-offset-1-expected.checksum: Added.
  • platform/qt/fast/canvas/shadow-offset-1-expected.png: Added.
  • platform/qt/fast/canvas/shadow-offset-1-expected.txt: Added.
  • platform/qt/fast/canvas/shadow-offset-2-expected.checksum: Added.
  • platform/qt/fast/canvas/shadow-offset-2-expected.png: Added.
  • platform/qt/fast/canvas/shadow-offset-2-expected.txt: Added.
  • platform/qt/fast/canvas/shadow-offset-3-expected.checksum: Added.
  • platform/qt/fast/canvas/shadow-offset-3-expected.png: Added.
  • platform/qt/fast/canvas/shadow-offset-3-expected.txt: Added.
  • platform/qt/fast/canvas/shadow-offset-4-expected.checksum: Added.
  • platform/qt/fast/canvas/shadow-offset-4-expected.png: Added.
  • platform/qt/fast/canvas/shadow-offset-4-expected.txt: Added.
  • platform/qt/fast/canvas/shadow-offset-5-expected.checksum: Added.
  • platform/qt/fast/canvas/shadow-offset-5-expected.png: Added.
  • platform/qt/fast/canvas/shadow-offset-5-expected.txt: Added.
  • platform/qt/fast/canvas/shadow-offset-6-expected.checksum: Added.
  • platform/qt/fast/canvas/shadow-offset-6-expected.png: Added.
  • platform/qt/fast/canvas/shadow-offset-6-expected.txt: Added.
  • platform/qt/fast/canvas/shadow-offset-7-expected.checksum: Added.
  • platform/qt/fast/canvas/shadow-offset-7-expected.png: Added.
  • platform/qt/fast/canvas/shadow-offset-7-expected.txt: Added.
03:17 Changeset [47189] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-08-13 David Levin <levin@chromium.org>

Unreviewed build fix for Chromium Linux.

Rollback r47157 as this broke debug tests of Chromium Linux.

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintCommon):
02:59 Changeset [47188] by levin@chromium.org
  • 3 edits in trunk/WebCore

Unreviewed build fix for chromium.

Patch by David Levin <levin@chromium.org> on 2009-08-13
The chromium build broke due to r47185 which added
a cookies array to inspector/InspectorBackend.idl.

  • bindings/v8/custom/V8CustomBinding.h: Added the declaration for the cookies callback.
  • bindings/v8/custom/V8InspectorBackendCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL(InspectorBackendCookies)): Stubbed out an implementation

for the cookies callback.

00:33 Changeset [47187] by dimich@chromium.org
  • 1 edit in trunk/LayoutTests/platform/win/media/controls-drag-timebar-expected.txt

Fix for media timebar test on windows.

08/12/09:

22:58 Changeset [47186] by barraclough@apple.com
  • 12 edits in trunk/JavaScriptCore

Add optimize call and property access support for ARM JIT.
https://bugs.webkit.org/show_bug.cgi?id=24986

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-12
Reviewed by Gavin Barraclough.

For tightly coupled sequences the BEGIN_UNINTERRUPTED_SEQUENCE and
END_UNINTERRUPTED_SEQUENCE macros have been introduced which ensure
space for instructions and constants of the named sequence. This
method is vital for those architecture which are using constant pool.

The 'latePatch' method - which was linked to JmpSrc - is replaced with
a port specific solution (each calls are marked to place their address
on the constant pool).

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::linkBranch):
(JSC::ARMAssembler::executableCopy): Add extra align for constant pool.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::JmpSrc::JmpSrc):
(JSC::ARMAssembler::sizeOfConstantPool):
(JSC::ARMAssembler::jmp):
(JSC::ARMAssembler::linkCall):

  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h:
  • assembler/AssemblerBufferWithConstantPool.h:

(JSC::AssemblerBufferWithConstantPool::flushIfNoSpaceFor): Fix the
computation of the remaining space.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::nearCall):
(JSC::MacroAssemblerARM::call):
(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::ensureSpace):
(JSC::MacroAssemblerARM::sizeOfConstantPool):
(JSC::MacroAssemblerARM::prepareCall):

  • assembler/X86Assembler.h:
  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITInlineMethods.h:

(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::endUninterruptedSequence):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):

22:58 Changeset [47185] by eric@webkit.org
  • 13 edits
    1 copy in trunk/WebCore

2009-08-12 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Show Hidden Cookie Data
https://bugs.webkit.org/show_bug.cgi?id=28185

Added new file Cookie.h to the WebCore XCode

  • WebCore.xcodeproj/project.pbxproj:

InspectorController.cookies() binding

  • bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::cookies):
  • inspector/InspectorBackend.idl:

Struct for static Cookie information
(name, value, path, domain, expires, httpOnly, secure, session)

  • platform/Cookie.h: Added. (WebCore::Cookie::Cookie):

Getter for the a list of raw Cookies
getRawCookies(., ., out Vector<Cookie>)

  • platform/CookieJar.h:

Implementation of getRawCookies for the mac platform.

  • platform/mac/CookieJar.mm: (WebCore::getRawCookies):

Stub other CookieJar implementations to satisfy the interface.

  • platform/haiku/CookieJarHaiku.cpp: (WebCore::getRawCookies):
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::getRawCookies):
  • platform/network/curl/CookieJarCurl.cpp: (WebCore::getRawCookies):
  • platform/network/soup/CookieJarSoup.cpp: (WebCore::getRawCookies):
  • platform/network/win/CookieJarCFNetWin.cpp: (WebCore::getRawCookies):
  • platform/network/win/CookieJarWin.cpp: (WebCore::getRawCookies):
  • platform/qt/CookieJarQt.cpp: (WebCore::getRawCookies):
22:26 Changeset [47184] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Rubber Stamped by Dave Kilzer.

Disable WTF_USE_JSVALUE32_64 on iPhone for now (support not yet added for ARMv7).

  • wtf/Platform.h:
22:21 Changeset [47183] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Ooops - moved code that had been accidentally added to op_new_func instead of
op_new_func_exp, to where it shoulds be.

Reviewed by Maciej Stachoviak.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • wtf/Platform.h:
22:00 Changeset [47182] by abarth@webkit.org
  • 2 edits in trunk/WebKitSite

2009-08-12 Joe Mason <joe.mason@torchmobile.com>

Reviewed by Adam Barth.

Better explanation of "Null after navigation" in object diagram
https://bugs.webkit.org/show_bug.cgi?id=28232

  • coding/major-objects.html:
21:51 Changeset [47181] by abarth@webkit.org
  • 5 edits
    3 adds in trunk/WebCore

2009-08-08 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Cookies in Storage Panel
https://bugs.webkit.org/show_bug.cgi?id=27202

Data Structure for a Cookie. Just Key/Value for Now:

A Storage View for Cookies. Allows for Refresh/Delete:

  • inspector/front-end/CookieItemsView.js: Added. (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.get statusBarItems): refresh and delete buttons (WebInspector.CookieItemsView.prototype.show): (WebInspector.CookieItemsView.prototype.hide): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype.buildCookies): parses the inspected window's document.cookie string (WebInspector.CookieItemsView.prototype.dataGridForCookies): creates a datagrid for cookies (WebInspector.CookieItemsView.prototype._deleteButtonClicked): attempt at deleting the cookie (not flawless) (WebInspector.CookieItemsView.prototype._refreshButtonClicked): rebuild the datagrid

Include a SidebarSection Section in the Databases Panel:

  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel): (WebInspector.DatabasesPanel.prototype.show): calls populateInterface (WebInspector.DatabasesPanel.prototype.populateInterface): adds cookies if they don't exist (WebInspector.DatabasesPanel.prototype.reset): remove cookie specific parts (WebInspector.DatabasesPanel.prototype.addCookies): add cookies sidebar tree element (WebInspector.DatabasesPanel.prototype.showCookies): sets the visible view to a CookiesItemView (WebInspector.CookieSidebarTreeElement): (WebInspector.CookieSidebarTreeElement.prototype.onselect): (WebInspector.CookieSidebarTreeElement.prototype.get mainTitle): just "Cookies" at the moment (WebInspector.CookieSidebarTreeElement.prototype.set mainTitle): (WebInspector.CookieSidebarTreeElement.prototype.get subtitle): no subtitle yet (WebInspector.CookieSidebarTreeElement.prototype.set subtitle):

New "Cookies" Image for the Sidebar:

  • inspector/front-end/Images/cookie.png: Added.
  • inspector/front-end/inspector.css:

Include the Added Files where appropriate:

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
21:46 Changeset [47180] by staikos@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 George Wright <george.wright@torchmobile.com>

Reviewed by George Staikos.

Add SQLTransactionCoordinator.[h,cpp] to WebCore.pro.

https://bugs.webkit.org/show_bug.cgi?id=28246

  • WebCore.pro:
21:38 Changeset [47179] by staikos@webkit.org
  • 2 edits in trunk

Fix double-fail of bug url. Not reviewed.

19:55 Changeset [47178] by staikos@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-12 George Staikos <george.staikos@torchmobile.com>

Reviewed by Adam Treat.

Enable WCSS and XHTML-MP flags for build-webkit.

  • Scripts/build-webkit:
19:48 Changeset [47177] by staikos@webkit.org
  • 3 edits in trunk/WebCore

2009-08-12 George Staikos <george.staikos@torchmobile.com>

Reviewed by Adam Treat.

Mark unused variables to avoid compile failures in -Werror.

19:47 Changeset [47176] by staikos@webkit.org
  • 9 edits
    2 adds in trunk/WebCore

2009-08-12 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by Niko Zimmermann.

This is to add WCSS marquee support , which is defined by OMA and is an extension for CSS2,
It extends CSS display with "display:-wap-marquee;-wap-marquee-dir:xxx;-wap-marquee-speed:xxx;-wap-marquee-style:xxx"
Minor fixes by Eric Seidel and George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=23727

No new tests, the tests have already been landed at LayoutTests/fast/wcss/

19:18 Changeset [47175] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

run-webkit-tests: document --nthly flag in help message

Reviewed by Simon Fraser.

  • Scripts/run-webkit-tests: Added --nthly flag to $usage string.
Also noted that -1singly implies --nthly 1.
18:37 Changeset [47174] by dimich@chromium.org
  • 1 edit
    1 copy
    1 move in trunk/LayoutTests

2009-08-12 Alpha Lam < hclam@chromium.org>

Not reviewed, Windows test fix after http://trac.webkit.org/changeset/47171.
This splits the expected result file into mac and Windows
versions since the result is different on Windows.

  • platform/mac/media/controls-drag-timebar-expected.txt: Renamed from LayoutTests/media/controls-drag-timebar-expected.txt.
  • platform/win/media/controls-drag-timebar-expected.txt: Added.
18:31 Changeset [47173] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-08-12 Eric Seidel <eric@webkit.org>

No review, just adding missing results.

<canvas> without CSS width/height is unaffected by full page zoom
https://bugs.webkit.org/show_bug.cgi?id=26908

Adding missing test results. Unsure why run-webkit-tests didn't fail.

  • fast/canvas/canvas-zoom-expected.checksum: Added.
  • fast/canvas/canvas-zoom-expected.png: Added.
  • fast/canvas/canvas-zoom-expected.txt: Added.
18:07 Changeset [47172] by eric@webkit.org
  • 4 edits
    1 add in trunk

2009-08-12 George Wright <george.wright@torchmobile.com>

Reviewed by David Hyatt.

Test the four cases of width and height being declared or not for a
canvas element with CSS zooming enabled.

https://bugs.webkit.org/show_bug.cgi?id=26908

  • fast/canvas/canvas-zoom.html: Added.

2009-08-12 George Wright <george.wright@torchmobile.com>

Reviewed by David Hyatt.

Update the canvas renderer's intrinsic size with the zoomed
lengths and ensure the intrinsic size is correct when setting
an initial style.

https://bugs.webkit.org/show_bug.cgi?id=26908

Test: fast/canvas/canvas-zoom.html

  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::canvasSizeChanged):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::styleDidChange):
18:00 Changeset [47171] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-08-12 Alpha Lam <hclam@chromium.org>

Reviewed by Simon Fraser.

Fix regression for dragging the media controller thumb.
https://bugs.webkit.org/show_bug.cgi?id=28211

Add a layout test to make sure dragging the timebar thumb of media
controls causes seeks.

  • media/controls-drag-timebar-expected.txt: Added.
  • media/controls-drag-timebar.html: Added.

2009-08-12 Alpha Lam <hclam@chromium.org>

Reviewed by Simon Fraser.

Fix regression for dragging the media controller thumb.
https://bugs.webkit.org/show_bug.cgi?id=28211

Modified the conditions for rejecting events on the media controller
to only rejecting mouse events not from the left button.

Test: media/controls-drag-timebar.html

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler):
17:52 Changeset [47170] by eric@webkit.org
  • 12 edits
    4 adds in trunk

2009-08-12 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Eric Seidel.

Regression test. Tests that two transactions that run on two
different handles for the same DB do not cause a deadlock.

https://bugs.webkit.org/show_bug?id=27966

  • storage/multiple-transactions-on-different-handles-expected.txt: Added.
  • storage/multiple-transactions-on-different-handles.html: Added.

2009-08-12 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Eric Seidel.

Fixing a deadlock caused by two transactions that run on two
different database handles for the same DB. Adding a per-DB thread
transaction coordinator that allows the DB thread to run only one
transaction per DB file at any given time.

Adding a regression test for this bug.

Test: storage/multiple-transactions-on-different-handles.html

https://bugs.webkit.org/show_bug.cgi?id=27996

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/Database.cpp: (WebCore::Database::transactionCoordinator):
  • storage/Database.h:
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread):
  • storage/DatabaseThread.h: (WebCore::DatabaseThread::transactionCoordinator):
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::debugStepName): (WebCore::SQLTransaction::performNextStep): (WebCore::SQLTransaction::aquireLock): (WebCore::SQLTransaction::lockAquired): (WebCore::SQLTransaction::cleanupAfterSuccessCallback): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
  • storage/SQLTransaction.h:
  • storage/SQLTransactionCoordinator.cpp: Added.
  • storage/SQLTransactionCoordinator.h: Added.
17:40 Changeset [47169] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2009-08-12 Eric Seidel <eric@webkit.org>

No review, finishing previous commit.

Add Geolocation layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27716

Add changes missed in http://trac.webkit.org/changeset/47168

  • platform/qt/Skipped:
  • platform/win/Skipped:
17:23 Changeset [47168] by eric@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

2009-08-12 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

Bug 27716: Add Geolocation layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27716

Adds the first, basic Geolocation layout test. This simply tests that
navigator.geolocation is present when it should be.

  • fast/dom/Geolocation: Added. Directory for Geolocation layout tests.
  • fast/dom/Geolocation/enabled.html: Added. HTML wrapper for enabled.js test.
  • fast/dom/Geolocation/resources: Added. Directory for Geolocation layout tests JS source.
  • fast/dom/Geolocation/resources/enabled.js: Added. Tests that navigator.geolocation is present.
  • fast/dom/Geolocation/resources/TEMPLATE.html: Added. Template for creating HTML wrapper files for JS tests with make-js-test-wrappers.
  • fast/dom/Geolocation/enabled-expected.txt: Added. Expected result for above test.
  • platform/mac/Skipped: Modified. Skip Geolocation tests.
  • platform/qt/Skipped: Modified. Skip Geolocation tests.
  • platform/win/Skipped: Modified. Skip Geolocation tests.
17:07 Changeset [47167] by eric@webkit.org
  • 1 edit in trunk/WebKitTools/ChangeLog

2009-08-12 Eric Seidel <eric@webkit.org>

No review, just fixing mismerged ChangeLogs.

17:03 Changeset [47166] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-08-11 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

bugzilla-tool : various improvements for running the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=28199

Make run_and_throw_if_fail silence STDERR as well as STDIN.
I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the output (per abarth's suggestion).
Change a few "print" statements to "log" so they appear in the output.
Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non-string objects).
Added a little more logging so that --quiet mode is easier to understand.
Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
Made curl call (downloading patch files) quieter.

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
  • Scripts/modules/scm.py:

<<<<<<< HEAD:WebKitTools/ChangeLog

16:40 Changeset [47165] by darin@apple.com
  • 24 edits
    2 adds in trunk

WebCore: Custom properties on DOM objects are lost after GC (as demonstrated by the gc-9.html test)
https://bugs.webkit.org/show_bug.cgi?id=28194

Patch by Darin Adler <darin@apple.com> on 2009-08-12
Reviewed by Geoff Garen.

  • GNUmakefile.am: Added the two new source files.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • bindings/js/JSCSSRuleListCustom.cpp: Added.

(WebCore::JSCSSRuleList::markChildren): Call markDOMObjectWrapper
on rules in the list.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::markChildren): Added. Call
markDOMObjectWrapper on the CSSValue objects that are owned by the
declaration as values of the properties.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::isObservableThroughDOM): Added code to handle some
cases where nodes are observable because they own objects that
in turn have custom properties.

  • bindings/js/JSDOMBinding.h: Fix a typo in the header.
  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::markChildren): Added call to markDOMObjectWrapper
for implementation and styleSheets.

  • bindings/js/JSElementCustom.cpp:

(WebCore::JSElement::markChildren): Added. Calls markDOMObjectWrapper
for attributes and style.

  • bindings/js/JSHTMLCanvasElementCustom.cpp: Added.

(WebCore::JSHTMLCanvasElement::markChildren): Call markDOMObjectWrapper
on the rendering context.

  • bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::markChildren): Call markDOMObjectWrapper on
items in the stylesheet.

  • bindings/js/JSStyleSheetListCustom.cpp:

(WebCore::JSStyleSheetList::markChildren): Added. Calls
markDOMObjectWrapper on stylesheets in the list.

  • css/CSSRuleList.idl: Added CustomMarkFunction.
  • css/CSSStyleDeclaration.idl: Ditto.
  • css/StyleSheetList.idl: Ditto.
  • dom/Element.idl: Ditto.
  • html/HTMLCanvasElement.idl: Ditto.
  • dom/Element.h: Made everything private that could be.

Added access to the attributeMap that does returns
the existing map without doing any of the lazy-updating work. This
is needed to get at the existing attributes during garbage collection
without having side effects.

  • html/HTMLCanvasElement.h: Cleaned up the header a bit, making

members private. Added renderingContext2D function for use in
JSHTMLCanvasElement::markChildren.

LayoutTests: Custom properties on DOM objects are lost after GC (as demonstrated by the gc-9.html test)
https://bugs.webkit.org/show_bug.cgi?id=28194

Patch by Darin Adler <darin@apple.com> on 2009-08-12
Reviewed by Geoff Garen.

  • fast/dom/gc-9-expected.txt: Regenerated.
  • fast/dom/gc-9.html: Updated to expect correct behavior instead of failures.
16:35 Changeset [47164] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/WebView.cpp

Build fix for Windows Debug.

16:24 Changeset [47163] by bweinstein@apple.com
  • 6 edits
    2 adds in trunk

2009-08-12 Brian Weinstein <bweinstein@apple.com>

Reviewed by Eric Seidel.

Fixes two bugs about Pan Scrolling - Scrolling with middle mouse button doesn't
work in Expanded view on reader.google.com, and Can enter auto scroll from a non-scrollable area.
https://bugs.webkit.org/show_bug.cgi?id=28023
https://bugs.webkit.org/show_bug.cgi?id=24794

Added a new method to RenderBox seeing if the Box can be scrolled and actually has something to
scroll, and use that for pan scrolling.

Test: platform/win/fast/events/panScroll-nested-divs.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::updateAutoscrollRenderer): (WebCore::EventHandler::handleMousePressEvent):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::canBeScrolledAndHasScrollableArea):
  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively):

2009-08-12 Brian Weinstein <bweinstein@apple.com>

Reviewed by Eric Seidel.

Added a Windows test for https://bugs.webkit.org/show_bug.cgi?id=28023.

  • platform/win/fast/events/panScroll-nested-divs-expected.txt: Added.
  • platform/win/fast/events/panScroll-nested-divs.html: Added.
16:19 Changeset [47162] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/6017913> Replace use of HISearchWindowShow in -[WebView _searchWithSpotlightFromMenu].

Reviewed by Kevin Decker.

  • WebView/WebView.mm:

(-[WebView _searchWithSpotlightFromMenu:]): Use -[NSWorkspace showSearchResultsForQueryString:] post-Leopard.

16:12 Changeset [47161] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/ChangeLog

Fix missing "by" in ChangeLog.

16:10 Changeset [47160] by bweinstein@apple.com
  • 5 edits in trunk

2009-08-12 Brian Weinstein <bweinstein@apple.com>

Reviewed Adam Roben.

Fix of <rdar://6728361> Mouse wheel scrolling on a page with expanded drop down
list detaches drop down.

Added a check in mouseWheel to see if our focus is currently in a popup, if so, close
the popup (matches other browser behavior).

  • WebView.cpp: (WebView::mouseWheel):

2009-08-12 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

Fix of <rdar://6728361> Mouse wheel scrolling on a page with expanded drop down
list detaches drop down.

Added a function for Windows PopupMenu's to return their class name.

  • platform/PopupMenu.h:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::popupClassName):
16:07 Changeset [47159] by adachan@apple.com
  • 3 edits in trunk/JavaScriptCore

Added workaround for the limitation that VirtualFree with MEM_RELEASE
can only accept the base address returned by VirtualAlloc when the region
was reserved and it can only free the entire region, and not a part of it.

Reviewed by Oliver Hunt.

  • runtime/MarkStack.h: (JSC::MarkStack::MarkStackArray::shrinkAllocation):
  • runtime/MarkStackWin.cpp: (JSC::MarkStack::releaseStack):
16:03 Changeset [47158] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-08-12 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dan Bernstein.

WINCE PORT: Color and Gradient
https://bugs.webkit.org/show_bug.cgi?id=27511

  • platform/graphics/wince/ColorWince.cpp: Added.
  • platform/graphics/wince/GradientWince.cpp: Added.
15:55 Changeset [47157] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dan Bernstein.

fix a typo in platform/graphics/skia/PlatformContextSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=28172

No new tests because it's a just typo fix.

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintCommon):
15:49 Changeset [47156] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-08-12 George Wright <george.wright@torchmobile.com>

Reviewed by Adam Treat.

Initialise zoom levels independent of whether a URL is valid or not to
fix https://bugs.webkit.org/show_bug.cgi?id=28162

  • QtLauncher/main.cpp: (MainWindow::MainWindow):
15:21 Changeset [47155] by pkasting@chromium.org
  • 10 edits
    8 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=27458
Support for the :default CSS pseudoclass, as per HTML5 spec.
http://www.whatwg.org/specs/web-apps/current-work/multipage/interactive-elements.html#selector-default

Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-12
Reviewed by Darin Adler.

Tests: fast/css/pseudo-default-001.html

fast/css/pseudo-default-002.html
fast/css/pseudo-default-003.html
fast/css/pseudo-default-004.html

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::extractPseudoType): pseudoDefault

  • css/CSSSelector.h:

(WebCore::CSSSelector::):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement): sharing stuff is
aware that only one default button can be present in a form
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): applies
the :default CSS pseudoclass

  • dom/Element.h:

(WebCore::Element::isDefaultButtonForForm): new method to determine
whether a FormControl is a default button for a given form

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isDefaultButtonForForm): ditto

  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::defaultButton): extracts the default button
from the form

  • html/HTMLFormElement.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=27458
Test suite for the :default CSS pseudoclass.

Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-12
Reviewed by Darin Adler.

  • fast/css/pseudo-default-001-expected.txt: Added.
  • fast/css/pseudo-default-001.html: Added.
  • fast/css/pseudo-default-002-expected.txt: Added.
  • fast/css/pseudo-default-002.html: Added.
  • fast/css/pseudo-default-003-expected.txt: Added.
  • fast/css/pseudo-default-003.html: Added.
  • fast/css/pseudo-default-004-expected.txt: Added.
  • fast/css/pseudo-default-004.html: Added.
15:15 Changeset [47154] by pkasting@chromium.org
  • 7 edits in trunk

WebKitLibraries: https://bugs.webkit.org/show_bug.cgi?id=27323
Change pattern that strips all trailing whitespace to just remove EOL
chars (\r, \n), to make it clear that varying EOL chars is the primary
problem being solved.

Reviewed by Darin Adler.

  • win/tools/scripts/auto-version.sh:

WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=27323
Change pattern that strips all trailing whitespace to just remove EOL
chars (\r, \n), to make it clear that varying EOL chars is the primary
problem being solved.

Reviewed by Darin Adler.

  • Scripts/prepare-ChangeLog:
  • Scripts/resolve-ChangeLogs:
  • Scripts/svn-create-patch:
  • Scripts/update-webkit:
15:10 Changeset [47153] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-08-12 David Levin <levin@chromium.org>

No review, rolling out r47106.
https://bugs.webkit.org/show_bug.cgi?id=28215

This patch relied on a new version of v8 which is not available
in chromium yet.

  • bindings/v8/V8Binding.cpp: (WebCore::v8StringToAtomicWebCoreString):
15:08 Changeset [47152] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-08-12 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

Bug 26993 : Geolocation::requestPermission()
https://bugs.webkit.org/show_bug.cgi?id=26993

Second patch to allow the Geolocation permission request to chrome to be asynchronous
or synchronous. Fixes a bug where callbacks were called twice when permissions
are granted synchronously.

No new tests required.

  • page/Geolocation.cpp: (WebCore::Geolocation::setIsAllowed): Modified. Calls makeSuccessCallbacks() rather than geolocationServicePositionChanged(). (WebCore::Geolocation::geolocationServicePositionChanged): Modified. Updated logic to avoid repeated callbacks when permissions are granted synchronously. (WebCore::Geolocation::makeSuccessCallbacks): Added. Calls success callbacks.
  • page/Geolocation.h: Modified. Adds makeSuccessCallbacks().
15:03 Changeset [47151] by andersca@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6952336>
CrashTracer: [USER] 3 crashes in Safari at com.apple.WebCore • WebCore::SecurityOrigin::canAccess const + 27

Reviewed by Sam Weinig.

Make sure to set the security origin before calling dispatchWindowObjectAvailable.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::begin):

14:49 Changeset [47150] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2009-08-12 Xiaomei Ji <xji@chromium.org>

Reviewed by Eric Seidel.

Fix [Chromium] drop down menu letter selection, skip selections
https://bugs.webkit.org/show_bug.cgi?id=28205

Not auto-testable since it is chromim platform specific code, and it involves sending a keyboard
event to the popup, which is not possible (eventSender sends the key
events through webview, we want to go through the webwidget).

  • manual-tests/keyboard_select_elements_with_same_beginning.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::isCharacterTypeEvent): style change. (WebCore::PopupListBox::handleKeyEvent): typeAheadFind should be called only when the event is a character type event to avoid calling twice for English. (WebCore::PopupListBox::typeAheadFind): remove unnecessary checking of isCharacterTypeEvent() since the whole function is only called under that condition.
14:22 Changeset [47149] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed build fix.

Last-minute change on the new soup API to use the keyring was not
reflected in our usage - the documentation says we should use
g_slist_free, and soup_auth_free_saved_users doesn't exist.

  • webkit/webkitsoupauthdialog.c: (session_authenticate):
14:08 Changeset [47148] by aroben@apple.com
  • 3 edits in trunk/WebKit/win

Make WebPreferenceKeysPrivate.h available for client use

Reviewed by Dave Hyatt.

Fixes <http://webkit.org/b/28227>.

  • WebKit.vcproj/WebKit.vcproj: Copy WebPreferenceKeysPrivate.h to

$WebKitOutputDir, just like we do for a few other headers. Also let VS
reorder some XML attributes.

  • WebPreferenceKeysPrivate.h: Touched this file to force a build.
14:02 Changeset [47147] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2009-08-12 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Adding GraphicsContext to WebCore/platform/graphics/haiku.
https://bugs.webkit.org/show_bug.cgi?id=28130

  • platform/graphics/haiku/GraphicsContextHaiku.cpp: Added. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::platformContext): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::setPlatformShouldAntialias): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::setURLForRect): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::getHaikuStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::clearPlatformShadow): (WebCore::GraphicsContext::setPlatformShadow):
13:55 Changeset [47146] by eric@webkit.org
  • 15 edits in trunk/WebCore

2009-08-12 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Modifying WebCore/platform/graphics files to allow Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=28128

  • platform/graphics/BitmapImage.h: Adding getBBitmap() function.
  • platform/graphics/Color.h: rgb_color is the Color struct in Haiku.
  • platform/graphics/FloatPoint.h: BPoint is the Point class in Haiku.
  • platform/graphics/FloatRect.h: BRect is the Rect class in Haiku.
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h: BView is the PlatformGraphicsContext class for Haiku. Adding getHaikuStrokeStyle() function.
  • platform/graphics/Icon.h: Adding an empty Icon() constructor because this class isn't implemented for the moment.
  • platform/graphics/ImageSource.h: BBitmap is the native bitmap class for Haiku.
  • platform/graphics/IntPoint.h: BPoint is the Point class in Haiku.
  • platform/graphics/IntRect.h: BRect is the Rect class in Haiku.
  • platform/graphics/IntSize.h: BSize is the Size class in Haiku.
  • platform/graphics/Path.h: BRegion is the Path class in Haiku.
  • platform/graphics/Pattern.h: Adding the GraphicsDef.h header and the native pattern type.
  • platform/graphics/SimpleFontData.h: Adding Haiku's Font.h header.
13:44 Changeset [47145] by eric@webkit.org
  • 11 edits in trunk/WebCore

2009-08-12 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Adding modification to the WebCore/platform/ files to allow
the Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=28128

  • platform/ContextMenuItem.h: BMenu is the PlatformMenuItemDescription class of Haiku.
  • platform/Cursor.h: BCursor is the Cursor class of Haiku.
  • platform/DragData.h: Use a BMessage as DragDataRef.
  • platform/DragImage.h: Use a BBitmap as DragImageRef.
  • platform/PlatformKeyboardEvent.h: Use BMessage as event vehicle.
  • platform/PlatformMenuDescription.h: BMenu is the PlatformMenuDescription class of Haiku.
  • platform/PlatformMouseEvent.h: Use BMessage as event vehicle.
  • platform/PlatformWheelEvent.h: Use BMessage as event vehicle.
  • platform/PopupMenu.h: Adding a m_menu attribute for Haiku.
  • platform/Widget.h: BView is the PlatformWidget class of Haiku.
13:35 Changeset [47144] by eric@webkit.org
  • 9 edits in trunk/WebCore

2009-08-12 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Tiny modifications on WebCore files to allow Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=28128

  • bindings/js/ScriptControllerHaiku.cpp: Style cleanup.
  • loader/CachedFont.cpp: Haiku behaves like Qt, Gtk, or Chromium, so many PLATFORM(HAIKU) were added to these functions. (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allClientsRemoved):
  • page/EventHandler.cpp: Like the mac and Qt port, Haiku doesn't need the invertSenseOfTabsToLinks() function.
  • page/haiku/DragControllerHaiku.cpp: Style cleanup.
  • platform/image-decoders/ImageDecoder.h: For image decoding Haiku behaves like Cairo or Wx, (not like Skia). (WebCore::RGBA32Buffer::getAddr):
  • platform/text/PlatformString.h: Adding the String(BString&) and BString() methods specific to Haiku.
  • platform/text/UnicodeRange.h: Haiku needs to include stdint.h.
  • platform/text/haiku/TextBreakIteratorInternalICUHaiku.cpp: (WebCore::currentSearchLocaleID): Missing function.
13:23 Changeset [47143] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-08-12 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Adding the ScrollbarTheme files.
https://bugs.webkit.org/show_bug.cgi?id=28125

  • platform/haiku/ScrollbarThemeHaiku.cpp: Added. (buttonWidth): (WebCore::ScrollbarTheme::nativeTheme): (WebCore::ScrollbarThemeHaiku::ScrollbarThemeHaiku): (WebCore::ScrollbarThemeHaiku::~ScrollbarThemeHaiku): (WebCore::ScrollbarThemeHaiku::scrollbarThickness): (WebCore::ScrollbarThemeHaiku::hasButtons): (WebCore::ScrollbarThemeHaiku::hasThumb): (WebCore::ScrollbarThemeHaiku::backButtonRect): (WebCore::ScrollbarThemeHaiku::forwardButtonRect): (WebCore::ScrollbarThemeHaiku::trackRect): (WebCore::ScrollbarThemeHaiku::paintScrollbarBackground): (WebCore::ScrollbarThemeHaiku::paintButton): (WebCore::ScrollbarThemeHaiku::paintThumb):
  • platform/haiku/ScrollbarThemeHaiku.h: Added.
13:16 Changeset [47142] by eric@webkit.org
  • 1 edit
    9 adds in trunk/WebCore

2009-08-12 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Adding eight simple files to WebCore/platform/graphics/haiku.
https://bugs.webkit.org/show_bug.cgi?id=28122

  • platform/graphics/haiku/ColorHaiku.cpp: Added. (WebCore::Color::Color): (WebCore::Color::operator rgb_color): (WebCore::focusRingColor):
  • platform/graphics/haiku/FloatPointHaiku.cpp: Added. (WebCore::FloatPoint::FloatPoint): (WebCore::FloatPoint::operator BPoint):
  • platform/graphics/haiku/FloatRectHaiku.cpp: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator BRect):
  • platform/graphics/haiku/GradientHaiku.cpp: Added. (WebCore::Gradient::platformDestroy): (WebCore::Gradient::platformGradient): (WebCore::Gradient::fill):
  • platform/graphics/haiku/IntPointHaiku.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator BPoint):
  • platform/graphics/haiku/IntRectHaiku.cpp: Added. (WebCore::IntRect::IntRect): (WebCore::IntRect::operator BRect):
  • platform/graphics/haiku/IntSizeHaiku.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator BSize):
  • platform/graphics/haiku/PathHaiku.cpp: Added. (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::hasCurrentPoint): (WebCore::Path::contains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::clear): (WebCore::Path::isEmpty): (WebCore::Path::debugString): (WebCore::Path::apply): (WebCore::Path::transform): (WebCore::Path::strokeBoundingRect):
13:03 Changeset [47141] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-08-12 Eric Seidel <eric@webkit.org>

No review, just fixing line-endings.

Change from DOS to unix line endings on tests from
http://trac.webkit.org/changeset/47130

  • fast/events/set-event-in-another-frame-expected.txt:
  • fast/events/set-event-to-null-expected.txt:
12:51 Changeset [47140] by andersca@apple.com
  • 41 edits
    6 deletes in trunk

As per Eric Carlson's request, revert r47110 (and the follow-up fixes r47113 and r47117) since it causes ~3000 Qt tests to fail.

12:45 Changeset [47139] by treat@webkit.org
  • 1 edit
    1 add in trunk/WebCore

WINCE PORT: Implement Keygen for WINCE
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Lyon Chen <lyon.chen@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.

  • platform/wince/KeygenWince.cpp: Added.
12:41 Changeset [47138] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Rubber-stamped by Kevin Ollivier.

Handle crash in wx due to null value passed to strlen in
the CString constructor.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::certificatePath): Check for null return from getenv
and use default CString constructor instead.

12:41 Changeset [47137] by treat@webkit.org
  • 1 edit
    4 adds in trunk/WebCore

WINCE PORT: simple stubs to make it build for WINCE
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by Eric Seidel.

  • platform/wince/DragDataWince.cpp: Added.
  • platform/wince/DragImageWince.cpp: Added.
  • platform/wince/EditorWince.cpp: Added.
  • platform/wince/KURLWince.cpp: Added.
12:38 Changeset [47136] by treat@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

WINCEPORT: FileSystem and FileChooser
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.

  • platform/wince/FileChooserWince.cpp: Added.
  • platform/wince/FileSystemWince.cpp: Added.
12:35 Changeset [47135] by treat@webkit.org
  • 1 edit
    1 add in trunk/WebCore

WINCE PORT: implement Cursor for WINCE. There's no real cursor on most
WinMob devices. We pass the cursor info to application, which so that
can determine what to do.
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by Eric Seidel.

  • platform/wince/CursorWince.cpp: Added.
12:32 Changeset [47134] by treat@webkit.org
  • 1 edit
    1 add in trunk/WebCore

WINCE PORT: MIMETypeRegistry
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.

  • platform/wince/MIMETypeRegistryWince.cpp: Added.
12:28 Changeset [47133] by treat@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

WINCE PORT: Pasteboard and SearchPopupMenu
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Joe Mason <joe.mason@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.

  • platform/wince/PasteboardWince.cpp: Added.
  • platform/wince/SearchPopupMenuWince.cpp: Added.
12:24 Changeset [47132] by treat@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

WINCE PORT: Add SharedTimerWince.cpp and SystemTimeWince.cpp
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.

  • platform/wince/SharedTimerWince.cpp: Added.
  • platform/wince/SystemTimeWince.cpp: Added.
12:18 CreatingLayoutTests edited by mike.fenton@torchmobile.com
Add link to writing a good test case. (diff)
12:11 CreatingLayoutTests edited by mike.fenton@torchmobile.com
Re-Organization and update. (diff)
12:05 Changeset [47131] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 Mark Mentovai <mark@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=28204
Allow C++ exceptions to be disabled in WebCore's V8 Mac build.

  • WebCorePrefix.h: Only undefine |try| and |catch| when building Objective-C[++], leaving the C++ library definitions intact for C++.
11:43 Changeset [47130] by japhet@chromium.org
  • 6 edits
    4 adds in trunk

2009-08-12 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Add a Custom Setter for DOMWindowEvent in the V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=27719

Tests: fast/events/set-event-in-another-frame.html

fast/events/set-event-to-null.html

11:37 Changeset [47129] by xan@webkit.org
  • 5 edits in trunk

2009-08-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Remove keyring optional features
https://bugs.webkit.org/show_bug.cgi?id=28173

Remove keyring support, we now do authentication storage through
libsoup. We depend on libsoup master now, will bump the dependency
when there's a new release.

  • GNUmakefile.am:
  • configure.ac:

WebKit/gtk:

2009-08-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Remove keyring optional features
https://bugs.webkit.org/show_bug.cgi?id=28173

Remove keyring support from our code and rely on libsoup to store
the authentication data if the user requests that support in their
application/library.

  • webkit/webkitsoupauthdialog.c: (response_callback): (show_auth_dialog): (session_authenticate):
11:33 Changeset [47128] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-12 Eric Seidel <eric@webkit.org>

No review, just skipping tests to make the bots green.

REGRESSION (r47110): 4 media regressions on the bots
https://bugs.webkit.org/show_bug.cgi?id=28221

Skipping these until Eric Carlson has a fix.

  • platform/mac/Skipped:
11:27 Changeset [47127] by pkasting@chromium.org
  • 4 edits
    1 delete in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=27965
Merge wx/ImageSourceWx.cpp into ImageSource.cpp. No changes to
ImageSource.cpp were needed, so this just deletes ImageSourceWx.cpp.

Reviewed by Adam Treat.

  • WebCore.gypi:
  • WebCoreSources.bkl:
  • platform/graphics/wx/ImageSourceWx.cpp: Removed.
  • webcore-wx.bkl:
11:23 Changeset [47126] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=27933
Build fix after r47099.

Reviewed by Dave Levin.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

11:18 Changeset [47125] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx waf build fix, add new directories to the build.

11:11 Changeset [47124] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wxPython build fix, the SWIG defines must also be available when compiling.

10:56 Changeset [47123] by cfleizach@apple.com
  • 3 edits in trunk/LayoutTests

Bug 28219: platform/mac/accessibility/string-range-contains-listmarker.html fails on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=28219

Reviewed by Eric Seidel.

  • platform/mac-snowleopard/Skipped:
  • platform/mac/accessibility/string-range-contains-listmarker.html:
10:23 Changeset [47122] by aroben@apple.com
  • 7 edits in trunk

Remove support for a window resizer within the WebView

WebKit/win:

Starting with Safari 4, there is never a window resizer inside the
WebView, so we no longer need to support that functionality.

Fixes <http://webkit.org/b/28190> Remove support for a window resizer
within the WebView

Reviewed by Dave Hyatt.

  • Interfaces/IWebUIDelegatePrivate.idl: Replaced the delegate

functions related to the window resizer with unused*() functions. We
can't remove them entirely because we need to keep the vtable
unchanged so new versions of WebKit will work with old versions of
Safari (e.g., for nightlies and WebKit development).

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::windowResizerRect): Now always returns an empty
rect.

  • WebView.cpp:

(WebView::paint):
(WebView::handleMouseEvent):

  • WebView.h:

Removed window-resizer-related code.

WebKitTools:

Update DumpRenderTree for IWebUIDelegatePrivate changes

Reviewed by Dave Hyatt.

  • DumpRenderTree/win/UIDelegate.h: Updated to match

IWebUIDelegatePrivate.

10:18 Changeset [47121] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Don't try to seek to the end of stdin on Cygwin

Doing so seems to always cause an exception (for unknown reasons).

Fixes <http://webkit.org/b/28159> create-bug throws an exception in
Cygwin

Reviewed by Dave Kilzer.

  • Scripts/bugzilla-tool:

(CreateBug.prompt_for_bug_title_and_comments): Ignore IOErrors
generated by calling sys.stdin.seek, since these seem to be generated
for no good reason on Cygwin.

10:17 Changeset [47120] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Don't raise an exception when --cc is not passed to create-bug

Fixes <http://webkit.org/b/28158> create-bug throws an exception if
--cc is not specified

Reviewed by Dave Kilzer.

  • Scripts/modules/bugzilla.py:

(Bugzilla.create_bug_with_patch): Only set the "cc" field if a CC
string was specified. Otherwise we'll generate an exception about the
"cc" variable not being a string.

09:55 Changeset [47119] by bolsinga@apple.com
  • 3 edits in trunk/WebKit/mac

Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153

Reviewed by Eric Seidel.

Have ObjC delegate methods match C++ method names in the ChromeClient.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::formDidFocus):
(WebChromeClient::formDidBlur):

  • WebView/WebUIDelegatePrivate.h:
09:50 Changeset [47118] by treat@webkit.org
  • 1 edit
    4 adds in trunk/WebCore

WINCE PORT: Implement Path for WINCE. Most code can be
reused for other ports that don't have native path support
https://bugs.webkit.org/show_bug.cgi?id=28188

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-08
Reviewed by Adam Treat.

Written also by George Staikos (including quadCurve() and bezier())

  • platform/graphics/wince/PathWince.cpp: Added.
  • platform/graphics/wince/PlatformPathWince.cpp: Added.
  • platform/graphics/wince/PlatformPathWince.h: Added.
  • platform/graphics/wince/WinceGraphicsExtras.h: Added.
09:49 Changeset [47117] by eric.carlson@apple.com
  • 2 edits in trunk/WebKit/win

2009-08-12 Eric Carlson <eric.carlson@apple.com>

Windows build fix.

  • WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaTimeDescription):
09:43 Changeset [47116] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 Joseph Pecoraro <joepeck02@gmail.com>

"Double-click to add" new style button does not always show up [quick fix]
https://bugs.webkit.org/show_bug.cgi?id=28187

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
09:42 Changeset [47115] by eric@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

2009-08-12 Crystal Zhang <crystal.zhang@torchmobile.com>

Reviewed by George Staikos.

WINCE PORT: MediaPlayerProxy and MediaPlayerPrivate
https://bugs.webkit.org/show_bug.cgi?id=28178

  • platform/graphics/wince/MediaPlayerPrivateWince.h: Added.
  • platform/graphics/wince/MediaPlayerProxy.cpp: Added.
  • platform/graphics/wince/MediaPlayerProxy.h: Added.
09:41 Changeset [47114] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=28175

Call QDir::toNativeSeparators() before the path is passed to the OS.

Based on work by David Leong.

  • platform/qt/FileSystemQt.cpp: (WebCore::pathByAppendingComponent):
09:41 Changeset [47113] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-08-12 Eric Carlson <eric.carlson@apple.com>

Tiger build fix.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

Define NSAccessibilityTimelineSubrole for Tiger.

09:35 Changeset [47112] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 Dirk Schulze <krit@webkit.org>

Reviewed by Ariya Hidayat.

Minor build-fix for SVG Filter. Use getUnmultipliedImageData instead
of getImageData. This changed since r47099.

  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
09:26 Changeset [47111] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-08-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool : various improvements for running the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=28199

Make run_and_throw_if_fail silence STDERR as well as STDIN.
I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the out
Change a few "print" statements to "log" so they appear in the output.
Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non
Added a little more logging so that --quiet mode is easier to understand.
Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
Made curl call (downloading patch files) quieter.

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
  • Scripts/modules/scm.py:
09:20 Changeset [47110] by eric.carlson@apple.com
  • 41 edits
    6 adds in trunk

2009-08-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

Test: accessibility/media-element.html

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

Add AccessibilityMediaControls.cpp/.h

  • accessibility/AXObjectCache.cpp:
  • accessibility/AXObjectCache.h: (WebCore::AXObjectCache::getOrCreate):

Create AccessibilityMediaControl. Update Copyright

  • accessibility/AccessibilityMediaControls.cpp:
  • accessibility/AccessibilityMediaControls.h:

Added.

  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityObject.h:

Add isMediaTimeline. Update Copyright.

  • accessibility/AccessibilitySlider.h:

Make constructor protected instead of private so AccessibilityMediaTimeline can
call it.

  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeNames]):

Add NSAccessibilityValueDescriptionAttribute to range attributes.

(-[AccessibilityObjectWrapper subrole]):

Return NSAccessibilityTimelineSubrole for AccessibilityMediaTimeline.

  • dom/Node.h:

add isMediaControlElement.

  • page/mac/WebCoreViewFactory.h:
  • platform/LocalizedStrings.h:
  • platform/mac/LocalizedStringsMac.mm: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):

New, return localized media controller strings.

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::MediaControlElement):

Initialize m_displayType.

(WebCore::MediaControlElement::MediaControlElement):
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):

Fix style.

(WebCore::MediaControlInputElement::MediaControlInputElement):

Set m_displayType based on pseudo style ID.

(WebCore::MediaControlInputElement::MediaControlInputElement):

rename local "o" to "object".

(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):

Update for MediaControlInputElement constructor change.

(WebCore::MediaControlTimeDisplayElement::formatTime):

New, moved here from RenderMedia so AccessibilityMediaTimeDisplay can use it.

(WebCore::MediaControlTimeDisplayElement::setCurrentValue):

New, set text to current time.

  • rendering/MediaControlElements.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):

Create controls in tab order.

(WebCore::RenderMedia::formatTime):

Moved to MediaControlTimeDisplayElement::formatTime.

(WebCore::RenderMedia::updateTimeDisplay):

Call MediaControlTimeDisplayElement::setCurrentValue.

  • rendering/RenderMedia.h:

2009-08-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

Add localized strings for media controller accessiblility.

  • English.lproj/Localizable.strings:

2009-08-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory localizedMediaControlElementString:]): (-[WebViewFactory localizedMediaControlElementHelpText:]): (-[WebViewFactory localizedMediaTimeDescription:]):

New.

2009-08-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

  • WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):

New.

2009-08-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

  • accessibility/media-element.html: Added.
  • platform/mac-leopard/accessibility/media-element-expected.txt:
  • platform/mac-leopard/media/controls-strict-expected.txt:
  • platform/mac/accessibility/media-element-expected.txt:

Added.

  • platform/mac-leopard/media/controls-after-reload-expected.txt:
  • platform/mac-leopard/media/controls-styling-expected.txt:
  • platform/mac-leopard/media/video-empty-source-expected.txt:
  • platform/mac-leopard/media/video-zoom-controls-expected.txt:
  • media/video-controls-visible-audio-only.html:
  • platform/mac-leopard/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-styling-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-empty-source-expected.txt:
  • platform/mac/media/video-zoom-controls-expected.txt:

Update for controller element tab order change.

09:17 Changeset [47109] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-11 Eric Seidel <eric@webkit.org>

No review, script regression fix only.

run-webkit-tests --quiet hangs
https://bugs.webkit.org/show_bug.cgi?id=28202

Do a huge dance to get open3 to pipe to /dev/null w/o blocking.
This was what I came up with after discussions in #perl.

  • Scripts/run-webkit-tests:
09:00 Changeset [47108] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-08-12 Viet-Trung Luu <viettrungluu@gmail.com>

Reviewed by Dimitri Glazkov.

Explicitly set control tints for Chromium/Mac, since the controls'
NSCell(s) lack an NSView and hence their tint isn't updated
automatically when the application is activated/deactivated.
https://bugs.webkit.org/show_bug.cgi?id=28108
http://crbug.com/18199

  • rendering/RenderThemeChromiumMac.mm: (WebCore::updateNSCellControlTint): (WebCore::RenderThemeChromiumMac::paintCheckbox): (WebCore::RenderThemeChromiumMac::paintRadio): (WebCore::RenderThemeChromiumMac::paintButton): (WebCore::RenderThemeChromiumMac::paintMenuList): (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintSearchField): (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton):
08:59 Changeset [47107] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

(no review) Disabling a failing test.

<rdar://problem/7136851> platform/mac/accessibility/string-range-contains-listmarker.html fails.

  • platform/mac-snowleopard/Skipped:
08:53 Changeset [47106] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-08-12 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>

Reviewed by Dimitri Glazkov.

[V8] Fix atomic string externalization crash.
Atomic string externalization assumes that all non-empty strings
can be externalized which is untrue on 64-bit. This change fixed
that.

https://bugs.webkit.org/show_bug.cgi?id=28215

This bug causes loads of test crashes, no need to add new tests
specifically for this.

  • bindings/v8/V8Binding.cpp: (WebCore::v8StringToAtomicWebCoreString):
07:16 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:55 Changeset [47105] by ariya@webkit.org
  • 5 edits in trunk

WebCore/ChangeLog:

2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Holger Freyther.

[Qt] Fix box-shadow painting in r47103. The edge should not be blurry.
Also optimize by not having to save and restore painter state.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::fillRect):

LayoutTests/ChangeLog:

2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Holger Hans Peter Freyther.

[Qt] Update the pixel tests for shadow edge fix.

  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
06:02 Changeset [47104] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Adam Treat.

[Qt] Fix coding style in GraphicsContextQt.cpp

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): (WebCore::toQtLineCap): (WebCore::toQtLineJoin): (WebCore::GraphicsContextPlatformPrivate::p): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness):
05:19 Changeset [47103] by ariya@webkit.org
  • 5 edits
    2 adds in trunk

WebCore/ChangeLog:

2009-08-12 Szabo Carol <carol.szabo@nokia.com>

Reviewed by Simon Hausmann and Ariya Hidayat.

https://bugs.webkit.org/show_bug.cgi?id=23291

[Qt] Partial support for -webkit-box-shadow. Blur is not support and
the shadow still does not go well with border radius.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::fillRect):

LayoutTests/ChangeLog:

2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Pixel tests for (partial) -webkit-box-shadow support.

  • platform/qt/Skipped: Include basic-shadows.
  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum: Added.
  • platform/qt/fast/box-shadow/basic-shadows-expected.png: Added.
  • platform/qt/fast/box-shadow/basic-shadows-expected.txt: Adjusted.
04:42 Changeset [47102] by ariya@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-12 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

Build fix: use std::numeric_limits<long long>::min() instead of LLONG_MIN
since LLONG_MIN is not defined in standard c++.

  • runtime/UString.cpp: (JSC::UString::from):
04:30 Changeset [47101] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

QtWebKit compile fix for Windows CE

Patch by Joerg Bornemann <joerg.bornemann@trolltech.com> on 2009-08-12
Reviewed by Simon Hausmann.

There's no getenv on Windows CE, use qgetenv instead.

  • Api/qwebpage.cpp:

(qt_drt_overwritePluginDirectories):

03:12 Changeset [47100] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-08-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

Use AM_V_GEN in a few more places, for less noisy builds.

  • GNUmakefile.am:
03:11 Changeset [47099] by krit@webkit.org
  • 9 edits in trunk/WebCore

2009-08-12 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

SVG Filter premultiplied color support for getImageDate/putImageData
https://bugs.webkit.org/show_bug.cgi?id=27933

Some SVG Filters need premultiplied ImageData for the calculation. Therefore getImageData
and putImageData of ImageBuffer need support for premultiplied colors.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData): (WebCore::CanvasRenderingContext2D::putImageData):
  • platform/graphics/ImageBuffer.h: (WebCore::):
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
02:58 Changeset [47098] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-12 Benjamin Otte <otte@gnome.org>

Reviewed by Jan Alonzo.

Buildfix for Gtk platforms debug builds.

  • GNUmakefile.am: Choose MarkStackPosix.cpp or MarkStackWin.cpp depending on platform.
02:13 Changeset [47097] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

Prospective build fix for Mac and 32-bit Windows.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-12

  • runtime/UString.cpp: Include wtf/StringExtras.h for snprintf.

(JSC::UString::from): Use %lld instead of %I64d for snprintf
on non-windows platforms.

01:58 Changeset [47096] by hausmann@webkit.org
  • 3 edits in trunk/JavaScriptCore

Fix compile error on 64Bit Windows, when UString::from
is called with an intptr_t.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-08-12
Reviewed by Simon Hausmann.

Added new UString::From overload with long long parameter.

Thanks to Holger for the long long idea.

  • runtime/UString.cpp:

(JSC::UString::from):

  • runtime/UString.h:
01:18 QtWebKitJournal edited by hausmann@webkit.org
(diff)
01:04 QtWebKitFeatures46 edited by hausmann@webkit.org
(diff)
00:59 Changeset [47095] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-08-12 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Changed Number.bytesToString to support low-resolution output.

https://bugs.webkit.org/show_bug.cgi?id=28146

  • inspector/front-end/utilities.js: (Number.bytesToString):
00:53 Changeset [47094] by hausmann@webkit.org
  • 3 edits
    1 add in trunk/WebCore

Add support for hooking BeginPaint/EndPaint on 64Bit Windows

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-08-12
Reviewed by Simon Hausmann.

Webkit uses the runtime patching trick explained by "Feng Yuan" for
hooking these paint functions. It currently supports only 32bit assembly
code. This patch adds support for 64Bit version. Since inline-assemblies
are not supported for 64Bit, we have use a seperate .asm file.

  • WebCore.pro:
  • plugins/win/PaintHooks.asm: Added.
  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::hookedBeginPaint):
(WebCore::PluginView::hookedEndPaint):
(WebCore::hook):

Note: See TracTimeline for information about the timeline view.