Timeline


and

08/26/09:

23:38 Changeset [47810] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-26 Cameron McCormack <cam@mcc.id.au>

Reviewed by David Kilzer.

Make prepare-ChangeLog notice property changes
https://bugs.webkit.org/show_bug.cgi?id=28675

Make the generated ChangeLog entry include a short description of
property changes if there were such changes. Also make
prepare-ChangeLog not bail if the only changes are property changes.

  • Scripts/prepare-ChangeLog:
23:33 Changeset [47809] by abarth@webkit.org
  • 6 edits
    4 adds in trunk/LayoutTests

2009-08-26 Yaar Schnitman <yaar@chromium.org>

Reviewed by Adam Barth.

Re-baselined and created new isolatedWorld tests to play nice with localStorage & sessionStorage.
https://bugs.webkit.org/show_bug.cgi?id=27992

  • http/tests/security/isolatedWorld/all-window-properties.html: Re-baselined.
  • http/tests/security/isolatedWorld/storage-properties-expected.txt: Added.
  • http/tests/security/isolatedWorld/storage-properties.html: Added.
  • http/tests/security/isolatedWorld/storage-prototype-expected.txt: Added.
  • http/tests/security/isolatedWorld/storage-prototype.html: Added.
  • platform/qtk/Skipped: Added new tests.
  • platform/mac/Skipped: Added new tests.
  • platform/qt/Skipped: Added new tests.
  • platform/win/Skipped: Added new tests.
22:22 Changeset [47808] by abarth@webkit.org
  • 39 edits in trunk/WebCore

2009-08-26 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Adam Barth.

Removing trailing whitespaces from all storage classes.

https://bugs.webkit.org/show_bug.cgi?id=28075

  • storage/ChangeVersionWrapper.cpp:
  • storage/Database.cpp:
  • storage/Database.h:
  • storage/DatabaseDetails.h:
  • storage/DatabaseThread.cpp:
  • storage/DatabaseTracker.cpp:
  • storage/DatabaseTracker.h:
  • storage/LocalStorageTask.cpp:
  • storage/LocalStorageTask.h:
  • storage/LocalStorageThread.cpp:
  • storage/LocalStorageThread.h:
  • storage/OriginQuotaManager.cpp:
  • storage/OriginUsageRecord.cpp:
  • storage/OriginUsageRecord.h:
  • storage/SQLError.h:
  • storage/SQLResultSetRowList.h:
  • storage/SQLStatement.cpp:
  • storage/SQLStatement.h:
  • storage/SQLStatementCallback.h:
  • storage/SQLStatementErrorCallback.h:
  • storage/SQLTransaction.cpp:
  • storage/SQLTransaction.h:
  • storage/SQLTransactionCallback.h:
  • storage/SQLTransactionErrorCallback.h:
  • storage/Storage.cpp:
  • storage/Storage.h:
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp:
  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp:
  • storage/StorageAreaSync.h:
  • storage/StorageEvent.cpp:
  • storage/StorageEvent.h:
  • storage/StorageMap.cpp:
  • storage/StorageMap.h:
  • storage/StorageNamespaceImpl.cpp:
  • storage/StorageSyncManager.cpp:
  • storage/StorageSyncManager.h:
22:21 Changeset [47807] by abarth@webkit.org
  • 8 edits in trunk

2009-08-26 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480

  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings):

2009-08-26 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480

  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):

2009-08-26 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480

A bunch of our LayoutTests rely on our old behavior, so we explicitly
grant local files universal access during testing. Mainly, these tests
involve making XMLHttpRequests for data URLs.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
20:49 EFLWebKit edited by tonikitoo@gmail.com
(diff)
19:45 Changeset [47806] by alice.liu@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix: added some exported symbols

19:26 Changeset [47805] by hyatt@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28763, flickering when opacity changes.

Reviewed by Anders Carlsson.

Make opacity changes from < 1 to 1 and from 1 to < 1 cause a relayout to happen. We need
to do this in order for overflow information to be properly recomputed.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

19:07 Changeset [47804] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix: Removed some exported symbols that no longer exist.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-26

19:02 Changeset [47803] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by NOBODY (Build fix).

Fixup test after r47801: skip the first 'waiting' event because it is fired
when we call play() and there isn't enough media to begin playback immediately,
but we are interested in the 'waiting' event fired when the movie runs
out of loaded media.

  • http/tests/media/video-play-stall-seek.html:
18:16 Changeset [47802] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

x86-64 GTK broken due to code offsets changing, pointers sometimes packed into immediates.
https://bugs.webkit.org/show_bug.cgi?id=28317

Reviewed by Olliejver Hunt.

We rely on a slightly OS X specific behaviour, that x86-64 applications have a 4Gb zero page,
so pointers are never representable as a 32-bit integer, and always have to be represented by
a separate immediate load instruction, rather than within the immediate field of an arithmetic
or memory operation.

We explicitly check for a couple of cases where a value might be representable in 32-bit, but
these probably never kick in on Mac OS, and only kick in to hose GTK. Deleting these does not
show a performance degradation on SunSpider. Remove.

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::storePtr):
(JSC::MacroAssemblerX86_64::branchPtr):

17:47 Changeset [47801] by eric.carlson@apple.com
  • 7 edits
    2 adds in trunk

2009-08-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

HTMLMediaElement sometimes loses events
https://bugs.webkit.org/show_bug.cgi?id=28762
<rdar://problem/7172437>

A media element triggers the resource selection algorithm if 
play() is called when the networkState attribute is NETWORK_EMPTY, but
it also immediately queues 'play' and either 'waiting' or 'playing' events.
One of the steps in preparing to load is to flush pending events, so those 
events were lost if the load timer fired quickly enough. Fixed by deleting
pending events before scheduling the load timer.

Test: media/audio-play-event.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::scheduleLoad):

Do nothing if the load timer is already scheduled. Call prepareForLoad so queue of
pending events is flushed immediately.

(WebCore::HTMLMediaElement::scheduleNextSourceChild):

New, start the load timer without flushing pending events.

(WebCore::HTMLMediaElement::load):

Call prepareForLoad();

(WebCore::HTMLMediaElement::prepareForLoad):

New, load setup code moved from loadInternal.

(WebCore::HTMLMediaElement::loadInternal):

Moved some setup code to prepareForLoad so it can be invoked immediately before
arming the load timer.

(WebCore::HTMLMediaElement::setNetworkState):

Call scheduleNextSourceChild instead of scheduleLoad as the later now clears
pending events.

  • html/HTMLMediaElement.h:

Declare scheduleNextSourceChild.

2009-08-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

HTMLMediaElement sometimes loses events
https://bugs.webkit.org/show_bug.cgi?id=28762
<rdar://problem/7172437>

  • media/audio-play-event.html:
  • media/audio-play-event-expected.txt:

Added.

  • media/video-play-empty-events-expected.txt:

Updated results for previously missed events.

  • media/video-src-remove.html:
  • media/video-timeupdate-during-playback-expected.txt:

Restructured to make results less timing dependent.

17:35 QtWebKit edited by ironstorm@gmail.com
add OSX building instructions link (diff)
17:33 BuildingQtOnOSX edited by ironstorm@gmail.com
(diff)
17:32 BuildingQtOnOSX edited by ironstorm@gmail.com
(diff)
17:29 BuildingQtOnOSX edited by ironstorm@gmail.com
(diff)
16:40 BuildingOnWindows edited by dbates@webkit.org
Added notice about proper ordering of Cygwin\bin in the list of VC++ … (diff)
16:40 Changeset [47800] by pkasting@chromium.org
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28751
Switch ICO decoder from a Vector of raw pointers to a Vector of
OwnPtrs now that that is possible. Makes code slightly simpler.

Reviewed by Eric Seidel.

  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::processDirectory):

  • platform/image-decoders/ico/ICOImageDecoder.h:
16:00 Changeset [47799] by ggaren@apple.com
  • 12 edits in trunk/JavaScriptCore

A bit of Collector refatoring.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-26
Reviewed by Oliver Hunt.

SunSpider says no change. v8 says 1.003x faster (1.02x faster on splay).

  • runtime/JSCell.cpp:

(JSC::JSCell::toPrimitive):
(JSC::JSCell::getPrimitiveNumber):
(JSC::JSCell::toBoolean):
(JSC::JSCell::toNumber):
(JSC::JSCell::toString):
(JSC::JSCell::toObject): Removed pure virtual functions from
JSCell, so the collector can construct one. This allowed
me to remove a bunch of ASSERT_NOT_REACHED throughout the
code, too.

  • runtime/JSCell.h:

(JSC::JSCell::JSCell): ditto
(JSC::Heap::heap): Inlined this function because it's trivial.

  • runtime/Collector.cpp:

(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlocks): Renamed freeHeap to freeBlocks, since
it doesn't actually free the Heap object.
(JSC::Heap::heapAllocate):
(JSC::Heap::sweep):

  • runtime/Collector.h: Refactored block allocation and destruction

into helper functions.

  • runtime/GetterSetter.cpp:
  • runtime/JSAPIValueWrapper.cpp:
  • runtime/JSPropertyNameIterator.cpp: Removed dummy implementations

of pure virtual functions. (See above.)

15:30 Changeset [47798] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=28718, image inside relpositioned inline doesn't paint.
Make sure vertical overflow is still computed across self-painting layers, even though it isn't
propagated to parents.

Reviewed by Dan Bernstein.

Added fast/repaint/rel-positioned-inline-with-overflow.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeVerticalOverflow):

LayoutTests: Add layout test for relpositioned inline regression.

Reviewed by Dan Bernstein.

  • fast/repaint/rel-positioned-inline-with-overflow.html: Added.
  • platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.checksum: Added.
  • platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
  • platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.txt: Added.
14:57 Changeset [47797] by levin@chromium.org
  • 10 edits in trunk

WebCore: ResourceRequestBase::*[Aa]llowHTTPCookies shouldn't mention http.
https://bugs.webkit.org/show_bug.cgi?id=28735

Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Darin Fisher.

Renaming the method to imply its wider implications of affecting cookies
over any protocol that supports them.

No change in functionality so no new tests.

  • WebCore.order:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):
(WebCore::ResourceRequestBase::allowCookies):
(WebCore::ResourceRequestBase::setAllowCookies):
(WebCore::equalIgnoringHeaderFields):

  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateFromSoupMessage):

WebKit/win: ResourceRequestBase::*[Aa]llowHTTPCookies shouldn't mention http.
https://bugs.webkit.org/show_bug.cgi?id=28735

Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Darin Fisher.

  • WebMutableURLRequest.cpp:

(WebMutableURLRequest::setHTTPShouldHandleCookies):

14:54 Changeset [47796] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:
Made RenderInline::clippedOverflowRectForRepaint() actually include
overflow.

Reviewed by Dave Hyatt.

Test: fast/repaint/inline-overflow.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::linesVisibleOverflowBoundingBox): Added. Returns

the bounding box of all lines’ visible overflow boxes (under the
assumption that the first and last lines determine the top and
bottom, respectively).

(WebCore::RenderInline::clippedOverflowRectForRepaint): Changed to use

linesVisibleOverflowBoundingBox() instead of linesBoundingBox().

  • rendering/RenderInline.h:

LayoutTests:
Test that RenderInline::clippedOverflowRectForRepaint() actually
includes overflow.

Reviewed by Dave Hyatt.

  • fast/repaint/inline-overflow-expected.checksum: Added.
  • fast/repaint/inline-overflow-expected.png: Added.
  • fast/repaint/inline-overflow-expected.txt: Added.
  • fast/repaint/inline-overflow.html: Added.
14:33 Changeset [47795] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

End re-roll-in of r47738:47740 with Windows crash fixed

2009-08-26 Geoffrey Garen <ggaren@apple.com>

Build fix: start out with a 32-bit value to avoid a shortening warning.

  • runtime/Collector.cpp: (JSC::Heap::sweep):

2009-08-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Substantially reduced VM thrash in the GC heap.


1.08x faster on v8 (1.60x faster on v8-splay).


1.40x faster on bench-alloc-nonretained.


1.90x faster on bench-alloc-retained.


SunSpider says no change.


  • runtime/Collector.cpp: (JSC::Heap::heapAllocate): Fixed a long-standing bug: update a few local variables unconditionally after calling collect(), since they may be used even if we don't "goto scan". (In the bug I saw, usedBlocks got out of sync with heap.usedBlocks). (JSC::Heap::sweep): Keep enough free heap space to accomodate the number of objects we'll allocate before the next GC, plus 25%, for good measure.
  • runtime/Collector.h: Bumped the block size to 256k. This seems to give the best cache performance, and it prevents us from initiating lots of VM traffic to recover very small chunks of memory.

Begin re-roll-in of r47738:47740 with Windows crash fixed

14:26 Changeset [47794] by jparent@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Follow-up to http://trac.webkit.org/changeset/47790. Add windows
specific results that are the same as the results next to the test,
since windows falls back on platform/mac.

Patch by Julie Parent <jparent@chromium.org> on 2009-08-26
Reviewed by Maciej Stachowiak.

  • platform/win/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Added.
14:25 BuildingQtOnOSX created by ironstorm@gmail.com
Initial Page for OSX build instructions
13:47 Changeset [47793] by levin@chromium.org
  • 6 edits in trunk

WebCore: minor style correction and include fix for notifications
https://bugs.webkit.org/show_bug.cgi?id=28745

Patch by John Gregg <johnnyg@google.com> on 2009-08-26
Reviewed by David Levin.

No change in behavior, so no tests.

  • bindings/js/JSDesktopNotificationsCustom.cpp: add include of Error.h
  • notifications/Notification.cpp: change enum style to InterCaps

(WebCore::Notification::Notification):

  • notifications/NotificationPresenter.h:

(WebCore::NotificationPresenter::):

WebKitTools: Minor style correction and include fix for notifications
https://bugs.webkit.org/show_bug.cgi?id=28745

Patch by John Gregg <johnnyg@google.com> on 2009-08-26
Reviewed by David Levin.

  • DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: change to correct EnumStyle

(DRTDesktopNotificationPresenter::checkNotificationPermission):

13:45 Changeset [47792] by levin@chromium.org
  • 14 edits
    1 copy
    2 adds in trunk

WebKitTools: XMLHttpRequest.withCredentials=false shouldn't save cookies.
https://bugs.webkit.org/show_bug.cgi?id=28743

Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Alexey Proskuryakov.

Added the support to the layout test controller on OSX and
Windows (for CFNETWORK) to allow for changing the accept cookie
policy.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Added a bool
to track the state of accepting cookies.
(setAlwaysAcceptCookiesCallback): Standard wrapper method
to go from js to a C++ method.
(LayoutTestController::staticFunctions): Added the
setAlwaysAcceptCookies method to the js layoutTestController.

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::alwaysAcceptCookies): Returns the value.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setAlwaysAcceptCookies): Stub out method.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues): Reset the accept cookie to
its default.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setAlwaysAcceptCookies): Does the work for
OSX to change the cookie accept policy.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(setAlwaysAcceptCookies): Method to handle all the calls necessary
to change the accept cookie policy on Windows.
(resetDefaultsToConsistentValues): Reset the accept cookie to
its default.

  • DumpRenderTree/win/DumpRenderTreeWin.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setAlwaysAcceptCookies): Stub out method.

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setAlwaysAcceptCookies): Stub out method.

LayoutTests: XMLHttpRequest.withCredentials=false shouldn't save cookies.
https://bugs.webkit.org/show_bug.cgi?id=28743

Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Alexey Proskuryakov.

Added a test to verify that XMLHttpRequest.withCredentials=false doesn't
save cookies.

  • http/tests/xmlhttprequest/cross-origin-cookie-storage-expected.txt: Added.
  • http/tests/xmlhttprequest/cross-origin-cookie-storage.html: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php: Added the ability

to check for a cookie by name.

  • platform/gtk/Skipped: Skip the new test.
  • platform/qt/Skipped: Ditto.
13:45 Changeset [47791] by atwilson@chromium.org
  • 20 edits in trunk

JavaScriptCore: postMessage() spec now supports sending arrays of ports
https://bugs.webkit.org/show_bug.cgi?id=26902

Reviewed by David Levin.

Added OwnPtr to VectorTraits so we can store OwnPtrs in Vectors.

  • wtf/VectorTraits.h:

WebCore: postMessage() spec now supports sending arrays of ports
https://bugs.webkit.org/show_bug.cgi?id=26902

Reviewed by David Levin.

Added support for sending multiple ports at once via postMessage(). JS bindings will be updated in an upcoming patch.

No new tests, since the new functionality is not exposed via new JS bindings yet, so the old tests suffice.

  • WebCore.xcodeproj/project.pbxproj:

Mark MessagePort.h and MessagePortChannel.h as private since they are used by WebKit now.

  • dom/MessageEvent.cpp:

Updated APIs to support passing MessagePortArrays.
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
(WebCore::MessageEvent::messagePort):

  • dom/MessageEvent.h:

(WebCore::MessageEvent::create):
Now accepts a MessagePortArray parameter instead of a single MessagePort.
(WebCore::MessageEvent::ports):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::postMessage):
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):
Added new static function to extract a MessagePortChannelArray from a MessagePortArray.
(WebCore::MessagePort::entanglePorts):
Added new static function to generate a MessagePortArray (entangled ports) from a MessagePortChannelArray.

  • dom/MessagePort.h:
  • dom/MessagePortChannel.cpp:

EventData now contains a MessagePortChannelArray field instead of a single MessagePortChannel.
(WebCore::MessagePortChannel::EventData::create):
(WebCore::MessagePortChannel::EventData::EventData):

  • dom/MessagePortChannel.h:

(WebCore::MessagePortChannel::EventData::channels):

  • page/DOMWindow.cpp:

(WebCore::PostMessageTimer::PostMessageTimer):
(WebCore::PostMessageTimer::event):
(WebCore::DOMWindow::postMessage):
Now accepts a MessagePortArray parameter instead of a single MessagePort.

  • page/DOMWindow.h:
  • workers/DedicatedWorkerContext.cpp:

(WebCore::DedicatedWorkerContext::postMessage):
Now accepts a MessagePortArray parameter instead of a single MessagePort.
(WebCore::DedicatedWorkerContext::dispatchMessage):

  • workers/DedicatedWorkerContext.h:
  • workers/Worker.cpp:

(WebCore::Worker::postMessage):
Now accepts a MessagePortArray parameter instead of a single MessagePort.
(WebCore::Worker::dispatchMessage):

  • workers/Worker.h:
  • workers/WorkerContextProxy.h:
  • workers/WorkerMessagingProxy.cpp:

Updated WorkerObjectProxy and WorkerContextProxy API implementations to support sending multiple MessagePorts.
(WebCore::MessageWorkerContextTask::create):
(WebCore::MessageWorkerContextTask::MessageWorkerContextTask):
(WebCore::MessageWorkerContextTask::performTask):
(WebCore::MessageWorkerTask::create):
(WebCore::MessageWorkerTask::MessageWorkerTask):
(WebCore::MessageWorkerTask::performTask):
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerContext):

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerObjectProxy.h:

Updated WorkerObjectProxy and WorkerContextProxy APIs to support sending multiple MessagePorts.

13:26 Changeset [47790] by jparent@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

Add Mac specific results for xhr-missing-file-expection test since it
incorrectly always has statusText of "OK" due to
https://bugs.webkit.org/show_bug.cgi?id=24572 and update the results
that are next to the file to use "Not Found" since that is more correct
and matches IE, FF, Chrome.

Patch by Julie Parent <jparent@chromium.org> on 2009-08-26
Reviewed by Alex Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=28723

  • http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt:
  • platform/mac/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Added.
  • platform/win/Skipped: Stop skipping the test.
13:25 Changeset [47789] by dglazkov@chromium.org
  • 2 edits in trunk/WebKitTools

2009-08-26 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed.

Remove accidentally left in clobber option.
https://bugs.webkit.org/show_bug.cgi?id=28400

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
13:05 Changeset [47788] by eric@webkit.org
  • 3 edits
    11 adds in trunk/WebCore

2009-08-26 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

SocketStreamHandle interface for WebSocket API
https://bugs.webkit.org/show_bug.cgi?id=28037

Add build systems only for GNUmakefile.am and WebCore.xcodeproj.now.
Other build systems will be updated once the code is functional.
Tests will be landed once this code is complete and functional.

  • GNUmakefile.am:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/SocketStreamErrorBase.cpp: Added.
  • platform/network/SocketStreamErrorBase.h: Added.
  • platform/network/SocketStreamHandleBase.cpp: Added.
  • platform/network/SocketStreamHandleBase.h: Added.
  • platform/network/SocketStreamHandleClient.h: Added.
  • platform/network/cf/SocketStreamError.h: Added.
  • platform/network/cf/SocketStreamHandle.h: Added.
  • platform/network/cf/SocketStreamHandleCFNet.cpp: Added.
  • platform/network/soup/SocketStreamError.h: Added.
  • platform/network/soup/SocketStreamHandle.h: Added.
  • platform/network/soup/SocketStreamHandleSoup.cpp: Added.
13:04 Changeset [47787] by dglazkov@chromium.org
  • 3 edits in trunk/WebKitTools

2009-08-17 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Mark Rowe.

Add canary-style Chromium WebKit build slave to the waterfall.
https://bugs.webkit.org/show_bug.cgi?id=28400

  • BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
12:55 Changeset [47786] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-26 Mads Ager <ager@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] setTimeout does not convert non-string argument to string
https://bugs.webkit.org/show_bug.cgi?id=28739

Convert non-string argument to setTimeout to string in the V8
bindings.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):
11:48 Changeset [47785] by mrowe@apple.com
  • 3 edits in trunk/WebKitSite

Upgrade WordPress to the latest version.

  • blog/wp-includes/version.php:
  • blog/wp-login.php:
11:08 Changeset [47784] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-26 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Remove duplicated files from file list.

  • GNUmakefile.am:
10:40 Changeset [47783] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

More export fixes.

10:33 Changeset [47782] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Hopefully fix all the exports from JSC on windows

10:12 Changeset [47781] by oliver@apple.com
  • 6 edits in trunk/JavaScriptCore

Build fix

09:52 Changeset [47780] by oliver@apple.com
  • 69 edits
    1 copy
    4 adds in trunk

[ES5] Implement getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=28724

Reviewed by Gavin Barraclough.

JavaScriptCore:
Implement the core runtime support for getOwnPropertyDescriptor.
This adds a virtual getOwnPropertyDescriptor method to every class
that implements getOwnPropertySlot that shadows the behaviour of
getOwnPropertySlot. The alternative would be to make getOwnPropertySlot
(or PropertySlots in general) provide property attribute information,
but quick testing showed this to be a regression.

WebCore:
Implement the WebCore side of getOwnPropertyDescriptor. This
requires a custom implementation of getOwnPropertyDescriptor
for every class with a custom implementation of getOwnPropertySlot.

The bindings generator has been updated to generate appropriate
versions of getOwnPropertyDescriptor for the general case where
a custom getOwnPropertyDescriptor is not needed. ES5 is vague
about how getOwnPropertyDescriptor should work in the context of
"host" functions with polymorphic GetOwnProperty?, so it seems
okay that occasionally we "guess" what attributes -- eg. determining
whether a property is writable.

Test: fast/js/getOwnPropertyDescriptor.html

07:08 Changeset [47779] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-08-26 Vincent Untz <vuntz@gnome.org>

Reviewed by Xan Lopez.

GObject checks for NULL (and not 0) in g_object_get, so use that
as we were already doing elsewhere to make the compiler happy.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::hasAudio):
07:06 Changeset [47778] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-26 Alpha Lam <hclam@chromium.org>

Reviewed by David Levin.

RenderThemeMac.mm has incorrect casting for media control element.
https://bugs.webkit.org/show_bug.cgi?id=28730

MediaControlMuteButtonElement was incorrectly casted to
MediaControlPlayButtonElement. This is corrected in this patch.

No new tests because this is code cleanup and is already covered by existing
media layout tests.

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaMuteButton):
06:56 Changeset [47777] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-26 Robert Sesek <rsesek@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Multi-value select boxes cannot do non-contiguous selection on Mac
https://bugs.webkit.org/show_bug.cgi?id=28670

Change the condition regarding the key modifier check for non-contiguous
selection on a multi-value list from just PLATFORM(MAC) to

PLATFORM(MAC)
(PLATFORM(CHROMIUM) && PLATFORM(DARWIN)).

No new tests. This patch only changes the condition on which a certain mouse
event modifier key is used.

  • dom/SelectElement.cpp: (WebCore::SelectElement::listBoxDefaultEventHandler):
06:31 Changeset [47776] by xan@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-08-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=28738
Expose undo/redo functionality in WebKitWebView

Expose undo/redo functionality in WebKitWebView, keeping the
default bindings as they were.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::):
  • webkit/webkitwebview.cpp: (webkit_web_view_real_undo): (webkit_web_view_real_redo): (webkit_web_view_class_init): (webkit_web_view_can_undo): (webkit_web_view_undo): (webkit_web_view_can_redo): (webkit_web_view_redo):
  • webkit/webkitwebview.h:
00:46 Changeset [47775] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

How many copies of the parameters do you need?
https://bugs.webkit.org/show_bug.cgi?id=28701

Reviewed by Darin Adler.

The function parameters in JSC get copied a lot - and unnecessarily so.

Originally this happened due to duplicating FunctionBodyNodes on recompilation,
though the problem has been exacerbated by copying the parameters from the
original function body onto the executable, then back onto the real body that
will be generated (this happens on every function). And this is all made worse
since the data structures in question are a little ugly - C style arrays of C++
objects containing ref counts, so they need a full copy-construct (rather than
a simple memcpy).

This can all be greatly simplified by just punting the parameters off into
their own ref-counted object, and forgoing all the copying.

~no performance change, possible slight progression.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::makeFunction):

  • parser/Nodes.cpp:

(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::finishParsing):

  • parser/Nodes.h:

(JSC::FunctionBodyNode::parameters):
(JSC::FunctionBodyNode::parameterCount):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::FunctionExecutable::compile):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::fromGlobalCode):
(JSC::FunctionExecutable::paramString):

  • runtime/Executable.h:

(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::parameterCount):

08/25/09:

22:49 Changeset [47774] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2009-08-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein

r47744 causes media/video-controls-with-mutation-event-handler.html to crash
https://bugs.webkit.org/show_bug.cgi?id=28732

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement):

Don't call setAttribute from the construtor, any registered mutation event
listener will cause a crash.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider):

Set the maxAttr here instead of in the constructor.

22:46 Changeset [47773] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Skip the new test fast/dom/Window/timer-resume-on-navigation-back.html
on gtk and qt - their DRT does not yet implement overridePreference.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
22:17 Changeset [47772] by dimich@chromium.org
  • 5 edits
    2 adds in trunk

WebCore: Timers from cached pages fire instantly rather than the after the specified timeout delay
https://bugs.webkit.org/show_bug.cgi?id=28683

Reviewed by Brady Eidson.

Test: fast/dom/Window/timer-resume-on-navigation-back.html

  • history/CachedPage.cpp:

(WebCore::CachedPage::restore): Remove duplicated Frame::restore() call, since

it should be done only once in FrameLoader::open(cachedFrame)

  • page/DOMTimer.cpp: Added a debug-only flag and ASSERT to catch out-of-order suspense/restore.

(WebCore::DOMTimer::DOMTimer): Ditto.
(WebCore::DOMTimer::suspend): Ditto.
(WebCore::DOMTimer::resume): Ditto.

  • page/DOMTimer.h: Ditto.

LayoutTests: Timers from cached pages fire instantly rather than the specified timeout delay
https://bugs.webkit.org/show_bug.cgi?id=28683

Reviewed by Brady Eidson.

Added test to verify the fix - it uses page cache and measures the timer callback fire time.

  • fast/dom/Window/timer-resume-on-navigation-back-expected.txt: Added.
  • fast/dom/Window/timer-resume-on-navigation-back.html: Added.
22:10 Changeset [47771] by eric.carlson@apple.com
  • 2 edits
    1 add in trunk/WebCore

2009-08-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Setting the volume of a media element has no effect if called too early
https://bugs.webkit.org/show_bug.cgi?id=28731

  • manual-tests/audio-volume.html:

Added.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setRate):

Don't bail if metadata hasn't been loaded, it is fine to set rate and/or
volume as soon as the movie has been created.

20:02 Changeset [47770] by levin@chromium.org
  • 2 edits in trunk/WebCore

DocumentThreadableLoader::getShouldUseCredentialStorage should allow for synchronous callbacks from SubresourceLoader::create.
https://bugs.webkit.org/show_bug.cgi?id=28728

Patch by David Levin <levin@chromium.org> on 2009-08-25
Reviewed by Maciej Stachowiak.

Test: This code path is exercised while running xhr layout tests in chromium.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::getShouldUseCredentialStorage): When called
back synchronously, the loader is 0, so the assert is changed to allow for that.
(WebCore::DocumentThreadableLoader::loadRequest): Synchronous callbacks may be
done before SubresourceLoader::create finishes, so ensure that any previous loader
-- from a preflight request -- is cleared before calling SubresourceLoader::create.

18:06 Changeset [47769] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

Rubber stamped by Steve Falkenburg.

debug_wincairo.vsprops was linking against wrong C runtime.

  • win/tools/vsprops/debug_wincairo.vsprops: Link to correct C runtime (as in the standard 'debug.vsprops' file.)
17:57 Changeset [47768] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Stop installing IDL files in to the framework.

  • WebCore.xcodeproj/project.pbxproj:
17:51 Changeset [47767] by eric@webkit.org
  • 6 edits
    4 adds in trunk

2009-08-25 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Support for HTMLInputElement::list and HTMLInputElement::selectedOption.
https://bugs.webkit.org/show_bug.cgi?id=27756

Tests: fast/forms/input-list.html

fast/forms/input-selectedoption.html

  • html/HTMLAttributeNames.in:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::list): (WebCore::HTMLInputElement::selectedOption):
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:

2009-08-25 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Support for HTMLInputElement::list and HTMLInputElement::selectedOption.
https://bugs.webkit.org/show_bug.cgi?id=27756

  • fast/forms/input-list-expected.txt: Added.
  • fast/forms/input-list.html: Added.
  • fast/forms/input-selectedoption-expected.txt: Added.
  • fast/forms/input-selectedoption.html: Added.
17:42 Changeset [47766] by darin@apple.com
  • 11 edits
    1 add in branches/one-view

WebCore: Some work on one-view WebKit.

Patch by Darin Adler <darin@apple.com> on 2009-08-25
Reviewed by David Hyatt.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMousePressEventToSubframe): Send the event to the
frame -- don't involve the NSView objects.
(WebCore::EventHandler::passMouseMoveEventToSubframe): Ditto.
(WebCore::EventHandler::passMouseReleaseEventToSubframe): Ditto.

WebKit: Some work on one-view WebKit.

Patch by Darin Adler <darin@apple.com> on 2009-08-25
Reviewed by David Hyatt.

  • WebKit.xcodeproj/project.pbxproj: Added WebView/WebViewEventHandling.mm.

WebKit/mac: Some work on one-view WebKit.

Patch by Darin Adler <darin@apple.com> on 2009-08-25
Reviewed by David Hyatt.

  • WebCoreSupport/WebDragClient.mm:

(WebDragClient::startDrag): Change code to use WebView instead of
WebHTMLView.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView rightMouseUp:]): ASSERT_NOT_REACHED.
(-[WebHTMLView menuForEvent:]): Ditto.
(-[WebHTMLView mouseDown:]): Ditto.
(-[WebHTMLView mouseDragged:]): Ditto.
(-[WebHTMLView mouseUp:]): Ditto.
(-[WebHTMLView otherMouseDown:]): Ditto.
(-[WebHTMLView otherMouseDragged:]): Ditto.
(-[WebHTMLView otherMouseUp:]): Ditto.
(-[WebHTMLView _mouseDownEvent]): Ditto.

  • WebView/WebView.mm:

(-[WebView _close]): Call _closingEventHandling.
(-[WebView viewWillMoveToWindow:]): Added calls to
_removeMouseMovedObserverUnconditionally and _addMouseMovedObserver.
(-[WebView _windowDidBecomeKey:]): Added non-main-thread handling,
and _addMouseMovedObserver
(-[WebView _windowDidResignKey:]): Added non-main-thread handling,
completion controller code, and _removeMouseMovedObserver.
(-[WebView _windowWillOrderOnScreen:]): Added non-main-thread handling.
(-[WebView _windowWillClose:]): Ditto.

  • WebView/WebViewData.h: Added toolTip, lastToolTipTag, trackingRectOwner,

trakcingRectUserData, observingMouseMovedNotifications, and exposeInputContext.

  • WebView/WebViewData.mm:

(-[WebViewPrivate dealloc]): Release a few more things. Sorted the list
of things to release with the sort tool.

  • WebView/WebViewEventHandling.mm: Added. Moved a lot of code in here.
  • WebView/WebViewInternal.h: Moved items to the WebViewEventHandling

category.

17:33 Changeset [47765] by darin@apple.com
  • 1 copy in branches/one-view

Create a branch for some one-view WebKit work.

16:24 Changeset [47764] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-08-25 Cameron McCormack <cam@mcc.id.au>

Reviewed by Darin Adler.

make-script-test-wrappers should be executable
https://bugs.webkit.org/show_bug.cgi?id=28669

Make make-script-test-wrappers and update-sources-list.py both be
executable.

  • Scripts/update-sources-list.py:
  • Scripts/make-script-test-wrappers:
16:07 Changeset [47763] by eric.carlson@apple.com
  • 44 edits
    12 adds in trunk

2009-08-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible (edit)
https://bugs.webkit.org/show_bug.cgi?id=28081

Test: accessibility/media-element.html

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

Add AccessibilityMediaControls.cpp/.h

  • accessibility/AXObjectCache.cpp:
  • accessibility/AXObjectCache.h: (WebCore::AXObjectCache::getOrCreate):

Create AccessibilityMediaControl. Update Copyright

  • accessibility/AccessibilityMediaControls.cpp:
  • accessibility/AccessibilityMediaControls.h:

Added.

  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityObject.h:

Add isMediaTimeline. Update Copyright.

  • accessibility/AccessibilitySlider.h:

Make constructor protected instead of private so AccessibilityMediaTimeline can
call it.

  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeNames]):

Add NSAccessibilityValueDescriptionAttribute to range attributes.

(-[AccessibilityObjectWrapper subrole]):

Return NSAccessibilityTimelineSubrole for AccessibilityMediaTimeline.

  • dom/Node.h:

add isMediaControlElement.

  • page/mac/WebCoreViewFactory.h:
  • platform/LocalizedStrings.h:
  • platform/mac/LocalizedStringsMac.mm: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):

New, return localized media controller strings.

  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText):

Move inside of "#if ENABLE(VIDEO)"

(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
(WebCore::localizedMediaTimeDescription):

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::MediaControlElement):

Initialize m_displayType.

(WebCore::MediaControlElement::MediaControlElement):
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):

Fix style.

(WebCore::MediaControlInputElement::MediaControlInputElement):

Set m_displayType based on pseudo style ID.

(WebCore::MediaControlInputElement::MediaControlInputElement):

rename local "o" to "object".

(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):

Update for MediaControlInputElement constructor change.

(WebCore::MediaControlTimeDisplayElement::formatTime):

New, moved here from RenderMedia so AccessibilityMediaTimeDisplay can use it.

(WebCore::MediaControlTimeDisplayElement::setCurrentValue):

New, set text to current time.

  • rendering/MediaControlElements.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):

Create controls in tab order.

(WebCore::RenderMedia::formatTime):

Moved to MediaControlTimeDisplayElement::formatTime.

(WebCore::RenderMedia::updateTimeDisplay):

Call MediaControlTimeDisplayElement::setCurrentValue.

  • rendering/RenderMedia.h:

2009-08-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

Add localized strings for media controller accessiblility.

  • English.lproj/Localizable.strings:

2009-08-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory localizedMediaControlElementString:]): (-[WebViewFactory localizedMediaControlElementHelpText:]): (-[WebViewFactory localizedMediaTimeDescription:]):

New.

2009-08-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

  • WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):

New.

2009-08-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

  • accessibility/media-element.html: Added.
  • platform/mac/accessibility/media-element-expected.txt: Added.
  • media/video-controls-visible-audio-only.html:
  • platform/mac-leopard/accessibility/media-element-expected.txt: Added.
  • platform/mac-leopard/media/controls-drag-timebar-expected.txt: Added.
  • platform/mac-leopard/media/controls-strict-expected.txt: Added.
  • platform/mac-leopard/media/video-controls-rendering-expected.txt: Added.
  • platform/mac-leopard/media/video-display-toggle-expected.txt: Added.
  • platform/win/media/controls-strict-expected.txt: Added.
  • platform/win/media/video-controls-rendering-expected.txt: Added.
  • platform/win/media/video-display-toggle-expected.txt: Added.

Added.

  • platform/mac-leopard/media/audio-controls-rendering-expected.txt:
  • platform/mac-leopard/media/controls-after-reload-expected.txt:
  • platform/mac-leopard/media/controls-styling-expected.txt:
  • platform/mac-leopard/media/video-zoom-controls-expected.txt:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-styling-expected.txt:
  • platform/mac/media/video-zoom-controls-expected.txt:
  • platform/win/media/audio-controls-rendering-expected.txt:
  • platform/win/media/controls-after-reload-expected.txt:
  • platform/win/media/controls-drag-timebar-expected.txt:
  • platform/win/media/controls-styling-expected.txt:

Update for controller element tab order change.

  • platform/gtk/Skipped:
  • platform/win/Skipped:

Skip new test.

16:03 Changeset [47762] by bfulgham@webkit.org
  • 6 edits in trunk

WebKit/win: Build fix for Windows.

Revise Debug_Cairo build target to build testapi, jsc, WinLauncher,
DumpRenderTree, and TestNetscapeAPI using WinCairo debug build
settings so they link against the proper libraries.

  • WebKit.vcproj/WebKit.sln:

WebKitTools: Build fix

Revise Debug_Cairo targets to point inherit from the
debug_wincairo.vsprops property sheet so that they link
against the proper libraries in Debug build.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
  • WinLauncher/WinLauncher.vcproj:
15:59 Changeset [47761] by mrowe@apple.com
  • 1 edit in trunk/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Versioning.

15:54 Changeset [47760] by bfulgham@webkit.org
  • 3 edits in trunk/JavaScriptCore
  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Add Debug_CFLite target that inherits from the debug_wincairo property sheet and therefore links to the proper debug library.
  • JavaScriptCore.vcproj/testapi/testapi.vcproj: Add Debug_CFLite target that inherits from the debug_wincairo property sheet and therefore links to the proper debug library.

Reviewed by NOBODY (Buildfix).

15:43 Changeset [47759] by sfalken@apple.com
  • 3 edits in trunk/JavaScriptCore

Rolled out r44739. Causes crash on Windows.

15:38 Changeset [47758] by jianli@chromium.org
  • 3 edits in trunk/WebCore

[V8] Fix Canvas layout test failures in Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=28720

Reviewed by David Levin.

The previous fix r47757 does not handle the V8 object conversion correctly.

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

14:04 Changeset [47757] by jianli@chromium.org
  • 7 edits in trunk/WebCore

[V8] Fix compiling errors in Chromium build caused by Canvas3D changes from r47752.
https://bugs.webkit.org/show_bug.cgi?id=28717

Reviewed by David Levin.

  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

13:40 Changeset [47756] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-08-25 Alpha Lam <hclam@chromium.org>

Reviewed by David Levin.

[chromium] Implement media volume slider for chromium
https://bugs.webkit.org/show_bug.cgi?id=28715

Provided the implementation of the volume slider and its container for
chromium port. With this change there will be a usable volume control
slider for chromium theme.

No new tests since this is covered by existing media layout tests.

  • css/mediaControlsChromium.css: CSS style for the volume slider.
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::mediaSliderThumbImage): Returns the image for slider thumb. (WebCore::mediaVolumeSliderThumbImage): Returns the image for volume slider thumb. (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderTrack): Paints the track with one vertical white line. (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize): Adjusts thumb sizes according to the images. (WebCore::RenderThemeChromiumSkia::paintMediaSliderThumb): Paints slider thumb image. (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderThumb): Paints volume slider thumb image.
12:56 Changeset [47755] by cmarrin@apple.com
  • 1 edit in trunk/WebCore/html/HTMLCanvasElement.cpp

Fixed a build problem on Tiger

12:45 Changeset [47754] by cmarrin@apple.com
  • 1 edit
    2 adds in trunk/WebCore

Missed checking in 2 Canvas3D files
https://bugs.webkit.org/show_bug.cgi?id=28018

12:31 Changeset [47753] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2009-08-25 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

[V8] Exception from JavaScript propagates to main script
https://bugs.webkit.org/show_bug.cgi?id=26433

Test that both compile time and runtime exceptions thrown in
javascript URLs are isolated from the main script.

  • fast/dom/javascript-url-exception-isolation-expected.txt: Added.
  • fast/dom/javascript-url-exception-isolation.html: Added.
  • fast/dom/resources/javascript-url-exception-isolation.js: Added.

2009-08-25 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

[V8] Exception from JavaScript propagates to main script
https://bugs.webkit.org/show_bug.cgi?id=26433

Make sure that exceptions thrown both at compile time and at
runtime in javascript URLs are isolated from the main script.

Test: fast/dom/javascript-url-exception-isolation.html

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate):
11:45 Changeset [47752] by cmarrin@apple.com
  • 27 edits in trunk

Added all new Canvas3D files to the build
https://bugs.webkit.org/show_bug.cgi?id=28018

This also hooks up CanvasRenderingContext as the common base class for
CanvasRenderingContext2D and CanvasRenderingContext3D. And it adds a bit
of logic throughout to support the new CanvasRenderingContext3D object.
But nothing is hooked up yet.

11:30 Changeset [47751] by levin@chromium.org
  • 6 edits in trunk

PLATFORM(CFNETWORK) should be USE(CFNETWORK).
https://bugs.webkit.org/show_bug.cgi?id=28713

Patch by David Levin <levin@chromium.org> on 2009-08-25
Reviewed by Adam Roben.

JavaScriptCore:

  • wtf/Platform.h: Added a #define to catch this issue in the

future. The define would generate an error on gcc without the
space in the expansion, but Visual C++ needs the space to cause an error.

WebKit/win:

Also, moved the #if header section after the other #includes.

  • WebError.cpp:

(WebError::localizedDescription):

WebKitTools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(main):

10:14 Changeset [47750] by bfulgham@webkit.org
  • 6 edits
    1 add in trunk

JavaScriptCore: Revise CFLite Debug build to emit DLL's with _debug label.
https://bugs.webkit.org/show_bug.cgi?id=28695.

Reviewed by Steve Falkenburg.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Modify Cairo debug build to inherit from new debug_cairo property sheet.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCFLite.vsprops: Modify to look for debug CFLite when in debug build.

WebKit/win: Revise CFLite Debug build to emit DLL's with _debug label.
https://bugs.webkit.org/show_bug.cgi?id=28695.

Reviewed by Steve Falkenburg.

  • WebKit.vcproj/WebKit.vcproj: Modify Debug_Cairo target to inherit from new debug_wincairo property sheet, instead of the current debug sheet.

WebKitLibraries: Revise CFLite Debug build to emit DLL's with _debug label.
https://bugs.webkit.org/show_bug.cgi?id=28695.

Reviewed by Steve Falkenburg.

  • win/tools/vsprops/debug_wincairo.vsprops: Added.
10:09 Changeset [47749] by mitz@apple.com
  • 4 edits in trunk/WebCore

REGRESSION (r47630): fast/repaint/background-generated.html is failing
https://bugs.webkit.org/show_bug.cgi?id=28704

Reviewed by Anders Carlsson.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize): Handle SizeNone.

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::FillLayer): Initialize the size type to SizeNone.

  • rendering/style/FillLayer.h:

(WebCore::FillSize::FillSize): Changed assignment to initialization and

removed redundant assignment to size.

09:28 Changeset [47748] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-25 Yusuke Sato <yusukes@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Complex text doesn't show up with text stroking
https://bugs.webkit.org/show_bug.cgi?id=28707

Skip the NULL check of m_hdc if Windows GDI is not in use.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawComplexText):
06:14 Changeset [47747] by kenneth@webkit.org
  • 8 edits in trunk/LayoutTests

[Qt] Update outdated metrics in css1/font_properties. All tests pass.

Patch by Renata Hodovan <hodovan.renata@stud.u-szeged.hu> on 2009-08-25
Reviewed by Ariya Hidayat.

  • platform/qt/Skipped:
  • platform/qt/css1/font_properties/font-expected.txt:
  • platform/qt/css1/font_properties/font_family-expected.txt:
  • platform/qt/css1/font_properties/font_size-expected.txt:
  • platform/qt/css1/font_properties/font_style-expected.txt:
  • platform/qt/css1/font_properties/font_variant-expected.txt:
  • platform/qt/css1/font_properties/font_weight-expected.txt:
06:12 Changeset [47746] by kenneth@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-08-25 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Ariya Hidayat.

Bug 28708 - Make possible to better use ResourceError in FrameLoaderClientQt class.

  • Api/qwebframe.cpp: (QWebFrame::requestedUrl):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): (WebCore::FrameLoaderClientQt::postProgressFinishedNotification): (WebCore::FrameLoaderClientQt::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoad):
  • WebCoreSupport/FrameLoaderClientQt.h:
06:08 Changeset [47745] by kenneth@webkit.org
  • 8 edits
    12 adds in trunk/LayoutTests

[Qt] Update outdated font metrics and add expected files for new tests.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-08-25
Reviewed by Ariya Hidayat.

  • platform/qt/Skipped:
  • platform/qt/fast/backgrounds/001-expected.txt:
  • platform/qt/fast/backgrounds/animated-gif-as-background-expected.txt: Added.
  • platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt: Added.
  • platform/qt/fast/backgrounds/animated-svg-as-mask-expected.txt: Added.
  • platform/qt/fast/backgrounds/background-clip-text-expected.txt: Added.
  • platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
  • platform/qt/fast/backgrounds/background-origin-root-element-expected.txt: Added.
  • platform/qt/fast/backgrounds/background-position-1-expected.txt: Added.
  • platform/qt/fast/backgrounds/background-position-rounding-expected.txt: Added.
  • platform/qt/fast/backgrounds/mask-composite-expected.txt: Added.
  • platform/qt/fast/backgrounds/opacity-on-document-element-expected.txt: Added.
  • platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt: Added.
  • platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
  • platform/qt/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/qt/fast/backgrounds/size/zero-expected.txt: Added.
  • platform/qt/fast/backgrounds/solid-color-context-restore-expected.txt:
  • platform/qt/fast/backgrounds/svg-as-mask-expected.txt: Added.
05:04 Changeset [47744] by eric@webkit.org
  • 18 edits in trunk/WebCore

2009-08-25 Alpha Lam <hclam@chromium.org>

Reviewed by David Levin.

Media controls panel does not have a volume control slider
https://bugs.webkit.org/show_bug.cgi?id=28241

Introduced "-webkit-media-controls-volume-slider",
"-webkit-media-controls-volume-slider-container" and the supporting
implementation. Also added appearances of "media-volume-slider" and
"media-volume-slider-container".

The implementation of the controls are in WebCore::MediaControlElements.
Logic to trigger the display of the volume controls are in WebCore::RenderMedia.

No new tests since this change doesn't have theme implementation and the
volume slider is disabled by default.

  • accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation): Marks that volume slider is vertical.
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added corresponding CSS values.
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): ditto.
  • css/CSSSelector.h: (WebCore::CSSSelector::): ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto.
  • css/CSSValueKeywords.in: ditto.
  • css/mediaControls.css: Makes the volume slider disabled by default.
  • platform/ThemeTypes.h: Defines theme parts for volume slider and its container. (WebCore::):
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement): (WebCore::MediaControlVolumeSliderContainerElement::styleForElement): Adjust the CSS values for "display", "postion", "left" and "top" according to member variables. (WebCore::MediaControlVolumeSliderContainerElement::setVisible): Affects the "display" CSS value. (WebCore::MediaControlVolumeSliderContainerElement::setPosition): Affects the "left" and "top" CSS values. (WebCore::MediaControlVolumeSliderContainerElement::hitTest): Hit testing this element. (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): (WebCore::MediaControlVolumeSliderElement::defaultEventHandler): Modifies the volume using the slider value, allows dragging.
  • rendering/MediaControlElements.h: (WebCore::): Added definition for MediaControlVolumeSliderElement and MediaControlVolumeSliderContainerElement. (WebCore::MediaControlVolumeSliderContainerElement::isVisible): Inline getter.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange): Updates styles for volume container and volume slider. (WebCore::RenderMedia::createVolumeSliderContainer): Creates volume slider container and attach to panel. (WebCore::RenderMedia::createVolumeSlider): Creates volume slider and attach to volume slider container. (WebCore::RenderMedia::updateControls): Updates volume container and volume slider. (WebCore::RenderMedia::updateVolumeSliderContainer): Sets the visibility and position of volume slider container and its child. (WebCore::RenderMedia::forwardEvent): Hit testing the volume slider container and volume slider to toggle the visibility and forward events to slider.
  • rendering/RenderMedia.h: Added definition for RenderMedia::updateVolumeSliderContainer().
  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart): Not implemented.
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Makes volume slider vertical. (WebCore::RenderSlider::thumbRect): ditto. (WebCore::RenderSlider::mouseEventIsInThumb): ditto. (WebCore::RenderSlider::setValueForPosition): ditto. (WebCore::RenderSlider::positionForOffset): ditto. (WebCore::RenderSlider::currentPosition): ditto. (WebCore::RenderSlider::trackSize): ditto.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): Adjust style for volume slider thumb. (WebCore::RenderTheme::paint): Paints volume control parts using theme.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::paintMediaVolumeSliderContainer): Naive implementation to be overridden. (WebCore::RenderTheme::paintMediaVolumeSliderTrack): ditto. (WebCore::RenderTheme::paintMediaVolumeSliderThumb): ditto.
  • rendering/style/RenderStyleConstants.h: (WebCore::): Constants for volume control parts.
04:36 Changeset [47743] by vestbo@webkit.org
  • 5 edits in trunk

[Qt/Mac] Use CONFIG+=build_all only when building libraries

Reviewed by Ariya Hidayat.

If no configuration is specified when building WebKit we pass the
debug_and_release option to QMake which results in Makefiles for
both configurations being generated.

Previously we built both of these configurations by default, for
all targets (both the QtWebKit framework/dyldlib and the various
executables such as QtLauncher and tests). This makes sense for
the libraries, which get the _debug suffix and can be loaded on
demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
ended up building the same executable twice.

We now only build one instance of each executable, and since this
is a developer build we build the debug-version. Passing either
--debug or --release to build-webkit will override this, and
even in the default case the release version can still be built
by running 'make release' in the the build directory of each
target.

  • WebCore.pro:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • Scripts/webkitdirs.pm:
00:18 Changeset [47742] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-08-25 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=28690
Build failure in webkitgtk+-1.1.3

Do not use deprecated function to unref a pixbuf.

  • platform/gtk/CursorGtk.cpp: (WebCore::Cursor::Cursor):

08/24/09:

23:53 Changeset [47741] by abarth@webkit.org
  • 8 edits
    2 adds in trunk

2009-08-24 Hironori Bono <hbono@chromium.org>

Reviewed by Adam Barth.

Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
<https://bugs.webkit.org/show_bug.cgi?id=27827>.

Because of the lack of mappings from GDK key-codes to WebKit key-codes,
Chromium cannot send valid key-codes to JavaScript when a user types
function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.

To write layout tests for this issue, added mappings from function-key
names to platform-specific key-codes to EventSendingController objects
so that eventSender.keyDown() can send function-key events without using
platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
is only for Mac. So this change adds this new test to Skipped tests for other
platforms to prevent this change from crashing the build trees.)

  • fast/events/keydown-function-keys-expected.txt: Added.
  • fast/events/keydown-function-keys.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2009-08-24 Hironori Bono <hbono@chromium.org>

Reviewed by Adam Barth.

Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
<https://bugs.webkit.org/show_bug.cgi?id=27827>.

Because of the lack of mappings from GDK key-codes to WebKit key-codes,
Chromium cannot send valid key-codes to JavaScript when a user types
function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.

To write layout tests for this issue, added mappings from function-key
names to platform-specific key-codes to EventSendingController objects
so that eventSender.keyDown() can send function-key events without using
platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
is only for Mac. So this change adds this new test to Skipped tests for other
platforms to prevent this change from crashing the build trees.)

Test: fast/events/keydown-function-keys.html

  • platform/chromium/KeyCodeConversionGtk.cpp: Add mappings from GDK key-codes to WebKit key-code for function keys. (WebCore::windowsKeyCodeForKeyEvent):

2009-08-24 Hironori Bono <hbono@chromium.org>

Reviewed by Adam Barth.

Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
<https://bugs.webkit.org/show_bug.cgi?id=27827>.

Because of the lack of mappings from GDK key-codes to WebKit key-codes,
Chromium cannot send valid key-codes to JavaScript when a user types
function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.

To write layout tests for this issue, added mappings from function-key
names to platform-specific key-codes to EventSendingController objects
so that eventSender.keyDown() can send function-key events without using
platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
is only for Mac. So this change adds this new test to Skipped tests for other
platforms to prevent this change from crashing the build trees.)

  • DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:]):
21:23 Changeset [47740] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix: start out with a 32-bit value to avoid a shortening warning.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-24

  • runtime/Collector.cpp:

(JSC::Heap::sweep):

21:09 Changeset [47739] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Substantially reduced VM thrash in the GC heap.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-24
Reviewed by Oliver Hunt.

1.08x faster on v8 (1.60x faster on v8-splay).

1.40x faster on bench-alloc-nonretained.

1.90x faster on bench-alloc-retained.

SunSpider says no change.

  • runtime/Collector.cpp:

(JSC::Heap::heapAllocate): Fixed a long-standing bug: update a few local
variables unconditionally after calling collect(), since they may be used
even if we don't "goto scan". (In the bug I saw, usedBlocks got out of
sync with heap.usedBlocks).
(JSC::Heap::sweep): Keep enough free heap space to accomodate
the number of objects we'll allocate before the next GC, plus 25%, for
good measure.

  • runtime/Collector.h: Bumped the block size to 256k. This seems to give

the best cache performance, and it prevents us from initiating lots of
VM traffic to recover very small chunks of memory.

19:53 Changeset [47738] by barraclough@apple.com
  • 19 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=28691
Do not retain ScopeNodes outside of parsing

Reviewed by Oliver Adler & Darin Hunt.

There is now no need for these to exist outside of parsing - their use in the runtime is replaced by Executable types.

  • bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::get):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::makeFunction):

  • debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions):
(JSC::evaluateInGlobalCallFrame):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluate):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • parser/Nodes.cpp:

(JSC::ScopeNodeData::ScopeNodeData):
(JSC::ProgramNode::create):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::create):

  • parser/Nodes.h:

(JSC::ScopeNode::adoptData):
(JSC::FunctionBodyNode::parameterCount):

  • parser/Parser.cpp:
  • parser/Parser.h:

(JSC::Parser::arena):
(JSC::Parser::Parser):
(JSC::Parser::parse):

  • runtime/ArrayPrototype.cpp:

(JSC::isNumericCompareFunction):
(JSC::arrayProtoFuncSort):

  • runtime/Completion.cpp:

(JSC::checkSyntax):
(JSC::evaluate):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::EvalExecutable::compile):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compile):
(JSC::FunctionExecutable::compile):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCode):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):
(JSC::FunctionExecutable::fromGlobalCode):
(JSC::FunctionExecutable::copyParameters):
(JSC::FunctionExecutable::paramString):

  • runtime/Executable.h:

(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::sourceID):
(JSC::ScriptExecutable::sourceURL):
(JSC::ScriptExecutable::lineNo):
(JSC::ScriptExecutable::lastLine):
(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::needsActivation):
(JSC::ScriptExecutable::recordParse):
(JSC::EvalExecutable::bytecode):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::bytecode):
(JSC::ProgramExecutable::reparseExceptionInfo):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::make):
(JSC::FunctionExecutable::bytecode):
(JSC::FunctionExecutable::isGenerated):
(JSC::FunctionExecutable::name):
(JSC::FunctionExecutable::parameterCount):
(JSC::FunctionExecutable::jitCode):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::numericCompareFunction):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

17:50 Changeset [47737] by antti@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28698
Avoid unnecessary transformations for the window resizer rect.

Reviewed by Simon Fraser.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::setFrameRect):

17:42 Changeset [47736] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

<rdar://problem/7161900> REGRESSION: 100 MB membuster leak on windows due to 47391
(DNS prefetching support)

  • platform/network/cf/DNSCFNet.cpp: (WebCore::prefetchDNS): Use a run loop from secondary thread on Windows, because there isn't one on main one.
17:09 Changeset [47735] by ap@apple.com
  • 3 edits
    3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=28374
Cross-scheme requests should not be blocked by appcache rules

Test: http/tests/appcache/different-scheme.html

  • loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache): Resources with different schemes can never be loaded from appcache.
17:03 Changeset [47734] by ap@apple.com
  • 6 edits
    2 adds in trunk

Reviewed by Darin Adler and Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=28688
REGRESSION(r24994): Cannot create a frame with a javascript URL

Test: http/tests/security/javascriptURL/javascriptURL-in-new-iframe.html

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue):
  • bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL):
  • bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL):
  • bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc): Omit the checks if there is no document in frame yet.
15:58 Changeset [47733] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Skip the correct test (media/video-currentTime-set.html, not
media/video-currentTime-set2.html).

  • platform/gtk/Skipped:
15:47 Changeset [47732] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Skip 3 new tests, and reenable some of the media tests, now that
the bot it fixed to handle the fact that it doesn't have a sound
card.

  • platform/gtk/Skipped:
14:56 Changeset [47731] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Skip again tests that we enabled, since they are
failing on the bot. The tests do pass, but there is an environment
configuration problem with GStreamer on the bot (possibly related
to the fact that it has no sound card).

  • platform/gtk/Skipped:
14:37 Changeset [47730] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore
  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::put): Landed revised version I had tested but forgot
to land. Leave out the branch, since we don't need one.

14:21 Changeset [47729] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2009-08-24 Nate Chapin <japhet@chromium.org>

Reviewed by Eric Seidel.

Fix crash in fast/css/rem-dynamic-scaling.html due to a freed
RenderStyle being accessed.

https://bugs.webkit.org/show_bug.cgi?id=28681

  • dom/Element.cpp: (WebCore::Element::recalcStyle): Make currentStyle a RefPtr.
14:08 Changeset [47728] by adachan@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Mark Rowe.


Skip loader/go-back-to-different-window-size.html for qt and gtk.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
14:05 Changeset [47727] by darin@apple.com
  • 3 edits in trunk/JavaScriptCore

Array index miss case creates a string every time
https://bugs.webkit.org/show_bug.cgi?id=28664

Patch by Darin Adler <darin@apple.com> on 2009-08-24
Reviewed by Geoff Garen.

SunSpider test results I saw:

0.5% faster overall
1% faster on crypto-aes
20% faster on crypto-md5
13% faster on crypto-sha1

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype): Initialize m_hasNoPropertiesWithUInt32Names
to true.
(JSC::ObjectPrototype::put): Clearly m_hasNoPropertiesWithUInt32Names if the new
property has a name that is the string form of a UInt32.
(JSC::ObjectPrototype::getOwnPropertySlot): Don't call JSObject::getOwnPropertySlot
if m_hasNoPropertiesWithUInt32Names is true, and it is highly likely to be true.

  • runtime/ObjectPrototype.h: Added declarations for the above.
13:45 Changeset [47726] by mitz@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/5743105> Long freezing during loading and selecting text
of a large table
https://bugs.webkit.org/show_bug.cgi?id=14918

Reviewed by Simon Fraser.

  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection): Added calls to

beginDeferredRepaints() and endDeferredRepaints() around the
invalidation of the selection, in order to better coalesce multiple
invalid rectangles.

13:26 Changeset [47725] by pfeldman@chromium.org
  • 5 edits in trunk/WebCore

2009-08-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Simplify findTreeElement code, get rid of potential infinite loop.

https://bugs.webkit.org/show_bug.cgi?id=28680

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.findTreeElement):
  • inspector/front-end/treeoutline.js: (TreeOutline.prototype.getCachedTreeElement): (TreeOutline.prototype.findTreeElement):
  • inspector/front-end/utilities.js: (isAncestorNode): ():
13:20 Changeset [47724] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-08-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Do expand local scope when hitting the break

https://bugs.webkit.org/show_bug.cgi?id=28678

  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
13:16 Changeset [47723] by adachan@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Brady Eidson.

Add test for https://bugs.webkit.org/show_bug.cgi?id=28659.
Cached page should be formatted according to the current window size, not the cached frame's size.

  • loader: Added.
  • loader/go-back-to-different-window-size-expected.txt: Added.
  • loader/go-back-to-different-window-size.html: Added.
12:55 Changeset [47722] by adachan@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Steve Falkenburg.

Make sure we use the current FrameView's frame rect when
going back to a cached page.


https://bugs.webkit.org/show_bug.cgi?id=28659

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::open):
12:10 Changeset [47721] by eric@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2009-08-24 Eric Seidel <eric@webkit.org>

No review, just updating results.

Support placeholder on textarea
https://bugs.webkit.org/show_bug.cgi?id=21248

Update expected test results form windows bot.

  • platform/win/fast/forms/basic-textareas-expected.txt:
  • platform/win/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
  • platform/win/fast/forms/textarea-placeholder-set-attribute-expected.txt: Added.
  • platform/win/fast/forms/textarea-placeholder-set-value-expected.txt: Added.
11:35 Changeset [47720] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-08-24 Cameron McCormack <cam@mcc.id.au>

Reviewed by Darin Adler.

Modifying <text rotate=""> doesn't clear the corresponding SVGAnimatedNumberList
https://bugs.webkit.org/show_bug.cgi?id=28673

  • svg/dom/resources/text-rotate-live.js: Added. (getRotate): (getAndSetRotate):
  • svg/dom/text-rotate-live-expected.txt: Added.
  • svg/dom/text-rotate-live.html: Added.

2009-08-24 Cameron McCormack <cam@mcc.id.au>

Reviewed by Darin Adler.

Modifying <text rotate=""> doesn't clear the corresponding SVGAnimatedNumberList
https://bugs.webkit.org/show_bug.cgi?id=28673

Test: svg/dom/text-rotate-live.html

  • svg/SVGNumberList.cpp: (WebCore::SVGNumberList::parse): Clear the list before adding the parsed numbers.
11:07 Changeset [47719] by simon.fraser@apple.com
  • 4 edits in trunk

2009-08-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by NOBODY (build fix)

Turn off ENABLE_3D_CANVAS in the xconfig files.

  • Configurations/FeatureDefines.xcconfig:
11:02 Changeset [47718] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.13

Tagging WebKitGTK+ 1.1.13

09:40 Changeset [47717] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-08-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Only expand local scope when hitting the break

https://bugs.webkit.org/show_bug.cgi?id=28678

  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
09:26 Changeset [47716] by mitz@apple.com
  • 6 edits in trunk

WebCore:
background-size fails to parse if a single length/percentage/auto is followed by a comma
https://bugs.webkit.org/show_bug.cgi?id=28674

Reviewed by Simon Fraser.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillSize): Added an allowComma parameter,

which is set to false when this method consumes a comma. Moved
handling of 'contain' and 'cover' from parseFillProperty into this
method.

(WebCore::CSSParser::parseFillProperty): Set allowComma to true before

processing the next value, and pass allowComma to parseFillSize.

  • css/CSSParser.h:

LayoutTests:
background-size fails to parse if a single length/percentage/auto is followed by a comma
https://bugs.webkit.org/show_bug.cgi?id=28674

Reviewed by Simon Fraser.

  • fast/backgrounds/size/parsing-background-size-values-expected.txt:
  • fast/backgrounds/size/resources/parsing-background-size-values.js:
09:02 Changeset [47715] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Fix a typo in my distcheck build fix.

  • GNUmakefile.am:
08:41 Changeset [47714] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

News about the 1.1.13 release.

  • NEWS:
08:28 Changeset [47713] by kov@webkit.org
  • 5 edits in trunk

2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Bump package and so versions for 1.1.13 release.

  • configure.ac:

WebKit/gtk

2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Add new symbols, and an index of new symbols for the 1.1.13
release.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
07:55 Changeset [47712] by kov@webkit.org
  • 2 edits
    3 adds in trunk/WebCore

2009-08-17 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] Support for cursors that are images
https://bugs.webkit.org/show_bug.cgi?id=28346

Added support for cursors which are images for CursorGtk. Added
a manual test for this.

  • manual-tests/gtk/cursor-image.html: Added.
  • manual-tests/gtk/resources/redcursor.cur: Added.
  • platform/gtk/CursorGtk.cpp: (WebCore::Cursor::Cursor):
07:48 Changeset [47711] by kenneth@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed. Add missing files from former commit 47709.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-08-24

  • platform/qt/fast/backgrounds/svg-as-background-1-expected.txt: Added.
  • platform/qt/fast/backgrounds/svg-as-background-2-expected.txt: Added.
  • platform/qt/fast/backgrounds/svg-as-background-3-expected.txt: Added.
  • platform/qt/fast/backgrounds/svg-as-background-4-expected.txt: Added.
  • platform/qt/fast/backgrounds/svg-as-background-5-expected.txt: Added.
  • platform/qt/fast/backgrounds/svg-as-background-6-expected.txt: Added.
07:30 Changeset [47710] by kov@webkit.org
  • 6 edits in trunk

WebCore:

2009-08-24 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] Integrate GStreamer video with the graphics backend
https://bugs.webkit.org/show_bug.cgi?id=16356

Improves GStreamer backend implementation of MediaPlayerPrivate class.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateErrorCallback): Send proper MediaPlayer error for different GStreamer errors to MediaPlayerPrivate. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Move static initialization boolean to a better place. (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::duration): Return if error occured, do not consider the source as stream if duration query failed. (WebCore::MediaPlayerPrivate::currentTime): Return if error occured, use an early return. (WebCore::MediaPlayerPrivate::seek): Return if error occured. (WebCore::MediaPlayerPrivate::setEndTime): Remove implementation since this function doesn't seem to be used anywhere in WebCore. (WebCore::MediaPlayerPrivate::paused): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::setRate): Seek to current time when rate is set. (WebCore::MediaPlayerPrivate::maxTimeBuffered): Return if error occured. (WebCore::MediaPlayerPrivate::maxTimeSeekable): Ditto. (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto. (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::totalBytesKnown): (WebCore::MediaPlayerPrivate::totalBytes): Ditto. (WebCore::MediaPlayerPrivate::updateStates): Return if error occured, update after seek ended with a successful change (WebCore::MediaPlayerPrivate::didEnd): Do not pause the playbin when end is reached. (WebCore::MediaPlayerPrivate::loadingFailed): Update network state with the given error. (WebCore::mimeTypeCache): Gather supported mime types from GStreamer. (WebCore::MediaPlayerPrivate::getSupportedTypes): (WebCore::MediaPlayerPrivate::supportsType): (WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin): (WebCore::MediaPlayerPrivate::supportsFullscreen): First step towards fullscreen support. (WebCore::MediaPlayerPrivate::createGSTPlayBin): Use playbin2 instead of playbin, do not set playbin's audio sink.
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func): Use C++ casts, decrease reference count of async queue at the end of the idle function. (webkit_video_sink_render): Increase reference count of async queue. (webkit_video_sink_stop): Remove any idle functions with the sink as data.

LayoutTests:

2009-08-24 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] Integrate GStreamer video with the graphics backend
https://bugs.webkit.org/show_bug.cgi?id=16356

Enable media tests that now pass.

  • platform/gtk/Skipped:
07:26 Changeset [47709] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Add results with updated font metrics for passing tests added in
r28637 and remove them from Skipped.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-08-24
Reviewed by Ariya Hidayat.

  • platform/qt/Skipped:
  • platform/qt/fast/backgrounds/svg-as-background-1-expected.txt: Added.
  • platform/qt/fast/backgrounds/svg-as-background-2-expected.txt: Added.
  • platform/qt/fast/backgrounds/svg-as-background-3-expected.txt: Added.
  • platform/qt/fast/backgrounds/svg-as-background-4-expected.txt: Added.
  • platform/qt/fast/backgrounds/svg-as-background-5-expected.txt: Added.
  • platform/qt/fast/backgrounds/svg-as-background-6-expected.txt: Added.
06:38 Changeset [47708] by cmarrin@apple.com
  • 2 edits
    6 adds in trunk/WebCore

Remaining new files for Canvas3D
https://bugs.webkit.org/show_bug.cgi?id=28018

04:58 Changeset [47707] by ariya@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2009-08-24 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Add results for new tests added in r47590 and r47702.

  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
  • platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt: Added.
  • platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt: Added.
  • platform/qt/fast/repaint/inline-block-resize-expected.txt: Added.
04:05 Changeset [47706] by ariya@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-24 Ariya Hidayat <ariya.hidayat@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] Skip new test added in r47630

  • platform/qt/Skipped: Skip fast/backgrounds/size/parsing-inherit.html.
03:18 Changeset [47705] by ariya@webkit.org
  • 5 edits in trunk/LayoutTests

2009-08-24 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update the outdated metrics for doctype tests. All tests pass.

  • platform/qt/Skipped:
  • platform/qt/fast/doctypes/001-expected.txt:
  • platform/qt/fast/doctypes/002-expected.txt:
  • platform/qt/fast/doctypes/004-expected.txt:
03:09 Changeset [47704] by ariya@webkit.org
  • 1 edit
    19 adds in trunk/LayoutTests

2009-08-24 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Add results for new tests added in r47678.

  • platform/qt/fast/block/margin-collapse/block-inside-inline: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/002-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/003-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/021-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/022-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt: Added.
03:09 Changeset [47703] by pfeldman@chromium.org
  • 11 edits in trunk/WebCore

2009-08-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Migrate call frames interaction to the InjectedScript-based schema.

https://bugs.webkit.org/show_bug.cgi?id=28408

  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleTextMessage):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.get domWindow): (InspectorController.openInInspectedWindow): (InspectorController.getCallFrames): (InspectorController.evaluateInCallFrame):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.generateStylesheet):
  • inspector/front-end/InjectedScript.js: (InjectedScript.evaluate): (InjectedScript._evaluateOn): (InjectedScript.openInInspectedWindow): (InjectedScript.getCallFrames): (InjectedScript.evaluateInCallFrame): (InjectedScript._callFrameForId): (InjectedScript._objectForId): (InjectedScript.CallFrameProxy): (InjectedScript.CallFrameProxy.prototype._wrapScopeChain):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype._update):
  • inspector/front-end/ObjectProxy.js: (WebInspector.ObjectPropertyProxy):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane): (WebInspector.ScopeChainSidebarPane.prototype.update): (WebInspector.ScopeVariableTreeElement.prototype.onattach): (WebInspector.ScopeVariableTreeElement.prototype.onexpand): (WebInspector.ScopeVariableTreeElement.prototype.oncollapse):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame): (WebInspector.ScriptsPanel.prototype.variablesInSelectedCallFrame): (WebInspector.ScriptsPanel.prototype.debuggerPaused.callback): (WebInspector.ScriptsPanel.prototype.debuggerPaused):
01:28 Changeset [47702] by eric@webkit.org
  • 21 edits
    9 adds in trunk

2009-08-24 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

  • fast/forms/resources/textarea-placeholder-dom-property.js: Added.
  • fast/forms/textarea-placeholder-dom-property-expected.txt: Added.
  • fast/forms/textarea-placeholder-dom-property.html: Added.
  • fast/forms/textarea-placeholder-pseudo-style.html: Added.
  • fast/forms/textarea-placeholder-set-attribute.html: Added.
  • fast/forms/textarea-placeholder-set-value.html: Added.
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt:
  • platform/mac/fast/forms/input-text-maxlength-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
  • platform/mac/fast/forms/textarea-placeholder-set-attribute-expected.txt: Added.
  • platform/mac/fast/forms/textarea-placeholder-set-value-expected.txt: Added.
  • platform/qt/fast/forms/input-text-maxlength-expected.txt:
  • platform/win/fast/forms/input-text-maxlength-expected.txt:

2009-08-24 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Add support for the placeholder attribute and DOM property of the textarea element.
https://bugs.webkit.org/show_bug.cgi?id=21248

A DOM node for an INPUT element doesn't have a flag for placeholder
visibility anymore. This patch also fixes a bug that a renderer
doesn't reflect a corresponding DOM value change.

Tests: fast/forms/textarea-placeholder-dom-property.html

fast/forms/textarea-placeholder-pseudo-style.html
fast/forms/textarea-placeholder-set-attribute.html
fast/forms/textarea-placeholder-set-value.html

  • css/html.css: Add the default style for placeholder of textarea.
  • dom/InputElement.cpp: Cleanup for m_placeholderShouldBeVisible removal (WebCore::InputElement::dispatchFocusEvent): (WebCore::InputElement::dispatchBlurEvent): (WebCore::InputElement::placeholderShouldBeVisible): (WebCore::InputElement::updatePlaceholderVisibility): (WebCore::InputElement::setValueFromRenderer): (WebCore::InputElementData::InputElementData):
  • dom/InputElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dispatchFocusEvent): (WebCore::HTMLInputElement::dispatchBlurEvent): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::placeholderShouldBeVisible):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::updatePlaceholderVisibility):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute): (WebCore::HTMLTextAreaElement::setValue): (WebCore::HTMLTextAreaElement::placeholderShouldBeVisible): (WebCore::HTMLTextAreaElement::updatePlaceholderVisibility): (WebCore::HTMLTextAreaElement::dispatchFocusEvent): (WebCore::HTMLTextAreaElement::dispatchBlurEvent):
  • html/HTMLTextAreaElement.h:
  • html/HTMLTextAreaElement.idl:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::styleDidChange): (WebCore::RenderTextControl::setInnerTextStyle): (WebCore::RenderTextControl::updatePlaceholderVisibility):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine): (WebCore::RenderTextControlMultiLine::nodeAtPoint): (WebCore::RenderTextControlMultiLine::updateFromElement): (WebCore::RenderTextControlMultiLine::createInnerTextStyle): (WebCore::RenderTextControlMultiLine::textBaseStyle):
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::textBaseStyle): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
  • rendering/RenderTextControlSingleLine.h:
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::dispatchFocusEvent): (WebCore::WMLInputElement::dispatchBlurEvent): (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::placeholderShouldBeVisible):
00:14 Changeset [47701] by zoltan@webkit.org
  • 1 edit in trunk/WebKitTools/Scripts/modules/committers.py

Unreviewed.

Change my mail address on the list of committers.

00:02 Changeset [47700] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-23 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix regression in editing tests by changing expected file to the
Mac one, since we now default to Mac in the EditingBehavior
setting.

  • platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt:
00:01 Changeset [47699] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-08-23 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix a couple of typos.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):

08/23/09:

23:00 Changeset [47698] by krit@webkit.org
  • 6 edits in trunk/WebCore

2009-08-23 Dirk Schulze <krit@webkit.org>

Reviewed by Mark Rowe.

Code clean-up and build fix for filters enabled builds. Moved SVGNames.h
into #if ENABLE(SVG) for Document.cpp and added SVGNames.h to the other
files. They are needed there after r47688.

  • dom/Document.cpp:
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
20:44 Changeset [47697] by kov@webkit.org
  • 8 edits in trunk

WebCore:

2009-08-23 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed, build fix for make distcheck on GTK+.

  • GNUmakefile.am: Added files needed for the build.
  • bindings/js/JSDOMWindowCustom.cpp: Protect SharedWorker include with #if clause.
  • bindings/js/JSEventTarget.cpp: Dito.
  • dom/Document.cpp: Dito.
  • loader/FrameLoader.cpp: Dito.

JavaScriptCore:

2009-08-23 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed build fix for make distcheck.

  • GNUmakefile.am: Added files required for the build.
14:42 Changeset [47696] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-08-23 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Inspector: Throws an Error on "null"
https://bugs.webkit.org/show_bug.cgi?id=28665

  • inspector/front-end/InjectedScript.js: (InjectedScript.evaluate):
12:49 Changeset [47695] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-08-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Inspector: REGRESSION Formatting Function in Console is Abbreviated Too Often

https://bugs.webkit.org/show_bug.cgi?id=28666

  • inspector/front-end/InjectedScript.js: (InjectedScript.getProperties): (InjectedScript.createProxyObject):
12:24 Changeset [47694] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-08-23 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update editing-behavior property here too.

  • webkit/webkitwebview.cpp: (webkit_web_view_settings_notify):
10:04 Changeset [47693] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Rubberstamped by Gustavo Noronha.

Fix regressions introduced by http://trac.webkit.org/changeset/47690.

Update the setting whenever the property gets set.

  • webkit/webkitwebview.cpp: (webkit_web_view_settings_notify):
03:08 Changeset [47692] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] API for disabling local file access to web URLs
https://bugs.webkit.org/show_bug.cgi?id=28663

Enable this setting for DRT.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
02:05 Changeset [47691] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Not reviewed. Skip new tests from
http://trac.webkit.org/changeset/47678 and the appcache HTTP
authentication tests (https://bugs.webkit.org/show_bug.cgi?id=28668)

  • platform/gtk/Skipped:
01:45 Changeset [47690] by jmalonzo@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] API for disabling local file access to web URLs
https://bugs.webkit.org/show_bug.cgi?id=28663

Add a setting to enable or disable file access to web URLs. It's
disabled by default for security reasons.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings):
00:18 Changeset [47689] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-08-22 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] BitmapImage::getGdkPixbuf does not handle alpha channels properly
https://bugs.webkit.org/show_bug.cgi?id=28345

When doing the conversion between cairo_surface_t* and GdkPixbuf*
account for the differences in the respective formats' in-memory
image format.

  • platform/graphics/gtk/ImageGtk.cpp: (WebCore::getCairoSurfacePixel): (WebCore::getGdkPixbufPixel): (WebCore::BitmapImage::getGdkPixbuf):

08/22/09:

23:55 Changeset [47688] by darin@apple.com
  • 43 edits in trunk/WebCore

Make DOM classes start with a reference count of 1, like all other RefCounted

Patch by Darin Adler <darin@apple.com> on 2009-08-22
Reviewed by Oliver Hunt.

Next step: Element, HTMLElement, HTMLAnchorElement, HTMLAppletElement,
HTMLAreaElement, HTMLEmbedElement, HTMLFrameElement, HTMLIFrameElement,
HTMLObjectElement, HTMLPlugInElement, HTMLPlugInImageElement.

  • DerivedSources.make: Fix error seen every time we build by escaping the $

in the build rule, since you have to use $$ for that in make.

  • WebCore.base.exp: Updated.
  • bindings/objc/DOM.mm:

Added now-needed include of SVGNames.h.

  • dom/Document.cpp: Added now-needed include of SVGNames.h.

(WebCore::Document::createElement): Use create instead of new.

  • dom/Element.cpp:

(WebCore::Element::Element): Added ConstructionType argument so the caller
can determine whether this starts with a reference count of either 0 or 1.
Later we will remove this again once they are all 1.
(WebCore::Element::create): Added.

  • dom/Element.h: Added create and made constructor protected.
  • dom/StyledElement.cpp:

(WebCore::StyledElement::StyledElement): Added ConstructionType argument.

  • dom/StyledElement.h: Made many functions protected or private, including

the constructor.

  • dom/make_names.pl: Use create to create the base elements HTMLElement,

SVGElement, and WMLElement.

  • editing/CreateLinkCommand.cpp:

(WebCore::CreateLinkCommand::doApply): Use create instead of new.

  • editing/UnlinkCommand.cpp:

(WebCore::UnlinkCommand::doApply): Ditto.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::create): Added.

  • html/HTMLAnchorElement.h: Made constructor protected and added create.

Also made m_rootEditableElementForSelectionOnMouseDown a RefPtr.

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::create): Added.

  • html/HTMLAppletElement.h: Made constructor private and added create.
  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::create): Added.

  • html/HTMLAreaElement.h: Made constructor private and added create.
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::create): Added.

  • html/HTMLElement.h: Made constructor protected and added create.

Made other functions protected and private. Also added inline
definition of constructor.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::create): Added.

  • html/HTMLEmbedElement.h: Made constructor private and added create.

Made other functions private.

  • html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::create): Added.
(WebCore::HTMLFrameElement::parseMappedAttribute):

  • html/HTMLFrameElement.h: Made constructor private and added create.

Made other functions private.

  • html/HTMLFrameElementBase.h: Made functions protected and private.
  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): Pass
CreateElement so reference count starts at 1.

  • html/HTMLFrameOwnerElement.h: Made functions protected and private.
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::create): Added.

  • html/HTMLIFrameElement.h: Made constructor private and added create.

Made other functions private.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::create): Added.
(WebCore::HTMLObjectElement::containsJavaApplet): Changed while loop
into a for loop and tweaked formatting.

  • html/HTMLObjectElement.h: Made constructor private and added create.

Made other functions private.

  • html/HTMLPlugInElement.h: Made constructor protected.

Made other functions protected and private.

  • html/HTMLPlugInImageElement.h: Made constructor and another function

protected.

  • html/HTMLTagNames.in: Removed createWithNew from all classes that

now have create functions. Moved conditional noscript to a separate
paragraph.

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::addSpanWithClassName): Use create.
(WebCore::HTMLViewSourceDocument::addLink): Ditto.

  • page/DragController.cpp:

(WebCore::documentFragmentFromDragData): Ditto.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::SVGElement): Pass CreateElementZeroRefCount
so reference count still starts at 0. Will change this class later.
(WebCore::SVGElement::create): Added.

  • svg/SVGElement.h: Added create, made constructor protected, and

made other functions protected and private. Removed unneeded
SVGNames.h include.

  • svg/SVGExternalResourcesRequired.h: Added now-needed SVGNames.h

include.

  • svg/SVGStopElement.h: Added now-needed SVGNames.h include.

Made functions private.

  • wml/WMLElement.cpp:

(WebCore::WMLElement::WMLElement): Pass CreateElementZeroRefCount
so reference count still starts at 0. Will change this class later.
(WebCore::WMLElement::create): Added.

  • wml/WMLElement.h: Added create and made constructor protected.
  • wml/WMLTagNames.in: Removed createWithNew from WMLElement.
23:36 Changeset [47687] by xan@webkit.org
  • 6 edits in trunk/WebKit/gtk

2009-08-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=28154
clicking below end of text in a textarea moves cursor to wrong position

Expose the EditingBehavior setting and set it by default to Mac,
since that what matches the GTK+ default behavior.

  • webkit/webkitprivate.cpp: (WebKit::core):
  • webkit/webkitprivate.h:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebsettings.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings):
22:04 Changeset [47686] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC
https://bugs.webkit.org/show_bug.cgi?id=28655

Reviewed by Mark Rowe.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction): Initialize properly with a VPtrHackExecutable.

  • wtf/Platform.h:
21:43 Changeset [47685] by abarth@webkit.org
  • 11 edits in trunk

WebKit/mac: Revert 47684. We're going to do this later once clients have had a
chance to opt into the setting they like.

Patch by Adam Barth <abarth@webkit.org> on 2009-08-22

  • Misc/WebKitVersionChecks.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

WebKit/qt: Revert 47684. We're going to do this later once clients have had a
chance to opt into the setting they like.

Patch by Adam Barth <abarth@webkit.org> on 2009-08-22

  • Api/qwebsettings.cpp:

(QWebSettings::QWebSettings):

WebKit/win: Revert 47684. We're going to do this later once clients have had a
chance to opt into the setting they like.

Patch by Adam Barth <abarth@webkit.org> on 2009-08-22

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):

WebKitTools: Revert 47684. We're going to do this later once clients have had a
chance to opt into the setting they like.

Patch by Adam Barth <abarth@webkit.org> on 2009-08-22

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::WebPage):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

21:24 Changeset [47684] by abarth@webkit.org
  • 11 edits in trunk

2009-08-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480

  • Misc/WebKitVersionChecks.m:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]):

2009-08-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480

  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings):

2009-08-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480

  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):

2009-08-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480

A bunch of our LayoutTests rely on our old behavior, so we explicitly
grant local files universal access during testing. Mainly, these tests
involve making XMLHttpRequests for data URLs.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
17:48 Changeset [47683] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

17:47 Changeset [47682] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.16

New tag.

17:47 Changeset [47681] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebCore

Merge r47679.

17:47 Changeset [47680] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r47663.

17:43 Changeset [47679] by adele@apple.com
  • 3 edits in trunk/WebCore

Fix for <rdar://problem/7161656> Crash in RenderObject::destroy when using custom scrollbars

Reviewed by Anders Carlsson.

Custom scrollbars normally get detached when a document gets detached. In this case, a crash was happening when the document had gone into the page cache
and then was getting destroyed without proper scrollbar teardown. This change makes custom scrollbars get detached when the document enters the cache.

I couldn't figure out a way to reliably cause this to happen in DRT, since the reproducible case relies on the cache being purged at a particular time.

  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Detach custom scrollbars when the CachedFrame is created. They'll get reattached when the document comes out of the page cache.
  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): Added some asserts to catch this problem earlier in debug builds.
16:26 Changeset [47678] by hyatt@apple.com
  • 4 edits
    74 adds in trunk

WebCore: Make sure self-collapsing blocks that clear floats are still able to collapse their bottom margins with
the bottom of their parent blocks. The old code prevented all collapsing, but all CSS2.1 states is that:
"An element that has had clearance applied to it never collapses its top margin with its parent block's bottom margin."

Reviewed by Dan Bernstein.

The implication is that the bottom margin can still collapse, and the block-inside-inline form of
fast/block/margin-collapse/025.html (added as fast/block/margin-collapse/block-inside-inline/025.html) depends
on it to get comparable results.

Added block-inside-inline tests (a whole slew of them) in fast/block/margin-collapse/block-inside-inline/

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::handleBottomOfBlock):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::MarginInfo::clearMargin):
(WebCore::RenderBlock::MarginInfo::canCollapseBottomWithChildren):

LayoutTests: Add a bunch of tests for the block-inside-inline cases of margin-collapsing. The same test
suite but converted to wrap all the blocks inside inlines to make sure they still collapse
the same way.

Reviewed by Dan Bernstein.

  • fast/block/margin-collapse/block-inside-inline: Added.
  • fast/block/margin-collapse/block-inside-inline/001.html: Added.
  • fast/block/margin-collapse/block-inside-inline/002.html: Added.
  • fast/block/margin-collapse/block-inside-inline/003.html: Added.
  • fast/block/margin-collapse/block-inside-inline/004.html: Added.
  • fast/block/margin-collapse/block-inside-inline/005.html: Added.
  • fast/block/margin-collapse/block-inside-inline/006.html: Added.
  • fast/block/margin-collapse/block-inside-inline/010.html: Added.
  • fast/block/margin-collapse/block-inside-inline/011.html: Added.
  • fast/block/margin-collapse/block-inside-inline/012.html: Added.
  • fast/block/margin-collapse/block-inside-inline/015.html: Added.
  • fast/block/margin-collapse/block-inside-inline/016.html: Added.
  • fast/block/margin-collapse/block-inside-inline/017.html: Added.
  • fast/block/margin-collapse/block-inside-inline/018.html: Added.
  • fast/block/margin-collapse/block-inside-inline/019.html: Added.
  • fast/block/margin-collapse/block-inside-inline/020.html: Added.
  • fast/block/margin-collapse/block-inside-inline/021.html: Added.
  • fast/block/margin-collapse/block-inside-inline/022.html: Added.
  • fast/block/margin-collapse/block-inside-inline/025.html: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/001-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/001-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/001-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/002-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/002-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/002-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/003-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/003-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/003-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/004-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/004-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/004-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/005-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/005-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/005-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/006-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/006-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/006-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/010-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/010-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/010-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/011-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/011-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/011-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/012-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/012-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/012-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/015-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/015-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/015-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/016-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/016-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/016-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/017-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/017-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/017-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/018-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/018-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/018-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/019-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/019-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/019-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/020-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/020-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/020-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/021-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/021-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/021-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/022-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/022-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/022-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.checksum: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.png: Added.
  • platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.txt: Added.
15:56 Changeset [47677] by mrowe@apple.com
  • 4 edits
    1 add in trunk/WebKitTools

Bring signed updates to the Mac nightly builds.

Rubber-stamped by Anders Carlsson.

  • WebKitLauncher/Info.plist:
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitNightlyEnablerSparkle.m:

(initializeSparkle):

  • WebKitLauncher/nightly.webkit.org.public.pem: Added.
10:54 Changeset [47676] by cfleizach@apple.com
  • 1 edit
    1 copy
    1 move in trunk/LayoutTests

Need to implement ARIA role="listitem" and role="list"
https://bugs.webkit.org/show_bug.cgi?id=28606

Fixing LayoutTest bustage.

The SnowLeopard results are the latest, so they need to move to platform/mac
The Tiger/Leopard results will default to the SnowLeopard results, so we need to move
the current test from platform/mac to platform/mac-leopard

  • platform/mac-leopard/accessibility/aria-roles-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-roles-expected.txt.
  • platform/mac-snowleopard/accessibility/aria-roles-expected.txt: Removed.
  • platform/mac/accessibility/aria-roles-expected.txt: Replaced with LayoutTests/platform/mac-snowleopard/accessibility/aria-roles-expected.txt.
10:03 Changeset [47675] by cfleizach@apple.com
  • 5 edits
    4 adds in trunk

WebCore: Need to implement ARIA role="listitem" and role="list"
https://bugs.webkit.org/show_bug.cgi?id=28606

Reviewed by Darin Adler.

Test: platform/mac-snowleopard/accessibility/aria-list-and-listitem.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::isUnorderedList):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::RoleEntry::):

LayoutTests: Need to implement ARIA role="listitem" and role="list"
https://bugs.webkit.org/show_bug.cgi?id=28606

Reviewed by Darin Adler.

Also added a SnowLeopard specific result for aria-roles-expected.

  • platform/mac-snowleopard/accessibility: Added.
  • platform/mac-snowleopard/accessibility/aria-list-and-listitem-expected.txt: Added.
  • platform/mac-snowleopard/accessibility/aria-list-and-listitem.html: Added.
  • platform/mac-snowleopard/accessibility/aria-roles-expected.txt: Added.
09:32 Changeset [47674] by mitz@apple.com
  • 3 edits in trunk/WebCore

Clean up fill image geometry calculation
https://bugs.webkit.org/show_bug.cgi?id=28652

Reviewed by Darin Adler.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize): Renamed

calculateBackgroundSize() to this. Replaced separate scaledWidth and
scaledHeight parameters with a single scaledSize parameter. Renamed
parameters and local variables.

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Changed

to use CSS3 Backgrounds and Borders terminology in comments and
local variable names. Renamed, clarified and consolidated some local
variables.

  • rendering/RenderBoxModelObject.h: Made calculateFillTileSize() private.
09:16 Changeset [47673] by cmarrin@apple.com
  • 3 edits in trunk/WebCore

Backing out http://trac.webkit.org/changeset/47669

09:10 Changeset [47672] by dglazkov@chromium.org
  • 7 edits in trunk/WebCore

2009-08-22 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

Backing out http://trac.webkit.org/changeset/47671 in preparation of
rolling out http://trac.webkit.org/changeset/47669.

08:13 Changeset [47671] by dglazkov@chromium.org
  • 7 edits in trunk/WebCore

2009-08-22 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Anders Carlsson.

Build fix, add CanvasRenderingContext to build systems.
https://bugs.webkit.org/show_bug.cgi?id=28018

  • DerivedSources.make: Added CanvasRenderinContext.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
06:11 Changeset [47670] by cmarrin@apple.com
  • 6 edits
    18 adds
    1 delete in trunk/WebCore

New files implementing GL buffer wrappers, and support to make them platform independent
https://bugs.webkit.org/show_bug.cgi?id=28018

05:56 Changeset [47669] by cmarrin@apple.com
  • 2 edits in trunk/WebCore/html/canvas

stash CanvasRenderingContext2D

02:02 Changeset [47668] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix storage leak from syntax tree arena allocation patch.

Patch by Darin Adler <darin@apple.com> on 2009-08-22

  • parser/Nodes.h: CommaNode needs to inherit from ParserArenaDeletable

because it has a vector.

Note: See TracTimeline for information about the timeline view.