Timeline


and

09/06/09:

22:25 Changeset [48107] by eric@webkit.org
  • 5 edits in trunk

2009-09-06 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

hostname and host are mixed up when manipulating anchor elements.
https://bugs.webkit.org/show_bug.cgi?id=28954

Added test case for when port is 0.

  • fast/dom/Element/hostname-host-expected.txt:
  • fast/dom/Element/hostname-host.html:

2009-09-06 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

hostname and host are mixed up when manipulating anchor elements.
https://bugs.webkit.org/show_bug.cgi?id=28954

handle the case of port 0.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::host):
22:10 Changeset [48106] by abarth@webkit.org
  • 31 edits
    6 adds in trunk

2009-09-06 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Tests for https://bugs.webkit.org/show_bug.cgi?id=27099
Make hidden elements not focusable. This is important becaue we should
not allow tabbing to a hidden element.

The patch also makes a element without href behave like generic elements
when it comes to focus. Added tests that asserts that this works as
expected.

  • fast/events/click-focus-anchor-expected.txt: Added.
  • fast/events/click-focus-anchor.html: Added.
  • fast/events/resources/tabindex-focus-blur-all.js: (test): (testProgrammaticFocus):
  • fast/events/tab-focus-anchor-expected.txt: Added.
  • fast/events/tab-focus-anchor.html: Added.
  • fast/events/tab-focus-hidden-expected.txt: Added.
  • fast/events/tab-focus-hidden.html: Added.
  • fast/events/tabindex-focus-blur-all-expected.txt:

2009-09-06 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Make hidden elements not focusable.

Clean up supportsFocus and isFocusable.
supportsFocus now strictly means that the node can be focused by default.
This is true for links, form controls and content editable elements for example.
isFocusable means that the user can actually focus it.
All (2) calls to supportsFocus have been updated to take this into account.

Make a elements without href work correctly as well.

https://bugs.webkit.org/show_bug.cgi?id=27099

Tests: fast/events/click-focus-anchor.html

fast/events/tab-focus-anchor.html
fast/events/tab-focus-hidden.html

  • dom/Element.cpp: (WebCore::Element::focus):
  • dom/Node.cpp: (WebCore::Node::supportsFocus): (WebCore::Node::isFocusable):
  • dom/Node.h:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::supportsFocus): (WebCore::HTMLAnchorElement::isMouseFocusable): (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  • html/HTMLAnchorElement.h:
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::supportsFocus):
  • html/HTMLAreaElement.h:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::supportsFocus):
  • html/HTMLElement.h:
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::supportsFocus):
  • html/HTMLFieldSetElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::supportsFocus): (WebCore::HTMLFormControlElement::isFocusable):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::supportsFocus):
  • html/HTMLFrameElementBase.h:
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::supportsFocus):
  • html/HTMLLegendElement.h:
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::supportsFocus): (WebCore::HTMLOptGroupElement::isFocusable):
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::supportsFocus): (WebCore::HTMLOptionElement::isFocusable):
  • html/HTMLOptionElement.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent):
  • page/FocusController.cpp: (WebCore::FocusController::advanceFocus):
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::supportsFocus): (WebCore::SVGAElement::isFocusable):
  • wml/WMLAElement.cpp: (WebCore::WMLAElement::supportsFocus):
  • wml/WMLAElement.h:
  • wml/WMLFormControlElement.cpp: (WebCore::WMLFormControlElement::supportsFocus): (WebCore::WMLFormControlElement::isFocusable):
  • wml/WMLFormControlElement.h:
21:15 Changeset [48105] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-06 Joel Stanley <joel@jms.id.au>

Reviewed by Dimitri Glazkov.

Expose functions to set the caret blink interval for Linux Chromium.
Default value is set to that of RenderTheme::caretBlankInterval().
Uses caretBlinkIntervalInternal to avoid overriding
RenderThemeChromiumSkia::caretBlankInterval to preserve the disabling
of blinking caret required for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=28931

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval): (WebCore::RenderThemeChromiumLinux::caretBlinkIntervalInternal):
  • rendering/RenderThemeChromiumLinux.h:
19:27 Changeset [48104] by adachan@apple.com
  • 2 edits in trunk/WebCore

Remove an extra </File> in WebCore.vcproj.

  • WebCore.vcproj/WebCore.vcproj:
15:44 Changeset [48103] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-09-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update the unitests to latest changes wrt scrollbar policy.

  • tests/testwindow.c: (test_webkit_window_scrollbar_policy):
13:43 Changeset [48102] by timothy@apple.com
  • 6 edits
    1 add in trunk/WebCore

Adds a persistent setting for color format in the Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=28889

Reviewed by Dan Bernstein.

  • English.lproj/localizedStrings.js: New strings.
  • inspector/front-end/Color.js: Minor style fixes.

(WebInspector.Color.prototype.toString): Added. Replaces the individual
"toFoo" functions. Takes a optional arguments for the color format to return.

  • inspector/front-end/Images/paneSettingsButtons.png: Added.
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._changeColorFormat): Update the sections to show
the new color format.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay):
Use the new toString function on Color.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor): Use the persistent setting
to format colors by default. Add a tooltip for the color swatch.

  • inspector/front-end/inspector.css: New styles for the settings menu.
  • inspector/front-end/inspector.js:

(WebInspector.loaded): Initilize the colorFormat preference.

07:31 Changeset [48101] by xan@webkit.org
  • 15 edits
    4 adds in trunk

2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.

[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899

Expose an HTML5 database API for GTK+.

  • GNUmakefile.am:

LayoutTests:

2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.

[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899

Expose an HTML5 database API for GTK+.

  • platform/gtk/Skipped:

WebKit/gtk:

2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.

[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899

Expose an HTML5 database API for GTK+.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::print):
  • webkit/webkit.h:
  • webkit/webkitdefines.h:
  • webkit/webkitprivate.cpp: (webkit_init):
  • webkit/webkitprivate.h:
  • webkit/webkitsecurityorigin.cpp: Added. (webkit_security_origin_finalize): (webkit_security_origin_dispose): (webkit_security_origin_set_property): (webkit_security_origin_get_property): (webkit_security_origins): (webkit_security_origin_class_init): (webkit_security_origin_init): (webkit_security_origin_get_protocol): (webkit_security_origin_get_host): (webkit_security_origin_get_port): (webkit_security_origin_get_web_database_usage): (webkit_security_origin_get_web_database_quota): (webkit_security_origin_set_web_database_quota): (webkit_security_origin_get_all_web_databases): (WebKit::kit): (WebKit::core): (webkit_security_origin_get_web_database):
  • webkit/webkitsecurityorigin.h: Added.
  • webkit/webkitwebdatabase.cpp: Added. (webkit_web_database_finalize): (webkit_web_database_dispose): (webkit_web_database_set_property): (webkit_web_database_get_property): (webkit_web_database_class_init): (webkit_web_database_init): (webkit_web_database_set_security_origin): (webkit_web_database_set_name): (webkit_web_database_get_security_origin): (webkit_web_database_get_name): (webkit_web_database_get_display_name): (webkit_web_database_get_expected_size): (webkit_web_database_get_size): (webkit_web_database_get_filename): (webkit_web_database_remove): (webkit_remove_all_web_databases): (webkit_get_web_database_directory_path): (webkit_set_web_database_directory_path): (webkit_get_default_web_database_quota):
  • webkit/webkitwebdatabase.h: Added.
  • webkit/webkitwebframe.cpp: (webkit_web_frame_new): (webkit_web_frame_get_focused_accessible_element): (webkit_web_frame_get_horizontal_scrollbar_policy):
  • webkit/webkitwebframe.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
05:38 Changeset [48100] by laszlo.1.gombos@nokia.com
  • 3 edits in trunk/WebCore

2009-09-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Remove Qt v4.6 check from the prefetchDNS implementation
https://bugs.webkit.org/show_bug.cgi?id=28993

  • platform/network/qt/DnsPrefetchHelper.cpp:
  • platform/network/qt/DnsPrefetchHelper.h:
00:24 Changeset [48099] by eric@webkit.org
  • 24 edits
    3 deletes in trunk

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

Update test not to expect a <definition-src> element to be of type
SVGDefinitionSrcElement.

  • svg/dom/font-face-elements-expected.txt:
  • svg/dom/font-face-elements.html:

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

http://dev.w3.org/SVG/profiles/1.1F2/publish/changes.html#FontsChapter

  • DerivedSources.cpp: Remove references to definition-src.
  • DerivedSources.make: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap): Ditto.
  • bindings/objc/DOMSVG.h: Ditto.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Ditto.
  • bindings/v8/V8DOMWrapper.cpp: Ditto.
  • bindings/v8/V8Index.cpp: Ditto.
  • bindings/v8/V8Index.h: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGDefinitionSrcElement.cpp: Removed.
  • svg/SVGDefinitionSrcElement.h: Removed.
  • svg/SVGDefinitionSrcElement.idl: Removed.
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace): Don't search for definition-src child.
  • svg/svgtags.in: Remove definition-src.

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

  • MigrateHeaders.make: Remove reference to ObjC definition-src binding class.

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

When SVG 1.1 Second Edition is a Recommendation we can remove the
entry altogether.

  • projects/svg/status.xml: Update page to state that <definition-src> is not supported.

09/05/09:

21:09 Changeset [48098] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-09-05 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[Chromium] Roll out http://trac.webkit.org/changeset/48094, because the
logic of retrieving default caret blink interval was incorrect (non-existent)
and caused layout test flakiness.

  • rendering/RenderThemeChromiumLinux.cpp:
  • rendering/RenderThemeChromiumLinux.h:
20:57 MathML Goals edited by alex@milowski.com
(diff)
16:47 Changeset [48097] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-09-05 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] r47424 broke binary compatibility
https://bugs.webkit.org/show_bug.cgi?id=28996

Append the new DnsPrefetchEnabled attribute at the end of the enum.

  • Api/qwebsettings.h:
10:42 Changeset [48096] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Back up partial change in r48072 in order to fix chromium reliability build break.

Reviewed by NOBODY (Chromium reliability build break).

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::invokeEventHandler):

02:13 Changeset [48095] by eric@webkit.org
  • 6 edits in trunk/WebCore

2009-09-05 Nicolas Weber <thakis@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=28975
Fix file upload on chrome/mac. Images that have "Hide Extension" set,
such as screenshots by default, can now be uploaded to sites such as
imgur.com.

  • platform/FileSystem.h: Add pathGetDisplayFileName().
  • platform/chromium/FileChooserChromium.cpp: (WebCore::FileChooser::basenameForWidth): Call pathGetDisplayFileName() instead of pathGetFileName().
  • platform/chromium/FileSystemChromiumLinux.cpp: (WebCore::pathGetDisplayFileName): Implement pathGetDisplayFileName() by delegating to pathGetFileName().
  • platform/chromium/FileSystemChromiumMac.mm: (WebCore::pathGetFileName): Now returns a real filename instead of a presentational one, which fixes the problem addressed by this change. (WebCore::pathGetDisplayFileName): New function that returns a presentational filename; does what pathGetDisplayFileName() did prior to this patch.
  • platform/chromium/FileSystemChromiumWin.cpp: (WebCore::pathGetDisplayFileName): Implement pathGetDisplayFileName() by delegating to pathGetFileName().
02:05 Changeset [48094] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-05 Joel Stanley <joel@jms.id.au>

Reviewed by David Levin.

Expose functions to set the caret blink interval for Linux Chromium.
https://bugs.webkit.org/show_bug.cgi?id=28931

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval): (WebCore::RenderThemeChromiumLinux::caretBlinkInterval):
  • rendering/RenderThemeChromiumLinux.h:
01:43 Changeset [48093] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-09-05 Eric Seidel <eric@webkit.org>

No review, results update only.

Update results after r48043.

  • fast/js/JSON-stringify-expected.txt:

09/04/09:

21:10 Changeset [48092] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

21:09 Changeset [48091] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.17

New tag.

21:08 Changeset [48090] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48085.

21:08 Changeset [48089] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch/WebCore

Merge r48070.

21:07 Changeset [48088] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

2009-09-04 Anders Carlsson <andersca@apple.com>

Reviewed by Adele Petersen.

  • Fix <rdar://problem/7192902>

Never throw away the first frame in an animation.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):
21:07 Changeset [48087] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch/WebCore

Merge r48062.

20:54 Changeset [48086] by dimich@chromium.org
  • 4 edits
    1 add in trunk/WebCore

Prevent UI freeze in case when too many timers are in the timer queue.
https://bugs.webkit.org/show_bug.cgi?id=23865

Reviewed by David Levin.

The fix measures the elapsed time while executing timers. If we have too many
timers and it takes significant time to fire, quit the loop and reschedule.
This lets the run loop process user input (close the window for example).

  • platform/ThreadTimers.h:
  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::sharedTimerFiredInternal):
(WebCore::ThreadTimers::fireTimersInNestedEventLoop):
Removed functions and members used before to grab a list of all expired timers.
Now we fetch one by one, measuring time and quitting the loop if it takes too long.

  • platform/Timer.cpp:

(WebCore::TimerBase::isActive):
(WebCore::TimerBase::setNextFireTime):
Since timers are now fired one by one, there is no need to keep track of updated timers.

  • manual-tests/input-starved-by-timers.html: Manual test that attempts to freeze browser by

creating of enough timers. It then keeps UI frozen and after 10 seconds starts to drain the timers
so the browser un-freezes. This is instead of a regular layout test because we don't have a way
to inject an input events via regular run loop in DRT - instead they are directly dispatched by
eventSender, which does not reproduce the UI freeze that happens with real input.

20:47 Changeset [48085] by andersca@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7201063>

Reviewed by Adele Peterson.

Detach any custom scrollbars before detaching the document.

  • page/Frame.cpp:

(WebCore::Frame::setView):

19:19 Changeset [48084] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix

19:07 Changeset [48083] by oliver@apple.com
  • 6 edits in trunk

ToString? conversion should use the actual toString function for String objects.

Reviewed by Gavin Barraclough.

Remove incorrect specialisations of toString conversions on StringObject.

18:13 Changeset [48082] by laszlo.1.gombos@nokia.com
  • 5 edits in trunk/WebCore

Unreviewed, build fix.

Remove remaining references to UserStyleSheetLoader after r48075.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • page/qt/FrameQt.cpp:
  • page/wince/FrameWince.cpp:
17:35 Changeset [48081] by eric@webkit.org
  • 7 edits in trunk

2009-09-04 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=28988
Minor fix: "novalidate" attribute renamed in "noValidate", according to
HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#dom-fs-novalidate

  • fast/forms/novalidate-attribute-expected.txt:
  • fast/forms/resources/novalidate-attribute.js:

2009-09-04 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=28988
Minor fix: "novalidate" attribute renamed in "noValidate", according to
HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#dom-fs-novalidate

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::noValidate): (WebCore::HTMLFormElement::setNoValidate):
  • html/HTMLFormElement.h:
  • html/HTMLFormElement.idl:
17:18 Changeset [48080] by dimich@chromium.org
  • 2 edits in trunk/WebCore

Remove unused line of code from WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=28990

Reviewed by David Levin.

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::importScripts):

17:03 Changeset [48079] by darin@apple.com
  • 2 edits in trunk/WebCore

Fix assertion seen when running buildbot.

Patch by Darin Adler <darin@apple.com> on 2009-09-04
Reviewed by Oliver Hunt.

  • bindings/js/JSDOMBinding.h:

(WebCore::DOMObjectWithGlobalPointer::createStructure): Create the structure without
the HasDefaultMark bit since this has a custom mark function.

15:27 Changeset [48078] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Fix expected test output.

  • fast/dom/DOMImplementation/detached-doctype-expected.txt:
14:54 Changeset [48077] by sfalken@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Add new export.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Add new export.
14:45 Changeset [48076] by sfalken@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove unneeded export.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Remove unneeded export.
14:33 Changeset [48075] by hyatt@apple.com
  • 11 edits
    2 deletes in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28984, remove the remote stylesheet loader on Mac/Qt.
Make sure the other code path (now used by everybody) can handle data URLs.

Reviewed by Adam Roben.

As per the post on webkit-dev, the ability to work remotely isn't working properly anyway (it doesn't
hold up the pending sheet count, so you'd just FOUC on every Web page), and it's extremely unlikely
that anybody is relying on this support.

Tor Arne agreed it was ok to disable (he enabled it on the Qt side), and only Mac/Qt were using this
code.

  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::userStyleSheet):

  • dom/Document.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::begin):

  • loader/UserStyleSheetLoader.cpp: Removed.
  • loader/UserStyleSheetLoader.h: Removed.
  • page/Frame.cpp:

(WebCore::Frame::reapplyStyles):

  • page/Frame.h:
  • page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):
(WebCore::Page::userStyleSheet):

  • page/mac/FrameMac.mm:
  • page/qt/FrameQt.cpp:
14:11 Changeset [48074] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-09-04 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Add "sampling profiler" preference, simplify data display when it's set.

https://bugs.webkit.org/show_bug.cgi?id=28969

  • inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds): (WebInspector.ProfileDataGridNode.prototype.get data):
  • inspector/front-end/ProfileView.js: (WebInspector.ProfileView):
  • inspector/front-end/inspector.js:
13:55 Changeset [48073] by hyatt@apple.com
  • 1 edit in trunk/WebCore/page/Frame.cpp

Remove bogus assert that is affecting layout tests.

13:40 Changeset [48072] by jianli@chromium.org
  • 10 edits in trunk/WebCore

[V8] Run-time exception in onmessage handler is not forwarded to the worker object.
https://bugs.webkit.org/show_bug.cgi?id=28980

Reviewed by Adam Barth.

Tested by worker-close.html.

  • bindings/v8/ScriptFunctionCall.cpp:
  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::invokeEventHandler):

  • bindings/v8/V8Utilities.cpp:

(WebCore::getScriptExecutionContext):
(WebCore::reportException):

  • bindings/v8/V8Utilities.h:

(WebCore::getScriptExecutionContext):

  • bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • bindings/v8/custom/V8SharedWorkerCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

12:53 Changeset [48071] by hyatt@apple.com
  • 3 edits in trunk/WebCore

Remove unused m_sheet variable and setCSSStyleSheet methods.

Reviewed by Anders Carlsson.

  • dom/Document.cpp:
  • dom/Document.h:
12:39 MathML Goals edited by alex@milowski.com
(diff)
12:31 Changeset [48070] by andersca@apple.com
  • 4 edits in trunk/WebCore

(Based on a patch from Adele).

Reviewed by David Hyatt and Adele Peterson.

Fix <rdar://problem/7185875>.

  • page/Frame.cpp:

(WebCore::Frame::setView):
Detach any custom scroll bars from the old view.

  • page/FrameView.cpp:

(WebCore::FrameView::detachCustomScrollbars):
Simplify the check (and make it work when body is null) by just checking that the scroll bar owner is
not a RenderPart object.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::destroy):
ASSERT that frame() is not null here and also add a null check so that release builds won't crash.

12:09 Changeset [48069] by hyatt@apple.com
  • 4 edits in trunk/WebCore

Make m_userStyleSheetLoader in Frame an OwnPtr.

Reviewed by Adam Roben.

  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::~Frame):

  • page/Frame.h:
  • page/mac/FrameMac.mm:

(WebCore::Frame::setUserStyleSheetLocation):
(WebCore::Frame::setUserStyleSheet):

12:05 MathML Goals created by alex@milowski.com
12:03 Changeset [48068] by darin@apple.com
  • 10 edits in trunk/JavaScriptCore

DateInstance object collected on ARM JIT (JSValue: WTF_USE_JSVALUE32)
https://bugs.webkit.org/show_bug.cgi?id=28909

Patch by Darin Adler <darin@apple.com> on 2009-09-04
Reviewed by Geoff Garen.

Part two.

Make some improvements to garbage collection code:

1) Create a runtime assertion that catches any classes that

override markChildren but have the HasDefaultMark bit set.

2) Remove checks of the mark bit outside the MarkStack::append

function; they are redundant.

3) Improve the efficiency of the asObject and asArray functions

when called on JSCell* to avoid a round trip to JSValue.

4) Make more callers use the checked asCell and asObject

casting functions rather than unchecked casts.

5) Removed the JSCell::marked function and other GC-related

functions because these operations are no longer things that
code other than the core GC code needs to do directly. Fixed
callers that were calling them.

  • runtime/Collector.cpp:

(JSC::Heap::markConservatively): Removed unneeded call to MarkStack::drain.
(JSC::Heap::markProtectedObjects): Removed unneeded check of the mark
bit and call to MarkStack::drain.
(JSC::Heap::collect): Removed unneeded checks of the mark bit and also
changed call to SmallStrings::mark to call markChildren instead to match
the rest of the objects.
(JSC::typeName): Removed unneeded cast to JSObject*.

  • runtime/JSArray.h:

(JSC::asArray): Added an overload for JSCell* and changed the JSValue
version to call it. Removed some unneeded casts.
(JSC::JSArray::markChildrenDirect): Marked this function inline. It's in
a header, and if not marked inline this could lead to linking problems.
(JSC::MarkStack::markChildren): Added. This helper function is used by
the drain function to avoid repating code. Also added the code here to
check fro default mark violations in debug code. If a markChildren
function adds something to the mark stack, but the type info claimed
hasDefaultMark was true, then we will get an assertion now. Also fixed
the assertion about the mark bit to use the Heap function directly
because we don't have a JSCell::marked function any more.
(JSC::MarkStack::drain): Changed a local variable from "v" to "value",
and from "currentCell" to "cell". Changed to call markChildren in two
places instead of repeating a chain of if statements twice. Changed
code that reads and writes the mark bit to use Heap::isCellMarked and
Heap::markCell so we can eliminate the JSCell::marked and
JSCell::markCellDirect functions.

  • runtime/JSCell.h: Removed JSCell's markCellDirect and marked member

functions. Added a comment explaining that asCell should be deprecated
in favor of the JSValue asCell member function.
(JSC::MarkStack::append): Added the assertion that catches callers
that have set the HasDefaultMark bit incorrectly. Changed
code that reads and writes the mark bit to use Heap::isCellMarked and
Heap::markCell so we can eliminate the JSCell::marked and
JSCell::markCellDirect functions. Moved the overload of
MarkStack::append for JSValue here so it can call through to the cell
version. The old version had a copy of all the code instead, but that
repeated the conversion from JSValue to JSCell* and the check for
whether a value is a cell multiple times.
(JSC::Structure::markAggregate): Moved this function here to avoid
dependencies for Structure.h, since this calls MarkStack::append.

  • runtime/JSObject.cpp:

(JSC::JSObject::markChildren): Added code to clear
m_isCheckingForDefaultMarkViolation so the marking done by JSObject
doesn't trigger the assertion.

  • runtime/JSValue.h: Moved some stray includes that were outside the

header guard inside it. Not sure how that happened! Removed the
GC-related member functions markChildren, hasChildren, marked, and
markDirect.

  • runtime/JSWrapperObject.h: Made markChildren private.

(JSC::JSWrapperObject::createStructure): Added. Fixes a bug where the
HasDefaultMark bit was set.

  • runtime/MarkStack.h: Added m_isCheckingForDefaultMarkViolation and

initialized it to false. Moved the append function body from here to
JSCell.h. Added a declaration of a private markChildren function used
inside the drain function.

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::markChildren): Changed the name and style of this
function to match other functions. This allows us to share the normal
mark stack code path.

  • runtime/SmallStrings.h: Changed the name and interface of mark to

the more-normal markChildren style.

  • runtime/Structure.h: Moved the body of markAggregate into the

JSCell.h to avoid a circular dependency with JSCell.h.

11:53 Changeset [48067] by darin@apple.com
  • 13 edits in trunk

JavaScriptCore: DateInstance object collected on ARM JIT (JSValue: WTF_USE_JSVALUE32)
https://bugs.webkit.org/show_bug.cgi?id=28909

Patch by Darin Adler <darin@apple.com> on 2009-09-04
Reviewed by Geoff Garen.

Part one.

Make some improvements to garbage collection code:

1) Fix the two classes that had the default mark bit set but

should not.

2) Remove checks of the mark bit outside the MarkStack::append

function; they are redundant.

3) Make more callers use the checked asCell and asObject

casting functions rather than unchecked casts.

4) Removed some GC-related functions because these operations are

no longer things that code other than the core GC code needs
to do directly. Fixed callers that were calling them.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::markAggregate): Removed unneeded check of the mark
bit before calling MarkStack::append.

  • interpreter/Register.h: Removed unneeded marked and markChildren

functions.

  • jit/JITStubs.cpp:

(op_eq): Removed unneeded assertions, instead using checked casting
functions such as asObject.

  • runtime/ArgList.h: Added now-needed forward declaration of MarkStack.
  • runtime/GetterSetter.cpp:

(JSC::GetterSetter::markChildren): Remmoved unneeded check of the mark bit.

  • runtime/GlobalEvalFunction.h:

(JSC::GlobalEvalFunction::createStructure): Added. Fixes a bug where the
HasDefaultMark bit was set.

  • runtime/JSCell.cpp:

(JSC::JSCell::getObject): Use asObject to avoid a direct static_cast.

  • runtime/JSObject.h:

(JSC::asObject): Added an overload for JSCell* and changed the JSValue
version to call it.
(JSC::JSValue::get): Use asObject to avoid a direct static_cast.

  • runtime/JSValue.h: Moved some stray includes that were outside the

header guard inside it. Not sure how that happened! Removed the
GC-related member functions markChildren, hasChildren, marked, and
markDirect.

  • runtime/JSWrapperObject.h: Made markChildren private.

(JSC::JSWrapperObject::createStructure): Added. Fixes a bug where the
HasDefaultMark bit was set. Later we may want to optimize this for
wrapper types that never have cells in their internal values, but there
is no measured performance regression in SunSpider or V8 doing this
all the time.

  • runtime/MarkStack.cpp: Tweaked formatting.

JavaScriptGlue: * JSValueWrapper.cpp:
(JSValueWrapper::JSObjectMark): Removed a check of the mark
bit. It's OK to do more work in this case, and there is no
longer a public function to access the mark bit.

Reviewed by Geoff Garen.

11:35 WikiStart edited by alex@milowski.com
(diff)
11:34 WikiStart edited by alex@milowski.com
added MathML section (diff)
11:22 Changeset [48066] by kevino@webkit.org
  • 4 edits in trunk

wx build fix. Switch USE_ defines over to the compiler so that they can be
checked by files not including config.h (like WebCorePrefix.h).

11:07 Changeset [48065] by timothy@apple.com
  • 3 edits in trunk/WebCore

Show color swatches in the Web Inspector before the color text so clicking them will not
shift the swatch. Also makes multiple swatches in the single property toggle the color format.

https://bugs.webkit.org/show_bug.cgi?id=28978

Reviewed by Darin Adler.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.updateTitle): Some refactoring to consolidate
the processing we do on the property value. This eliminated the old nickname code, since the new
WebInspector.Color class handles this. We could also simplify the color regex since more
is handled by the Color class. Also no longer uses innerHTML for the linkify code.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processValue): Helper function to
process a value given a regex and processor functions.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): Make an anchor for the
URL with "url()" syntax surrounding it.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor): Makes a color, if
there was an exception just return a text node.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay.changeTo):
Moved from later in the file.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay): Ditto.

  • inspector/front-end/inspector.css:
10:59 Changeset [48064] by dglazkov@chromium.org
  • 13 edits in trunk

WebCore:

2009-09-04 Mark Mentovai <mark@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=28614

Account for scrollbar state changes that occur during layout.

  • platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):

Perform a layout prior to checking whether the scrollbar modes are
off, on, or automatic. The modes may change during layout.

  • WebCore.base.exp:
  • WebCore.order:
  • page/Frame.cpp: (WebCore::Frame::createView):
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::layout):
  • page/FrameView.h:
  • platform/ScrollView.h:

Eliminate duplicated (and incorrect) scrollbar mode tracking between
FrameView and ScrollView.

WebKit/mac:

2009-09-04 Mark Mentovai <mark@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=28614

Account for scrollbar state changes that occur during layout.

  • WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView updateScrollers]):

Perform a layout prior to checking whether the scrollbar modes are
off, on, or automatic. The modes may change during layout.

  • WebView/WebFrameView.mm: (-[WebFrameView _install]):

Eliminate duplicated (and incorrect) scrollbar mode tracking between
FrameView and ScrollView.

WebKit/qt:

2009-09-04 Mark Mentovai <mark@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=28614

Account for scrollbar state changes that occur during layout.

  • Api/qwebframe.cpp: (QWebFrame::setScrollBarPolicy):

Eliminate duplicated (and incorrect) scrollbar mode tracking between
FrameView and ScrollView.

10:53 Changeset [48063] by yael.aharon@nokia.com
  • 5 edits
    2 adds in trunk

WebCore: hostname and host are mixed up when manipulating anchor elements.
https://bugs.webkit.org/show_bug.cgi?id=28954

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-04
Reviewed by Darin Adler.

Swapped the implementation of host and hostname, and made sure not to return
the port number if it is default for the given protocol.
FireFox also avoids returning the protocol number if it is default.

Test: fast/dom/Element/hostname-host.html

10:19 Changeset [48062] by andersca@apple.com
  • 4 edits in trunk/WebCore

Fix <rdar://problem/7192902>.

Reviewed by Darin Adler and Steve Falkenburg.

Add the necessary plumbing for having QTMovieWin use WebCore timers.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:

(WebCore::TaskTimer::initialize):
Create the timer and call QTMovieWin::setTaskTimerFuncs.

(WebCore::TaskTimer::setTaskTimerDelay):
Start the timer.

(WebCore::TaskTimer::stopTaskTimer):
Stop the timer.

(WebCore::TaskTimer::fired):
Call QTMovieWin::taskTimerFired().

(WebCore::MediaPlayerPrivate::load):
Initialize the Task timer.

  • platform/graphics/win/QTMovieWin.cpp:

(updateTaskTimer):
Call the global stopTaskTimer function and setTaskTimerDelay.

(QTMovieWin::taskTimerFired):
Make this a member function.

(QTMovieWin::setTaskTimerFuncs):
Set the global function pointers.

(QTMovieWin::initializeQuickTime):
(DllMain):
No need to use the QT shared timer.

  • platform/graphics/win/QTMovieWin.h:
10:08 Changeset [48061] by levin@chromium.org
  • 2 edits in trunk/WebCore

Fix Chromium Win compile. Missing return statement in
WebCore::RenderThemeChromiumSkia::paintSliderThumb.
https://bugs.webkit.org/show_bug.cgi?id=28974

Patch by Tony Chang <tony@chromium.org> on 2009-09-04
Reviewed by David Levin.

No new tests, build fix.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintSliderThumb):

10:07 Changeset [48060] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Make WebView function without a parent window

When WebView has no parent window, it becomes a message-only window,
which hides it from the screen and prevents it from appearing on the
taskbar.

Fixes <http://webkit.org/b/28971> <rdar://problem/4976998>
WebView::initWithFrame fails if there's no host window

Reviewed by Dave Hyatt.

  • WebView.cpp:

(WebView::initWithFrame): m_hostWindow is null, use HWND_MESSAGE as
our parent window, which will make us a message-only window.
(WebView::setHostWindow): If he new host window is null, use
HWND_MESSAGE as our parent window, which will make us a message-only
window.

10:06 Changeset [48059] by dglazkov@chromium.org
  • 7 edits
    3 deletes in trunk

2009-09-04 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[Chromium] Rolling out http://trac.webkit.org/changeset/48035, because it broke
the build.
https://bugs.webkit.org/show_bug.cgi?id=28696

10:02 Changeset [48058] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix vcproj file.

  • WebCore.vcproj/WebCore.vcproj:
10:01 Changeset [48057] by hyatt@apple.com
  • 29 edits
    6 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.

Reviewed by Adam Roben.

This patch adds new API for adding and removing user scripts from page groups. User scripts
are bundled together in isolated worlds (you can have multiple scripts together in the same
world).

Added userscripts/ directory for holding new tests (along with a simple test of script injection).

  • WebCore.base.exp:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInIsolatedWorld):

  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::evaluateInIsolatedWorld):

  • bindings/v8/ScriptController.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::dispatchDocumentElementAvailable):

  • page/Frame.cpp:

(WebCore::Frame::injectUserScripts):
(WebCore::Frame::injectUserScriptsForWorld):

  • page/Frame.h:
  • page/PageGroup.cpp:

(WebCore::PageGroup::~PageGroup):
(WebCore::PageGroup::addUserScript):
(WebCore::PageGroup::removeUserContentForWorld):
(WebCore::PageGroup::removeAllUserContent):

  • page/PageGroup.h:

(WebCore::PageGroup::userScripts):

  • page/UserScript.h: Added.

(WebCore::UserScript::UserScript):
(WebCore::UserScript::source):
(WebCore::UserScript::url):
(WebCore::UserScript::patterns):
(WebCore::UserScript::worldID):
(WebCore::UserScript::injectionTime):

  • page/UserScriptTypes.h: Added.

(WebCore::):

WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.

Reviewed by Adam Roben.

This patch adds new API for adding and removing user scripts from page groups. User scripts
are bundled together in isolated worlds (you can have multiple scripts together in the same
world).

Added userscripts/ directory for holding new tests (along with a simple test of script injection).

  • WebView/WebView.mm:

(+[WebView _addUserScriptToGroup:source:url:worldID:patterns:injectionTime:]):
(+[WebView _removeUserContentFromGroup:worldID:]):
(+[WebView _removeAllUserContentFromGroup:]):

  • WebView/WebViewPrivate.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.

Reviewed by Adam Roben.

This patch adds new API for adding and removing user scripts from page groups. User scripts
are bundled together in isolated worlds (you can have multiple scripts together in the same
world).

Added userscripts/ directory for holding new tests (along with a simple test of script injection).

  • platform/mac/userscripts: Added.
  • platform/mac/userscripts/script-run-at-end-expected.txt: Added.
  • userscripts: Added.
  • userscripts/script-run-at-end.html: Added.
09:42 Changeset [48056] by abarth@webkit.org
  • 1 edit in trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp

Added missing ;

09:34 Changeset [48055] by ap@apple.com
  • 4 edits
    2 adds in trunk

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26402
Crashes when using a detached DocumentType node

Test: fast/dom/DOMImplementation/detached-doctype.html

DocumentType nodes are the only one that can have null document(), and they can never have
children, so they are a degenerate case for NodeLists.

  • dom/Node.cpp: (WebCore::Node::childNodes): Don't try register node list with document if there's no document. Since there are no changes possible for a DocumentType's node list, this is not necessary. (WebCore::Node::registerDynamicNodeList): Ditto. (WebCore::Node::unregisterDynamicNodeList): Ditto. I couldn't find a scenario where this was invoked for a DocumentType node, but I also couldn't prove that it can't be (the de-registration code path that I saw taken was via Node destructor, and that already has a null check for document).
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): Bail out if there is no document (just as we already do if there is no window). (WebCore::JSNode::removeEventListener): Ditto.
09:34 Changeset [48054] by abarth@webkit.org
  • 2 edits in trunk/WebKit/win

2009-09-04 Adam Barth <abarth@webkit.org>

Unreviewed attempt at a build fix.

Added missing include.

  • WebCoreSupport/WebFrameLoaderClient.cpp:
09:23 Changeset [48053] by abarth@webkit.org
  • 5 edits in trunk

2009-09-04 Adam Barth <abarth@webkit.org>

Unreviewed attempt at a build fix.

Fix typo of IWebFrameLoadDelegatePrivate2 and make
IWebFrameLoadDelegatePrivate inherit from IWebFrameLoadDelegatePrivate
as requestd by Adam Roben.

  • Interfaces/IWebFrameLoadDelegatePrivate2.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):

2009-09-04 Adam Barth <abarth@webkit.org>

Unreviewed build fix.

Update declaration of FrameLoadDelegate to reflect that
IWebFrameLoadDelegatePrivate2 inherits from
IWebFrameLoadDelegatePrivate.

  • DumpRenderTree/win/FrameLoadDelegate.h:
08:53 Changeset [48052] by vestbo@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Fix brainfart in r48050, tests should have paths

Rubber-stamped by Simon Hausmann.

  • platform/qt/Skipped:
08:49 Changeset [48051] by abarth@webkit.org
  • 13 edits
    2 adds in trunk

2009-09-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24696

Plumb mixed content notifications to WebFrameLoadDelegatePrivate.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebFrameLoadDelegatePrivate.h: Added.

2009-09-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24696

Plumb mixed content notifications to IWebFrameLoadDelegatePrivate.

  • Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added.
  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
  • WebKit.vcproj/Interfaces.vcproj:

2009-09-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24696

Add testing instrumentation for mixed content.

  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:]): (-[FrameLoadDelegate webView:didRunInsecureContent:]):
  • DumpRenderTree/win/FrameLoadDelegate.cpp: (descriptionSuitableForTestResult): (FrameLoadDelegate::QueryInterface): (FrameLoadDelegate::didDisplayInsecureContent): (FrameLoadDelegate::didRunInsecureContent):
  • DumpRenderTree/win/FrameLoadDelegate.h:
08:34 Changeset [48050] by vestbo@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip tests failing due to missing DRT features

Rubber-stamped by Simon Hausmann.

  • platform/qt/Skipped:
07:04 Changeset [48049] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-09-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] loadFinished never emitted
https://bugs.webkit.org/show_bug.cgi?id=28935

Do not report errors right away from
ResourceHandle::start. Instead return true and schedule an error
to be reported in the handle later. Otherwise WebCore gets
confused and thinks the resource never finished loading, making it
not emit the finished status.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp): (WebCore::):
07:00 Changeset [48048] by yong.li@torchmobile.com
  • 2 edits in trunk/JavaScriptCore

2009-09-03 Yong Li <yong.li@torchmobile.com>

Reviewed by David Levin.

Remove unnecessary dependency on unistd.h
https://bugs.webkit.org/show_bug.cgi?id=28962

  • runtime/Completion.cpp:
03:28 Changeset [48047] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-04 Ben Murdoch <benm@google.com>

Reviewed by Eric Seidel.

[V8] DOM Storage bindings: Event Handler should create StorageEvents
https://bugs.webkit.org/show_bug.cgi?id=28942

Tests:
Causes the following tests that were failing with V8 to pass:

  • storage/domstorage/localstorage/onstorage-attribute-setwindow.html
  • storage/domstorage/localstorage/complex-keys.html
  • storage/domstorage/localstorage/onstorage-attribute-markup.html
  • storage/domstorage/localstorage/simple-events.html
  • storage/domstorage/localstorage/onstorage-attribute-set-attribute.html
  • storage/domstorage/localstorage/index-get-and-set.html
  • storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html
  • storage/domstorage/sessionstorage/onstorage-attribute-markup.html
  • storage/domstorage/sessionstorage/simple-events.html
  • storage/domstorage/sessionstorage/onstorage-attribute-set-attribute.html
  • storage/domstorage/sessionstorage/index-get-and-set.html

Code changes:

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object): Create StorageEvents.
  • bindings/v8/custom/V8StorageCustom.cpp: (WebCore::storageGetter): Check if we are retrieving the length property and return the number of items in the object rather than a property named length when invoking the getItem() member of local/sessionStorage.
02:04 Changeset [48046] by pfeldman@chromium.org
  • 19 edits
    1 add in trunk/WebCore

2009-09-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=28911

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._formatarray): (WebInspector.ConsoleView.prototype._formatnode):
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch):
  • inspector/front-end/InjectedScript.js: (InjectedScript.dispatch):
  • inspector/front-end/InjectedScriptAccess.js: Added. (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName): (InjectedScriptAccess._installHandler):
  • inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.html:
01:47 Changeset [48045] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-09-04 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Implement <input type="range"> for Chromium Linux by painting
the slider and the thumb using skia.
https://bugs.webkit.org/show_bug.cgi?id=28928

Covered by existing tests (we're currently hitting an assert for them).

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
  • rendering/RenderThemeChromiumLinux.h:
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::drawVertLine): (WebCore::drawHorizLine): (WebCore::drawBox): (WebCore::RenderThemeChromiumSkia::paintSliderTrack): (WebCore::RenderThemeChromiumSkia::paintSliderThumb):
  • rendering/RenderThemeChromiumSkia.h:
01:40 Changeset [48044] by eric@webkit.org
  • 3 edits in trunk

2009-09-04 Albert Bachand <albertb@google.com>

Reviewed by Eric Seidel.

Modify the condition regarding the key modifier for opening combo
boxes under GTK from just PLATFORM(GTK) to also look for
(PLATFORM(CHROMIUM) && PLATFORM(LINUX)).

  • WebCore/dom/SelectElement.cpp:
  • WebCore/manual-tests/select-popup-on-spacebar.html:
01:32 Changeset [48043] by eric@webkit.org
  • 6 edits
    6 adds in trunk

2009-09-04 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Tests for <input type=color> validation.
https://bugs.webkit.org/show_bug.cgi?id=28966

  • fast/forms/ValidityState-patternMismatch-unsupported-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-unsupported.html: Added.
  • fast/forms/ValidityState-typeMismatch-color-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-color.html: Added.
  • fast/forms/resources/ValidityState-patternMismatch-unsupported.js: Added.
  • fast/forms/resources/ValidityState-typeMismatch-color.js: Added.

2009-09-04 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Tests: fast/forms/ValidityState-patternMismatch-unsupported.html

fast/forms/ValidityState-typeMismatch-color.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueMissing): (WebCore::HTMLInputElement::patternMismatch): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::formControlType): (WebCore::HTMLInputElement::saveFormControlState): (WebCore::HTMLInputElement::restoreFormControlState): (WebCore::HTMLInputElement::accessKeyAction): (WebCore::HTMLInputElement::rendererIsNeeded): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::appendFormData): (WebCore::HTMLInputElement::valueWithDefault): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::isRequiredFormControl): (WebCore::HTMLInputElement::dataList):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::): (WebCore::HTMLInputElement::isTextField):
  • html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch): (WebCore::ValidityState::isValidColorString):
  • html/ValidityState.h:
01:07 Changeset [48042] by levin@chromium.org
  • 2 edits in trunk/WebCore

[V8] Crash when updating document cache
https://bugs.webkit.org/show_bug.cgi?id=28965

Patch by Mads Ager <ager@chromium.org> on 2009-09-04
Reviewed by David Levin.

Initialization of a V8 JavaScript context can fail. When that
happens, do not attempt to update the document wrapper cache.

This code path is exercised by http/tests/security/javascriptURL/javascriptURL-in-new-iframe.html.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::updateDocument):

00:50 Changeset [48041] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-09-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Fix tst_QWebPage::database autotest failure
https://bugs.webkit.org/show_bug.cgi?id=28961

Make sure that the test case enables the feature before
the feature gets tested

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::database):
00:15 Changeset [48040] by eric@webkit.org
  • 5 edits in trunk

2009-09-04 Yaar Schnitman <yaar@chromium.org>

Reviewed by Eric Seidel.

Two bugs:

https://bugs.webkit.org/show_bug.cgi?id=25489
CSS property background-position is now serialized in shorthand string as
background-position-x background-position-y, as the specification requires
(See http://www.w3.org/TR/2008/WD-css3-background-20080910/#the-background-position).

https://bugs.webkit.org/show_bug.cgi?id=26541
CSS background-color is now be serialized before other background properties,
as CSS specification requires (See http://dev.w3.org/csswg/cssom/#css-value).

An existing layout test that accepted wrong order and skipped position test
had to be modified.

  • fast/dom/background-shorthand-csstext-expected.txt:
  • fast/dom/background-shorthand-csstext.html:

2009-09-04 Yaar Schnitman <yaar@chromium.org>

Reviewed by Eric Seidel.

Two bugs:

https://bugs.webkit.org/show_bug.cgi?id=25489
CSS property background-position is now serialized in shorthand string as
background-position-x background-position-y, as the specification requires
(See http://www.w3.org/TR/2008/WD-css3-background-20080910/#the-background-position).

https://bugs.webkit.org/show_bug.cgi?id=26541
CSS background-color is now be serialized before other background properties,
as CSS specification requires (See http://dev.w3.org/csswg/cssom/#css-value).

An existing layout test that accepted wrong order and skipped position test
had to be modified.

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
00:07 Changeset [48039] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-09-04 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by Eric Seidel.

Any QtWebKit application crashes on exit if the inspector is
used during the session rather then exiting.

If a QWebView has a QWebPage that is destroyed the QWebView
does not update its pointer and will crash the next time
it access the page pointers (such as in its destructor).

InspectorClientView should not call deleteLater when the page
is destroyed because it does not have a parent and is a top
level widget. close() needs to be called so that QApplication
can exit the application if quitOnLastWindowClosed is set
and a InspectorClientView is the last window, otherwise
the application will never exit.

  • Api/qwebview.cpp: (QWebViewPrivate::_q_pageDestroyed): (QWebView::setPage):
  • Api/qwebview.h:
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientView::InspectorClientView):

09/03/09:

22:24 Changeset [48038] by eric@webkit.org
  • 4 edits
    3 adds in trunk

2009-09-03 Kent Tamura <tkent@chromium.org>

Reviewed by David Levin.

Test for HTMLTextAreaElement.textLength
https://bugs.webkit.org/show_bug.cgi?id=28929

  • fast/forms/resources/textarea-textlength.js: Added.
  • fast/forms/textarea-textlength-expected.txt: Added.
  • fast/forms/textarea-textlength.html: Added.

2009-09-03 Kent Tamura <tkent@chromium.org>

Reviewed by David Levin.

Add support for HTMLTextAreaElement.textLength
https://bugs.webkit.org/show_bug.cgi?id=28929

Test: fast/forms/textarea-textlength.html

  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::textLength):
  • html/HTMLTextAreaElement.idl:
17:27 Changeset [48037] by ap@apple.com
  • 3 edits
    3 adds in trunk

Reviewed by Darin Adler.

<rdar://problem/7180197>, https://bugs.webkit.org/show_bug.cgi?id=28822
REGRESSION(r31231): Creating document with current document's DOCTYPE causes crashes

Test: fast/dom/DOMImplementation/createDocument-with-used-doctype.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Even though we cannot raise an exception immediately out of fear of breaking Acid3, we shouldn't use a DocumentType node in two documents.
16:57 Changeset [48036] by beidson@apple.com
  • 3 edits
    9 adds in trunk

WebCore: Page Cache should support pages with Frames.
https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Sam Weinig.

Tests: fast/events/pageshow-pagehide-on-back-cached-with-frames.html

fast/loader/frames-with-unload-handlers-in-page-cache.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):

LayoutTests: Page Cache should support pages with Frames.
https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Sam Weinig.

  • fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt: Added.
  • fast/events/pageshow-pagehide-on-back-cached-with-frames.html: Added.
  • fast/events/resources/pageshow-pagehide-subframe-cachable.html: Added.
  • fast/events/resources/pageshow-pagehide-subsubframe-cachable.html: Added.
  • fast/loader/frames-with-unload-handlers-in-page-cache-expected.txt: Added.
  • fast/loader/frames-with-unload-handlers-in-page-cache.html: Added.
  • fast/loader/resources/notify-done.html: Added.
  • fast/loader/resources/subframe-with-subsubframe-with-unload-handler.html: Added.
  • fast/loader/resources/subframe-with-unload-handler.html: Added.
16:23 Changeset [48035] by eric@webkit.org
  • 7 edits
    5 adds in trunk

2009-09-03 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by Eric Seidel.

Check that middle click triggers an onpaste event in Linux.
https://bugs.webkit.org/show_bug.cgi?id=28696

  • platform/gtk/editing/pasteboard: Added.
  • platform/gtk/editing/pasteboard/middle-click-onpaste-expected.txt: Added.
  • platform/gtk/editing/pasteboard/resources: Added.
  • platform/gtk/editing/pasteboard/resources/TEMPLATE.html: Added.
  • platform/gtk/editing/pasteboard/resources/middle-click-onpaste.js: Added. (handlePaste):

2009-09-03 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by Eric Seidel.

Handle middle click in Chromium like QT
https://bugs.webkit.org/show_bug.cgi?id=28696

Tested by middle-click-onpaste.html.

  • platform/Pasteboard.h:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::getData):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::isSelectionMode): (WebCore::Pasteboard::setSelectionMode): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
  • platform/chromium/PasteboardPrivate.h: (WebCore::PasteboardPrivate::):
16:10 Changeset [48034] by beidson@apple.com
  • 2 edits in trunk/WebCore

More partial work towards "Page Cache should support pages with Frames"
https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Sam Weinig.

Fix a bug where subframes weren't asked if they were cacheable.

No new tests, especially since page caching for frames isn't turned on yet.
A layout test will come in my next patch, which enables frames in the page cache.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::canCachePageContainingThisFrame):

16:08 Changeset [48033] by abarth@webkit.org
  • 2 edits in trunk/WebKit/mac

2009-09-03 Adam Barth <abarth@webkit.org>

Unreviewed build fix.

Change notImplemented() to a FIXME.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
15:59 Changeset [48032] by abarth@webkit.org
  • 18 edits in trunk

2009-09-03 Adam Barth <abarth@webkit.org>

Reviewed by eric@webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=24696

Added mixed content methods to FrameLoaderClient.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didDisplayInsecureContent): (WebCore::EmptyFrameLoaderClient::didRunInsecureContent):
  • loader/FrameLoaderClient.h:

2009-09-03 Adam Barth <abarth@webkit.org>

Reviewed by eric@webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=24696

Stub implementations of mixed content methods of FrameLoaderClient.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didDisplayInsecureContent): (WebKit::FrameLoaderClient::didRunInsecureContent):
  • WebCoreSupport/FrameLoaderClientGtk.h:

2009-09-03 Adam Barth <abarth@webkit.org>

Reviewed by eric@webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=24696

Stub implementations of mixed content methods of FrameLoaderClient.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):

2009-09-03 Adam Barth <abarth@webkit.org>

Reviewed by eric@webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=24696

Stub implementations of mixed content methods of FrameLoaderClient.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didDisplayInsecureContent): (WebCore::FrameLoaderClientQt::didRunInsecureContent):
  • WebCoreSupport/FrameLoaderClientQt.h:

2009-09-03 Adam Barth <abarth@webkit.org>

Reviewed by eric@webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=24696

Stub implementations of mixed content methods of FrameLoaderClient.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
  • WebCoreSupport/WebFrameLoaderClient.h:

2009-09-03 Adam Barth <abarth@webkit.org>

Reviewed by eric@webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=24696

Stub implementations of mixed content methods of FrameLoaderClient.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::didDisplayInsecureContent): (WebCore::FrameLoaderClientWx::didRunInsecureContent):
  • WebKitSupport/FrameLoaderClientWx.h:
14:37 Changeset [48031] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-09-03 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Access private member variables directly instead of using the
accessor.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame): (WebKit::FrameLoaderClient::windowObjectCleared):
13:25 Changeset [48030] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Exception.toString() on Qt seems to print out a different value than other platforms.
https://bugs.webkit.org/show_bug.cgi?id=28952

Reviewed by Dave Levin.

  • platform/qt/Skipped:

Disabled new worker tests that rely on the string format of DOM exceptions until bug #28952 is resolved.

12:38 Changeset [48029] by kevino@webkit.org
  • 19 edits
    6 adds in trunk

Reviewed by Kevin Ollivier.

[wx] Frames support
https://bugs.webkit.org/show_bug.cgi?id=19041

12:35 Changeset [48028] by yael.aharon@nokia.com
  • 3 edits in trunk/WebCore

[Qt] Page content is not displayed in case of HTTP status error
https://bugs.webkit.org/show_bug.cgi?id=28949

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-03
Reviewed by Simon Hausmann.

If the server sent content, show it to the user instead of an error,
even if the HTTP status code is not success.

  • platform/network/qt/QNetworkReplyHandler.cpp:
  • platform/network/qt/QNetworkReplyHandler.h:
12:07 Changeset [48027] by ddkilzer@apple.com
  • 4 edits in trunk/WebKitTools

<http://webkit.org/b/28880> svn-apply --force doesn't actually work

Reviewed by Eric Seidel.

This fixes "svn-apply --force" and adds unit tests for the
scm.apply_patch() method which uses this script.

  • Scripts/svn-apply: Created $globalExitCode variable that defaults to 0. Exit with a value of $globalExitCode when the script is finished. (applyPatch): Ignore a non-zero $exitCode if $force is true, but set $globalExitCode to $exitCode so that svn-apply exits with a non-zero status if any patches did not apply cleanly. Also print out the actual patch command if $force was not true.
  • Scripts/modules/scm.py: (scripts_directory): Added. Extracted from script_path(). (script_path): Extracted scripts_directory().
  • Scripts/modules/scm_unittest.py: Import urllib. (SVNTestRepository.setup): Save the original working directory in test_object since this represents the WebKit repository from where the unit tests are run. (SCMTest): Created new super class to hold utility methods. (SCMTest._create_patch): Creates a patch file on disk and a dictionary for use with scm.svn_apply(). (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink back to WebKitTools/Scripts in the test repository so that scm.apply_patch() is able to find the svn-apply script. (SVNTest): Inherit from SCMTest instead of unittest.TestCase. (SVNTest.tearDown): Make sure to change directories back to the original_path before the next test. (SVNTest.test_apply_svn_patch): New test case for applying an svn patch with scm.apply_patch(). (SVNTest.test_apply_svn_patch_force): New test case for applying an svn patch with scm.apply_patch() that conflicts. (GitTest): Inherit from SCMTest instead of unittest.TestCase. (GitTest.tearDown): Make sure to change directories back to the original_path before the next test. (GitTest.test_apply_git_patch): New test case for applying a git patch with scm.apply_patch(). (GitTest.test_apply_git_patch_force): New test case for applying a git patch with scm.apply_patch() that conflicts.
11:36 Changeset [48026] by atwilson@chromium.org
  • 7 edits
    2 adds in trunk/WebCore

Need to update v8 bindings to support passing multiple ports to postMessage()
https://bugs.webkit.org/show_bug.cgi?id=28839

Reviewed by Dimitri Glazkov.

Added support for passing MessagePortArray to v8 bindings.

New tests that now pass with V8:

fast/events/message-port-multi.html
fast/workers/worker-context-multi-port.html
fast/workers/worker-multi-port.html

  • WebCore.gypi:

Added V8MessageEventCustom.cpp and V8MessagePortCustom.h

  • bindings/v8/custom/V8CustomBinding.h:

Added custom postMessage() handlers for various classes.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::DOMWindowPostMessage):
Added custom handler that supports MessagePortArray.

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::DedicatedWorkerContextPostMessage):
Added custom handler that supports MessagePortArray.

  • bindings/v8/custom/V8MessageEventCustom.cpp: Added.

(WebCore::MessageEventPorts):
Added getter for ports attribute.
(WebCore::MessageEventInitMessageEvent):
Added custom handler that supports MessagePortArray.

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::MessagePortPostMessage):
Added custom handler that supports MessagePortArray.
(WebCore::getMessagePortArray):
Added helper function that supports converting from a sequence-like object to a MessagePortArray.

  • bindings/v8/custom/V8MessagePortCustom.h: Added.

Added declaration for getMessagePortArray().

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::WorkerPostMessage):
Added custom handler that supports MessagePortArray.

11:36 Changeset [48025] by atwilson@chromium.org
  • 47 edits
    1 copy
    12 adds in trunk

WebCore: Need to update JS bindings and IDL files to support multiple message ports in postMessage()
https://bugs.webkit.org/show_bug.cgi?id=28460

Reviewed by Sam Weinig.

Added new toJSSequence() API which validates that a JSValue meets the WebIDL criteria for a sequence.

Tests: fast/events/message-port-multi.html

fast/workers/worker-context-multi-port.html
fast/workers/worker-multi-port.html

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

Added JSMessagePortCustom.h and JSMessageEventCustom.cpp.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::toJSSequence):
Added toJSSequence() API to do validation on sequence-like objects per WebIDL.

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArrays.

  • bindings/js/JSDedicatedWorkerContextCustom.cpp:

(WebCore::JSDedicatedWorkerContext::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArrays.

  • bindings/js/JSMessageEventCustom.cpp: Added.

(WebCore::JSMessageEvent::ports):
Added custom ports() getter that converts from MessagePortArray to JSArray.
(WebCore::JSMessageEvent::initMessageEvent):
Added support for passing a MessagePortArray.

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArray.
(WebCore::fillMessagePortArray):
New helper routine that validates/converts from a JS sequence o a WebCore::MessagePortArray.

  • bindings/js/JSMessagePortCustom.h: Added.
  • bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorker::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArray.

  • dom/MessageEvent.cpp:
  • dom/MessageEvent.h:

(WebCore::MessageEvent::ports):
Changed ports() to return a MessagePortArray* since this value can be null.

  • dom/MessageEvent.idl:

Updated IDL to match HTML5 spec (now accepts MessagePortArrays instead of a solitary MessagePort).

  • dom/MessagePort.cpp:
  • dom/MessagePort.h:
  • dom/MessagePort.idl:

Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).

  • workers/DedicatedWorkerContext.cpp:
  • workers/DedicatedWorkerContext.h:
  • workers/DedicatedWorkerContext.idl:

Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).

  • workers/Worker.cpp:
  • workers/Worker.h:
  • workers/Worker.idl:

Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).

LayoutTests: Need to update JS bindings and IDL files to support multiple message ports in postMessage()
https://bugs.webkit.org/show_bug.cgi?id=28460

Reviewed by Sam Weinig.

Updated layout tests to match new postMessage() and MessageEvent APIs.

Added new layout tests to test sending/receiving multiple ports.

  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/dom/Window/window-postmessage-args.html:

Updated to match new postMessage API.

  • fast/events/init-events-expected.txt:
  • fast/events/message-channel-gc-4.html:

Updated to match new postMessage API.

  • fast/events/message-port-clone.html:

Updated to match new postMessage API.

  • fast/events/message-port-deleted-document.html:

Updated to match new postMessage API.

  • fast/events/message-port-deleted-frame.html:

Updated to match new postMessage API.

  • fast/events/message-port-inactive-document.html:

Updated to match new postMessage API.

  • fast/events/message-port-multi-expected.txt: Added.
  • fast/events/message-port-multi.html: Added.

Added tests for various cases of sending multiple ports.

  • fast/events/message-port.html:

Updated to match new postMessage API.

  • fast/events/resources/init-events.js:

Added tests for sending ports to initMessageEvent()

  • fast/events/resources/message-port-iframe.html:
  • fast/events/resources/message-port-multi.js: Added.

Added tests for various cases of sending multiple ports.

  • fast/workers/resources/shared-worker-common.js:

(onconnect):
Updated to reflect new MessageEvent API.

  • fast/workers/resources/shared-worker-script-error.js:

(onconnect):
Updated to reflect new MessageEvent API.

  • fast/workers/resources/worker-cloneport.js:

(onmessage):
Updated to reflect new MessageEvent API.

  • fast/workers/resources/worker-context-multi-port.js: Added.

(worker.onmessage):
Added tests for various cases of sending multiple ports.

  • fast/workers/resources/worker-context-thread-multi-port.js: Added.

Added tests for various cases of sending multiple ports.

  • fast/workers/resources/worker-messageport.js:

(onmessage):
Updated to reflect new MessageEvent API.

  • fast/workers/resources/worker-multi-port.js: Added.

(worker.onmessage):
Added tests for various cases of sending multiple ports.

  • fast/workers/resources/worker-thread-multi-port.js: Added.

(onmessage):
Worker-thread side of multiple port layout test.
(testPassed):
(testFailed):

  • fast/workers/worker-cloneport.html:
  • fast/workers/worker-context-multi-port-expected.txt: Added.
  • fast/workers/worker-context-multi-port.html: Added.

Added tests for sending multiple ports from the worker thread.

  • fast/workers/worker-messageport-expected.txt:
  • fast/workers/worker-messageport-gc.html:
  • fast/workers/worker-messageport.html:
  • fast/workers/worker-multi-port-expected.txt: Added.
  • fast/workers/worker-multi-port.html: Added.
09:54 Changeset [48024] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-09-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Do not query non-function call frames for function name.

https://bugs.webkit.org/show_bug.cgi?id=28799

  • inspector/front-end/InjectedScript.js: (InjectedScript.CallFrameProxy): (InjectedScript.CallFrameProxy.prototype._wrapScopeChain):
09:52 Changeset [48023] by sullivan@apple.com
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt:

Brought this file up to date.

Reviewed by Adam Roben

09:51 Changeset [48022] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-09-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Crash after typing "clear" and pressing return in inspector console.

https://bugs.webkit.org/show_bug.cgi?id=28684

  • inspector/front-end/InjectedScript.js: (InjectedScript._clearConsoleMessages): (InjectedScript._inspectObject): (InjectedScript._ensureCommandLineAPIInstalled):
09:09 Changeset [48021] by vestbo@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip a couple of failing layout-tests

Rubber-stamped by Ariya Hidayat.

We skip most of the D&D tests already, and the animation test
seems to be flakey on our platform since the commit that triggered
it only touched V8 bindings.

  • platform/qt/Skipped:
06:56 Changeset [48020] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-03 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Squeezed out some performance from string conversion.
https://bugs.webkit.org/show_bug.cgi?id=28945

  • bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource): (WebCore::WebCoreStringResource::data): (WebCore::WebCoreStringResource::length): (WebCore::WebCoreStringResource::atomicString): (WebCore::WebCoreStringResource::string): Avoid calling virtual length method. Be more explicit with external memory computation. Avoid function calls in data and length. (WebCore::): (WebCore::v8StringToWebCoreString): (WebCore::v8StringToAtomicWebCoreString): (WebCore::v8NonStringValueToWebCoreString): (WebCore::v8NonStringValueToAtomicWebCoreString): Avoid extra calls of WebCoreStringResource::toString. When AtomicString is computed pass it immediately when constructing WebCoreStringResource. Use inline buffer for small strings.
  • bindings/v8/V8Binding.h: (WebCore::v8ValueToWebCoreString): (WebCore::v8ValueToAtomicWebCoreString): (WebCore::toString): Inline dispatch of string vs. non-string values.
06:49 Changeset [48019] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-03 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Inlined common case of V8IsolatedWorld::getEntered to speed
up V8Proxy lookup.
https://bugs.webkit.org/show_bug.cgi?id=28946

  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::getEnteredImpl):
  • bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::getEntered):
06:40 Changeset [48018] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-09-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Remove bogus asserts that break Debug builds at runtime.

  • WebCoreSupport/DocumentLoaderGtk.cpp: (WebKit::DocumentLoader::detachFromFrame): (WebKit::DocumentLoader::decreaseLoadCount):
05:57 Changeset [48017] by zoltan@webkit.org
  • 52 edits in trunk/LayoutTests

2009-09-03 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated metrics in css2.1/t170602-bdr-conflct-w-* (50 files).
Remove these files from Skipped.

  • platform/qt/Skipped:
  • platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
04:53 Changeset [48016] by zoltan@webkit.org
  • 19 edits in trunk/LayoutTests

2009-09-03 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated metrics in css2.1/t1202-counters-* (17 files).
Remove these files from Skipped.

  • platform/qt/Skipped:
  • platform/qt/css2.1/t1202-counters-00-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-01-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-02-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-03-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-05-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-06-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-07-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-08-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-09-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-11-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-12-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-13-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-14-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-15-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-16-c-expected.txt:
  • platform/qt/css2.1/t1202-counters-17-d-expected.txt:
  • platform/qt/css2.1/t1202-counters-18-f-expected.txt:
03:50 Changeset [48015] by vestbo@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Disable a few tests that require new controller features

Reviewed by Ariya Hidayat.

  • platform/qt/Skipped:
03:44 Changeset [48014] by vestbo@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Qt/Linux] Add platform-spesific result for plugin-javascript-access

Rubber-stamped by Simon Hausmann..

  • platform/qt-linux/plugins/plugin-javascript-access-expected.txt: Added.
02:47 Changeset [48013] by zoltan@webkit.org
  • 18 edits in trunk/LayoutTests

2009-09-03 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated metrics in css2.1/t140201* (16 files).
Remove these files from Skipped.

  • platform/qt/Skipped:
  • platform/qt/css2.1/t140201-c532-bgcolor-00-a-expected.txt:
  • platform/qt/css2.1/t140201-c532-bgcolor-01-b-expected.txt:
  • platform/qt/css2.1/t140201-c533-bgimage-00-a-expected.txt:
  • platform/qt/css2.1/t140201-c533-bgimage-01-b-g-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgre-00-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgre-01-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgreps-00-c-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgreps-01-c-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgreps-02-c-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgreps-03-c-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgreps-04-c-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgreps-05-c-ag-expected.txt:
  • platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
  • platform/qt/css2.1/t140201-c536-bgpos-00-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c536-bgpos-01-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c537-bgfxps-00-c-ag-expected.txt:
02:38 Changeset [48012] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-09-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Add strnstr for Linux and Windows in StringExtras.h
https://bugs.webkit.org/show_bug.cgi?id=28901

  • wtf/StringExtras.h: (strnstr):
02:29 Changeset [48011] by eric@webkit.org
  • 8 edits
    6 adds in trunk

2009-09-03 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Tests for maxLength and IME input.
https://bugs.webkit.org/show_bug.cgi?id=25253

  • fast/forms/input-maxlength-ime-completed-expected.txt: Added.
  • fast/forms/input-maxlength-ime-completed.html: Added.
  • fast/forms/input-maxlength-ime-preedit-expected.txt: Added.
  • fast/forms/input-maxlength-ime-preedit.html: Added.
  • fast/forms/resources/input-maxlength-ime-completed.js: Added.
  • fast/forms/resources/input-maxlength-ime-preedit.js: Added.
  • platform/gtk/Skipped:
  • platform/win/Skipped:

2009-09-03 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Fix a regression bug that maxLength doesn't work for IME input.
https://bugs.webkit.org/show_bug.cgi?id=25253

Tests: fast/forms/input-maxlength-ime-completed.html

fast/forms/input-maxlength-ime-preedit.html

  • dom/InputElement.cpp: (WebCore::InputElement::handleBeforeTextInsertedEvent):
  • dom/InputElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
02:12 Changeset [48010] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-09-03 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Make SVGStyleElement title/media/type setters do something
https://bugs.webkit.org/show_bug.cgi?id=28828

  • svg/dom/resources/style-reflect.js: Added.
  • svg/dom/style-reflect-expected.txt: Added.
  • svg/dom/style-reflect.html: Added.

2009-09-03 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Make SVGStyleElement title/media/type setters do something
https://bugs.webkit.org/show_bug.cgi?id=28828

Test: svg/dom/style-reflect.html

  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::setXmlspace): Actually change the attribute. (WebCore::SVGStyleElement::setType): Ditto. (WebCore::SVGStyleElement::setMedia): Ditto. (WebCore::SVGStyleElement::setTitle): Ditto.
02:08 Changeset [48009] by vestbo@webkit.org
  • 3 edits in trunk/WebKitTools

[Qt] Add support for platform-spesific layout-test results

Reviewed by Mark Rowe.

For the Qt port we use the qt-[mac|linux|win] directories and then fall
back to the generic qt directory for both test results and skipped list.

  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
02:04 Changeset [48008] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-09-03 Ben Murdoch <benm@google.com>

https://bugs.webkit.org/show_bug.cgi?id=28872
Test to verify statement error callbacks behave as expected when they return true or throw an exception.

  • storage/statement-error-callback-expected.txt: Added with properties svn:eol-style.
  • storage/statement-error-callback.html: Added with properties svn:eol-style.

2009-09-03 Ben Murdoch <benm@google.com>

https://bugs.webkit.org/show_bug.cgi?id=28872

Fixes a bug where handleEvent() in the V8 Custom SQL Statement Error binding would not return the correct result to WebCore after invoking the callback.

Test: storage/statement-error-callback.html

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8CustomSQLStatementErrorCallback::handleEvent): Return true from handleEvent() if the callback raised an exception or the callback itself returned true.
01:57 Changeset [48007] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-09-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Add a setting to turn SessionStorage on/off
https://bugs.webkit.org/show_bug.cgi?id=28836

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
  • Api/qwebsettings.h:
  • tests/qwebpage/tst_qwebpage.cpp: (testFlag): (tst_QWebPage::testOptionalJSObjects):
01:50 Changeset [48006] by eric@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

2009-09-03 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

[Haiku] Adding three font-specific files to WebCore:
FontCustomPlatformData.cpp, FontCustomPlatformData.h,
and FontPlatformData.h
https://bugs.webkit.org/show_bug.cgi?id=28131

  • platform/graphics/haiku/FontCustomPlatformData.cpp: Added. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/haiku/FontCustomPlatformData.h: Added. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
  • platform/graphics/haiku/FontPlatformData.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::bold): (WebCore::FontPlatformData::oblique): (WebCore::FontPlatformData::hashTableDeletedFontValue):
00:14 Changeset [48005] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-09-03 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's HashEntry class
https://bugs.webkit.org/show_bug.cgi?id=27830

Inherits HashEntry class from FastAllocBase because it has been
instantiated by 'new' JavaScriptCore/runtime/Lookup.cpp:32.

  • runtime/Lookup.h:

09/02/09:

19:31 Changeset [48004] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-02 Laurent Cerveau <lcerveau@me.com>

Reviewed by David Kilzer.

<http://webkit.org/b/25517> build-webkit script should print build time at end

  • Scripts/build-webkit: Added startTime and endTime variable so that the build time is computed and printed as part of the build message; display formatting has been separated in a dedicated subroutine.
18:44 Changeset [48003] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root

Reviewed by Eric Seidel.

  • Scripts/VCSUtils.pm: (determineSvnRoot): Added back check for repository root that was removed in r46134 when this code lived in svn-create-patch. It's necessary to check both the repository root and the repository UUID in case two different working directories are checked out from the same repository.
18:10 Changeset [48002] by timothy@apple.com
  • 2 edits in trunk/WebKitTools

Use new 512x512 icons for nightly builds.

Rubber-stamped by Mark Rowe.

  • WebKitLauncher/webkit.icns:
17:55 Changeset [48001] by beidson@apple.com
  • 5 edits in trunk/WebCore

More partial work towards "Page Cache should support pages with Frames"
https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Darin Adler.

No new tests. (No change in behavior, current tests pass).

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopLoading): Adopt the new enum form for FrameLoader::stopLoading().

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading): Take an enum to decide whether to dispatch no unload events,

only unload, or unload and pagehide.

(WebCore::FrameLoader::closeURL):
(WebCore::FrameLoader::scheduleRedirection):
(WebCore::FrameLoader::cachePageForHistoryItem): Call pageHidden().
(WebCore::FrameLoader::pageHidden): Add to dispatch the pagehide event to all frames in the case

where a page is added to the PageCache.

  • loader/FrameLoader.h:
  • loader/FrameLoaderTypes.h: Add an UnloadEventPolicy enum.
17:18 Changeset [48000] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Should crash if JIT code buffer allocation fails.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-09-02
https://bugs.webkit.org/show_bug.cgi?id=28926
<rdar://problem/7031922>

  • jit/ExecutableAllocatorPosix.cpp:

(JSC::ExecutablePool::systemAlloc):

  • jit/ExecutableAllocatorWin.cpp:

(JSC::ExecutablePool::systemAlloc):

17:07 Changeset [47999] by beidson@apple.com
  • 8 edits in trunk

WebCore: More partial work towards "Page Cache should support pages with Frames"
https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Darin Adler.

  • More CachedFrame destruction work.
  • Including related Frame and FrameLoader changes and cleanup.

No new tests. (No change in behavior, current tests pass).

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): Rebuild up the whole FrameTree when restoring.
(WebCore::CachedFrame::CachedFrame): Tear down the entire FrameTree when caching.
(WebCore::CachedFrame::destroy): For child frames that are being destroyed while in

the PageCache, do lightweight cleanup to:
A - Prevent referring to a stale Page object.
B - Prevent World Leaks of WebKit objects.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopAllLoaders): stopAllLoaders() should never be called on Frames that are

in the PageCache. ASSERT that fact.

(WebCore::FrameLoader::open): Remove a bogus release-build workaround, as the comment right above it

explains it is not effective, and it'd be better to see the crash locally instead of downstream.

(WebCore::FrameLoader::closeAndRemoveChild): Make sure the owner element has a page pointer before

referencing it.

(WebCore::FrameLoader::detachFromParent): Use the new detachViewsAndDocumentLoader() call
(WebCore::FrameLoader::detachViewsAndDocumentLoader): Does lightweight cleanup of client (WebKit) objects.

  • loader/FrameLoader.h:
  • page/Frame.cpp:

(WebCore::Frame::detachFromPage): Simply clear the Page pointer without doing any other work.
(WebCore::Frame::pageDestroyed): Use the new detachFromPage().

  • page/Frame.h:

WebKit/mac: More partial work towards "Page Cache should support pages with Frames"
https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Darin Adler.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _topHTMLView]): Rework the ASSERT in this method to reflect the

reality of calling this method for pages currently in the PageCache.

16:41 Changeset [47998] by jshin@chromium.org
  • 2 edits in trunk/WebCore

2009-09-02 Jungshik Shin <jshin@chromium.org>

Reviewed by Dimitri Glazkov

[Chromium] Add 'icu::' qualifier in preparation for ICU upgrade to 4.2
in Chromium. This is to fix a new file added in r28742 since the
last patch for this issue.

https://bugs.webkit.org/show_bug.cgi?id=28410

No change in the test result.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::getNormalizedTextRun):
16:01 Changeset [47997] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

waf build fix. Remove local variable shadowing global.

15:21 Changeset [47996] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-09-02 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[Chromium] Correct a typo to fix bustage, caused by r47991.
https://bugs.webkit.org/show_bug.cgi?id=27933

  • platform/graphics/skia/ImageBufferSkia.cpp: Changed "Unpremultipled" to "Unmultiplied".
14:31 Changeset [47995] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-09-02 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[Chromium] Add a missing include to fix bustage, caused by r47991.
https://bugs.webkit.org/show_bug.cgi?id=27933

  • platform/graphics/skia/ImageBufferSkia.cpp: Added SkColorPriv include.
14:30 Changeset [47994] by jianli@chromium.org
  • 2 edits in trunk/WebCore

[Chromium] Implement file support for DragData.
https://bugs.webkit.org/show_bug.cgi?id=28896

Reviewed by Dimitri Glazkov.

  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::containsCompatibleContent):

14:07 Changeset [47993] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Protect libcurl shared data with Mutex objects via curl_set_share_opt.
https://bugs.webkit.org/show_bug.cgi?id=28920

13:45 Changeset [47992] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-02 Evan Stade <estade@chromium.org>

Reviewed by Eric Seidel.

Expose functions to change the focus ring color for Linux Chromium

https://bugs.webkit.org/show_bug.cgi?id=28887

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::setFocusRingColor): (WebCore::RenderThemeChromiumLinux::platformFocusRingColor):
  • rendering/RenderThemeChromiumLinux.h:
13:38 Changeset [47991] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-02 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVG Filter premultiplied color support for getImageDate/putImageData
https://bugs.webkit.org/show_bug.cgi?id=27933

Patch to get premultiplied color support for Skia on getImageDate/putImageData.

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::putImageData):
13:23 Changeset [47990] by beidson@apple.com
  • 4 edits in trunk/WebCore

Forget to rename openInFrameloader() to open(), which was requested in Darin's review of my last patch.

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::open):

  • history/CachedFrame.h:
  • history/CachedPage.cpp:

(WebCore::CachedPage::restore):

13:16 Changeset [47989] by beidson@apple.com
  • 7 edits in trunk/WebCore

In http://trac.webkit.org/changeset/47943 I added new header dependencies to FrameLoader.h.
Removing them is a little trouble, but worth it going forward.
The pattern of creating a "CachedFrameBase" as the interface CachedFrame provides to FrameLoader
was suggested by Darin Adler.

Reviewed by Darin Adler.

No new tests. (No change in behavior)

Make CachedFrame inherit privately from CachedFrameBase, which becomes the interface FrameLoader uses:

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::CachedFrameBase):
(WebCore::CachedFrameBase::~CachedFrameBase):
(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::openInFrameLoader):

  • history/CachedFrame.h:

(WebCore::CachedFrameBase::document):
(WebCore::CachedFrameBase::view):
(WebCore::CachedFrameBase::domWindow):
(WebCore::CachedFrame::create):
(WebCore::CachedFrame::documentLoader):
(WebCore::CachedFrame::mousePressNode):

Call the new ::openInFrameLoader() method on the CachedFrame, as CachedFrameBase is now the only
thing capable of interacting with FrameLoader::open(CachedFrameBase):

  • history/CachedPage.cpp:

(WebCore::CachedPage::restore):

  • history/CachedPage.h:

(WebCore::CachedPage::documentLoader):

Make ::open(CachedFrame) public, and change it to ::open(CachedFrameBase):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::open):

  • loader/FrameLoader.h:
13:13 Changeset [47988] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

2009-09-02 Zan Dobersek <zandobersek@gmail.com>

Reviewed by David Kilzer.

Calls exitStatus function from the main package where it is also defined.

  • Scripts/VCSUtils.pm:
13:13 Changeset [47987] by rniwa@webkit.org
  • 3 edits
    3 adds in trunk

WebCore: Cannot pres Enter to escape from bulleted list when <ul> is a child of <li>.
https://bugs.webkit.org/show_bug.cgi?id=24866

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-09-02
Reviewed by Eric Seidel.

This patch modifies breakOutOfEmptyListItem to break out of a properly nested list
(a list to break out of is inside another list item).

When the empty list item appears at the end of another list item, WebKit breaks out of
the outer list item, and adds new item below the outer list item.
Otherwise, WebKit breaks out of the the inner list item and inserts new paragraph.

Test: editing/execCommand/break-out-of-empty-list-item.html

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):

LayoutTests: Cannot press Enter to escape from bulleted list when <ul> is a child of <li>.
https://bugs.webkit.org/show_bug.cgi?id=24866

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-09-02
Reviewed by Eric Seidel.

This patch adds a test to make sure WebKit break out of an empty list item.

  • editing/execCommand/break-out-of-empty-list-item-expected.txt: Added.
  • editing/execCommand/break-out-of-empty-list-item.html: Added.
  • editing/execCommand/resources/break-out-of-empty-list-item.js: Added.

(pressKey):
(enterAtTarget):
(testBreakOutOfEmptyListItem):

12:55 Changeset [47986] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Brady Eidson.

Fix the test to pass on Tiger.

Tiger's ICU decodes the invalid text differently. Moved it inside the comment - this also
matches the original from the Web better.

  • fast/encoding/japanese-encoding-mix-expected.txt:
  • fast/encoding/japanese-encoding-mix.html:
12:32 Changeset [47985] by beidson@apple.com
  • 5 edits in trunk/WebCore

More partial work towards "Page Cache should support pages with Frames"
https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Sam Weinig.

This patch is primarily about the "CachedFrame tree" and making slightly different decisions
based on whether a CachedFrame is the main frame or a subframe.

  • Store whether a CachedFrame represents the main frame or a subframe.
  • "Chop off the frame tree" for the main frame when creating its CachedFrame, as main frames are reused and need to start new page loads with an empty frame tree.
  • Reattach the frame tree to the main frame when restoring it.
  • open() the cached subframes in their respective loaders when restoring.
  • Properly clear() and destroy() cached subframes.
  • When committing to a new page load, and after caching the previous page, only clear the FrameView for the main frame.

Note that all of above will eventually be necessary as I continue to land this work in pieces,
but doesn't actually change any behavior right now because we still refuse to even *try* to
cache pages with frames.

No new tests. No change in behavior, and current tests continue to pass.

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::restore):
(WebCore::CachedFrame::clear):
(WebCore::CachedFrame::destroy):

  • history/CachedFrame.h:

(WebCore::CachedFrame::isMainFrame):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::open):

  • loader/FrameLoader.h:
11:32 Changeset [47984] by beidson@apple.com
  • 2 edits in trunk/WebCore

No review, build fix.

http://trac.webkit.org/changeset/47976 broke the build.
Let's try compiling before we land things, shall we?

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::SimpleFontData): Order the initialization list correctly.

11:28 Changeset [47983] by kevino@webkit.org
  • 11 edits in trunk

waf build fixes for Windows/MSVC and Mac/Snow Leopard.

11:14 Changeset [47982] by benm@google.com
  • 2 edits in trunk/WebCore

Unreviewed build fix for Chromium.

Missed #including V8Proxy.h in WebCore/bindings/v8/V8Binding.cpp.

  • bindings/v8/V8Binding.cpp: add V8Proxy.h as an include
11:03 Changeset [47981] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

wx port: Call WTF::initializeThreading().
https://bugs.webkit.org/show_bug.cgi?id=28912

10:41 Changeset [47980] by kevino@webkit.org
  • 2 edits in trunk/WebCore

waf build fix, don't define symbols we now grab from other sources.

10:39 Changeset [47979] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

Build fix for building on Windows.

10:34 Changeset [47978] by kevino@webkit.org
  • 3 edits in trunk/WebCore

Build fixes for PluginViewNone.cpp and a wx build fix for PluginView.cpp.

10:32 Changeset [47977] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. Use the 2 param KURL constructor.

10:10 Changeset [47976] by yong.li@torchmobile.com
  • 3 edits in trunk/WebCore

2009-09-02 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by Eric Seidel.

Fix the build failure of WebKit for Linux/Qt when WML is enabled

No test cases needed since this just fixes the build problem.

  • wml/WMLElement.cpp: (WebCore::WMLElement::create):
  • wml/WMLTableElement.cpp: (WebCore::WMLTableElement::joinSuperflousColumns): (WebCore::WMLTableElement::padWithEmptyColumns):
09:37 Changeset [47975] by yong.li@torchmobile.com
  • 5 edits in trunk/WebCore

2009-09-02 Yong Li <yong.li@torchmobile.com>

Reviewed by Adam Barth.

WINCE PORT: use shared buffer for custom font data
https://bugs.webkit.org/show_bug.cgi?id=27734

Refactored by Joe Mason <joe.mason@torchmobile.com>

  • loader/CachedFont.cpp: add WINCE to platforms using cached custom data
  • platform/graphics/opentype/OpenTypeUtilities.cpp: (WebCore::renameFont): implement for WinCE
  • platform/graphics/opentype/OpenTypeUtilities.h: build fixes
  • platform/graphics/wince/FontCustomPlatformData.cpp: (WebCore::setCustomFontCache): add accessor (WebCore::createFontCustomPlatformData): change param to SharedBuffer
  • platform/graphics/wince/FontCustomPlatformData.h: update function signatures
09:32 Changeset [47974] by yong.li@torchmobile.com
  • 5 edits in trunk/WebCore

2009-09-02 Yong Li <yong.li@torchmobile.com>

Reviewed by Adam Barth.

WINCE PORT: font-related build fixes and minor bugfixes
https://bugs.webkit.org/show_bug.cgi?id=27734

  • platform/graphics/FontCache.h: declare functions added in https://bugs.webkit.org/show_bug.cgi?id=27509
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): fix ambiguous overload error in min/max on Windows
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): initialize member vars
  • platform/graphics/SimpleFontData.h: disable unused members on Wince to save space
08:54 Changeset [47973] by abarth@webkit.org
  • 6 edits in trunk/WebCore

2009-09-02 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

Another pass at releasing the storage mutex.
https://bugs.webkit.org/show_bug.cgi?id=28904

Another pass at releasing the storage mutex (when applicable) when we finish
executing JavaScript. http://dev.w3.org/html5/spec/Overview.html#storage-mutex
describes the required behavior.

As it turns out, https://bugs.webkit.org/show_bug.cgi?id=28789 didn't solve
the problem correctly. First of all, I missed that events and timeouts go
through a different call path. Second of all, I didn't consider recursion
correctly. Third of all, my check to see if LocalStorage is alive actually
instantiates it if it isn't yet. Fourth, I forgot DOM_STORAGE guards around
it. So I'm reverting that change completely and doing it more cleanly.
Unfortunately, the solution isn't as portable (and thus I've left out the JSC
implementation for now).

NOTE: This change now tracks recursion on function callbacks in V8. I ran this
by Mads Ager and Mike Belshe and they seemed to think adding the checks were
fine. Most callbacks are asynchronous and thus wouldn't be nested. The few
scenareos where you can have nested callbacks probably should have always been
protected by a recursion guard.

Unfortunately, this can't be tested without a hook added to the layout test
controllers since the lock is (by design) not supposed to be observable by
JavaScript. https://bugs.webkit.org/show_bug.cgi?id=28906

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): revert
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): revert
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::runScript):

Add releaseStorageMutex call. A small amount of clean up.

(WebCore::V8Proxy::callFunction):

Add releaseStorageMutex call. A small amount of clean up.

(WebCore::V8Proxy::releaseStorageMutex):

Check to see if localStorage has been instantiated. If so, tell it to
unlock all storage areas.

  • bindings/v8/V8Proxy.h:
  • page/PageGroup.h: (WebCore::PageGroup::hasLocalStorage): Make hasLocalStorage public.
08:48 Changeset [47972] by kevino@webkit.org
  • 4 edits in trunk/WebKitTools

Reviewed by Eric Seidel.

Changes needed for build-webkit to support the waf build system for the wx port.

https://bugs.webkit.org/show_bug.cgi?id=27619

08:24 Changeset [47971] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts

Reviewed by Eric Seidel.

  • Scripts/update-webkit: Added "--accept postpone" to @svnOptions when running with svn-1.6 or newer.
08:24 Changeset [47970] by ddkilzer@apple.com
  • 5 edits in trunk/WebKitTools

Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()

Reviewed by Eric Seidel.

  • Scripts/VCSUtils.pm: (@EXPORT): Added &isSVNVersion16OrNewer. (svnVersion): Added. Internal method that gets the SVN version and caches it. (isSVNVersion16OrNewer): Added. Method that does the SVN 1.6 version check.
  • Scripts/prepare-ChangeLog: Switched to use new isSVNVersion16OrNewer() method.
  • Scripts/resolve-ChangeLogs: Ditto.
  • Scripts/svn-create-patch: Ditto.
08:24 Changeset [47969] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Clean up VCSUtils.pm

Reviewed by Eric Seidel.

  • Scripts/VCSUtils.pm: Added proper package statement. Fixed indentation of BEGIN block. Listed each exported method on a line by itself. Added methods to the export list after adding the package statement. Sorted module variables. Moved definiton of $gitRoot next to other module variables.
08:19 Changeset [47968] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-09-02 Yong Li <yong.li@torchmobile.com>

Reviewed by Adam Barth.

WINCE PORT: Implement ImageBuffer for WINCE
Implement Image interface with a light class BufferedImage
for rendering ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=28167

  • platform/graphics/wince/ImageBufferData.h: Added.
  • platform/graphics/wince/ImageBufferWince.cpp: Added.
07:24 Changeset [47967] by vestbo@webkit.org
  • 8 edits in trunk/WebCore

Join the various PluginView destructors into one shared implementation

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27706

The Qt port used to delete the platform plugin widget as the last step.
Now this is done before cleaning up the script objects and unloading the
plugin package, similar to how the Win port does it.

  • plugins/PluginView.cpp:
  • plugins/PluginViewNone.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/mac/PluginViewMac.cpp:
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp:
06:50 Changeset [47966] by vestbo@webkit.org
  • 8 edits in trunk/WebCore

Share PluginView::init() between ports

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27706

The port-spesific bits are moved to platformStart(), which now returns
a bool based on the success of the platformStart.

m_hasPendingGeometryChange is now initialized in the initializer list
instead of in PluginViewQt's init()

PluginViewMac (currently used only by the Qt port) used to manually call
stop() in the case where an unsupported drawing or event model was detected.
This was wrong, as the m_status and m_isStarted fields should be used to
guard against doing operations on a plugin in this intermediate state.

  • plugins/PluginView.cpp:
  • plugins/PluginView.h:
  • plugins/PluginViewNone.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/mac/PluginViewMac.cpp:
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp:
06:06 Changeset [47965] by jmalonzo@webkit.org
  • 5 edits
    1 add in trunk

2009-09-02 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez and Gustavo Noronha.

[Gtk] Implement a WebDataSource for the gtk port
https://bugs.webkit.org/show_bug.cgi?id=24758

Add data source API getters to WebKitWebFrame.
Also add WebKitWebDataSource unit test.

  • tests/testwebdatasource.c: Added.
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebframe.h:

Add WebKitWebDataSource unit test to the build script

  • GNUmakefile.am:
05:58 Changeset [47964] by jmalonzo@webkit.org
  • 8 edits
    4 adds in trunk

2009-09-02 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez and Gustavo Noronha.

[Gtk] Implement a WebDataSource for the gtk port
https://bugs.webkit.org/show_bug.cgi?id=24758

Subclass DocumentLoader for Gtk and implement it under the WebKit
namespace. Add WebKitWebDataSource implementation that closely
follows the mac implementation of the API.

  • WebCoreSupport/DocumentLoaderGtk.cpp: Added.
  • WebCoreSupport/DocumentLoaderGtk.h: Added.
  • webkit/webkitwebdatasource.cpp: Added.
  • webkit/webkitwebdatasource.h: Added.

Add WebKitWebDataSource and DocumentLoaderGtk to the build script.

  • GNUmakefile.am:
05:40 Changeset [47963] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

[Qt] Make sure we relayout the page after evaluating JS

Patch by Richard Moore <rich@kde.org> on 2009-09-02
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=28235

QtWebKit does not always seem to reflow the page when evaluating
javascript. This patch changes the way evaluateJavaScript works to
use the frameloader which ensures that this is done properly.

  • Api/qwebframe.cpp:

(QWebFrame::evaluateJavaScript):

  • tests/qwebframe/tst_qwebframe.cpp:
04:38 Changeset [47962] by benm@google.com
  • 7 edits in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=28737

Patch by Ben Murdoch <benm@google.com> on 2009-09-02
Update JavaScript bindings in JSC and V8 for SQLTransaction to throw exceptions in the right places.

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql): Throw an exception if no parameters are passed to executeSql().

  • bindings/v8/V8Binding.cpp:

(WebCore::v8ValueToWebCoreString): Catch an exception if thrown from toString().

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL): Allow "arrayish objects" to be passed to executeSql.

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=28737

Patch by Ben Murdoch <benm@google.com> on 2009-09-02
Update the execute-sql-args.html to be agnostic to exception message formatting between JSC and V8 and throw an exception when no parameters are passed to the executeSql() function.

  • storage/execute-sql-args-expected.txt:
  • storage/execute-sql-args.html:
03:16 Changeset [47961] by vestbo@webkit.org
  • 4 edits in trunk

[Qt] Fix layout-test plugins/plugin-javascript-access.html

Rubber-stamped by Simon Hausmann.

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • platform/qt/Skipped:
02:59 Changeset [47960] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2009-09-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Migrate Databases tab to InjectedScript /
serialized interaction.

https://bugs.webkit.org/show_bug.cgi?id=28873

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::handleEvent):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.isDB): (WebInspector.Database.prototype.runWithTableNames.sortingCallback): (WebInspector.Database.prototype.runWithTableNames): (WebInspector.Database.prototype.executeSql): (WebInspector.Database.prototype.executeSql.errorCallback): (WebInspector.Database.prototype.executeSql.queryTransaction):
  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._enterKeyPressed): (WebInspector.DatabaseQueryView.prototype._queryFinished):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.selectDatabase): (WebInspector.StoragePanel.prototype.updateDatabaseTables.withTableNames): (WebInspector.StoragePanel.prototype.updateDatabaseTables): (WebInspector.DatabaseSidebarTreeElement.prototype.onpopulate.withTableNames): (WebInspector.DatabaseSidebarTreeElement.prototype.onpopulate):
02:49 Changeset [47959] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-09-02 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Eric Seidel.

Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled

RegisterFile constructor currently throws #error when both
MMAP and VIRTUALALLOC conditions fail.
On any platform that does not provide these features
(for instance, Symbian),
the fallback should be regular malloc (or fastMalloc).
It is functionally equivalent in this case, even though it may
have certain drawbacks such as lack of dynamic pre-allocation.

  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::~RegisterFile):
  • interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile):
02:46 Changeset [47958] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-09-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed (trivial followup fix).


Web Inspector: Trivial follow up fix to r47944.

https://bugs.webkit.org/show_bug.cgi?id=28800

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::nodeForId):
02:44 Changeset [47957] by zoltan@webkit.org
  • 24 edits in trunk/LayoutTests

2009-09-02 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update css2.1/t1202-counter-* and css2.1/t1205* tests after new metrics.
Remove these files from Skipped (and fixed Skipped according to Changeset 47815).

  • platform/qt/Skipped:
  • platform/qt/css2.1/t1202-counter-00-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-01-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-02-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-03-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-04-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-05-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-06-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-07-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-08-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-09-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-11-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-12-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-13-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-14-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-15-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-16-f-expected.txt:
  • platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c563-list-type-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c563-list-type-01-b-expected.txt:
  • platform/qt/css2.1/t1205-c564-list-img-00-b-g-expected.txt:
  • platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c566-list-stl-01-c-g-expected.txt:
01:08 Changeset [47956] by eric@webkit.org
  • 5 edits
    2 moves
    1 add in trunk

2009-09-02 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

js tests should move into jstests subdirectory instead of resources/
https://bugs.webkit.org/show_bug.cgi?id=25880

make-script-wrappers supports both resources and script-tests directories.
run-webkit-tests ignores files in script-tests.
Move script tests of animations to check the new script is working.

  • animations/animation-css-rule-types.html:
  • animations/resources/TEMPLATE.html: Removed.
  • animations/resources/animation-css-rule-types.js: Removed.
  • animations/script-tests: Added.
  • animations/script-tests/TEMPLATE.html: Copied from LayoutTests/animations/resources/TEMPLATE.html.
  • animations/script-tests/animation-css-rule-types.js: Copied from LayoutTests/animations/resources/animation-css-rule-types.js.

2009-09-02 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

js tests should move into jstests subdirectory instead of resources/
https://bugs.webkit.org/show_bug.cgi?id=25880

make-script-wrappers supports both resources and script-tests directories.
run-webkit-tests ignores files in script-tests.
Move script tests of animations to check the new script is working.

  • Scripts/make-script-test-wrappers:
  • Scripts/run-webkit-tests:
01:01 Changeset [47955] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2009-09-02 Szabo Carol <carol.szabo@nokia.com>

Reviewed by David Levin.

check-webkit-style uses python from /usr/bin instead of the PATH
https://bugs.webkit.org/show_bug.cgi?id=28225

  • Scripts/bugzilla-tool:
  • Scripts/check-webkit-style:
  • Scripts/run-webkit-unittests:
  • Scripts/update-sources-list.py: Changed the first line from #!/usr/bin/python to #!/usr/bin/env python which causes python to be invoked from the path location returned by "which python" when any of these scripts are launched. these are currently all the python scripts in WebKitTools/Scripts.
Note: See TracTimeline for information about the timeline view.