Timeline
Sep 7, 2009:
- 11:22 PM Changeset in webkit [48145] by
-
- 2 edits in trunk/WebCore
2009-09-07 Adam Barth <abarth@webkit.org>
Unreviewed speculative build fix for Snow Leopard.
- platform/GeolocationService.cpp: (WebCore::createGeolocationServiceNull):
- 11:13 PM Changeset in webkit [48144] by
-
- 30 edits2 copies6 adds in trunk
2009-09-07 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264
- fast/dom/Geolocation/resources/error.js: Added. Tests that the error callback is called when the service reports an error.
- fast/dom/Geolocation/error-expected.txt: Added. Expected result for above test.
- fast/dom/Geolocation/error.html: Added. Wrapper for above test.
2009-09-07 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264
The mock Geolocation service returns a fixed position or error. This position or error can be
set through static methods on the GeolocationService class. The position or error is shared
between all instances of the mock Geolocation service.
Implementation details.
The GeolocationService object maintains a pointer to a factory function which it uses to create
Geolocation service instances. Each platform implementing Geolocation sets this pointer
to the factory function for their platform's implementation. When the mock Geolocation service
is activated, the factory function pointer is reset to the factory function for the mock service.
Test: fast/dom/Geolocation/error.html
- WebCore.base.exp: Modified. Exports GeolocationServiceMock methods.
- GNUMakefile.am: Modified. Added GeolocationServiceMock files.
- WebCore.gypi: Modified. Added GeolocationServiceMock files.
- WebCore.pro: Modified. Added GeolocationServiceMock files.
- WebCore.vcproj/WebCore.vcproj: Modified. Added GeolocationServiceMock files.
- WebCore.vcproj/WebCoreCommon.vsprops: Modified. Added mock directory to includes.
- WebCore.xcodeproj/project.pbxproj: Modified. Added GeolocationServiceMock files and exports some headers.
- WebCoreSources.bkl: Modified. Added GeolocationServiceMock files.
- page/ChromeClient.h: Modified. Fixed comment.
- page/Geolocation.cpp: Modified. (WebCore::Geolocation::setIsAllowed): Modified. Fixed error string.
- platform/GeolocationService.cpp: Modified. (WebCore::createGeolocationServiceNull): Added. Returns null in place of a Geolocation service. Used to avoid link errors on platforms where Geolocation is not implemented. (WebCore::GeolocationService::create): Added. Uses the factory function pointer to create a Geolocation service implementation. (WebCore::GeolocationService::useMock): Added. Configures the GeolocationServie to use the mock implementation.
- platform/GeolocationService.h: Modified.
- platform/mock: Added.
- platform/mock/GeolocationServiceMock.cpp: Added. (WebCore::GeolocationServiceMock::create): Added. Creates a GeolocationServiceMock object. (WebCore::GeolocationServiceMock::GeolocationServiceMock): Added. Constructor. (WebCore::GeolocationServiceMock::~GeolocationServiceMock): Added. Destructor. (WebCore::GeolocationServiceMock::setPosition): Added. Sets the position that will be returned by the object. (WebCore::GeolocationServiceMock::setError): Added. Sets the error that will be returned by the object. (WebCore::GeolocationServiceMock::startUpdating): Added. GeolocationService implementation. Starts the service. (WebCore::GeolocationServiceMock::stopUpdating): Added. GeolocationService implementation. Stops the service. (WebCore::GeolocationServiceMock::timerFired): Added. Used to provide an asynchronous callback when the service is started. (WebCore::GeolocationServiceMock::makeGeolocationCallbackFromAllInstances): Added. Used to call back when the position or error is updated. (WebCore::GeolocationServiceMock::makeGeolocationCallback): Added. Used to call back when the service starts. (WebCore::GeolocationServiceMock::initStatics): Added. Initializes statics members with constructors. (WebCore::GeolocationServiceMock::cleanUpStatics): Added. Cleans up static members with constructors.
- platform/mock/GeolocationServiceMock.h: Added. (WebCore::GeolocationServiceMock::lastPosition): Added. Returns the fixed position. (WebCore::GeolocationServiceMock::lastError): Added. Returns the fixed error.
- platform/gtk/GeolocationServiceGtk.cpp: Modified. (WebCore::GeolocationServiceGtk::create): Added. Creates an instance of GeolocationServiceGtk.
- platform/gtk/GeolocationServiceGtk.h: Modified.
- platform/mac/GeolocationServiceMac.h: Modified.
- platform/mac/GeolocationServiceMac.mm: Modified. (WebCore::GeolocationServiceMac::create): Added. Creates an instance of GeolocationServiceMac.
2009-09-07 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264
- WebKit.xcodeproj/project.pbxproj: Modified. Adds WebGeolocationMock.
2009-09-07 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264
- WebCoreSupport/WebGeolocationMockPrivate.h: Added.
- WebCoreSupport/WebGeolocationMock.mm: Added. (+[WebGeolocationMock setError:code:]): Added. Used by DumpRender tree to configure the mock Geolocation service. (+[WebGeolocationMock setPosition:latitude:longitude:accuracy:]): Added. Used by DumpRender tree to configure the mock Geolocation service.
- WebKit.exp: Modified. Exports WebGeolocationMock.
2009-09-07 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264
- DumpRenderTree/LayoutTestController.cpp: Modified. (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service. (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service. (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
- DumpRenderTree/LayoutTestController.h: Modified.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified. (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service. (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
- 10:19 PM Changeset in webkit [48143] by
-
- 6 edits2 adds in trunk/LayoutTests
2009-09-07 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Eric Seidel.
Clean up localStorage.clear() layout test.
https://bugs.webkit.org/show_bug.cgi?id=28939
This is the first step of https://bugs.webkit.org/show_bug.cgi?id=27897 which
is a pretty major cleanup of all the dom storage layout tests. I'm just
changing this one to begin with to get buy-in on the approach.
This also adds a new method to the fast/js/js-test-pre.js that runs a command
and prints it to the screen. This should really help with making the output of
the tests readable without looking at the source code.
- fast/js/resources/js-test-pre.js: (tryAndLog): Runs a command and logs it to the screen.
- storage/domstorage/localstorage/clear-expected.txt:
- storage/domstorage/localstorage/clear.html:
- storage/domstorage/resources: Added.
- storage/domstorage/resources/clear.js: Added.
The meat of the test is now in this file.
- storage/domstorage/sessionstorage/clear-expected.txt:
- storage/domstorage/sessionstorage/clear.html:
- 6:25 PM Changeset in webkit [48142] by
-
- 2 edits in trunk/WebCore
2009-09-07 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
We need to be slightly more careful about how we pick up a script
execution context. In particular, we were getting the wrong document
for frames that had been navigated somewhere else.
In the long term, we should think about a better algorithm for
computing the script context.
Fixes LayoutTests/http/tests/xmlhttprequest/detaching-frame-2.html
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieveFrame):
- 5:32 PM Changeset in webkit [48141] by
-
- 4 edits in trunk/LayoutTests
Rubber-stamped by Sam Weinig.
Rebaseline tests for GTK platform, and skipping shared worker XHR tests (worker XHR tests are already skipped).
Tracked as https://bugs.webkit.org/show_bug.cgi?id=29020.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- 5:08 PM Changeset in webkit [48140] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test fixup.
Added shared worker lifecycle tests to Skipped test list due to missing DRT functionality on Qt platform.
- platform/qt/Skipped:
- 4:55 PM Changeset in webkit [48139] by
-
- 1 edit21 moves in trunk/LayoutTests
Enable shared worker tests.
https://bugs.webkit.org/show_bug.cgi?id=28977
Reviewed by David Levin.
Just moved tests from shared-worker-xxxx.html-disabled to shared-worker-xxxx.html. No other changes.
- fast/workers/shared-worker-constructor.html: Renamed from LayoutTests/fast/workers/shared-worker-constructor.html-disabled.
- fast/workers/shared-worker-context-gc.html: Renamed from LayoutTests/fast/workers/shared-worker-context-gc.html-disabled.
- fast/workers/shared-worker-event-listener.html: Renamed from LayoutTests/fast/workers/shared-worker-event-listener.html-disabled.
- fast/workers/shared-worker-exception.html: Renamed from LayoutTests/fast/workers/shared-worker-exception.html-disabled.
- fast/workers/shared-worker-frame-lifecycle.html: Renamed from LayoutTests/fast/workers/shared-worker-frame-lifecycle.html-disabled.
- fast/workers/shared-worker-gc.html: Renamed from LayoutTests/fast/workers/shared-worker-gc.html-disabled.
- fast/workers/shared-worker-lifecycle.html: Renamed from LayoutTests/fast/workers/shared-worker-lifecycle.html-disabled.
- fast/workers/shared-worker-load-error.html: Renamed from LayoutTests/fast/workers/shared-worker-load-error.html-disabled.
- fast/workers/shared-worker-location.html: Renamed from LayoutTests/fast/workers/shared-worker-location.html-disabled.
- fast/workers/shared-worker-navigator.html: Renamed from LayoutTests/fast/workers/shared-worker-navigator.html-disabled.
- fast/workers/shared-worker-replace-global-constructor.html: Renamed from LayoutTests/fast/workers/shared-worker-replace-global-constructor.html-disabled.
- fast/workers/shared-worker-replace-self.html: Renamed from LayoutTests/fast/workers/shared-worker-replace-self.html-disabled.
- fast/workers/shared-worker-script-error.html: Renamed from LayoutTests/fast/workers/shared-worker-script-error.html-disabled.
- fast/workers/shared-worker-shared.html: Renamed from LayoutTests/fast/workers/shared-worker-shared.html-disabled.
- fast/workers/shared-worker-simple.html: Renamed from LayoutTests/fast/workers/shared-worker-simple.html-disabled.
- http/tests/workers/shared-worker-importScripts.html: Renamed from LayoutTests/http/tests/workers/shared-worker-importScripts.html-disabled.
- http/tests/workers/shared-worker-redirect.html: Renamed from LayoutTests/http/tests/workers/shared-worker-redirect.html-disabled.
- http/tests/xmlhttprequest/workers/shared-worker-close.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-close.html-disabled.
- http/tests/xmlhttprequest/workers/shared-worker-methods-async.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-methods-async.html-disabled.
- http/tests/xmlhttprequest/workers/shared-worker-methods.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-methods.html-disabled.
- http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html-disabled.
- 4:05 PM Changeset in webkit [48138] by
-
- 2 edits in trunk/WebCore
wx build fix for 2.8 compilation.
- 3:23 PM Changeset in webkit [48137] by
-
- 18 edits5 deletes in trunk
JavaScriptCore: Reverting r48121 to fix Windows build errors.
- JavaScriptCore.exp:
WebCore: Unreviewed build fix.
Reverting r48121 to fix Windows build errors.
- DerivedSources.cpp:
- GNUmakefile.am:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
(WebCore::toEventTarget):
- dom/EventTarget.cpp:
- dom/EventTarget.h:
- page/DOMWindow.idl:
- websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::bufferedAmount):
(WebCore::WebSocket::addEventListener):
(WebCore::WebSocket::removeEventListener):
(WebCore::WebSocket::dispatchEvent):
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didReceiveMessage):
(WebCore::WebSocket::didClose):
(WebCore::WebSocket::dispatchOpenEvent):
(WebCore::WebSocket::dispatchMessageEvent):
(WebCore::WebSocket::dispatchCloseEvent):
- websockets/WebSocket.h:
(WebCore::WebSocket::create):
(WebCore::WebSocket::):
(WebCore::WebSocket::setOnopen):
(WebCore::WebSocket::onopen):
(WebCore::WebSocket::setOnmessage):
(WebCore::WebSocket::onmessage):
(WebCore::WebSocket::setOnclose):
(WebCore::WebSocket::onclose):
(WebCore::WebSocket::toWebSocket):
(WebCore::WebSocket::refEventTarget):
(WebCore::WebSocket::derefEventTarget):
- websockets/WebSocketChannel.cpp: Removed.
- websockets/WebSocketChannel.h: Removed.
- websockets/WebSocketChannelClient.h: Removed.
- websockets/WebSocketHandshake.cpp: Removed.
- websockets/WebSocketHandshake.h: Removed.
LayoutTests: Unreviewed build fix.
Reverting r48121 to fix Windows build errors.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- 2:29 PM Changeset in webkit [48136] by
-
- 2 edits in trunk/WebCore
Unreviewed speculative build fix.
Reverted previous build fix as it didn't fix the problem.
- bindings/js/JSEventTarget.cpp:
(WebCore::toEventTarget):
- 2:20 PM Changeset in webkit [48135] by
-
- 2 edits in trunk/WebCore
2009-09-07 Laszlo Gombos <Laszlo Gombos>
Unreviewed, build fix.
[Qt] Fix build after SHARED_WORKERS are enabled by default (r48131)
- WebCore.pro:
- 1:50 PM Changeset in webkit [48134] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix.
Temporarily removed depenency between JSEventTarget.cpp and WebSocket.h in an attempt to fix a windows build break.
- bindings/js/JSEventTarget.cpp:
(WebCore::toEventTarget):
- 1:10 PM Changeset in webkit [48133] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Link new objects documents in the main document.
- docs/webkitgtk-docs.sgml:
- 1:04 PM Changeset in webkit [48132] by
-
- 3 edits in trunk/WebKit/gtk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Documentation control files updated for 1.1.14.
- docs/webkitgtk-docs.sgml:
- docs/webkitgtk-sections.txt:
- 12:53 PM Changeset in webkit [48131] by
-
- 27 edits in trunk
JavaScriptCore: Enable SHARED_WORKERS by default
https://bugs.webkit.org/show_bug.cgi?id=28959
Reviewed by David Levin.
- Configurations/FeatureDefines.xcconfig:
WebCore: Enable SHARED_WORKERS by default.
https://bugs.webkit.org/show_bug.cgi?id=28959
Reviewed by David Levin.
Tests (enabled in a separate patch):
fast/workers/shared-worker-constructor.html
fast/workers/shared-worker-context-gc.html
fast/workers/shared-worker-event-listener.html
fast/workers/shared-worker-exception.html
fast/workers/shared-worker-frame-lifecycle.html
fast/workers/shared-worker-gc.html
fast/workers/shared-worker-lifecycle.html
fast/workers/shared-worker-load-error.html
fast/workers/shared-worker-location.html
fast/workers/shared-worker-navigator.html
fast/workers/shared-worker-replace-global-constructor.html
fast/workers/shared-worker-replace-self.html
fast/workers/shared-worker-shared.html
fast/workers/shared-worker-simple.html
http/tests/workers/shared-worker-importScripts.html
http/tests/workers/shared-worker-redirect.html
http/tests/xmlhttprequest/workers/shared-worker-close.html
http/tests/xmlhttprequest/workers/shared-worker-methods-async.html
http/tests/xmlhttprequest/workers/shared-worker-methods.html
http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html
- config.h: Removed some whitespace/touched the file to force a full rebuild on the build-bots.
- Configurations/FeatureDefines.xcconfig:
- WebCore.pro:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/build-generated-files.sh:
- dom/DOMWindow.idl: Removed unnecessary whitespace to force a rebuild on the build-bots to pickup the flag change.
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::load):
Clean up bitrot in SharedWorker code - DenyCrossOriginRedirect is now DenyCrossOriginRequests.
- workers/SharedWorkerContext.cpp:
(WebCore::SharedWorkerContext::dispatchConnect):
Clean up bitrot - updated SharedWorker code to reflect new MessageEvent API.
WebKit/mac: Enable SHARED_WORKERS by default.
https://bugs.webkit.org/show_bug.cgi?id=28959
Reviewed by David Levin.
- Configurations/FeatureDefines.xcconfig:
WebKit/win: Enable SHARED_WORKERS by default.
https://bugs.webkit.org/show_bug.cgi?id=28959
Reviewed by David Levin.
- WebKit.vcproj/WebKit.vcproj:
WebKitTools: Enable SHARED_WORKERS by default
https://bugs.webkit.org/show_bug.cgi?id=28959
Reviewed by David Levin.
- Scripts/build-webkit:
LayoutTests: Enable SHARED_WORKERS by default
https://bugs.webkit.org/show_bug.cgi?id=28959
Reviewed by David Levin.
Update test expectations to reflect the availability of the SharedWorker constructor.
Fixup bitrot in disabled tests - now reflects new MessagePort API.
- fast/dom/Window/window-properties-expected.txt:
Updated expectations now that window.SharedWorkers is defined.
- fast/dom/prototype-inheritance-2-expected.txt:
Updated expectations now that window.SharedWorkers is defined.
- fast/dom/prototype-inheritance-expected.txt:
Updated expectations now that window.SharedWorkers is defined.
- fast/workers/shared-worker-script-error-expected.txt
Updated expectations to reflect current (correct) behavior (unhandled exceptions are logged to console).
- fast/workers/shared-worker-script-error.html
Pauses before exiting the test to allow pending console errors to get emitted (makes test less flaky).
- fast/workers/resources/shared-worker-script-error.js
(onerror):
Now properly handles the exception (onerror function has to return false to swallow the exception).
- fast/js/global-constructors-expected.txt:
Updated expectations now that window.SharedWorkers is defined.
- http/tests/workers/resources/worker-importScripts.js:
Clean up bitrot in tests - MessageEvent.messagePort => MessageEvent.ports.
(handleConnect.self.postMessage):
(handleConnect):
- http/tests/workers/resources/worker-redirect-target.js:
Clean up bitrot in tests - MessageEvent.messagePort => MessageEvent.ports.
(self.onconnect):
- http/tests/xmlhttprequest/workers/resources/worker-pre.js:
Clean up bitrot in tests - MessageEvent.messagePort => MessageEvent.ports.
- 12:47 PM Changeset in webkit [48130] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.14
Tagging 1.1.14.
- 12:27 PM Changeset in webkit [48129] by
-
- 2 edits in trunk/LayoutTests
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Skipping one more test affected by the libsoup issue, a new test,
and tests that require eventSender.
- platform/gtk/Skipped:
- 11:57 AM Changeset in webkit [48128] by
-
- 2 edits in trunk/LayoutTests
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Skipping tests that are failing because of a libsoup
problem. Bug reported.
- platform/gtk/Skipped:
- 11:52 AM Changeset in webkit [48127] by
-
- 2 edits in trunk/WebKit/qt
[PATCH 2/6] Speed up the QWebPluginInfo::supportsMimeType() function.
https://bugs.webkit.org/show_bug.cgi?id=27651
Instead of going through the MIME types list constructed with
mimeTypes() function, look up the internal mimeToDescriptions map.
- 11:16 AM Changeset in webkit [48126] by
-
- 2 edits in trunk/WebCore
2009-09-07 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
Add new file to sources list.
- GNUmakefile.am:
- 10:53 AM Changeset in webkit [48125] by
-
- 7 edits in trunk
wx build fixes for wx SVN trunk.
- 10:21 AM Changeset in webkit [48124] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
What's new for 1.1.14.
- NEWS:
- 10:16 AM Changeset in webkit [48123] by
-
- 2 edits in trunk
2009-09-07 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
Bump versions in preparation for 1.1.14 release.
- configure.ac:
- 10:07 AM Changeset in webkit [48122] by
-
- 2 edits in trunk/WebCore
[Qt] Use direct includes for Phonon, not the pretty ones
Patch by Chris Hills <chaz@chaz6.com> on 2009-09-07
Reviewed by Tor Arne Vestbø.
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- 10:02 AM Changeset in webkit [48121] by
-
- 18 edits5 adds in trunk
2009-09-07 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Export WTF::tryFastMalloc used in WebSocketChannel.
https://bugs.webkit.org/show_bug.cgi?id=28038
- JavaScriptCore.exp:
2009-09-07 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Add WebSocket API.
https://bugs.webkit.org/show_bug.cgi?id=28038
WebSocket constructor is available in window object.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
2009-09-07 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket API implementation.
https://bugs.webkit.org/show_bug.cgi?id=28038
Add build systems only for GNUmakefile.am and WebCore.xcodeproj now.
Other build systems will be updated once the code is functional.
Tests will be landed once the code is completed and functional.
- DerivedSources.cpp:
- GNUmakefile.am:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webSocket):
- bindings/js/JSEventTarget.cpp: (WebCore::toJS): (WebCore::toEventTarget):
- dom/EventTarget.cpp: (WebCore::EventTarget::toWebSocket):
- dom/EventTarget.h:
- page/DOMWindow.idl:
- websockets/WebSocket.cpp: (WebCore::ProcessWebSocketEventTask::create): (WebCore::ProcessWebSocketEventTask::performTask): (WebCore::ProcessWebSocketEventTask::ProcessWebSocketEventTask): (WebCore::isValidProtocolString): (WebCore::WebSocket::connect): (WebCore::WebSocket::send): (WebCore::WebSocket::close): (WebCore::WebSocket::bufferedAmount): (WebCore::WebSocket::addEventListener): (WebCore::WebSocket::removeEventListener): (WebCore::WebSocket::dispatchEvent): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): (WebCore::WebSocket::didClose): (WebCore::WebSocket::dispatchOpenEvent): (WebCore::WebSocket::dispatchMessageEvent): (WebCore::WebSocket::dispatchCloseEvent):
- websockets/WebSocket.h: (WebCore::WebSocket::create): (WebCore::WebSocket::): (WebCore::WebSocket::setOnopen): (WebCore::WebSocket::onopen): (WebCore::WebSocket::setOnmessage): (WebCore::WebSocket::onmessage): (WebCore::WebSocket::setOnclose): (WebCore::WebSocket::onclose): (WebCore::WebSocket::toWebSocket): (WebCore::WebSocket::eventListeners): (WebCore::WebSocket::refEventTarget): (WebCore::WebSocket::derefEventTarget):
- websockets/WebSocketChannel.cpp: Added.
- websockets/WebSocketChannel.h: Added.
- websockets/WebSocketChannelClient.h: Added.
- websockets/WebSocketHandshake.cpp: Added.
- websockets/WebSocketHandshake.h: Added.
- 9:31 AM Changeset in webkit [48120] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Use g_return_if_fail to check for the SoupURI creation, instead of
printing a custom warning.
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_set_uri):
- 9:29 AM Changeset in webkit [48119] by
-
- 1 edit in trunk/WebKit/gtk/ChangeLog
Fixing name of reviewer in some older commits. Xan suggested the fix,
but Jan reviewed.
- 9:27 AM Changeset in webkit [48118] by
-
- 17 edits4 adds in trunk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=26854
[GTK] Needs API to allow more control over outgoing requests
- GNUmakefile.am: new files added to the build for new class WebKitNetworkResponse
WebCore:
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=26854
[GTK] Needs API to allow more control over outgoing requests
Add infrastructure required to provide the new
WebKitNetworkResponse object in our API.
- GNUmakefile.am: Add new files to the build.
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage):
- platform/network/soup/ResourceResponse.h:
- platform/network/soup/ResourceResponseSoup.cpp: Added. (WebCore::ResourceResponse::toSoupMessage):
WebKit/gtk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=26854
[GTK] Needs API to allow more control over outgoing requests
Map the willSendRequest delegate to the 'resource-request-starting'
signal, allowing more control of the resources that are fetched.
Mapping willSendRequest properly requires an appropriate Response
object, so we are introducing WebKitNetworkResponse, which works in a
way similar to WebKitNetworkRequest.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest): (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::FrameLoaderClient::dispatchDidFinishLoading): (WebKit::FrameLoaderClient::dispatchDidFailLoading):
- tests/testnetworkresponse.c: Added. (test_network_response_create_destroy): (test_network_response_properties): (main):
- tests/testwebresource.c: (resource_request_starting_cb): (load_finished_cb): (test_web_resource_loading): (main):
- webkit/webkit.h:
- webkit/webkitdefines.h:
- webkit/webkitnetworkrequest.cpp:
- webkit/webkitnetworkresponse.cpp: Added. (webkit_network_response_dispose): (webkit_network_response_finalize): (webkit_network_response_get_property): (webkit_network_response_set_property): (webkit_network_response_class_init): (webkit_network_response_init): (webkit_network_response_new_with_core_response): (webkit_network_response_new): (webkit_network_response_set_uri): (webkit_network_response_get_uri): (webkit_network_response_get_message):
- webkit/webkitnetworkresponse.h: Added.
- webkit/webkitprivate.cpp: (WTF::SoupMessage): (WTF::WebKitNetworkRequest): (WTF::WebKitNetworkResponse): (WTF::WebKitWebResource):
- webkit/webkitprivate.h:
- webkit/webkitwebresource.cpp: (webkit_web_resource_cleanup): (webkit_web_resource_finalize): (webkit_web_resource_class_init): (webkit_web_resource_set_property): (webkit_web_resource_get_uri):
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
- webkitmarshal.list:
- 8:28 AM Changeset in webkit [48117] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=28979
[GTK] Misc improvments to NetworkRequest
Unref message in dispose, as it should be, not in finalize.
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_dispose): (webkit_network_request_finalize): (webkit_network_request_class_init):
- 8:28 AM Changeset in webkit [48116] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=28979
[GTK] Misc improvments to NetworkRequest
Bring documentation up-to-date with reality regarding NetworkRequest.
- webkit/webkitnetworkrequest.cpp:
- 8:11 AM Changeset in webkit [48115] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-07 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Make the auth dialog usable when libsoup does not have a
SoupPasswordManager, since it might go away in the next
development cycle.
- webkit/webkitsoupauthdialog.c: (response_callback): (session_can_save_passwords): (session_authenticate):
- 7:49 AM Changeset in webkit [48114] by
-
- 2 edits in trunk/WebCore
2009-09-07 Mads Ager <ager@chromium.org>
Reviewed by Adam Barth.
[V8] Cleanup document/frame null-checking in V8DOMWindowCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=29009
Be consistent in document and frame null checks.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::V8Custom::ClearTimeoutImpl):
- 7:21 AM Changeset in webkit [48113] by
-
- 4 edits in trunk/WebKit/qt
2009-09-07 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
Speed up the QWebPluginInfo::mimeTypes() function.
https://bugs.webkit.org/show_bug.cgi?id=27651
Instead of constructing a list of MIME types every time it is called,
do this only once.
- Api/qwebplugindatabase.cpp: (QWebPluginInfo::mimeTypes): (QWebPluginInfo::operator=):
- Api/qwebplugindatabase.h:
- tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: (tst_QWebPluginDatabase::operatorassign_data): (tst_QWebPluginDatabase::operatorassign):
- 7:15 AM Changeset in webkit [48112] by
-
- 3 edits1 delete in trunk/WebKit/qt
2009-09-07 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
Remove the private classes from QWebPluginDatabase.
https://bugs.webkit.org/show_bug.cgi?id=27651
Instead, hold the PluginDatabase and PluginPackage objects as class
members and take care of refcounting on our own instead of using RefPtr.
This way we not only made the code cleaner but also got rid of
redundant allocations when constructing null QWebPluginInfo objects.
The private classes have been forward-declared and the d-pointers left
to be on the safe side.
- Api/qwebplugindatabase.cpp: (QWebPluginInfo::QWebPluginInfo): (QWebPluginInfo::~QWebPluginInfo): (QWebPluginInfo::name): (QWebPluginInfo::description): (QWebPluginInfo::mimeTypes): (QWebPluginInfo::path): (QWebPluginInfo::isNull): (QWebPluginInfo::setEnabled): (QWebPluginInfo::isEnabled): (QWebPluginInfo::operator==): (QWebPluginInfo::operator!=): (QWebPluginInfo::operator=): (QWebPluginDatabase::QWebPluginDatabase): (QWebPluginDatabase::~QWebPluginDatabase): (QWebPluginDatabase::plugins): (QWebPluginDatabase::searchPaths): (QWebPluginDatabase::setSearchPaths): (QWebPluginDatabase::addSearchPath): (QWebPluginDatabase::refresh): (QWebPluginDatabase::pluginForMimeType): (QWebPluginDatabase::setPreferredPluginForMimeType):
- Api/qwebplugindatabase.h:
- Api/qwebplugindatabase_p.h: Removed.
- 6:38 AM Changeset in webkit [48111] by
-
- 2 edits in trunk/WebCore
2009-09-07 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[Soup] Limit the number of connections
https://bugs.webkit.org/show_bug.cgi?id=18431
Increase the maximum number of per host and total connections to
similar values than those used by the other modern browsers. Seems
to significantly improve page loading time in many cases.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized):
- 3:09 AM Changeset in webkit [48110] by
-
- 2 edits in trunk/LayoutTests
[Qt] Disable a few tests that require missing controller features
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-07
Reviewed by Tor Arne Vestbø
- platform/qt/Skipped:
- 12:35 AM Changeset in webkit [48109] by
-
- 4 edits in trunk/WebCore
2009-09-07 Michael Nordman <Michael Nordman>
Reviewed by Darin Fisher.
Various minor chromium appcache modifications.
https://bugs.webkit.org/show_bug.cgi?id=28960
No new tests.
- bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: Fix a null pointer exception. (WebCore::ACCESSOR_GETTER):
- platform/network/chromium/ResourceRequest.h: Switch from appCache 'context' to 'host' terminology. Note: leaving the old deprecated accessors in place until the matching change in chrome is landed to use the new accessors. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::appCacheHostID): (WebCore::ResourceRequest::setAppCacheHostID): (WebCore::ResourceRequest::appCacheContextID): (WebCore::ResourceRequest::setAppCacheContextID):
- platform/network/chromium/ResourceResponse.h: Add an appCacheManifestURL getter/setter. Drop the 'get' prefix from the appCacheID getter. Note: leaving the old deprecated 'get' prefixed accessor in place until the matching change in chrome is landed to use the new accessor. (WebCore::ResourceResponse::appCacheID): (WebCore::ResourceResponse::appCacheManifestURL): (WebCore::ResourceResponse::setAppCacheManifestURL): (WebCore::ResourceResponse::getAppCacheID):
- 12:28 AM Changeset in webkit [48108] by
-
- 5 edits2 adds in trunk
2009-09-07 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=28359
Test to ensure the the window.applicationCache attribute is defined but non-functional
with the feature disabled.
- http/tests/appcache/disabled-expected.txt: Added.
- http/tests/appcache/disabled.html: Added.
2009-09-07 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=28359
Cleanup: Undo some accidental changes around DOMApplicationCache.
- Restore support for constructing a DOMApplicationCache object with a null frame ptr.
- Return a non-null object for window.applicationCache when the feature is disabled.
- Simplify the swapCache method.
Test: http/tests/appcache/disabled.html
- loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::DOMApplicationCache): (WebCore::DOMApplicationCache::swapCache): (WebCore::DOMApplicationCache::scriptExecutionContext):
- loader/appcache/DOMApplicationCache.h:
- page/DOMWindow.cpp: (WebCore::DOMWindow::applicationCache):
Sep 6, 2009:
- 10:25 PM Changeset in webkit [48107] by
-
- 5 edits in trunk
2009-09-06 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
hostname and host are mixed up when manipulating anchor elements.
https://bugs.webkit.org/show_bug.cgi?id=28954
Added test case for when port is 0.
- fast/dom/Element/hostname-host-expected.txt:
- fast/dom/Element/hostname-host.html:
2009-09-06 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
hostname and host are mixed up when manipulating anchor elements.
https://bugs.webkit.org/show_bug.cgi?id=28954
handle the case of port 0.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::host):
- 10:10 PM Changeset in webkit [48106] by
-
- 31 edits6 adds in trunk
2009-09-06 Erik Arvidsson <arv@chromium.org>
Reviewed by Eric Seidel.
Tests for https://bugs.webkit.org/show_bug.cgi?id=27099
Make hidden elements not focusable. This is important becaue we should
not allow tabbing to a hidden element.
The patch also makes a element without href behave like generic elements
when it comes to focus. Added tests that asserts that this works as
expected.
- fast/events/click-focus-anchor-expected.txt: Added.
- fast/events/click-focus-anchor.html: Added.
- fast/events/resources/tabindex-focus-blur-all.js: (test): (testProgrammaticFocus):
- fast/events/tab-focus-anchor-expected.txt: Added.
- fast/events/tab-focus-anchor.html: Added.
- fast/events/tab-focus-hidden-expected.txt: Added.
- fast/events/tab-focus-hidden.html: Added.
- fast/events/tabindex-focus-blur-all-expected.txt:
2009-09-06 Erik Arvidsson <arv@chromium.org>
Reviewed by Eric Seidel.
Make hidden elements not focusable.
Clean up supportsFocus and isFocusable.
supportsFocus now strictly means that the node can be focused by default.
This is true for links, form controls and content editable elements for example.
isFocusable means that the user can actually focus it.
All (2) calls to supportsFocus have been updated to take this into account.
Make a elements without href work correctly as well.
Tests: fast/events/click-focus-anchor.html
fast/events/tab-focus-anchor.html
fast/events/tab-focus-hidden.html
- dom/Element.cpp: (WebCore::Element::focus):
- dom/Node.cpp: (WebCore::Node::supportsFocus): (WebCore::Node::isFocusable):
- dom/Node.h:
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::supportsFocus): (WebCore::HTMLAnchorElement::isMouseFocusable): (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- html/HTMLAnchorElement.h:
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::supportsFocus):
- html/HTMLAreaElement.h:
- html/HTMLElement.cpp: (WebCore::HTMLElement::supportsFocus):
- html/HTMLElement.h:
- html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::supportsFocus):
- html/HTMLFieldSetElement.h:
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::supportsFocus): (WebCore::HTMLFormControlElement::isFocusable):
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::supportsFocus):
- html/HTMLFrameElementBase.h:
- html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::supportsFocus):
- html/HTMLLegendElement.h:
- html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::supportsFocus): (WebCore::HTMLOptGroupElement::isFocusable):
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::supportsFocus): (WebCore::HTMLOptionElement::isFocusable):
- html/HTMLOptionElement.h:
- page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent):
- page/FocusController.cpp: (WebCore::FocusController::advanceFocus):
- svg/SVGAElement.cpp: (WebCore::SVGAElement::supportsFocus): (WebCore::SVGAElement::isFocusable):
- wml/WMLAElement.cpp: (WebCore::WMLAElement::supportsFocus):
- wml/WMLAElement.h:
- wml/WMLFormControlElement.cpp: (WebCore::WMLFormControlElement::supportsFocus): (WebCore::WMLFormControlElement::isFocusable):
- wml/WMLFormControlElement.h:
- 9:15 PM Changeset in webkit [48105] by
-
- 3 edits in trunk/WebCore
2009-09-06 Joel Stanley <joel@jms.id.au>
Reviewed by Dimitri Glazkov.
Expose functions to set the caret blink interval for Linux Chromium.
Default value is set to that of RenderTheme::caretBlankInterval().
Uses caretBlinkIntervalInternal to avoid overriding
RenderThemeChromiumSkia::caretBlankInterval to preserve the disabling
of blinking caret required for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=28931
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval): (WebCore::RenderThemeChromiumLinux::caretBlinkIntervalInternal):
- rendering/RenderThemeChromiumLinux.h:
- 7:27 PM Changeset in webkit [48104] by
-
- 2 edits in trunk/WebCore
Remove an extra </File> in WebCore.vcproj.
- WebCore.vcproj/WebCore.vcproj:
- 3:44 PM Changeset in webkit [48103] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-06 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update the unitests to latest changes wrt scrollbar policy.
- tests/testwindow.c: (test_webkit_window_scrollbar_policy):
- 1:43 PM Changeset in webkit [48102] by
-
- 6 edits1 add in trunk/WebCore
Adds a persistent setting for color format in the Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=28889
Reviewed by Dan Bernstein.
- English.lproj/localizedStrings.js: New strings.
- inspector/front-end/Color.js: Minor style fixes.
(WebInspector.Color.prototype.toString): Added. Replaces the individual
"toFoo" functions. Takes a optional arguments for the color format to return.
- inspector/front-end/Images/paneSettingsButtons.png: Added.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._changeColorFormat): Update the sections to show
the new color format.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay):
Use the new toString function on Color.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor): Use the persistent setting
to format colors by default. Add a tooltip for the color swatch.
- inspector/front-end/inspector.css: New styles for the settings menu.
- inspector/front-end/inspector.js:
(WebInspector.loaded): Initilize the colorFormat preference.
- 7:31 AM Changeset in webkit [48101] by
-
- 15 edits4 adds in trunk
2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.
[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899
Expose an HTML5 database API for GTK+.
- GNUmakefile.am:
LayoutTests:
2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.
[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899
Expose an HTML5 database API for GTK+.
- platform/gtk/Skipped:
WebKit/gtk:
2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.
[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899
Expose an HTML5 database API for GTK+.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::print):
- webkit/webkit.h:
- webkit/webkitdefines.h:
- webkit/webkitprivate.cpp: (webkit_init):
- webkit/webkitprivate.h:
- webkit/webkitsecurityorigin.cpp: Added. (webkit_security_origin_finalize): (webkit_security_origin_dispose): (webkit_security_origin_set_property): (webkit_security_origin_get_property): (webkit_security_origins): (webkit_security_origin_class_init): (webkit_security_origin_init): (webkit_security_origin_get_protocol): (webkit_security_origin_get_host): (webkit_security_origin_get_port): (webkit_security_origin_get_web_database_usage): (webkit_security_origin_get_web_database_quota): (webkit_security_origin_set_web_database_quota): (webkit_security_origin_get_all_web_databases): (WebKit::kit): (WebKit::core): (webkit_security_origin_get_web_database):
- webkit/webkitsecurityorigin.h: Added.
- webkit/webkitwebdatabase.cpp: Added. (webkit_web_database_finalize): (webkit_web_database_dispose): (webkit_web_database_set_property): (webkit_web_database_get_property): (webkit_web_database_class_init): (webkit_web_database_init): (webkit_web_database_set_security_origin): (webkit_web_database_set_name): (webkit_web_database_get_security_origin): (webkit_web_database_get_name): (webkit_web_database_get_display_name): (webkit_web_database_get_expected_size): (webkit_web_database_get_size): (webkit_web_database_get_filename): (webkit_web_database_remove): (webkit_remove_all_web_databases): (webkit_get_web_database_directory_path): (webkit_set_web_database_directory_path): (webkit_get_default_web_database_quota):
- webkit/webkitwebdatabase.h: Added.
- webkit/webkitwebframe.cpp: (webkit_web_frame_new): (webkit_web_frame_get_focused_accessible_element): (webkit_web_frame_get_horizontal_scrollbar_policy):
- webkit/webkitwebframe.h:
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
- 5:38 AM Changeset in webkit [48100] by
-
- 3 edits in trunk/WebCore
2009-09-06 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Remove Qt v4.6 check from the prefetchDNS implementation
https://bugs.webkit.org/show_bug.cgi?id=28993
- platform/network/qt/DnsPrefetchHelper.cpp:
- platform/network/qt/DnsPrefetchHelper.h:
- 12:24 AM Changeset in webkit [48099] by
-
- 24 edits3 deletes in trunk
2009-09-06 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991
Update test not to expect a <definition-src> element to be of type
SVGDefinitionSrcElement.
- svg/dom/font-face-elements-expected.txt:
- svg/dom/font-face-elements.html:
2009-09-06 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991
http://dev.w3.org/SVG/profiles/1.1F2/publish/changes.html#FontsChapter
- DerivedSources.cpp: Remove references to definition-src.
- DerivedSources.make: Ditto.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/objc/DOM.mm: (WebCore::createElementClassMap): Ditto.
- bindings/objc/DOMSVG.h: Ditto.
- bindings/v8/DerivedSourcesAllInOne.cpp: Ditto.
- bindings/v8/V8DOMWrapper.cpp: Ditto.
- bindings/v8/V8Index.cpp: Ditto.
- bindings/v8/V8Index.h: Ditto.
- svg/SVGAllInOne.cpp: Ditto.
- svg/SVGDefinitionSrcElement.cpp: Removed.
- svg/SVGDefinitionSrcElement.h: Removed.
- svg/SVGDefinitionSrcElement.idl: Removed.
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace): Don't search for definition-src child.
- svg/svgtags.in: Remove definition-src.
2009-09-06 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991
- MigrateHeaders.make: Remove reference to ObjC definition-src binding class.
2009-09-06 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991
When SVG 1.1 Second Edition is a Recommendation we can remove the
entry altogether.
- projects/svg/status.xml: Update page to state that <definition-src> is not supported.
Sep 5, 2009:
- 9:09 PM Changeset in webkit [48098] by
-
- 3 edits in trunk/WebCore
2009-09-05 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Roll out http://trac.webkit.org/changeset/48094, because the
logic of retrieving default caret blink interval was incorrect (non-existent)
and caused layout test flakiness.
- rendering/RenderThemeChromiumLinux.cpp:
- rendering/RenderThemeChromiumLinux.h:
- 8:57 PM MathML Goals edited by
- (diff)
- 4:47 PM Changeset in webkit [48097] by
-
- 2 edits in trunk/WebKit/qt
2009-09-05 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Eric Seidel.
[Qt] r47424 broke binary compatibility
https://bugs.webkit.org/show_bug.cgi?id=28996
Append the new DnsPrefetchEnabled attribute at the end of the enum.
- Api/qwebsettings.h:
- 10:42 AM Changeset in webkit [48096] by
-
- 2 edits in trunk/WebCore
Back up partial change in r48072 in order to fix chromium reliability build break.
Reviewed by NOBODY (Chromium reliability build break).
- bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):
- 2:13 AM Changeset in webkit [48095] by
-
- 6 edits in trunk/WebCore
2009-09-05 Nicolas Weber <thakis@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=28975
Fix file upload on chrome/mac. Images that have "Hide Extension" set,
such as screenshots by default, can now be uploaded to sites such as
imgur.com.
- platform/FileSystem.h: Add pathGetDisplayFileName().
- platform/chromium/FileChooserChromium.cpp: (WebCore::FileChooser::basenameForWidth): Call pathGetDisplayFileName() instead of pathGetFileName().
- platform/chromium/FileSystemChromiumLinux.cpp: (WebCore::pathGetDisplayFileName): Implement pathGetDisplayFileName() by delegating to pathGetFileName().
- platform/chromium/FileSystemChromiumMac.mm: (WebCore::pathGetFileName): Now returns a real filename instead of a presentational one, which fixes the problem addressed by this change. (WebCore::pathGetDisplayFileName): New function that returns a presentational filename; does what pathGetDisplayFileName() did prior to this patch.
- platform/chromium/FileSystemChromiumWin.cpp: (WebCore::pathGetDisplayFileName): Implement pathGetDisplayFileName() by delegating to pathGetFileName().
- 2:05 AM Changeset in webkit [48094] by
-
- 3 edits in trunk/WebCore
2009-09-05 Joel Stanley <joel@jms.id.au>
Reviewed by David Levin.
Expose functions to set the caret blink interval for Linux Chromium.
https://bugs.webkit.org/show_bug.cgi?id=28931
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval): (WebCore::RenderThemeChromiumLinux::caretBlinkInterval):
- rendering/RenderThemeChromiumLinux.h:
- 1:43 AM Changeset in webkit [48093] by
-
- 2 edits in trunk/LayoutTests
2009-09-05 Eric Seidel <eric@webkit.org>
No review, results update only.
Update results after r48043.
- fast/js/JSON-stringify-expected.txt:
Sep 4, 2009:
- 9:10 PM Changeset in webkit [48092] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 9:09 PM Changeset in webkit [48091] by
-
- 1 copy in tags/Safari-6531.17
New tag.
- 9:08 PM Changeset in webkit [48090] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48085.
- 9:08 PM Changeset in webkit [48089] by
-
- 4 edits in branches/safari-4-branch/WebCore
Merge r48070.
- 9:07 PM Changeset in webkit [48088] by
-
- 2 edits in branches/safari-4-branch/WebCore
2009-09-04 Anders Carlsson <andersca@apple.com>
Reviewed by Adele Petersen.
- Fix <rdar://problem/7192902>
Never throw away the first frame in an animation.
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):
- 9:07 PM Changeset in webkit [48087] by
-
- 4 edits in branches/safari-4-branch/WebCore
Merge r48062.
- 8:54 PM Changeset in webkit [48086] by
-
- 4 edits1 add in trunk/WebCore
Prevent UI freeze in case when too many timers are in the timer queue.
https://bugs.webkit.org/show_bug.cgi?id=23865
Reviewed by David Levin.
The fix measures the elapsed time while executing timers. If we have too many
timers and it takes significant time to fire, quit the loop and reschedule.
This lets the run loop process user input (close the window for example).
- platform/ThreadTimers.h:
- platform/ThreadTimers.cpp:
(WebCore::ThreadTimers::sharedTimerFiredInternal):
(WebCore::ThreadTimers::fireTimersInNestedEventLoop):
Removed functions and members used before to grab a list of all expired timers.
Now we fetch one by one, measuring time and quitting the loop if it takes too long.
- platform/Timer.cpp:
(WebCore::TimerBase::isActive):
(WebCore::TimerBase::setNextFireTime):
Since timers are now fired one by one, there is no need to keep track of updated timers.
- manual-tests/input-starved-by-timers.html: Manual test that attempts to freeze browser by
creating of enough timers. It then keeps UI frozen and after 10 seconds starts to drain the timers
so the browser un-freezes. This is instead of a regular layout test because we don't have a way
to inject an input events via regular run loop in DRT - instead they are directly dispatched by
eventSender, which does not reproduce the UI freeze that happens with real input.
- 8:47 PM Changeset in webkit [48085] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7201063>
Reviewed by Adele Peterson.
Detach any custom scrollbars before detaching the document.
- page/Frame.cpp:
(WebCore::Frame::setView):
- 7:19 PM Changeset in webkit [48084] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix
- 7:07 PM Changeset in webkit [48083] by
-
- 6 edits in trunk
ToString? conversion should use the actual toString function for String objects.
Reviewed by Gavin Barraclough.
Remove incorrect specialisations of toString conversions on StringObject.
- 6:13 PM Changeset in webkit [48082] by
-
- 5 edits in trunk/WebCore
Unreviewed, build fix.
Remove remaining references to UserStyleSheetLoader after r48075.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- page/qt/FrameQt.cpp:
- page/wince/FrameWince.cpp:
- 5:35 PM Changeset in webkit [48081] by
-
- 7 edits in trunk
2009-09-04 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=28988
Minor fix: "novalidate" attribute renamed in "noValidate", according to
HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#dom-fs-novalidate
- fast/forms/novalidate-attribute-expected.txt:
- fast/forms/resources/novalidate-attribute.js:
2009-09-04 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=28988
Minor fix: "novalidate" attribute renamed in "noValidate", according to
HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#dom-fs-novalidate
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::noValidate): (WebCore::HTMLFormElement::setNoValidate):
- html/HTMLFormElement.h:
- html/HTMLFormElement.idl:
- 5:18 PM Changeset in webkit [48080] by
-
- 2 edits in trunk/WebCore
Remove unused line of code from WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=28990
Reviewed by David Levin.
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::importScripts):
- 5:03 PM Changeset in webkit [48079] by
-
- 2 edits in trunk/WebCore
Fix assertion seen when running buildbot.
Patch by Darin Adler <Darin Adler> on 2009-09-04
Reviewed by Oliver Hunt.
- bindings/js/JSDOMBinding.h:
(WebCore::DOMObjectWithGlobalPointer::createStructure): Create the structure without
the HasDefaultMark bit since this has a custom mark function.
- 3:27 PM Changeset in webkit [48078] by
-
- 2 edits in trunk/LayoutTests
Fix expected test output.
- fast/dom/DOMImplementation/detached-doctype-expected.txt:
- 2:54 PM Changeset in webkit [48077] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Add new export.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Add new export.
- 2:45 PM Changeset in webkit [48076] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove unneeded export.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Remove unneeded export.
- 2:33 PM Changeset in webkit [48075] by
-
- 11 edits2 deletes in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28984, remove the remote stylesheet loader on Mac/Qt.
Make sure the other code path (now used by everybody) can handle data URLs.
Reviewed by Adam Roben.
As per the post on webkit-dev, the ability to work remotely isn't working properly anyway (it doesn't
hold up the pending sheet count, so you'd just FOUC on every Web page), and it's extremely unlikely
that anybody is relying on this support.
Tor Arne agreed it was ok to disable (he enabled it on the Qt side), and only Mac/Qt were using this
code.
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::userStyleSheet):
- dom/Document.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::begin):
- loader/UserStyleSheetLoader.cpp: Removed.
- loader/UserStyleSheetLoader.h: Removed.
- page/Frame.cpp:
(WebCore::Frame::reapplyStyles):
- page/Frame.h:
- page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
(WebCore::Page::userStyleSheet):
- page/mac/FrameMac.mm:
- page/qt/FrameQt.cpp:
- 2:11 PM Changeset in webkit [48074] by
-
- 4 edits in trunk/WebCore
2009-09-04 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Add "sampling profiler" preference, simplify data display when it's set.
- inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds): (WebInspector.ProfileDataGridNode.prototype.get data):
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView):
- inspector/front-end/inspector.js:
- 1:55 PM Changeset in webkit [48073] by
-
- 1 edit in trunk/WebCore/page/Frame.cpp
Remove bogus assert that is affecting layout tests.
- 1:40 PM Changeset in webkit [48072] by
-
- 10 edits in trunk/WebCore
[V8] Run-time exception in onmessage handler is not forwarded to the worker object.
https://bugs.webkit.org/show_bug.cgi?id=28980
Reviewed by Adam Barth.
Tested by worker-close.html.
- bindings/v8/ScriptFunctionCall.cpp:
- bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):
- bindings/v8/V8Utilities.cpp:
(WebCore::getScriptExecutionContext):
(WebCore::reportException):
- bindings/v8/V8Utilities.h:
(WebCore::getScriptExecutionContext):
- bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8SharedWorkerCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- 12:53 PM Changeset in webkit [48071] by
-
- 3 edits in trunk/WebCore
Remove unused m_sheet variable and setCSSStyleSheet methods.
Reviewed by Anders Carlsson.
- dom/Document.cpp:
- dom/Document.h:
- 12:39 PM MathML Goals edited by
- (diff)
- 12:31 PM Changeset in webkit [48070] by
-
- 4 edits in trunk/WebCore
(Based on a patch from Adele).
Reviewed by David Hyatt and Adele Peterson.
Fix <rdar://problem/7185875>.
- page/Frame.cpp:
(WebCore::Frame::setView):
Detach any custom scroll bars from the old view.
- page/FrameView.cpp:
(WebCore::FrameView::detachCustomScrollbars):
Simplify the check (and make it work when body is null) by just checking that the scroll bar owner is
not a RenderPart object.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::destroy):
ASSERT that frame() is not null here and also add a null check so that release builds won't crash.
- 12:09 PM Changeset in webkit [48069] by
-
- 4 edits in trunk/WebCore
Make m_userStyleSheetLoader in Frame an OwnPtr.
Reviewed by Adam Roben.
- page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::~Frame):
- page/Frame.h:
- page/mac/FrameMac.mm:
(WebCore::Frame::setUserStyleSheetLocation):
(WebCore::Frame::setUserStyleSheet):
- 12:05 PM MathML Goals created by
- 12:03 PM Changeset in webkit [48068] by
-
- 10 edits in trunk/JavaScriptCore
DateInstance object collected on ARM JIT (JSValue: WTF_USE_JSVALUE32)
https://bugs.webkit.org/show_bug.cgi?id=28909
Patch by Darin Adler <Darin Adler> on 2009-09-04
Reviewed by Geoff Garen.
Part two.
Make some improvements to garbage collection code:
1) Create a runtime assertion that catches any classes that
override markChildren but have the HasDefaultMark bit set.
2) Remove checks of the mark bit outside the MarkStack::append
function; they are redundant.
3) Improve the efficiency of the asObject and asArray functions
when called on JSCell* to avoid a round trip to JSValue.
4) Make more callers use the checked asCell and asObject
casting functions rather than unchecked casts.
5) Removed the JSCell::marked function and other GC-related
functions because these operations are no longer things that
code other than the core GC code needs to do directly. Fixed
callers that were calling them.
- runtime/Collector.cpp:
(JSC::Heap::markConservatively): Removed unneeded call to MarkStack::drain.
(JSC::Heap::markProtectedObjects): Removed unneeded check of the mark
bit and call to MarkStack::drain.
(JSC::Heap::collect): Removed unneeded checks of the mark bit and also
changed call to SmallStrings::mark to call markChildren instead to match
the rest of the objects.
(JSC::typeName): Removed unneeded cast to JSObject*.
- runtime/JSArray.h:
(JSC::asArray): Added an overload for JSCell* and changed the JSValue
version to call it. Removed some unneeded casts.
(JSC::JSArray::markChildrenDirect): Marked this function inline. It's in
a header, and if not marked inline this could lead to linking problems.
(JSC::MarkStack::markChildren): Added. This helper function is used by
the drain function to avoid repating code. Also added the code here to
check fro default mark violations in debug code. If a markChildren
function adds something to the mark stack, but the type info claimed
hasDefaultMark was true, then we will get an assertion now. Also fixed
the assertion about the mark bit to use the Heap function directly
because we don't have a JSCell::marked function any more.
(JSC::MarkStack::drain): Changed a local variable from "v" to "value",
and from "currentCell" to "cell". Changed to call markChildren in two
places instead of repeating a chain of if statements twice. Changed
code that reads and writes the mark bit to use Heap::isCellMarked and
Heap::markCell so we can eliminate the JSCell::marked and
JSCell::markCellDirect functions.
- runtime/JSCell.h: Removed JSCell's markCellDirect and marked member
functions. Added a comment explaining that asCell should be deprecated
in favor of the JSValue asCell member function.
(JSC::MarkStack::append): Added the assertion that catches callers
that have set the HasDefaultMark bit incorrectly. Changed
code that reads and writes the mark bit to use Heap::isCellMarked and
Heap::markCell so we can eliminate the JSCell::marked and
JSCell::markCellDirect functions. Moved the overload of
MarkStack::append for JSValue here so it can call through to the cell
version. The old version had a copy of all the code instead, but that
repeated the conversion from JSValue to JSCell* and the check for
whether a value is a cell multiple times.
(JSC::Structure::markAggregate): Moved this function here to avoid
dependencies for Structure.h, since this calls MarkStack::append.
- runtime/JSObject.cpp:
(JSC::JSObject::markChildren): Added code to clear
m_isCheckingForDefaultMarkViolation so the marking done by JSObject
doesn't trigger the assertion.
- runtime/JSValue.h: Moved some stray includes that were outside the
header guard inside it. Not sure how that happened! Removed the
GC-related member functions markChildren, hasChildren, marked, and
markDirect.
- runtime/JSWrapperObject.h: Made markChildren private.
(JSC::JSWrapperObject::createStructure): Added. Fixes a bug where the
HasDefaultMark bit was set.
- runtime/MarkStack.h: Added m_isCheckingForDefaultMarkViolation and
initialized it to false. Moved the append function body from here to
JSCell.h. Added a declaration of a private markChildren function used
inside the drain function.
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::markChildren): Changed the name and style of this
function to match other functions. This allows us to share the normal
mark stack code path.
- runtime/SmallStrings.h: Changed the name and interface of mark to
the more-normal markChildren style.
- runtime/Structure.h: Moved the body of markAggregate into the
JSCell.h to avoid a circular dependency with JSCell.h.
- 11:53 AM Changeset in webkit [48067] by
-
- 13 edits in trunk
JavaScriptCore: DateInstance object collected on ARM JIT (JSValue: WTF_USE_JSVALUE32)
https://bugs.webkit.org/show_bug.cgi?id=28909
Patch by Darin Adler <Darin Adler> on 2009-09-04
Reviewed by Geoff Garen.
Part one.
Make some improvements to garbage collection code:
1) Fix the two classes that had the default mark bit set but
should not.
2) Remove checks of the mark bit outside the MarkStack::append
function; they are redundant.
3) Make more callers use the checked asCell and asObject
casting functions rather than unchecked casts.
4) Removed some GC-related functions because these operations are
no longer things that code other than the core GC code needs
to do directly. Fixed callers that were calling them.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::markAggregate): Removed unneeded check of the mark
bit before calling MarkStack::append.
- interpreter/Register.h: Removed unneeded marked and markChildren
functions.
- jit/JITStubs.cpp:
(op_eq): Removed unneeded assertions, instead using checked casting
functions such as asObject.
- runtime/ArgList.h: Added now-needed forward declaration of MarkStack.
- runtime/GetterSetter.cpp:
(JSC::GetterSetter::markChildren): Remmoved unneeded check of the mark bit.
- runtime/GlobalEvalFunction.h:
(JSC::GlobalEvalFunction::createStructure): Added. Fixes a bug where the
HasDefaultMark bit was set.
- runtime/JSCell.cpp:
(JSC::JSCell::getObject): Use asObject to avoid a direct static_cast.
- runtime/JSObject.h:
(JSC::asObject): Added an overload for JSCell* and changed the JSValue
version to call it.
(JSC::JSValue::get): Use asObject to avoid a direct static_cast.
- runtime/JSValue.h: Moved some stray includes that were outside the
header guard inside it. Not sure how that happened! Removed the
GC-related member functions markChildren, hasChildren, marked, and
markDirect.
- runtime/JSWrapperObject.h: Made markChildren private.
(JSC::JSWrapperObject::createStructure): Added. Fixes a bug where the
HasDefaultMark bit was set. Later we may want to optimize this for
wrapper types that never have cells in their internal values, but there
is no measured performance regression in SunSpider or V8 doing this
all the time.
- runtime/MarkStack.cpp: Tweaked formatting.
JavaScriptGlue: * JSValueWrapper.cpp:
(JSValueWrapper::JSObjectMark): Removed a check of the mark
bit. It's OK to do more work in this case, and there is no
longer a public function to access the mark bit.
Reviewed by Geoff Garen.
- 11:35 AM WikiStart edited by
- (diff)
- 11:34 AM WikiStart edited by
- added MathML section (diff)
- 11:22 AM Changeset in webkit [48066] by
-
- 4 edits in trunk
wx build fix. Switch USE_ defines over to the compiler so that they can be
checked by files not including config.h (like WebCorePrefix.h).
- 11:07 AM Changeset in webkit [48065] by
-
- 3 edits in trunk/WebCore
Show color swatches in the Web Inspector before the color text so clicking them will not
shift the swatch. Also makes multiple swatches in the single property toggle the color format.
https://bugs.webkit.org/show_bug.cgi?id=28978
Reviewed by Darin Adler.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle): Some refactoring to consolidate
the processing we do on the property value. This eliminated the old nickname code, since the new
WebInspector.Color class handles this. We could also simplify the color regex since more
is handled by the Color class. Also no longer uses innerHTML for the linkify code.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processValue): Helper function to
process a value given a regex and processor functions.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): Make an anchor for the
URL with "url()" syntax surrounding it.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor): Makes a color, if
there was an exception just return a text node.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay.changeTo):
Moved from later in the file.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay): Ditto.
- inspector/front-end/inspector.css:
- 10:59 AM Changeset in webkit [48064] by
-
- 13 edits in trunk
WebCore:
2009-09-04 Mark Mentovai <mark@chromium.org>
Reviewed by Dave Hyatt.
Account for scrollbar state changes that occur during layout.
- platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):
Perform a layout prior to checking whether the scrollbar modes are
off, on, or automatic. The modes may change during layout.
- WebCore.base.exp:
- WebCore.order:
- page/Frame.cpp: (WebCore::Frame::createView):
- page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::layout):
- page/FrameView.h:
- platform/ScrollView.h:
Eliminate duplicated (and incorrect) scrollbar mode tracking between
FrameView and ScrollView.
WebKit/mac:
2009-09-04 Mark Mentovai <mark@chromium.org>
Reviewed by Dave Hyatt.
Account for scrollbar state changes that occur during layout.
- WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView updateScrollers]):
Perform a layout prior to checking whether the scrollbar modes are
off, on, or automatic. The modes may change during layout.
- WebView/WebFrameView.mm: (-[WebFrameView _install]):
Eliminate duplicated (and incorrect) scrollbar mode tracking between
FrameView and ScrollView.
WebKit/qt:
2009-09-04 Mark Mentovai <mark@chromium.org>
Reviewed by Dave Hyatt.
Account for scrollbar state changes that occur during layout.
- Api/qwebframe.cpp: (QWebFrame::setScrollBarPolicy):
Eliminate duplicated (and incorrect) scrollbar mode tracking between
FrameView and ScrollView.
- 10:53 AM Changeset in webkit [48063] by
-
- 5 edits2 adds in trunk
WebCore: hostname and host are mixed up when manipulating anchor elements.
https://bugs.webkit.org/show_bug.cgi?id=28954
Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-04
Reviewed by Darin Adler.
Swapped the implementation of host and hostname, and made sure not to return
the port number if it is default for the given protocol.
FireFox also avoids returning the protocol number if it is default.
Test: fast/dom/Element/hostname-host.html
- 10:19 AM Changeset in webkit [48062] by
-
- 4 edits in trunk/WebCore
Fix <rdar://problem/7192902>.
Reviewed by Darin Adler and Steve Falkenburg.
Add the necessary plumbing for having QTMovieWin use WebCore timers.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
(WebCore::TaskTimer::initialize):
Create the timer and call QTMovieWin::setTaskTimerFuncs.
(WebCore::TaskTimer::setTaskTimerDelay):
Start the timer.
(WebCore::TaskTimer::stopTaskTimer):
Stop the timer.
(WebCore::TaskTimer::fired):
Call QTMovieWin::taskTimerFired().
(WebCore::MediaPlayerPrivate::load):
Initialize the Task timer.
- platform/graphics/win/QTMovieWin.cpp:
(updateTaskTimer):
Call the global stopTaskTimer function and setTaskTimerDelay.
(QTMovieWin::taskTimerFired):
Make this a member function.
(QTMovieWin::setTaskTimerFuncs):
Set the global function pointers.
(QTMovieWin::initializeQuickTime):
(DllMain):
No need to use the QT shared timer.
- platform/graphics/win/QTMovieWin.h:
- 10:08 AM Changeset in webkit [48061] by
-
- 2 edits in trunk/WebCore
Fix Chromium Win compile. Missing return statement in
WebCore::RenderThemeChromiumSkia::paintSliderThumb.
https://bugs.webkit.org/show_bug.cgi?id=28974
Patch by Tony Chang <tony@chromium.org> on 2009-09-04
Reviewed by David Levin.
No new tests, build fix.
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintSliderThumb):
- 10:07 AM Changeset in webkit [48060] by
-
- 2 edits in trunk/WebKit/win
Make WebView function without a parent window
When WebView has no parent window, it becomes a message-only window,
which hides it from the screen and prevents it from appearing on the
taskbar.
Fixes <http://webkit.org/b/28971> <rdar://problem/4976998>
WebView::initWithFrame fails if there's no host window
Reviewed by Dave Hyatt.
- WebView.cpp:
(WebView::initWithFrame): m_hostWindow is null, use HWND_MESSAGE as
our parent window, which will make us a message-only window.
(WebView::setHostWindow): If he new host window is null, use
HWND_MESSAGE as our parent window, which will make us a message-only
window.
- 10:06 AM Changeset in webkit [48059] by
-
- 7 edits3 deletes in trunk
2009-09-04 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Rolling out http://trac.webkit.org/changeset/48035, because it broke
the build.
https://bugs.webkit.org/show_bug.cgi?id=28696
- 10:02 AM Changeset in webkit [48058] by
-
- 2 edits in trunk/WebCore
Fix vcproj file.
- WebCore.vcproj/WebCore.vcproj:
- 10:01 AM Changeset in webkit [48057] by
-
- 29 edits6 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.
Reviewed by Adam Roben.
This patch adds new API for adding and removing user scripts from page groups. User scripts
are bundled together in isolated worlds (you can have multiple scripts together in the same
world).
Added userscripts/ directory for holding new tests (along with a simple test of script injection).
- WebCore.base.exp:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInIsolatedWorld):
- bindings/js/ScriptController.h:
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::evaluateInIsolatedWorld):
- bindings/v8/ScriptController.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::dispatchDocumentElementAvailable):
- page/Frame.cpp:
(WebCore::Frame::injectUserScripts):
(WebCore::Frame::injectUserScriptsForWorld):
- page/Frame.h:
- page/PageGroup.cpp:
(WebCore::PageGroup::~PageGroup):
(WebCore::PageGroup::addUserScript):
(WebCore::PageGroup::removeUserContentForWorld):
(WebCore::PageGroup::removeAllUserContent):
- page/PageGroup.h:
(WebCore::PageGroup::userScripts):
- page/UserScript.h: Added.
(WebCore::UserScript::UserScript):
(WebCore::UserScript::source):
(WebCore::UserScript::url):
(WebCore::UserScript::patterns):
(WebCore::UserScript::worldID):
(WebCore::UserScript::injectionTime):
- page/UserScriptTypes.h: Added.
(WebCore::):
WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.
Reviewed by Adam Roben.
This patch adds new API for adding and removing user scripts from page groups. User scripts
are bundled together in isolated worlds (you can have multiple scripts together in the same
world).
Added userscripts/ directory for holding new tests (along with a simple test of script injection).
- WebView/WebView.mm:
(+[WebView _addUserScriptToGroup:source:url:worldID:patterns:injectionTime:]):
(+[WebView _removeUserContentFromGroup:worldID:]):
(+[WebView _removeAllUserContentFromGroup:]):
- WebView/WebViewPrivate.h:
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.
Reviewed by Adam Roben.
This patch adds new API for adding and removing user scripts from page groups. User scripts
are bundled together in isolated worlds (you can have multiple scripts together in the same
world).
Added userscripts/ directory for holding new tests (along with a simple test of script injection).
- platform/mac/userscripts: Added.
- platform/mac/userscripts/script-run-at-end-expected.txt: Added.
- userscripts: Added.
- userscripts/script-run-at-end.html: Added.
- 9:42 AM Changeset in webkit [48056] by
-
- 1 edit in trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp
Added missing ;
- 9:34 AM Changeset in webkit [48055] by
-
- 4 edits2 adds in trunk
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26402
Crashes when using a detached DocumentType node
Test: fast/dom/DOMImplementation/detached-doctype.html
DocumentType nodes are the only one that can have null document(), and they can never have
children, so they are a degenerate case for NodeLists.
- dom/Node.cpp: (WebCore::Node::childNodes): Don't try register node list with document if there's no document. Since there are no changes possible for a DocumentType's node list, this is not necessary. (WebCore::Node::registerDynamicNodeList): Ditto. (WebCore::Node::unregisterDynamicNodeList): Ditto. I couldn't find a scenario where this was invoked for a DocumentType node, but I also couldn't prove that it can't be (the de-registration code path that I saw taken was via Node destructor, and that already has a null check for document).
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): Bail out if there is no document (just as we already do if there is no window). (WebCore::JSNode::removeEventListener): Ditto.
- 9:34 AM Changeset in webkit [48054] by
-
- 2 edits in trunk/WebKit/win
2009-09-04 Adam Barth <abarth@webkit.org>
Unreviewed attempt at a build fix.
Added missing include.
- WebCoreSupport/WebFrameLoaderClient.cpp:
- 9:23 AM Changeset in webkit [48053] by
-
- 5 edits in trunk
2009-09-04 Adam Barth <abarth@webkit.org>
Unreviewed attempt at a build fix.
Fix typo of IWebFrameLoadDelegatePrivate2 and make
IWebFrameLoadDelegatePrivate inherit from IWebFrameLoadDelegatePrivate
as requestd by Adam Roben.
- Interfaces/IWebFrameLoadDelegatePrivate2.idl:
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
2009-09-04 Adam Barth <abarth@webkit.org>
Unreviewed build fix.
Update declaration of FrameLoadDelegate to reflect that
IWebFrameLoadDelegatePrivate2 inherits from
IWebFrameLoadDelegatePrivate.
- DumpRenderTree/win/FrameLoadDelegate.h:
- 8:53 AM Changeset in webkit [48052] by
-
- 2 edits in trunk/LayoutTests
[Qt] Fix brainfart in r48050, tests should have paths
Rubber-stamped by Simon Hausmann.
- platform/qt/Skipped:
- 8:49 AM Changeset in webkit [48051] by
-
- 13 edits2 adds in trunk
2009-09-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Plumb mixed content notifications to WebFrameLoadDelegatePrivate.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
- WebView/WebDelegateImplementationCaching.h:
- WebView/WebFrameLoadDelegatePrivate.h: Added.
2009-09-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Plumb mixed content notifications to IWebFrameLoadDelegatePrivate.
- Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added.
- Interfaces/WebKit.idl:
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
- WebKit.vcproj/Interfaces.vcproj:
2009-09-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add testing instrumentation for mixed content.
- DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:]): (-[FrameLoadDelegate webView:didRunInsecureContent:]):
- DumpRenderTree/win/FrameLoadDelegate.cpp: (descriptionSuitableForTestResult): (FrameLoadDelegate::QueryInterface): (FrameLoadDelegate::didDisplayInsecureContent): (FrameLoadDelegate::didRunInsecureContent):
- DumpRenderTree/win/FrameLoadDelegate.h:
- 8:34 AM Changeset in webkit [48050] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip tests failing due to missing DRT features
Rubber-stamped by Simon Hausmann.
- platform/qt/Skipped:
- 7:04 AM Changeset in webkit [48049] by
-
- 2 edits in trunk/WebCore
2009-09-04 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] loadFinished never emitted
https://bugs.webkit.org/show_bug.cgi?id=28935
Do not report errors right away from
ResourceHandle::start. Instead return true and schedule an error
to be reported in the handle later. Otherwise WebCore gets
confused and thinks the resource never finished loading, making it
not emit the finished status.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp): (WebCore::):
- 7:00 AM Changeset in webkit [48048] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-03 Yong Li <yong.li@torchmobile.com>
Reviewed by David Levin.
Remove unnecessary dependency on unistd.h
https://bugs.webkit.org/show_bug.cgi?id=28962
- runtime/Completion.cpp:
- 3:28 AM Changeset in webkit [48047] by
-
- 3 edits in trunk/WebCore
2009-09-04 Ben Murdoch <benm@google.com>
Reviewed by Eric Seidel.
[V8] DOM Storage bindings: Event Handler should create StorageEvents
https://bugs.webkit.org/show_bug.cgi?id=28942
Tests:
Causes the following tests that were failing with V8 to pass:
- storage/domstorage/localstorage/onstorage-attribute-setwindow.html
- storage/domstorage/localstorage/complex-keys.html
- storage/domstorage/localstorage/onstorage-attribute-markup.html
- storage/domstorage/localstorage/simple-events.html
- storage/domstorage/localstorage/onstorage-attribute-set-attribute.html
- storage/domstorage/localstorage/index-get-and-set.html
- storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html
- storage/domstorage/sessionstorage/onstorage-attribute-markup.html
- storage/domstorage/sessionstorage/simple-events.html
- storage/domstorage/sessionstorage/onstorage-attribute-set-attribute.html
- storage/domstorage/sessionstorage/index-get-and-set.html
Code changes:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object): Create StorageEvents.
- bindings/v8/custom/V8StorageCustom.cpp: (WebCore::storageGetter): Check if we are retrieving the length property and return the number of items in the object rather than a property named length when invoking the getItem() member of local/sessionStorage.
- 2:04 AM Changeset in webkit [48046] by
-
- 19 edits1 add in trunk/WebCore
2009-09-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._formatarray): (WebInspector.ConsoleView.prototype._formatnode):
- inspector/front-end/DOMAgent.js:
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch):
- inspector/front-end/InjectedScript.js: (InjectedScript.dispatch):
- inspector/front-end/InjectedScriptAccess.js: Added. (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName): (InjectedScriptAccess._installHandler):
- inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
- inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted): (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/inspector.html:
- 1:47 AM Changeset in webkit [48045] by
-
- 5 edits in trunk/WebCore
2009-09-04 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Implement <input type="range"> for Chromium Linux by painting
the slider and the thumb using skia.
https://bugs.webkit.org/show_bug.cgi?id=28928
Covered by existing tests (we're currently hitting an assert for them).
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
- rendering/RenderThemeChromiumLinux.h:
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::drawVertLine): (WebCore::drawHorizLine): (WebCore::drawBox): (WebCore::RenderThemeChromiumSkia::paintSliderTrack): (WebCore::RenderThemeChromiumSkia::paintSliderThumb):
- rendering/RenderThemeChromiumSkia.h:
- 1:40 AM Changeset in webkit [48044] by
-
- 3 edits in trunk
2009-09-04 Albert Bachand <albertb@google.com>
Reviewed by Eric Seidel.
Modify the condition regarding the key modifier for opening combo
boxes under GTK from just PLATFORM(GTK) to also look for
(PLATFORM(CHROMIUM) && PLATFORM(LINUX)).
- WebCore/dom/SelectElement.cpp:
- WebCore/manual-tests/select-popup-on-spacebar.html:
- 1:32 AM Changeset in webkit [48043] by
-
- 6 edits6 adds in trunk
2009-09-04 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Tests for <input type=color> validation.
https://bugs.webkit.org/show_bug.cgi?id=28966
- fast/forms/ValidityState-patternMismatch-unsupported-expected.txt: Added.
- fast/forms/ValidityState-patternMismatch-unsupported.html: Added.
- fast/forms/ValidityState-typeMismatch-color-expected.txt: Added.
- fast/forms/ValidityState-typeMismatch-color.html: Added.
- fast/forms/resources/ValidityState-patternMismatch-unsupported.js: Added.
- fast/forms/resources/ValidityState-typeMismatch-color.js: Added.
2009-09-04 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
- Implement <input type=color> as a text field.
- ValidityState::typeMismatch supports for type=color. https://bugs.webkit.org/show_bug.cgi?id=28966
Tests: fast/forms/ValidityState-patternMismatch-unsupported.html
fast/forms/ValidityState-typeMismatch-color.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueMissing): (WebCore::HTMLInputElement::patternMismatch): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::formControlType): (WebCore::HTMLInputElement::saveFormControlState): (WebCore::HTMLInputElement::restoreFormControlState): (WebCore::HTMLInputElement::accessKeyAction): (WebCore::HTMLInputElement::rendererIsNeeded): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::appendFormData): (WebCore::HTMLInputElement::valueWithDefault): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::isRequiredFormControl): (WebCore::HTMLInputElement::dataList):
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::): (WebCore::HTMLInputElement::isTextField):
- html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch): (WebCore::ValidityState::isValidColorString):
- html/ValidityState.h:
- 1:07 AM Changeset in webkit [48042] by
-
- 2 edits in trunk/WebCore
[V8] Crash when updating document cache
https://bugs.webkit.org/show_bug.cgi?id=28965
Patch by Mads Ager <ager@chromium.org> on 2009-09-04
Reviewed by David Levin.
Initialization of a V8 JavaScript context can fail. When that
happens, do not attempt to update the document wrapper cache.
This code path is exercised by http/tests/security/javascriptURL/javascriptURL-in-new-iframe.html.
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::updateDocument):
- 12:50 AM Changeset in webkit [48041] by
-
- 2 edits in trunk/WebKit/qt
2009-09-04 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Fix tst_QWebPage::database autotest failure
https://bugs.webkit.org/show_bug.cgi?id=28961
Make sure that the test case enables the feature before
the feature gets tested
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::database):
- 12:15 AM Changeset in webkit [48040] by
-
- 5 edits in trunk
2009-09-04 Yaar Schnitman <yaar@chromium.org>
Reviewed by Eric Seidel.
Two bugs:
https://bugs.webkit.org/show_bug.cgi?id=25489
CSS property background-position is now serialized in shorthand string as
background-position-x background-position-y, as the specification requires
(See http://www.w3.org/TR/2008/WD-css3-background-20080910/#the-background-position).
https://bugs.webkit.org/show_bug.cgi?id=26541
CSS background-color is now be serialized before other background properties,
as CSS specification requires (See http://dev.w3.org/csswg/cssom/#css-value).
An existing layout test that accepted wrong order and skipped position test
had to be modified.
- fast/dom/background-shorthand-csstext-expected.txt:
- fast/dom/background-shorthand-csstext.html:
2009-09-04 Yaar Schnitman <yaar@chromium.org>
Reviewed by Eric Seidel.
Two bugs:
https://bugs.webkit.org/show_bug.cgi?id=25489
CSS property background-position is now serialized in shorthand string as
background-position-x background-position-y, as the specification requires
(See http://www.w3.org/TR/2008/WD-css3-background-20080910/#the-background-position).
https://bugs.webkit.org/show_bug.cgi?id=26541
CSS background-color is now be serialized before other background properties,
as CSS specification requires (See http://dev.w3.org/csswg/cssom/#css-value).
An existing layout test that accepted wrong order and skipped position test
had to be modified.
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
- 12:07 AM Changeset in webkit [48039] by
-
- 4 edits in trunk/WebKit/qt
2009-09-04 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Eric Seidel.
Any QtWebKit application crashes on exit if the inspector is
used during the session rather then exiting.
If a QWebView has a QWebPage that is destroyed the QWebView
does not update its pointer and will crash the next time
it access the page pointers (such as in its destructor).
InspectorClientView should not call deleteLater when the page
is destroyed because it does not have a parent and is a top
level widget. close() needs to be called so that QApplication
can exit the application if quitOnLastWindowClosed is set
and a InspectorClientView is the last window, otherwise
the application will never exit.
- Api/qwebview.cpp: (QWebViewPrivate::_q_pageDestroyed): (QWebView::setPage):
- Api/qwebview.h:
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientView::InspectorClientView):
Sep 3, 2009:
- 10:24 PM Changeset in webkit [48038] by
-
- 4 edits3 adds in trunk
2009-09-03 Kent Tamura <tkent@chromium.org>
Reviewed by David Levin.
Test for HTMLTextAreaElement.textLength
https://bugs.webkit.org/show_bug.cgi?id=28929
- fast/forms/resources/textarea-textlength.js: Added.
- fast/forms/textarea-textlength-expected.txt: Added.
- fast/forms/textarea-textlength.html: Added.
2009-09-03 Kent Tamura <tkent@chromium.org>
Reviewed by David Levin.
Add support for HTMLTextAreaElement.textLength
https://bugs.webkit.org/show_bug.cgi?id=28929
Test: fast/forms/textarea-textlength.html
- html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::textLength):
- html/HTMLTextAreaElement.idl:
- 5:27 PM Changeset in webkit [48037] by
-
- 3 edits3 adds in trunk
Reviewed by Darin Adler.
<rdar://problem/7180197>, https://bugs.webkit.org/show_bug.cgi?id=28822
REGRESSION(r31231): Creating document with current document's DOCTYPE causes crashes
Test: fast/dom/DOMImplementation/createDocument-with-used-doctype.html
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Even though we cannot raise an exception immediately out of fear of breaking Acid3, we shouldn't use a DocumentType node in two documents.
- 4:57 PM Changeset in webkit [48036] by
-
- 3 edits9 adds in trunk
WebCore: Page Cache should support pages with Frames.
https://bugs.webkit.org/show_bug.cgi?id=13631
Reviewed by Sam Weinig.
Tests: fast/events/pageshow-pagehide-on-back-cached-with-frames.html
fast/loader/frames-with-unload-handlers-in-page-cache.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):
LayoutTests: Page Cache should support pages with Frames.
https://bugs.webkit.org/show_bug.cgi?id=13631
Reviewed by Sam Weinig.
- fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt: Added.
- fast/events/pageshow-pagehide-on-back-cached-with-frames.html: Added.
- fast/events/resources/pageshow-pagehide-subframe-cachable.html: Added.
- fast/events/resources/pageshow-pagehide-subsubframe-cachable.html: Added.
- fast/loader/frames-with-unload-handlers-in-page-cache-expected.txt: Added.
- fast/loader/frames-with-unload-handlers-in-page-cache.html: Added.
- fast/loader/resources/notify-done.html: Added.
- fast/loader/resources/subframe-with-subsubframe-with-unload-handler.html: Added.
- fast/loader/resources/subframe-with-unload-handler.html: Added.
- 4:23 PM Changeset in webkit [48035] by
-
- 7 edits5 adds in trunk
2009-09-03 Steve VanDeBogart <vandebo@chromium.org>
Reviewed by Eric Seidel.
Check that middle click triggers an onpaste event in Linux.
https://bugs.webkit.org/show_bug.cgi?id=28696
- platform/gtk/editing/pasteboard: Added.
- platform/gtk/editing/pasteboard/middle-click-onpaste-expected.txt: Added.
- platform/gtk/editing/pasteboard/resources: Added.
- platform/gtk/editing/pasteboard/resources/TEMPLATE.html: Added.
- platform/gtk/editing/pasteboard/resources/middle-click-onpaste.js: Added. (handlePaste):
2009-09-03 Steve VanDeBogart <vandebo@chromium.org>
Reviewed by Eric Seidel.
Handle middle click in Chromium like QT
https://bugs.webkit.org/show_bug.cgi?id=28696
Tested by middle-click-onpaste.html.
- platform/Pasteboard.h:
- platform/chromium/ChromiumBridge.h:
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::getData):
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::isSelectionMode): (WebCore::Pasteboard::setSelectionMode): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
- platform/chromium/PasteboardPrivate.h: (WebCore::PasteboardPrivate::):
- 4:10 PM Changeset in webkit [48034] by
-
- 2 edits in trunk/WebCore
More partial work towards "Page Cache should support pages with Frames"
https://bugs.webkit.org/show_bug.cgi?id=13631
Reviewed by Sam Weinig.
Fix a bug where subframes weren't asked if they were cacheable.
No new tests, especially since page caching for frames isn't turned on yet.
A layout test will come in my next patch, which enables frames in the page cache.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::canCachePageContainingThisFrame):
- 4:08 PM Changeset in webkit [48033] by
-
- 2 edits in trunk/WebKit/mac
2009-09-03 Adam Barth <abarth@webkit.org>
Unreviewed build fix.
Change notImplemented() to a FIXME.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
- 3:59 PM Changeset in webkit [48032] by
-
- 18 edits in trunk
2009-09-03 Adam Barth <abarth@webkit.org>
Reviewed by eric@webkit.org.
Added mixed content methods to FrameLoaderClient.
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didDisplayInsecureContent): (WebCore::EmptyFrameLoaderClient::didRunInsecureContent):
- loader/FrameLoaderClient.h:
2009-09-03 Adam Barth <abarth@webkit.org>
Reviewed by eric@webkit.org.
Stub implementations of mixed content methods of FrameLoaderClient.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didDisplayInsecureContent): (WebKit::FrameLoaderClient::didRunInsecureContent):
- WebCoreSupport/FrameLoaderClientGtk.h:
2009-09-03 Adam Barth <abarth@webkit.org>
Reviewed by eric@webkit.org.
Stub implementations of mixed content methods of FrameLoaderClient.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
2009-09-03 Adam Barth <abarth@webkit.org>
Reviewed by eric@webkit.org.
Stub implementations of mixed content methods of FrameLoaderClient.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didDisplayInsecureContent): (WebCore::FrameLoaderClientQt::didRunInsecureContent):
- WebCoreSupport/FrameLoaderClientQt.h:
2009-09-03 Adam Barth <abarth@webkit.org>
Reviewed by eric@webkit.org.
Stub implementations of mixed content methods of FrameLoaderClient.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
- WebCoreSupport/WebFrameLoaderClient.h:
2009-09-03 Adam Barth <abarth@webkit.org>
Reviewed by eric@webkit.org.
Stub implementations of mixed content methods of FrameLoaderClient.
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::didDisplayInsecureContent): (WebCore::FrameLoaderClientWx::didRunInsecureContent):
- WebKitSupport/FrameLoaderClientWx.h:
- 2:37 PM Changeset in webkit [48031] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Access private member variables directly instead of using the
accessor.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame): (WebKit::FrameLoaderClient::windowObjectCleared):
- 1:25 PM Changeset in webkit [48030] by
-
- 2 edits in trunk/LayoutTests
Exception.toString() on Qt seems to print out a different value than other platforms.
https://bugs.webkit.org/show_bug.cgi?id=28952
Reviewed by Dave Levin.
- platform/qt/Skipped:
Disabled new worker tests that rely on the string format of DOM exceptions until bug #28952 is resolved.
- 12:38 PM Changeset in webkit [48029] by
-
- 19 edits6 adds in trunk
Reviewed by Kevin Ollivier.
[wx] Frames support
https://bugs.webkit.org/show_bug.cgi?id=19041
- 12:35 PM Changeset in webkit [48028] by
-
- 3 edits in trunk/WebCore
[Qt] Page content is not displayed in case of HTTP status error
https://bugs.webkit.org/show_bug.cgi?id=28949
Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-03
Reviewed by Simon Hausmann.
If the server sent content, show it to the user instead of an error,
even if the HTTP status code is not success.
- platform/network/qt/QNetworkReplyHandler.cpp:
- platform/network/qt/QNetworkReplyHandler.h:
- 12:07 PM Changeset in webkit [48027] by
-
- 4 edits in trunk/WebKitTools
<http://webkit.org/b/28880> svn-apply --force doesn't actually work
Reviewed by Eric Seidel.
This fixes "svn-apply --force" and adds unit tests for the
scm.apply_patch() method which uses this script.
- Scripts/svn-apply: Created $globalExitCode variable that defaults to 0. Exit with a value of $globalExitCode when the script is finished. (applyPatch): Ignore a non-zero $exitCode if $force is true, but set $globalExitCode to $exitCode so that svn-apply exits with a non-zero status if any patches did not apply cleanly. Also print out the actual patch command if $force was not true.
- Scripts/modules/scm.py: (scripts_directory): Added. Extracted from script_path(). (script_path): Extracted scripts_directory().
- Scripts/modules/scm_unittest.py: Import urllib. (SVNTestRepository.setup): Save the original working directory in test_object since this represents the WebKit repository from where the unit tests are run. (SCMTest): Created new super class to hold utility methods. (SCMTest._create_patch): Creates a patch file on disk and a dictionary for use with scm.svn_apply(). (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink back to WebKitTools/Scripts in the test repository so that scm.apply_patch() is able to find the svn-apply script. (SVNTest): Inherit from SCMTest instead of unittest.TestCase. (SVNTest.tearDown): Make sure to change directories back to the original_path before the next test. (SVNTest.test_apply_svn_patch): New test case for applying an svn patch with scm.apply_patch(). (SVNTest.test_apply_svn_patch_force): New test case for applying an svn patch with scm.apply_patch() that conflicts. (GitTest): Inherit from SCMTest instead of unittest.TestCase. (GitTest.tearDown): Make sure to change directories back to the original_path before the next test. (GitTest.test_apply_git_patch): New test case for applying a git patch with scm.apply_patch(). (GitTest.test_apply_git_patch_force): New test case for applying a git patch with scm.apply_patch() that conflicts.
- 11:36 AM Changeset in webkit [48026] by
-
- 7 edits2 adds in trunk/WebCore
Need to update v8 bindings to support passing multiple ports to postMessage()
https://bugs.webkit.org/show_bug.cgi?id=28839
Reviewed by Dimitri Glazkov.
Added support for passing MessagePortArray to v8 bindings.
New tests that now pass with V8:
fast/events/message-port-multi.html
fast/workers/worker-context-multi-port.html
fast/workers/worker-multi-port.html
- WebCore.gypi:
Added V8MessageEventCustom.cpp and V8MessagePortCustom.h
- bindings/v8/custom/V8CustomBinding.h:
Added custom postMessage() handlers for various classes.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::DOMWindowPostMessage):
Added custom handler that supports MessagePortArray.
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::DedicatedWorkerContextPostMessage):
Added custom handler that supports MessagePortArray.
- bindings/v8/custom/V8MessageEventCustom.cpp: Added.
(WebCore::MessageEventPorts):
Added getter for ports attribute.
(WebCore::MessageEventInitMessageEvent):
Added custom handler that supports MessagePortArray.
- bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::MessagePortPostMessage):
Added custom handler that supports MessagePortArray.
(WebCore::getMessagePortArray):
Added helper function that supports converting from a sequence-like object to a MessagePortArray.
- bindings/v8/custom/V8MessagePortCustom.h: Added.
Added declaration for getMessagePortArray().
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::WorkerPostMessage):
Added custom handler that supports MessagePortArray.
- 11:36 AM Changeset in webkit [48025] by
-
- 47 edits1 copy12 adds in trunk
WebCore: Need to update JS bindings and IDL files to support multiple message ports in postMessage()
https://bugs.webkit.org/show_bug.cgi?id=28460
Reviewed by Sam Weinig.
Added new toJSSequence() API which validates that a JSValue meets the WebIDL criteria for a sequence.
Tests: fast/events/message-port-multi.html
fast/workers/worker-context-multi-port.html
fast/workers/worker-multi-port.html
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
Added JSMessagePortCustom.h and JSMessageEventCustom.cpp.
- bindings/js/JSDOMBinding.cpp:
(WebCore::toJSSequence):
Added toJSSequence() API to do validation on sequence-like objects per WebIDL.
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArrays.
- bindings/js/JSDedicatedWorkerContextCustom.cpp:
(WebCore::JSDedicatedWorkerContext::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArrays.
- bindings/js/JSMessageEventCustom.cpp: Added.
(WebCore::JSMessageEvent::ports):
Added custom ports() getter that converts from MessagePortArray to JSArray.
(WebCore::JSMessageEvent::initMessageEvent):
Added support for passing a MessagePortArray.
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArray.
(WebCore::fillMessagePortArray):
New helper routine that validates/converts from a JS sequence o a WebCore::MessagePortArray.
- bindings/js/JSMessagePortCustom.h: Added.
- bindings/js/JSWorkerCustom.cpp:
(WebCore::JSWorker::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArray.
- dom/MessageEvent.cpp:
- dom/MessageEvent.h:
(WebCore::MessageEvent::ports):
Changed ports() to return a MessagePortArray* since this value can be null.
- dom/MessageEvent.idl:
Updated IDL to match HTML5 spec (now accepts MessagePortArrays instead of a solitary MessagePort).
- dom/MessagePort.cpp:
- dom/MessagePort.h:
- dom/MessagePort.idl:
Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).
- page/DOMWindow.h:
- page/DOMWindow.idl:
Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).
- workers/DedicatedWorkerContext.cpp:
- workers/DedicatedWorkerContext.h:
- workers/DedicatedWorkerContext.idl:
Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).
- workers/Worker.cpp:
- workers/Worker.h:
- workers/Worker.idl:
Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).
LayoutTests: Need to update JS bindings and IDL files to support multiple message ports in postMessage()
https://bugs.webkit.org/show_bug.cgi?id=28460
Reviewed by Sam Weinig.
Updated layout tests to match new postMessage() and MessageEvent APIs.
Added new layout tests to test sending/receiving multiple ports.
- fast/dom/Window/window-postmessage-args-expected.txt:
- fast/dom/Window/window-postmessage-args.html:
Updated to match new postMessage API.
- fast/events/init-events-expected.txt:
- fast/events/message-channel-gc-4.html:
Updated to match new postMessage API.
- fast/events/message-port-clone.html:
Updated to match new postMessage API.
- fast/events/message-port-deleted-document.html:
Updated to match new postMessage API.
- fast/events/message-port-deleted-frame.html:
Updated to match new postMessage API.
- fast/events/message-port-inactive-document.html:
Updated to match new postMessage API.
- fast/events/message-port-multi-expected.txt: Added.
- fast/events/message-port-multi.html: Added.
Added tests for various cases of sending multiple ports.
- fast/events/message-port.html:
Updated to match new postMessage API.
- fast/events/resources/init-events.js:
Added tests for sending ports to initMessageEvent()
- fast/events/resources/message-port-iframe.html:
- fast/events/resources/message-port-multi.js: Added.
Added tests for various cases of sending multiple ports.
- fast/workers/resources/shared-worker-common.js:
(onconnect):
Updated to reflect new MessageEvent API.
- fast/workers/resources/shared-worker-script-error.js:
(onconnect):
Updated to reflect new MessageEvent API.
- fast/workers/resources/worker-cloneport.js:
(onmessage):
Updated to reflect new MessageEvent API.
- fast/workers/resources/worker-context-multi-port.js: Added.
(worker.onmessage):
Added tests for various cases of sending multiple ports.
- fast/workers/resources/worker-context-thread-multi-port.js: Added.
Added tests for various cases of sending multiple ports.
- fast/workers/resources/worker-messageport.js:
(onmessage):
Updated to reflect new MessageEvent API.
- fast/workers/resources/worker-multi-port.js: Added.
(worker.onmessage):
Added tests for various cases of sending multiple ports.
- fast/workers/resources/worker-thread-multi-port.js: Added.
(onmessage):
Worker-thread side of multiple port layout test.
(testPassed):
(testFailed):
- fast/workers/worker-cloneport.html:
- fast/workers/worker-context-multi-port-expected.txt: Added.
- fast/workers/worker-context-multi-port.html: Added.
Added tests for sending multiple ports from the worker thread.
- fast/workers/worker-messageport-expected.txt:
- fast/workers/worker-messageport-gc.html:
- fast/workers/worker-messageport.html:
- fast/workers/worker-multi-port-expected.txt: Added.
- fast/workers/worker-multi-port.html: Added.
- 9:54 AM Changeset in webkit [48024] by
-
- 2 edits in trunk/WebCore
2009-09-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Do not query non-function call frames for function name.
- inspector/front-end/InjectedScript.js: (InjectedScript.CallFrameProxy): (InjectedScript.CallFrameProxy.prototype._wrapScopeChain):
- 9:52 AM Changeset in webkit [48023] by
-
- 2 edits in trunk/WebKit
- StringsNotToBeLocalized.txt:
Brought this file up to date.
Reviewed by Adam Roben
- 9:51 AM Changeset in webkit [48022] by
-
- 2 edits in trunk/WebCore
2009-09-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Crash after typing "clear" and pressing return in inspector console.
- inspector/front-end/InjectedScript.js: (InjectedScript._clearConsoleMessages): (InjectedScript._inspectObject): (InjectedScript._ensureCommandLineAPIInstalled):
- 9:09 AM Changeset in webkit [48021] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip a couple of failing layout-tests
Rubber-stamped by Ariya Hidayat.
We skip most of the D&D tests already, and the animation test
seems to be flakey on our platform since the commit that triggered
it only touched V8 bindings.
- platform/qt/Skipped:
- 6:56 AM Changeset in webkit [48020] by
-
- 3 edits in trunk/WebCore
2009-09-03 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
[V8] Squeezed out some performance from string conversion.
https://bugs.webkit.org/show_bug.cgi?id=28945
- bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource): (WebCore::WebCoreStringResource::data): (WebCore::WebCoreStringResource::length): (WebCore::WebCoreStringResource::atomicString): (WebCore::WebCoreStringResource::string): Avoid calling virtual length method. Be more explicit with external memory computation. Avoid function calls in data and length. (WebCore::): (WebCore::v8StringToWebCoreString): (WebCore::v8StringToAtomicWebCoreString): (WebCore::v8NonStringValueToWebCoreString): (WebCore::v8NonStringValueToAtomicWebCoreString): Avoid extra calls of WebCoreStringResource::toString. When AtomicString is computed pass it immediately when constructing WebCoreStringResource. Use inline buffer for small strings.
- bindings/v8/V8Binding.h: (WebCore::v8ValueToWebCoreString): (WebCore::v8ValueToAtomicWebCoreString): (WebCore::toString): Inline dispatch of string vs. non-string values.
- 6:49 AM Changeset in webkit [48019] by
-
- 3 edits in trunk/WebCore
2009-09-03 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
[V8] Inlined common case of V8IsolatedWorld::getEntered to speed
up V8Proxy lookup.
https://bugs.webkit.org/show_bug.cgi?id=28946
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::getEnteredImpl):
- bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::getEntered):
- 6:40 AM Changeset in webkit [48018] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Remove bogus asserts that break Debug builds at runtime.
- WebCoreSupport/DocumentLoaderGtk.cpp: (WebKit::DocumentLoader::detachFromFrame): (WebKit::DocumentLoader::decreaseLoadCount):
- 5:57 AM Changeset in webkit [48017] by
-
- 52 edits in trunk/LayoutTests
2009-09-03 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Update outdated metrics in css2.1/t170602-bdr-conflct-w-* (50 files).
Remove these files from Skipped.
- platform/qt/Skipped:
- platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
- 4:53 AM Changeset in webkit [48016] by
-
- 19 edits in trunk/LayoutTests
2009-09-03 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Update outdated metrics in css2.1/t1202-counters-* (17 files).
Remove these files from Skipped.
- platform/qt/Skipped:
- platform/qt/css2.1/t1202-counters-00-b-expected.txt:
- platform/qt/css2.1/t1202-counters-01-b-expected.txt:
- platform/qt/css2.1/t1202-counters-02-b-expected.txt:
- platform/qt/css2.1/t1202-counters-03-b-expected.txt:
- platform/qt/css2.1/t1202-counters-05-b-expected.txt:
- platform/qt/css2.1/t1202-counters-06-b-expected.txt:
- platform/qt/css2.1/t1202-counters-07-b-expected.txt:
- platform/qt/css2.1/t1202-counters-08-b-expected.txt:
- platform/qt/css2.1/t1202-counters-09-b-expected.txt:
- platform/qt/css2.1/t1202-counters-11-b-expected.txt:
- platform/qt/css2.1/t1202-counters-12-b-expected.txt:
- platform/qt/css2.1/t1202-counters-13-b-expected.txt:
- platform/qt/css2.1/t1202-counters-14-b-expected.txt:
- platform/qt/css2.1/t1202-counters-15-b-expected.txt:
- platform/qt/css2.1/t1202-counters-16-c-expected.txt:
- platform/qt/css2.1/t1202-counters-17-d-expected.txt:
- platform/qt/css2.1/t1202-counters-18-f-expected.txt:
- 3:50 AM Changeset in webkit [48015] by
-
- 2 edits in trunk/LayoutTests
[Qt] Disable a few tests that require new controller features
Reviewed by Ariya Hidayat.
- platform/qt/Skipped:
- 3:44 AM Changeset in webkit [48014] by
-
- 1 edit3 adds in trunk/LayoutTests
[Qt/Linux] Add platform-spesific result for plugin-javascript-access
Rubber-stamped by Simon Hausmann..
- platform/qt-linux/plugins/plugin-javascript-access-expected.txt: Added.
- 2:47 AM Changeset in webkit [48013] by
-
- 18 edits in trunk/LayoutTests
2009-09-03 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Update outdated metrics in css2.1/t140201* (16 files).
Remove these files from Skipped.
- platform/qt/Skipped:
- platform/qt/css2.1/t140201-c532-bgcolor-00-a-expected.txt:
- platform/qt/css2.1/t140201-c532-bgcolor-01-b-expected.txt:
- platform/qt/css2.1/t140201-c533-bgimage-00-a-expected.txt:
- platform/qt/css2.1/t140201-c533-bgimage-01-b-g-expected.txt:
- platform/qt/css2.1/t140201-c534-bgre-00-b-ag-expected.txt:
- platform/qt/css2.1/t140201-c534-bgre-01-b-ag-expected.txt:
- platform/qt/css2.1/t140201-c534-bgreps-00-c-ag-expected.txt:
- platform/qt/css2.1/t140201-c534-bgreps-01-c-ag-expected.txt:
- platform/qt/css2.1/t140201-c534-bgreps-02-c-ag-expected.txt:
- platform/qt/css2.1/t140201-c534-bgreps-03-c-ag-expected.txt:
- platform/qt/css2.1/t140201-c534-bgreps-04-c-ag-expected.txt:
- platform/qt/css2.1/t140201-c534-bgreps-05-c-ag-expected.txt:
- platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
- platform/qt/css2.1/t140201-c536-bgpos-00-b-ag-expected.txt:
- platform/qt/css2.1/t140201-c536-bgpos-01-b-ag-expected.txt:
- platform/qt/css2.1/t140201-c537-bgfxps-00-c-ag-expected.txt:
- 2:38 AM Changeset in webkit [48012] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
Add strnstr for Linux and Windows in StringExtras.h
https://bugs.webkit.org/show_bug.cgi?id=28901
- wtf/StringExtras.h: (strnstr):
- 2:29 AM Changeset in webkit [48011] by
-
- 8 edits6 adds in trunk
2009-09-03 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Tests for maxLength and IME input.
https://bugs.webkit.org/show_bug.cgi?id=25253
- fast/forms/input-maxlength-ime-completed-expected.txt: Added.
- fast/forms/input-maxlength-ime-completed.html: Added.
- fast/forms/input-maxlength-ime-preedit-expected.txt: Added.
- fast/forms/input-maxlength-ime-preedit.html: Added.
- fast/forms/resources/input-maxlength-ime-completed.js: Added.
- fast/forms/resources/input-maxlength-ime-preedit.js: Added.
- platform/gtk/Skipped:
- platform/win/Skipped:
2009-09-03 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Fix a regression bug that maxLength doesn't work for IME input.
https://bugs.webkit.org/show_bug.cgi?id=25253
Tests: fast/forms/input-maxlength-ime-completed.html
fast/forms/input-maxlength-ime-preedit.html
- dom/InputElement.cpp: (WebCore::InputElement::handleBeforeTextInsertedEvent):
- dom/InputElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
- 2:12 AM Changeset in webkit [48010] by
-
- 3 edits3 adds in trunk
2009-09-03 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Make SVGStyleElement title/media/type setters do something
https://bugs.webkit.org/show_bug.cgi?id=28828
- svg/dom/resources/style-reflect.js: Added.
- svg/dom/style-reflect-expected.txt: Added.
- svg/dom/style-reflect.html: Added.
2009-09-03 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Make SVGStyleElement title/media/type setters do something
https://bugs.webkit.org/show_bug.cgi?id=28828
Test: svg/dom/style-reflect.html
- svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::setXmlspace): Actually change the attribute. (WebCore::SVGStyleElement::setType): Ditto. (WebCore::SVGStyleElement::setMedia): Ditto. (WebCore::SVGStyleElement::setTitle): Ditto.
- 2:08 AM Changeset in webkit [48009] by
-
- 3 edits in trunk/WebKitTools
[Qt] Add support for platform-spesific layout-test results
Reviewed by Mark Rowe.
For the Qt port we use the qt-[mac|linux|win] directories and then fall
back to the generic qt directory for both test results and skipped list.
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
- 2:04 AM Changeset in webkit [48008] by
-
- 3 edits2 adds in trunk
2009-09-03 Ben Murdoch <benm@google.com>
https://bugs.webkit.org/show_bug.cgi?id=28872
Test to verify statement error callbacks behave as expected when they return true or throw an exception.
- storage/statement-error-callback-expected.txt: Added with properties svn:eol-style.
- storage/statement-error-callback.html: Added with properties svn:eol-style.
2009-09-03 Ben Murdoch <benm@google.com>
Fixes a bug where handleEvent() in the V8 Custom SQL Statement Error binding would not return the correct result to WebCore after invoking the callback.
Test: storage/statement-error-callback.html
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8CustomSQLStatementErrorCallback::handleEvent): Return true from handleEvent() if the callback raised an exception or the callback itself returned true.
- 1:57 AM Changeset in webkit [48007] by
-
- 4 edits in trunk/WebKit/qt
2009-09-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Add a setting to turn SessionStorage on/off
https://bugs.webkit.org/show_bug.cgi?id=28836
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
- Api/qwebsettings.h:
- tests/qwebpage/tst_qwebpage.cpp: (testFlag): (tst_QWebPage::testOptionalJSObjects):
- 1:50 AM Changeset in webkit [48006] by
-
- 1 edit3 adds in trunk/WebCore
2009-09-03 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Adding three font-specific files to WebCore:
FontCustomPlatformData.cpp, FontCustomPlatformData.h,
and FontPlatformData.h
https://bugs.webkit.org/show_bug.cgi?id=28131
- platform/graphics/haiku/FontCustomPlatformData.cpp: Added. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
- platform/graphics/haiku/FontCustomPlatformData.h: Added. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
- platform/graphics/haiku/FontPlatformData.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::bold): (WebCore::FontPlatformData::oblique): (WebCore::FontPlatformData::hashTableDeletedFontValue):
- 12:14 AM Changeset in webkit [48005] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-03 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's HashEntry class
https://bugs.webkit.org/show_bug.cgi?id=27830
Inherits HashEntry class from FastAllocBase because it has been
instantiated by 'new' JavaScriptCore/runtime/Lookup.cpp:32.
- runtime/Lookup.h:
