Timeline


and

09/08/09:

22:55 Changeset [48201] by oliver@apple.com

Reviewed by NOBODY (Build fix).

Remove a few incorrect changes I left in.

21:32 Changeset [48200] by oliver@apple.com

Support numeric index getters in bindings
https://bugs.webkit.org/show_bug.cgi?id=29067

Reviewed by Sam Weinig.

Add HasNumericIndexGetter to indicate a non-custom getter that
returns a number. The numeric index getter also uses PropertySlot's
setValue rather than setCustomIndex to avoid an additional indirect
call.

20:03 Changeset [48199] by dglazkov@chromium.org

2009-09-08 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Mark Rowe.

Reduce dglazkov's boboiness by properly concatenating revision value.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution

rather than "+".

19:25 Changeset [48198] by kevino@webkit.org

wxWebKit Python extension build fix - get swig.py if it doesn't exist.

19:20 Changeset [48197] by kevino@webkit.org

wx build fix for 2.8.

18:45 Changeset [48196] by atwilson@chromium.org

shared-worker-exception.html needs to pause to let console messages get written out
https://bugs.webkit.org/show_bug.cgi?id=29043

Reviewed by Maciej Stachowiak.

  • fast/workers/resources/shared-worker-exception.js:

(worker.onmessage):
Now invokes layoutTestController.notifyDone() via a timer so any pending ReportException tasks get a chance to fire.

17:29 Changeset [48195] by eric@webkit.org

2009-09-08 Jens Alfke <snej@chromium.org>

Reviewed by Eric Seidel.

In Mac Chromium, clicking below the last line of an editable area (textarea or
contenteditable) should put the caret at the end of the last line, as in Mac Safari.

Tests: LayoutTests/editing/selection/click-in-margins-inside-editable-div.html

LayoutTests/editing/selection/click-in-padding-with-multiple-line-boxes.html

  • page/Settings.cpp: (WebCore::Settings::Settings): Change #if PLATFORM_MAC to be Mac-Chrome-inclusive.
17:01 Changeset [48194] by mrowe@apple.com

Fix an incorrect variable name in UpdateChromiumSource.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
15:51 Changeset [48193] by mrowe@apple.com

Don't check for leaks on the release SnowLeopard builder.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
15:39 Changeset [48192] by mrowe@apple.com

Add a SnowLeopard release builder.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
15:17 Changeset [48191] by hyatt@apple.com

Make sure not to do an early return when a data URL stylesheet successfully loads. We need to still
clear the old cached sheet out of all existing Frames. Fixes the data URL stylesheet layout test failure.

Reviewed by Mark Rowe.

  • page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):

15:14 Changeset [48190] by weinig@apple.com

Fix windows build.

  • dom/Document.idl:
15:11 Changeset [48189] by kevino@webkit.org

More robust wx build fix for 2.9.

15:02 Changeset [48188] by weinig@apple.com

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=27046
Implement CSSOM DocumentView.caretRangeFromPoint

Reviewed by Timothy Hatcher.

Tests: fast/dom/Document/CaretRangeFromPoint/basic.html

fast/dom/Document/CaretRangeFromPoint/replace-element.html

  • dom/Document.cpp:

(WebCore::Document::caretRangeFromPoint):

  • dom/Document.h:
  • dom/Document.idl:

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=27046
Implement CSSOM DocumentView.caretRangeFromPoint

Reviewed by Timothy Hatcher.

  • fast/dom/Document/CaretRangeFromPoint: Added.
  • fast/dom/Document/CaretRangeFromPoint/basic-expected.txt: Added.
  • fast/dom/Document/CaretRangeFromPoint/basic.html: Added.
  • fast/dom/Document/CaretRangeFromPoint/replace-element-expected.txt: Added.
  • fast/dom/Document/CaretRangeFromPoint/replace-element.html: Added.
  • fast/dom/Window/window-properties-expected.txt:
14:46 Changeset [48187] by levin@chromium.org

Remove end of line whitespace check from check-webkit-style.
https://bugs.webkit.org/show_bug.cgi?id=29053

Patch by David Levin <levin@chromium.org> on 2009-09-08
Reviewed by Darin Adler.

  • Scripts/modules/cpp_style.py:
14:32 Changeset [48186] by kevino@webkit.org

wx build fix, generate derived sources earlier in order to make sure
they're found by the build system when generating the list of sources to build.

14:11 Changeset [48185] by japhet@chromium.org

2009-09-08 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

<iterator> include in V8Proxy.h is spurious and causing ObjC compile issues for Chromium.

Test: Chromium mac canary build is fixed.

14:05 Changeset [48184] by bweinstein@apple.com

2009-09-08 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Adam Roben.

Updated results for media/audio-controls-rendering.html, and added 3 failing
tests to the Skipped list to investigate further <http://webkit.org/b/29047>.

  • platform/win/Skipped:
  • platform/win/media/audio-controls-rendering-expected.txt:
14:01 Changeset [48183] by kov@webkit.org

2009-09-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=29044
[GTK] Should update suggested-filename when the response is received

Set suggested filename also when the response only comes after the
download has started.

  • webkit/webkitdownload.cpp: (webkit_download_set_response): (webkit_download_set_suggested_filename):
  • webkit/webkitwebview.cpp: (webkit_web_view_request_download):
13:34 Changeset [48182] by xan@webkit.org

2009-09-08 Xan Lopez <xlopez@igalia.com>

Unreviewed attempt to fix the GTK+ build.

  • GNUmakefile.am:
13:26 Changeset [48181] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=28987, make the Document cache the page's user stylesheet in
parsed form. Allows the sheet to survive across destruction/re-creation of the CSSStyleSelector.

Reviewed by Eric Seidel.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):

  • css/CSSStyleSelector.h:
  • dom/Document.cpp:

(WebCore::Document::attach):
(WebCore::Document::pageUserSheet):
(WebCore::Document::clearPageUserSheet):
(WebCore::Document::recalcStyleSelector):

  • dom/Document.h:
  • loader/PlaceholderDocument.cpp:

(WebCore::PlaceholderDocument::attach):

  • page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):

  • page/Settings.cpp:

(WebCore::Settings::setUserStyleSheetLocation):

13:23 Changeset [48180] by kenneth@webkit.org

Unreviewed buildfix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Fix Qt build after 48167, by adding the new cpp/h files
added to WebCore.gypi to WebCore.pro as well.

  • WebCore.pro:
13:11 Changeset [48179] by kenneth@webkit.org

Unreviewed build fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Potential build fix for Qt 4.5

  • Api/qwebpage.cpp:

(QWebPagePrivate::mousePressEvent):

13:06 Changeset [48178] by xan@webkit.org

2009-09-08 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

should not pass URI fragments to libsoup
https://bugs.webkit.org/show_bug.cgi?id=28687

Strip the fragment from the URI before passing it to soup, since
it forwards it to servers in some cases (like when using a proxy)
which confuses them and makes them return 403/404.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp): (WebCore::):
12:40 Changeset [48177] by kenneth@webkit.org

WebCore: Add QGraphicsScene events support to the Qt platform events.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.

  • platform/PlatformMouseEvent.h:
  • platform/PlatformWheelEvent.h:
  • platform/qt/PlatformMouseEventQt.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/qt/WheelEventQt.cpp:

(WebCore::PlatformWheelEvent::applyDelta):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit/qt: Add support for handling QGraphicsScene events.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:

(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseTripleClickEvent):
(QWebPagePrivate::handleClipboard):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::wheelEvent):
(QWebPagePrivate::dragEnterEvent):
(QWebPagePrivate::dragLeaveEvent):
(QWebPagePrivate::dragMoveEvent):
(QWebPagePrivate::dropEvent):
(QWebPage::event):

  • Api/qwebpage_p.h:
12:40 Changeset [48176] by weinig@apple.com

Update Security Group Members list.

Reviewed by Adele Peterson.

  • security/security-group-members.html:
12:28 Changeset [48175] by eric@webkit.org

2009-09-08 Michael Nordman <michaeln@google.com>

Reviewed by Eric Seidel.

[Chromium] Cleanup: remove a few deprecated methods.
https://bugs.webkit.org/show_bug.cgi?id=28960

No new tests, just syntactic sugar.

  • platform/network/chromium/ResourceRequest.h:
  • platform/network/chromium/ResourceResponse.h:
12:21 Changeset [48174] by eric@webkit.org

2009-09-08 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Ariya Hidayat.

https://bugs.webkit.org/show_bug.cgi?id=28981

[Qt] make npapi.h compile in winscw compiler.

Add XP_SYMBIAN macro to identify Symbian OS; this macro should be used for Symbian
specific changes in npapi.h.
Undefine XP_WIN when building for Symbian to avoid including Windows specific code.

  • bridge/npapi.h:
12:06 Changeset [48173] by kov@webkit.org

2009-09-08 Priit Laes <plaes@plaes.org>

Reviewed by Gustavo Noronha.

Fix up erroneus 'Since: @version@' tags in documentation.

  • webkit/webkitwebdatasource.cpp:
  • webkit/webkitwebresource.cpp: (webkit_web_resource_class_init):
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
  • webkit/webkitwebwindowfeatures.cpp:
12:02 Changeset [48172] by oliver@apple.com

Web Inspector assertion failure related to marking
https://bugs.webkit.org/show_bug.cgi?id=28997

Reviewed by Geoff Garen.

When wrapping the callback the JSInspectorCallbackWrapper creator was using
inheritorID for the prototype structure which is unsafe for anything other
than a pure JS object. Instead we now create a new structure, which while
inefficient is not problematic as this code is not hit frequently.

11:34 Changeset [48171] by dglazkov@chromium.org

2009-09-08 Kelly Norton <knorton@google.com>

Reviewed by Dimitri Glazkov.

Add missing extension to the file entry in WebCore.vcproj.

  • WebCore.vcproj/WebCore.vcproj: Added "cpp".
11:02 Changeset [48170] by eric@webkit.org

2009-09-08 Cameron McCormack <cam@mcc.id.au>

Reviewed by Darin Adler.

Fix DumpRenderTree build from clean tree on Tiger
https://bugs.webkit.org/show_bug.cgi?id=28927

  • DumpRenderTree/mac/PerlSupport/Makefile: Ensure the DerivedSources/DumpRenderTree directory exists when building on Tiger.
11:02 Changeset [48169] by jianli@chromium.org

WebCore: dataTransfer.types() should not return Files if file list is empty in the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28891

Reviewed by David Levin.

We change the behavior to handle the empty file list in order to match the spec.

Tested by clipboard-file-access.html.

  • platform/mac/ClipboardMac.mm:

(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):

LayoutTests: dataTransfer.types() should not return Files if file list is empty in the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28891

Reviewed by David Levin.

Update the test script and expected result to reflect the behavior change.

  • http/tests/security/clipboard/clipboard-file-access-expected.txt:
  • http/tests/security/clipboard/resources/clipboard-file-access.js:
10:58 Changeset [48168] by japhet@chromium.org

2009-09-08 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by Eric Seidel.

Handle middle click in Chromium like QT
https://bugs.webkit.org/show_bug.cgi?id=28696

Tested by middle-click-onpaste.html.

10:55 Changeset [48167] by eric@webkit.org

2009-09-08 Kelly Norton <knorton@google.com>

Reviewed by Eric Seidel.

WebInspector: Adds a timeline agent to InspectorController that collects
high-level timing data about event dispatch, layout, painting and HTML
parsing and makes it available to Inspector.
https://bugs.webkit.org/show_bug.cgi?id=25503

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • dom/Document.h: (WebCore::Document::inspectorTimelineAgent):
  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
  • inspector/DOMDispatchTimelineItem.cpp: Added. (WebCore::DOMDispatchTimelineItem::DOMDispatchTimelineItem): (WebCore::DOMDispatchTimelineItem::convertToScriptObject):
  • inspector/DOMDispatchTimelineItem.h: Added. (WebCore::DOMDispatchTimelineItem::~DOMDispatchTimelineItem):
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::enableTimeline): (WebCore::InspectorBackend::disableTimeline): (WebCore::InspectorBackend::timelineEnabled):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::enableTimeline): (WebCore::InspectorController::disableTimeline): (WebCore::InspectorController::timelineEnabled):
  • inspector/InspectorController.h: (WebCore::InspectorController::timelineAgent):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::timelineWasEnabled): (WebCore::InspectorFrontend::timelineWasDisabled): (WebCore::InspectorFrontend::addItemToTimeline):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorTimelineAgent.cpp: Added. (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::currentTimeInMilliseconds): (WebCore::InspectorTimelineAgent::sessionTimeInMilliseconds):
  • inspector/InspectorTimelineAgent.h: Added.
  • inspector/TimelineItem.cpp: Added. (WebCore::TimelineItem::TimelineItem): (WebCore::TimelineItem::addToTimeline): (WebCore::TimelineItem::convertToScriptObject): (WebCore::TimelineItem::convertChildrenToScriptArray): (WebCore::TimelineItem::addChildItem):
  • inspector/TimelineItem.h: Added. (WebCore::): (WebCore::TimelineItem::~TimelineItem): (WebCore::TimelineItem::previous): (WebCore::TimelineItem::releasePrevious): (WebCore::TimelineItem::setEndTime): (WebCore::TimelineItem::type):
  • inspector/front-end/TimelineAgent.js: Added. (WebInspector.TimelineAgent): (WebInspector.addItemToTimeline): (WebInspector.timelineWasEnabled): (WebInspector.timelineWasDisabled):
  • inspector/front-end/inspector.html:
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::paintContents):
  • page/FrameView.h: (WebCore::FrameView::inspectorTimelineAgent):
  • page/Page.cpp: (WebCore::Page::inspectorTimelineAgent):
  • page/Page.h:
10:44 Changeset [48166] by eric@webkit.org

2009-09-08 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29007
Add a test for the signal QWebFrame::javaScriptWindowObjectCleared()

  • tests/qwebframe/tst_qwebframe.cpp:
10:37 Changeset [48165] by eric@webkit.org

2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix unused variable warnings
https://bugs.webkit.org/show_bug.cgi?id=29018

No functional change, no tests.

  • history/qt/HistoryItemQt.cpp: (WebCore::HistoryItem::restoreState):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::putImageData):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintMenuList):

2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix unused variable warnings
https://bugs.webkit.org/show_bug.cgi?id=29018

  • Api/qwebpage.cpp: (QWebPagePrivate::keyPressEvent):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::startDownload): (WebCore::FrameLoaderClientQt::createFrame):
10:30 Changeset [48164] by eric@webkit.org

2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Use the declaration order in initializer lists
https://bugs.webkit.org/show_bug.cgi?id=29017

No functional change, no new tests.

  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):

2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Use the declaration order in initializer lists
https://bugs.webkit.org/show_bug.cgi?id=29017

  • Api/qwebframe_p.h:
10:23 Changeset [48163] by eric@webkit.org

2009-09-08 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Tests for ValidityState::typeMismatch() for <input type=number>.
https://bugs.webkit.org/show_bug.cgi?id=28934

  • fast/forms/ValidityState-typeMismatch-number-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-number.html: Added.
  • fast/forms/resources/ValidityState-typeMismatch-number.js: Added.

2009-09-08 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Implement ValidityState::typeMismatch() for <input type=number>.
https://bugs.webkit.org/show_bug.cgi?id=28934

Test: fast/forms/ValidityState-typeMismatch-number.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::formStringToDouble):
  • html/HTMLInputElement.h:
  • html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
  • html/ValidityState.h:
10:19 Changeset [48162] by kevino@webkit.org

wx build fix after introduction of platform/mock directory.

10:15 Changeset [48161] by eric@webkit.org

2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

Build fix when USE(LOCKFREE_THREADSAFESHARED) is not defined
https://bugs.webkit.org/show_bug.cgi?id=29011

  • wtf/Threading.h: Use LOCKFREE_THREADSAFESHARED guard for atomicIncrement and atomicDecrement
09:39 Changeset [48160] by yael.aharon@nokia.com

Unreviewed.

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-08
Add myself to list of committers.

  • Scripts/modules/committers.py:
09:08 Changeset [48159] by laszlo.1.gombos@nokia.com

2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed.

Add myself to list of committers.

  • Scripts/modules/committers.py:
08:51 Changeset [48158] by eric@webkit.org

2009-09-08 Cameron McCormack <cam@mcc.id.au>

Reviewed by Darin Adler.

prepare-ChangeLog too chatty on file additions
https://bugs.webkit.org/show_bug.cgi?id=29019

  • Scripts/prepare-ChangeLog: Omit description of added properties on newly added files.
08:49 Changeset [48157] by kov@webkit.org

2009-09-08 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Gustavo Noronha.

[Gtk] Another attempt of a buildfix.

  • GNUmakefile.am: Modified. Remove some extra IDL files added in r48153.
08:43 Changeset [48156] by eric@webkit.org

2009-09-08 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds a LayoutTestController method to set the permission state for Geolocation.
This is required to use the mock Geolocation service for testing.
https://bugs.webkit.org/show_bug.cgi?id=29027

  • fast/dom/Geolocation/resources/permission-denied.js: Added. Tests that the error callback is invoked with a permission error code when Geolocation permission is denied and the Geolocation service provides a good position fix.
  • fast/dom/Geolocation/permission-denied-expected.txt: Added. Expected result for above test.
  • fast/dom/Geolocation/permission-denied.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/resources/success.js: Added. Tests that the success callback is invoked when the Geolocation service provides a good position fix.
  • fast/dom/Geolocation/success-expected.txt: Added. Expected result for above test.
  • fast/dom/Geolocation/success.html: Added. Wrapper for above test.
  • platform/gtk/Skipped:

2009-09-08 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds a LayoutTestController method to set the permission state for Geolocation.
This is required to use the mock Geolocation service for testing.
https://bugs.webkit.org/show_bug.cgi?id=29027

  • DumpRenderTree/LayoutTestController.cpp: Modified. (setDatabaseQuotaCallback): Modified. Style fix. (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state. (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
  • DumpRenderTree/LayoutTestController.h: Modified. (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state. (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set. (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
  • DumpRenderTree/mac/UIDelegate.mm: Modified. (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
08:17 WebKit Team edited by oszi@inf.u-szeged.hu
(diff)
08:00 Changeset [48155] by zoltan@webkit.org

2009-09-07 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control in Yarr's RegexInterpreter
https://bugs.webkit.org/show_bug.cgi?id=29025

Inherits RegexInterpreter classes from FastAllocBase (bug #20422), which has
been instantiated by 'new':

class ByteDisjunction
-> instantiated in JavaScriptCore/yarr/RegexInterpreter.cpp:1462

struct BytecodePattern
-> instantiated in JavaScriptCore/yarr/RegexInterpreter.cpp:1279

  • yarr/RegexInterpreter.h:
07:58 WebKit Team edited by oszi@inf.u-szeged.hu
(diff)
07:43 Changeset [48154] by hausmann@webkit.org

WebCore: [Qt] Make cursor set cleaner in QtWebKit Api: eliminate SetCursorEvent hack.
https://bugs.webkit.org/show_bug.cgi?id=28865

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.

Save the QCursor as a property in WidgetQt::setCursor
and actually change the cursor in QWebView::event() by making use
of the QEvent::DynamicPropertyChange event type.
When unsetCursor() is called on the QWidget we can fallback to
the cursor set by WebCore.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> and

Antonio Gomes <antonio.gomes@openbossa.org> on 2009-09-07

  • platform/qt/WidgetQt.cpp:

(WebCore::Widget::setCursor):

WebKit/qt: [Qt] Make cursor set cleaner in QtWebKit Api: eliminate SetCursorEvent hack.
https://bugs.webkit.org/show_bug.cgi?id=28865

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.

Clean up the unserCursor hack to use the QCursor set
as a property of the QWidget by WebCore::WidgetQt.

Remove all code that are no longer necessary for getting
cursor change events.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> and

Antonio Gomes <antonio.gomes@openbossa.org> on 2009-09-07

  • Api/qwebpage.cpp:
  • Api/qwebpage_p.h:
  • Api/qwebview.cpp:

(QWebViewPrivate::QWebViewPrivate):
(QWebView::event):

07:34 Changeset [48153] by kov@webkit.org

2009-09-08 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Gustavo Noronha.

[Gtk] Buildfix for build error introduced in r48150.

  • GNUmakefile.am: Modified. Added missing IDL files.
07:05 Changeset [48152] by vestbo@webkit.org

[Qt] Buildfix. Build error caused by r48150.

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-08
Reviewed by Tor Arne Vestbø.

  • WebCore.pro: missing IDL files added
06:44 QtWebKitContrib edited by vestbo@webkit.org
(diff)
06:31 QtWebKitContrib edited by vestbo@webkit.org
(diff)
06:27 Changeset [48151] by laszlo.1.gombos@nokia.com

2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] QtWebKit single API to enable persistency
https://bugs.webkit.org/show_bug.cgi?id=28682

Disable LocalStorage, ApplicationCache, HTML5 offline storage by
default.

If persistency is enabled the default directory for LocalStorage and
ApplicationCache is now based on QDesktopServices::DataLocation and not
QDesktopServices::CacheLocation (as it is expected to keep this data
around after a reboot).

If persistency is enabled initialize HTML5 offline storage as well - this
fixed offline Storage for QtLauncher.

06:01 Changeset [48150] by cmarrin@apple.com

Update Canvas 3D implementation to match spec
https://bugs.webkit.org/show_bug.cgi?id=29010

This adds several new CanvasXXXArray classes each of which has a custom constructor
and custom getters and setters. Also changed CanvasRenderingContext3D and GraphicsContext3D
to match the new and changed API.

05:35 Changeset [48149] by vestbo@webkit.org

[Qt] Add expected files for new tests since we pass them.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-08
Reviewed by Tor Arne Vestbø.

  • platform/qt/fast/reflections/abs-position-in-reflection-expected.txt: Added.
  • platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.txt: Added.
05:27 Changeset [48148] by vestbo@webkit.org

Refactor --strict switch to --ignore-metrics and correct the
implementation to make the feature usable on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=28907

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-07
Reviewed by Tor Arne Vestbø.

run-webkit-tests --ignore-metrics strips the font related metrics from
the actual and expected data before comparing them.
In this way the render trees can be checked for obvious differences but
a successful test implies by no means that the layout is actually correct.

  • Scripts/run-webkit-tests:
02:51 Changeset [48147] by hamaji@chromium.org

Unreviewed.

Change my mail address on the list of committers.

00:45 Changeset [48146] by hausmann@webkit.org

Make m_windowVisible more consistent with the actual visibility of the inspector.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-08
Reviewed by Timothy Hatcher.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::setWindowVisible):

09/07/09:

23:22 Changeset [48145] by abarth@webkit.org

2009-09-07 Adam Barth <abarth@webkit.org>

Unreviewed speculative build fix for Snow Leopard.

  • platform/GeolocationService.cpp: (WebCore::createGeolocationServiceNull):
23:13 Changeset [48144] by abarth@webkit.org

2009-09-07 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264

  • fast/dom/Geolocation/resources/error.js: Added. Tests that the error callback is called when the service reports an error.
  • fast/dom/Geolocation/error-expected.txt: Added. Expected result for above test.
  • fast/dom/Geolocation/error.html: Added. Wrapper for above test.

2009-09-07 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264

The mock Geolocation service returns a fixed position or error. This position or error can be
set through static methods on the GeolocationService class. The position or error is shared
between all instances of the mock Geolocation service.

Implementation details.
The GeolocationService object maintains a pointer to a factory function which it uses to create
Geolocation service instances. Each platform implementing Geolocation sets this pointer
to the factory function for their platform's implementation. When the mock Geolocation service
is activated, the factory function pointer is reset to the factory function for the mock service.

Test: fast/dom/Geolocation/error.html

  • WebCore.base.exp: Modified. Exports GeolocationServiceMock methods.
  • GNUMakefile.am: Modified. Added GeolocationServiceMock files.
  • WebCore.gypi: Modified. Added GeolocationServiceMock files.
  • WebCore.pro: Modified. Added GeolocationServiceMock files.
  • WebCore.vcproj/WebCore.vcproj: Modified. Added GeolocationServiceMock files.
  • WebCore.vcproj/WebCoreCommon.vsprops: Modified. Added mock directory to includes.
  • WebCore.xcodeproj/project.pbxproj: Modified. Added GeolocationServiceMock files and exports some headers.
  • WebCoreSources.bkl: Modified. Added GeolocationServiceMock files.
  • page/ChromeClient.h: Modified. Fixed comment.
  • page/Geolocation.cpp: Modified. (WebCore::Geolocation::setIsAllowed): Modified. Fixed error string.
  • platform/GeolocationService.cpp: Modified. (WebCore::createGeolocationServiceNull): Added. Returns null in place of a Geolocation service. Used to avoid link errors on platforms where Geolocation is not implemented. (WebCore::GeolocationService::create): Added. Uses the factory function pointer to create a Geolocation service implementation. (WebCore::GeolocationService::useMock): Added. Configures the GeolocationServie to use the mock implementation.
  • platform/GeolocationService.h: Modified.
  • platform/mock: Added.
  • platform/mock/GeolocationServiceMock.cpp: Added. (WebCore::GeolocationServiceMock::create): Added. Creates a GeolocationServiceMock object. (WebCore::GeolocationServiceMock::GeolocationServiceMock): Added. Constructor. (WebCore::GeolocationServiceMock::~GeolocationServiceMock): Added. Destructor. (WebCore::GeolocationServiceMock::setPosition): Added. Sets the position that will be returned by the object. (WebCore::GeolocationServiceMock::setError): Added. Sets the error that will be returned by the object. (WebCore::GeolocationServiceMock::startUpdating): Added. GeolocationService implementation. Starts the service. (WebCore::GeolocationServiceMock::stopUpdating): Added. GeolocationService implementation. Stops the service. (WebCore::GeolocationServiceMock::timerFired): Added. Used to provide an asynchronous callback when the service is started. (WebCore::GeolocationServiceMock::makeGeolocationCallbackFromAllInstances): Added. Used to call back when the position or error is updated. (WebCore::GeolocationServiceMock::makeGeolocationCallback): Added. Used to call back when the service starts. (WebCore::GeolocationServiceMock::initStatics): Added. Initializes statics members with constructors. (WebCore::GeolocationServiceMock::cleanUpStatics): Added. Cleans up static members with constructors.
  • platform/mock/GeolocationServiceMock.h: Added. (WebCore::GeolocationServiceMock::lastPosition): Added. Returns the fixed position. (WebCore::GeolocationServiceMock::lastError): Added. Returns the fixed error.
  • platform/gtk/GeolocationServiceGtk.cpp: Modified. (WebCore::GeolocationServiceGtk::create): Added. Creates an instance of GeolocationServiceGtk.
  • platform/gtk/GeolocationServiceGtk.h: Modified.
  • platform/mac/GeolocationServiceMac.h: Modified.
  • platform/mac/GeolocationServiceMac.mm: Modified. (WebCore::GeolocationServiceMac::create): Added. Creates an instance of GeolocationServiceMac.

2009-09-07 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264

  • WebKit.xcodeproj/project.pbxproj: Modified. Adds WebGeolocationMock.

2009-09-07 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264

  • WebCoreSupport/WebGeolocationMockPrivate.h: Added.
  • WebCoreSupport/WebGeolocationMock.mm: Added. (+[WebGeolocationMock setError:code:]): Added. Used by DumpRender tree to configure the mock Geolocation service. (+[WebGeolocationMock setPosition:latitude:longitude:accuracy:]): Added. Used by DumpRender tree to configure the mock Geolocation service.
  • WebKit.exp: Modified. Exports WebGeolocationMock.

2009-09-07 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264

  • DumpRenderTree/LayoutTestController.cpp: Modified. (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service. (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service. (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
  • DumpRenderTree/LayoutTestController.h: Modified.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified. (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service. (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
22:19 Changeset [48143] by jorlow@chromium.org

2009-09-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Eric Seidel.

Clean up localStorage.clear() layout test.
https://bugs.webkit.org/show_bug.cgi?id=28939

This is the first step of https://bugs.webkit.org/show_bug.cgi?id=27897 which
is a pretty major cleanup of all the dom storage layout tests. I'm just
changing this one to begin with to get buy-in on the approach.

This also adds a new method to the fast/js/js-test-pre.js that runs a command
and prints it to the screen. This should really help with making the output of
the tests readable without looking at the source code.

  • fast/js/resources/js-test-pre.js: (tryAndLog): Runs a command and logs it to the screen.
  • storage/domstorage/localstorage/clear-expected.txt:
  • storage/domstorage/localstorage/clear.html:
  • storage/domstorage/resources: Added.
  • storage/domstorage/resources/clear.js: Added.

The meat of the test is now in this file.

  • storage/domstorage/sessionstorage/clear-expected.txt:
  • storage/domstorage/sessionstorage/clear.html:
18:25 Changeset [48142] by abarth@webkit.org

2009-09-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=28985

We need to be slightly more careful about how we pick up a script
execution context. In particular, we were getting the wrong document
for frames that had been navigated somewhere else.

In the long term, we should think about a better algorithm for
computing the script context.

Fixes LayoutTests/http/tests/xmlhttprequest/detaching-frame-2.html

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieveFrame):
17:32 Changeset [48141] by atwilson@chromium.org

Rubber-stamped by Sam Weinig.

Rebaseline tests for GTK platform, and skipping shared worker XHR tests (worker XHR tests are already skipped).
Tracked as https://bugs.webkit.org/show_bug.cgi?id=29020.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
17:08 Changeset [48140] by atwilson@chromium.org

Unreviewed test fixup.

Added shared worker lifecycle tests to Skipped test list due to missing DRT functionality on Qt platform.

  • platform/qt/Skipped:
16:55 Changeset [48139] by atwilson@chromium.org

Enable shared worker tests.
https://bugs.webkit.org/show_bug.cgi?id=28977

Reviewed by David Levin.

Just moved tests from shared-worker-xxxx.html-disabled to shared-worker-xxxx.html. No other changes.

  • fast/workers/shared-worker-constructor.html: Renamed from LayoutTests/fast/workers/shared-worker-constructor.html-disabled.
  • fast/workers/shared-worker-context-gc.html: Renamed from LayoutTests/fast/workers/shared-worker-context-gc.html-disabled.
  • fast/workers/shared-worker-event-listener.html: Renamed from LayoutTests/fast/workers/shared-worker-event-listener.html-disabled.
  • fast/workers/shared-worker-exception.html: Renamed from LayoutTests/fast/workers/shared-worker-exception.html-disabled.
  • fast/workers/shared-worker-frame-lifecycle.html: Renamed from LayoutTests/fast/workers/shared-worker-frame-lifecycle.html-disabled.
  • fast/workers/shared-worker-gc.html: Renamed from LayoutTests/fast/workers/shared-worker-gc.html-disabled.
  • fast/workers/shared-worker-lifecycle.html: Renamed from LayoutTests/fast/workers/shared-worker-lifecycle.html-disabled.
  • fast/workers/shared-worker-load-error.html: Renamed from LayoutTests/fast/workers/shared-worker-load-error.html-disabled.
  • fast/workers/shared-worker-location.html: Renamed from LayoutTests/fast/workers/shared-worker-location.html-disabled.
  • fast/workers/shared-worker-navigator.html: Renamed from LayoutTests/fast/workers/shared-worker-navigator.html-disabled.
  • fast/workers/shared-worker-replace-global-constructor.html: Renamed from LayoutTests/fast/workers/shared-worker-replace-global-constructor.html-disabled.
  • fast/workers/shared-worker-replace-self.html: Renamed from LayoutTests/fast/workers/shared-worker-replace-self.html-disabled.
  • fast/workers/shared-worker-script-error.html: Renamed from LayoutTests/fast/workers/shared-worker-script-error.html-disabled.
  • fast/workers/shared-worker-shared.html: Renamed from LayoutTests/fast/workers/shared-worker-shared.html-disabled.
  • fast/workers/shared-worker-simple.html: Renamed from LayoutTests/fast/workers/shared-worker-simple.html-disabled.
  • http/tests/workers/shared-worker-importScripts.html: Renamed from LayoutTests/http/tests/workers/shared-worker-importScripts.html-disabled.
  • http/tests/workers/shared-worker-redirect.html: Renamed from LayoutTests/http/tests/workers/shared-worker-redirect.html-disabled.
  • http/tests/xmlhttprequest/workers/shared-worker-close.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-close.html-disabled.
  • http/tests/xmlhttprequest/workers/shared-worker-methods-async.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-methods-async.html-disabled.
  • http/tests/xmlhttprequest/workers/shared-worker-methods.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-methods.html-disabled.
  • http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html-disabled.
16:05 Changeset [48138] by kevino@webkit.org

wx build fix for 2.8 compilation.

15:23 Changeset [48137] by atwilson@chromium.org

JavaScriptCore: Reverting r48121 to fix Windows build errors.

WebCore: Unreviewed build fix.

Reverting r48121 to fix Windows build errors.

  • DerivedSources.cpp:
  • GNUmakefile.am:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):
(WebCore::toEventTarget):

  • dom/EventTarget.cpp:
  • dom/EventTarget.h:
  • page/DOMWindow.idl:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::bufferedAmount):
(WebCore::WebSocket::addEventListener):
(WebCore::WebSocket::removeEventListener):
(WebCore::WebSocket::dispatchEvent):
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didReceiveMessage):
(WebCore::WebSocket::didClose):
(WebCore::WebSocket::dispatchOpenEvent):
(WebCore::WebSocket::dispatchMessageEvent):
(WebCore::WebSocket::dispatchCloseEvent):

  • websockets/WebSocket.h:

(WebCore::WebSocket::create):
(WebCore::WebSocket::):
(WebCore::WebSocket::setOnopen):
(WebCore::WebSocket::onopen):
(WebCore::WebSocket::setOnmessage):
(WebCore::WebSocket::onmessage):
(WebCore::WebSocket::setOnclose):
(WebCore::WebSocket::onclose):
(WebCore::WebSocket::toWebSocket):
(WebCore::WebSocket::refEventTarget):
(WebCore::WebSocket::derefEventTarget):

  • websockets/WebSocketChannel.cpp: Removed.
  • websockets/WebSocketChannel.h: Removed.
  • websockets/WebSocketChannelClient.h: Removed.
  • websockets/WebSocketHandshake.cpp: Removed.
  • websockets/WebSocketHandshake.h: Removed.

LayoutTests: Unreviewed build fix.

Reverting r48121 to fix Windows build errors.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
14:29 Changeset [48136] by atwilson@chromium.org

Unreviewed speculative build fix.

Reverted previous build fix as it didn't fix the problem.

  • bindings/js/JSEventTarget.cpp:

(WebCore::toEventTarget):

14:20 Changeset [48135] by laszlo.1.gombos@nokia.com

2009-09-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, build fix.

[Qt] Fix build after SHARED_WORKERS are enabled by default (r48131)

  • WebCore.pro:
13:50 Changeset [48134] by atwilson@chromium.org

Unreviewed build fix.

Temporarily removed depenency between JSEventTarget.cpp and WebSocket.h in an attempt to fix a windows build break.

  • bindings/js/JSEventTarget.cpp:

(WebCore::toEventTarget):

13:10 Changeset [48133] by kov@webkit.org

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Link new objects documents in the main document.

  • docs/webkitgtk-docs.sgml:
13:04 Changeset [48132] by kov@webkit.org

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Documentation control files updated for 1.1.14.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
12:53 Changeset [48131] by atwilson@chromium.org

JavaScriptCore: Enable SHARED_WORKERS by default
https://bugs.webkit.org/show_bug.cgi?id=28959

Reviewed by David Levin.

  • Configurations/FeatureDefines.xcconfig:

WebCore: Enable SHARED_WORKERS by default.
https://bugs.webkit.org/show_bug.cgi?id=28959

Reviewed by David Levin.

Tests (enabled in a separate patch):

fast/workers/shared-worker-constructor.html
fast/workers/shared-worker-context-gc.html
fast/workers/shared-worker-event-listener.html
fast/workers/shared-worker-exception.html
fast/workers/shared-worker-frame-lifecycle.html
fast/workers/shared-worker-gc.html
fast/workers/shared-worker-lifecycle.html
fast/workers/shared-worker-load-error.html
fast/workers/shared-worker-location.html
fast/workers/shared-worker-navigator.html
fast/workers/shared-worker-replace-global-constructor.html
fast/workers/shared-worker-replace-self.html
fast/workers/shared-worker-shared.html
fast/workers/shared-worker-simple.html
http/tests/workers/shared-worker-importScripts.html
http/tests/workers/shared-worker-redirect.html
http/tests/xmlhttprequest/workers/shared-worker-close.html
http/tests/xmlhttprequest/workers/shared-worker-methods-async.html
http/tests/xmlhttprequest/workers/shared-worker-methods.html
http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html

  • config.h: Removed some whitespace/touched the file to force a full rebuild on the build-bots.
  • Configurations/FeatureDefines.xcconfig:
  • WebCore.pro:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/build-generated-files.sh:
  • dom/DOMWindow.idl: Removed unnecessary whitespace to force a rebuild on the build-bots to pickup the flag change.
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::load):
Clean up bitrot in SharedWorker code - DenyCrossOriginRedirect is now DenyCrossOriginRequests.

  • workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::dispatchConnect):
Clean up bitrot - updated SharedWorker code to reflect new MessageEvent API.

WebKit/mac: Enable SHARED_WORKERS by default.
https://bugs.webkit.org/show_bug.cgi?id=28959

Reviewed by David Levin.

  • Configurations/FeatureDefines.xcconfig:

WebKit/win: Enable SHARED_WORKERS by default.
https://bugs.webkit.org/show_bug.cgi?id=28959

Reviewed by David Levin.

  • WebKit.vcproj/WebKit.vcproj:

WebKitTools: Enable SHARED_WORKERS by default
https://bugs.webkit.org/show_bug.cgi?id=28959

Reviewed by David Levin.

  • Scripts/build-webkit:

LayoutTests: Enable SHARED_WORKERS by default
https://bugs.webkit.org/show_bug.cgi?id=28959

Reviewed by David Levin.

Update test expectations to reflect the availability of the SharedWorker constructor.
Fixup bitrot in disabled tests - now reflects new MessagePort API.

  • fast/dom/Window/window-properties-expected.txt:

Updated expectations now that window.SharedWorkers is defined.

  • fast/dom/prototype-inheritance-2-expected.txt:

Updated expectations now that window.SharedWorkers is defined.

  • fast/dom/prototype-inheritance-expected.txt:

Updated expectations now that window.SharedWorkers is defined.

  • fast/workers/shared-worker-script-error-expected.txt

Updated expectations to reflect current (correct) behavior (unhandled exceptions are logged to console).

  • fast/workers/shared-worker-script-error.html

Pauses before exiting the test to allow pending console errors to get emitted (makes test less flaky).

  • fast/workers/resources/shared-worker-script-error.js

(onerror):
Now properly handles the exception (onerror function has to return false to swallow the exception).

  • fast/js/global-constructors-expected.txt:

Updated expectations now that window.SharedWorkers is defined.

  • http/tests/workers/resources/worker-importScripts.js:

Clean up bitrot in tests - MessageEvent.messagePort => MessageEvent.ports.
(handleConnect.self.postMessage):
(handleConnect):

  • http/tests/workers/resources/worker-redirect-target.js:

Clean up bitrot in tests - MessageEvent.messagePort => MessageEvent.ports.
(self.onconnect):

  • http/tests/xmlhttprequest/workers/resources/worker-pre.js:

Clean up bitrot in tests - MessageEvent.messagePort => MessageEvent.ports.

12:47 Changeset [48130] by kov@webkit.org

Tagging 1.1.14.

12:27 Changeset [48129] by kov@webkit.org

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Skipping one more test affected by the libsoup issue, a new test,
and tests that require eventSender.

  • platform/gtk/Skipped:
11:57 Changeset [48128] by kov@webkit.org

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Skipping tests that are failing because of a libsoup
problem. Bug reported.

  • platform/gtk/Skipped:
11:52 Changeset [48127] by ben@webkit.org

[PATCH 2/6] Speed up the QWebPluginInfo::supportsMimeType() function.
https://bugs.webkit.org/show_bug.cgi?id=27651

Instead of going through the MIME types list constructed with
mimeTypes() function, look up the internal mimeToDescriptions map.

11:16 Changeset [48126] by xan@webkit.org

2009-09-07 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Add new file to sources list.

  • GNUmakefile.am:
10:53 Changeset [48125] by kevino@webkit.org

wx build fixes for wx SVN trunk.

10:21 Changeset [48124] by kov@webkit.org

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

What's new for 1.1.14.

  • NEWS:
10:16 Changeset [48123] by xan@webkit.org

2009-09-07 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Bump versions in preparation for 1.1.14 release.

  • configure.ac:
10:07 Changeset [48122] by vestbo@webkit.org

[Qt] Use direct includes for Phonon, not the pretty ones

Patch by Chris Hills <chaz@chaz6.com> on 2009-09-07
Reviewed by Tor Arne Vestbø.

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
10:02 Changeset [48121] by eric@webkit.org

2009-09-07 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Export WTF::tryFastMalloc used in WebSocketChannel.
https://bugs.webkit.org/show_bug.cgi?id=28038

2009-09-07 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Add WebSocket API.
https://bugs.webkit.org/show_bug.cgi?id=28038

WebSocket constructor is available in window object.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:

2009-09-07 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket API implementation.
https://bugs.webkit.org/show_bug.cgi?id=28038

Add build systems only for GNUmakefile.am and WebCore.xcodeproj now.
Other build systems will be updated once the code is functional.
Tests will be landed once the code is completed and functional.

  • DerivedSources.cpp:
  • GNUmakefile.am:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webSocket):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): (WebCore::toEventTarget):
  • dom/EventTarget.cpp: (WebCore::EventTarget::toWebSocket):
  • dom/EventTarget.h:
  • page/DOMWindow.idl:
  • websockets/WebSocket.cpp: (WebCore::ProcessWebSocketEventTask::create): (WebCore::ProcessWebSocketEventTask::performTask): (WebCore::ProcessWebSocketEventTask::ProcessWebSocketEventTask): (WebCore::isValidProtocolString): (WebCore::WebSocket::connect): (WebCore::WebSocket::send): (WebCore::WebSocket::close): (WebCore::WebSocket::bufferedAmount): (WebCore::WebSocket::addEventListener): (WebCore::WebSocket::removeEventListener): (WebCore::WebSocket::dispatchEvent): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): (WebCore::WebSocket::didClose): (WebCore::WebSocket::dispatchOpenEvent): (WebCore::WebSocket::dispatchMessageEvent): (WebCore::WebSocket::dispatchCloseEvent):
  • websockets/WebSocket.h: (WebCore::WebSocket::create): (WebCore::WebSocket::): (WebCore::WebSocket::setOnopen): (WebCore::WebSocket::onopen): (WebCore::WebSocket::setOnmessage): (WebCore::WebSocket::onmessage): (WebCore::WebSocket::setOnclose): (WebCore::WebSocket::onclose): (WebCore::WebSocket::toWebSocket): (WebCore::WebSocket::eventListeners): (WebCore::WebSocket::refEventTarget): (WebCore::WebSocket::derefEventTarget):
  • websockets/WebSocketChannel.cpp: Added.
  • websockets/WebSocketChannel.h: Added.
  • websockets/WebSocketChannelClient.h: Added.
  • websockets/WebSocketHandshake.cpp: Added.
  • websockets/WebSocketHandshake.h: Added.
09:31 Changeset [48120] by kov@webkit.org

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Use g_return_if_fail to check for the SoupURI creation, instead of
printing a custom warning.

  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_set_uri):
09:29 Changeset [48119] by kov@webkit.org

Fixing name of reviewer in some older commits. Xan suggested the fix,
but Jan reviewed.

09:27 Changeset [48118] by kov@webkit.org

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=26854
[GTK] Needs API to allow more control over outgoing requests

  • GNUmakefile.am: new files added to the build for new class WebKitNetworkResponse

WebCore:

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=26854
[GTK] Needs API to allow more control over outgoing requests

Add infrastructure required to provide the new
WebKitNetworkResponse object in our API.

  • GNUmakefile.am: Add new files to the build.
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage):
  • platform/network/soup/ResourceResponse.h:
  • platform/network/soup/ResourceResponseSoup.cpp: Added. (WebCore::ResourceResponse::toSoupMessage):

WebKit/gtk

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=26854
[GTK] Needs API to allow more control over outgoing requests

Map the willSendRequest delegate to the 'resource-request-starting'
signal, allowing more control of the resources that are fetched.

Mapping willSendRequest properly requires an appropriate Response
object, so we are introducing WebKitNetworkResponse, which works in a
way similar to WebKitNetworkRequest.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest): (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::FrameLoaderClient::dispatchDidFinishLoading): (WebKit::FrameLoaderClient::dispatchDidFailLoading):
  • tests/testnetworkresponse.c: Added. (test_network_response_create_destroy): (test_network_response_properties): (main):
  • tests/testwebresource.c: (resource_request_starting_cb): (load_finished_cb): (test_web_resource_loading): (main):
  • webkit/webkit.h:
  • webkit/webkitdefines.h:
  • webkit/webkitnetworkrequest.cpp:
  • webkit/webkitnetworkresponse.cpp: Added. (webkit_network_response_dispose): (webkit_network_response_finalize): (webkit_network_response_get_property): (webkit_network_response_set_property): (webkit_network_response_class_init): (webkit_network_response_init): (webkit_network_response_new_with_core_response): (webkit_network_response_new): (webkit_network_response_set_uri): (webkit_network_response_get_uri): (webkit_network_response_get_message):
  • webkit/webkitnetworkresponse.h: Added.
  • webkit/webkitprivate.cpp: (WTF::SoupMessage): (WTF::WebKitNetworkRequest): (WTF::WebKitNetworkResponse): (WTF::WebKitWebResource):
  • webkit/webkitprivate.h:
  • webkit/webkitwebresource.cpp: (webkit_web_resource_cleanup): (webkit_web_resource_finalize): (webkit_web_resource_class_init): (webkit_web_resource_set_property): (webkit_web_resource_get_uri):
  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
  • webkitmarshal.list:
08:28 Changeset [48117] by kov@webkit.org

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=28979
[GTK] Misc improvments to NetworkRequest

Unref message in dispose, as it should be, not in finalize.

  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_dispose): (webkit_network_request_finalize): (webkit_network_request_class_init):
08:28 Changeset [48116] by kov@webkit.org

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=28979
[GTK] Misc improvments to NetworkRequest

Bring documentation up-to-date with reality regarding NetworkRequest.

  • webkit/webkitnetworkrequest.cpp:
08:11 Changeset [48115] by xan@webkit.org

2009-09-07 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Make the auth dialog usable when libsoup does not have a
SoupPasswordManager, since it might go away in the next
development cycle.

  • webkit/webkitsoupauthdialog.c: (response_callback): (session_can_save_passwords): (session_authenticate):
07:49 Changeset [48114] by eric@webkit.org

2009-09-07 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

[V8] Cleanup document/frame null-checking in V8DOMWindowCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=29009

Be consistent in document and frame null checks.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::V8Custom::ClearTimeoutImpl):
07:21 Changeset [48113] by eric@webkit.org

2009-09-07 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

Speed up the QWebPluginInfo::mimeTypes() function.
https://bugs.webkit.org/show_bug.cgi?id=27651

Instead of constructing a list of MIME types every time it is called,
do this only once.

  • Api/qwebplugindatabase.cpp: (QWebPluginInfo::mimeTypes): (QWebPluginInfo::operator=):
  • Api/qwebplugindatabase.h:
  • tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: (tst_QWebPluginDatabase::operatorassign_data): (tst_QWebPluginDatabase::operatorassign):
07:15 Changeset [48112] by eric@webkit.org

2009-09-07 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

Remove the private classes from QWebPluginDatabase.
https://bugs.webkit.org/show_bug.cgi?id=27651

Instead, hold the PluginDatabase and PluginPackage objects as class
members and take care of refcounting on our own instead of using RefPtr.

This way we not only made the code cleaner but also got rid of
redundant allocations when constructing null QWebPluginInfo objects.

The private classes have been forward-declared and the d-pointers left
to be on the safe side.

  • Api/qwebplugindatabase.cpp: (QWebPluginInfo::QWebPluginInfo): (QWebPluginInfo::~QWebPluginInfo): (QWebPluginInfo::name): (QWebPluginInfo::description): (QWebPluginInfo::mimeTypes): (QWebPluginInfo::path): (QWebPluginInfo::isNull): (QWebPluginInfo::setEnabled): (QWebPluginInfo::isEnabled): (QWebPluginInfo::operator==): (QWebPluginInfo::operator!=): (QWebPluginInfo::operator=): (QWebPluginDatabase::QWebPluginDatabase): (QWebPluginDatabase::~QWebPluginDatabase): (QWebPluginDatabase::plugins): (QWebPluginDatabase::searchPaths): (QWebPluginDatabase::setSearchPaths): (QWebPluginDatabase::addSearchPath): (QWebPluginDatabase::refresh): (QWebPluginDatabase::pluginForMimeType): (QWebPluginDatabase::setPreferredPluginForMimeType):
  • Api/qwebplugindatabase.h:
  • Api/qwebplugindatabase_p.h: Removed.
06:38 Changeset [48111] by xan@webkit.org

2009-09-07 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[Soup] Limit the number of connections
https://bugs.webkit.org/show_bug.cgi?id=18431

Increase the maximum number of per host and total connections to
similar values than those used by the other modern browsers. Seems
to significantly improve page loading time in many cases.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized):
03:09 Changeset [48110] by vestbo@webkit.org

[Qt] Disable a few tests that require missing controller features

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-07
Reviewed by Tor Arne Vestbø

  • platform/qt/Skipped:
00:35 Changeset [48109] by eric@webkit.org

2009-09-07 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

Various minor chromium appcache modifications.
https://bugs.webkit.org/show_bug.cgi?id=28960

No new tests.

  • bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: Fix a null pointer exception. (WebCore::ACCESSOR_GETTER):
  • platform/network/chromium/ResourceRequest.h: Switch from appCache 'context' to 'host' terminology. Note: leaving the old deprecated accessors in place until the matching change in chrome is landed to use the new accessors. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::appCacheHostID): (WebCore::ResourceRequest::setAppCacheHostID): (WebCore::ResourceRequest::appCacheContextID): (WebCore::ResourceRequest::setAppCacheContextID):
  • platform/network/chromium/ResourceResponse.h: Add an appCacheManifestURL getter/setter. Drop the 'get' prefix from the appCacheID getter. Note: leaving the old deprecated 'get' prefixed accessor in place until the matching change in chrome is landed to use the new accessor. (WebCore::ResourceResponse::appCacheID): (WebCore::ResourceResponse::appCacheManifestURL): (WebCore::ResourceResponse::setAppCacheManifestURL): (WebCore::ResourceResponse::getAppCacheID):
00:28 Changeset [48108] by eric@webkit.org

2009-09-07 Michael Nordman <michaeln@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=28359
Test to ensure the the window.applicationCache attribute is defined but non-functional
with the feature disabled.

  • http/tests/appcache/disabled-expected.txt: Added.
  • http/tests/appcache/disabled.html: Added.

2009-09-07 Michael Nordman <michaeln@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=28359
Cleanup: Undo some accidental changes around DOMApplicationCache.

  • Restore support for constructing a DOMApplicationCache object with a null frame ptr.
  • Return a non-null object for window.applicationCache when the feature is disabled.
  • Simplify the swapCache method.

Test: http/tests/appcache/disabled.html

  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::DOMApplicationCache): (WebCore::DOMApplicationCache::swapCache): (WebCore::DOMApplicationCache::scriptExecutionContext):
  • loader/appcache/DOMApplicationCache.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::applicationCache):

09/06/09:

22:25 Changeset [48107] by eric@webkit.org

2009-09-06 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

hostname and host are mixed up when manipulating anchor elements.
https://bugs.webkit.org/show_bug.cgi?id=28954

Added test case for when port is 0.

  • fast/dom/Element/hostname-host-expected.txt:
  • fast/dom/Element/hostname-host.html:

2009-09-06 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

hostname and host are mixed up when manipulating anchor elements.
https://bugs.webkit.org/show_bug.cgi?id=28954

handle the case of port 0.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::host):
22:10 Changeset [48106] by abarth@webkit.org

2009-09-06 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Tests for https://bugs.webkit.org/show_bug.cgi?id=27099
Make hidden elements not focusable. This is important becaue we should
not allow tabbing to a hidden element.

The patch also makes a element without href behave like generic elements
when it comes to focus. Added tests that asserts that this works as
expected.

  • fast/events/click-focus-anchor-expected.txt: Added.
  • fast/events/click-focus-anchor.html: Added.
  • fast/events/resources/tabindex-focus-blur-all.js: (test): (testProgrammaticFocus):
  • fast/events/tab-focus-anchor-expected.txt: Added.
  • fast/events/tab-focus-anchor.html: Added.
  • fast/events/tab-focus-hidden-expected.txt: Added.
  • fast/events/tab-focus-hidden.html: Added.
  • fast/events/tabindex-focus-blur-all-expected.txt:

2009-09-06 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Make hidden elements not focusable.

Clean up supportsFocus and isFocusable.
supportsFocus now strictly means that the node can be focused by default.
This is true for links, form controls and content editable elements for example.
isFocusable means that the user can actually focus it.
All (2) calls to supportsFocus have been updated to take this into account.

Make a elements without href work correctly as well.

https://bugs.webkit.org/show_bug.cgi?id=27099

Tests: fast/events/click-focus-anchor.html

fast/events/tab-focus-anchor.html
fast/events/tab-focus-hidden.html

  • dom/Element.cpp: (WebCore::Element::focus):
  • dom/Node.cpp: (WebCore::Node::supportsFocus): (WebCore::Node::isFocusable):
  • dom/Node.h:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::supportsFocus): (WebCore::HTMLAnchorElement::isMouseFocusable): (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  • html/HTMLAnchorElement.h:
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::supportsFocus):
  • html/HTMLAreaElement.h:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::supportsFocus):
  • html/HTMLElement.h:
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::supportsFocus):
  • html/HTMLFieldSetElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::supportsFocus): (WebCore::HTMLFormControlElement::isFocusable):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::supportsFocus):
  • html/HTMLFrameElementBase.h:
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::supportsFocus):
  • html/HTMLLegendElement.h:
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::supportsFocus): (WebCore::HTMLOptGroupElement::isFocusable):
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::supportsFocus): (WebCore::HTMLOptionElement::isFocusable):
  • html/HTMLOptionElement.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent):
  • page/FocusController.cpp: (WebCore::FocusController::advanceFocus):
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::supportsFocus): (WebCore::SVGAElement::isFocusable):
  • wml/WMLAElement.cpp: (WebCore::WMLAElement::supportsFocus):
  • wml/WMLAElement.h:
  • wml/WMLFormControlElement.cpp: (WebCore::WMLFormControlElement::supportsFocus): (WebCore::WMLFormControlElement::isFocusable):
  • wml/WMLFormControlElement.h:
21:15 Changeset [48105] by eric@webkit.org

2009-09-06 Joel Stanley <joel@jms.id.au>

Reviewed by Dimitri Glazkov.

Expose functions to set the caret blink interval for Linux Chromium.
Default value is set to that of RenderTheme::caretBlankInterval().
Uses caretBlinkIntervalInternal to avoid overriding
RenderThemeChromiumSkia::caretBlankInterval to preserve the disabling
of blinking caret required for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=28931

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval): (WebCore::RenderThemeChromiumLinux::caretBlinkIntervalInternal):
  • rendering/RenderThemeChromiumLinux.h:
19:27 Changeset [48104] by adachan@apple.com

Remove an extra </File> in WebCore.vcproj.

  • WebCore.vcproj/WebCore.vcproj:
15:44 Changeset [48103] by xan@webkit.org

2009-09-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update the unitests to latest changes wrt scrollbar policy.

  • tests/testwindow.c: (test_webkit_window_scrollbar_policy):
13:43 Changeset [48102] by timothy@apple.com

Adds a persistent setting for color format in the Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=28889

Reviewed by Dan Bernstein.

  • English.lproj/localizedStrings.js: New strings.
  • inspector/front-end/Color.js: Minor style fixes.

(WebInspector.Color.prototype.toString): Added. Replaces the individual
"toFoo" functions. Takes a optional arguments for the color format to return.

  • inspector/front-end/Images/paneSettingsButtons.png: Added.
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._changeColorFormat): Update the sections to show
the new color format.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay):
Use the new toString function on Color.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor): Use the persistent setting
to format colors by default. Add a tooltip for the color swatch.

  • inspector/front-end/inspector.css: New styles for the settings menu.
  • inspector/front-end/inspector.js:

(WebInspector.loaded): Initilize the colorFormat preference.

07:31 Changeset [48101] by xan@webkit.org

2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.

[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899

Expose an HTML5 database API for GTK+.

  • GNUmakefile.am:

LayoutTests:

2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.

[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899

Expose an HTML5 database API for GTK+.

  • platform/gtk/Skipped:

WebKit/gtk:

2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.

[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899

Expose an HTML5 database API for GTK+.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::print):
  • webkit/webkit.h:
  • webkit/webkitdefines.h:
  • webkit/webkitprivate.cpp: (webkit_init):
  • webkit/webkitprivate.h:
  • webkit/webkitsecurityorigin.cpp: Added. (webkit_security_origin_finalize): (webkit_security_origin_dispose): (webkit_security_origin_set_property): (webkit_security_origin_get_property): (webkit_security_origins): (webkit_security_origin_class_init): (webkit_security_origin_init): (webkit_security_origin_get_protocol): (webkit_security_origin_get_host): (webkit_security_origin_get_port): (webkit_security_origin_get_web_database_usage): (webkit_security_origin_get_web_database_quota): (webkit_security_origin_set_web_database_quota): (webkit_security_origin_get_all_web_databases): (WebKit::kit): (WebKit::core): (webkit_security_origin_get_web_database):
  • webkit/webkitsecurityorigin.h: Added.
  • webkit/webkitwebdatabase.cpp: Added. (webkit_web_database_finalize): (webkit_web_database_dispose): (webkit_web_database_set_property): (webkit_web_database_get_property): (webkit_web_database_class_init): (webkit_web_database_init): (webkit_web_database_set_security_origin): (webkit_web_database_set_name): (webkit_web_database_get_security_origin): (webkit_web_database_get_name): (webkit_web_database_get_display_name): (webkit_web_database_get_expected_size): (webkit_web_database_get_size): (webkit_web_database_get_filename): (webkit_web_database_remove): (webkit_remove_all_web_databases): (webkit_get_web_database_directory_path): (webkit_set_web_database_directory_path): (webkit_get_default_web_database_quota):
  • webkit/webkitwebdatabase.h: Added.
  • webkit/webkitwebframe.cpp: (webkit_web_frame_new): (webkit_web_frame_get_focused_accessible_element): (webkit_web_frame_get_horizontal_scrollbar_policy):
  • webkit/webkitwebframe.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
05:38 Changeset [48100] by laszlo.1.gombos@nokia.com

2009-09-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Remove Qt v4.6 check from the prefetchDNS implementation
https://bugs.webkit.org/show_bug.cgi?id=28993

  • platform/network/qt/DnsPrefetchHelper.cpp:
  • platform/network/qt/DnsPrefetchHelper.h:
00:24 Changeset [48099] by eric@webkit.org

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

Update test not to expect a <definition-src> element to be of type
SVGDefinitionSrcElement.

  • svg/dom/font-face-elements-expected.txt:
  • svg/dom/font-face-elements.html:

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

http://dev.w3.org/SVG/profiles/1.1F2/publish/changes.html#FontsChapter

  • DerivedSources.cpp: Remove references to definition-src.
  • DerivedSources.make: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap): Ditto.
  • bindings/objc/DOMSVG.h: Ditto.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Ditto.
  • bindings/v8/V8DOMWrapper.cpp: Ditto.
  • bindings/v8/V8Index.cpp: Ditto.
  • bindings/v8/V8Index.h: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGDefinitionSrcElement.cpp: Removed.
  • svg/SVGDefinitionSrcElement.h: Removed.
  • svg/SVGDefinitionSrcElement.idl: Removed.
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace): Don't search for definition-src child.
  • svg/svgtags.in: Remove definition-src.

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

  • MigrateHeaders.make: Remove reference to ObjC definition-src binding class.

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

When SVG 1.1 Second Edition is a Recommendation we can remove the
entry altogether.

  • projects/svg/status.xml: Update page to state that <definition-src> is not supported.

09/05/09:

21:09 Changeset [48098] by dglazkov@chromium.org

2009-09-05 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[Chromium] Roll out http://trac.webkit.org/changeset/48094, because the
logic of retrieving default caret blink interval was incorrect (non-existent)
and caused layout test flakiness.

  • rendering/RenderThemeChromiumLinux.cpp:
  • rendering/RenderThemeChromiumLinux.h:
20:57 MathML Goals edited by alex@milowski.com
(diff)
16:47 Changeset [48097] by eric@webkit.org

2009-09-05 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] r47424 broke binary compatibility
https://bugs.webkit.org/show_bug.cgi?id=28996

Append the new DnsPrefetchEnabled attribute at the end of the enum.

  • Api/qwebsettings.h:
10:42 Changeset [48096] by jianli@chromium.org

Back up partial change in r48072 in order to fix chromium reliability build break.

Reviewed by NOBODY (Chromium reliability build break).

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::invokeEventHandler):

02:13 Changeset [48095] by eric@webkit.org

2009-09-05 Nicolas Weber <thakis@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=28975
Fix file upload on chrome/mac. Images that have "Hide Extension" set,
such as screenshots by default, can now be uploaded to sites such as
imgur.com.

  • platform/FileSystem.h: Add pathGetDisplayFileName().
  • platform/chromium/FileChooserChromium.cpp: (WebCore::FileChooser::basenameForWidth): Call pathGetDisplayFileName() instead of pathGetFileName().
  • platform/chromium/FileSystemChromiumLinux.cpp: (WebCore::pathGetDisplayFileName): Implement pathGetDisplayFileName() by delegating to pathGetFileName().
  • platform/chromium/FileSystemChromiumMac.mm: (WebCore::pathGetFileName): Now returns a real filename instead of a presentational one, which fixes the problem addressed by this change. (WebCore::pathGetDisplayFileName): New function that returns a presentational filename; does what pathGetDisplayFileName() did prior to this patch.
  • platform/chromium/FileSystemChromiumWin.cpp: (WebCore::pathGetDisplayFileName): Implement pathGetDisplayFileName() by delegating to pathGetFileName().
02:05 Changeset [48094] by eric@webkit.org

2009-09-05 Joel Stanley <joel@jms.id.au>

Reviewed by David Levin.

Expose functions to set the caret blink interval for Linux Chromium.
https://bugs.webkit.org/show_bug.cgi?id=28931

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval): (WebCore::RenderThemeChromiumLinux::caretBlinkInterval):
  • rendering/RenderThemeChromiumLinux.h:
01:43 Changeset [48093] by eric@webkit.org

2009-09-05 Eric Seidel <eric@webkit.org>

No review, results update only.

Update results after r48043.

  • fast/js/JSON-stringify-expected.txt:

09/04/09:

21:10 Changeset [48092] by mrowe@apple.com

Versioning.

21:09 Changeset [48091] by mrowe@apple.com

New tag.

21:08 Changeset [48090] by mrowe@apple.com

Merge r48085.

21:08 Changeset [48089] by mrowe@apple.com

Merge r48070.

21:07 Changeset [48088] by mrowe@apple.com

2009-09-04 Anders Carlsson <andersca@apple.com>

Reviewed by Adele Petersen.

  • Fix <rdar://problem/7192902>

Never throw away the first frame in an animation.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):
21:07 Changeset [48087] by mrowe@apple.com

Merge r48062.

20:54 Changeset [48086] by dimich@chromium.org

Prevent UI freeze in case when too many timers are in the timer queue.
https://bugs.webkit.org/show_bug.cgi?id=23865

Reviewed by David Levin.

The fix measures the elapsed time while executing timers. If we have too many
timers and it takes significant time to fire, quit the loop and reschedule.
This lets the run loop process user input (close the window for example).

  • platform/ThreadTimers.h:
  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::sharedTimerFiredInternal):
(WebCore::ThreadTimers::fireTimersInNestedEventLoop):
Removed functions and members used before to grab a list of all expired timers.
Now we fetch one by one, measuring time and quitting the loop if it takes too long.

  • platform/Timer.cpp:

(WebCore::TimerBase::isActive):
(WebCore::TimerBase::setNextFireTime):
Since timers are now fired one by one, there is no need to keep track of updated timers.

  • manual-tests/input-starved-by-timers.html: Manual test that attempts to freeze browser by

creating of enough timers. It then keeps UI frozen and after 10 seconds starts to drain the timers
so the browser un-freezes. This is instead of a regular layout test because we don't have a way
to inject an input events via regular run loop in DRT - instead they are directly dispatched by
eventSender, which does not reproduce the UI freeze that happens with real input.

20:47 Changeset [48085] by andersca@apple.com

<rdar://problem/7201063>

Reviewed by Adele Peterson.

Detach any custom scrollbars before detaching the document.

  • page/Frame.cpp:

(WebCore::Frame::setView):

19:19 Changeset [48084] by oliver@apple.com

Windows build fix

19:07 Changeset [48083] by oliver@apple.com

ToString? conversion should use the actual toString function for String objects.

Reviewed by Gavin Barraclough.

Remove incorrect specialisations of toString conversions on StringObject.

18:13 Changeset [48082] by laszlo.1.gombos@nokia.com

Unreviewed, build fix.

Remove remaining references to UserStyleSheetLoader after r48075.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • page/qt/FrameQt.cpp:
  • page/wince/FrameWince.cpp:
17:35 Changeset [48081] by eric@webkit.org

2009-09-04 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=28988
Minor fix: "novalidate" attribute renamed in "noValidate", according to
HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#dom-fs-novalidate

  • fast/forms/novalidate-attribute-expected.txt:
  • fast/forms/resources/novalidate-attribute.js:

2009-09-04 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=28988
Minor fix: "novalidate" attribute renamed in "noValidate", according to
HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#dom-fs-novalidate

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::noValidate): (WebCore::HTMLFormElement::setNoValidate):
  • html/HTMLFormElement.h:
  • html/HTMLFormElement.idl:
17:18 Changeset [48080] by dimich@chromium.org

Remove unused line of code from WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=28990

Reviewed by David Levin.

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::importScripts):

17:03 Changeset [48079] by darin@apple.com

Fix assertion seen when running buildbot.

Patch by Darin Adler <darin@apple.com> on 2009-09-04
Reviewed by Oliver Hunt.

  • bindings/js/JSDOMBinding.h:

(WebCore::DOMObjectWithGlobalPointer::createStructure): Create the structure without
the HasDefaultMark bit since this has a custom mark function.

15:27 Changeset [48078] by ap@apple.com

Fix expected test output.

  • fast/dom/DOMImplementation/detached-doctype-expected.txt:
14:54 Changeset [48077] by sfalken@apple.com

Windows build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Add new export.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Add new export.
14:45 Changeset [48076] by sfalken@apple.com

Windows build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove unneeded export.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Remove unneeded export.
14:33 Changeset [48075] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=28984, remove the remote stylesheet loader on Mac/Qt.
Make sure the other code path (now used by everybody) can handle data URLs.

Reviewed by Adam Roben.

As per the post on webkit-dev, the ability to work remotely isn't working properly anyway (it doesn't
hold up the pending sheet count, so you'd just FOUC on every Web page), and it's extremely unlikely
that anybody is relying on this support.

Tor Arne agreed it was ok to disable (he enabled it on the Qt side), and only Mac/Qt were using this
code.

  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::userStyleSheet):

  • dom/Document.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::begin):

  • loader/UserStyleSheetLoader.cpp: Removed.
  • loader/UserStyleSheetLoader.h: Removed.
  • page/Frame.cpp:

(WebCore::Frame::reapplyStyles):

  • page/Frame.h:
  • page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):
(WebCore::Page::userStyleSheet):

  • page/mac/FrameMac.mm:
  • page/qt/FrameQt.cpp:
14:11 Changeset [48074] by pfeldman@chromium.org

2009-09-04 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Add "sampling profiler" preference, simplify data display when it's set.

https://bugs.webkit.org/show_bug.cgi?id=28969

  • inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds): (WebInspector.ProfileDataGridNode.prototype.get data):
  • inspector/front-end/ProfileView.js: (WebInspector.ProfileView):
  • inspector/front-end/inspector.js:
13:55 Changeset [48073] by hyatt@apple.com

Remove bogus assert that is affecting layout tests.

13:40 Changeset [48072] by jianli@chromium.org

[V8] Run-time exception in onmessage handler is not forwarded to the worker object.
https://bugs.webkit.org/show_bug.cgi?id=28980

Reviewed by Adam Barth.

Tested by worker-close.html.

  • bindings/v8/ScriptFunctionCall.cpp:
  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::invokeEventHandler):

  • bindings/v8/V8Utilities.cpp:

(WebCore::getScriptExecutionContext):
(WebCore::reportException):

  • bindings/v8/V8Utilities.h:

(WebCore::getScriptExecutionContext):

  • bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • bindings/v8/custom/V8SharedWorkerCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

12:53 Changeset [48071] by hyatt@apple.com

Remove unused m_sheet variable and setCSSStyleSheet methods.

Reviewed by Anders Carlsson.

  • dom/Document.cpp:
  • dom/Document.h:
12:39 MathML Goals edited by alex@milowski.com
(diff)
12:31 Changeset [48070] by andersca@apple.com

(Based on a patch from Adele).

Reviewed by David Hyatt and Adele Peterson.

Fix <rdar://problem/7185875>.

  • page/Frame.cpp:

(WebCore::Frame::setView):
Detach any custom scroll bars from the old view.

  • page/FrameView.cpp:

(WebCore::FrameView::detachCustomScrollbars):
Simplify the check (and make it work when body is null) by just checking that the scroll bar owner is
not a RenderPart object.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::destroy):
ASSERT that frame() is not null here and also add a null check so that release builds won't crash.

12:09 Changeset [48069] by hyatt@apple.com

Make m_userStyleSheetLoader in Frame an OwnPtr.

Reviewed by Adam Roben.

  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::~Frame):

  • page/Frame.h:
  • page/mac/FrameMac.mm:

(WebCore::Frame::setUserStyleSheetLocation):
(WebCore::Frame::setUserStyleSheet):

12:05 MathML Goals created by alex@milowski.com
12:03 Changeset [48068] by darin@apple.com

DateInstance object collected on ARM JIT (JSValue: WTF_USE_JSVALUE32)
https://bugs.webkit.org/show_bug.cgi?id=28909

Patch by Darin Adler <darin@apple.com> on 2009-09-04
Reviewed by Geoff Garen.

Part two.

Make some improvements to garbage collection code:

1) Create a runtime assertion that catches any classes that

override markChildren but have the HasDefaultMark bit set.

2) Remove checks of the mark bit outside the MarkStack::append

function; they are redundant.

3) Improve the efficiency of the asObject and asArray functions

when called on JSCell* to avoid a round trip to JSValue.

4) Make more callers use the checked asCell and asObject

casting functions rather than unchecked casts.

5) Removed the JSCell::marked function and other GC-related

functions because these operations are no longer things that
code other than the core GC code needs to do directly. Fixed
callers that were calling them.

  • runtime/Collector.cpp:

(JSC::Heap::markConservatively): Removed unneeded call to MarkStack::drain.
(JSC::Heap::markProtectedObjects): Removed unneeded check of the mark
bit and call to MarkStack::drain.
(JSC::Heap::collect): Removed unneeded checks of the mark bit and also
changed call to SmallStrings::mark to call markChildren instead to match
the rest of the objects.
(JSC::typeName): Removed unneeded cast to JSObject*.

  • runtime/JSArray.h:

(JSC::asArray): Added an overload for JSCell* and changed the JSValue
version to call it. Removed some unneeded casts.
(JSC::JSArray::markChildrenDirect): Marked this function inline. It's in
a header, and if not marked inline this could lead to linking problems.
(JSC::MarkStack::markChildren): Added. This helper function is used by
the drain function to avoid repating code. Also added the code here to
check fro default mark violations in debug code. If a markChildren
function adds something to the mark stack, but the type info claimed
hasDefaultMark was true, then we will get an assertion now. Also fixed
the assertion about the mark bit to use the Heap function directly
because we don't have a JSCell::marked function any more.
(JSC::MarkStack::drain): Changed a local variable from "v" to "value",
and from "currentCell" to "cell". Changed to call markChildren in two
places instead of repeating a chain of if statements twice. Changed
code that reads and writes the mark bit to use Heap::isCellMarked and
Heap::markCell so we can eliminate the JSCell::marked and
JSCell::markCellDirect functions.

  • runtime/JSCell.h: Removed JSCell's markCellDirect and marked member

functions. Added a comment explaining that asCell should be deprecated
in favor of the JSValue asCell member function.
(JSC::MarkStack::append): Added the assertion that catches callers
that have set the HasDefaultMark bit incorrectly. Changed
code that reads and writes the mark bit to use Heap::isCellMarked and
Heap::markCell so we can eliminate the JSCell::marked and
JSCell::markCellDirect functions. Moved the overload of
MarkStack::append for JSValue here so it can call through to the cell
version. The old version had a copy of all the code instead, but that
repeated the conversion from JSValue to JSCell* and the check for
whether a value is a cell multiple times.
(JSC::Structure::markAggregate): Moved this function here to avoid
dependencies for Structure.h, since this calls MarkStack::append.

  • runtime/JSObject.cpp:

(JSC::JSObject::markChildren): Added code to clear
m_isCheckingForDefaultMarkViolation so the marking done by JSObject
doesn't trigger the assertion.

  • runtime/JSValue.h: Moved some stray includes that were outside the

header guard inside it. Not sure how that happened! Removed the
GC-related member functions markChildren, hasChildren, marked, and
markDirect.

  • runtime/JSWrapperObject.h: Made markChildren private.

(JSC::JSWrapperObject::createStructure): Added. Fixes a bug where the
HasDefaultMark bit was set.

  • runtime/MarkStack.h: Added m_isCheckingForDefaultMarkViolation and

initialized it to false. Moved the append function body from here to
JSCell.h. Added a declaration of a private markChildren function used
inside the drain function.

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::markChildren): Changed the name and style of this
function to match other functions. This allows us to share the normal
mark stack code path.

  • runtime/SmallStrings.h: Changed the name and interface of mark to

the more-normal markChildren style.

  • runtime/Structure.h: Moved the body of markAggregate into the

JSCell.h to avoid a circular dependency with JSCell.h.

11:53 Changeset [48067] by darin@apple.com

JavaScriptCore: DateInstance object collected on ARM JIT (JSValue: WTF_USE_JSVALUE32)
https://bugs.webkit.org/show_bug.cgi?id=28909

Patch by Darin Adler <darin@apple.com> on 2009-09-04
Reviewed by Geoff Garen.

Part one.

Make some improvements to garbage collection code:

1) Fix the two classes that had the default mark bit set but

should not.

2) Remove checks of the mark bit outside the MarkStack::append

function; they are redundant.

3) Make more callers use the checked asCell and asObject

casting functions rather than unchecked casts.

4) Removed some GC-related functions because these operations are

no longer things that code other than the core GC code needs
to do directly. Fixed callers that were calling them.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::markAggregate): Removed unneeded check of the mark
bit before calling MarkStack::append.

  • interpreter/Register.h: Removed unneeded marked and markChildren

functions.

  • jit/JITStubs.cpp:

(op_eq): Removed unneeded assertions, instead using checked casting
functions such as asObject.

  • runtime/ArgList.h: Added now-needed forward declaration of MarkStack.
  • runtime/GetterSetter.cpp:

(JSC::GetterSetter::markChildren): Remmoved unneeded check of the mark bit.

  • runtime/GlobalEvalFunction.h:

(JSC::GlobalEvalFunction::createStructure): Added. Fixes a bug where the
HasDefaultMark bit was set.

  • runtime/JSCell.cpp:

(JSC::JSCell::getObject): Use asObject to avoid a direct static_cast.

  • runtime/JSObject.h:

(JSC::asObject): Added an overload for JSCell* and changed the JSValue
version to call it.
(JSC::JSValue::get): Use asObject to avoid a direct static_cast.

  • runtime/JSValue.h: Moved some stray includes that were outside the

header guard inside it. Not sure how that happened! Removed the
GC-related member functions markChildren, hasChildren, marked, and
markDirect.

  • runtime/JSWrapperObject.h: Made markChildren private.

(JSC::JSWrapperObject::createStructure): Added. Fixes a bug where the
HasDefaultMark bit was set. Later we may want to optimize this for
wrapper types that never have cells in their internal values, but there
is no measured performance regression in SunSpider or V8 doing this
all the time.

  • runtime/MarkStack.cpp: Tweaked formatting.

JavaScriptGlue: * JSValueWrapper.cpp:
(JSValueWrapper::JSObjectMark): Removed a check of the mark
bit. It's OK to do more work in this case, and there is no
longer a public function to access the mark bit.

Reviewed by Geoff Garen.

11:35 WikiStart edited by alex@milowski.com
(diff)
11:34 WikiStart edited by alex@milowski.com
added MathML section (diff)
11:22 Changeset [48066] by kevino@webkit.org

wx build fix. Switch USE_ defines over to the compiler so that they can be
checked by files not including config.h (like WebCorePrefix.h).

11:07 Changeset [48065] by timothy@apple.com

Show color swatches in the Web Inspector before the color text so clicking them will not
shift the swatch. Also makes multiple swatches in the single property toggle the color format.

https://bugs.webkit.org/show_bug.cgi?id=28978

Reviewed by Darin Adler.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.updateTitle): Some refactoring to consolidate
the processing we do on the property value. This eliminated the old nickname code, since the new
WebInspector.Color class handles this. We could also simplify the color regex since more
is handled by the Color class. Also no longer uses innerHTML for the linkify code.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processValue): Helper function to
process a value given a regex and processor functions.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): Make an anchor for the
URL with "url()" syntax surrounding it.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor): Makes a color, if
there was an exception just return a text node.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay.changeTo):
Moved from later in the file.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay): Ditto.

  • inspector/front-end/inspector.css:
10:59 Changeset [48064] by dglazkov@chromium.org

WebCore:

2009-09-04 Mark Mentovai <mark@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=28614

Account for scrollbar state changes that occur during layout.

  • platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):

Perform a layout prior to checking whether the scrollbar modes are
off, on, or automatic. The modes may change during layout.

  • WebCore.base.exp:
  • WebCore.order:
  • page/Frame.cpp: (WebCore::Frame::createView):
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::layout):
  • page/FrameView.h:
  • platform/ScrollView.h:

Eliminate duplicated (and incorrect) scrollbar mode tracking between
FrameView and ScrollView.

WebKit/mac:

2009-09-04 Mark Mentovai <mark@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=28614

Account for scrollbar state changes that occur during layout.

  • WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView updateScrollers]):

Perform a layout prior to checking whether the scrollbar modes are
off, on, or automatic. The modes may change during layout.

  • WebView/WebFrameView.mm: (-[WebFrameView _install]):

Eliminate duplicated (and incorrect) scrollbar mode tracking between
FrameView and ScrollView.

WebKit/qt:

2009-09-04 Mark Mentovai <mark@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=28614

Account for scrollbar state changes that occur during layout.

  • Api/qwebframe.cpp: (QWebFrame::setScrollBarPolicy):

Eliminate duplicated (and incorrect) scrollbar mode tracking between
FrameView and ScrollView.

10:53 Changeset [48063] by yael.aharon@nokia.com

WebCore: hostname and host are mixed up when manipulating anchor elements.
https://bugs.webkit.org/show_bug.cgi?id=28954

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-04
Reviewed by Darin Adler.

Swapped the implementation of host and hostname, and made sure not to return
the port number if it is default for the given protocol.
FireFox also avoids returning the protocol number if it is default.

Test: fast/dom/Element/hostname-host.html

10:19 Changeset [48062] by andersca@apple.com

Fix <rdar://problem/7192902>.

Reviewed by Darin Adler and Steve Falkenburg.

Add the necessary plumbing for having QTMovieWin use WebCore timers.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:

(WebCore::TaskTimer::initialize):
Create the timer and call QTMovieWin::setTaskTimerFuncs.

(WebCore::TaskTimer::setTaskTimerDelay):
Start the timer.

(WebCore::TaskTimer::stopTaskTimer):
Stop the timer.

(WebCore::TaskTimer::fired):
Call QTMovieWin::taskTimerFired().

(WebCore::MediaPlayerPrivate::load):
Initialize the Task timer.

  • platform/graphics/win/QTMovieWin.cpp:

(updateTaskTimer):
Call the global stopTaskTimer function and setTaskTimerDelay.

(QTMovieWin::taskTimerFired):
Make this a member function.

(QTMovieWin::setTaskTimerFuncs):
Set the global function pointers.

(QTMovieWin::initializeQuickTime):
(DllMain):
No need to use the QT shared timer.

  • platform/graphics/win/QTMovieWin.h:
10:08 Changeset [48061] by levin@chromium.org

Fix Chromium Win compile. Missing return statement in
WebCore::RenderThemeChromiumSkia::paintSliderThumb.
https://bugs.webkit.org/show_bug.cgi?id=28974

Patch by Tony Chang <tony@chromium.org> on 2009-09-04
Reviewed by David Levin.

No new tests, build fix.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintSliderThumb):

10:07 Changeset [48060] by aroben@apple.com

Make WebView function without a parent window

When WebView has no parent window, it becomes a message-only window,
which hides it from the screen and prevents it from appearing on the
taskbar.

Fixes <http://webkit.org/b/28971> <rdar://problem/4976998>
WebView::initWithFrame fails if there's no host window

Reviewed by Dave Hyatt.

  • WebView.cpp:

(WebView::initWithFrame): m_hostWindow is null, use HWND_MESSAGE as
our parent window, which will make us a message-only window.
(WebView::setHostWindow): If he new host window is null, use
HWND_MESSAGE as our parent window, which will make us a message-only
window.

10:06 Changeset [48059] by dglazkov@chromium.org

2009-09-04 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[Chromium] Rolling out http://trac.webkit.org/changeset/48035, because it broke
the build.
https://bugs.webkit.org/show_bug.cgi?id=28696

10:02 Changeset [48058] by andersca@apple.com

Fix vcproj file.

  • WebCore.vcproj/WebCore.vcproj:
10:01 Changeset [48057] by hyatt@apple.com

WebCore: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.

Reviewed by Adam Roben.

This patch adds new API for adding and removing user scripts from page groups. User scripts
are bundled together in isolated worlds (you can have multiple scripts together in the same
world).

Added userscripts/ directory for holding new tests (along with a simple test of script injection).

  • WebCore.base.exp:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInIsolatedWorld):

  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::evaluateInIsolatedWorld):

  • bindings/v8/ScriptController.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::dispatchDocumentElementAvailable):

  • page/Frame.cpp:

(WebCore::Frame::injectUserScripts):
(WebCore::Frame::injectUserScriptsForWorld):

  • page/Frame.h:
  • page/PageGroup.cpp:

(WebCore::PageGroup::~PageGroup):
(WebCore::PageGroup::addUserScript):
(WebCore::PageGroup::removeUserContentForWorld):
(WebCore::PageGroup::removeAllUserContent):

  • page/PageGroup.h:

(WebCore::PageGroup::userScripts):

  • page/UserScript.h: Added.

(WebCore::UserScript::UserScript):
(WebCore::UserScript::source):
(WebCore::UserScript::url):
(WebCore::UserScript::patterns):
(WebCore::UserScript::worldID):
(WebCore::UserScript::injectionTime):

  • page/UserScriptTypes.h: Added.

(WebCore::):

WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.

Reviewed by Adam Roben.

This patch adds new API for adding and removing user scripts from page groups. User scripts
are bundled together in isolated worlds (you can have multiple scripts together in the same
world).

Added userscripts/ directory for holding new tests (along with a simple test of script injection).

  • WebView/WebView.mm:

(+[WebView _addUserScriptToGroup:source:url:worldID:patterns:injectionTime:]):
(+[WebView _removeUserContentFromGroup:worldID:]):
(+[WebView _removeAllUserContentFromGroup:]):

  • WebView/WebViewPrivate.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.

Reviewed by Adam Roben.

This patch adds new API for adding and removing user scripts from page groups. User scripts
are bundled together in isolated worlds (you can have multiple scripts together in the same
world).

Added userscripts/ directory for holding new tests (along with a simple test of script injection).

  • platform/mac/userscripts: Added.
  • platform/mac/userscripts/script-run-at-end-expected.txt: Added.
  • userscripts: Added.
  • userscripts/script-run-at-end.html: Added.
09:42 Changeset [48056] by abarth@webkit.org

Added missing ;

09:34 Changeset [48055] by ap@apple.com

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26402
Crashes when using a detached DocumentType node

Test: fast/dom/DOMImplementation/detached-doctype.html

DocumentType nodes are the only one that can have null document(), and they can never have
children, so they are a degenerate case for NodeLists.

  • dom/Node.cpp: (WebCore::Node::childNodes): Don't try register node list with document if there's no document. Since there are no changes possible for a DocumentType's node list, this is not necessary. (WebCore::Node::registerDynamicNodeList): Ditto. (WebCore::Node::unregisterDynamicNodeList): Ditto. I couldn't find a scenario where this was invoked for a DocumentType node, but I also couldn't prove that it can't be (the de-registration code path that I saw taken was via Node destructor, and that already has a null check for document).
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): Bail out if there is no document (just as we already do if there is no window). (WebCore::JSNode::removeEventListener): Ditto.
09:34 Changeset [48054] by abarth@webkit.org

2009-09-04 Adam Barth <abarth@webkit.org>

Unreviewed attempt at a build fix.

Added missing include.

  • WebCoreSupport/WebFrameLoaderClient.cpp:
09:23 Changeset [48053] by abarth@webkit.org

2009-09-04 Adam Barth <abarth@webkit.org>

Unreviewed attempt at a build fix.

Fix typo of IWebFrameLoadDelegatePrivate2 and make
IWebFrameLoadDelegatePrivate inherit from IWebFrameLoadDelegatePrivate
as requestd by Adam Roben.

  • Interfaces/IWebFrameLoadDelegatePrivate2.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):

2009-09-04 Adam Barth <abarth@webkit.org>

Unreviewed build fix.

Update declaration of FrameLoadDelegate to reflect that
IWebFrameLoadDelegatePrivate2 inherits from
IWebFrameLoadDelegatePrivate.

  • DumpRenderTree/win/FrameLoadDelegate.h:
08:53 Changeset [48052] by vestbo@webkit.org

[Qt] Fix brainfart in r48050, tests should have paths

Rubber-stamped by Simon Hausmann.

  • platform/qt/Skipped:
08:49 Changeset [48051] by abarth@webkit.org

2009-09-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24696

Plumb mixed content notifications to WebFrameLoadDelegatePrivate.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebFrameLoadDelegatePrivate.h: Added.

2009-09-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24696

Plumb mixed content notifications to IWebFrameLoadDelegatePrivate.

  • Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added.
  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
  • WebKit.vcproj/Interfaces.vcproj:

2009-09-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24696

Add testing instrumentation for mixed content.

  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:]): (-[FrameLoadDelegate webView:didRunInsecureContent:]):
  • DumpRenderTree/win/FrameLoadDelegate.cpp: (descriptionSuitableForTestResult): (FrameLoadDelegate::QueryInterface): (FrameLoadDelegate::didDisplayInsecureContent): (FrameLoadDelegate::didRunInsecureContent):
  • DumpRenderTree/win/FrameLoadDelegate.h:
08:34 Changeset [48050] by vestbo@webkit.org

[Qt] Skip tests failing due to missing DRT features

Rubber-stamped by Simon Hausmann.

  • platform/qt/Skipped:
07:04 Changeset [48049] by xan@webkit.org

2009-09-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] loadFinished never emitted
https://bugs.webkit.org/show_bug.cgi?id=28935

Do not report errors right away from
ResourceHandle::start. Instead return true and schedule an error
to be reported in the handle later. Otherwise WebCore gets
confused and thinks the resource never finished loading, making it
not emit the finished status.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp): (WebCore::):
07:00 Changeset [48048] by yong.li@torchmobile.com

2009-09-03 Yong Li <yong.li@torchmobile.com>

Reviewed by David Levin.

Remove unnecessary dependency on unistd.h
https://bugs.webkit.org/show_bug.cgi?id=28962

  • runtime/Completion.cpp:
03:28 Changeset [48047] by eric@webkit.org

2009-09-04 Ben Murdoch <benm@google.com>

Reviewed by Eric Seidel.

[V8] DOM Storage bindings: Event Handler should create StorageEvents
https://bugs.webkit.org/show_bug.cgi?id=28942

Tests:
Causes the following tests that were failing with V8 to pass:

  • storage/domstorage/localstorage/onstorage-attribute-setwindow.html
  • storage/domstorage/localstorage/complex-keys.html
  • storage/domstorage/localstorage/onstorage-attribute-markup.html
  • storage/domstorage/localstorage/simple-events.html
  • storage/domstorage/localstorage/onstorage-attribute-set-attribute.html
  • storage/domstorage/localstorage/index-get-and-set.html
  • storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html
  • storage/domstorage/sessionstorage/onstorage-attribute-markup.html
  • storage/domstorage/sessionstorage/simple-events.html
  • storage/domstorage/sessionstorage/onstorage-attribute-set-attribute.html
  • storage/domstorage/sessionstorage/index-get-and-set.html

Code changes:

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object): Create StorageEvents.
  • bindings/v8/custom/V8StorageCustom.cpp: (WebCore::storageGetter): Check if we are retrieving the length property and return the number of items in the object rather than a property named length when invoking the getItem() member of local/sessionStorage.
02:04 Changeset [48046] by pfeldman@chromium.org

2009-09-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=28911

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._formatarray): (WebInspector.ConsoleView.prototype._formatnode):
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch):
  • inspector/front-end/InjectedScript.js: (InjectedScript.dispatch):
  • inspector/front-end/InjectedScriptAccess.js: Added. (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName): (InjectedScriptAccess._installHandler):
  • inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.html:
01:47 Changeset [48045] by eric@webkit.org

2009-09-04 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Implement <input type="range"> for Chromium Linux by painting
the slider and the thumb using skia.
https://bugs.webkit.org/show_bug.cgi?id=28928

Covered by existing tests (we're currently hitting an assert for them).

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
  • rendering/RenderThemeChromiumLinux.h:
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::drawVertLine): (WebCore::drawHorizLine): (WebCore::drawBox): (WebCore::RenderThemeChromiumSkia::paintSliderTrack): (WebCore::RenderThemeChromiumSkia::paintSliderThumb):
  • rendering/RenderThemeChromiumSkia.h:
01:40 Changeset [48044] by eric@webkit.org

2009-09-04 Albert Bachand <albertb@google.com>

Reviewed by Eric Seidel.

Modify the condition regarding the key modifier for opening combo
boxes under GTK from just PLATFORM(GTK) to also look for
(PLATFORM(CHROMIUM) && PLATFORM(LINUX)).

  • WebCore/dom/SelectElement.cpp:
  • WebCore/manual-tests/select-popup-on-spacebar.html:
01:32 Changeset [48043] by eric@webkit.org

2009-09-04 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Tests for <input type=color> validation.
https://bugs.webkit.org/show_bug.cgi?id=28966

  • fast/forms/ValidityState-patternMismatch-unsupported-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-unsupported.html: Added.
  • fast/forms/ValidityState-typeMismatch-color-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-color.html: Added.
  • fast/forms/resources/ValidityState-patternMismatch-unsupported.js: Added.
  • fast/forms/resources/ValidityState-typeMismatch-color.js: Added.

2009-09-04 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Tests: fast/forms/ValidityState-patternMismatch-unsupported.html

fast/forms/ValidityState-typeMismatch-color.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueMissing): (WebCore::HTMLInputElement::patternMismatch): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::formControlType): (WebCore::HTMLInputElement::saveFormControlState): (WebCore::HTMLInputElement::restoreFormControlState): (WebCore::HTMLInputElement::accessKeyAction): (WebCore::HTMLInputElement::rendererIsNeeded): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::appendFormData): (WebCore::HTMLInputElement::valueWithDefault): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::isRequiredFormControl): (WebCore::HTMLInputElement::dataList):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::): (WebCore::HTMLInputElement::isTextField):
  • html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch): (WebCore::ValidityState::isValidColorString):
  • html/ValidityState.h:
01:07 Changeset [48042] by levin@chromium.org

[V8] Crash when updating document cache
https://bugs.webkit.org/show_bug.cgi?id=28965

Patch by Mads Ager <ager@chromium.org> on 2009-09-04
Reviewed by David Levin.

Initialization of a V8 JavaScript context can fail. When that
happens, do not attempt to update the document wrapper cache.

This code path is exercised by http/tests/security/javascriptURL/javascriptURL-in-new-iframe.html.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::updateDocument):

00:50 Changeset [48041] by eric@webkit.org

2009-09-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Fix tst_QWebPage::database autotest failure
https://bugs.webkit.org/show_bug.cgi?id=28961

Make sure that the test case enables the feature before
the feature gets tested

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::database):
00:15 Changeset [48040] by eric@webkit.org

2009-09-04 Yaar Schnitman <yaar@chromium.org>

Reviewed by Eric Seidel.

Two bugs:

https://bugs.webkit.org/show_bug.cgi?id=25489
CSS property background-position is now serialized in shorthand string as
background-position-x background-position-y, as the specification requires
(See http://www.w3.org/TR/2008/WD-css3-background-20080910/#the-background-position).

https://bugs.webkit.org/show_bug.cgi?id=26541
CSS background-color is now be serialized before other background properties,
as CSS specification requires (See http://dev.w3.org/csswg/cssom/#css-value).

An existing layout test that accepted wrong order and skipped position test
had to be modified.

  • fast/dom/background-shorthand-csstext-expected.txt:
  • fast/dom/background-shorthand-csstext.html:

2009-09-04 Yaar Schnitman <yaar@chromium.org>

Reviewed by Eric Seidel.

Two bugs:

https://bugs.webkit.org/show_bug.cgi?id=25489
CSS property background-position is now serialized in shorthand string as
background-position-x background-position-y, as the specification requires
(See http://www.w3.org/TR/2008/WD-css3-background-20080910/#the-background-position).

https://bugs.webkit.org/show_bug.cgi?id=26541
CSS background-color is now be serialized before other background properties,
as CSS specification requires (See http://dev.w3.org/csswg/cssom/#css-value).

An existing layout test that accepted wrong order and skipped position test
had to be modified.

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
00:07 Changeset [48039] by eric@webkit.org

2009-09-04 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by Eric Seidel.

Any QtWebKit application crashes on exit if the inspector is
used during the session rather then exiting.

If a QWebView has a QWebPage that is destroyed the QWebView
does not update its pointer and will crash the next time
it access the page pointers (such as in its destructor).

InspectorClientView should not call deleteLater when the page
is destroyed because it does not have a parent and is a top
level widget. close() needs to be called so that QApplication
can exit the application if quitOnLastWindowClosed is set
and a InspectorClientView is the last window, otherwise
the application will never exit.

  • Api/qwebview.cpp: (QWebViewPrivate::_q_pageDestroyed): (QWebView::setPage):
  • Api/qwebview.h:
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientView::InspectorClientView):
Note: See TracTimeline for information about the timeline view.