Timeline
09/14/09:
- 21:25 Changeset [48388] by
-
Page cache should support pages with unload handlers as an experiment.
<rdar://problem/7196485> and https://bugs.webkit.org/show_bug.cgi?id=29021
Reviewed by Darin Adler.
WebCore:
For the experiment, only allow pages with unload handlers into the Page Cache on
Mac and Windows.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):
LayoutTests:
Disable fast/loader/frames-with-unload-handlers-in-page-cache.html as it doesn't
make sense in the context of this experiment.
- platform/mac/Skipped:
- platform/win/Skipped:
- 20:22 Changeset [48387] by
-
Versioning.
- 20:21 Changeset [48386] by
-
New tag.
- 20:07 Changeset [48385] by
-
Merge r48368.
- 20:05 Changeset [48384] by
-
Merge r48367.
- 19:11 Changeset [48383] by
-
Undoing mess: committing test code
- 19:11 Changeset [48382] by
-
2009-09-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez and Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=29134
[GTK] Add API to access sub resources
Implement getting subresources, and improve testing of
main, and sub resources loading.
- 19:08 Changeset [48381] by
-
Java
- 18:28 Changeset [48380] by
-
Add LayoutTests infrastructure to enable and disable webgl tests.
Also added a webgl test.
https://bugs.webkit.org/show_bug.cgi?id=29254
- 18:07 Changeset [48379] by
-
2009-09-14 Simon Fraser <simon.fraser@apple.com>
Fix the change in r48376 to do a null-check to fix a crashing test.
- dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
- 17:54 Changeset [48378] by
-
2009-09-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Add --iterations option to run-webkit-tests to repeat the tests N times
https://bugs.webkit.org/show_bug.cgi?id=29263
When run with --iterations N, run-webkit-tests will repeat the tests N times.
- Scripts/run-webkit-tests:
- 17:28 Changeset [48377] by
- 17:19 Changeset [48376] by
-
2009-09-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/7047282> Safari crashes at WebCore::RenderMenuList::adjustInnerStyle() + 436
Avoid a crash when a mouse event handler on a <select> changes the select from a popup
to a list (by setting the 'size' property) inside the event handler.
Test: fast/forms/select-change-popup-to-listbox-in-event-handler.html
- dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
- 16:52 Changeset [48375] by
-
More PopupMenu cleanup.
Reviewed by Jon Honeycutt.
- platform/PopupMenu.h:
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::show):
Call registerClass.
(WebCore::PopupMenu::registerClass):
Make this a private static member function so it can refer to PopupMenuWndProc.
(WebCore::PopupMenu::PopupMenuWndProc):
Try to get the PopupMenu and call its wndProc member function.
(WebCore::PopupMenu::wndProc):
Make this a member function.
- 16:08 Changeset [48374] by
-
Fix more fallout I wrought on myself by not testing the final authentication patch on Windows.
- 15:46 Changeset [48373] by
-
GTK build fix.
Unreviewed.
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::setLogScrollingStartEvents):
- 15:45 Changeset [48372] by
-
Speculative Qt build fix.
- platform/qt/QWebPopup.cpp:
(WebCore::QWebPopup::hidePopup):
- 15:38 Changeset [48371] by
-
2009-09-14 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Fisher.
Fix RenderThemeChromiumWin::determineClassicState so that classic_state
matches the state values (and you get a single classic_state value
for a given {part,state} value. This change will be tested by a
chromium patch that will land after this.
This will be tested by code landing downstream on Chromium.org; the
code does not execute on webkit.org.
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineClassicState): (WebCore::RenderThemeChromiumWin::getThemeData):
- 15:14 Changeset [48370] by
-
https://bugs.webkit.org/show_bug.cgi?id=29138
Simplify popup menu handling.
Reviewed by Adam Roben.
- platform/PopupMenuClient.h:
Rename hidePopup to popupDidHide.
- platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::acceptIndex):
Call popupDidHide instead of hidePopup.
- platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenu::menuUnmapped):
Ditto.
- platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::show):
Ditto.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::hide):
Call popupDidHide.
(WebCore::PopupWndProc):
Call PopupMenu::hide.
- platform/wx/PopupMenuWx.cpp:
(WebCore::PopupMenu::OnMenuItemSelected):
Call popupDidHide.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::hidePopup):
(WebCore::RenderMenuList::popupDidHide):
- rendering/RenderMenuList.h:
Set the "popup is visible" flag in popupDidHide.
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::popupDidHide):
- rendering/RenderTextControlSingleLine.h:
Ditto.
- 14:27 Changeset [48369] by
-
- Fix <rdar://problem/7182275>.
Reviewed by David Hyatt.
Make sure that the newly created scrollbar's style is up to date.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::~PopupMenu):
Call setParent so that the scrollbar's parts are torn down correctly.
(WebCore::PopupMenu::show):
Call styleChanged.
- 14:25 Changeset [48368] by
-
DRT/test part of
<rdar://problem/7197644> WebKit should broadcast an MSAA event when
jumping to a named anchor
https://bugs.webkit.org/show_bug.cgi?id=28899
Reviewed by Adam Roben.
WebKitTools:
- DumpRenderTree/AccessibilityController.cpp:
(logScrollingStartEventsCallback):
Turn on logging of scrolling start events.
(AccessibilityController::getJSClass):
Add a "logScrollingStartEvents" to the AccessibilityController's JS
class definition.
(AccessibilityController::resetToConsistentState):
Turn off logging of scrolling start events.
- DumpRenderTree/AccessibilityController.h:
Declare setLogScrollingStartEvents(). Add a member for the scrolling
start event hook.
- DumpRenderTree/mac/AccessibilityControllerMac.cpp:
(AccessibilityController::setLogScrollingStartEvents):
Stubbed.
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::AccessibilityController):
Initialize the handle to 0.
(logEventProc):
Renamed from logFocusEventProc; now logs scrolling start events, too.
Removed the assertion that the event is a focus event. Added a switch
to print a message for focus, scrolling start, and other, unknown
events.
(AccessibilityController::setLogFocusEvents):
Changed to use logEventProc.
(AccessibilityController::setLogScrollingStartEvents):
If turning logging off, unhook the scrolling start event hook, and clear
the member holding the handle. If turning on, query for the root
accessible, so that accessibility is enabled for the WebView, and call
SetWinEventHook to setup an event hook using logEventProc as the
callback function.
LayoutTests:
- platform/win/accessibility/scroll-to-anchor-expected.txt: Added.
- platform/win/accessibility/scroll-to-anchor.html:
Added. Turns on scrolling start event logging, then jumps to an
anchor at the bottom of the page.
- 14:25 Changeset [48367] by
-
<rdar://problem/7197644> WebKit should broadcast an MSAA event when
jumping to a named anchor
https://bugs.webkit.org/show_bug.cgi?id=28899
Reviewed by Adam Roben.
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::):
Added declaration for handleScrolledToAnchor(). Added a new entry to
the enum of accessibility notifications.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::firstAccessibleObjectFromNode):
Code moved from AccessibilityRenderObject::internalLinkElement() and
refactored slightly; walks the tree until it finds a Node (with a
renderer) whose accessibility is not ignored.
- accessibility/AccessibilityObject.h:
Added a declaration for firstAccessibleObjectFromNode().
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::internalLinkElement):
Code moved to AccessibilityObject::firstAccessibleObjectFromNode().
- accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.
- accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
Add a default case that returns early for notifications that Mac
doesn't handle.
(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.
- accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::handleScrolledToAnchor):
Post an AXScrolledToAnchor notification for the first accessible from
the anchor Node.
(WebCore::AXObjectCache::postPlatformNotification):
If the notification is AXFocusedUIElementChanged, fire an
EVENT_OBJECT_FOCUS. If the notification is AXScrolledToAnchor, fire
EVENT_SYSTEM_SCROLLINGSTART, matching Firefox.
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
Code moved to postPlatformNotification().
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
Call AXObjectCache::handleScrolledToAnchor().
- 14:09 Changeset [48366] by
-
Cookies are not inspectable after reloading a page
https://bugs.webkit.org/show_bug.cgi?id=29222
Patch by Anthony Ricaud <rik@webkit.org> on 2009-09-14
Reviewed by Timothy Hatcher.
Create the cookieTreeElement on initialization instead of when the view is shown.
Reset the selected element of the sidebar on reset.
- inspector/front-end/StoragePanel.js:
(WebInspector.StoragePanel):
(WebInspector.StoragePanel.prototype.show):
(WebInspector.StoragePanel.prototype.reset):
- 14:07 CommitQueue edited by
- (diff)
- 13:32 Changeset [48365] by
-
Windows DRT build fix.
- 13:12 Changeset [48364] by
-
Windows build fix.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
(WebCore::WebCoreSynchronousLoader::load):
- 13:05 Changeset [48363] by
-
Safari 4 cannot be used to update firmware on Linksys routers.
<rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
Reviewed by Alexey Proskuryakov.
WebCore:
In http://trac.webkit.org/changeset/42483, we disabled CFNetwork's session credential storage and
implemented our own in WebCore.
One feature we lost is that CFNetwork would automatically send previously authenticated credentials
with new connections when the paths match, as allowed by RFC 2617 for HTTP Basic and Digest Authentication.
Even though it's optional for User Agents to do this, (some?) Linksys routers rely on this behavior for
HTTP Basic Authentication. So now WebCore's CredentialStorage will track URL paths for Basic credentials.
We're not making this enhancement for Digest at this time, since we don't know of anything that broke
due to the change in Digest behavior.
Test: http/tests/loading/basic-credentials-sent-automatically.html
http/tests/loading/basic-auth-resend-wrong-credentials.html
- WebCore.base.exp:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/Credential.cpp:
(WebCore::Credential::isEmpty):
- platform/network/Credential.h:
Add a slightly more full featured CredentialStore that will track URL paths a credential belongs to:
- platform/network/CredentialStorage.cpp: Added.
(WebCore::protectionSpaceToCredentialMap):
(WebCore::originToDefaultCredentialMap):
(WebCore::originStringFromURL):
(WebCore::CredentialStorage::set):
(WebCore::CredentialStorage::get):
(WebCore::CredentialStorage::getDefaultAuthenticationCredential):
- platform/network/CredentialStorage.h: Added.
Allow ProtectionSpace to be a hash key:
- platform/network/ProtectionSpace.cpp:
(WebCore::ProtectionSpace::ProtectionSpace):
- platform/network/ProtectionSpace.h:
(WebCore::ProtectionSpace::ProtectionSpace):
(WebCore::ProtectionSpace::isHashTableDeletedValue):
- platform/network/ProtectionSpaceHash.h: Added.
(WebCore::ProtectionSpaceHash::hash):
(WebCore::ProtectionSpaceHash::equal):
Allow ResourceHandles to remember the initial credential they used:
- platform/network/ResourceHandleInternal.h:
Allow mutable ResourceRequests to update their platform object if HTTP header fields change:
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::addHTTPHeaderField):
Remove WebCoreCredentialStorage:
- platform/network/cf/AuthenticationCF.cpp:
- platform/network/cf/AuthenticationCF.h:
- platform/network/mac/AuthenticationMac.h:
- platform/network/mac/AuthenticationMac.mm:
Change ResourceHandleCFNet to try to use stored credentials on new connections, if appropriate:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Only try the ProtectionSpace key'ed
Credential if it does not match the initially used Credential.
(WebCore::ResourceHandle::receivedCredential):
(WebCore::WebCoreSynchronousLoader::didReceiveChallenge): Only try the ProtectionSpace key'ed
Credential if it does not match the initially used Credential.
(WebCore::WebCoreSynchronousLoader::load):
Change ResourceHandleMac to try to use stored credentials on new connections, if appropriate:
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Only try the ProtectionSpace key'ed
Credential if it does not match the initially used Credential.
(WebCore::ResourceHandle::receivedCredential):
(-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Only try the
ProtectionSpace key'ed Credential if it does not match the initially used Credential.
(+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):
Add base64-ability to CString:
- platform/text/CString.cpp:
(WebCore::CStringBuffer::base64Encode):
(WebCore::CString::base64Encode):
- platform/text/CString.h:
(WebCore::CStringBuffer::create):
(WebCore::CStringBuffer::CStringBuffer):
WebKit/mac:
Adopt the new WebCore::CredentialStorage in WebKit/Mac.
- Misc/WebDownload.mm:
(-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
- Plugins/WebBaseNetscapePluginView.mm:
(WebKit::getAuthenticationInfo):
WebKit/win:
Adopt the new WebCore::CredentialStorage in WebKit/Win.
- WebDownloadCFNet.cpp:
(WebDownload::didReceiveAuthenticationChallenge):
WebKitTools:
Add the ability for DRT to handle authentication challenges.
- DumpRenderTree/LayoutTestController.cpp:
(setAuthenticationPasswordCallback):
(setAuthenticationUsernameCallback):
(setHandlesAuthenticationChallengesCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController::handlesAuthenticationChallenges):
(LayoutTestController::setHandlesAuthenticationChallenges):
(LayoutTestController::authenticationUsername):
(LayoutTestController::setAuthenticationUsername):
(LayoutTestController::authenticationPassword):
(LayoutTestController::setAuthenticationPassword):
- DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
- DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::didReceiveAuthenticationChallenge):
- DumpRenderTree/win/ResourceLoadDelegate.h:
LayoutTests:
- http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Added.
- http/tests/loading/basic-auth-resend-wrong-credentials.html: Added.
- http/tests/loading/basic-credentials-sent-automatically-expected.txt: Added.
- http/tests/loading/basic-credentials-sent-automatically.html: Added.
- http/tests/loading/resources/basic-auth-testing.php: Added.
- http/tests/loading/resources/othersubresources: Added.
- http/tests/loading/resources/othersubresources/protected-resource.php: Added.
- http/tests/loading/resources/protected-resource.php: Added.
- http/tests/loading/resources/subresources: Added.
- http/tests/loading/resources/subresources/protected-resource.php: Added.
- http/tests/loading/resources/test2: Added.
- http/tests/loading/resources/test2/basic-auth-testing.php: Added.
- http/tests/loading/resources/test2/protected-resource.php: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 12:01 Changeset [48362] by
-
2009-09-14 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Add some tests that fail to the skipped list and rebaseline two tests
to pass them.
- platform/gtk/Skipped: Populate with more failing tests.
- platform/gtk/fast/dom/Window/window-properties-expected.txt: Rebaseline.
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Ditto.
- 11:10 Changeset [48361] by
-
Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
Reviewed by Dan Bernstein.
WebKitTools:
Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
LayoutTests:
- plugins/destroy-during-npp-new-expected.txt: Added.
- plugins/destroy-during-npp-new.html: Added.
- 11:10 Changeset [48360] by
-
Fix <rdar://problem/7090444> Crashes in-[WebBaseNetscapePluginView stop] handling NSWindowWillCloseNotification.
Reviewed by Anders Carlsson.
It's not valid to call -addWindowObservers when the view is not in a window, but this can happen when -start
initializes a plug-in and the plug-in removes itself from the document during initialization. -viewDidMoveToWindow
calls -start and then calls -addWindowObservers without ensuring that the view is still in a window.
If -[WebBaseNetscapePluginView addWindowObservers] is incorrectly called when the view is not in a window, it will
observe NSWindowWillCloseNotification on all windows. This unexpected observer registration is not balanced by an
unregistration so the notification can be delivered after the view is deallocated, causing the crash seen in
<rdar://problem/7090444>.
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView start]): Only call -updateAndSetWindow if we still have a current window.
(-[WebBaseNetscapePluginView viewDidMoveToWindow]): Remove unnecessary calls to -restartTimers and -addWindowObservers
from -[WebBaseNetscapePluginView viewDidMoveToWindow]. They are already called from within -start with the extra benefit
of ensuring that the view is still in a window when they are called.
- 11:10 Changeset [48359] by
-
Fix <rdar://problem/6954546> Crashes in WebCore::RenderPart::setWidget below FrameLoader::loadPlugin.
Reviewed by Dan Bernstein.
The calls to FrameLoader::requestObject within RenderPartObject::updateWidget can result in a plug-in
being initialized. This can run cause arbitrary JavaScript to run and may result in the RenderPartObject
being detached from the render tree and destroyed, causing a crash like <rdar://problem/6954546>.
No test is possible until <rdar://problem/7090444> is fixed
- rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::updateWidget): Ensure that we stay alive for the duration of plug-in initialization.
- 11:10 Changeset [48358] by
-
Add RenderWidgetProtector to simplify protecting a RenderWidget from destruction for the duration of a function. Deploy it within RenderWidget.
Reviewed by Dan Bernstein.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::updateWidgetPosition): Use a RefPtr rather than explicitly
ref'ing and deref'ing the node.
- rendering/RenderWidget.h:
- rendering/RenderWidgetProtector.h:
(WebCore::RenderWidgetProtector::RenderWidgetProtector):
(WebCore::RenderWidgetProtector::~RenderWidgetProtector):
- 10:26 Changeset [48357] by
-
2009-09-14 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] QWebGraphicsItem should check for null QWebPage.
https://bugs.webkit.org/show_bug.cgi?id=29185
Don't crash in QWebGraphicsItem when the page is still null, by
either checking if it's the case or constructing the default one.
- Api/qwebgraphicsitem.cpp: (QWebGraphicsItem::icon): (QWebGraphicsItem::setZoomFactor): (QWebGraphicsItem::zoomFactor): (QWebGraphicsItem::setGeometry): (QWebGraphicsItem::load): (QWebGraphicsItem::setHtml): (QWebGraphicsItem::toHtml): (QWebGraphicsItem::setContent): (QWebGraphicsItem::history): (QWebGraphicsItem::settings):
- 10:19 Changeset [48356] by
-
2009-09-14 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
CodeGenerator.pm needs some cleaning up
https://bugs.webkit.org/show_bug.cgi?id=29238
- bindings/scripts/CodeGenerator.pm: (FindParentsRecursively): Removed; its functionality is now handled in AddMethodsConstantsAndAttributesFromParentClasses. (ForAllParents): New function that visits an interface's ancestors and invokes a callback for each one. (AddMethodsConstantsAndAttributesFromParentClasses): Simplified by using ForAllParents. (GetMethodsAndAttributesFromParentClasses): Ditto. (IDLFileForInterface): Factored out previous calls to ScanDirectory into this new function, which returns the filename containing a given IDL interface definition. (ParseInterface): Simplified by using IDLFileForInterface. (ScanDirectory): Removed in lieu of IDLFileForInterface.
- bindings/scripts/CodeGeneratorV8.pm: Drop call to FindParentsRecursively and get the list of parents from the AddMethodsConstantsAndAttributesFromParentClasses call instead.
- 10:06 Changeset [48355] by
-
wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
- 07:46 Changeset [48354] by
-
[Qt] Assert hit when dropping a file in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=29242
Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-14
Reviewed by Tor Arne Vestbø.
Qt's implementation of DropData::asURL does not return a URL encoded string
as expected.
- platform/qt/DragDataQt.cpp:
- 05:45 Changeset [48353] by
-
[Qt] Build fix for windows build.
Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-14
Reviewed by Tor Arne Vestbø.
- JavaScriptCore.pri: Correct a logic error.
- pcre/dftables: Add missing paranthesis for tmpdir function.
WebKitTools:
- Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
09/13/09:
- 22:47 Changeset [48352] by
-
wx build fix, file was missed during TLS.cpp removal.
- 19:29 Changeset [48351] by
-
Web Inspector: Add "New Style Rule" to the localizedStrings
https://bugs.webkit.org/show_bug.cgi?id=29237
Patch by Anthony Ricaud <rik@webkit.org> on 2009-09-13
Reviewed by Oliver Hunt.
- English.lproj/localizedStrings.js:
- 19:03 Changeset [48350] by
-
Fix typo accidently landed in last commit.
- 18:52 Changeset [48349] by
-
wx build fix, error out if using the wrong Python.
- 18:32 Changeset [48348] by
-
Reviewed by Kevin Ollivier.
Allow a way to set the cache policy via wx API.
https://bugs.webkit.org/show_bug.cgi?id=29200
- 18:20 Changeset [48347] by
-
Reviewed by Kevin Ollivier.
Allow the user to query Frame::shouldClose via wx API.
https://bugs.webkit.org/show_bug.cgi?id=29199
- 18:12 Changeset [48346] by
-
Reviewed by Kevin Ollivier.
Fix mouse handling when the mouse leaves the window during mouse down.
https://bugs.webkit.org/show_bug.cgi?id=29198
- 18:04 Changeset [48345] by
-
Reviewed by Kevin Ollivier.
Add support for console MessageLevel at wx API level.
https://bugs.webkit.org/show_bug.cgi?id=29197
- 17:34 Changeset [48344] by
-
Reviewed by Kevin Ollivier.
[wx] Implement filesystem functions.
- 03:45 Changeset [48343] by
-
2009-09-13 Xan Lopez <xlopez@igalia.com>
Build fix for GTK+ < 2.14.
Do not use gtk_widget_get_window, access the window directly
through the struct.
- DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (keyDownCallback):
- 03:23 Changeset [48342] by
-
2009-09-13 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez and Jan Alonzo.
[GTK] EventSender does not set 'window' property on synthesized GDK events
https://bugs.webkit.org/show_bug.cgi?id=29169
Set the window property on synthesized GDK events in the GTK+ EventSender.
- DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (keyDownCallback):
- 00:14 Changeset [48341] by
-
wx build fixes for wx 2.9.
09/12/09:
- 20:24 Changeset [48340] by
-
Build fix for windows exports (again).
- 20:10 Changeset [48339] by
-
Build fix for windows exports
- 20:03 Changeset [48338] by
-
Correct fix for non-allinonefile builds
- 20:00 Changeset [48337] by
-
Fix non-allinonefile builds
- 19:44 Changeset [48336] by
-
[ES5] Implement Object.keys
https://bugs.webkit.org/show_bug.cgi?id=29170
Reviewed by Maciej Stachowiak.
This patch basically requires two separate steps, the first is to split getPropertyNames
into two functions -- getOwnPropertyNames and getPropertyNames, basically making them behave
in the same way as getOwnPropertySlot and getPropertySlot. In essence getOwnPropertyNames
produces the list of properties on an object excluding its prototype chain and getPropertyNames
just iterates the the object and its prototype chain calling getOwnPropertyNames at each level.
- 18:17 Changeset [48335] by
-
run-webkit-tests has a timeout value that is too low
https://bugs.webkit.org/show_bug.cgi?id=29223
Reviewed by Mark Rowe.
- Scripts/run-webkit-tests:
Changed timeout value to 20 seconds to avoid timing out too early.
- 12:11 Changeset [48334] by
-
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29219
Document.elementFromPoint() should take page scroll into consideration
Reviewed by Anders Carlsson.
Test: fast/dom/elementFromPoint-relative-to-viewport.html
- dom/Document.cpp:
(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29219
Document.elementFromPoint() should take page scroll into consideration
Reviewed by Anders Carlsson.
- fast/dom/elementFromPoint-relative-to-viewport-expected.txt: Added.
- fast/dom/elementFromPoint-relative-to-viewport.html: Added.
- fast/events/offsetX-offsetY.html: Change to use clientX/Y instead of pageX/Y.
- fast/forms/slider-transformed.html: Ditto.
- fast/forms/slider-zoomed.html: Ditto.
- 01:14 Changeset [48333] by
-
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29217
Document.caretRangeFromPoint should take the scroll offset into account before hit testing
Reviewed by Maciej Stachowiak.
In accordance with the CSSOM View Module spec, Document.caretRangeFromPoint should interpret
the point passed to it as relative to the viewport, not the document.
Test: fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html
- dom/Document.cpp:
(WebCore::Document::caretRangeFromPoint):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29217
Document.caretRangeFromPoint should take the scroll offset into account before hit testing
Reviewed by Maciej Stachowiak.
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html: Added.
09/11/09:
- 23:55 Changeset [48332] by
-
2009-09-11 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
[GTK] Use gtk_style_set_background instead of gdk_window_set_background
https://bugs.webkit.org/show_bug.cgi?id=29173
Use gtk_style_set_background instead of gdk_window_set_background,
as suggested by the documentation. Also, use GTK_STATE_NORMAL
directly, since that's the default state of a GtkWidget.
- webkit/webkitwebview.cpp: (webkit_web_view_realize):
- 21:52 Changeset [48331] by
-
getPropertyNames caching is invalid when the prototype chain contains objects with custom getPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=29214
Reviewed by Sam Weinig.
Add a flag to TypeInfo to indicate whether a type overrides getPropertyNames.
This flag is used to make sure that caching of the property name data is safe.
- 20:40 Changeset [48330] by
-
Added some manual tests to show WebGL in action
https://bugs.webkit.org/show_bug.cgi?id=29215
- 20:33 Changeset [48329] by
-
wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
architectures are supported for building wxWebKit.
- 20:31 Changeset [48328] by
-
aria definition role spelled wrong "defintion"
https://bugs.webkit.org/show_bug.cgi?id=28840
Reviewed by Darin Adler.
WebCore:
Test: accessibility/aria-slider-value-change.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::RoleEntry::):
LayoutTests:
- platform/mac/accessibility/aria-grouping-roles-expected.txt:
- platform/mac/accessibility/aria-grouping-roles.html:
- 19:17 Changeset [48327] by
-
2009-09-11 Erik Arvidsson <arv@chromium.org>
Reviewed by Eric Seidel.
Fixes an assert in Node::isFocusable which was causing crashes in certain cases.
https://bugs.webkit.org/show_bug.cgi?id=29210
- fast/events/resources/tab-is-focusable-assert.js:
- fast/events/tab-is-focusable-assert-expected.txt: Added.
2009-09-11 Erik Arvidsson <arv@chromium.org>
Reviewed by Eric Seidel.
Fixes an assert in Node::isFocusable which was causing crashes in certain cases.
https://bugs.webkit.org/show_bug.cgi?id=29210
- dom/Node.cpp: (WebCore::Node::isFocusable):
- 18:48 Changeset [48326] by
-
Fix <rdar://problem/7145242> Crashes inside WTF::HashTable below NetscapePluginInstanceProxy::disconnectStream
Reviewed by Jon Honeycutt.
- Plugins/Hosted/HostedNetscapePluginStream.mm:
(WebKit::HostedNetscapePluginStream::cancelLoad): Canceling the load can result in calling through to disconnectStream.
If the plug-in instance holds the last reference to the plug-in stream this will result in the stream being deallocated.
This leads to HostedNetscapePluginStream::cancelLoad's call to disconnectStream being passed a deallocated stream object.
Since the stream was already disconnected by the call to cancel there's no need to call disconnectStream a second time.
- 17:13 Changeset [48325] by
-
Added variants to uniform* and vertexAttrib* calls which take sequence<> in place of CanvasArray
https://bugs.webkit.org/show_bug.cgi?id=29139
I also added a data() call to each of the CanvasArray subclasses to give back a types pointer
to the baseAddress().
- 17:00 Changeset [48324] by
-
2009-09-11 Steve Falkenburg <sfalken@apple.com>
Reviewed by Dan Bernstein.
Properly propagate preference from WebPreferences to WebCore::Settings.
https://bugs.webkit.org/show_bug.cgi?id=29192
- WebView.cpp: (WebView::initWithFrame): Apply setting when creating a new WebView. (WebView::notifyPreferencesChanged): Apply setting when preferences change.
- 16:59 Changeset [48323] by
-
2009-09-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
Add ENABLE(WEB_SOCKETS) guards.
https://bugs.webkit.org/show_bug.cgi?id=29174
- bindings/v8/custom/V8WebSocketCustom.cpp:
- 16:57 Changeset [48322] by
-
2009-09-11 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Mark Rowe.
Add the http/tests/security/mixedContent to the Skipped list while
test failures are being investigated.
- platform/win/Skipped:
- 16:34 Changeset [48321] by
-
2009-09-11 Eric Seidel <eric@webkit.org>
No review, rolling out r48229.
http://trac.webkit.org/changeset/48229
- fast/events/drag-dropeffect-expected.txt: Removed.
- fast/events/drag-dropeffect.html: Removed.
2009-09-11 Eric Seidel <eric@webkit.org>
No review, rolling out r48229.
http://trac.webkit.org/changeset/48229
- WebCore.base.exp:
- dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard): (WebCore::Clipboard::sourceOperation):
- page/DragController.cpp: (WebCore::DragController::DragController): (WebCore::DragController::dragExited): (WebCore::DragController::performDrag): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDHTMLDrag): (WebCore::DragController::startDrag):
- page/DragController.h:
- page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::dragSourceMovedTo): (WebCore::EventHandler::handleDrag):
- page/EventHandler.h:
2009-09-11 Eric Seidel <eric@webkit.org>
No review, rolling out r48229.
http://trac.webkit.org/changeset/48229
- WebView/WebFrame.mm: (-[WebFrame _dragSourceMovedTo:]):
- 16:28 Changeset [48320] by
-
2009-09-11 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
bugzilla-tool rollout threw exception under svn
https://bugs.webkit.org/show_bug.cgi?id=29211
- Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
- Scripts/modules/scm_unittest.py: add testing for this fix.
- 15:18 Changeset [48319] by
-
Fix the build.
2009-09-11 Michelangelo De Simone <micdesim@gmail.com>
Fix the build.
- html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
- 15:01 Changeset [48318] by
-
2009-09-11 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=27456
Test case for url validation in ValidityState.
- fast/forms/ValidityState-typeMismatch-url-expected.txt: Added.
- fast/forms/ValidityState-typeMismatch-url.html: Added.
- fast/forms/resources/ValidityState-typeMismatch-url.js: Added. (check):
2009-09-11 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=27456
Added support for static validation of url in
ValidityState, for url state inputs.
From HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#url-state
Test: fast/forms/ValidityState-typeMismatch-url.html
- html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
- 14:52 Changeset [48317] by
-
2009-09-11 Evan Stade <estade@chromium.org>
Reviewed by Darin Adler.
Revert r47992: Expose functions to change the focus ring color for
Linux Chromium.
As Darin Fisher has pointed out, there is a better way to do this.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux):
- rendering/RenderThemeChromiumLinux.h:
- 14:51 CommitQueue edited by
- (diff)
- 14:47 Changeset [48316] by
-
2009-09-11 Brian Weinstein <bweinstein@apple.com>
Add myself to the committers list.
- Scripts/modules/committers.py:
- 14:34 Changeset [48315] by
-
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=29207
Add checks for using WebCore JS context on secondary threads
- 13:21 Changeset [48314] by
-
2009-09-11 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
The inspector should have scope bars.
https://bugs.webkit.org/show_bug.cgi?id=14353
Add scope bars to the console, so the user can choose which category
of messages they want to see (All, Errors, Warnings, Logs), and they
can choose from one or more of {Errors, Warnings, Logs}.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createFilterElement): (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._updateFilter): (WebInspector.ConsoleView.prototype.filter): (WebInspector.ConsoleView.prototype.attach):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- 13:09 Changeset [48313] by
-
2009-09-11 Yusuke Sato <yusukes@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Complex text doesn't show up with text stroking
https://bugs.webkit.org/show_bug.cgi?id=28707
Added extra NULL checks for HDC. This is the second fix for issue 28707,
and the fix is similar to http://trac.webkit.org/changeset/45482.
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawComplexText):
- platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::draw):
- 12:05 Changeset [48312] by
-
2009-09-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool land-patches should only fail-fast in --commit-queue mode
https://bugs.webkit.org/show_bug.cgi?id=29201
- Scripts/bugzilla-tool:
- 11:47 Changeset [48311] by
-
2009-09-11 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Make ElementTimeControl methods return void and not throw.
https://bugs.webkit.org/show_bug.cgi?id=28831
SVG 1.1 erratum:
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#elementtimecontrol-interface
- svg/dom/smil-methods-expected.txt: Added.
- svg/dom/smil-methods.svg: Added.
2009-09-11 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Make ElementTimeControl methods return void and not throw.
https://bugs.webkit.org/show_bug.cgi?id=28831
SVG 1.1 erratum:
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#elementtimecontrol-interface
Test: svg/dom/smil-methods.svg
- svg/ElementTimeControl.h: Change return type from bool to void and remove exception argument.
- svg/ElementTimeControl.idl: Change return type from bool to void and remove raises claus.
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::beginElement): Change return type from bool to void and remove exception argument. (WebCore::SVGAnimationElement::beginElementAt): Ditto. (WebCore::SVGAnimationElement::endElement): Ditto. (WebCore::SVGAnimationElement::endElementAt): Ditto.
- svg/SVGAnimationElement.h: Ditto.
- 11:31 Changeset [48310] by
-
Added support for texImage2D which takes CanvasArray
https://bugs.webkit.org/show_bug.cgi?id=29191
- bindings/js/JSCanvasRenderingContext3DCustom.cpp: (WebCore::JSCanvasRenderingContext3D::texImage2D):
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::texImage2D):
- 11:15 Changeset [48309] by
-
2009-09-11 David Kilzer <ddkilzer@apple.com>
Apply fix for http://www.bugzilla.org/security/3.0.8/
- 11:04 Changeset [48308] by
-
WebCore: Allow WebKit clients to opt out of high resolution timers on Windows.
https://bugs.webkit.org/show_bug.cgi?id=29192
Reviewed by Darin Adler.
- page/Settings.cpp:
(WebCore::Settings::setShouldUseHighResolutionTimers): Added.
- page/Settings.h: Added getter/setter for shouldUseHighResolutionTimers.
(WebCore::Settings::shouldUseHighResolutionTimers): Added.
- platform/win/SharedTimerWin.cpp:
(WebCore::setSharedTimerFireTime): Don't run high resolution timer code if it is disabled.
WebKit/win: Allow WebKit clients to opt out of high resolution timers on Windows.
https://bugs.webkit.org/show_bug.cgi?id=29192
Reviewed by Darin Adler.
- Interfaces/IWebPreferencesPrivate.idl: Added getter/setter.
Put this just after last 4.0.3 method for future merging.
- Interfaces/WebKit.idl: Touched to force a rebuild.
- WebPreferenceKeysPrivate.h: Added prefs key for high res timers.
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Initialize high res timers to enabled.
(WebPreferences::setShouldUseHighResolutionTimers): Added.
(WebPreferences::shouldUseHighResolutionTimers): Added.
- WebPreferences.h: Added getter/setter.
- 11:03 Changeset [48307] by
-
Make commit-log-editor move common prefixes to the top of the log
Fies <http://webkit.org/b/29190> commit-log-editor should move common
prefixes to the top of the commit log
Reviewed by Darin Adler.
- Scripts/commit-log-editor: Find and remove the longest common prefix
ending in a double newline from each ChangeLog entry, then put that
common prefix at the top of the commit log.
(removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
removes, and returns the longest common prefix ending in a double
newline from a hash of strings
- 10:59 Changeset [48306] by
-
2009-09-11 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
Reviewed by Adam Barth.
[v8] Share persistent context handles between events
Change events to use a single ref-counted shared persistent handle
to the context in which to run, rather than create a new
persistent handle for each new event which puts pressure on the
gc.
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- bindings/v8/SharedPersistent.h: Added. (WebCore::SharedPersistent::set): (WebCore::SharedPersistent::get): (WebCore::SharedPersistent::disposeHandle): (WebCore::SharedPersistent::create): (WebCore::SharedPersistent::SharedPersistent):
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): (WebCore::V8AbstractEventListener::handleEvent):
- bindings/v8/V8AbstractEventListener.h:
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld): (WebCore::V8IsolatedWorld::~V8IsolatedWorld):
- bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::context): (WebCore::V8IsolatedWorld::shared_context):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::createWrapperFromCacheSlowCase): (WebCore::V8Proxy::isContextInitialized): (WebCore::V8Proxy::updateDocumentWrapperCache): (WebCore::V8Proxy::clearDocumentWrapperCache): (WebCore::V8Proxy::disposeContextHandles): (WebCore::V8Proxy::clearForClose): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::setSecurityToken): (WebCore::V8Proxy::updateDocument): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::shared_context): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::setContextDebugId):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::context): (WebCore::V8Proxy::shared_context):
- 10:20 Changeset [48305] by
-
2009-09-11 Anton Muhin <antonm@chromium.org>
Reviewed by David Levin.
Create a real handle (one which would save an object from GC).
https://bugs.webkit.org/show_bug.cgi?id=29150
- bindings/v8/V8Binding.cpp: (WebCore::v8ExternalString):
- 10:12 Changeset [48304] by
-
2009-09-11 Eric Seidel <eric@webkit.org>
Fix obvious typo in previous commit, no review.
bugzilla-tool should automate rollouts
https://bugs.webkit.org/show_bug.cgi?id=26715
- Scripts/bugzilla-tool: add back missing "scm" argument.
- 09:54 Changeset [48303] by
-
2009-09-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool should automate rollouts
https://bugs.webkit.org/show_bug.cgi?id=26715
bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
The --complete-rollout option will automatically land and update the bug.
Eventually --complete-rollout will be default, but that will require more testing.
This first pass is good enough for others to try and file bugs about.
- Scripts/bugzilla-tool:
- Move modified_changelogs into scm.py.
- Move svn_revision_from_commit_text logic into scm.py.
- Add RolloutCommit command.
- Scripts/modules/bugzilla.py:
- Add reopen_bug command used by RolloutCommit.
- Scripts/modules/scm.py:
- Add functions to support RolloutCommit.
- Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
- Add a str() call so that svn_commit_log can take a numeric argument.
- Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
- Made dry_run commits return something that svn_revision_from_commit_text can parse.
- Scripts/modules/scm_unittest.py:
- Add read_from_path for easy file reading.
- Put test4 on a new line to make reverts work w/o conflict.
- Add an "svn update" call so that the checkout revision matches the server revision.
- Add tests for svn_revision_from_commit_text.
- Add a simple test for apply_reverse_diff.
- Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
- Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
- Scripts/bugzilla-tool:
- 09:35 Changeset [48302] by
-
Get user script/stylesheet tests running on Windows
Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
skipped on Windows
Reviewed by John Sullivan.
WebKit/win:
- Interfaces/IWebViewPrivate.idl: Added addUserScriptToGroup,
addUserStyleSheetToGroup, removeUserContentFromGroup,
removeAllUserContentFromGropu to match the Mac SPI.
- WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserContentFromGroup):
(WebView::removeAllUserContentFromGroup):
- WebView.h:
Added. Implementation was based on similar methods in WebView.mm.
WebKitTools:
- DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
against comsuppw.lib so we can use _bstr_t.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
order, added #include of comutil.h for _bstr_t.
(bstrT): Helper function to convert a JSStringRef to a _bstr_t.
(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
Implemented. Implementations were based on those in
LayoutTestControllerMac.mm.
LayoutTests:
- platform/win/Skipped: Removed the userscripts directory.
- 07:47 Changeset [48301] by
-
2009-09-11 Anton Muhin <antonm@chromium.org>
Reviewed by David Levin.
Inline WebCore::v8String as it only invokes WebCore::v8ExternalString.
https://bugs.webkit.org/show_bug.cgi?id=29152
- bindings/v8/V8Binding.cpp:
- bindings/v8/V8Binding.h: (WebCore::v8String):
- 06:29 Changeset [48300] by
-
2009-09-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
Compiling JavaScriptCore on sparc 64 with gcc fails.
ThreadSafeShared uses the atomic gnu_cxx::exchange_and_add with an int,
however on sparc 64 the _Atomic_word argument is typedefed to long (8 bytes).
The patch disables WTF_USE_LOCKFREE_THREADSAFESHARED in ThreadSafeShared to use
a mutex instead when compiling for sparc 64 with gcc.
- wtf/Platform.h: sparc64 is not defined on all OS.
Uses instead: sparc && arch64 sparcv9 - wtf/Threading.h:
- 05:58 Changeset [48299] by
-
Doc: Note that Netscape plugins are only available on desktop platforms.
Patch by David Boddie <dboddie@trolltech.com> on 2009-09-11
Reviewed by Simon Hausmann.
- docs/qtwebkit.qdoc:
- 05:58 Changeset [48298] by
-
Fix compile error on Windows7(64Bit) with latest SDK.
Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.
Added the missing include file.
- runtime/UString.cpp:
- 05:58 Changeset [48297] by
-
Adjust the name of the contentspage for the documentation
to the new name used in Qt 4.6.
Patch by Martin Smith <msmith@trolltech.com> on 2009-09-11
Reviewed by Simon Hausmann.
- docs/qtwebkit.qdoc:
- 05:58 Changeset [48296] by
-
Qt/Windows CE compile fix, include the executable allocator and
markstack implementation in the windows build.
Patch by Joerg Bornemann <joerg.bornemann@trolltech.com> on 2009-09-11
Reviewed by Simon Hausmann.
- JavaScriptCore.pri:
- 05:58 Changeset [48295] by
-
WebCore: Changed URLs from qtsoftware.com to qt.nokia.com, as part of a general
renaming.
Patch by Ariya Hidayat <ariya.hidayat@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.
- ChangeLog-2009-06-16:
WebKit/qt: Changed URLs from qtsoftware.com to qt.nokia.com, as part of a general
renaming.
Patch by Ariya Hidayat <ariya.hidayat@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.
- Api/qwebpluginfactory.cpp:
- docs/webkitsnippets/simple/main.cpp:
(main):
- docs/webkitsnippets/webpage/main.cpp:
(main):
- 05:57 Changeset [48294] by
-
Restructure the documentation, both on a file and on a content level.
Patch by Volker Hilsheimer <volker.hilsheimer@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.
- Api/qwebdatabase.cpp:
- Api/qwebelement.cpp:
- Api/qwebframe.cpp:
- Api/qwebhistory.cpp:
- Api/qwebhistoryinterface.cpp:
- Api/qwebpage.cpp:
- Api/qwebpluginfactory.cpp:
- Api/qwebsecurityorigin.cpp:
- Api/qwebsettings.cpp:
- Api/qwebview.cpp:
- docs/qtwebkit.qdoc:
- 05:57 Changeset [48293] by
-
Use LIBS_PRIVATE on Qt/Mac.
Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.
On the Mac, it means "-framework ApplicationServices -framework Carbon
-framework AppKit" are no longer part of the default LIBS in Qt
applications. This required a lot of fixes where we used Mac-specific
code in Qt.
- WebCore.pro:
- 02:02 Changeset [48292] by
-
2009-09-11 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Remove duplicated WK_{u,l}cfirst subs from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=29165
- bindings/scripts/CodeGeneratorV8.pm: Remove WK_ucfirst and WK_lcfirst, and call the ones in CodeGenerator.pm instead.
- 01:55 Changeset [48291] by
-
2009-09-11 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=29136
[Qt] emit microFocusChanged() signal when no QWidget-based view is present.
emit microFocusChange() signal regardless of view.
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
- 01:43 Changeset [48290] by
-
2009-09-11 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=29132
Symbian winscw compiler fails compiling WebCore/text/RegularExpression.cpp.
Add RegularExpression class qualifier before Private.
- platform/text/RegularExpression.cpp:
- 01:35 Changeset [48289] by
-
2009-09-11 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=29131
Use a different variadic macro format for Symbian compiler.
Use arg... instead of ellipsis in variadic macro.
- platform/StaticConstructors.h:
- 01:27 Changeset [48288] by
-
WebCore: https://bugs.webkit.org/show_bug.cgi?id=28806
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.
[Qt] Make the WebInspector available as a QWidget.
- WebCore.pro:
WebKit/qt: https://bugs.webkit.org/show_bug.cgi?id=28806
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.
[Qt] Make the WebInspector available as a QWidget.
- Api/headers.pri:
- Api/qwebelement.cpp:
(QWebElement::enclosingElement):
- Api/qwebelement.h:
- Api/qwebinspector.cpp: Added.
- Api/qwebinspector.h: Added.
- Api/qwebinspector_p.h: Added.
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::setInspector):
(QWebPagePrivate::getOrCreateInspector):
(QWebPagePrivate::inspectorController):
(QWebPage::~QWebPage):
(QWebPage::triggerAction):
- Api/qwebpage.h:
- Api/qwebpage_p.h:
- Api/qwebsettings.cpp:
- QtLauncher/main.cpp:
(MainWindow::MainWindow):
- WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientWebPage::InspectorClientWebPage):
(WebCore::InspectorClientWebPage::createWindow):
(WebCore::InspectorClientQt::createPage):
(WebCore::InspectorClientQt::showWindow):
(WebCore::InspectorClientQt::closeWindow):
(WebCore::InspectorClientQt::attachWindow):
(WebCore::InspectorClientQt::detachWindow):
(WebCore::InspectorClientQt::updateWindowTitle):
- WebCoreSupport/InspectorClientQt.h:
- docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp: Added.
- 01:18 Changeset [48287] by
-
Unreviewed fix for the Web Inspector with the Qt build.
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-11
Re-generate the Qt resource file by running
WebKitTools/Scripts/generate-qt-inspector-resource
- inspector/front-end/WebKit.qrc:
- 01:12 Changeset [48286] by
-
Fix the Qt build, remove stray semicolon from function definition.
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-11
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivate::buffered):
- 00:43 Changeset [48285] by
-
Fix crash on launch on Windows.
Rubber-stamped by Mark Rowe.
- WebKit.vcproj/WebKit.vcproj:
Define ENABLE_WEB_SOCKETS for all configurations.
09/10/09:
- 22:48 Changeset [48284] by
-
2009-09-10 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Detect mixed content
https://bugs.webkit.org/show_bug.cgi?id=29003
Add some tests for mixed content. All but one of these tests pass
currently. The one that fails is pretty tricky, but I wanted to get it
into the tree with a FIXME so we won't forget it. I'll file a followup
bug about fixing it.
- http/tests/security/mixedContent/about-blank-iframe-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html: Added.
- http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/data-url-iframe-in-main-frame.html: Added.
- http/tests/security/mixedContent/data-url-script-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/data-url-script-in-iframe.html: Added.
- http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/insecure-css-in-iframe.html: Added.
- http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/insecure-css-in-main-frame.html: Added.
- http/tests/security/mixedContent/insecure-iframe-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/insecure-iframe-in-iframe.html: Added.
- http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/insecure-iframe-in-main-frame.html: Added.
- http/tests/security/mixedContent/insecure-image-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/insecure-image-in-iframe.html: Added.
- http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/insecure-image-in-main-frame.html: Added.
- http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/insecure-script-in-iframe.html: Added.
- http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html: Added.
- http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html: Added.
- http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html: Added.
- http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html: Added.
- http/tests/security/mixedContent/resources/boring.html: Added.
- http/tests/security/mixedContent/resources/frame-with-about-blank-frame.html: Added.
- http/tests/security/mixedContent/resources/frame-with-data-url-frame.html: Added.
- http/tests/security/mixedContent/resources/frame-with-data-url-script.html: Added.
- http/tests/security/mixedContent/resources/frame-with-insecure-css.html: Added.
- http/tests/security/mixedContent/resources/frame-with-insecure-frame.html: Added.
- http/tests/security/mixedContent/resources/frame-with-insecure-image.html: Added.
- http/tests/security/mixedContent/resources/frame-with-insecure-script.html: Added.
- http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-frame.html: Added.
- http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-script.html: Added.
- http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-frame.html: Added.
- http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-script.html: Added.
- http/tests/security/mixedContent/resources/script.js: Added.
- http/tests/security/mixedContent/resources/style.css: Added.
2009-09-10 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Detect mixed content
https://bugs.webkit.org/show_bug.cgi?id=29003
Detect some basic kinds of mixed content (HTTP content loaded into an
HTTPS context). This new detection logic isn't perfect, but it's a
place to start.
Tests: http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html
http/tests/security/mixedContent/data-url-iframe-in-main-frame.html
http/tests/security/mixedContent/data-url-script-in-iframe.html
http/tests/security/mixedContent/insecure-css-in-iframe.html
http/tests/security/mixedContent/insecure-css-in-main-frame.html
http/tests/security/mixedContent/insecure-iframe-in-iframe.html
http/tests/security/mixedContent/insecure-iframe-in-main-frame.html
http/tests/security/mixedContent/insecure-image-in-iframe.html
http/tests/security/mixedContent/insecure-image-in-main-frame.html
http/tests/security/mixedContent/insecure-script-in-iframe.html
http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
- loader/DocLoader.cpp: (WebCore::DocLoader::canRequest): (WebCore::DocLoader::requestResource): (WebCore::DocLoader::checkCacheObjectStatus):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::isMixedContent): (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent):
- loader/FrameLoader.h:
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest):
- 21:03 Changeset [48283] by
-
Revert http://trac.webkit.org/changeset/48277, as it wasn't the right way to fix the build.
- 20:34 Changeset [48282] by
-
Fix the Windows build.
Restore platform/mock to the header search path after it was removed in r48270.
- WebCore.vcproj/WebCoreCommon.vsprops:
- 20:17 Changeset [48281] by
-
Web Inspector: Move the option to create a new style rule under the Styles' gear menu.
https://bugs.webkit.org/show_bug.cgi?id=29039
Reviewed by Sam Weinig.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane): Add "New Style Rule" option to the gear menu.
(WebInspector.StylesSidebarPane.prototype._update): Check instanceof BlankStylePropertiesSection instead.
(WebInspector.StylesSidebarPane.prototype._changeSetting): Added. Keeps the color format setting selected
while calling the correct action.
(WebInspector.StylesSidebarPane.prototype._createNewRule): Creates a new section and edits the selector.
(WebInspector.StylesSidebarPane.prototype.addBlankSection): Insert the section in a cleaner way.
(WebInspector.StylesSidebarPane.prototype.removeSection): Added. Removes the passed in section.
(WebInspector.StylesSidebarPane.prototype.appropriateSelectorForNode): Return an empty string if there is no node.
(WebInspector.StylePropertiesSection.prototype.expand): Removed the check for _blank.
(WebInspector.StylePropertiesSection.prototype.startEditingSelector): No need for the context, the original selector
is remembered by the editing code.
(WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled): Do nothing. The original text is already
restored by the editing code.
(WebInspector.BlankStylePropertiesSection): Call the StylePropertiesSection constructor with appropriate data.
Remove event listener code.
(WebInspector.BlankStylePropertiesSection.prototype.expand): Added. Does nothing to prevent expanding.
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.callback): Correctly construct the
WebInspector.CSSStyleDeclaration. Call editingSelectorCancelled instead of editingCancelled.
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted): Renamed from editingCommitted to
override the base class.
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCancelled): Remove the section.
(WebInspector.BlankStylePropertiesSection.prototype.makeNormal): Removed event listener code. Removed the delete lines
since they were doing nothing (deleting nonexistent properties that exist only on the prototype.) Change prototypes at
the end to correctly swtich to a real StylePropertiesSection.
- inspector/front-end/inspector.js:
(WebInspector.startEditing.editingCancelled): Ceck for null/undefined callbacks.
(WebInspector.startEditing.editingCommitted): Ditto.
- 20:10 Changeset [48280] by
-
2009-09-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
[Qt] Fix comparison between signed and unsigned integer warnings
https://bugs.webkit.org/show_bug.cgi?id=29162
No functional change.
- Api/qwebelement.cpp: (QWebElement::findAll):
- Api/qwebhistory.cpp: (QWebHistory::items): (QWebHistory::backItems): (QWebHistory::forwardItems): (QWebHistory::saveState):
- Api/qwebplugindatabase.cpp: (QWebPluginDatabase::setSearchPaths):
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runOpenPanel):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
2009-09-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
[Qt] Fix comparison between signed and unsigned integer warnings
https://bugs.webkit.org/show_bug.cgi?id=29162
No functional change.
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::findMethodIndex):
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedImageMIMETypesForEncoding):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::duration): (WebCore::ImageDecoderQt::imageAtIndex):
- plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::fetchInfo):
- 19:45 Changeset [48279] by
-
2009-09-10 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha.
Build fix for GTK+ after r48267.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::buffered):
- 19:14 Changeset [48278] by
-
<http://webkit.org/b/29147> run-webkit-tests: make -h show help
Reviewed by Mark Rowe.
- Scripts/run-webkit-tests: Updated to make -h switch show help.
- 19:13 Changeset [48277] by
-
Attemped Windows build fix by adding platform/mock headers to be copied.
- 18:22 MathML edited by
- (diff)
- 18:16 WikiStart edited by
- (diff)
- 16:59 Changeset [48276] by
-
Sorry, one more unused paramater breaking Mac build. Will test on my Mac first next time.
- 16:57 Changeset [48275] by
-
Fix build break on Mac
- 16:38 Changeset [48274] by
-
2009-09-08 John Abd-El-Malek <jam@chromium.org>
Reviewed by Dimitri Glazkov.
Remove unneeded define for ActiveX.
https://bugs.webkit.org/show_bug.cgi?id=29054
- wtf/Platform.h:
WebCore:
2009-09-08 John Abd-El-Malek <jam@chromium.org>
Reviewed by Dimitri Glazkov.
Remove unneeded define for ActiveX.
https://bugs.webkit.org/show_bug.cgi?id=29054
- rendering/RenderPartObject.cpp: (WebCore::createClassIdToTypeMap): (WebCore::serviceTypeForClassId): (WebCore::RenderPartObject::updateWidget):
- 16:16 Changeset [48273] by
-
Update JavaScriptCore and WebKit's FeatureDefines.xcconfig so that they are in sync with WebCore as they need to be.
Rubber-stamped by Sam Weinig.
- 16:06 Changeset [48272] by
-
Don't copy IDL files in to the built framework.
Rubber-stamped by Sam Weinig.
- WebCore.xcodeproj/project.pbxproj:
- 16:00 Changeset [48271] by
-
2009-09-10 Xiaomei Ji <xji@chromium.org>
Reviewed by Eric Seidel.
Implement Range.expand().
https://bugs.webkit.org/show_bug.cgi?id=27632
- fast/dom/Range/range-expand-expected.txt: Added.
- fast/dom/Range/range-expand.html: Added.
- fast/dom/Window/window-properties-expected.txt:
2009-09-10 Xiaomei Ji <xji@chromium.org>
Reviewed by Eric Seidel.
Implment Range.expand().
https://bugs.webkit.org/show_bug.cgi?id=27632
Test: fast/dom/Range/range-expand.html
- dom/Range.cpp: (WebCore::Range::expand):
- dom/Range.h:
- dom/Range.idl:
- 15:45 Changeset [48270] by
-
Reviewed by Alexey Proskuryakov.
WebSocket API implementation.
https://bugs.webkit.org/show_bug.cgi?id=28038
Add build systems for GNUmakefile.am, WebCore.xcodeproj and
WebCore.vcproj.
Add websockets directory and WebSocket.idl in qt build system.
Tests will be landed once the code is completed and functional.
- 15:28 Changeset [48269] by
-
2009-09-10 Albert J. Wong <ajwong@chromium.org>
No review, windows build fix only.
Spurious semicolon causing parse error in chromium build on windows.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::buffered): Removed semicolon.
- 15:15 Changeset [48268] by
-
2009-09-10 Albert J. Wong <ajwong@chromium.org>
No review, build fix only.
Adding in a missed include from the last patch that is breaking the
chromium build.
- rendering/RenderThemeChromiumMac.mm: include TimeRanges.h
- 14:46 Changeset [48267] by
-
HTMLMediaElement buffered attribute should report a list of time ranges
https://bugs.webkit.org/show_bug.cgi?id=29041
Patch by Alpha Lam <hclam@chromium.org> on 2009-09-10
Reviewed by Eric Carlson.
Changed MediaPlayerPrivateInterface and MediaPlayer's definition to
report a list of buffered time ranges as WebCore::TimeRanges. This
change also got rid of the maxTimeBuffered() method.
No new tests since this is a API change.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::percentLoaded):
Use MediaPlaier::buffered() instead of maxTimeBuffered().
(WebCore::HTMLMediaElement::buffered):
ditto.
- platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::buffered):
Use MediaPlayerPrivateInterface::buffered() instead of maxTimeBuffered().
(WebCore::MediaPlayer::buffered):
ditto.
- platform/graphics/MediaPlayer.h:
Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().
- platform/graphics/MediaPlayerPrivate.h:
ditto.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
Implements PassRefPtr<TimeRanges> buffered();
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::buffered):
Implementation of buffered().
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
Implements PassRefPtr<TimeRanegs> buffered().
- platform/graphics/qt/MediaPlayerPrivatePhonon.h:
Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
Implements PassRefPtr<TimeRanges> buffered().
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().
- platform/graphics/wince/MediaPlayerPrivateWince.h:
ditto.
- rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
Use buffered() instead of maxTimeBuffered().
- rendering/RenderThemeChromiumSkia.cpp:
ditto.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaSliderTrack):
ditto.
- 14:34 Changeset [48266] by
-
2009-09-10 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Make bindings generators more aware of IDL dependencies
https://bugs.webkit.org/show_bug.cgi?id=29114
Make the JS and ObjC bindings generators able to output dependency
rules for DerivedSources.make to consume. These rules make a given
generated binding class file header, JSWhatever.h, depend on Whatever's
ancestor interfaces.
- DerivedSources.make: Pass --write-dependencies to generate-bindings.pl when generating JS and ObjC bindings. Include dependency fies that are generated due to that.
- bindings/scripts/CodeGenerator.pm: Make AddMethodsConstantsAndAttributesFromParentClasses accumulate a list of the ancestor interfaces that were visited.
- bindings/scripts/CodeGeneratorJS.pm: Optionally write out a dependency file.
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- bindings/scripts/generate-bindings.pl: Add a --write-dependencies option.
- 13:49 Changeset [48265] by
-
Windows build fix.
Make StructureTransitionTable use an enum for the PtrAndFlags member
used for the single transition slot optimisation.
- 13:01 Changeset [48264] by
-
Refactor StructureTransitionTable and Structure to unify handling of the single slot optimization
https://bugs.webkit.org/show_bug.cgi?id=29141
Reviewed by Geoff Garen
Make StructureTransitionTable encapsulate the single transition slot optimization.
- 12:52 Changeset [48263] by
-
Rubber-stamped by Ariya Hidayat.
Patch by Simon Hausmann <hausmann@webkit.org> on 2009-09-10
Fix a bunch of qdoc warnings: Invalid references, non-standard
wording, etc.
- Api/qwebelement.cpp:
- Api/qwebgraphicsitem.cpp:
- Api/qwebsecurityorigin.cpp:
- 12:42 Changeset [48262] by
-
Fix context menu event delivery with QWebGraphicsItem.
Patch by Simon Hausmann <hausmann@webkit.org> on 2009-09-10
Reviewed by Ariya Hidayat.
Re-implement the correct context menu virtual function using
a QGraphicsSceneContextMenuEvent and forward & handle it in
QWebPage.
- Api/qwebgraphicsitem.cpp:
(QWebGraphicsItem::contextMenuEvent):
- Api/qwebgraphicsitem.h:
- Api/qwebpage.cpp:
(QWebPagePrivate::contextMenuEvent):
(QWebPage::event):
- Api/qwebpage_p.h:
- 11:24 MathML edited by
- (diff)
- 11:24 MathML edited by
- (diff)
- 11:19 MathML edited by
- (diff)
- 11:18 MathML created by
- 10:58 Changeset [48261] by
-
2009-09-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez and Dan Winship.
Give all requests to libsoup, to let it queue, and schedule them
itself, instead of throttling the number of requests in WebCore.
- platform/network/ResourceRequestBase.cpp:
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::initializeMaximumHTTPConnectionCountPerHost):
- 10:39 Changeset [48260] by
-
WebCore: [V8] Make XMLHttpRequest.send handle File object.
https://bugs.webkit.org/show_bug.cgi?id=28924
Reviewed by Eric Seidel.
Test: http/tests/local/send-dragged-file.html
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
LayoutTests: [V8] Make XMLHttpRequest.send handle File object.
https://bugs.webkit.org/show_bug.cgi?id=28924
Reviewed by Eric Seidel.
Add a new layout test.
- http/tests/local/resources/file-for-drag-to-send.txt: Added.
- http/tests/local/resources/send-dragged-file.js: Added.
- http/tests/local/send-dragged-file-expected.txt: Added.
- http/tests/local/send-dragged-file.html: Added.
- 10:33 Changeset [48259] by
-
2009-09-10 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Implement fastDeleteSkippingDestructor for FastAllocBase and fastDeleteAllValues for HashSet
https://bugs.webkit.org/show_bug.cgi?id=25930
FastAllocBase has been extended with fastDeleteSkippingDestructor function which
releases memory without destructor call. fastDeleteAllValues has been implemented
similar as deleteAllValues but it uses fastDelete function to release memory.
- wtf/FastAllocBase.h: (WTF::fastDeleteSkippingDestructor):
- wtf/HashSet.h: (WTF::fastDeleteAllValues):
2009-09-10 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Use fastNew and fastDelete instead of operator new and delete for CSSSelector class.
https://bugs.webkit.org/show_bug.cgi?id=25930
Change using of operator new to fastNew and operator delete to
fastDeleteSkippingDestructor for CSSSelector class to avoid mismatched function call.
This change fixes valgrind's 'mismatched free' notification.
- css/CSSParser.cpp: (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::createFloatingSelector):
- css/CSSSelectorList.cpp: (WebCore::CSSSelectorList::adoptSelectorVector):
- 10:16 Changeset [48258] by
-
WebCore: Geolocation does not correctly handle reentrant calls from callbacks.
https://bugs.webkit.org/show_bug.cgi?id=29040
Patch by Steve Block <steveblock@google.com> on 2009-09-10
Reviewed by Darin Adler.
Tests: fast/dom/Geolocation/reentrant-error.html
fast/dom/Geolocation/reentrant-success.html
- page/Geolocation.cpp: Modified.
(WebCore::Geolocation::handleError): Modified. Call sendError directly, clearing notifier lists before making callback.
(WebCore::Geolocation::makeSuccessCallbacks): Modified. Call sendPosition directly, clearing notifier lists before making callback.
- page/Geolocation.h: Modified. Deleted sendErrorToXX and sendPositionToXXX methods.
LayoutTests: Geolocation does not correctly handle reentrant calls from callbacks.
https://bugs.webkit.org/show_bug.cgi?id=29040
Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Darin Adler.
- fast/dom/Geolocation/resources/reentrant-error.js: Added. Tests that reentrant calls from the error callback are OK.
- fast/dom/Geolocation/reentrant-error.html: Added. Wrapper for above test.
- fast/dom/Geolocation/reentrant-error-expected.txt: Added. Expected result for above test.
- fast/dom/Geolocation/resources/reentrant-success.js: Added. Tests that reentrant calls from the success callback are OK.
- fast/dom/Geolocation/reentrant-success.html: Added. Wrapper for above test.
- fast/dom/Geolocation/reentrant-success-expected.txt: Added. Expected result for above test.
- platform/gtk/Skipped: Modified. Skips above tests.
- 10:03 Changeset [48257] by
-
2009-09-10 Erik Arvidsson <arv@chromium.org>
Reviewed by Eric Seidel.
Fixes issue where focused elements did not get blur and focus events when the window was blurred and focused.
https://bugs.webkit.org/show_bug.cgi?id=27105
- fast/events/blur-focus-window-should-blur-focus-element-expected.txt: Added.
- fast/events/blur-focus-window-should-blur-focus-element.html: Added.
- fast/events/resources/blur-focus-window-should-blur-focus-element.js: Added. (divElement.onfocus.divElement.onblur.window.onfocus.window.onblur.innerDiv.onfocus.innerDiv.onblur.iframe.onfocus.iframe.onblur): (testNextEvent):
- fast/events/resources/tabindex-focus-blur-all.js: (test):
- fast/events/tabindex-focus-blur-all-expected.txt:
2009-09-10 Erik Arvidsson <arv@chromium.org>
Reviewed by Eric Seidel.
Fixes issue where focused elements did not get blur and focus events when the window was blurred and focused.
https://bugs.webkit.org/show_bug.cgi?id=27105
Test: fast/events/blur-focus-window-should-blur-focus-element.html
- page/FocusController.cpp: (WebCore::dispatchEventsOnWindowAndFocusedNode): (WebCore::FocusController::setFocused): (WebCore::FocusController::setActive):
- 09:41 Changeset [48256] by
-
2009-09-10 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Added a test case for inserting a new line character into the
request-uri.
- http/tests/xmlhttprequest/newline-in-request-uri-expected.txt: Added.
- http/tests/xmlhttprequest/newline-in-request-uri.html: Added.
- 08:56 Changeset [48255] by
-
Make the play/pause button in <video> controls indicate the button's action, not the movie state
This matches the Mac behavior, iTunes, and many other media players.
No test possible.
Fixes <http://webkit.org/b/29126> Play/pause button in <video>
controls shows the wrong image
Reviewed by Eric Carlson.
- rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::paintMediaControlsPart): Reversed when
we show the play vs. pause artwork, so that the button reflects what
will happen when you click it, rather than the current state of the
movie.
- 08:34 Changeset [48254] by
-
2009-09-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed.
qevent and qstyleoption are QtGui interfaces.
- Api/qwebgraphicsitem.cpp:
- Api/qwebgraphicsitem.h:
- 07:04 Changeset [48253] by
-
2009-09-10 Martin Robinson <martin.james.robinson@gmail.com>
[GTK] EventSender does not properly convert some keyDown strings
https://bugs.webkit.org/show_bug.cgi?id=29119
Add more keyDown string to character code conversions for GTK+ EventSender.
- DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
- 06:26 Changeset [48252] by
-
WebCore: Geolocation Coordinates::toString() prints bogus values for unspecified properties.
https://bugs.webkit.org/show_bug.cgi?id=29080
Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Maciej Stachowiak.
Test: fast/dom/Geolocation/position-string.html
- GNUmakefile.am: Modified. Removes Geoposition.cpp and Coordinates.cpp.
- WebCore.gypi: Modified. Removes Geoposition.cpp and Coordinates.cpp.
- WebCore.pro: Modified. Removes Geoposition.cpp and Coordinates.cpp.
- WebCore.vcproj/WebCore.vcproj: Modified. Removes Geoposition.cpp and Coordinates.cpp.
- WebCore.xcodeproj/project.pbxproj: Modified. Removes Geoposition.cpp and Coordinates.cpp.
- WebCoreSources.bkl: Modified. Removes Geoposition.cpp and Coordinates.cpp.
- page/Coordinates.cpp: Removed.
- page/Coordinates.h: Modified. Removes toString method.
- page/Coordinates.idl: Modified. Removes toString method.
- page/Geoposition.cpp: Removed.
- page/Geoposition.h: Modified. Removes toString method.
- page/Geoposition.idl: Modified. Removes toString method.
WebKitTools: Geolocation Coordinates::toString() prints bogus values for unspecified properties.
https://bugs.webkit.org/show_bug.cgi?id=29080
Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Maciej Stachowiak.
- Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
LayoutTests: Geolocation Coordinates::toString() prints bogus values for unspecified properties.
https://bugs.webkit.org/show_bug.cgi?id=29080
Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Maciej Stachowiak.
- fast/dom/Geolocation/resources/position-string.js: Added. Tests output of position.toString().
- fast/dom/Geolocation/position-string.html: Added. Wrapper for above test.
- fast/dom/Geolocation/position-string-expected.txt: Added. Expected result for above test.
- platform/gtk/Skipped: Modified. Skips above test.
- 05:45 Changeset [48251] by
-
2009-09-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
ARM compiler does not understand GCC visibility attribute
https://bugs.webkit.org/show_bug.cgi?id=29079
- API/JSBase.h: Make the test more specific to hit only the GCC compiler
- 04:59 Changeset [48250] by
-
2009-09-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Ariya Hidayat.
Disable some ARM compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=29083
The following ARM compiler warnings are disabled
- #68-D: integer conversion resulted in a change of sign
- #111-D: statement is unreachable
- #177-D: variable XXX was declared but never referenced
- #368-D: class XXX defines no constructor to initialize the following: YYY
- #830-D: function XXX "XXX::operator new" has no corresponding operator delete
- #1293-D: assignment in condition
- WebKit.pri:
- 04:32 Changeset [48249] by
-
WebCore: Correctly applies the Geolocation timeout property.
https://bugs.webkit.org/show_bug.cgi?id=27256
Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Adam Barth.
If a timeout is specified, the timer is started as soon as the location acquistion process starts.
If a position fix is not obtained within the timeout interval, the position request is cancelled
and the error callback (if specified) is invoked. If a position fix is obtained within the timeout
interval, the timer is stopped. Permissions are then requested from the user if required. See
http://www.w3.org/TR/geolocation-API/#position-options.
Note that this logic means that the time required to obtain permissions from the user is not
included in the timeout interval.
Tests: fast/dom/Geolocation/timeout.html
fast/dom/Geolocation/timeout-zero.html
- page/Geolocation.cpp: Modified.
(WebCore::Geolocation::GeoNotifier::GeoNotifier): Modified. Takes Geolocation object as parameter.
(WebCore::Geolocation::GeoNotifier::hasZeroTimeout): Added. Determines whether this request has a zero timeout.
(WebCore::Geolocation::GeoNotifier::startTimerIfNeeded): Renamed from startTimer. Starts the timer if a timeout was specified.
(WebCore::Geolocation::GeoNotifier::timerFired): Modified. Calls the error callback if specified, and reports the timeout to the Geolocation object.
(WebCore::Geolocation::getCurrentPosition): Modified. Calls maybeStartTimer when starting the location acquisition process.
(WebCore::Geolocation::watchPosition): Modified. Calls maybeStartTimer when starting the location acquisition process.
(WebCore::Geolocation::requestTimedOut): Added. Cancels a request when it times out.
(WebCore::Geolocation::setIsAllowed): Modified. No longer starts timers.
(WebCore::Geolocation::sendPosition): Modified. No longer stops timers.
(WebCore::Geolocation::stopTimer): Added. Stops the timers for a vector of notifiers.
(WebCore::Geolocation::stopTimersForOneShots): Added. Stops the timers for all one-shots.
(WebCore::Geolocation::stopTimersForWatchers): Added. Stops the timers for all watchers.
(WebCore::Geolocation::stopTimers): Added. Stops the timers for all requests.
(WebCore::Geolocation::geolocationServicePositionChanged): Modfified. Stops the timers for all requests.
- page/Geolocation.h: Modified.
(WebCore::Geolocation::GeoNotifier::create): Modified. Takes Geolocation object as parameter.
LayoutTests: Correctly applies the Geolocation timeout property.
https://bugs.webkit.org/show_bug.cgi?id=27256
Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Adam Barth.
- fast/dom/Geolocation/resources/timeout.js: Added. Tests that when a non-zero timeout is used, the success callback is invoked as expected.
- fast/dom/Geolocation/timeout.html: Added. Wrapper for above test.
- fast/dom/Geolocation/timeout-expected.txt: Added. Expected result for above test.
- fast/dom/Geolocation/resources/timeout-zero.js: Added. Tests that when a zero timeout is used, the error callback is invoked with code TIMEOUT.
- fast/dom/Geolocation/timeout-zero.html: Added. Wrapper for above test.
- fast/dom/Geolocation/timeout-zero-expected.txt: Added. Expected result for above test.
- platform/gtk/Skipped: Modified. Skips the above tests.
- 02:08 Changeset [48248] by
-
2009-09-10 Adam Barth <abarth@webkit.org>
Unreviewed revert of the previous change. It broke the tests.
- wtf/dtoa.cpp: (WTF::dtoa):
- 01:51 Changeset [48247] by
-
2009-09-10 Ben Laurie <benl@google.com>
Reviewed by Adam Barth.
If dtoa was given a small buffer and the number was either infinite or
NaN, then the buffer would be overflowed.
- wtf/dtoa.cpp:
