Timeline



Sep 15, 2009:

10:20 PM Changeset in webkit [48408] by cfleizach@apple.com
  • 2 edits in trunk/LayoutTests

WAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton roles
https://bugs.webkit.org/show_bug.cgi?id=28841

Layout test fix redux.
The paths to the fast/js resources needed to be updated.

  • platform/mac/accessibility/aria-slider-value-change.html:
8:39 PM Changeset in webkit [48407] by cfleizach@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

Layout test fix.
This test should only be for Mac, since the other platforms don't support the necessary features.

WAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton roles
https://bugs.webkit.org/show_bug.cgi?id=28841

  • accessibility/aria-slider-value-change-expected.txt: Removed.
  • accessibility/aria-slider-value-change.html: Removed.
  • platform/mac/accessibility/aria-slider-value-change-expected.txt: Copied from LayoutTests/accessibility/aria-slider-value-change-expected.txt.
  • platform/mac/accessibility/aria-slider-value-change.html: Copied from LayoutTests/accessibility/aria-slider-value-change.html.
6:30 PM Changeset in webkit [48406] by ggaren@apple.com
  • 4 edits in trunk/WebCore

Removed the notion of "disconnected nodes with event listeners" because
it was vestigial. The reference cycle it tried to solve was solved another
way in https://bugs.webkit.org/show_bug.cgi?id=21260.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-15
Reviewed by Sam Weinig.

  • dom/Document.cpp:

(WebCore::Document::removeAllEventListeners):

  • dom/Document.h:
  • dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::insertedIntoDocument):
(WebCore::Node::removedFromDocument):
(WebCore::Node::willMoveToNewOwnerDocument):
(WebCore::Node::didMoveToNewOwnerDocument):
(WebCore::Node::addEventListener):
(WebCore::Node::removeEventListener):
(WebCore::Node::clearAttributeEventListener):

5:40 PM Changeset in webkit [48405] by cfleizach@apple.com
  • 7 edits
    2 adds in trunk

WAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton roles
https://bugs.webkit.org/show_bug.cgi?id=28841

Reviewed by Beth Dakin.

WebCore:

Allow certain ARIA roles to change value with AXIncrement and AXDecrement.
Consolidate increment/decrement/changeValue methods.

Test: accessibility/aria-slider-value-change.html

  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::increment):
(WebCore::AccessibilityRenderObject::decrement):
(WebCore::AccessibilityRenderObject::changeValueByPercent):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySlider.cpp:
  • accessibility/AccessibilitySlider.h:
  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

LayoutTests:

  • accessibility/aria-slider-value-change-expected.txt: Added.
  • accessibility/aria-slider-value-change.html: Added.
4:52 PM Changeset in webkit [48404] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-09-15 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Steve Falkenburg.

Add four currently failing tests to the Skipped list so we can figure out what's wrong
with them and try to get the bot closer to green. Bugs have been filed for each test.

  • platform/win/Skipped:
4:17 PM Changeset in webkit [48403] by oliver@apple.com
  • 8 edits in trunk/JavaScriptCore

Allow anonymous storage inside JSObject
https://bugs.webkit.org/show_bug.cgi?id=29168

Reviewed by Geoff Garen

Add the concept of anonymous slots to Structures so that it is
possible to store references to values that need marking in the
standard JSObject storage buffer. This allows us to reduce the
malloc overhead of some objects (by allowing them to store JS
values in the inline storage of the object) and reduce the
dependence of custom mark functions (if all an objects children
are in the standard object property storage there's no need to
mark them manually).

2:47 PM Changeset in webkit [48402] by ggaren@apple.com
  • 33 edits in trunk/WebCore

Removed the jsEventListeners set from JSDOMGlobalObject, to simplify
creation and destruction of JSDOMGlobalObject and event listeners.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-15
Reviewed by Sam Weinig.

Added an abstract operator==() to EventListener, to replace the
jsEventListeners set's role in determining if two event listeners are
equal from the DOM's perspective.

Added a type field to EventListener, and casting operations, to support
operator==() and other abstract operations.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAbstractWorkerCustom.cpp:

(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):

  • bindings/js/JSDOMApplicationCacheCustom.cpp:

(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):

  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

  • bindings/js/JSDesktopNotificationsCustom.cpp:

(WebCore::JSNotification::addEventListener):
(WebCore::):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):
(WebCore::JSEventListener::markJSFunction):
(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):
(WebCore::JSEventListener::operator==):

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::cast):

  • bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):

  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:

(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):

  • bindings/objc/ObjCEventListener.h:

(WebCore::ObjCEventListener::cast):

  • bindings/objc/ObjCEventListener.mm:

(WebCore::ObjCEventListener::ObjCEventListener):
(WebCore::ObjCEventListener::operator==):

  • dom/EventListener.h:

(WebCore::EventListener::):
(WebCore::EventListener::type):
(WebCore::EventListener::EventListener):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::addEventListener):
(WebCore::MessagePort::removeEventListener):

  • dom/Node.cpp:

(WebCore::Node::removeEventListener):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::mainFrameDocument):
(WebCore::InspectorDOMAgent::operator==):

  • inspector/InspectorDOMAgent.h:

(WebCore::InspectorDOMAgent::cast):

  • loader/ImageDocument.cpp:

(WebCore::ImageEventListener::cast):
(WebCore::ImageEventListener::ImageEventListener):
(WebCore::ImageEventListener::operator==):

  • loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::addEventListener):
(WebCore::DOMApplicationCache::removeEventListener):

  • notifications/Notification.cpp:

(WebCore::Notification::removeEventListener):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::removeEventListener):

  • page/EventSource.cpp:

(WebCore::EventSource::addEventListener):
(WebCore::EventSource::removeEventListener):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::ConditionEventListener::cast):
(WebCore::ConditionEventListener::ConditionEventListener):
(WebCore::ConditionEventListener::operator==):
(WebCore::ConditionEventListener::handleEvent):

  • workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::addEventListener):
(WebCore::AbstractWorker::removeEventListener):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::addEventListener):
(WebCore::WorkerContext::removeEventListener):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::addEventListener):
(WebCore::XMLHttpRequest::removeEventListener):

  • xml/XMLHttpRequestUpload.cpp:

(WebCore::XMLHttpRequestUpload::addEventListener):
(WebCore::XMLHttpRequestUpload::removeEventListener):

2:26 PM Changeset in webkit [48401] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-09-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Fixed position elements flash when CSS transforms are applied on page > 2048px tall
https://bugs.webkit.org/show_bug.cgi?id=27272

Update the previous workaround for misplaced compositing layers, which used a 4096px
threshold, to 2048px since that's the GPU max texture size on some older hardware.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateLayerHostingViewPosition]):
1:46 PM WebKit Team edited by vestbo@webkit.org
(diff)
1:33 PM Changeset in webkit [48400] by vestbo@webkit.org
  • 8 edits in trunk

Added ENABLE_MATHML feature define and build-webkit toggle

Patch by Alex Milowski <alex@milowski.com> on 2009-09-15
Reviewed by Tor Arne Vestbø.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKitTools:

  • Scripts/build-webkit:
1:25 PM CommitQueue edited by eric@webkit.org
(diff)
12:25 PM Changeset in webkit [48399] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix. Allow waf build to support Python < 2.6.

11:40 AM Changeset in webkit [48398] by mrowe@apple.com
  • 7 edits in trunk

WebCore: Document.elementFromPoint() and Document.caretRangeFromPoint() erroneously returning null at points visible only after scrolling.
https://bugs.webkit.org/show_bug.cgi?id=29245

Patch by Andrew Richards <randrew@gmail.com> on 2009-09-14
Reviewed by Sam Weinig.

Use visibleContentRect() instead of boundsRect() when checking hit point bounds on viewport.

  • dom/Document.cpp:

(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):

LayoutTests: Document.elementFromPoint() and Document.caretRangeFromPoint() returning null at points visible only after scrolling.
https://bugs.webkit.org/show_bug.cgi?id=29245

Patch by Andrew Richards <randrew@gmail.com> on 2009-09-14
Reviewed by Sam Weinig.

Extend tests to include hits in areas that are not in the initial containing block of the page.

  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
  • fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
  • fast/dom/elementFromPoint-relative-to-viewport.html:
11:36 AM Changeset in webkit [48397] by jshin@chromium.org
  • 3 edits
    9 adds in trunk

2009-09-15 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel

http://bugs.webkit.org/show_bug.cgi?id=26660

Chromium Windows: When rotated, the baseline for a span of complex
script is completely misaligned with that of the adjacent
simple script text. It's fixed by not applying the baseline offset for
the Skia code path.

Test: transforms/2d/hindi-rotated.html

  • platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::draw):

2009-09-15 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel

http://bugs.webkit.org/show_bug.cgi?id=26660

Chromium Windows: When rotated, the baseline for a span of complex
script is completely misaligned with that of the adjacent simple
script text.

  • transforms/2d/hindi-rotated.html: Added.
  • platform/mac/transforms/2d/hindi-rotated-expected.checksum: Added.
  • platform/mac/transforms/2d/hindi-rotated-expected.png: Added.
  • platform/mac/transforms/2d/hindi-rotated-expected.txt: Added.
  • platform/win/transforms: Added.
  • platform/win/transforms/2d: Added.
  • platform/win/transforms/2d/hindi-rotated-expected.checksum: Added.
  • platform/win/transforms/2d/hindi-rotated-expected.png: Added.
  • platform/win/transforms/2d/hindi-rotated-expected.txt: Added.
11:30 AM Changeset in webkit [48396] by andersca@apple.com
  • 2 edits in trunk/WebCore

Pass the PopupMenu pointer to CreateWindowEx and then get it from the LPCREATESTRUCT in
the WM_CREATE handler. This way we don't have to first create an zero size window and then size it.

Reviewed by Adam Roben.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::show):
(WebCore::PopupMenu::PopupMenuWndProc):

11:27 AM Changeset in webkit [48395] by atwilson@chromium.org
  • 5 edits in trunk

MessageEvent should not be cancelable by default
https://bugs.webkit.org/show_bug.cgi?id=27846

Reviewed by Darin Adler.

WebCore:

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):
Changed constructor to set cancelable=false by default, per the HTML5 spec.

LayoutTests:

  • fast/events/message-port-expected.txt:
  • fast/events/message-port.html:

Added test case to check state of MessageEvent.cancelable attribute.

11:20 AM Changeset in webkit [48394] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/7224378> REGRESSION(r48360): Dragging a tab with a plug-in out of a window, the plug-in gets slow and confused

Reviewed by Anders Carlsson.

In r48360, the fix for <rdar://problem/7090444>, I neglected to consider the case where the plug-in had already been started and
-start would do an early-return rather than calling -restartTimers and -addWindowObservers itself.

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView viewDidMoveToWindow]): Reinstate the call to -restartTimers and -addWindowObservers, but guard them
with a check that the view is still in the window.

10:52 AM Changeset in webkit [48393] by eric@webkit.org
  • 5 edits in trunk

2009-09-15 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Add a new test case for SVG Path parsing with a default command and starts with dot '.'
https://bugs.webkit.org/show_bug.cgi?id=29123

  • svg/dom/path-parser-expected.txt:
  • svg/dom/resources/path-parser.js:

2009-09-15 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Fix SVG path parsing error if a command starts with dot '.'
https://bugs.webkit.org/show_bug.cgi?id=29123

  • svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG):
6:14 AM Changeset in webkit [48392] by rik@webkit.org
  • 10 edits
    1 add in trunk/WebCore

Implement conditional breakpoints in the Web Inspector frontend.
https://bugs.webkit.org/show_bug.cgi?id=28908

Patch by Alexander Pavlov <apavlov@chromium.org> on 2009-09-15
Reviewed by Timothy Hatcher.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/Breakpoint.js:

(WebInspector.Breakpoint.prototype.set condition):

  • inspector/front-end/Popup.js: Added.

(WebInspector.Popup):
(WebInspector.Popup.prototype.show):
(WebInspector.Popup.prototype.hide):
(WebInspector.Popup.prototype.get visible):
(WebInspector.Popup.prototype.set element):
(WebInspector.Popup.prototype.get element):
(WebInspector.Popup.prototype.positionElement):
(WebInspector.Popup.prototype.set anchor):
(WebInspector.Popup.prototype.get anchor):
(WebInspector.Popup.prototype.set autoHide):
(WebInspector.Popup.prototype._checkNotVisible):
(WebInspector.Popup.prototype._keyEventHandler):
(WebInspector.Popup.prototype._mouseDownEventHandler):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype._loaded):
(WebInspector.SourceFrame.prototype._documentContextMenu):
(WebInspector.SourceFrame.prototype._documentMouseDown):
(WebInspector.SourceFrame.prototype._editBreakpointCondition.committed):
(WebInspector.SourceFrame.prototype._editBreakpointCondition.dismissed):
(WebInspector.SourceFrame.prototype._editBreakpointCondition):
(WebInspector.SourceFrame.prototype._showBreakpointConditionPopup):
(WebInspector.SourceFrame.prototype._createPopupElement):
(WebInspector.SourceFrame.prototype._addBreakpointToSource):
(WebInspector.SourceFrame.prototype._removeBreakpointFromSource):
(WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded.drawBreakpoint):
(WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.set currentFocusElement):
(WebInspector.set currentPanel):
(WebInspector.loaded):
(WebInspector.contextMenu):
(WebInspector.elementDragStart):
(WebInspector.updateResource):
(WebInspector.drawLoadingPieChart):
(WebInspector.linkifyURLAsNode):
(WebInspector.startEditing.getContent):
(WebInspector.startEditing.editingCancelled):
(WebInspector.startEditing.editingCommitted):

  • inspector/front-end/utilities.js:

(Element.prototype.positionAt):
(Element.prototype.offsetRelativeToWindow):

6:03 AM Changeset in webkit [48391] by vestbo@webkit.org
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix for windows.

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-15
Reviewed by Tor Arne Vestbø.

After http://trac.webkit.org/changeset/47795 the MinGW build broke,
because MinGW has mingw_aligned_malloc instead of _aligned_malloc.

  • runtime/Collector.cpp:

(JSC::Heap::allocateBlock): MinGW case added.
(JSC::Heap::freeBlock): MinGW case added.

5:51 AM Changeset in webkit [48390] by vestbo@webkit.org
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix for Windows/MinGW

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-15
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=29268

  • wtf/Platform.h: JSVALUE32_64 temporarily disabled on PLATFORM(WIN_OS) with COMPILER(MINGW)
4:29 AM Changeset in webkit [48389] by zoltan@webkit.org
  • 3 edits
    1 add in trunk/JavaScriptCore

2009-09-14 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Detect VFP at runtime in generic ARM port on Linux platform.
https://bugs.webkit.org/show_bug.cgi?id=29076

  • JavaScriptCore.pri:
  • assembler/MacroAssemblerARM.cpp: Added. (JSC::isVFPPresent):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::supportsFloatingPoint):

Sep 14, 2009:

9:25 PM Changeset in webkit [48388] by beidson@apple.com
  • 5 edits in trunk

Page cache should support pages with unload handlers as an experiment.
<rdar://problem/7196485> and https://bugs.webkit.org/show_bug.cgi?id=29021

Reviewed by Darin Adler.

WebCore:

For the experiment, only allow pages with unload handlers into the Page Cache on
Mac and Windows.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):

LayoutTests:

Disable fast/loader/frames-with-unload-handlers-in-page-cache.html as it doesn't
make sense in the context of this experiment.

  • platform/mac/Skipped:
  • platform/win/Skipped:
8:22 PM Changeset in webkit [48387] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

8:21 PM Changeset in webkit [48386] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.18

New tag.

8:07 PM Changeset in webkit [48385] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-4-branch

Merge r48368.

8:05 PM Changeset in webkit [48384] by mrowe@apple.com
  • 10 edits in branches/safari-4-branch/WebCore

Merge r48367.

7:11 PM Changeset in webkit [48383] by kov@webkit.org
  • 5 edits in trunk

Undoing mess: committing test code

7:11 PM Changeset in webkit [48382] by kov@webkit.org
  • 8 edits in trunk/WebKit/gtk

2009-09-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez and Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=29134
[GTK] Add API to access sub resources

Implement getting subresources, and improve testing of
main, and sub resources loading.

7:08 PM Changeset in webkit [48381] by kov@webkit.org
  • 5 edits in trunk

Java

6:28 PM Changeset in webkit [48380] by cmarrin@apple.com
  • 4 edits
    3 adds in trunk

Add LayoutTests infrastructure to enable and disable webgl tests.
Also added a webgl test.
https://bugs.webkit.org/show_bug.cgi?id=29254

6:07 PM Changeset in webkit [48379] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-09-14 Simon Fraser <simon.fraser@apple.com>

Fix the change in r48376 to do a null-check to fix a crashing test.

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
5:54 PM Changeset in webkit [48378] by simon.fraser@apple.com
  • 2 edits in trunk/WebKitTools

2009-09-14 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Add --iterations option to run-webkit-tests to repeat the tests N times
https://bugs.webkit.org/show_bug.cgi?id=29263

When run with --iterations N, run-webkit-tests will repeat the tests N times.

  • Scripts/run-webkit-tests:
5:28 PM Changeset in webkit [48377] by beidson@apple.com
  • 2 edits in trunk/LayoutTests
5:19 PM Changeset in webkit [48376] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2009-09-14 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7047282> Safari crashes at WebCore::RenderMenuList::adjustInnerStyle() + 436

Avoid a crash when a mouse event handler on a <select> changes the select from a popup
to a list (by setting the 'size' property) inside the event handler.

Test: fast/forms/select-change-popup-to-listbox-in-event-handler.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
4:52 PM Changeset in webkit [48375] by andersca@apple.com
  • 3 edits in trunk/WebCore

More PopupMenu cleanup.

Reviewed by Jon Honeycutt.

  • platform/PopupMenu.h:
  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::show):
Call registerClass.

(WebCore::PopupMenu::registerClass):
Make this a private static member function so it can refer to PopupMenuWndProc.

(WebCore::PopupMenu::PopupMenuWndProc):
Try to get the PopupMenu and call its wndProc member function.

(WebCore::PopupMenu::wndProc):
Make this a member function.

4:08 PM Changeset in webkit [48374] by beidson@apple.com
  • 4 edits in trunk

Fix more fallout I wrought on myself by not testing the final authentication patch on Windows.

3:46 PM Changeset in webkit [48373] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKitTools

GTK build fix.

Unreviewed.

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::setLogScrollingStartEvents):

3:45 PM Changeset in webkit [48372] by andersca@apple.com
  • 2 edits in trunk/WebCore

Speculative Qt build fix.

  • platform/qt/QWebPopup.cpp:

(WebCore::QWebPopup::hidePopup):

3:38 PM Changeset in webkit [48371] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Fisher.

Fix RenderThemeChromiumWin::determineClassicState so that classic_state
matches the state values (and you get a single classic_state value
for a given {part,state} value. This change will be tested by a
chromium patch that will land after this.

This will be tested by code landing downstream on Chromium.org; the
code does not execute on webkit.org.

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineClassicState): (WebCore::RenderThemeChromiumWin::getThemeData):
3:14 PM Changeset in webkit [48370] by andersca@apple.com
  • 11 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=29138
Simplify popup menu handling.

Reviewed by Adam Roben.

  • platform/PopupMenuClient.h:

Rename hidePopup to popupDidHide.

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::acceptIndex):
Call popupDidHide instead of hidePopup.

  • platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenu::menuUnmapped):
Ditto.

  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenu::show):
Ditto.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::hide):
Call popupDidHide.

(WebCore::PopupWndProc):
Call PopupMenu::hide.

  • platform/wx/PopupMenuWx.cpp:

(WebCore::PopupMenu::OnMenuItemSelected):
Call popupDidHide.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::hidePopup):
(WebCore::RenderMenuList::popupDidHide):

  • rendering/RenderMenuList.h:

Set the "popup is visible" flag in popupDidHide.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::popupDidHide):

  • rendering/RenderTextControlSingleLine.h:

Ditto.

2:27 PM Changeset in webkit [48369] by andersca@apple.com
  • 2 edits in trunk/WebCore
  • Fix <rdar://problem/7182275>.

Reviewed by David Hyatt.

Make sure that the newly created scrollbar's style is up to date.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::~PopupMenu):
Call setParent so that the scrollbar's parts are torn down correctly.

(WebCore::PopupMenu::show):
Call styleChanged.

2:25 PM Changeset in webkit [48368] by jhoneycutt@apple.com
  • 6 edits
    2 adds in trunk

DRT/test part of
<rdar://problem/7197644> WebKit should broadcast an MSAA event when
jumping to a named anchor

https://bugs.webkit.org/show_bug.cgi?id=28899

Reviewed by Adam Roben.

WebKitTools:

  • DumpRenderTree/AccessibilityController.cpp:

(logScrollingStartEventsCallback):
Turn on logging of scrolling start events.
(AccessibilityController::getJSClass):
Add a "logScrollingStartEvents" to the AccessibilityController's JS
class definition.
(AccessibilityController::resetToConsistentState):
Turn off logging of scrolling start events.

  • DumpRenderTree/AccessibilityController.h:

Declare setLogScrollingStartEvents(). Add a member for the scrolling
start event hook.

  • DumpRenderTree/mac/AccessibilityControllerMac.cpp:

(AccessibilityController::setLogScrollingStartEvents):
Stubbed.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
Initialize the handle to 0.
(logEventProc):
Renamed from logFocusEventProc; now logs scrolling start events, too.
Removed the assertion that the event is a focus event. Added a switch
to print a message for focus, scrolling start, and other, unknown
events.
(AccessibilityController::setLogFocusEvents):
Changed to use logEventProc.
(AccessibilityController::setLogScrollingStartEvents):
If turning logging off, unhook the scrolling start event hook, and clear
the member holding the handle. If turning on, query for the root
accessible, so that accessibility is enabled for the WebView, and call
SetWinEventHook to setup an event hook using logEventProc as the
callback function.

LayoutTests:

  • platform/win/accessibility/scroll-to-anchor-expected.txt: Added.
  • platform/win/accessibility/scroll-to-anchor.html:

Added. Turns on scrolling start event logging, then jumps to an
anchor at the bottom of the page.

2:25 PM Changeset in webkit [48367] by jhoneycutt@apple.com
  • 10 edits in trunk/WebCore

<rdar://problem/7197644> WebKit should broadcast an MSAA event when
jumping to a named anchor

https://bugs.webkit.org/show_bug.cgi?id=28899

Reviewed by Adam Roben.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::):
Added declaration for handleScrolledToAnchor(). Added a new entry to
the enum of accessibility notifications.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::firstAccessibleObjectFromNode):
Code moved from AccessibilityRenderObject::internalLinkElement() and
refactored slightly; walks the tree until it finds a Node (with a
renderer) whose accessibility is not ignored.

  • accessibility/AccessibilityObject.h:

Added a declaration for firstAccessibleObjectFromNode().

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::internalLinkElement):
Code moved to AccessibilityObject::firstAccessibleObjectFromNode().

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):
Add a default case that returns early for notifications that Mac
doesn't handle.
(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::handleScrolledToAnchor):
Post an AXScrolledToAnchor notification for the first accessible from
the anchor Node.
(WebCore::AXObjectCache::postPlatformNotification):
If the notification is AXFocusedUIElementChanged, fire an
EVENT_OBJECT_FOCUS. If the notification is AXScrolledToAnchor, fire
EVENT_SYSTEM_SCROLLINGSTART, matching Firefox.
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
Code moved to postPlatformNotification().

  • page/FrameView.cpp:

(WebCore::FrameView::scrollToAnchor):
Call AXObjectCache::handleScrolledToAnchor().

2:09 PM Changeset in webkit [48366] by rik@webkit.org
  • 2 edits in trunk/WebCore

Cookies are not inspectable after reloading a page
https://bugs.webkit.org/show_bug.cgi?id=29222

Patch by Anthony Ricaud <rik@webkit.org> on 2009-09-14
Reviewed by Timothy Hatcher.

Create the cookieTreeElement on initialization instead of when the view is shown.
Reset the selected element of the sidebar on reset.

  • inspector/front-end/StoragePanel.js:

(WebInspector.StoragePanel):
(WebInspector.StoragePanel.prototype.show):
(WebInspector.StoragePanel.prototype.reset):

2:07 PM CommitQueue edited by eric@webkit.org
(diff)
1:32 PM Changeset in webkit [48365] by beidson@apple.com
  • 3 edits in trunk/WebKitTools

Windows DRT build fix.

1:12 PM Changeset in webkit [48364] by beidson@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
(WebCore::WebCoreSynchronousLoader::load):

1:05 PM Changeset in webkit [48363] by beidson@apple.com
  • 32 edits
    16 adds in trunk

Safari 4 cannot be used to update firmware on Linksys routers.
<rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160

Reviewed by Alexey Proskuryakov.

WebCore:

In http://trac.webkit.org/changeset/42483, we disabled CFNetwork's session credential storage and
implemented our own in WebCore.

One feature we lost is that CFNetwork would automatically send previously authenticated credentials
with new connections when the paths match, as allowed by RFC 2617 for HTTP Basic and Digest Authentication.

Even though it's optional for User Agents to do this, (some?) Linksys routers rely on this behavior for
HTTP Basic Authentication. So now WebCore's CredentialStorage will track URL paths for Basic credentials.

We're not making this enhancement for Digest at this time, since we don't know of anything that broke
due to the change in Digest behavior.

Test: http/tests/loading/basic-credentials-sent-automatically.html

http/tests/loading/basic-auth-resend-wrong-credentials.html

  • WebCore.base.exp:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/Credential.cpp:

(WebCore::Credential::isEmpty):

  • platform/network/Credential.h:

Add a slightly more full featured CredentialStore that will track URL paths a credential belongs to:

  • platform/network/CredentialStorage.cpp: Added.

(WebCore::protectionSpaceToCredentialMap):
(WebCore::originToDefaultCredentialMap):
(WebCore::originStringFromURL):
(WebCore::CredentialStorage::set):
(WebCore::CredentialStorage::get):
(WebCore::CredentialStorage::getDefaultAuthenticationCredential):

  • platform/network/CredentialStorage.h: Added.

Allow ProtectionSpace to be a hash key:

  • platform/network/ProtectionSpace.cpp:

(WebCore::ProtectionSpace::ProtectionSpace):

  • platform/network/ProtectionSpace.h:

(WebCore::ProtectionSpace::ProtectionSpace):
(WebCore::ProtectionSpace::isHashTableDeletedValue):

  • platform/network/ProtectionSpaceHash.h: Added.

(WebCore::ProtectionSpaceHash::hash):
(WebCore::ProtectionSpaceHash::equal):

Allow ResourceHandles to remember the initial credential they used:

  • platform/network/ResourceHandleInternal.h:

Allow mutable ResourceRequests to update their platform object if HTTP header fields change:

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::addHTTPHeaderField):

Remove WebCoreCredentialStorage:

  • platform/network/cf/AuthenticationCF.cpp:
  • platform/network/cf/AuthenticationCF.h:
  • platform/network/mac/AuthenticationMac.h:
  • platform/network/mac/AuthenticationMac.mm:

Change ResourceHandleCFNet to try to use stored credentials on new connections, if appropriate:

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Only try the ProtectionSpace key'ed

Credential if it does not match the initially used Credential.

(WebCore::ResourceHandle::receivedCredential):
(WebCore::WebCoreSynchronousLoader::didReceiveChallenge): Only try the ProtectionSpace key'ed

Credential if it does not match the initially used Credential.

(WebCore::WebCoreSynchronousLoader::load):

Change ResourceHandleMac to try to use stored credentials on new connections, if appropriate:

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Only try the ProtectionSpace key'ed

Credential if it does not match the initially used Credential.

(WebCore::ResourceHandle::receivedCredential):
(-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Only try the

ProtectionSpace key'ed Credential if it does not match the initially used Credential.

(+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):

Add base64-ability to CString:

  • platform/text/CString.cpp:

(WebCore::CStringBuffer::base64Encode):
(WebCore::CString::base64Encode):

  • platform/text/CString.h:

(WebCore::CStringBuffer::create):
(WebCore::CStringBuffer::CStringBuffer):

WebKit/mac:

Adopt the new WebCore::CredentialStorage in WebKit/Mac.

  • Misc/WebDownload.mm:

(-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):

  • Plugins/WebBaseNetscapePluginView.mm:

(WebKit::getAuthenticationInfo):

WebKit/win:

Adopt the new WebCore::CredentialStorage in WebKit/Win.

  • WebDownloadCFNet.cpp:

(WebDownload::didReceiveAuthenticationChallenge):

WebKitTools:

Add the ability for DRT to handle authentication challenges.

  • DumpRenderTree/LayoutTestController.cpp:

(setAuthenticationPasswordCallback):
(setAuthenticationUsernameCallback):
(setHandlesAuthenticationChallengesCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::handlesAuthenticationChallenges):
(LayoutTestController::setHandlesAuthenticationChallenges):
(LayoutTestController::authenticationUsername):
(LayoutTestController::setAuthenticationUsername):
(LayoutTestController::authenticationPassword):
(LayoutTestController::setAuthenticationPassword):

  • DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):

  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::didReceiveAuthenticationChallenge):

  • DumpRenderTree/win/ResourceLoadDelegate.h:

LayoutTests:

  • http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Added.
  • http/tests/loading/basic-auth-resend-wrong-credentials.html: Added.
  • http/tests/loading/basic-credentials-sent-automatically-expected.txt: Added.
  • http/tests/loading/basic-credentials-sent-automatically.html: Added.
  • http/tests/loading/resources/basic-auth-testing.php: Added.
  • http/tests/loading/resources/othersubresources: Added.
  • http/tests/loading/resources/othersubresources/protected-resource.php: Added.
  • http/tests/loading/resources/protected-resource.php: Added.
  • http/tests/loading/resources/subresources: Added.
  • http/tests/loading/resources/subresources/protected-resource.php: Added.
  • http/tests/loading/resources/test2: Added.
  • http/tests/loading/resources/test2/basic-auth-testing.php: Added.
  • http/tests/loading/resources/test2/protected-resource.php: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
12:01 PM Changeset in webkit [48362] by kov@webkit.org
  • 4 edits in trunk/LayoutTests

2009-09-14 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

Add some tests that fail to the skipped list and rebaseline two tests
to pass them.

  • platform/gtk/Skipped: Populate with more failing tests.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt: Rebaseline.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Ditto.
11:10 AM Changeset in webkit [48361] by mrowe@apple.com
  • 3 edits
    2 adds in trunk

Test for <rdar://problem/6954546> and <rdar://problem/7090444>.

Reviewed by Dan Bernstein.

WebKitTools:

Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:

(NPP_New):

LayoutTests:

  • plugins/destroy-during-npp-new-expected.txt: Added.
  • plugins/destroy-during-npp-new.html: Added.
11:10 AM Changeset in webkit [48360] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix <rdar://problem/7090444> Crashes in-[WebBaseNetscapePluginView stop] handling NSWindowWillCloseNotification.

Reviewed by Anders Carlsson.

It's not valid to call -addWindowObservers when the view is not in a window, but this can happen when -start
initializes a plug-in and the plug-in removes itself from the document during initialization. -viewDidMoveToWindow
calls -start and then calls -addWindowObservers without ensuring that the view is still in a window.

If -[WebBaseNetscapePluginView addWindowObservers] is incorrectly called when the view is not in a window, it will
observe NSWindowWillCloseNotification on all windows. This unexpected observer registration is not balanced by an
unregistration so the notification can be delivered after the view is deallocated, causing the crash seen in
<rdar://problem/7090444>.

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView start]): Only call -updateAndSetWindow if we still have a current window.
(-[WebBaseNetscapePluginView viewDidMoveToWindow]): Remove unnecessary calls to -restartTimers and -addWindowObservers
from -[WebBaseNetscapePluginView viewDidMoveToWindow]. They are already called from within -start with the extra benefit
of ensuring that the view is still in a window when they are called.

11:10 AM Changeset in webkit [48359] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix <rdar://problem/6954546> Crashes in WebCore::RenderPart::setWidget below FrameLoader::loadPlugin.

Reviewed by Dan Bernstein.

The calls to FrameLoader::requestObject within RenderPartObject::updateWidget can result in a plug-in
being initialized. This can run cause arbitrary JavaScript to run and may result in the RenderPartObject
being detached from the render tree and destroyed, causing a crash like <rdar://problem/6954546>.

No test is possible until <rdar://problem/7090444> is fixed

  • rendering/RenderPartObject.cpp:

(WebCore::RenderPartObject::updateWidget): Ensure that we stay alive for the duration of plug-in initialization.

11:10 AM Changeset in webkit [48358] by mrowe@apple.com
  • 3 edits
    1 add in trunk/WebCore

Add RenderWidgetProtector to simplify protecting a RenderWidget from destruction for the duration of a function. Deploy it within RenderWidget.

Reviewed by Dan Bernstein.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::updateWidgetPosition): Use a RefPtr rather than explicitly
ref'ing and deref'ing the node.

  • rendering/RenderWidget.h:
  • rendering/RenderWidgetProtector.h:

(WebCore::RenderWidgetProtector::RenderWidgetProtector):
(WebCore::RenderWidgetProtector::~RenderWidgetProtector):

10:26 AM Changeset in webkit [48357] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-09-14 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] QWebGraphicsItem should check for null QWebPage.
https://bugs.webkit.org/show_bug.cgi?id=29185

Don't crash in QWebGraphicsItem when the page is still null, by
either checking if it's the case or constructing the default one.

  • Api/qwebgraphicsitem.cpp: (QWebGraphicsItem::icon): (QWebGraphicsItem::setZoomFactor): (QWebGraphicsItem::zoomFactor): (QWebGraphicsItem::setGeometry): (QWebGraphicsItem::load): (QWebGraphicsItem::setHtml): (QWebGraphicsItem::toHtml): (QWebGraphicsItem::setContent): (QWebGraphicsItem::history): (QWebGraphicsItem::settings):
10:19 AM Changeset in webkit [48356] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-14 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

CodeGenerator.pm needs some cleaning up
https://bugs.webkit.org/show_bug.cgi?id=29238

  • bindings/scripts/CodeGenerator.pm: (FindParentsRecursively): Removed; its functionality is now handled in AddMethodsConstantsAndAttributesFromParentClasses. (ForAllParents): New function that visits an interface's ancestors and invokes a callback for each one. (AddMethodsConstantsAndAttributesFromParentClasses): Simplified by using ForAllParents. (GetMethodsAndAttributesFromParentClasses): Ditto. (IDLFileForInterface): Factored out previous calls to ScanDirectory into this new function, which returns the filename containing a given IDL interface definition. (ParseInterface): Simplified by using IDLFileForInterface. (ScanDirectory): Removed in lieu of IDLFileForInterface.
  • bindings/scripts/CodeGeneratorV8.pm: Drop call to FindParentsRecursively and get the list of parents from the AddMethodsConstantsAndAttributesFromParentClasses call instead.
10:06 AM Changeset in webkit [48355] by kevino@webkit.org
  • 3 edits in trunk/WebKitTools

wx build fix for non-wxPython builds and a fix for errors when updating swig.py.

7:46 AM Changeset in webkit [48354] by yael.aharon@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Assert hit when dropping a file in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=29242

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-14
Reviewed by Tor Arne Vestbø.

Qt's implementation of DropData::asURL does not return a URL encoded string
as expected.

  • platform/qt/DragDataQt.cpp:
5:45 AM Changeset in webkit [48353] by vestbo@webkit.org
  • 5 edits in trunk

[Qt] Build fix for windows build.

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-14
Reviewed by Tor Arne Vestbø.

JavaScriptCore

  • JavaScriptCore.pri: Correct a logic error.
  • pcre/dftables: Add missing paranthesis for tmpdir function.

WebKitTools:

  • Scripts/bisect-builds: Add missing paranthesis for tmpdir function.

Sep 13, 2009:

10:47 PM Changeset in webkit [48352] by kevino@webkit.org
  • 1 edit
    1 add in trunk/WebCore

wx build fix, file was missed during TLS.cpp removal.

7:29 PM Changeset in webkit [48351] by rik@webkit.org
  • 2 edits in trunk/WebCore

Web Inspector: Add "New Style Rule" to the localizedStrings
https://bugs.webkit.org/show_bug.cgi?id=29237

Patch by Anthony Ricaud <rik@webkit.org> on 2009-09-13
Reviewed by Oliver Hunt.

  • English.lproj/localizedStrings.js:
7:03 PM Changeset in webkit [48350] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

Fix typo accidently landed in last commit.

6:52 PM Changeset in webkit [48349] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix, error out if using the wrong Python.

6:32 PM Changeset in webkit [48348] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Allow a way to set the cache policy via wx API.

https://bugs.webkit.org/show_bug.cgi?id=29200

6:20 PM Changeset in webkit [48347] by kevino@webkit.org
  • 5 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Allow the user to query Frame::shouldClose via wx API.

https://bugs.webkit.org/show_bug.cgi?id=29199

6:12 PM Changeset in webkit [48346] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Fix mouse handling when the mouse leaves the window during mouse down.

https://bugs.webkit.org/show_bug.cgi?id=29198

6:04 PM Changeset in webkit [48345] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Add support for console MessageLevel at wx API level.

https://bugs.webkit.org/show_bug.cgi?id=29197

5:34 PM Changeset in webkit [48344] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx] Implement filesystem functions.

https://bugs.webkit.org/show_bug.cgi?id=29196

3:45 AM Changeset in webkit [48343] by xan@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-13 Xan Lopez <xlopez@igalia.com>

Build fix for GTK+ < 2.14.

Do not use gtk_widget_get_window, access the window directly
through the struct.

  • DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (keyDownCallback):
3:23 AM Changeset in webkit [48342] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-13 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez and Jan Alonzo.

[GTK] EventSender does not set 'window' property on synthesized GDK events
https://bugs.webkit.org/show_bug.cgi?id=29169

Set the window property on synthesized GDK events in the GTK+ EventSender.

  • DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (keyDownCallback):
12:14 AM Changeset in webkit [48341] by kevino@webkit.org
  • 3 edits in trunk/WebCore

wx build fixes for wx 2.9.

Sep 12, 2009:

8:24 PM Changeset in webkit [48340] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix for windows exports (again).

8:10 PM Changeset in webkit [48339] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix for windows exports

8:03 PM Changeset in webkit [48338] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Correct fix for non-allinonefile builds

8:00 PM Changeset in webkit [48337] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix non-allinonefile builds

7:44 PM Changeset in webkit [48336] by oliver@apple.com
  • 41 edits
    3 adds in trunk

[ES5] Implement Object.keys
https://bugs.webkit.org/show_bug.cgi?id=29170

Reviewed by Maciej Stachowiak.

This patch basically requires two separate steps, the first is to split getPropertyNames
into two functions -- getOwnPropertyNames and getPropertyNames, basically making them behave
in the same way as getOwnPropertySlot and getPropertySlot. In essence getOwnPropertyNames
produces the list of properties on an object excluding its prototype chain and getPropertyNames
just iterates the the object and its prototype chain calling getOwnPropertyNames at each level.

6:17 PM Changeset in webkit [48335] by atwilson@chromium.org
  • 2 edits in trunk/WebKitTools

run-webkit-tests has a timeout value that is too low
https://bugs.webkit.org/show_bug.cgi?id=29223

Reviewed by Mark Rowe.

  • Scripts/run-webkit-tests:

Changed timeout value to 20 seconds to avoid timing out too early.

12:11 PM Changeset in webkit [48334] by weinig@apple.com
  • 6 edits
    2 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29219
Document.elementFromPoint() should take page scroll into consideration

Reviewed by Anders Carlsson.

Test: fast/dom/elementFromPoint-relative-to-viewport.html

  • dom/Document.cpp:

(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29219
Document.elementFromPoint() should take page scroll into consideration

Reviewed by Anders Carlsson.

  • fast/dom/elementFromPoint-relative-to-viewport-expected.txt: Added.
  • fast/dom/elementFromPoint-relative-to-viewport.html: Added.
  • fast/events/offsetX-offsetY.html: Change to use clientX/Y instead of pageX/Y.
  • fast/forms/slider-transformed.html: Ditto.
  • fast/forms/slider-zoomed.html: Ditto.
1:14 AM Changeset in webkit [48333] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29217
Document.caretRangeFromPoint should take the scroll offset into account before hit testing

Reviewed by Maciej Stachowiak.

In accordance with the CSSOM View Module spec, Document.caretRangeFromPoint should interpret
the point passed to it as relative to the viewport, not the document.

Test: fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html

  • dom/Document.cpp:

(WebCore::Document::caretRangeFromPoint):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29217
Document.caretRangeFromPoint should take the scroll offset into account before hit testing

Reviewed by Maciej Stachowiak.

  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html: Added.

Sep 11, 2009:

11:55 PM Changeset in webkit [48332] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-09-11 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Use gtk_style_set_background instead of gdk_window_set_background
https://bugs.webkit.org/show_bug.cgi?id=29173

Use gtk_style_set_background instead of gdk_window_set_background,
as suggested by the documentation. Also, use GTK_STATE_NORMAL
directly, since that's the default state of a GtkWidget.

  • webkit/webkitwebview.cpp: (webkit_web_view_realize):
9:52 PM Changeset in webkit [48331] by oliver@apple.com
  • 20 edits in trunk

getPropertyNames caching is invalid when the prototype chain contains objects with custom getPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=29214

Reviewed by Sam Weinig.

Add a flag to TypeInfo to indicate whether a type overrides getPropertyNames.
This flag is used to make sure that caching of the property name data is safe.

8:40 PM Changeset in webkit [48330] by cmarrin@apple.com
  • 1 edit
    12 adds in trunk/WebCore

Added some manual tests to show WebGL in action
https://bugs.webkit.org/show_bug.cgi?id=29215

8:33 PM Changeset in webkit [48329] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
architectures are supported for building wxWebKit.

8:31 PM Changeset in webkit [48328] by cfleizach@apple.com
  • 5 edits in trunk

aria definition role spelled wrong "defintion"
https://bugs.webkit.org/show_bug.cgi?id=28840

Reviewed by Darin Adler.

WebCore:

Test: accessibility/aria-slider-value-change.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::RoleEntry::):

LayoutTests:

  • platform/mac/accessibility/aria-grouping-roles-expected.txt:
  • platform/mac/accessibility/aria-grouping-roles.html:
7:17 PM Changeset in webkit [48327] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-09-11 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Fixes an assert in Node::isFocusable which was causing crashes in certain cases.
https://bugs.webkit.org/show_bug.cgi?id=29210

  • fast/events/resources/tab-is-focusable-assert.js:
  • fast/events/tab-is-focusable-assert-expected.txt: Added.

2009-09-11 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Fixes an assert in Node::isFocusable which was causing crashes in certain cases.
https://bugs.webkit.org/show_bug.cgi?id=29210

  • dom/Node.cpp: (WebCore::Node::isFocusable):
6:48 PM Changeset in webkit [48326] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix <rdar://problem/7145242> Crashes inside WTF::HashTable below NetscapePluginInstanceProxy::disconnectStream

Reviewed by Jon Honeycutt.

  • Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::cancelLoad): Canceling the load can result in calling through to disconnectStream.
If the plug-in instance holds the last reference to the plug-in stream this will result in the stream being deallocated.
This leads to HostedNetscapePluginStream::cancelLoad's call to disconnectStream being passed a deallocated stream object.
Since the stream was already disconnected by the call to cancel there's no need to call disconnectStream a second time.

5:13 PM Changeset in webkit [48325] by cmarrin@apple.com
  • 14 edits in trunk/WebCore

Added variants to uniform* and vertexAttrib* calls which take sequence<> in place of CanvasArray
https://bugs.webkit.org/show_bug.cgi?id=29139


I also added a data() call to each of the CanvasArray subclasses to give back a types pointer
to the baseAddress().

5:00 PM Changeset in webkit [48324] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

2009-09-11 Steve Falkenburg <sfalken@apple.com>

Reviewed by Dan Bernstein.

Properly propagate preference from WebPreferences to WebCore::Settings.
https://bugs.webkit.org/show_bug.cgi?id=29192

  • WebView.cpp: (WebView::initWithFrame): Apply setting when creating a new WebView. (WebView::notifyPreferencesChanged): Apply setting when preferences change.
4:59 PM Changeset in webkit [48323] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Add ENABLE(WEB_SOCKETS) guards.
https://bugs.webkit.org/show_bug.cgi?id=29174

  • bindings/v8/custom/V8WebSocketCustom.cpp:
4:57 PM Changeset in webkit [48322] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-09-11 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Mark Rowe.

Add the http/tests/security/mixedContent to the Skipped list while
test failures are being investigated.

  • platform/win/Skipped:
4:34 PM Changeset in webkit [48321] by eric@webkit.org
  • 10 edits
    2 deletes in trunk

2009-09-11 Eric Seidel <eric@webkit.org>

No review, rolling out r48229.
http://trac.webkit.org/changeset/48229

  • fast/events/drag-dropeffect-expected.txt: Removed.
  • fast/events/drag-dropeffect.html: Removed.

2009-09-11 Eric Seidel <eric@webkit.org>

No review, rolling out r48229.
http://trac.webkit.org/changeset/48229

  • WebCore.base.exp:
  • dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard): (WebCore::Clipboard::sourceOperation):
  • page/DragController.cpp: (WebCore::DragController::DragController): (WebCore::DragController::dragExited): (WebCore::DragController::performDrag): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDHTMLDrag): (WebCore::DragController::startDrag):
  • page/DragController.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::dragSourceMovedTo): (WebCore::EventHandler::handleDrag):
  • page/EventHandler.h:

2009-09-11 Eric Seidel <eric@webkit.org>

No review, rolling out r48229.
http://trac.webkit.org/changeset/48229

  • WebView/WebFrame.mm: (-[WebFrame _dragSourceMovedTo:]):
4:28 PM Changeset in webkit [48320] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-09-11 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

bugzilla-tool rollout threw exception under svn
https://bugs.webkit.org/show_bug.cgi?id=29211

  • Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
  • Scripts/modules/scm_unittest.py: add testing for this fix.
3:18 PM Changeset in webkit [48319] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the build.

2009-09-11 Michelangelo De Simone <micdesim@gmail.com>

Fix the build.

  • html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
3:01 PM Changeset in webkit [48318] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-09-11 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=27456
Test case for url validation in ValidityState.

  • fast/forms/ValidityState-typeMismatch-url-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-url.html: Added.
  • fast/forms/resources/ValidityState-typeMismatch-url.js: Added. (check):

2009-09-11 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=27456
Added support for static validation of url in
ValidityState, for url state inputs.
From HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#url-state

Test: fast/forms/ValidityState-typeMismatch-url.html

  • html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
2:52 PM Changeset in webkit [48317] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-11 Evan Stade <estade@chromium.org>

Reviewed by Darin Adler.

Revert r47992: Expose functions to change the focus ring color for
Linux Chromium.

As Darin Fisher has pointed out, there is a better way to do this.

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux):
  • rendering/RenderThemeChromiumLinux.h:
2:51 PM CommitQueue edited by levin@chromium.org
(diff)
2:47 PM Changeset in webkit [48316] by bweinstein@apple.com
  • 2 edits in trunk/WebKitTools

2009-09-11 Brian Weinstein <bweinstein@apple.com>

Add myself to the committers list.

  • Scripts/modules/committers.py:
2:34 PM Changeset in webkit [48315] by ap@apple.com
  • 6 edits in trunk

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=29207
Add checks for using WebCore JS context on secondary threads

1:21 PM Changeset in webkit [48314] by bweinstein@apple.com
  • 4 edits in trunk/WebCore

2009-09-11 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.

The inspector should have scope bars.
https://bugs.webkit.org/show_bug.cgi?id=14353


Add scope bars to the console, so the user can choose which category
of messages they want to see (All, Errors, Warnings, Logs), and they
can choose from one or more of {Errors, Warnings, Logs}.

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createFilterElement): (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._updateFilter): (WebInspector.ConsoleView.prototype.filter): (WebInspector.ConsoleView.prototype.attach):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
1:09 PM Changeset in webkit [48313] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-11 Yusuke Sato <yusukes@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Complex text doesn't show up with text stroking
https://bugs.webkit.org/show_bug.cgi?id=28707

Added extra NULL checks for HDC. This is the second fix for issue 28707,
and the fix is similar to http://trac.webkit.org/changeset/45482.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawComplexText):
  • platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::draw):
12:05 PM Changeset in webkit [48312] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool land-patches should only fail-fast in --commit-queue mode
https://bugs.webkit.org/show_bug.cgi?id=29201

  • Scripts/bugzilla-tool:
11:47 AM Changeset in webkit [48311] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2009-09-11 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Make ElementTimeControl methods return void and not throw.
https://bugs.webkit.org/show_bug.cgi?id=28831

SVG 1.1 erratum:
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#elementtimecontrol-interface

  • svg/dom/smil-methods-expected.txt: Added.
  • svg/dom/smil-methods.svg: Added.

2009-09-11 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Make ElementTimeControl methods return void and not throw.
https://bugs.webkit.org/show_bug.cgi?id=28831

SVG 1.1 erratum:
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#elementtimecontrol-interface

Test: svg/dom/smil-methods.svg

  • svg/ElementTimeControl.h: Change return type from bool to void and remove exception argument.
  • svg/ElementTimeControl.idl: Change return type from bool to void and remove raises claus.
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::beginElement): Change return type from bool to void and remove exception argument. (WebCore::SVGAnimationElement::beginElementAt): Ditto. (WebCore::SVGAnimationElement::endElement): Ditto. (WebCore::SVGAnimationElement::endElementAt): Ditto.
  • svg/SVGAnimationElement.h: Ditto.
11:31 AM Changeset in webkit [48310] by cmarrin@apple.com
  • 3 edits in trunk/WebCore

Added support for texImage2D which takes CanvasArray
https://bugs.webkit.org/show_bug.cgi?id=29191

  • bindings/js/JSCanvasRenderingContext3DCustom.cpp: (WebCore::JSCanvasRenderingContext3D::texImage2D):
  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::texImage2D):
11:15 AM Changeset in webkit [48309] by wsiegrist@apple.com
  • 3 edits in trunk/BugsSite

2009-09-11 David Kilzer <ddkilzer@apple.com>

Apply fix for http://www.bugzilla.org/security/3.0.8/

11:04 AM Changeset in webkit [48308] by sfalken@apple.com
  • 10 edits in trunk

WebCore: Allow WebKit clients to opt out of high resolution timers on Windows.
https://bugs.webkit.org/show_bug.cgi?id=29192

Reviewed by Darin Adler.

  • page/Settings.cpp:

(WebCore::Settings::setShouldUseHighResolutionTimers): Added.

  • page/Settings.h: Added getter/setter for shouldUseHighResolutionTimers.

(WebCore::Settings::shouldUseHighResolutionTimers): Added.

  • platform/win/SharedTimerWin.cpp:

(WebCore::setSharedTimerFireTime): Don't run high resolution timer code if it is disabled.

WebKit/win: Allow WebKit clients to opt out of high resolution timers on Windows.
https://bugs.webkit.org/show_bug.cgi?id=29192

Reviewed by Darin Adler.

  • Interfaces/IWebPreferencesPrivate.idl: Added getter/setter.

Put this just after last 4.0.3 method for future merging.

  • Interfaces/WebKit.idl: Touched to force a rebuild.
  • WebPreferenceKeysPrivate.h: Added prefs key for high res timers.
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Initialize high res timers to enabled.
(WebPreferences::setShouldUseHighResolutionTimers): Added.
(WebPreferences::shouldUseHighResolutionTimers): Added.

  • WebPreferences.h: Added getter/setter.
11:03 AM Changeset in webkit [48307] by Adam Roben
  • 2 edits in trunk/WebKitTools

Make commit-log-editor move common prefixes to the top of the log

Fies <http://webkit.org/b/29190> commit-log-editor should move common
prefixes to the top of the commit log

Reviewed by Darin Adler.

  • Scripts/commit-log-editor: Find and remove the longest common prefix

ending in a double newline from each ChangeLog entry, then put that
common prefix at the top of the commit log.
(removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
removes, and returns the longest common prefix ending in a double
newline from a hash of strings

10:59 AM Changeset in webkit [48306] by eric@webkit.org
  • 8 edits
    1 add in trunk/WebCore

2009-09-11 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>

Reviewed by Adam Barth.

[v8] Share persistent context handles between events
Change events to use a single ref-counted shared persistent handle
to the context in which to run, rather than create a new
persistent handle for each new event which puts pressure on the
gc.

https://bugs.webkit.org/show_bug.cgi?id=29077

  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/v8/SharedPersistent.h: Added. (WebCore::SharedPersistent::set): (WebCore::SharedPersistent::get): (WebCore::SharedPersistent::disposeHandle): (WebCore::SharedPersistent::create): (WebCore::SharedPersistent::SharedPersistent):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): (WebCore::V8AbstractEventListener::handleEvent):
  • bindings/v8/V8AbstractEventListener.h:
  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld): (WebCore::V8IsolatedWorld::~V8IsolatedWorld):
  • bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::context): (WebCore::V8IsolatedWorld::shared_context):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::createWrapperFromCacheSlowCase): (WebCore::V8Proxy::isContextInitialized): (WebCore::V8Proxy::updateDocumentWrapperCache): (WebCore::V8Proxy::clearDocumentWrapperCache): (WebCore::V8Proxy::disposeContextHandles): (WebCore::V8Proxy::clearForClose): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::setSecurityToken): (WebCore::V8Proxy::updateDocument): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::shared_context): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::setContextDebugId):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::context): (WebCore::V8Proxy::shared_context):
10:20 AM Changeset in webkit [48305] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-11 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

Create a real handle (one which would save an object from GC).
https://bugs.webkit.org/show_bug.cgi?id=29150

  • bindings/v8/V8Binding.cpp: (WebCore::v8ExternalString):
10:12 AM Changeset in webkit [48304] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-11 Eric Seidel <eric@webkit.org>

Fix obvious typo in previous commit, no review.

bugzilla-tool should automate rollouts
https://bugs.webkit.org/show_bug.cgi?id=26715

  • Scripts/bugzilla-tool: add back missing "scm" argument.
9:54 AM Changeset in webkit [48303] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2009-09-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool should automate rollouts
https://bugs.webkit.org/show_bug.cgi?id=26715

bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
The --complete-rollout option will automatically land and update the bug.
Eventually --complete-rollout will be default, but that will require more testing.

This first pass is good enough for others to try and file bugs about.

  • Scripts/bugzilla-tool:
    • Move modified_changelogs into scm.py.
    • Move svn_revision_from_commit_text logic into scm.py.
    • Add RolloutCommit command.
  • Scripts/modules/bugzilla.py:
    • Add reopen_bug command used by RolloutCommit.
  • Scripts/modules/scm.py:
    • Add functions to support RolloutCommit.
    • Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
    • Add a str() call so that svn_commit_log can take a numeric argument.
    • Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
    • Made dry_run commits return something that svn_revision_from_commit_text can parse.
  • Scripts/modules/scm_unittest.py:
    • Add read_from_path for easy file reading.
    • Put test4 on a new line to make reverts work w/o conflict.
    • Add an "svn update" call so that the checkout revision matches the server revision.
    • Add tests for svn_revision_from_commit_text.
    • Add a simple test for apply_reverse_diff.
    • Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
    • Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
9:35 AM Changeset in webkit [48302] by Adam Roben
  • 9 edits in trunk

Get user script/stylesheet tests running on Windows

Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
skipped on Windows

Reviewed by John Sullivan.

WebKit/win:

  • Interfaces/IWebViewPrivate.idl: Added addUserScriptToGroup,

addUserStyleSheetToGroup, removeUserContentFromGroup,
removeAllUserContentFromGropu to match the Mac SPI.

  • WebView.cpp:

(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserContentFromGroup):
(WebView::removeAllUserContentFromGroup):

  • WebView.h:

Added. Implementation was based on similar methods in WebView.mm.

WebKitTools:

  • DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations

against comsuppw.lib so we can use _bstr_t.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include

order, added #include of comutil.h for _bstr_t.

(bstrT): Helper function to convert a JSStringRef to a _bstr_t.
(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
Implemented. Implementations were based on those in
LayoutTestControllerMac.mm.

LayoutTests:

  • platform/win/Skipped: Removed the userscripts directory.
7:47 AM Changeset in webkit [48301] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-11 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

Inline WebCore::v8String as it only invokes WebCore::v8ExternalString.
https://bugs.webkit.org/show_bug.cgi?id=29152

  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8Binding.h: (WebCore::v8String):
6:29 AM Changeset in webkit [48300] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-09-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Simon Hausmann.

Compiling JavaScriptCore on sparc 64 with gcc fails.

ThreadSafeShared uses the atomic gnu_cxx::exchange_and_add with an int,
however on sparc 64 the _Atomic_word argument is typedefed to long (8 bytes).

The patch disables WTF_USE_LOCKFREE_THREADSAFESHARED in ThreadSafeShared to use
a mutex instead when compiling for sparc 64 with gcc.

https://bugs.webkit.org/show_bug.cgi?id=29175

  • wtf/Platform.h: sparc64 is not defined on all OS.
Uses instead: sparc && arch64
sparcv9
  • wtf/Threading.h:
5:58 AM Changeset in webkit [48299] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Doc: Note that Netscape plugins are only available on desktop platforms.

Patch by David Boddie <dboddie@trolltech.com> on 2009-09-11
Reviewed by Simon Hausmann.

  • docs/qtwebkit.qdoc:
5:58 AM Changeset in webkit [48298] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Fix compile error on Windows7(64Bit) with latest SDK.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.

Added the missing include file.

  • runtime/UString.cpp:
5:58 AM Changeset in webkit [48297] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Adjust the name of the contentspage for the documentation
to the new name used in Qt 4.6.

Patch by Martin Smith <msmith@trolltech.com> on 2009-09-11
Reviewed by Simon Hausmann.

  • docs/qtwebkit.qdoc:
5:58 AM Changeset in webkit [48296] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Qt/Windows CE compile fix, include the executable allocator and
markstack implementation in the windows build.

Patch by Joerg Bornemann <joerg.bornemann@trolltech.com> on 2009-09-11
Reviewed by Simon Hausmann.

5:58 AM Changeset in webkit [48295] by Simon Hausmann
  • 6 edits in trunk

WebCore: Changed URLs from qtsoftware.com to qt.nokia.com, as part of a general
renaming.

Patch by Ariya Hidayat <ariya.hidayat@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.

  • ChangeLog-2009-06-16:

WebKit/qt: Changed URLs from qtsoftware.com to qt.nokia.com, as part of a general
renaming.

Patch by Ariya Hidayat <ariya.hidayat@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.

  • Api/qwebpluginfactory.cpp:
  • docs/webkitsnippets/simple/main.cpp:

(main):

  • docs/webkitsnippets/webpage/main.cpp:

(main):

5:57 AM Changeset in webkit [48294] by Simon Hausmann
  • 12 edits in trunk/WebKit/qt

Restructure the documentation, both on a file and on a content level.

Patch by Volker Hilsheimer <volker.hilsheimer@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.

  • Api/qwebdatabase.cpp:
  • Api/qwebelement.cpp:
  • Api/qwebframe.cpp:
  • Api/qwebhistory.cpp:
  • Api/qwebhistoryinterface.cpp:
  • Api/qwebpage.cpp:
  • Api/qwebpluginfactory.cpp:
  • Api/qwebsecurityorigin.cpp:
  • Api/qwebsettings.cpp:
  • Api/qwebview.cpp:
  • docs/qtwebkit.qdoc:
5:57 AM Changeset in webkit [48293] by Simon Hausmann
  • 2 edits in trunk/WebCore

Use LIBS_PRIVATE on Qt/Mac.

Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.

On the Mac, it means "-framework ApplicationServices -framework Carbon
-framework AppKit" are no longer part of the default LIBS in Qt
applications. This required a lot of fixes where we used Mac-specific
code in Qt.

  • WebCore.pro:
2:02 AM Changeset in webkit [48292] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-11 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Remove duplicated WK_{u,l}cfirst subs from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=29165

  • bindings/scripts/CodeGeneratorV8.pm: Remove WK_ucfirst and WK_lcfirst, and call the ones in CodeGenerator.pm instead.
1:55 AM Changeset in webkit [48291] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-09-11 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29136
[Qt] emit microFocusChanged() signal when no QWidget-based view is present.

emit microFocusChange() signal regardless of view.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
1:43 AM Changeset in webkit [48290] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-11 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=29132
Symbian winscw compiler fails compiling WebCore/text/RegularExpression.cpp.

Add RegularExpression class qualifier before Private.

  • platform/text/RegularExpression.cpp:
1:35 AM Changeset in webkit [48289] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-11 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=29131
Use a different variadic macro format for Symbian compiler.

Use arg... instead of ellipsis in variadic macro.

  • platform/StaticConstructors.h:
1:27 AM Changeset in webkit [48288] by Simon Hausmann
  • 13 edits
    4 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=28806

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.

[Qt] Make the WebInspector available as a QWidget.

  • WebCore.pro:

WebKit/qt: https://bugs.webkit.org/show_bug.cgi?id=28806

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.

[Qt] Make the WebInspector available as a QWidget.

  • Api/headers.pri:
  • Api/qwebelement.cpp:

(QWebElement::enclosingElement):

  • Api/qwebelement.h:
  • Api/qwebinspector.cpp: Added.
  • Api/qwebinspector.h: Added.
  • Api/qwebinspector_p.h: Added.
  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::setInspector):
(QWebPagePrivate::getOrCreateInspector):
(QWebPagePrivate::inspectorController):
(QWebPage::~QWebPage):
(QWebPage::triggerAction):

  • Api/qwebpage.h:
  • Api/qwebpage_p.h:
  • Api/qwebsettings.cpp:
  • QtLauncher/main.cpp:

(MainWindow::MainWindow):

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientWebPage::InspectorClientWebPage):
(WebCore::InspectorClientWebPage::createWindow):
(WebCore::InspectorClientQt::createPage):
(WebCore::InspectorClientQt::showWindow):
(WebCore::InspectorClientQt::closeWindow):
(WebCore::InspectorClientQt::attachWindow):
(WebCore::InspectorClientQt::detachWindow):
(WebCore::InspectorClientQt::updateWindowTitle):

  • WebCoreSupport/InspectorClientQt.h:
  • docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp: Added.
1:18 AM Changeset in webkit [48287] by Simon Hausmann
  • 2 edits in trunk/WebCore

Unreviewed fix for the Web Inspector with the Qt build.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-11
Re-generate the Qt resource file by running
WebKitTools/Scripts/generate-qt-inspector-resource

  • inspector/front-end/WebKit.qrc:
1:12 AM Changeset in webkit [48286] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Qt build, remove stray semicolon from function definition.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-11

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:

(WebCore::MediaPlayerPrivate::buffered):

12:43 AM Changeset in webkit [48285] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

Fix crash on launch on Windows.

Rubber-stamped by Mark Rowe.

  • WebKit.vcproj/WebKit.vcproj:

Define ENABLE_WEB_SOCKETS for all configurations.

Note: See TracTimeline for information about the timeline view.