Timeline


and

09/28/09:

22:51 Changeset [48860] by mrowe@apple.com

Fix the PowerPC build.

22:42 Changeset [48859] by ukai@chromium.org

2009-09-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Adam Barth.

Add platform code to support WebSocket for chromium.
https://bugs.webkit.org/show_bug.cgi?id=29171

To build within chromium tree, it requires a patch in bug 29174.
Real implementation will be landed in chromium tree.

  • WebCore.gypi:
  • platform/network/chromium/SocketStreamError.h: Added. (WebCore::SocketStreamError::SocketStreamError):
  • platform/network/chromium/SocketStreamHandle.h: Added. (WebCore::SocketStreamHandle::create):
22:16 Changeset [48858] by xan@webkit.org

2009-09-29 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Eric Seidel.

[Gtk] Crash when saving a password
https://bugs.webkit.org/show_bug.cgi?id=28070

Disconnect the 'got-headers' callback when we are done with
it. The signal can be emitted more than once if the message is
retransmitted, but each time that happens authData is created
again and a new callback connected, so we have to get rid of the
old one (which will crash because we free authData).

  • webkit/webkitsoupauthdialog.c: (save_password_callback):
21:57 Changeset [48857] by mrowe@apple.com

Versioning.

21:56 Changeset [48856] by mrowe@apple.com

Merge r48854.

21:53 Changeset [48855] by mrowe@apple.com

New tag.

21:51 Changeset [48854] by mrowe@apple.com

<rdar://problem/7195704> JavaScriptCore fails to mark registers when built for x86_64 using LLVM GCC.

Reviewed by Gavin Barraclough.

  • runtime/Collector.cpp:

(JSC::Heap::markCurrentThreadConservatively): Force jmp_buf to use the appropriate alignment for a pointer
to ensure that we correctly interpret the contents of registers during marking.

21:01 Changeset [48853] by ddkilzer@apple.com

2009-09-28 Yaar Schnitman <yaar@chromium.org>

Reviewed by David Kilzer.

Integrated chromium port building into webkit tools update-webkit and
build-webkit.

https://bugs.webkit.org/show_bug.cgi?id=29749

  • Scripts/build-webkit: When --chromium is specified, will build the chromium port (currently only Mac is supported).
  • Scripts/update-webkit: When --chromium is specified, delegates to update-webkit-chromium.
  • Scripts/webkitdirs.pm: Added chromium specific defs.
  • Scripts/update-webkit-chromium: Uses gclient and gyp to fetch chromium port's dependencies and update its project files.
18:48 Changeset [48852] by ukai@chromium.org

2009-09-28 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed.

Add myself to list of committers.

  • Scripts/modules/committers.py:
18:10 Changeset [48851] by eric@webkit.org

2009-09-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by David Kilzer.

[Gtk][Layout tests] Generate results for css3 tests
https://bugs.webkit.org/show_bug.cgi?id=29784

Add results for css3 tests and enable these tests in the Skipped.

  • platform/gtk/Skipped:
  • platform/gtk/css3/css3-modsel-33-expected.txt: Added.
  • platform/gtk/css3/css3-modsel-35-expected.txt: Added.
  • platform/gtk/css3/css3-modsel-36-expected.txt: Added.
  • platform/gtk/css3/css3-modsel-37-expected.txt: Added.
17:47 Changeset [48850] by eric@webkit.org

2009-09-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by David Kilzer.

[Gtk][Layout tests] Generate results for transitions tests
https://bugs.webkit.org/show_bug.cgi?id=29786

Add results for transitions tests and enable these tests in the Skipped.

  • platform/gtk/Skipped:
  • platform/gtk/transitions/transition-drt-api-expected.txt: Added.
17:35 Changeset [48849] by eric@webkit.org

2009-09-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by David Kilzer.

[Gtk][Layout tests] Generate results for animations tests
https://bugs.webkit.org/show_bug.cgi?id=29783

Add results for animations tests and enable these tests in the Skipped.

  • platform/gtk/Skipped:
  • platform/gtk/animations/animation-drt-api-expected.txt: Added.
  • platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt: Added.
17:28 Changeset [48848] by mitz@apple.com

<rdar://problem/7157288> Crash in RenderStyle::computedLineHeight()
when Times New Roman is not installed

Reviewed by Sam Weinig.

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::getLastResortFallbackFont): If Times New Roman is
not available, use the Windows default GUI font.

17:27 Changeset [48847] by eric@webkit.org

2009-09-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by David Kilzer.

[Gtk][Layout tests] Generate results for transforms tests
https://bugs.webkit.org/show_bug.cgi?id=29785

Add results for transforms tests and enable these tests in the Skipped.

  • platform/gtk/Skipped:
  • platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
  • platform/gtk/transforms/2d/transform-borderbox-expected.txt: Added.
  • platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt: Added.
  • platform/gtk/transforms/no_transform_hit_testing-expected.txt: Added.
16:56 Changeset [48846] by jianli@chromium.org

Do not add platform-specific methods to cross-platform header
FileSystem.h per Darin's feedback for 29109.
https://bugs.webkit.org/show_bug.cgi?id=29830

Reviewed by David Levin.

  • platform/FileSystem.h:
  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):

  • platform/chromium/FileSystemChromium.cpp:
16:35 WebKit Team edited by ukai@chromium.org
add ukai (diff)
16:33 Changeset [48845] by eric@webkit.org

2009-09-28 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Register Chromium's VFSs with a proper sqlite3_io_methods
finder. This should only affect the POSIX implementation. The
Windows change is included for consistency and in case sqlite
starts using something similar in its Windows VFS in the future.

https://bugs.webkit.org/show_bug.cgi?id=29743

  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):
16:25 Changeset [48844] by eric@webkit.org

2009-09-28 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Update the Skipped list after adding XSLT support.
https://bugs.webkit.org/show_bug.cgi?id=29817

Remove the tests that are passing now and skip these that are not,
with a reason of failure for each of them.

  • platform/qt/Skipped:
15:58 Changeset [48843] by ddkilzer@apple.com

2009-09-28 Alex Milowski <alex@milowski.com>

<http://webkit.org/b/29098> Update to MathML project webpage

Reviewed by David Kilzer.

Updated MathML project page and added link to Wiki page.

  • projects/mathml/index.html:
15:50 Changeset [48842] by eric@webkit.org

2009-09-28 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

11 transforms/3d tests failing on the Leopard Debug bot after r48833
https://bugs.webkit.org/show_bug.cgi?id=29828

Leopard has HW compositing disabled until rdar://problem/7228836 can be fixed.
So skip tests which depend on it being enabled per Simon's request.

  • platform/mac-leopard/Skipped:
15:25 Changeset [48841] by japhet@chromium.org

2009-09-28 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Change the V8 bindings' handling of window.toString(),
so we return [object DOMWindow] (like JSC), not [object global].

https://bugs.webkit.org/show_bug.cgi?id=29742

This will fix a couple of Chromium port test failures and enable us to
use the default expectations for a bunch more.

15:23 Changeset [48840] by ggaren@apple.com

Windows build fix: added new exports.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28

15:16 Changeset [48839] by mrowe@apple.com

Roll out r48825. It causes build failures by calling an undefined function from within RefPtr.h.

15:06 Changeset [48838] by japhet@chromium.org

2009-09-28 Nate Chapin <japhet@chromium.org>

Rubber stamped by David Levin.

Chromium build fix, add back in #include of V8Proxy.h in V8WebKitPointConstructor.cpp.

  • bindings/v8/custom/V8WebKitPointConstructor.cpp: Re-include V8Proxy.h.
15:06 Changeset [48837] by ggaren@apple.com

Windows build fix: removed exports that no longer exist.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28

14:45 Changeset [48836] by ggaren@apple.com

NotNullPassRefPtr: smart pointer optimized for passing references that are not null
https://bugs.webkit.org/show_bug.cgi?id=29822

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28
Reviewed by Darin Adler.

JavaScriptCore:

Added NotNullPassRefPtr, and deployed it in all places that initialize
JavaScript objects.

2.2% speedup on bench-allocate-nonretained.js.

  • API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::JSCallbackConstructor):

  • API/JSCallbackConstructor.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject::JSCallbackObject):

(JSC::CodeBlock::addFunctionDecl):
(JSC::CodeBlock::addFunctionExpr):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::ArrayConstructor):

  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::ArrayPrototype):

  • runtime/ArrayPrototype.h:
  • runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::BooleanConstructor):

  • runtime/BooleanConstructor.h:
  • runtime/BooleanObject.cpp:

(JSC::BooleanObject::BooleanObject):

  • runtime/BooleanObject.h:
  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::BooleanPrototype):

  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::DateConstructor):

  • runtime/DateConstructor.h:
  • runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):

  • runtime/DateInstance.h:
  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype):

  • runtime/DatePrototype.h:
  • runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::ErrorConstructor):

  • runtime/ErrorConstructor.h:
  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

  • runtime/ErrorInstance.h:
  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):

  • runtime/ErrorPrototype.h:
  • runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::FunctionConstructor):

  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::FunctionPrototype):

  • runtime/FunctionPrototype.h:
  • runtime/GlobalEvalFunction.cpp:

(JSC::GlobalEvalFunction::GlobalEvalFunction):

  • runtime/GlobalEvalFunction.h:
  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):

  • runtime/InternalFunction.h:

(JSC::InternalFunction::InternalFunction):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):

  • runtime/JSActivation.h:

(JSC::JSActivation::JSActivationData::JSActivationData):

  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::JSByteArray):

  • runtime/JSByteArray.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::JSGlobalObject):

  • runtime/JSONObject.h:

(JSC::JSONObject::JSONObject):

  • runtime/JSObject.h:

(JSC::JSObject::JSObject):
(JSC::JSObject::setStructure):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::JSVariableObject):

  • runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::JSWrapperObject):

  • runtime/MathObject.cpp:

(JSC::MathObject::MathObject):

  • runtime/MathObject.h:
  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::NativeErrorConstructor):

  • runtime/NativeErrorConstructor.h:
  • runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):

  • runtime/NativeErrorPrototype.h:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::NumberConstructor):

  • runtime/NumberConstructor.h:
  • runtime/NumberObject.cpp:

(JSC::NumberObject::NumberObject):

  • runtime/NumberObject.h:
  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::NumberPrototype):

  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::ObjectConstructor):

  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype):

  • runtime/ObjectPrototype.h:
  • runtime/PropertyNameArray.h:

(JSC::PropertyNameArrayData::setCachedPrototypeChain):

  • runtime/PrototypeFunction.cpp:

(JSC::PrototypeFunction::PrototypeFunction):

  • runtime/PrototypeFunction.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::RegExpConstructor):

  • runtime/RegExpConstructor.h:
  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::RegExpObject):

  • runtime/RegExpObject.h:

(JSC::RegExpObject::RegExpObjectData::RegExpObjectData):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):

  • runtime/RegExpPrototype.h:
  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):

  • runtime/StringConstructor.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::StringObject):

  • runtime/StringObject.h:
  • runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::StringPrototype):

  • runtime/StringPrototype.h:
  • wtf/PassRefPtr.h:

(WTF::NotNullPassRefPtr::NotNullPassRefPtr):
(WTF::NotNullPassRefPtr::~NotNullPassRefPtr):
(WTF::NotNullPassRefPtr::get):
(WTF::NotNullPassRefPtr::clear):
(WTF::NotNullPassRefPtr::releaseRef):
(WTF::NotNullPassRefPtr::operator*):
(WTF::NotNullPassRefPtr::operator->):
(WTF::NotNullPassRefPtr::operator!):
(WTF::NotNullPassRefPtr::operator UnspecifiedBoolType):

  • wtf/RefPtr.h:

(WTF::RefPtr::RefPtr):
(WTF::operator==):

WebCore:

Added NotNullPassRefPtr, and deployed it in all places that initialize
JavaScript objects.

  • bindings/js/DOMObjectWithSVGContext.h:

(WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::cacheDOMStructure):

  • bindings/js/JSDOMBinding.h:

(WebCore::DOMObject::DOMObject):
(WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):

  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSHTMLAllCollection.h:

(WebCore::JSHTMLAllCollection::JSHTMLAllCollection):

  • bindings/js/JSInspectedObjectWrapper.cpp:

(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):

  • bindings/js/JSInspectedObjectWrapper.h:
  • bindings/js/JSInspectorCallbackWrapper.cpp:

(WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):

  • bindings/js/JSInspectorCallbackWrapper.h:
  • bindings/js/JSQuarantinedObjectWrapper.cpp:

(WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):

  • bindings/js/JSQuarantinedObjectWrapper.h:
  • bindings/js/JSWorkerContextBase.cpp:

(WebCore::JSWorkerContextBase::JSWorkerContextBase):

  • bindings/js/JSWorkerContextBase.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/runtime_object.cpp:

(JSC::RuntimeObjectImp::RuntimeObjectImp):

  • bridge/runtime_object.h:
14:38 Changeset [48835] by eric@webkit.org

2009-09-28 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Add the expected result for the fast/xsl/document-function test.
https://bugs.webkit.org/show_bug.cgi?id=29817

  • platform/qt/fast/xsl/document-function-expected.txt: Added.
14:30 Changeset [48834] by eric@webkit.org

2009-09-28 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Allow V8 to handle x/y parameters in a WebKitPoint constructor.
https://bugs.webkit.org/show_bug.cgi?id=29823

Fixes V8's handling of LayoutTests/fast/dom/Window/webkitConvertPoint.html

  • bindings/v8/custom/V8WebKitPointConstructor.cpp: Allow for x/y parameters in constructor.
14:22 Changeset [48833] by eric@webkit.org

2009-09-25 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
https://bugs.webkit.org/show_bug.cgi?id=28624

No longer skip media tests now that we're disabling hardware compositing instead.
Add leopard-specific results for 2 tests expected to fail with HW compositing disabled.

  • platform/mac-leopard/Skipped:
  • platform/mac-leopard/fast/media/mq-transform-02-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.checksum.
  • platform/mac-leopard/fast/media/mq-transform-02-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.png.
  • platform/mac-leopard/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.txt.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.checksum.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.png.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.txt.

2009-09-27 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Darin Adler.

run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
https://bugs.webkit.org/show_bug.cgi?id=29771

  • Scripts/run-webkit-tests:
13:57 Changeset [48832] by mrowe@apple.com

Fix the build by doing something approximating reasonableness in the Xcode project.

  • WebCore.xcodeproj/project.pbxproj:
13:55 Changeset [48831] by mitz@apple.com

<rdar://problem/7240911> REGRESSION (r48586): Crash occurs when loading
a PDF

Reviewed by Anders Carlsson.

CGPDFObjectRef is not a CFTypeRef, and cannot be retained or released.
Its lifetime is managed by its container. Just use a Vector to store
CGPDFObjectRefs, relying on the CGPDFDocument to keep them alive.

  • WebView/WebPDFDocumentExtras.mm:

(appendValuesInPDFNameSubtreeToVector):
(getAllValuesInPDFNameTree):
(web_PDFDocumentAllScripts):

13:42 Changeset [48830] by oliver@apple.com

Hard dependency on SSE2 instruction set with JIT
https://bugs.webkit.org/show_bug.cgi?id=29779

Reviewed by Geoff Garen

Add floating point support checks to op_jfalse and op_jtrue, and
fix the logic for the slow case of op_add

13:41 Changeset [48829] by hausmann@webkit.org

Prospective Tiger build fix.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-09-28

  • WebCore.xcodeproj/project.pbxproj: Try to use unique IDs for the new files.
13:33 Changeset [48828] by pfeldman@chromium.org

2009-09-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add explicit frontend event for commit load.

https://bugs.webkit.org/show_bug.cgi?id=29814

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didCommitLoad):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._setDocument):
  • inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.didCommitLoad):
13:30 Changeset [48827] by eric@webkit.org

2009-09-28 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium port - recognize we are being built independently
of chromium and look for dependencies under webkit/chromium rather
than chromium/src.

https://bugs.webkit.org/show_bug.cgi?id=29722

2009-09-28 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium port - recognize we are being built independently
of chromium and look for dependencies under webkit/chromium rather
than chromium/src.

https://bugs.webkit.org/show_bug.cgi?id=29722

  • WebCore.gyp/WebCore.gyp: See above. Also removed a few files from the sources list, since they are not supposed to be built here.

2009-09-28 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=29722

  • chromium/DEPS: Describes the chromium port's dependencies and is used by gclient to fetch them.
  • chromium/webkit.gyp: Currently only builds webcore but in the future will also build the webkit api.
13:11 Changeset [48826] by hausmann@webkit.org

[Qt] Implement XSLT support with QtXmlPatterns.
https://bugs.webkit.org/show_bug.cgi?id=28303

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
Reviewed by Simon Hausmann.

JavaScriptCore:

  • wtf/Platform.h: Add a WTF_USE_QXMLQUERY #define.

WebCore:

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setTransformSource):

  • dom/Document.h:

(WebCore::Document::transformSource):

  • dom/TransformSource.h: Added.

(WebCore::TransformSource::platformSource):

  • dom/TransformSourceLibxslt.cpp: Added.

(WebCore::TransformSource::TransformSource): Wraps a libxml2 document.
(WebCore::TransformSource::~TransformSource):

  • dom/TransformSourceQt.cpp: Added.

(WebCore::TransformSource::TransformSource): Wraps a plain string.
(WebCore::TransformSource::~TransformSource):

  • dom/XMLTokenizerLibxml2.cpp:

(WebCore::XMLTokenizer::doEnd):

  • dom/XMLTokenizerQt.cpp:

(WebCore::XMLTokenizer::doEnd):
(WebCore::XMLTokenizer::parseProcessingInstruction):

  • xml/XSLStyleSheet.h:

(WebCore::XSLStyleSheet::sheetString):

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::document):

  • xml/XSLStyleSheetQt.cpp: Added.
  • xml/XSLTProcessor.h:
  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::xmlDocPtrFromNode):

  • xml/XSLTProcessorQt.cpp: Added.

(WebCore::XSLTMessageHandler::XSLTMessageHandler): A subclass of QAbstractMessageHandler.
(WebCore::XSLTMessageHandler::handleMessage): Forwards all processor messages to the Console.
(WebCore::XSLTProcessor::transformToString): Uses QXmlQuery.

13:09 Changeset [48825] by eric@webkit.org

2009-09-28 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=28054

Use derefInNotNull() to work around winscw compiler forward declaration bug
regarding templated classes.

The compiler bug is reported at
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.

The change should be reverted when the above bug is fixed in winscw compiler.

Add parenthesis around (RefPtr::*UnspecifiedBoolType) to make winscw compiler
work with the default UnSpecifiedBoolType() operator, which removes the winscw hack.

  • wtf/RefPtr.h: (WTF::RefPtr::~RefPtr): (WTF::RefPtr::clear): (WTF::RefPtr::operator UnspecifiedBoolType):

2009-09-28 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Eric Seidel.

Make JObjectWrapper::ref() and deref() public accessible to derefIfNull().

Will be reverted when the following winscw compiler bug is fixed.
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812

  • bridge/jni/jni_instance.h:
11:57 Changeset [48824] by hausmann@webkit.org

Remove clear_cache which is an internal function of GCC
https://bugs.webkit.org/show_bug.cgi?id=28886

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-09-28
Reviewed by Simon Hausmann.

Although clear_cache is exported from GCC, this is an internal
function. GCC makes no promises about it.

  • jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

11:51 Changeset [48823] by eric@webkit.org

2009-09-28 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Move message-port-multi.js from resources to script-tests
https://bugs.webkit.org/show_bug.cgi?id=29798

  • fast/events/message-port-multi-expected.txt:
  • fast/events/message-port-multi.html:
  • fast/events/resources/message-port-multi.js: Removed.
  • fast/events/script-tests/message-port-multi.js: Added. (channel.port2.onmessage):
11:43 Changeset [48822] by eric@webkit.org

2009-09-28 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Delegate implementation of rendererIsNeeded() for media control elements to RenderTheme.

https://bugs.webkit.org/show_bug.cgi?id=28689

Covered by LayoutTests/media/video-no-audio.html

  • rendering/MediaControlElements.cpp: Removed subclass implementations of rendererIsNeeded(). (WebCore::MediaControlElement::rendererIsNeeded): Include calling shouldRenderMediaControlPart(). (WebCore::MediaControlInputElement::rendererIsNeeded): Include calling shouldRenderMediaControlPart().
  • rendering/MediaControlElements.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::shouldRenderMediaControlPart): New method. Contains logic moved from subclass implementations of rendererIsNeeded().
  • rendering/RenderTheme.h:
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::shouldRenderMediaControlPart): Override to always render mute button.
  • rendering/RenderThemeChromiumSkia.h:
11:13 Changeset [48821] by jianli@chromium.org

[chromium] DragData::asURL should return file URL.
https://bugs.webkit.org/show_bug.cgi?id=29109

Reviewed by David Levin.

Tested by LayoutTests/fast/events/drag-to-navigate.html.

  • platform/FileSystem.h:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):

  • platform/chromium/FileSystemChromium.cpp:

(WebCore::getAbsolutePath):
(WebCore::isDirectory):
(WebCore::filePathToURL):

10:57 Changeset [48820] by dglazkov@chromium.org

2009-09-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by David Levin.

[V8] Add a special case to handle index arguments, because we need to be
able to see if they're < 0.
https://bugs.webkit.org/show_bug.cgi?id=29810

Test: LayoutTests/dom/html/level1/core/hc_characterdataindexsizeerrdeletedatacountnegative.html

  • bindings/scripts/CodeGeneratorV8.pm: Added special case (matching CodeGeneratorJS.pm) for index arguments.
10:55 Changeset [48819] by weinig@apple.com

Fix an absolute path to somewhere in Oliver's machine to a relative path
for derived JSONObject.lut.h.

Reviewed by Oliver Hunt.

09:34 Changeset [48818] by mitz@apple.com

Extend the MediaWiki/KHTMLFixes.css workaround to cover older MediaWiki versions
https://bugs.webkit.org/show_bug.cgi?id=29792

Reviewed by Darin Adler.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet): If site specific hacks are
enabled, check if the linked style sheet is one of two versions of the
MediaWiki KHTMLFixes.css. If so, remove the offending rule.

09:29 Changeset [48817] by dglazkov@chromium.org

2009-09-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

[V8] Fix an error in type logic in CodeGeneratorV8.pm, where
unsigned ints are accidentally used as signed.
https://bugs.webkit.org/show_bug.cgi?id=29810

Test: LayoutTests/fast/forms/textarea-maxlength.html

  • bindings/scripts/CodeGeneratorV8.pm: Made sure "unsigned long" in IDL is properly generates on "unsigned" return value.
09:14 Changeset [48816] by simon.fraser@apple.com

2009-09-25 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

ASSERTION FAILED: !repaintContainer
repaintContainer == this

https://bugs.webkit.org/show_bug.cgi?id=29755

It's possible for RenderObject::container() to return an object that is higher
in the hierarchy than the repaintContainer that is being used to repaint an
object. For example, this can happen when running an accelerated opacity
transition on an element with a position:absolute parent, and a position:absolute child.

In this case we need to detect when RenderObject::container() will skip over
repaintContainer, and in that case adjust the coords to shift into repaintContainer's space.

Test: compositing/repaint/opacity-between-absolute.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::computeRectForRepaint):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::computeRectForRepaint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::container):
  • rendering/RenderObject.h:
08:06 Changeset [48815] by hausmann@webkit.org

Rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp.
https://bugs.webkit.org/show_bug.cgi?id=28303

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
Reviewed by Simon Hausmann.

In preparation for adding XSLT support with QtXmlPatterns to the Qt
port, rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp as we will
have our own implementation which most likely will not share any code
with the current one.

Additionally, fix some coding style issues.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • xml/XSLStyleSheet.cpp: Renamed to XSLStyleSheetLibxslt.cpp.
  • xml/XSLStyleSheetLibxslt.cpp: Added.
07:45 Changeset [48814] by hausmann@webkit.org

Prospective build fix for r48812.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-28
Forgot to remove the inline reset() implementation when reverting the indentation
changes in the file.

  • xml/XSLTProcessor.h:
07:40 Changeset [48813] by pfeldman@chromium.org

2009-09-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by nobody (trivial follow up fix), Joseph Pecoraro LGTM-ed.

Web Inspector: Follow up to r48809.
InspectorController.wrapObject should only be called on the inspectable page side.

https://bugs.webkit.org/show_bug.cgi?id=17429

07:36 Changeset [48812] by hausmann@webkit.org

Move the libxslt specific part of XSLTProcessor to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=28303

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
Reviewed by Simon Hausmann.

In preparation for adding XSLT support with QtXmlPatterns to the Qt
port, move the libxslt part of the XSLTProcessor implementation into
another file and leave the part that can be reused and shared.

Additionally, fix some coding style issues.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource): Remove trailing whitespaces.
(WebCore::createFragmentFromSource): Remove trailing whitespaces.
(WebCore::XSLTProcessor::transformToFragment): Remove trailing whitespaces.
(WebCore::XSLTProcessor::reset): Moved out of the class definition.

  • xml/XSLTProcessorLibxslt.cpp: Added.

(WebCore::XSLTProcessor::genericErrorFunc): Moved.
(WebCore::XSLTProcessor::parseErrorFunc): Moved.
(WebCore::docLoaderFunc): Moved.
(WebCore::setXSLTLoadCallBack): Moved.
(WebCore::writeToVector): Moved.
(WebCore::saveResultToString): Moved.
(WebCore::xsltParamArrayFromParameterMap): Moved.
(WebCore::freeXsltParamArray): Moved.
(WebCore::xsltStylesheetPointer): Moved.
(WebCore::xmlDocPtrFromNode): Moved.
(WebCore::resultMIMEType): Moved.
(WebCore::XSLTProcessor::transformToString): Moved.

07:28 Changeset [48811] by staikos@webkit.org

Minor correction to Copyright notice. Not reviewed.

06:35 Changeset [48810] by eric@webkit.org

2009-09-28 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Fix the crash of SVG that crashes when use a non-exist symbol
https://bugs.webkit.org/show_bug.cgi?id=27693

  • svg/custom/use-non-existing-symbol-crash-expected.txt: Added.
  • svg/custom/use-non-existing-symbol-crash.svg: Added.

2009-09-28 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Fix the crash of SVG that crashes when use a non-exist symbol
https://bugs.webkit.org/show_bug.cgi?id=27693

Test: svg/custom/use-non-existing-symbol-crash.svg

  • svg/SVGUseElement.cpp: (WebCore::shadowTreeContainsChangedNodes):
05:36 Changeset [48809] by pfeldman@chromium.org

2009-09-28 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Inspector Should Show Event Listeners/Handlers Registered on each Node
https://bugs.webkit.org/show_bug.cgi?id=17429


Extracted a method from dispatchEvent to get the event ancestor chain


  • dom/Node.cpp: (WebCore::Node::eventAncestors): the extracted method (WebCore::Node::dispatchGenericEvent): use eventAncestors
  • dom/Node.h:

Asynchronous Flow For the Inspector, Backend -> DOM Agent -> Frontend
The DOMAgent's getEventListenersForNode handles the logic of finding
all the relevant listeners in the event flow.

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getEventListenersForNode):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::buildObjectForEventListener): (WebCore::InspectorDOMAgent::buildObjectForNode): added localName
  • inspector/InspectorDOMAgent.h: (WebCore::EventListenerInfo::EventListenerInfo):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetEventListenersForNode):
  • inspector/InspectorFrontend.h: (WebCore::InspectorFrontend::scriptState):
  • inspector/front-end/DOMAgent.js: added localName to WebInspector.DOMNode from payload (WebInspector.EventListeners.getEventListenersForNodeAsync.mycallback): (WebInspector.EventListeners.getEventListenersForNodeAsync):

New Sidebar Pane in the Element's Panel
Includes Gear Menu for filtering the Event Listeners on the
"Selected Node Only" or "All Nodes"

  • inspector/front-end/ElementsPanel.js: Handles refreshing the Pane when necessary (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.updateEventListeners):
  • inspector/front-end/EventListenersSidebarPane.js: Added. (WebInspector.EventListenersSidebarPane): The 1st level in the Pane (WebInspector.EventListenersSidebarPane.prototype.update.callback): (WebInspector.EventListenersSidebarPane.prototype.update): (WebInspector.EventListenersSection): The 2nd level in the Pane (WebInspector.EventListenersSection.prototype.update): filters on Preference (WebInspector.EventListenersSection.prototype.addListener): (WebInspector.EventListenerBar): The 3rd level in the Pane (WebInspector.EventListenerBar.prototype._getNodeDisplayName): (WebInspector.EventListenerBar.prototype._getFunctionDisplayName): (WebInspector.EventListenersSidebarPane.prototype._changeSetting): For the Gear Menu


Consolidated "appropriateSelectorForNode"

  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/utilities.js:

Miscellaneous Updates

  • English.lproj/localizedStrings.js: "Event Listeners", "No Event Listeners", "Selected Node Only", "All Nodes"
  • WebCore.gypi: included the new inspector files
  • WebCore.vcproj/WebCore.vcproj: included source files that were missing
  • inspector/front-end/Images/grayConnectorPoint.png: Added. Thanks to Timothy Hatcher.
  • inspector/front-end/Images/whiteConnectorPoint.png: Added. Thanks to Timothy Hatcher.
  • inspector/front-end/inspector.js: Preferences for the Gear Menu Event Listeners filter
  • inspector/front-end/inspector.css: reused as much as possible
  • inspector/front-end/inspector.html: include the new script
  • inspector/front-end/WebKit.qrc: included the new inspector files
04:16 Changeset [48808] by hausmann@webkit.org

Compile fix with namespaced Qt.

Patch by Andre Poenitz <andre.poenitz@trolltech.com> on 2009-09-28
Reviewed by Simon Hausmann.

  • Api/qwebinspector_p.h:
02:17 Changeset [48807] by hausmann@webkit.org

Add ARM version detection for Windows CE.

Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-28
Reviewed by Simon Hausmann.

  • wtf/Platform.h:

09/27/09:

21:49 WebKit Team edited by hamaji@chromium.org
(diff)
16:59 Changeset [48806] by weinig@apple.com

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29760
Implement CSSOM Range.getClientRects/getBoundingClientRect

Reviewed by Dan Bernstein.

Tests: fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport.html

fast/dom/Range/getBoundingClientRect.html
fast/dom/Range/getClientRects.html

  • dom/Range.cpp:

(WebCore::Range::getClientRects):
(WebCore::Range::getBoundingClientRect):
(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoom):
(WebCore::Range::getBorderAndTextQuads):

  • dom/Range.h:
  • dom/Range.idl:

Implement Range.getClientRects/getBoundingClientRect.

  • dom/Element.cpp:
  • rendering/RenderObject.h:

(WebCore::adjustForAbsoluteZoom):
(WebCore::adjustIntRectForAbsoluteZoom):
(WebCore::adjustFloatPointForAbsoluteZoom):
(WebCore::adjustFloatQuadForAbsoluteZoom):
Move point/quad adjustment methods from Element.cpp to RenderObject.h
so that Range.cpp can use them as well.

LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=29760
Implement CSSOM Range.getClientRects/getBoundingClientRect

Reviewed by Dan Bernstein.

  • fast/dom/Element/getBoundingClientRect-expected.txt: Copied from LayoutTests/fast/dom/getBoundingClientRect-expected.txt.
  • fast/dom/Element/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Copied from LayoutTests/fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt.
  • fast/dom/Element/getBoundingClientRect-getClientRects-relative-to-viewport.html: Copied from LayoutTests/fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html.
  • fast/dom/Element/getBoundingClientRect.html: Copied from LayoutTests/fast/dom/getBoundingClientRect.html.
  • fast/dom/Element/getClientRects-expected.txt: Copied from LayoutTests/fast/dom/getClientRects-expected.txt.
  • fast/dom/Element/getClientRects.html: Copied from LayoutTests/fast/dom/getClientRects.html.
  • fast/dom/Range/getBoundingClientRect-expected.txt: Added.
  • fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Added.
  • fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport.html: Added.
  • fast/dom/Range/getBoundingClientRect.html: Added.
  • fast/dom/Range/getClientRects-expected.txt: Added.
  • fast/dom/Range/getClientRects.html: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/getBoundingClientRect-expected.txt: Removed.
  • fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Removed.
  • fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html: Removed.
  • fast/dom/getBoundingClientRect.html: Removed.
  • fast/dom/getClientRects-expected.txt: Removed.
  • fast/dom/getClientRects.html: Removed.
14:33 Changeset [48805] by eric@webkit.org

2009-09-27 Joe Ligman <joseph.ligman@mindspring.com>

Reviewed by Simon Hausmann.

[Qt] Adding API setFocus and hasFocus to QWebElement. This API is needed for
clients that want to check/set the focus node of the document.
https://bugs.webkit.org/show_bug.cgi?id=29682

  • Api/qwebelement.cpp: (QWebElement::hasFocus): (QWebElement::setFocus):
  • Api/qwebelement.h:
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::hasSetFocus):
14:32 Changeset [48804] by hausmann@webkit.org

Unreviewed fix for WebInspector with Qt build.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-09-27
Simply re-generate the Qt resource file by running
WebKitTools/Scripts/generate-qt-inspector-resource

  • inspector/front-end/WebKit.qrc:
12:45 Changeset [48803] by eric@webkit.org

2009-09-27 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Darin Adler.

run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
https://bugs.webkit.org/show_bug.cgi?id=29771

  • Scripts/run-webkit-tests:
12:17 BuildingGtk edited by kov@webkit.org
(diff)
12:12 Changeset [48802] by eric@webkit.org

2009-09-27 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Remove tests that are passing from the Skipped list after implementing
the waitForPolicyDelegate() function in LayoutTestController.
https://bugs.webkit.org/show_bug.cgi?id=25037

  • platform/qt/Skipped:
12:05 Changeset [48801] by eric@webkit.org

2009-09-27 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement layoutTestController.waitForPolicyDelegate.
https://bugs.webkit.org/show_bug.cgi?id=25037

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::acceptNavigationRequest):
  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::notifyDone): (LayoutTestController::waitForPolicyDelegate):
  • DumpRenderTree/qt/jsobjects.h: (LayoutTestController::waitForPolicy):
02:44 Changeset [48800] by pfeldman@chromium.org

2009-09-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by nobody (trivial ChangeLog fix).

Restore WebCore/ChangeLog truncated in r48778.

02:19 Changeset [48799] by pfeldman@chromium.org

2009-09-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: DOM store is being unbound twice, leading to assertion failure.

https://bugs.webkit.org/show_bug.cgi?id=29770

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage):
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::unbind):
02:14 Changeset [48798] by pfeldman@chromium.org

2009-09-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not track DOM changes while inspector window is closed.

https://bugs.webkit.org/show_bug.cgi?id=29769

  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument):
  • inspector/InspectorDOMAgent.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchWindowObjectAvailable):
  • page/android/InspectorControllerAndroid.cpp: (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
00:08 Changeset [48797] by pfeldman@chromium.org

2009-09-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] Double Clicking Resources Fails to Open in New Window

https://bugs.webkit.org/show_bug.cgi?id=29762

  • inspector/front-end/InjectedScript.js: (InjectedScript.setStyleText): (InjectedScript.openInInspectedWindow):
  • inspector/front-end/InjectedScriptAccess.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):

09/26/09:

20:15 Changeset [48796] by ddkilzer@apple.com

GTK BUILD FIX: add ENABLE_ORIENTATION_EVENTS support to configure.ac

  • configure.ac: Added support for ENABLE_ORIENTATION_EVENTS.
20:02 Changeset [48795] by ddkilzer@apple.com

Part 2 of 2: <http://webkit.org/b/29753> DerivedSources.make broken for non-Mac targets

Reviewed by Darin Adler.

Fix ENABLE_ORIENTATION_EVENTS for non-Mac platforms.

WebCore:

  • DerivedSources.make: Moved Platform.h check for ENABLE_ORIENTATION_EVENTS into Mac-only section and added default of ENABLE_ORIENTATION_EVENTS = 0 to non-Mac section. Added ifndef test to make it possible to override both ENABLE_DASHBOARD_SUPPORT and ENABLE_ORIENTATION_EVENTS external to the makefile. Moved addition of ENABLE_ORIENTATION_EVENTS to ADDITIONAL_IDL_DEFINES to common section.
  • GNUmakefile.am: Added support for ENABLE_ORIENTATION_EVENTS if it is ever used.
  • WebCore.pro: Ditto.

WebKit:

  • chromium/features.gypi: Added 'ENABLE_ORIENTATION_EVENTS=0' to disable this feature by default.
16:14 Changeset [48794] by ddkilzer@apple.com
<http://webkit.org/b/29764> mark-bug-fixed: add -oopen switch

Reviewed by Eric Seidel.

The -oopen switch uses the open(1) command on Mac OS X to

open the bug URL in the default web browser. If there are
similar mechanisms on other platforms, they may be added later.

  • Scripts/mark-bug-fixed:
(MarkBugFixed.init): Added -oopen switch to list of parse

options.
(MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
code into main() and extracted prompting code into
_prompt_user_for_correctness().
(MarkBugFixed._open_bug_in_web_browser): Added.
(MarkBugFixed._prompt_user_for_correctness): Added.
(MarkBugFixed.main): Added logging code from
_determine_bug_id_and_svn_revision(). Added code to call
_open_bug_in_web_browser() if the switch is set. Added code to
call _prompt_user_for_correctness() when needed.

  • Scripts/modules/bugzilla.py: (Bugzilla.short_bug_url_for_bug_id): Added.
15:57 Changeset [48793] by ddkilzer@apple.com

svn-unapply and svn-apply don't work when used outside multiple svn working directories

<http://webkit.org/b/29744>
<rdar://problem/7252905>

Reviewed by Eric Seidel.

Some users have a workflow where svn-create-patch, svn-apply and
svn-unapply are used outside of multiple svn working
directories. Instead of aborting the scripts in these cases,
print a warning and assume that Subversion is being used.

  • Scripts/VCSUtils.pm: (determineVCSRoot): Call warn() instead of die() if both isGit() and isSVN() initially return false. Set $VCSUtils::isSVN to 1 to enforce the assumption about Subversion, then return determineSVNRoot().
  • Scripts/svn-apply: Switch to using isGit() and isSVN() from VCSUtils.pm. They both already cache their values and checking here is redundant since determineVCSRoot() is called later.
11:56 Changeset [48792] by eric@webkit.org

2009-09-26 Kent Tamura <tkent@chromium.org>

Reviewed by David Kilzer.

Move placeholder-related code to HTMLTextFormControlElement from
HTMLInputElement, WMLInputElement, InputElement, and
HTMLTextAreaElement.
https://bugs.webkit.org/show_bug.cgi?id=28703

  • dom/InputElement.cpp: (WebCore::InputElement::dispatchFocusEvent): (WebCore::InputElement::dispatchBlurEvent): (WebCore::InputElement::setValueFromRenderer):
  • dom/InputElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): (WebCore::HTMLTextFormControlElement::~HTMLTextFormControlElement): (WebCore::HTMLTextFormControlElement::dispatchFocusEvent): (WebCore::HTMLTextFormControlElement::dispatchBlurEvent): (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible): (WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
  • html/HTMLFormControlElement.h: (WebCore::HTMLTextFormControlElement::handleFocusEvent): (WebCore::HTMLTextFormControlElement::handleBlurEvent):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): (WebCore::HTMLInputElement::handleFocusEvent): (WebCore::HTMLInputElement::handleBlurEvent): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::supportsPlaceholder): (WebCore::HTMLInputElement::isEmptyValue):
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::parseMappedAttribute):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): (WebCore::HTMLTextAreaElement::createRenderer):
  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::supportsPlaceholder): (WebCore::HTMLTextAreaElement::isEmptyValue):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::updateFromElement):
  • rendering/RenderTextControlSingleLine.h:
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::createRenderer):
  • wml/WMLInputElement.h:
10:51 Changeset [48791] by eric@webkit.org

2009-09-26 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
https://bugs.webkit.org/show_bug.cgi?id=29689

Load test fonts through FontConfig before each test.
This ensures a more proper rendering of the tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): (runTest): (main):
  • DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
  • GNUmakefile.am:
08:00 Changeset [48790] by eric@webkit.org

2009-09-26 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Alexey Proskuryakov.

Optimize the code so only the text from start to end is scanned.
https://bugs.webkit.org/show_bug.cgi?id=29092

On a platform with webkit+Qt+Symbian, the parsing time for a 600K text
file improved from 400ms to 40ms (10x faster).

  • dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
06:12 Changeset [48789] by eric@webkit.org

2009-09-26 Xiaomei Ji <xji@chromium.org>

Reviewed by Eric Seidel.

This Patch fixes [chromium] the drop-down is always left-aligned even
for RTL element.
https://bugs.webkit.org/show_bug.cgi?id=29612

For auto-complete, the items in drop-down should be right-aligned if
the directionality of <input> field is RTL.
For <select><option>, the items in drop-down should be right-aligned
if the directionality of <select> is RTL.

No automatic test is possible. Manual tests are added.

  • manual-tests/autofill_alignment.html: Added.
  • manual-tests/select_alignment.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::paintRow): Adjust the starting x-axis of text to be paint if it should be right-aligned.
05:47 Changeset [48788] by hausmann@webkit.org

Add MarkStackSymbian.cpp to build JavascriptCore for Symbian.

Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-09-26
Reviewed by Simon Hausmann.

Re-use Windows shrinkAllocation implementation because Symbian doesn't
support releasing part of memory region.

Use fastMalloc and fastFree to implement allocateStack and releaseStack
for Symbian port.

(JSC::MarkStack::MarkStackArray::shrinkAllocation):

  • runtime/MarkStackSymbian.cpp: Added.

(JSC::MarkStack::initializePagesize):
(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack):

09/25/09:

23:43 Changeset [48787] by mitz@apple.com

REGRESSION (r48775) FontList.plist written by TOT WebKit causes Safari 4
to crash on launch
https://bugs.webkit.org/show_bug.cgi?id=29759

Reviewed by Sam Weinig.

  • platform/graphics/win/FontDatabase.cpp:

(WebCore::writeFontDatabaseToPlist): Reverted to saving the CG font DB
property list at the root of FontList.plist, but with an additional
key for the last value of the Fonts registry key.
(WebCore::populateFontDatabase): Pass the FontList.plist in its entirety
to populatFontDatabaseFromPlist.

23:41 Changeset [48786] by kevino@webkit.org

wx build fix. Add EmptyPluginHalterClient when creating Page.

23:31 Changeset [48785] by kevino@webkit.org

Build fix. Adding missing header files.

21:32 Changeset [48784] by ddkilzer@apple.com

Part 1 of 2: <http://webkit.org/b/29753> DerivedSources.make broken for non-Mac targets

Reviewed by Darin Adler.

  • DerivedSources.make: Move tests for ENABLE_CONTEXT_MENUS, ENABLE_DRAG_SUPPORT and ENABLE_INSPECTOR into Mac-only section.
19:35 Changeset [48783] by eric@webkit.org

2009-09-25 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Load blocks during unload should not affect targeted loads
https://bugs.webkit.org/show_bug.cgi?id=29747

Test that we can follow targeted hyperlinks in an unload handler.

  • fast/loader/resources/unload-hyperlink-targeted-subframe.html: Added.
  • fast/loader/unload-hyperlink-targeted-expected.txt: Added.
  • fast/loader/unload-hyperlink-targeted.html: Added.

2009-09-25 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Load blocks during unload should not affect targeted loads
https://bugs.webkit.org/show_bug.cgi?id=29747

Move the check of the unload state after checking for targeted links.

Test: fast/loader/unload-hyperlink-targeted.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL):
19:27 Changeset [48782] by eric@webkit.org

2009-09-25 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Fix unaligned data access in YARR_JIT on ARMv5 and below.
https://bugs.webkit.org/show_bug.cgi?id=29695

On ARMv5 and below all data access should be naturally aligned.
In the YARR_JIT there is a case when character pairs are
loaded from the input string, but this data access is not
naturally aligned. This fix introduces load32WithUnalignedHalfWords
and branch32WithUnalignedHalfWords functions which contain
naturally aligned memory loads - half word loads - on ARMv5 and below.

  • assembler/MacroAssemblerARM.cpp: (JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::load32WithUnalignedHalfWords): (JSC::MacroAssemblerARM::branch32WithUnalignedHalfWords):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::load32WithUnalignedHalfWords): (JSC::MacroAssemblerARMv7::branch32): (JSC::MacroAssemblerARMv7::branch32WithUnalignedHalfWords):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::load32WithUnalignedHalfWords): (JSC::MacroAssemblerX86Common::branch32WithUnalignedHalfWords):
  • wtf/Platform.h:
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generatePatternCharacterPair):
19:13 Changeset [48781] by eric@webkit.org

2009-09-25 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

[Chromium] Add initial V8 bindings for WebGL
https://bugs.webkit.org/show_bug.cgi?id=29664

  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8CanvasArrayBufferCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8CanvasArrayCustom.h: Added. (WebCore::constructCanvasArray):
  • bindings/v8/custom/V8CanvasByteArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8CanvasFloatArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8CanvasIntArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8CanvasRenderingContext3DCustom.cpp: Added. (WebCore::jsArrayToFloatArray): (WebCore::jsArrayToIntArray): (WebCore::CALLBACK_FUNC_DECL): (WebCore::): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
  • bindings/v8/custom/V8CanvasShortArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8CanvasUnsignedByteArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8CanvasUnsignedIntArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8CanvasUnsignedShortArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • platform/graphics/GraphicsContext3D.h:
18:45 Changeset [48780] by jorlow@chromium.org

JavaScriptCore: This is breaking Chromium try bots, so I'm counting this as a build fix.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-25
Add more svn:ignore exceptions. On different platforms, these files are
generated with different case for JavaScriptCore. Also there are some
wtf project files that get built apparently.

WebCore: This is breaking Chromium try bots, so I'm counting this as a build fix.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-25
Add more svn:ignore exceptions. On different platforms, these files are
generated with different case for WebCore.

  • WebCore.gyp: Changed property svn:ignore.
17:57 Changeset [48779] by adachan@apple.com

Build fix.

17:21 Changeset [48778] by ap@apple.com

Reverting r48767, as it broke Windows build in a non-trivial way.

16:18 Changeset [48777] by agl@chromium.org

2009-09-24 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

Add a gyp variable to allow building a debug webcore without debug
symbols. This allows for faster compile, link, and gdb times.

https://bugs.webkit.org/show_bug.cgi?id=29721

No new tests, build config change.

  • WebCore.gyp/WebCore.gyp:
16:11 Changeset [48776] by darin@chromium.org

2009-09-25 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

Declare RegisteredEventListener as a class instead of a struct.
This fixes a warning in the Chromium build.

  • dom/RegisteredEventListener.h:
16:07 Changeset [48775] by mitz@apple.com

WebCore: WebCore part of
<rdar://problem/7211635> 2 byte characters are displayed as garbaged
<rdar://problem/7212626> garbled/gibberish text (off-by-one)

Reviewed by Jon Honeycutt.

When the Windows Fonts directory contains more than one font file for a
given font name, which of the fonts gets assigned to the name in the
Core Graphics font database was determined arbitrarily and did not
always match the font GDI used for the same font name. The mismatch
caused character-to-glyph mapping to use one font and glyph rendering to
use another.

The fix is to update the Core Graphics font database from the registry
entries (that reflect the name-to-font mapping that GDI uses) after
populating it with the result of scanning the Fonts directory. As a
consequence, the directory needs to be scanned at startup every time the
registry key changes, so the last value of the registry key is kept
in the property list on disk so that it could be compared to the current
value on startup.

  • platform/graphics/win/FontDatabase.cpp:

(WebCore::populateFontDatabaseFromPlist): Now takes a property list as
a parameter and avoids round-tripping through XML by calling
wkAddFontsFromPlist() instead of wkAddFontsFromPlistRepresentation().
(WebCore::fontFilenamesFromRegistryKey):
(WebCore::cgFontDBKey):
(WebCore::writeFontDatabaseToPlist): Now takes the CG font DB property
list and a property list with the font filenames from the registry and
writes a dictionary with those property lists as values.
(WebCore::fontFilenamesFromRegistry): Added. Returns an array with the
values in the HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Fonts
registry key.
(WebCore::populateFontDatabase): Changed to read the contents of the
Fonts registry key and compare it with the last-saved value from the
property list, and to call wkAddFontsFromRegistry() after populating the
CG font DB from the file system. Uses wkCreateFontsPlist() instead of
wkCreateFontsPlistRepresentation() to avoid round-tripping through XML.

WebKitLibraries: WebKitSystemInterface changes for
<rdar://problem/7211635> 2 byte characters are displayed as garbaged
<rdar://problem/7212626> garbled/gibberish text (off-by-one)

Reviewed by Adam Roben.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h: Added

wkAddFontsFromPlistRepresentation() and replaced
wkCreateFontsPlistRepresentation() with wkCreateFontsPlist() and
wkAddFontsFromPlistRepresentation() with wkAddFontsFromPlist().

  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
15:26 Changeset [48774] by ggaren@apple.com

JavaScriptCore: Inlined some object creation code, including lexicalGlobalObject access
https://bugs.webkit.org/show_bug.cgi?id=29750

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-25
Reviewed by Darin Adler.

SunSpider says 0.5% faster.

0.8% speedup on bench-alloc-nonretained.js.
2.5% speedup on v8-splay.js.

  • interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):

  • interpreter/CallFrame.h:

(JSC::ExecState::lexicalGlobalObject):
(JSC::ExecState::globalThisValue):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

  • runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::print):

  • runtime/ScopeChain.h:

(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::~ScopeChainNode):
(JSC::ScopeChainNode::push):
(JSC::ScopeChain::ScopeChain):
(JSC::ScopeChain::globalObject): Added a globalObject data member to ScopeChainNode.
Replaced accessor function for globalObject() with data member. Replaced
globalThisObject() accessor with direct access to globalThis, to match.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSGlobalObject.h: Inlined array and object construction.

WebCore: Inlined some object creation code, including lexicalGlobalObject access
https://bugs.webkit.org/show_bug.cgi?id=29750

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-25
Reviewed by Darin Adler.

  • bindings/js/JSInspectorBackendCustom.cpp:

(WebCore::JSInspectorBackend::currentCallFrame):

  • inspector/JavaScriptDebugServer.cpp:

(WebCore::JavaScriptDebugServer::hasBreakpoint): Updated for JavaScriptCore
API changes.

15:24 Changeset [48773] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=24399
Make @import work in user stylesheets. The first bug was that the URL wasn't being set on the
user sheets themselves, so relative @import URLs couldn't resolve properly. The second bug
was that the loads would be denied. This is fixed by using the requestUserCSSStyleSheet method
instead of the normal request method. In order to know when to do this, CSSStyleSheets now have
a propagated boolean, m_isUserStyleSheet, that lets them know if they are user stylesheets or not.

Reviewed by Anders Carlsson.

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::insertedIntoParent):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::CSSStyleSheet):

  • css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::setIsUserStyleSheet):
(WebCore::CSSStyleSheet::isUserStyleSheet):

  • dom/Document.cpp:

(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):

15:02 Changeset [48772] by ddkilzer@apple.com
<http://webkit.org/b/29718> mark-bug-fixed: add -uupdate-only switch

Reviewed by Eric Seidel.

  • Scripts/mark-bug-fixed:
(MarkBugFixed.init): Added -uupdate-only switch to list

of parse options.

(MarkBugFixed.main): When -uupdate-only is specified, add a

comment to the bug without marking it Resolved/Fixed.

15:01 Changeset [48771] by simon.fraser@apple.com

2009-09-25 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Crash with hardware accelerated rotation of a PDF image in a data URL
<rdar://problem/7250378>

PDF images don't return a color space from CGImageGetColorSpace(),
so we need to null-check the return value before use.

Test: compositing/color-matching/pdf-image-match.html

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToImage):
14:40 Changeset [48770] by darin@apple.com

Speed up access to history items by caching date computation.

Patch by Darin Adler <darin@apple.com> on 2009-09-25
Reviewed by Steve Falkenburg.

  • History/WebHistory.mm:

(getDayBoundaries): Refactored from timeIntervalForBeginningOfDay.
Returns the beginning of the day that the passed time is within and
the beginning of the next day.
(beginningOfDay): Added. Uses getDayBoundaries so it can be fast for
multiple dates within the same day, which is the common case.
(dateKey): Added. Calls beginningOfDay and converts to an integer.
(WebHistory::findKey): Changed to call dateKey instead of
timeIntervalForBeginningOfDay.

14:08 Changeset [48769] by darin@apple.com

Null-deref when first access to an Attr node is after its Element is destroyed
https://bugs.webkit.org/show_bug.cgi?id=29748

Patch by Darin Adler <darin@apple.com> on 2009-09-25
Reviewed by Geoffrey Garen.

WebCore:

Test: fast/dom/Attr/access-after-element-destruction.html

  • bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::markChildren): Added. Keeps the ownerElement alive as
long as the Attr is alive.

  • bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::markChildren): Added. Keeps the Element alive as
long as the NamedNodeMap is alive.

  • dom/Attr.idl: Added CustomMarkFunction attribute.
  • dom/NamedAttrMap.cpp:

(WebCore::NamedNodeMap::getAttributeItem): Tweaked formatting.
(WebCore::NamedNodeMap::detachFromElement): Call clearAttributes so we don't
have attributes hanging around that might need an Attr node created; that way
we won't crash with a null-dereference trying to deal with one of them. This
can't happen when working with JavaScript since the Element will be kept
alive due to the change above.
(WebCore::NamedNodeMap::addAttribute): Fix function name in comment.
(WebCore::NamedNodeMap::removeAttribute): Removed unneeded "+ 1" and added
missing braces.

  • dom/NamedAttrMap.h: Made the element function public so it can be used by

the JavaScript binding to keep the Element alive.

  • dom/NamedNodeMap.idl: Added CustomMarkFunction attribute.

LayoutTests:

  • fast/dom/Attr/access-after-element-destruction-expected.txt: Added.
  • fast/dom/Attr/access-after-element-destruction.html: Added.
  • fast/dom/Attr/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Node/script-tests/TEMPLATE.html.
  • fast/dom/Attr/script-tests/access-after-element-destruction.js: Added.
14:07 Changeset [48768] by darin@apple.com
  • Scripts/prepare-ChangeLog: Leave files from the script-tests directory

out, just as we do for the resources directory.

Reviewed by Geoffrey Garen.

13:44 Changeset [48767] by ap@apple.com

Reviewed by Darin Adler and Sam Weinig.

Onclick not fired for an element copied with cloneContents() or cloneNode()
https://bugs.webkit.org/show_bug.cgi?id=25130

The change here is that JS event listeners don't keep a reference to a global object from
where they were created, and instead take it as a parameter when parsing source code. Also,
the listener creation won't fail just because it happens for an element in a frameless
document.
Thus, moving nodes between documents no longer results in having incorrect registered
lazy event listeners on them.

Tests: fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html

fast/events/attribute-listener-cloned-from-frameless-doc-context.html
fast/events/attribute-listener-cloned-from-frameless-doc.xhtml
fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html
fast/events/attribute-listener-extracted-from-frameless-doc-context.html

  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): Don't take a reference to JSDOMGlobalObject. (WebCore::JSEventListener::jsFunction): Take ScriptExecutionContext as a parameter for getting to JSDOMGlobalObject. It's not used in base class, but is in JSLazyEventListner. (WebCore::JSEventListener::markJSFunction): Don't mark the global object. (WebCore::JSEventListener::handleEvent): Get global object from ScriptExecutionContext. (WebCore::JSEventListener::reportError): Ditto.
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::create): Don't keep a reference to JSDOMGlobalObject.
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Listener creation was split between this function and ScriptEventListener; moved it here, as JS global object can be different now.
  • bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::create): Keep source URL, which can not be determined at parsing time.
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Moved code for listener creation to JSLazyEventListener. XSSAuditor code remains here, because tests expect that errors are logged at document parsing time, and because I don't know what other side effects moving it vould have.
  • dom/EventListener.h: handleEvent() and reportError() now take ScriptExecutionContext, because JSC needs a global context here.
  • bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::JSAbstractWorker::addEventListener): (WebCore::JSAbstractWorker::removeEventListener):
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener):
  • bindings/js/JSEventSourceCustom.cpp: (WebCore::JSEventSource::addEventListener): (WebCore::JSEventSource::removeEventListener):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  • bindings/objc/ObjCEventListener.h:
  • bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::handleEvent):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/EventTarget.cpp: (WebCore::EventTarget::fireEventListeners):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::handleEvent):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::handleEvent):
  • inspector/InspectorDOMStorageResource.h:
  • loader/ImageDocument.cpp: (WebCore::ImageEventListener::handleEvent):
  • svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::handleEvent):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::reportException): Don't pass global object to JSEventListener::create(), which no longer needs it. Note that some of these functions still have an early return for null global object, which can probably be removed in a later patch. Pass ScriptExecutionContext to EventListener methods that now need it.
13:24 Changeset [48766] by darin@apple.com

Checked in a file that was created by make-script-test-wrappers.

Patch by Darin Adler <darin@apple.com> on 2009-09-25

  • platform/gtk/editing/pasteboard/middle-click-onpaste.html: Added.
13:00 Changeset [48765] by abarth@webkit.org

2009-09-25 Adam Barth <abarth@webkit.org>

Unreviewed. Added Tony to committers.py because he's a
committer now.

  • Scripts/modules/committers.py:
11:55 Changeset [48764] by adele@apple.com

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29740
<rdar://problem/7168738> Gmail: After changing a foreground text color, pressing return doesn't apply background to new line

Patch by Enrica Casucci <enrica@apple.com> on 2009-09-25
Reviewed by Darin Adler, Dan Bernstein, Adele Peterson, and others.

Change the way style is preserved when inserting a new paragraph.
The original code handled insertion at the beginning and at the end of a paragraph as special
cases. The newly created paragraph contained a set of nodes generated starting from the
computed style of the insertion node. This approach has two problems:

  1. if the insertion node has a non opaque background color and one of the parent element did have

a solid background color the new paragraph did not have the element with the solid color in the tree.

  1. in some circumstances it generated more markup than the original paragraph had (a span with bold, italic,

background color and some font attribute was being reproduced as span + bold + italic + font as separate tags.
The new approach is to recreate in the new paragraph the same hierarchy of nodes found in the
paragraph where the insertion point is.

Test: editing/inserting/insert-bg-font.html

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::getAncestorsInsideBlock): retrieves the list of all the ancestors
between the insert node and the outer block.
(WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock): uses the list of ancestors to recreate
in the new paragraph the same element hierarchy present in the starting paragraph.
(WebCore::InsertParagraphSeparatorCommand::doApply): changed the code to handle the general case of insertion
in the middle of the paragraph to use the new methods. Changed the handling of the insertion at the beginning and
at the end of the paragraph to use the new methods instead of applying the calculated style.

  • editing/InsertParagraphSeparatorCommand.h: added methods getAncestorsInsideBlock and cloneHierarchyUnderNewBlock.

LayoutTests: Updated the expected results to reflect the changes in the way the new paragraph
is created and added test case for https://bugs.webkit.org/show_bug.cgi?id=29740
<rdar://problem/7168738> Gmail: After changing a foreground text color, pressing return doesn't apply background to new line

Patch by Enrica Casucci <enrica@apple.com> on 2009-09-25
Reviewed by Darin Adler, Dan Bernstein, Adele Peterson, and others.

  • editing/inserting/insert-bg-font.html: Added.
  • platform/mac/editing/inserting/insert-bg-font-expected.txt: Added.
  • platform/mac/editing/pasteboard/5478250-expected.txt:
11:36 Changeset [48763] by eric@webkit.org

2009-09-25 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Content-type parameters not taken into account when building form-data
https://bugs.webkit.org/show_bug.cgi?id=28970

existing manual test case extended with new tests

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshFormData): (WebInspector.ResourceView.prototype._refreshParms):
  • manual-tests/inspector/display-form-data.html:
11:27 Changeset [48762] by eric@webkit.org

2009-09-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should auto-retry patches which fail to commit due to out of date files
https://bugs.webkit.org/show_bug.cgi?id=28316

  • Scripts/bugzilla-tool:
    • Handle new CheckoutNeedsUpdate exception.
  • Scripts/modules/logging_unittest.py:
    • Call the ScriptError constructor correctly (this test had regressed).
  • Scripts/modules/scm.py:
    • Added the ability to define custom error handlers for run_command and added a commit_error_handler which throws CheckoutNeedsUpdate instead of ScriptError.
    • Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
  • Scripts/modules/scm_unittest.py:
    • Added tests of new error handlers.
10:53 Changeset [48761] by eric@webkit.org

2009-09-25 Yuan Song <song.yuan@ericsson.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=14566

Add test "invalid-domain-change-throws-exception.html" to ensure a SECURITY_ERR exception is raised if an attempt is made to change document.domain to an invalid value. In the existing test case "basic-textareas.html", fix the faulty behavior of setting document.domain to invalid value, and replace the data URL to a file URL that points to "basic-textareas-standards.html" in order to make "basic-textareas.html" runnable in a browser.

  • fast/forms/basic-textareas.html:
  • fast/forms/resources/basic-textareas-standards.html: Added.
  • fast/js/invalid-domain-change-throws-exception-expected.txt: Added.
  • fast/js/invalid-domain-change-throws-exception.html: Added.
  • fast/js/resources/invalid-domain-change-throws-exception.js: Added.

2009-09-25 Yuan Song <song.yuan@ericsson.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=14566

Raise SECURITY_ERR exception if an attempt is made to change document.domain to an invalid value.

Test: fast/js/invalid-domain-change-throws-exception.html

  • dom/Document.cpp: (WebCore::Document::setDomain):
  • dom/Document.h:
  • dom/Document.idl:
10:40 Changeset [48760] by eric@webkit.org

2009-09-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should give better feedback when failing a patch
https://bugs.webkit.org/show_bug.cgi?id=29316

  • Scripts/bugzilla-tool:
    • Update ScriptError uses to the new constructor format.
    • Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output so that we can print to both stdout as well as an output buffer for error reporting.
    • Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
    • Use e.message_with_output() when failing a patch (this is the real fix here). I also removed use of "This patch will require manual commit." as that's not always true.
    • Add missing word "bug" from log message.
  • Scripts/modules/scm.py:
    • Make ScriptError save a bunch more data so that error messages can be nicer.
    • Update ScriptError callers.
10:31 BuildingOnWindows edited by dbates@webkit.org
Changed title of subsection to reflect fix for linker problems (diff)
09:36 Changeset [48759] by eric@webkit.org

2009-09-25 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703

Test a strange error condition after clearing a setInterval
timer. The key point is not to crash on this test.

  • fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Added.
  • fast/dom/timer-clear-interval-in-handler-and-generate-error.html: Added.

2009-09-25 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703

When setTimeout is called with a string argument in an isolated
world, we now compile the string in the isolated world.

Last time we tried this change, we got a lot of crashes. This
time we're using a fresh local handle as our context to avoid
trouble if the peristent handle gets disposed before we leave
the context.

Test: fast/dom/timer-clear-interval-in-handler-and-generate-error.html

  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
09:30 Changeset [48758] by eric@webkit.org

2009-09-25 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Make tst_qwebframe work if Qt built without SSL support
https://bugs.webkit.org/show_bug.cgi?id=29735

  • tests/qwebframe/tst_qwebframe.cpp: Missing #ifndef blocks added.
09:23 Changeset [48757] by eric@webkit.org

2009-09-25 Paul Godavari <paul@chromium.org>

Reviewed by Darin Fisher.

Fix a regression in Mac Chromium popup menus, where the user's
selection was ignored and the popup became unresponsive.
https://bugs.webkit.org/show_bug.cgi?id=29726

The fix is to notify the popup's client that the popup was hidden,
even if the popup has no parent.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::hidePopup):
09:10 Changeset [48756] by eric@webkit.org

2009-09-25 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Gavin Barraclough.

Add ARM version detection rules for Symbian
https://bugs.webkit.org/show_bug.cgi?id=29715

  • wtf/Platform.h:
08:47 Changeset [48755] by pfeldman@chromium.org

2009-09-25 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Dan Bernstein.

Enable Pasteboard::writePlainText for Chromium and fix code style nits.
https://bugs.webkit.org/show_bug.cgi?id=29734

  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writePlainText):
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writePlainText):
08:32 Changeset [48754] by aroben@apple.com

Add SPI to invalidate a WebView's backing store

This is useful in conjunction with
IWebUIDelegatePrivate2::drawBackground. This provides a way for the UI
delegate to force WebView to get its background redrawn.

Fixes <http://webkit.org/b/29737> Need SPI to invalidate a WebView's
backing store

Reviewed by Anders Carlsson.

  • Interfaces/IWebViewPrivate.idl: Added invalidateBackingStore.
  • WebView.cpp:

(WebView::invalidateBackingStore): If rect is 0, invalidate our whole
client rect. Otherwise invalidate the intersection of rect with our
client rect.

  • WebView.h:
07:01 Changeset [48753] by kov@webkit.org

2009-09-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Pop down the context menu when the page transitions to committed,
to avoid keeping a context menu out of context.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (destroy_menu_cb): (webkit_web_view_forward_context_menu_event):
01:54 Changeset [48752] by hausmann@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=28876
[Qt] reduce peak memory consumption of text decoding.

Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-09-25
Reviewed by Ariya Hidayat.

Chop large input buffer into small buffers to reduce peak memory
during decoding.

  • platform/text/qt/TextCodecQt.cpp:

(WebCore::TextCodecQt::decode):

01:53 Changeset [48751] by hausmann@webkit.org

[Qt] Update QWebElement API to remove script related methods.
QWebElement::evaluateScript is the only one kept, these are
removed to postpone most of the QtWebKit<->JavaScript API design
after 4.6.
https://bugs.webkit.org/show_bug.cgi?id=29708

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-24
Reviewed by Simon Hausmann.

  • Api/qwebelement.cpp:
  • Api/qwebelement.h:

Methods removed:

  • QWebElement::callFunction
  • QWebElement::functions
  • QWebElement::scriptableProperty
  • QWebElement::setScriptableProperty
  • QWebElement::scriptableProperties
  • tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::evaluateScript):

01:19 Changeset [48750] by hausmann@webkit.org

[Qt] Rename QWebElement::evaluateScript
to QWebElement::evaluateJavaScript.
https://bugs.webkit.org/show_bug.cgi?id=29709

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-25
Reviewed by Simon Hausmann.

  • Api/qwebelement.cpp:

(QWebElement::evaluateJavaScript):

  • Api/qwebelement.h:
  • tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::evaluateJavaScript):

01:18 Changeset [48749] by hausmann@webkit.org

[Qt] Update the stypeProperty API of QWebElement.
https://bugs.webkit.org/show_bug.cgi?id=29711

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-25
Reviewed by Simon Hausmann.

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):

  • Merge the stypeProperty and the computedStyleProperty methods
  • Remove the default value for the style resolving enum
  • Rename ResolveRule to StyleResolveStrategy

(QWebElement::setStyleProperty):

  • Remove the priority argument since it is possible to control the behaviour by adding !important or removing in the value.
  • Api/qwebelement.h:
  • tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::style):
(tst_QWebElement::computedStyle):

  • tests/qwebframe/tst_qwebframe.cpp:

09/24/09:

23:53 Changeset [48748] by jhoneycutt@apple.com

Add a mechanism for automatically halting plug-ins.

Reviewed by Oliver Hunt and Alice Liu.

WebCore:

  • GNUmakefile.am:
  • WebCore.base.exp:

Update export of Page constructor.

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:

Add PluginHalter.{h,cpp}, PluginHalterClient.h, and
HaltablePlugin.h.

  • WebCore.xcodeproj/project.pbxproj:

Add files to Mac project.

  • loader/EmptyClients.h:

Added an empty PluginHalterClient.
(WebCore::EmptyPluginHalterClient::shouldHaltPlugin):
Return false.

  • page/PluginHalter.cpp: Added.

(WebCore::PluginHalter::PluginHalter):
(WebCore::PluginHalter::didStartPlugin):
Add the object to the plug-in set. If this is the only item in the set,
set m_oldestStartTime to this object's time, and start the timer.
(WebCore::PluginHalter::didStopPlugin):
Remove the plug-in from the set.
(WebCore::PluginHalter::timerFired):
Find the cut-off time as the current time minus the allowed run time;
plug-ins older than this may be halted. Iterate over the plug-ins. Find
the object with the oldest start time that is too young to be halted;
we'll use its start time to set the timer's next fire time. For all
plug-ins that are candidates to be halted, call the
PluginHalterClient's shouldHaltPlugin(). If this function returns true,
call the plug-in's halt() function. Remove these objects from the set
of tracked plug-ins. Call startTimerIfNecessary() to restart the timer.
(WebCore::PluginHalter::startTimerIfNecessary):
If the timer is set to fire, or the set of tracked plug-ins is empty,
return early. Set the timer to fire after the oldest plug-in has run
for the allowed run time.

  • page/PluginHalter.h: Added.

(WebCore::PluginHalter::setPluginAllowedRunTime):

  • page/PluginHalterClient.h: Added.

(WebCore::PluginHalterClient::~PluginHalterClient)

  • page/Page.cpp:

(WebCore::Page::Page):
Initialize m_pluginHalterClient. Call pluginHalterEnabledStateChanged()
to create the PluginHalter if necessary.
(WebCore::Page::pluginHalterEnabledStateChanged):
If plug-in halting is enabled, create the PluginHalter. If it is
disabled, clear it.
(WebCore::Page::pluginAllowedRunTimeChanged):
If there is a plug-in halter, call its setPluginAllowedRunTime().
(WebCore::Page::didStartPlugin):
If there is a plug-in halter, call its didStartPlugin().
(WebCore::Page::didStopPlugin):
If there is a plug-in halter, call its didStopPlugin().

  • page/Page.h:

Add a parameter to the Page constructor for the PluginHalterClient.
Added declarations for didStartPlugin() and didStopPlugin(), which are
called when HaltablePlugins are added to or removed from the page. Adds
pluginAllowedRunTimeChanged() and pluginHalterEnabledStateChanged() to
notify the Page when these settings are changed. Added members to hold
the PluginHalter and the PluginHalterClient.

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setPluginHalterEnabled):
If the enabled state has changed, call the Page's
pluginHalterEnabledStateChanged().
(WebCore::Settings::setPluginAllowedRunTime):
Call the Page's pluginAllowedRunTimeChanged().

  • page/Settings.h:

(WebCore::Settings::pluginHalterEnabled):
(WebCore::Settings::pluginAllowedRunTime):

  • page/HaltablePlugin.h: Added. Defines an interface for plug-ins that

can be automatically halted.
(WebCore::HaltablePlugin::~HaltablePlugin)

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):
Pass a dummy PluginHalterClient.

WebKit/gtk/:

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):
Pass 0 for new Page constructor argument.

WebKit/mac/:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
Pass 0 for new Page constructor argument.

WebKit/qt/:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
Pass 0 for new Page constructor argument.

WebKit/win:

  • Interfaces/IWebPluginHalterDelegate.idl: Added. Defines an interface

for a delegate that determines whether plug-ins should be halted.

  • Interfaces/IWebPreferencesPrivate.idl:

Declare functions to get and set the enabled state of the plug-in
halter and the plug-in allowed run time.

  • Interfaces/IWebViewPrivate.idl:

Declare functions to get and set the IWebPluginHalterDelegate.

  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebPluginHalterClient.cpp: Added.

(WebPluginHalterClient::WebPluginHalterClient):
(WebPluginHalterClient::shouldHaltPlugin):
Get the IWebPluginHalterDelegate for the WebView. Create a WebKit
DOMNode for the WebCore Node. Call the delegate's shouldHaltPlugin().
If the call fails, return false. Otherwise, return the result of the
call.

  • WebCoreSupport/WebPluginHalterClient.h: Added.
  • WebKit.vcproj/Interfaces.vcproj:

Add IWebPluginHalterDelegate.idl.

  • WebKit.vcproj/WebKit.vcproj:

Add WebPluginHalterClient.{h,cpp}.

  • WebPreferenceKeysPrivate.h:

Define WebKitPluginHalterEnabledPreferenceKey and
WebKitPluginAllowedRunTimePreferenceKey.

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
Leave plug-in halting disabled by default. Set the default value for
the plug-in allowed run time to the max value of an unsigned int.
(WebPreferences::setPluginHalterEnabled):
(WebPreferences::pluginHalterEnabled):
(WebPreferences::setPluginAllowedRunTime):
(WebPreferences::pluginAllowedRunTime):

  • WebPreferences.h:
  • WebView.cpp:

(WebView::close):
Clear the IWebPluginHalterDelegate.
(WebView::initWithFrame):
Pass a WebPluginHalterClient when creating the Page.
(WebView::notifyPreferencesChanged):
Set the new settings when the preferences changed notification is
received.
(WebView::setPluginHalterDelegate):
(WebView::pluginHalterDelegate):

  • WebView.h:

Declare overrides of setPluginHalterDelegate() and
pluginHalterDelegate(). Added a member to track the
IWebPluginHalterDelegate.

23:26 Changeset [48747] by xan@webkit.org

2009-09-24 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark "Do It!" Rowe.

Some GCC versions don't like C++-style comments in preprocessor
directives, change to C-style to shut them up.

  • wtf/Platform.h:
20:53 Changeset [48746] by simon.fraser@apple.com

2009-09-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

REGRESSION: webkit-transform scale no longer works properly in nightly build
https://bugs.webkit.org/show_bug.cgi?id=29730

When the initial or final state of a scale animation does not specify a transform,
use a default scale of 1, rather than zero.

Test: compositing/transitions/scale-transition-no-start.html

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::getTransformFunctionValue):
19:45 Changeset [48745] by atwilson@chromium.org

WebCore: isEnabled switch for notifications (experimental) in Page Settings
https://bugs.webkit.org/show_bug.cgi?id=28930

Patch by John Gregg <johnnyg@google.com> on 2009-09-14
Reviewed by Eric Seidel.

Adds a run-time flag in Settings object that controls whether
to expose desktop notifications.

No new test, but test code also modified to set this preference.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitNotifications): check preference before returning notifications object

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setExperimentalNotificationsEnabled):

  • page/Settings.h:

(WebCore::Settings::experimentalNotificationsEnabled):

WebKit/mac: isEnabled switch for notifications (experimental) in Page Settings
https://bugs.webkit.org/show_bug.cgi?id=28930

Patch by John Gregg <johnnyg@google.com> on 2009-09-14
Reviewed by Eric Seidel.

Adds support for the experimentalNotificationsEnabled flag in Settings
through WebPreferencesPrivate.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences experimentalNotificationsEnabled]):
(-[WebPreferences setExperimentalNotificationsEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

WebKit/win: Enable switch for notifications (experimental) in Page Settings
https://bugs.webkit.org/show_bug.cgi?id=28930

Patch by John Gregg <johnnyg@google.com> on 2009-09-14
Reviewed by Eric Seidel.

Adds support for the experimentalNotificationsEnabled flag in Settings through
WebPreferencesPrivate interface. Also cleans up some issues accessing the
notification delegate through DumpRenderTree.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp:

(WebDesktopNotificationsDelegate::hasNotificationDelegate):
(WebDesktopNotificationsDelegate::notificationDelegate):

  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setExperimentalNotificationsEnabled):
(WebPreferences::experimentalNotificationsEnabled):

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged):

WebKitTools: Enable switch for notifications (experimental) in Page Settings
https://bugs.webkit.org/show_bug.cgi?id=28930

Patch by John Gregg <johnnyg@google.com> on 2009-09-14
Reviewed by Eric Seidel.

Now that desktop notifications are controlled by run-time switch,
set that switch to true for DumpRenderTree.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::QueryInterface):

19:40 Changeset [48744] by oliver@apple.com

Division is needlessly slow in 64-bit
https://bugs.webkit.org/show_bug.cgi?id=29723

Reviewed by Gavin Barraclough.

Add codegen for op_div on x86-64

19:25 Changeset [48743] by mitz@apple.com

WebCore: Fix <rdar://problem/7162000> Crash while trying to
calculate the horizontal position of image

Reviewed by Sam Weinig.

Test: fast/inline-block/relative-positioned-rtl-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::calcAbsoluteHorizontalReplaced): Corrected an
isInline() test to isRenderInline(). This is similar to r41259.

LayoutTests: Test for <rdar://problem/7162000> Crash while trying to
calculate the horizontal position of image

Reviewed by Sam Weinig.

  • fast/inline-block/relative-positioned-rtl-crash-expected.txt: Added.
  • fast/inline-block/relative-positioned-rtl-crash.html: Added.
19:16 Changeset [48742] by jberlin@webkit.org

Fix expanding profile call stacks being broken after sorting.
https://bugs.webkit.org/show_bug.cgi?id=26423

Patch by Jessie Berlin <jberlin@webkit.org> on 2009-09-24
Reviewed by Timothy Hatcher.

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.sort):
Set shouldRefreshChildren to true on collapsed nodes with children so that expanding it
causes the children to be placed in the right positions.

18:13 Changeset [48741] by kevino@webkit.org

wx build fix. SnowLeopard fixes for Mac dependencies.

17:18 Changeset [48740] by ggaren@apple.com

Fixed sudden termination console spew due to too many calls to
enableSuddenTermination.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24
Reviewed by Stephanie Lewis.

<rdar://problem/7063125> 10A410: Safari logging enableSuddenTermination errors

  • page/DOMWindow.cpp:

(WebCore::removeUnloadEventListener):
(WebCore::removeAllUnloadEventListeners):
(WebCore::removeBeforeUnloadEventListener):
(WebCore::removeAllBeforeUnloadEventListeners): Only
enableSuddenTermination if the set of listeners is empty *and* this
window was in the set. Otherwise, a no-op will cause us to enableSuddenTermination.

16:44 Changeset [48739] by eric@webkit.org

2009-09-24 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Alexey Proskuryakov.

WebKit returns "" instead of null when getting
inexistent, forbidden or invalidly named headers.
https://bugs.webkit.org/show_bug.cgi?id=29140

  • http/tests/xmlhttprequest/get-dangerous-headers.html: Updated to test for null instead of ""
  • http/tests/xmlhttprequest/getResponseHeader-expected.txt:
  • http/tests/xmlhttprequest/getResponseHeader.html: Extended to also test for headers that should return null.
  • http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader.html: Removed. getResponseHeader.html now covers this case as well.

2009-09-24 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Alexey Proskuryakov.

WebKit returns "" instead of null when getting
inexistent, forbidden or invalidly named headers.
https://bugs.webkit.org/show_bug.cgi?id=29140

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseHeader): Changed to return null as it should according to the spec.
15:34 Changeset [48738] by jorlow@chromium.org

JavaScriptCore: Add GYP generated files to svn:ignore
https://bugs.webkit.org/show_bug.cgi?id=29724

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-24
Reviewed by Dimitri Glazkov.

Adding the following files to the svn:ignore list (all in the
JavaScriptCore/JavaScriptCore.gyp directory)

JavaScriptCore.xcodeproj
JavaScriptCore.sln
JavaScriptCore.vcproj
JavaScriptCore_Debug.rules
JavaScriptCore_Release.rules
JavaScriptCore_Release - no tcmalloc.rules
JavaScriptCore_Purify.rules
JavaScriptCore.mk
JavaScriptCore_Debug_rules.mk
JavaScriptCore_Release_rules.mk
JavaScriptCore_Release - no tcmalloc_rules.mk
JavaScriptCore_Purify_rules.mk
JavaScriptCore.scons
JavaScriptCore_main.scons

WebCore: Add GYP generated files to svn:ignore
https://bugs.webkit.org/show_bug.cgi?id=29724

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-24
Reviewed by Dimitri Glazkov.

Adding the following files to the svn:ignore list (all in the
WebCore/WebCore.gyp directory)

WebCore.xcodeproj
WebCore.sln
WebCore.vcproj
WebCore_Debug.rules
WebCore_Release.rules
WebCore_Release - no tcmalloc.rules
WebCore_Purify.rules
WebCore.mk
WebCore_Debug_rules.mk
WebCore_Release_rules.mk
WebCore_Release - no tcmalloc_rules.mk
WebCore_Purify_rules.mk
WebCore.scons
WebCore_main.scons

  • WebCore.gyp: Changed property svn:ignore.
15:24 Changeset [48737] by kov@webkit.org

Unreviewed Mac build fix

15:00 Changeset [48736] by eric@webkit.org

2009-09-24 Yong Li <yong.li@torchmobile.com>

Reviewed by Adam Barth.

Replace platform-dependent code with WTF::currentTime()
https://bugs.webkit.org/show_bug.cgi?id=29148

  • jsc.cpp: (StopWatch::start): (StopWatch::stop): (StopWatch::getElapsedMS):
  • runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
14:58 Changeset [48735] by kov@webkit.org

Implement correct horizontal scrollbar behavior for GTK+

WebCore

2009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Oliver Hunt.

Implement correct horizontal scrollbar behavior for GTK+ also on
styled scrollbars.

https://bugs.webkit.org/show_bug.cgi?id=29348
[Gtk] Scrollwheel on horizontal scrollbars should slide horizontally

Test: platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent): on GTK+, when using the wheel with the pointer on the horizontal scrollbar, scroll horizontally;
  • platform/PlatformWheelEvent.h:
  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::swapOrientation): allow adding a vertical scroll to the horizontal one;

WebKitTools

2009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Oliver Hunt.

Add support for DRT to send mouse wheel events.

https://bugs.webkit.org/show_bug.cgi?id=29348
[Gtk] Scrollwheel on horizontal scrollbars should slide horizontally

  • DumpRenderTree/gtk/EventSender.cpp: (mouseWheelToCallback):

LayoutTests

2009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Oliver Hunt.

Test for correct wheel scrolling behavior.

https://bugs.webkit.org/show_bug.cgi?id=29348
[Gtk] Scrollwheel on horizontal scrollbars should slide horizontally

  • platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html: Added.
  • platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll-expected.txt: Added.
14:36 Changeset [48734] by jorlow@chromium.org

2009-09-24 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Eric Seidel.

StorageNamespace::storageArea() should take in a PassRefPtr<StorageOrigin>
https://bugs.webkit.org/show_bug.cgi?id=29290

Modified StorageNamespace::storageArea() to take in a PassRefPtr<StorageOrigin>
per http://webkit.org/coding/RefPtr.html

No behavior change, so no tests.

  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::storageArea):
  • storage/StorageNamespaceImpl.h:
14:25 Changeset [48733] by mrowe@apple.com

<rdar://problem/7215058> FastMalloc scavenging thread should be named

Reviewed by Sam Weinig.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::scavengerThread): Set the thread name.

  • wtf/Platform.h: Move the knowledge of whether pthread_setname_np exists to here as HAVE(PTHREAD_SETNAME_NP).
  • wtf/ThreadingPthreads.cpp:

(WTF::setThreadNameInternal): Use HAVE(PTHREAD_SETNAME_NP).

14:18 Changeset [48732] by ggaren@apple.com

JavaScriptCore: Renamed clear to removeAll, as suggested by Darin Adler.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24
Reviewed by Sam Weinig.

  • wtf/HashCountedSet.h:

(WTF::::removeAll):

WebCore: Added back enable/disableSuddenTermination() functionality I accidentally
removed in my last patch.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24
Reviewed by Sam Weinig.

  • page/DOMWindow.cpp:

(WebCore::addUnloadEventListener):
(WebCore::removeUnloadEventListener):
(WebCore::removeAllUnloadEventListeners):
(WebCore::addBeforeUnloadEventListener):
(WebCore::removeBeforeUnloadEventListener):
(WebCore::removeAllBeforeUnloadEventListeners):
(WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

14:15 Changeset [48731] by mrowe@apple.com

Fix FastMalloc to build with assertions enabled.

Reviewed by Gavin Barraclough.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_Central_FreeList::ReleaseToSpans):

  • wtf/TCSpinLock.h:

(TCMalloc_SpinLock::IsHeld):

13:40 Changeset [48730] by eric@webkit.org

2009-09-17 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

commit-queue needs web-based status reporting
https://bugs.webkit.org/show_bug.cgi?id=29307

Add a first-pass web-based status for the commit-queue.
The bot is currently reachable at:
http://webkit-commit-queue.appspot.com/

  • CommitQueueStatus/app.yaml: Added.
    • Application description file required by App Engine.
  • CommitQueueStatus/filters/init.py: Added.
    • Required by python to treat 'filters' as a module.
  • CommitQueueStatus/filters/webkit_extras.py: Added.
    • Support for turning 'bug 123' and 'patch 123' into links. This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
  • CommitQueueStatus/index.html: Added.
  • CommitQueueStatus/index.yaml: Added.
    • Some auto-generated file from app engine.
  • CommitQueueStatus/queue_status.py: Added.
    • The core logic of this bot. We could eventually split this file out into pieces.
  • CommitQueueStatus/stylesheets/main.css: Added.
    • Some basic lame-o CSS to make the page look less awful.
  • CommitQueueStatus/update_status.html: Added.
    • The form that the commit-queue (or a human) can use to update the status.
  • Scripts/bugzilla-tool:
    • Add some very basic update_status calls.
  • Scripts/modules/statusbot.py: Added.
    • Knows how to post to the CommitQueueStatus web application.
13:32 Changeset [48729] by weinig@apple.com

Don't pass -F to GCC on non-mac platforms since it is an darwin only.

Reviewed by Steve Falkenburg and Mark Rowe.

  • DerivedSources.make:
12:42 Changeset [48728] by weinig@apple.com

Fix windows build.

  • dom/Element.idl:
12:37 Changeset [48727] by ggaren@apple.com

Suggested by Darin Adler.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24
Removed some unnecessary parameter names.

  • wtf/HashCountedSet.h:
11:51 Changeset [48726] by senorblanco@chromium.org

Fix for https://bugs.webkit.org/show_bug.cgi?id=29696 ([CHROMIUM] Paths fail to render in SVG with large viewbox)

Revert the relevant parts of r47925, and implement an alternate
fix (localize the coordinate check to GraphicsContext::clipPath()).
See http://crbug.com/21174.

Reviewed by Eric Seidel.

Covered by LayoutTests/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clipPath):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(PlatformContextSkia::currentPathInLocalCoordinates):

11:18 Changeset [48725] by beidson@apple.com

Merge changes from Mozilla's FTP directory parser.
<rdar://problem/7227620> and https://bugs.webkit.org/show_bug.cgi?id=29294

Reviewed by Sam Weinig.

FTP layout tests not possible at this time.
https://bugs.webkit.org/show_bug.cgi?id=29719 tracks making them possible.

  • loader/FTPDirectoryParser.cpp:

(WebCore::ParsingFailed):
(WebCore::parseOneFTPLine):

10:55 Changeset [48724] by kov@webkit.org

WebCore

2009-09-24 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] re-enable some media tests
https://bugs.webkit.org/show_bug.cgi?id=29716

make canPlayType() return "probably" if mime-type is known
and codecs string is not empty. If codecs is empty return
"maybe".

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::supportsType):

LayoutTests

2009-09-24 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] re-enable some media tests
https://bugs.webkit.org/show_bug.cgi?id=29716

  • platform/gtk/Skipped:
10:47 Changeset [48723] by weinig@apple.com

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29703
Add a function to element to check whether it matches a CSS selector

Reviewed by Dan Bernstein.

Implement Element.webkitMatchesSelector.

  • css/CSSSelectorList.cpp:

(WebCore::forEachTagSelector):
(WebCore::forEachSelector):
(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
(WebCore::CSSSelectorList::selectorsNeedNamespaceResolution):

  • css/CSSSelectorList.h:

Moved code to iterate the CSSSelectorList and determine if any
selectors need namespace resolution from a static function in
Node.cpp to CSSSelectorList so that it can be used by webkitMatchesSelector
as well as querySelector/querySelectorAll.

  • dom/Element.cpp:

(WebCore::Element::webkitMatchesSelector):

  • dom/Element.h:
  • dom/Element.idl:

Implement the new function. Handles exceptional cases identically to
querySelector/querySelectorAll.

  • dom/Node.cpp:

(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):
Moved selectorsNeedNamespaceResolution to CSSSelectorList from here.

LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=29703
Add a function to element to check whether it matches a CSS selector

Reviewed by Dan Bernstein.

Add webkitMatchesSelector to SelectorAPI tests.

  • fast/dom/SelectorAPI/caseID-almost-strict-expected.txt:
  • fast/dom/SelectorAPI/caseID-almost-strict.html:
  • fast/dom/SelectorAPI/caseID-expected.txt:
  • fast/dom/SelectorAPI/caseID-strict-expected.txt:
  • fast/dom/SelectorAPI/caseID-strict.html:
  • fast/dom/SelectorAPI/caseID.html:
  • fast/dom/SelectorAPI/caseTag-expected.txt:
  • fast/dom/SelectorAPI/caseTag.html:
  • fast/dom/SelectorAPI/caseTagX-expected.txt:
  • fast/dom/SelectorAPI/caseTagX.xhtml:
  • fast/dom/SelectorAPI/detached-element-expected.txt:
  • fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt:
  • fast/dom/SelectorAPI/not-supported-namespace-in-selector.html:
  • fast/dom/SelectorAPI/script-tests/detached-element.js:
  • fast/dom/SelectorAPI/script-tests/undefined-null-stringify.js:
  • fast/dom/SelectorAPI/script-tests/viewless-document.js:
  • fast/dom/SelectorAPI/undefined-null-stringify-expected.txt:
  • fast/dom/SelectorAPI/viewless-document-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/script-tests/domListEnumeration.js:
10:14 Changeset [48722] by ddkilzer@apple.com
<http://webkit.org/b/29712> mark-bug-fixed: add -mcomment switch

Reviewed by Adam Roben.

  • Scripts/mark-bug-fixed:
(MarkBugFixed.init): Added -mcomment switch to list of

parse options.
(MarkBugFixed.main): When specified, prepend comment from

-mcomment command-line switch to the bug comment.
07:15 Changeset [48721] by kov@webkit.org

2009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Jan Alonzo.

[GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
https://bugs.webkit.org/show_bug.cgi?id=29693

Show the window, to be able to synthesize events correctly.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): (main):
07:11 Changeset [48720] by pfeldman@chromium.org

2009-09-24 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fixed bindings build after http://trac.webkit.org/changeset/48701
https://bugs.webkit.org/show_bug.cgi?id=29713

Got rid of isWindowEvent in function signatures:

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler): (WebCore::V8AbstractEventListener::handleEvent): (WebCore::V8AbstractEventListener::getReceiverObject):
  • bindings/v8/V8AbstractEventListener.h:
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::callListenerFunction):
  • bindings/v8/V8LazyEventListener.h:
  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent): (WebCore::V8WorkerContextEventListener::callListenerFunction): (WebCore::V8WorkerContextEventListener::getReceiverObject):
  • bindings/v8/V8WorkerContextEventListener.h:
  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::callListenerFunction):
  • bindings/v8/custom/V8CustomEventListener.h:

Switched to EventTarget methods of adding/removing listeners:

  • bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: (WebCore::toEventID): (WebCore::ACCESSOR_SETTER):
  • dom/EventTarget.h: Some functions were incorrectly marked as JSC-specific.
05:54 Changeset [48719] by xan@webkit.org

2009-09-24 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha and Jan Alonzo.
[GTK] Add WEBKIT_LOAD_ERROR status
https://bugs.webkit.org/show_bug.cgi?id=29644

Add a new load-status enum value, WEBKIT_LOAD_FAILED, emitted when
there's an error during the load process. This is needed if we
want notify::load-status to be able to handle all situations,
since WEBKIT_LOAD_FINISHED is not emitted when there's an error
and we are lacking a notification of the load being stopped.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
  • tests/testloading.c: (web_loading_fixture_setup): (load_error_status_changed_cb): (load_error_cb): (test_loading_error): (load_cancelled_cb): (stop_load): (load_cancelled_status_changed_cb): (test_loading_cancelled): (main):
  • webkit/webkitwebframe.h:
05:00 Changeset [48718] by pfeldman@chromium.org

2009-09-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Color-code watch expression errors with red.

https://bugs.webkit.org/show_bug.cgi?id=29707

  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionTreeElement.prototype.update):
  • inspector/front-end/inspector.css:
04:57 Changeset [48717] by pfeldman@chromium.org

2009-09-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Fix formatting for messages derived from resource warnings,
couple of drive-by formatting fixes.

https://bugs.webkit.org/show_bug.cgi?id=29705

  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addMessageToConsole):
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/InjectedScript.js: (InjectedScript._evaluateAndWrap):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
04:45 Changeset [48716] by pfeldman@chromium.org

2009-09-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Implement InspectorController::copyNode(id).

https://bugs.webkit.org/show_bug.cgi?id=28357

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::copyNode):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.handleCopyEvent):
03:55 Changeset [48715] by oliver@apple.com

Roll out r48712 as it is incorrect.

Reviewed by NOBODY(rollout)

03:52 Changeset [48714] by xan@webkit.org

Revert r48697, since it broke key handling notification to GTK+.

03:49 Changeset [48713] by eric@webkit.org

2009-09-24 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] GStreamer MediaPlayer is unable to correctly querry duration
https://bugs.webkit.org/show_bug.cgi?id=24639

check duration returned by gst_element_query_duration() only
when using GStreamer < 0.10.23.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration):
03:42 Changeset [48712] by eric@webkit.org

2009-09-24 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Eric Seidel.

The indices of RuntimeArray should be enumerated like for a regular array.
https://bugs.webkit.org/show_bug.cgi?id=29005

  • platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
  • platform/mac/fast/dom/wrapper-classes-objc.html:

2009-09-24 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Eric Seidel.

The indices of RuntimeArray should be enumerated like for a regular array.
https://bugs.webkit.org/show_bug.cgi?id=29005

  • bridge/runtime_array.cpp: (JSC::RuntimeArray::getPropertyNames):
  • bridge/runtime_array.h:

2009-09-24 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=29005
The indices of RuntimeArray should be enumerated like for a regular array.

  • DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController arrayOfString]):
03:12 Changeset [48711] by hausmann@webkit.org

On Windows JSChar is typedef'ed to wchar_t.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-24
Reviewed by Simon Hausmann.

When building with WINSCW for Symbian we need to do the
same typedef.

  • API/JSStringRef.h:
02:38 Changeset [48710] by pfeldman@chromium.org

2009-09-23 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Eric Seidel.

Introduce Pasteboard::writePlaintext(const String&) so that copying
of the inspected elements HTML will be possible in WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=29634

  • platform/Pasteboard.h:
  • platform/android/TemporaryLinkStubs.cpp: (Pasteboard::writePlainText):
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writePlainText):
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writePlainText):
  • platform/haiku/PasteboardHaiku.cpp: (WebCore::Pasteboard::writePlainText):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writePlainText):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writePlainText):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText):
  • platform/wince/PasteboardWince.cpp: (WebCore::Pasteboard::writePlainText):
  • platform/wx/PasteboardWx.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
01:11 Changeset [48709] by hausmann@webkit.org

Fix QApp::translate() calls to provide the correct class name without
a trailing comma.

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2009-09-24
Reviewed by Simon Hausmann.

  • platform/qt/Localizations.cpp:

(WebCore::localizedMediaTimeDescription):

01:11 Changeset [48708] by hausmann@webkit.org

qdoc: Added \brief texts to all the since 4.6 functions.

Patch by Martin Smith <msmith@trolltech.com> on 2009-09-24
Reviewed by Simon Hausmann.

  • Api/qwebhistory.cpp:
00:20 Changeset [48707] by ggaren@apple.com

More build fix: Removed JSSharedWorkerContextCustom.cpp from project
files, since it no longer exists in the repository.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
00:15 Changeset [48706] by ggaren@apple.com

Windows build fix: Declare set/unsetPendingActivity public, so
SharedWorkerScriptLoader can call them.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24

  • dom/ActiveDOMObject.h:
00:12 Changeset [48705] by ggaren@apple.com

Fixed a bit of the Windows build.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24

  • workers/SharedWorker.idl: Declare a custom mark function. (I accidentally

removed this in my last patch.)

  • WebCore.xcodeproj/project.pbxproj: Added JSSharedWorkerCustom.cpp back

to the build. (I accidentally removed this in my last patch.)

Note: See TracTimeline for information about the timeline view.