Timeline


and

10/02/09:

23:31 Changeset [49063] by pfeldman@chromium.org

2009-10-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Node search mode is not getting reset on element selection.

https://bugs.webkit.org/show_bug.cgi?id=30016

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
22:24 Changeset [49062] by bweinstein@apple.com

2009-10-02 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.

Fixes <https://bugs.webkit.org/show_bug.cgi?id=30036>
Should be able to resize Cookie Columns.

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype.update.callback): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype.resize):
22:10 Changeset [49061] by sfalken@apple.com

Windows build fix.
Re-apply lost changes to auto-version.sh.

  • win/tools/scripts/auto-version.sh:
19:51 Changeset [49060] by jhoneycutt@apple.com

Make WebCore::PluginView participate in plug-in halting.

Reviewed by Sam Weinig.

WebCore:

Have plug-ins opt in to automatic halting.

Reviewed by NOBODY (OOPS!).

  • platform/graphics/BitmapImage.h:

Declare a create() function that takes an HBITMAP.

  • platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::create):
Use GetObject() to fill out a DIBSECTION structure for the given
HBITMAP. Call CGBitmapContextCreate() to create a CG context from the
bits of the bitmap. Create a CG image from the context, and pass this
when creating a new BitmapImage.

  • plugins/PluginView.cpp:

(WebCore::PluginView::start):
If we successfully started, tell our parent frame's Page.
(WebCore::PluginView::stop):
Tell our parent frame's Page that we stopped.
(WebCore::PluginView::node):

  • plugins/PluginView.h:

Inherit from HaltablePlugin.
(WebCore::PluginView::setPlatformPluginWidget):
On platforms where the platform plug-in widget is the WebCore::Widget's
platform widget, have setPlatformPluginWidget() call
setPlatformWidget().

  • plugins/PluginViewNone.cpp:

(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

  • plugins/mac/PluginViewMac.cpp:

(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::platformDestroy):
After destroying the window, set the platform plug-in widget to 0 to
ensure that Widget isn't holding a stale handle.
(WebCore::PluginView::halt):
Have our element's RenderWidget display a screenshot of the plug-in,
then stop the plug-in and destroy it.
(WebCore::PluginView::restart):
Clear the RenderWidget's substitute image, then start the plug-in.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::showSubstituteImage):
Set m_substituteImage to the passed image, and repaint.
(WebCore::RenderWidget::paint):
If we have a substitute image, paint that instead of allowing the
widget to paint itself.

  • rendering/RenderWidget.h:

Declare showSubstituteImage(). Added a member to store the substitute
image.

19:10 Changeset [49059] by abarth@webkit.org

2009-10-02 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Move PolicyCheck out of FrameLoader.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=30035

Purely code motion (and adding a destructor).

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/PolicyCheck.cpp:
  • loader/PolicyCheck.h:
18:47 Changeset [49058] by jparent@chromium.org

Unreviewed.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-02
Adding myself and Ojan Vafai as committers, because we are committers.

  • Scripts/modules/committers.py:
17:47 Changeset [49057] by mrowe@apple.com

Roll out r49044 as it breaks many tests.

16:35 Changeset [49056] by eric@webkit.org

2009-10-02 Jonni Rainisto <jonni.rainisto@nokia.com>

Reviewed by Darin Adler.

Math.random() gives too low values on Win32 when _CRT_RAND_S is not defined
https://bugs.webkit.org/show_bug.cgi?id=29956

  • wtf/RandomNumber.cpp: (WTF::randomNumber): Added PLATFORM(WIN_OS) to handle 15bit rand()
16:27 Changeset [49055] by eric@webkit.org

2009-10-02 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Update pixel test image for fast/table/vertical-align-baseline.html.

Expected render tree dump for this test was modified in r40146
<http://trac.webkit.org/changeset/40146>, but the image was not updated with it.

  • platform/mac/fast/table/vertical-align-baseline-expected.checksum:
  • platform/mac/fast/table/vertical-align-baseline-expected.png:
16:20 Changeset [49054] by eric@webkit.org

2009-10-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Add NPNVToolkit value quirk in plugins for nspluginwrapper.
Plugin error message was:
ERROR: failed to initialize brower-side RPC events listener
https://bugs.webkit.org/show_bug.cgi?id=25053

(WebCore::staticPluginQuirkRequiresGtkToolKit_NPN_GetValue):
(WebCore::PluginPackage::load):

16:12 Changeset [49053] by eric@webkit.org

2009-10-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] X sync our XEmbed container window creation before sending the
xid to plugins.
https://bugs.webkit.org/show_bug.cgi?id=25053

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
16:02 Changeset [49052] by simon.fraser@apple.com

2009-10-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Setting zero size on a container of a video element doesn't hide the controller
https://bugs.webkit.org/show_bug.cgi?id=30031

Fix a logic error in enclosingCompositingLayer() when mixing normal flow and
positioned layers. This resulted in enclosingCompositingLayer() giving back a different
answer to the logic used to actually parent compositing layers, so layer positions
and layer hierarchy would be out of agreement.

Test: compositing/geometry/clipped-video-controller.html

  • rendering/RenderLayer.cpp: (WebCore::compositingContainer): (WebCore::RenderLayer::enclosingCompositingLayer):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::setCompositingParent):
15:49 Changeset [49051] by eric@webkit.org

2009-10-02 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

  • Move the following methods of HTMLInputElement and HTMLTextAreaElement to HTMLTextFormControlElement.

setSelectionStart()
setSelectionEnd()
select()
setSelectionRange()
selectionStart()
selectionEnd()
selection()

  • Introduce cachedSelectionStart() and cachedSelectionEnd().
  • Unify HTMLInputElement::isTextFieldWithRenderer() and HTMLTextAreaElement::rendererAfterUpdateLayout() into textRendererAfterUpdateLayout().
  • Unify a part of parseMappedAttribute() of HTMLInputElement and HTMLTextAreaElement.

https://bugs.webkit.org/show_bug.cgi?id=29782

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::textRendererAfterUpdateLayout): (WebCore::HTMLTextFormControlElement::setSelectionStart): (WebCore::HTMLTextFormControlElement::setSelectionEnd): (WebCore::HTMLTextFormControlElement::select): (WebCore::HTMLTextFormControlElement::setSelectionRange): (WebCore::HTMLTextFormControlElement::selectionStart): (WebCore::HTMLTextFormControlElement::selectionEnd): (WebCore::HTMLTextFormControlElement::selection): (WebCore::HTMLTextFormControlElement::parseMappedAttribute):
  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::cachedSelectionStart): (WebCore::HTMLInputElement::cachedSelectionEnd):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::cachedSelectionStart): (WebCore::HTMLTextAreaElement::cachedSelectionEnd):
15:40 Changeset [49050] by eric@webkit.org

2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Disconnect event listeners on navigation.
Fixes http://crbug.com/23597.
https://bugs.webkit.org/show_bug.cgi?id=30027

Added V8ListenerGuard that is shared by listeners and proxy. On
navigation proxy sets a flag in the guard turning off listeners.

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener):
  • bindings/v8/V8AbstractEventListener.h: (WebCore::V8ListenerGuard::create): (WebCore::V8ListenerGuard::isDisconnected): (WebCore::V8ListenerGuard::disconnectListeners): (WebCore::V8ListenerGuard::V8ListenerGuard): (WebCore::V8AbstractEventListener::disconnected):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getEventListener):
  • bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper):
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::disconnectFrame): (WebCore::V8Proxy::disconnectEventListeners): (WebCore::V8Proxy::clearForNavigation):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::listenerGuard):
  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener):
  • bindings/v8/V8WorkerContextEventListener.h: (WebCore::V8WorkerContextEventListener::create):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener):
  • bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create):
15:33 Changeset [49049] by eric@webkit.org

2009-10-02 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Fix WebGL build after CustomGetter constructor changes
https://bugs.webkit.org/show_bug.cgi?id=30020

  • page/DOMWindow.idl: Changed CustomGetter to JSCCustomGetter for CanvasArray constructors.
15:23 Changeset [49048] by eric@webkit.org

2009-10-02 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Web Inspector: text in a "Request Payload" section disappears on selection
https://bugs.webkit.org/show_bug.cgi?id=29967

No new tests.

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestPayload):
15:15 Changeset [49047] by eric@webkit.org

2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

Test that having infinite recursion in XMLHttpRequest event handler does not crash.
https://bugs.webkit.org/show_bug.cgi?id=29974

  • fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html: Added.

2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Recursion guard for V8Proxy::callFunction.
Fixes http://crbug.com/23278.
https://bugs.webkit.org/show_bug.cgi?id=29974

Test: fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction):
14:59 Changeset [49046] by kenneth@webkit.org

Clean up the QNetworkReplyHandler to only apply HTTP headers
for protocols in the HTTP family.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-02
Reviewed by Simon Hausmann.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

14:55 Changeset [49045] by japhet@chromium.org

2009-10-02 Victor Wang <victorw@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=29619

Patch http://trac.webkit.org/changeset/35290 adds win support for
JPEG and GIF for toDataURL encoding canvases and the test was
rewritten to not output the encoded image data, it should pass
on Win now.

  • platform/win/Skipped:
  • platform/win/fast/canvas/toDataURL-supportedTypes-expected.txt: Removed.
14:53 Changeset [49044] by andersca@apple.com

WebKit side of <rdar://problem/7179166>

Reviewed by Kevin Decker and Dan Bernstein.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:

Add an m_pluginIsWaitingForDraw member variable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Initialize m_pluginIsWaitingForDraw.

(WebKit::NetscapePluginInstanceProxy::invalidateRect):
Set m_pluginIsWaitingForDraw to true.

(WebKit::NetscapePluginInstanceProxy::didDraw):
If m_pluginIsWaitingForDraw is true, call _WKPHPluginInstanceDidDraw.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView drawRect:]):
Call didDraw.

  • Plugins/Hosted/WebKitPluginHost.defs:

Add PHPluginInstanceDidDraw.

14:49 Changeset [49043] by bweinstein@apple.com

2009-10-02 Brian Weinstein <bweinstein@apple.com>

Reviewed by Jon Honeycutt.

Fix test breakages by adding null checks, and putting inspector code in
ENABLE(INSPECTOR).

  • dom/Document.cpp: (WebCore::Document::finishedParsing):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
14:39 Changeset [49042] by kenneth@webkit.org

Move error check into sendResponseIfNeeded() as suggested
by Eric Seidel. Also, remove some dead code.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-02
Reviewed by Simon Hausmann.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

14:34 Changeset [49041] by adele@apple.com

WebCore: Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting.
<rdar://problem/7148712>
https://bugs.webkit.org/show_bug.cgi?id=28992

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-02
Reviewed by Adele Peterson.

Test: editing/selection/replace-selection-crash.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Handle properly the case of
the destination position matching the end of the paragraph to move.

LayoutTests: Added test case.
<rdar://problem/7148712> Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting.
https://bugs.webkit.org/show_bug.cgi?id=28992

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-02
Reviewed by Adele Peterson.

  • editing/selection/replace-selection-crash-expected.txt: Added.
  • editing/selection/replace-selection-crash.html: Added.
14:15 Changeset [49040] by jorlow@chromium.org

2009-10-02 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Implement per-storage-area quotas for LocalStorage
https://bugs.webkit.org/show_bug.cgi?id=29991

I put 90% of the code in StorageMap since the decision to allow an update is
closely tied to quota tracking. The quota is set via a page's Settings class.
Like with the local storage path and whether it's enabled, it's assumed that
all pages in the same group will have the same settings. The setting defaults
to 5mb which is what the spec suggests, but it can easily be changed to
anything else--including StorageMap::noQuota. Any values in LocalStorage are
grandfathered in regarudless of quota, so importItem only tracks (and will
never block) imports.

I believe this change is a good transition to more complex quota management.
For example, if we wanted to track quotas in the SQLite DB, then we'd just add
a function to the StorageMap that sets the quota. This would be fine since all
use of LocalStorage is blocked on the import completing, so you'd never hit a
quota error in the mean time. Also, if embedders wanted to ask the user
whether to expand the quota whenever it's hit (before deciding whether or not
to raise an exception), a callback via the chrome client should be fairly easy.
That said, I think it's best to add these features in steps rather than one
huge patch. (Both of these are on my TODO list, btw.)

Included is a layout test that verifies the behavior. It assumes the default
quota is 5mb (since that's what Settings defaults to).

Test: storage/domstorage/localstorage/quota.html

  • page/PageGroup.cpp: (WebCore::PageGroup::localStorage):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setLocalStorageQuota):
  • page/Settings.h: (WebCore::Settings::localStorageQuota):
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::create): (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::clear):
  • storage/StorageAreaImpl.h:
  • storage/StorageMap.cpp: (WebCore::StorageMap::create): (WebCore::StorageMap::StorageMap): (WebCore::StorageMap::copy): (WebCore::StorageMap::setItem): (WebCore::StorageMap::removeItem): (WebCore::StorageMap::importItem):
  • storage/StorageMap.h: (WebCore::StorageMap::quota):
  • storage/StorageNamespace.cpp: (WebCore::StorageNamespace::localStorageNamespace):
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::localStorageNamespace): (WebCore::StorageNamespaceImpl::sessionStorageNamespace): (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea):
  • storage/StorageNamespaceImpl.h:

2009-10-02 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Implement per-storage-area quotas for LocalStorage
https://bugs.webkit.org/show_bug.cgi?id=29991

I put 90% of the code in StorageMap since the decision to allow an update is
closely tied to quota tracking. The quota is set via a page's Settings class.
Like with the local storage path and whether it's enabled, it's assumed that
all pages in the same group will have the same settings. The setting defaults
to 5mb which is what the spec suggests, but it can easily be changed to
anything else--including StorageMap::noQuota. Any values in LocalStorage are
grandfathered in regarudless of quota, so importItem only tracks (and will
never block) imports.

I believe this change is a good transition to more complex quota management.
For example, if we wanted to track quotas in the SQLite DB, then we'd just add
a function to the StorageMap that sets the quota. This would be fine since all
use of LocalStorage is blocked on the import completing, so you'd never hit a
quota error in the mean time. Also, if embedders wanted to ask the user
whether to expand the quota whenever it's hit (before deciding whether or not
to raise an exception), a callback via the chrome client should be fairly easy.
That said, I think it's best to add these features in steps rather than one
huge patch. (Both of these are on my TODO list, btw.)

Included is a layout test that verifies the behavior. It assumes the default
quota is 5mb (since that's what Settings defaults to).

  • storage/domstorage/localstorage/quota-expected.txt: Added.
  • storage/domstorage/localstorage/quota.html: Added.
  • storage/domstorage/script-tests/quota.js: Added. (runTest):
13:09 Changeset [49039] by joepeck@webkit.org

2009-10-02 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Database Inspector crashes Safari when table has more than 21 columns
https://bugs.webkit.org/show_bug.cgi?id=29924

  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.dataGridForResult): adjust the minimum column width percentage to be flexible for many columns.
13:07 Changeset [49038] by hyatt@apple.com

Fix Windows bustage.

13:07 Changeset [49037] by hyatt@apple.com

Fix Windows bustage.

13:01 Changeset [49036] by bweinstein@apple.com

2009-10-02 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.

Fixes <http://webkit.org/b/14370>.
Inspector's timeline should record when certain DOM events fired.


This patch adds calls into the Web Inspector when the main frame
fires an load event, and when the document fires its DOMContent
event. Once these values are passed in, they are sent to the Web Inspector
as a timing change, and these are denoted by vertical lines in the resources
panel (blue for DOM Content, red for load event).

  • English.lproj/localizedStrings.js: Added tooltip text.
  • dom/Document.cpp: (WebCore::Document::finishedParsing): Added an Inspector callback for DOM Content.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::mainResourceFiredDOMContentEvent): Tell the main resource it got the event. (WebCore::InspectorController::mainResourceFiredLoadEvent): Ditto.
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): Added new variables. (WebCore::InspectorResource::updateScriptObject): Send new variables to inspector.js. (WebCore::InspectorResource::markDOMContentEventTime): Send a TimingChange event. (WebCore::InspectorResource::markLoadEventTime): Ditto.
  • inspector/InspectorResource.h:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get mainResourceLoadTime): (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime): (WebInspector.ResourcesPanel.prototype.get mainResourceDOMContentTime): (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Draw dividers for event timings. (WebInspector.ResourceTimeCalculator.prototype.computePercentageFromEventTime):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent): Add an Inspector callback for the Load event.
13:00 Changeset [49035] by hyatt@apple.com

Fix Windows bustage.

12:57 Changeset [49034] by hyatt@apple.com

Update DUmpRenderTree to account for new API.

12:42 Changeset [49033] by hyatt@apple.com

Add support for blacklist patterns to user stylesheets and scripts in addition to whitelist patterns.

Reviewed by Adam Roben.

WebCore:

  • WebCore.base.exp:
  • dom/Document.cpp:

(WebCore::Document::pageGroupUserSheets):

  • page/Frame.cpp:

(WebCore::Frame::injectUserScriptsForWorld):

  • page/PageGroup.cpp:

(WebCore::PageGroup::addUserScript):
(WebCore::PageGroup::addUserStyleSheet):
(WebCore::PageGroup::removeUserContentWithURLForWorld):
(WebCore::PageGroup::removeUserContentForWorld):

  • page/PageGroup.h:
  • page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::matchesPatterns):

  • page/UserContentURLPattern.h:
  • page/UserScript.h:

(WebCore::UserScript::UserScript):
(WebCore::UserScript::whitelist):
(WebCore::UserScript::blacklist):

  • page/UserStyleSheet.h:

(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::whitelist):
(WebCore::UserStyleSheet::blacklist):

WebKit/mac:

  • WebView/WebView.mm:

(toStringVector):
(+[WebView _addUserScriptToGroup:source:url:worldID:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:source:url:worldID:whitelist:blacklist:]):

  • WebView/WebViewPrivate.h:

WebKit/win:

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:

(toStringVector):
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):

  • WebView.h:
11:41 Changeset [49032] by eric@webkit.org

2009-10-02 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Added gyp_webkit that does a subset of the things gyp_chromium does
plus some specialization for an upstream chromium build.

https://bugs.webkit.org/show_bug.cgi?id=29986

  • chromium/DEPS: Points to gyp_webkit instead of gyp_chromium.
  • chromium/gyp_webkit: A new python file.
11:08 Changeset [49031] by eric.carlson@apple.com

2009-10-02 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

<rdar://problem/7271334>
Rename MediaControllerThemeQT to MediaControllerThemeQuickTime

  • WebKitSystemInterface.h: MediaControllerThemeQT -> MediaControllerThemeQuickTime
11:06 Changeset [49030] by ggaren@apple.com

Rolled back in r49004 with the debug 64bit build fixed

11:02 Changeset [49029] by eric@webkit.org

2009-10-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

Build fix when SVG is not enabled
https://bugs.webkit.org/show_bug.cgi?id=30011

Move TextRenderingMode related functions out from
the ENABLE(SVG) guard.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator TextRenderingMode):
10:57 Changeset [49028] by bweinstein@apple.com

2009-10-02 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
this will help the patch merging process when TryBots are used.

  • Scripts/svn-create-patch:
10:49 Changeset [49027] by cmarrin@apple.com

WebGL crashes with recent CanvasArray change
https://bugs.webkit.org/show_bug.cgi?id=30018

10:22 Changeset [49026] by sfalken@apple.com

<https://bugs.webkit.org/show_bug.cgi?id=29989>
Safari version number shouldn't be exposed in WebKit code

Reviewed by Mark Rowe.

For a WebKit version of 532.3.4:
Product version is: 5.32.3.4 (was 4.0.3.0)
File version is: 5.32.3.4 (was 4.532.3.4)

JavaScriptCore:

WebCore:

  • WebCore.vcproj/QTMovieWin.rc:

WebKit/win:

  • WebKit.vcproj/WebKit.rc:

WebKitLibraries:

  • win/tools/scripts/PRODUCTVERSION: Removed.
  • win/tools/scripts/auto-version.sh: Re-worked script to remove references to PRODUCTVERSION.
10:19 Changeset [49025] by senorblanco@chromium.org

Enable two point radial gradients in Chromium/Skia.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=30017

Covered by the following tests:

LayoutTests/svg/W3C-SVG-1.1/pservers-grad-13-b.svg
LayoutTests/fast/backgrounds/svg-as-background-3.html
LayoutTests/fast/gradients/generated-gradients.html
LayoutTests/fast/gradients/simple-gradients.html

  • platform/graphics/skia/GradientSkia.cpp:

(WebCore::Gradient::platformGradient):

09:14 Changeset [49024] by eric@webkit.org

2009-10-02 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement layoutTestController.overridePreference().
https://bugs.webkit.org/show_bug.cgi?id=29970

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setPrivateBrowsingEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::overridePreference):
  • DumpRenderTree/qt/jsobjects.h:
08:49 Changeset [49023] by laszlo.1.gombos@nokia.com

2009-10-02 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Conditionally guard cursor code (cursor and updateCursor functions) with !QT_NO_CURSOR.
Otherwise, it is inconsistent with class declaration of QCursor.

  • Api/qgraphicswebview.cpp:
  • Api/qwebview.cpp:

2009-10-02 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Conditionally guard cursor code (cursor and updateCursor functions) with !QT_NO_CURSOR.
Otherwise, it is inconsistent with class declaration of QCursor.

No new tests.

  • platform/qt/QWebPageClient.h:
08:40 Changeset [49022] by vestbo@webkit.org

Fix the Qt on Mac OS X build.

Rubber-stamped by Simon Hausmann.

  • wtf/FastMalloc.cpp:
05:05 QtBackLog edited by zecke@selfish.org
(diff)
05:04 QtBackLog edited by zecke@selfish.org
(diff)
04:32 Changeset [49021] by eric@webkit.org

2009-10-02 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] missing support for anamorphic PAR video size
https://bugs.webkit.org/show_bug.cgi?id=29717

cleanup of caps handling in the video sink

  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_set_caps):
04:18 Changeset [49020] by hausmann@webkit.org

.: Disable a few more harmless MSVC warnings.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

  • WebKit.pri:

WebCore: Fix compiler warnings about unused function arguments.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

  • bridge/qt/qt_class.h:
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):

  • dom/XMLTokenizerQt.cpp:

(WebCore::XMLTokenizer::initializeParserContext):

  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::getCachedFontPlatformData):

  • platform/graphics/qt/FontFallbackListQt.cpp:

(WebCore::FontFallbackList::setPlatformFont):

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::offsetForPositionForComplexText):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::setURLForRect):

  • platform/graphics/qt/IconQt.cpp:

(WebCore::Icon::createIconForFiles):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::frameBufferAtIndex):

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:

(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::setEndTime):

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::containsCharacters):

  • platform/graphics/qt/StillImageQt.h:

(WebCore::StillImage::destroyDecodedData):

  • platform/network/qt/DnsPrefetchHelper.h:

(WebCore::DnsPrefetchHelper::lookedUp):

  • platform/qt/ContextMenuQt.cpp:

(WebCore::ContextMenu::setPlatformDescription):

  • platform/qt/DragDataQt.cpp:

(WebCore::DragData::asURL):

  • platform/qt/PopupMenuQt.cpp:

(WebCore::PopupMenu::populate):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::supportsFocusRing):
(WebCore::RenderThemeQt::systemFont):
(WebCore::RenderThemeQt::adjustButtonStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::paintMediaSeekBackButton):
(WebCore::RenderThemeQt::paintMediaSeekForwardButton):

  • platform/qt/ScrollViewQt.cpp:

(WebCore::ScrollView::platformAddChild):

  • platform/qt/SearchPopupMenuQt.cpp:

(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):

  • platform/qt/TemporaryLinkStubs.cpp:

(WebCore::signedPublicKeyAndChallengeString):

  • platform/qt/WidgetQt.cpp:

(WebCore::Widget::paint):

  • xml/XSLStyleSheetQt.cpp:

(WebCore::XSLStyleSheet::loadChildSheet):
(WebCore::XSLStyleSheet::setParentStyleSheet):

  • xml/XSLTProcessorQt.cpp:

(WebCore::XSLTMessageHandler::handleMessage):
(WebCore::XSLTProcessor::transformToString):

WebKit/qt: Fix compiler warnings about unused function arguments.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

  • Api/qwebframe.cpp:

(QWebFrame::scrollBarMinimum):

  • Api/qwebpage.cpp:

(QWebPagePrivate::focusInEvent):
(QWebPagePrivate::focusOutEvent):
(QWebPagePrivate::leaveEvent):
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
(QWebPage::triggerAction):
(QWebPage::acceptNavigationRequest):
(QWebPage::chooseFile):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::repaint):
(WebCore::ChromeClientQt::mouseDidMoveOverElement):
(WebCore::ChromeClientQt::reachedMaxAppCacheSize):

  • WebCoreSupport/ContextMenuClientQt.cpp:

(WebCore::ContextMenuClientQt::downloadURL):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
(WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
(WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
(WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
(WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
(WebCore::FrameLoaderClientQt::pluginWillHandleLoadError):
(WebCore::FrameLoaderClientQt::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientQt::createJavaAppletWidget):

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::setAttachedWindowHeight):
(WebCore::InspectorClientQt::highlight):
(WebCore::InspectorClientQt::removeSetting):

04:14 Changeset [49019] by eric@webkit.org

2009-10-02 Ben Murdoch <benm@google.com>

Reviewed by David Kilzer.

Stale database version persists through browser refresh (changeVersion doesn't work)
https://bugs.webkit.org/show_bug.cgi?id=27836

Scale the cairo surface of the video sink depending on the
pixel-aspect-ratio of the video buffer to paint. Also
destruct/re-create the surface when setSize() is called with a new
size.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::setSize): (WebCore::MediaPlayerPrivate::paint):
  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func):
03:19 Changeset [49018] by benm@google.com

Stale database version persists through browser refresh (changeVersion doesn't work)
https://bugs.webkit.org/show_bug.cgi?id=27836

WebCore:

Reviewed by David Kilzer.

Tests: storage/change-version-handle-reuse.html

storage/change-version.html

  • bindings/v8/custom/V8DatabaseCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL): Implement the V8 binding for database.changeVersion().
(WebCore::createTransaction): Fix a bug that was checking the wrong argument index to save the success callback.

  • storage/Database.cpp:

(WebCore::updateGuidVersionMap): Safely update the Guid/version hash map.
(WebCore::Database::~Database): Remove code that removes the database from the guid->database and guid->version maps.
(WebCore::Database::setVersionInDatabase): Add a comment to explain some behaviour.
(WebCore::Database::close): Move the code that updates the maps from the destructor to here.
(WebCore::Database::performOpenAndVerify): Call updateGuidVersionMap instead of setting the hash map directly.
(WebCore::Database::setExpectedVersion): Update the in memory guid->version map when we want to update the database version.

LayoutTests:

Reviewed by David Kilzer.

  • storage/change-version-expected.txt: Added.
  • storage/change-version-handle-reuse-expected.txt: Added.
  • storage/change-version-handle-reuse.html: Added.
  • storage/change-version.html: Added.
01:34 Changeset [49017] by hausmann@webkit.org

Partial WINSCW build fix.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-10-02
Reviewed by Simon Hausmann.

Add parentheses around the function pointer declaration, similar to the
second hunk in r48825.

  • loader/CachedResourceHandle.h:
01:22 Changeset [49016] by hausmann@webkit.org

Roll out accidential r49015 commit

01:21 Changeset [49015] by hausmann@webkit.org

use wtf/unicode/qt4/unicodeQt4.h for RVCT and WINSCW

Relative includes don't work properly with WINSCW

01:20 Changeset [49014] by abarth@webkit.org

2009-10-02 Adam Barth <abarth@webkit.org>

Unreviewed attempted build fix by Xcode magic.

  • WebCore.xcodeproj/project.pbxproj:
01:03 Changeset [49013] by abarth@webkit.org

2009-10-02 Adam Barth <abarth@webkit.org>

Unreviewed build fix. Actually add the new files.

  • loader/RedirectScheduler.cpp: Added. (WebCore::ScheduledRedirection::): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::RedirectScheduler::RedirectScheduler): (WebCore::RedirectScheduler::~RedirectScheduler): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel):
  • loader/RedirectScheduler.h: Added.
00:57 Changeset [49012] by abarth@webkit.org

2009-10-01 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Move RedirectScheduler to its own file
https://bugs.webkit.org/show_bug.cgi?id=29952

This change is purely code motion.

No behavior change.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/RedirectScheduler.cpp: Added. (WebCore::ScheduledRedirection::): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::RedirectScheduler::RedirectScheduler): (WebCore::RedirectScheduler::~RedirectScheduler): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel):
  • loader/RedirectScheduler.h: Added.
00:41 Changeset [49011] by eric@webkit.org

2009-10-02 Dave MacLachlan <dmaclach@gmail.com>

Reviewed by David Levin.

Clean up warnings in WebCore/bindings/v8/npruntime.cpp
https://bugs.webkit.org/show_bug.cgi?id=29971

Gets rid of warnings on gcc about using anonymous namespaces

warning: 'StringKeyHashTraits' has a base
'WTF::GenericHashTraits<<unnamed>::StringKey>'
whose type uses the anonymous namespace

and

warning: 'WTF::PairHashTraits<StringKeyHashTraits,
WTF::HashTraits<PrivateIdentifier*> >' has a base
'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey,
PrivateIdentifier*> >' whose type uses the anonymous namespace

No tests required.

  • bindings/v8/npruntime.cpp:
00:31 Changeset [49010] by hausmann@webkit.org

Allow enabling and disabling of the JIT through a qmake variable.

Patch by Jørgen Lind <jorgen.lind@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

Qt's configure may set this variable through .qmake.cache if a
commandline option is given and/or the compile test for hwcap.h
failed/succeeded.

10/01/09:

21:01 Changeset [49009] by eric@webkit.org

2009-10-01 Drew Wilson <atwilson@chromium.org>

Reviewed by David Levin.

Remove clone count from worker-cloneport.html as it's flakey on multi-process ports like Chromium.
https://bugs.webkit.org/show_bug.cgi?id=29698

  • fast/workers/worker-cloneport-expected.txt:
  • fast/workers/worker-cloneport.html:
19:50 Changeset [49008] by mrowe@apple.com

Fix the Tiger build. Don't unconditionally enable 3D canvas as it is not supported on Tiger.

17:58 Changeset [49007] by laszlo.1.gombos@nokia.com

2009-10-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, build fix.

[Qt] Symbian build break after r48976.
unix is set for Symbian in the Qt build system.

  • WebKit.pri:
17:25 Changeset [49006] by cmarrin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=29906
Turn on compile time switch for WebGL, but have runtime switch default to off

This also fixes LayoutTests which broke with the flag turned on, and
fixes a crash found in the LayoutTests.

16:49 Changeset [49005] by mrowe@apple.com

Roll out r49004 since it broke the debug build.

16:32 Changeset [49004] by ggaren@apple.com

Take one branch instead of two to test for JSValue().

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-01
Reviewed by Sam Weinig.

1.1% SunSpider speedup.

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_create_arguments):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.

  • runtime/JSValue.cpp:

(JSC::JSValue::description): Added support for dumping the new empty value,
and deleted values, in debug builds.

  • runtime/JSValue.h:

(JSC::JSValue::JSValue()): Construct JSValue() with the empty value tag.

(JSC::JSValue::JSValue(JSCell*)): Convert null pointer to the empty value
tag, to avoid having two different c++ versions of null / empty.

(JSC::JSValue::operator bool): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.

16:00 Changeset [49003] by bdakin@apple.com

WebCore: Fix for <rdar://problem/7264725> Re-add a vendor prefix to box-
shadow (29927)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29927

Reviewed by Dan Bernstein.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::ShadowParseContext::ShadowParseContext):
(WebCore::ShadowParseContext::commitValue):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitColor):
(WebCore::cssPropertyID):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • page/animation/AnimationBase.cpp:

(WebCore::ensurePropertyMap):

LayoutTests: Updated test results for <rdar://problem/7264725> Re-add a vendor
prefix to box-shadow (29927)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29927

Reviewed by Dan Bernstein.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
15:21 Changeset [49002] by eric@webkit.org

2009-10-01 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Make it possible to override the list of feature defines when building
downstream.

https://bugs.webkit.org/show_bug.cgi?id=29979

  • chromium/features.gypi:
14:56 Changeset [49001] by bweinstein@apple.com

2009-10-01 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Adam Roben.

Added fast/inline/relative-positioned-overflow.html to Skipped list because
it hits an asssert in Windows debug builds. Assertion failure is being tracked
by <https://bugs.webkit.org/show_bug.cgi?id=29966>.

  • platform/win/Skipped:
14:24 Changeset [49000] by bdakin@apple.com

Rubber-stamped by Sam Weinig.

Appeasing the Bot.

  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
14:19 Changeset [48999] by bweinstein@apple.com

2009-10-01 Brian Weinstein <bweinstein@apple.com>

Reviewed by Beth Dakin.

Update expected Windows results after new CSS Text Kerning changes.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/win/fast/css/text-rendering-expected.txt: Added.
13:46 Changeset [48998] by xan@webkit.org

2009-10-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Set the type for the fake event, otherwise the test ASSERTs in
debug builds.

  • tests/testhittestresult.c: (load_status_cb):
13:44 Changeset [48997] by kenneth@webkit.org

Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Disable HTTP loading tests that fail on the buildbot.

  • platform/qt/Skipped:
13:27 Changeset [48996] by atwilson@chromium.org

REGRESSION: fast/workers/dedicated-worker-lifecycle.html failing intermittently on leopard bot
https://bugs.webkit.org/show_bug.cgi?id=29344

Reviewed by Eric Seidel.

  • fast/workers/resources/dedicated-worker-lifecycle.js:

(runTests):
Allocate objects on the stack to try to force a GC to eliminate flakiness.

  • fast/workers/resources/worker-util.js:

(gc):
Added an optional "forceAlloc" parameter which causes a more extensive stack-clobbering algorithm to be run.
(waitUntilThreadCountMatches):
Pass the forceAlloc flag to gc() to try to force unreferenced workers to get GC'd.

13:24 Changeset [48995] by bdakin@apple.com

Rubber-stamped by Sam Weinig.

At bad merge at some point in the development of my patch must have
put TextRenderMode.h in a weird spot in the xcodeproj. Moving it
back where it belongs!

  • WebCore.xcodeproj/project.pbxproj:
13:12 Changeset [48994] by abarth@webkit.org

2009-10-01 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove FrameLoader::schedule* APIs
https://bugs.webkit.org/show_bug.cgi?id=29950

Change clients of FrameLoader::schedule* to call redirectScheduler
directly.

No behavior change.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::createWindow): (WebCore::JSDOMWindow::open):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
  • bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::reload):
  • bindings/v8/V8Utilities.cpp: (WebCore::navigateIfAllowed):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::processHttpEquiv):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::receivedFirstData):
  • loader/FrameLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
  • page/History.cpp: (WebCore::History::back): (WebCore::History::forward): (WebCore::History::go):
13:08 Changeset [48993] by bdakin@apple.com

Just removing a comment I accidentally committed earlier.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::getCFStringAttributes):

12:54 Changeset [48992] by jorlow@chromium.org

2009-09-30 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Clean up use of const and mutable in StorageMap
https://bugs.webkit.org/show_bug.cgi?id=29933

What's the point of having every single member variable be mutable and nearly
every method be const? Let's clean it up.

  • storage/StorageMap.cpp: (WebCore::StorageMap::setIteratorToIndex): (WebCore::StorageMap::key): (WebCore::StorageMap::importItem):
  • storage/StorageMap.h:
12:32 Changeset [48991] by kenneth@webkit.org

Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable Local tests for Qt.

  • platform/qt/Skipped:
12:21 Changeset [48990] by kenneth@webkit.org

Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP loading tests for Qt.

  • platform/qt/Skipped:
12:19 Changeset [48989] by bdakin@apple.com

WebCore: Fix for <rdar://problem/6934421> Support CSS for Text Kerning and
ligature
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=6136

Reviewed by Dave Hyatt.

This patch makes the SVG CSS property text-rendering work with any
HTML, much like it does in Firefox. It accepts four possible input
values: auto, optimizeSpeed, optimizeLegibility, and
geometricPrecision. Right now, in this implementation, here is what
those values correspond to:

auto = optimizeSpeed = what we normally when the value's not set
optimizeLegibility = geometricPrecision = ligatures + kerning

Add new file TextRenderingMode.h to the project files.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

CSS support for the new CSSPropertyTextRendering

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:

All the old SVG CSS support for this property can go away. When
it's used in SVG, it will just fall into the normal HTML case.

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

  • css/SVGCSSValueKeywords.in:

FontDescription stores the m_textRendering bit.

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::textRenderingMode):
(WebCore::FontDescription::setTextRenderingMode):
(WebCore::FontDescription::operator==):

We want to fall into the complex text rendering code path if
kerning and ligatures have been enabled with this property.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::canUseGlyphCache):

Now takes a TextRenderingMode as a parameter.

  • platform/graphics/SimpleFontData.h:

New header for the enum.

  • platform/graphics/TextRenderingMode.h: Added.

(WebCore::):

getCFStringAttributes() now takes a TextRenderingMode as an
attribute.

  • platform/graphics/mac/CoreTextController.cpp:

(WebCore::CoreTextController::collectCoreTextRunsForCharacters):

Enable kerning and ligatures whenever the TextRenderingMode is
OptimizeLegibility or GeometricPrecision

  • platform/graphics/mac/FontMacATSUI.mm:

(WebCore::disableLigatures):
(WebCore::initializeATSUStyle):
(WebCore::ATSULayoutParameters::initialize):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::getCFStringAttributes):

More SVG CSS stuff that isn't needed anymore since SVG will use the
new HTML CSS implementation.

  • rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::InheritedFlags::operator==):
(WebCore::SVGRenderStyle::setBitDefaults):

  • rendering/style/SVGRenderStyleDefs.h:

LayoutTests: Tests for <rdar://problem/6934421> Support CSS for Text Kerning and
ligature
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=6136

Reviewed by Dave Hyatt.

New tests.

  • fast/css/parsing-text-rendering-expected.txt: Added.
  • fast/css/parsing-text-rendering.html: Added.
  • fast/css/resources/parsing-text-rendering.js: Added.

(test):

  • fast/css/text-rendering.html: Added.
  • platform/mac/fast/css/text-rendering-expected.checksum: Added.
  • platform/mac/fast/css/text-rendering-expected.png: Added.
  • platform/mac/fast/css/text-rendering-expected.txt: Added.

New and improved results.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
12:18 Changeset [48988] by eric@webkit.org

2009-10-01 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=29187

Don't inline ~ListRefPtr() to work around winscw compiler forward declaration
bug regarding templated classes.

The compiler bug is reported at:
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812

The change will be reverted when the above bug is fixed in winscw compiler.

  • wtf/ListRefPtr.h: (WTF::::~ListRefPtr):
12:10 Changeset [48987] by kenneth@webkit.org

Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable URI tests for Qt, skip the single test we don't pass.

  • platform/qt/Skipped:
11:29 Changeset [48986] by japhet@chromium.org

2009-10-01 Nate Chapin <japhet@chromium.org>

Reviewed by Darin Adler.

Add baseline pngs for a couple of tests that currently only have checksums.

https://bugs.webkit.org/show_bug.cgi?id=28322

  • platform/mac/fast/borders/border-radius-constraints-expected.png: Added.
  • platform/mac/fast/borders/border-radius-split-inline-expected.png: Added.
11:14 Changeset [48985] by kenneth@webkit.org

Rubberstamped by Simon Hausmann.

WebKitTools:

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP tests for Qt

  • Scripts/run-webkit-tests:

LayoutTests:

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP tests for Qt, and skip the subdirs we don't pass yet.

  • platform/qt/Skipped:
11:08 Changeset [48984] by eric@webkit.org

2009-10-01 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Added windows-specific dependencies, updated some revisions and
re-organized file to make revision tracking easier. Also removed
extensions/v8 dependency that is no longer needed upstream.

https://bugs.webkit.org/show_bug.cgi?id=29973

  • chromium/DEPS:

2009-10-01 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

build-webkit --chromium now also works on cygwin.

https://bugs.webkit.org/show_bug.cgi?id=29973

  • Scripts/webkitdirs.pm:
10:41 Changeset [48983] by eric@webkit.org

2009-10-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Use isClosure property of scope proxy to decide whether the
scope is a closure.

https://bugs.webkit.org/show_bug.cgi?id=29965

  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
10:29 Changeset [48982] by simon.fraser@apple.com

2009-10-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Odd color transitions on anchors with transition-property: all
https://bugs.webkit.org/show_bug.cgi?id=29911

When transitioning maybe-invalid colors, if the source and destination
color are both invalid, then don't animate.

This fixes an issue where a child element of an element running a color
transition, with -webkit-transition-property:all, would show a color change.
This happened because the "maybe invalid color" logic copied the color style
into -webkit-text-fill-color for both endpoints, causing -webkit-text-fill-color
to animate while the transition ran, and to then to disappear when the transition
finished.

Test: transitions/color-transition-all.html

  • page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperMaybeInvalidColor::equals): (WebCore::PropertyWrapperMaybeInvalidColor::blend):
10:25 Changeset [48981] by eric@webkit.org

2009-10-01 Victor Wang <victorw@chromium.org>

Reviewed by Oliver Hunt.

Allow dragging a node who has child nodes.

https://bugs.webkit.org/show_bug.cgi?id=28632

  • fast/events/drag-parent-node-expected.txt: Added.
  • fast/events/drag-parent-node.html: Added.
  • fast/events/resources/bookmark.gif: Added.

2009-10-01 Victor Wang <victorw@chromium.org>

Reviewed by Oliver Hunt.

Allow dragging a node who has child nodes.

https://bugs.webkit.org/show_bug.cgi?id=28632

Test: fast/events/drag-parent-node.html

  • page/EventHandler.cpp: (WebCore::EventHandler::shouldDragAutoNode):
10:17 Changeset [48980] by eric@webkit.org

2009-10-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] media player: better mute support
https://bugs.webkit.org/show_bug.cgi?id=29960

Handle volume and mute state with the two corresponding properties
of playbin2.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::setVolume):
10:09 Changeset [48979] by eric@webkit.org

2009-10-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] video sink pad template colorspace is wrong
https://bugs.webkit.org/show_bug.cgi?id=29953

Set sink pad template colorspace depending on byte order.

  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func):
10:01 Changeset [48978] by eric@webkit.org

2009-10-01 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Refactored V8 event listeners:
(This change should fix http://crbug.com/21079 and
https://bugs.webkit.org/show_bug.cgi?id=29093.)

o All listeners use weak handles to JS objects to avoid creating

cycles and leaking memory.

o "Object" variants of listeners removed.
o All event accessor callbacks are generated.
o Custom event accessors removed.
o All wrappers have hidden dependencies on their listeners to

prevent listeners from being collected.

o All variats of getEventListener function grouped in V8DOMWrapper.
o Pointers to C++ EventListener wrappers are stored in JS objects

instead of event listener lists.

https://bugs.webkit.org/show_bug.cgi?id=29825

  • WebCore.gypi: Removed "Object" listeners.
  • bindings/scripts/CodeGeneratorV8.pm: Now handles event accessors.
  • bindings/v8/DOMObjectsInclude.h:

V8AbstractEventListener manages weak JS handle:

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::weakEventListenerCallback): (WebCore::V8AbstractEventListener::V8AbstractEventListener): (WebCore::V8AbstractEventListener::~V8AbstractEventListener): (WebCore::V8AbstractEventListener::handleEvent): (WebCore::V8AbstractEventListener::disposeListenerObject): (WebCore::V8AbstractEventListener::setListenerObject):
  • bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::cast): (WebCore::V8AbstractEventListener::isLazy): (WebCore::V8AbstractEventListener::getListenerObject): (WebCore::V8AbstractEventListener::getExistingListenerObject): (WebCore::V8AbstractEventListener::hasExistingListenerObject): (WebCore::V8AbstractEventListener::disconnectFrame): (WebCore::V8AbstractEventListener::disconnected): (WebCore::V8AbstractEventListener::prepareListenerObject): (WebCore::V8AbstractEventListener::lineNumber): (WebCore::V8AbstractEventListener::virtualisAttribute):

Grouped getEventListener functions:

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::getEventListener):
  • bindings/v8/V8DOMWrapper.h:

Removed most event listener objects bookkeeping:

  • bindings/v8/V8EventListenerList.cpp:
  • bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findWrapper): (WebCore::V8EventListenerList::clearWrapper): (WebCore::V8EventListenerList::doFindWrapper): (WebCore::V8EventListenerList::getHiddenProperty): (WebCore::V8EventListenerList::findOrCreateWrapper):

Added hidden properties for storing EventListener wrappers:

  • bindings/v8/V8HiddenPropertyName.cpp: (WebCore::V8HiddenPropertyName::listener): (WebCore::V8HiddenPropertyName::attributeListener):
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): (WebCore::V8LazyEventListener::callListenerFunction): (WebCore::V8LazyEventListener::prepareListenerObject):
  • bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::isLazy):
  • bindings/v8/V8ObjectEventListener.cpp: Removed.
  • bindings/v8/V8ObjectEventListener.h: Removed.
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::disconnectFrame): (WebCore::V8Proxy::disconnectEventListeners):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::reportError): (WebCore::V8WorkerContextEventListener::getReceiverObject):
  • bindings/v8/V8WorkerContextEventListener.h:
  • bindings/v8/V8WorkerContextObjectEventListener.cpp: Removed.
  • bindings/v8/V8WorkerContextObjectEventListener.h: Removed.
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener): (WebCore::V8EventListener::getListenerFunction): (WebCore::V8EventListener::callListenerFunction):
  • bindings/v8/custom/V8CustomEventListener.h:
  • bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::getEventListener): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SVGElementInstanceCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WorkerCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
09:59 Changeset [48977] by hausmann@webkit.org

Make Software Input Panel requests work with QGraphicsWebView
_and_ QWebView by sharing the event code in handleSoftwareInputPanel().

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-01
Reviewed by Tor Arne Vestbø.

  • Api/qwebpage.cpp:

(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::handleSoftwareInputPanel):

  • Api/qwebpage_p.h:
09:22 Changeset [48976] by zoltan@webkit.org

2009-10-01 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Allow custom memory allocation control for the whole JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=27029

Since in JavaScriptCore almost every class which has been instantiated by operator new is
inherited from FastAllocBase (bug #20422), we disable customizing global operator new for the Qt-port
when USE_SYSTEM_MALLOC=0.

Add #include <unistd.h> to FastMalloc.cpp because it's used by TCMalloc_PageHeap::scavengerThread().
(It's needed for the functionality of TCmalloc.)

Add TCSystemAlloc.cpp to JavaScriptCore.pri if USE_SYSTEM_MALLOC is disabled.

  • JavaScriptCore.pri:
  • wtf/FastMalloc.cpp: (WTF::sleep):
  • wtf/FastMalloc.h:

2009-10-01 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Don't use TCmalloc in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=27029

Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.

  • DumpRenderTree/qt/DumpRenderTree.pro:

2009-10-01 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Enable TCmalloc for the Linux, Mac and Windows Qt-port
https://bugs.webkit.org/show_bug.cgi?id=27029

Remove USE_SYSTEM_MALLOC for Linux, Mac and Windows Qt-port from WebKit.pri,
so these Qt-ports will use TCmalloc as other ports.

  • WebKit.pri:
08:35 Changeset [48975] by aroben@apple.com

Land expected failure results for two tests on Windows

These failures are covered by <http://webkit.org/b/29963> and
<http://webkit.org/b/29964>.

Rubber-stamped in advance by Eric Carlson.

  • platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt:

Added.

  • platform/win/fast/forms/basic-inputs-expected.txt: Added.
08:28 Changeset [48974] by vestbo@webkit.org

Rename QWebGraphicsItem to QGraphicsWebView

Patch by Alexis Menard <alexis.menard@nokia.com> on 2009-10-01
Reviewed by Tor Arne Vestbø.

08:26 Changeset [48973] by eric@webkit.org

2009-10-01 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Read-only transactions do not change file sizes and therefore
should not trigger quota updates.

https://bugs.webkit.org/show_bug.cgi?id=29945

  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): (WebCore::SQLTransaction::runStatements):
07:31 Changeset [48972] by tonikitoo@webkit.org

2009-09-28 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29248
[Qt] [API] Make it possible to have 'invisible' loads

Make QWebFrame's setHtml and setContent methods to not change
session and global history at all.

  • Api/qwebframe.cpp: (QWebFrame::setHtml): (QWebFrame::setContent):
  • tests/qwebframe/qwebframe.pro:
  • tests/qwebframe/tst_qwebframe.cpp:
06:18 Changeset [48971] by timothy@apple.com

Fix list box scrolling by correctly overriding the scroll()
function on RenderBox.

<rdar://problem/7255440> REGRESSION (r48683): Mousewheel scrolling
of listboxes is broken (29756)

Reviewed by Dan Bernstein.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scroll):

  • rendering/RenderListBox.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::scroll):

  • rendering/RenderTextControlSingleLine.h:
06:17 Changeset [48970] by eric@webkit.org

2009-10-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Make a copy of listeners array before dispatching an event in
WebInspector.Object.prototype.dispatchEventToListeners. Otherwise if current
listener removes itself from the array next listener will be skipped.

https://bugs.webkit.org/show_bug.cgi?id=29920

  • inspector/front-end/Object.js: (WebInspector.Object.prototype.dispatchEventToListeners): make a copy of listeners array before dispatching an event
06:02 Changeset [48969] by zoltan@webkit.org

2009-10-01 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Skip fast/table/008.html until a solution for the crash on the buildbot is found.

  • platform/qt/Skipped:
05:43 Changeset [48968] by hausmann@webkit.org

Fixed software input panel support on web input elements.

Patch by Kristian Amlie <kristian.amlie@nokia.com> on 2009-10-01
Reviewed by Simon Hausmann.

Send the RequestSoftwareInputPanel event if the element supports focus
and the element is clicked.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseReleaseEvent):

  • Api/qwebpage_p.h:
05:43 Changeset [48967] by hausmann@webkit.org

Implementation for QWebPage::inputMethodQuery and QWebPagePrivate::inputMethodEvent

Patch by Joe Ligman <joseph.ligman@nokia.com> on 2009-10-01
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29681

Some additional changes from Kristian Amlie <kristian.amlie@nokia.com>:

  • Fixed surrounding text to exclude preedit string
  • Avoid emission of microFocusChanged during setComposition()
  • Api/qwebpage.cpp:

(QWebPagePrivate::inputMethodEvent):
(QWebPage::inputMethodQuery):

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::respondToChangedSelection):

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::inputMethods):

04:28 QtWebKitProfilingSetup edited by zecke@selfish.org
(diff)
03:43 Changeset [48966] by eric@webkit.org

2009-10-01 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement eventSender.scheduleAsynchronousClick().

https://bugs.webkit.org/show_bug.cgi?id=29931

  • platform/qt/Skipped:

2009-10-01 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement eventSender.scheduleAsynchronousClick().

https://bugs.webkit.org/show_bug.cgi?id=29931

  • DumpRenderTree/qt/jsobjects.cpp: (EventSender::scheduleAsynchronousClick):
  • DumpRenderTree/qt/jsobjects.h:
03:35 Changeset [48965] by eric@webkit.org

2009-10-01 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
fast/events/open-window-from-another-frame.html from the Skipped list.

https://bugs.webkit.org/show_bug.cgi?id=29930

  • platform/qt/Skipped:

2009-10-01 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
fast/events/open-window-from-another-frame.html from the Skipped list.

https://bugs.webkit.org/show_bug.cgi?id=29930

  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::setPopupBlockingEnabled):
  • DumpRenderTree/qt/jsobjects.h:
02:02 Changeset [48964] by eric@webkit.org

2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733

Add new key event test ensuring that IME keypresses are handled.

  • GNUmakefile.am:

2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733

Re-enable skipped tests which were previously failing.

  • platform/gtk/Skipped:

2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733

Ensure that keyboard events filtered by the GtkIMContext still create
the proper DOM events.

No tests added. Instead previously skipped tests have been enabled.

  • platform/gtk/KeyEventGtk.cpp: (WebCore::keyIdentifierForGdkKeyCode): (WebCore::singleCharacterString):

2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733

Ensure that keyboard events filtered by the GtkIMContext still create
the proper DOM events.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::clearPendingIMData): (WebKit::imContextCommitted): (WebKit::imContextPreeditChanged): (WebKit::EditorClient::shouldBeginEditing): (WebKit::EditorClient::shouldEndEditing): (WebKit::interpretEditorCommandKeyEvent): (WebKit::handleCaretBrowsingKeyboardEvent): (WebKit::EditorClient::handleKeyboardEvent): (WebKit::EditorClient::handleInputMethodKeydown):
  • tests/testkeyevents.c: Added. (test_info_new): (test_info_destroy): (key_event_fixture_setup): (key_event_fixture_teardown): (key_press_event_cb): (key_release_event_cb): (load_status_cb): (map_event_cb): (test_keypress): (main):
01:19 Changeset [48963] by eric@webkit.org

2009-10-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] data: uri support in media player
https://bugs.webkit.org/show_bug.cgi?id=29842

Check presence of gstreamer-pbutils-0.10.

  • configure.ac:

2009-10-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] data: uri support in media player
https://bugs.webkit.org/show_bug.cgi?id=29842

Re-enable media/audio-data-url.html.

  • platform/gtk/Skipped:

2009-10-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] data: uri support in media player
https://bugs.webkit.org/show_bug.cgi?id=29842

New GStreamer element to handle data: uris. For now only base64
encoded data is supported. Decoded data is handed over to
giostreamsrc.

  • GNUmakefile.am:
  • platform/graphics/gtk/DataSourceGStreamer.cpp: Added. (_do_init): (webkit_data_src_base_init): (webkit_data_src_class_init): (webkit_data_src_reset): (webkit_data_src_init): (webkit_data_src_finalize): (webkit_data_src_uri_get_type): (webkit_data_src_uri_get_protocols): (webkit_data_src_uri_get_uri): (webkit_data_src_uri_set_uri): (webkit_data_src_uri_handler_init):
  • platform/graphics/gtk/DataSourceGStreamer.h: Added.
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::do_gst_init): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::mimeTypeCache):

09/30/09:

23:24 Changeset [48962] by cam@webkit.org

Unreviewed.

Added myself to the list of committers.

  • Scripts/modules/committers.py:
22:56 Changeset [48961] by dbates@webkit.org

2009-09-30 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=29944


Reduces false positives in the XSSAuditor by explicitly allowing requests
that do not contain illegal URI characters.


As a side effect of this change, the tests property-inject.html,
property-escape-noquotes.html, and property-escape-noquotes-tab-slash-chars.html
fail because these attacks do not contain any illegal URI characters and
thus are now allowed by the XSSAuditor, where previously they weren't. A future
change may reinstate this functionality.

Tests: http/tests/security/xssAuditor/script-tag-safe2.html

http/tests/security/xssAuditor/script-tag-safe3.html

  • page/XSSAuditor.cpp: (WebCore::isIllegalURICharacter): Added method. (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::findInRequest): Added parameter allowRequestIfNoIllegalURICharacters.
  • page/XSSAuditor.h:

2009-09-30 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=29944


Tests that the XSSAuditor allows requests that do not contain illegal URI
characters.


Added a notice regarding the failure of tests property-inject.html,
property-escape-noquotes.html and property-escape-noquotes-tab-slash-chars.html,
and rebased the expected results of these tests.

  • http/tests/security/xssAuditor/property-escape-noquotes-expected.txt:
  • http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars-expected.txt:
  • http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html:
  • http/tests/security/xssAuditor/property-escape-noquotes.html:
  • http/tests/security/xssAuditor/property-inject-expected.txt:
  • http/tests/security/xssAuditor/property-inject.html:
  • http/tests/security/xssAuditor/resources/safe-script-noquotes.js: Added.
  • http/tests/security/xssAuditor/resources/script-tag-safe2.html: Added.
  • http/tests/security/xssAuditor/resources/script-tag-safe3.html: Added.
  • http/tests/security/xssAuditor/script-tag-safe2-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-safe2.html: Added.
  • http/tests/security/xssAuditor/script-tag-safe3-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-safe3.html: Added.
22:52 Changeset [48960] by oliver@apple.com

reproducible freeze and crash on closing form popup at bosch-home.nl
https://bugs.webkit.org/show_bug.cgi?id=28948

Reviewed by Maciej Stachowiak.

showModalDialog calls getDirect on what is actually a window shell,
so ends up not getting a value (since no value can ever be placed
directly on the shell), which leads to incorrect behaviour.

We use a manual test rather than automatic as it was not
possible to get a modal run loop to work inside DRT.

22:49 Changeset [48959] by eric@webkit.org

2009-09-30 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Add ValidityState.tooLong support for <input> and <textarea>.
https://bugs.webkit.org/show_bug.cgi?id=27454

  • fast/forms/ValidityState-tooLong-input-expected.txt: Added.
  • fast/forms/ValidityState-tooLong-input.html: Added.
  • fast/forms/ValidityState-tooLong-textarea-expected.txt: Added.
  • fast/forms/ValidityState-tooLong-textarea.html: Added.
  • fast/forms/script-tests/ValidityState-tooLong-input.js: Added.
  • fast/forms/script-tests/ValidityState-tooLong-textarea.js: Added.

2009-09-30 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Adds ValidityState.tooLong support for <input> and <textarea>.

Introduces tooLong() in HTMLFormControlElement and it always returns false.
HTMLInputElement and HTMLTextAreaElement overrides it and checks the text
length and maxLength. tooLong() should work only for `dirty' values.
So, introduces m_isDirty flag for HTMLTextAreaElement, and
!m_data.value().isNull() works as a dirty flag for HTMLInputElement.

Renames parameter names of setMaxLength().

https://bugs.webkit.org/show_bug.cgi?id=27454

Tests: fast/forms/ValidityState-tooLong-input.html

fast/forms/ValidityState-tooLong-textarea.html

  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::tooLong):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::tooLong): (WebCore::HTMLInputElement::setMaxLength):
  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): (WebCore::HTMLTextAreaElement::reset): (WebCore::HTMLTextAreaElement::updateValue): (WebCore::HTMLTextAreaElement::setMaxLength): (WebCore::HTMLTextAreaElement::tooLong):
  • html/HTMLTextAreaElement.h:
  • html/ValidityState.h: (WebCore::ValidityState::tooLong):
22:12 QtWebKitProfilingSetup edited by zecke@selfish.org
(diff)
22:11 QtWebKitProfilingSetup edited by zecke@selfish.org
(diff)
22:06 QtWebKitProfilingSetup edited by zecke@selfish.org
(diff)
22:04 QtWebKitProfilingSetup edited by zecke@selfish.org
(diff)
21:52 QtWebKitProfilingSetup edited by zecke@selfish.org
(diff)
21:42 QtWebKitProfilingSetup edited by zecke@selfish.org
(diff)
21:39 QtWebKitProfilingSetup edited by zecke@selfish.org
(diff)
21:37 QtWebKitProfilingSetup edited by zecke@selfish.org
(diff)
21:30 QtWebKitProfilingSetup edited by zecke@selfish.org
(diff)
21:25 Changeset [48958] by abarth@webkit.org

2009-09-30 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Factor RedirectScheduler out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=29948

This change introduces a new sub-object of Frame, redirectScheduler.
The redirectScheduler is responsible for scheduling redirects.

This change leaves the code for the redirectScheduler in
FrameLoader.cpp. A future change will move the class into its own
file.

No behavior change (hopefully!).

  • loader/FrameLoader.cpp: (WebCore::RedirectScheduler::RedirectScheduler): (WebCore::RedirectScheduler::~RedirectScheduler): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::setDefersLoading): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::cancelAndClear): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::checkCompleted): (WebCore::FrameLoader::isScheduledLocationChangePending): (WebCore::FrameLoader::scheduleHTTPRedirection): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::FrameLoader::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::FrameLoader::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::FrameLoader::scheduleRefresh): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::FrameLoader::scheduleHistoryNavigation): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel): (WebCore::FrameLoader::completed): (WebCore::FrameLoader::open):
  • loader/FrameLoader.h: (WebCore::FrameLoader::committedFirstRealDocumentLoad):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::redirectScheduler):
  • page/Frame.h:
21:22 QtWebKitProfilingSetup edited by zecke@selfish.org
(diff)
21:02 QtWebKitProfilingSetup created by zecke@selfish.org
20:37 Changeset [48957] by mjs@apple.com

Build fix, not reviewed.

More Windows build fixes for https://bugs.webkit.org/show_bug.cgi?id=29943

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):

20:18 QtBackLog edited by zecke@selfish.org
(diff)
20:17 QtWebKitPerformanceWork edited by zecke@selfish.org
(diff)
20:14 Changeset [48956] by mjs@apple.com

Build fix, not reviewed.

Fix windows build for fix for https://bugs.webkit.org/show_bug.cgi?id=29943

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):

20:12 QtWebKitMirrorGuide edited by zecke@selfish.org
(diff)
19:59 Changeset [48955] by dglazkov@chromium.org

2009-09-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

[V8] HTMLAudioElement, HTMLImageElement, and HTMLOptionElement are constructable, but they shouldn't be.
Only Audio, Image, and Option should be constructable.
https://bugs.webkit.org/show_bug.cgi?id=29940

Test: fast/dom/dom-constructor.html

  • WebCore.gypi: Added new files to project.
  • bindings/scripts/CodeGeneratorV8.pm: Modified to generate custom constructors.
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed handling of HTMLImageElement, HTMLOptionElement and HTMLAudioElement construction.
  • bindings/v8/V8HTMLAudioElementConstructor.h: Added.
  • bindings/v8/V8HTMLImageElementConstructor.h: Added.
  • bindings/v8/V8HTMLOptionElementConstructor.h: Added.
  • bindings/v8/V8Index.cpp: Added new headers.
  • bindings/v8/V8Index.h: Added Audio, Image and Option decls.
  • bindings/v8/custom/V8CustomBinding.h: Ditto.
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER): Added custom constructors.
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::V8HTMLImageElementConstructor::GetTemplate): Added custom template creator.
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::V8HTMLOptionElementConstructor::GetTemplate): Ditto.
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::V8HTMLImageElementConstructor::GetTemplate): Ditto.
18:13 Changeset [48954] by eric@webkit.org

2009-09-30 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by George Staikos.

Defines two pseudo-platforms for ARM and Thumb-2 instruction set.
https://bugs.webkit.org/show_bug.cgi?id=29122

Introduces WTF_PLATFORM_ARM_TRADITIONAL and WTF_PLATFORM_ARM_THUMB2
macros on ARM platforms. The PLATFORM(ARM_THUMB2) should be used
when Thumb-2 instruction set is the required target. The
PLATFORM(ARM_TRADITIONAL) is for generic ARM instruction set. In
case where the code is common the PLATFORM(ARM) have to be used.

Modified by George Wright <gwright@rim.com> to correctly work
with the RVCT-defined TARGET_ARCH_ARM and TARGET_ARCH_THUMB
compiler macros, as well as adding readability changes.

  • wtf/Platform.h:
18:09 Changeset [48953] by mjs@apple.com

2009-09-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Brady Eidson.

307 redirects should pass along http body and Content-Type header
https://bugs.webkit.org/show_bug.cgi?id=29943

Follow-up fix for:
<rdar://problem/3802660> SAP: 307 (Temporary Redirect) responses should use POST, not GET


Test: http/tests/loading/resources/redirect-methods-result.php

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): Pass along http body and Content-Type header.
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): ditto

2009-09-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Brady Eidson.

307 redirects should pass along http body and Content-Type header
https://bugs.webkit.org/show_bug.cgi?id=29943

Follow-up fix for:
<rdar://problem/3802660> SAP: 307 (Temporary Redirect) responses should use POST, not GET

  • http/tests/loading/redirect-methods.html: Updated test to show the http body and content-type header.
  • http/tests/loading/redirect-methods-expected.txt:
  • http/tests/loading/resources/redirect-methods-result.php:
17:40 Changeset [48952] by ggaren@apple.com

Fixed https://bugs.webkit.org/show_bug.cgi?id=29941
REGRESSION (r48882-r48888): Many memory leaks on SnowLeopard leaks bot

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-30
Reviewed by Mark Rowe.

Forgot to implement a destructor for JSDOMWindowBaseData, so it was
leaking its RefPtr data member.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::destroyJSDOMWindowBaseData):

  • bindings/js/JSDOMWindowBase.h:

(WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData::JSDOMWindowBaseData):

17:13 Changeset [48951] by hyatt@apple.com

Make sure the removal of user stylesheets results in all of the WebViews being updated to
reflect the changes.

Reviewed by Tim Hatcher.

  • page/PageGroup.cpp:

(WebCore::PageGroup::removeUserContentWithURLForWorld):
(WebCore::PageGroup::removeUserContentForWorld):

15:30 Changeset [48950] by jorlow@chromium.org

2009-09-30 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Use a script-tests directory rather than a resources directory for DOM Storage
https://bugs.webkit.org/show_bug.cgi?id=29938

Use a script-tests directory rather than a resources directory for DOM Storage.
This matches up with what's been done elsewhere in the tree.

  • storage/domstorage/localstorage/clear.html:
  • storage/domstorage/resources: Removed.
  • storage/domstorage/resources/clear.js: Removed.
  • storage/domstorage/script-tests: Copied from LayoutTests/storage/domstorage/resources.
  • storage/domstorage/sessionstorage/clear.html:
15:06 Changeset [48949] by eric@webkit.org

2009-09-30 Eric Seidel <eric@webkit.org>

No review, just adding Geoff to the list of reviewers.

  • Scripts/modules/committers.py:
14:42 WikiStart edited by zoltan@webkit.org
Point the coding style guidelines to the offical on the WebKit website. (diff)
14:32 Changeset [48948] by oliver@apple.com

Devirtualise array toString conversion

Reviewed by Geoff Garen.

Tweak the implementation of Array.prototype.toString to have a fast path
when acting on a true JSArray.

14:15 Changeset [48947] by mitz@apple.com

REGRESSION(r47440): drop down menus at americanexpress.com disappear on mouse out
https://bugs.webkit.org/show_bug.cgi?id=29209

Reviewed by Sam Weinig.

WebCore:

Test: fast/inline/relative-positioned-overflow.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeVerticalOverflow): Add self-painting
inlines to overflow to ensure that they are included in hit-testing.

LayoutTests:

  • fast/inline/relative-positioned-overflow-expected.txt: Added.
  • fast/inline/relative-positioned-overflow.html: Added.
  • platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
13:56 Changeset [48946] by weinig@apple.com

Fix for <rdar://problem/7259706>
Need WebKit API or SPI on Mac and Windows to test whether it's safe to load a page in a new tab/window

Reviewed by Dan Bernstein.

WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _allowsFollowingLink:]):

  • WebView/WebFramePrivate.h:

WebKit/win:

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp:

(WebFrame::allowsFollowingLink):

  • WebFrame.h:
13:19 Changeset [48945] by simon.fraser@apple.com

2009-09-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

transforms/3d tests are not run in Release builds
https://bugs.webkit.org/show_bug.cgi?id=29827

Make sure we export the WebCoreHas3DRendering symbol in Release builds,
because this symbols is used by run-webkit-tests (via 'nm') to detect whether
WebCore was built with ENABLE_3D_RENDERING turned on.

  • DerivedSources.make:
  • WebCore.3DRendering.exp: Added.
  • WebCore.xcodeproj/project.pbxproj:
12:44 Changeset [48944] by mitz@apple.com

Added the WebKit Layout Tests fonts that are referenced in
LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css

Reviewed by Sam Weinig.

  • DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
  • DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
12:38 Changeset [48943] by kenneth@webkit.org

Add the failed URL to the ErrorPageExtension, as it is quite
useful for creating error pages.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-30
Reviewed by David Hyatt.

  • Api/qwebpage.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::callErrorPageExtension):

12:33 Changeset [48942] by jorlow@chromium.org

Build fix for QT. Didn't know WebCore.pro existed.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-30

  • WebCore.pro:
12:25 Changeset [48941] by hyatt@apple.com

WebCore: Add a method for removal of user scripts and stylesheets by URL from a specific world.

Reviewed by Adam Roben.

  • page/PageGroup.cpp:

(WebCore::PageGroup::removeUserContentURLForWorld):

  • page/PageGroup.h:

WebKit/mac: Add the ability to remove user stylesheets and scripts by URL.

Reviewed by Adam Roben.

  • WebView/WebView.mm:

(+[WebView _removeUserContentFromGroup:url:worldID:]):

  • WebView/WebViewPrivate.h:

WebKit/win: Add the ability to remove user stylesheets and scripts by URL.

Reviewed by Adam Roben.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:

(WebView::removeUserContentWithURLFromGroup):

  • WebView.h:
12:01 Changeset [48940] by eric@webkit.org

2009-09-30 Chris Hawk <hawk@chromium.org>

Reviewed by Dimitri Glazkov.

Fix for conditionals in the WebCore gyp file, which contained two separate
'conditions' values for the webcore target. The first entry was ignored,
resulting in some missine defines.
https://bugs.webkit.org/show_bug.cgi?id=29907

  • WebCore.gyp/WebCore.gyp:
11:52 Changeset [48939] by jorlow@chromium.org

2009-09-21 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

DOM Storage needs to be more careful about where "ThreadSafe" objects are destroyed.
https://bugs.webkit.org/show_bug.cgi?id=29265

DOM Storage needs to be more careful about where "ThreadSafe" objects are
destroyed. With the current code, there actually isn't a race condition, but
it sure would be easy for someone to introduce one. A bunch of
ThreadSafeShared objects have RefPtrs to objects that are NOT ThreadSafeShared
objects. If it were possible any of these objects' destructors to be fired off
the main thread, then the you'd have a race condition. The code should be more
clear and self-documenting about how things related to each other.

Since the lifetime of a LocalStorageTask is bounded by the LocalStorageThread
which is bounded by the StorageSyncManager, StorageAreaImpl, and
StorageAreaSync, there's no reason for LocalStorageTask to store anything other
than pointers. By breaking this dependency, we can eliminate the risk.

Note that we _could_ have LocalStorageThread's task queue just store
LocalStorageTask*'s rather than RefPtr<LocalStorageTask>s but then we'd need to
manually take care of deleting. It'd probably also be possible to change
LocalStorageThread around so that it needn't hold onto a reference of itself
and have a more deterministic shutdown, but my initial attempts to do so
failed, and I decided it wasn't worth changing. The queue is killed before
hand, so the thread is 100% impotent before the main thread continues anyway.

The constructors and destructors of StorageSyncManager, StorageAreaImpl, and
StorageAreaSync now have ASSERTs to verify they're running on the main thread.
I'm fairly positive that it'd be impossible to hit these asserts and the fact
that these classes are no longer ThreadSafeShared should make it clear how
they're meant to be used, but I think it's worth it to be extra sure. Of
course, ideally, we'd have such an assert every time a ref is incremented or
decremented.

Behavior should be unchanged and this is just an internal code cleanup, so no
new tests.

  • storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::LocalStorageTask): (WebCore::LocalStorageTask::performTask):
  • storage/LocalStorageTask.h: (WebCore::LocalStorageTask::createImport): (WebCore::LocalStorageTask::createSync): (WebCore::LocalStorageTask::createTerminate):
  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync):
  • storage/LocalStorageThread.h:
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::~StorageAreaImpl): (WebCore::StorageAreaImpl::StorageAreaImpl):
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::~StorageAreaSync):
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::~StorageSyncManager): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
  • storage/StorageSyncManager.h:
11:26 Changeset [48938] by ggaren@apple.com

Buildfix for platforms using JSVALUE32.
https://bugs.webkit.org/show_bug.cgi?id=29915

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-30
Reviewed by Geoffrey Garen.

After http://trac.webkit.org/changeset/48905 the build broke in JSVALUE32 case.
Also removed unreachable code.

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_add):

  • Declaration of "OperandTypes types" moved before first use.
  • Typos fixed: dst modified to result, regT2 added.
  • Unreachable code removed.

(JSC::JIT::emitSlow_op_add):

  • Missing declaration of "OperandTypes types" added.
11:17 Changeset [48937] by jorlow@chromium.org

2009-09-28 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Chromium needs to be able to override the way storage events are delivered
https://bugs.webkit.org/show_bug.cgi?id=29655

Chromium needs to be able to override the way storage events are delivered.
This replaced https://bugs.webkit.org/show_bug.cgi?id=29257 because it'll be
faster (no vtables and extra allocation) and somewhat cleaner (no dependency
injection). This is necessary because Chromium needs to transport events across
a process barrier and then dispatch them without use of a Frame*.

Behavior should not change with this, so no updates to tests.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::removeItem): (WebCore::StorageAreaImpl::clear):
  • storage/StorageAreaImpl.h:
  • storage/StorageEventDispatcher.cpp: Copied from WebCore/storage/StorageAreaImpl.cpp. (WebCore::StorageEventDispatcher::dispatch):
  • storage/StorageEventDispatcher.h: Added. (Well, technically in the other half of this patch.)
11:15 Changeset [48936] by mrowe@apple.com

Versioning.

11:11 Changeset [48935] by mrowe@apple.com

New tag.

10:52 Changeset [48934] by jianli@chromium.org

Need to check NULL frame in EventHandler::updateDragAndDrop.
https://bugs.webkit.org/show_bug.cgi?id=29929

Reviewed by Darin Adler.

WebCore:

Test: http/tests/misc/drag-over-iframe-invalid-source-crash.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateDragAndDrop):

LayoutTests:

Add a new test for the bug.

  • http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt: Added.
  • http/tests/misc/drag-over-iframe-invalid-source-crash.html: Added.
10:33 Changeset [48933] by mitz@apple.com

Set the svn:mime-type property of recently-added PNG files to image/png.

10:21 Changeset [48932] by simon.fraser@apple.com

2009-09-29 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

ASSERTION FAILED: !repaintContainer
repaintContainer == this

https://bugs.webkit.org/show_bug.cgi?id=29755

Generalize the fix for this bug to account for cases where there may be multiple
containing blocks between the repaint container, and the container of the element
being repainted.

Test: compositing/repaint/opacity-between-absolute2.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): Call offsetFromAncestorContainer() to get the correct offset.

(WebCore::RenderBox::computeRectForRepaint): Ditto

  • rendering/RenderInline.cpp: (WebCore::RenderInline::computeRectForRepaint): Ditto.
  • rendering/RenderObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetFromAncestorContainer): New method that computes an offset from some object in the ancestor container() chain.
10:15 Changeset [48931] by ddkilzer@apple.com

2009-09-30 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by David Kilzer.

Make sunspider scripts work on Windows platform.
https://bugs.webkit.org/show_bug.cgi?id=29656

  • Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
  • Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
  • Scripts/webkitdirs.pm: currentPerlPath() added.
10:13 Changeset [48930] by eric@webkit.org

2009-09-30 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

  1. Keeping up with downstream revisions.
  2. Turning off v8 snapshot build step.

https://bugs.webkit.org/show_bug.cgi?id=29928

  • chromium/DEPS
08:35 Changeset [48929] by eric@webkit.org

2009-09-30 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Fix TextCodecQt::decode method after r48752 to return a non-null string if the length of the input is 0.
This fixes https://bugs.webkit.org/show_bug.cgi?id=29736.

  • platform/text/qt/TextCodecQt.cpp: (WebCore::TextCodecQt::decode):
07:20 Changeset [48928] by hausmann@webkit.org

Reduce heap size on Symbian from 64MB to 8MB.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-30
Reviewed by Simon Hausmann.

This is not a perfect fix, it requires more fine tuning.
But this makes it possible again to debug in the emulator,
which is more important in order to be able to fix other
run-time issues.

  • runtime/Collector.h:
05:41 QtWebKitMirrorGuide edited by zecke@selfish.org
(diff)
05:33 QtWebKitMirrorGuide edited by zecke@selfish.org
(diff)
05:31 QtWebKitTodo edited by kenneth@webkit.org
(diff)
05:16 Changeset [48927] by hausmann@webkit.org

[Qt] Update Skipped after #48873 and some expected files, whose
problems are the same (default font size reconciliation
16px/13px), but the previous update didn't contain them.

Patch by Renata Hodovan <hodovan.renata@stud.u-szeged.hu> on 2009-09-30
Reviewed by Simon Hausmann.

  • platform/qt/Skipped:
  • platform/qt/css2.1/t040103-ident-04-c-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt:
  • platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.txt:
  • platform/qt/css2.1/t040306-syntax-01-f-expected.txt:
  • platform/qt/css2.1/t1202-counter-05-b-expected.txt:
  • platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
05:02 Changeset [48926] by eric@webkit.org

2009-09-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

Move message-port-multi.js from resources to script-tests
https://bugs.webkit.org/show_bug.cgi?id=29798

Revert r48823. message-port-multi.js needs custom HTML.

  • fast/events/message-port-multi-expected.txt:
  • fast/events/message-port-multi.html:
  • fast/events/resources/message-port-multi.js: Added. (channel.port2.onmessage):
  • fast/events/script-tests/message-port-multi.js: Removed.
04:47 QtWebKitMirrorGuide edited by zecke@selfish.org
(diff)
03:49 Changeset [48925] by eric@webkit.org

2009-09-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Kilzer.

Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=12140

Fixes for JS files.

  • fast/js/date-preserve-milliseconds-expected.txt:
  • fast/js/script-tests/array-float-delete.js:
  • fast/js/script-tests/array-tostring-ignore-separator.js:
  • fast/js/script-tests/date-big-setmonth.js:
  • fast/js/script-tests/date-negative-setmonth.js:
  • fast/js/script-tests/date-preserve-milliseconds.js:
  • fast/js/script-tests/number-tofixed.js:
  • fast/js/script-tests/object-extra-comma.js:
  • fast/js/script-tests/object-prototype-constructor.js:
  • fast/js/script-tests/object-prototype-toLocaleString.js:
  • fast/js/script-tests/regexp-lastindex.js:
  • fast/js/script-tests/regexp-stack-overflow.js:
  • fast/js/script-tests/string-split-ignore-case.js:
  • fast/js/script-tests/toString-exception.js:
  • fast/js/script-tests/toString-overrides.js:
  • fast/js/script-tests/toString-stack-overflow.js:
  • fast/js/toString-stack-overflow-expected.txt:
01:55 Changeset [48924] by eric@webkit.org

2009-09-30 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Geolocation LayoutTests should use an HTML template.
https://bugs.webkit.org/show_bug.cgi?id=29179

Updates Geolocation LayoutTests to correctly use an HTML template so that
individual HTML files can be generated using make-script-test-wrappers.
This requires a new js-test-post.js which allows for asynchronous tests.

  • fast/dom/Geolocation/resources/TEMPLATE.html: Modified. Updated to use new js-test-post.js.
  • fast/dom/Geolocation/resources/js-test-post.js: Added. Allows for asynchronous tests.
  • fast/dom/Geolocation/resources/argument-types.js: Modified. Sepcifies synchronous test.
  • fast/dom/Geolocation/argument-types.html: Modified. Updated to use new js-test-post.js.
  • fast/dom/Geolocation/resources/callback-exception.js: Modified. Specifies asynchronous test.
  • fast/dom/Geolocation/callback-exception.html: Modified. Updated to use new js-test-post.js.
  • fast/dom/Geolocation/callback-exception-expected.txt: Modified. Adds successfullyParsed.
  • fast/dom/Geolocation/resources/enabled.js: Modified. Sepcifies synchronous test.
  • fast/dom/Geolocation/enabled.html: Modified. Updated to use new js-test-post.js.
  • fast/dom/Geolocation/resources/error.js: Modified. Specifies asynchronous test.
  • fast/dom/Geolocation/error.html: Modified. Updated to use new js-test-post.js.
  • fast/dom/Geolocation/error-expected.txt: Modified. Adds successfullyParsed.
  • fast/dom/Geolocation/resources/permission-denied.js: Modified. Specifies asynchronous test.
  • fast/dom/Geolocation/permission-denied.html: Modified. Updated to use new js-test-post.js.
  • fast/dom/Geolocation/permission-denied-expected.txt: Modified. Adds successfullyParsed.
  • fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Modified. Specifies asynchronous test.
  • fast/dom/Geolocation/permission-denied-stops-watches.html: Modified. Updated to use new js-test-post.js.
  • fast/dom/Geolocation/permission-denied-stops-watches-expected.txt: Modified. Adds successfullyParsed.
  • fast/dom/Geolocation/resources/position-string.js: Modified. Specifies asynchronous test.
  • fast/dom/Geolocation/position-string.html: Modified. Updated to use new js-test-post.js.
  • fast/dom/Geolocation/position-string-expected.txt: Modified. Adds successfullyParsed.
  • fast/dom/Geolocation/resources/reentrant-error.js: Modified. Specifies asynchronous test.
  • fast/dom/Geolocation/reentrant-error.html: Modified. Updated to use new js-test-post.js.
  • fast/dom/Geolocation/reentrant-error-expected.txt: Modified. Adds successfullyParsed.
  • fast/dom/Geolocation/resources/reentrant-success.js: Modified. Specifies asynchronous test.
  • fast/dom/Geolocation/reentrant-success.html: Modified. Updated to use new js-test-post.js.
  • fast/dom/Geolocation/reentrant-success-expected.txt: Modified. Adds successfullyParsed.
  • fast/dom/Geolocation/resources/success.js: Modified. Specifies asynchronous test.
  • fast/dom/Geolocation/success.html: Modified. Updated to use new js-test-post.js.
  • fast/dom/Geolocation/success-expected.txt: Modified. Adds successfullyParsed.
  • fast/dom/Geolocation/resources/timeout.js: Modified. Specifies asynchronous test.
  • fast/dom/Geolocation/timeout.html: Modified. Updated to use new js-test-post.js.
  • fast/dom/Geolocation/timeout-expected.txt: Modified. Adds successfullyParsed.
  • fast/dom/Geolocation/resources/timeout-zero.js: Modified. Specifies asynchronous test.
  • fast/dom/Geolocation/timeout-zero.html: Modified. Updated to use new js-test-post.js.
  • fast/dom/Geolocation/timeout-zero-expected.txt: Modified. Adds successfullyParsed.
  • fast/dom/Geolocation/resources/watch.js: Modified. Specifies asynchronous test.
  • fast/dom/Geolocation/watch.html: Updated to use new js-test-post.js.
  • fast/dom/Geolocation/watch-expected.txt: Modified. Adds successfullyParsed.
01:38 QtWebKitMirrorGuide created by zecke@selfish.org
01:13 Changeset [48923] by eric@webkit.org

2009-09-30 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Darin Adler.

Platform specific null device replaced with a platform independent.
https://bugs.webkit.org/show_bug.cgi?id=29544

  • sunspider: Using File::Spec->devnull() instead of /dev/null and NUL.
01:06 QtWebKitPerformanceWork edited by zecke@selfish.org
(diff)
00:48 Changeset [48922] by hausmann@webkit.org

Fix CRASH() macro for Symbian build.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-30
Reviewed by Simon Hausmann.

  • wtf/Assertions.h: Added missing }
00:03 QtWebKitPerformanceUtilities edited by zecke@selfish.org
(diff)

09/29/09:

23:55 Changeset [48921] by hamaji@chromium.org

2009-09-29 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=12140

Remove opendarwin URLs from href="".
This change doesn't change pixel test results.

  • editing/pasteboard/display-block-on-spans.html:
  • editing/pasteboard/drop-text-without-selection.html:
  • editing/pasteboard/paste-text-019.html:
  • editing/selection/6476.html:
  • editing/selection/7152-1.html:
  • editing/selection/7152-2.html:
  • editing/selection/after-line-wrap.html:
  • editing/selection/click-start-of-line.html:
  • editing/selection/leave-requested-block.html:
  • editing/selection/select-from-textfield-outwards.html:
  • fast/block/basic/text-indent-rtl.html:
  • fast/block/float/nopaint-after-layer-destruction.html:
  • fast/block/float/nopaint-after-layer-destruction2.html:
  • fast/block/float/table-relayout.html:
  • fast/block/float/vertical-move-relayout.html:
  • fast/block/positioning/height-change.html:
  • fast/block/positioning/relayout-on-position-change.html:
  • fast/block/positioning/window-height-change.html:
  • fast/css-generated-content/hover-style-change.html: Added property allow-tabs.
  • fast/css/error-in-last-decl.html:
  • fast/css/ex-after-font-variant.html:
  • fast/css/find-next-layer.html:
  • fast/css/first-letter-detach.html:
  • fast/css/font-shorthand-weight-only.html:
  • fast/css/hover-subselector.html:
  • fast/css/invalidation-errors-2.html:
  • fast/css/invalidation-errors-3.html:
  • fast/css/invalidation-errors.html:
  • fast/css/resize-corner-tracking.html:
  • fast/css/rtl-ordering.html:
  • fast/css/universal-hover-quirk.html:
  • fast/dom/Element/class-attribute-whitespace.html: Added property allow-tabs.
  • fast/dom/HTMLHeadElement/head-link-style-href-check.html:
  • fast/dom/HTMLLinkElement/pending-stylesheet-count.html:
  • fast/dynamic/layer-hit-test-crash.html:
  • fast/dynamic/selection-highlight-adjust.html:
  • fast/encoding/resources/%25%u0435 0 %xx%%%ulike.html:
  • fast/events/event-sender-mouse-moved.html:
  • fast/events/resources/drag-outside-window-frame.html:
  • fast/forms/button-cannot-be-nested.html:
  • fast/forms/button-generated-content.html:
  • fast/forms/button-inner-block-reuse.html:
  • fast/forms/button-white-space.html:
  • fast/forms/floating-textfield-relayout.html:
  • fast/forms/form-hides-table.html:
  • fast/forms/visual-hebrew-text-field.html:
  • fast/history/clicked-link-is-visited.html:
  • fast/history/resources/clicked-link-is-visited-2.html:
  • fast/inline-block/overflow-clip.html:
  • fast/invalid/missing-address-end-tag.html:
  • fast/invalid/missing-dl-end-tag.html:
  • fast/invalid/missing-dt-end-tag.html:
  • fast/invalid/missing-font-end-tag.html:
  • fast/js/exception-linenums-in-html-3.html:
  • fast/js/missing-style-end-tag-js.html:
  • fast/layers/opacity-outline.html:
  • fast/lists/list-style-none-crash.html:
  • fast/lists/markers-in-selection.html:
  • fast/lists/scrolled-marker-paint.html:
  • fast/overflow/image-selection-highlight.html:
  • fast/overflow/overflow-rtl-inline-scrollbar.html:
  • fast/parser/broken-comments-vs-parsing-mode.html:
  • fast/parser/nofoo-tags-inside-paragraph.html:
  • fast/parser/remove-block-in-residual-style.html:
  • fast/repaint/backgroundSizeRepaint.html:
  • fast/repaint/border-repaint-glitch.html:
  • fast/repaint/bugzilla-3509.html:
  • fast/repaint/bugzilla-5699.html:
  • fast/repaint/bugzilla-6278.html:
  • fast/repaint/bugzilla-6388.html:
  • fast/repaint/bugzilla-6473.html:
  • fast/repaint/bugzilla-7235.html:
  • fast/repaint/clipped-relative.html:
  • fast/repaint/containing-block-position-change.html:
  • fast/repaint/flexible-box-overflow-horizontal.html:
  • fast/repaint/flexible-box-overflow.html:
  • fast/repaint/float-move-during-layout.html:
  • fast/repaint/inline-outline-repaint.html:
  • fast/repaint/layer-outline-horizontal.html:
  • fast/repaint/layer-outline.html:
  • fast/repaint/line-overflow.html:
  • fast/repaint/outline-repaint-glitch.html:
  • fast/repaint/outline-shrinking.html:
  • fast/repaint/repaint-resized-overflow.html:
  • fast/repaint/static-to-positioned.html:
  • fast/repaint/table-cell-move.html:
  • fast/repaint/table-extra-bottom-grow.html:
  • fast/repaint/text-shadow-horizontal.html:
  • fast/repaint/text-shadow.html:
  • fast/replaced/applet-rendering-java-disabled.html:
  • fast/replaced/image-solid-color-with-alpha.html:
  • fast/replaced/inline-box-wrapper-handover.html:
  • fast/replaced/pdf-as-image.html:
  • fast/table/absolute-table-at-bottom.html:
  • fast/table/add-before-anonymous-child.html:
  • fast/table/border-collapsing/003.html:
  • fast/table/border-collapsing/border-collapsing-head-foot.html:
  • fast/table/border-collapsing/rtl-border-collapsing.html:
  • fast/table/cell-absolute-child.html:
  • fast/table/click-near-anonymous-table.html:
  • fast/table/edge-offsets.html:
  • fast/table/empty-section-crash.html:
  • fast/table/fixed-table-non-cell-in-row.html:
  • fast/table/form-with-table-style.html:
  • fast/table/row-height-recalc.html:
  • fast/table/rtl-cell-display-none-assert.html:
  • fast/table/text-field-baseline.html:
  • fast/text/atsui-small-caps-punctuation-size.html:
  • fast/text/atsui-spacing-features.html:
  • fast/text/basic/015.html:
  • fast/text/capitalize-empty-generated-string.html:
  • fast/text/in-rendered-text-rtl.html:
  • fast/text/international/rtl-caret.html:
  • fast/text/midword-break-hang.html:
  • fast/text/whitespace/pre-wrap-overflow-selection.html:
  • fast/text/whitespace/pre-wrap-spaces-after-newline.html:
  • fast/tokenizer/missing-style-end-tag-1.html:
  • fast/tokenizer/missing-style-end-tag-2.html:
  • fast/tokenizer/missing-title-end-tag-1.html:
  • fast/tokenizer/missing-title-end-tag-2.html:
  • http/tests/misc/iframe404.html:
23:38 QtWebKitPerformanceUtilities edited by zecke@selfish.org
(diff)
23:36 QtWebKitPerformanceWork edited by zecke@selfish.org
(diff)
23:17 QtWebKitPerformanceUtilities edited by zecke@selfish.org
(diff)
23:15 QtWebKitPerformanceUtilities edited by zecke@selfish.org
(diff)
22:18 QtWebKitPerformanceUtilities edited by zecke@selfish.org
more command line invocation (diff)
22:14 QtWebKitPerformanceUtilities edited by zecke@selfish.org
(diff)
22:04 QtWebKitPerformanceToolBackLog: created by zecke@selfish.org
22:02 QtWebKitPerformanceWork edited by zecke@selfish.org
(diff)
21:55 QtBackLog created by zecke@selfish.org
21:48 QtWebKitPerformanceUtilities edited by zecke@selfish.org
(diff)
21:46 Changeset [48920] by ggaren@apple.com

Inlined a few math operations.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29
Reviewed by Gavin Barraclough.

~1% SunSpider speedup.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp:

(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub): Don't take a stub call when operating on
a constant int and a double.

20:40 QtWebKitPerformanceUtilities created by zecke@selfish.org
Create overview of the utilities... stub
20:27 QtWebKitPerformanceWork created by zecke@selfish.org
Start QtWebKit performance analysis page.
19:46 Changeset [48919] by hyatt@apple.com

Fix a couple of bugs with patterns. Move the setting of the document URL to before the style
selector gets constructed so that pattern match testing gets the correct URL.

Reviewed by Jon Honeycutt.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::begin):

  • page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::parse):

19:02 Changeset [48918] by ap@apple.com

Rubber-stamped by Brady Eidson.

Assertion failure in http/tests/xmlhttprequest/failed-auth.html.

I couldn't find out why this only started to happen now, but it was incorrect to check
persistence of a credential returned by CredentialStorage::get() without checking that it
was non-null. When there is no credential for the protection space in storage, get()
returns a new object, and Credentil constructor doesn't initialize m_persistence.

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Moved the assertion after credential null check. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Added the same persistence assertion, matching sync code (and CF one, as well).
19:00 Changeset [48917] by beidson@apple.com

Rubberstamped by Dan Bernstein.

Fix license and some sorting in new files.

WebKit/mac:

  • WebView/WebHistoryDelegate.h:
  • WebView/WebNavigationData.h:
  • WebView/WebNavigationData.mm:

WebKitTools:

  • DumpRenderTree/mac/HistoryDelegate.h:
  • DumpRenderTree/mac/HistoryDelegate.mm:
18:46 Changeset [48916] by eric@webkit.org

2009-09-29 Yaar Schnitman <yaar@chromium.org>

Reviewed by David Kilzer.

Fixed how error codes are handled.
https://bugs.webkit.org/show_bug.cgi?id=29898

  • Scripts/update-webkit:
  • Scripts/update-webkit-chromium:
18:36 Changeset [48915] by beidson@apple.com

Updated way-out-of-date sorting throughout the dump methods/flags.

Reviewed by John Sullivan.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(dumpAsPDFCallback):
(dumpAsTextCallback):
(dumpFrameLoadCallbacksCallback):
(dumpResourceLoadCallbacksCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::dumpAsText):
(LayoutTestController::setDumpAsText):
(LayoutTestController::dumpFrameLoadCallbacks):
(LayoutTestController::setDumpFrameLoadCallbacks):
(LayoutTestController::dumpSelectionRect):
(LayoutTestController::setDumpSelectionRect):
(LayoutTestController::dumpSourceAsWebArchive):
(LayoutTestController::setDumpSourceAsWebArchive):
(LayoutTestController::dumpStatusCallbacks):
(LayoutTestController::setDumpStatusCallbacks):
(LayoutTestController::dumpTitleChanges):
(LayoutTestController::setDumpTitleChanges):
(LayoutTestController::dumpWillCacheResponse):
(LayoutTestController::setDumpWillCacheResponse):

18:35 Changeset [48914] by beidson@apple.com

WebKit Mac API should provide a delegate interface for global history.
<rdar://problem/7042773> and https://webkit.org/b/29904

Reviewed by John Sullivan.

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

  • WebView/WebHistoryDelegate.h: Added. New interface for WebKit clients to implement to manage their own global history store.

Object to store all of the bits of data relevant to a page visit:

  • WebView/WebNavigationData.h: Added.
  • WebView/WebNavigationData.mm: Added.

(-[WebNavigationDataPrivate dealloc]):
(-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
(-[WebNavigationData url]):
(-[WebNavigationData title]):
(-[WebNavigationData originalRequest]):
(-[WebNavigationData response]):
(-[WebNavigationData hasSubstituteData]):
(-[WebNavigationData clientRedirectSource]):
(-[WebNavigationData dealloc]):

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::updateGlobalHistory): If the delegate exists, don't use the built-in WebHistory.

If the implementation for this method exists, call it.

(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Ditto

  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebDelegateImplementationCaching.mm:

(WebViewGetHistoryDelegateImplementations):
(CallHistoryDelegate):

  • WebView/WebView.mm:

(-[WebView _cacheHistoryDelegateImplementations]):
(-[WebView setHistoryDelegate:]):
(-[WebView historyDelegate]):

  • WebView/WebViewData.h:
  • WebView/WebViewPrivate.h:

WebKitTools:

Adding the dumping of global history delegate callbacks.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):
(allocateGlobalControllers):
(shouldLogFrameLoadDelegates):
(shouldLogHistoryDelegates):
(runTest):

Dump history delegate callbacks:

  • DumpRenderTree/mac/HistoryDelegate.h: Added.
  • DumpRenderTree/mac/HistoryDelegate.mm: Added.

(-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
(-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
(-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):

LayoutTests:

  • http/tests/globalhistory: Added.
  • http/tests/globalhistory/history-delegate-basic-302-redirect-expected.txt: Added.
  • http/tests/globalhistory/history-delegate-basic-302-redirect.html: Added.
  • http/tests/globalhistory/history-delegate-basic-refresh-redirect-expected.txt: Added.
  • http/tests/globalhistory/history-delegate-basic-refresh-redirect.html: Added.
  • http/tests/resources/notify-done.html: Added.
  • http/tests/resources/redirect.php: Augment to optionally do "Refresh:"-style redirects.

Skip these new tests on all platforms that don't have history delegates (yet):

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
18:07 Changeset [48913] by yong.li@torchmobile.com

2009-09-29 Yong Li <yong.li@torchmobile.com>

Reviewed by Darin Adler.

Add an ASSERT for UTF8Encoding().isValid()
https://bugs.webkit.org/show_bug.cgi?id=29908

  • platform/text/TextEncoding.cpp: (WebCore::UTF8Encoding):
17:32 Changeset [48912] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=29892
Add support for whitelist patterns to control conditional injection of user scripts and
user stylesheets.

Reviewed by Jon Honeycutt.

No new tests. Not testable until WebKit portion is added in followup patch.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::pageGroupUserSheets):

  • page/Frame.cpp:

(WebCore::Frame::injectUserScriptsForWorld):

  • page/UserContentURLPattern.cpp: Added.

(WebCore::UserContentURLPattern::matchesPatterns):
(WebCore::UserContentURLPattern::parse):
(WebCore::UserContentURLPattern::matches):
(WebCore::UserContentURLPattern::matchesHost):
(WebCore::MatchTester::MatchTester):
(WebCore::MatchTester::testStringFinished):
(WebCore::MatchTester::patternStringFinished):
(WebCore::MatchTester::eatWildcard):
(WebCore::MatchTester::eatSameChars):
(WebCore::MatchTester::test):
(WebCore::UserContentURLPattern::matchesPath):

  • page/UserContentURLPattern.h: Added.

(WebCore::UserContentURLPattern::UserContentURLPattern):
(WebCore::UserContentURLPattern::scheme):
(WebCore::UserContentURLPattern::host):
(WebCore::UserContentURLPattern::path):
(WebCore::UserContentURLPattern::matchSubdomains):

16:20 Changeset [48911] by dbates@webkit.org

2009-09-29 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=29837


More tests for the XSSAuditor.

  • http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt: Added.
  • http/tests/security/xssAuditor/embed-tag-javascript-url.html: Added.
  • http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt: Added.
  • http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url.html: Added.
  • http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt: Added.
  • http/tests/security/xssAuditor/object-tag-javascript-url.html: Added.
  • http/tests/security/xssAuditor/property-escape-noquotes-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html: Added.
  • http/tests/security/xssAuditor/property-escape-noquotes.html: Added.
  • http/tests/security/xssAuditor/property-inject-expected.txt: Added.
  • http/tests/security/xssAuditor/property-inject.html: Added.
  • http/tests/security/xssAuditor/resources/echo-head.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-inner-tag.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-property-noquotes.pl: Added.
16:10 Changeset [48910] by eric@webkit.org

2009-09-29 Enrica Casucci <enrica@apple.com>

Reviewed by Adele Peterson.

Test case for <rdar://problem/7085453>.

  • editing/selection/blockquote-crash-expected.txt: Added.
  • editing/selection/blockquote-crash.html: Added.

2009-09-29 Enrica Casucci <enrica@apple.com>

Reviewed by Adele Peterson.

Reproducible crash pressing return inside quoted content
at WebCore::BreakBlockquoteCommand::doApply.
<rdar://problem/7085453>
In some case, like the one provided in the test case, m_downStreamEnd
refers to a node that gets deleted when executing the DeleteSelectionCommand.
We shouldn't use m_downStreamEnd to recalculate the new m_endPosition when
pruning is needed, because it may be point to a node that has been deleted, but
rather rely on removeNode in CompositeEditCommand to update m_endPosition correctly.

Test: editing/selection/blockquote-crash.html

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Added check for invalid position to avoid dereferencing a null node pointer.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Don't reset m_endPosition using the value in m_downStreamEnd when it is necessary to prune the start block.
15:58 Changeset [48909] by ap@apple.com

Reviewed by Brady Eidson.

Basic authentication credentials are not sent automatically to top resources
https://bugs.webkit.org/show_bug.cgi?id=29901

No new tests - I don't want to pollute root directory of http tests to check for this rather
minor issue.

  • platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::set): Changed to always preserve leading slash. (WebCore::CredentialStorage::getDefaultAuthenticationCredential): Made breaking out of the loop more explicit.
15:27 Changeset [48908] by bweinstein@apple.com

Windows build fix.

15:10 Changeset [48907] by pfeldman@chromium.org

2009-09-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Oliver Hunt.

Web Inspector REGRESSION(r47820-r47822): Profiles aren't
added to the inspector unless the inspector is already open
when the profile completes.

https://bugs.webkit.org/show_bug.cgi?id=29897

  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._populateProfiles):
15:06 Changeset [48906] by kenneth@webkit.org

Rubberstamped by David Hyatt.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Fix to logic of earlier commit 48902.

When merging two if's before committing, I forgot to invert the
bool check.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::ignoreHttpError):

14:48 Changeset [48905] by oliver@apple.com

Tidy up codeblock sampler
https://bugs.webkit.org/show_bug.cgi?id=29836

Reviewed by Gavin Barraclough.

Some rather simple refactoring of codeblock sampler so that
it's easier for us to use it to find problems in non-jsc
environments

14:43 Changeset [48904] by senorblanco@chromium.org

Unreviewed, build fix.

Fixing Chromium build, following r48884.

https://bugs.webkit.org/show_bug.cgi?id=29894

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::handleEvent):

  • bindings/v8/V8AbstractEventListener.h:
  • bindings/v8/V8WorkerContextEventListener.cpp:

(WebCore::V8WorkerContextEventListener::handleEvent):

  • bindings/v8/V8WorkerContextEventListener.h:
14:25 Changeset [48903] by eric@webkit.org

2009-09-29 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Update for .maxLength behavior change.
https://bugs.webkit.org/show_bug.cgi?id=29796

  • fast/forms/input-maxlength-expected.txt:
  • fast/forms/input-maxlength.html:
  • fast/forms/script-tests/textarea-maxlength.js:
  • fast/forms/textarea-maxlength-expected.txt:

2009-09-29 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Follows HTML5's maxLength change in September 2009.

  • Change HTMLTextAreaElement.maxLength type to signed.
  • HTMLTextAreaElement.maxLength returns -1 if maxlength= attribute is missing.
  • HTMLTextAreaElement.maxLength and HTMLInputElement.maxLength throw INDEX_SIZE_ERR for setting negative values. https://bugs.webkit.org/show_bug.cgi?id=29796
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setMaxLength):
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent): (WebCore::HTMLTextAreaElement::maxLength): (WebCore::HTMLTextAreaElement::setMaxLength):
  • html/HTMLTextAreaElement.h:
  • html/HTMLTextAreaElement.idl:
14:07 Changeset [48902] by kenneth@webkit.org

Don't rely on QNetworkReply::NetworkError codes, but
on HTTP error codes instead.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::ignoreHttpError):
(WebCore::QNetworkReplyHandler::finish):

14:07 Changeset [48901] by kenneth@webkit.org

Use const references when using Qt's foreach.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

14:07 Changeset [48900] by kenneth@webkit.org

Fix handling of QNetworkReply errors.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

In the QNetworkReplyHandler::finish() a response was sent even when
the reply contained an error. This resulted in a sendResponseIfNeeded()
calling didReceiveResponse on the client, leading to the destruction
of the m_resourceHandle, discontinuing further processing in finish(),
and thus not calling didFail on the client.

Instead it continued as everything went fine, and
FrameLoaderClientQt::dispatchDecidePolicyForMIMEType() changed the
policy to PolicyDownload due to not being able to show the non existing
MIMEType. As the download also obviously fails, it ended up with a
policy change error.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::finish):

14:01 Changeset [48899] by dbates@webkit.org

2009-09-29 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=28902


Fixes an issue where the drop effect returned by Window Dump Render Tree
was always DROPEFFECT_NONE (since it was hard coded to do so).


This patch corrects this issue by determining the actual drop effect
performed by the corresponding drag-and-drop operation so that we can
return it.

  • DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect. (DraggingInfo::DraggingInfo): (DraggingInfo::performedDropEffect): Added method. (DraggingInfo::setPerformedDropEffect): Added method.
  • DumpRenderTree/win/EventSender.cpp: (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect. Moved delete draggingInfo to UIDelegate::doDragDrop.
  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
13:48 Changeset [48898] by jorlow@chromium.org

2009-09-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Add GYP generated files to svn:ignore
https://bugs.webkit.org/show_bug.cgi?id=29895

The following files are generated by JavaScriptCore's GYP file and should be ignored:

pcre.mk
wtf.scons
wtf.mk
SConstruct
wtf_config.scons
wtf_config.mk
pcre.scons

13:42 Changeset [48897] by dglazkov@chromium.org

2009-09-29 Dimitri Glazkov <dglazkov@chromium.org>

No review, rolling out r48894, because review discussion was not complete.
http://trac.webkit.org/changeset/48894

  • platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::begin):
13:29 Changeset [48896] by krit@webkit.org

2009-09-29 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filter feComposite implementation is missing
https://bugs.webkit.org/show_bug.cgi?id=28362

feComposite implementation for SVG.

Test: svg/filters/feComposite.svg

  • platform/graphics/filters/FEComposite.cpp: (WebCore::arithmetic): (WebCore::FEComposite::apply):

Tests the feComposite implementation for SVG.

  • platform/mac/svg/filters/feComposite-expected.checksum: Added.
  • platform/mac/svg/filters/feComposite-expected.png: Added.
  • platform/mac/svg/filters/feComposite-expected.txt: Added.
  • svg/filters/feComposite.svg: Added.
13:28 Changeset [48895] by ggaren@apple.com

Standardized an optimization for adding non-numbers.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29
Reviewed by Sam Weinig.

SunSpider says maybe a tiny speedup.

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):

13:05 Changeset [48894] by eric@webkit.org

2009-09-29 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Starting all read-only transactions with an explicit BEGIN
DEFERRED command instead of BEGIN, since some ports (chromium)
might compile their own SQLite library and set BEGIN to BEGIN
IMMEDIATE by default; which would result in a deadlock in case of
two concurrent read-only transactions on the same DB, and would
unnecessarily delay other potential transactions to the same DB.

https://bugs.webkit.org/show_bug.cgi?id=29729

  • platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::begin):
12:49 Changeset [48893] by dglazkov@chromium.org

WebCore:

2009-09-29 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Add support for run-time flag for 3D canvas
https://bugs.webkit.org/show_bug.cgi?id=29826

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): Check page settings for experimental WebGL flag before returning 3D graphics context.
  • page/Settings.cpp: (WebCore::Settings::Settings): Initialize new flag to false. (WebCore::Settings::setExperimentalWebGLEnabled):
  • page/Settings.h: Set new flag. (WebCore::Settings::experimentalWebGLEnabled): Return new flag.

WebKit/mac:

2009-09-29 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Add support for run-time flag for 3D canvas
https://bugs.webkit.org/show_bug.cgi?id=29826

  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Enable experimental WebGL flag when 3D_CANVAS is enabled in the build.

WebKit/win:

2009-09-29 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Add support for run-time flag for 3D canvas
https://bugs.webkit.org/show_bug.cgi?id=29826

  • WebView.cpp: (WebView::notifyPreferencesChanged): Enable experimental WebGL flag when 3D_CANVAS is enabled in the build.
12:39 Changeset [48892] by jorlow@chromium.org

2009-09-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Chromium needs to be able to override the way storage events are delivered - part 1
https://bugs.webkit.org/show_bug.cgi?id=29889

Chromium needs to be able to override the way storage events are delivered.
This replaced https://bugs.webkit.org/show_bug.cgi?id=29257 because it'll be
faster (no vtables and extra allocation) and somewhat cleaner (no dependency
injection). This is necessary because Chromium needs to transport events across
a process barrier and then dispatch them without use of a Frame*.

This patch should be a no-op for all ports other than Chromium.

  • WebCore.gypi:
  • storage/StorageEventDispatcher.h: Added.
12:15 Changeset [48891] by eric@webkit.org

2009-09-29 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Kilzer.

Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=12140

Change the URLs in dumpAsText tests.

  • editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • editing/deleting/delete-all-text-in-text-field-assertion.html:
  • fast/dom/Document/doc-open-while-parsing.html:
  • fast/dom/Document/document-reopen.html:
  • fast/dom/Element/setAttribute-case-insensitivity.html:
  • fast/dom/HTMLHeadElement/head-check.html:
  • fast/dom/HTMLImageElement/image-without-renderer-width-expected.txt:
  • fast/dom/HTMLImageElement/image-without-renderer-width.html:
  • fast/dom/HTMLScriptElement/script-load-events-expected.txt:
  • fast/dom/HTMLScriptElement/script-load-events.html:
  • fast/dom/clone-node-form-elements-with-attr.html:
  • fast/dom/document-dir-property-expected.txt:
  • fast/dom/document-dir-property.html:
  • fast/dom/everything-to-string.html:
  • fast/dom/generic-form-element-assert-expected.txt:
  • fast/dom/generic-form-element-assert.html:
  • fast/dom/inner-text-rtl-expected.txt:
  • fast/dom/inner-text-rtl.html:
  • fast/dom/navigator-vendorSub.html:
  • fast/dom/option-properties-expected.txt:
  • fast/dom/option-properties.html:
  • fast/dom/replace-child-siblings-expected.txt:
  • fast/dom/replace-child-siblings.html:
  • fast/dom/replace-first-child.html:
  • fast/dom/setAttribute-using-initial-input-value.html:
  • fast/dom/space-to-text.html:
  • fast/dynamic/hovered-detach-expected.txt:
  • fast/dynamic/hovered-detach.html:
  • fast/encoding/charset-koi8-u.html:
  • fast/encoding/css-charset-dom.html:
  • fast/encoding/css-charset-evil.html:
  • fast/encoding/css-charset.html:
  • fast/encoding/latin1-winlatin.html:
  • fast/encoding/mispositioned-meta.html:
  • fast/encoding/percent-escaping.html:
  • fast/encoding/pseudo-xml-2.html:
  • fast/encoding/pseudo-xml-3.html:
  • fast/encoding/pseudo-xml-4.html:
  • fast/encoding/pseudo-xml.html:
  • fast/events/init-event-null-view.html:
  • fast/events/mouseover-mouseout.html:
  • fast/events/mouseover-mouseout2.html:
  • fast/events/onload-webkit-before-webcore.html:
  • fast/forms/button-in-forms-collection.html:
  • fast/forms/document-write.html:
  • fast/forms/domstring-replace-crash-expected.txt:
  • fast/forms/domstring-replace-crash.html:
  • fast/forms/element-by-name.html:
  • fast/forms/empty-get.html:
  • fast/forms/form-data-encoding-normalization-overrun.html:
  • fast/forms/radio-button-no-change-event.html:
  • fast/forms/selected-index-assert-expected.txt:
  • fast/forms/selected-index-assert.html:
  • fast/forms/textarea-hard-linewrap-empty-expected.txt:
  • fast/forms/textarea-hard-linewrap-empty.html:
  • fast/forms/textfield-focus-out-expected.txt:
  • fast/forms/textfield-focus-out.html:
  • fast/frames/empty-frame-document-expected.txt:
  • fast/frames/empty-frame-document.html:
  • fast/frames/frame-name-reset.html:
  • fast/frames/frame-set-same-location.html:
  • fast/frames/frame-set-same-src.html:
  • fast/frames/frameElement-widthheight.html:
  • fast/frames/iframe-name-and-id-expected.txt:
  • fast/frames/iframe-name-and-id.html:
  • fast/frames/iframe-set-same-location.html:
  • fast/frames/iframe-set-same-src.html:
  • fast/frames/repaint-display-none-crash-expected.txt:
  • fast/frames/repaint-display-none-crash.html:
  • fast/js/exception-linenums-in-html-2.html:
  • fast/js/missing-title-end-tag-js.html:
  • fast/loader/link-no-URL.html:
  • fast/loader/url-strip-cr-lf-tab.html:
  • fast/overflow/generated-content-crash-expected.txt:
  • fast/overflow/generated-content-crash.html:
  • fast/parser/number-sign-in-map-name.html:
  • fast/parser/remove-current-node-parent.html:
  • fast/parser/script-after-frameset-assert.html:
  • fast/tokenizer/image-empty-crash-expected.txt:
  • fast/tokenizer/image-empty-crash.html:
  • fast/tokenizer/nested-cached-scripts-expected.txt:
  • fast/tokenizer/nested-cached-scripts.html:
  • fast/tokenizer/write-unclosed-script-expected.txt:
  • fast/tokenizer/write-unclosed-script.html:
  • fast/xsl/transformToFragment-XML-declaration.html:
  • http/tests/misc/text-refresh.html:
  • http/tests/plugins/npapi-response-headers.html:
  • http/tests/uri/utf8-path.html:
  • http/tests/xmlhttprequest/cache-override.html:
  • http/tests/xmlhttprequest/event-listener-gc-expected.txt:
  • http/tests/xmlhttprequest/event-listener-gc.html:
  • http/tests/xmlhttprequest/event-target.html:
  • http/tests/xmlhttprequest/frame-load-cancelled-abort.html:
  • http/tests/xmlhttprequest/interactive-state.html:
  • http/tests/xmlhttprequest/methods-async.html:
  • http/tests/xmlhttprequest/methods-lower-case.html:
  • http/tests/xmlhttprequest/methods.html:
  • http/tests/xmlhttprequest/post-content-type.html:
  • http/tests/xmlhttprequest/readystatechange.html:
  • http/tests/xmlhttprequest/supported-xml-content-types.html:
  • http/tests/xmlhttprequest/xhr-onunload.html:
  • http/tests/xmlhttprequest/zero-length-response.html:
  • platform/mac/fast/events/objc-event-api.html:
  • platform/mac/fast/events/objc-keyboard-event-creation.html:
  • plugins/get-empty-url.html:
  • plugins/geturl-replace-query.html:
  • plugins/invoke.html:
  • plugins/mouse-events.html:
12:01 Changeset [48890] by oliver@apple.com

Adding file missed in previous commit.

11:51 Changeset [48889] by dglazkov@chromium.org

2009-09-29 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

[V8] Correct an issue with XMLHttpRequest attribute event listeners never being cleared.
https://bugs.webkit.org/show_bug.cgi?id=29888

Test: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-abort-readyState-shouldDispatchEvent.html

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::getEventListener): Added isAttribute parameter. (WebCore::ACCESSOR_SETTER): Made all event listener setters create attribute listeners. (WebCore::CALLBACK_FUNC_DECL): Made addEventListener create object listener.
11:40 Changeset [48888] by oliver@apple.com

[GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images
https://bugs.webkit.org/show_bug.cgi?id=29654

Patch by Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Eric Seidel

Added an additional manual-test for this issue to the existing Gtk
cursor image test.

11:39 Changeset [48887] by ap@apple.com

Reviewed by Timothy Hatcher.

Build fix - pass a proper ScriptExecutipnContext to getEventListenerHandlerBody()

  • bindings/js/ScriptEventListener.cpp: (WebCore::getEventListenerHandlerBody):
  • bindings/js/ScriptEventListener.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::getEventListenerHandlerBody):
  • bindings/v8/ScriptEventListener.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForEventListener):
11:37 Changeset [48886] by japhet@chromium.org

2009-09-29 Nate Chapin <japhet@chromium.org>

Reviewed by Eric Seidel.

Ensure that we don't scroll lock to an anchor node after a
user-initiated scroll, even if that scroll doesn't propagate
all the way up to FrameView.

Test: fast/events/node-event-anchor-lock.html

11:12 Changeset [48885] by ggaren@apple.com

Windows build fix: export a new symbol.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29

11:05 Changeset [48884] by ap@apple.com

Reviewed by Darin Adler and Sam Weinig.

Onclick not fired for an element copied with cloneContents() or cloneNode()
https://bugs.webkit.org/show_bug.cgi?id=25130

The change here is that JS event listeners don't keep a reference to a global object from
where they were created, and instead take it as a parameter when parsing source code. Also,
the listener creation won't fail just because it happens for an element in a frameless
document.
Thus, moving nodes between documents no longer results in having incorrect registered
lazy event listeners on them.

Tests: fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html

fast/events/attribute-listener-cloned-from-frameless-doc-context.html
fast/events/attribute-listener-cloned-from-frameless-doc.xhtml
fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html
fast/events/attribute-listener-extracted-from-frameless-doc-context.html

  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): Don't take a reference to JSDOMGlobalObject. (WebCore::JSEventListener::jsFunction): Take ScriptExecutionContext as a parameter for getting to JSDOMGlobalObject. It's not used in base class, but is in JSLazyEventListner. (WebCore::JSEventListener::markJSFunction): Don't mark the global object. (WebCore::JSEventListener::handleEvent): Get global object from ScriptExecutionContext. (WebCore::JSEventListener::reportError): Ditto.
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::create): Don't keep a reference to JSDOMGlobalObject.
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Listener creation was split between this function and ScriptEventListener; moved it here, as JS global object can be different now.
  • bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::create): Keep source URL, which can not be determined at parsing time.
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Moved code for listener creation to JSLazyEventListener. XSSAuditor code remains here, because tests expect that errors are logged at document parsing time, and because I don't know what other side effects moving it vould have.
  • dom/EventListener.h: handleEvent() and reportError() now take ScriptExecutionContext, because JSC needs a global context here.
  • bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::JSAbstractWorker::addEventListener): (WebCore::JSAbstractWorker::removeEventListener):
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener):
  • bindings/js/JSEventSourceCustom.cpp: (WebCore::JSEventSource::addEventListener): (WebCore::JSEventSource::removeEventListener):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  • bindings/objc/ObjCEventListener.h:
  • bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::handleEvent):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/EventTarget.cpp: (WebCore::EventTarget::fireEventListeners):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::handleEvent):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::handleEvent):
  • inspector/InspectorDOMStorageResource.h:
  • loader/ImageDocument.cpp: (WebCore::ImageEventListener::handleEvent):
  • svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::handleEvent):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::reportException): Don't pass global object to JSEventListener::create(), which no longer needs it. Note that some of these functions still have an early return for null global object, which can probably be removed in a later patch. Pass ScriptExecutionContext to EventListener methods that now need it.
  • bindings/scripts/CodeGeneratorCOM.pm: Don't force EventTarget implementation on Node - it doesn't work yet (it didn't quite work before this patch, too, because it assumed that any object implementing EventTarget COM interface originated from WebCore).
  • dom/EventListener.idl: Just like in ObjC, EventListener should be a pure interface in COM bindings.

WebKit/win:

  • DOMCreateInstance.cpp: GEN_DOMEventListener is a pure interface now.
  • WebKit.vcproj/WebKit.vcproj: Removed GEN_DOMEventListener.cpp.
10:54 Changeset [48883] by ggaren@apple.com

Removed virtual destructor from JSGlobalObjectData to eliminate pointer
fix-ups when accessing JSGlobalObject::d.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28
Reviewed by Sam Weinig.

JavaScriptCore:

Replaced with an explicit destructor function pointer.

6% speedup on bench-alloc-nonretained.js.

(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::destroyJSGlobalObjectData):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
(JSC::JSGlobalObject::JSGlobalObject):

JavaScriptGlue:

Replaced with an explicit destructor function pointer.

  • JSRun.cpp:

(JSGlueGlobalObject::destroyData):

  • JSRun.h:

(JSGlueGlobalObject::Data::Data):

WebCore:

Replaced with an explicit destructor function pointer.

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::destroyJSDOMGlobalObjectData):

  • bindings/js/JSDOMGlobalObject.h:

(WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):

10:44 Changeset [48882] by kenneth@webkit.org

The code for showing error pages when the response was
a 401/403/404, was not actually doing so. This patch
fixes that.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::finish):

09:43 Changeset [48881] by mitz@apple.com

Remove copying of unnecessary or nonexistent files from the ImageDiff
post-build event.

Reviewed by Adam Roben.

  • DumpRenderTree/win/ImageDiff.vcproj:
09:19 Changeset [48880] by eric@webkit.org

2009-09-29 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by David Kilzer.

[Qt] Make build-webkit script work on Windows
https://bugs.webkit.org/show_bug.cgi?id=29802

  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
    • Removed unnecessary -p switch for mkdir on Windows.
    • Use canonical path, which uses slashes or backslashes depends on platform.
    • isWindows() only test for Windows and not for Cyqwin.
09:19 Changeset [48879] by ap@apple.com

Reviewed by Brady Eidson.

<rdar://problem/7259965> REGRESSION: http/tests/xmlhttprequest/cross-origin-authorization.html
is failing/crashing intermittently
https://bugs.webkit.org/show_bug.cgi?id=29322

This was caused by CStringBuffer::encodeBase64() returning a buffer that wasn't zero terminated.
The code had other issues as well, so I removed it altogether:

  • it claimed to avoid some buffer copies, but it didn't;
  • and I don't think that base64 encoding should be part of CString interface.

WebCore:

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::encodeBasicAuthorization): Encode username and password using Base64.h directly. (WebCore::ResourceHandle::start): Use encodeBasicAuthorization(). (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Ditto. (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Extended logging to synchronous case. (-[WebCoreSynchronousLoader connectionShouldUseCredentialStorage:]): Ditto. (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto. (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto. (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto. (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.
  • platform/network/cf/ResourceHandleCFNet.cpp: Matched Mac changes.
  • platform/text/CString.cpp:
  • platform/text/CString.h: (WebCore::CStringBuffer::create): (WebCore::CStringBuffer::CStringBuffer): Removed code that was added for Base64 in r48363.

LayoutTests:

  • http/tests/xmlhttprequest/cross-origin-authorization.html: While at it, made the test detect more error conditions
09:10 Changeset [48878] by eric@webkit.org

2009-09-29 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by David Kilzer.

[Qt] Assert messages prints visible in Symbian
https://bugs.webkit.org/show_bug.cgi?id=29808

Asserts use vprintf to print the messages to stderr.
In Symbian Open C it is not possible to see stderr so
I routed the messages to stdout instead.

  • wtf/Assertions.cpp:
08:18 Changeset [48877] by xan@webkit.org

2009-09-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not set a non-default parent window for child widgets. We are
just doing the same than the default path does, and on top of that
if the widget's window changes (for example, during DnD widgets
are usually unrealized/realized) the child widget will we left
pointing to a dead window.

For examples of crashers caused by this see
https://bugzilla.gnome.org/show_bug.cgi?id=596397 and
https://bugzilla.gnome.org/show_bug.cgi?id=596398

  • webkit/webkitwebview.cpp: (webkit_web_view_container_add):
08:00 Changeset [48876] by eric@webkit.org

2009-09-29 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Fix typo in Localizations.cpp

https://bugs.webkit.org/show_bug.cgi?id=29872

  • platform/qt/Localizations.cpp: (WebCore::localizedMediaControlElementHelpText):
07:45 Changeset [48875] by hausmann@webkit.org

Make the XSLT conditional in DOMWindow.idl's xsltProcessor
attribute conditional in the generated files, similar to
r44116.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-29
Reviewed by Tor Arne Vestbø.

  • page/DOMWindow.idl:
07:40 Changeset [48874] by zoltan@webkit.org

2009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Fix time measurement in build-webkit after refactoring done in r48853.

  • Scripts/build-webkit:
07:25 Changeset [48873] by vestbo@webkit.org

[Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.

This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-29
Reviewed by Tor Arne Vestbø.

Done together with Renata Hodovan <renata.hodovan@stud.u-szeged.hu>

07:06 Changeset [48872] by hausmann@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=29844

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2009-09-29
Reviewed by Simon Hausmann.

QWebPage dependency autotest fix.

Fix for database() autotest. All opened databases should be removed at
end of test.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::database):

07:06 Changeset [48871] by hausmann@webkit.org

Some QWebHistory and QWebPage autotest crash fixes.

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2009-09-29
Reviewed by Simon Hausmann.

Some checking for m_mainFrame were added. MainFrame should be created
at some point of QWebPage live cicle.

https://bugs.webkit.org/show_bug.cgi?id=29803

  • Api/qwebpage.cpp:

(QWebPage::~QWebPage):
(QWebPage::currentFrame):
(QWebPage::history):
(QWebPage::selectedText):
(QWebPage::updatePositionDependentActions):

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::crashTests_LazyInitializationOfMainFrame):

06:55 Changeset [48870] by kenneth@webkit.org

WebCore: Use the ResourceError as it is supposed to and handle
not HTTP errors from QNetworkReply.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

Thanks to Adam Roben for his input.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::finish):

WebKit/qt: Implement QWebPage Extension for error pages, incl.
an example on how to use it in QtLauncher.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

Correct our use of ResourceError.

  • Api/qwebpage.h:

(ExtensionOption::):
(ExtensionOption::ErrorPageExtensionReturn::ErrorPageExtensionReturn):

  • QtLauncher/main.cpp:

(WebPage::supportsExtension):
(MainWindow::MainWindow):
(MainWindow::selectElements):
(WebPage::extension):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::cancelledError):
(WebCore::FrameLoaderClientQt::blockedError):
(WebCore::FrameLoaderClientQt::cannotShowURLError):
(WebCore::FrameLoaderClientQt::interruptForPolicyChangeError):
(WebCore::FrameLoaderClientQt::cannotShowMIMETypeError):
(WebCore::FrameLoaderClientQt::fileDoesNotExistError):
(WebCore::FrameLoaderClientQt::callErrorPageExtension):
(WebCore::FrameLoaderClientQt::dispatchDidFailProvisionalLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFailLoad):

  • WebCoreSupport/FrameLoaderClientQt.h:
05:20 Changeset [48869] by eric@webkit.org

2009-09-29 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Darin Adler.

[Qt] Symbian CRASH macro implementation

Added Symbian specific crash macro that
stops to crash line if JIT debugging is used.
Additional differentiation of access violation
(KERN-EXEC 3) and CRASH panic.

  • wtf/Assertions.h:
04:43 Changeset [48868] by zoltan@webkit.org

2009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Update Skipped list after test refactoring done in r48806.

  • platform/qt/Skipped:
03:15 QtWebKitContrib edited by hausmann@webkit.org
(diff)
03:12 QtWebKitTodo edited by hausmann@webkit.org
(diff)
03:11 QtWebKitTodo edited by hausmann@webkit.org
(diff)
02:56 Changeset [48867] by eric@webkit.org

2009-09-29 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Unskip the passing tests that make use of eventSender.contextClick().
https://bugs.webkit.org/show_bug.cgi?id=29821

  • platform/qt/Skipped:
02:53 Changeset [48866] by pfeldman@chromium.org

2009-09-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Encapsulate JS listeners specifics into ScriptEventListener.

https://bugs.webkit.org/show_bug.cgi?id=29816

  • bindings/js/ScriptEventListener.cpp: (WebCore::getEventListenerHandlerBody):
  • bindings/js/ScriptEventListener.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::getEventListenerHandlerBody):
  • bindings/v8/ScriptEventListener.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForEventListener):
02:48 Changeset [48865] by xan@webkit.org

2009-09-29 Xan Lopez <xlopez@igalia.com>

Unreviewed attempt to fix the build.

  • page/Settings.cpp: (WebCore::Settings::Settings):
02:48 Changeset [48864] by eric@webkit.org

2009-09-29 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement eventSender.contextClick().
https://bugs.webkit.org/show_bug.cgi?id=29821

  • DumpRenderTree/qt/jsobjects.cpp: (EventSender::contextClick):
  • DumpRenderTree/qt/jsobjects.h:
01:57 Changeset [48863] by ukai@chromium.org

2009-09-29 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed. Fix 4 layout test failures by webkit r48861.
http://bugs.webkit.org/show_bug.cgi?id=29840

r48861 introduced experimentalWebSocketsEnabled, and false by default.
When experimentalWebSocketsEnabled is false, window.WebSocket is
undefined, instead of a constructor.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
00:22 Changeset [48862] by bweinstein@apple.com

Fix the build by fixing a typo.

00:02 Changeset [48861] by ukai@chromium.org

2009-09-28 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Add experimentalWebSocketsEnabled in Settings.
https://bugs.webkit.org/show_bug.cgi?id=28941

  • WebCore.base.exp:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webSocket):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor):
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setExperimentalWebSocketsEnabled):
  • page/Settings.h: (WebCore::Settings::experimentalWebSocketsEnabled):

2009-09-28 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Add experimentalWebSocketsEnabled in WebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=28941

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences experimentalWebSocketsEnabled]): (-[WebPreferences setExperimentalWebSocketsEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2009-09-28 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Add experimentalWebSocketsEnabled in WebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=28941

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::setExperimentalWebSocketsEnabled): (WebPreferences::experimentalWebSocketsEnabled):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged): (core):

2009-09-28 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Add experimentalWebSocketsEnabled in WebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=28941

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):

09/28/09:

22:51 Changeset [48860] by mrowe@apple.com

Fix the PowerPC build.

22:42 Changeset [48859] by ukai@chromium.org

2009-09-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Adam Barth.

Add platform code to support WebSocket for chromium.
https://bugs.webkit.org/show_bug.cgi?id=29171

To build within chromium tree, it requires a patch in bug 29174.
Real implementation will be landed in chromium tree.

  • WebCore.gypi:
  • platform/network/chromium/SocketStreamError.h: Added. (WebCore::SocketStreamError::SocketStreamError):
  • platform/network/chromium/SocketStreamHandle.h: Added. (WebCore::SocketStreamHandle::create):
22:16 Changeset [48858] by xan@webkit.org

2009-09-29 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Eric Seidel.

[Gtk] Crash when saving a password
https://bugs.webkit.org/show_bug.cgi?id=28070

Disconnect the 'got-headers' callback when we are done with
it. The signal can be emitted more than once if the message is
retransmitted, but each time that happens authData is created
again and a new callback connected, so we have to get rid of the
old one (which will crash because we free authData).

  • webkit/webkitsoupauthdialog.c: (save_password_callback):
21:57 Changeset [48857] by mrowe@apple.com

Versioning.

21:56 Changeset [48856] by mrowe@apple.com

Merge r48854.

21:53 Changeset [48855] by mrowe@apple.com

New tag.

21:51 Changeset [48854] by mrowe@apple.com

<rdar://problem/7195704> JavaScriptCore fails to mark registers when built for x86_64 using LLVM GCC.

Reviewed by Gavin Barraclough.

  • runtime/Collector.cpp:

(JSC::Heap::markCurrentThreadConservatively): Force jmp_buf to use the appropriate alignment for a pointer
to ensure that we correctly interpret the contents of registers during marking.

21:01 Changeset [48853] by ddkilzer@apple.com

2009-09-28 Yaar Schnitman <yaar@chromium.org>

Reviewed by David Kilzer.

Integrated chromium port building into webkit tools update-webkit and
build-webkit.

https://bugs.webkit.org/show_bug.cgi?id=29749

  • Scripts/build-webkit: When --chromium is specified, will build the chromium port (currently only Mac is supported).
  • Scripts/update-webkit: When --chromium is specified, delegates to update-webkit-chromium.
  • Scripts/webkitdirs.pm: Added chromium specific defs.
  • Scripts/update-webkit-chromium: Uses gclient and gyp to fetch chromium port's dependencies and update its project files.
18:48 Changeset [48852] by ukai@chromium.org

2009-09-28 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed.

Add myself to list of committers.

  • Scripts/modules/committers.py:
18:10 Changeset [48851] by eric@webkit.org

2009-09-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by David Kilzer.

[Gtk][Layout tests] Generate results for css3 tests
https://bugs.webkit.org/show_bug.cgi?id=29784

Add results for css3 tests and enable these tests in the Skipped.

  • platform/gtk/Skipped:
  • platform/gtk/css3/css3-modsel-33-expected.txt: Added.
  • platform/gtk/css3/css3-modsel-35-expected.txt: Added.
  • platform/gtk/css3/css3-modsel-36-expected.txt: Added.
  • platform/gtk/css3/css3-modsel-37-expected.txt: Added.
17:47 Changeset [48850] by eric@webkit.org

2009-09-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by David Kilzer.

[Gtk][Layout tests] Generate results for transitions tests
https://bugs.webkit.org/show_bug.cgi?id=29786

Add results for transitions tests and enable these tests in the Skipped.

  • platform/gtk/Skipped:
  • platform/gtk/transitions/transition-drt-api-expected.txt: Added.
17:35 Changeset [48849] by eric@webkit.org

2009-09-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by David Kilzer.

[Gtk][Layout tests] Generate results for animations tests
https://bugs.webkit.org/show_bug.cgi?id=29783

Add results for animations tests and enable these tests in the Skipped.

  • platform/gtk/Skipped:
  • platform/gtk/animations/animation-drt-api-expected.txt: Added.
  • platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt: Added.
17:28 Changeset [48848] by mitz@apple.com

<rdar://problem/7157288> Crash in RenderStyle::computedLineHeight()
when Times New Roman is not installed

Reviewed by Sam Weinig.

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::getLastResortFallbackFont): If Times New Roman is
not available, use the Windows default GUI font.

17:27 Changeset [48847] by eric@webkit.org

2009-09-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by David Kilzer.

[Gtk][Layout tests] Generate results for transforms tests
https://bugs.webkit.org/show_bug.cgi?id=29785

Add results for transforms tests and enable these tests in the Skipped.

  • platform/gtk/Skipped:
  • platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
  • platform/gtk/transforms/2d/transform-borderbox-expected.txt: Added.
  • platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt: Added.
  • platform/gtk/transforms/no_transform_hit_testing-expected.txt: Added.
16:56 Changeset [48846] by jianli@chromium.org

Do not add platform-specific methods to cross-platform header
FileSystem.h per Darin's feedback for 29109.
https://bugs.webkit.org/show_bug.cgi?id=29830

Reviewed by David Levin.

  • platform/FileSystem.h:
  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):

  • platform/chromium/FileSystemChromium.cpp:
16:35 WebKit Team edited by ukai@chromium.org
add ukai (diff)
16:33 Changeset [48845] by eric@webkit.org

2009-09-28 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Register Chromium's VFSs with a proper sqlite3_io_methods
finder. This should only affect the POSIX implementation. The
Windows change is included for consistency and in case sqlite
starts using something similar in its Windows VFS in the future.

https://bugs.webkit.org/show_bug.cgi?id=29743

  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):
16:25 Changeset [48844] by eric@webkit.org

2009-09-28 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Update the Skipped list after adding XSLT support.
https://bugs.webkit.org/show_bug.cgi?id=29817

Remove the tests that are passing now and skip these that are not,
with a reason of failure for each of them.

  • platform/qt/Skipped:
15:58 Changeset [48843] by ddkilzer@apple.com

2009-09-28 Alex Milowski <alex@milowski.com>

<http://webkit.org/b/29098> Update to MathML project webpage

Reviewed by David Kilzer.

Updated MathML project page and added link to Wiki page.

  • projects/mathml/index.html:
15:50 Changeset [48842] by eric@webkit.org

2009-09-28 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

11 transforms/3d tests failing on the Leopard Debug bot after r48833
https://bugs.webkit.org/show_bug.cgi?id=29828

Leopard has HW compositing disabled until rdar://problem/7228836 can be fixed.
So skip tests which depend on it being enabled per Simon's request.

  • platform/mac-leopard/Skipped:
15:25 Changeset [48841] by japhet@chromium.org

2009-09-28 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Change the V8 bindings' handling of window.toString(),
so we return [object DOMWindow] (like JSC), not [object global].

https://bugs.webkit.org/show_bug.cgi?id=29742

This will fix a couple of Chromium port test failures and enable us to
use the default expectations for a bunch more.

15:23 Changeset [48840] by ggaren@apple.com

Windows build fix: added new exports.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28

15:16 Changeset [48839] by mrowe@apple.com

Roll out r48825. It causes build failures by calling an undefined function from within RefPtr.h.

15:06 Changeset [48838] by japhet@chromium.org

2009-09-28 Nate Chapin <japhet@chromium.org>

Rubber stamped by David Levin.

Chromium build fix, add back in #include of V8Proxy.h in V8WebKitPointConstructor.cpp.

  • bindings/v8/custom/V8WebKitPointConstructor.cpp: Re-include V8Proxy.h.
15:06 Changeset [48837] by ggaren@apple.com

Windows build fix: removed exports that no longer exist.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28

14:45 Changeset [48836] by ggaren@apple.com

NotNullPassRefPtr: smart pointer optimized for passing references that are not null
https://bugs.webkit.org/show_bug.cgi?id=29822

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28
Reviewed by Darin Adler.

JavaScriptCore:

Added NotNullPassRefPtr, and deployed it in all places that initialize
JavaScript objects.

2.2% speedup on bench-allocate-nonretained.js.

  • API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::JSCallbackConstructor):

  • API/JSCallbackConstructor.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject::JSCallbackObject):

(JSC::CodeBlock::addFunctionDecl):
(JSC::CodeBlock::addFunctionExpr):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::ArrayConstructor):

  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::ArrayPrototype):

  • runtime/ArrayPrototype.h:
  • runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::BooleanConstructor):

  • runtime/BooleanConstructor.h:
  • runtime/BooleanObject.cpp:

(JSC::BooleanObject::BooleanObject):

  • runtime/BooleanObject.h:
  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::BooleanPrototype):

  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::DateConstructor):

  • runtime/DateConstructor.h:
  • runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):

  • runtime/DateInstance.h:
  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype):

  • runtime/DatePrototype.h:
  • runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::ErrorConstructor):

  • runtime/ErrorConstructor.h:
  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

  • runtime/ErrorInstance.h:
  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):

  • runtime/ErrorPrototype.h:
  • runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::FunctionConstructor):

  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::FunctionPrototype):

  • runtime/FunctionPrototype.h:
  • runtime/GlobalEvalFunction.cpp:

(JSC::GlobalEvalFunction::GlobalEvalFunction):

  • runtime/GlobalEvalFunction.h:
  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):

  • runtime/InternalFunction.h:

(JSC::InternalFunction::InternalFunction):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):

  • runtime/JSActivation.h:

(JSC::JSActivation::JSActivationData::JSActivationData):

  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::JSByteArray):

  • runtime/JSByteArray.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::JSGlobalObject):

  • runtime/JSONObject.h:

(JSC::JSONObject::JSONObject):

  • runtime/JSObject.h:

(JSC::JSObject::JSObject):
(JSC::JSObject::setStructure):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::JSVariableObject):

  • runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::JSWrapperObject):

  • runtime/MathObject.cpp:

(JSC::MathObject::MathObject):

  • runtime/MathObject.h:
  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::NativeErrorConstructor):

  • runtime/NativeErrorConstructor.h:
  • runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):

  • runtime/NativeErrorPrototype.h:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::NumberConstructor):

  • runtime/NumberConstructor.h:
  • runtime/NumberObject.cpp:

(JSC::NumberObject::NumberObject):

  • runtime/NumberObject.h:
  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::NumberPrototype):

  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::ObjectConstructor):

  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype):

  • runtime/ObjectPrototype.h:
  • runtime/PropertyNameArray.h:

(JSC::PropertyNameArrayData::setCachedPrototypeChain):

  • runtime/PrototypeFunction.cpp:

(JSC::PrototypeFunction::PrototypeFunction):

  • runtime/PrototypeFunction.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::RegExpConstructor):

  • runtime/RegExpConstructor.h:
  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::RegExpObject):

  • runtime/RegExpObject.h:

(JSC::RegExpObject::RegExpObjectData::RegExpObjectData):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):

  • runtime/RegExpPrototype.h:
  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):

  • runtime/StringConstructor.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::StringObject):

  • runtime/StringObject.h:
  • runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::StringPrototype):

  • runtime/StringPrototype.h:
  • wtf/PassRefPtr.h:

(WTF::NotNullPassRefPtr::NotNullPassRefPtr):
(WTF::NotNullPassRefPtr::~NotNullPassRefPtr):
(WTF::NotNullPassRefPtr::get):
(WTF::NotNullPassRefPtr::clear):
(WTF::NotNullPassRefPtr::releaseRef):
(WTF::NotNullPassRefPtr::operator*):
(WTF::NotNullPassRefPtr::operator->):
(WTF::NotNullPassRefPtr::operator!):
(WTF::NotNullPassRefPtr::operator UnspecifiedBoolType):

  • wtf/RefPtr.h:

(WTF::RefPtr::RefPtr):
(WTF::operator==):

WebCore:

Added NotNullPassRefPtr, and deployed it in all places that initialize
JavaScript objects.

  • bindings/js/DOMObjectWithSVGContext.h:

(WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::cacheDOMStructure):

  • bindings/js/JSDOMBinding.h:

(WebCore::DOMObject::DOMObject):
(WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):

  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSHTMLAllCollection.h:

(WebCore::JSHTMLAllCollection::JSHTMLAllCollection):

  • bindings/js/JSInspectedObjectWrapper.cpp:

(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):

  • bindings/js/JSInspectedObjectWrapper.h:
  • bindings/js/JSInspectorCallbackWrapper.cpp:

(WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):

  • bindings/js/JSInspectorCallbackWrapper.h:
  • bindings/js/JSQuarantinedObjectWrapper.cpp:

(WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):

  • bindings/js/JSQuarantinedObjectWrapper.h:
  • bindings/js/JSWorkerContextBase.cpp:

(WebCore::JSWorkerContextBase::JSWorkerContextBase):

  • bindings/js/JSWorkerContextBase.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/runtime_object.cpp:

(JSC::RuntimeObjectImp::RuntimeObjectImp):

  • bridge/runtime_object.h:
14:38 Changeset [48835] by eric@webkit.org

2009-09-28 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Add the expected result for the fast/xsl/document-function test.
https://bugs.webkit.org/show_bug.cgi?id=29817

  • platform/qt/fast/xsl/document-function-expected.txt: Added.
14:30 Changeset [48834] by eric@webkit.org

2009-09-28 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Allow V8 to handle x/y parameters in a WebKitPoint constructor.
https://bugs.webkit.org/show_bug.cgi?id=29823

Fixes V8's handling of LayoutTests/fast/dom/Window/webkitConvertPoint.html

  • bindings/v8/custom/V8WebKitPointConstructor.cpp: Allow for x/y parameters in constructor.
14:22 Changeset [48833] by eric@webkit.org

2009-09-25 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
https://bugs.webkit.org/show_bug.cgi?id=28624

No longer skip media tests now that we're disabling hardware compositing instead.
Add leopard-specific results for 2 tests expected to fail with HW compositing disabled.

  • platform/mac-leopard/Skipped:
  • platform/mac-leopard/fast/media/mq-transform-02-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.checksum.
  • platform/mac-leopard/fast/media/mq-transform-02-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.png.
  • platform/mac-leopard/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.txt.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.checksum.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.png.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.txt.

2009-09-27 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Darin Adler.

run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
https://bugs.webkit.org/show_bug.cgi?id=29771

  • Scripts/run-webkit-tests:
13:57 Changeset [48832] by mrowe@apple.com

Fix the build by doing something approximating reasonableness in the Xcode project.

  • WebCore.xcodeproj/project.pbxproj:
13:55 Changeset [48831] by mitz@apple.com

<rdar://problem/7240911> REGRESSION (r48586): Crash occurs when loading
a PDF

Reviewed by Anders Carlsson.

CGPDFObjectRef is not a CFTypeRef, and cannot be retained or released.
Its lifetime is managed by its container. Just use a Vector to store
CGPDFObjectRefs, relying on the CGPDFDocument to keep them alive.

  • WebView/WebPDFDocumentExtras.mm:

(appendValuesInPDFNameSubtreeToVector):
(getAllValuesInPDFNameTree):
(web_PDFDocumentAllScripts):

13:42 Changeset [48830] by oliver@apple.com

Hard dependency on SSE2 instruction set with JIT
https://bugs.webkit.org/show_bug.cgi?id=29779

Reviewed by Geoff Garen

Add floating point support checks to op_jfalse and op_jtrue, and
fix the logic for the slow case of op_add

13:41 Changeset [48829] by hausmann@webkit.org

Prospective Tiger build fix.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-09-28

  • WebCore.xcodeproj/project.pbxproj: Try to use unique IDs for the new files.
13:33 Changeset [48828] by pfeldman@chromium.org

2009-09-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add explicit frontend event for commit load.

https://bugs.webkit.org/show_bug.cgi?id=29814

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didCommitLoad):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._setDocument):
  • inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.didCommitLoad):
13:30 Changeset [48827] by eric@webkit.org

2009-09-28 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium port - recognize we are being built independently
of chromium and look for dependencies under webkit/chromium rather
than chromium/src.

https://bugs.webkit.org/show_bug.cgi?id=29722

2009-09-28 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium port - recognize we are being built independently
of chromium and look for dependencies under webkit/chromium rather
than chromium/src.

https://bugs.webkit.org/show_bug.cgi?id=29722

  • WebCore.gyp/WebCore.gyp: See above. Also removed a few files from the sources list, since they are not supposed to be built here.

2009-09-28 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=29722

  • chromium/DEPS: Describes the chromium port's dependencies and is used by gclient to fetch them.
  • chromium/webkit.gyp: Currently only builds webcore but in the future will also build the webkit api.
13:11 Changeset [48826] by hausmann@webkit.org

[Qt] Implement XSLT support with QtXmlPatterns.
https://bugs.webkit.org/show_bug.cgi?id=28303

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
Reviewed by Simon Hausmann.

JavaScriptCore:

  • wtf/Platform.h: Add a WTF_USE_QXMLQUERY #define.

WebCore:

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setTransformSource):

  • dom/Document.h:

(WebCore::Document::transformSource):

  • dom/TransformSource.h: Added.

(WebCore::TransformSource::platformSource):

  • dom/TransformSourceLibxslt.cpp: Added.

(WebCore::TransformSource::TransformSource): Wraps a libxml2 document.
(WebCore::TransformSource::~TransformSource):

  • dom/TransformSourceQt.cpp: Added.

(WebCore::TransformSource::TransformSource): Wraps a plain string.
(WebCore::TransformSource::~TransformSource):

  • dom/XMLTokenizerLibxml2.cpp:

(WebCore::XMLTokenizer::doEnd):

  • dom/XMLTokenizerQt.cpp:

(WebCore::XMLTokenizer::doEnd):
(WebCore::XMLTokenizer::parseProcessingInstruction):

  • xml/XSLStyleSheet.h:

(WebCore::XSLStyleSheet::sheetString):

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::document):

  • xml/XSLStyleSheetQt.cpp: Added.
  • xml/XSLTProcessor.h:
  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::xmlDocPtrFromNode):

  • xml/XSLTProcessorQt.cpp: Added.

(WebCore::XSLTMessageHandler::XSLTMessageHandler): A subclass of QAbstractMessageHandler.
(WebCore::XSLTMessageHandler::handleMessage): Forwards all processor messages to the Console.
(WebCore::XSLTProcessor::transformToString): Uses QXmlQuery.

13:09 Changeset [48825] by eric@webkit.org

2009-09-28 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=28054

Use derefInNotNull() to work around winscw compiler forward declaration bug
regarding templated classes.

The compiler bug is reported at
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.

The change should be reverted when the above bug is fixed in winscw compiler.

Add parenthesis around (RefPtr::*UnspecifiedBoolType) to make winscw compiler
work with the default UnSpecifiedBoolType() operator, which removes the winscw hack.

  • wtf/RefPtr.h: (WTF::RefPtr::~RefPtr): (WTF::RefPtr::clear): (WTF::RefPtr::operator UnspecifiedBoolType):

2009-09-28 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Eric Seidel.

Make JObjectWrapper::ref() and deref() public accessible to derefIfNull().

Will be reverted when the following winscw compiler bug is fixed.
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812

  • bridge/jni/jni_instance.h:
11:57 Changeset [48824] by hausmann@webkit.org

Remove clear_cache which is an internal function of GCC
https://bugs.webkit.org/show_bug.cgi?id=28886

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-09-28
Reviewed by Simon Hausmann.

Although clear_cache is exported from GCC, this is an internal
function. GCC makes no promises about it.

  • jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

11:51 Changeset [48823] by eric@webkit.org

2009-09-28 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Move message-port-multi.js from resources to script-tests
https://bugs.webkit.org/show_bug.cgi?id=29798

  • fast/events/message-port-multi-expected.txt:
  • fast/events/message-port-multi.html:
  • fast/events/resources/message-port-multi.js: Removed.
  • fast/events/script-tests/message-port-multi.js: Added. (channel.port2.onmessage):
11:43 Changeset [48822] by eric@webkit.org

2009-09-28 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Delegate implementation of rendererIsNeeded() for media control elements to RenderTheme.

https://bugs.webkit.org/show_bug.cgi?id=28689

Covered by LayoutTests/media/video-no-audio.html

  • rendering/MediaControlElements.cpp: Removed subclass implementations of rendererIsNeeded(). (WebCore::MediaControlElement::rendererIsNeeded): Include calling shouldRenderMediaControlPart(). (WebCore::MediaControlInputElement::rendererIsNeeded): Include calling shouldRenderMediaControlPart().
  • rendering/MediaControlElements.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::shouldRenderMediaControlPart): New method. Contains logic moved from subclass implementations of rendererIsNeeded().
  • rendering/RenderTheme.h:
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::shouldRenderMediaControlPart): Override to always render mute button.
  • rendering/RenderThemeChromiumSkia.h:
11:13 Changeset [48821] by jianli@chromium.org

[chromium] DragData::asURL should return file URL.
https://bugs.webkit.org/show_bug.cgi?id=29109

Reviewed by David Levin.

Tested by LayoutTests/fast/events/drag-to-navigate.html.

  • platform/FileSystem.h:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):

  • platform/chromium/FileSystemChromium.cpp:

(WebCore::getAbsolutePath):
(WebCore::isDirectory):
(WebCore::filePathToURL):

10:57 Changeset [48820] by dglazkov@chromium.org

2009-09-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by David Levin.

[V8] Add a special case to handle index arguments, because we need to be
able to see if they're < 0.
https://bugs.webkit.org/show_bug.cgi?id=29810

Test: LayoutTests/dom/html/level1/core/hc_characterdataindexsizeerrdeletedatacountnegative.html

  • bindings/scripts/CodeGeneratorV8.pm: Added special case (matching CodeGeneratorJS.pm) for index arguments.
10:55 Changeset [48819] by weinig@apple.com

Fix an absolute path to somewhere in Oliver's machine to a relative path
for derived JSONObject.lut.h.

Reviewed by Oliver Hunt.

09:34 Changeset [48818] by mitz@apple.com

Extend the MediaWiki/KHTMLFixes.css workaround to cover older MediaWiki versions
https://bugs.webkit.org/show_bug.cgi?id=29792

Reviewed by Darin Adler.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet): If site specific hacks are
enabled, check if the linked style sheet is one of two versions of the
MediaWiki KHTMLFixes.css. If so, remove the offending rule.

09:29 Changeset [48817] by dglazkov@chromium.org

2009-09-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

[V8] Fix an error in type logic in CodeGeneratorV8.pm, where
unsigned ints are accidentally used as signed.
https://bugs.webkit.org/show_bug.cgi?id=29810

Test: LayoutTests/fast/forms/textarea-maxlength.html

  • bindings/scripts/CodeGeneratorV8.pm: Made sure "unsigned long" in IDL is properly generates on "unsigned" return value.
09:14 Changeset [48816] by simon.fraser@apple.com

2009-09-25 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

ASSERTION FAILED: !repaintContainer
repaintContainer == this

https://bugs.webkit.org/show_bug.cgi?id=29755

It's possible for RenderObject::container() to return an object that is higher
in the hierarchy than the repaintContainer that is being used to repaint an
object. For example, this can happen when running an accelerated opacity
transition on an element with a position:absolute parent, and a position:absolute child.

In this case we need to detect when RenderObject::container() will skip over
repaintContainer, and in that case adjust the coords to shift into repaintContainer's space.

Test: compositing/repaint/opacity-between-absolute.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::computeRectForRepaint):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::computeRectForRepaint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::container):
  • rendering/RenderObject.h:
08:06 Changeset [48815] by hausmann@webkit.org

Rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp.
https://bugs.webkit.org/show_bug.cgi?id=28303

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
Reviewed by Simon Hausmann.

In preparation for adding XSLT support with QtXmlPatterns to the Qt
port, rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp as we will
have our own implementation which most likely will not share any code
with the current one.

Additionally, fix some coding style issues.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • xml/XSLStyleSheet.cpp: Renamed to XSLStyleSheetLibxslt.cpp.
  • xml/XSLStyleSheetLibxslt.cpp: Added.
07:45 Changeset [48814] by hausmann@webkit.org

Prospective build fix for r48812.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-28
Forgot to remove the inline reset() implementation when reverting the indentation
changes in the file.

  • xml/XSLTProcessor.h:
07:40 Changeset [48813] by pfeldman@chromium.org

2009-09-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by nobody (trivial follow up fix), Joseph Pecoraro LGTM-ed.

Web Inspector: Follow up to r48809.
InspectorController.wrapObject should only be called on the inspectable page side.

https://bugs.webkit.org/show_bug.cgi?id=17429

07:36 Changeset [48812] by hausmann@webkit.org

Move the libxslt specific part of XSLTProcessor to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=28303

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
Reviewed by Simon Hausmann.

In preparation for adding XSLT support with QtXmlPatterns to the Qt
port, move the libxslt part of the XSLTProcessor implementation into
another file and leave the part that can be reused and shared.

Additionally, fix some coding style issues.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource): Remove trailing whitespaces.
(WebCore::createFragmentFromSource): Remove trailing whitespaces.
(WebCore::XSLTProcessor::transformToFragment): Remove trailing whitespaces.
(WebCore::XSLTProcessor::reset): Moved out of the class definition.

  • xml/XSLTProcessorLibxslt.cpp: Added.

(WebCore::XSLTProcessor::genericErrorFunc): Moved.
(WebCore::XSLTProcessor::parseErrorFunc): Moved.
(WebCore::docLoaderFunc): Moved.
(WebCore::setXSLTLoadCallBack): Moved.
(WebCore::writeToVector): Moved.
(WebCore::saveResultToString): Moved.
(WebCore::xsltParamArrayFromParameterMap): Moved.
(WebCore::freeXsltParamArray): Moved.
(WebCore::xsltStylesheetPointer): Moved.
(WebCore::xmlDocPtrFromNode): Moved.
(WebCore::resultMIMEType): Moved.
(WebCore::XSLTProcessor::transformToString): Moved.

07:28 Changeset [48811] by staikos@webkit.org

Minor correction to Copyright notice. Not reviewed.

06:35 Changeset [48810] by eric@webkit.org

2009-09-28 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Fix the crash of SVG that crashes when use a non-exist symbol
https://bugs.webkit.org/show_bug.cgi?id=27693

  • svg/custom/use-non-existing-symbol-crash-expected.txt: Added.
  • svg/custom/use-non-existing-symbol-crash.svg: Added.

2009-09-28 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Fix the crash of SVG that crashes when use a non-exist symbol
https://bugs.webkit.org/show_bug.cgi?id=27693

Test: svg/custom/use-non-existing-symbol-crash.svg

  • svg/SVGUseElement.cpp: (WebCore::shadowTreeContainsChangedNodes):
05:36 Changeset [48809] by pfeldman@chromium.org

2009-09-28 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Inspector Should Show Event Listeners/Handlers Registered on each Node
https://bugs.webkit.org/show_bug.cgi?id=17429


Extracted a method from dispatchEvent to get the event ancestor chain


  • dom/Node.cpp: (WebCore::Node::eventAncestors): the extracted method (WebCore::Node::dispatchGenericEvent): use eventAncestors
  • dom/Node.h:

Asynchronous Flow For the Inspector, Backend -> DOM Agent -> Frontend
The DOMAgent's getEventListenersForNode handles the logic of finding
all the relevant listeners in the event flow.

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getEventListenersForNode):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::buildObjectForEventListener): (WebCore::InspectorDOMAgent::buildObjectForNode): added localName
  • inspector/InspectorDOMAgent.h: (WebCore::EventListenerInfo::EventListenerInfo):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetEventListenersForNode):
  • inspector/InspectorFrontend.h: (WebCore::InspectorFrontend::scriptState):
  • inspector/front-end/DOMAgent.js: added localName to WebInspector.DOMNode from payload (WebInspector.EventListeners.getEventListenersForNodeAsync.mycallback): (WebInspector.EventListeners.getEventListenersForNodeAsync):

New Sidebar Pane in the Element's Panel
Includes Gear Menu for filtering the Event Listeners on the
"Selected Node Only" or "All Nodes"

  • inspector/front-end/ElementsPanel.js: Handles refreshing the Pane when necessary (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.updateEventListeners):
  • inspector/front-end/EventListenersSidebarPane.js: Added. (WebInspector.EventListenersSidebarPane): The 1st level in the Pane (WebInspector.EventListenersSidebarPane.prototype.update.callback): (WebInspector.EventListenersSidebarPane.prototype.update): (WebInspector.EventListenersSection): The 2nd level in the Pane (WebInspector.EventListenersSection.prototype.update): filters on Preference (WebInspector.EventListenersSection.prototype.addListener): (WebInspector.EventListenerBar): The 3rd level in the Pane (WebInspector.EventListenerBar.prototype._getNodeDisplayName): (WebInspector.EventListenerBar.prototype._getFunctionDisplayName): (WebInspector.EventListenersSidebarPane.prototype._changeSetting): For the Gear Menu


Consolidated "appropriateSelectorForNode"

  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/utilities.js:

Miscellaneous Updates

  • English.lproj/localizedStrings.js: "Event Listeners", "No Event Listeners", "Selected Node Only", "All Nodes"
  • WebCore.gypi: included the new inspector files
  • WebCore.vcproj/WebCore.vcproj: included source files that were missing
  • inspector/front-end/Images/grayConnectorPoint.png: Added. Thanks to Timothy Hatcher.
  • inspector/front-end/Images/whiteConnectorPoint.png: Added. Thanks to Timothy Hatcher.
  • inspector/front-end/inspector.js: Preferences for the Gear Menu Event Listeners filter
  • inspector/front-end/inspector.css: reused as much as possible
  • inspector/front-end/inspector.html: include the new script
  • inspector/front-end/WebKit.qrc: included the new inspector files
04:16 Changeset [48808] by hausmann@webkit.org

Compile fix with namespaced Qt.

Patch by Andre Poenitz <andre.poenitz@trolltech.com> on 2009-09-28
Reviewed by Simon Hausmann.

  • Api/qwebinspector_p.h:
02:17 Changeset [48807] by hausmann@webkit.org

Add ARM version detection for Windows CE.

Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-28
Reviewed by Simon Hausmann.

  • wtf/Platform.h:
Note: See TracTimeline for information about the timeline view.