Timeline


and

10/05/09:

23:58 Changeset [49155] by jorlow@chromium.org
  • 3 edits
    2 copies
    1 add in trunk/LayoutTests

2009-10-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Convert DOM Storage's "complex-values" test into the new format.
https://bugs.webkit.org/show_bug.cgi?id=30097

Convert DOM Storage's "complex-values" test into the new format and add it for
session storage. This also increases the coverage of these tests a bit.

  • storage/domstorage/localstorage/complex-values-expected.txt:
  • storage/domstorage/localstorage/complex-values.html:
  • storage/domstorage/script-tests/complex-values.js: Added. (handleStorageEvent): (testKeyValue): (runTest):
  • storage/domstorage/sessionstorage/complex-values-expected.txt: Copied from LayoutTests/storage/domstorage/localstorage/complex-values-expected.txt.
  • storage/domstorage/sessionstorage/complex-values.html: Copied from LayoutTests/storage/domstorage/localstorage/complex-values.html.
23:56 Changeset [49154] by jorlow@chromium.org
  • 3 edits
    3 adds in trunk/LayoutTests

2009-10-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Convert DOM Storage's "complex-keys" test into the new format
https://bugs.webkit.org/show_bug.cgi?id=30089

Convert DOM Storage's "complex-keys" test into the new format and add it for
session storage. This test should be a bit more thorough than the old
version as well.

  • storage/domstorage/localstorage/complex-keys-expected.txt:
  • storage/domstorage/localstorage/complex-keys.html:
  • storage/domstorage/script-tests/complex-keys.js: Added. (runTest):
  • storage/domstorage/sessionstorage/complex-keys-expected.txt: Added.
  • storage/domstorage/sessionstorage/complex-keys.html: Added.
22:58 Changeset [49153] by krit@webkit.org
  • 4 edits
    4 adds in trunk

2009-10-05 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filters do not support source images besides "sourceGraphic"
https://bugs.webkit.org/show_bug.cgi?id=6022

Add support for SourceAlpha to SVG filters.

Test: svg/filters/sourceAlpha.svg

  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::calculateEffectRect): (WebCore::SourceAlpha::apply):
  • platform/graphics/filters/SourceAlpha.h:

Test for SVG's SourceAlpha support for Filters.

  • platform/mac/svg/filters/sourceAlpha-expected.checksum: Added.
  • platform/mac/svg/filters/sourceAlpha-expected.png: Added.
  • platform/mac/svg/filters/sourceAlpha-expected.txt: Added.
  • svg/filters/sourceAlpha.svg: Added.
22:39 WebKit Team edited by jam@chromium.org
(diff)
22:13 Changeset [49152] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Rubber-stamped by Mark Rowe.

Moved a WebPluginHalterClient out of the WebCore namesapce.

  • WebCoreSupport/WebPluginHalterClient.h:
22:07 Changeset [49151] by kevino@webkit.org
  • 4 edits in trunk

wx libjpeg link fix and JSC build fix.

21:58 Changeset [49150] by simon.fraser@apple.com
  • 21 edits
    4 adds in trunk/LayoutTests

2009-10-05 Simon Fraser <simon.fraser@apple.com>

Updated results for media tests after controller change to add the fullscreen button.

  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.checksum: Added.
  • platform/mac/media/controls-after-reload-expected.png: Added.
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-styling-expected.checksum:
  • platform/mac/media/controls-styling-expected.png:
  • platform/mac/media/controls-styling-expected.txt:
  • platform/mac/media/video-aspect-ratio-expected.checksum:
  • platform/mac/media/video-aspect-ratio-expected.png:
  • platform/mac/media/video-empty-source-expected.checksum:
  • platform/mac/media/video-empty-source-expected.png:
  • platform/mac/media/video-empty-source-expected.txt:
  • platform/mac/media/video-no-audio-expected.checksum:
  • platform/mac/media/video-no-audio-expected.png:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-transformed-expected.checksum:
  • platform/mac/media/video-transformed-expected.png:
  • platform/mac/media/video-zoom-controls-expected.checksum: Added.
  • platform/mac/media/video-zoom-controls-expected.png: Added.
  • platform/mac/media/video-zoom-controls-expected.txt:
  • platform/mac/media/video-zoom-expected.checksum:
  • platform/mac/media/video-zoom-expected.png:
21:58 Changeset [49149] by kdecker@apple.com
  • 8 edits
    2 adds in trunk/WebKit

Reviewed by Dan Bernstein.

Added new PluginHalter client, delegate and few more WebPreferences keys.

  • WebView/WebPreferenceKeysPrivate.h: Added two new keys.
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Initialize newly added key. (-[WebPreferences pluginAllowedRunTime]): Added. (-[WebPreferences setPluginAllowedRunTime:]): Added.
  • WebView/WebPreferencesPrivate.h: Added above two methods.
  • WebView/WebUIDelegatePrivate.h: Added shouldHaltPlugin delegate.
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Setup a new WebPluginHalterClient. (-[WebView _preferencesChangedNotification:]): Update WebCore settings accordingly.
  • WebCoreSupport/WebPluginHalterClient.h: Added.
  • WebCoreSupport/WebPluginHalterClient.mm: Added. (WebPluginHalterClient::WebPluginHalterClient): (WebPluginHalterClient::shouldHaltPlugin): Added, invoke the delegate.
21:55 Changeset [49148] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-10-05 John Abd-El-Malek <jam@chromium.org>

Reviewed by Adam Barth.

Fix reliablity bot crash in DateExtension.
https://bugs.webkit.org/show_bug.cgi?id=30033

There were a few problems using the weak persistent pointers because no one else had a
handle to them. The new approach stores them as a hidden value on the Date constructor.

  • bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep): (WebCore::DateExtension::GetNativeFunction): (WebCore::DateExtension::Setup): (WebCore::DateExtension::OnSleepDetected):
  • bindings/v8/DateExtension.h:
  • bindings/v8/V8HiddenPropertyName.cpp: (WebCore::V8HiddenPropertyName::sleepFunction):
  • bindings/v8/V8HiddenPropertyName.h:
21:40 Changeset [49147] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-05 Simon Fraser <simon.fraser@apple.com>

More build fixes for Tiger.

  • WebView/WebVideoFullscreenController.mm:
21:17 Changeset [49146] by simon.fraser@apple.com
  • 3 edits in trunk/WebKit/mac

2009-10-05 Simon Fraser <simon.fraser@apple.com>

More build fixes for Tiger.

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenWindow animationDidEnd:]):
  • WebView/WebWindowAnimation.m:
21:17 Changeset [49145] by slewis@apple.com
  • 2 edits in trunk/WebCore

Crash when trying to load a null stylesheet for a site specific hack.
https://bugs.webkit.org/show_bug.cgi?id=30105

Reviewed by Dan Bernstein.

Created a testcase and tested in browser. DRT doesn't test
site specific hacks.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

21:12 Changeset [49144] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-05 James Robinson <jamesr@google.com>

Reviewed by Darin Adler.

Fix forward declaration (struct vs class mismatch)

https://bugs.webkit.org/show_bug.cgi?id=30094

  • loader/RedirectScheduler.h:
20:58 Changeset [49143] by simon.fraser@apple.com
  • 3 edits in trunk/WebKit/mac

2009-10-05 Simon Fraser <simon.fraser@apple.com>

More build fixes for Tiger.

  • WebView/WebVideoFullscreenController.mm:
  • WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): (-[WebVideoFullscreenHUDWindowController fadeWindowIn]): (-[WebVideoFullscreenHUDWindowController fadeWindowOut]): (-[WebVideoFullscreenHUDWindowController closeWindow]):
18:53 Changeset [49142] by jparent@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, last Chromium build fix corresponding to revision 49113.
Add include for BeforeLoadEvent to DOMObjectsInclude.h.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-05

  • bindings/v8/DOMObjectsInclude.h:
18:47 Changeset [49141] by eric@webkit.org
  • 2 edits in trunk/WebKit

2009-10-05 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

One of the dependencies' SVN url was missing a @ before the revision number.

https://bugs.webkit.org/show_bug.cgi?id=30101

  • chromium/DEPS:
18:21 Changeset [49140] by simon.fraser@apple.com
  • 3 edits in trunk/WebKit/mac

2009-10-05 Simon Fraser <simon.fraser@apple.com>

Build fixes for Tiger.

  • WebView/WebVideoFullscreenHUDWindowController.h:
  • WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): (-[WebVideoFullscreenHUDWindowController dealloc]): (-[WebVideoFullscreenHUDWindowController closeWindow]): (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
18:05 Changeset [49139] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-05 Simon Fraser <simon.fraser@apple.com>

Build fix. If you call Node::hasTagName(), you also have to include Element.h.

  • WebCoreSupport/WebChromeClient.mm:
17:43 Changeset [49138] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-10-05 Simon Fraser <simon.fraser@apple.com>

Fix Windows build.

  • html/HTMLMediaElement.cpp:
17:40 Changeset [49137] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-10-05 Simon Fraser <simon.fraser@apple.com>

Fix the build: MediaControllerThemeQT was renamed to MediaControllerThemeQuickTime.

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
17:24 Changeset [49136] by simon.fraser@apple.com
  • 31 edits
    7 adds in trunk

2009-10-05 Pierre d'Herbemont <pdherbemont@webkit.org>

Reviewed by Simon Fraser

Support fullscreen in MediaPlayer (Mac)
https://bugs.webkit.org/show_bug.cgi?id=26742

Add a fullscreen button to the <video> controller if the media engine,
and the theme have support for fullscreen, and can show appropriate controls.
Clicking the button calls through the ChromeClient to the WebVideoFullscreenController
in WebKit to do a nice animation to fullscreen, with a custom controller.

17:21 Changeset [49135] by kdecker@apple.com
  • 2 edits in trunk/WebCore

Export a few more methods from Settings.h


Rubberstamped by Jon Honeycutt.


  • WebCore.base.exp:
17:03 Changeset [49134] by dimich@chromium.org
  • 2 edits in trunk/WebCore

1-char fix for obviously reverse condition.
https://bugs.webkit.org/show_bug.cgi?id=30100
No test since the only difference is a timing of GC.

Reviewed by Darin Adler.

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::clear): Revert condition. Almost a typo.

17:00 Changeset [49133] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

WebKit side of <rdar://problem/7179166>

Reviewed by Kevin Decker.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:

Add an m_pluginIsWaitingForDraw member variable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Initialize m_pluginIsWaitingForDraw.

(WebKit::NetscapePluginInstanceProxy::invalidateRect):
Set m_pluginIsWaitingForDraw to true.

(WebKit::NetscapePluginInstanceProxy::didDraw):
If m_pluginIsWaitingForDraw is true, call _WKPHPluginInstanceDidDraw.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView drawRect:]):
Call didDraw.

  • Plugins/Hosted/WebKitPluginHost.defs:

Add PHPluginInstanceDidDraw.

16:57 Changeset [49132] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-09-30 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Update platform-specific #ifdefs in GraphicsContext3D.h for the
Chromium port.
https://bugs.webkit.org/show_bug.cgi?id=29936

  • platform/graphics/GraphicsContext3D.h: Changed #if PLATFORM(SKIA) to #if PLATFORM(CHROMIUM).
16:37 Changeset [49131] by mitz@apple.com
  • 3 edits
    4 adds in trunk

REGRESSION (r47440): Inserting text in the middle of content in a scrolled textfield results in painting bugs
<rdar://problem/7269108>
https://bugs.webkit.org/show_bug.cgi?id=29982

Reviewed by Darin Adler.

WebCore:

Test: fast/repaint/line-in-scrolled-clipped-block.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock): Use the unclipped overflow rect
(including layout overflow) for the repaint rect calculation.

LayoutTests:

  • fast/repaint/line-in-scrolled-clipped-block.html: Added.
  • platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.checksum: Added.
  • platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
  • platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Added.
16:34 Changeset [49130] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-10-05 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Chromium wants to turn off SharedWorkers at runtime
https://bugs.webkit.org/show_bug.cgi?id=29757

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::sharedWorker): Now returns jsUndefined if isAvailable() returns false, to allow SharedWorkers to be disabled at runtime.
  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerRepository::isAvailable): Made SharedWorkers available by default.
  • workers/SharedWorkerRepository.h: Added definition for SharedWorkerRepository::isAvailable().
16:26 Changeset [49129] by eric@webkit.org
  • 4 edits
    4 adds in trunk

2009-10-05 Hironori Bono <hbono@chromium.org>

Reviewed by Eric Seidel.

A super quick fix for Bug 28710.

https://bugs.webkit.org/show_bug.cgi?id=28710

This change just resets the style sent to addStyleMarkup() to avoid an assertion error
and creates an empty style when computedStyleAtPosition is 0 to avoid a crash.
(This change is nothing but a better-than-crash change.)

  • editing/selection/select-crash-001-expected.txt: Added.
  • editing/selection/select-crash-001.html: Added.
  • editing/selection/select-crash-002-expected.txt: Added.
  • editing/selection/select-crash-002.html: Added.

2009-10-05 Hironori Bono <hbono@chromium.org>

Reviewed by Eric Seidel.

A super quick fix for Bug 28710.

https://bugs.webkit.org/show_bug.cgi?id=28710

This change just resets the style sent to addStyleMarkup() to avoid an assertion error
and creates an empty style when computedStyleAtPosition is 0 to avoid a crash.
(This change is nothing but a better-than-crash change.)

Tests: editing/selection/select-crash-001.html

editing/selection/select-crash-002.html

  • editing/ApplyStyleCommand.cpp: (WebCore::editingStyleAtPosition): Resets the style sent to addStyleMarkup() if it is not valid.
  • editing/markup.cpp: (WebCore::createMarkup): Creates an empty style if computedStyleAtPosition is 0.
16:18 Changeset [49128] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-10-05 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Remove precompiled header from JavaScriptCore compilation to
prevent qmake warning during autonomous compilation.
https://bugs.webkit.org/show_bug.cgi?id=30069

16:10 Changeset [49127] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-05 Julie Parent <jparent@chromium.org>

Reviewed by Darin Adler.

Make LayoutTests/editing/selection/hit-test-anonymous.html resistant to
GDI/CG differences, by increasing the font size so the slight
difference in fonts doesn't result in a different character clicked.
https://bugs.webkit.org/show_bug.cgi?id=29985

  • editing/selection/hit-test-anonymous.html:
16:10 Changeset [49126] by weinig@apple.com
  • 2 edits in trunk/WebCore

Silence duplicate errors logged for missing getComputedStyle
implementations. Improves the error message as well.

Reviewed by Mark Rowe.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::logUnimplementedPropertyID):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

16:03 Changeset [49125] by jparent@chromium.org
  • 3 edits in trunk/WebCore

Unreviewed, Chromium build fix #3. Add V8BeforeLoadEvent.[cc|h] to derived sources.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-05

  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
16:03 Changeset [49124] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-10-05 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Simon Hausmann.

Add screenshot option to menubar

https://bugs.webkit.org/show_bug.cgi?id=30067

  • QtLauncher/main.cpp: (MainWindow::screenshot): (MainWindow::setupUI):
15:49 Changeset [49123] by cmarrin@apple.com
  • 1 edit in trunk/WebKitSite/blog-files/webgl/WebGL+CSS.html

Another change to one of the WebGL blog post demos

15:45 Changeset [49122] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-10-05 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Simon Hausmann.

Setting the env QTLAUNCHER_USE_ARGB_VISUALS makes Qt use WA_TranslucentWindow.

https://bugs.webkit.org/show_bug.cgi?id=30068

  • QtLauncher/main.cpp: (MainWindow::MainWindow):
15:44 Changeset [49121] by cmarrin@apple.com
  • 7 edits in trunk/WebKitSite/blog-files/webgl

Fixed some tests for WebGL blog post

15:41 Changeset [49120] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Try and fix the GTK build.

  • GNUmakefile.am:
15:37 Changeset [49119] by cmarrin@apple.com
  • 17 adds in trunk/WebKitSite/blog-files/webgl

Added files for WebGL blog post

15:37 Changeset [49118] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-05 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] EventSender::keyDown() cannot send function-key events.
https://bugs.webkit.org/show_bug.cgi?id=30044

This affects the fast/events/keydown-function-keys.html layout test.

  • DumpRenderTree/qt/jsobjects.cpp: (EventSender::keyDown):
15:31 Changeset [49117] by jparent@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, Chromium build fix #2. Add new BEFORELOADEVENT to V8ClassIndex.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-05

  • bindings/v8/V8Index.h:
15:07 Changeset [49116] by jparent@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, Chromium build fix. Missing "," after entry for BeforeLoadEvent.idl.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-05

  • WebCore.gypi:
15:04 Changeset [49115] by hyatt@apple.com
  • 4 edits in trunk/LayoutTests

Update layout tests to account for the new beforeload event object.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
14:28 Changeset [49114] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.pro

Fix Qt bustage.

14:16 Changeset [49113] by hyatt@apple.com
  • 8 edits
    2 adds in trunk/WebCore

Add a beforeload event that will be fired before subresources load. (It isn't fired yet.) The event
has one field, the URL that is going to be requested. Setting preventDefault will stop the load
from occurring.

Reviewed by Sam Weinig.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/BeforeLoadEvent.h: Added.

(WebCore::BeforeLoadEvent::create):
(WebCore::BeforeLoadEvent::initBeforeLoadEvent):
(WebCore::BeforeLoadEvent::url):
(WebCore::BeforeLoadEvent::BeforeLoadEvent):

  • dom/BeforeLoadEvent.idl: Added.
  • dom/EventNames.h:
  • page/DOMWindow.idl:
14:07 Changeset [49112] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-05 Priit Laes <plaes@plaes.org>

Reviewed by Gustavo Noronha.

Add Gentoo-specific paths for searching browser plugins.
https://bugs.webkit.org/show_bug.cgi?id=30088

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::defaultPluginDirectories):
13:46 Changeset [49111] by cmarrin@apple.com
  • 7 edits in trunk

Add functionality to pause/throttle CSS transitions/animations in a WebView
https://bugs.webkit.org/show_bug.cgi?id=29942

13:44 Changeset [49110] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Remove test that I forgot in earlier commit.

  • platform/qt/Skipped:
13:23 Changeset [49109] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-10-05 Vadim Zeitlin <vadim@wxwidgets.org>

Added --wx-compiler-prefix waf option to allow building wxWebKit with
wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".

  • wx/build/settings.py:
  • wx/build/wxpresets.py:
13:06 Changeset [49108] by kdecker@apple.com
  • 3 edits in trunk/WebCore

Rubberstamped by Anders Carlsson.


  • WebCore.base.exp: Update export of HaltablePlugin/PluginHalterClient.
  • WebCore.xcodeproj/project.pbxproj: Likewise.
12:07 Changeset [49107] by eric@webkit.org
  • 8 edits
    15 deletes in trunk

2009-10-05 Eric Seidel <eric@webkit.org>

No review, rolling out r49104.
http://trac.webkit.org/changeset/49104

  • fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-number.html: Removed.
  • fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-range.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
  • fast/forms/input-minmax-expected.txt: Removed.
  • fast/forms/input-minmax.html: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
  • fast/forms/script-tests/input-minmax.js: Removed.

2009-10-05 Eric Seidel <eric@webkit.org>

No review, rolling out r49104.
http://trac.webkit.org/changeset/49104

  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • html/ValidityState.cpp:
  • html/ValidityState.h: (WebCore::ValidityState::rangeUnderflow): (WebCore::ValidityState::rangeOverflow):
  • rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): (WebCore::SliderRange::valueFromElement):
11:57 Changeset [49106] by kdecker@apple.com
  • 3 edits in trunk/WebKit/mac

Reviewed by Sam Weinig.

<rdar://problem/7273363> Plug-ins should use PluginHalter


  • Plugins/WebBaseNetscapePluginView.h: Add WebHaltablePlugin forward declare and _haltable ivar.
  • Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::WebHaltablePlugin): Added. (WebHaltablePlugin::halt): New method that stops a plug-in. (WebHaltablePlugin::restart): New method that starts a plug-in. (WebHaltablePlugin::node): Added. Provides the DOMNode corresponding to the plug-in in WebBaseNetscapePluginView. (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): Initialize new _haltable ivar. (-[WebBaseNetscapePluginView start]): Call the page's didStartPlugin() upon starting a plug-in. (-[WebBaseNetscapePluginView stop]): Call the page's didStopPlugin() upon stopping a plug-in.
11:23 Changeset [49105] by eric@webkit.org
  • 7 edits
    7 adds in trunk

2009-10-05 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Tests to check if validation-related CSS selectors are applied immediately.
https://bugs.webkit.org/show_bug.cgi?id=28868

  • fast/forms/input-live-pseudo-selectors-expected.txt: Added.
  • fast/forms/input-live-pseudo-selectors.html: Added.
  • fast/forms/resources/input-live-pseudo-selectors.js: Added.
  • fast/forms/resources/live-pseudo-selectors.css: Added.
  • fast/forms/resources/textarea-live-pseudo-selectors.js: Added.
  • fast/forms/textarea-live-pseudo-selectors-expected.txt: Added.
  • fast/forms/textarea-live-pseudo-selectors.html: Added.

2009-10-05 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Update style immediately when validation-related values are updated.
https://bugs.webkit.org/show_bug.cgi?id=28868

In order to apply :valid, :invalid, :optional or :required lively,

  • call setNeedsStyleRecalc() when properties which can change willValidate state are updated, and

(Parent form element, name, disabled, readonly)

  • call updateValidity() when properties which can change validity state are updated. (value, pattern, required)

Tests: fast/forms/input-live-pseudo-selectors.html

fast/forms/textarea-live-pseudo-selectors.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseMappedAttribute): (WebCore::HTMLFormControlElement::required): (WebCore::HTMLFormControlElement::updateValidity):
  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::setFileListFromRenderer):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
11:14 Changeset [49104] by eric@webkit.org
  • 8 edits
    15 adds in trunk

2009-10-05 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Implement min/max attributes, ValidityState.rangeUnderflow and
ValidityState.rangeOverflow for <input type=number> and <input type=range>
https://bugs.webkit.org/show_bug.cgi?id=29069

  • fast/forms/ValidityState-rangeOverflow-number-expected.txt: Added.
  • fast/forms/ValidityState-rangeOverflow-number.html: Added.
  • fast/forms/ValidityState-rangeOverflow-range-expected.txt: Added.
  • fast/forms/ValidityState-rangeOverflow-range.html: Added.
  • fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Added.
  • fast/forms/ValidityState-rangeUnderflow-number.html: Added.
  • fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Added.
  • fast/forms/ValidityState-rangeUnderflow-range.html: Added.
  • fast/forms/input-minmax-expected.txt: Added.
  • fast/forms/input-minmax.html: Added.
  • fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Added.
  • fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Added.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Added.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Added.
  • fast/forms/script-tests/input-minmax.js: Added.

2009-10-05 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Implement min/max attributes, ValidityState.rangeUnderflow and
ValidityState.rangeOverflow for <input type=number> and <input type=range>
https://bugs.webkit.org/show_bug.cgi?id=29069

Tests: fast/forms/ValidityState-rangeOverflow-number.html

fast/forms/ValidityState-rangeOverflow-range.html
fast/forms/ValidityState-rangeUnderflow-number.html
fast/forms/ValidityState-rangeUnderflow-range.html
fast/forms/input-minmax.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::rangeUnderflow): (WebCore::HTMLInputElement::rangeOverflow): (WebCore::HTMLInputElement::rangeMinimum): (WebCore::HTMLInputElement::rangeMaximum):
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • html/ValidityState.cpp: (WebCore::ValidityState::rangeUnderflow): (WebCore::ValidityState::rangeOverflow):
  • html/ValidityState.h:
  • rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): (WebCore::SliderRange::valueFromElement):
11:05 Changeset [49103] by eric@webkit.org
  • 13 edits
    2 adds in trunk

2009-10-05 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Tests for -webkit-appearance:list-button
https://bugs.webkit.org/show_bug.cgi?id=27794

  • platform/mac/fast/forms/input-list-button-size-expected.txt: Added.
  • platform/mac/fast/forms/input-list-button-size.html: Added.

2009-10-05 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Introduces

  • new CSS pseudo selector: "-webkit-input-list-button"
  • new CSS apperance type: "list-button"
  • new ControlPart value: "ListButtonPart"

for the UI of the list attribute of the input element, and adds
implementation to draw ListButtonPart on Mac.
The code is guarded by ENABLE(DATALIST).

https://bugs.webkit.org/show_bug.cgi?id=27794

Test: platform/mac/fast/forms/input-list-button-size.html

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • css/CSSValueKeywords.in:
  • css/html.css:
  • html/HTMLInputElement.cpp:
  • platform/ThemeTypes.h: (WebCore::):
  • platform/mac/ThemeMac.mm: (WebCore::listButtonSizes): (WebCore::button): (WebCore::paintButton): (WebCore::ThemeMac::controlSize): (WebCore::ThemeMac::minimumControlSize): (WebCore::ThemeMac::controlBorder): (WebCore::ThemeMac::paint):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect):
  • rendering/style/RenderStyleConstants.h: (WebCore::):
11:00 Changeset [49102] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Add documentation to the ErrorPageExtension.

  • Api/qwebpage.cpp:
10:39 Changeset [49101] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

2009-10-05 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.

Fixes <https://bugs.webkit.org/show_bug.cgi?id=30065>
nodeTitleInfo should be placed in ElementsTreeOutline.


Move nodeTitleInfo into ElementsTreeOutline.js from utilities.js.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateTitle): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
  • inspector/front-end/utilities.js:
10:36 Changeset [49100] by yael.aharon@nokia.com
  • 6 edits in trunk

[Qt] Inform the application when a new request is created
https://bugs.webkit.org/show_bug.cgi?id=29975

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

WebCore:

Emit a signal each time a request is created, with the request and the frame
that created it.

WebKit/qt:

Add a signal to QWebPage, to inform the application when a request is created.

10:30 Changeset [49099] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-05 Ben Murdoch <benm@google.com>

Reviewed by Darin Adler.

Add an ASSERT in updateGuidVersionMap.
https://bugs.webkit.org/show_bug.cgi?id=30077

  • storage/Database.cpp: (WebCore::updateGuidVersionMap): ASSERT that the guidMutex() is locked.
10:15 Changeset [49098] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2009-10-05 Nate Chapin <japhet@chromium.org>

Reviewed by Eric Seidel.

Allow V8 to throw an exception in _NPN_SetException without worrying about context
if we don't have enough information to find the correct context.

https://bugs.webkit.org/show_bug.cgi?id=30026

Part of the fix for Chromium's failure of LayouTests/plugins/netscape-throw-exception.html.

  • bindings/v8/NPV8Object.cpp: (_NPN_SetException): Don't suppress the exception if we can't find the relevant context.
09:03 Changeset [49097] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-10-01 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Place "Close" button in docked mode on the same side as the window "Close" button in detached mode.

https://bugs.webkit.org/show_bug.cgi?id=29961

  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded):
08:11 Changeset [49096] by kenneth@webkit.org
  • 3 edits in trunk/WebKit/qt

ErrorPageExtension: Add a pointer to the QWebFrame that had
an error.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Reviewed by Simon Hausmann.

  • Api/qwebpage.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::callErrorPageExtension):

08:01 Changeset [49095] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Do not empty the offline web appcache when clearing
memory caches. That one is not in memory, but stored
in sqlite.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Reviewed by Tor Arne Vestbø.

  • Api/qwebsettings.cpp:

(QWebSettings::clearMemoryCaches):

07:36 Changeset [49094] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Re-enable fast/table/008.html

07:08 Changeset [49093] by kenneth@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[Qt] Add expected files for passing fast/table tests.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-05
Reviewed by Ariya Hidayat.

  • platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.txt: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt: Added.
  • platform/qt/fast/table/fixed-table-with-small-percent-width-expected.txt: Added.
07:03 Changeset [49092] by hausmann@webkit.org
  • 6 edits in trunk

WebCore: [Qt] Added pure virtual QWebPageClient::pluginParent()

Patch by J-P Nurmi <jpnurmi@gmail.com> on 2009-10-05
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29710

  • platform/qt/QWebPageClient.h:

WebKit/qt: Added QGraphicsWidget-plugins support to FrameLoaderClientQt.

Patch by J-P Nurmi <jpnurmi@gmail.com> on 2009-10-05
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29710

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::pluginParent):

  • Api/qwebview.cpp:

(QWebViewPrivate::pluginParent):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::):
(WebCore::FrameLoaderClientQt::createPlugin):

07:03 Changeset [49091] by pfeldman@chromium.org
  • 19 edits
    2 adds in trunk

2009-10-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add testing harness for Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=30010

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

WebKit/win:

  • Interfaces/IWebInspectorPrivate.idl: Added.
  • Interfaces/IWebViewPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebInspector.cpp: (WebInspector::evaluateInFrontend):
  • WebInspector.h:
  • WebView.cpp: (WebView::inspectorPrivate):
  • WebView.h:

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp: (showWebInspectorCallback): (closeWebInspectorCallback): (evaluateInWebInspectorCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
06:25 Changeset [49090] by zoltan@webkit.org
  • 2 edits in trunk

2009-10-05 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Disable TCmalloc for Windows port at the present, because MinGW
hasn't got built-in pthread library.

  • WebKit.pri:
03:57 Changeset [49089] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-10-05 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Tor Arne Vestbø.

[Qt] windowsKeyCodeForKeyEvent() returns a wrong value for the F10 key.
https://bugs.webkit.org/show_bug.cgi?id=30042

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent):
03:48 Changeset [49088] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

Pass arguments to system() as a string instead of array

Reviewed by Ariya Hidayat.

When passed as an array entries with a space fail to translate
to two arguments to the child process, so instead of manually
splitting all the entries in @buildArgs we pass the whole thing
as a string instead.

  • Scripts/webkitdirs.pm:
02:31 Changeset [49087] by vestbo@webkit.org
  • 4 edits
    1 copy
    1 delete in trunk/WebCore

Move mediaControls extras for the Qt port into WebCore/css like other ports

https://bugs.webkit.org/show_bug.cgi?id=30013

Reviewed by Eric Carlson.

02:17 Changeset [49086] by ukai@chromium.org
  • 2 edits in trunk/WebCore

2009-10-05 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed build fix for ENABLE(WEB_SOCKETS) and v8.

V8ObjectEventListener.h has been removed at r48978

  • bindings/v8/custom/V8WebSocketCustom.cpp:
02:06 Changeset [49085] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector console stops working while JS in IFRAME is paused.

https://bugs.webkit.org/show_bug.cgi?id=29958

  • inspector/front-end/InjectedScript.js: (InjectedScript._evaluateOn): (InjectedScript.addInspectedNode): (InjectedScript._ensureCommandLineAPIInstalled):
01:56 Changeset [49084] by pfeldman@chromium.org
  • 13 edits in trunk/WebCore

2009-10-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Introduce inspected object groups for console
and watch evaluation results so that they could be released
explicitly.

https://bugs.webkit.org/show_bug.cgi?id=29891

  • bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::wrapObject):
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::wrapObject): (WebCore::InspectorBackend::releaseWrapperObjectGroup):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::wrapObject): (WebCore::InspectorController::unwrapObject): (WebCore::InspectorController::releaseWrapperObjectGroup):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addMessageToConsole):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.evalInInspectedWindow): (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed):
  • inspector/front-end/InjectedScript.js: (InjectedScript.evaluate): (InjectedScript._evaluateAndWrap): (InjectedScript.evaluateInCallFrame):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSection.prototype.update):
01:42 Changeset [49083] by vestbo@webkit.org
  • 4 edits
    1 move in trunk/WebCore

Rename WebCore/css/mediaControlsQT.css and MediaControllerThemeQT

https://bugs.webkit.org/show_bug.cgi?id=30013

Reviewed by Eric Carlson.

The QT suffix has been expanded to QuickTime, to not cause confusion
and name-crashes with similar files in the Qt port.

10/04/09:

22:27 Changeset [49082] by bweinstein@apple.com
  • 7 edits
    1 add in trunk/WebCore

2009-10-04 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.


Fixes <https://bugs.webkit.org/show_bug.cgi?id=30064>
Syntax Highlighting CSS shouldn't be duplicated.

Refactor syntax highlighting CSS into a new file, add it to the
projects, and have SourceFrame.js and inspector.html include the
new CSS file.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspectorSyntaxHighlight.css: Added.
  • inspector/front-end/WebKit.qrc:
21:16 Changeset [49081] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

2009-10-04 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.


Fixes <https://bugs.webkit.org/show_bug.cgi?id=30062>
Inspector should syntax highlight JS/CSS in elements view.

Add syntax highlighting of CSS and JavaScript tags to the elements panel.
Copied CSS rules from SourceFrame.js to inspector.css, and have the text nodes
in utilities.js call the CSS or JS Syntax highlighters if their parent is a script
or style tag.

  • inspector/front-end/inspector.css:
  • inspector/front-end/utilities.js:
19:52 Changeset [49080] by ukai@chromium.org
  • 4 edits in trunk

2009-10-04 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel

Enable Web Sockets in chromium build.
https://bugs.webkit.org/show_bug.cgi?id=29917

  • WebCore.gyp/WebCore.gyp:

2009-10-04 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel

Enable Web Sockets in chromium build.
https://bugs.webkit.org/show_bug.cgi?id=29917

  • chromium/features.gypi:
16:43 Changeset [49079] by kdecker@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Cameron Zwarich.

  • WebView/WebPreferenceKeysPrivate.h: Added new key.
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Leave plug-in halting disabled by default. (-[WebPreferences pluginHalterEnabled]): Added. (-[WebPreferences setPluginHalterEnabled:]): Ditto.
  • WebView/WebPreferencesPrivate.h: Added above new methods.
14:12 Changeset [49078] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-10-04 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Levin.

check-webkit-style misses whitespace errors for operators:

<<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&,
.

https://bugs.webkit.org/show_bug.cgi?id=30021

  • Scripts/modules/cpp_style.py: Added the operators mentioned above to the same list as == and !=.
13:01 Changeset [49077] by xan@webkit.org
  • 5 edits
    4 adds in trunk

WebCore:

2009-10-01 Xan Lopez <xlopez@igalia.com>

Reviewed by NOBODY (OOPS!).

[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761

Update the HTTP method in the request stored by willSendRequest
after a redirect, since it could have changed.

Test: http/tests/navigation/postredirect-reload.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):

LayoutTests:

2009-10-01 Xan Lopez <xlopez@igalia.com>

Reviewed by NOBODY (OOPS!).

[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761

New test that checks that a reload after a redirect to a page with
a GET method from one with a POST method will use GET and not
POST.

  • http/tests/navigation/postredirect-reload-expected.txt: Added.
  • http/tests/navigation/postredirect-reload.html: Added.
  • http/tests/navigation/resources/postresult.pl:
  • http/tests/navigation/resources/reloadresult.pl: Added.
  • http/tests/navigation/resources/redirect-reload.html: Added.
  • http/tests/navigation/resources/success200.html:
  • http/tests/navigation/resources/testcode.js: (submitFormWithPostRedirectReload): (runRedirectReloadTest):
11:14 Changeset [49076] by xan@webkit.org
  • 6 edits
    3 deletes in trunk

Revert previous patch, as the newly added test breaks other tests.

10:17 Changeset [49075] by xan@webkit.org
  • 6 edits
    3 adds in trunk

WebCore:

2009-10-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761

Update the HTTP method in the request stored by willSendRequest
after a redirect, since it could have changed.

Test: http/tests/navigation/postredirect-reload.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):

LayoutTests:

2009-10-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761

New test that checks that a reload after a redirect to a page with
a GET method from one with a POST method will use GET and not
POST.

  • http/tests/navigation/postredirect-reload-expected.txt: Added.
  • http/tests/navigation/postredirect-reload.html: Added.
  • http/tests/navigation/resources/postresult.pl:
  • http/tests/navigation/resources/reloadresult.pl: Added.
  • http/tests/navigation/resources/success200.html:
  • http/tests/navigation/resources/testcode.js: (submitFormWithPostRedirectReload): (runRedirectReloadTest):
10:12 Changeset [49074] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-10-04 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Fixed Function leak in V8LazyEventListener.
(Should fix the remaning leak in
https://bugs.webkit.org/show_bug.cgi?id=29093).
V8LazyEventListeners used to create FunctionTemplates for each
wrapped listener which in turn created Functions that were cached
forever in V8 Context. Now there is at most one such Function per
Context.
https://bugs.webkit.org/show_bug.cgi?id=30060

Added new hidden property name to store toString result:

  • bindings/v8/V8HiddenPropertyName.cpp:
  • bindings/v8/V8HiddenPropertyName.h:

Switched to static FunctionTemplate:

  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListenerToString): (WebCore::V8LazyEventListener::prepareListenerObject):

10/03/09:

20:46 Changeset [49073] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2009-10-03 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

CSS Source View Should be Syntax Highlighted
https://bugs.webkit.org/show_bug.cgi?id=14359

Support for WebKit's CSS Variables @variables and var()

  • inspector/front-end/SourceFrame.js: (WebInspector.CSSSourceSyntaxHighligher):
20:14 Changeset [49072] by joepeck@webkit.org
  • 3 edits in trunk/WebCore

2009-10-03 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Inspector should remember preferences for docked/undocked etc
https://bugs.webkit.org/show_bug.cgi?id=29089

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._toggleLargerResources): toggle the preference
  • inspector/front-end/inspector.js: (WebInspector._loadPreferences): factored out loading preferences (WebInspector.loaded):
19:50 Changeset [49071] by joepeck@webkit.org
  • 3 edits in trunk/WebCore

2009-10-03 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

CSS Source View Should be Syntax Highlighted
https://bugs.webkit.org/show_bug.cgi?id=14359

Trigger the Syntax Highlighter for CSS files.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): (WebInspector.SourceFrame.prototype.syntaxHighlightCSS):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded):

Factored out the Syntax Highlighting procedure into a "Class"
Added CSSSourceSyntaxHighlighter and JavaScriptSourceSyntaxHighlighter

(WebInspector.SourceSyntaxHighligher):
(WebInspector.SourceSyntaxHighligher.prototype.createSpan):
(WebInspector.SourceSyntaxHighligher.prototype.process.processChunk):
(WebInspector.SourceSyntaxHighligher.prototype.process):
(WebInspector.CSSSourceSyntaxHighligher): the CSS Highlighter
(WebInspector.JavaScriptSourceSyntaxHighligher): the JS Highlighter

17:41 Changeset [49070] by abarth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-10-03 Adam Barth <abarth@webkit.org>

Unreview build fix. I wish I had a try server...

  • Api/qwebpage.cpp: (QWebPagePrivate::updateAction):
17:36 Changeset [49069] by abarth@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-03 Adam Barth <abarth@webkit.org>

More build fixing.

  • webkit/webkitwebview.cpp: (webkit_web_view_go_back_or_forward): (webkit_web_view_can_go_back_or_forward):
17:26 Changeset [49068] by abarth@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-03 Adam Barth <abarth@webkit.org>

Unreviewed build fix.

  • webkit/webkitwebview.cpp: (webkit_web_view_go_back_or_forward):
17:17 Changeset [49067] by abarth@webkit.org
  • 12 edits in trunk

2009-10-03 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Factor back-forward list methods out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30037

This change moves these back-forward related methods from FrameLoader
to Page. It's possible we should move these methods into some kind of
"page controller" object, but we can figure that out in a future patch.

  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::timerFired):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::close):
  • page/History.cpp: (WebCore::History::length):
  • page/Page.cpp: (WebCore::Page::canGoBackOrForward): (WebCore::Page::goBackOrForward): (WebCore::Page::getHistoryLength):
  • page/Page.h:
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):

2009-10-03 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Factor PageController out of FrameLoader and Page
https://bugs.webkit.org/show_bug.cgi?id=30037

  • webkit/webkitwebview.cpp: (webkit_web_view_can_go_back_or_forward):
13:50 Changeset [49066] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-03 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Remove 5 tests from the Skipped list that pass after the addition
of layoutTestController.overridePreference().

https://bugs.webkit.org/show_bug.cgi?id=29970

  • platform/qt/Skipped:
10:01 Changeset [49065] by ggaren@apple.com
  • 7 edits in trunk/JavaScriptCore

Removed the concept of a "fast access cutoff" in arrays, because it
punished some patterns of array access too much, and made things too
complex for inlining in some cases.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-02
Reviewed by Sam Weinig.

1.3% speedup on SunSpider.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emitSlow_op_put_by_val):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:

(JSC::): Check m_vectorLength instead of m_fastAccessCutoff when
getting / putting from / to an array. Inline putting past the end of
the array.

  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToRegisters):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::checkConsistency):

  • runtime/JSArray.h:

(JSC::JSArray::canGetIndex):
(JSC::JSArray::canSetIndex):
(JSC::JSArray::setIndex):
(JSC::JSArray::markChildrenDirect): Removed m_fastAccessCutoff, and
replaced with checks for JSValue() to detect reads and writes from / to
uninitialized parts of the array.

03:27 Changeset [49064] by pfeldman@chromium.org
  • 11 edits in trunk/WebCore

2009-10-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: prepare InspectorController for being used from layout tests.
This change adds evaluateForTestInFrontend method with the callback that
allows evaluating arbitrary code in the frontend context.

https://bugs.webkit.org/show_bug.cgi?id=30008

  • WebCore.Inspector.exp:
  • WebCore.order:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::didEvaluateForTestInFrontend):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::evaluateForTestInFrontend): (WebCore::InspectorController::didEvaluateForTestInFrontend):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::evaluateForTestInFrontend):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/inspector.js: (WebInspector.evaluateForTestInFrontend):

10/02/09:

23:31 Changeset [49063] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Node search mode is not getting reset on element selection.

https://bugs.webkit.org/show_bug.cgi?id=30016

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
22:24 Changeset [49062] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

2009-10-02 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.

Fixes <https://bugs.webkit.org/show_bug.cgi?id=30036>
Should be able to resize Cookie Columns.

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype.update.callback): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype.resize):
22:10 Changeset [49061] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Windows build fix.
Re-apply lost changes to auto-version.sh.

  • win/tools/scripts/auto-version.sh:
19:51 Changeset [49060] by jhoneycutt@apple.com
  • 12 edits in trunk/WebCore

Make WebCore::PluginView participate in plug-in halting.

Reviewed by Sam Weinig.

WebCore:

Have plug-ins opt in to automatic halting.

Reviewed by NOBODY (OOPS!).

  • platform/graphics/BitmapImage.h:

Declare a create() function that takes an HBITMAP.

  • platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::create):
Use GetObject() to fill out a DIBSECTION structure for the given
HBITMAP. Call CGBitmapContextCreate() to create a CG context from the
bits of the bitmap. Create a CG image from the context, and pass this
when creating a new BitmapImage.

  • plugins/PluginView.cpp:

(WebCore::PluginView::start):
If we successfully started, tell our parent frame's Page.
(WebCore::PluginView::stop):
Tell our parent frame's Page that we stopped.
(WebCore::PluginView::node):

  • plugins/PluginView.h:

Inherit from HaltablePlugin.
(WebCore::PluginView::setPlatformPluginWidget):
On platforms where the platform plug-in widget is the WebCore::Widget's
platform widget, have setPlatformPluginWidget() call
setPlatformWidget().

  • plugins/PluginViewNone.cpp:

(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

  • plugins/mac/PluginViewMac.cpp:

(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::platformDestroy):
After destroying the window, set the platform plug-in widget to 0 to
ensure that Widget isn't holding a stale handle.
(WebCore::PluginView::halt):
Have our element's RenderWidget display a screenshot of the plug-in,
then stop the plug-in and destroy it.
(WebCore::PluginView::restart):
Clear the RenderWidget's substitute image, then start the plug-in.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::showSubstituteImage):
Set m_substituteImage to the passed image, and repaint.
(WebCore::RenderWidget::paint):
If we have a substitute image, paint that instead of allowing the
widget to paint itself.

  • rendering/RenderWidget.h:

Declare showSubstituteImage(). Added a member to store the substitute
image.

19:10 Changeset [49059] by abarth@webkit.org
  • 8 edits
    2 adds in trunk/WebCore

2009-10-02 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Move PolicyCheck out of FrameLoader.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=30035

Purely code motion (and adding a destructor).

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/PolicyCheck.cpp:
  • loader/PolicyCheck.h:
18:47 Changeset [49058] by jparent@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-02
Adding myself and Ojan Vafai as committers, because we are committers.

  • Scripts/modules/committers.py:
17:47 Changeset [49057] by mrowe@apple.com
  • 5 edits in trunk/WebKit/mac

Roll out r49044 as it breaks many tests.

16:35 Changeset [49056] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-10-02 Jonni Rainisto <jonni.rainisto@nokia.com>

Reviewed by Darin Adler.

Math.random() gives too low values on Win32 when _CRT_RAND_S is not defined
https://bugs.webkit.org/show_bug.cgi?id=29956

  • wtf/RandomNumber.cpp: (WTF::randomNumber): Added PLATFORM(WIN_OS) to handle 15bit rand()
16:27 Changeset [49055] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-10-02 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Update pixel test image for fast/table/vertical-align-baseline.html.

Expected render tree dump for this test was modified in r40146
<http://trac.webkit.org/changeset/40146>, but the image was not updated with it.

  • platform/mac/fast/table/vertical-align-baseline-expected.checksum:
  • platform/mac/fast/table/vertical-align-baseline-expected.png:
16:20 Changeset [49054] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Add NPNVToolkit value quirk in plugins for nspluginwrapper.
Plugin error message was:
ERROR: failed to initialize brower-side RPC events listener
https://bugs.webkit.org/show_bug.cgi?id=25053

(WebCore::staticPluginQuirkRequiresGtkToolKit_NPN_GetValue):
(WebCore::PluginPackage::load):

16:12 Changeset [49053] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] X sync our XEmbed container window creation before sending the
xid to plugins.
https://bugs.webkit.org/show_bug.cgi?id=25053

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
16:02 Changeset [49052] by simon.fraser@apple.com
  • 4 edits
    4 adds in trunk

2009-10-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Setting zero size on a container of a video element doesn't hide the controller
https://bugs.webkit.org/show_bug.cgi?id=30031

Fix a logic error in enclosingCompositingLayer() when mixing normal flow and
positioned layers. This resulted in enclosingCompositingLayer() giving back a different
answer to the logic used to actually parent compositing layers, so layer positions
and layer hierarchy would be out of agreement.

Test: compositing/geometry/clipped-video-controller.html

  • rendering/RenderLayer.cpp: (WebCore::compositingContainer): (WebCore::RenderLayer::enclosingCompositingLayer):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::setCompositingParent):
15:49 Changeset [49051] by eric@webkit.org
  • 7 edits in trunk/WebCore

2009-10-02 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

  • Move the following methods of HTMLInputElement and HTMLTextAreaElement to HTMLTextFormControlElement.

setSelectionStart()
setSelectionEnd()
select()
setSelectionRange()
selectionStart()
selectionEnd()
selection()

  • Introduce cachedSelectionStart() and cachedSelectionEnd().
  • Unify HTMLInputElement::isTextFieldWithRenderer() and HTMLTextAreaElement::rendererAfterUpdateLayout() into textRendererAfterUpdateLayout().
  • Unify a part of parseMappedAttribute() of HTMLInputElement and HTMLTextAreaElement.

https://bugs.webkit.org/show_bug.cgi?id=29782

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::textRendererAfterUpdateLayout): (WebCore::HTMLTextFormControlElement::setSelectionStart): (WebCore::HTMLTextFormControlElement::setSelectionEnd): (WebCore::HTMLTextFormControlElement::select): (WebCore::HTMLTextFormControlElement::setSelectionRange): (WebCore::HTMLTextFormControlElement::selectionStart): (WebCore::HTMLTextFormControlElement::selectionEnd): (WebCore::HTMLTextFormControlElement::selection): (WebCore::HTMLTextFormControlElement::parseMappedAttribute):
  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::cachedSelectionStart): (WebCore::HTMLInputElement::cachedSelectionEnd):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::cachedSelectionStart): (WebCore::HTMLTextAreaElement::cachedSelectionEnd):
15:40 Changeset [49050] by eric@webkit.org
  • 14 edits in trunk/WebCore

2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Disconnect event listeners on navigation.
Fixes http://crbug.com/23597.
https://bugs.webkit.org/show_bug.cgi?id=30027

Added V8ListenerGuard that is shared by listeners and proxy. On
navigation proxy sets a flag in the guard turning off listeners.

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener):
  • bindings/v8/V8AbstractEventListener.h: (WebCore::V8ListenerGuard::create): (WebCore::V8ListenerGuard::isDisconnected): (WebCore::V8ListenerGuard::disconnectListeners): (WebCore::V8ListenerGuard::V8ListenerGuard): (WebCore::V8AbstractEventListener::disconnected):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getEventListener):
  • bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper):
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::disconnectFrame): (WebCore::V8Proxy::disconnectEventListeners): (WebCore::V8Proxy::clearForNavigation):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::listenerGuard):
  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener):
  • bindings/v8/V8WorkerContextEventListener.h: (WebCore::V8WorkerContextEventListener::create):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener):
  • bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create):
15:33 Changeset [49049] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Fix WebGL build after CustomGetter constructor changes
https://bugs.webkit.org/show_bug.cgi?id=30020

  • page/DOMWindow.idl: Changed CustomGetter to JSCCustomGetter for CanvasArray constructors.
15:23 Changeset [49048] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Web Inspector: text in a "Request Payload" section disappears on selection
https://bugs.webkit.org/show_bug.cgi?id=29967

No new tests.

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestPayload):
15:15 Changeset [49047] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

Test that having infinite recursion in XMLHttpRequest event handler does not crash.
https://bugs.webkit.org/show_bug.cgi?id=29974

  • fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html: Added.

2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Recursion guard for V8Proxy::callFunction.
Fixes http://crbug.com/23278.
https://bugs.webkit.org/show_bug.cgi?id=29974

Test: fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction):
14:59 Changeset [49046] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Clean up the QNetworkReplyHandler to only apply HTTP headers
for protocols in the HTTP family.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-02
Reviewed by Simon Hausmann.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

14:55 Changeset [49045] by japhet@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2009-10-02 Victor Wang <victorw@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=29619

Patch http://trac.webkit.org/changeset/35290 adds win support for
JPEG and GIF for toDataURL encoding canvases and the test was
rewritten to not output the encoded image data, it should pass
on Win now.

  • platform/win/Skipped:
  • platform/win/fast/canvas/toDataURL-supportedTypes-expected.txt: Removed.
14:53 Changeset [49044] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

WebKit side of <rdar://problem/7179166>

Reviewed by Kevin Decker and Dan Bernstein.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:

Add an m_pluginIsWaitingForDraw member variable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Initialize m_pluginIsWaitingForDraw.

(WebKit::NetscapePluginInstanceProxy::invalidateRect):
Set m_pluginIsWaitingForDraw to true.

(WebKit::NetscapePluginInstanceProxy::didDraw):
If m_pluginIsWaitingForDraw is true, call _WKPHPluginInstanceDidDraw.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView drawRect:]):
Call didDraw.

  • Plugins/Hosted/WebKitPluginHost.defs:

Add PHPluginInstanceDidDraw.

14:49 Changeset [49043] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

2009-10-02 Brian Weinstein <bweinstein@apple.com>

Reviewed by Jon Honeycutt.

Fix test breakages by adding null checks, and putting inspector code in
ENABLE(INSPECTOR).

  • dom/Document.cpp: (WebCore::Document::finishedParsing):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
14:39 Changeset [49042] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Move error check into sendResponseIfNeeded() as suggested
by Eric Seidel. Also, remove some dead code.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-02
Reviewed by Simon Hausmann.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

14:34 Changeset [49041] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting.
<rdar://problem/7148712>
https://bugs.webkit.org/show_bug.cgi?id=28992

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-02
Reviewed by Adele Peterson.

Test: editing/selection/replace-selection-crash.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Handle properly the case of
the destination position matching the end of the paragraph to move.

LayoutTests: Added test case.
<rdar://problem/7148712> Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting.
https://bugs.webkit.org/show_bug.cgi?id=28992

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-02
Reviewed by Adele Peterson.

  • editing/selection/replace-selection-crash-expected.txt: Added.
  • editing/selection/replace-selection-crash.html: Added.
14:15 Changeset [49040] by jorlow@chromium.org
  • 13 edits
    3 adds in trunk

2009-10-02 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Implement per-storage-area quotas for LocalStorage
https://bugs.webkit.org/show_bug.cgi?id=29991

I put 90% of the code in StorageMap since the decision to allow an update is
closely tied to quota tracking. The quota is set via a page's Settings class.
Like with the local storage path and whether it's enabled, it's assumed that
all pages in the same group will have the same settings. The setting defaults
to 5mb which is what the spec suggests, but it can easily be changed to
anything else--including StorageMap::noQuota. Any values in LocalStorage are
grandfathered in regarudless of quota, so importItem only tracks (and will
never block) imports.

I believe this change is a good transition to more complex quota management.
For example, if we wanted to track quotas in the SQLite DB, then we'd just add
a function to the StorageMap that sets the quota. This would be fine since all
use of LocalStorage is blocked on the import completing, so you'd never hit a
quota error in the mean time. Also, if embedders wanted to ask the user
whether to expand the quota whenever it's hit (before deciding whether or not
to raise an exception), a callback via the chrome client should be fairly easy.
That said, I think it's best to add these features in steps rather than one
huge patch. (Both of these are on my TODO list, btw.)

Included is a layout test that verifies the behavior. It assumes the default
quota is 5mb (since that's what Settings defaults to).

Test: storage/domstorage/localstorage/quota.html

  • page/PageGroup.cpp: (WebCore::PageGroup::localStorage):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setLocalStorageQuota):
  • page/Settings.h: (WebCore::Settings::localStorageQuota):
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::create): (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::clear):
  • storage/StorageAreaImpl.h:
  • storage/StorageMap.cpp: (WebCore::StorageMap::create): (WebCore::StorageMap::StorageMap): (WebCore::StorageMap::copy): (WebCore::StorageMap::setItem): (WebCore::StorageMap::removeItem): (WebCore::StorageMap::importItem):
  • storage/StorageMap.h: (WebCore::StorageMap::quota):
  • storage/StorageNamespace.cpp: (WebCore::StorageNamespace::localStorageNamespace):
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::localStorageNamespace): (WebCore::StorageNamespaceImpl::sessionStorageNamespace): (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea):
  • storage/StorageNamespaceImpl.h:

2009-10-02 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Implement per-storage-area quotas for LocalStorage
https://bugs.webkit.org/show_bug.cgi?id=29991

I put 90% of the code in StorageMap since the decision to allow an update is
closely tied to quota tracking. The quota is set via a page's Settings class.
Like with the local storage path and whether it's enabled, it's assumed that
all pages in the same group will have the same settings. The setting defaults
to 5mb which is what the spec suggests, but it can easily be changed to
anything else--including StorageMap::noQuota. Any values in LocalStorage are
grandfathered in regarudless of quota, so importItem only tracks (and will
never block) imports.

I believe this change is a good transition to more complex quota management.
For example, if we wanted to track quotas in the SQLite DB, then we'd just add
a function to the StorageMap that sets the quota. This would be fine since all
use of LocalStorage is blocked on the import completing, so you'd never hit a
quota error in the mean time. Also, if embedders wanted to ask the user
whether to expand the quota whenever it's hit (before deciding whether or not
to raise an exception), a callback via the chrome client should be fairly easy.
That said, I think it's best to add these features in steps rather than one
huge patch. (Both of these are on my TODO list, btw.)

Included is a layout test that verifies the behavior. It assumes the default
quota is 5mb (since that's what Settings defaults to).

  • storage/domstorage/localstorage/quota-expected.txt: Added.
  • storage/domstorage/localstorage/quota.html: Added.
  • storage/domstorage/script-tests/quota.js: Added. (runTest):
13:09 Changeset [49039] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Database Inspector crashes Safari when table has more than 21 columns
https://bugs.webkit.org/show_bug.cgi?id=29924

  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.dataGridForResult): adjust the minimum column width percentage to be flexible for many columns.
13:07 Changeset [49038] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebView.cpp

Fix Windows bustage.

13:07 Changeset [49037] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebView.cpp

Fix Windows bustage.

13:01 Changeset [49036] by bweinstein@apple.com
  • 11 edits in trunk/WebCore

2009-10-02 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.

Fixes <http://webkit.org/b/14370>.
Inspector's timeline should record when certain DOM events fired.


This patch adds calls into the Web Inspector when the main frame
fires an load event, and when the document fires its DOMContent
event. Once these values are passed in, they are sent to the Web Inspector
as a timing change, and these are denoted by vertical lines in the resources
panel (blue for DOM Content, red for load event).

  • English.lproj/localizedStrings.js: Added tooltip text.
  • dom/Document.cpp: (WebCore::Document::finishedParsing): Added an Inspector callback for DOM Content.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::mainResourceFiredDOMContentEvent): Tell the main resource it got the event. (WebCore::InspectorController::mainResourceFiredLoadEvent): Ditto.
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): Added new variables. (WebCore::InspectorResource::updateScriptObject): Send new variables to inspector.js. (WebCore::InspectorResource::markDOMContentEventTime): Send a TimingChange event. (WebCore::InspectorResource::markLoadEventTime): Ditto.
  • inspector/InspectorResource.h:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get mainResourceLoadTime): (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime): (WebInspector.ResourcesPanel.prototype.get mainResourceDOMContentTime): (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Draw dividers for event timings. (WebInspector.ResourceTimeCalculator.prototype.computePercentageFromEventTime):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent): Add an Inspector callback for the Load event.
13:00 Changeset [49035] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebView.cpp

Fix Windows bustage.

12:57 Changeset [49034] by hyatt@apple.com
  • 2 edits in trunk/WebKitTools/DumpRenderTree

Update DUmpRenderTree to account for new API.

12:42 Changeset [49033] by hyatt@apple.com
  • 17 edits in trunk

Add support for blacklist patterns to user stylesheets and scripts in addition to whitelist patterns.

Reviewed by Adam Roben.

WebCore:

  • WebCore.base.exp:
  • dom/Document.cpp:

(WebCore::Document::pageGroupUserSheets):

  • page/Frame.cpp:

(WebCore::Frame::injectUserScriptsForWorld):

  • page/PageGroup.cpp:

(WebCore::PageGroup::addUserScript):
(WebCore::PageGroup::addUserStyleSheet):
(WebCore::PageGroup::removeUserContentWithURLForWorld):
(WebCore::PageGroup::removeUserContentForWorld):

  • page/PageGroup.h:
  • page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::matchesPatterns):

  • page/UserContentURLPattern.h:
  • page/UserScript.h:

(WebCore::UserScript::UserScript):
(WebCore::UserScript::whitelist):
(WebCore::UserScript::blacklist):

  • page/UserStyleSheet.h:

(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::whitelist):
(WebCore::UserStyleSheet::blacklist):

WebKit/mac:

  • WebView/WebView.mm:

(toStringVector):
(+[WebView _addUserScriptToGroup:source:url:worldID:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:source:url:worldID:whitelist:blacklist:]):

  • WebView/WebViewPrivate.h:

WebKit/win:

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:

(toStringVector):
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):

  • WebView.h:
11:41 Changeset [49032] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKit

2009-10-02 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Added gyp_webkit that does a subset of the things gyp_chromium does
plus some specialization for an upstream chromium build.

https://bugs.webkit.org/show_bug.cgi?id=29986

  • chromium/DEPS: Points to gyp_webkit instead of gyp_chromium.
  • chromium/gyp_webkit: A new python file.
11:08 Changeset [49031] by eric.carlson@apple.com
  • 2 edits in trunk/WebKitLibraries

2009-10-02 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

<rdar://problem/7271334>
Rename MediaControllerThemeQT to MediaControllerThemeQuickTime

  • WebKitSystemInterface.h: MediaControllerThemeQT -> MediaControllerThemeQuickTime
11:06 Changeset [49030] by ggaren@apple.com
  • 6 edits in trunk/JavaScriptCore

Rolled back in r49004 with the debug 64bit build fixed

11:02 Changeset [49029] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

Build fix when SVG is not enabled
https://bugs.webkit.org/show_bug.cgi?id=30011

Move TextRenderingMode related functions out from
the ENABLE(SVG) guard.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator TextRenderingMode):
10:57 Changeset [49028] by bweinstein@apple.com
  • 2 edits in trunk/WebKitTools

2009-10-02 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
this will help the patch merging process when TryBots are used.

  • Scripts/svn-create-patch:
10:49 Changeset [49027] by cmarrin@apple.com
  • 3 edits
    2 adds in trunk

WebGL crashes with recent CanvasArray change
https://bugs.webkit.org/show_bug.cgi?id=30018

10:22 Changeset [49026] by sfalken@apple.com
  • 8 edits
    1 delete in trunk

<https://bugs.webkit.org/show_bug.cgi?id=29989>
Safari version number shouldn't be exposed in WebKit code

Reviewed by Mark Rowe.

For a WebKit version of 532.3.4:
Product version is: 5.32.3.4 (was 4.0.3.0)
File version is: 5.32.3.4 (was 4.532.3.4)

JavaScriptCore:

WebCore:

  • WebCore.vcproj/QTMovieWin.rc:

WebKit/win:

  • WebKit.vcproj/WebKit.rc:

WebKitLibraries:

  • win/tools/scripts/PRODUCTVERSION: Removed.
  • win/tools/scripts/auto-version.sh: Re-worked script to remove references to PRODUCTVERSION.
10:19 Changeset [49025] by senorblanco@chromium.org
  • 2 edits in trunk/WebCore

Enable two point radial gradients in Chromium/Skia.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=30017

Covered by the following tests:

LayoutTests/svg/W3C-SVG-1.1/pservers-grad-13-b.svg
LayoutTests/fast/backgrounds/svg-as-background-3.html
LayoutTests/fast/gradients/generated-gradients.html
LayoutTests/fast/gradients/simple-gradients.html

  • platform/graphics/skia/GradientSkia.cpp:

(WebCore::Gradient::platformGradient):

09:14 Changeset [49024] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-10-02 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement layoutTestController.overridePreference().
https://bugs.webkit.org/show_bug.cgi?id=29970

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setPrivateBrowsingEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::overridePreference):
  • DumpRenderTree/qt/jsobjects.h:
08:49 Changeset [49023] by laszlo.1.gombos@nokia.com
  • 5 edits in trunk

2009-10-02 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Conditionally guard cursor code (cursor and updateCursor functions) with !QT_NO_CURSOR.
Otherwise, it is inconsistent with class declaration of QCursor.

  • Api/qgraphicswebview.cpp:
  • Api/qwebview.cpp:

2009-10-02 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Conditionally guard cursor code (cursor and updateCursor functions) with !QT_NO_CURSOR.
Otherwise, it is inconsistent with class declaration of QCursor.

No new tests.

  • platform/qt/QWebPageClient.h:
08:40 Changeset [49022] by vestbo@webkit.org
  • 2 edits in trunk/JavaScriptCore

Fix the Qt on Mac OS X build.

Rubber-stamped by Simon Hausmann.

  • wtf/FastMalloc.cpp:
05:05 QtBackLog edited by zecke@selfish.org
(diff)
05:04 QtBackLog edited by zecke@selfish.org
(diff)
04:32 Changeset [49021] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] missing support for anamorphic PAR video size
https://bugs.webkit.org/show_bug.cgi?id=29717

cleanup of caps handling in the video sink

  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_set_caps):
04:18 Changeset [49020] by hausmann@webkit.org
  • 34 edits in trunk

.: Disable a few more harmless MSVC warnings.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

  • WebKit.pri:

WebCore: Fix compiler warnings about unused function arguments.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

  • bridge/qt/qt_class.h:
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):

  • dom/XMLTokenizerQt.cpp:

(WebCore::XMLTokenizer::initializeParserContext):

  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::getCachedFontPlatformData):

  • platform/graphics/qt/FontFallbackListQt.cpp:

(WebCore::FontFallbackList::setPlatformFont):

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::offsetForPositionForComplexText):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::setURLForRect):

  • platform/graphics/qt/IconQt.cpp:

(WebCore::Icon::createIconForFiles):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::frameBufferAtIndex):

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:

(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::setEndTime):

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::containsCharacters):

  • platform/graphics/qt/StillImageQt.h:

(WebCore::StillImage::destroyDecodedData):

  • platform/network/qt/DnsPrefetchHelper.h:

(WebCore::DnsPrefetchHelper::lookedUp):

  • platform/qt/ContextMenuQt.cpp:

(WebCore::ContextMenu::setPlatformDescription):

  • platform/qt/DragDataQt.cpp:

(WebCore::DragData::asURL):

  • platform/qt/PopupMenuQt.cpp:

(WebCore::PopupMenu::populate):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::supportsFocusRing):
(WebCore::RenderThemeQt::systemFont):
(WebCore::RenderThemeQt::adjustButtonStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::paintMediaSeekBackButton):
(WebCore::RenderThemeQt::paintMediaSeekForwardButton):

  • platform/qt/ScrollViewQt.cpp:

(WebCore::ScrollView::platformAddChild):

  • platform/qt/SearchPopupMenuQt.cpp:

(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):

  • platform/qt/TemporaryLinkStubs.cpp:

(WebCore::signedPublicKeyAndChallengeString):

  • platform/qt/WidgetQt.cpp:

(WebCore::Widget::paint):

  • xml/XSLStyleSheetQt.cpp:

(WebCore::XSLStyleSheet::loadChildSheet):
(WebCore::XSLStyleSheet::setParentStyleSheet):

  • xml/XSLTProcessorQt.cpp:

(WebCore::XSLTMessageHandler::handleMessage):
(WebCore::XSLTProcessor::transformToString):

WebKit/qt: Fix compiler warnings about unused function arguments.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

  • Api/qwebframe.cpp:

(QWebFrame::scrollBarMinimum):

  • Api/qwebpage.cpp:

(QWebPagePrivate::focusInEvent):
(QWebPagePrivate::focusOutEvent):
(QWebPagePrivate::leaveEvent):
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
(QWebPage::triggerAction):
(QWebPage::acceptNavigationRequest):
(QWebPage::chooseFile):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::repaint):
(WebCore::ChromeClientQt::mouseDidMoveOverElement):
(WebCore::ChromeClientQt::reachedMaxAppCacheSize):

  • WebCoreSupport/ContextMenuClientQt.cpp:

(WebCore::ContextMenuClientQt::downloadURL):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
(WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
(WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
(WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
(WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
(WebCore::FrameLoaderClientQt::pluginWillHandleLoadError):
(WebCore::FrameLoaderClientQt::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientQt::createJavaAppletWidget):

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::setAttachedWindowHeight):
(WebCore::InspectorClientQt::highlight):
(WebCore::InspectorClientQt::removeSetting):

04:14 Changeset [49019] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-02 Ben Murdoch <benm@google.com>

Reviewed by David Kilzer.

Stale database version persists through browser refresh (changeVersion doesn't work)
https://bugs.webkit.org/show_bug.cgi?id=27836

Scale the cairo surface of the video sink depending on the
pixel-aspect-ratio of the video buffer to paint. Also
destruct/re-create the surface when setSize() is called with a new
size.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::setSize): (WebCore::MediaPlayerPrivate::paint):
  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func):
03:19 Changeset [49018] by benm@google.com
  • 4 edits
    4 adds in trunk

Stale database version persists through browser refresh (changeVersion doesn't work)
https://bugs.webkit.org/show_bug.cgi?id=27836

WebCore:

Reviewed by David Kilzer.

Tests: storage/change-version-handle-reuse.html

storage/change-version.html

  • bindings/v8/custom/V8DatabaseCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL): Implement the V8 binding for database.changeVersion().
(WebCore::createTransaction): Fix a bug that was checking the wrong argument index to save the success callback.

  • storage/Database.cpp:

(WebCore::updateGuidVersionMap): Safely update the Guid/version hash map.
(WebCore::Database::~Database): Remove code that removes the database from the guid->database and guid->version maps.
(WebCore::Database::setVersionInDatabase): Add a comment to explain some behaviour.
(WebCore::Database::close): Move the code that updates the maps from the destructor to here.
(WebCore::Database::performOpenAndVerify): Call updateGuidVersionMap instead of setting the hash map directly.
(WebCore::Database::setExpectedVersion): Update the in memory guid->version map when we want to update the database version.

LayoutTests:

Reviewed by David Kilzer.

  • storage/change-version-expected.txt: Added.
  • storage/change-version-handle-reuse-expected.txt: Added.
  • storage/change-version-handle-reuse.html: Added.
  • storage/change-version.html: Added.
01:34 Changeset [49017] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Partial WINSCW build fix.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-10-02
Reviewed by Simon Hausmann.

Add parentheses around the function pointer declaration, similar to the
second hunk in r48825.

  • loader/CachedResourceHandle.h:
01:22 Changeset [49016] by hausmann@webkit.org
  • 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h

Roll out accidential r49015 commit

01:21 Changeset [49015] by hausmann@webkit.org
  • 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h

use wtf/unicode/qt4/unicodeQt4.h for RVCT and WINSCW

Relative includes don't work properly with WINSCW

01:20 Changeset [49014] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Adam Barth <abarth@webkit.org>

Unreviewed attempted build fix by Xcode magic.

  • WebCore.xcodeproj/project.pbxproj:
01:03 Changeset [49013] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-10-02 Adam Barth <abarth@webkit.org>

Unreviewed build fix. Actually add the new files.

  • loader/RedirectScheduler.cpp: Added. (WebCore::ScheduledRedirection::): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::RedirectScheduler::RedirectScheduler): (WebCore::RedirectScheduler::~RedirectScheduler): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel):
  • loader/RedirectScheduler.h: Added.
00:57 Changeset [49012] by abarth@webkit.org
  • 9 edits in trunk/WebCore

2009-10-01 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Move RedirectScheduler to its own file
https://bugs.webkit.org/show_bug.cgi?id=29952

This change is purely code motion.

No behavior change.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/RedirectScheduler.cpp: Added. (WebCore::ScheduledRedirection::): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::RedirectScheduler::RedirectScheduler): (WebCore::RedirectScheduler::~RedirectScheduler): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel):
  • loader/RedirectScheduler.h: Added.
00:41 Changeset [49011] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Dave MacLachlan <dmaclach@gmail.com>

Reviewed by David Levin.

Clean up warnings in WebCore/bindings/v8/npruntime.cpp
https://bugs.webkit.org/show_bug.cgi?id=29971

Gets rid of warnings on gcc about using anonymous namespaces

warning: 'StringKeyHashTraits' has a base
'WTF::GenericHashTraits<<unnamed>::StringKey>'
whose type uses the anonymous namespace

and

warning: 'WTF::PairHashTraits<StringKeyHashTraits,
WTF::HashTraits<PrivateIdentifier*> >' has a base
'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey,
PrivateIdentifier*> >' whose type uses the anonymous namespace

No tests required.

  • bindings/v8/npruntime.cpp:
00:31 Changeset [49010] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

Allow enabling and disabling of the JIT through a qmake variable.

Patch by Jørgen Lind <jorgen.lind@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

Qt's configure may set this variable through .qmake.cache if a
commandline option is given and/or the compile test for hwcap.h
failed/succeeded.

10/01/09:

21:01 Changeset [49009] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-10-01 Drew Wilson <atwilson@chromium.org>

Reviewed by David Levin.

Remove clone count from worker-cloneport.html as it's flakey on multi-process ports like Chromium.
https://bugs.webkit.org/show_bug.cgi?id=29698

  • fast/workers/worker-cloneport-expected.txt:
  • fast/workers/worker-cloneport.html:
19:50 Changeset [49008] by mrowe@apple.com
  • 6 edits in trunk

Fix the Tiger build. Don't unconditionally enable 3D canvas as it is not supported on Tiger.

17:58 Changeset [49007] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk

2009-10-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, build fix.

[Qt] Symbian build break after r48976.
unix is set for Symbian in the Qt build system.

  • WebKit.pri:
17:25 Changeset [49006] by cmarrin@apple.com
  • 30 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=29906
Turn on compile time switch for WebGL, but have runtime switch default to off

This also fixes LayoutTests which broke with the flag turned on, and
fixes a crash found in the LayoutTests.

16:49 Changeset [49005] by mrowe@apple.com
  • 6 edits in trunk/JavaScriptCore

Roll out r49004 since it broke the debug build.

16:32 Changeset [49004] by ggaren@apple.com
  • 6 edits in trunk/JavaScriptCore

Take one branch instead of two to test for JSValue().

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-01
Reviewed by Sam Weinig.

1.1% SunSpider speedup.

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_create_arguments):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.

  • runtime/JSValue.cpp:

(JSC::JSValue::description): Added support for dumping the new empty value,
and deleted values, in debug builds.

  • runtime/JSValue.h:

(JSC::JSValue::JSValue()): Construct JSValue() with the empty value tag.

(JSC::JSValue::JSValue(JSCell*)): Convert null pointer to the empty value
tag, to avoid having two different c++ versions of null / empty.

(JSC::JSValue::operator bool): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.

16:00 Changeset [49003] by bdakin@apple.com
  • 14 edits in trunk

WebCore: Fix for <rdar://problem/7264725> Re-add a vendor prefix to box-
shadow (29927)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29927

Reviewed by Dan Bernstein.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::ShadowParseContext::ShadowParseContext):
(WebCore::ShadowParseContext::commitValue):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitColor):
(WebCore::cssPropertyID):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • page/animation/AnimationBase.cpp:

(WebCore::ensurePropertyMap):

LayoutTests: Updated test results for <rdar://problem/7264725> Re-add a vendor
prefix to box-shadow (29927)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29927

Reviewed by Dan Bernstein.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
15:21 Changeset [49002] by eric@webkit.org
  • 2 edits in trunk/WebKit

2009-10-01 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Make it possible to override the list of feature defines when building
downstream.

https://bugs.webkit.org/show_bug.cgi?id=29979

  • chromium/features.gypi:
14:56 Changeset [49001] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-10-01 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Adam Roben.

Added fast/inline/relative-positioned-overflow.html to Skipped list because
it hits an asssert in Windows debug builds. Assertion failure is being tracked
by <https://bugs.webkit.org/show_bug.cgi?id=29966>.

  • platform/win/Skipped:
14:24 Changeset [49000] by bdakin@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

Appeasing the Bot.

  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
14:19 Changeset [48999] by bweinstein@apple.com
  • 3 edits
    1 add in trunk/LayoutTests

2009-10-01 Brian Weinstein <bweinstein@apple.com>

Reviewed by Beth Dakin.

Update expected Windows results after new CSS Text Kerning changes.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/win/fast/css/text-rendering-expected.txt: Added.
13:46 Changeset [48998] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Set the type for the fake event, otherwise the test ASSERTs in
debug builds.

  • tests/testhittestresult.c: (load_status_cb):
13:44 Changeset [48997] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Disable HTTP loading tests that fail on the buildbot.

  • platform/qt/Skipped:
13:27 Changeset [48996] by atwilson@chromium.org
  • 3 edits in trunk/LayoutTests

REGRESSION: fast/workers/dedicated-worker-lifecycle.html failing intermittently on leopard bot
https://bugs.webkit.org/show_bug.cgi?id=29344

Reviewed by Eric Seidel.

  • fast/workers/resources/dedicated-worker-lifecycle.js:

(runTests):
Allocate objects on the stack to try to force a GC to eliminate flakiness.

  • fast/workers/resources/worker-util.js:

(gc):
Added an optional "forceAlloc" parameter which causes a more extensive stack-clobbering algorithm to be run.
(waitUntilThreadCountMatches):
Pass the forceAlloc flag to gc() to try to force unreferenced workers to get GC'd.

13:24 Changeset [48995] by bdakin@apple.com
  • 2 edits in trunk/WebCore

Rubber-stamped by Sam Weinig.

At bad merge at some point in the development of my patch must have
put TextRenderMode.h in a weird spot in the xcodeproj. Moving it
back where it belongs!

  • WebCore.xcodeproj/project.pbxproj:
13:12 Changeset [48994] by abarth@webkit.org
  • 13 edits in trunk/WebCore

2009-10-01 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove FrameLoader::schedule* APIs
https://bugs.webkit.org/show_bug.cgi?id=29950

Change clients of FrameLoader::schedule* to call redirectScheduler
directly.

No behavior change.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::createWindow): (WebCore::JSDOMWindow::open):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
  • bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::reload):
  • bindings/v8/V8Utilities.cpp: (WebCore::navigateIfAllowed):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::processHttpEquiv):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::receivedFirstData):
  • loader/FrameLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
  • page/History.cpp: (WebCore::History::back): (WebCore::History::forward): (WebCore::History::go):
13:08 Changeset [48993] by bdakin@apple.com
  • 2 edits in trunk/WebCore

Just removing a comment I accidentally committed earlier.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::getCFStringAttributes):

12:54 Changeset [48992] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2009-09-30 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Clean up use of const and mutable in StorageMap
https://bugs.webkit.org/show_bug.cgi?id=29933

What's the point of having every single member variable be mutable and nearly
every method be const? Let's clean it up.

  • storage/StorageMap.cpp: (WebCore::StorageMap::setIteratorToIndex): (WebCore::StorageMap::key): (WebCore::StorageMap::importItem):
  • storage/StorageMap.h:
12:32 Changeset [48991] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable Local tests for Qt.

  • platform/qt/Skipped:
12:21 Changeset [48990] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP loading tests for Qt.

  • platform/qt/Skipped:
12:19 Changeset [48989] by bdakin@apple.com
  • 29 edits
    8 adds in trunk

WebCore: Fix for <rdar://problem/6934421> Support CSS for Text Kerning and
ligature
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=6136

Reviewed by Dave Hyatt.

This patch makes the SVG CSS property text-rendering work with any
HTML, much like it does in Firefox. It accepts four possible input
values: auto, optimizeSpeed, optimizeLegibility, and
geometricPrecision. Right now, in this implementation, here is what
those values correspond to:

auto = optimizeSpeed = what we normally when the value's not set
optimizeLegibility = geometricPrecision = ligatures + kerning

Add new file TextRenderingMode.h to the project files.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

CSS support for the new CSSPropertyTextRendering

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:

All the old SVG CSS support for this property can go away. When
it's used in SVG, it will just fall into the normal HTML case.

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

  • css/SVGCSSValueKeywords.in:

FontDescription stores the m_textRendering bit.

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::textRenderingMode):
(WebCore::FontDescription::setTextRenderingMode):
(WebCore::FontDescription::operator==):

We want to fall into the complex text rendering code path if
kerning and ligatures have been enabled with this property.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::canUseGlyphCache):

Now takes a TextRenderingMode as a parameter.

  • platform/graphics/SimpleFontData.h:

New header for the enum.

  • platform/graphics/TextRenderingMode.h: Added.

(WebCore::):

getCFStringAttributes() now takes a TextRenderingMode as an
attribute.

  • platform/graphics/mac/CoreTextController.cpp:

(WebCore::CoreTextController::collectCoreTextRunsForCharacters):

Enable kerning and ligatures whenever the TextRenderingMode is
OptimizeLegibility or GeometricPrecision

  • platform/graphics/mac/FontMacATSUI.mm:

(WebCore::disableLigatures):
(WebCore::initializeATSUStyle):
(WebCore::ATSULayoutParameters::initialize):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::getCFStringAttributes):

More SVG CSS stuff that isn't needed anymore since SVG will use the
new HTML CSS implementation.

  • rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::InheritedFlags::operator==):
(WebCore::SVGRenderStyle::setBitDefaults):

  • rendering/style/SVGRenderStyleDefs.h:

LayoutTests: Tests for <rdar://problem/6934421> Support CSS for Text Kerning and
ligature
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=6136

Reviewed by Dave Hyatt.

New tests.

  • fast/css/parsing-text-rendering-expected.txt: Added.
  • fast/css/parsing-text-rendering.html: Added.
  • fast/css/resources/parsing-text-rendering.js: Added.

(test):

  • fast/css/text-rendering.html: Added.
  • platform/mac/fast/css/text-rendering-expected.checksum: Added.
  • platform/mac/fast/css/text-rendering-expected.png: Added.
  • platform/mac/fast/css/text-rendering-expected.txt: Added.

New and improved results.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
12:18 Changeset [48988] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-10-01 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=29187

Don't inline ~ListRefPtr() to work around winscw compiler forward declaration
bug regarding templated classes.

The compiler bug is reported at:
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812

The change will be reverted when the above bug is fixed in winscw compiler.

  • wtf/ListRefPtr.h: (WTF::::~ListRefPtr):
12:10 Changeset [48987] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable URI tests for Qt, skip the single test we don't pass.

  • platform/qt/Skipped:
11:29 Changeset [48986] by japhet@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-10-01 Nate Chapin <japhet@chromium.org>

Reviewed by Darin Adler.

Add baseline pngs for a couple of tests that currently only have checksums.

https://bugs.webkit.org/show_bug.cgi?id=28322

  • platform/mac/fast/borders/border-radius-constraints-expected.png: Added.
  • platform/mac/fast/borders/border-radius-split-inline-expected.png: Added.
11:14 Changeset [48985] by kenneth@webkit.org
  • 4 edits in trunk

Rubberstamped by Simon Hausmann.

WebKitTools:

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP tests for Qt

  • Scripts/run-webkit-tests:

LayoutTests:

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP tests for Qt, and skip the subdirs we don't pass yet.

  • platform/qt/Skipped:
11:08 Changeset [48984] by eric@webkit.org
  • 4 edits in trunk

2009-10-01 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Added windows-specific dependencies, updated some revisions and
re-organized file to make revision tracking easier. Also removed
extensions/v8 dependency that is no longer needed upstream.

https://bugs.webkit.org/show_bug.cgi?id=29973

  • chromium/DEPS:

2009-10-01 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

build-webkit --chromium now also works on cygwin.

https://bugs.webkit.org/show_bug.cgi?id=29973

  • Scripts/webkitdirs.pm:
10:41 Changeset [48983] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Use isClosure property of scope proxy to decide whether the
scope is a closure.

https://bugs.webkit.org/show_bug.cgi?id=29965

  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
10:29 Changeset [48982] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2009-10-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Odd color transitions on anchors with transition-property: all
https://bugs.webkit.org/show_bug.cgi?id=29911

When transitioning maybe-invalid colors, if the source and destination
color are both invalid, then don't animate.

This fixes an issue where a child element of an element running a color
transition, with -webkit-transition-property:all, would show a color change.
This happened because the "maybe invalid color" logic copied the color style
into -webkit-text-fill-color for both endpoints, causing -webkit-text-fill-color
to animate while the transition ran, and to then to disappear when the transition
finished.

Test: transitions/color-transition-all.html

  • page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperMaybeInvalidColor::equals): (WebCore::PropertyWrapperMaybeInvalidColor::blend):
10:25 Changeset [48981] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-10-01 Victor Wang <victorw@chromium.org>

Reviewed by Oliver Hunt.

Allow dragging a node who has child nodes.

https://bugs.webkit.org/show_bug.cgi?id=28632

  • fast/events/drag-parent-node-expected.txt: Added.
  • fast/events/drag-parent-node.html: Added.
  • fast/events/resources/bookmark.gif: Added.

2009-10-01 Victor Wang <victorw@chromium.org>

Reviewed by Oliver Hunt.

Allow dragging a node who has child nodes.

https://bugs.webkit.org/show_bug.cgi?id=28632

Test: fast/events/drag-parent-node.html

  • page/EventHandler.cpp: (WebCore::EventHandler::shouldDragAutoNode):
10:17 Changeset [48980] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] media player: better mute support
https://bugs.webkit.org/show_bug.cgi?id=29960

Handle volume and mute state with the two corresponding properties
of playbin2.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::setVolume):
10:09 Changeset [48979] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] video sink pad template colorspace is wrong
https://bugs.webkit.org/show_bug.cgi?id=29953

Set sink pad template colorspace depending on byte order.

  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func):
10:01 Changeset [48978] by eric@webkit.org
  • 37 edits
    4 deletes in trunk/WebCore

2009-10-01 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Refactored V8 event listeners:
(This change should fix http://crbug.com/21079 and
https://bugs.webkit.org/show_bug.cgi?id=29093.)

o All listeners use weak handles to JS objects to avoid creating

cycles and leaking memory.

o "Object" variants of listeners removed.
o All event accessor callbacks are generated.
o Custom event accessors removed.
o All wrappers have hidden dependencies on their listeners to

prevent listeners from being collected.

o All variats of getEventListener function grouped in V8DOMWrapper.
o Pointers to C++ EventListener wrappers are stored in JS objects

instead of event listener lists.

https://bugs.webkit.org/show_bug.cgi?id=29825

  • WebCore.gypi: Removed "Object" listeners.
  • bindings/scripts/CodeGeneratorV8.pm: Now handles event accessors.
  • bindings/v8/DOMObjectsInclude.h:

V8AbstractEventListener manages weak JS handle:

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::weakEventListenerCallback): (WebCore::V8AbstractEventListener::V8AbstractEventListener): (WebCore::V8AbstractEventListener::~V8AbstractEventListener): (WebCore::V8AbstractEventListener::handleEvent): (WebCore::V8AbstractEventListener::disposeListenerObject): (WebCore::V8AbstractEventListener::setListenerObject):
  • bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::cast): (WebCore::V8AbstractEventListener::isLazy): (WebCore::V8AbstractEventListener::getListenerObject): (WebCore::V8AbstractEventListener::getExistingListenerObject): (WebCore::V8AbstractEventListener::hasExistingListenerObject): (WebCore::V8AbstractEventListener::disconnectFrame): (WebCore::V8AbstractEventListener::disconnected): (WebCore::V8AbstractEventListener::prepareListenerObject): (WebCore::V8AbstractEventListener::lineNumber): (WebCore::V8AbstractEventListener::virtualisAttribute):

Grouped getEventListener functions:

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::getEventListener):
  • bindings/v8/V8DOMWrapper.h:

Removed most event listener objects bookkeeping:

  • bindings/v8/V8EventListenerList.cpp:
  • bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findWrapper): (WebCore::V8EventListenerList::clearWrapper): (WebCore::V8EventListenerList::doFindWrapper): (WebCore::V8EventListenerList::getHiddenProperty): (WebCore::V8EventListenerList::findOrCreateWrapper):

Added hidden properties for storing EventListener wrappers:

  • bindings/v8/V8HiddenPropertyName.cpp: (WebCore::V8HiddenPropertyName::listener): (WebCore::V8HiddenPropertyName::attributeListener):
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): (WebCore::V8LazyEventListener::callListenerFunction): (WebCore::V8LazyEventListener::prepareListenerObject):
  • bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::isLazy):
  • bindings/v8/V8ObjectEventListener.cpp: Removed.
  • bindings/v8/V8ObjectEventListener.h: Removed.
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::disconnectFrame): (WebCore::V8Proxy::disconnectEventListeners):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::reportError): (WebCore::V8WorkerContextEventListener::getReceiverObject):
  • bindings/v8/V8WorkerContextEventListener.h:
  • bindings/v8/V8WorkerContextObjectEventListener.cpp: Removed.
  • bindings/v8/V8WorkerContextObjectEventListener.h: Removed.
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener): (WebCore::V8EventListener::getListenerFunction): (WebCore::V8EventListener::callListenerFunction):
  • bindings/v8/custom/V8CustomEventListener.h:
  • bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::getEventListener): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SVGElementInstanceCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WorkerCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
09:59 Changeset [48977] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

Make Software Input Panel requests work with QGraphicsWebView
_and_ QWebView by sharing the event code in handleSoftwareInputPanel().

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-01
Reviewed by Tor Arne Vestbø.

  • Api/qwebpage.cpp:

(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::handleSoftwareInputPanel):

  • Api/qwebpage_p.h:
09:22 Changeset [48976] by zoltan@webkit.org
  • 8 edits in trunk

2009-10-01 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Allow custom memory allocation control for the whole JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=27029

Since in JavaScriptCore almost every class which has been instantiated by operator new is
inherited from FastAllocBase (bug #20422), we disable customizing global operator new for the Qt-port
when USE_SYSTEM_MALLOC=0.

Add #include <unistd.h> to FastMalloc.cpp because it's used by TCMalloc_PageHeap::scavengerThread().
(It's needed for the functionality of TCmalloc.)

Add TCSystemAlloc.cpp to JavaScriptCore.pri if USE_SYSTEM_MALLOC is disabled.

  • JavaScriptCore.pri:
  • wtf/FastMalloc.cpp: (WTF::sleep):
  • wtf/FastMalloc.h:

2009-10-01 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Don't use TCmalloc in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=27029

Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.

  • DumpRenderTree/qt/DumpRenderTree.pro:

2009-10-01 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Enable TCmalloc for the Linux, Mac and Windows Qt-port
https://bugs.webkit.org/show_bug.cgi?id=27029

Remove USE_SYSTEM_MALLOC for Linux, Mac and Windows Qt-port from WebKit.pri,
so these Qt-ports will use TCmalloc as other ports.

  • WebKit.pri:
08:35 Changeset [48975] by aroben@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Land expected failure results for two tests on Windows

These failures are covered by <http://webkit.org/b/29963> and
<http://webkit.org/b/29964>.

Rubber-stamped in advance by Eric Carlson.

  • platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt:

Added.

  • platform/win/fast/forms/basic-inputs-expected.txt: Added.
08:28 Changeset [48974] by vestbo@webkit.org
  • 7 edits
    2 copies
    2 moves
    1 add
    1 delete in trunk

Rename QWebGraphicsItem to QGraphicsWebView

Patch by Alexis Menard <alexis.menard@nokia.com> on 2009-10-01
Reviewed by Tor Arne Vestbø.

08:26 Changeset [48973] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-01 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Read-only transactions do not change file sizes and therefore
should not trigger quota updates.

https://bugs.webkit.org/show_bug.cgi?id=29945

  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): (WebCore::SQLTransaction::runStatements):
07:31 Changeset [48972] by tonikitoo@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-09-28 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29248
[Qt] [API] Make it possible to have 'invisible' loads

Make QWebFrame's setHtml and setContent methods to not change
session and global history at all.

  • Api/qwebframe.cpp: (QWebFrame::setHtml): (QWebFrame::setContent):
  • tests/qwebframe/qwebframe.pro:
  • tests/qwebframe/tst_qwebframe.cpp:
06:18 Changeset [48971] by timothy@apple.com
  • 5 edits in trunk/WebCore

Fix list box scrolling by correctly overriding the scroll()
function on RenderBox.

<rdar://problem/7255440> REGRESSION (r48683): Mousewheel scrolling
of listboxes is broken (29756)

Reviewed by Dan Bernstein.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scroll):

  • rendering/RenderListBox.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::scroll):

  • rendering/RenderTextControlSingleLine.h:
06:17 Changeset [48970] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Make a copy of listeners array before dispatching an event in
WebInspector.Object.prototype.dispatchEventToListeners. Otherwise if current
listener removes itself from the array next listener will be skipped.

https://bugs.webkit.org/show_bug.cgi?id=29920

  • inspector/front-end/Object.js: (WebInspector.Object.prototype.dispatchEventToListeners): make a copy of listeners array before dispatching an event
06:02 Changeset [48969] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-01 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Skip fast/table/008.html until a solution for the crash on the buildbot is found.

  • platform/qt/Skipped:
05:43 Changeset [48968] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

Fixed software input panel support on web input elements.

Patch by Kristian Amlie <kristian.amlie@nokia.com> on 2009-10-01
Reviewed by Simon Hausmann.

Send the RequestSoftwareInputPanel event if the element supports focus
and the element is clicked.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseReleaseEvent):

  • Api/qwebpage_p.h:
05:43 Changeset [48967] by hausmann@webkit.org
  • 4 edits in trunk/WebKit/qt

Implementation for QWebPage::inputMethodQuery and QWebPagePrivate::inputMethodEvent

Patch by Joe Ligman <joseph.ligman@nokia.com> on 2009-10-01
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29681

Some additional changes from Kristian Amlie <kristian.amlie@nokia.com>:

  • Fixed surrounding text to exclude preedit string
  • Avoid emission of microFocusChanged during setComposition()
  • Api/qwebpage.cpp:

(QWebPagePrivate::inputMethodEvent):
(QWebPage::inputMethodQuery):

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::respondToChangedSelection):

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::inputMethods):

04:28 QtWebKitProfilingSetup edited by zecke@selfish.org
(diff)
03:43 Changeset [48966] by eric@webkit.org
  • 5 edits in trunk

2009-10-01 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement eventSender.scheduleAsynchronousClick().

https://bugs.webkit.org/show_bug.cgi?id=29931

  • platform/qt/Skipped:

2009-10-01 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement eventSender.scheduleAsynchronousClick().

https://bugs.webkit.org/show_bug.cgi?id=29931

  • DumpRenderTree/qt/jsobjects.cpp: (EventSender::scheduleAsynchronousClick):
  • DumpRenderTree/qt/jsobjects.h:
03:35 Changeset [48965] by eric@webkit.org
  • 5 edits in trunk

2009-10-01 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
fast/events/open-window-from-another-frame.html from the Skipped list.

https://bugs.webkit.org/show_bug.cgi?id=29930

  • platform/qt/Skipped:

2009-10-01 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
fast/events/open-window-from-another-frame.html from the Skipped list.

https://bugs.webkit.org/show_bug.cgi?id=29930

  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::setPopupBlockingEnabled):
  • DumpRenderTree/qt/jsobjects.h:
02:02 Changeset [48964] by eric@webkit.org
  • 8 edits
    1 add in trunk

2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733

Add new key event test ensuring that IME keypresses are handled.

  • GNUmakefile.am:

2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733

Re-enable skipped tests which were previously failing.

  • platform/gtk/Skipped:

2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733

Ensure that keyboard events filtered by the GtkIMContext still create
the proper DOM events.

No tests added. Instead previously skipped tests have been enabled.

  • platform/gtk/KeyEventGtk.cpp: (WebCore::keyIdentifierForGdkKeyCode): (WebCore::singleCharacterString):

2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733

Ensure that keyboard events filtered by the GtkIMContext still create
the proper DOM events.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::clearPendingIMData): (WebKit::imContextCommitted): (WebKit::imContextPreeditChanged): (WebKit::EditorClient::shouldBeginEditing): (WebKit::EditorClient::shouldEndEditing): (WebKit::interpretEditorCommandKeyEvent): (WebKit::handleCaretBrowsingKeyboardEvent): (WebKit::EditorClient::handleKeyboardEvent): (WebKit::EditorClient::handleInputMethodKeydown):
  • tests/testkeyevents.c: Added. (test_info_new): (test_info_destroy): (key_event_fixture_setup): (key_event_fixture_teardown): (key_press_event_cb): (key_release_event_cb): (load_status_cb): (map_event_cb): (test_keypress): (main):
01:19 Changeset [48963] by eric@webkit.org
  • 7 edits
    2 adds in trunk

2009-10-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] data: uri support in media player
https://bugs.webkit.org/show_bug.cgi?id=29842

Check presence of gstreamer-pbutils-0.10.

  • configure.ac:

2009-10-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] data: uri support in media player
https://bugs.webkit.org/show_bug.cgi?id=29842

Re-enable media/audio-data-url.html.

  • platform/gtk/Skipped:

2009-10-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] data: uri support in media player
https://bugs.webkit.org/show_bug.cgi?id=29842

New GStreamer element to handle data: uris. For now only base64
encoded data is supported. Decoded data is handed over to
giostreamsrc.

  • GNUmakefile.am:
  • platform/graphics/gtk/DataSourceGStreamer.cpp: Added. (_do_init): (webkit_data_src_base_init): (webkit_data_src_class_init): (webkit_data_src_reset): (webkit_data_src_init): (webkit_data_src_finalize): (webkit_data_src_uri_get_type): (webkit_data_src_uri_get_protocols): (webkit_data_src_uri_get_uri): (webkit_data_src_uri_set_uri): (webkit_data_src_uri_handler_init):
  • platform/graphics/gtk/DataSourceGStreamer.h: Added.
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::do_gst_init): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::mimeTypeCache):
Note: See TracTimeline for information about the timeline view.