Timeline


and

10/08/09:

23:05 Changeset [49382] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2009-10-08 Alex Milowski <alex@milowski.com>

Reviewed by Darin Adler.

Added a basic description of the layout and rendering project and added links to the blog entries on rendering.

  • projects/layout/index.html:
22:30 Changeset [49381] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-4-branch

Merge r48521.

22:23 Changeset [49380] by mrowe@apple.com
  • 2 edits
    1 add in branches/safari-4-branch/WebCore

Merge r48960.

22:21 Changeset [49379] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebCore

Merge r46604.

22:16 Changeset [49378] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48443.

22:14 Changeset [49377] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebKit/mac

Merge r48394.

22:14 Changeset [49376] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r48361.

22:13 Changeset [49375] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebKit/mac

Merge r48360.

22:13 Changeset [49374] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48359.

22:13 Changeset [49373] by mrowe@apple.com
  • 3 edits
    1 add in branches/safari-4-branch/WebCore

Merge r48358.

22:08 Changeset [49372] by abarth@webkit.org
  • 31 edits
    1 add in trunk

2009-10-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200

Update API call.

  • Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):

2009-10-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200

Update API call.

  • webkit/webkitwebview.cpp: (webkit_web_view_execute_script):

2009-10-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200

Update API call.

  • WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):

2009-10-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200

Update API call.

  • WebFrame.cpp: (wxWebFrame::RunScript):

2009-10-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200

Update API call.

  • WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
  • WebView/WebView.mm: (-[WebView aeDescByEvaluatingJavaScriptFromString:]):

2009-10-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200

These methods have virtually no interaction with FrameLoader. They
really seem like they ought to belong to ScriptController.

  • WebCore.base.exp:
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::executeScript): (WebCore::ScriptController::executeIfJavaScriptURL): (WebCore::ScriptController::evaluate):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::executeScript): (WebCore::ScriptController::executeIfJavaScriptURL):
  • bindings/v8/ScriptController.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::notifyFinished):
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::endElementNs):
  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseEndElement):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::replaceDocument):
  • loader/FrameLoader.h:
  • plugins/PluginView.cpp: (WebCore::PluginView::performRequest):
20:45 Changeset [49371] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Tiger build fix: added a few more variable initializations.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncSearch):

20:42 Changeset [49370] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Qt build fix: added missing #include.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • jsc.cpp:
20:39 Changeset [49369] by beidson@apple.com
  • 18 edits
    2 adds in trunk

Ask the History Delegate to populate the visited links hash.
<rdar://problem/7285293> and https://webkit.org/b/29904

Reviewed by Dan Bernstein.

WebKit/mac:

  • History/WebHistory.mm:

(+[WebHistory _removeAllVisitedLinks]):

  • History/WebHistoryPrivate.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::populateVisitedLinks):

  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebDelegateImplementationCaching.mm:

(CallHistoryDelegate):

  • WebView/WebHistoryDelegate.h:
  • WebView/WebView.mm:

(-[WebView _cacheHistoryDelegateImplementations]):
(-[WebView addVisitedLinks:]):

  • WebView/WebViewPrivate.h:

WebKitTools:

Add the ability for LayoutTestController to clear all visited links.
Also lets the History Delegate dump visited links, but only if this test specifically cleared them.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(removeAllVisitedLinksCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::removeAllVisitedLinks):

  • DumpRenderTree/mac/HistoryDelegate.mm:

(-[HistoryDelegate populateVisitedLinksForWebView:]):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::removeAllVisitedLinks):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::removeAllVisitedLinks):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::removeAllVisitedLinks):

LayoutTests:

  • http/tests/globalhistory/history-delegate-basic-visited-links-expected.txt: Added.
  • http/tests/globalhistory/history-delegate-basic-visited-links.html: Added.
20:37 Changeset [49368] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Tiger build fix: initialize variable whose initialization the compiler
can't otherwise figure out.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::match):

20:35 Changeset [49367] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix: updated exports.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

20:29 Changeset [49366] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Tiger build fix: fixed file name case.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

20:22 Changeset [49365] by ggaren@apple.com
  • 22 edits in trunk/JavaScriptCore

At long last, I pronounce the death of AllInOneFile.cpp.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
Reviewed by Maciej Stachowiak.

SunSpider reports a 1.01x speedup.

to compilation stages.

  • parser/Grammar.y:
  • parser/Lexer.cpp:
  • parser/Lexer.h:

(JSC::jscyylex):

  • runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):

  • runtime/Collector.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::operator new):

  • runtime/JSCell.h:

(JSC::JSCell::operator new):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::operator new):

  • runtime/JSNumberCell.h:

(JSC::JSNumberCell::operator new):

  • runtime/JSString.cpp:
  • runtime/JSString.h:

(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString):

  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpConstructor.h:

(JSC::RegExpConstructorPrivate::RegExpConstructorPrivate):
(JSC::RegExpConstructorPrivate::lastOvector):
(JSC::RegExpConstructorPrivate::tempOvector):
(JSC::RegExpConstructorPrivate::changeLastOvector):
(JSC::RegExpConstructor::performMatch):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncMatch):

  • yarr/RegexJIT.cpp:
  • yarr/RegexJIT.h:

(JSC::Yarr::executeRegex): Inlined a few things that Shark said
were hot, on the presumption that AllInOneFile.cpp used to inline them
automatically.

20:13 Changeset [49364] by mrowe@apple.com
  • 8 edits in branches/safari-4-branch/JavaScriptCore

Merge r48582.

20:07 Changeset [49363] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch/JavaScriptCore

Merge r47605.

20:07 Changeset [49362] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r47604.

20:07 Changeset [49361] by mrowe@apple.com
  • 6 edits in branches/safari-4-branch/JavaScriptCore

Merge r47601.

20:07 Changeset [49360] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r47474.

19:54 Changeset [49359] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r48830.

19:54 Changeset [49358] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r46706.

19:54 Changeset [49357] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r46705.

19:54 Changeset [49356] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r46704.

19:54 Changeset [49355] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r46703.

19:54 Changeset [49354] by mrowe@apple.com
  • 5 edits in branches/safari-4-branch/JavaScriptCore

Merge r46702.

19:54 Changeset [49353] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r46701.

19:54 Changeset [49352] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r46610.

19:54 Changeset [49351] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r46601.

19:54 Changeset [49350] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r46599.

19:54 Changeset [49349] by mrowe@apple.com
  • 63 edits
    3 adds in branches/safari-4-branch

Merge r46598.

19:53 Changeset [49348] by mrowe@apple.com
  • 5 edits in branches/safari-4-branch/JavaScriptCore

Merge r46438.

19:53 Changeset [49347] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r46347.

19:53 Changeset [49346] by mrowe@apple.com
  • 13 edits in branches/safari-4-branch/JavaScriptCore

Merge r46247.

19:53 Changeset [49345] by mrowe@apple.com
  • 5 edits
    3 adds in branches/safari-4-branch

Merge r46210.

19:53 Changeset [49344] by mrowe@apple.com
  • 6 edits in branches/safari-4-branch/JavaScriptCore

Merge r46209.

19:53 Changeset [49343] by mrowe@apple.com
  • 9 edits
    2 adds in branches/safari-4-branch/JavaScriptCore

Merge r46202.

19:53 Changeset [49342] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r46187.

19:53 Changeset [49341] by mrowe@apple.com
  • 2 edits
    1 add in branches/safari-4-branch/JavaScriptCore

Merge r46057.

19:53 Changeset [49340] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r45933.

19:53 Changeset [49339] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r45918.

19:53 Changeset [49338] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r45904.

19:53 Changeset [49337] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r45903.

19:10 Changeset [49336] by dbates@webkit.org
  • 4 edits in trunk/WebKitTools

2009-10-08 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=30175


The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
the OLE drag-and-drop return value like the function it emulates. Currently,
UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
whether the drag-and-drop operation was successful or was cancelled.


This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
return value according to whether the drop operation was successful or not.

  • DumpRenderTree/win/EventSender.cpp: (doMouseUp): Added parameter oleDragAndDropReturnValue. (replaySavedEvents): Ditto.
  • DumpRenderTree/win/EventSender.h:
  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
16:49 Changeset [49335] by ggaren@apple.com
  • 10 edits in trunk/JavaScriptCore

Rolled out 49331 because it still doesn't build on Windows

16:43 Changeset [49334] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: added missing #include.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • interpreter/CallFrame.cpp:
16:35 Changeset [49333] by ggaren@apple.com
  • 3 edits
    1 copy in trunk

Windows build fix: added missing #include.

JavaScriptCore:

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • runtime/PropertyNameArray.h:

WebCore:

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • ForwardingHeaders/runtime/StructureChain.h: Copied from WebCore/ForwardingHeaders/runtime/PropertyNameArray.h.
16:29 Changeset [49332] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: added missing #include.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • runtime/NumberPrototype.cpp:
16:24 Changeset [49331] by ggaren@apple.com
  • 8 edits in trunk/JavaScriptCore

Migrated some code that didn't belong out of Structure.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
Reviewed by Sam Weinig.

SunSpider says maybe 1.03x faster.

  • runtime/JSCell.h: Nixed Structure::markAggregate, and made marking of

a Structure's prototype the direct responsility of the object using it.
(Giving Structure a mark function was misleading because it implied that
all live structures get marked during GC, when they don't.)

  • runtime/JSGlobalObject.cpp:

(JSC::markIfNeeded):
(JSC::JSGlobalObject::markChildren): Added code to mark prototypes stored
on the global object. Maybe this wasn't necessary, but now we don't have
to wonder.

  • runtime/JSObject.cpp:

(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::getEnumerableNamesFromClassInfoTable):

  • runtime/JSObject.h:

(JSC::JSObject::markChildrenDirect):

  • runtime/PropertyNameArray.h:
  • runtime/Structure.cpp:
  • runtime/Structure.h:

(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache): Moved property name gathering code
from Structure to JSObject because having a Structure iterate its JSObject
was a layering violation. A JSObject is implemented using a Structure; not
the other way around.

15:45 Changeset [49330] by agl@chromium.org
  • 13 edits in trunk/WebCore

Revert 49329: broke Windows Debug (Build)

15:31 Changeset [49329] by agl@chromium.org
  • 13 edits in trunk/WebCore

2009-10-08 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Currently, Skia clip paths are 1-bit. This patch makes our path
clipping anti-aliased for non-canvas drawing.

http://code.google.com/p/chromium/issues/detail?id=5927
https://bugs.webkit.org/show_bug.cgi?id=28820
http://www.imperialviolet.org/2009/09/02/anti-aliased-clipping.html

Already covered by layout tests. New baselines will be needed in the
Chromium tree.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::clip):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::canvasClip):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::canvasClip):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::canvasClip):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::canvasClip):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::clipPath):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::clipPathAntiAliased): (PlatformContextSkia::restore): (PlatformContextSkia::applyAntiAliasedClipPaths):
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::canvasClip):
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::canvasClip):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::canvasClip):
15:25 Changeset [49328] by ggaren@apple.com
  • 9 edits in trunk/JavaScriptCore

Rolled out r49322 and friends because they killed the build

15:14 Changeset [49327] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Fixes <https://bugs.webkit.org/show_bug.cgi?id=30237>.
DOM Content and Load lines aren't shown if a page is loaded when the inspector is up.

Reviewed by Timothy Hatcher.

Make sure to call update script object if we have an InspectorFrontend to
call it on when we get one of the new events.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::mainResourceFiredDOMContentEvent):
(WebCore::InspectorController::mainResourceFiredLoadEvent):

15:11 Changeset [49326] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Build fix: updated for removal of Structure::markAggregate().

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::markChildren):

15:08 Changeset [49325] by ggaren@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Removed some conflict markers from the ChangeLog

15:08 Changeset [49324] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: Added missing #include.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • runtime/JSGlobalData.h:
15:02 Changeset [49323] by ggaren@apple.com
  • 8 edits in trunk/JavaScriptCore

Take one branch instead of two to test for JSValue().

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-01
Reviewed by Sam Weinig.

1.1% SunSpider speedup.

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_create_arguments):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.

  • runtime/JSValue.cpp:

(JSC::JSValue::description): Added support for dumping the new empty value,
and deleted values, in debug builds.

  • runtime/JSValue.h:

(JSC::JSValue::JSValue()): Construct JSValue() with the empty value tag.

(JSC::JSValue::JSValue(JSCell*)): Convert null pointer to the empty value
tag, to avoid having two different c++ versions of null / empty.

(JSC::JSValue::operator bool): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.

14:42 Changeset [49322] by levin@chromium.org
  • 4 edits in trunk/WebCore

Make AtomicString create its StringImpl via create(), not the constructor,
so it gets allocated in a single heap block, saving memory and CPU cycles.
This eliminates two StringImpl constructors, making the remaining ones
unambiguous, so the "AdoptBuffer" parameter is no longer needed.
Added const attribute to UChar* in StringImpl constructor, eliminating the
need for several const_casts in calls to it.
StringImpl also unfriends AtomicString (OMG drama!!!)
https://bugs.webkit.org/show_bug.cgi?id=30141

Patch by Jens Alfke <snej@chromium.org> on 2009-10-08
Reviewed by Darin Adler.

  • platform/text/AtomicString.cpp:

(WebCore::CStringTranslator::translate): Call StringImpl::create().
(WebCore::UCharBufferTranslator::translate): Ditto.
(WebCore::HashAndCharactersTranslator::translate): Ditto.

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::StringImpl): Remove unnecessary AdoptBuffer param.
(WebCore::StringImpl::adopt): Ditto.
(WebCore::StringImpl::createUninitialized): Ditto.
(WebCore::StringImpl::create): Ditto.
(WebCore::StringImpl::crossThreadString): Ditto.

  • platform/text/StringImpl.h:

(WebCore::StringImpl::setHash): Used by AtomicString when creating StringImpls.

14:27 Changeset [49321] by eric@webkit.org
  • 22 edits in trunk/LayoutTests

2009-10-08 Aaron Boodman <aa@chromium.org>

Reviewed by Eric Seidel.

r49278 added support for reusing isolated worlds, and the
corresponding change to Chromium's LayoutTestController changed
to expect two arguments. The first argument is the world that
the script should run in.

This change fixes the tests by updating them all to pass 0
for the world id. The specific world id used for these tests
doesn't really matter because they don't test world interaction.

https://bugs.webkit.org/show_bug.cgi?id=30231

  • http/tests/security/isolatedWorld/all-window-properties.html:
  • http/tests/security/isolatedWorld/all-window-prototypes.html:
  • http/tests/security/isolatedWorld/body-properties.html:
  • http/tests/security/isolatedWorld/body-prototype.html:
  • http/tests/security/isolatedWorld/click-event.html:
  • http/tests/security/isolatedWorld/document-open.html:
  • http/tests/security/isolatedWorld/document-properties.html:
  • http/tests/security/isolatedWorld/document-prototype.html:
  • http/tests/security/isolatedWorld/global-variables.html:
  • http/tests/security/isolatedWorld/image-properties.html:
  • http/tests/security/isolatedWorld/image-prototype.html:
  • http/tests/security/isolatedWorld/location-properties.html:
  • http/tests/security/isolatedWorld/location-prototype.html:
  • http/tests/security/isolatedWorld/number-prototype.html:
  • http/tests/security/isolatedWorld/object-prototype.html:
  • http/tests/security/isolatedWorld/storage-properties.html:
  • http/tests/security/isolatedWorld/storage-prototype.html:
  • http/tests/security/isolatedWorld/string-prototype.html:
  • http/tests/security/isolatedWorld/window-properties.html:
  • http/tests/security/isolatedWorld/window-setTimeout-function.html:
  • http/tests/security/isolatedWorld/window-setTimeout-string.html:
14:24 Changeset [49320] by andersca@apple.com
  • 10 edits in trunk

WebCore: Remove the shouldLoadMediaElementURL frame loader client function.

Reviewed by Sam Weinig.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::willLoadMediaElementURL):

WebKit/mac: Remove the shouldLoadMediaElementURL implementation.

Reviewed by Sam Weinig.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebPolicyDelegatePrivate.h:

WebKit/win: Remove the shouldLoadMediaElementURL implementation.

Reviewed by Sam Weinig.

  • Interfaces/IWebPolicyDelegatePrivate.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::shouldUsePluginDocument):

  • WebCoreSupport/WebFrameLoaderClient.h:
14:19 Changeset [49319] by atwilson@chromium.org
  • 2 edits in trunk/WebCore

SVGURIReference Build problem for V8. An additional stale reference to SVGURIReference bindings
which wasn't exposed until a clean build.
https://bugs.webkit.org/show_bug.cgi?id=30217

Patch by John Gregg <johnnyg@google.com> on 2009-10-08
Reviewed by Dimitri Glazkov.

No new tests, just a build fix.

  • bindings/v8/V8Index.cpp:
14:12 Changeset [49318] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Added support for a parameter setting the button that was
pressed in the mouseDown function.
https://bugs.webkit.org/show_bug.cgi?id=30220

  • WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
14:12 Changeset [49317] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

2009-10-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Sort XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
14:05 Changeset [49316] by eric@webkit.org
  • 2 edits in trunk

2009-10-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Added a line to the bottom of the expected result to match
the output of the test.
https://bugs.webkit.org/show_bug.cgi?id=30220

  • LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste- expected.txt:
13:57 Changeset [49315] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2009-10-08 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

unselectable resources in resource panel
https://bugs.webkit.org/show_bug.cgi?id=30079

manual test added

Also changed the way DnD for resources in the Resources panel is
handled.

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.onattach): (WebInspector.ResourceSidebarTreeElement.prototype.ondragstart):
  • manual-tests/inspector/duplicate-resource-urls.html: Added.
13:27 Changeset [49314] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

Fixes <http://webkit.org/b/30233>
Local Storage and Cookies show Blank Titles on Local Files.

Reviewed by Timothy Hatcher.

If a local storage or cookies sidebar item has no domain, set the
title to "Local Files", because that is what it represents.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/StoragePanel.js:

(WebInspector.DOMStorageSidebarTreeElement.prototype.get mainTitle):
(WebInspector.CookieSidebarTreeElement.prototype.get mainTitle):
(WebInspector.CookieSidebarTreeElement.prototype.set mainTitle):

13:03 Changeset [49313] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix failing media layout tests. Don't make beforeload block loads of objects that aren't in the
document, since video/audio (and images eventually too) can load when not in the document yet.

Reviewed by Oliver Hunt.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::dispatchBeforeLoadEvent):

12:59 Changeset [49312] by zimmermann@webkit.org
  • 19 edits in trunk

2009-10-08 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel.

Move SVGFitToViewBox ANIMATED_* macros in classes that inherit from it
https://bugs.webkit.org/show_bug.cgi?id=30230

This patch also devirtualizes viewBoxToViewTransform(), is it's superflous.
viewBoxToViewTransform() is now a simple static heper function in SVGFitToViewBox.
As a result, the SVGSVGElement::viewBoxToViewTransform() function now resuses the same logic.

As side-effect this patch fixes svg/custom/linking-a-03-b-transform.svg, the return
statement in SVGSVGElement::viewBoxToViewTransform() was clearly wrong.

12:03 Changeset [49311] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Correct a typo that fixes the resizing of columns in Cookie view when you
resize the Inspector window.

Reviewed by Jon Honeycutt.

  • inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView.prototype.resize):

10:43 Changeset [49310] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Fixes <https://bugs.webkit.org/show_bug.cgi?id=29811>
Text in Inspector's Styles gear menu is invisible.

Reviewed by Adam Roben.

Adds a style rule for the option text and hr's in the gear menu,
to prevent them from being transparent.

  • inspector/front-end/inspector.css:
10:34 Changeset [49309] by levin@chromium.org
  • 3 edits in trunk/WebCore

Fix build problem with SVGURIReference in V8.
https://bugs.webkit.org/show_bug.cgi?id=30217

Patch by John Gregg <johnnyg@google.com> on 2009-10-08
Reviewed by David Levin.

No new tests, just a build fix.

  • WebCore.gypi:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
10:26 Changeset [49308] by hyatt@apple.com
  • 2 edits
    2 adds in trunk

Make beforeload work on <video>/<audio> elements.

Reviewed by Eric Carlson.

Added fast/dom/beforeload/video-before-load.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseMappedAttribute):
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::selectNextSourceChild):

10:14 Changeset [49307] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-08 Xan Lopez <xlopez@igalia.com>

Skip another failing test with reference to its bug.

  • platform/gtk/Skipped:
10:09 Changeset [49306] by zimmermann@webkit.org
  • 61 edits in trunk/WebCore

2009-10-08 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel.

Move SVGExternalResourcesRequired ANIMATED_* macros in classes that inherit from it
https://bugs.webkit.org/show_bug.cgi?id=30218

The long term goal is to kill the need for the virtual contextElement() function in SVG code.
No change in functionality, thus no new tests.

09:11 Changeset [49305] by aroben@apple.com
  • 7 edits in trunk

Make IWebInspectorPrivate be accessed in a more standard way

Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
accessed in a more standard way

Reviewed by John Sullivan and Tim Hatcher.

WebKit/win:

IWebViewPrivate::inspectorPrivate has been removed. Callers should
instead use IWebViewPrivate::inspector and then use QueryInterface to
get the IWebInspectorPrivate interface. This matches how our other COM
classes work.

  • Interfaces/IWebViewPrivate.idl: Removed inspectorPrivate.

(WebInspector::QueryInterface): Support querying to
IWebInspectorPrivate.

  • WebView.cpp:
  • WebView.h:

Removed inspectorPrivate.

WebKitTools:

Use QueryInterface to get IWebInspectorPrivate

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::evaluateInWebInspector): Get the IWebInspector
by calling IWebViewPrivate::inspector, then use QueryInterface to get
to the IWebInspectorPrivate interface.

08:38 Changeset [49304] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Move the new IWebViewPrivate::inspectorPrivate function after all functions that existed when Safari 4.0.3 was released

Fixes <http://webkit.org/b/30085> REGRESSION (r49091): run-safari
crashes in Safari.dll

Reviewed by John Sullivan.

  • Interfaces/IWebViewPrivate.idl: Moved inspectorPrivate to the end of

the interface, so it won't modify the vtable that Safari 4.0.3 sees.

08:28 Changeset [49303] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-08 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

SVG feComposite: operator over mixes up inputs
https://bugs.webkit.org/show_bug.cgi?id=30205

SVG feComposite operator over mixed up the inputs.
The pixel-test svg/filters/feComposite.svg can already test this.
No new test result is needed as long as filters are disabled.

  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
08:15 Changeset [49302] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-08 Xan Lopez <xlopez@igalia.com>

Skip flakey transition test.

  • platform/gtk/Skipped:
07:53 Changeset [49301] by zimmermann@webkit.org
  • 33 edits in trunk/WebCore

Reviewed by George Staikos.

Move SVGURIReference ANIMATED_* macros in classes that inherit from it
https://bugs.webkit.org/show_bug.cgi?id=30184

The long term goal is to kill the need for the virtual contextElement() function in SVG code.
No change in functionality, thus no new tests.

07:44 Changeset [49300] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Re-add the QApplication::syncX() line for plugin windows removed
by r49169. Also changed the location of the sync just after the
creation instead of just before sending it to the plugin.
https://bugs.webkit.org/show_bug.cgi?id=25053

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::platformStart):
07:09 Changeset [49299] by aroben@apple.com
  • 9 edits in trunk

Expose origin whitelisting in the WebKit API on Windows

Fixes <http://webkit.org/b/30185>.

Reviewed by Eric Seidel.

WebKit/win:

  • Interfaces/IWebViewPrivate.idl: Added whiteListAccessFromOrigin and

resetOriginAccessWhiteLists, to match the Mac SPI.

  • WebView.cpp:

(WebView::whiteListAccessFromOrigin):
(WebView::resetOriginAccessWhiteLists):

  • WebView.h:

Added. These just call through to SecurityOrigin.

WebKitTools:

Implement DRT support for origin whitelisting

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting): Reset any origin
whitelist, to match Mac DRT.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::whiteListAccessFromOrigin): Call through to
IWebViewPrivate::whiteListAccessFromOrigin.

LayoutTests:

Start running origin whitelist tests on Windows

  • platform/win/Skipped:
07:09 Changeset [49298] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2009-10-08 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Inspector: NodeLists Don't Display Well in the Console
https://bugs.webkit.org/show_bug.cgi?id=28061

  • inspector/front-end/InjectedScript.js: (Object.type):
06:29 Changeset [49297] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-08 Xan Lopez <xlopez@igalia.com>

Fix typo in skipped test.

  • platform/gtk/Skipped:
06:25 Changeset [49296] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-08 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Simon Hausmann.

[Qt] Windowless plugins: Remove unnecessary XSync for opaque mode.

The reason for the XSync was that the plugin would not know about the
Drawable. It turns out that the real reason behind this is that even
though XCreatePixmap returns a handle, this id is unknown to the server
until we flush the connection.

So, move the XSync to right after we create the Pixmap.

https://bugs.webkit.org/show_bug.cgi?id=30207

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint):
06:14 Changeset [49295] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-08 Xan Lopez <xlopez@igalia.com>

Skip editing/selection/home-end.html, since it seems to be
somewhat broken. See https://bugs.webkit.org/show_bug.cgi?id=30208
for details.

  • platform/gtk/Skipped:
06:09 Changeset [49294] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Part of testOptionalJSObjects autotest was marked as "expect to fail".

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2009-10-08
Reviewed by Simon Hausmann.

Two places in tst_QWebPage::testOptionalJSObjects were marked as
expected to fail. The problem concern checking if a feature is enabled
or disabled. According to discussion on webkit dev mailing list
a disabled feature should be invisible from java script level, but
there are exceptions from the rule. So we decided to disable the test
for now.

https://bugs.webkit.org/show_bug.cgi?id=29867

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::testOptionalJSObjects):

02:18 Changeset [49293] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix for JIT'ed op_call instructions (evals, constructs, etc.)
when !ENABLE(JIT_OPTIMIZE_CALL) && USE(JSVALUE32_64)

Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2009-10-08
Reviewed by Gavin Barraclough.

https://bugs.webkit.org/show_bug.cgi?id=30201

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

10/07/09:

23:57 Changeset [49292] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2009-10-07 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30188


Fixes an issue where performing a non DHTML drag-and-drop operation
does not work as expected. For instance, dragging some selected text
to an external application, such as TextEdit.


This issue was a regression that arose from patching bug #30107.


This change is covered by the manual test:
drag-out-of-background-window.html

23:29 Changeset [49291] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-10-07 Xan Lopez <xlopez@igalia.com>

Fix more breakage in the GTK+ build.

  • GNUmakefile.am:
23:17 Changeset [49290] by abarth@webkit.org
  • 8 edits
    4 adds
    2 deletes in trunk/WebCore

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move PolicyChecker to it's own file
https://bugs.webkit.org/show_bug.cgi?id=30193

This is just moving code around and re-naming things.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/PolicyCallback.cpp: Added. (WebCore::PolicyCallback::PolicyCallback): (WebCore::PolicyCallback::~PolicyCallback): (WebCore::PolicyCallback::clear): (WebCore::PolicyCallback::set): (WebCore::PolicyCallback::call): (WebCore::PolicyCallback::clearRequest): (WebCore::PolicyCallback::cancel):
  • loader/PolicyCallback.h: Added. (WebCore::PolicyCallback::request):
  • loader/PolicyCheck.cpp: Removed.
  • loader/PolicyCheck.h: Removed.
23:13 Changeset [49289] by eric@webkit.org
  • 7 edits in trunk/WebCore

2009-10-07 Joel Stanley <joel@jms.id.au>

Reviewed by Mark Rowe.

Include <limits> for std::numeric_limits. Required by gcc-4.4
https://bugs.webkit.org/show_bug.cgi?id=30197

  • html/canvas/CanvasByteArray.h:
  • html/canvas/CanvasIntArray.h:
  • html/canvas/CanvasShortArray.h:
  • html/canvas/CanvasUnsignedByteArray.h:
  • html/canvas/CanvasUnsignedIntArray.h:
  • html/canvas/CanvasUnsignedShortArray.h:
23:09 Changeset [49288] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-07 Xan Lopez <xlopez@igalia.com>

Fix the GTK+ build.

  • webkit/webkitwebpolicydecision.cpp: (webkit_web_policy_decision_use): (webkit_web_policy_decision_ignore): (webkit_web_policy_decision_download):
22:30 Changeset [49287] by weinig@apple.com
  • 2 edits in trunk/WebKitSite

Fix for https://bugs.webkit.org/show_bug.cgi?id=30196
Change style guidelines for indentation in header files

Reviewed by Dan Bernstein.

  • coding/coding-style.html: Don't indent in a namespace in a header file.
21:55 QtWebKitPerformanceUtilities edited by zecke@selfish.org
Update pahs. (diff)
21:44 Changeset [49286] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-07 Simon Fraser <simon.fraser@apple.com>

Re-land 49269-49271 since reverting them did not fix the tests.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
21:09 Changeset [49285] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-07 Simon Fraser <simon.fraser@apple.com>

Revert 49269-49271 to see if it fixes test failures on SnowLeopard that do not
reproduce locally.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
20:17 Changeset [49284] by abarth@webkit.org
  • 18 edits in trunk

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::callPolicyFunction):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSubmitForm): (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

  • WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): (WebFrame::receivedPolicyDecision): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchWillSubmitForm): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForMIMEType): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNavigationAction):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::receivedPolicyDecison):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::dispatchWillSubmitForm): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForMIMEType): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNavigationAction):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

This patch separates PolicyChecker from FrameLoader. Loader policy is
in change of managing the FrameLoaderClient callbacks. Ideally, it
shouldn't know anything about FrameLoader, but I couldn't quite remove
all knowledge (although we might be able to do more later). In a
future patch, I'll move PolicyChecker into a separate file.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::PolicyChecker::handleUnimplementablePolicy): (WebCore::PolicyChecker::cannotShowMIMEType): (WebCore::PolicyChecker::PolicyChecker): (WebCore::PolicyChecker::checkNavigationPolicy): (WebCore::PolicyChecker::checkContentPolicy): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::stopAllLoaders): (WebCore::PolicyChecker::cancelCheck): (WebCore::PolicyChecker::stopCheck): (WebCore::PolicyChecker::continueAfterContentPolicy): (WebCore::PolicyChecker::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::loadPostRequest): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::PolicyChecker::checkNewWindowPolicy): (WebCore::PolicyChecker::continueAfterNewWindowPolicy): (WebCore::PolicyChecker::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
  • loader/FrameLoader.h: (WebCore::PolicyChecker::loadType): (WebCore::PolicyChecker::setLoadType): (WebCore::PolicyChecker::delegateIsDecidingNavigationPolicy): (WebCore::PolicyChecker::delegateIsHandlingUnimplementablePolicy): (WebCore::FrameLoader::policy):
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
19:28 Changeset [49283] by aa@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests/http/tests/security/isolatedWorld

Not reviewed. Fix layout test missing results.

19:04 Changeset [49282] by sfalken@apple.com
  • 2 edits in trunk/WebKitSite

Add new Windows build prerequisite: Visual Studio 2005 Service Pack 1 ATL Security Update

Reviewed by Mark Rowe.

  • building/tools.html:
18:52 Changeset [49281] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix: removed no longer exported symbol.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07

18:46 Changeset [49280] by ggaren@apple.com
  • 24 edits
    2 copies in trunk

JavaScriptCore: Fixed <rdar://problem/5751979> Database code takes JSLock on secondary
thread, permanently slowing down JavaScript

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07
Reviewed by Oliver Hunt.

Removed the optional lock from Heap::protect, Heap::unprotect, and friends,
since WebCore no longer uses it.

(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::markProtectedObjects):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::protectedObjectCount):
(JSC::Heap::protectedObjectTypeCounts):

  • runtime/Collector.h:

WebCore: Fixed <rdar://problem/5751979> Database code takes JSLock on secondary
thread, permanently slowing down JavaScript

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07
Reviewed by Oliver Hunt.

Changed callback objects to use a standard helper object. The helper
object ASSERTs that it is deleted on the main thread, so no lock is
required when unprotecting its members. It also centralizes some previously
duplicated code.

Callback objects that might be deleted on a secondary thread use
callOnMainThread to delete their helper objects on the main thread.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCallbackData.cpp: Copied from bindings/js/JSCustomSQLTransactionCallback.cpp.

(WebCore::JSCallbackData::deleteData):
(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCallbackData.h: Copied from bindings/js/JSCustomSQLTransactionCallback.cpp.

(WebCore::JSCallbackData::JSCallbackData):
(WebCore::JSCallbackData::~JSCallbackData):
(WebCore::JSCallbackData::callback):

  • bindings/js/JSCustomPositionCallback.cpp:

(WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
(WebCore::JSCustomPositionCallback::handleEvent):

  • bindings/js/JSCustomPositionCallback.h:
  • bindings/js/JSCustomPositionErrorCallback.cpp:

(WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
(WebCore::JSCustomPositionErrorCallback::handleEvent):

  • bindings/js/JSCustomPositionErrorCallback.h:
  • bindings/js/JSCustomSQLStatementCallback.cpp:

(WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::~JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::handleEvent):

  • bindings/js/JSCustomSQLStatementCallback.h:
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::~JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):

  • bindings/js/JSCustomSQLStatementErrorCallback.h:
  • bindings/js/JSCustomSQLTransactionCallback.cpp:

(WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::handleEvent):

  • bindings/js/JSCustomSQLTransactionCallback.h:
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp:

(WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::~JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):

  • bindings/js/JSCustomSQLTransactionErrorCallback.h:
  • bindings/js/JSCustomVoidCallback.cpp:

(WebCore::JSCustomVoidCallback::JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::~JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::handleEvent):

  • bindings/js/JSCustomVoidCallback.h:
  • storage/Database.cpp:

(WebCore::Database::Database):

17:41 Changeset [49279] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2009-10-07 Jens Alfke <snej@chromium.org>

Reviewed by Dave Levin.

Fix StringImpl::m_buffer
https://bugs.webkit.org/show_bug.cgi?id=30189

Fix my previous StringImpl patch to avoid using an indefinite-length array member,
since MSVC doesn't like it. Instead, go back to offsetting by sizeof(StringImpl).

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): (WebCore::StringImpl::createUninitialized):
  • platform/text/StringImpl.h: (WebCore::StringImpl::bufferIsInternal):
17:07 Changeset [49278] by aa@chromium.org
  • 12 edits
    3 adds in trunk

Update isolated worlds under v8 to support world reuse.
https://bugs.webkit.org/show_bug.cgi?id=30145

Patch by Aaron Boodman <aa@chromium.org> on 2009-10-07
Reviewed by Adam Barth.

WebCore:

  • bindings/v8/ScriptController.cpp:

Replace evaluateInNewIsolatedWorld() withe evaluateInIsolatedWorld(id).
(WebCore::ScriptController::evaluateInIsolatedWorld):

  • bindings/v8/ScriptController.h: Ditto.
  • bindings/v8/V8Proxy.cpp: Ditto.

(WebCore::V8Proxy::~V8Proxy): Dittio.
(WebCore::V8Proxy::evaluateInIsolatedWorld): Ditto.

  • bindings/v8/V8Proxy.h: Ditto.
  • bindings/v8/V8IsolatedWorld.cpp:

Add support for controlling lifetime of a world, rather than relying on GC.
(WebCore::V8IsolatedWorld::contextWeakReferenceCallback): Ditto.
(WebCore::V8IsolatedWorld::V8IsolatedWorld): Ditto.
(WebCore::V8IsolatedWorld::destroy): Ditto.

  • bindings/v8/V8IsolatedWorld.h: Ditto.

LayoutTests:

  • http/tests/security/isolatedWorld/iframe.html: Added.
  • http/tests/security/isolatedWorld/world-reuse-expected.txt: Added.
  • http/tests/security/isolatedWorld/world-reuse.html: Added.
17:05 Changeset [49277] by beidson@apple.com
  • 8 edits
    2 adds in trunk

Send title changes to the global history delegate.
<rdar://problem/7285293> and https://webkit.org/b/29904

Reviewed by Darin Adler.

WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::setTitle):

  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebHistoryDelegate.h:
  • WebView/WebView.mm:

(-[WebView _cacheHistoryDelegateImplementations]):

WebKitTools:

  • DumpRenderTree/mac/HistoryDelegate.mm:

(-[HistoryDelegate webView:updateHistoryTitle:forURL:]):

LayoutTests:

  • http/tests/globalhistory/history-delegate-basic-title-expected.txt: Added.
  • http/tests/globalhistory/history-delegate-basic-title.html: Added.
16:55 Changeset [49276] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/platform/text/StringImpl.cpp

Well that was wrong, undo-ing previous build fix.

16:50 Changeset [49275] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/platform/text/StringImpl.cpp

Hopefully the rest of the Windows build fix.

16:33 Changeset [49274] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

Build fix for http://trac.webkit.org/changeset/49272 on Windows

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-07

  • platform/text/StringImpl.h:
16:20 Changeset [49273] by darin@apple.com
  • 4 edits in trunk/WebKit/mac

Make the setMetadataURL function foolproof by having it remove user info
https://bugs.webkit.org/show_bug.cgi?id=30178
rdar://problem/6544670

Patch by Darin Adler <darin@apple.com> on 2009-10-07
Reviewed by John Sullivan.

  • Misc/WebNSFileManagerExtras.m:

(-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
Call _web_URLByRemovingUserInfo on the passed in URL string after converting
it to a URL, and then convert it back to a string.

  • Misc/WebNSURLExtras.h: Added _web_URLByRemovingUserInfo.
  • Misc/WebNSURLExtras.mm: Removed unused WebKitURLComponents struct.

(-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Renamed to be
clearer on what this does.
(-[NSURL _webkit_URLByRemovingFragment]): Changed to call new name.
(-[NSURL _webkit_URLByRemovingResourceSpecifier]): Ditto.
(-[NSURL _web_URLByRemovingComponentAndSubsequentCharacter:]): Added.
(-[NSURL _web_URLByRemovingUserInfo]): Added.

15:41 Changeset [49272] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-07 Jens Alfke <snej@chromium.org>

Reviewed by Darin Adler.

Optimization of StringImpl:

  • Remove unnecessary m_bufferIsInternal member (saves 4 bytes). Instead, check whether m_data points to just past the end of the object's members.
  • copy() and createWithTerminatingNullCharacter() create the string in a single malloc block instead of 2 (saves ~20 bytes and considerable CPU cycles, increases locality).
  • Move m_length next to m_hash to save 4 bytes of padding in 64-bit builds.

https://bugs.webkit.org/show_bug.cgi?id=29500

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Re-ordered members. (WebCore::StringImpl::~StringImpl): Change to is-buffer-internal check. (WebCore::StringImpl::createUninitialized): Use new m_buffer member instead of sizeof()

to ensure chars are copied to correct location.

(WebCore::StringImpl::createWithTerminatingNullCharacter): Make sure copy is created

in a single malloc block.

(WebCore::StringImpl::threadsafeCopy): Make sure copy is created in a single malloc block.
(WebCore::StringImpl::crossThreadString): Make sure copy is created in a single malloc block.
(WebCore::StringImpl::sharedBuffer): Change to is-buffer-internal check.

  • platform/text/StringImpl.h: (WebCore::StringImpl::startsWith): Just fixed a confusing param name. (WebCore::StringImpl::bufferIsInternal): Changed member var into accessor method. (WebCore::StringImpl::m_data): Repositioned for optimal member packing in 64-bit. (WebCore::StringImpl::m_buffer): Added to provide an explicit location for where internal buffer goes.
15:41 Changeset [49271] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-07 Simon Fraser <simon.fraser@apple.com>

Make Dan Bernstein happy.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
15:38 Changeset [49270] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Avoid Obj-C message dispatch when possible by storing accessed objects
in local variables.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
15:29 Changeset [49269] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Animation stalls for a few seconds partway through
https://bugs.webkit.org/show_bug.cgi?id=30182

Make sure that we only call -disableScreenUpdatesUntilFlush when a window
update is actually going to happen, otherwise screen updates are disabled
for too long.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
15:26 Changeset [49268] by dbates@webkit.org
  • 3 edits
    1 add in trunk

2009-10-07 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30102
And
<rdar://problem/5015957>


Fixes an issue (in the Windows build) where the cursor does not change to the
not-allowed cursor when the drag-and-drop operation is not allowed.


The allowed effects in WebDragClient::startDrag are hard-coded to be
DROPEFFECT_COPY | DROPEFFECT_LINK | DROPEFFECT_MOVE. Instead, the list of
allowed drop effects should be determined by the allowed operations of the
drag source.


We cannot test this using DRT because DRT looks at the programmatic drop
cursor and until bug #24731 is fixed this value is hard-coded to DragOperationCopy.
That is, there is a discrepancy in the Windows build between the Windows API-based
drop effect and the WebKit drop effect. Because DRT cannot read the screen buffer
to determine the cursor, a manual test is needed.

  • WebCoreSupport/WebDragClient.cpp: (draggingSourceOperationMaskToDragCursors): Added method. (WebDragClient::startDrag):

2009-10-07 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30102
And
<rdar://problem/5015957>


Manual test to confirm that the not-allowed cursor is shown for an
invalid drag-and-drop operation.


We cannot test this using DRT because of a discrepancy between the Windows
API-based drop effect and the WebKit drop effect. See bug #24731 for more
details.

  • manual-tests/drag-cursor-notallowed.html: Added.
15:22 Changeset [49267] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-07 Adam Barth <abarth@webkit.org>

Unreviewed. Remove some folks from committers.py who were listed on
the WebKit Team wiki page but who weren't actually listed as commit+.
At some point, we should coorelate this list with the committers
mailing list.

  • Scripts/modules/committers.py:
15:16 Changeset [49266] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the build.

15:10 Changeset [49265] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-07 Adam Barth <abarth@webkit.org>

Unreviewed. Import a bunch of committers from the WebKit Team page on
the wiki into committers.py.

  • Scripts/modules/committers.py:
14:56 Changeset [49264] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-10-07 Evan Martin <evan@chromium.org>

Reviewed by Adam Roben.

Windows-specific baselines for some new tests.

  • platform/win/fast/css/large-number-round-trip-expected.txt: Added.
  • platform/win/fast/css/opacity-float-expected.txt: Copied from LayoutTests/fast/css/opacity-float-expected.txt.
14:55 Changeset [49263] by bweinstein@apple.com
  • 18 edits in trunk/WebCore

2009-10-07 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.

Fixes <http://webkit.org/b/30104>.
Inspector should show cookies of sub-resources on the page.


This function implements showing cookies for all sub-resources of a page.
When the page is loaded, it populates the Storage Panel with a list of all
domains that were loaded as part of the full page load (iframes, ads, etc).
When the user selects one of the domains, the inspector calls back into the
controller, and the controller combines all of the cookies from that domain
into a list, and sends that list is sent back to the controller to render.


A domain now needs to be passed into CookieItemsView, and CookieSidebarTreeElement.


As a result of a previous patch, we now have detailed cookie information for
both Windows on CFNetwork and Mac. Additionally, this patch provides deleteCookie
support on Windows.

  • bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::set):
  • bindings/js/ScriptObject.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getCookies): (WebCore::InspectorBackend::deleteCookie):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::buildArrayForCookies): (WebCore::InspectorController::buildObjectForCookie): (WebCore::InspectorController::deleteCookie):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addCookieDomainForDocument):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
  • inspector/front-end/DOMAgent.js: (WebInspector.Cookies.getCookiesAsync):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addCookieDomain): (WebInspector.StoragePanel.prototype.showCookies): (WebInspector.CookieSidebarTreeElement): (WebInspector.CookieSidebarTreeElement.prototype.onselect):
  • inspector/front-end/inspector.js: (WebInspector.addCookieDomain):
  • platform/Cookie.h: (WebCore::CookieHash::hash): (WebCore::CookieHash::equal): (WTF::):
  • platform/network/win/CookieJarCFNetWin.cpp: (WebCore::deleteCookie):
14:50 Changeset [49262] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

2009-10-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add ScriptObject::set(const char*, unsigned).

https://bugs.webkit.org/show_bug.cgi?id=30104

  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::set):
  • bindings/v8/ScriptObject.h:
14:49 LayoutAndRendering edited by alex@milowski.com
(diff)
14:47 Changeset [49261] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-07 Adam Barth <abarth@webkit.org>

Unreviewed. Added Aaron Boodman to committers.py.

  • Scripts/modules/committers.py:
14:46 LayoutAndRendering edited by alex@milowski.com
(diff)
14:46 LayoutAndRendering created by alex@milowski.com
14:41 WikiStart edited by alex@milowski.com
added link to new layout and rendering page (diff)
13:51 Changeset [49260] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed build fix for Windows (Cairo).

Provide implementation of new BitmapImage::create that was
added in @r49060.

  • platform/graphics/win/ImageCairoWin.cpp:
13:25 Changeset [49259] by eric@webkit.org
  • 9 edits
    2 adds in trunk/WebCore

2009-10-07 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Refactor RenderThemeChromiumMac and RenderThemeChromiumSkia to render media controls using GraphicsContext.

Design was based on existing RenderMediaControls.cpp used by RenderThemeSafari/Win.

https://bugs.webkit.org/show_bug.cgi?id=29987

Covered by existing layout tests as no new functionality was introduced.

  • WebCore.gypi: Added RenderMediaControlsChromium.cpp/h.
  • css/mediaControlsChromium.css: Tweaked media slider position and border style.
  • rendering/MediaControlElements.cpp: (WebCore::toParentMediaElement): Taken from RenderMediaControls. (WebCore::MediaControlElement::rendererIsNeeded): Don't call shouldRenderMediaControlPart() if element has no appearance. (WebCore::MediaControlInputElement::rendererIsNeeded): Ditto.
  • rendering/RenderMediaControls.cpp: Moved parentMediaElement() to MediaControlElements.
  • rendering/RenderMediaControlsChromium.cpp: Added. (WebCore::platformResource): Helper to load and cache media control image resources. (WebCore::mediaSliderThumbImage): Implementation refactored from RenderThemeChromiumMac/Skia. (WebCore::mediaVolumeSliderThumbImage): Ditto. (WebCore::paintMediaButton): Ditto. (WebCore::paintMediaMuteButton): Ditto. (WebCore::paintMediaPlayButton): Ditto. (WebCore::paintMediaSlider): Ditto. (WebCore::paintMediaSliderThumb): Ditto. (WebCore::paintMediaVolumeSlider): Ditto. (WebCore::paintMediaVolumeSliderThumb): Ditto. (WebCore::paintMediaTimelineContainer): Ditto. (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart): Ditto. (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Same (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
  • rendering/RenderMediaControlsChromium.h: Added.
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): Implementation delegated to RenderMediaControlsChromium. (WebCore::RenderThemeChromiumMac::shouldRenderMediaControlPart): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground): Ditto.
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintMediaControlsBackground): Implementation delegated to RenderMediaControlsChromium. (WebCore::RenderThemeChromiumSkia::paintMediaSliderTrack): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderTrack): Ditto. (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaSliderThumb): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderThumb): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): Ditto. (WebCore::RenderThemeChromiumSkia::shouldRenderMediaControlPart): Ditto.
13:03 Changeset [49258] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

Make plugins work with beforeload.

Reviewed by Adam Roben.

Added fast/dom/beforeload/flash-before-load.html

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):

  • rendering/RenderPartObject.cpp:

(WebCore::RenderPartObject::updateWidget):

12:10 Changeset [49257] by cmarrin@apple.com
  • 6 edits in trunk/WebKitSite/blog-files/webgl/resources

resized thumbnails

11:32 Changeset [49256] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

https://bugs.webkit.org/show_bug.cgi?id=30176
<rdar://problem/7281553> Extra information in UA causes problems with gmail

Reviewed by Darin Adler.

  • WebKit.vcproj/WebKit.rc: Restore PRODUCTVERSION to build number only. Remove extra space.
11:20 Changeset [49255] by cmarrin@apple.com
  • 6 adds in trunk/WebKitSite/blog-files/webgl/resources

added thumbnail images for demos

11:10 Changeset [49254] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-10-07 Evan Martin <evan@chromium.org>

Reviewed by Simon Fraser.

Add a currently-failing test exhibiting the problem in
https://bugs.webkit.org/show_bug.cgi?id=20674:

When converting very large or small numbers back to strings, exponential
notation is used, so a value like 90010000px is returned from
getComputedStyle() as 9.001e+07px.

9.001e+07px does not parse, so such a value cannot be round-tripped.

This is a particular problem with tranformation matrices, which can often
contain very large or small numbers.

(Test written by Simon Fraser; I've just made it a committable patch.)

  • fast/css/large-number-round-trip-expected.txt: Added.
  • fast/css/large-number-round-trip.html: Added.
10:47 Changeset [49253] by eric@webkit.org
  • 8 edits
    3 adds in trunk

2009-10-07 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

Layout test for verifying that LC_NUMERIC setting doesn't affect
the way CSS properties are stringified.
https://bugs.webkit.org/show_bug.cgi?id=18994

  • fast/css/opacity-float-expected.txt: Added.
  • fast/css/opacity-float.html: Added.

2009-10-07 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

Add API to LayoutTestController for re/setting the system locale.
https://bugs.webkit.org/show_bug.cgi?id=18994

  • DumpRenderTree/LayoutTestController.cpp: (setLocaleCallback): (LayoutTestController::staticFunctions): (LayoutTestController::setLocale):
  • DumpRenderTree/LayoutTestController.h:
10:25 Changeset [49252] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-07 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Protect JS listener object from GC while clearing a property on it.
See http://crbug.com/23780.
https://bugs.webkit.org/show_bug.cgi?id=30137

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
10:09 Changeset [49251] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2009-10-07 Zoltan Horvath <zoltan@webkit.org>

Rubber-stamped by Eric Seidel.

Allow custom memory allocation control for WebCore's CachedResourceClient class
https://bugs.webkit.org/show_bug.cgi?id=30165

Inherits CachedResourceClient class from FastAllocBase because (its
child class) CSSFontFaceSource has been instantiated by 'new' in WebCore/css/CSSFontFaceSource.h:46.

  • loader/CachedResourceClient.h:
10:04 Changeset [49250] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2009-10-07 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for WebCore's IdentifierRep
https://bugs.webkit.org/show_bug.cgi?id=30159

Inherits IdentifierRep class from FastAllocBase because it has been
instantiated by 'new' in WebCore/bridge/IdentifierRep.cpp:61.

  • bridge/IdentifierRep.h:
10:00 Changeset [49249] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-10-07 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's IdentifierArena
https://bugs.webkit.org/show_bug.cgi?id=30158

Inherits IdentifierArena class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/parser/ParserArena.cpp:36.

  • parser/ParserArena.h:
09:59 Changeset [49248] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-10-07 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Fetch pointers to C++ DOM window immediately from holder
object (do not search prototype chain for proper JS wrapper).
https://bugs.webkit.org/show_bug.cgi?id=29031

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createNewContext): (WebCore::V8Proxy::installDOMWindow):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_ACCESS_CHECK):
09:49 Changeset [49247] by aroben@apple.com
  • 4 edits in trunk/JavaScriptCore

Export DateInstance::info in a way that works on Windows

Fixes <http://webkit.org/b/30171>
fast/dom/Window/window-postmessage-clone.html fails on Windows

Reviewed by Anders Carlsson.

Removed the export of DateInstance::info from here.

  • runtime/DateInstance.h: Use JS_EXPORTDATA to export

DateInstance::info, which is the required way of exporting data on
Windows.

09:23 Changeset [49246] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2009-10-06 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Jan Alonzo.

[Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
https://bugs.webkit.org/show_bug.cgi?id=29689

Build fix by adding -lfontconfig for DumpRenderTree.

  • GNUmakefile.am:
08:22 Changeset [49245] by tonikitoo@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-10-07 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Get rid of useless loadFailed signal in QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=30166

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_doLoadFinished):
  • Api/qgraphicswebview.h:
  • QGVLauncher/main.cpp: (MainWindow::init): (MainWindow::loadFinished):
08:11 Changeset [49244] by aroben@apple.com
  • 2 edits in trunk/WebCore

Fix typo in PluginView::load that was causing cross-origin loads to be allowed

This typo was introduced in the build fix in r49213.

Fixes <http://webkit.org/b/30168> REGRESSION (r49213):
http/tests/plugins/local-geturl-from-remote.html is failing on Windows

Reviewed by Sam Weinig.

  • plugins/PluginView.cpp:

(WebCore::PluginView::load): Removed a comma operator that was making
a condition always evaluate to true.

07:53 Changeset [49243] by zoltan@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-07 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.

  • Scripts/run-webkit-tests:
07:06 Changeset [49242] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Do not create valid QColor's for invalid WebCore::Color's.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-07
Reviewed by Simon Hausmann.

  • platform/graphics/qt/ColorQt.cpp:

(WebCore::Color::operator QColor):

05:44 Changeset [49241] by xan@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-07 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

"delete" in EventSender is the backspace key, not the delete one.

  • DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
04:46 Changeset [49240] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-10-07 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Simon Hausmann.

Add a simple rotation effect to QGVLauncher

https://bugs.webkit.org/show_bug.cgi?id=30162

  • QGVLauncher/main.cpp: (MainView::animatedFlip): (MainWindow::animatedFlip): (MainWindow::buildUI):
03:58 Changeset [49239] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-07 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Simon Hausmann.

[Qt] Symbian SBSv2 .data segment adress fix
https://bugs.webkit.org/show_bug.cgi?id=30157

RO-section in qtwebkit.dll exceeds allocated space in SBSv2. Move RW-section
base address to start from 0x800000 instead of the toolchain default 0x400000

  • WebCore.pro:
03:45 Changeset [49238] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

When enabling or disabling the JIT through .qmake.cache, make sure
to also toggle ENABLE_YARR_JIT.

Patch by Jørgen Lind <jorgen.lind@nokia.com> on 2009-10-07
Reviewed by Simon Hausmann.

03:44 Changeset [49237] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Doc: Document HTML and status as properties.

Patch by Volker Hilsheimer <volker.hilsheimer@nokia.com> on 2009-10-07
Reviewed by Simon Hausmann.

  • Api/qgraphicswebview.cpp:
03:42 Changeset [49236] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

Fix qdoc warning about disabled renderHints property
on Symbian.

Patch by Martin Smith <msmith@trolltech.com> on 2009-10-07
Reviewed by Simon Hausmann.

  • Api/qwebview.cpp:
  • Api/qwebview.h:
03:36 Changeset [49235] by xan@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-07 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

getChildrenWithRange expects as last parameter the end index, not
the length of the range. Correct this and clarify the variable
names to reflect how the code works.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::getChildrenWithRange): (AccessibilityUIElement::getChildAtIndex):
02:32 Changeset [49234] by pfeldman@chromium.org
  • 18 edits in trunk/WebCore

2009-10-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Migrate database inspection to the injected script-based schema.

https://bugs.webkit.org/show_bug.cgi?id=29788

  • bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::databaseForId):
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::databaseForId): (WebCore::InspectorBackend::selectDatabase): (WebCore::InspectorBackend::getDatabaseTableNames): (WebCore::InspectorBackend::reportDidDispatchOnInjectedScript):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::selectDatabase): (WebCore::InspectorController::databaseForId): (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::selectDOMStorage): (WebCore::InspectorController::getDOMStorageResourceForId):
  • inspector/InspectorController.h:
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind):
  • inspector/InspectorDatabaseResource.h: (WebCore::InspectorDatabaseResource::database): (WebCore::InspectorDatabaseResource::id):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::selectDatabase): (WebCore::InspectorFrontend::didGetDatabaseTableNames): (WebCore::InspectorFrontend::addDOMStorage):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/Database.js: (WebInspector.Database): (WebInspector.Database.prototype.get id): (WebInspector.Database.prototype.set name): (WebInspector.Database.prototype.set version): (WebInspector.Database.prototype.set domain): (WebInspector.Database.prototype.getTableNames): (WebInspector.Database.prototype.executeSql):
  • inspector/front-end/InjectedScript.js: (InjectedScript.dispatch): (InjectedScript.executeSql): (InjectedScript.executeSql.errorCallback): (InjectedScript.executeSql.queryTransaction):
  • inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName): (InjectedScriptAccess._installHandler):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.selectDatabase): (WebInspector.StoragePanel.prototype.dataGridForResult):
  • inspector/front-end/inspector.js: (WebInspector.addDatabase):
01:23 Changeset [49233] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-07 Martin Robinson <martin.james.robinson@gmail.com>

[GTK] Segfault while testing fast/events/keydown-keypress-preventDefault.html
https://bugs.webkit.org/show_bug.cgi?id=30121

Clear previous preedit or pending composition before storing new ones.
This can happen when a WebView receives a native keydown event without
a matching keyup event or when preventDefault() is called on DOM keydown
events.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::setPendingComposition): (WebKit::setPendingPreedit): (WebKit::clearPendingIMData): (WebKit::imContextCommitted): (WebKit::imContextPreeditChanged):
00:42 Changeset [49232] by pfeldman@chromium.org
  • 4 edits in trunk/WebKit

2009-10-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: default to an attached inspector window on Windows (as on Mac).

https://bugs.webkit.org/show_bug.cgi?id=30134

WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]):

WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::showWindowWithoutNotifications):
00:40 Changeset [49231] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-07 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins: Disable content propagation for QGraphicsView items

We cannot support content propagation for items in QGraphicsView because
the contents of the backing store might be transformed. So turn it off
if we are not painting on QWidget.

Note that this check will not work for a QWebView in a
QGraphicsProxyWidget, but I guess it's fine. Alternative is to do an
even uglier cast: static_cast painter's paintDevice() to QWidget and
check if it is the viewport() of QGraphicsView.

https://bugs.webkit.org/show_bug.cgi?id=30149

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint):
00:38 Changeset [49230] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-07 Xan Lopez <xlopez@igalia.com>

Skip two new tests for which we are missing results.

  • platform/gtk/Skipped:
00:17 Changeset [49229] by oliver@apple.com
  • 3 edits in trunk/LayoutTests

Tidy up postMessage testcase

Reviewed by Gavin Barraclough.

00:15 Changeset [49228] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Fix the Qt build by adding the missing files to the build.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-07

  • WebCore.pro:
00:10 Changeset [49227] by kov@webkit.org
  • 3 edits in trunk/WebCore

2009-10-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Fix incorrect convertion of double into int while assigning it to
a float.

  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):
00:10 Changeset [49226] by kov@webkit.org
  • 3 edits in trunk/WebCore

2009-10-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Fix rounding error issues in height calculation in 64 bits.

Already covered by existing tests.

  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):

10/06/09:

23:20 Changeset [49225] by hamaji@chromium.org
  • 4 edits
    8 adds in trunk

2009-10-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Dual lines in css2.1 layout tests do not match:
https://bugs.webkit.org/show_bug.cgi?id=23262

Now we can put a counter node as the next sibling of a reset node.
Re-layout the counter content when the count is updated.

Tests: fast/css/counters/t1204-increment-00-c-o.html

fast/css/counters/t1204-increment-01-c-o.html

  • rendering/CounterNode.cpp: (WebCore::CounterNode::recount):
  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter):

2009-10-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Dual lines in css2.1 layout tests do not match:
https://bugs.webkit.org/show_bug.cgi?id=23262

Now we can put a counter node as the next sibling of a reset node.
Re-layout the counter content when the count is updated.

  • fast/css/counters/t1204-increment-00-c-o.html: Added.
  • fast/css/counters/t1204-increment-01-c-o.html: Added.
  • platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.checksum: Added.
  • platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.png: Added.
  • platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
  • platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.checksum: Added.
  • platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.png: Added.
  • platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.
22:44 Changeset [49224] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-10-06 Priit Laes <plaes@plaes.org>

Reviewed by Gavin Barraclough.

Linking fails with "relocation R_X86_64_PC32 against symbol
`cti_vm_throw'"
https://bugs.webkit.org/show_bug.cgi?id=28422

  • jit/JITStubs.cpp: Mark cti_vm_throw symbol as PLT-indirect symbol, so it doesn't end up in text segment causing relocation errors on amd64 architecture. Introduced new define SYMBOL_STRING_RELOCATION for such symbols.
22:15 Changeset [49223] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-10-06 Xan Lopez <xlopez@igalia.com>

Try to fix the GTK+ build.

  • GNUmakefile.am:
20:56 Changeset [49222] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-06 Adam Barth <abarth@webkit.org>

Reviewed by Adam Barth.

Removed unused member variable from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30146

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader):
  • loader/FrameLoader.h:
20:45 Changeset [49221] by levin@chromium.org
  • 2 edits in trunk/WebCore

A few small/trivial tweaks to the last build fix.

Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by NOBODY (build fix).

  • bindings/scripts/CodeGeneratorV8.pm:
20:16 Changeset [49220] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows linking fix

20:07 Changeset [49219] by levin@chromium.org
  • 8 edits
    1 copy in trunk/WebCore

[Chromium] Need to adjust MessagePort, etc. code for the post clone work done.
https://bugs.webkit.org/show_bug.cgi?id=30147

Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by Dimitri Glazkov.

No change in functionality so no new tests.

  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/SerializedScriptValue.h: Added. A very simple implementation of SerializedScriptValue that only works for strings.
  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

19:48 Changeset [49218] by weinig@apple.com
  • 4 edits in trunk/WebCore

Fix for <rdar://problem/7271202>
Dispatch resource load delegate functions for the media element.
Since we don't get the required callbacks from the media engine,
just fake the parameters to the delegate functions as best as possible.

Reviewed by Brady Eidson.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::isSafeToLoadURL):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::willLoadMediaElementURL):

  • loader/FrameLoader.h:
19:39 Changeset [49217] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix

19:29 Changeset [49216] by oliver@apple.com
  • 3 edits in trunk/WebCore

Build fix

19:21 Changeset [49215] by oliver@apple.com
  • 3 edits
    1 add in trunk/WebCore

Build and formatting fix.

19:06 Changeset [49214] by oliver@apple.com
  • 41 edits
    4 adds in trunk

It should be possible to post (clone) built-in JS objects to Workers
https://bugs.webkit.org/show_bug.cgi?id=22878

Reviewed by Gavin Barraclough.

Implement object cloning semantics for postMessage. Currently only
a partial implementation of the spec -- cloning of File, FileList,
ImageData, and RegExp were left out as they would have significantly
increased patch size.

Cloning requires multiple tree walks so we use a templated tree
walk function, allowing us to share a single implementation for
serialization, deserialization, and eventual destruction of the
serialized object tree.

Test: fast/dom/Window/window-postmessage-clone.html

18:28 Changeset [49213] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-10-06 Adam Barth <abarth@webkit.org>

Unreviewed build fix for Windows.

  • plugins/PluginView.cpp: (WebCore::PluginView::load):
18:14 Changeset [49212] by eric@webkit.org
  • 18 edits in trunk

2009-10-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move FrameLoader::canLoad to SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=30111

  • WebCore.base.exp:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL):
  • loader/Cache.cpp: (WebCore::Cache::requestResource):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::loadFrameRequest): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::createJavaAppletWidget):
  • loader/FrameLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canLoad): (WebCore::SecurityOrigin::shouldHideReferrer):
  • page/SecurityOrigin.h:

2009-10-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move FrameLoader::canLoad to SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=30111

  • Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::loadRequest):
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
  • Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _isForbiddenFileLoad]):
  • WebView/WebFrame.mm: (-[WebFrame _allowsFollowingLink:]):

2009-10-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move FrameLoader::canLoad to SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=30111

  • WebFrame.cpp: (WebFrame::allowsFollowingLink):
18:05 Changeset [49211] by eric@webkit.org
  • 13 edits in trunk

2009-10-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move setLocalLoadPolicy and friends to SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=30110

These have more to do with security policies than with loading frames.

  • WebCore.base.exp:
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • loader/Cache.cpp: (WebCore::Cache::requestResource):
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::setLocalLoadPolicy): (WebCore::SecurityOrigin::restrictAccessToLocal): (WebCore::SecurityOrigin::allowSubstituteDataAccessToLocal):
  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::):

2009-10-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move setLocalLoadPolicy and friends to SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=30110

Call the new API.

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

2009-10-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move setLocalLoadPolicy and friends to SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=30110

Call the new API.

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
15:48 Changeset [49210] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

2009-10-06 Brian Weinstein <bweinstein@apple.com>

Reviewed by Brady Eidson.

Preparation for <http://webkit.org/b/30104>.
Inspector should show cookies of sub-resources on the page.


Implement getRawCookies for CFNetwork for Windows, so we can see more
than just a key/value pair for Cookies when we are on Windows.

  • platform/network/win/CookieJarCFNetWin.cpp: (WebCore::getRawCookies):
15:26 Changeset [49209] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2009-10-06 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

Diagram needs to be linked from the home page
https://bugs.webkit.org/show_bug.cgi?id=30142

http://webkit.org/coding/major-objects.html was never linked from the home
page.

  • nav.inc:
15:26 Changeset [49208] by hyatt@apple.com
  • 13 edits
    5 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=30132, make beforeload work with <link> elements and
XML processing instructions.

Reviewed by Adam Roben.

Fix up ProcessingInstruction's setData call so that it actually updates a stylesheet when the
data gets changed.

Move dispatchBeforeLoadedEvent to ContainerNode so all Elements (and ProcessingInstruction) can
access it.

Added fast/dom/beforeload/link-before-load.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::dispatchBeforeLoadEvent):

  • dom/ContainerNode.h:
  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::setData):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElementData::requestScript):

  • dom/ScriptElement.h:
  • dom/XMLTokenizerLibxml2.cpp:

(WebCore::XMLTokenizer::endElementNs):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::process):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::forAttributeValue):

  • html/HTMLScriptElement.h:
  • svg/SVGScriptElement.cpp:
  • svg/SVGScriptElement.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=30132, make beforeload work with CSS stylesheets loaded from
<link> elements and XML processing instructions.

Reviewed by Adam Roben.

  • fast/dom/beforeload/link-before-load-expected.txt: Added.
  • fast/dom/beforeload/link-before-load.html: Added.
  • fast/dom/beforeload/pi-before-load-expected.txt: Added.
  • fast/dom/beforeload/pi-before-load.xhtml: Added.
14:08 Changeset [49207] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH

Reviewed by Simon Fraser.

  • Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the

the fact we have already changed the working directory to the top of the open source tree.

13:47 Changeset [49206] by simon.fraser@apple.com
  • 8 edits in trunk

2009-10-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

accessibility/media-element.html crashes (and has incorrect result)
https://bugs.webkit.org/show_bug.cgi?id=30108

Fix up the accessibilty label for the newly added fullscreen button,
and update the test result accordingly.

13:10 Changeset [49205] by jparent@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
rather than my committer email.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-06

  • Scripts/modules/committers.py:
12:56 Changeset [49204] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-06 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Fixes <https://bugs.webkit.org/show_bug.cgi?id=30028>
Multiple calls to SetFrontendProxyObject can leave an InspectorTimelineAgent with an invalid
InspectorFrontend.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): Adds a check for an existing timeline agent.
12:14 Changeset [49203] by dbates@webkit.org
  • 4 edits
    2 adds in trunk

2009-10-06 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30107


Fixes an issue where the Mac build does return the correct drop effect
with respect to the HTML 5 specification when effectAllowed == "none".


Currently, when effectAllowed == "none" and dropEffect == "copy" or
dropEffect == "move" the resulting drop effect is "copy" and "move",
respectively. However, the HTML 5 specification states that regardless
of the specified dropEffect, when effectAllowed == "none" the resulting
drop effect should be "none".

  • WebView/WebHTMLView.mm: (-[WebHTMLView draggingSourceOperationMaskForLocal:]):

2009-10-06 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30107


Tests that drag-and-drop returns dropEffect = "none" when
effectAllowed == "none", regardless of the user-specified
drop effect.

  • fast/events/drag-and-drop-none-expected.txt: Added.
  • fast/events/drag-and-drop-none.html: Added.
  • platform/win/Skipped: This test does not work under Windows. We need the fix for bug #24731.
12:13 Changeset [49202] by antti@apple.com
  • 2 edits in trunk/WebCore

Move textRects to the right category in DOM.mm. Include DOMPrivate.h to ensure that the interfaces match.

Reviewed by Dave Kilzer.

  • bindings/objc/DOM.mm:

(-[DOMNode textRects]):

12:02 Changeset [49201] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-06 Benjamin C Meyer <bmeyer@rim.com>

Reviewed by Ariya Hidayat.

Match the behavior of other WebKit browser and have the first url of the drag data be the url passed in declareAndWriteDragImage and set the text of the drag data to be the title argument.

Manual test: Drag the readability js link from http://lab.arc90.com/experiments/readability/

  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage):
11:55 Changeset [49200] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-10-06 Benjamin C Meyer <bmeyer@rim.com>

Reviewed by Ariya Hidayat.

When the drag data contains an image set it on the QDrag so it will be visible to the user.

  • WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::startDrag):
11:47 Changeset [49199] by eric@webkit.org
  • 8 edits
    15 adds in trunk

2009-10-06 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Implement min/max attributes, ValidityState.rangeUnderflow and
ValidityState.rangeOverflow for <input type=number> and <input type=range>
https://bugs.webkit.org/show_bug.cgi?id=29069

  • fast/forms/ValidityState-rangeOverflow-number-expected.txt: Added.
  • fast/forms/ValidityState-rangeOverflow-number.html: Added.
  • fast/forms/ValidityState-rangeOverflow-range-expected.txt: Added.
  • fast/forms/ValidityState-rangeOverflow-range.html: Added.
  • fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Added.
  • fast/forms/ValidityState-rangeUnderflow-number.html: Added.
  • fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Added.
  • fast/forms/ValidityState-rangeUnderflow-range.html: Added.
  • fast/forms/input-minmax-expected.txt: Added.
  • fast/forms/input-minmax.html: Added.
  • fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Added.
  • fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Added.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Added.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Added.
  • fast/forms/script-tests/input-minmax.js: Added.

2009-10-06 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Implement min/max attributes, ValidityState.rangeUnderflow and
ValidityState.rangeOverflow for <input type=number> and <input type=range>
https://bugs.webkit.org/show_bug.cgi?id=29069

HTMLInputElement::max and min are not defined for COM because they
conflict with the standard min() and max() macros.

Tests: fast/forms/ValidityState-rangeOverflow-number.html

fast/forms/ValidityState-rangeOverflow-range.html
fast/forms/ValidityState-rangeUnderflow-number.html
fast/forms/ValidityState-rangeUnderflow-range.html
fast/forms/input-minmax.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::rangeUnderflow): (WebCore::HTMLInputElement::rangeOverflow): (WebCore::HTMLInputElement::rangeMinimum): (WebCore::HTMLInputElement::rangeMaximum):
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • html/ValidityState.cpp: (WebCore::ValidityState::rangeUnderflow): (WebCore::ValidityState::rangeOverflow):
  • html/ValidityState.h:
  • rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): (WebCore::SliderRange::valueFromElement):
11:29 Changeset [49198] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-06 Xan Lopez <xlopez@igalia.com>

Skip new tests for which we are missing expected results.

  • platform/gtk/Skipped:
11:27 Changeset [49197] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-06 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().

r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
it after each layout test as it should do, making the DRT dump additional output
for all of the subsequent layout tests.

  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset):
11:20 Changeset [49196] by eric@webkit.org
  • 8 edits in trunk/WebCore

2009-10-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move m_openedByDOM to Page
https://bugs.webkit.org/show_bug.cgi?id=30109

We only need one instance of m_openedByDOM per page, we should move it
to a page-scoped object. Notice that it's only ever touched for the
main frame.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::createWindow):
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::close):
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::openedByDOM): (WebCore::Page::setOpenedByDOM):
  • page/Page.h:
10:49 Changeset [49195] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-06 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Some functions in GraphicsContext do not work
as expected if the associated painter has no clipping.
https://bugs.webkit.org/show_bug.cgi?id=29691

No new tests are associated with this because DumpRenderTree
always sets clipping on the painter, thus it would never hit
the test case, but fast/box-shadow/basic-shadows.html is a
good example of what happens if the clipping is not set by
the user of QtWebKit.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): Fixed to handle the case that there is no clipping before the call.
10:37 Changeset [49194] by hyatt@apple.com
  • 11 edits
    8 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=30131, make beforeload fire on script elements.

Reviewed by Adam Roben.

WebCore:

Added tests in fast/dom/beforeload/.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElementData::requestScript):

  • dom/ScriptElement.h:
  • dom/XMLTokenizerLibxml2.cpp:

(WebCore::XMLTokenizer::endElementNs):

  • html/HTMLAttributeNames.in:
  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::parseMappedAttribute):
(WebCore::HTMLScriptElement::dispatchBeforeLoadEvent):

  • html/HTMLScriptElement.h:
  • html/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::scriptHandler):

  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::dispatchBeforeLoadEvent):

  • svg/SVGScriptElement.h:

LayoutTests:

  • fast/dom/beforeload: Added.
  • fast/dom/beforeload/resources: Added.
  • fast/dom/beforeload/script-before-load-dynamic-expected.txt: Added.
  • fast/dom/beforeload/script-before-load-dynamic.html: Added.
  • fast/dom/beforeload/script-before-load-expected.txt: Added.
  • fast/dom/beforeload/script-before-load-xhtml-expected.txt: Added.
  • fast/dom/beforeload/script-before-load-xhtml.xhtml: Added.
  • fast/dom/beforeload/script-before-load.html: Added.
10:24 Changeset [49193] by xan@webkit.org
  • 4 edits
    1 add in trunk

WebCore:

2009-10-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25526
[Gtk] Additional support is needed for caret browsing

Enable caret movement commands also when caret browsing setting is
enabled.

  • editing/EditorCommand.cpp: (WebCore::caretBrowsingEnabled): (WebCore::enabledVisibleSelectionOrCaretBrowsing): (WebCore::enabledInEditableTextOrCaretBrowsing): (WebCore::CommandEntry::):
  • manual-tests/gtk/caret-browsing.html: Added.

WebKit/gtk:

2009-10-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25526
[Gtk] Additional support is needed for caret browsing

Remove special cases for caret browsing, they are now handled in
cross-platform code.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeyboardEvent):
10:24 Changeset [49192] by eric@webkit.org
  • 2 edits
    273 adds in trunk/LayoutTests

2009-10-06 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Eric Seidel.

[Gtk][Layout tests] Generate results for editing tests
https://bugs.webkit.org/show_bug.cgi?id=30061

Add results for editing tests and enable these tests in the Skipped.
Also moves some improperly placed tests to the 'failing' section.

  • platform/gtk/Skipped:
  • platform/gtk/editing/deleting/4922367-expected.txt: Added.
  • platform/gtk/editing/deleting/5026848-1-expected.txt: Added.
  • platform/gtk/editing/deleting/5026848-2-expected.txt: Added.
  • platform/gtk/editing/deleting/5026848-3-expected.txt: Added.
  • platform/gtk/editing/deleting/5032066-expected.txt: Added.
  • platform/gtk/editing/deleting/5091898-expected.txt: Added.
  • platform/gtk/editing/deleting/5099303-expected.txt: Added.
  • platform/gtk/editing/deleting/5115601-expected.txt: Added.
  • platform/gtk/editing/deleting/5126166-expected.txt: Added.
  • platform/gtk/editing/deleting/5156801-2-expected.txt: Added.
  • platform/gtk/editing/deleting/5206311-1-expected.txt: Added.
  • platform/gtk/editing/deleting/5206311-2-expected.txt: Added.
  • platform/gtk/editing/deleting/5272440-expected.txt: Added.
  • platform/gtk/editing/deleting/5369009-expected.txt: Added.
  • platform/gtk/editing/deleting/5390681-2-expected.txt: Added.
  • platform/gtk/editing/deleting/5390681-expected.txt: Added.
  • platform/gtk/editing/deleting/5433862-2-expected.txt: Added.
  • platform/gtk/editing/deleting/5483370-expected.txt: Added.
  • platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-3608430-fix-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-3608445-fix-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-3608462-fix-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-3775172-fix-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-3800834-fix-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-3959464-fix-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-and-undo-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-block-contents-001-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-block-contents-002-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-block-contents-003-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-br-001-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-br-002-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-br-003-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-br-004-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-br-005-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-br-006-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-br-007-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-br-010-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-br-013-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-by-word-001-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-image-004-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-line-001-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-line-002-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-line-005-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-line-006-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-line-007-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-line-008-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-line-009-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-line-010-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-line-011-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-line-012-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-line-013-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-line-014-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-listitem-001-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-listitem-002-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-select-all-001-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-select-all-002-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-tab-002-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-tab-004-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-to-select-table-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt: Added.
  • platform/gtk/editing/deleting/forward-delete-expected.txt: Added.
  • platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt: Added.
  • platform/gtk/editing/deleting/move-nodes-001-expected.txt: Added.
  • platform/gtk/editing/deleting/type-delete-after-quote-expected.txt: Added.
  • platform/gtk/editing/execCommand/4580583-1-expected.txt: Added.
  • platform/gtk/editing/execCommand/4580583-2-expected.txt: Added.
  • platform/gtk/editing/execCommand/4747450-expected.txt: Added.
  • platform/gtk/editing/execCommand/4786404-1-expected.txt: Added.
  • platform/gtk/editing/execCommand/4786404-2-expected.txt: Added.
  • platform/gtk/editing/execCommand/4916402-expected.txt: Added.
  • platform/gtk/editing/execCommand/4916541-expected.txt: Added.
  • platform/gtk/editing/execCommand/4920488-expected.txt: Added.
  • platform/gtk/editing/execCommand/4920742-1-expected.txt: Added.
  • platform/gtk/editing/execCommand/4924441-expected.txt: Added.
  • platform/gtk/editing/execCommand/5049671-expected.txt: Added.
  • platform/gtk/editing/execCommand/5080333-1-expected.txt: Added.
  • platform/gtk/editing/execCommand/5080333-2-expected.txt: Added.
  • platform/gtk/editing/execCommand/5136770-expected.txt: Added.
  • platform/gtk/editing/execCommand/5138441-expected.txt: Added.
  • platform/gtk/editing/execCommand/5142012-1-expected.txt: Added.
  • platform/gtk/editing/execCommand/5142012-2-expected.txt: Added.
  • platform/gtk/editing/execCommand/5190926-expected.txt: Added.
  • platform/gtk/editing/execCommand/5481523-expected.txt: Added.
  • platform/gtk/editing/execCommand/5482023-expected.txt: Added.
  • platform/gtk/editing/execCommand/5569741-expected.txt: Added.
  • platform/gtk/editing/execCommand/5573879-expected.txt: Added.
  • platform/gtk/editing/execCommand/insert-list-empty-div-expected.txt: Added.
  • platform/gtk/editing/inserting/12882-expected.txt: Added.
  • platform/gtk/editing/inserting/4840662-expected.txt: Added.
  • platform/gtk/editing/inserting/4875189-1-expected.txt: Added.
  • platform/gtk/editing/inserting/4875189-2-expected.txt: Added.
  • platform/gtk/editing/inserting/4959067-expected.txt: Added.
  • platform/gtk/editing/inserting/4960120-2-expected.txt: Added.
  • platform/gtk/editing/inserting/5002441-expected.txt: Added.
  • platform/gtk/editing/inserting/5058163-1-expected.txt: Added.
  • platform/gtk/editing/inserting/5058163-2-expected.txt: Added.
  • platform/gtk/editing/inserting/5156401-2-expected.txt: Added.
  • platform/gtk/editing/inserting/5418891-expected.txt: Added.
  • platform/gtk/editing/inserting/5510537-expected.txt: Added.
  • platform/gtk/editing/inserting/5549929-2-expected.txt: Added.
  • platform/gtk/editing/inserting/5549929-3-expected.txt: Added.
  • platform/gtk/editing/inserting/6633727-expected.txt: Added.
  • platform/gtk/editing/inserting/6703873-expected.txt: Added.
  • platform/gtk/editing/inserting/editable-inline-element-expected.txt: Added.
  • platform/gtk/editing/inserting/edited-whitespace-1-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-3654864-fix-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-3659587-fix-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-3775316-fix-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-3800346-fix-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-3851164-fix-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-3907422-fix-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-after-delete-001-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-bg-font-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-bg-font-expected.txt.
  • platform/gtk/editing/inserting/insert-br-005-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-div-001-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-div-002-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-div-003-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-div-004-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-div-005-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-div-009-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-div-024-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt: Added.
  • platform/gtk/editing/inserting/redo-expected.txt: Added.
  • platform/gtk/editing/inserting/typing-001-expected.txt: Added.
  • platform/gtk/editing/inserting/typing-002-expected.txt: Added.
  • platform/gtk/editing/inserting/typing-003-expected.txt: Added.
  • platform/gtk/editing/inserting/typing-around-br-001-expected.txt: Added.
  • platform/gtk/editing/inserting/typing-around-image-001-expected.txt: Added.
  • platform/gtk/editing/pasteboard/4076267-2-expected.txt: Added.
  • platform/gtk/editing/pasteboard/4076267-3-expected.txt: Added.
  • platform/gtk/editing/pasteboard/4076267-expected.txt: Added.
  • platform/gtk/editing/pasteboard/5032095-expected.txt: Added.
  • platform/gtk/editing/pasteboard/5071074-2-expected.txt: Added.
  • platform/gtk/editing/pasteboard/5075944-3-expected.txt: Added.
  • platform/gtk/editing/pasteboard/5089327-expected.txt: Added.
  • platform/gtk/editing/pasteboard/5134759-expected.txt: Added.
  • platform/gtk/editing/pasteboard/5156401-1-expected.txt: Added.
  • platform/gtk/editing/pasteboard/5387578-expected.txt: Added.
  • platform/gtk/editing/pasteboard/5483567-expected.txt: Added.
  • platform/gtk/editing/pasteboard/7955-expected.txt: Added.
  • platform/gtk/editing/pasteboard/cut-text-001-expected.txt: Added.
  • platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-blockquote-1-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-blockquote-2-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-blockquote-3-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-table-001-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-text-001-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-text-004-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-text-005-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-text-007-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-text-008-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-text-009-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-text-010-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-text-015-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-xml-expected.txt: Added.
  • platform/gtk/editing/pasteboard/select-element-1-expected.txt: Added.
  • platform/gtk/editing/selection/13804-expected.txt: Added.
  • platform/gtk/editing/selection/14971-expected.txt: Added.
  • platform/gtk/editing/selection/4818145-expected.txt: Added.
  • platform/gtk/editing/selection/4866671-expected.txt: Added.
  • platform/gtk/editing/selection/4889598-expected.txt: Added.
  • platform/gtk/editing/selection/4895428-2-expected.txt: Added.
  • platform/gtk/editing/selection/4960116-expected.txt: Added.
  • platform/gtk/editing/selection/4960137-expected.txt: Added.
  • platform/gtk/editing/selection/4983858-expected.txt: Added.
  • platform/gtk/editing/selection/5007143-2-expected.txt: Added.
  • platform/gtk/editing/selection/5007143-expected.txt: Added.
  • platform/gtk/editing/selection/5057506-2-expected.txt: Added.
  • platform/gtk/editing/selection/5057506-expected.txt: Added.
  • platform/gtk/editing/selection/5076323-1-expected.txt: Added.
  • platform/gtk/editing/selection/5076323-2-expected.txt: Added.
  • platform/gtk/editing/selection/5076323-3-expected.txt: Added.
  • platform/gtk/editing/selection/5081257-1-expected.txt: Added.
  • platform/gtk/editing/selection/5081257-2-expected.txt: Added.
  • platform/gtk/editing/selection/5099303-expected.txt: Added.
  • platform/gtk/editing/selection/5109817-expected.txt: Added.
  • platform/gtk/editing/selection/5131716-1-expected.txt: Added.
  • platform/gtk/editing/selection/5131716-2-expected.txt: Added.
  • platform/gtk/editing/selection/5131716-3-expected.txt: Added.
  • platform/gtk/editing/selection/5131716-4-expected.txt: Added.
  • platform/gtk/editing/selection/5232159-expected.txt: Added.
  • platform/gtk/editing/selection/5234383-1-expected.txt: Added.
  • platform/gtk/editing/selection/5234383-2-expected.txt: Added.
  • platform/gtk/editing/selection/5333725-expected.txt: Added.
  • platform/gtk/editing/selection/5354455-1-expected.txt: Added.
  • platform/gtk/editing/selection/5354455-2-expected.txt: Added.
  • platform/gtk/editing/selection/addRange-expected.txt: Added.
  • platform/gtk/editing/selection/drag-in-iframe-expected.txt: Added.
  • platform/gtk/editing/selection/extend-by-character-002-expected.txt: Added.
  • platform/gtk/editing/selection/extend-by-character-003-expected.txt: Added.
  • platform/gtk/editing/selection/extend-by-character-004-expected.txt: Added.
  • platform/gtk/editing/selection/extend-by-character-005-expected.txt: Added.
  • platform/gtk/editing/selection/fake-drag-expected.txt: Added.
  • platform/gtk/editing/selection/iframe-expected.txt: Added.
  • platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt: Added.
  • platform/gtk/editing/selection/inline-table-expected.txt: Added.
  • platform/gtk/editing/selection/mixed-editability-6-expected.txt: Added.
  • platform/gtk/editing/selection/mixed-editability-7-expected.txt: Added.
  • platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt: Added.
  • platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt: Added.
  • platform/gtk/editing/selection/move-between-blocks-yes-001-expected.txt: Added.
  • platform/gtk/editing/selection/move-by-character-001-expected.txt: Added.
  • platform/gtk/editing/selection/move-by-character-002-expected.txt: Added.
  • platform/gtk/editing/selection/move-by-character-003-expected.txt: Added.
  • platform/gtk/editing/selection/move-by-character-004-expected.txt: Added.
  • platform/gtk/editing/selection/move-by-character-005-expected.txt: Added.
  • platform/gtk/editing/selection/move-by-sentence-001-expected.txt: Added.
  • platform/gtk/editing/selection/move-by-sentence-linebreak-expected.txt: Added.
  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt: Added.
  • platform/gtk/editing/selection/select-box-expected.txt: Added.
  • platform/gtk/editing/selection/selectNode-expected.txt: Added.
  • platform/gtk/editing/selection/selectNodeContents-expected.txt: Added.
  • platform/gtk/editing/selection/wrapped-line-caret-1-expected.txt: Added.
  • platform/gtk/editing/selection/wrapped-line-caret-2-expected.txt: Added.
  • platform/gtk/editing/spelling/spelling-expected.txt: Added.
  • platform/gtk/editing/spelling/spelling-linebreak-expected.txt: Added.
  • platform/gtk/editing/style/4916887-expected.txt: Added.
  • platform/gtk/editing/style/5017613-1-expected.txt: Added.
  • platform/gtk/editing/style/5017613-2-expected.txt: Added.
  • platform/gtk/editing/style/5046875-1-expected.txt: Added.
  • platform/gtk/editing/style/5046875-2-expected.txt: Added.
  • platform/gtk/editing/style/5084241-expected.txt: Added.
  • platform/gtk/editing/style/5228141-expected.txt: Added.
  • platform/gtk/editing/style/5279521-expected.txt: Added.
  • platform/gtk/editing/style/block-style-003-expected.txt: Added.
  • platform/gtk/editing/style/fontsize-1-expected.txt: Added.
  • platform/gtk/editing/style/highlight-expected.txt: Added.
  • platform/gtk/editing/style/relative-font-size-change-001-expected.txt: Added.
  • platform/gtk/editing/style/style-3681552-fix-001-expected.txt: Added.
  • platform/gtk/editing/style/style-3681552-fix-002-expected.txt: Added.
  • platform/gtk/editing/style/style-3690704-fix-expected.txt: Added.
  • platform/gtk/editing/style/typing-style-001-expected.txt: Added.
  • platform/gtk/editing/style/typing-style-002-expected.txt: Added.
  • platform/gtk/editing/style/typing-style-003-expected.txt: Added.
  • platform/gtk/editing/style/unbold-in-bold-expected.txt: Added.
  • platform/gtk/editing/undo/4063751-expected.txt: Added.
  • platform/gtk/editing/undo/5378473-expected.txt: Added.
  • platform/gtk/editing/undo/redo-typing-001-expected.txt: Added.
  • platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt: Added.
  • platform/gtk/editing/undo/undo-combined-delete-expected.txt: Added.
  • platform/gtk/editing/undo/undo-delete-boundary-expected.txt: Added.
  • platform/gtk/editing/undo/undo-delete-expected.txt: Added.
  • platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt: Added.
  • platform/gtk/editing/undo/undo-forward-delete-expected.txt: Added.
  • platform/gtk/editing/undo/undo-misspellings-expected.txt: Added.
10:15 Changeset [49191] by eric@webkit.org
  • 7 edits in trunk

2009-10-06 Anton Muhin <antonm@chromium>

Reviewed by Dimitri Glazkov.

Non standard, but popular exetension allows automagically
turn a function into a namespace resolver. Support that in
Chromium as well.

This adds new layout tests.
https://bugs.webkit.org/show_bug.cgi?id=30128

  • fast/xpath/xpath-namespaces-expected.txt:
  • fast/xpath/xpath-namespaces.html:

2009-10-06 Anton Muhin <antonm@chromium>

Reviewed by Dimitri Glazkov.

Non standard, but popular exetension allows automagically
turn a function into a namespace resolver. Support that in
Chromium as well.

Adjust CodeGeneratorV8 to treat XPathNSResolver in a special way.
https://bugs.webkit.org/show_bug.cgi?id=30128

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::getXPathNSResolver):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
09:48 HighLevelOverview edited by Atlant@mac.com
-typos, "to"->"from", grammar (diff)
08:48 Changeset [49190] by pfeldman@chromium.org
  • 10 edits in trunk

2009-10-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: close inspector client view on
InspectorController::close API call.

In order to run batch web inspector layout tests (and not affect
subsequent tests) we should close inspector client's view upon
InspectorController::close API call.

https://bugs.webkit.org/show_bug.cgi?id=30009

WebCore:

  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::close):

WebKit/gtk:

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::createPage):

WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::createPage):

WebKit/qt:

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::createPage):

WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::createPage):
08:34 Changeset [49189] by eric@webkit.org
  • 6 edits in trunk

2009-10-06 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
fast/dom/assign-to-window-status.html test, which is passing as a result.

https://bugs.webkit.org/show_bug.cgi?id=30127

  • platform/qt/Skipped:

2009-10-06 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
fast/dom/assign-to-window-status.html test, which is passing as a result.

https://bugs.webkit.org/show_bug.cgi?id=30127

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::statusBarMessage):
  • DumpRenderTree/qt/DumpRenderTree.h:
  • DumpRenderTree/qt/jsobjects.h: (LayoutTestController::shouldDumpStatusCallbacks): (LayoutTestController::dumpStatusCallbacks):
08:27 Changeset [49188] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-10-06 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Simon Hausmann.

[Qt] don't enable input methods on Symbian by default.
https://bugs.webkit.org/show_bug.cgi?id=30117

If input methods are enabled Symbian FEP will be launched on every
pointer event making webpage navigation impossible with QWebView.

  • Api/qwebview.cpp: (QWebView::QWebView):
08:06 Changeset [49187] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Fix the Qt/Windows build by stubbing out the still image
support for halted plugins for the Qt build.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-06
Reviewed by Tor Arne Vestbø.

Bugzilla entry https://bugs.webkit.org/show_bug.cgi?id=30130
tracks removing this by implementing Frame::nodeImage().

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::halt):

07:15 Changeset [49186] by hausmann@webkit.org
  • 5 edits in trunk/WebCore

[Qt] Change QImageReader usage in ImageDecoderQt

https://bugs.webkit.org/show_bug.cgi?id=27538

Replace the ReadContext with another appoach to
reading the image. Attempt to only read meta information
like the image size and number of frames (for animations)
first and then when the page is getting drawn decode
the image with the QImageReader.

This is a huge benefit on pages with many images and saves
~2GB of memory on the szeged image test page.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::ImageDecoderQt):
(WebCore::ImageDecoderQt::~ImageDecoderQt):
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::isSizeAvailable):
(WebCore::ImageDecoderQt::frameCount):
(WebCore::ImageDecoderQt::repetitionCount):
(WebCore::ImageDecoderQt::filenameExtension):
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::clearFrameBufferCache):
(WebCore::ImageDecoderQt::internalDecodeSize):
(WebCore::ImageDecoderQt::internalReadImage):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
(WebCore::ImageDecoderQt::forceLoadEverything):
(WebCore::ImageDecoderQt::failRead):

  • platform/graphics/qt/ImageDecoderQt.h:
07:14 Changeset [49185] by hausmann@webkit.org
  • 7 edits
    2 adds
    1 delete in trunk/WebCore

[Qt] Make use of RGBA32Buffer in ImageDecoderQt

https://bugs.webkit.org/show_bug.cgi?id=27538

Use the RGBA32Buffer instead of the internal ImageData
to be able to use support of the base class, optionally
support WebCore decoders for Qt and most importantly
separate metadata and image data for better cache control.

Remove ImageSourceQt as everything is now shared with
the normal ImageSource.

Change the ownership of the NativeImagePtr/QPixmap in
ImageQt.cpp to delete the m_frame to be subject to cache
control.

  • WebCore.pro:
  • platform/graphics/ImageSource.cpp:
  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::ReadContext::ReadContext):
(WebCore::ImageDecoderQt::ReadContext::read):
(WebCore::ImageDecoderQt::ReadContext::readImageLines):
(WebCore::ImageDecoderQt::ImageDecoderQt):
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::frameCount):
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::clearFrameBufferCache):

  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/graphics/qt/ImageSourceQt.cpp: Removed.
  • platform/image-decoders/ImageDecoder.h:

(WebCore::RGBA32Buffer::decodedImage):
(WebCore::RGBA32Buffer::getAddr):

  • platform/image-decoders/qt/RGBA32BufferQt.cpp: Added.

(WebCore::RGBA32Buffer::RGBA32Buffer):
(WebCore::RGBA32Buffer::setDecodedImage):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::zeroFill):
(WebCore::RGBA32Buffer::copyBitmapData):
(WebCore::RGBA32Buffer::setSize):
(WebCore::RGBA32Buffer::asNewNativeImage):
(WebCore::RGBA32Buffer::hasAlpha):
(WebCore::RGBA32Buffer::setHasAlpha):
(WebCore::RGBA32Buffer::setStatus):
(WebCore::RGBA32Buffer::operator=):
(WebCore::RGBA32Buffer::width):
(WebCore::RGBA32Buffer::height):

06:54 Changeset [49184] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-06 Xan Lopez <xlopez@igalia.com>

Skip another failing test.

  • platform/gtk/Skipped:
06:46 Changeset [49183] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

[Qt] ImageDecoderQt avoid QString creation.

https://bugs.webkit.org/show_bug.cgi?id=27538

Avoid going from CString to QString to String
and go directly from CString to String. Also
avoid going to lower case to avoid an extra
memory allocation.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoder::create):
(WebCore::ImageDecoderQt::ImageDecoderQt):

  • platform/graphics/qt/ImageDecoderQt.h:
06:46 Changeset [49182] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

[Qt] Cleanup the ImageDecoder of Qt.

https://bugs.webkit.org/show_bug.cgi?id=27538

Remove the various enums for partial load. The fact is
that this image decoder will decode everything that is
in the file at once. Make it look like it behaves to
ease fixing this core problem.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::ImageData::ImageData):
(WebCore::ImageDecoderQt::ReadContext::ReadContext):
(WebCore::ImageDecoderQt::ReadContext::read):
(WebCore::ImageDecoderQt::ReadContext::readImageLines):
(WebCore::ImageDecoderQt::hasFirstImageHeader):
(WebCore::ImageDecoderQt::setData):

  • platform/graphics/qt/ImageDecoderQt.h:
06:46 Changeset [49181] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

[Qt] Reimplement instead of overload frameCount in ImageDecoderQt.cpp

https://bugs.webkit.org/show_bug.cgi?id=27538

Reimplement frameCount instead of overloading it.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::frameCount):

  • platform/graphics/qt/ImageDecoderQt.h:
06:46 Changeset [49180] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

[Qt] QImageReader does not support progressive reading

https://bugs.webkit.org/show_bug.cgi?id=27538

Change the ImageDecoderQt::setData to store the encoded
data in ImageDecoder.

Only call ReadContext when the whole Resource has been
loaded to avoid needless calls to reset and the
ReadContext as progressive loading is not supported.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::setData):

  • platform/graphics/qt/ImageDecoderQt.h:
06:46 Changeset [49179] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Remove dead code from ImageDecoderQt.

https://bugs.webkit.org/show_bug.cgi?id=27538

Remove unused variables and debugging code. The debug
code has never been used and does not provide anything
useful.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::ReadContext::read):
(WebCore::ImageDecoderQt::ReadContext::readImageLines):
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::isSizeAvailable):
(WebCore::ImageDecoderQt::frameCount):
(WebCore::ImageDecoderQt::repetitionCount):
(WebCore::ImageDecoderQt::filenameExtension):
(WebCore::ImageDecoderQt::imageAtIndex):

06:46 Changeset [49178] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

QtLauncher: print the number of loaded urls

When using the -r mode print the number of URLs loaded so far. This
is extremly useful when opening the same URL over and over again and
one wants to see the progress.

06:38 Changeset [49177] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-06 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Update the Skipped list.
Remove some tests that are passing now, mostly due to the recent DRT fixes.

  • platform/qt/Skipped:
05:50 Changeset [49176] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-06 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] segfault when calling gst_video_format_parse_caps in the video sink
https://bugs.webkit.org/show_bug.cgi?id=30120

Fix use of gst_video_format_parse_caps()

  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func):
05:34 Changeset [49175] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Update mediaControls CSS

Reviewed by Simon Hausmann.

05:29 Changeset [49174] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2009-10-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Get rid of Preferences.ignoreWhitespace.

https://bugs.webkit.org/show_bug.cgi?id=30092

  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent): (WebInspector.DOMAgent.prototype._childNodeCountUpdated):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.update): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.onpopulate): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren):
  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
  • inspector/front-end/inspector.js:
  • inspector/front-end/utilities.js: (Node.prototype.rangeOfWord): (traverseNextNode): (traversePreviousNode): (onlyTextChild):
05:03 Changeset [49173] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not call nodeTitleInfo twice +
followup fixes for r49101.

https://bugs.webkit.org/show_bug.cgi?id=30087

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement):
04:57 Changeset [49172] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-06 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

ASSERT executing the webhistory unittest in a debug build
https://bugs.webkit.org/show_bug.cgi?id=28947

We have to call g_object_new first to initialize webkit threading
before creating the KURL.

  • WebKit/gtk/webkit/webkitwebhistoryitem.cpp:
04:53 Changeset [49171] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Windowless plugins: Enable painting on printer.

Patch by Girish Ramakrishnan <girish@forwardbias.in> on 2009-10-06
Reviewed by Simon Hausmann.

The print preview dialog crashed because the depth of the drawable
changed owing to a bug in Qt - if you draw onto a 32-bit pixmap,
and set a 24-bit pixmap as source, it will convert the source to
32-bit.

1210fa5b2d65895ad2be1f9ca7cae586e3b29dc1 is the bug fix in Qt.

https://bugs.webkit.org/show_bug.cgi?id=20081

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::paint):

04:52 Changeset [49170] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Windowless plugins: Make painting and events work when page is zoomed.

Patch by Girish Ramakrishnan <girish@forwardbias.in> on 2009-10-06
Reviewed by Simon Hausmann.

The element gets resized when zoomed. So, we have to make sure that we resize
the drawable and do a setwindow call. Multiple calls to setwindow do not
crash plugin in windowless mode (unlike in windowed mode).

For mouse events we have to convert the pos to post-zoom position.

https://bugs.webkit.org/show_bug.cgi?id=20081

  • plugins/qt/PluginViewQt.cpp:

(WebCore::setXButtonEventSpecificFields):
(WebCore::setXMotionEventSpecificFields):
(WebCore::setXCrossingEventSpecificFields):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowIfNeeded):

04:52 Changeset [49169] by hausmann@webkit.org
  • 6 edits in trunk/WebCore

[Qt] Windowless plugins: Add PluginQuirkRequiresDefaultScreenDepth quirk for Flash.

Patch by Girish Ramakrishnan <girish@forwardbias.in> on 2009-10-06
Reviewed by Simon Hausmann.

Flash does not use the visual provided by us to draw into the drawable.
It instead uses the system default visual (as returned by XDefaultVisual).
This means that if the screen default visual is 24-bit, Flash won't be
able to draw on 32-bit drawable created by us. This is a bug in Flash
and for the moment, the above quirk is only set for Flash.

Our strategy to create the drawable:

  1. Create a 32-bit drawable if the default screen depth is 32 or the

quirk is not set (i.e not flash)

  1. If we didn't create a 32-bit drawable (maybe the Display has no such

visual), we create a drawable with default screen depth.

As a result of the above changes, content propagation behavior changes as:

  1. Content propagation is possible only if the drawable we create and

Qt's backing store are of the same depth.

  1. If we created a 32-bit drawable, there is no need for content

propagation (Qt will take care of it).

https://bugs.webkit.org/show_bug.cgi?id=20081

  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::determineQuirks):

  • plugins/PluginQuirkSet.h:

(WebCore::):

  • plugins/PluginView.cpp:

(WebCore::PluginView::PluginView):

  • plugins/PluginView.h:
  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::getVisualAndColormap):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):

04:49 Changeset [49168] by eric@webkit.org
  • 24 edits in trunk/WebKit/gtk

2009-10-06 José Millán Soto <fid@gpul.org>

Reviewed by Xan Lopez.

Header files of WebKitGTK do not comply with WebKit coding style (Patch attached)
https://bugs.webkit.org/show_bug.cgi?id=30076

Solves various issues in header files.

  • WebCoreSupport/DocumentLoaderGtk.h: Added "headed guards"
  • webkit/webkitdefines.h:
  • webkit/webkitdownload.h:
  • webkit/webkiterror.h:
  • webkit/webkithittestresult.h:
  • webkit/webkitnetworkrequest.h:
  • webkit/webkitnetworkresponse.h:
  • webkit/webkitprivate.h:
  • webkit/webkitsecurityorigin.h:
  • webkit/webkitsoupauthdialog.h:
  • webkit/webkitversion.h.in:
  • webkit/webkitwebbackforwardlist.h:
  • webkit/webkitwebdatabase.h:
  • webkit/webkitwebdatasource.h:
  • webkit/webkitwebframe.h:
  • webkit/webkitwebhistoryitem.h:
  • webkit/webkitwebinspector.h:
  • webkit/webkitwebnavigationaction.h:
  • webkit/webkitwebpolicydecision.h:
  • webkit/webkitwebresource.h:
  • webkit/webkitwebsettings.h:
  • webkit/webkitwebview.h:
  • webkit/webkitwebwindowfeatures.h:
04:42 Changeset [49167] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-10-06 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
ignores the argument indicating which mouse button to trigger.
https://bugs.webkit.org/show_bug.cgi?id=30048

This affects the fast/events/mouse-click-events.html layout test.

  • DumpRenderTree/qt/jsobjects.cpp: (EventSender::mouseDown): (EventSender::mouseUp):
  • DumpRenderTree/qt/jsobjects.h:
04:35 Changeset [49166] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-06 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Fix the EventSender::keyDown() implementation
https://bugs.webkit.org/show_bug.cgi?id=30043

It should post both a key press event and a key release event,
just like other ports do.

  • DumpRenderTree/qt/jsobjects.cpp: (EventSender::keyDown):
04:27 Changeset [49165] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-06 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Ariya Hidayat.

Qt build fix.
https://bugs.webkit.org/show_bug.cgi?id=29362.

In Qt 4.5, a new function QPainter::fillRect(QRect, QColor) is
introduced to avoid the expensive construction of QBrush.
By casting WebCore::Color to QColor, we can compile on Qt 4.4
and use optimization for solid color fill in Qt 4.5.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::drawBorderlessRectShadow):
04:08 Changeset [49164] by benm@google.com
  • 6 edits in trunk/WebCore

Allow the platform media player to know the <video> poster URL.
Add MediaPlayerPrivate::prepareToPlay() to support media engines
that do not buffer video data automatically. This method allows
such media engines to start the buffering just before starting
playback.
https://bugs.webkit.org/show_bug.cgi?id=29133

Patch by Andrei Popescu <andreip@google.com> on 2009-10-05
Reviewed by Eric Carlson.

All platforms that currently implement <video> return false
in MediaPlayerPrivate::canLoadPoster() and do nothing in
MediaPlayerPrivate::prepareToPlay() their behavior is
unchanged. The current set of media test should then be
sufficient to guarantee that this patch does not break anything.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource):
After the MediaPlayer is created, inform it what the poster URL is.
(WebCore::HTMLMediaElement::updatePlayState):
Add another case where prepareToPlay is called for the platforms
that do not buffer video content automatically.
(WebCore::HTMLMediaElement::couldPlayIfEnoughData)
Same as potentiallyPlaying, except that we don't check for
the readyState being at least HAVE_FUTURE_DATA.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::canLoadPoster):
Empty implementation for the NullMediaPlayerPrivate.
(WebCore::NullMediaPlayerPrivate::setPoster):
Empty implementation for the NullMediaPlayerPrivate.
(WebCore::MediaPlayer::canLoadPoster):
Proxy to the m_private.
(WebCore::MediaPlayer::setPoster):
Proxy to m_private.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::canLoadPoster):
(WebCore::MediaPlayerPrivateInterface::setPoster):
Add new methods that allow the platform player to receive the poster URL.
(WebCore::MediaPlayerPrivateInterface::prepareToPlay):
Notifies the media engine that playback should start. The media engine
should start preparing (e.g. by initializing the player and starting to buffer)
and call back when the state is changed to HAVE_FUTURE_DATA.

03:45 Changeset [49163] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-06 Dirk Schulze <krit@webkit.org>

Previous SourceAlpha test were made with an filters enabled build.
This is the result of a filters disabled build (default).

  • platform/mac/svg/filters/sourceAlpha-expected.txt:
01:11 Changeset [49162] by levin@chromium.org
  • 3 edits in trunk/WebKit/win

Speculative build fix for windows (due to r49160).

Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by NOBODY (windows build fix).

  • WebDownloadCFNet.cpp:

(WebDownload::initToResumeWithBundle):

  • WebIconDatabase.cpp:

(WebIconDatabase::dispatchDidAddIconForPageURL):

01:08 Changeset [49161] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-06 Xan Lopez <xlopez@igalia.com>

Update the skipped list to recent changes in tests.

  • platform/gtk/Skipped:
00:45 Changeset [49160] by levin@chromium.org
  • 36 edits in trunk

StringImpl needs a method to get an instance for another thread which doesn't copy the underlying buffer.
https://bugs.webkit.org/show_bug.cgi?id=30095

Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by Oliver Hunt.

JavaScriptCore:

  • wtf/CrossThreadRefCounted.h:

Removed an unused function and assert improvement.
(WTF::CrossThreadRefCounted::isOwnedByCurrentThread): Moved out common code from asserts.
(WTF::CrossThreadRefCounted::ref): Changed assert to use the common method.
(WTF::CrossThreadRefCounted::deref): Changed assert to use the common method.
(WTF::CrossThreadRefCounted::crossThreadCopy): Since this includes a potentially
non-threadsafe operation, add an assert that the class is owned by the current thread.

WebCore:

All String::copy methods were changed to call either threadsafeCopy or crossThreadString. The method
call was made threadsafeCopy unless I could show that threadsafety wasn't needed.

No visible change in functionality so no new tests.

  • dom/MessagePortChannel.cpp:

(WebCore::MessagePortChannel::EventData::EventData):

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::open):
(WebCore::IconDatabase::iconForPageURL):
(WebCore::IconDatabase::iconURLForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::databasePath):
(WebCore::IconDatabase::defaultDatabaseFilename):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin): Since this is used by SecurityOrigin::threadsafeCopy,
it makes threadsafe calls.
(WebCore::SecurityOrigin::threadsafeCopy): The only place that called this
needed a threadsafe method.

  • page/SecurityOrigin.h:
  • platform/CrossThreadCopier.cpp:

(WebCore::::copy):

  • platform/KURL.cpp:

(WebCore::KURL::copy):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):

  • platform/network/ResourceErrorBase.cpp:

(WebCore::ResourceErrorBase::copy):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::copyData):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::copyData):

  • platform/sql/SQLValue.cpp:

(WebCore::SQLValue::SQLValue):
(WebCore::SQLValue::string):

  • platform/sql/SQLValue.h:

(WebCore::SQLValue::SQLValue):
All constructors now initialize the m_number which is a double. Failure to
do so can result in unexpected crashes when it is copied in the copy constructor.
See http://blogs.msdn.com/oldnewthing/archive/2008/07/02/8679191.aspx, I was that colleague.

  • platform/text/PlatformString.h:
  • platform/text/String.cpp:

(WebCore::String::threadsafeCopy):
(WebCore::String::crossThreadString):

  • platform/text/StringImpl.cpp:

Removed StringImpl::substringCopy which was no longer being used anywhere.
(WebCore::StringImpl::threadsafeCopy): Changed the name to indicate that
it is threadsafe.
(WebCore::StringImpl::crossThreadString): The way to get strings for
another thread which is not threadsafe. This shares the underlying buffer
with both strings and gives them a way to do threadsafe refcounting for it.

  • platform/text/StringImpl.h:
  • storage/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::ChangeVersionWrapper):

  • storage/Database.cpp:

(WebCore::updateGuidVersionMap):
(WebCore::Database::Database):
(WebCore::Database::getVersionFromDatabase):
(WebCore::Database::setVersionInDatabase):
(WebCore::Database::version):
(WebCore::Database::setExpectedVersion):
(WebCore::Database::securityOriginCopy):
(WebCore::Database::stringIdentifier):

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged):

  • storage/OriginQuotaManager.cpp:

(WebCore::OriginQuotaManager::addDatabase):

  • storage/SQLError.h:

(WebCore::SQLError::message):
(WebCore::SQLError::SQLError):

  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::SQLStatement):

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::syncTimerFired):

  • storage/StorageMap.cpp:

(WebCore::StorageMap::importItem):

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::StorageNamespaceImpl):

  • storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::StorageSyncManager):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::url): Do the copy of the url in a way that is threadsafe.
(WebCore::SharedWorkerProxy::name):
(WebCore::SharedWorkerProxy::SharedWorkerProxy):
(WebCore::DefaultSharedWorkerRepository::getProxy): Do the copy of the url in a way that is threadsafe.

  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::SharedWorkerThread):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::MessageWorkerContextTask::MessageWorkerContextTask):
(WebCore::MessageWorkerTask::MessageWorkerTask):
(WebCore::WorkerExceptionTask::WorkerExceptionTask):

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::Task::Task):
(WebCore::WorkerRunLoop::postTaskForMode):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):

00:35 Changeset [49159] by hausmann@webkit.org
  • 4 edits in trunk/WebCore

[Qt] Windowless plugins: Use X Pixmap instead of QPixmap.

Patch by Girish Ramakrishnan <girish@forwardbias.in> on 2009-10-06
Reviewed by Simon Hausmann.

This has the following advantages:

  1. Allows more sharing of code between gtk and Qt ports in the future
  2. QPixmap creates 24-bit by default. We have to later 'upgrade' it to 32-bit.
  3. QPixmap may sometime change depth behind our back! This will require us to

update the plugin about the new visual and colormap.

  1. We cannot ensure that QPixmap is backed by a X Drawable. For example, with

-graphicssystem raster, QPixmap uses the raster (image) backend.

https://bugs.webkit.org/show_bug.cgi?id=20081

  • plugins/PluginView.cpp:

(WebCore::PluginView::PluginView):

  • plugins/PluginView.h:
  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::platformDestroy):

00:31 Changeset [49158] by hausmann@webkit.org
  • 4 edits in trunk/WebCore

[Qt] Add support for windowless NPAPI plugins

Patch by Girish Ramakrishnan <girish@forwardbias.in> on 2009-10-06
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=20081

  • plugins/PluginView.cpp:

(WebCore::PluginView::setFrameRect):
(WebCore::PluginView::handleEvent):
(WebCore::PluginView::PluginView):

  • plugins/PluginView.h:
  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::dispatchNPEvent):
(WebCore::setSharedXEventFields):
(WebCore::PluginView::initXEvent):
(WebCore::setXKeyEventSpecificFields):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::inputEventState):
(WebCore::setXButtonEventSpecificFields):
(WebCore::setXMotionEventSpecificFields):
(WebCore::setXCrossingEventSpecificFields):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::handleFocusInEvent):
(WebCore::PluginView::handleFocusOutEvent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::getValueStatic):
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::invalidateRegion):
(WebCore::PluginView::forceRedraw):
(WebCore::getPluginDisplay):
(WebCore::PluginView::platformStart):

00:02 Changeset [49157] by jorlow@chromium.org
  • 3 edits
    2 copies
    1 add in trunk/LayoutTests

2009-10-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Convert DOM Storage's "remove-item" test into the new format.
https://bugs.webkit.org/show_bug.cgi?id=30099

Convert DOM Storage's "remove-item" test into the new format and add it for
session storage. Make it a (tiny bit) more robust as well.

  • storage/domstorage/localstorage/remove-item-expected.txt:
  • storage/domstorage/localstorage/remove-item.html:
  • storage/domstorage/script-tests/remove-item.js: Added. (runTest):
  • storage/domstorage/sessionstorage/remove-item-expected.txt: Copied from LayoutTests/storage/domstorage/localstorage/remove-item-expected.txt.
  • storage/domstorage/sessionstorage/remove-item.html: Copied from LayoutTests/storage/domstorage/localstorage/remove-item.html.
00:01 Changeset [49156] by jorlow@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-10-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Add a test to verify session storage does not have a quota
https://bugs.webkit.org/show_bug.cgi?id=30093

  • storage/domstorage/script-tests/no-quota.js: Added. (runTest):
  • storage/domstorage/sessionstorage/no-quota-expected.txt: Added.
  • storage/domstorage/sessionstorage/no-quota.html: Added.

10/05/09:

23:58 Changeset [49155] by jorlow@chromium.org
  • 3 edits
    2 copies
    1 add in trunk/LayoutTests

2009-10-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Convert DOM Storage's "complex-values" test into the new format.
https://bugs.webkit.org/show_bug.cgi?id=30097

Convert DOM Storage's "complex-values" test into the new format and add it for
session storage. This also increases the coverage of these tests a bit.

  • storage/domstorage/localstorage/complex-values-expected.txt:
  • storage/domstorage/localstorage/complex-values.html:
  • storage/domstorage/script-tests/complex-values.js: Added. (handleStorageEvent): (testKeyValue): (runTest):
  • storage/domstorage/sessionstorage/complex-values-expected.txt: Copied from LayoutTests/storage/domstorage/localstorage/complex-values-expected.txt.
  • storage/domstorage/sessionstorage/complex-values.html: Copied from LayoutTests/storage/domstorage/localstorage/complex-values.html.
23:56 Changeset [49154] by jorlow@chromium.org
  • 3 edits
    3 adds in trunk/LayoutTests

2009-10-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Convert DOM Storage's "complex-keys" test into the new format
https://bugs.webkit.org/show_bug.cgi?id=30089

Convert DOM Storage's "complex-keys" test into the new format and add it for
session storage. This test should be a bit more thorough than the old
version as well.

  • storage/domstorage/localstorage/complex-keys-expected.txt:
  • storage/domstorage/localstorage/complex-keys.html:
  • storage/domstorage/script-tests/complex-keys.js: Added. (runTest):
  • storage/domstorage/sessionstorage/complex-keys-expected.txt: Added.
  • storage/domstorage/sessionstorage/complex-keys.html: Added.
22:58 Changeset [49153] by krit@webkit.org
  • 4 edits
    4 adds in trunk

2009-10-05 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filters do not support source images besides "sourceGraphic"
https://bugs.webkit.org/show_bug.cgi?id=6022

Add support for SourceAlpha to SVG filters.

Test: svg/filters/sourceAlpha.svg

  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::calculateEffectRect): (WebCore::SourceAlpha::apply):
  • platform/graphics/filters/SourceAlpha.h:

Test for SVG's SourceAlpha support for Filters.

  • platform/mac/svg/filters/sourceAlpha-expected.checksum: Added.
  • platform/mac/svg/filters/sourceAlpha-expected.png: Added.
  • platform/mac/svg/filters/sourceAlpha-expected.txt: Added.
  • svg/filters/sourceAlpha.svg: Added.
22:39 WebKit Team edited by jam@chromium.org
(diff)
22:13 Changeset [49152] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Rubber-stamped by Mark Rowe.

Moved a WebPluginHalterClient out of the WebCore namesapce.

  • WebCoreSupport/WebPluginHalterClient.h:
22:07 Changeset [49151] by kevino@webkit.org
  • 4 edits in trunk

wx libjpeg link fix and JSC build fix.

21:58 Changeset [49150] by simon.fraser@apple.com
  • 21 edits
    4 adds in trunk/LayoutTests

2009-10-05 Simon Fraser <simon.fraser@apple.com>

Updated results for media tests after controller change to add the fullscreen button.

  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.checksum: Added.
  • platform/mac/media/controls-after-reload-expected.png: Added.
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-styling-expected.checksum:
  • platform/mac/media/controls-styling-expected.png:
  • platform/mac/media/controls-styling-expected.txt:
  • platform/mac/media/video-aspect-ratio-expected.checksum:
  • platform/mac/media/video-aspect-ratio-expected.png:
  • platform/mac/media/video-empty-source-expected.checksum:
  • platform/mac/media/video-empty-source-expected.png:
  • platform/mac/media/video-empty-source-expected.txt:
  • platform/mac/media/video-no-audio-expected.checksum:
  • platform/mac/media/video-no-audio-expected.png:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-transformed-expected.checksum:
  • platform/mac/media/video-transformed-expected.png:
  • platform/mac/media/video-zoom-controls-expected.checksum: Added.
  • platform/mac/media/video-zoom-controls-expected.png: Added.
  • platform/mac/media/video-zoom-controls-expected.txt:
  • platform/mac/media/video-zoom-expected.checksum:
  • platform/mac/media/video-zoom-expected.png:
21:58 Changeset [49149] by kdecker@apple.com
  • 8 edits
    2 adds in trunk/WebKit

Reviewed by Dan Bernstein.

Added new PluginHalter client, delegate and few more WebPreferences keys.

  • WebView/WebPreferenceKeysPrivate.h: Added two new keys.
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Initialize newly added key. (-[WebPreferences pluginAllowedRunTime]): Added. (-[WebPreferences setPluginAllowedRunTime:]): Added.
  • WebView/WebPreferencesPrivate.h: Added above two methods.
  • WebView/WebUIDelegatePrivate.h: Added shouldHaltPlugin delegate.
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Setup a new WebPluginHalterClient. (-[WebView _preferencesChangedNotification:]): Update WebCore settings accordingly.
  • WebCoreSupport/WebPluginHalterClient.h: Added.
  • WebCoreSupport/WebPluginHalterClient.mm: Added. (WebPluginHalterClient::WebPluginHalterClient): (WebPluginHalterClient::shouldHaltPlugin): Added, invoke the delegate.
21:55 Changeset [49148] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-10-05 John Abd-El-Malek <jam@chromium.org>

Reviewed by Adam Barth.

Fix reliablity bot crash in DateExtension.
https://bugs.webkit.org/show_bug.cgi?id=30033

There were a few problems using the weak persistent pointers because no one else had a
handle to them. The new approach stores them as a hidden value on the Date constructor.

  • bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep): (WebCore::DateExtension::GetNativeFunction): (WebCore::DateExtension::Setup): (WebCore::DateExtension::OnSleepDetected):
  • bindings/v8/DateExtension.h:
  • bindings/v8/V8HiddenPropertyName.cpp: (WebCore::V8HiddenPropertyName::sleepFunction):
  • bindings/v8/V8HiddenPropertyName.h:
21:40 Changeset [49147] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-05 Simon Fraser <simon.fraser@apple.com>

More build fixes for Tiger.

  • WebView/WebVideoFullscreenController.mm:
21:17 Changeset [49146] by simon.fraser@apple.com
  • 3 edits in trunk/WebKit/mac

2009-10-05 Simon Fraser <simon.fraser@apple.com>

More build fixes for Tiger.

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenWindow animationDidEnd:]):
  • WebView/WebWindowAnimation.m:
21:17 Changeset [49145] by slewis@apple.com
  • 2 edits in trunk/WebCore

Crash when trying to load a null stylesheet for a site specific hack.
https://bugs.webkit.org/show_bug.cgi?id=30105

Reviewed by Dan Bernstein.

Created a testcase and tested in browser. DRT doesn't test
site specific hacks.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

21:12 Changeset [49144] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-05 James Robinson <jamesr@google.com>

Reviewed by Darin Adler.

Fix forward declaration (struct vs class mismatch)

https://bugs.webkit.org/show_bug.cgi?id=30094

  • loader/RedirectScheduler.h:
20:58 Changeset [49143] by simon.fraser@apple.com
  • 3 edits in trunk/WebKit/mac

2009-10-05 Simon Fraser <simon.fraser@apple.com>

More build fixes for Tiger.

  • WebView/WebVideoFullscreenController.mm:
  • WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): (-[WebVideoFullscreenHUDWindowController fadeWindowIn]): (-[WebVideoFullscreenHUDWindowController fadeWindowOut]): (-[WebVideoFullscreenHUDWindowController closeWindow]):
18:53 Changeset [49142] by jparent@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, last Chromium build fix corresponding to revision 49113.
Add include for BeforeLoadEvent to DOMObjectsInclude.h.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-05

  • bindings/v8/DOMObjectsInclude.h:
18:47 Changeset [49141] by eric@webkit.org
  • 2 edits in trunk/WebKit

2009-10-05 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

One of the dependencies' SVN url was missing a @ before the revision number.

https://bugs.webkit.org/show_bug.cgi?id=30101

  • chromium/DEPS:
18:21 Changeset [49140] by simon.fraser@apple.com
  • 3 edits in trunk/WebKit/mac

2009-10-05 Simon Fraser <simon.fraser@apple.com>

Build fixes for Tiger.

  • WebView/WebVideoFullscreenHUDWindowController.h:
  • WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): (-[WebVideoFullscreenHUDWindowController dealloc]): (-[WebVideoFullscreenHUDWindowController closeWindow]): (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
18:05 Changeset [49139] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-05 Simon Fraser <simon.fraser@apple.com>

Build fix. If you call Node::hasTagName(), you also have to include Element.h.

  • WebCoreSupport/WebChromeClient.mm:
17:43 Changeset [49138] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-10-05 Simon Fraser <simon.fraser@apple.com>

Fix Windows build.

  • html/HTMLMediaElement.cpp:
17:40 Changeset [49137] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-10-05 Simon Fraser <simon.fraser@apple.com>

Fix the build: MediaControllerThemeQT was renamed to MediaControllerThemeQuickTime.

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
17:24 Changeset [49136] by simon.fraser@apple.com
  • 31 edits
    7 adds in trunk

2009-10-05 Pierre d'Herbemont <pdherbemont@webkit.org>

Reviewed by Simon Fraser

Support fullscreen in MediaPlayer (Mac)
https://bugs.webkit.org/show_bug.cgi?id=26742

Add a fullscreen button to the <video> controller if the media engine,
and the theme have support for fullscreen, and can show appropriate controls.
Clicking the button calls through the ChromeClient to the WebVideoFullscreenController
in WebKit to do a nice animation to fullscreen, with a custom controller.

17:21 Changeset [49135] by kdecker@apple.com
  • 2 edits in trunk/WebCore

Export a few more methods from Settings.h


Rubberstamped by Jon Honeycutt.


  • WebCore.base.exp:
17:03 Changeset [49134] by dimich@chromium.org
  • 2 edits in trunk/WebCore

1-char fix for obviously reverse condition.
https://bugs.webkit.org/show_bug.cgi?id=30100
No test since the only difference is a timing of GC.

Reviewed by Darin Adler.

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::clear): Revert condition. Almost a typo.

17:00 Changeset [49133] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

WebKit side of <rdar://problem/7179166>

Reviewed by Kevin Decker.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:

Add an m_pluginIsWaitingForDraw member variable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Initialize m_pluginIsWaitingForDraw.

(WebKit::NetscapePluginInstanceProxy::invalidateRect):
Set m_pluginIsWaitingForDraw to true.

(WebKit::NetscapePluginInstanceProxy::didDraw):
If m_pluginIsWaitingForDraw is true, call _WKPHPluginInstanceDidDraw.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView drawRect:]):
Call didDraw.

  • Plugins/Hosted/WebKitPluginHost.defs:

Add PHPluginInstanceDidDraw.

16:57 Changeset [49132] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-09-30 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Update platform-specific #ifdefs in GraphicsContext3D.h for the
Chromium port.
https://bugs.webkit.org/show_bug.cgi?id=29936

  • platform/graphics/GraphicsContext3D.h: Changed #if PLATFORM(SKIA) to #if PLATFORM(CHROMIUM).
16:37 Changeset [49131] by mitz@apple.com
  • 3 edits
    4 adds in trunk

REGRESSION (r47440): Inserting text in the middle of content in a scrolled textfield results in painting bugs
<rdar://problem/7269108>
https://bugs.webkit.org/show_bug.cgi?id=29982

Reviewed by Darin Adler.

WebCore:

Test: fast/repaint/line-in-scrolled-clipped-block.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock): Use the unclipped overflow rect
(including layout overflow) for the repaint rect calculation.

LayoutTests:

  • fast/repaint/line-in-scrolled-clipped-block.html: Added.
  • platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.checksum: Added.
  • platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
  • platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Added.
16:34 Changeset [49130] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-10-05 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Chromium wants to turn off SharedWorkers at runtime
https://bugs.webkit.org/show_bug.cgi?id=29757

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::sharedWorker): Now returns jsUndefined if isAvailable() returns false, to allow SharedWorkers to be disabled at runtime.
  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerRepository::isAvailable): Made SharedWorkers available by default.
  • workers/SharedWorkerRepository.h: Added definition for SharedWorkerRepository::isAvailable().
16:26 Changeset [49129] by eric@webkit.org
  • 4 edits
    4 adds in trunk

2009-10-05 Hironori Bono <hbono@chromium.org>

Reviewed by Eric Seidel.

A super quick fix for Bug 28710.

https://bugs.webkit.org/show_bug.cgi?id=28710

This change just resets the style sent to addStyleMarkup() to avoid an assertion error
and creates an empty style when computedStyleAtPosition is 0 to avoid a crash.
(This change is nothing but a better-than-crash change.)

  • editing/selection/select-crash-001-expected.txt: Added.
  • editing/selection/select-crash-001.html: Added.
  • editing/selection/select-crash-002-expected.txt: Added.
  • editing/selection/select-crash-002.html: Added.

2009-10-05 Hironori Bono <hbono@chromium.org>

Reviewed by Eric Seidel.

A super quick fix for Bug 28710.

https://bugs.webkit.org/show_bug.cgi?id=28710

This change just resets the style sent to addStyleMarkup() to avoid an assertion error
and creates an empty style when computedStyleAtPosition is 0 to avoid a crash.
(This change is nothing but a better-than-crash change.)

Tests: editing/selection/select-crash-001.html

editing/selection/select-crash-002.html

  • editing/ApplyStyleCommand.cpp: (WebCore::editingStyleAtPosition): Resets the style sent to addStyleMarkup() if it is not valid.
  • editing/markup.cpp: (WebCore::createMarkup): Creates an empty style if computedStyleAtPosition is 0.
16:18 Changeset [49128] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-10-05 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Remove precompiled header from JavaScriptCore compilation to
prevent qmake warning during autonomous compilation.
https://bugs.webkit.org/show_bug.cgi?id=30069

16:10 Changeset [49127] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-05 Julie Parent <jparent@chromium.org>

Reviewed by Darin Adler.

Make LayoutTests/editing/selection/hit-test-anonymous.html resistant to
GDI/CG differences, by increasing the font size so the slight
difference in fonts doesn't result in a different character clicked.
https://bugs.webkit.org/show_bug.cgi?id=29985

  • editing/selection/hit-test-anonymous.html:
16:10 Changeset [49126] by weinig@apple.com
  • 2 edits in trunk/WebCore

Silence duplicate errors logged for missing getComputedStyle
implementations. Improves the error message as well.

Reviewed by Mark Rowe.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::logUnimplementedPropertyID):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

16:03 Changeset [49125] by jparent@chromium.org
  • 3 edits in trunk/WebCore

Unreviewed, Chromium build fix #3. Add V8BeforeLoadEvent.[cc|h] to derived sources.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-05

  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
16:03 Changeset [49124] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-10-05 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Simon Hausmann.

Add screenshot option to menubar

https://bugs.webkit.org/show_bug.cgi?id=30067

  • QtLauncher/main.cpp: (MainWindow::screenshot): (MainWindow::setupUI):
15:49 Changeset [49123] by cmarrin@apple.com
  • 1 edit in trunk/WebKitSite/blog-files/webgl/WebGL+CSS.html

Another change to one of the WebGL blog post demos

15:45 Changeset [49122] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-10-05 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Simon Hausmann.

Setting the env QTLAUNCHER_USE_ARGB_VISUALS makes Qt use WA_TranslucentWindow.

https://bugs.webkit.org/show_bug.cgi?id=30068

  • QtLauncher/main.cpp: (MainWindow::MainWindow):
15:44 Changeset [49121] by cmarrin@apple.com
  • 7 edits in trunk/WebKitSite/blog-files/webgl

Fixed some tests for WebGL blog post

15:41 Changeset [49120] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Try and fix the GTK build.

  • GNUmakefile.am:
15:37 Changeset [49119] by cmarrin@apple.com
  • 17 adds in trunk/WebKitSite/blog-files/webgl

Added files for WebGL blog post

15:37 Changeset [49118] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-05 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] EventSender::keyDown() cannot send function-key events.
https://bugs.webkit.org/show_bug.cgi?id=30044

This affects the fast/events/keydown-function-keys.html layout test.

  • DumpRenderTree/qt/jsobjects.cpp: (EventSender::keyDown):
15:31 Changeset [49117] by jparent@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, Chromium build fix #2. Add new BEFORELOADEVENT to V8ClassIndex.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-05

  • bindings/v8/V8Index.h:
15:07 Changeset [49116] by jparent@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, Chromium build fix. Missing "," after entry for BeforeLoadEvent.idl.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-05

  • WebCore.gypi:
15:04 Changeset [49115] by hyatt@apple.com
  • 4 edits in trunk/LayoutTests

Update layout tests to account for the new beforeload event object.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
14:28 Changeset [49114] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.pro

Fix Qt bustage.

14:16 Changeset [49113] by hyatt@apple.com
  • 8 edits
    2 adds in trunk/WebCore

Add a beforeload event that will be fired before subresources load. (It isn't fired yet.) The event
has one field, the URL that is going to be requested. Setting preventDefault will stop the load
from occurring.

Reviewed by Sam Weinig.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/BeforeLoadEvent.h: Added.

(WebCore::BeforeLoadEvent::create):
(WebCore::BeforeLoadEvent::initBeforeLoadEvent):
(WebCore::BeforeLoadEvent::url):
(WebCore::BeforeLoadEvent::BeforeLoadEvent):

  • dom/BeforeLoadEvent.idl: Added.
  • dom/EventNames.h:
  • page/DOMWindow.idl:
14:07 Changeset [49112] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-05 Priit Laes <plaes@plaes.org>

Reviewed by Gustavo Noronha.

Add Gentoo-specific paths for searching browser plugins.
https://bugs.webkit.org/show_bug.cgi?id=30088

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::defaultPluginDirectories):
13:46 Changeset [49111] by cmarrin@apple.com
  • 7 edits in trunk

Add functionality to pause/throttle CSS transitions/animations in a WebView
https://bugs.webkit.org/show_bug.cgi?id=29942

13:44 Changeset [49110] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Remove test that I forgot in earlier commit.

  • platform/qt/Skipped:
13:23 Changeset [49109] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-10-05 Vadim Zeitlin <vadim@wxwidgets.org>

Added --wx-compiler-prefix waf option to allow building wxWebKit with
wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".

  • wx/build/settings.py:
  • wx/build/wxpresets.py:
13:06 Changeset [49108] by kdecker@apple.com
  • 3 edits in trunk/WebCore

Rubberstamped by Anders Carlsson.


  • WebCore.base.exp: Update export of HaltablePlugin/PluginHalterClient.
  • WebCore.xcodeproj/project.pbxproj: Likewise.
12:07 Changeset [49107] by eric@webkit.org
  • 8 edits
    15 deletes in trunk

2009-10-05 Eric Seidel <eric@webkit.org>

No review, rolling out r49104.
http://trac.webkit.org/changeset/49104

  • fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-number.html: Removed.
  • fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-range.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
  • fast/forms/input-minmax-expected.txt: Removed.
  • fast/forms/input-minmax.html: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
  • fast/forms/script-tests/input-minmax.js: Removed.

2009-10-05 Eric Seidel <eric@webkit.org>

No review, rolling out r49104.
http://trac.webkit.org/changeset/49104

  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • html/ValidityState.cpp:
  • html/ValidityState.h: (WebCore::ValidityState::rangeUnderflow): (WebCore::ValidityState::rangeOverflow):
  • rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): (WebCore::SliderRange::valueFromElement):
11:57 Changeset [49106] by kdecker@apple.com
  • 3 edits in trunk/WebKit/mac

Reviewed by Sam Weinig.

<rdar://problem/7273363> Plug-ins should use PluginHalter


  • Plugins/WebBaseNetscapePluginView.h: Add WebHaltablePlugin forward declare and _haltable ivar.
  • Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::WebHaltablePlugin): Added. (WebHaltablePlugin::halt): New method that stops a plug-in. (WebHaltablePlugin::restart): New method that starts a plug-in. (WebHaltablePlugin::node): Added. Provides the DOMNode corresponding to the plug-in in WebBaseNetscapePluginView. (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): Initialize new _haltable ivar. (-[WebBaseNetscapePluginView start]): Call the page's didStartPlugin() upon starting a plug-in. (-[WebBaseNetscapePluginView stop]): Call the page's didStopPlugin() upon stopping a plug-in.
11:23 Changeset [49105] by eric@webkit.org
  • 7 edits
    7 adds in trunk

2009-10-05 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Tests to check if validation-related CSS selectors are applied immediately.
https://bugs.webkit.org/show_bug.cgi?id=28868

  • fast/forms/input-live-pseudo-selectors-expected.txt: Added.
  • fast/forms/input-live-pseudo-selectors.html: Added.
  • fast/forms/resources/input-live-pseudo-selectors.js: Added.
  • fast/forms/resources/live-pseudo-selectors.css: Added.
  • fast/forms/resources/textarea-live-pseudo-selectors.js: Added.
  • fast/forms/textarea-live-pseudo-selectors-expected.txt: Added.
  • fast/forms/textarea-live-pseudo-selectors.html: Added.

2009-10-05 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Update style immediately when validation-related values are updated.
https://bugs.webkit.org/show_bug.cgi?id=28868

In order to apply :valid, :invalid, :optional or :required lively,

  • call setNeedsStyleRecalc() when properties which can change willValidate state are updated, and

(Parent form element, name, disabled, readonly)

  • call updateValidity() when properties which can change validity state are updated. (value, pattern, required)

Tests: fast/forms/input-live-pseudo-selectors.html

fast/forms/textarea-live-pseudo-selectors.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseMappedAttribute): (WebCore::HTMLFormControlElement::required): (WebCore::HTMLFormControlElement::updateValidity):
  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::setFileListFromRenderer):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
11:14 Changeset [49104] by eric@webkit.org
  • 8 edits
    15 adds in trunk

2009-10-05 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Implement min/max attributes, ValidityState.rangeUnderflow and
ValidityState.rangeOverflow for <input type=number> and <input type=range>
https://bugs.webkit.org/show_bug.cgi?id=29069

  • fast/forms/ValidityState-rangeOverflow-number-expected.txt: Added.
  • fast/forms/ValidityState-rangeOverflow-number.html: Added.
  • fast/forms/ValidityState-rangeOverflow-range-expected.txt: Added.
  • fast/forms/ValidityState-rangeOverflow-range.html: Added.
  • fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Added.
  • fast/forms/ValidityState-rangeUnderflow-number.html: Added.
  • fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Added.
  • fast/forms/ValidityState-rangeUnderflow-range.html: Added.
  • fast/forms/input-minmax-expected.txt: Added.
  • fast/forms/input-minmax.html: Added.
  • fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Added.
  • fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Added.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Added.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Added.
  • fast/forms/script-tests/input-minmax.js: Added.

2009-10-05 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Implement min/max attributes, ValidityState.rangeUnderflow and
ValidityState.rangeOverflow for <input type=number> and <input type=range>
https://bugs.webkit.org/show_bug.cgi?id=29069

Tests: fast/forms/ValidityState-rangeOverflow-number.html

fast/forms/ValidityState-rangeOverflow-range.html
fast/forms/ValidityState-rangeUnderflow-number.html
fast/forms/ValidityState-rangeUnderflow-range.html
fast/forms/input-minmax.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::rangeUnderflow): (WebCore::HTMLInputElement::rangeOverflow): (WebCore::HTMLInputElement::rangeMinimum): (WebCore::HTMLInputElement::rangeMaximum):
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • html/ValidityState.cpp: (WebCore::ValidityState::rangeUnderflow): (WebCore::ValidityState::rangeOverflow):
  • html/ValidityState.h:
  • rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): (WebCore::SliderRange::valueFromElement):
11:05 Changeset [49103] by eric@webkit.org
  • 13 edits
    2 adds in trunk

2009-10-05 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Tests for -webkit-appearance:list-button
https://bugs.webkit.org/show_bug.cgi?id=27794

  • platform/mac/fast/forms/input-list-button-size-expected.txt: Added.
  • platform/mac/fast/forms/input-list-button-size.html: Added.

2009-10-05 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Introduces

  • new CSS pseudo selector: "-webkit-input-list-button"
  • new CSS apperance type: "list-button"
  • new ControlPart value: "ListButtonPart"

for the UI of the list attribute of the input element, and adds
implementation to draw ListButtonPart on Mac.
The code is guarded by ENABLE(DATALIST).

https://bugs.webkit.org/show_bug.cgi?id=27794

Test: platform/mac/fast/forms/input-list-button-size.html

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • css/CSSValueKeywords.in:
  • css/html.css:
  • html/HTMLInputElement.cpp:
  • platform/ThemeTypes.h: (WebCore::):
  • platform/mac/ThemeMac.mm: (WebCore::listButtonSizes): (WebCore::button): (WebCore::paintButton): (WebCore::ThemeMac::controlSize): (WebCore::ThemeMac::minimumControlSize): (WebCore::ThemeMac::controlBorder): (WebCore::ThemeMac::paint):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect):
  • rendering/style/RenderStyleConstants.h: (WebCore::):
11:00 Changeset [49102] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Add documentation to the ErrorPageExtension.

  • Api/qwebpage.cpp:
10:39 Changeset [49101] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

2009-10-05 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.

Fixes <https://bugs.webkit.org/show_bug.cgi?id=30065>
nodeTitleInfo should be placed in ElementsTreeOutline.


Move nodeTitleInfo into ElementsTreeOutline.js from utilities.js.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateTitle): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
  • inspector/front-end/utilities.js:
10:36 Changeset [49100] by yael.aharon@nokia.com
  • 6 edits in trunk

[Qt] Inform the application when a new request is created
https://bugs.webkit.org/show_bug.cgi?id=29975

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

WebCore:

Emit a signal each time a request is created, with the request and the frame
that created it.

WebKit/qt:

Add a signal to QWebPage, to inform the application when a request is created.

10:30 Changeset [49099] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-05 Ben Murdoch <benm@google.com>

Reviewed by Darin Adler.

Add an ASSERT in updateGuidVersionMap.
https://bugs.webkit.org/show_bug.cgi?id=30077

  • storage/Database.cpp: (WebCore::updateGuidVersionMap): ASSERT that the guidMutex() is locked.
10:15 Changeset [49098] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2009-10-05 Nate Chapin <japhet@chromium.org>

Reviewed by Eric Seidel.

Allow V8 to throw an exception in _NPN_SetException without worrying about context
if we don't have enough information to find the correct context.

https://bugs.webkit.org/show_bug.cgi?id=30026

Part of the fix for Chromium's failure of LayouTests/plugins/netscape-throw-exception.html.

  • bindings/v8/NPV8Object.cpp: (_NPN_SetException): Don't suppress the exception if we can't find the relevant context.
09:03 Changeset [49097] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-10-01 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Place "Close" button in docked mode on the same side as the window "Close" button in detached mode.

https://bugs.webkit.org/show_bug.cgi?id=29961

  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded):
08:11 Changeset [49096] by kenneth@webkit.org
  • 3 edits in trunk/WebKit/qt

ErrorPageExtension: Add a pointer to the QWebFrame that had
an error.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Reviewed by Simon Hausmann.

  • Api/qwebpage.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::callErrorPageExtension):

08:01 Changeset [49095] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Do not empty the offline web appcache when clearing
memory caches. That one is not in memory, but stored
in sqlite.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Reviewed by Tor Arne Vestbø.

  • Api/qwebsettings.cpp:

(QWebSettings::clearMemoryCaches):

07:36 Changeset [49094] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Re-enable fast/table/008.html

07:08 Changeset [49093] by kenneth@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[Qt] Add expected files for passing fast/table tests.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-05
Reviewed by Ariya Hidayat.

  • platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.txt: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt: Added.
  • platform/qt/fast/table/fixed-table-with-small-percent-width-expected.txt: Added.
07:03 Changeset [49092] by hausmann@webkit.org
  • 6 edits in trunk

WebCore: [Qt] Added pure virtual QWebPageClient::pluginParent()

Patch by J-P Nurmi <jpnurmi@gmail.com> on 2009-10-05
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29710

  • platform/qt/QWebPageClient.h:

WebKit/qt: Added QGraphicsWidget-plugins support to FrameLoaderClientQt.

Patch by J-P Nurmi <jpnurmi@gmail.com> on 2009-10-05
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29710

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::pluginParent):

  • Api/qwebview.cpp:

(QWebViewPrivate::pluginParent):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::):
(WebCore::FrameLoaderClientQt::createPlugin):

07:03 Changeset [49091] by pfeldman@chromium.org
  • 19 edits
    2 adds in trunk

2009-10-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add testing harness for Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=30010

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

WebKit/win:

  • Interfaces/IWebInspectorPrivate.idl: Added.
  • Interfaces/IWebViewPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebInspector.cpp: (WebInspector::evaluateInFrontend):
  • WebInspector.h:
  • WebView.cpp: (WebView::inspectorPrivate):
  • WebView.h:

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp: (showWebInspectorCallback): (closeWebInspectorCallback): (evaluateInWebInspectorCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
06:25 Changeset [49090] by zoltan@webkit.org
  • 2 edits in trunk

2009-10-05 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Disable TCmalloc for Windows port at the present, because MinGW
hasn't got built-in pthread library.

  • WebKit.pri:
03:57 Changeset [49089] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-10-05 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Tor Arne Vestbø.

[Qt] windowsKeyCodeForKeyEvent() returns a wrong value for the F10 key.
https://bugs.webkit.org/show_bug.cgi?id=30042

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent):
03:48 Changeset [49088] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

Pass arguments to system() as a string instead of array

Reviewed by Ariya Hidayat.

When passed as an array entries with a space fail to translate
to two arguments to the child process, so instead of manually
splitting all the entries in @buildArgs we pass the whole thing
as a string instead.

  • Scripts/webkitdirs.pm:
02:31 Changeset [49087] by vestbo@webkit.org
  • 4 edits
    1 copy
    1 delete in trunk/WebCore

Move mediaControls extras for the Qt port into WebCore/css like other ports

https://bugs.webkit.org/show_bug.cgi?id=30013

Reviewed by Eric Carlson.

02:17 Changeset [49086] by ukai@chromium.org
  • 2 edits in trunk/WebCore

2009-10-05 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed build fix for ENABLE(WEB_SOCKETS) and v8.

V8ObjectEventListener.h has been removed at r48978

  • bindings/v8/custom/V8WebSocketCustom.cpp:
02:06 Changeset [49085] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector console stops working while JS in IFRAME is paused.

https://bugs.webkit.org/show_bug.cgi?id=29958

  • inspector/front-end/InjectedScript.js: (InjectedScript._evaluateOn): (InjectedScript.addInspectedNode): (InjectedScript._ensureCommandLineAPIInstalled):
01:56 Changeset [49084] by pfeldman@chromium.org
  • 13 edits in trunk/WebCore

2009-10-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Introduce inspected object groups for console
and watch evaluation results so that they could be released
explicitly.

https://bugs.webkit.org/show_bug.cgi?id=29891

  • bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::wrapObject):
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::wrapObject): (WebCore::InspectorBackend::releaseWrapperObjectGroup):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::wrapObject): (WebCore::InspectorController::unwrapObject): (WebCore::InspectorController::releaseWrapperObjectGroup):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addMessageToConsole):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.evalInInspectedWindow): (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed):
  • inspector/front-end/InjectedScript.js: (InjectedScript.evaluate): (InjectedScript._evaluateAndWrap): (InjectedScript.evaluateInCallFrame):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSection.prototype.update):
01:42 Changeset [49083] by vestbo@webkit.org
  • 4 edits
    1 move in trunk/WebCore

Rename WebCore/css/mediaControlsQT.css and MediaControllerThemeQT

https://bugs.webkit.org/show_bug.cgi?id=30013

Reviewed by Eric Carlson.

The QT suffix has been expanded to QuickTime, to not cause confusion
and name-crashes with similar files in the Qt port.

10/04/09:

22:27 Changeset [49082] by bweinstein@apple.com
  • 7 edits
    1 add in trunk/WebCore

2009-10-04 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.


Fixes <https://bugs.webkit.org/show_bug.cgi?id=30064>
Syntax Highlighting CSS shouldn't be duplicated.

Refactor syntax highlighting CSS into a new file, add it to the
projects, and have SourceFrame.js and inspector.html include the
new CSS file.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspectorSyntaxHighlight.css: Added.
  • inspector/front-end/WebKit.qrc:
21:16 Changeset [49081] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

2009-10-04 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.


Fixes <https://bugs.webkit.org/show_bug.cgi?id=30062>
Inspector should syntax highlight JS/CSS in elements view.

Add syntax highlighting of CSS and JavaScript tags to the elements panel.
Copied CSS rules from SourceFrame.js to inspector.css, and have the text nodes
in utilities.js call the CSS or JS Syntax highlighters if their parent is a script
or style tag.

  • inspector/front-end/inspector.css:
  • inspector/front-end/utilities.js:
19:52 Changeset [49080] by ukai@chromium.org
  • 4 edits in trunk

2009-10-04 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel

Enable Web Sockets in chromium build.
https://bugs.webkit.org/show_bug.cgi?id=29917

  • WebCore.gyp/WebCore.gyp:

2009-10-04 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel

Enable Web Sockets in chromium build.
https://bugs.webkit.org/show_bug.cgi?id=29917

  • chromium/features.gypi:
16:43 Changeset [49079] by kdecker@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Cameron Zwarich.

  • WebView/WebPreferenceKeysPrivate.h: Added new key.
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Leave plug-in halting disabled by default. (-[WebPreferences pluginHalterEnabled]): Added. (-[WebPreferences setPluginHalterEnabled:]): Ditto.
  • WebView/WebPreferencesPrivate.h: Added above new methods.
14:12 Changeset [49078] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-10-04 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Levin.

check-webkit-style misses whitespace errors for operators:

<<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&,
.

https://bugs.webkit.org/show_bug.cgi?id=30021

  • Scripts/modules/cpp_style.py: Added the operators mentioned above to the same list as == and !=.
13:01 Changeset [49077] by xan@webkit.org
  • 5 edits
    4 adds in trunk

WebCore:

2009-10-01 Xan Lopez <xlopez@igalia.com>

Reviewed by NOBODY (OOPS!).

[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761

Update the HTTP method in the request stored by willSendRequest
after a redirect, since it could have changed.

Test: http/tests/navigation/postredirect-reload.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):

LayoutTests:

2009-10-01 Xan Lopez <xlopez@igalia.com>

Reviewed by NOBODY (OOPS!).

[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761

New test that checks that a reload after a redirect to a page with
a GET method from one with a POST method will use GET and not
POST.

  • http/tests/navigation/postredirect-reload-expected.txt: Added.
  • http/tests/navigation/postredirect-reload.html: Added.
  • http/tests/navigation/resources/postresult.pl:
  • http/tests/navigation/resources/reloadresult.pl: Added.
  • http/tests/navigation/resources/redirect-reload.html: Added.
  • http/tests/navigation/resources/success200.html:
  • http/tests/navigation/resources/testcode.js: (submitFormWithPostRedirectReload): (runRedirectReloadTest):
11:14 Changeset [49076] by xan@webkit.org
  • 6 edits
    3 deletes in trunk

Revert previous patch, as the newly added test breaks other tests.

10:17 Changeset [49075] by xan@webkit.org
  • 6 edits
    3 adds in trunk

WebCore:

2009-10-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761

Update the HTTP method in the request stored by willSendRequest
after a redirect, since it could have changed.

Test: http/tests/navigation/postredirect-reload.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):

LayoutTests:

2009-10-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761

New test that checks that a reload after a redirect to a page with
a GET method from one with a POST method will use GET and not
POST.

  • http/tests/navigation/postredirect-reload-expected.txt: Added.
  • http/tests/navigation/postredirect-reload.html: Added.
  • http/tests/navigation/resources/postresult.pl:
  • http/tests/navigation/resources/reloadresult.pl: Added.
  • http/tests/navigation/resources/success200.html:
  • http/tests/navigation/resources/testcode.js: (submitFormWithPostRedirectReload): (runRedirectReloadTest):
10:12 Changeset [49074] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-10-04 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Fixed Function leak in V8LazyEventListener.
(Should fix the remaning leak in
https://bugs.webkit.org/show_bug.cgi?id=29093).
V8LazyEventListeners used to create FunctionTemplates for each
wrapped listener which in turn created Functions that were cached
forever in V8 Context. Now there is at most one such Function per
Context.
https://bugs.webkit.org/show_bug.cgi?id=30060

Added new hidden property name to store toString result:

  • bindings/v8/V8HiddenPropertyName.cpp:
  • bindings/v8/V8HiddenPropertyName.h:

Switched to static FunctionTemplate:

  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListenerToString): (WebCore::V8LazyEventListener::prepareListenerObject):
Note: See TracTimeline for information about the timeline view.