Timeline



Oct 11, 2009:

11:50 PM Changeset in webkit [49434] by dbates@webkit.org
  • 5 edits
    6 adds in trunk

2009-10-11 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=30242


Fixes an issue where JavaScript URLs that are URL-encoded twice can
bypass the XSSAuditor.


JavaScript URLs that are completed by method Document::completeURL have added
URL-encoded characters such that a direct comparison with the URL-decoded
outgoing HTTP parameters is not sufficient. Instead, the URL-decoded outgoing
HTTP parameters must be URL-decoded before comparison.

Tests: http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html

http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL): Modified to pass XSSAuditor the URL-decoded source code for the JavaScript URL.
  • page/XSSAuditor.cpp: (WebCore::isIllegalURICharacter): Minor syntactical change to the comment. (WebCore::XSSAuditor::CachingURLCanonicalizer::canonicalizeURL): Added parameter decodeURLEscapeSequencesTwice. (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::decodeURL): Ditto. (WebCore::XSSAuditor::findInRequest): Ditto.
  • page/XSSAuditor.h: (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer): Ditto.

2009-10-11 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=30242


Tests that JavaScript URLs that are twice URL encoded do not bypass the XSSAuditor.

  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html: Added.
9:17 PM Changeset in webkit [49433] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebKit/mac: <rdar://problem/7294267> REGRESSION (r48492): Gmail voice and video chat
doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30295

Reviewed by Darin Adler.

Test: plugins/setProperty.html

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::setFieldValue): Fixed a typo. The function
should return early if m_instanceProxy is null.

LayoutTests: Test for <rdar://problem/7294267> REGRESSION (r48492): Gmail voice and
video chat doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30295

Reviewed by Darin Adler.

  • plugins/setProperty-expected.txt: Added.
  • plugins/setProperty.html: Added.
8:30 PM Changeset in webkit [49432] by eric@webkit.org
  • 7 edits in trunk/WebCore

2009-10-11 Dominic Cooney <dominicc@google.com>

Reviewed by Adam Barth.

Fixes a build break in the V8 bindings caused by revision 49420.
https://bugs.webkit.org/show_bug.cgi?id=30294

Revision 49420 introduces an IDL-defined CanvasActiveInfo
type. This causes a build break in the V8 bindings where
CanvasGraphicsContext3D naively refers to CanvasActiveInfo as a
non-ref type.

  • WebCore.gypi: Include CanvasActiveInfo.idl in build.
  • bindings/scripts/CodeGeneratorV8.pm: CanvasActiveInfo is a ref ptr type.
  • bindings/v8/DOMObjectsInclude.h: Include generated CanvasActiveInfo files.
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
8:15 PM Changeset in webkit [49431] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-11 Collin Jackson <collinj@webkit.org>

Reviewed by Adam Barth.

Log mixed content warnings to console

https://bugs.webkit.org/show_bug.cgi?id=30290

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent):
7:53 PM Changeset in webkit [49430] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-11 Adam Barth <abarth@webkit.org>

Unreviewed. Add Collin to committers.py.

  • Scripts/modules/committers.py:
7:36 PM QtBackLog edited by zecke@selfish.org
(diff)
3:48 PM Changeset in webkit [49429] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-11 Søren Gjesse <sgjesse@chromium.org>

Reviewed by Adam Barth.

[V8] Add a context scope in JS listener destructor. The destructor code uses the cotext. See http://crbug.com/24200.
https://bugs.webkit.org/show_bug.cgi?id=30250

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
3:34 PM Changeset in webkit [49428] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-11 Lyon Chen <lyon.chen@torchmobile.com>

Reviewed by Alexey Proskuryakov.

Correct the position of #endif sentence inside WebCore::Document::finishedParsing().

https://bugs.webkit.org/show_bug.cgi?id=30244

This change requires no test case as it fix a compiling error.

  • dom/Document.cpp: (WebCore::Document::finishedParsing):
3:17 PM Changeset in webkit [49427] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-11 Dominic Cooney <dominicc@google.com>

Reviewed by Adam Barth.

Sets a 500K stack limit for JavaScript workers in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=29797

Runaway recursion in JavaScript workers crashes the Chromium
worker process on OS X. This is because V8's default stack limit
is 512K on ia32 or 1M on x64, but the worker process runs workers
on a thread with the OS X default stack size--512K. Because there
are already some C++ frames on the stack when V8 establishes its
512K default stack limit, and V8 doesn't precisely enforce the
stack limit, runaway recursion in V8 workers overflows the OS
stack and segfaults, killing the worker process. This is described
in Chromium bug 21653 <http://crbug.com/21653>.

This patch sets the V8 stack limit for worker JavaScript in
Chromium to a more conservative 500K on all platforms. This allows
some "headroom" for the C++ stack in use when the limit is set up,
and some "legroom" for the V8 helper functions which in practice
briefly flout the V8 stack limit.

Test: LayoutTests/fast/workers/use-machine-stack.html

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
  • bindings/v8/WorkerContextExecutionProxy.h:
2:30 PM Changeset in webkit [49426] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Re-enable the JIT.

1:01 PM Changeset in webkit [49425] by kevino@webkit.org
  • 4 edits in trunk

wx build fixes, adding bindings to include/source dirs and fixing wxMac 2.9 compilation.

2:46 AM Changeset in webkit [49424] by cam@webkit.org
  • 10 edits
    3 adds in trunk

Allow [Reflect] on SVG elements.
https://bugs.webkit.org/show_bug.cgi?id=28936

Reviewed by Sam Weinig.

Update the JS binding generators to reference SVGNames instead of
HTMLNames, if [Reflect]ing an attribute on an SVG element. Make
SVGElement::id use [Reflect].

Also make [Reflect] on an attribute with a setter exception work in ObjC
bindings.

WebCore:

Test: svg/dom/id-reflect.html

  • bindings/scripts/CodeGenerator.pm: Add a function to determine the

appropriate C++ namespace for attribute name constants.

  • bindings/scripts/CodeGeneratorObjC.pm: Generate ExceptionCode handling

code for [Reflect] on an attribute with a setter exception.

  • bindings/scripts/CodeGeneratorCOM.pm: Generate "SVGNames" instead of

"HTMLNames" when appropriate.

  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • svg/SVGElement.cpp: Remove getter and setter methods for id.
  • svg/SVGElement.h: Ditto.
  • svg/SVGElement.idl: Add [Reflect] to id.

LayoutTests:

  • svg/dom/script-tests/id-reflect.js: Added.
  • svg/dom/id-reflect-expected.txt: Added.
  • svg/dom/id-reflect.html: Added.

Oct 10, 2009:

8:47 PM Changeset in webkit [49423] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Support for String.trim(), String.trimLeft() and String.trimRight() methods
https://bugs.webkit.org/show_bug.cgi?id=26590

Reviewed by Maciej Stachowiak.

Implement trim, trimLeft, and trimRight

3:10 PM Changeset in webkit [49422] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

REGRESSION (r49414): Rebaseline needed for Windows / Gtk Linux
https://bugs.webkit.org/show_bug.cgi?id=30279

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-10
Reviewed by Eric Seidel.

  • platform/gtk/editing/style/5228141-expected.txt: Same rebaseline done for Mac in r49414
  • platform/win/editing/execCommand/toggle-compound-styles-expected.txt: two i tags are merged properly
2:46 PM Changeset in webkit [49421] by oliver@apple.com
  • 2 edits in trunk/WebCore

Fix paths in xcode.

2:16 PM Changeset in webkit [49420] by oliver@apple.com
  • 10 edits
    2 copies
    8 adds in trunk

Implement getActiveAttrib and getActiveUniform
https://bugs.webkit.org/show_bug.cgi?id=30276

Reviewed by Eric Carlson.

Implements the getActiveAttrib and getActiveUniform APIs.
Rather simple patch, adds CanvasActiveInfo definition and implementation
and adds forwarding to the GraphicsContext3D.

Test: fast/canvas/webgl/getActiveTest.html

12:21 PM Changeset in webkit [49419] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Adding new attributes in Element Panel is
counterintuitive.

https://bugs.webkit.org/show_bug.cgi?id=30057

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmousemove): (WebInspector.ElementsTreeElement.prototype.set hovered): (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton):
9:19 AM Changeset in webkit [49418] by Laszlo Gombos
  • 4 edits in trunk/WebCore

2009-10-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

Build fix if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=30275

In addition to fixing the build break with guards
remove notImplemented() from PluginViewNone.cpp and
make them just just be empty functions.

  • plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): (WebCore::PluginView::PluginView):
  • plugins/PluginView.h:
  • plugins/PluginViewNone.cpp: (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::paint): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::handlePostReadFile): (WebCore::PluginView::getValue): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::invalidateRect): (WebCore::PluginView::invalidateRegion): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy): (WebCore::PluginView::setParentVisible): (WebCore::PluginView::updatePluginWidget):
8:56 AM Changeset in webkit [49417] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2009-10-10 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Build fix for QtWebKit after r49415.

Add HistoryController.cpp to the build.

  • WebCore.pro:
6:53 AM Changeset in webkit [49416] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-10-09 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

[Chromium] KURLGoogle's protocolIs barfs on input containing hyphens
https://bugs.webkit.org/show_bug.cgi?id=30262

This is not testable from WebKit since WebKit never uses the member
function form of protocolIs with input that can be controlled from a
web page. It always passes string literals lacking hyphens.

  • platform/KURLGoogle.cpp: (WebCore::lowerCaseEqualsASCII): Only assert if toASCIILower would transform the input character.
3:04 AM BuildingQtOnWindows edited by robert@roberthogan.net
(diff)
2:11 AM Changeset in webkit [49415] by abarth@webkit.org
  • 8 edits
    2 adds in trunk/WebCore

2009-10-10 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

Move HistoryController to its own file
https://bugs.webkit.org/show_bug.cgi?id=30272

Purely mechanical.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/HistoryController.cpp: Added.
  • loader/HistoryController.h: Added.

Oct 9, 2009:

8:36 PM Changeset in webkit [49414] by rniwa@webkit.org
  • 10 edits
    3 adds in trunk

ApplyStyleCommand removes presentational tags even when not necessary
https://bugs.webkit.org/show_bug.cgi?id=28091

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-09
Reviewed by Eric Seidel.

WebCore:

This patch updates implicitlyStyledElementShouldBeRemovedWhenApplyingStyle to return true
(triggering removal of tag) only if the style implicitly added by the element is not present in
the new style to apply. It also changes surroundNodeRangeWithElement so that it merges the
surrounding element when possible. applyTextDecorationStyle is modified so that it does not add
style span when the style attribute is empty.

Test: editing/execCommand/toggle-style-3.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::shouldRemoveTextDecorationTag): Returns true if specified text
decoration is not present in the style to apply
(WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): No longer
returns true if the tag is used in new style
(WebCore::ApplyStyleCommand::applyTextDecorationStyle): Does not add style-span when redundant
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Merges the newly created element
with the surrounding identical elements

  • editing/ApplyStyleCommand.h:

LayoutTests:

This patch adds test to make sure to preserve presentational tag
(u, s, strike, i, em, sup, sub, b, & strong) when the corresponding style is present in
the final computed style. i.e. avoid removing tag and re-applying the style later

  • editing/execCommand/19653-2-expected.txt: Two b elements are merged.
  • editing/execCommand/createLink-expected.txt: Two anchor elements are merged.
  • editing/execCommand/script-tests/toggle-style-3.js: Added.

(testSingleToggle):

  • editing/execCommand/strikethroughSelection-expected.txt: Redundant style spans are no longer added.
  • editing/execCommand/toggle-style-3-expected.txt: Added.
  • editing/execCommand/toggle-style-3.html: Added.
  • editing/execCommand/unlink-expected.txt: Two anchor elements are merged.
  • platform/mac/editing/style/5228141-expected.txt: Two b elements are merged.
  • platform/mac/editing/style/style-boundary-001-expected.txt: Two b elements are merged.
7:27 PM Changeset in webkit [49413] by abarth@webkit.org
  • 10 edits in trunk

2009-10-09 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor HistoryController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30246

Update API call.

  • WebView.cpp: (WebView::loadBackForwardListFromOtherView):

2009-10-09 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor HistoryController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30246

Update API call.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::restoreViewState):
  • WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]):

2009-10-09 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor HistoryController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30246

HistoryController is in charge of managing the current / previous /
provisional HistoryItems. The split isn't perfect, but it's a place to
start. I'll move HistoryController into its own file in another patch.

  • WebCore.base.exp:
  • loader/FrameLoader.cpp: (WebCore::HistoryController::HistoryController): (WebCore::HistoryController::~HistoryController): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::closeURL): (WebCore::FrameLoader::begin): (WebCore::HistoryController::restoreDocumentState): (WebCore::HistoryController::setCurrentItem): (WebCore::HistoryController::setProvisionalItem): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::scrollToAnchor): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::didFirstLayout): (WebCore::HistoryController::updateForFrameLoadCompleted): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::HistoryController::addHistoryItemForFragmentScroll): (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): (WebCore::HistoryController::createHistoryItem): (WebCore::FrameLoader::checkDidPerformFirstNavigation): (WebCore::HistoryController::addBackForwardItemClippedAtTarget): (WebCore::HistoryController::createHistoryItemTree): (WebCore::HistoryController::saveScrollPositionAndViewStateToItem): (WebCore::HistoryController::restoreScrollPositionAndViewState): (WebCore::HistoryController::invalidateCurrentItemCachedPage): (WebCore::HistoryController::saveDocumentState): (WebCore::FrameLoader::loadItem): (WebCore::HistoryController::urlsMatchItem): (WebCore::HistoryController::goToItem): (WebCore::HistoryController::recursiveGoToItem): (WebCore::HistoryController::childFramesMatchItem): (WebCore::HistoryController::updateForStandardLoad): (WebCore::HistoryController::updateForClientRedirect): (WebCore::HistoryController::updateForBackForwardNavigation): (WebCore::HistoryController::updateForReload): (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): (WebCore::HistoryController::updateForCommit): (WebCore::HistoryController::updateForAnchorScroll): (WebCore::HistoryController::saveDocumentAndScrollState): (WebCore::HistoryController::setCurrentItemTitle): (WebCore::FrameLoader::didChangeTitle):
  • loader/FrameLoader.h: (WebCore::HistoryController::current): (WebCore::HistoryController::provisional): (WebCore::FrameLoader::policyChecker): (WebCore::FrameLoader::history): (WebCore::FrameLoader::creatingInitialEmptyDocument):
  • page/Page.cpp: (WebCore::Page::goToItem):
5:53 PM Changeset in webkit [49412] by bweinstein@apple.com
  • 2 edits in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore

Try to fix Windows build by adding needed exports.

5:46 PM Changeset in webkit [49411] by mrowe@apple.com
  • 5 edits in trunk

WebKit/mac: <rdar://problem/7290671> Crash after navigating away from a page with subframe containing plug-in

Reviewed by Brady Eidson.

At the time that -stop is called on a WebBaseNetscapePluginView that is contained within a subframe
the WebFrame's data source has been zeroed out. This was causing -[WebBaseNetscapePluginView webFrame]
to return nil during -stop, preventing the plug-in view from unregistering itself from the PluginHalter.
We fix this by having -webFrame retrieve the frame directly rather than retrieving it from the data source.

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView dataSource]): Get the data source from the WebFrame.
(-[WebBaseNetscapePluginView webFrame]): Get the Frame directly from the element's document rather
than taking a windy route through the WebDataSource.

WebKitTools: Enable plug-in halting in DumpRenderTree.

We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:shouldHaltPlugin:]):

5:38 PM Changeset in webkit [49410] by ap@apple.com
  • 2 edits in trunk/WebCore

Unreviewed - fixing an obvious typo in my previous check-in.

https://bugs.webkit.org/show_bug.cgi?id=30260
<rdar://problem/6447115> REGRESSION: Logging out from SAP doesn't work

Fixes existing tests (which I thought I had run the previous time).

  • platform/network/CredentialStorage.cpp: (WebCore::originsWithCredentials): Return the set by reference.
5:30 PM Changeset in webkit [49409] by ggaren@apple.com
  • 10 edits in trunk/JavaScriptCore

Eliminated some legacy bytecode weirdness.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-09
Reviewed by Oliver Hunt.

Use vPC[x] subscripting instead of ++vPC to access instruction operands.
This is simpler, and often more efficient.

To support this, and to remove use of hard-coded offsets in bytecode and
JIT code generation and dumping, calculate jump offsets from the beginning
of an instruction, rather than the middle or end.

Also, use OPCODE_LENGTH instead of hard-coded constants for the sizes of
opcodes.

SunSpider reports no change in JIT mode, and a 1.01x speedup in Interpreter
mode.

  • bytecode/CodeBlock.cpp:

(JSC::printConditionalJump):
(JSC::CodeBlock::dump):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitJump):
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
(JSC::BytecodeGenerator::emitComplexJumpScopes):
(JSC::BytecodeGenerator::emitJumpScopes):
(JSC::BytecodeGenerator::emitNextPropertyName):
(JSC::BytecodeGenerator::emitCatch):
(JSC::BytecodeGenerator::emitJumpSubroutine):
(JSC::prepareJumpTableForImmediateSwitch):
(JSC::prepareJumpTableForCharacterSwitch):
(JSC::prepareJumpTableForStringSwitch):
(JSC::BytecodeGenerator::endSwitch):

  • bytecompiler/Label.h:

(JSC::Label::setLocation):
(JSC::Label::bind):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveBase):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::Interpreter::createExceptionScope):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:
  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emitBinaryDoubleOp):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_loop):
(JSC::JIT::emit_op_loop_if_less):
(JSC::JIT::emitSlow_op_loop_if_less):
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emitSlow_op_loop_if_lesseq):
(JSC::JIT::emit_op_loop_if_true):
(JSC::JIT::emitSlow_op_loop_if_true):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_jmp_scopes):

4:28 PM Changeset in webkit [49408] by levin@chromium.org
  • 3 edits in trunk/WebCore

[v8] Need change to V8WorkerContextEventListener::reportError signature to match the base class.
https://bugs.webkit.org/show_bug.cgi?id=30264

Patch by David Levin <levin@chromium.org> on 2009-10-09
Reviewed by Eric Seidel.

The base class method changed in r48884.

Test: fast/worker/worker-script-error.html

  • bindings/v8/V8WorkerContextEventListener.cpp:

(WebCore::V8WorkerContextEventListener::reportError):

  • bindings/v8/V8WorkerContextEventListener.h:
3:45 PM Changeset in webkit [49407] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix bad ChangeLog entry merge in r49019 by the commit queue script.

3:29 PM Changeset in webkit [49406] by ap@apple.com
  • 6 edits
    10 adds in trunk

Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=30260
<rdar://problem/6447115> REGRESSION: Logging out from SAP doesn't work

Tests: http/tests/xmlhttprequest/logout.html

http/tests/xmlhttprequest/re-login-async.html
http/tests/xmlhttprequest/re-login.html

Fix several issues with existing credential handling code.

  • platform/network/CredentialStorage.cpp: (WebCore::pathToDefaultProtectionSpaceMap): Changed the data structure to a simpler one. (WebCore::originsWithCredentials): The reason for two-stage lookup above was that we didn't want to iterate paths for origins that never had credentials associated with them. Changed to use a separate HashSet for this. (WebCore::pathToDefaultProtectionSpaceMap): The concept of default per-path credentials didn't match the spec very well. UAs are supposed to deduce protection space from an URL, and then use whichever credentials are known for this protection space. So, OriginToDefaultBasicCredentialMap is now PathToDefaultProtectionSpaceMap. (WebCore::protectionSpaceMapKeyFromURL): Factored out a helper that extracts a directory URL from a given URL. These directory URLs are what we use as keys in PathToDefaultProtectionSpaceMap. (WebCore::CredentialStorage::set): Updated for above changes. (WebCore::findDefaultProtectionSpaceForURL): Factored out code iterating path length to find a prefix in OriginToDefaultBasicCredentialMap. (WebCore::CredentialStorage::set): Another version of set() can update credentials for a URL default protection space. It does nothing if the given URL doesn't correspond to a known protection space. (WebCore::CredentialStorage::get): Renamed from getDefaultAuthenticationCredential.
  • platform/network/CredentialStorage.h: Made the distinction between methods that use a known protection space and those that deduce one from URL more clear.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Update credentials before starting the request for real. This makes the following pattern work: var req = new XMLHttpRequest("GET", "logout.html", "logout", "logout"); wrong credentials req.send(""); req.abort(); Abort() is used here to avoid having UA present an auth dialog after getting a 401 response. Note that one cannot log in using the same method, because there isn't a known protection space for the URL yet in that case, so the added code has no effect. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Use a correct persistence for calling receivedCredential(). This fixes logging in using an async XHR (withut abort(), of course), and matches sync case. (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Renamed getDefaultAuthenticationCredential() to get().
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start): (WebCore::WebCoreSynchronousLoader::load): Same changes as in Mac code.
3:01 PM Changeset in webkit [49405] by eric@webkit.org
  • 14 edits
    4 adds in trunk

2009-10-09 Enrica Casucci <enrica@apple.com>

Reviewed by Adele Peterson.

Undoing a indent removes text instead of it's formatting.
<rdar://problem/7169206>
https://bugs.webkit.org/show_bug.cgi?id=28722
Added test case for https://bugs.webkit.org/show_bug.cgi?id=23995

  • editing/execCommand/19653-1-expected.txt: Re-baselined.
  • editing/execCommand/indent-div-inside-list-expected.txt: Re-baselined.
  • editing/execCommand/indent-nested-blockquotes-expected.txt: Re-baselined.
  • editing/execCommand/indent-nested-div-expected.txt: Re-baselined.
  • editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Re-baselined.
  • editing/execCommand/indent-with-style-expected.txt: Added.
  • editing/execCommand/indent-with-style.html: Added.
  • editing/undo/undo-indent-expected.txt: Added.
  • editing/undo/undo-indent.html: Added.
  • platform/mac/editing/execCommand/4641880-2-expected.txt: Re-baselined.
  • platform/mac/editing/execCommand/4916541-expected.txt: Re-baselined.
  • platform/mac/editing/execCommand/5138441-expected.txt: Re-baselined.
  • platform/mac/editing/execCommand/5481523-expected.txt: Re-baselined.
  • platform/mac/editing/execCommand/indent-selection-expected.txt: Re-baselined.

2009-10-09 Enrica Casucci <enrica@apple.com>

Reviewed by Adele Peterson.

Undoing a indent removes text instead of it's formatting.
<rdar://problem/7169206>
https://bugs.webkit.org/show_bug.cgi?id=28722
Restored the behavior prior to http://trac.webkit.org/changeset/46143. This change implemented the
indent command making simple DOM operation, without using moveParagraph which cause undo to be broken.

Added editing/undo/undo-indent.html test.

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Restored. (WebCore::IndentOutdentCommand::tryIndentingAsListItem): Merged changes. (WebCore::IndentOutdentCommand::indentIntoBlockquote): Restored. (WebCore::IndentOutdentCommand::indentRegion): Restored and added call to updateLayout to ensure TextIterator could correctly calculate the position starting from the index.
  • editing/IndentOutdentCommand.h: Restored.
2:24 PM Changeset in webkit [49404] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-10-09 Rimas Kudelis <rq@akl.lt>

Rubber-stamped by Gustavo Noronha

https://bugs.webkit.org/show_bug.cgi?id=30054
Localization of WebKit GTK into Lithuanian

  • lt.po: Added.
2:24 PM Changeset in webkit [49403] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-09 Jens Alfke <snej@chromium.org>

Reviewed by Darin Adler.

Optimization: Many StringImpl transformations are no-ops and should just return 'this'
https://bugs.webkit.org/show_bug.cgi?id=30186

Optimized StringImpl methods lower(), stripWhiteSpace() and simplifyWhiteSpace() to
detect no-ops and return this instead of creating a new instance.
Empirical testing shows that the majority of calls to these methods are no-ops, making
this worthwhile even if (in the case of lower()) the non-no-op case is slightly slowed.
Upper() is very rarely a no-op, so it wasn't worthwhile to optimize it.

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): Just add a comment explaining why this wasn't optimized (WebCore::StringImpl::stripWhiteSpace): (WebCore::StringImpl::simplifyWhiteSpace):
1:51 PM Changeset in webkit [49402] by krit@webkit.org
  • 6 edits
    4 adds in trunk

2009-10-09 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

SVG Filter feGaussianBlur implementation is missing
https://bugs.webkit.org/show_bug.cgi?id=28141

This is the implementation of GaussianBlur filter for SVG.

There is already a test for feGaussianBlur
Test: svg/W3C-SVG-1.1/filters-gauss-01-b-w3c.svg

Test: svg/filters/feGaussianBlur.svg

  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect):
  • platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::isAlphaImage): (WebCore::FilterEffect::setIsAlphaImage):
  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::apply):
  • svg/graphics/filters/SVGFEGaussianBlur.cpp: (WebCore::boxBlur): (WebCore::FEGaussianBlur::apply):

Test for feGaussianBlur implementation

  • platform/mac/svg/filters/feGaussianBlur-expected.checksum: Added.
  • platform/mac/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/mac/svg/filters/feGaussianBlur-expected.txt: Added.
  • svg/filters/feGaussianBlur.svg: Added.
12:37 PM Changeset in webkit [49401] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-10-09 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] QoS support in the video sink
https://bugs.webkit.org/show_bug.cgi?id=29959

Removed the async buffer queue from the sink. Synchronize the
render method of the sink using a g_timeout_add() combined with a
gcond triggered when the buffer has been rendered.
Also fixed the video sink reference handling in the player, now
that the idle is not there anymore to mess up things.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_init): (webkit_video_sink_timeout_func): (webkit_video_sink_render): (webkit_video_sink_dispose): (unlock_buffer_mutex): (webkit_video_sink_unlock): (webkit_video_sink_stop): (webkit_video_sink_class_init):
12:13 PM Changeset in webkit [49400] by krit@webkit.org
  • 19 edits
    6 adds in trunk

2009-10-08 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

feMorphology filter is not implemented
https://bugs.webkit.org/show_bug.cgi?id=5863

Adds SVGFEMorphologyElement, for the SVG filter. It also fixes a bug
with the attribute "operator". It was only accessible via "_operator"
on JavaScript.

Test: svg/dom/operatorAttribute.xhtml

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.SVG.Filters.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap):
  • bindings/objc/DOMSVG.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • page/DOMWindow.idl:
  • svg/SVGAllInOne.cpp:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEMorphologyElement.cpp: Added. (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement): (WebCore::SVGFEMorphologyElement::~SVGFEMorphologyElement): (WebCore::SVGFEMorphologyElement::setRadius): (WebCore::SVGFEMorphologyElement::parseMappedAttribute): (WebCore::SVGFEMorphologyElement::build):
  • svg/SVGFEMorphologyElement.h: Added.
  • svg/SVGFEMorphologyElement.idl: Added.
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::operator<<):
  • svg/graphics/filters/SVGFEMorphology.h: (WebCore::):
  • svg/svgtags.in:

Reviewed by Nikolas Zimmermann.

Attribute "operator" schould only be accessible by "operator", not by "_operator"

  • svg/dom/operatorAttribute-expected.txt: Added.
  • svg/dom/operatorAttribute.html: Added.
  • svg/dom/script-tests/operatorAttribute.js: Added.
12:12 PM Changeset in webkit [49399] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Dimitri Glazkov.

Fix Chromium breakage.

https://bugs.webkit.org/show_bug.cgi?id=30104

  • inspector/front-end/inspector.js: (WebInspector.addCookieDomain): check that Storage panel is present before calling its methods.
11:14 AM Changeset in webkit [49398] by ggaren@apple.com
  • 9 edits in trunk/JavaScriptCore

Migrated some code that didn't belong out of Structure.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-09
Reviewed by Sam Weinig.

SunSpider says maybe 1.03x faster.

  • runtime/JSCell.h: Nixed Structure::markAggregate, and made marking of

a Structure's prototype the direct responsility of the object using it.
(Giving Structure a mark function was misleading because it implied that
all live structures get marked during GC, when they don't.)

  • runtime/JSGlobalObject.cpp:

(JSC::markIfNeeded):
(JSC::JSGlobalObject::markChildren): Added code to mark prototypes stored
on the global object. Maybe this wasn't necessary, but now we don't have
to wonder.

  • runtime/JSObject.cpp:

(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::getEnumerableNamesFromClassInfoTable):

  • runtime/JSObject.h:

(JSC::JSObject::markChildrenDirect):

  • runtime/PropertyNameArray.h:
  • runtime/Structure.cpp:
  • runtime/Structure.h:

(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache): Moved property name gathering code
from Structure to JSObject because having a Structure iterate its JSObject
was a layering violation. A JSObject is implemented using a Structure; not
the other way around.

10:31 AM Changeset in webkit [49397] by Laszlo Gombos
  • 7 edits in trunk

2009-10-09 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

Sets Qt::WA_InputMethodEnabled and Qt::ImhHiddenText for password fields in EditorClientQt
setInputMethodState. This change is needed so widgets such as the s60 software
input panel can receive input method events for password fields.
It's up to the Qt platform to determine which widget will receive input method
events when these flags are set.
Also added implementation for setInputMethodEnabled and setInputMethodHint
to QGraphicsWebViewPrivate and QWebViewPrivate. This change removes the direct
dependency on QWebView and uses QWebPageClient.
Added autotest to tst_qwebpage.cpp

https://bugs.webkit.org/show_bug.cgi?id=30023

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::setInputMethodEnabled): (QGraphicsWebViewPrivate::setInputMethodHint):
  • Api/qwebview.cpp: (QWebViewPrivate::setInputMethodEnabled): (QWebViewPrivate::setInputMethodHint):
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):

2009-10-09 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Added pure virtual methods setInputMethodEnabled and setInputMethodHint to QWebPageClient

https://bugs.webkit.org/show_bug.cgi?id=30023

  • platform/qt/QWebPageClient.h:
10:26 AM Changeset in webkit [49396] by darin@apple.com
  • 1 edit
    3 moves in trunk/LayoutTests

Requested by Mark Rowe.

Patch by Darin Adler <darin@apple.com> on 2009-10-09
Moved DOM test that was in fast/js to fast/dom where it belongs.

  • fast/dom/Document/invalid-domain-change-throws-exception-expected.txt:

Copied from fast/js/invalid-domain-change-throws-exception-expected.txt.

  • fast/dom/Document/invalid-domain-change-throws-exception.html:

Copied from fast/js/invalid-domain-change-throws-exception.html.
Regenerated with the make-script-test-wrappers.

  • fast/dom/Document/script-tests/invalid-domain-change-throws-exception.js:

Copied from fast/js/resources/invalid-domain-change-throws-exception.js.

  • fast/js/invalid-domain-change-throws-exception-expected.txt: Removed.
  • fast/js/invalid-domain-change-throws-exception.html: Removed.
  • fast/js/resources/invalid-domain-change-throws-exception.js: Removed.
10:20 AM Changeset in webkit [49395] by hyatt@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog patch reviewer to be accurate.

10:03 AM Changeset in webkit [49394] by hyatt@apple.com
  • 11 edits
    2 adds in trunk

Implement beforeload for images. ImageLoadEventSender has been refactored into a more generic
ImageEventSender that can be used by both load and beforeload events. If the document has any
beforeload listeners, then the installation of images onto the renderer becomes asynchronous
and will be held up until the beforeload event can fire at a later date.

Reviewed by Adam Roben.

Both beforeload and load events now fire at the end of the tokenizer write() methods, so that
in the typical parsing case we don't have to put off the beforeload/load events until after
a layout or paint might already have happened. This lets beforeload/load not cause extra
layouts and repaints.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::dispatchBeforeLoadEvent):

  • dom/Document.cpp:

(WebCore::Document::implicitClose):
(WebCore::Document::addListenerTypeIfNeeded):

  • dom/Document.h:

(WebCore::Document::):

  • dom/XMLTokenizer.cpp:

(WebCore::XMLTokenizer::write):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::attach):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::attach):

  • html/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::write):

  • loader/ImageLoader.cpp:

(WebCore::ImageBeforeLoadEventSender::ImageBeforeLoadEventSender):
(WebCore::ImageLoadEventSender::ImageLoadEventSender):
(WebCore::beforeLoadEventSender):
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::setLoadingImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingEvents):
(WebCore::ImageEventSender::ImageEventSender):
(WebCore::ImageEventSender::dispatchEventSoon):
(WebCore::ImageEventSender::cancelEvent):
(WebCore::ImageEventSender::dispatchPendingEvents):
(WebCore::ImageEventSender::timerFired):

  • loader/ImageLoader.h:

(WebCore::ImageLoader::haveFiredBeforeLoadEvent):

  • wml/WMLImageElement.cpp:

(WebCore::WMLImageElement::attach):

9:36 AM Changeset in webkit [49393] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

Web Inspector: Wrap Database into ScriptObject in v8 bindings.

https://bugs.webkit.org/show_bug.cgi?id=30174

No tests due to no Script* test infrastructure.

  • bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
9:35 AM Changeset in webkit [49392] by beidson@apple.com
  • 3 edits in trunk/WebKit/mac

Add SPI to specifically enable visited link tracking.

Reviewed by Dan Bernstein.

  • History/WebHistory.mm:

(+[WebHistory _setVisitedLinkTrackingEnabled:]):

  • History/WebHistoryPrivate.h:
7:58 AM Changeset in webkit [49391] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-09 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins : Fix crash when using QWebPage without QWebView.

'client' is 0 when we have no view.

https://bugs.webkit.org/show_bug.cgi?id=30251

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint):
7:51 AM Changeset in webkit [49390] by mitz@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac

Set the svn:mime-type property of recently-added PNG files to image/png.

5:47 AM Changeset in webkit [49389] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-09 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Simon Hausmann.

[Qt] Plugins : Add missing setCurrentPlugin(0)

https://bugs.webkit.org/show_bug.cgi?id=30248

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::dispatchNPEvent):
5:32 AM Changeset in webkit [49388] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-09 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] beforeload event does not fire on script elements in XML
https://bugs.webkit.org/show_bug.cgi?id=30235

r49194 was lacking a change to XMLTokenizerQt.cpp, equivalent to the one
made in XMLTokenizerLibxml2.cpp.

  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseEndElement):
5:12 AM Changeset in webkit [49387] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2009-10-09 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for WebCore's CSSParserValueList
https://bugs.webkit.org/show_bug.cgi?id=30249

Inherits CSSParserValueList class from FastAllocBase because it has
been instantiated by 'new' in WebCore/css/CSSGrammar.y:1271.

  • css/CSSParserValues.h:
4:32 AM Changeset in webkit [49386] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-09 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins : Create Pixmap only when size changes.

https://bugs.webkit.org/show_bug.cgi?id=30214

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
2:36 AM Changeset in webkit [49385] by jhoneycutt@apple.com
  • 25 edits in trunk

Remove the WebKitPluginHalterEnabledPreferenceKey in favor of checking
for the existence of a PluginHalterDelegate.

This fixes a leak of WebPluginHalterClients:
https://bugs.webkit.org/show_bug.cgi?id=30119.

WebCore:

Reviewed by Dan Bernstein.

  • WebCore.base.exp:

Removed the export of WebCore::Settings::setPluginHalterEnabled().

  • loader/EmptyClients.h:

(WebCore::EmptyPluginHalterClient::enabled):

  • page/Page.cpp:

(WebCore::Page::Page):
Remove initialization of m_pluginHalterClient, which was removed. If a
non-null PluginHalterClient was passed, create the PluginHalter, and
set its allowed run time.

  • page/Page.h:

Removed pluginHalterEnabledStateChanged() and m_pluginHalterClient.

  • page/PluginHalter.cpp:

(WebCore::PluginHalter::didStartPlugin):
Check whether the PluginHalterClient is enabled.
(WebCore::PluginHalter::didStopPlugin):
Ditto.

  • page/PluginHalter.h:

Made m_client an OwnPtr.

  • page/PluginHalterClient.h:

Added a function to return the enabled state.

  • page/Settings.cpp:

(WebCore::Settings::Settings):
Remove initialization of removed member.

  • page/Settings.h:

Removed settings for the enabled state of the PluginHalter; we now use
the existence of a WebPluginHalterDelegate to determine whether the
PluginHalter is enabled.

WebKit/mac:

  • WebCoreSupport/WebPluginHalterClient.h:

Add declaration for new function.

  • WebCoreSupport/WebPluginHalterClient.mm:

(WebPluginHalterClient::enabled):
Check whether the UIDelegate responds to shouldHaltPlugin.

  • WebView/WebPreferenceKeysPrivate.h:

Remove the "enabled" preference key.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
Remove the initialization of the pref.

  • WebView/WebPreferencesPrivate.h:

Remove the getter/setter for this pref.

  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):
Remove propagation of the pref.

WebKit/win:

  • Interfaces/IWebPreferencesPrivate.idl:

Remove the getter and setter.

  • WebCoreSupport/WebPluginHalterClient.cpp:

(WebPluginHalterClient::enabled):
Return true if the delegate exists.

  • WebCoreSupport/WebPluginHalterClient.h:

Declare implementation of enabled().

  • WebPreferenceKeysPrivate.h:

Removed the pref key.

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
Removed initialization of the pref.

  • WebPreferences.h:

Removed declaration of the getter/setter.

  • WebView.cpp:

(WebView::notifyPreferencesChanged):
Don't propagate the pref.

1:59 AM Changeset in webkit [49384] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Attempt to fix the GTK release build.

  • GNUmakefile.am: Include Grammar.cpp in release builds now that

AllInOneFile.cpp is gone.

12:50 AM Changeset in webkit [49383] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-10-09 Gabor Loki <loki@inf.u-szeged.hu>

Rubber-stamped by Eric Seidel.

Add ARM JIT support for Gtk port (disabled by default)
https://bugs.webkit.org/show_bug.cgi?id=30228

  • GNUmakefile.am:

Oct 8, 2009:

11:05 PM Changeset in webkit [49382] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2009-10-08 Alex Milowski <alex@milowski.com>

Reviewed by Darin Adler.

Added a basic description of the layout and rendering project and added links to the blog entries on rendering.

  • projects/layout/index.html:
10:30 PM Changeset in webkit [49381] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-4-branch

Merge r48521.

10:23 PM Changeset in webkit [49380] by mrowe@apple.com
  • 2 edits
    1 add in branches/safari-4-branch/WebCore

Merge r48960.

10:21 PM Changeset in webkit [49379] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebCore

Merge r46604.

10:16 PM Changeset in webkit [49378] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48443.

10:14 PM Changeset in webkit [49377] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebKit/mac

Merge r48394.

10:14 PM Changeset in webkit [49376] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r48361.

10:13 PM Changeset in webkit [49375] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebKit/mac

Merge r48360.

10:13 PM Changeset in webkit [49374] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48359.

10:13 PM Changeset in webkit [49373] by mrowe@apple.com
  • 3 edits
    1 add in branches/safari-4-branch/WebCore

Merge r48358.

10:08 PM Changeset in webkit [49372] by abarth@webkit.org
  • 31 edits
    1 add in trunk

2009-10-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200

Update API call.

  • Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):

2009-10-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200

Update API call.

  • webkit/webkitwebview.cpp: (webkit_web_view_execute_script):

2009-10-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200

Update API call.

  • WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):

2009-10-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200

Update API call.

  • WebFrame.cpp: (wxWebFrame::RunScript):

2009-10-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200

Update API call.

  • WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
  • WebView/WebView.mm: (-[WebView aeDescByEvaluatingJavaScriptFromString:]):

2009-10-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200

These methods have virtually no interaction with FrameLoader. They
really seem like they ought to belong to ScriptController.

  • WebCore.base.exp:
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::executeScript): (WebCore::ScriptController::executeIfJavaScriptURL): (WebCore::ScriptController::evaluate):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::executeScript): (WebCore::ScriptController::executeIfJavaScriptURL):
  • bindings/v8/ScriptController.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::notifyFinished):
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::endElementNs):
  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseEndElement):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::replaceDocument):
  • loader/FrameLoader.h:
  • plugins/PluginView.cpp: (WebCore::PluginView::performRequest):
8:45 PM Changeset in webkit [49371] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Tiger build fix: added a few more variable initializations.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncSearch):

8:42 PM Changeset in webkit [49370] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Qt build fix: added missing #include.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • jsc.cpp:
8:39 PM Changeset in webkit [49369] by beidson@apple.com
  • 18 edits
    2 adds in trunk

Ask the History Delegate to populate the visited links hash.
<rdar://problem/7285293> and https://webkit.org/b/29904

Reviewed by Dan Bernstein.

WebKit/mac:

  • History/WebHistory.mm:

(+[WebHistory _removeAllVisitedLinks]):

  • History/WebHistoryPrivate.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::populateVisitedLinks):

  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebDelegateImplementationCaching.mm:

(CallHistoryDelegate):

  • WebView/WebHistoryDelegate.h:
  • WebView/WebView.mm:

(-[WebView _cacheHistoryDelegateImplementations]):
(-[WebView addVisitedLinks:]):

  • WebView/WebViewPrivate.h:

WebKitTools:

Add the ability for LayoutTestController to clear all visited links.
Also lets the History Delegate dump visited links, but only if this test specifically cleared them.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(removeAllVisitedLinksCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::removeAllVisitedLinks):

  • DumpRenderTree/mac/HistoryDelegate.mm:

(-[HistoryDelegate populateVisitedLinksForWebView:]):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::removeAllVisitedLinks):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::removeAllVisitedLinks):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::removeAllVisitedLinks):

LayoutTests:

  • http/tests/globalhistory/history-delegate-basic-visited-links-expected.txt: Added.
  • http/tests/globalhistory/history-delegate-basic-visited-links.html: Added.
8:37 PM Changeset in webkit [49368] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Tiger build fix: initialize variable whose initialization the compiler
can't otherwise figure out.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::match):

8:35 PM Changeset in webkit [49367] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix: updated exports.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

8:29 PM Changeset in webkit [49366] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Tiger build fix: fixed file name case.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

8:22 PM Changeset in webkit [49365] by ggaren@apple.com
  • 22 edits in trunk/JavaScriptCore

At long last, I pronounce the death of AllInOneFile.cpp.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
Reviewed by Maciej Stachowiak.

SunSpider reports a 1.01x speedup.

to compilation stages.

  • parser/Grammar.y:
  • parser/Lexer.cpp:
  • parser/Lexer.h:

(JSC::jscyylex):

  • runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):

  • runtime/Collector.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::operator new):

  • runtime/JSCell.h:

(JSC::JSCell::operator new):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::operator new):

  • runtime/JSNumberCell.h:

(JSC::JSNumberCell::operator new):

  • runtime/JSString.cpp:
  • runtime/JSString.h:

(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString):

  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpConstructor.h:

(JSC::RegExpConstructorPrivate::RegExpConstructorPrivate):
(JSC::RegExpConstructorPrivate::lastOvector):
(JSC::RegExpConstructorPrivate::tempOvector):
(JSC::RegExpConstructorPrivate::changeLastOvector):
(JSC::RegExpConstructor::performMatch):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncMatch):

  • yarr/RegexJIT.cpp:
  • yarr/RegexJIT.h:

(JSC::Yarr::executeRegex): Inlined a few things that Shark said
were hot, on the presumption that AllInOneFile.cpp used to inline them
automatically.

8:13 PM Changeset in webkit [49364] by mrowe@apple.com
  • 8 edits in branches/safari-4-branch/JavaScriptCore

Merge r48582.

8:07 PM Changeset in webkit [49363] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch/JavaScriptCore

Merge r47605.

8:07 PM Changeset in webkit [49362] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r47604.

8:07 PM Changeset in webkit [49361] by mrowe@apple.com
  • 6 edits in branches/safari-4-branch/JavaScriptCore

Merge r47601.

8:07 PM Changeset in webkit [49360] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r47474.

7:54 PM Changeset in webkit [49359] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r48830.

7:54 PM Changeset in webkit [49358] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r46706.

7:54 PM Changeset in webkit [49357] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r46705.

7:54 PM Changeset in webkit [49356] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r46704.

7:54 PM Changeset in webkit [49355] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r46703.

7:54 PM Changeset in webkit [49354] by mrowe@apple.com
  • 5 edits in branches/safari-4-branch/JavaScriptCore

Merge r46702.

7:54 PM Changeset in webkit [49353] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r46701.

7:54 PM Changeset in webkit [49352] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r46610.

7:54 PM Changeset in webkit [49351] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r46601.

7:54 PM Changeset in webkit [49350] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r46599.

7:54 PM Changeset in webkit [49349] by mrowe@apple.com
  • 63 edits
    3 adds in branches/safari-4-branch

Merge r46598.

7:53 PM Changeset in webkit [49348] by mrowe@apple.com
  • 5 edits in branches/safari-4-branch/JavaScriptCore

Merge r46438.

7:53 PM Changeset in webkit [49347] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r46347.

7:53 PM Changeset in webkit [49346] by mrowe@apple.com
  • 13 edits in branches/safari-4-branch/JavaScriptCore

Merge r46247.

7:53 PM Changeset in webkit [49345] by mrowe@apple.com
  • 5 edits
    3 adds in branches/safari-4-branch

Merge r46210.

7:53 PM Changeset in webkit [49344] by mrowe@apple.com
  • 6 edits in branches/safari-4-branch/JavaScriptCore

Merge r46209.

7:53 PM Changeset in webkit [49343] by mrowe@apple.com
  • 9 edits
    2 adds in branches/safari-4-branch/JavaScriptCore

Merge r46202.

7:53 PM Changeset in webkit [49342] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r46187.

7:53 PM Changeset in webkit [49341] by mrowe@apple.com
  • 2 edits
    1 add in branches/safari-4-branch/JavaScriptCore

Merge r46057.

7:53 PM Changeset in webkit [49340] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r45933.

7:53 PM Changeset in webkit [49339] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r45918.

7:53 PM Changeset in webkit [49338] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r45904.

7:53 PM Changeset in webkit [49337] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r45903.

7:10 PM Changeset in webkit [49336] by dbates@webkit.org
  • 4 edits in trunk/WebKitTools

2009-10-08 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=30175


The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
the OLE drag-and-drop return value like the function it emulates. Currently,
UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
whether the drag-and-drop operation was successful or was cancelled.


This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
return value according to whether the drop operation was successful or not.

  • DumpRenderTree/win/EventSender.cpp: (doMouseUp): Added parameter oleDragAndDropReturnValue. (replaySavedEvents): Ditto.
  • DumpRenderTree/win/EventSender.h:
  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
4:49 PM Changeset in webkit [49335] by ggaren@apple.com
  • 10 edits in trunk/JavaScriptCore

Rolled out 49331 because it still doesn't build on Windows

4:43 PM Changeset in webkit [49334] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: added missing #include.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • interpreter/CallFrame.cpp:
4:35 PM Changeset in webkit [49333] by ggaren@apple.com
  • 3 edits
    1 copy in trunk

Windows build fix: added missing #include.

JavaScriptCore:

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • runtime/PropertyNameArray.h:

WebCore:

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • ForwardingHeaders/runtime/StructureChain.h: Copied from WebCore/ForwardingHeaders/runtime/PropertyNameArray.h.
4:29 PM Changeset in webkit [49332] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: added missing #include.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • runtime/NumberPrototype.cpp:
4:24 PM Changeset in webkit [49331] by ggaren@apple.com
  • 8 edits in trunk/JavaScriptCore

Migrated some code that didn't belong out of Structure.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
Reviewed by Sam Weinig.

SunSpider says maybe 1.03x faster.

  • runtime/JSCell.h: Nixed Structure::markAggregate, and made marking of

a Structure's prototype the direct responsility of the object using it.
(Giving Structure a mark function was misleading because it implied that
all live structures get marked during GC, when they don't.)

  • runtime/JSGlobalObject.cpp:

(JSC::markIfNeeded):
(JSC::JSGlobalObject::markChildren): Added code to mark prototypes stored
on the global object. Maybe this wasn't necessary, but now we don't have
to wonder.

  • runtime/JSObject.cpp:

(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::getEnumerableNamesFromClassInfoTable):

  • runtime/JSObject.h:

(JSC::JSObject::markChildrenDirect):

  • runtime/PropertyNameArray.h:
  • runtime/Structure.cpp:
  • runtime/Structure.h:

(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache): Moved property name gathering code
from Structure to JSObject because having a Structure iterate its JSObject
was a layering violation. A JSObject is implemented using a Structure; not
the other way around.

3:45 PM Changeset in webkit [49330] by agl@chromium.org
  • 13 edits in trunk/WebCore

Revert 49329: broke Windows Debug (Build)

3:31 PM Changeset in webkit [49329] by agl@chromium.org
  • 13 edits in trunk/WebCore

2009-10-08 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Currently, Skia clip paths are 1-bit. This patch makes our path
clipping anti-aliased for non-canvas drawing.

http://code.google.com/p/chromium/issues/detail?id=5927
https://bugs.webkit.org/show_bug.cgi?id=28820
http://www.imperialviolet.org/2009/09/02/anti-aliased-clipping.html

Already covered by layout tests. New baselines will be needed in the
Chromium tree.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::clip):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::canvasClip):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::canvasClip):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::canvasClip):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::canvasClip):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::clipPath):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::clipPathAntiAliased): (PlatformContextSkia::restore): (PlatformContextSkia::applyAntiAliasedClipPaths):
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::canvasClip):
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::canvasClip):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::canvasClip):
3:25 PM Changeset in webkit [49328] by ggaren@apple.com
  • 9 edits in trunk/JavaScriptCore

Rolled out r49322 and friends because they killed the build

3:14 PM Changeset in webkit [49327] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Fixes <https://bugs.webkit.org/show_bug.cgi?id=30237>.
DOM Content and Load lines aren't shown if a page is loaded when the inspector is up.

Reviewed by Timothy Hatcher.

Make sure to call update script object if we have an InspectorFrontend to
call it on when we get one of the new events.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::mainResourceFiredDOMContentEvent):
(WebCore::InspectorController::mainResourceFiredLoadEvent):

3:11 PM Changeset in webkit [49326] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Build fix: updated for removal of Structure::markAggregate().

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::markChildren):

3:08 PM Changeset in webkit [49325] by ggaren@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Removed some conflict markers from the ChangeLog

3:08 PM Changeset in webkit [49324] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: Added missing #include.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08

  • runtime/JSGlobalData.h:
3:02 PM Changeset in webkit [49323] by ggaren@apple.com
  • 8 edits in trunk/JavaScriptCore

Take one branch instead of two to test for JSValue().

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-01
Reviewed by Sam Weinig.

1.1% SunSpider speedup.

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_create_arguments):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.

  • runtime/JSValue.cpp:

(JSC::JSValue::description): Added support for dumping the new empty value,
and deleted values, in debug builds.

  • runtime/JSValue.h:

(JSC::JSValue::JSValue()): Construct JSValue() with the empty value tag.

(JSC::JSValue::JSValue(JSCell*)): Convert null pointer to the empty value
tag, to avoid having two different c++ versions of null / empty.

(JSC::JSValue::operator bool): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.

2:42 PM Changeset in webkit [49322] by levin@chromium.org
  • 4 edits in trunk/WebCore

Make AtomicString create its StringImpl via create(), not the constructor,
so it gets allocated in a single heap block, saving memory and CPU cycles.
This eliminates two StringImpl constructors, making the remaining ones
unambiguous, so the "AdoptBuffer" parameter is no longer needed.
Added const attribute to UChar* in StringImpl constructor, eliminating the
need for several const_casts in calls to it.
StringImpl also unfriends AtomicString (OMG drama!!!)
https://bugs.webkit.org/show_bug.cgi?id=30141

Patch by Jens Alfke <snej@chromium.org> on 2009-10-08
Reviewed by Darin Adler.

  • platform/text/AtomicString.cpp:

(WebCore::CStringTranslator::translate): Call StringImpl::create().
(WebCore::UCharBufferTranslator::translate): Ditto.
(WebCore::HashAndCharactersTranslator::translate): Ditto.

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::StringImpl): Remove unnecessary AdoptBuffer param.
(WebCore::StringImpl::adopt): Ditto.
(WebCore::StringImpl::createUninitialized): Ditto.
(WebCore::StringImpl::create): Ditto.
(WebCore::StringImpl::crossThreadString): Ditto.

  • platform/text/StringImpl.h:

(WebCore::StringImpl::setHash): Used by AtomicString when creating StringImpls.

2:27 PM Changeset in webkit [49321] by eric@webkit.org
  • 22 edits in trunk/LayoutTests

2009-10-08 Aaron Boodman <aa@chromium.org>

Reviewed by Eric Seidel.

r49278 added support for reusing isolated worlds, and the
corresponding change to Chromium's LayoutTestController changed
to expect two arguments. The first argument is the world that
the script should run in.

This change fixes the tests by updating them all to pass 0
for the world id. The specific world id used for these tests
doesn't really matter because they don't test world interaction.

https://bugs.webkit.org/show_bug.cgi?id=30231

  • http/tests/security/isolatedWorld/all-window-properties.html:
  • http/tests/security/isolatedWorld/all-window-prototypes.html:
  • http/tests/security/isolatedWorld/body-properties.html:
  • http/tests/security/isolatedWorld/body-prototype.html:
  • http/tests/security/isolatedWorld/click-event.html:
  • http/tests/security/isolatedWorld/document-open.html:
  • http/tests/security/isolatedWorld/document-properties.html:
  • http/tests/security/isolatedWorld/document-prototype.html:
  • http/tests/security/isolatedWorld/global-variables.html:
  • http/tests/security/isolatedWorld/image-properties.html:
  • http/tests/security/isolatedWorld/image-prototype.html:
  • http/tests/security/isolatedWorld/location-properties.html:
  • http/tests/security/isolatedWorld/location-prototype.html:
  • http/tests/security/isolatedWorld/number-prototype.html:
  • http/tests/security/isolatedWorld/object-prototype.html:
  • http/tests/security/isolatedWorld/storage-properties.html:
  • http/tests/security/isolatedWorld/storage-prototype.html:
  • http/tests/security/isolatedWorld/string-prototype.html:
  • http/tests/security/isolatedWorld/window-properties.html:
  • http/tests/security/isolatedWorld/window-setTimeout-function.html:
  • http/tests/security/isolatedWorld/window-setTimeout-string.html:
2:24 PM Changeset in webkit [49320] by andersca@apple.com
  • 10 edits in trunk

WebCore: Remove the shouldLoadMediaElementURL frame loader client function.

Reviewed by Sam Weinig.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::willLoadMediaElementURL):

WebKit/mac: Remove the shouldLoadMediaElementURL implementation.

Reviewed by Sam Weinig.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebPolicyDelegatePrivate.h:

WebKit/win: Remove the shouldLoadMediaElementURL implementation.

Reviewed by Sam Weinig.

  • Interfaces/IWebPolicyDelegatePrivate.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::shouldUsePluginDocument):

  • WebCoreSupport/WebFrameLoaderClient.h:
2:19 PM Changeset in webkit [49319] by atwilson@chromium.org
  • 2 edits in trunk/WebCore

SVGURIReference Build problem for V8. An additional stale reference to SVGURIReference bindings
which wasn't exposed until a clean build.
https://bugs.webkit.org/show_bug.cgi?id=30217

Patch by John Gregg <johnnyg@google.com> on 2009-10-08
Reviewed by Dimitri Glazkov.

No new tests, just a build fix.

  • bindings/v8/V8Index.cpp:
2:12 PM Changeset in webkit [49318] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Added support for a parameter setting the button that was
pressed in the mouseDown function.
https://bugs.webkit.org/show_bug.cgi?id=30220

  • WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2:12 PM Changeset in webkit [49317] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

2009-10-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Sort XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
2:05 PM Changeset in webkit [49316] by eric@webkit.org
  • 2 edits in trunk

2009-10-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Added a line to the bottom of the expected result to match
the output of the test.
https://bugs.webkit.org/show_bug.cgi?id=30220

  • LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste- expected.txt:
1:57 PM Changeset in webkit [49315] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2009-10-08 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

unselectable resources in resource panel
https://bugs.webkit.org/show_bug.cgi?id=30079

manual test added

Also changed the way DnD for resources in the Resources panel is
handled.

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.onattach): (WebInspector.ResourceSidebarTreeElement.prototype.ondragstart):
  • manual-tests/inspector/duplicate-resource-urls.html: Added.
1:27 PM Changeset in webkit [49314] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

Fixes <http://webkit.org/b/30233>
Local Storage and Cookies show Blank Titles on Local Files.

Reviewed by Timothy Hatcher.

If a local storage or cookies sidebar item has no domain, set the
title to "Local Files", because that is what it represents.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/StoragePanel.js:

(WebInspector.DOMStorageSidebarTreeElement.prototype.get mainTitle):
(WebInspector.CookieSidebarTreeElement.prototype.get mainTitle):
(WebInspector.CookieSidebarTreeElement.prototype.set mainTitle):

1:03 PM Changeset in webkit [49313] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix failing media layout tests. Don't make beforeload block loads of objects that aren't in the
document, since video/audio (and images eventually too) can load when not in the document yet.

Reviewed by Oliver Hunt.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::dispatchBeforeLoadEvent):

12:59 PM Changeset in webkit [49312] by zimmermann@webkit.org
  • 19 edits in trunk

2009-10-08 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel.

Move SVGFitToViewBox ANIMATED_* macros in classes that inherit from it
https://bugs.webkit.org/show_bug.cgi?id=30230

This patch also devirtualizes viewBoxToViewTransform(), is it's superflous.
viewBoxToViewTransform() is now a simple static heper function in SVGFitToViewBox.
As a result, the SVGSVGElement::viewBoxToViewTransform() function now resuses the same logic.

As side-effect this patch fixes svg/custom/linking-a-03-b-transform.svg, the return
statement in SVGSVGElement::viewBoxToViewTransform() was clearly wrong.

12:03 PM Changeset in webkit [49311] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Correct a typo that fixes the resizing of columns in Cookie view when you
resize the Inspector window.

Reviewed by Jon Honeycutt.

  • inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView.prototype.resize):

10:43 AM Changeset in webkit [49310] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Fixes <https://bugs.webkit.org/show_bug.cgi?id=29811>
Text in Inspector's Styles gear menu is invisible.

Reviewed by Adam Roben.

Adds a style rule for the option text and hr's in the gear menu,
to prevent them from being transparent.

  • inspector/front-end/inspector.css:
10:34 AM Changeset in webkit [49309] by levin@chromium.org
  • 3 edits in trunk/WebCore

Fix build problem with SVGURIReference in V8.
https://bugs.webkit.org/show_bug.cgi?id=30217

Patch by John Gregg <johnnyg@google.com> on 2009-10-08
Reviewed by David Levin.

No new tests, just a build fix.

  • WebCore.gypi:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
10:26 AM Changeset in webkit [49308] by hyatt@apple.com
  • 2 edits
    2 adds in trunk

Make beforeload work on <video>/<audio> elements.

Reviewed by Eric Carlson.

Added fast/dom/beforeload/video-before-load.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseMappedAttribute):
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::selectNextSourceChild):

10:14 AM Changeset in webkit [49307] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-08 Xan Lopez <xlopez@igalia.com>

Skip another failing test with reference to its bug.

  • platform/gtk/Skipped:
10:09 AM Changeset in webkit [49306] by zimmermann@webkit.org
  • 61 edits in trunk/WebCore

2009-10-08 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel.

Move SVGExternalResourcesRequired ANIMATED_* macros in classes that inherit from it
https://bugs.webkit.org/show_bug.cgi?id=30218

The long term goal is to kill the need for the virtual contextElement() function in SVG code.
No change in functionality, thus no new tests.

9:11 AM Changeset in webkit [49305] by Adam Roben
  • 7 edits in trunk

Make IWebInspectorPrivate be accessed in a more standard way

Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
accessed in a more standard way

Reviewed by John Sullivan and Tim Hatcher.

WebKit/win:

IWebViewPrivate::inspectorPrivate has been removed. Callers should
instead use IWebViewPrivate::inspector and then use QueryInterface to
get the IWebInspectorPrivate interface. This matches how our other COM
classes work.

  • Interfaces/IWebViewPrivate.idl: Removed inspectorPrivate.

(WebInspector::QueryInterface): Support querying to
IWebInspectorPrivate.

  • WebView.cpp:
  • WebView.h:

Removed inspectorPrivate.

WebKitTools:

Use QueryInterface to get IWebInspectorPrivate

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::evaluateInWebInspector): Get the IWebInspector
by calling IWebViewPrivate::inspector, then use QueryInterface to get
to the IWebInspectorPrivate interface.

8:38 AM Changeset in webkit [49304] by Adam Roben
  • 2 edits in trunk/WebKit/win

Move the new IWebViewPrivate::inspectorPrivate function after all functions that existed when Safari 4.0.3 was released

Fixes <http://webkit.org/b/30085> REGRESSION (r49091): run-safari
crashes in Safari.dll

Reviewed by John Sullivan.

  • Interfaces/IWebViewPrivate.idl: Moved inspectorPrivate to the end of

the interface, so it won't modify the vtable that Safari 4.0.3 sees.

8:28 AM Changeset in webkit [49303] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-08 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

SVG feComposite: operator over mixes up inputs
https://bugs.webkit.org/show_bug.cgi?id=30205

SVG feComposite operator over mixed up the inputs.
The pixel-test svg/filters/feComposite.svg can already test this.
No new test result is needed as long as filters are disabled.

  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
8:15 AM Changeset in webkit [49302] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-08 Xan Lopez <xlopez@igalia.com>

Skip flakey transition test.

  • platform/gtk/Skipped:
7:53 AM Changeset in webkit [49301] by zimmermann@webkit.org
  • 33 edits in trunk/WebCore

Reviewed by George Staikos.

Move SVGURIReference ANIMATED_* macros in classes that inherit from it
https://bugs.webkit.org/show_bug.cgi?id=30184

The long term goal is to kill the need for the virtual contextElement() function in SVG code.
No change in functionality, thus no new tests.

7:44 AM Changeset in webkit [49300] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Re-add the QApplication::syncX() line for plugin windows removed
by r49169. Also changed the location of the sync just after the
creation instead of just before sending it to the plugin.
https://bugs.webkit.org/show_bug.cgi?id=25053

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::platformStart):
7:09 AM Changeset in webkit [49299] by Adam Roben
  • 9 edits in trunk

Expose origin whitelisting in the WebKit API on Windows

Fixes <http://webkit.org/b/30185>.

Reviewed by Eric Seidel.

WebKit/win:

  • Interfaces/IWebViewPrivate.idl: Added whiteListAccessFromOrigin and

resetOriginAccessWhiteLists, to match the Mac SPI.

  • WebView.cpp:

(WebView::whiteListAccessFromOrigin):
(WebView::resetOriginAccessWhiteLists):

  • WebView.h:

Added. These just call through to SecurityOrigin.

WebKitTools:

Implement DRT support for origin whitelisting

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting): Reset any origin
whitelist, to match Mac DRT.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::whiteListAccessFromOrigin): Call through to
IWebViewPrivate::whiteListAccessFromOrigin.

LayoutTests:

Start running origin whitelist tests on Windows

  • platform/win/Skipped:
7:09 AM Changeset in webkit [49298] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2009-10-08 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Inspector: NodeLists Don't Display Well in the Console
https://bugs.webkit.org/show_bug.cgi?id=28061

  • inspector/front-end/InjectedScript.js: (Object.type):
6:29 AM Changeset in webkit [49297] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-08 Xan Lopez <xlopez@igalia.com>

Fix typo in skipped test.

  • platform/gtk/Skipped:
6:25 AM Changeset in webkit [49296] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-08 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Simon Hausmann.

[Qt] Windowless plugins: Remove unnecessary XSync for opaque mode.

The reason for the XSync was that the plugin would not know about the
Drawable. It turns out that the real reason behind this is that even
though XCreatePixmap returns a handle, this id is unknown to the server
until we flush the connection.

So, move the XSync to right after we create the Pixmap.

https://bugs.webkit.org/show_bug.cgi?id=30207

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint):
6:14 AM Changeset in webkit [49295] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-08 Xan Lopez <xlopez@igalia.com>

Skip editing/selection/home-end.html, since it seems to be
somewhat broken. See https://bugs.webkit.org/show_bug.cgi?id=30208
for details.

  • platform/gtk/Skipped:
6:09 AM Changeset in webkit [49294] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Part of testOptionalJSObjects autotest was marked as "expect to fail".

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2009-10-08
Reviewed by Simon Hausmann.

Two places in tst_QWebPage::testOptionalJSObjects were marked as
expected to fail. The problem concern checking if a feature is enabled
or disabled. According to discussion on webkit dev mailing list
a disabled feature should be invisible from java script level, but
there are exceptions from the rule. So we decided to disable the test
for now.

https://bugs.webkit.org/show_bug.cgi?id=29867

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::testOptionalJSObjects):

2:18 AM Changeset in webkit [49293] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix for JIT'ed op_call instructions (evals, constructs, etc.)
when !ENABLE(JIT_OPTIMIZE_CALL) && USE(JSVALUE32_64)

Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2009-10-08
Reviewed by Gavin Barraclough.

https://bugs.webkit.org/show_bug.cgi?id=30201

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

Oct 7, 2009:

11:57 PM Changeset in webkit [49292] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2009-10-07 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30188


Fixes an issue where performing a non DHTML drag-and-drop operation
does not work as expected. For instance, dragging some selected text
to an external application, such as TextEdit.


This issue was a regression that arose from patching bug #30107.


This change is covered by the manual test:
drag-out-of-background-window.html

11:29 PM Changeset in webkit [49291] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-10-07 Xan Lopez <xlopez@igalia.com>

Fix more breakage in the GTK+ build.

  • GNUmakefile.am:
11:17 PM Changeset in webkit [49290] by abarth@webkit.org
  • 8 edits
    4 adds
    2 deletes in trunk/WebCore

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move PolicyChecker to it's own file
https://bugs.webkit.org/show_bug.cgi?id=30193

This is just moving code around and re-naming things.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/PolicyCallback.cpp: Added. (WebCore::PolicyCallback::PolicyCallback): (WebCore::PolicyCallback::~PolicyCallback): (WebCore::PolicyCallback::clear): (WebCore::PolicyCallback::set): (WebCore::PolicyCallback::call): (WebCore::PolicyCallback::clearRequest): (WebCore::PolicyCallback::cancel):
  • loader/PolicyCallback.h: Added. (WebCore::PolicyCallback::request):
  • loader/PolicyCheck.cpp: Removed.
  • loader/PolicyCheck.h: Removed.
11:13 PM Changeset in webkit [49289] by eric@webkit.org
  • 7 edits in trunk/WebCore

2009-10-07 Joel Stanley <joel@jms.id.au>

Reviewed by Mark Rowe.

Include <limits> for std::numeric_limits. Required by gcc-4.4
https://bugs.webkit.org/show_bug.cgi?id=30197

  • html/canvas/CanvasByteArray.h:
  • html/canvas/CanvasIntArray.h:
  • html/canvas/CanvasShortArray.h:
  • html/canvas/CanvasUnsignedByteArray.h:
  • html/canvas/CanvasUnsignedIntArray.h:
  • html/canvas/CanvasUnsignedShortArray.h:
11:09 PM Changeset in webkit [49288] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-07 Xan Lopez <xlopez@igalia.com>

Fix the GTK+ build.

  • webkit/webkitwebpolicydecision.cpp: (webkit_web_policy_decision_use): (webkit_web_policy_decision_ignore): (webkit_web_policy_decision_download):
10:30 PM Changeset in webkit [49287] by weinig@apple.com
  • 2 edits in trunk/WebKitSite

Fix for https://bugs.webkit.org/show_bug.cgi?id=30196
Change style guidelines for indentation in header files

Reviewed by Dan Bernstein.

  • coding/coding-style.html: Don't indent in a namespace in a header file.
9:55 PM QtWebKitPerformanceUtilities edited by zecke@selfish.org
Update pahs. (diff)
9:44 PM Changeset in webkit [49286] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-07 Simon Fraser <simon.fraser@apple.com>

Re-land 49269-49271 since reverting them did not fix the tests.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
9:09 PM Changeset in webkit [49285] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-07 Simon Fraser <simon.fraser@apple.com>

Revert 49269-49271 to see if it fixes test failures on SnowLeopard that do not
reproduce locally.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
8:17 PM Changeset in webkit [49284] by abarth@webkit.org
  • 18 edits in trunk

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::callPolicyFunction):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSubmitForm): (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

  • WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): (WebFrame::receivedPolicyDecision): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchWillSubmitForm): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForMIMEType): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNavigationAction):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::receivedPolicyDecison):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::dispatchWillSubmitForm): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForMIMEType): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNavigationAction):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

This patch separates PolicyChecker from FrameLoader. Loader policy is
in change of managing the FrameLoaderClient callbacks. Ideally, it
shouldn't know anything about FrameLoader, but I couldn't quite remove
all knowledge (although we might be able to do more later). In a
future patch, I'll move PolicyChecker into a separate file.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::PolicyChecker::handleUnimplementablePolicy): (WebCore::PolicyChecker::cannotShowMIMEType): (WebCore::PolicyChecker::PolicyChecker): (WebCore::PolicyChecker::checkNavigationPolicy): (WebCore::PolicyChecker::checkContentPolicy): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::stopAllLoaders): (WebCore::PolicyChecker::cancelCheck): (WebCore::PolicyChecker::stopCheck): (WebCore::PolicyChecker::continueAfterContentPolicy): (WebCore::PolicyChecker::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::loadPostRequest): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::PolicyChecker::checkNewWindowPolicy): (WebCore::PolicyChecker::continueAfterNewWindowPolicy): (WebCore::PolicyChecker::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
  • loader/FrameLoader.h: (WebCore::PolicyChecker::loadType): (WebCore::PolicyChecker::setLoadType): (WebCore::PolicyChecker::delegateIsDecidingNavigationPolicy): (WebCore::PolicyChecker::delegateIsHandlingUnimplementablePolicy): (WebCore::FrameLoader::policy):
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
7:28 PM Changeset in webkit [49283] by aa@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests/http/tests/security/isolatedWorld

Not reviewed. Fix layout test missing results.

7:04 PM Changeset in webkit [49282] by sfalken@apple.com
  • 2 edits in trunk/WebKitSite

Add new Windows build prerequisite: Visual Studio 2005 Service Pack 1 ATL Security Update

Reviewed by Mark Rowe.

  • building/tools.html:
6:52 PM Changeset in webkit [49281] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix: removed no longer exported symbol.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07

6:46 PM Changeset in webkit [49280] by ggaren@apple.com
  • 24 edits
    2 copies in trunk

JavaScriptCore: Fixed <rdar://problem/5751979> Database code takes JSLock on secondary
thread, permanently slowing down JavaScript

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07
Reviewed by Oliver Hunt.

Removed the optional lock from Heap::protect, Heap::unprotect, and friends,
since WebCore no longer uses it.

(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::markProtectedObjects):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::protectedObjectCount):
(JSC::Heap::protectedObjectTypeCounts):

  • runtime/Collector.h:

WebCore: Fixed <rdar://problem/5751979> Database code takes JSLock on secondary
thread, permanently slowing down JavaScript

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07
Reviewed by Oliver Hunt.

Changed callback objects to use a standard helper object. The helper
object ASSERTs that it is deleted on the main thread, so no lock is
required when unprotecting its members. It also centralizes some previously
duplicated code.

Callback objects that might be deleted on a secondary thread use
callOnMainThread to delete their helper objects on the main thread.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCallbackData.cpp: Copied from bindings/js/JSCustomSQLTransactionCallback.cpp.

(WebCore::JSCallbackData::deleteData):
(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCallbackData.h: Copied from bindings/js/JSCustomSQLTransactionCallback.cpp.

(WebCore::JSCallbackData::JSCallbackData):
(WebCore::JSCallbackData::~JSCallbackData):
(WebCore::JSCallbackData::callback):

  • bindings/js/JSCustomPositionCallback.cpp:

(WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
(WebCore::JSCustomPositionCallback::handleEvent):

  • bindings/js/JSCustomPositionCallback.h:
  • bindings/js/JSCustomPositionErrorCallback.cpp:

(WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
(WebCore::JSCustomPositionErrorCallback::handleEvent):

  • bindings/js/JSCustomPositionErrorCallback.h:
  • bindings/js/JSCustomSQLStatementCallback.cpp:

(WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::~JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::handleEvent):

  • bindings/js/JSCustomSQLStatementCallback.h:
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::~JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):

  • bindings/js/JSCustomSQLStatementErrorCallback.h:
  • bindings/js/JSCustomSQLTransactionCallback.cpp:

(WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::handleEvent):

  • bindings/js/JSCustomSQLTransactionCallback.h:
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp:

(WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::~JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):

  • bindings/js/JSCustomSQLTransactionErrorCallback.h:
  • bindings/js/JSCustomVoidCallback.cpp:

(WebCore::JSCustomVoidCallback::JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::~JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::handleEvent):

  • bindings/js/JSCustomVoidCallback.h:
  • storage/Database.cpp:

(WebCore::Database::Database):

5:41 PM Changeset in webkit [49279] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2009-10-07 Jens Alfke <snej@chromium.org>

Reviewed by Dave Levin.

Fix StringImpl::m_buffer
https://bugs.webkit.org/show_bug.cgi?id=30189

Fix my previous StringImpl patch to avoid using an indefinite-length array member,
since MSVC doesn't like it. Instead, go back to offsetting by sizeof(StringImpl).

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): (WebCore::StringImpl::createUninitialized):
  • platform/text/StringImpl.h: (WebCore::StringImpl::bufferIsInternal):
5:07 PM Changeset in webkit [49278] by aa@chromium.org
  • 12 edits
    3 adds in trunk

Update isolated worlds under v8 to support world reuse.
https://bugs.webkit.org/show_bug.cgi?id=30145

Patch by Aaron Boodman <aa@chromium.org> on 2009-10-07
Reviewed by Adam Barth.

WebCore:

  • bindings/v8/ScriptController.cpp:

Replace evaluateInNewIsolatedWorld() withe evaluateInIsolatedWorld(id).
(WebCore::ScriptController::evaluateInIsolatedWorld):

  • bindings/v8/ScriptController.h: Ditto.
  • bindings/v8/V8Proxy.cpp: Ditto.

(WebCore::V8Proxy::~V8Proxy): Dittio.
(WebCore::V8Proxy::evaluateInIsolatedWorld): Ditto.

  • bindings/v8/V8Proxy.h: Ditto.
  • bindings/v8/V8IsolatedWorld.cpp:

Add support for controlling lifetime of a world, rather than relying on GC.
(WebCore::V8IsolatedWorld::contextWeakReferenceCallback): Ditto.
(WebCore::V8IsolatedWorld::V8IsolatedWorld): Ditto.
(WebCore::V8IsolatedWorld::destroy): Ditto.

  • bindings/v8/V8IsolatedWorld.h: Ditto.

LayoutTests:

  • http/tests/security/isolatedWorld/iframe.html: Added.
  • http/tests/security/isolatedWorld/world-reuse-expected.txt: Added.
  • http/tests/security/isolatedWorld/world-reuse.html: Added.
5:05 PM Changeset in webkit [49277] by beidson@apple.com
  • 8 edits
    2 adds in trunk

Send title changes to the global history delegate.
<rdar://problem/7285293> and https://webkit.org/b/29904

Reviewed by Darin Adler.

WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::setTitle):

  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebHistoryDelegate.h:
  • WebView/WebView.mm:

(-[WebView _cacheHistoryDelegateImplementations]):

WebKitTools:

  • DumpRenderTree/mac/HistoryDelegate.mm:

(-[HistoryDelegate webView:updateHistoryTitle:forURL:]):

LayoutTests:

  • http/tests/globalhistory/history-delegate-basic-title-expected.txt: Added.
  • http/tests/globalhistory/history-delegate-basic-title.html: Added.
4:55 PM Changeset in webkit [49276] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/platform/text/StringImpl.cpp

Well that was wrong, undo-ing previous build fix.

4:50 PM Changeset in webkit [49275] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/platform/text/StringImpl.cpp

Hopefully the rest of the Windows build fix.

4:33 PM Changeset in webkit [49274] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

Build fix for http://trac.webkit.org/changeset/49272 on Windows

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-07

  • platform/text/StringImpl.h:
4:20 PM Changeset in webkit [49273] by darin@apple.com
  • 4 edits in trunk/WebKit/mac

Make the setMetadataURL function foolproof by having it remove user info
https://bugs.webkit.org/show_bug.cgi?id=30178
rdar://problem/6544670

Patch by Darin Adler <darin@apple.com> on 2009-10-07
Reviewed by John Sullivan.

  • Misc/WebNSFileManagerExtras.m:

(-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
Call _web_URLByRemovingUserInfo on the passed in URL string after converting
it to a URL, and then convert it back to a string.

  • Misc/WebNSURLExtras.h: Added _web_URLByRemovingUserInfo.
  • Misc/WebNSURLExtras.mm: Removed unused WebKitURLComponents struct.

(-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Renamed to be
clearer on what this does.
(-[NSURL _webkit_URLByRemovingFragment]): Changed to call new name.
(-[NSURL _webkit_URLByRemovingResourceSpecifier]): Ditto.
(-[NSURL _web_URLByRemovingComponentAndSubsequentCharacter:]): Added.
(-[NSURL _web_URLByRemovingUserInfo]): Added.

3:41 PM Changeset in webkit [49272] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-07 Jens Alfke <snej@chromium.org>

Reviewed by Darin Adler.

Optimization of StringImpl:

  • Remove unnecessary m_bufferIsInternal member (saves 4 bytes). Instead, check whether m_data points to just past the end of the object's members.
  • copy() and createWithTerminatingNullCharacter() create the string in a single malloc block instead of 2 (saves ~20 bytes and considerable CPU cycles, increases locality).
  • Move m_length next to m_hash to save 4 bytes of padding in 64-bit builds.

https://bugs.webkit.org/show_bug.cgi?id=29500

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Re-ordered members. (WebCore::StringImpl::~StringImpl): Change to is-buffer-internal check. (WebCore::StringImpl::createUninitialized): Use new m_buffer member instead of sizeof()

to ensure chars are copied to correct location.

(WebCore::StringImpl::createWithTerminatingNullCharacter): Make sure copy is created

in a single malloc block.

(WebCore::StringImpl::threadsafeCopy): Make sure copy is created in a single malloc block.
(WebCore::StringImpl::crossThreadString): Make sure copy is created in a single malloc block.
(WebCore::StringImpl::sharedBuffer): Change to is-buffer-internal check.

  • platform/text/StringImpl.h: (WebCore::StringImpl::startsWith): Just fixed a confusing param name. (WebCore::StringImpl::bufferIsInternal): Changed member var into accessor method. (WebCore::StringImpl::m_data): Repositioned for optimal member packing in 64-bit. (WebCore::StringImpl::m_buffer): Added to provide an explicit location for where internal buffer goes.
3:41 PM Changeset in webkit [49271] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-07 Simon Fraser <simon.fraser@apple.com>

Make Dan Bernstein happy.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
3:38 PM Changeset in webkit [49270] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Avoid Obj-C message dispatch when possible by storing accessed objects
in local variables.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
3:29 PM Changeset in webkit [49269] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Animation stalls for a few seconds partway through
https://bugs.webkit.org/show_bug.cgi?id=30182

Make sure that we only call -disableScreenUpdatesUntilFlush when a window
update is actually going to happen, otherwise screen updates are disabled
for too long.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
3:26 PM Changeset in webkit [49268] by dbates@webkit.org
  • 3 edits
    1 add in trunk

2009-10-07 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30102
And
<rdar://problem/5015957>


Fixes an issue (in the Windows build) where the cursor does not change to the
not-allowed cursor when the drag-and-drop operation is not allowed.


The allowed effects in WebDragClient::startDrag are hard-coded to be
DROPEFFECT_COPY | DROPEFFECT_LINK | DROPEFFECT_MOVE. Instead, the list of
allowed drop effects should be determined by the allowed operations of the
drag source.


We cannot test this using DRT because DRT looks at the programmatic drop
cursor and until bug #24731 is fixed this value is hard-coded to DragOperationCopy.
That is, there is a discrepancy in the Windows build between the Windows API-based
drop effect and the WebKit drop effect. Because DRT cannot read the screen buffer
to determine the cursor, a manual test is needed.

  • WebCoreSupport/WebDragClient.cpp: (draggingSourceOperationMaskToDragCursors): Added method. (WebDragClient::startDrag):

2009-10-07 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30102
And
<rdar://problem/5015957>


Manual test to confirm that the not-allowed cursor is shown for an
invalid drag-and-drop operation.


We cannot test this using DRT because of a discrepancy between the Windows
API-based drop effect and the WebKit drop effect. See bug #24731 for more
details.

  • manual-tests/drag-cursor-notallowed.html: Added.
3:22 PM Changeset in webkit [49267] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-07 Adam Barth <abarth@webkit.org>

Unreviewed. Remove some folks from committers.py who were listed on
the WebKit Team wiki page but who weren't actually listed as commit+.
At some point, we should coorelate this list with the committers
mailing list.

  • Scripts/modules/committers.py:
3:16 PM Changeset in webkit [49266] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the build.

3:10 PM Changeset in webkit [49265] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-07 Adam Barth <abarth@webkit.org>

Unreviewed. Import a bunch of committers from the WebKit Team page on
the wiki into committers.py.

  • Scripts/modules/committers.py:
2:56 PM Changeset in webkit [49264] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-10-07 Evan Martin <evan@chromium.org>

Reviewed by Adam Roben.

Windows-specific baselines for some new tests.

  • platform/win/fast/css/large-number-round-trip-expected.txt: Added.
  • platform/win/fast/css/opacity-float-expected.txt: Copied from LayoutTests/fast/css/opacity-float-expected.txt.
2:55 PM Changeset in webkit [49263] by bweinstein@apple.com
  • 18 edits in trunk/WebCore

2009-10-07 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.

Fixes <http://webkit.org/b/30104>.
Inspector should show cookies of sub-resources on the page.


This function implements showing cookies for all sub-resources of a page.
When the page is loaded, it populates the Storage Panel with a list of all
domains that were loaded as part of the full page load (iframes, ads, etc).
When the user selects one of the domains, the inspector calls back into the
controller, and the controller combines all of the cookies from that domain
into a list, and sends that list is sent back to the controller to render.


A domain now needs to be passed into CookieItemsView, and CookieSidebarTreeElement.


As a result of a previous patch, we now have detailed cookie information for
both Windows on CFNetwork and Mac. Additionally, this patch provides deleteCookie
support on Windows.

  • bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::set):
  • bindings/js/ScriptObject.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getCookies): (WebCore::InspectorBackend::deleteCookie):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::buildArrayForCookies): (WebCore::InspectorController::buildObjectForCookie): (WebCore::InspectorController::deleteCookie):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addCookieDomainForDocument):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
  • inspector/front-end/DOMAgent.js: (WebInspector.Cookies.getCookiesAsync):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addCookieDomain): (WebInspector.StoragePanel.prototype.showCookies): (WebInspector.CookieSidebarTreeElement): (WebInspector.CookieSidebarTreeElement.prototype.onselect):
  • inspector/front-end/inspector.js: (WebInspector.addCookieDomain):
  • platform/Cookie.h: (WebCore::CookieHash::hash): (WebCore::CookieHash::equal): (WTF::):
  • platform/network/win/CookieJarCFNetWin.cpp: (WebCore::deleteCookie):
2:50 PM Changeset in webkit [49262] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

2009-10-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add ScriptObject::set(const char*, unsigned).

https://bugs.webkit.org/show_bug.cgi?id=30104

  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::set):
  • bindings/v8/ScriptObject.h:
2:49 PM LayoutAndRendering edited by alex@milowski.com
(diff)
2:47 PM Changeset in webkit [49261] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-07 Adam Barth <abarth@webkit.org>

Unreviewed. Added Aaron Boodman to committers.py.

  • Scripts/modules/committers.py:
2:46 PM LayoutAndRendering edited by alex@milowski.com
(diff)
2:46 PM LayoutAndRendering created by alex@milowski.com
2:41 PM WikiStart edited by alex@milowski.com
added link to new layout and rendering page (diff)
1:51 PM Changeset in webkit [49260] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed build fix for Windows (Cairo).

Provide implementation of new BitmapImage::create that was
added in @r49060.

  • platform/graphics/win/ImageCairoWin.cpp:
1:25 PM Changeset in webkit [49259] by eric@webkit.org
  • 9 edits
    2 adds in trunk/WebCore

2009-10-07 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Refactor RenderThemeChromiumMac and RenderThemeChromiumSkia to render media controls using GraphicsContext.

Design was based on existing RenderMediaControls.cpp used by RenderThemeSafari/Win.

https://bugs.webkit.org/show_bug.cgi?id=29987

Covered by existing layout tests as no new functionality was introduced.

  • WebCore.gypi: Added RenderMediaControlsChromium.cpp/h.
  • css/mediaControlsChromium.css: Tweaked media slider position and border style.
  • rendering/MediaControlElements.cpp: (WebCore::toParentMediaElement): Taken from RenderMediaControls. (WebCore::MediaControlElement::rendererIsNeeded): Don't call shouldRenderMediaControlPart() if element has no appearance. (WebCore::MediaControlInputElement::rendererIsNeeded): Ditto.
  • rendering/RenderMediaControls.cpp: Moved parentMediaElement() to MediaControlElements.
  • rendering/RenderMediaControlsChromium.cpp: Added. (WebCore::platformResource): Helper to load and cache media control image resources. (WebCore::mediaSliderThumbImage): Implementation refactored from RenderThemeChromiumMac/Skia. (WebCore::mediaVolumeSliderThumbImage): Ditto. (WebCore::paintMediaButton): Ditto. (WebCore::paintMediaMuteButton): Ditto. (WebCore::paintMediaPlayButton): Ditto. (WebCore::paintMediaSlider): Ditto. (WebCore::paintMediaSliderThumb): Ditto. (WebCore::paintMediaVolumeSlider): Ditto. (WebCore::paintMediaVolumeSliderThumb): Ditto. (WebCore::paintMediaTimelineContainer): Ditto. (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart): Ditto. (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Same (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
  • rendering/RenderMediaControlsChromium.h: Added.
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): Implementation delegated to RenderMediaControlsChromium. (WebCore::RenderThemeChromiumMac::shouldRenderMediaControlPart): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground): Ditto.
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintMediaControlsBackground): Implementation delegated to RenderMediaControlsChromium. (WebCore::RenderThemeChromiumSkia::paintMediaSliderTrack): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderTrack): Ditto. (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaSliderThumb): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderThumb): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): Ditto. (WebCore::RenderThemeChromiumSkia::shouldRenderMediaControlPart): Ditto.
1:03 PM Changeset in webkit [49258] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

Make plugins work with beforeload.

Reviewed by Adam Roben.

Added fast/dom/beforeload/flash-before-load.html

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):

  • rendering/RenderPartObject.cpp:

(WebCore::RenderPartObject::updateWidget):

12:10 PM Changeset in webkit [49257] by cmarrin@apple.com
  • 6 edits in trunk/WebKitSite/blog-files/webgl/resources

resized thumbnails

11:32 AM Changeset in webkit [49256] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

https://bugs.webkit.org/show_bug.cgi?id=30176
<rdar://problem/7281553> Extra information in UA causes problems with gmail

Reviewed by Darin Adler.

  • WebKit.vcproj/WebKit.rc: Restore PRODUCTVERSION to build number only. Remove extra space.
11:20 AM Changeset in webkit [49255] by cmarrin@apple.com
  • 6 adds in trunk/WebKitSite/blog-files/webgl/resources

added thumbnail images for demos

11:10 AM Changeset in webkit [49254] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-10-07 Evan Martin <evan@chromium.org>

Reviewed by Simon Fraser.

Add a currently-failing test exhibiting the problem in
https://bugs.webkit.org/show_bug.cgi?id=20674:

When converting very large or small numbers back to strings, exponential
notation is used, so a value like 90010000px is returned from
getComputedStyle() as 9.001e+07px.

9.001e+07px does not parse, so such a value cannot be round-tripped.

This is a particular problem with tranformation matrices, which can often
contain very large or small numbers.

(Test written by Simon Fraser; I've just made it a committable patch.)

  • fast/css/large-number-round-trip-expected.txt: Added.
  • fast/css/large-number-round-trip.html: Added.
10:47 AM Changeset in webkit [49253] by eric@webkit.org
  • 8 edits
    3 adds in trunk

2009-10-07 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

Layout test for verifying that LC_NUMERIC setting doesn't affect
the way CSS properties are stringified.
https://bugs.webkit.org/show_bug.cgi?id=18994

  • fast/css/opacity-float-expected.txt: Added.
  • fast/css/opacity-float.html: Added.

2009-10-07 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

Add API to LayoutTestController for re/setting the system locale.
https://bugs.webkit.org/show_bug.cgi?id=18994

  • DumpRenderTree/LayoutTestController.cpp: (setLocaleCallback): (LayoutTestController::staticFunctions): (LayoutTestController::setLocale):
  • DumpRenderTree/LayoutTestController.h:
10:25 AM Changeset in webkit [49252] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-07 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Protect JS listener object from GC while clearing a property on it.
See http://crbug.com/23780.
https://bugs.webkit.org/show_bug.cgi?id=30137

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
10:09 AM Changeset in webkit [49251] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2009-10-07 Zoltan Horvath <zoltan@webkit.org>

Rubber-stamped by Eric Seidel.

Allow custom memory allocation control for WebCore's CachedResourceClient class
https://bugs.webkit.org/show_bug.cgi?id=30165

Inherits CachedResourceClient class from FastAllocBase because (its
child class) CSSFontFaceSource has been instantiated by 'new' in WebCore/css/CSSFontFaceSource.h:46.

  • loader/CachedResourceClient.h:
10:04 AM Changeset in webkit [49250] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2009-10-07 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for WebCore's IdentifierRep
https://bugs.webkit.org/show_bug.cgi?id=30159

Inherits IdentifierRep class from FastAllocBase because it has been
instantiated by 'new' in WebCore/bridge/IdentifierRep.cpp:61.

  • bridge/IdentifierRep.h:
10:00 AM Changeset in webkit [49249] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-10-07 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's IdentifierArena
https://bugs.webkit.org/show_bug.cgi?id=30158

Inherits IdentifierArena class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/parser/ParserArena.cpp:36.

  • parser/ParserArena.h:
9:59 AM Changeset in webkit [49248] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-10-07 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Fetch pointers to C++ DOM window immediately from holder
object (do not search prototype chain for proper JS wrapper).
https://bugs.webkit.org/show_bug.cgi?id=29031

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createNewContext): (WebCore::V8Proxy::installDOMWindow):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_ACCESS_CHECK):
9:49 AM Changeset in webkit [49247] by Adam Roben
  • 4 edits in trunk/JavaScriptCore

Export DateInstance::info in a way that works on Windows

Fixes <http://webkit.org/b/30171>
fast/dom/Window/window-postmessage-clone.html fails on Windows

Reviewed by Anders Carlsson.

Removed the export of DateInstance::info from here.

  • runtime/DateInstance.h: Use JS_EXPORTDATA to export

DateInstance::info, which is the required way of exporting data on
Windows.

9:23 AM Changeset in webkit [49246] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2009-10-06 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Jan Alonzo.

[Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
https://bugs.webkit.org/show_bug.cgi?id=29689

Build fix by adding -lfontconfig for DumpRenderTree.

  • GNUmakefile.am:
8:22 AM Changeset in webkit [49245] by tonikitoo@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-10-07 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Get rid of useless loadFailed signal in QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=30166

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_doLoadFinished):
  • Api/qgraphicswebview.h:
  • QGVLauncher/main.cpp: (MainWindow::init): (MainWindow::loadFinished):
8:11 AM Changeset in webkit [49244] by Adam Roben
  • 2 edits in trunk/WebCore

Fix typo in PluginView::load that was causing cross-origin loads to be allowed

This typo was introduced in the build fix in r49213.

Fixes <http://webkit.org/b/30168> REGRESSION (r49213):
http/tests/plugins/local-geturl-from-remote.html is failing on Windows

Reviewed by Sam Weinig.

  • plugins/PluginView.cpp:

(WebCore::PluginView::load): Removed a comma operator that was making
a condition always evaluate to true.

7:53 AM Changeset in webkit [49243] by zoltan@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-07 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.

  • Scripts/run-webkit-tests:
7:06 AM Changeset in webkit [49242] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Do not create valid QColor's for invalid WebCore::Color's.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-07
Reviewed by Simon Hausmann.

  • platform/graphics/qt/ColorQt.cpp:

(WebCore::Color::operator QColor):

5:44 AM Changeset in webkit [49241] by xan@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-07 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

"delete" in EventSender is the backspace key, not the delete one.

  • DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
4:46 AM Changeset in webkit [49240] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-10-07 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Simon Hausmann.

Add a simple rotation effect to QGVLauncher

https://bugs.webkit.org/show_bug.cgi?id=30162

  • QGVLauncher/main.cpp: (MainView::animatedFlip): (MainWindow::animatedFlip): (MainWindow::buildUI):
3:58 AM Changeset in webkit [49239] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-07 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Simon Hausmann.

[Qt] Symbian SBSv2 .data segment adress fix
https://bugs.webkit.org/show_bug.cgi?id=30157

RO-section in qtwebkit.dll exceeds allocated space in SBSv2. Move RW-section
base address to start from 0x800000 instead of the toolchain default 0x400000

  • WebCore.pro:
3:45 AM Changeset in webkit [49238] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

When enabling or disabling the JIT through .qmake.cache, make sure
to also toggle ENABLE_YARR_JIT.

Patch by Jørgen Lind <jorgen.lind@nokia.com> on 2009-10-07
Reviewed by Simon Hausmann.

3:44 AM Changeset in webkit [49237] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Doc: Document HTML and status as properties.

Patch by Volker Hilsheimer <volker.hilsheimer@nokia.com> on 2009-10-07
Reviewed by Simon Hausmann.

  • Api/qgraphicswebview.cpp:
3:42 AM Changeset in webkit [49236] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Fix qdoc warning about disabled renderHints property
on Symbian.

Patch by Martin Smith <msmith@trolltech.com> on 2009-10-07
Reviewed by Simon Hausmann.

  • Api/qwebview.cpp:
  • Api/qwebview.h:
3:36 AM Changeset in webkit [49235] by xan@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-07 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

getChildrenWithRange expects as last parameter the end index, not
the length of the range. Correct this and clarify the variable
names to reflect how the code works.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::getChildrenWithRange): (AccessibilityUIElement::getChildAtIndex):
2:32 AM Changeset in webkit [49234] by pfeldman@chromium.org
  • 18 edits in trunk/WebCore

2009-10-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Migrate database inspection to the injected script-based schema.

https://bugs.webkit.org/show_bug.cgi?id=29788

  • bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::databaseForId):
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::databaseForId): (WebCore::InspectorBackend::selectDatabase): (WebCore::InspectorBackend::getDatabaseTableNames): (WebCore::InspectorBackend::reportDidDispatchOnInjectedScript):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::selectDatabase): (WebCore::InspectorController::databaseForId): (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::selectDOMStorage): (WebCore::InspectorController::getDOMStorageResourceForId):
  • inspector/InspectorController.h:
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind):
  • inspector/InspectorDatabaseResource.h: (WebCore::InspectorDatabaseResource::database): (WebCore::InspectorDatabaseResource::id):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::selectDatabase): (WebCore::InspectorFrontend::didGetDatabaseTableNames): (WebCore::InspectorFrontend::addDOMStorage):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/Database.js: (WebInspector.Database): (WebInspector.Database.prototype.get id): (WebInspector.Database.prototype.set name): (WebInspector.Database.prototype.set version): (WebInspector.Database.prototype.set domain): (WebInspector.Database.prototype.getTableNames): (WebInspector.Database.prototype.executeSql):
  • inspector/front-end/InjectedScript.js: (InjectedScript.dispatch): (InjectedScript.executeSql): (InjectedScript.executeSql.errorCallback): (InjectedScript.executeSql.queryTransaction):
  • inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName): (InjectedScriptAccess._installHandler):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.selectDatabase): (WebInspector.StoragePanel.prototype.dataGridForResult):
  • inspector/front-end/inspector.js: (WebInspector.addDatabase):
1:23 AM Changeset in webkit [49233] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-07 Martin Robinson <martin.james.robinson@gmail.com>

[GTK] Segfault while testing fast/events/keydown-keypress-preventDefault.html
https://bugs.webkit.org/show_bug.cgi?id=30121

Clear previous preedit or pending composition before storing new ones.
This can happen when a WebView receives a native keydown event without
a matching keyup event or when preventDefault() is called on DOM keydown
events.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::setPendingComposition): (WebKit::setPendingPreedit): (WebKit::clearPendingIMData): (WebKit::imContextCommitted): (WebKit::imContextPreeditChanged):
12:42 AM Changeset in webkit [49232] by pfeldman@chromium.org
  • 4 edits in trunk/WebKit

2009-10-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: default to an attached inspector window on Windows (as on Mac).

https://bugs.webkit.org/show_bug.cgi?id=30134

WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]):

WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::showWindowWithoutNotifications):
12:40 AM Changeset in webkit [49231] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-07 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins: Disable content propagation for QGraphicsView items

We cannot support content propagation for items in QGraphicsView because
the contents of the backing store might be transformed. So turn it off
if we are not painting on QWidget.

Note that this check will not work for a QWebView in a
QGraphicsProxyWidget, but I guess it's fine. Alternative is to do an
even uglier cast: static_cast painter's paintDevice() to QWidget and
check if it is the viewport() of QGraphicsView.

https://bugs.webkit.org/show_bug.cgi?id=30149

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint):
12:38 AM Changeset in webkit [49230] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-07 Xan Lopez <xlopez@igalia.com>

Skip two new tests for which we are missing results.

  • platform/gtk/Skipped:
12:17 AM Changeset in webkit [49229] by oliver@apple.com
  • 3 edits in trunk/LayoutTests

Tidy up postMessage testcase

Reviewed by Gavin Barraclough.

12:15 AM Changeset in webkit [49228] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Qt build by adding the missing files to the build.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-07

  • WebCore.pro:
12:10 AM Changeset in webkit [49227] by kov@webkit.org
  • 3 edits in trunk/WebCore

2009-10-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Fix incorrect convertion of double into int while assigning it to
a float.

  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):
12:10 AM Changeset in webkit [49226] by kov@webkit.org
  • 3 edits in trunk/WebCore

2009-10-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Fix rounding error issues in height calculation in 64 bits.

Already covered by existing tests.

  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):
Note: See TracTimeline for information about the timeline view.