Timeline
10/13/09:
- 22:14 Changeset [49556] by
-
2009-10-13 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Ariya Hidayat.
https://bugs.webkit.org/show_bug.cgi?id=29106
[Qt] make CachedResourceHandle.h compile in winscw Symbian compiler.
Don't inline constructor CachedResourceHandle<T>(R*) to stop winscw
compiler aggressively resolve inheritance of class R.
The winscw compiler bug is reported at:
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.
The change should be reverted when the above bug is fixed in winscw compiler.
- loader/CachedResourceHandle.h: (WebCore::::CachedResourceHandle):
- 21:43 Changeset [49555] by
-
2009-10-13 Dimitri Glazkov <dglazkov@chromium.org>
No review, rolling out r49554, because it broke Win and Chromium builds.
http://trac.webkit.org/changeset/49554
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
- 21:09 Changeset [49554] by
-
2009-10-13 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Float formatting changes affect three tests:
- large-number-round-trip now passes
- opacity-float now passes and has more test cases
- compound-2d-transforms output tweaked slightly
- fast/css/large-number-round-trip-expected.txt:
- fast/css/opacity-float-expected.txt:
- fast/css/opacity-float.html:
- platform/mac/fast/css/opacity-float-expected.txt: Removed.
- transforms/2d/compound-2d-transforms-expected.txt:
- transforms/2d/compound-2d-transforms.html:
2009-10-13 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Stringify CSS units manually (without printf) to make the formatting
locale-insensitive and obey CSS spec with respect to large values.
- css/CSSPrimitiveValue.cpp: (WebCore::appendCSSDouble): (WebCore::formatWithUnits): (WebCore::CSSPrimitiveValue::cssText):
- 20:52 Changeset [49553] by
-
2009-10-13 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
Make grippy lines vertical on horizontal scrollbars in Linux Chrome.
While we're rebaselining scrollbars, fix an off by one in the vertical
scrollbar rendering too.
Tests: this is covered by every pixel test involving scrollbars.
- platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
- 20:37 Changeset [49552] by
-
2009-10-13 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
[LayoutTests][Gtk] Set a common Gtk theme as default and update the results
https://bugs.webkit.org/show_bug.cgi?id=30223
Update test results to reflect the usage of the default theme.
- platform/gtk/editing/selection/iframe-expected.txt:
- platform/gtk/editing/selection/select-box-expected.txt:
- 20:16 Changeset [49551] by
-
WebCore: Fix issue where clientX and clientY on MouseEvents were wrong when
the page was zoomed and scrolled.
Reviewed by David Hyatt.
Test: fast/events/clientXY-in-zoom-and-scroll.html
- dom/MouseRelatedEvent.cpp:
(WebCore::contentsX): Take page zoom into account.
(WebCore::contentsY): Ditto.
LayoutTests: Test issue where clientX and clientY on MouseEvents were wrong when
the page was zoomed and scrolled.
Reviewed by David Hyatt.
- fast/events/clientXY-in-zoom-and-scroll-expected.txt: Added.
- fast/events/clientXY-in-zoom-and-scroll.html: Added.
- 19:42 Changeset [49550] by
-
Fix more WebView bustage.
- WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
- 19:22 Changeset [49549] by
-
Merge r48770.
- 19:22 Changeset [49548] by
-
Merge r48689.
- 19:22 Changeset [49547] by
-
Fix build bustage on Windows.
- WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
- 19:03 Changeset [49546] by
-
Merge r48324.
- 19:03 Changeset [49545] by
-
Merge r48308.
- 18:54 Changeset [49544] by
-
Unreviewed, adding myself to reviewers list.
- Scripts/modules/committers.py:
- 18:52 Changeset [49543] by
-
Fix null assignment so root tests work again.
Reviewed by Mark Rowe.
- Scripts/webkitdirs.pm:
- 18:38 Changeset [49542] by
-
Fix DumpRenderTree to account for API changes in the user script stuff.
- 18:37 Changeset [49541] by
-
WebCore: Change the order of arguments on some of the user stylesheet/script functions. Split the removal functions
out into separate ones for scripts and stylesheets.
Reviewed by Adam Roben.
- WebCore.base.exp:
- page/PageGroup.cpp:
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
- page/PageGroup.h:
(WebCore::PageGroup::userScripts):
(WebCore::PageGroup::userStyleSheets):
WebKit/mac: Change the order of arguments on some methods. Split removal for user stylesheets and script into
separate functions based off the type of object being removed.
Reviewed by Adam Roben.
- WebView/WebView.mm:
(+[WebView _addUserScriptToGroup:worldID:source:url:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:worldID:source:url:whitelist:blacklist:]):
(+[WebView _removeUserScriptFromGroup:worldID:url:]):
(+[WebView _removeUserStyleSheetFromGroup:worldID:url:]):
(+[WebView _removeUserScriptsFromGroup:worldID:]):
(+[WebView _removeUserStyleSheetsFromGroup:worldID:]):
- WebView/WebViewPrivate.h:
WebKit/win: Split removal functions for user scripts and stylehseets based on type.
Reviewed by Adam Roben..
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp:
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
- WebView.h:
- 18:16 Changeset [49540] by
-
Chrome's "Skia" theme paints select controls backwards in RTL.
Patch by Evan Martin <evan@chromium.org> on 2009-10-13
Reviewed by Dmitry Titov.
https://bugs.webkit.org/show_bug.cgi?id=30320
Test: fast/text/international/bidi-menulist.html
(The test is about something else, but it includes RTL selects.)
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintMenuList): flip the arrow position in RTL case.
- 18:15 Changeset [49539] by
-
https://bugs.webkit.org/show_bug.cgi?id=30318
ScriptExecutionContext is not anymore needed to create an EventListener - remove old code.
It's a followup to r48884. It removed the need to pass the ScritpExecutionContext
into EventListener constructor but did not remove the code pulling ScriptExecutionContext.
Reviewed by Alexey Proskuryakov.
WebCore:
Tests:
Test adds event listener to a DocumentType Node which is created without a document
and then dispatches the event after attaching a node to the tree. Event
should fire when node is attached to the tree.
- fast/events/add-event-without-document-expected.txt: Added.
- fast/events/add-event-without-document.html: Added.
All changes in files below are the same - remove the code that calls
EventTarget::scriptExecutionContext and checks it for NULL.
- bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
- bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDesktopNotificationsCustom.cpp:
(WebCore::JSNotification::addEventListener):
(WebCore::):
- bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
- bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
LayoutTests:
Test adds event listener to a DocumentType Node which is created without a document
and then dispatches the event after attaching a node to the tree. Event
should fire when node is attached to the tree.
- fast/events/add-event-without-document-expected.txt: Added.
- fast/events/add-event-without-document.html: Added.
- 18:04 Changeset [49538] by
-
Merge r48733.
- 18:04 Changeset [49537] by
-
Merge r46725.
- 18:04 Changeset [49536] by
-
Merge r46724.
- 18:04 Changeset [49535] by
-
Merge r46648.
- 18:04 Changeset [49534] by
-
Merge r46511.
- 18:04 Changeset [49533] by
-
Merge r46387.
- 17:41 Changeset [49532] by
-
Rubber-stamped by Jon Honeycutt.
Add trailing newline to the Windows Skipped List.
- platform/win/Skipped:
- 17:36 Changeset [49531] by
-
Add bug number to previous ChangeLog entry.
- 17:34 Changeset [49530] by
-
Rubber-stamped by Anders Carlsson.
Add plugins/private-browsing-mode.html to the Windows Skipped
list because the feature is not implemented on Windows.
- platform/win/Skipped:
- 17:33 Changeset [49529] by
-
Merge r48590.
- 17:24 Changeset [49528] by
-
Merge r46645.
- 16:58 Changeset [49527] by
-
2009-10-13 Simon Fraser <simon.fraser@apple.com>
Temporary debugging changes to figure out why the webgl tests are crashing on the build bot.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 16:39 Changeset [49526] by
-
Enable SHARED_WORKERS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=30289
Patch by Drew Wilson <atwilson@atwilson-macpro.local> on 2009-10-13
Reviewed by David Levin.
WebCore:
Cleaned up bitrot in SharedWorker V8 bindings.
- WebCore.gypi:
Removed default implementation of SharedWorkerRepository so Chromium can provide its own.
- bindings/v8/DerivedSourcesAllInOne.cpp:
Added V8SharedWorkerContext.cpp.
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getTemplate):
Added case statements for SHAREDWORKER and SHAREDWORKERCONTEXT.
- bindings/v8/V8Index.cpp:
Now includes V8SharedWorkerContext.h to allow supporting SharedWorkers.
- bindings/v8/V8Index.h:
Added definition for SHAREDWORKERCONTEXT wrapper.
- bindings/v8/WorkerContextExecutionProxy.cpp:
Added includes for SharedWorker.h and SharedWorkerContext.h.
- bindings/v8/custom/V8CustomBinding.h:
Reorganized Worker field indexes to be clearer, and fixed mismatch in worker field index.
Also added field indexes for SharedWorkers.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
Added runtime enabler for the SharedWorker constructor.
- bindings/v8/custom/V8SharedWorkerCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
Cleaned up bitrot (various APIs have changed since this file was written).
- page/DOMWindow.idl:
Added EnabledAtRuntime flag to window.SharedWorker.
WebKit:
- chromium/features.gypi:
Turned on ENABLE_SHARED_WORKERS by default. This doesn't actually turn on
SharedWorkers yet, as Chromium overrides this flag in its feature_overrides.gypi.
- 16:36 Changeset [49525] by
-
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=30345
HTTP tests for credential handling fail on Tiger
We cannot prevent NSURLConnection from doing its credentil handling on Tiger anyway; so
let it do its work without intervention. Once again, we pass explicitly passed credentials
in URL, fixing regressions from Safari 3.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential):
- 16:19 Changeset [49524] by
-
2009-10-13 Roland Steiner <rolandsteiner@google.com>
Reviewed by Adam Barth.
Bug 28964 - [Chromium] ChromiumDataObject should have getter/setter interface
Reworked and added to the getter/setter interface in ChromiumDataObject:
- added contains...() methods to just query the state
- added containsValid...URL() methods for URL data members
- removed takeFileNames() as this was too type-dependent
- changed return type of fileNames() to Vector<String>
- added interface methods to allow appending to and iteration over file names
No new tests (no functional behavior changed).
- platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::containsMainURL): (WebCore::ChromiumDataObject::containsValidMainURL): (WebCore::ChromiumDataObject::containsMainURLTitle): (WebCore::ChromiumDataObject::containsTextPlain): (WebCore::ChromiumDataObject::containsTextHTML): (WebCore::ChromiumDataObject::containsHTMLBaseURL): (WebCore::ChromiumDataObject::containsValidHTMLBaseURL): (WebCore::ChromiumDataObject::containsContent): (WebCore::ChromiumDataObject::containsContentFileExtension): (WebCore::ChromiumDataObject::containsContentFileName): (WebCore::ChromiumDataObject::setContentFileName): (WebCore::ChromiumDataObject::containsFileNames): (WebCore::ChromiumDataObject::fileNames): (WebCore::ChromiumDataObject::clearFileNames): (WebCore::ChromiumDataObject::countFileNames): (WebCore::ChromiumDataObject::fileNameAt): (WebCore::ChromiumDataObject::setFileNames): (WebCore::ChromiumDataObject::appendToFileNames): (WebCore::ChromiumDataObject::popFileName):
- 16:05 Changeset [49523] by
-
Merge r49111.
- 16:03 Changeset [49522] by
-
Merge r47534.
- 15:57 Changeset [49521] by
-
Merge r49133.
- 15:53 Changeset [49520] by
-
2009-10-13 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Visibility:visible inside a compositing layer doesn't make the element visible
https://bugs.webkit.org/show_bug.cgi?id=30339
When deciding if a layer had any renderable content, RenderLayerBacking::paintIntoLayer()
only consulted hasVisibleContent(), which does not take into a account child layers which
may be visible. We also have to consult hasVisibleDescendant() as well.
Test: compositing/compositing-visible-descendant.html
- rendering/RenderLayer.h: (WebCore::RenderLayer::hasVisibleDescendant):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
- 15:51 Changeset [49519] by
-
2009-10-13 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
This is done in preparation of implementing missing features in DRT.
No functionality changes made yet.
- DumpRenderTree/qt/DumpRenderTree.cpp:
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/EventSenderQt.cpp: Added. (EventSender::EventSender): (EventSender::mouseDown): (EventSender::mouseUp): (EventSender::mouseMoveTo): (EventSender::leapForward): (EventSender::keyDown): (EventSender::contextClick): (EventSender::scheduleAsynchronousClick): (EventSender::frameUnderMouse):
- DumpRenderTree/qt/EventSenderQt.h: Added. (EventSender::clearKillRing):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added. (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::processWork): (LayoutTestController::maybeDump): (LayoutTestController::waitUntilDone): (LayoutTestController::notifyDone): (LayoutTestController::windowCount): (LayoutTestController::clearBackForwardList): (LayoutTestController::dumpEditingCallbacks): (LayoutTestController::dumpResourceLoadCallbacks): (LayoutTestController::queueBackNavigation): (LayoutTestController::queueForwardNavigation): (LayoutTestController::queueLoad): (LayoutTestController::queueReload): (LayoutTestController::queueScript): (LayoutTestController::provisionalLoad): (LayoutTestController::timerEvent): (LayoutTestController::encodeHostName): (LayoutTestController::decodeHostName): (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setFixedContentsSize): (LayoutTestController::setPrivateBrowsingEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::numberOfActiveAnimations): (LayoutTestController::disableImageLoading): (LayoutTestController::dispatchPendingLoadRequests): (LayoutTestController::setDatabaseQuota): (LayoutTestController::clearAllDatabases): (LayoutTestController::whiteListAccessFromOrigin): (LayoutTestController::waitForPolicyDelegate): (LayoutTestController::overridePreference):
- DumpRenderTree/qt/LayoutTestControllerQt.h: Added. (LayoutTestController::isLoading): (LayoutTestController::setLoading): (LayoutTestController::shouldDumpAsText): (LayoutTestController::shouldDumpBackForwardList): (LayoutTestController::shouldDumpChildrenAsText): (LayoutTestController::shouldDumpDatabaseCallbacks): (LayoutTestController::shouldDumpStatusCallbacks): (LayoutTestController::shouldWaitUntilDone): (LayoutTestController::canOpenWindows): (LayoutTestController::shouldDumpTitleChanges): (LayoutTestController::waitForPolicy): (LayoutTestController::dumpAsText): (LayoutTestController::dumpChildFramesAsText): (LayoutTestController::dumpDatabaseCallbacks): (LayoutTestController::dumpStatusCallbacks): (LayoutTestController::setCanOpenWindows): (LayoutTestController::dumpBackForwardList): (LayoutTestController::setCloseRemainingWindowsWhenComplete): (LayoutTestController::display): (LayoutTestController::dumpTitleChanges): (LayoutTestController::dumpSelectionRect):
- DumpRenderTree/qt/TextInputControllerQt.cpp: Added. (TextInputController::TextInputController): (TextInputController::doCommand):
- DumpRenderTree/qt/TextInputControllerQt.h: Added.
- DumpRenderTree/qt/WorkQueue.cpp:
- DumpRenderTree/qt/WorkQueue.h:
- DumpRenderTree/qt/WorkQueueItem.h:
- DumpRenderTree/qt/WorkQueueItemQt.cpp: Added. (findFrameNamed): (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke):
- DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
- DumpRenderTree/qt/jsobjects.h:
- 15:50 Changeset [49518] by
-
Merge r49433.
- 15:50 Changeset [49517] by
-
Merge r48492.
- 15:37 Changeset [49516] by
-
Merge r49026.
- 15:17 Changeset [49515] by
-
2009-10-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
https://bugs.webkit.org/show_bug.cgi?id=30278
Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
from the make system into common code.
Enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH if NETSCAPE_PLUGIN_API
support is not enabled.
Remove notImplemented() from PluginPackageNone.cpp and
PluginDataNone.cpp make them just empty functions.
- GNUmakefile.am:
- WebCore.pro:
- plugins/PluginDataNone.cpp: (WebCore::PluginData::initPlugins): (WebCore::PluginData::refresh):
- plugins/PluginPackageNone.cpp: (WebCore::PluginPackage::determineQuirks): (WebCore::PluginPackage::fetchInfo): (WebCore::PluginPackage::load):
2009-10-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
https://bugs.webkit.org/show_bug.cgi?id=30278
Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
from the make system into common code.
- wtf/Platform.h:
- 15:02 Changeset [49514] by
-
Not reviewed, adding myself to the list of reviewers.
- Scripts/modules/committers.py:
- 15:02 Changeset [49513] by
-
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=30150
<rdar://problem/7283540> REGRESSION: Crash when accessing clipboardData.types
Test: editing/pasteboard/crash-accessing-clipboardData-types.html
- platform/mac/ClipboardMac.mm: (WebCore::addHTMLClipboardTypesForCocoaType): The String class doesn't have operator bool, it's operator NSString* that is invoked instead, and it converts null strings to non-null @"".
- 14:59 Changeset [49512] by
-
<rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
Reviewed by Sam Weinig.
WebKit/mac:
Listen for WebPreferences notifications and update the _isPrivateBrowsingEnabled ivar
when the value changes. Also call -[WebBaseNetscapePluginView privateBrowsingModeDidChange] when the
value changes. In process this just calls NPP_SetValue, and OOP it sends a MIG message to the plug-in host.
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::privateBrowsingModeDidChange):
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
(-[WebHostedNetscapePluginView privateBrowsingModeDidChange]):
- Plugins/Hosted/WebKitPluginHost.defs:
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView privateBrowsingModeDidChange]):
(-[WebBaseNetscapePluginView viewDidMoveToWindow]):
(-[WebBaseNetscapePluginView preferencesHaveChanged:]):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView privateBrowsingModeDidChange]):
(-[WebNetscapePluginView getVariable:value:]):
WebKitTools:
Make the private browsing mode testable by the test plug-in.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginGetProperty):
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
(NPP_SetValue):
LayoutTests:
Add test.
- platform/mac-snowleopard/Skipped:
Remove now passing tests that was fixed by https://bugs.webkit.org/show_bug.cgi?id=30295.
- plugins/private-browsing-mode-expected.txt: Added.
- plugins/private-browsing-mode.html: Added.
- 14:54 Changeset [49511] by
-
Merge r47494.
- 14:44 Changeset [49510] by
-
window attributes (like localStorage) that are disabled at runtime are still visible
https://bugs.webkit.org/show_bug.cgi?id=30240
Patch by Drew Wilson <atwilson@atwilson-macpro.local> on 2009-10-13
Reviewed by Dimitri Glazkov.
Adding codegen/bindings to support runtime disabling of attributes.
No new tests (only supported by chrome currently)
- bindings/scripts/CodeGeneratorV8.pm:
Refactored the guts of GenerateBatchedAttributeData into a separate GenerateSingleBatchedAttribute with a passed-in indentation level to allow generating a single BatchedAttribute struct.
Added support for the EnabledAtRuntime extended attribute, which generates a call to the appropriate XXXXEnabled() API before adding the attribute to the instance.
- bindings/v8/V8Proxy.cpp:
(WebCore::batchConfigureAttributes):
Refactored attribute setting code into a common inline routine.
- bindings/v8/V8Proxy.h:
(WebCore::configureAttribute):
Inline function which configures a single attribute given a BatchedAttribute struct.
- bindings/v8/custom/V8CustomBinding.h:
Added (DECLARE_)ACCESSOR_RUNTIME_ENABLER to allow enabling attributes at runtime.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
Added code to enable window.Audio only if MediaPlayer.isAvailable() == true
- page/DOMWindow.idl:
Added [EnabledAtRuntime] extended attribute to the Audio attribute.
- 14:24 Changeset [49509] by
-
2009-10-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
ARM compiler does not understand reinterpret_cast<void*>
https://bugs.webkit.org/show_bug.cgi?id=29034
Change reinterpret_cast<void*> to regular C style (void*) cast
for the ARM RVCT compiler.
- assembler/MacroAssemblerCodeRef.h: (JSC::FunctionPtr::FunctionPtr):
- jit/JITOpcodes.cpp: Cast to FunctionPtr first
instead of directly casting to reinterpret_cast
- jit/JITStubCall.h: Ditto + change the type of m_stub from void* to FunctionPtr. (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::call):
- jit/JITStubs.cpp: Ditto. (JSC::DEFINE_STUB_FUNCTION(EncodedJSValue, op_throw)):
- 13:53 Changeset [49508] by
-
2009-10-13 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=27457
Test case for static email validation on type=email input elements as
per HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#e-mail-state
- fast/forms/ValidityState-typeMismatch-email-expected.txt: Added.
- fast/forms/ValidityState-typeMismatch-email.html: Added.
- fast/forms/resources/ValidityState-typeMismatch-email.js: Added. ():
2009-10-13 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=27457
Added support for static validation on type=email input elements as per
HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#e-mail-state
Test: fast/forms/ValidityState-typeMismatch-email.html
- html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch): ValidityState.typeMismatch performs validation on type=email input elements now. (WebCore::ValidityState::isValidEmailAddress): simple validation method
- html/ValidityState.h:
- 13:27 Changeset [49507] by
-
2009-10-13 Dmitry Titov <dimich@chromium.org>
Reviewed by Adam Barth.
Event listeners installed on a window object returned from window.open() don't work
https://bugs.webkit.org/show_bug.cgi?id=28716
- http/tests/security/resources/has-window-events.html: Added.
- http/tests/security/window-events-clear-domain-expected.txt: Added.
- http/tests/security/window-events-clear-domain.html: Added.
- http/tests/security/window-events-clear-port-expected.txt: Added.
- http/tests/security/window-events-clear-port.html: Added.
- http/tests/security/window-events-pass-expected.txt: Added.
- http/tests/security/window-events-pass.html: Added.
2009-10-13 Dmitry Titov <dimich@chromium.org>
Reviewed by Adam Barth.
Event listeners installed on a window object returned from window.open() don't work
https://bugs.webkit.org/show_bug.cgi?id=28716
Tests: http/tests/security/window-events-clear-domain.html
http/tests/security/window-events-clear-port.html
http/tests/security/window-events-pass.html
- dom/Document.cpp: Split code of Document::clear() in a way to avoid removing all window event handlers when implicitOpen is called. It is called in 2 cases - on committing loaded content (no need to clean handlers) and on document.open() (needs to remove handlers).
(WebCore::Document::open): in addition to calling implicitOpen it also removes window
event handlers, to preserve the behavior of document.open().
(WebCore::Document::implicitOpen): includes the part of removed Document::clear() that
does not remove window event handlers.
- dom/Document.h: Removed clear().
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): add check to avoid removing window event handlers if we transition from temporary empty document to a loaded one.
(WebCore::FrameLoader::didOpenURL): Remove closeURL() which was called twice when loading.
(WebCore::FrameLoader::finishedLoadingDocument): add closeURL() to compensate for change above.
- 13:03 Changeset [49506] by
-
Fix a leak in the inspector by calling didRemoveNode with
an error code when it fails, instead of returning from the
Backend.
Reviewed by Pavel Feldman.
- inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::removeNode):
- inspector/front-end/ElementsTreeOutline.js:
- 12:01 Changeset [49505] by
-
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30337>.
Web Inspector: Should be able to delete nodes from the Elements Tree.
Reviewed by Timothy Hatcher.
When the delete key is pressed and a element is selected in the tree,
the element should be deleted from the Elements Tree and the DOM.
- inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::removeNode):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::didRemoveNode):
- inspector/InspectorFrontend.h:
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._updateModifiedNodes):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.handleKeyEvent):
- 10:08 Changeset [49504] by
-
Fix REGRESSION(49479): Mouseover on resources graph doesn't show timings.
Reviewed by Timothy Hatcher.
Set pointer-events: none on the new overlay so mouseover events are passed
to the resources graph so we can show timings.
- inspector/front-end/inspector.css:
- 10:04 Changeset [49503] by
-
2009-10-13 Pavel Feldman <pfeldman@chromium.org>
No review, just adding self to the list of reviewers.
- Scripts/modules/committers.py:
- 07:27 Changeset [49502] by
-
2009-10-13 Girish Ramakrishnan <girish@forwardbias.in>
Reviewed by Simon Hausmann.
[Qt] Plugins : Remove all traces of winId. Use ownerWidget() instead.
This is a bug for two reasons:
- Everytime we use winId(), we end up creating a native widget. This causes an unnecessary copy of contents from the backing store to the native widget.
- Neither windowed nor windowless plugins require the winId of the QWebView or QGraphicsView.
Introduce ownerWidget() which returns a QWidget * without creating a native widget
(as opposed to QWidget::find(winId)).
- platform/qt/PlatformScreenQt.cpp: (WebCore::screenDepthPerComponent):
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::show):
- platform/qt/QWebPageClient.h:
- plugins/qt/PluginViewQt.cpp: (WebCore::setSharedXEventFields): (WebCore::PluginView::initXEvent): (WebCore::PluginView::getValue): (WebCore::PluginView::platformStart):
2009-10-13 Girish Ramakrishnan <girish@forwardbias.in>
Reviewed by Simon Hausmann.
[Qt] Plugins : Remove all traces of winId. Use ownerWidget() instead.
This is a bug for two reasons:
- Everytime we use winId(), we end up creating a native widget. This causes an unnecessary copy of contents from the backing store to the native widget.
- Neither windowed nor windowless plugins require the winId of the QWebView or QGraphicsView.
Introduce ownerWidget() which returns a QWidget * without creating a native widget
(as opposed to QWidget::find(winId)).
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::ownerWidget):
- Api/qwebview.cpp: (QWebViewPrivate::ownerWidget):
- 06:26 Changeset [49501] by
-
Unreviewed fix for typo in filename
- 05:14 Changeset [49500] by
-
2009-10-13 Pavel Feldman <pfeldman@chromium.org>
Layout test fix, reverting previous change.
Reverting r49499 as it caused several layout test failures.
- inspector/console-tests-expected.txt: Removed.
- inspector/console-tests.html: Removed.
- inspector/elements-panel-structure-expected.txt: Removed.
- inspector/elements-panel-structure.html: Removed.
- inspector/evaluate-in-frontend-expected.txt: Removed.
- inspector/evaluate-in-frontend.html: Removed.
- inspector/evaluate-in-frontend.js: Removed.
- 04:53 Changeset [49499] by
-
2009-10-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add initial layout tests for web inspector.
- inspector/console-tests-expected.txt: Added.
- inspector/console-tests.html: Added.
- inspector/elements-panel-structure-expected.txt: Added.
- inspector/elements-panel-structure.html: Added.
- inspector/evaluate-in-frontend-expected.txt: Added.
- inspector/evaluate-in-frontend.html: Added.
- inspector/evaluate-in-frontend.js: Added.
- 04:35 Changeset [49498] by
-
[Qt] Add some initial autotests for QWebPage's ErrorPageExtention
https://bugs.webkit.org/show_bug.cgi?id=30296
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.
- tests/qwebpage/tst_qwebpage.cpp:
(ErrorPage::ErrorPage):
(ErrorPage::supportsExtension):
(ErrorPage::extension):
(tst_QWebPage::errorPageExtension):
- 03:57 Changeset [49497] by
-
[Qt] better handle possible edge cases on qwebframe::requestedUrl use
https://bugs.webkit.org/show_bug.cgi?id=30216
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.
QWebFrame::requestedUrl can be called at any time during the load
process, including:
- An error handling (whereas an alternate error page for unsuccessful load is being set);
- A ssl error exception call;
- Navigation notifications (titleChanged, urlChanged, progresses, addHistoryEntry, etc);
- Among others.
This patch makes requestedUrl calls to fallback to FrameLoaderClient
m_loadError's failingURL when an error has occurred, unless it is
null/empty.
Also, m_loadError is now being reset at each the main frame starts a
load, in order to avoid previous load errors footprints.
- Api/qwebframe.cpp:
(QWebFrame::requestedUrl):
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::postProgressStartedNotification):
- 01:28 Changeset [49496] by
-
2009-10-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Adam Roben.
Web Inspector: Use proper web view in inspector layout
tests for windows.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
- 01:26 Changeset [49495] by
-
2009-10-12 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Alter profile link format to enable multiple profile types
https://bugs.webkit.org/show_bug.cgi?id=30253
The new profile URL includes the profile type along with the
profile title and uid.
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole):
- inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.linkifyStringAsFragment):
- 01:19 Changeset [49494] by
-
2009-10-12 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Fix same-named profiles grouping in the Profiles panel.
The tree node re-parenting while adding a new group node was broken.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfile):
- 01:16 Changeset [49493] by
-
2009-10-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Enforce async interaction between inspector controller and frontend.
- inspector/front-end/inspector.js: (WebInspector.dispatch.delayDispatch): (WebInspector.dispatch):
10/12/09:
- 23:11 Changeset [49492] by
-
2009-10-12 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Missing default value for the default text encoding.
https://bugs.webkit.org/show_bug.cgi?id=30311
QtWebKit has provided a default, hardcoded value for default charset but since
the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
value has had no effect.
Added a regression test and unskipped fast/dom/Document/document-charset.html,
which is passing now.
- platform/qt/Skipped:
2009-10-12 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Missing default value for the default text encoding.
https://bugs.webkit.org/show_bug.cgi?id=30311
QtWebKit has provided a default, hardcoded value for default charset but since
the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
value has had no effect.
Added a regression test and unskipped fast/dom/Document/document-charset.html,
which is passing now.
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
- Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::defaultTextEncoding):
- 22:38 Changeset [49491] by
-
Change <a name> to id="" to fix styling problems
https://bugs.webkit.org/show_bug.cgi?id=30283
Reviewed by Eric Seidel.
This prevents the headings from being styled like links.
- coding/contributing.html:
- 21:59 Changeset [49490] by
-
2009-10-12 Xiaomei Ji <xji@chromium.org>
Reviewed by Sam Weinig.
Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30034
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
- fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
- fast/dom/elementFromPoint-relative-to-viewport.html:
2009-10-12 Xiaomei Ji <xji@chromium.org>
Reviewed by Sam Weinig.
Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30034
- dom/Document.cpp: (WebCore::Document::elementFromPoint): calculate the correct point relative to document when the page is zoomed and scrolled. (WebCore::Document::caretRangeFromPoint): calculate the correct point relative to document when the page is zoomed and scrolled.
- 21:22 Changeset [49489] by
-
2009-10-12 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed. Fix 4 layout test failures by webkit r49488
WebKit r49488 enables window.WebSocket back.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- 18:44 Changeset [49488] by
-
WebCore: JavaScript bindings of WebSocket addEventListener/removeEventListener
https://bugs.webkit.org/show_bug.cgi?id=29841
Patch by Fumitoshi Ukai <ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).
Test: fast/websockets/websocket-event-target.html
- bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- websockets/WebSocket.idl:
WebKitTools: Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
https://bugs.webkit.org/show_bug.cgi?id=29841
Patch by Fumitoshi Ukai <ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
LayoutTests: Add a test to verify WebSocket's EventTarget methods.
https://bugs.webkit.org/show_bug.cgi?id=29841
Patch by Fumitoshi Ukai <ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).
- fast/websockets/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/canvas/script-tests/TEMPLATE.html.
- fast/websockets/script-tests/websocket-event-target.js: Added.
(openListener):
(messageListener):
(closeListener):
- fast/websockets/websocket-event-target-expected.txt: Added.
- fast/websockets/websocket-event-target.html: Added.
- 17:47 Changeset [49487] by
-
Fix for https://bugs.webkit.org/show_bug.cgi?id=29078
<rdar://problem/7288221>
Reviewed by Darin Adler.
WebCore:
Add a mechanism to blacklist certain codecs. Initially, just blacklist UTF-7 as HTML5 encourages.
- platform/text/TextEncodingRegistry.cpp:
(WebCore::pruneBlacklistedCodecs):
(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):
LayoutTests:
Test the lack of UTF-7 support. Remove old UTF-7 tests.
- fast/encoding/char-decoding-expected.txt:
- fast/encoding/char-decoding.html:
- http/tests/misc/submit-get-in-utf7-expected.txt: Removed.
- http/tests/misc/submit-get-in-utf7.html: Removed.
- http/tests/misc/submit-post-in-utf7-expected.txt: Removed.
- http/tests/misc/submit-post-in-utf7.html: Removed.
- http/tests/misc/url-in-utf7-expected.txt: Removed.
- http/tests/misc/url-in-utf7.html: Removed.
- http/tests/security/xssAuditor/http-equiv-utf-7-encoded-expected.txt: Removed.
- http/tests/security/xssAuditor/http-equiv-utf-7-encoded.html: Removed.
- http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Removed.
- http/tests/security/xssAuditor/script-tag-utf-7-encoded-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-utf-7-encoded.html: Removed.
- http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-utf-7.html: Removed.
- 17:37 Changeset [49486] by
-
Add support for the beforeload event to frames. Complete support of the beforeload event by making sure
its wrapper gets properly constructed (so that the URL field of the event can be accessed). Add support
for the Objective-C wrapper class as well.
Reviewed by Darin Adler.
Added fast/dom/beforeload/frame-before-load.html
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
- bindings/objc/DOMEvents.mm:
(kitClass):
- dom/BeforeLoadEvent.h:
(WebCore::BeforeLoadEvent::isBeforeLoadEvent):
- dom/Event.cpp:
(WebCore::Event::isBeforeLoadEvent):
- dom/Event.h:
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseMappedAttribute):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithDocumentLoader):
- 17:27 Changeset [49485] by
-
2009-10-12 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium Port - Windows
https://bugs.webkit.org/show_bug.cgi?id=29969
- chromium/DEPS: Added gtest dep required by windows and incremented some of the deps revisions.
2009-10-12 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium Port - Windows
https://bugs.webkit.org/show_bug.cgi?id=29969
- Scripts/pdevenv: removed msvc's /useenv for chromium builds
- Scripts/webkitdirs.pm:
- 17:15 BuildingQtOnLinux edited by
- added error relating to phonon (diff)
- 16:49 Changeset [49484] by
-
WebCore: Fix <rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()
Reviewed by Simon Fraser.
Test: fast/dynamic/position-absolute-to-fixed-crash.html
The crash was caused by stale positioned objects lists following an
object transitioning from being absolutely position to being fixed
positioned.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange): In case of a transition between
absolute and fixed position, mark the parent as having a child needing
layout, so that this object will get inserted into its new container's
positioned objects list.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange): Changed a condition to cover
this transition, so that this object gets removed from its current
container's positioned objects list.
LayoutTests: Test for <rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()
Reviewed by Simon Fraser.
- fast/dynamic/position-absolute-to-fixed-crash-expected.txt: Added.
- fast/dynamic/position-absolute-to-fixed-crash.html: Added.
- 16:20 Changeset [49483] by
-
2009-10-12 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Add a palette() method that is needed by our RenderTheme.
- platform/qt/QWebPageClient.h:
2009-10-12 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Implement the new palette() methods on the page clients
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::palette):
- Api/qwebview.cpp: (QWebViewPrivate::palette):
- 16:16 Changeset [49482] by
-
Fix release builds.
- 16:05 Changeset [49481] by
-
2009-10-12 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Three old test results give back the absolute position instead of the realtive position.
The new test will check the correct behavior of gradients in userSpaceOnUse mode and
values in percentage.
- platform/mac/svg/custom/gradient-attr-update-expected.txt:
- platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
- platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum: Added.
- platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Added.
- platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt: Added.
- platform/mac/svg/custom/text-gradient-no-content-expected.txt:
- svg/custom/gradient-userSpaceOnUse-with-percentage.svg: Added.
2009-10-12 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Gradients can't handle percentage values in userSpaceOnUse mode
https://bugs.webkit.org/show_bug.cgi?id=30286
Fixed *GradientAttributes to take SVGLength instead of double. This casues
the problem, that we can't calculate the correct size of a gradient on
userSpaceOnUse mode with percentage values.
Test: svg/custom/gradient-userSpaceOnUse-with-percentage.svg
- svg/LinearGradientAttributes.h: (WebCore::LinearGradientAttributes::LinearGradientAttributes): (WebCore::LinearGradientAttributes::x1): (WebCore::LinearGradientAttributes::y1): (WebCore::LinearGradientAttributes::x2): (WebCore::LinearGradientAttributes::y2): (WebCore::LinearGradientAttributes::setX1): (WebCore::LinearGradientAttributes::setY1): (WebCore::LinearGradientAttributes::setX2): (WebCore::LinearGradientAttributes::setY2):
- svg/RadialGradientAttributes.h: (WebCore::RadialGradientAttributes::RadialGradientAttributes): (WebCore::RadialGradientAttributes::cx): (WebCore::RadialGradientAttributes::cy): (WebCore::RadialGradientAttributes::r): (WebCore::RadialGradientAttributes::fx): (WebCore::RadialGradientAttributes::fy): (WebCore::RadialGradientAttributes::setCx): (WebCore::RadialGradientAttributes::setCy): (WebCore::RadialGradientAttributes::setR): (WebCore::RadialGradientAttributes::setFx): (WebCore::RadialGradientAttributes::setFy):
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient): (WebCore::SVGLinearGradientElement::collectGradientProperties):
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient): (WebCore::SVGRadialGradientElement::collectGradientProperties):
- 15:39 Changeset [49480] by
-
Merge r49218.
- 15:33 Changeset [49479] by
-
Fixes <http://webkit.org/b/30315>.
Web Inspector: DOM Content and Load lines in Resources are unclear what they mean.
Reviewed by Timothy Hatcher.
Add tooltip text to the Load event and DOM Content event lines through
a new layer that allows these lines to be on top of the view.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
(WebInspector.ResourcesPanel.prototype._updateDividersLabelBarPosition):
- inspector/front-end/inspector.css:
- 15:32 Changeset [49478] by
-
Merge r48946.
- 15:32 Changeset [49477] by
-
Merge r47883.
- 15:25 Changeset [49476] by
-
jsc scripts cleanup and Qt/GTK fix
https://bugs.webkit.org/show_bug.cgi?id=30288
Patch by Csaba Osztrogonac <ossy@webkit.org> on 2009-10-12
Reviewed by Darin Adler.
Duplicated jscPath() moved to webkitdirs.pm.
New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
Configuration added (release/debug) to path for Qt-port on Windows.
- Scripts/run-javascriptcore-tests:
- Scripts/run-jsc:
- Scripts/run-sunspider:
- Scripts/sunspider-compare-results:
- Scripts/webkitdirs.pm:
- 15:25 Changeset [49475] by
-
Merge r48787.
- 15:25 Changeset [49474] by
-
Merge r48775.
- 14:30 Changeset [49473] by
-
2009-10-12 Dimitri Glazkov <dglazkov@chromium.org>
No review, rolling out r49429, because it broke layout tests.
http://trac.webkit.org/changeset/49429
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
- 14:15 Changeset [49472] by
-
2009-10-12 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
SVG - crash on feMerge when input not available
https://bugs.webkit.org/show_bug.cgi?id=30297
Make a early return in SVGFEMergeElement if the needed
filter effect doesn't exist.
Test: svg/filters/feMerge-wrong-input.svg
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
2009-10-12 Dirk Schulze <krit@webkit.org>
Reviewed by Eirc Seidel.
feMergeNod has a reference to an effect that doesn't exist. This test will
check if SVGFEMergeElement handles this correctly and stops the filter process.
- svg/filters/feMerge-wrong-input-expected.checksum: Added.
- svg/filters/feMerge-wrong-input-expected.png: Added.
- svg/filters/feMerge-wrong-input-expected.txt: Added.
- svg/filters/feMerge-wrong-input.svg: Added.
- 14:07 Changeset [49471] by
-
Merge r48572.
- 14:07 Changeset [49470] by
-
Merge r47801.
- 14:07 Changeset [49469] by
-
Merge r47771.
- 14:00 Changeset [49468] by
-
Merge r48848.
- 14:00 Changeset [49467] by
-
Merge r48547.
- 14:00 Changeset [49466] by
-
Merge r48546.
- 14:00 Changeset [49465] by
-
Merge r47900.
- 14:00 Changeset [49464] by
-
Merge r48743.
- 13:49 Changeset [49463] by
-
Merge r46136.
- 13:49 Changeset [49462] by
-
Merge r47509.
- 13:42 Changeset [49461] by
-
2009-10-12 Csaba Osztrogonac <ossy@webkit.org>
Unreviewed. Added myself to committers.py.
- Scripts/modules/committers.py:
- 13:42 Changeset [49460] by
-
Merge r48647.
- 13:42 Changeset [49459] by
-
Merge r46521.
- 13:38 Changeset [49458] by
-
Merge r47551.
- 13:38 Changeset [49457] by
-
Merge r47300.
- 13:34 Changeset [49456] by
-
Merge r48957.
- 13:34 Changeset [49455] by
-
Merge r48956.
- 13:34 Changeset [49454] by
-
Merge r48953.
- 13:33 Changeset [49453] by
-
Merge r46548.
- 13:19 Changeset [49452] by
-
Merge r48369.
- 13:19 Changeset [49451] by
-
Merge r47657.
- 13:19 Changeset [49450] by
-
Merge r46058.
- 13:19 Changeset [49449] by
-
Merge r45945.
- 13:19 Changeset [49448] by
-
Merge r48725.
- 13:03 WebKit Team edited by
- (diff)
- 13:00 Changeset [49447] by
-
Added automatic flush before compositing
https://bugs.webkit.org/show_bug.cgi?id=30236
This causes image to always render correctly. In writing a testcase
I needed to implement readPixels. This exposed a bug in reading back
values from a CanvasArray subclass, so I fixed that as well. Now when
you wrap a CanvasArray in a JSValue it actually wraps the specific
subclass. To do this I need to add virtual methods to each CanvasArray
subclass to determine the type and a custom toJS method for CanvasArray
to create the proper wrapper.
Test: fast/canvas/webgl/triangle.html
- 12:38 Changeset [49446] by
-
2009-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Update Fedora httpd.conf settings to closely match the generic httpd.conf
https://bugs.webkit.org/show_bug.cgi?id=30302
Closely match the default httpd.conf for layout tests.
- http/conf/fedora-httpd.conf:
- 11:09 Changeset [49445] by
-
2009-10-12 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Fix 0 sentinel for g_object_set() function call.
- platform/graphics/gtk/DataSourceGStreamer.cpp: (webkit_data_src_uri_set_uri): 0 is passed as 32 bit value on x86-64 in vararg functions, but g_object_set() expects a 64 bit 0. This will cause crashes.
- 11:05 Changeset [49444] by
-
2009-10-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Remove unnecessary self-include.
- webkit/webkitsecurityorigin.h:
- 09:29 Changeset [49443] by
-
2009-10-12 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Video keeps playing after going fullscreen, then closing window
https://bugs.webkit.org/show_bug.cgi?id=30164
Clear the QTMovie on the QTMovieView when coming out of fullscreen,
to fix issue where the underlying movie keeps playing.
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidExitFullscreen]):
- 08:52 Changeset [49442] by
-
2009-10-12 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Tor Arne Vestbø.
[Qt] Add expected files for new passing fast tests.
- platform/qt/fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
- platform/qt/fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.
- platform/qt/fast/css/text-rendering-expected.txt: Added.
- platform/qt/fast/forms/basic-buttons-expected.txt: Added.
- platform/qt/fast/forms/basic-inputs-expected.txt: Added.
- platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt: Added.
- platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt: Added.
- platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Added.
- 08:26 Changeset [49441] by
-
2009-10-12 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Drop in="" from <feFlood>
https://bugs.webkit.org/show_bug.cgi?id=29001
This makes <feFlood in="bogus"> have an effect, too.
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute
Test: svg/dom/feFlood-no-in1.html
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::build):
- svg/SVGFEFloodElement.h:
- svg/SVGFEFloodElement.idl:
- svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::FEFlood): (WebCore::FEFlood::create):
- svg/graphics/filters/SVGFEFlood.h:
LayoutTest:
Drop in="" from <feFlood>
https://bugs.webkit.org/show_bug.cgi?id=29001
This makes <feFlood in="bogus"> have an effect, too.
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute
- svg/dom/feFlood-no-in1-expected.txt: Added.
- svg/dom/feFlood-no-in1.html: Added.
- svg/dom/script-tests/feFlood-no-in1.js: Added.
- 08:05 Changeset [49440] by
-
2009-10-12 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
QWebPage's createViewlessPlugin autotest crash fix.
It is possible that plugins that are QWidgets or QGraphicsWidgets
are created before a view has been assigned to a QWebPage. The
plug-ins won't be fully functional, as by design, they should
visualise something, but they won't crash and will stay in memory.
An autotest that covers this use-case, is included.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
- tests/qwebpage/tst_qwebpage.cpp: (PluginTrackedPageWidget::PluginTrackedPageWidget): (PluginTrackedPageGraphicsWidget::PluginTrackedPageGraphicsWidget): (PluginTrackedPageGraphicsWidget::createPlugin): (tst_QWebPage::destroyPlugin): (tst_QWebPage::createViewlessPlugin):
- 07:34 Changeset [49439] by
-
2009-10-12 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Scale video to completely fill the target surface while
keeping the aspect ratio. This fixes displaying of the
YouTube HTML5 sample website.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Scale video to completely fill the target surface, keep the aspect ratio and center it.
- 07:18 Changeset [49438] by
-
2009-10-12 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Fixes double memcpy of all rendered video frames.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateRepaintCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::duration):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_timeout_func): (webkit_video_sink_dispose): (unlock_buffer_mutex): (webkit_video_sink_unlock): (marshal_VOIDMINIOBJECT): (webkit_video_sink_class_init): (webkit_video_sink_new):
- platform/graphics/gtk/VideoSinkGStreamer.h: Directly pass the buffers up to the MediaPlayerPrivate::paint() method instead of rendering them first to an intermediate cairo surface. This should increase performance and peak memory usage.
- 07:15 Changeset [49437] by
-
2009-10-12 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha.
[GTK] Crash when right-clicking misspelled word
https://bugs.webkit.org/show_bug.cgi?id=29772
Make sure the dictionary exist before adding it to the list of
dictionaries.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::checkSpellingOfString):
- webkit/webkitwebsettings.cpp: (webkit_web_settings_set_property):
- 04:56 Changeset [49436] by
-
2009-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubberstamped by Eric Seidel.
[Gtk] Fix icu CFLAG for Darwin
https://bugs.webkit.org/show_bug.cgi?id=29517
Don't escape the srcdir variable. Also use $host instead of the
os_foo variables.
- autotools/webkit.m4:
- 04:55 Changeset [49435] by
-
2009-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[Gtk] Use the SQLite3 headers from WebKitLibraries if sqlite3 is undetected
https://bugs.webkit.org/show_bug.cgi?id=29518
- configure.ac:
- 03:14 QtBackLog edited by
- Add new items and pointers to them (diff)
10/11/09:
- 23:50 Changeset [49434] by
-
2009-10-11 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Fixes an issue where JavaScript URLs that are URL-encoded twice can
bypass the XSSAuditor.
JavaScript URLs that are completed by method Document::completeURL have added
URL-encoded characters such that a direct comparison with the URL-decoded
outgoing HTTP parameters is not sufficient. Instead, the URL-decoded outgoing
HTTP parameters must be URL-decoded before comparison.
Tests: http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL): Modified to pass XSSAuditor the URL-decoded source code for the JavaScript URL.
- page/XSSAuditor.cpp: (WebCore::isIllegalURICharacter): Minor syntactical change to the comment. (WebCore::XSSAuditor::CachingURLCanonicalizer::canonicalizeURL): Added parameter decodeURLEscapeSequencesTwice. (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::decodeURL): Ditto. (WebCore::XSSAuditor::findInRequest): Ditto.
- page/XSSAuditor.h: (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer): Ditto.
2009-10-11 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Tests that JavaScript URLs that are twice URL encoded do not bypass the XSSAuditor.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html: Added.
- 21:17 Changeset [49433] by
-
WebKit/mac: <rdar://problem/7294267> REGRESSION (r48492): Gmail voice and video chat
doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30295
Reviewed by Darin Adler.
Test: plugins/setProperty.html
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::setFieldValue): Fixed a typo. The function
should return early if m_instanceProxy is null.
LayoutTests: Test for <rdar://problem/7294267> REGRESSION (r48492): Gmail voice and
video chat doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30295
Reviewed by Darin Adler.
- plugins/setProperty-expected.txt: Added.
- plugins/setProperty.html: Added.
- 20:30 Changeset [49432] by
-
2009-10-11 Dominic Cooney <dominicc@google.com>
Reviewed by Adam Barth.
Fixes a build break in the V8 bindings caused by revision 49420.
https://bugs.webkit.org/show_bug.cgi?id=30294
Revision 49420 introduces an IDL-defined CanvasActiveInfo
type. This causes a build break in the V8 bindings where
CanvasGraphicsContext3D naively refers to CanvasActiveInfo as a
non-ref type.
- WebCore.gypi: Include CanvasActiveInfo.idl in build.
- bindings/scripts/CodeGeneratorV8.pm: CanvasActiveInfo is a ref ptr type.
- bindings/v8/DOMObjectsInclude.h: Include generated CanvasActiveInfo files.
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- 20:15 Changeset [49431] by
-
2009-10-11 Collin Jackson <collinj@webkit.org>
Reviewed by Adam Barth.
Log mixed content warnings to console
- loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent):
- 19:53 Changeset [49430] by
-
2009-10-11 Adam Barth <abarth@webkit.org>
Unreviewed. Add Collin to committers.py.
- Scripts/modules/committers.py:
- 19:36 QtBackLog edited by
- (diff)
- 15:48 Changeset [49429] by
-
2009-10-11 Søren Gjesse <sgjesse@chromium.org>
Reviewed by Adam Barth.
[V8] Add a context scope in JS listener destructor. The destructor code uses the cotext. See http://crbug.com/24200.
https://bugs.webkit.org/show_bug.cgi?id=30250
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
- 15:34 Changeset [49428] by
-
2009-10-11 Lyon Chen <lyon.chen@torchmobile.com>
Reviewed by Alexey Proskuryakov.
Correct the position of #endif sentence inside WebCore::Document::finishedParsing().
This change requires no test case as it fix a compiling error.
- dom/Document.cpp: (WebCore::Document::finishedParsing):
- 15:17 Changeset [49427] by
-
2009-10-11 Dominic Cooney <dominicc@google.com>
Reviewed by Adam Barth.
Sets a 500K stack limit for JavaScript workers in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=29797
Runaway recursion in JavaScript workers crashes the Chromium
worker process on OS X. This is because V8's default stack limit
is 512K on ia32 or 1M on x64, but the worker process runs workers
on a thread with the OS X default stack size--512K. Because there
are already some C++ frames on the stack when V8 establishes its
512K default stack limit, and V8 doesn't precisely enforce the
stack limit, runaway recursion in V8 workers overflows the OS
stack and segfaults, killing the worker process. This is described
in Chromium bug 21653 <http://crbug.com/21653>.
This patch sets the V8 stack limit for worker JavaScript in
Chromium to a more conservative 500K on all platforms. This allows
some "headroom" for the C++ stack in use when the limit is set up,
and some "legroom" for the V8 helper functions which in practice
briefly flout the V8 stack limit.
Test: LayoutTests/fast/workers/use-machine-stack.html
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
- bindings/v8/WorkerContextExecutionProxy.h:
- 14:30 Changeset [49426] by
-
Re-enable the JIT.
- 13:01 Changeset [49425] by
-
wx build fixes, adding bindings to include/source dirs and fixing wxMac 2.9 compilation.
- 02:46 Changeset [49424] by
-
Allow [Reflect] on SVG elements.
https://bugs.webkit.org/show_bug.cgi?id=28936
Reviewed by Sam Weinig.
Update the JS binding generators to reference SVGNames instead of
HTMLNames, if [Reflect]ing an attribute on an SVG element. Make
SVGElement::id use [Reflect].
Also make [Reflect] on an attribute with a setter exception work in ObjC
bindings.
WebCore:
Test: svg/dom/id-reflect.html
- bindings/scripts/CodeGenerator.pm: Add a function to determine the
appropriate C++ namespace for attribute name constants.
- bindings/scripts/CodeGeneratorObjC.pm: Generate ExceptionCode handling
code for [Reflect] on an attribute with a setter exception.
- bindings/scripts/CodeGeneratorCOM.pm: Generate "SVGNames" instead of
"HTMLNames" when appropriate.
- bindings/scripts/CodeGeneratorJS.pm: Ditto.
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
- svg/SVGElement.cpp: Remove getter and setter methods for id.
- svg/SVGElement.h: Ditto.
- svg/SVGElement.idl: Add [Reflect] to id.
LayoutTests:
- svg/dom/script-tests/id-reflect.js: Added.
- svg/dom/id-reflect-expected.txt: Added.
- svg/dom/id-reflect.html: Added.
10/10/09:
- 20:47 Changeset [49423] by
-
Support for String.trim(), String.trimLeft() and String.trimRight() methods
https://bugs.webkit.org/show_bug.cgi?id=26590
Reviewed by Maciej Stachowiak.
Implement trim, trimLeft, and trimRight
- 15:10 Changeset [49422] by
-
REGRESSION (r49414): Rebaseline needed for Windows / Gtk Linux
https://bugs.webkit.org/show_bug.cgi?id=30279
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-10
Reviewed by Eric Seidel.
- platform/gtk/editing/style/5228141-expected.txt: Same rebaseline done for Mac in r49414
- platform/win/editing/execCommand/toggle-compound-styles-expected.txt: two i tags are merged properly
- 14:46 Changeset [49421] by
-
Fix paths in xcode.
- 14:16 Changeset [49420] by
-
Implement getActiveAttrib and getActiveUniform
https://bugs.webkit.org/show_bug.cgi?id=30276
Reviewed by Eric Carlson.
Implements the getActiveAttrib and getActiveUniform APIs.
Rather simple patch, adds CanvasActiveInfo definition and implementation
and adds forwarding to the GraphicsContext3D.
Test: fast/canvas/webgl/getActiveTest.html
- 12:21 Changeset [49419] by
-
2009-10-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Adding new attributes in Element Panel is
counterintuitive.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmousemove): (WebInspector.ElementsTreeElement.prototype.set hovered): (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton):
- 09:19 Changeset [49418] by
-
2009-10-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Holger Freyther.
Build fix if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=30275
In addition to fixing the build break with guards
remove notImplemented() from PluginViewNone.cpp and
make them just just be empty functions.
- plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): (WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/PluginViewNone.cpp: (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::paint): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::handlePostReadFile): (WebCore::PluginView::getValue): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::invalidateRect): (WebCore::PluginView::invalidateRegion): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy): (WebCore::PluginView::setParentVisible): (WebCore::PluginView::updatePluginWidget):
- 08:56 Changeset [49417] by
-
2009-10-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed.
Add HistoryController.cpp to the build.
- WebCore.pro:
- 06:53 Changeset [49416] by
-
2009-10-09 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
[Chromium] KURLGoogle's protocolIs barfs on input containing hyphens
https://bugs.webkit.org/show_bug.cgi?id=30262
This is not testable from WebKit since WebKit never uses the member
function form of protocolIs with input that can be controlled from a
web page. It always passes string literals lacking hyphens.
- platform/KURLGoogle.cpp: (WebCore::lowerCaseEqualsASCII): Only assert if toASCIILower would transform the input character.
- 03:04 BuildingQtOnWindows edited by
- (diff)
- 02:11 Changeset [49415] by
-
2009-10-10 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Move HistoryController to its own file
https://bugs.webkit.org/show_bug.cgi?id=30272
Purely mechanical.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/HistoryController.cpp: Added.
- loader/HistoryController.h: Added.
10/09/09:
- 20:36 Changeset [49414] by
-
ApplyStyleCommand removes presentational tags even when not necessary
https://bugs.webkit.org/show_bug.cgi?id=28091
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-09
Reviewed by Eric Seidel.
WebCore:
This patch updates implicitlyStyledElementShouldBeRemovedWhenApplyingStyle to return true
(triggering removal of tag) only if the style implicitly added by the element is not present in
the new style to apply. It also changes surroundNodeRangeWithElement so that it merges the
surrounding element when possible. applyTextDecorationStyle is modified so that it does not add
style span when the style attribute is empty.
Test: editing/execCommand/toggle-style-3.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::shouldRemoveTextDecorationTag): Returns true if specified text
decoration is not present in the style to apply
(WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): No longer
returns true if the tag is used in new style
(WebCore::ApplyStyleCommand::applyTextDecorationStyle): Does not add style-span when redundant
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Merges the newly created element
with the surrounding identical elements
- editing/ApplyStyleCommand.h:
LayoutTests:
This patch adds test to make sure to preserve presentational tag
(u, s, strike, i, em, sup, sub, b, & strong) when the corresponding style is present in
the final computed style. i.e. avoid removing tag and re-applying the style later
- editing/execCommand/19653-2-expected.txt: Two b elements are merged.
- editing/execCommand/createLink-expected.txt: Two anchor elements are merged.
- editing/execCommand/script-tests/toggle-style-3.js: Added.
(testSingleToggle):
- editing/execCommand/strikethroughSelection-expected.txt: Redundant style spans are no longer added.
- editing/execCommand/toggle-style-3-expected.txt: Added.
- editing/execCommand/toggle-style-3.html: Added.
- editing/execCommand/unlink-expected.txt: Two anchor elements are merged.
- platform/mac/editing/style/5228141-expected.txt: Two b elements are merged.
- platform/mac/editing/style/style-boundary-001-expected.txt: Two b elements are merged.
- 19:27 Changeset [49413] by
-
2009-10-09 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor HistoryController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30246
Update API call.
- WebView.cpp: (WebView::loadBackForwardListFromOtherView):
2009-10-09 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor HistoryController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30246
Update API call.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::restoreViewState):
- WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]):
2009-10-09 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor HistoryController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30246
HistoryController is in charge of managing the current / previous /
provisional HistoryItems. The split isn't perfect, but it's a place to
start. I'll move HistoryController into its own file in another patch.
- WebCore.base.exp:
- loader/FrameLoader.cpp: (WebCore::HistoryController::HistoryController): (WebCore::HistoryController::~HistoryController): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::closeURL): (WebCore::FrameLoader::begin): (WebCore::HistoryController::restoreDocumentState): (WebCore::HistoryController::setCurrentItem): (WebCore::HistoryController::setProvisionalItem): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::scrollToAnchor): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::didFirstLayout): (WebCore::HistoryController::updateForFrameLoadCompleted): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::HistoryController::addHistoryItemForFragmentScroll): (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): (WebCore::HistoryController::createHistoryItem): (WebCore::FrameLoader::checkDidPerformFirstNavigation): (WebCore::HistoryController::addBackForwardItemClippedAtTarget): (WebCore::HistoryController::createHistoryItemTree): (WebCore::HistoryController::saveScrollPositionAndViewStateToItem): (WebCore::HistoryController::restoreScrollPositionAndViewState): (WebCore::HistoryController::invalidateCurrentItemCachedPage): (WebCore::HistoryController::saveDocumentState): (WebCore::FrameLoader::loadItem): (WebCore::HistoryController::urlsMatchItem): (WebCore::HistoryController::goToItem): (WebCore::HistoryController::recursiveGoToItem): (WebCore::HistoryController::childFramesMatchItem): (WebCore::HistoryController::updateForStandardLoad): (WebCore::HistoryController::updateForClientRedirect): (WebCore::HistoryController::updateForBackForwardNavigation): (WebCore::HistoryController::updateForReload): (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): (WebCore::HistoryController::updateForCommit): (WebCore::HistoryController::updateForAnchorScroll): (WebCore::HistoryController::saveDocumentAndScrollState): (WebCore::HistoryController::setCurrentItemTitle): (WebCore::FrameLoader::didChangeTitle):
- loader/FrameLoader.h: (WebCore::HistoryController::current): (WebCore::HistoryController::provisional): (WebCore::FrameLoader::policyChecker): (WebCore::FrameLoader::history): (WebCore::FrameLoader::creatingInitialEmptyDocument):
- page/Page.cpp: (WebCore::Page::goToItem):
- 17:53 Changeset [49412] by
-
Try to fix Windows build by adding needed exports.
- 17:46 Changeset [49411] by
-
WebKit/mac: <rdar://problem/7290671> Crash after navigating away from a page with subframe containing plug-in
Reviewed by Brady Eidson.
At the time that -stop is called on a WebBaseNetscapePluginView that is contained within a subframe
the WebFrame's data source has been zeroed out. This was causing -[WebBaseNetscapePluginView webFrame]
to return nil during -stop, preventing the plug-in view from unregistering itself from the PluginHalter.
We fix this by having -webFrame retrieve the frame directly rather than retrieving it from the data source.
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView dataSource]): Get the data source from the WebFrame.
(-[WebBaseNetscapePluginView webFrame]): Get the Frame directly from the element's document rather
than taking a windy route through the WebDataSource.
WebKitTools: Enable plug-in halting in DumpRenderTree.
We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:shouldHaltPlugin:]):
- 17:38 Changeset [49410] by
-
Unreviewed - fixing an obvious typo in my previous check-in.
https://bugs.webkit.org/show_bug.cgi?id=30260
<rdar://problem/6447115> REGRESSION: Logging out from SAP doesn't work
Fixes existing tests (which I thought I had run the previous time).
- platform/network/CredentialStorage.cpp: (WebCore::originsWithCredentials): Return the set by reference.
- 17:30 Changeset [49409] by
-
Eliminated some legacy bytecode weirdness.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-09
Reviewed by Oliver Hunt.
Use vPC[x] subscripting instead of ++vPC to access instruction operands.
This is simpler, and often more efficient.
To support this, and to remove use of hard-coded offsets in bytecode and
JIT code generation and dumping, calculate jump offsets from the beginning
of an instruction, rather than the middle or end.
Also, use OPCODE_LENGTH instead of hard-coded constants for the sizes of
opcodes.
SunSpider reports no change in JIT mode, and a 1.01x speedup in Interpreter
mode.
- bytecode/CodeBlock.cpp:
(JSC::printConditionalJump):
(JSC::CodeBlock::dump):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJump):
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
(JSC::BytecodeGenerator::emitComplexJumpScopes):
(JSC::BytecodeGenerator::emitJumpScopes):
(JSC::BytecodeGenerator::emitNextPropertyName):
(JSC::BytecodeGenerator::emitCatch):
(JSC::BytecodeGenerator::emitJumpSubroutine):
(JSC::prepareJumpTableForImmediateSwitch):
(JSC::prepareJumpTableForCharacterSwitch):
(JSC::prepareJumpTableForStringSwitch):
(JSC::BytecodeGenerator::endSwitch):
- bytecompiler/Label.h:
(JSC::Label::setLocation):
(JSC::Label::bind):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveBase):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::Interpreter::createExceptionScope):
(JSC::Interpreter::privateExecute):
- interpreter/Interpreter.h:
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emitBinaryDoubleOp):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_loop):
(JSC::JIT::emit_op_loop_if_less):
(JSC::JIT::emitSlow_op_loop_if_less):
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emitSlow_op_loop_if_lesseq):
(JSC::JIT::emit_op_loop_if_true):
(JSC::JIT::emitSlow_op_loop_if_true):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_jmp_scopes):
- 16:28 Changeset [49408] by
-
[v8] Need change to V8WorkerContextEventListener::reportError signature to match the base class.
https://bugs.webkit.org/show_bug.cgi?id=30264
Patch by David Levin <levin@chromium.org> on 2009-10-09
Reviewed by Eric Seidel.
The base class method changed in r48884.
Test: fast/worker/worker-script-error.html
- bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::reportError):
- bindings/v8/V8WorkerContextEventListener.h:
- 15:45 Changeset [49407] by
-
Fix bad ChangeLog entry merge in r49019 by the commit queue script.
- 15:29 Changeset [49406] by
-
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=30260
<rdar://problem/6447115> REGRESSION: Logging out from SAP doesn't work
Tests: http/tests/xmlhttprequest/logout.html
http/tests/xmlhttprequest/re-login-async.html
http/tests/xmlhttprequest/re-login.html
Fix several issues with existing credential handling code.
- platform/network/CredentialStorage.cpp: (WebCore::pathToDefaultProtectionSpaceMap): Changed the data structure to a simpler one. (WebCore::originsWithCredentials): The reason for two-stage lookup above was that we didn't want to iterate paths for origins that never had credentials associated with them. Changed to use a separate HashSet for this. (WebCore::pathToDefaultProtectionSpaceMap): The concept of default per-path credentials didn't match the spec very well. UAs are supposed to deduce protection space from an URL, and then use whichever credentials are known for this protection space. So, OriginToDefaultBasicCredentialMap is now PathToDefaultProtectionSpaceMap. (WebCore::protectionSpaceMapKeyFromURL): Factored out a helper that extracts a directory URL from a given URL. These directory URLs are what we use as keys in PathToDefaultProtectionSpaceMap. (WebCore::CredentialStorage::set): Updated for above changes. (WebCore::findDefaultProtectionSpaceForURL): Factored out code iterating path length to find a prefix in OriginToDefaultBasicCredentialMap. (WebCore::CredentialStorage::set): Another version of set() can update credentials for a URL default protection space. It does nothing if the given URL doesn't correspond to a known protection space. (WebCore::CredentialStorage::get): Renamed from getDefaultAuthenticationCredential.
- platform/network/CredentialStorage.h: Made the distinction between methods that use a known protection space and those that deduce one from URL more clear.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Update credentials before starting the request for real. This makes the following pattern work: var req = new XMLHttpRequest("GET", "logout.html", "logout", "logout"); wrong credentials req.send(""); req.abort(); Abort() is used here to avoid having UA present an auth dialog after getting a 401 response. Note that one cannot log in using the same method, because there isn't a known protection space for the URL yet in that case, so the added code has no effect. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Use a correct persistence for calling receivedCredential(). This fixes logging in using an async XHR (withut abort(), of course), and matches sync case. (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Renamed getDefaultAuthenticationCredential() to get().
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start): (WebCore::WebCoreSynchronousLoader::load): Same changes as in Mac code.
- 15:01 Changeset [49405] by
-
2009-10-09 Enrica Casucci <enrica@apple.com>
Reviewed by Adele Peterson.
Undoing a indent removes text instead of it's formatting.
<rdar://problem/7169206>
https://bugs.webkit.org/show_bug.cgi?id=28722
Added test case for https://bugs.webkit.org/show_bug.cgi?id=23995
- editing/execCommand/19653-1-expected.txt: Re-baselined.
- editing/execCommand/indent-div-inside-list-expected.txt: Re-baselined.
- editing/execCommand/indent-nested-blockquotes-expected.txt: Re-baselined.
- editing/execCommand/indent-nested-div-expected.txt: Re-baselined.
- editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Re-baselined.
- editing/execCommand/indent-with-style-expected.txt: Added.
- editing/execCommand/indent-with-style.html: Added.
- editing/undo/undo-indent-expected.txt: Added.
- editing/undo/undo-indent.html: Added.
- platform/mac/editing/execCommand/4641880-2-expected.txt: Re-baselined.
- platform/mac/editing/execCommand/4916541-expected.txt: Re-baselined.
- platform/mac/editing/execCommand/5138441-expected.txt: Re-baselined.
- platform/mac/editing/execCommand/5481523-expected.txt: Re-baselined.
- platform/mac/editing/execCommand/indent-selection-expected.txt: Re-baselined.
2009-10-09 Enrica Casucci <enrica@apple.com>
Reviewed by Adele Peterson.
Undoing a indent removes text instead of it's formatting.
<rdar://problem/7169206>
https://bugs.webkit.org/show_bug.cgi?id=28722
Restored the behavior prior to http://trac.webkit.org/changeset/46143. This change implemented the
indent command making simple DOM operation, without using moveParagraph which cause undo to be broken.
Added editing/undo/undo-indent.html test.
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Restored. (WebCore::IndentOutdentCommand::tryIndentingAsListItem): Merged changes. (WebCore::IndentOutdentCommand::indentIntoBlockquote): Restored. (WebCore::IndentOutdentCommand::indentRegion): Restored and added call to updateLayout to ensure TextIterator could correctly calculate the position starting from the index.
- editing/IndentOutdentCommand.h: Restored.
- 14:24 Changeset [49404] by
-
2009-10-09 Rimas Kudelis <rq@akl.lt>
Rubber-stamped by Gustavo Noronha
https://bugs.webkit.org/show_bug.cgi?id=30054
Localization of WebKit GTK into Lithuanian
- lt.po: Added.
- 14:24 Changeset [49403] by
-
2009-10-09 Jens Alfke <snej@chromium.org>
Reviewed by Darin Adler.
Optimization: Many StringImpl transformations are no-ops and should just return 'this'
https://bugs.webkit.org/show_bug.cgi?id=30186
Optimized StringImpl methods lower(), stripWhiteSpace() and simplifyWhiteSpace() to
detect no-ops and return this instead of creating a new instance.
Empirical testing shows that the majority of calls to these methods are no-ops, making
this worthwhile even if (in the case of lower()) the non-no-op case is slightly slowed.
Upper() is very rarely a no-op, so it wasn't worthwhile to optimize it.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): Just add a comment explaining why this wasn't optimized (WebCore::StringImpl::stripWhiteSpace): (WebCore::StringImpl::simplifyWhiteSpace):
- 13:51 Changeset [49402] by
-
2009-10-09 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
SVG Filter feGaussianBlur implementation is missing
https://bugs.webkit.org/show_bug.cgi?id=28141
This is the implementation of GaussianBlur filter for SVG.
There is already a test for feGaussianBlur
Test: svg/W3C-SVG-1.1/filters-gauss-01-b-w3c.svg
Test: svg/filters/feGaussianBlur.svg
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect):
- platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::isAlphaImage): (WebCore::FilterEffect::setIsAlphaImage):
- platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::apply):
- svg/graphics/filters/SVGFEGaussianBlur.cpp: (WebCore::boxBlur): (WebCore::FEGaussianBlur::apply):
Test for feGaussianBlur implementation
- platform/mac/svg/filters/feGaussianBlur-expected.checksum: Added.
- platform/mac/svg/filters/feGaussianBlur-expected.png: Added.
- platform/mac/svg/filters/feGaussianBlur-expected.txt: Added.
- svg/filters/feGaussianBlur.svg: Added.
- 12:37 Changeset [49401] by
-
2009-10-09 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] QoS support in the video sink
https://bugs.webkit.org/show_bug.cgi?id=29959
Removed the async buffer queue from the sink. Synchronize the
render method of the sink using a g_timeout_add() combined with a
gcond triggered when the buffer has been rendered.
Also fixed the video sink reference handling in the player, now
that the idle is not there anymore to mess up things.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_init): (webkit_video_sink_timeout_func): (webkit_video_sink_render): (webkit_video_sink_dispose): (unlock_buffer_mutex): (webkit_video_sink_unlock): (webkit_video_sink_stop): (webkit_video_sink_class_init):
- 12:13 Changeset [49400] by
-
2009-10-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
feMorphology filter is not implemented
https://bugs.webkit.org/show_bug.cgi?id=5863
Adds SVGFEMorphologyElement, for the SVG filter. It also fixes a bug
with the attribute "operator". It was only accessible via "_operator"
on JavaScript.
Test: svg/dom/operatorAttribute.xhtml
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.SVG.Filters.exp:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm: (WebCore::createElementClassMap):
- bindings/objc/DOMSVG.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- page/DOMWindow.idl:
- svg/SVGAllInOne.cpp:
- svg/SVGFECompositeElement.idl:
- svg/SVGFEMorphologyElement.cpp: Added. (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement): (WebCore::SVGFEMorphologyElement::~SVGFEMorphologyElement): (WebCore::SVGFEMorphologyElement::setRadius): (WebCore::SVGFEMorphologyElement::parseMappedAttribute): (WebCore::SVGFEMorphologyElement::build):
- svg/SVGFEMorphologyElement.h: Added.
- svg/SVGFEMorphologyElement.idl: Added.
- svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::operator<<):
- svg/graphics/filters/SVGFEMorphology.h: (WebCore::):
- svg/svgtags.in:
Reviewed by Nikolas Zimmermann.
Attribute "operator" schould only be accessible by "operator", not by "_operator"
- svg/dom/operatorAttribute-expected.txt: Added.
- svg/dom/operatorAttribute.html: Added.
- svg/dom/script-tests/operatorAttribute.js: Added.
- 12:12 Changeset [49399] by
-
2009-10-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Dimitri Glazkov.
Fix Chromium breakage.
- inspector/front-end/inspector.js: (WebInspector.addCookieDomain): check that Storage panel is present before calling its methods.
- 11:14 Changeset [49398] by
-
Migrated some code that didn't belong out of Structure.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-09
Reviewed by Sam Weinig.
SunSpider says maybe 1.03x faster.
- runtime/JSCell.h: Nixed Structure::markAggregate, and made marking of
a Structure's prototype the direct responsility of the object using it.
(Giving Structure a mark function was misleading because it implied that
all live structures get marked during GC, when they don't.)
- runtime/JSGlobalObject.cpp:
(JSC::markIfNeeded):
(JSC::JSGlobalObject::markChildren): Added code to mark prototypes stored
on the global object. Maybe this wasn't necessary, but now we don't have
to wonder.
- runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::getEnumerableNamesFromClassInfoTable):
- runtime/JSObject.h:
(JSC::JSObject::markChildrenDirect):
- runtime/PropertyNameArray.h:
- runtime/Structure.cpp:
- runtime/Structure.h:
(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache): Moved property name gathering code
from Structure to JSObject because having a Structure iterate its JSObject
was a layering violation. A JSObject is implemented using a Structure; not
the other way around.
- 10:31 Changeset [49397] by
-
2009-10-09 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
Sets Qt::WA_InputMethodEnabled and Qt::ImhHiddenText for password fields in EditorClientQt
setInputMethodState. This change is needed so widgets such as the s60 software
input panel can receive input method events for password fields.
It's up to the Qt platform to determine which widget will receive input method
events when these flags are set.
Also added implementation for setInputMethodEnabled and setInputMethodHint
to QGraphicsWebViewPrivate and QWebViewPrivate. This change removes the direct
dependency on QWebView and uses QWebPageClient.
Added autotest to tst_qwebpage.cpp
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::setInputMethodEnabled): (QGraphicsWebViewPrivate::setInputMethodHint):
- Api/qwebview.cpp: (QWebViewPrivate::setInputMethodEnabled): (QWebViewPrivate::setInputMethodHint):
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
2009-10-09 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Added pure virtual methods setInputMethodEnabled and setInputMethodHint to QWebPageClient
- platform/qt/QWebPageClient.h:
- 10:26 Changeset [49396] by
-
Requested by Mark Rowe.
Patch by Darin Adler <darin@apple.com> on 2009-10-09
Moved DOM test that was in fast/js to fast/dom where it belongs.
- fast/dom/Document/invalid-domain-change-throws-exception-expected.txt:
Copied from fast/js/invalid-domain-change-throws-exception-expected.txt.
- fast/dom/Document/invalid-domain-change-throws-exception.html:
Copied from fast/js/invalid-domain-change-throws-exception.html.
Regenerated with the make-script-test-wrappers.
- fast/dom/Document/script-tests/invalid-domain-change-throws-exception.js:
Copied from fast/js/resources/invalid-domain-change-throws-exception.js.
- fast/js/invalid-domain-change-throws-exception-expected.txt: Removed.
- fast/js/invalid-domain-change-throws-exception.html: Removed.
- fast/js/resources/invalid-domain-change-throws-exception.js: Removed.
- 10:20 Changeset [49395] by
-
Fix ChangeLog patch reviewer to be accurate.
- 10:03 Changeset [49394] by
-
Implement beforeload for images. ImageLoadEventSender has been refactored into a more generic
ImageEventSender that can be used by both load and beforeload events. If the document has any
beforeload listeners, then the installation of images onto the renderer becomes asynchronous
and will be held up until the beforeload event can fire at a later date.
Reviewed by Adam Roben.
Both beforeload and load events now fire at the end of the tokenizer write() methods, so that
in the typical parsing case we don't have to put off the beforeload/load events until after
a layout or paint might already have happened. This lets beforeload/load not cause extra
layouts and repaints.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::dispatchBeforeLoadEvent):
- dom/Document.cpp:
(WebCore::Document::implicitClose):
(WebCore::Document::addListenerTypeIfNeeded):
- dom/Document.h:
(WebCore::Document::):
- dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::write):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::attach):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attach):
- html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::write):
- loader/ImageLoader.cpp:
(WebCore::ImageBeforeLoadEventSender::ImageBeforeLoadEventSender):
(WebCore::ImageLoadEventSender::ImageLoadEventSender):
(WebCore::beforeLoadEventSender):
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::setLoadingImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingEvents):
(WebCore::ImageEventSender::ImageEventSender):
(WebCore::ImageEventSender::dispatchEventSoon):
(WebCore::ImageEventSender::cancelEvent):
(WebCore::ImageEventSender::dispatchPendingEvents):
(WebCore::ImageEventSender::timerFired):
- loader/ImageLoader.h:
(WebCore::ImageLoader::haveFiredBeforeLoadEvent):
- wml/WMLImageElement.cpp:
(WebCore::WMLImageElement::attach):
- 09:36 Changeset [49393] by
-
2009-10-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dimitri Glazkov.
Web Inspector: Wrap Database into ScriptObject in v8 bindings.
No tests due to no Script* test infrastructure.
- bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
- 09:35 Changeset [49392] by
-
Add SPI to specifically enable visited link tracking.
Reviewed by Dan Bernstein.
- History/WebHistory.mm:
(+[WebHistory _setVisitedLinkTrackingEnabled:]):
- History/WebHistoryPrivate.h:
- 07:58 Changeset [49391] by
-
2009-10-09 Girish Ramakrishnan <girish@forwardbias.in>
Reviewed by Simon Hausmann.
[Qt] Windowless Plugins : Fix crash when using QWebPage without QWebView.
'client' is 0 when we have no view.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint):
- 07:51 Changeset [49390] by
-
Set the svn:mime-type property of recently-added PNG files to image/png.
- 05:47 Changeset [49389] by
-
2009-10-09 Girish Ramakrishnan <girish@forwardbias.in>
Reviewed by Simon Hausmann.
[Qt] Plugins : Add missing setCurrentPlugin(0)
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::dispatchNPEvent):
- 05:32 Changeset [49388] by
-
2009-10-09 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] beforeload event does not fire on script elements in XML
https://bugs.webkit.org/show_bug.cgi?id=30235
r49194 was lacking a change to XMLTokenizerQt.cpp, equivalent to the one
made in XMLTokenizerLibxml2.cpp.
- dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseEndElement):
- 05:12 Changeset [49387] by
-
2009-10-09 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WebCore's CSSParserValueList
https://bugs.webkit.org/show_bug.cgi?id=30249
Inherits CSSParserValueList class from FastAllocBase because it has
been instantiated by 'new' in WebCore/css/CSSGrammar.y:1271.
- css/CSSParserValues.h:
- 04:32 Changeset [49386] by
-
2009-10-09 Girish Ramakrishnan <girish@forwardbias.in>
Reviewed by Simon Hausmann.
[Qt] Windowless Plugins : Create Pixmap only when size changes.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
- 02:36 Changeset [49385] by
-
Remove the WebKitPluginHalterEnabledPreferenceKey in favor of checking
for the existence of a PluginHalterDelegate.
This fixes a leak of WebPluginHalterClients:
https://bugs.webkit.org/show_bug.cgi?id=30119.
WebCore:
Reviewed by Dan Bernstein.
- WebCore.base.exp:
Removed the export of WebCore::Settings::setPluginHalterEnabled().
- loader/EmptyClients.h:
(WebCore::EmptyPluginHalterClient::enabled):
- page/Page.cpp:
(WebCore::Page::Page):
Remove initialization of m_pluginHalterClient, which was removed. If a
non-null PluginHalterClient was passed, create the PluginHalter, and
set its allowed run time.
- page/Page.h:
Removed pluginHalterEnabledStateChanged() and m_pluginHalterClient.
- page/PluginHalter.cpp:
(WebCore::PluginHalter::didStartPlugin):
Check whether the PluginHalterClient is enabled.
(WebCore::PluginHalter::didStopPlugin):
Ditto.
- page/PluginHalter.h:
Made m_client an OwnPtr.
- page/PluginHalterClient.h:
Added a function to return the enabled state.
- page/Settings.cpp:
(WebCore::Settings::Settings):
Remove initialization of removed member.
- page/Settings.h:
Removed settings for the enabled state of the PluginHalter; we now use
the existence of a WebPluginHalterDelegate to determine whether the
PluginHalter is enabled.
WebKit/mac:
- WebCoreSupport/WebPluginHalterClient.h:
Add declaration for new function.
- WebCoreSupport/WebPluginHalterClient.mm:
(WebPluginHalterClient::enabled):
Check whether the UIDelegate responds to shouldHaltPlugin.
- WebView/WebPreferenceKeysPrivate.h:
Remove the "enabled" preference key.
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Remove the initialization of the pref.
- WebView/WebPreferencesPrivate.h:
Remove the getter/setter for this pref.
- WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
Remove propagation of the pref.
WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl:
Remove the getter and setter.
- WebCoreSupport/WebPluginHalterClient.cpp:
(WebPluginHalterClient::enabled):
Return true if the delegate exists.
- WebCoreSupport/WebPluginHalterClient.h:
Declare implementation of enabled().
- WebPreferenceKeysPrivate.h:
Removed the pref key.
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
Removed initialization of the pref.
- WebPreferences.h:
Removed declaration of the getter/setter.
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Don't propagate the pref.
- 01:59 Changeset [49384] by
-
Attempt to fix the GTK release build.
- GNUmakefile.am: Include Grammar.cpp in release builds now that
AllInOneFile.cpp is gone.
- 00:50 Changeset [49383] by
-
2009-10-09 Gabor Loki <loki@inf.u-szeged.hu>
Rubber-stamped by Eric Seidel.
Add ARM JIT support for Gtk port (disabled by default)
https://bugs.webkit.org/show_bug.cgi?id=30228
- GNUmakefile.am:
