Timeline
10/16/09:
- 23:59 Changeset [49736] by
-
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=30470
Make marking a bug as duplicate easier
- js/field.js: (setResolutionToDuplicate): Show edit field right away, don't make the user click again.
- 23:50 WebKit Team edited by
- Added Drag and Drop to my section. (diff)
- 23:29 Changeset [49735] by
-
https://bugs.webkit.org/show_bug.cgi?id=30456
Fixes for new Debug_All Windows build configuration.
Reviewed by Dan Bernstein.
WebCore:
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::findCFNetworkModule): Ask for the correct library instead of guessing.
* platform/win/ScrollbarThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming.
* rendering/RenderMediaControls.cpp: Use new DEBUG_ALL preprocessor define for library naming.
* rendering/RenderThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming.
WebKit/win:
* WebKitClassFactory.cpp: Use new DEBUG_ALL preprocessor define for library naming.
WebKitLibraries:
* win/tools/vsprops/debug_all.vsprops:
Define DEBUG_ALL in Debug_All configuration.
Continue to define USE_DEBUG_SAFARI_THEME for open source SafariTheme header usage.
WebKitTools:
* DumpRenderTree/win/DumpRenderTree.cpp:
(sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
* DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
- 22:52 Changeset [49734] by
-
Rolled back in r49717 with the build maybe working now?
- 22:15 Changeset [49733] by
-
Reviewed by Jon Honeycutt.
- Plugins/WebBaseNetscapePluginView.h: Added new boolean ivar and -hasBeenHalted instance method.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView halt]):Update _hasBeenHalted. (-[WebBaseNetscapePluginView hasBeenHalted]): Added.
- WebView/WebView.mm: (+[WebView _hasPluginForNodeBeenHalted:]): Checks to see if a plug-in node's been halted.
- WebView/WebViewPrivate.h: Added -_hasPluginForNodeBeenHalted method.
- 21:38 Changeset [49732] by
-
Add SPI to determine whether a plug-in has ever been halted.
Part of < rdar://problem/7312158>.
Reviewed by Dan Bernstein.
WebCore:
* plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
Initialize m_hasBeenHalted.
* plugins/PluginView.h:
(WebCore::PluginView::hasBeenHalted):
Return m_hasBeenHalted.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::halt):
Set m_hasBeenHalted.
WebKit/win:
* Interfaces/IWebViewPrivate.idl:
Add hasPluginForNodeBeenHalted().
* WebView.cpp:
(pluginViewForNode):
Code factored out of isNodeHaltedPlugin().
(WebView::isNodeHaltedPlugin):
Remove STDMETHODCALLTYPE, as it has no use at the definition. Use
pluginViewForNode().
(WebView::restartHaltedPluginForNode):
Ditto.
(WebView::hasPluginForNodeBeenHalted):
Get the PluginView for the given node. Return the result of
PluginView::hasBeenHalted().
* WebView.h:
Declare hasPluginForNodeBeenHalted().
- 21:23 Changeset [49731] by
-
2009-10-16 Simon Fraser < simon.fraser@apple.com>
Skip this test:
compositing/animation/animated-composited-inside-hidden.html
because the fix for https://bugs.webkit.org/show_bug.cgi?id=26770 was backed out.
- platform/mac/Skipped:
- 20:54 Changeset [49730] by
-
[Qt] QGLauncher leaks WebPage object
https://bugs.webkit.org/show_bug.cgi?id=30465
Patch by Antonio Gomes < tonikitoo@webkit.org> on 2009-10-16
Reviewed by Simon Hausmann.
Make 'SharedScene' to own 'WebPage' reference and delete it at its destructor.
* Api/qwebpage.cpp:
(QWebPage::view):
* Api/qwebpage_p.h:
* QGVLauncher/main.cpp:
(SharedScene::SharedScene):
(SharedScene::~SharedScene):
- 20:51 Changeset [49729] by
-
[Qt] "dangling" pointer to qwebpage's view object can leads QGLauncher to crash
https://bugs.webkit.org/show_bug.cgi?id=30459
Patch by Antonio Gomes < tonikitoo@webkit.org> on 2009-10-16
Reviewed by Simon Hausmann.
Remove all setView(ev->widget()) calls in QWebPage and QGWV event handling methods,
since QWebPageClient would do the trick.
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::hoverMoveEvent):
* Api/qwebpage.cpp:
(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::wheelEvent):
(QWebPagePrivate::dragEnterEvent):
(QWebPagePrivate::dragLeaveEvent):
(QWebPagePrivate::dragMoveEvent):
- 20:35 Changeset [49728] by
-
Updated expected results of tests that give CONSOLE messages for
new verbose output.
* fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt:
* fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
* platform/mac/fast/dynamic/015-expected.txt:
- 20:10 Changeset [49727] by
-
2009-10-16 Adam Barth < abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
@charset rule after the first byte causes the rest of css to be ignored
https://bugs.webkit.org/show_bug.cgi?id=18265
Apparently we're supposed to tolerate whitespace before the charset
rule so folks can write code like this:
<style>
@charset "utf-8"
...
</style>
I'm told this is one of the top compatability problems in China.
Tests: fast/css/comment-before-charset-external.html
fast/css/comment-before-charset.html
fast/css/many-spaces-before-charset.html
fast/css/space-before-charset-external.html
fast/css/space-before-charset.html
- css/CSSGrammar.y:
2009-10-16 Adam Barth < abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
@charset rule after the first byte causes the rest of css to be ignored
https://bugs.webkit.org/show_bug.cgi?id=18265
Test that we allow whitespace and comments before the charset rule.
These test results all match Firefox.
- fast/css/comment-before-charset-expected.txt: Added.
- fast/css/comment-before-charset-external-expected.txt: Added.
- fast/css/comment-before-charset-external.html: Added.
- fast/css/comment-before-charset.html: Added.
- fast/css/many-spaces-before-charset-expected.txt: Added.
- fast/css/many-spaces-before-charset.html: Added.
- fast/css/resources/comment-before-charset.css: Added.
- fast/css/resources/space-before-charset.css: Added.
- fast/css/space-before-charset-expected.txt: Added.
- fast/css/space-before-charset-external-expected.txt: Added.
- fast/css/space-before-charset-external.html: Added.
- fast/css/space-before-charset.html: Added.
- 19:31 Changeset [49726] by
-
Roll out r49717 as it broke the build.
- 18:23 Changeset [49725] by
-
Rubber-stamped by Adam Roben.
Remove inspector tests from Windows Skipped list, because they pass locally
and the front-end changes are picked up by the bots.
* platform/win/Skipped:
- 18:20 Changeset [49724] by
-
Build fix: apparently we shouldn't export those symbols?
Patch by Geoffrey Garen < ggaren@apple.com> on 2009-10-16
* JavaScriptCore.exp:
- 18:18 Changeset [49723] by
-
WebCore: Fixes part of < http://webkit.org/b/30412>.
Web Inspector should get human readable DOM Exceptions.
Reviewed by Darin Adler.
Add a description field to ExceptionBase, and call it through
reportException which allows the user/developer to get a more detailed
and coherent error explanation through the Web Inspector.
This only applies to exceptions that come from a script on the page when
it is run. DOM Exceptions that come from the code run in the console, or DOM
exceptions that are caught and logged will come in a future patch.
Tests: inspector/uncaught-dom1-exception.html
inspector/uncaught-dom3-exception.html
inspector/uncaught-dom8-exception.html
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
* bindings/js/JSExceptionBase.cpp: Added.
(WebCore::toExceptionBase):
* bindings/js/JSExceptionBase.h: Added.
* dom/ExceptionBase.cpp:
(WebCore::ExceptionBase::ExceptionBase):
* dom/ExceptionBase.h:
(WebCore::ExceptionBase::description):
* dom/ExceptionCode.cpp:
(WebCore::):
(WebCore::getExceptionCodeDescription):
* dom/ExceptionCode.h:
LayoutTests: Fixes part of < http://webkit.org/b/30412>.
Web Inspector should get human readable DOM Exceptions.
Reviewed by Darin Adler.
Adds tests for output of uncaught exceptions to the Web Inspector
Console. Tests DOM exceptions 1, 3, and 8 (INDEX_SIZE_ERR, NOT_FOUND_ERR, and
HIERARCHY_REQUEST_ERR).
* inspector/uncaught-dom1-exception-expected.txt: Added.
* inspector/uncaught-dom1-exception.html: Added.
* inspector/uncaught-dom3-exception-expected.txt: Added.
* inspector/uncaught-dom3-exception.html: Added.
* inspector/uncaught-dom8-exception-expected.txt: Added.
* inspector/uncaught-dom8-exception.html: Added.
- 18:09 Changeset [49722] by
-
Build fix: export some symbols.
Patch by Geoffrey Garen < ggaren@apple.com> on 2009-10-16
* JavaScriptCore.exp:
- 18:06 Changeset [49721] by
-
structure typeinfo flags should be inherited.
https://bugs.webkit.org/show_bug.cgi?id=30468
Reviewed by Gavin Barraclough.
Add StructureFlag constant to the various JSC classes and use
it for the TypeInfo construction. This allows us to simply
accumulate flags by basing each classes StructureInfo on its parents.
- 17:45 Changeset [49720] by
-
Build fix: forgot to check in this #include.
Patch by Geoffrey Garen < ggaren@apple.com> on 2009-10-16
* bridge/runtime_root.h:
- 17:40 Changeset [49719] by
-
* coding/RefPtr.html: Minor revision, updating a link and tweaking
wording a bit in few places.
- 17:32 Changeset [49718] by
-
New tag.
- 17:28 Changeset [49717] by
-
Fast for-in enumeration: Cache JSPropertyNameIterator; cache JSStrings
in JSPropertyNameIterator; inline more code.
Patch by Geoffrey Garen < ggaren@apple.com> on 2009-10-16
Reviewed by Oliver Hunt.
1.024x as fast on SunSpider (fasta: 1.43x as fast).
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetPropertyNames):
(JSC::BytecodeGenerator::emitNextPropertyName):
* bytecompiler/BytecodeGenerator.h: Added a few extra operands to
op_get_pnames and op_next_pname so that we can track iteration state
in the register file instead of in the JSPropertyNameIterator. (To be
cacheable, the JSPropertyNameIterator must be stateless.)
* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCachePutByID):
(JSC::Interpreter::tryCacheGetByID): Updated for rename to
"normalizePrototypeChain" and removal of "isCacheable".
(JSC::Interpreter::privateExecute): Updated for in-RegisterFile
iteration state tracking.
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_pnames): Updated for in-RegisterFile
iteration state tracking.
(JSC::JIT::emit_op_next_pname): Inlined code generation for op_next_pname.
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID): Updated for rename to
"normalizePrototypeChain" and removal of "isCacheable".
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::): Added has_property and to_object stubs. Removed op_next_pname
stub, since has_property is all we need anymore.
* parser/Nodes.cpp:
(JSC::ForInNode::emitBytecode): Updated for in-RegisterFile
iteration state tracking.
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames): Don't do caching at this layer
anymore, since we don't create a JSPropertyNameIterator at this layer.
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create): Do do caching at this layer.
(JSC::JSPropertyNameIterator::get): Updated for in-RegisterFile
iteration state tracking.
(JSC::JSPropertyNameIterator::markChildren): Mark our JSStrings.
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::size):
(JSC::JSPropertyNameIterator::setCachedStructure):
(JSC::JSPropertyNameIterator::cachedStructure):
(JSC::JSPropertyNameIterator::setCachedPrototypeChain):
(JSC::JSPropertyNameIterator::cachedPrototypeChain):
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::Structure::setEnumerationCache): Don't store iteration state in
a JSPropertyNameIterator. Do cache a JSPropertyNameIterator in a
Structure.
* runtime/JSValue.h:
(JSC::asCell):
* runtime/MarkStack.h: Make those mischievous #include gods happy.
* runtime/ObjectConstructor.cpp:
* runtime/Operations.h:
(JSC::normalizePrototypeChain): Renamed countPrototypeChainEntriesAndCheckForProxies
to normalizePrototypeChain, since it changes dictionary prototypes to
non-dictionary objects.
* runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
* runtime/PropertyNameArray.h:
(JSC::PropertyNameArrayData::PropertyNameArrayData):
(JSC::PropertyNameArray::data):
(JSC::PropertyNameArray::size):
(JSC::PropertyNameArray::begin):
(JSC::PropertyNameArray::end): Simplified some code here to help with
current and future refactoring.
* runtime/Protect.h:
* runtime/Structure.cpp:
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition): No need to clear
the enumeration cache with adding / removing properties without
transition. It is an error to add / remove properties without transition
once an object has been observed, and we can ASSERT to catch that.
* runtime/Structure.h:
(JSC::Structure::enumerationCache): Changed the enumeration cache to
hold a JSPropertyNameIterator.
* runtime/StructureChain.cpp:
* runtime/StructureChain.h:
(JSC::StructureChain::head): Removed StructureChain::isCacheable because
it was wrong-headed in two ways: (1) It gave up when a prototype was a
dictionary, but instead we want un-dictionary heavily accessed
prototypes; (2) It folded a test for hasDefaultGetPropertyNames() into
a generic test for "cacheable-ness", but hasDefaultGetPropertyNames()
is only releavant to for-in caching.
- 17:27 Changeset [49716] by
-
Merge r48971.
- 17:27 Changeset [49715] by
-
Merge r48683.
- 17:27 Changeset [49714] by
-
Versioning.
- 17:20 Changeset [49713] by
-
2009-10-16 Simon Fraser < simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Transform layer gets stuck with the wrong transform after an animation ends
< rdar://problem/7311662>
Work around a CoreAnimation bug which causes an animated transform layer to
end up with a stale transform.
Test: compositing/animation/state-at-end-event-transform-layer.html
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::bug7311367Workaround): (WebCore::GraphicsLayerCA::removeAnimationFromLayer):
- 17:20 Changeset [49712] by
-
wxMSW non-precomp headers build fix.
- 17:17 Changeset [49711] by
-
2009-10-16 Simon Fraser < simon.fraser@apple.com>
Reviewed by Dan Bernstein.
After running a transition with an end event listener, can't change the transform
https://bugs.webkit.org/show_bug.cgi?id=30454
Fix an issue where, if a document had any listener for webkitTransitionEnd or webkitAnimationEnd,
the animations would not get cleaned up correctly, which broke subsequent changes of transform.
Now, we always clean up the animations right after queuing up the end events.
Tests: animations/state-at-end-event.html
transitions/move-after-transition.html
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::onAnimationEnd):
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::onAnimationEnd):
- 17:11 Changeset [49710] by
-
Reviewed by Anders Carlson.
Small code cleanup
- Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::halt): Just call -[WebBaseNetscapePluginView halt]. (WebHaltablePlugin::restart): Just call -[WebBaseNetscapePluginView resumeFromHalt] (-[WebBaseNetscapePluginView halt]): (-[WebBaseNetscapePluginView resumeFromHalt]):
- WebView/WebView.mm: (_pluginViewForNode): Added a check if a render is a widget. This prevents a later assertion.
- 17:08 Changeset [49709] by
-
2009-10-15 Joseph Pecoraro < joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Handle the Enter Key in the Elements Tree Hierarchy
https://bugs.webkit.org/show_bug.cgi?id=30428
TextNode => Edit Text Node
Has Attributes => Edit First Attribute
No Attributes => Start Editing New Attribute
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): handle the "Enter" key (WebInspector.ElementsTreeElement.prototype.set hovered): only add new attribute button on nodes with attributes (WebInspector.ElementsTreeElement.prototype._addNewAttribute): prevent moving backwards where there are no attributes (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): renamed to be clearer (WebInspector.ElementsTreeElement.prototype._startEditing): transition to the appropriate edit state for a tree element
- 17:04 Changeset [49708] by
-
2009-10-16 Eric Seidel < eric@webkit.org>
Reviewed by Adam Barth.
commit-queue status bot should list which buildbot is blocking the queue
https://bugs.webkit.org/show_bug.cgi?id=30452
Add new methods and testing.
- Scripts/bugzilla-tool:
- Scripts/modules/buildbot.py:
- Scripts/modules/buildbot_unittest.py:
- 16:57 Changeset [49707] by
-
2009-10-16 Eric Seidel < eric@webkit.org>
Reviewed by Adam Barth.
run-webkit-tests fails when CWD is not inside a WebKit checkout
https://bugs.webkit.org/show_bug.cgi?id=30451
- Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
- Scripts/modules/scm_unittest.py:
- Remove use of original_path (we don't need to restore the CWD).
- Don't use '.' to find the webkit checkout, use file instead.
- 16:44 Changeset [49706] by
-
2009-10-16 Adam Barth < abarth@webkit.org>
Reviewed by Eric Seidel.
Fix header indent style for FrameLoader and friends
https://bugs.webkit.org/show_bug.cgi?id=30430
- loader/FrameLoader.h: (WebCore::FrameLoader::frame): (WebCore::FrameLoader::policyChecker): (WebCore::FrameLoader::history): (WebCore::FrameLoader::notifier): (WebCore::FrameLoader::isLoadingMainResource): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::policyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::client): (WebCore::FrameLoader::url): (WebCore::FrameLoader::isLoadingFromCachedPage): (WebCore::FrameLoader::committingFirstRealLoad): (WebCore::FrameLoader::committedFirstRealDocumentLoad): (WebCore::FrameLoader::creatingInitialEmptyDocument):
- loader/HistoryController.h: (WebCore::HistoryController::currentItem): (WebCore::HistoryController::provisionalItem):
- loader/PolicyCallback.h: (WebCore::PolicyCallback::request):
- loader/PolicyChecker.h: (WebCore::PolicyChecker::loadType): (WebCore::PolicyChecker::setLoadType): (WebCore::PolicyChecker::delegateIsDecidingNavigationPolicy): (WebCore::PolicyChecker::delegateIsHandlingUnimplementablePolicy):
- loader/RedirectScheduler.h:
- loader/ResourceLoadNotifier.h:
- 15:31 Changeset [49705] by
-
Add a Debug_All configuration to build entire stack as debug.
Change Debug_Internal to:
- stop using _debug suffix for all WebKit/Safari binaries
- not use _debug as a DLL naming suffix
- use non-debug C runtime lib.
Reviewed by Adam Roben.
JavaScriptCore:
* JavaScriptCore.vcproj/JavaScriptCore.make: Debug build in makefile should build Debug_All.
* JavaScriptCore.vcproj/JavaScriptCore.sln: Add Debug_All configuration.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add Debug_All configuration.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Renamed single configuration from "Release" to "all".
* JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Add Debug_All configuration.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Add Debug_All configuration.
* JavaScriptCore.vcproj/jsc/jsc.vcproj: Add Debug_All configuration.
* JavaScriptCore.vcproj/testapi/testapi.vcproj: Add Debug_All configuration.
WebCore:
* WebCore.vcproj/QTMovieWin.vcproj: Add Debug_All configuration.
* WebCore.vcproj/WebCore.make: Debug build in makefile should build Debug_All.
* WebCore.vcproj/WebCore.sln: Add Debug_All configuration.
* WebCore.vcproj/WebCore.submit.sln: Add Debug_All configuration.
* WebCore.vcproj/WebCore.vcproj: Add Debug_All configuration.
* WebCore.vcproj/WebCoreGenerated.vcproj: Renamed single configuration from "Release" to "all".
WebKit/win:
* WebKit.vcproj/InterfacesGenerated.vcproj: Renamed single configuration from "Release" to "all".
* WebKit.vcproj/WebKit.make: Debug build in makefile should build Debug_All.
* WebKit.vcproj/WebKit.sln: Add Debug_All configuration.
* WebKit.vcproj/WebKit.submit.sln: Add Debug_All configuration.
* WebKit.vcproj/WebKit.vcproj:
Remove extraneous OutputDirectory/IntermediateDirectory in Debug_Cairo.
Add Debug_All configuration.
* WebKit.vcproj/WebKitGUID.vcproj: Add Debug_All configuration.
WebKitLibraries:
* win/tools/vsprops/debug_all.vsprops: Added.
Use debug C runtime library in debug_all.
Specify USE_DEBUG_SAFARI_THEME to get "_debug" suffix for debug_all.
* win/tools/vsprops/debug_internal.vsprops:
Don't specify debug C runtime library in debug_internal.
Don't specify _debug suffix for standard debug_internal builds.
WebKitTools:
* DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
* DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
* DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
* DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
Add missing debug.vsprops inherited property sheet.
Add Debug_All configuration.
* FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
* WinLauncher/WinLauncher.vcproj:
Removed extraneous definitions inherited from vsprops.
Add Debug_All configuration.
- 15:28 Changeset [49704] by
-
Unreviewed. Rolling out r49661 since it makes tests fail on GTK+ and Mac with Xiph plugin
- 15:07 Changeset [49703] by
-
2009-10-16 Dimitri Glazkov < dglazkov@chromium.org>
No review, rolling out r49693, because it broke Chromium build.
http://trac.webkit.org/changeset/49693
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 15:03 Changeset [49702] by
-
2009-10-16 Andrew Scherkus < scherkus@chromium.org>
Reviewed by Eric Carlson.
Updated media resource selection algorithm to reflect latest HTML 5 specification.
- media/video-play-pause-exception-expected.txt:
- media/video-play-pause-exception.html:
- media/video-src-empty-expected.txt: Added.
- media/video-src-empty.html: Added.
- media/video-src-none-expected.txt: Added.
- media/video-src-none.html: Added.
2009-10-16 Andrew Scherkus < scherkus@chromium.org>
Reviewed by Eric Carlson.
Updated media resource selection algorithm to reflect latest HTML 5 specification.
Noticable changes:
- Elements with no source should have their network state set to NETWORK_EMPTY as opposed to NETWORK_NO_SOURCE
- Empty string ("") is now considered a valid URL resolving to the current page and will be loaded
Tests: media/video-src-empty.html
media/video-src-none.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectMediaResource): Updated code and comments to match spec.
- 14:33 Changeset [49701] by
-
2009-10-16 Daniel Bates < dbates@webkit.org>
Reviewed by Darin Adler.
Tests that the JavaScript array event.dataTransfer.types can be accessed
within an ondrop handler without causing a crash.
Although this issue has been resolved as of nightly r49550 we should add a
test case so that we can prevent a regression of this issue.
- fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Added.
- fast/events/drag-and-drop-dataTransfer-types-nocrash.html: Added.
- 14:30 Changeset [49700] by
-
2009-10-16 Adam Barth < abarth@webkit.org>
Reviewed by Eric Seidel.
Insecure plug-ins don't trigger mixed content
https://bugs.webkit.org/show_bug.cgi?id=30431
- http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/insecure-plugin-in-iframe.html: Added.
- http/tests/security/mixedContent/resources/frame-with-insecure-plugin.html: Added.
2009-10-16 Adam Barth < abarth@webkit.org>
Reviewed by Eric Seidel.
Insecure plug-ins don't trigger mixed content
https://bugs.webkit.org/show_bug.cgi?id=30431
Added the missing check.
Test: http/tests/security/mixedContent/insecure-plugin-in-iframe.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin):
- 14:26 Changeset [49699] by
-
Add SPI to restart a halted plug-in.
Part of < rdar://problem/7273354> Halted plug-ins should restart on
mouseover
https://bugs.webkit.org/show_bug.cgi?id=30151
Reviewed by Kevin Decker.
* Interfaces/IWebViewPrivate.idl:
Add restartHaltedPluginForNode().
* WebView.cpp:
(WebView::restartHaltedPluginForNode):
From the IDOMNode, query for the DOMNode. From the DOMNode, get the
WebCore::Node. Get the node's renderer, and check whether it is a
RenderWidget. If so, get its Widget, and check whether it's a
PluginView. If so, call PluginView::restart().
* WebView.h:
Declare restartHaltedPluginForNode().
- 14:21 Changeset [49698] by
-
2009-10-16 Andrew Scherkus < scherkus@chromium.org>
Reviewed by Eric Carlson.
Set autobuffer to true and schedule load in V8 audio element constructor.
Covered by existing tests.
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Set autobuffer to true and schedule load.
- 14:06 Changeset [49697] by
-
2009-10-16 Andrew Scherkus < scherkus@chromium.org>
Reviewed by Eric Seidel.
Remove FIXME in RenderMediaControlsChromium as bug was fixed upstream.
Covered by existing media layout tests.
- rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaSlider): Removed round() and FIXME.
- 14:01 BuildingOnWindows edited by
- Added note about error PRJ0002 - i.e. cannot find mspdb80.dll (diff)
- 13:57 Changeset [49696] by
-
Reviewed by Anders Carlson.
Last part of:
< rdar://problem/7273354>
- WebView/WebView.mm: (_pluginViewForNode): Added with code extracted from _isNodeHaltedPlugin (+[WebView _isNodeHaltedPlugin:]): Made this a class method. (+[WebView _restartHaltedPluginForNode:]): Added. Restarts a plug-in
- WebView/WebViewPrivate.h: Added +_restartHaltedPluginForNode to header.
- 13:56 Changeset [49695] by
-
2009-10-16 Andrew Scherkus < scherkus@chromium.org>
Reviewed by Eric Seidel.
Fix Chromium media controls to render a disabled play button when the element is unintialized.
Covered by existing layout tests.
- rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaPlayButton): Include check for NETWORK_EMPTY to render disabled play button.
- 13:39 Changeset [49694] by
-
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372
Reviewed by Gavin Barraclough.
Last part -- replace HasDefaultGetPropertyNames with OverridesGetPropertyNames
flag.
- 13:37 Changeset [49693] by
-
2009-10-16 Steven Knight < sgk@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=30447
Handle long link lines by building .idl-generated bindings in a
separate webcore_bindings library target. Avoid Visual Studio
dependency issues by building additional generated .cpp and .h files
in a separate webcore_bindings_sources target.
Chrome should still build and test successfully.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 13:28 Changeset [49692] by
-
2009-10-16 Simon Fraser < simon.fraser@apple.com>
Reviewed by Eric Carlson.
Transform transitions that used to be accelerated are no longer so
https://bugs.webkit.org/show_bug.cgi?id=30453
The change in r49633, to not run accelerated animations/transitions on layers that
are not attached, broke accelerated transitions/animations in many cases where they start
as soon as the page loads. This change reverts the code that tests for the GraphicsLayer being
attached.
No test, because it's not possible from a test to know whether a transition is accelerated or not.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): (WebCore::RenderLayerBacking::startTransition):
- 13:21 Changeset [49691] by
-
2009-10-16 Yuzo Fujishima < yuzo@google.com>
Reviewed by Darin Adler.
LayoutTests/fast/loader/local-JavaScript-from-local.html times out in case of error.
https://bugs.webkit.org/show_bug.cgi?id=30434
- fast/loader/local-JavaScript-from-local.html:
- 11:46 Changeset [49690] by
-
check-webkit-style is wrong about indent checking in namespaces
in header files and a few other things
https://bugs.webkit.org/show_bug.cgi?id=30362
Patch by Carol Szabo < carol.szabo@nokia.com> on 2009-10-16
Reviewed by David Levin.
The few other things include:
+ check-webkit-style does not require spaces around the equal sign
inside 'if' statements and around binary operators that take
numeric literals.
+ check-webkit-style reports false errors for the / operator
when part of a filename in the #include directive.
* Scripts/modules/cpp_style.py:
Improved indentation checking and space checking around
binary operators. While the checks are still not perfect,
they are clearly better than before.
* Scripts/modules/cpp_style_unittest.py:
Added test cases for the newly supported checks and modified old
test cases to match the new guidelines
- 11:33 Changeset [49689] by
-
Reviewed by Anders.
- Plugins/WebBaseNetscapePluginView.h: Added _isHalted ivar and three new methods: -halt, -resumeFromHalt, and -isHalted
- Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::halt): Call -halt instead of -stop. (WebHaltablePlugin::restart):Call -resumeFromHalt instead of -start. (-[WebBaseNetscapePluginView halt]): Added. Stop the plug-in, update _isHalted. (-[WebBaseNetscapePluginView resumeFromHalt]): Added. Start the plug-in, update _isHalted. (-[WebBaseNetscapePluginView isHalted]): Added.
- WebView/WebView.mm: (-[WebView _isNodeHaltedPlugin:]): Added. Queries a DOMNode to determine if it's a halted plug-in.
- WebView/WebViewPrivate.h: Added _isNodeHaltedPlugin.
- 11:23 Changeset [49688] by
-
wxMSW build fix, we can't use the simple hash there because the PlatformModuleVersion
structure differs.
- 10:46 Changeset [49687] by
-
2009-10-16 Adam Barth < abarth@webkit.org>
Unreviewed build fix. Add back MIMETypeRegistryChromium with the right
casing.
- platform/chromium/MIMETypeRegistryChromium.cpp: Added. (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::getMIMETypeForPath): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType): (WebCore::MIMETypeRegistry::isJavaAppletMIMEType): (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): (WebCore::dummyHashSet): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding): (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
- 10:41 Changeset [49686] by
-
2009-10-16 Adam Barth < abarth@webkit.org>
Reviewed by Darin Adler.
MimeTypeRegistryChromium is mis-casen
https://bugs.webkit.org/show_bug.cgi?id=30441
Change the case of MimeTypeRegistryChromium to match other platforms.
- WebCore.gypi:
- platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp.
- platform/chromium/MimeTypeRegistryChromium.cpp: Removed.
- 10:35 Changeset [49685] by
-
2009-10-16 Dimitri Glazkov < dglazkov@chromium.org>
Reviewed by Eric Seidel.
Change EmptyPluginHalterClient in SVGImage to be non-static, to
match changes made http://trac.webkit.org/changeset/49385.
https://bugs.webkit.org/show_bug.cgi?id=30403
Run the following layout test sequence:
LayoutTests/svg/W3C-SVG-1.1/struct-image-01-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-03-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-04-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-05-b.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-06-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-08-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-09-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-10-t.svg
LayoutTests/svg/carto.net/scrollbar.svg
LayoutTests/svg/carto.net/selectionlist.svg
selectionlist.svg should not crash.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Made EmptyPluginHalterClient non-static.
- 10:27 Changeset [49684] by
-
2009-10-16 Victor Wang < victorw@chromium.org>
Reviewed by David Levin.
Add beforeload event support to V8DOMWrapper
LayoutTests/fast/dom/beforeload/frame-before-load.html
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object):
- 09:41 Changeset [49683] by
-
2009-10-16 Adam Barth < abarth@webkit.org>
Reviewed by Darin Adler.
MimeTypeRegistryChromium is mis-casen
https://bugs.webkit.org/show_bug.cgi?id=30441
Change the case of MimeTypeRegistryChromium to match other platforms.
- WebCore.gypi:
- platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp.
- platform/chromium/MimeTypeRegistryChromium.cpp: Removed.
- 09:20 Changeset [49682] by
-
2009-10-16 Adam Barth < abarth@webkit.org>
Reviewed by Mark Rowe.
Chrome doesn't set Content-Type for file upload when the file extension
is not recognized
https://bugs.webkit.org/show_bug.cgi?id=30433
Apparently, getMIMETypeForPath is supposed to return
application/octet-stream when it doesn't have a better MIME type.
- platform/chromium/MimeTypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForPath):
- 08:58 Changeset [49681] by
-
Pull out r49676 as it caused build breakges on Symbian
- 08:53 Changeset [49680] by
-
[Qt] Add empty skipped lists for the platform-specific results
Reviewed by Ariya Hidayat.
* platform/qt-linux/Skipped:
* platform/qt-mac/Skipped:
* platform/qt-win/Skipped:
- 08:45 Changeset [49679] by
-
2009-10-16 Laszlo Gombos < laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Implement ExecutableAllocator for Symbian
https://bugs.webkit.org/show_bug.cgi?id=29946
Tested with YARR JIT enabled for Symbian;
This patch does not (yet) enable YARR JIT by default.
- JavaScriptCore.pri:
- jit/ExecutableAllocator.h:
- jit/ExecutableAllocatorSymbian.cpp: Added. (JSC::ExecutableAllocator::intializePageSize): (JSC::ExecutablePool::systemAlloc): (JSC::ExecutablePool::systemRelease):
- 07:35 BuildingQtOnWindows edited by
- (diff)
- 06:26 Changeset [49678] by
-
[Qt] Update outdated platform dependent expected file.
Patch by Andras Becsi < becsi.andras@stud.u-szeged.hu> on 2009-10-16
Reviewed by Tor Arne Vestbø.
* platform/qt/editing/execCommand/toggle-compound-styles-expected.txt:
- 06:26 Changeset [49677] by
-
Crash fix when loading NPAPI plugins on Qt/Mac
Reviewed by Ariya Hidayat.
There's no guarantee that the plist will be valid even if we
ask the plugin to create it. Crash obverved with iGetter.
* plugins/mac/PluginPackageMac.cpp:
- 06:18 Changeset [49676] by
-
2009-10-16 Yael Aharon < yael.aharon@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Need a way to inform the application when a Netscape plugin is created or deleted
https://bugs.webkit.org/show_bug.cgi?id=30179
Inform the application when a plugin is created or destroyed, but only if the
application registered for these notifications.
- plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):
2009-10-16 Yael Aharon < yael.aharon@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Need a way to inform the application when a Netscape plugin is created or deleted
https://bugs.webkit.org/show_bug.cgi?id=30179
Added "c" style static methods for the application to hook up for
receiving notifications when a plugin is created or destroyed.
- Api/qwebpage.cpp:
- 05:47 Changeset [49675] by
-
2009-10-16 Shu Chang < Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
Added test case for testing navigator.language.
https://bugs.webkit.org/show_bug.cgi?id=29653
Different browsers may not return the exact same result.
Some examples here:
Safari 4 WinXP: "en-US"
Safari 4 Mac: "en-us"
Firefox 3 Mac/WinXP: "en-US"
Opera 9.64: "en"
Epiphany 2 GTK: "en"
Chrome 3 WinXP: "en-US"
The test case checks if the first two letters are "en"
when system locale is set to "en_US.iso88591".
- fast/js/navigator-language-expected.txt: Added.
- fast/js/navigator-language.html: Added.
2009-10-16 Shu Chang < Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
Default language translation should be determined by locale settings,
e.g., "en-US".
https://bugs.webkit.org/show_bug.cgi?id=29653
Test: fast/js/navigator-language.html
- platform/qt/Localizations.cpp: (WebCore::defaultLanguage):
- 03:58 QtWebKitPlugins edited by
- (diff)
- 03:53 NetscapePluginsOnMacNotes created by
- 03:42 QtWebKitPlugins edited by
- (diff)
- 03:35 Changeset [49674] by
-
Crash fix when loading NPAPI plugins on Qt/Mac
Reviewed by Ariya Hidayat.
There's no guarantee that the plist will be valid even if we
ask the plugin to create it. Crash obverved with iGetter.
* plugins/mac/PluginPackageMac.cpp:
- 01:02 QtWebKitPlugins edited by
- (diff)
- 00:53 QtWebKitPlugins created by
10/15/09:
- 23:46 Changeset [49673] by
-
Fix for Chromium/skia's implementation of canvas's isPointInPath().
https://bugs.webkit.org/show_bug.cgi?id=30402
Reviewed by David Levin.
Covered by LayoutTests/fast/canvas/pointInPath.html.
* platform/graphics/skia/SkiaUtils.cpp:
(WebCore::SkPathContainsPoint):
- 23:42 Changeset [49672] by
-
2009-10-15 Yuzo Fujishima < yuzo@google.com>
Reviewed by David Levin.
Add mod_pywebsocket to test Web Sockets.
http://code.google.com/p/pywebsocket/
https://bugs.webkit.org/show_bug.cgi?id=27490
- pywebsocket/COPYING: Added.
- pywebsocket/MANIFEST.in: Added.
- pywebsocket/README: Added.
- pywebsocket/example/echo_client.py: Added.
- pywebsocket/example/echo_wsh.py: Added.
- pywebsocket/mod_pywebsocket/init.py: Added.
- pywebsocket/mod_pywebsocket/dispatch.py: Added.
- pywebsocket/mod_pywebsocket/handshake.py: Added.
- pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
- pywebsocket/mod_pywebsocket/msgutil.py: Added.
- pywebsocket/mod_pywebsocket/standalone.py: Added.
- pywebsocket/mod_pywebsocket/util.py: Added.
- pywebsocket/setup.py: Added.
- pywebsocket/test/config.py: Added.
- pywebsocket/test/mock.py: Added.
- pywebsocket/test/run_all.py: Added.
- pywebsocket/test/test_dispatch.py: Added.
- pywebsocket/test/test_handshake.py: Added.
- pywebsocket/test/test_mock.py: Added.
- pywebsocket/test/test_msgutil.py: Added.
- pywebsocket/test/test_util.py: Added.
- pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
- pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
- pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
- pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
- pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
- pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
- pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
- pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
- 22:32 Changeset [49671] by
-
2009-10-15 Adam Barth < abarth@webkit.org>
Reviewed by Darin Adler.
Factor ResourceLoadNotifier out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30379
These methods have virtually no interaction with the rest of
FrameLoader.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- dom/Document.cpp: (WebCore::Document::resourceRetrievedByXMLHttpRequest):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::ResourceLoadNotifier::ResourceLoadNotifier): (WebCore::ResourceLoadNotifier::activeDocumentLoader): (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest): (WebCore::ResourceLoadNotifier::willSendRequest): (WebCore::ResourceLoadNotifier::didReceiveResponse): (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::didFailToLoad): (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::ResourceLoadNotifier::didFinishLoad): (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge): (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge): (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
- loader/FrameLoader.h: (WebCore::FrameLoader::notifier):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::receivedError):
- loader/ResourceLoadNotifier.cpp: Added. (WebCore::ResourceLoadNotifier::ResourceLoadNotifier): (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge): (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge): (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest): (WebCore::ResourceLoadNotifier::willSendRequest): (WebCore::ResourceLoadNotifier::didReceiveResponse): (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::didFinishLoad): (WebCore::ResourceLoadNotifier::didFailToLoad): (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest): (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): (WebCore::ResourceLoadNotifier::activeDocumentLoader):
- loader/ResourceLoadNotifier.h: Added.
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoadingOnePart): (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
- 22:19 Changeset [49670] by
-
2009-10-15 Roland Steiner < rolandsteiner@google.com>
Reviewed by Darin Fisher.
Bug 30427 - Remove unneeded methods in ChromiumDataObject
( https://bugs.webkit.org/show_bug.cgi?id=30427)
Remove no longer needed methods from ChromiumDataObject.
No new tests (no functional change)
- platform/chromium/ChromiumDataObject.h:
- 22:03 Changeset [49669] by
-
2009-10-15 James Robinson < jamesr@google.com>
Reviewed by David Levin.
Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 18:27 Changeset [49668] by
-
2009-10-15 Daniel Bates < dbates@webkit.org>
No review, rolling out r49644.
http://trac.webkit.org/changeset/49644
We need to think about this change some more. See bug #30418
for more details.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::canSetBaseElementURL): (WebCore::XSSAuditor::findInRequest):
- page/XSSAuditor.h:
2009-10-15 Daniel Bates < dbates@webkit.org>
No review, rolling out r49644.
http://trac.webkit.org/changeset/49644
- http/tests/security/xssAuditor/base-href-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/base-href-comment.html: Removed.
- http/tests/security/xssAuditor/iframe-javascript-url-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/iframe-javascript-url-comment.html: Removed.
- http/tests/security/xssAuditor/img-onerror-HTML-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/img-onerror-HTML-comment.html: Removed.
- http/tests/security/xssAuditor/img-onerror-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/img-onerror-comment.html: Removed.
- http/tests/security/xssAuditor/object-tag-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/object-tag-comment.html: Removed.
- http/tests/security/xssAuditor/resources/echo-before-image.pl: Removed.
- http/tests/security/xssAuditor/resources/echo-head-base-href-comment.pl: Removed.
- http/tests/security/xssAuditor/script-tag-comment-HTML-entity-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html: Removed.
- http/tests/security/xssAuditor/script-tag-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-comment.html: Removed.
- http/tests/security/xssAuditor/script-tag-with-source-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-with-source-comment.html: Removed.
- 16:44 Changeset [49667] by
-
Rubber-stamped by Adele Peterson.
Update Windows expected results after http://trac.webkit.org/changeset/49619.
* platform/win/fast/inline: Added.
* platform/win/fast/inline/dirtyLinesForInline-expected.txt: Added.
- 16:22 Changeset [49666] by
-
Add SPI to determine whether a node is a halted plug-in.
Part of < rdar://problem/7273354> Halted plug-ins should restart on
mouseover
https://bugs.webkit.org/show_bug.cgi?id=30151
Reviewed by Darin Adler.
WebCore:
* plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
Initialize m_isHalted.
* plugins/PluginView.h:
(WebCore::PluginView::isHalted):
Return m_isHalted.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::halt):
Set m_isHalted to true.
(WebCore::PluginView::restart):
clear m_isHalted.
WebKit/win:
* Interfaces/IWebViewPrivate.idl:
Add isNodehaltedPlugin().
* WebView.cpp:
(WebView::isNodeHaltedPlugin):
From the IDOMNode, query for the DOMNode. From the DOMNode, get the
WebCore::Node. Get the node's renderer, and check whether it is a
RenderWidget. If so, get its Widget, and check whether it's a
PluginView. If so, return the result of PluginView::isHalted().
* WebView.h:
Declare isNodeHaltedPlugin().
- 16:17 Changeset [49665] by
-
2009-10-15 Jan Michael Alonzo < jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[GTK] marshal stamp files are not cleaned after a distclean
https://bugs.webkit.org/show_bug.cgi?id=30156
Add stamp-po to CLEANFILES.
- GNUmakefile.am:
2009-10-15 Jan Michael Alonzo < jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[GTK] marshal stamp files are not cleaned after a distclean
https://bugs.webkit.org/show_bug.cgi?id=30156
Add the stamp files directly to cleanfiles. Also rearrange the
variable declarations so we don't miss any files that need to be
cleaned up during the clean targets.
- GNUmakefile.am:
- 16:00 Changeset [49664] by
-
Fixes < http://webkit.org/b/30411>.
REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
Reviewed by Adam Roben.
Added a check for isChromium() in pdevenv, and pass /useenv if we are not
building Chromium.
* Scripts/pdevenv:
- 14:55 Changeset [49663] by
-
2009-10-15 Pavel Feldman < pfeldman@chromium.org>
Not reviewed: skip inspector tests on windows until
incremental build catches frontend files.
- platform/win/Skipped:
- 14:54 Changeset [49662] by
-
2009-10-15 Zoltan Horvath < zoltan@webkit.org>
Reviewed by Oliver Hunt.
Change JSC::HasNonDefaultMark to OverridesMarkChildren in createStructure function.
- bridge/qt/qt_runtime.h: (JSC::Bindings::QtRuntimeMethod::createStructure):
- 14:53 Changeset [49661] by
-
2009-10-15 Andrew Scherkus < scherkus@chromium.org>
Reviewed by Darin Adler.
Fix media layout test file ordering so both branded and unbranded builds of Chromium will pass layout tests.
- media/media-file.js: Fixed file ordering.
- 14:51 Changeset [49660] by
-
Versioning.
- 14:50 Changeset [49659] by
-
New tag.
- 14:39 Changeset [49658] by
-
Merge r46777.
- 14:37 Changeset [49657] by
-
Reviewed by Kevin Ollivier.
Update the wxPython simple.py sample to match current wxWebKit API.
https://bugs.webkit.org/show_bug.cgi?id=30406
- 14:31 Changeset [49656] by
-
2009-10-15 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Prevent subsequent tests from failing upon inspector
test timeout.
- inspector/evaluate-in-frontend.js: (onload.setTimeout):
- 14:30 Changeset [49655] by
-
Versioning.
- 14:27 Changeset [49654] by
-
Reviewed by Kevin Ollivier.
Add Mac package building scripts for wx.
https://bugs.webkit.org/show_bug.cgi?id=30405
- 14:11 Changeset [49653] by
-
2009-10-15 Eric Carlson < eric.carlson@apple.com>
Reviewed by Adele Peterson.
< rdar://problem/7306052> Fullscreen max/min volume buttons non-functional
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Set volume buttons target and action. (-[WebVideoFullscreenHUDWindowController decrementVolume:]): New, decrement the volume by 10%. (-[WebVideoFullscreenHUDWindowController incrementVolume:]): New, increment the volume by 10%.
- 14:01 Changeset [49652] by
-
2009-10-15 Zan Dobersek < zandobersek@gmail.com>
Reviewed by Eric Seidel.
[Gtk][Layout tests] Generate results for dom tests
https://bugs.webkit.org/show_bug.cgi?id=29893
Add results for dom tests and enable these tests in the Skipped.
- platform/gtk/Skipped:
- platform/gtk/dom/xhtml/level3/core/canonicalform08-expected.txt: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.txt.
- platform/gtk/dom/xhtml/level3/core/canonicalform09-expected.txt: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform09-expected.txt.
- platform/gtk/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodelookupprefix19-expected.txt: Added.
- 13:39 Changeset [49651] by
-
2009-10-15 Daniel Bates < dbates@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=24731
And
rdar://problem/5015961
Implements support for DHTML drag-and-drop operations (i.e. ondragstart, ondragend)
in the Windows build so that it conforms to the Mac OS X build. Hence, dropEffect is
correctly set.
The WebView and WebDropSource drag-and-drop functions, as called by function
DoDragDrop in its event loop, neither used the drop effect as specified by
event.dataTransfer.dropEffect nor respected event.dataTransfer.effectsAllowed.
Instead, these functions defaulted to some hardcoded drop effect and set of
allowed drop effects, respectively.
Tests: fast/events/drag-and-drop.html
- WebCoreSupport/WebDragClient.cpp: (WebDragClient::startDrag):
- WebDropSource.cpp: (WebDropSource::QueryContinueDrag): Moved call to EventHandler::dragSourceEndedAt into method WebDragClient::startDrag.
- WebDropSource.h:
- WebView.cpp: (WebView::keyStateToDragOperation): Fixes < rdar://problem/5015961>. Determines appropriate drop effect from state of keyboard and allowed effects m_page->dragController()->sourceDragOperation(). (WebView::DragEnter): (WebView::DragOver): (WebView::Drop):
- WebView.h:
2009-10-15 Daniel Bates < dbates@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=24731
And
rdar://problem/5015961
Tests that DHTML drag-and-drop works correctly.
Note, this test fails when effectAllowed == "uninitialized" because
this effect has not been implemented yet (see bug #30291).
- fast/events/drag-and-drop-expected.txt: Added.
- fast/events/drag-and-drop.html: Added.
- 13:34 Changeset [49650] by
-
2009-10-15 Pavel Feldman < pfeldman@chromium.org>
Not reviewed - build fix.
Web Inspector: add file missing in r49648
- inspector/front-end/TestController.js: Added. (WebInspector.TestController): (WebInspector.TestController.prototype.waitUntilDone): (WebInspector.TestController.prototype.notifyDone): (WebInspector.evaluateForTestInFrontend):
- 12:55 Changeset [49649] by
-
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372
Reviewed by Darin Adler
Part 2 -- Reverse the TypeInfo HasDefaultMark flag to OverridesMarkChildren, etc
- 12:51 Changeset [49648] by
-
2009-10-15 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: introduce test controller with waitUntilDone
on frontend side.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/TestController.js: Added. (WebInspector.TestController): (WebInspector.TestController.prototype.waitUntilDone): (WebInspector.TestController.prototype.notifyDone): (WebInspector.evaluateForTestInFrontend):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
- 12:28 Changeset [49647] by
-
2009-10-15 Xan Lopez < xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Protect WebSocket calls in case the feature is not compiled in.
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
- 12:28 Changeset [49646] by
-
2009-10-15 Zan Dobersek < zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Rebaseline tests after changes made in r49405.
- platform/gtk/editing/execCommand/4916541-expected.txt: Rebaseline.
- platform/gtk/editing/execCommand/5138441-expected.txt: Ditto.
- platform/gtk/editing/execCommand/5481523-expected.txt: Ditto.
- 12:11 Changeset [49645] by
-
2009-10-15 Xan Lopez < xlopez@igalia.com>
Remove obsolete test from Skipped list.
- platform/gtk/Skipped:
- 12:04 Changeset [49644] by
-
2009-10-15 Daniel Bates < dbates@webkit.org>
Reviewed by Adam Barth.
Fixes an issue in which injecting an inline event handler whose value ends in a single-line
JavaScript comment can bypass the XSSAuditor. Similarly fixes this issue with respect to
the HTML Base element, HTML Object element, inline and external script tags, and
JavaScript multi-line variants of all of these attacks.
Tests: http/tests/security/xssAuditor/base-href-comment.html
http/tests/security/xssAuditor/iframe-javascript-url-comment.html
http/tests/security/xssAuditor/img-onerror-HTML-comment.html
http/tests/security/xssAuditor/img-onerror-comment.html
http/tests/security/xssAuditor/object-tag-comment.html
http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html
http/tests/security/xssAuditor/script-tag-comment.html
http/tests/security/xssAuditor/script-tag-with-source-comment.html
- page/XSSAuditor.cpp: Added constant minAttackLength. (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::canSetBaseElementURL): (WebCore::XSSAuditor::findInRequest): Added parameter context. Only looks at up to minAttackLength of script code plus context (if any).
- page/XSSAuditor.h:
2009-10-15 Daniel Bates < dbates@webkit.org>
Reviewed by Adam Barth.
Tests that inline event handlers whose value ends in a single-line JavaScript
comment cannot bypass the XSSAuditor. Also tests that the XSSAuditor prevents
similar attack vectors with respect to the HTML Base element, HTML Object
element, and external JavaScripts.
- http/tests/security/xssAuditor/base-href-comment-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-comment.html: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-comment-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-comment.html: Added.
- http/tests/security/xssAuditor/img-onerror-HTML-comment-expected.txt: Added.
- http/tests/security/xssAuditor/img-onerror-HTML-comment.html: Added.
- http/tests/security/xssAuditor/img-onerror-comment-expected.txt: Added.
- http/tests/security/xssAuditor/img-onerror-comment.html: Added.
- http/tests/security/xssAuditor/object-tag-comment-expected.txt: Added.
- http/tests/security/xssAuditor/object-tag-comment.html: Added.
- http/tests/security/xssAuditor/resources/echo-before-image.pl: Added.
- http/tests/security/xssAuditor/resources/echo-head-base-href-comment.pl: Added.
- http/tests/security/xssAuditor/script-tag-comment-HTML-entity-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html: Added.
- http/tests/security/xssAuditor/script-tag-comment-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-comment.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-comment-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-comment.html: Added.
- 11:42 Changeset [49643] by
-
WebKit/gtk
2009-10-15 Zan Dobersek < zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Add a settings to enable support for experimental Web Sockets.
Currently this comes in handy in layout tests.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
WebKitTools
2009-10-15 Zan Dobersek < zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Enable Web Sockets support when running layout tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 11:21 Changeset [49642] by
-
[Qt] Make QGLauncher's WebPage class constructor to get a QObject* as parent (not QWidget*).
Patch by Antonio Gomes < tonikitoo@webkit.org> on 2009-10-15
Rubberstamped by Tor Arne.
* QGVLauncher/main.cpp:
(WebPage::WebPage):
- 11:16 Changeset [49641] by
-
2009-10-08 Adam Langley < agl@google.com>
Reviewed by Eric Seidel.
Currently, Skia clip paths are 1-bit. This patch makes our path
clipping anti-aliased for non-canvas drawing.
http://code.google.com/p/chromium/issues/detail?id=5927
https://bugs.webkit.org/show_bug.cgi?id=28820
http://www.imperialviolet.org/2009/09/02/anti-aliased-clipping.html
Already covered by layout tests. New baselines will be needed in the
Chromium tree.
(Reland. First landed in r49329, reverted in r49330 due to Windows
build break)
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::clip):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::clipPath):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::clipPathAntiAliased): (PlatformContextSkia::restore): (PlatformContextSkia::applyAntiAliasedClipPaths):
- platform/graphics/skia/PlatformContextSkia.h:
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::canvasClip):
- 10:55 Changeset [49640] by
-
Rubber-stamped by Adele Peterson.
Add click-focus-anchor expected results on Windows, to make up for
the wonky way Windows finds its expected results.
* platform/win/fast/events/click-focus-anchor-expected.txt: Added.
- 10:53 Changeset [49639] by
-
2009-10-15 Gustavo Noronha Silva < gustavo.noronha@collabora.co.uk>
Unreviewed. Help text fix - Web Sockets default is no, not yes.
- configure.ac:
- 10:42 Changeset [49638] by
-
2009-10-15 Xan Lopez < xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Need to initialize event.button.button, since in most cases a
button number is not passed as an argument.
- DumpRenderTree/gtk/EventSender.cpp: (mouseDownCallback): (mouseUpCallback):
- 10:33 Changeset [49637] by
-
2009-10-15 Andras Becsi < becsi.andras@stud.u-szeged.hu>
Reviewed by Adam Treat.
[Qt] Add expected files for passing http tests.
- platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt: Added.
- platform/qt/http/tests/uri/css-href-expected.txt: Added.
- 10:32 Changeset [49636] by
-
2009-10-15 Eric Carlson < eric.carlson@apple.com>
Reviewed by Simon Fraser.
< rdar://problem/7295738> No way to mute/unmute a movie in full screen video mode
- WebCore.Video.exp: Export muted and setMute.
2009-10-15 Eric Carlson < eric.carlson@apple.com>
Reviewed by Simon Fraser.
< rdar://problem/7295738> No way to mute/unmute a movie in full screen video mode
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController setVolume:]): Unmute movie before changing volume.
- 10:26 Changeset [49635] by
-
2009-10-15 Andras Becsi < becsi.andras@stud.u-szeged.hu>
Reviewed by Adam Treat.
[Qt] Add expected files for passing svg tests.
- platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt: Added.
- platform/qt/svg/custom/mask-with-default-value-expected.txt: Added.
- platform/qt/svg/filters/feComposite-expected.txt: Added.
- platform/qt/svg/filters/feGaussianBlur-expected.txt: Added.
- platform/qt/svg/filters/feMerge-wrong-input-expected.txt: Added.
- platform/qt/svg/filters/sourceAlpha-expected.txt: Added.
- platform/qt/svg/filters/subRegion-in-userSpace-expected.txt: Added.
- 10:14 Changeset [49634] by
-
[Qt] QGLauncher crashes while closing a window
https://bugs.webkit.org/show_bug.cgi?id=30385
Patch by Antonio Gomes < tonikitoo@webkit.org> on 2009-10-15
Reviewed by Tor Arne.
Set page's pageClient reference to '0' at QGWV deletion.
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::~QGraphicsWebView):
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(WebPage::WebPage):
(WebPage::aborting):
(tst_QGraphicsWebView::crashOnViewlessWebPages):
- 09:52 Changeset [49633] by
-
2009-10-15 Simon Fraser < simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Transitions fail to run sometimes
https://bugs.webkit.org/show_bug.cgi?id=26770
Fix an issue where we could attempt to start accelerated animations or transitions on
GraphicsLayer that were not rooted (because of visibility:hidden), which would leave
the AnimationController's m_waitingForResponse flag in a state that killed subsequent
software transitions.
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::endAnimationUpdate): (WebCore::AnimationControllerPrivate::receivedStartTimeResponse): (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList): (WebCore::AnimationControllerPrivate::startTimeResponse):
- page/animation/AnimationControllerPrivate.h: Make some methods non-inline for ease of debugging (these are not hot methods). Rename m_waitingForAResponse to m_waitingForResponse.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::hasAncestor): New method to report whether the receiver has the given layer as an ancestor. Used for checking whether a layer is rooted.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): (WebCore::RenderLayerBacking::startTransition): Don't try to start accelerated animations or transitions on non-rooted GraphicsLayers.
- 09:50 Changeset [49632] by
-
2009-10-15 Alexander Pavlov < apavlov@chromium.org>
Reviewed by Pavel Feldman.
Refactor ProfilesPanel to support multiple profile types
Data describing different profile types are now stored in distinct objects.
https://bugs.webkit.org/show_bug.cgi?id=30332
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView.profileCallback): (WebInspector.CPUProfileView): (WebInspector.CPUProfileView.prototype._sortData): (WebInspector.CPUProfileType): (WebInspector.CPUProfileType.prototype.get buttonTooltip): (WebInspector.CPUProfileType.prototype.get buttonStyle): (WebInspector.CPUProfileType.prototype.buttonClicked): (WebInspector.CPUProfileType.prototype.setRecordingProfile): (WebInspector.CPUProfile): (WebInspector.CPUProfile.prototype.get title): (WebInspector.CPUProfile.prototype.get uid): (WebInspector.CPUProfile.prototype.get head): (WebInspector.CPUProfile.prototype.createView): (WebInspector.CPUProfile.prototype.viewForProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileType): (WebInspector.ProfileType.prototype.get buttonTooltip): (WebInspector.ProfileType.prototype.get buttonStyle): (WebInspector.ProfileType.prototype.get buttonCaption): (WebInspector.ProfileType.prototype.get id): (WebInspector.ProfileType.prototype.get name): (WebInspector.ProfileType.prototype.buttonClicked): (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.get statusBarItems.clickHandler): (WebInspector.ProfilesPanel.prototype.get statusBarItems): (WebInspector.ProfilesPanel.prototype.reset): (WebInspector.ProfilesPanel.prototype.registerProfileType): (WebInspector.ProfilesPanel.prototype._makeKey): (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.showProfile): (WebInspector.ProfilesPanel.prototype.getProfileType): (WebInspector.ProfilesPanel.prototype.showProfileForURL): (WebInspector.ProfilesPanel.prototype.updateProfileTypeButtons): (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink): (WebInspector.ProfilesPanel.prototype.get searchableViews): (WebInspector.ProfilesPanel.prototype._updateInterface):
- inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.addProfileHeader): (WebInspector.setRecordingProfile): (WebInspector.linkifyStringAsFragment): (WebInspector.showProfileForURL):
- 09:46 Changeset [49631] by
-
2009-10-15 Pavel Feldman < pfeldman@chromium.org>
Not reviewed: remove timer-related logs from the previously
submitted test.
- inspector/console-tests-expected.txt:
- inspector/console-tests.html:
- 09:21 Changeset [49630] by
-
wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
the OS if none was explicitly set.
- 09:16 Changeset [49629] by
-
2009-10-15 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Enable inspector layout tests.
WebCore:
- inspector/InspectorController.cpp: (WebCore::InspectorController::evaluateForTestInFrontend):
LayoutTests:
- inspector/elements-panel-structure-expected.txt:
- inspector/elements-panel-structure.html:
- inspector/evaluate-in-frontend.js: (evaluateInWebInspector): (window.didEvaluateForTestInFrontend):
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
- 08:31 Changeset [49628] by
-
2009-10-15 Xan Lopez < xlopez@igalia.com>
Skip new SVG tests without expected results for GTK+.
- platform/gtk/Skipped:
- 07:56 Changeset [49627] by
-
2009-10-15 Gustavo Noronha Silva < gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
page transition may crash webkit
https://bugs.webkit.org/show_bug.cgi?id=29890
There are actually cases in which a resource may be asked using
webkit_web_view_get_resource after a new load has already been
started, so protect ourselves from crashes in this case.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
- webkit/webkitwebview.cpp: (webkit_web_view_get_resource):
- 07:46 Changeset [49626] by
-
2009-10-15 Philippe Normand < pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GStreamer] READY state doesn't mean "enough data"
https://bugs.webkit.org/show_bug.cgi?id=30003
STATE_READY means MediaPlayer::HaveNothing
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::updateStates):
- 07:35 Changeset [49625] by
-
2009-10-15 Xan Lopez < xlopez@igalia.com>
Skip a couple of tests that need support for dumpEditingCallbacks.
- platform/gtk/Skipped:
- 07:31 Changeset [49624] by
-
2009-10-15 Philippe Normand < pnormand@igalia.com>
Reviewed by Gustavo Noronha.
implement cancelLoad
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::cancelLoad):
- 07:16 Changeset [49623] by
-
2009-10-15 Sebastian Dröge < sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Fix race condition, leading to a deadlock
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_timeout_func): (webkit_video_sink_render): (unlock_buffer_mutex): (webkit_video_sink_unlock): (webkit_video_sink_unlock_stop): (webkit_video_sink_stop): (webkit_video_sink_start): (webkit_video_sink_class_init): Fix race condition in unlock/render that would lead to deadlocks.
- 06:25 Changeset [49622] by
-
2009-10-15 Sebastian Dröge < sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Check if caps are valid before parsing them
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration): Check if caps are valid before parsing them in ::naturalSize(). This prevents assertions if the natural size should be calculated before the video caps are negotiated.
- 06:09 Changeset [49621] by
-
2009-10-15 Philippe Normand < pnormand@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=30006
[GStreamer] Unnecessary checks for Messages types in callbacks
refactored gst message callbacks into a single one
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::do_gst_init): (WebCore::MediaPlayerPrivate::duration):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- 05:58 Changeset [49620] by
-
Fix the Qt build on Mac OS X
- 05:49 Changeset [49619] by
-
2009-10-15 Shu Chang < Chang.Shu@nokia.com>
Reviewed by Adele Peterson.
Change behavior so that <a> element is always mouse-focusable.
- fast/events/click-focus-anchor-expected.txt:
- fast/events/click-focus-anchor.html:
2009-10-15 Shu Chang < Chang.Shu@nokia.com>
Reviewed by Adele Peterson.
Anchor elements should be mouse focusable regardless isLink flag.
https://bugs.webkit.org/show_bug.cgi?id=26856
- html/HTMLAnchorElement.cpp:
- html/HTMLAnchorElement.h:
- 05:41 Changeset [49618] by
-
[Qt] Make context menu to work in QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=30336
Patch by Antonio Gomes < tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::event):
- 05:32 Changeset [49617] by
-
Not reviewed. Sort XCode project file.
- 03:44 QtWebKitContrib edited by
- (diff)
- 03:41 QtWebKitContrib edited by
- (diff)
- 03:40 QtWebKitContrib edited by
- (diff)
- 03:35 BuildingQtOnLinux edited by
- merging install line into a single one and adding the required … (diff)
- 02:40 Changeset [49616] by
-
2009-10-15 Yury Semikhatsky < yurys@chromium.org>
Reviewed by Dave Hyatt.
Return correct shorthand property name for
background-repeat-x, background-repeat-y, background-position-x,
background-position-y, -webkit-mask-position-x, -webkit-mask-position-y,
-webkit-mask-repeat-x, -webkit-mask-repeat-y.
Test: fast/backgrounds/repeat/background-repeat-shorthand.html
WebCore
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
LayoutTests:
- fast/backgrounds/repeat/background-repeat-shorthand-expected.txt: Added.
- fast/backgrounds/repeat/background-repeat-shorthand.html: Added.
- fast/backgrounds/repeat/resources/background-repeat-shorthand.css: Added.
- fast/backgrounds/repeat/resources/background-repeat-shorthand.js: Added. (getShorthand):
- 02:31 Changeset [49615] by
-
2009-10-14 Mikhail Naganov < mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Migrate profiles to the injected script-based schema.
- bindings/js/JSInspectorBackendCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfileHeaders): (WebCore::InspectorBackend::getProfile):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::createProfileHeader):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile):
- inspector/InspectorFrontend.h:
- inspector/JavaScriptProfileNode.cpp: (WebCore::ProfileNodeClass):
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView.profileCallback): (WebInspector.ProfileView): (WebInspector.ProfileView.prototype._mouseDownInDataGrid): (WebInspector.ProfileView.prototype._assignParentsInProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader):
- inspector/front-end/inspector.js: (WebInspector.addProfileHeader):
- 02:15 Changeset [49614] by
-
2009-10-14 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Create and update frontend script objects only when
web inspector is visible.
- inspector/InspectorController.cpp: (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::pruneResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::mainResourceFiredDOMContentEvent): (WebCore::InspectorController::mainResourceFiredLoadEvent): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::evaluateForTestInFrontend):
- 01:56 Changeset [49613] by
-
2009-10-14 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: enable developers extras within inspector layout tests.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
- 00:35 Changeset [49612] by
-
2009-10-14 José Millán Soto < jmillan@igalia.com>
Reviewed by Jan Alonzo.
GtkLauncher is using a deprecated signal
https://bugs.webkit.org/show_bug.cgi?id=30364
Modified GtkLauncher to use notify::title signal instead of
deprecated title-changed signal
- GtkLauncher/main.c: (notify_title_cb): (create_browser):
- 00:10 Changeset [49611] by
-
2009-10-15 Joseph Pecoraro < joepeck@webkit.org>
Fix Windows build.
- dom/Document.idl:
10/14/09:
- 23:41 Changeset [49610] by
-
2009-10-14 Joseph Pecoraro < joepeck@webkit.org>
Reviewed by Adam Barth.
[HTML5] Add document.head
https://bugs.webkit.org/show_bug.cgi?id=30232
Test is fast/dom/document-head.html
- dom/Document.idl: added readonly attribute head
- 23:12 Changeset [49609] by
-
2009-10-14 Matt Mueller < mattm@chromium.org>
Reviewed by Darin Adler.
Check FNonNeg after the unit switch to avoid valgrind uninitialised conditional reference in WebCore::CSSParser::validUnit. See http://crbug.com/20939.
https://bugs.webkit.org/show_bug.cgi?id=30347
https://bugs.webkit.org/show_bug.cgi?id=22772
Covered by running LayoutTests/fast/css/invalid-percentage-property.html under valgrind.
- css/CSSParser.cpp: (WebCore::CSSParser::validUnit):
- 22:15 Changeset [49608] by
-
2009-10-14 Adam Barth < abarth@webkit.org>
Reviewed by Sam Weinig.
Move scrolling code from FrameLoader to FrameView
https://bugs.webkit.org/show_bug.cgi?id=30370
This code is about controlling the Frame's view, not about loading
stuff into the frame.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::scrollToAnchor):
- page/FrameView.cpp: (WebCore::FrameView::scrollToFragment): (WebCore::FrameView::scrollToAnchor):
- page/FrameView.h:
- 20:24 Changeset [49607] by
-
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372
Reviewed by Geoff Garen.
Part 1. Reverse the HasStandardGetOwnPropertySlot flag.
- 19:39 Changeset [49606] by
-
2009-10-14 Evan Martin < evan@chromium.org>
Reviewed by Darin Adler.
Document what state the build tree is expected to be in after a patch.
- coding/contributing.html:
- 19:14 Changeset [49605] by
-
2009-10-14 Adam Barth < abarth@webkit.org>
Reviewed by Darin Adler.
[XSSAuditor] Add an exception for local files
https://bugs.webkit.org/show_bug.cgi?id=30352
Test that we allow sites to load scripts from their own domain as long
as they don't use query strings.
- http/tests/security/xssAuditor/script-tag-with-source-same-host-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-same-host.html: Added.
2009-10-14 Adam Barth < abarth@webkit.org>
Reviewed by Darin Adler.
[XSSAuditor] Add an exception for local files
https://bugs.webkit.org/show_bug.cgi?id=30352
Reduce XSS auditor false positives by always letting pages load scripts
from their own host. We don't actually know of any false positives
that this prevents, but it seems like a good idea.
One subtly is that we don't add this exception for scripts that have a
query string because (1) URLs with query strings are more apt to
confuse servers and (2) it is much less common to load scripts with a
query string.
Tests: http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html
http/tests/security/xssAuditor/script-tag-with-source-same-host.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
- 17:33 Changeset [49604] by
-
Unbreak the world.
- Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::restart):
- 17:14 Changeset [49603] by
-
Reviewed by Anders Carlsson and Jon Honeycutt
< rdar://problem/7304295> snapshots of halted plug-ins are missing
- Plugins/WebBaseNetscapePluginView.mm: Move bodies of WebHaltablePlugin virtual functions from WebHaltablePlugin class definition. (WebHaltablePlugin::halt): Provide a substitute image to the RenderWidget for the plug-in view. (WebHaltablePlugin::restart): Clear the substitute image.
- 16:54 Changeset [49602] by
-
2009-10-14 Nikolas Zimmermann < nzimmermann@rim.com>
Reviewed by George Staikos.
Kill virtual contextElement() method spread all over SVG code
https://bugs.webkit.org/show_bug.cgi?id=30183
Remove virtual contextElement() function from all SVG*Element classes, as all animated properties live in the
SVG*Element classes now instead of the SVGFitToViewBox / SVGURIReference / SVGExternalResourcesRequired
subclasses. This is a first step to working animVal support. More patches will follow that depend on this change.
Remove "This file is part of the KDE project" from several files, change my old mail adress wildfox -> zimmermann,
and remove vim modelines on all files I touched. No change in functionality, thus no new tests.
- svg/SVGAElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGAltGlyphElement.h: Remove virtual contextElement() method.
- svg/SVGAnimatedProperty.h: (WebCore::::synchronize): (WebCore::::startAnimation): (WebCore::::stopAnimation):
- svg/SVGAnimationElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGCircleElement.h: Ditto.
- svg/SVGClipPathElement.h: Ditto.
- svg/SVGCursorElement.h: Ditto.
- svg/SVGDefsElement.h: Ditto.
- svg/SVGEllipseElement.h: Ditto.
- svg/SVGExternalResourcesRequired.h: Remove pure-virtual contextElement() method.
- svg/SVGFEImageElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGFELightElement.h: Remove virtual contextElement() method.
- svg/SVGFEMergeNodeElement.h: Ditto.
- svg/SVGFilterElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGFilterPrimitiveStandardAttributes.h: Remove virtual contextElement() method.
- svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseViewBox): Add Document* parameter - we used to fetch the Document pointer from the context element. (WebCore::SVGFitToViewBox::parseMappedAttribute): Ditto.
- svg/SVGFitToViewBox.h: Remove pure-virtual contextElement() method.
- svg/SVGFontElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGForeignObjectElement.h: Ditto.
- svg/SVGGElement.h: Ditto.
- svg/SVGGradientElement.h: Ditto.
- svg/SVGImageElement.h: Ditto.
- svg/SVGLineElement.h: Ditto.
- svg/SVGMPathElement.h: Ditto. Fix license indention.
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGMarkerElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGMaskElement.h: Ditto.
- svg/SVGPathElement.h: Ditto.
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGPatternElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::updateAnimatedSVGAttribute): synchronizeProperty<...>() has been renamed to PropertySynchronizer<...>::synchronize().
- svg/SVGPolyElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGRectElement.h: Ditto.
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGSVGElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGScriptElement.h: Ditto.
- svg/SVGSwitchElement.h: Ditto.
- svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGSymbolElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGTRefElement.h: Remove virtual contextElement() method.
- svg/SVGTextContentElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGTextPathElement.h: Remove virtual contextElement() method.
- svg/SVGUseElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGViewElement.cpp: (WebCore::SVGViewElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGViewElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::setViewBoxString): Pass document() to SVGFitToViewBox::parseMappedAttribute(). (WebCore::SVGViewSpec::parseViewSpec): Ditto.
- svg/SVGViewSpec.h: Devirtualize contextElement() method, it's the only place where contextElement() remains needed.
- 16:48 Changeset [49601] by
-
Fix a failure seen on buildbot after landing the fix for
https://bugs.webkit.org/show_bug.cgi?id=18994
Patch by Darin Adler < darin@apple.com> on 2009-10-14
* platform/win/fast/css/large-number-round-trip-expected.txt: Removed.
- 16:29 Changeset [49600] by
-
Versioning.
- 16:27 Changeset [49599] by
-
New tag.
- 16:21 Changeset [49598] by
-
2009-10-14 Dirk Schulze < krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Masking with wrong offset
https://bugs.webkit.org/show_bug.cgi?id=30325
SVGMaskElement moves the mask image graphics context to the wrong location.
In objectBoundingBoxMode the maskDestRect gets translated. This transformation
is not used in the later calculation. Fix by consistenly calculating the translation
offsets from the final mask destination rect.
Test: svg/custom/mask-with-default-value.svg
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
2009-10-14 Dirk Schulze < krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Masking with wrong offset
https://bugs.webkit.org/show_bug.cgi?id=30325
SVGMaskElement moves the mask image graphics context to the wrong location.
In objectBoundingBoxMode the maskDestRect gets translated. This transformation
is not used in the later calculation. Fix by consistenly calculating the translation
offsets from the final mask destination rect.
Test: svg/custom/mask-with-default-value.svg
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- 16:14 Changeset [49597] by
-
Rubberstamped by Jon Honeycutt.
Export a few more showSubstituteImage() related methods.
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- 16:11 Changeset [49596] by
-
Fix failures seen on buildbot after landing the fix for
https://bugs.webkit.org/show_bug.cgi?id=18994
Patch by Darin Adler < darin@apple.com> on 2009-10-14
Reviewed by Mark Rowe.
Somehow I had the mac/fast/css/opacity-float-expected.txt
removed locally, and Subversion didn't check that in!
* platform/mac/fast/css/opacity-float-expected.txt: Removed.
* platform/win/fast/css/opacity-float-expected.txt: Removed.
- 16:04 Changeset [49595] by
-
Versioning.
- 16:00 Changeset [49594] by
-
Disable plugins/private-browsing-mode.html on Snow Leopard.
Reviewed by Sam Weinig.
* platform/mac-snowleopard/Skipped:
- 15:42 Changeset [49593] by
-
Merge r47620.
- 15:38 Changeset [49592] by
-
https://bugs.webkit.org/show_bug.cgi?id=30269
Use onload to detect iframe load, rather than setTimeout.
This will give more consistent test results and hopefully faster run times.
Patch by Julie Parent < jparent@chromium.org> on 2009-10-13
Reviewed by Darin Adler.
* editing/execCommand/paste-1.html:
* editing/execCommand/paste-2.html:
* editing/pasteboard/subframe-dragndrop-1.html:
* editing/selection/4776665.html:
* editing/selection/4975120.html:
* editing/selection/5136696.html:
* editing/selection/drag-to-contenteditable-iframe.html:
* platform/mac/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
* platform/qt/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
* platform/win/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
- 14:46 Changeset [49591] by
-
Merge r48531.
- 14:46 Changeset [49590] by
-
Merge r48529.
- 14:46 Changeset [49589] by
-
Merge r48446.
- 14:46 Changeset [49588] by
-
Merge r48396.
- 14:46 Changeset [49587] by
-
Merge r48375.
- 14:46 Changeset [49586] by
-
Merge r48370.
- 14:45 Changeset [49585] by
-
JavaScriptCore: Additions so fix for https://bugs.webkit.org/show_bug.cgi?id=18994
can build on Windows.
Patch by Darin Adler < darin@apple.com> on 2009-10-14
* wtf/MathExtras.h: Added llround and llroundf for Windows.
WebCore: Stringify CSS units manually (without printf) to make the formatting
locale-insensitive and obey CSS spec with respect to large values.
Patch by Evan Martin < evan@chromium.org> on 2009-10-14
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=18994
* css/CSSPrimitiveValue.cpp:
(WebCore::appendCSSDouble):
(WebCore::formatWithUnits):
(WebCore::CSSPrimitiveValue::cssText):
LayoutTests: Float formatting changes affect three tests:
- large-number-round-trip now passes
- opacity-float now passes and has more test cases
- compound-2d-transforms output tweaked slightly
Patch by Evan Martin < evan@chromium.org> on 2009-10-14
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=18994
* fast/css/large-number-round-trip-expected.txt:
* fast/css/opacity-float-expected.txt:
* fast/css/opacity-float.html:
* platform/mac/fast/css/opacity-float-expected.txt: Removed.
* transforms/2d/compound-2d-transforms-expected.txt:
* transforms/2d/compound-2d-transforms.html:
- 14:41 Changeset [49584] by
-
2009-10-14 Mark Seaborn < mseaborn@google.com>
Reviewed by Darin Adler.
Check error return value in Perl build script
https://bugs.webkit.org/show_bug.cgi?id=30316
- css/makevalues.pl: Die if gperf fails.
- 13:39 Changeset [49583] by
-
Roll out r49580 as it is completely wrong and breaks the Mac builds.
- 13:30 Changeset [49582] by
-
2009-10-14 Dirk Schulze < krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG wrong filterRegions for userSpaceOnUse and percentage values
https://bugs.webkit.org/show_bug.cgi?id=30330
Some clean-up of the SVG filter calculation code. This clean-up
also fixes the problem with percentage and userSpaceInUse mode.
Test: svg/filters/subRegion-in-userSpace.svg
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect):
- platform/graphics/filters/FilterEffect.h:
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::buildFilter): (WebCore::SVGFilterElement::canvasResource):
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
- svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::addFilterEffect): (WebCore::SVGResourceFilter::prepareFilter):
- svg/graphics/SVGResourceFilter.h: (WebCore::SVGResourceFilter::create):
- svg/graphics/filters/SVGFilter.cpp: (WebCore::SVGFilter::SVGFilter): (WebCore::SVGFilter::calculateEffectSubRegion): (WebCore::SVGFilter::create):
- svg/graphics/filters/SVGFilter.h:
Reviewed by Nikolas Zimmermann.
Check if the percentage of effect values takes user space as reference and
not the FilterRect.
- platform/mac/svg/filters/subRegion-in-userSpace-expected.checksum: Added.
- platform/mac/svg/filters/subRegion-in-userSpace-expected.png: Added.
- platform/mac/svg/filters/subRegion-in-userSpace-expected.txt: Added.
- svg/filters/subRegion-in-userSpace.svg: Added.
- 12:32 Changeset [49581] by
-
WebKitTools: Don't set the history delegate on new windows that are opened during a test, as the history delegate:
1 - Disables WebHistory
2 - Doesn't make sense in that context anyway.
Reviewed by Sam Weinig.
* DumpRenderTree/win/DumpRenderTree.cpp:
(createWebViewAndOffscreenWindow):
LayoutTests: Un-skip a test that now passes.
Reviewed by Sam Weinig.
* platform/win/Skipped:
- 12:01 Changeset [49580] by
-
Mac build fix, use MIN_REQUIRED rather than MAX_ALLOWED to determine
compilation of code that requires 10.6.
- 11:51 Changeset [49579] by
-
wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
- 11:41 Changeset [49578] by
-
The last change fixed the problem, removing diagnostic printfs.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 11:34 BuildingOnWindows edited by
- Add (non-ideal) workaround for Visual Studio 2005 missing Crypt32.lib … (diff)
- 11:31 Changeset [49577] by
-
CURL build fix for versions < 7.18.
- 11:30 Changeset [49576] by
-
2009-10-14 Nate Chapin < japhet@chromium.org>
Unreviewed, build fix.
When I landed r49569 for Victor, I failed to svn add one of the required files.
This should fix the redness on the Windows test bots.
- platform/win/editing/pasteboard/paste-xml-expected.txt: Added.
- 11:18 Changeset [49575] by
-
One more round of changes to figure out why the webgl
tests are crashing on the build bot. Here I am trying
to see if we can create a software renderer. I am also
printing the found pixel formats.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 10:42 Changeset [49574] by
-
Enabling NPAPI plugin support on Qt Webkit for S60 platform
https://bugs.webkit.org/show_bug.cgi?id=29302
Patch by Yael Aharon < yael.aharon@nokia.com> on 2009-10-14
Reviewed by
Also implemented by Mahesh Kulkarni< mahesh.kulkarni@nokia.com>,
Rohini Ananth < rohini.ananth@nokia.com> and help from Norbert Lesr
< norbert.leser@nokia.com>
- 10:34 Changeset [49573] by
-
2009-10-14 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: skip inspector tests that were recently added
until harness is fixed in release mode.
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 10:29 Changeset [49572] by
-
Skip my two new failures while I'm actively looking at them.
* platform/win/Skipped:
- 10:18 Changeset [49571] by
-
More changes to figure out why the webgl tests are crashing on the build bot.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 10:11 Changeset [49570] by
-
wx build fix. Set ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH for plugins while we're still building stubs.
- 10:02 Changeset [49569] by
-
2009-10-14 Victor Wang < victorw@chromium.org>
Reviewed by Darin Adler.
Add paste-xml test back for Win.
The result difference between Mac and Win is due to the
platform dependent implementation. The diff is expected
with current implementation.
See bug for more deails:
- platform/win/Skipped:
- platform/win/editing/pasteboard/paste-xml-expected.txt: Added.
- 09:39 Changeset [49568] by
-
2009-10-14 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add initial layout tests for web inspector.
- inspector/console-tests-expected.txt: Added.
- inspector/console-tests.html: Added.
- inspector/elements-panel-structure-expected.txt: Added.
- inspector/elements-panel-structure.html: Added.
- inspector/evaluate-in-frontend-expected.txt: Added.
- inspector/evaluate-in-frontend.html: Added.
- inspector/evaluate-in-frontend.js: Added.
- 09:26 Changeset [49567] by
-
2009-10-14 Victor Wang < victorw@chromium.org>
Reviewed by David Hyatt.
Round non-integer line height values.
Change webkit to rounding non-integer line height values
instead of truncating them. This fixes a layout test
failure on Windows and matches the calculation in IE and Firefox.
- 09:23 Changeset [49566] by
-
Windows build fix
* WebKit.vcproj/Interfaces.vcproj: Exclude IWebHistoryDelegate and
IWebNavigationData from the build (they get #imported via WebKit.idl).
- 09:21 Changeset [49565] by
-
2009-10-13 Kelly Norton < knorton@google.com>
Reviewed by Pavel Feldman.
Removes the persistent setting for InspectorTimelineAgent and renames timeline related
interfaces to be more consistent with the JavaScript profiler.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::startTimelineProfiler): (WebCore::InspectorBackend::stopTimelineProfiler): (WebCore::InspectorBackend::timelineProfilerEnabled):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::timelineProfilerEnabled):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::timelineProfilerWasStarted): (WebCore::InspectorFrontend::timelineProfilerWasStopped):
- inspector/InspectorFrontend.h:
- inspector/front-end/TimelineAgent.js: (WebInspector.timelineProfilerWasStarted): (WebInspector.timelineProfilerWasStopped):
- 09:03 Changeset [49564] by
-
WebKit Win API should provide a delegate interface for global history.
https://bugs.webkit.org/show_bug.cgi?id=29905
Reviewed by Sam Weinig.
WebKit/win:
-Add IWebHistoryDelegate for clients to implement.
-Add (I)WebNavigationData for the history delegate's use.
-When it exists, call the history delegate instead of using WebHistory.
* Interfaces/IWebHistoryDelegate.idl: Added.
* Interfaces/IWebHistoryPrivate.idl:
* Interfaces/IWebNavigationData.idl: Added.
* Interfaces/IWebViewPrivate.idl:
* Interfaces/WebKit.idl:
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.vcproj:
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::populateVisitedLinks):
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistory):
(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebFrameLoaderClient::setTitle):
- WebView.cpp:
(WebView::close):
(WebView::mainFrameURL):
(WebView::setHistoryDelegate):
(WebView::historyDelegate):
(WebView::addVisitedLinks):
* WebView.h:
* WebHistory.cpp:
(WebHistory::setVisitedLinkTrackingEnabled):
(WebHistory::removeAllVisitedLinks):
* WebHistory.h:
* WebNavigationData.cpp: Added.
(WebNavigationData::QueryInterface):
(WebNavigationData::AddRef):
(WebNavigationData::Release):
(WebNavigationData::WebNavigationData):
(WebNavigationData::~WebNavigationData):
(WebNavigationData::createInstance):
(WebNavigationData::url):
(WebNavigationData::title):
(WebNavigationData::originalRequest):
(WebNavigationData::response):
(WebNavigationData::hasSubstituteData):
(WebNavigationData::clientRedirectSource):
* WebNavigationData.h: Added.
WebKitTools:
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::dumpHistoryDelegateCallbacks):
(LayoutTestController::setDumpHistoryDelegateCallbacks):
* DumpRenderTree/win/DumpRenderTree.cpp:
(shouldLogHistoryDelegates):
(runTest):
(createWebViewAndOffscreenWindow):
(main):
* DumpRenderTree/win/DumpRenderTree.vcproj:
Add the IWebHistoryDelegate to DRT Windows:
* DumpRenderTree/win/HistoryDelegate.cpp: Added.
(wstringFromBSTR):
(HistoryDelegate::HistoryDelegate):
(HistoryDelegate::~HistoryDelegate):
(HistoryDelegate::QueryInterface):
(HistoryDelegate::AddRef):
(HistoryDelegate::Release):
(HistoryDelegate::didNavigateWithNavigationData):
(HistoryDelegate::didPerformClientRedirectFromURL):
(HistoryDelegate::didPerformServerRedirectFromURL):
(HistoryDelegate::updateHistoryTitle):
(HistoryDelegate::populateVisitedLinksForWebView):
* DumpRenderTree/win/HistoryDelegate.h: Added.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::removeAllVisitedLinks):
LayoutTests:
* platform/win/Skipped: Enable globalhistory tests.
- 09:02 Changeset [49563] by
-
2009-10-14 Shu Chang < Chang.Shu@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Implement support for setPOSIXLocale on Qt.
https://bugs.webkit.org/show_bug.cgi?id=30268
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setPOSIXLocale):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 08:48 Changeset [49562] by
-
2009-10-02 Yong Li < yong.li@torchmobile.com>
Reviewed by Adele Peterson.
Fixed crash when loading invalid image data.
Also added a test case that loads an invalid image to make sure
we don't crash in this situation.
https://bugs.webkit.org/show_bug.cgi?id=29980
WebCore:
- rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText):
LayoutTests:
- fast/images/image-invalid-data-expected.txt: Added.
- fast/images/image-invalid-data.html: Added.
- fast/images/resources/invalid.jpg: Added.
- 08:40 QtWebKitPerformanceToolBackLog: edited by
- (diff)
- 08:30 QtBackLog edited by
- (diff)
- 08:02 Changeset [49561] by
-
WebCore: Fix for NULL ptr deref in canvas's toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=30254
Reviewed by Eric Seidel.
Test: fast/canvas/canvas-toDataURL-crash.html
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toDataURL):
LayoutTests: New test for NULL ptr deref in canvas's toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=30254
Reviewed by Eric Seidel.
* fast/canvas/canvas-toDataURL-crash-expected.txt: Added.
* fast/canvas/canvas-toDataURL-crash.html: Added.
- 07:54 Changeset [49560] by
-
2009-10-14 Pavel Feldman < pfeldman@chromium.org>
Not reviewed, reverting r49558 since it broke profiler tests.
- bindings/js/JSInspectorBackendCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfileHeaders): (WebCore::InspectorBackend::getProfile):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::createProfileHeader):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile):
- inspector/InspectorFrontend.h:
- inspector/JavaScriptProfileNode.cpp: (WebCore::ProfileNodeClass):
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView.profileCallback): (WebInspector.ProfileView): (WebInspector.ProfileView.prototype._mouseDownInDataGrid): (WebInspector.ProfileView.prototype._assignParentsInProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader):
- inspector/front-end/inspector.js: (WebInspector.addProfileHeader):
- 07:10 Changeset [49559] by
-
ImageDecoderQt: Minor tweaks to the decoder
- Only cache the data when we start to use it.
- Start with a repetition count of none for normal images.
- Do not use canRead as this will trigger parsing of the full image
- Cope with a GIF failing to decode the first frame, do not
set m_failed to true if decoding the first frame failed
- Inform the QImageReader about the format that was detected
- Always create a ImageDecoderQt when when we have more
than four byte.
- 06:32 Changeset [49558] by
-
2009-10-14 Mikhail Naganov < mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Migrate profiles to the injected script-based schema.
- bindings/js/JSInspectorBackendCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfileHeaders): (WebCore::InspectorBackend::getProfile):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::createProfileHeader):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile):
- inspector/InspectorFrontend.h:
- inspector/JavaScriptProfileNode.cpp: (WebCore::ProfileNodeClass):
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView.profileCallback): (WebInspector.ProfileView): (WebInspector.ProfileView.prototype._mouseDownInDataGrid): (WebInspector.ProfileView.prototype._assignParentsInProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader):
- inspector/front-end/inspector.js: (WebInspector.addProfileHeader):
- 02:14 Changeset [49557] by
-
2009-10-13 Yury Semikhatsky < yurys@chromium.org>
Reviewed by Pavel Feldman.
Don't collect call frame properties until they're needed for completion.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions):
- inspector/front-end/InjectedScript.js: (InjectedScript.getCompletions): if call frame id is specified and the expression is empty collect frame properties. (InjectedScript.CallFrameProxy.prototype._wrapScopeChain): don't send call frame properties until they're needed.
- inspector/front-end/ScriptsPanel.js:
10/13/09:
- 22:14 Changeset [49556] by
-
2009-10-13 Yongjun Zhang < yongjun.zhang@nokia.com>
Reviewed by Ariya Hidayat.
https://bugs.webkit.org/show_bug.cgi?id=29106
[Qt] make CachedResourceHandle.h compile in winscw Symbian compiler.
Don't inline constructor CachedResourceHandle<T>(R*) to stop winscw
compiler aggressively resolve inheritance of class R.
The winscw compiler bug is reported at:
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.
The change should be reverted when the above bug is fixed in winscw compiler.
- loader/CachedResourceHandle.h: (WebCore::::CachedResourceHandle):
- 21:43 Changeset [49555] by
-
2009-10-13 Dimitri Glazkov < dglazkov@chromium.org>
No review, rolling out r49554, because it broke Win and Chromium builds.
http://trac.webkit.org/changeset/49554
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
- 21:09 Changeset [49554] by
-
2009-10-13 Evan Martin < evan@chromium.org>
Reviewed by Adam Barth.
Float formatting changes affect three tests:
- large-number-round-trip now passes
- opacity-float now passes and has more test cases
- compound-2d-transforms output tweaked slightly
- fast/css/large-number-round-trip-expected.txt:
- fast/css/opacity-float-expected.txt:
- fast/css/opacity-float.html:
- platform/mac/fast/css/opacity-float-expected.txt: Removed.
- transforms/2d/compound-2d-transforms-expected.txt:
- transforms/2d/compound-2d-transforms.html:
2009-10-13 Evan Martin < evan@chromium.org>
Reviewed by Adam Barth.
Stringify CSS units manually (without printf) to make the formatting
locale-insensitive and obey CSS spec with respect to large values.
- css/CSSPrimitiveValue.cpp: (WebCore::appendCSSDouble): (WebCore::formatWithUnits): (WebCore::CSSPrimitiveValue::cssText):
- 20:52 Changeset [49553] by
-
2009-10-13 Evan Martin < evan@chromium.org>
Reviewed by David Levin.
Make grippy lines vertical on horizontal scrollbars in Linux Chrome.
While we're rebaselining scrollbars, fix an off by one in the vertical
scrollbar rendering too.
Tests: this is covered by every pixel test involving scrollbars.
- platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
- 20:37 Changeset [49552] by
-
2009-10-13 Zan Dobersek < zandobersek@gmail.com>
Reviewed by Holger Freyther.
[LayoutTests][Gtk] Set a common Gtk theme as default and update the results
https://bugs.webkit.org/show_bug.cgi?id=30223
Update test results to reflect the usage of the default theme.
- platform/gtk/editing/selection/iframe-expected.txt:
- platform/gtk/editing/selection/select-box-expected.txt:
- 20:16 Changeset [49551] by
-
WebCore: Fix issue where clientX and clientY on MouseEvents were wrong when
the page was zoomed and scrolled.
Reviewed by David Hyatt.
Test: fast/events/clientXY-in-zoom-and-scroll.html
* dom/MouseRelatedEvent.cpp:
(WebCore::contentsX): Take page zoom into account.
(WebCore::contentsY): Ditto.
LayoutTests: Test issue where clientX and clientY on MouseEvents were wrong when
the page was zoomed and scrolled.
Reviewed by David Hyatt.
* fast/events/clientXY-in-zoom-and-scroll-expected.txt: Added.
* fast/events/clientXY-in-zoom-and-scroll.html: Added.
- 19:42 Changeset [49550] by
-
Fix more WebView bustage.
* WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
- 19:22 Changeset [49549] by
-
Merge r48770.
- 19:22 Changeset [49548] by
-
Merge r48689.
- 19:22 Changeset [49547] by
-
Fix build bustage on Windows.
* WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
- 19:03 Changeset [49546] by
-
Merge r48324.
- 19:03 Changeset [49545] by
-
Merge r48308.
- 18:54 Changeset [49544] by
-
Unreviewed, adding myself to reviewers list.
* Scripts/modules/committers.py:
- 18:52 Changeset [49543] by
-
Fix null assignment so root tests work again.
Reviewed by Mark Rowe.
* Scripts/webkitdirs.pm:
- 18:38 Changeset [49542] by
-
Fix DumpRenderTree to account for API changes in the user script stuff.
- 18:37 Changeset [49541] by
-
WebCore: Change the order of arguments on some of the user stylesheet/script functions. Split the removal functions
out into separate ones for scripts and stylesheets.
Reviewed by Adam Roben.
* WebCore.base.exp:
* page/PageGroup.cpp:
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
* page/PageGroup.h:
(WebCore::PageGroup::userScripts):
(WebCore::PageGroup::userStyleSheets):
WebKit/mac: Change the order of arguments on some methods. Split removal for user stylesheets and script into
separate functions based off the type of object being removed.
Reviewed by Adam Roben.
* WebView/WebView.mm:
(+[WebView _addUserScriptToGroup:worldID:source:url:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:worldID:source:url:whitelist:blacklist:]):
(+[WebView _removeUserScriptFromGroup:worldID:url:]):
(+[WebView _removeUserStyleSheetFromGroup:worldID:url:]):
(+[WebView _removeUserScriptsFromGroup:worldID:]):
(+[WebView _removeUserStyleSheetsFromGroup:worldID:]):
* WebView/WebViewPrivate.h:
WebKit/win: Split removal functions for user scripts and stylehseets based on type.
Reviewed by Adam Roben..
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
* WebView.h:
- 18:16 Changeset [49540] by
-
Chrome's "Skia" theme paints select controls backwards in RTL.
Patch by Evan Martin < evan@chromium.org> on 2009-10-13
Reviewed by Dmitry Titov.
https://bugs.webkit.org/show_bug.cgi?id=30320
Test: fast/text/international/bidi-menulist.html
(The test is about something else, but it includes RTL selects.)
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintMenuList): flip the arrow position in RTL case.
- 18:15 Changeset [49539] by
-
https://bugs.webkit.org/show_bug.cgi?id=30318
ScriptExecutionContext is not anymore needed to create an EventListener - remove old code.
It's a followup to r48884. It removed the need to pass the ScritpExecutionContext
into EventListener constructor but did not remove the code pulling ScriptExecutionContext.
Reviewed by Alexey Proskuryakov.
WebCore:
Tests:
Test adds event listener to a DocumentType Node which is created without a document
and then dispatches the event after attaching a node to the tree. Event
should fire when node is attached to the tree.
* fast/events/add-event-without-document-expected.txt: Added.
* fast/events/add-event-without-document.html: Added.
All changes in files below are the same - remove the code that calls
EventTarget::scriptExecutionContext and checks it for NULL.
* bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
* bindings/js/JSDesktopNotificationsCustom.cpp:
(WebCore::JSNotification::addEventListener):
(WebCore::):
* bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
LayoutTests:
Test adds event listener to a DocumentType Node which is created without a document
and then dispatches the event after attaching a node to the tree. Event
should fire when node is attached to the tree.
* fast/events/add-event-without-document-expected.txt: Added.
* fast/events/add-event-without-document.html: Added.
- 18:04 Changeset [49538] by
-
Merge r48733.
- 18:04 Changeset [49537] by
-
Merge r46725.
- 18:04 Changeset [49536] by
-
Merge r46724.
- 18:04 Changeset [49535] by
-
Merge r46648.
- 18:04 Changeset [49534] by
-
Merge r46511.
- 18:04 Changeset [49533] by
-
Merge r46387.
- 17:41 Changeset [49532] by
-
Rubber-stamped by Jon Honeycutt.
Add trailing newline to the Windows Skipped List.
* platform/win/Skipped:
- 17:36 Changeset [49531] by
-
Add bug number to previous ChangeLog entry.
- 17:34 Changeset [49530] by
-
Rubber-stamped by Anders Carlsson.
Add plugins/private-browsing-mode.html to the Windows Skipped
list because the feature is not implemented on Windows.
* platform/win/Skipped:
- 17:33 Changeset [49529] by
-
Merge r48590.
- 17:24 Changeset [49528] by
-
Merge r46645.
- 16:58 Changeset [49527] by
-
2009-10-13 Simon Fraser < simon.fraser@apple.com>
Temporary debugging changes to figure out why the webgl tests are crashing on the build bot.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 16:39 Changeset [49526] by
-
Enable SHARED_WORKERS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=30289
Patch by Drew Wilson < atwilson@atwilson-macpro.local> on 2009-10-13
Reviewed by David Levin.
WebCore:
Cleaned up bitrot in SharedWorker V8 bindings.
* WebCore.gypi:
Removed default implementation of SharedWorkerRepository so Chromium can provide its own.
* bindings/v8/DerivedSourcesAllInOne.cpp:
Added V8SharedWorkerContext.cpp.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getTemplate):
Added case statements for SHAREDWORKER and SHAREDWORKERCONTEXT.
* bindings/v8/V8Index.cpp:
Now includes V8SharedWorkerContext.h to allow supporting SharedWorkers.
* bindings/v8/V8Index.h:
Added definition for SHAREDWORKERCONTEXT wrapper.
* bindings/v8/WorkerContextExecutionProxy.cpp:
Added includes for SharedWorker.h and SharedWorkerContext.h.
* bindings/v8/custom/V8CustomBinding.h:
Reorganized Worker field indexes to be clearer, and fixed mismatch in worker field index.
Also added field indexes for SharedWorkers.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
Added runtime enabler for the SharedWorker constructor.
* bindings/v8/custom/V8SharedWorkerCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
Cleaned up bitrot (various APIs have changed since this file was written).
* page/DOMWindow.idl:
Added EnabledAtRuntime flag to window.SharedWorker.
WebKit:
* chromium/features.gypi:
Turned on ENABLE_SHARED_WORKERS by default. This doesn't actually turn on
SharedWorkers yet, as Chromium overrides this flag in its feature_overrides.gypi.
- 16:36 Changeset [49525] by
-
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=30345
HTTP tests for credential handling fail on Tiger
We cannot prevent NSURLConnection from doing its credentil handling on Tiger anyway; so
let it do its work without intervention. Once again, we pass explicitly passed credentials
in URL, fixing regressions from Safari 3.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential):
- 16:19 Changeset [49524] by
-
2009-10-13 Roland Steiner < rolandsteiner@google.com>
Reviewed by Adam Barth.
Bug 28964 - [Chromium] ChromiumDataObject should have getter/setter interface
Reworked and added to the getter/setter interface in ChromiumDataObject:
- added contains...() methods to just query the state
- added containsValid...URL() methods for URL data members
- removed takeFileNames() as this was too type-dependent
- changed return type of fileNames() to Vector<String>
- added interface methods to allow appending to and iteration over file names
No new tests (no functional behavior changed).
- platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::containsMainURL): (WebCore::ChromiumDataObject::containsValidMainURL): (WebCore::ChromiumDataObject::containsMainURLTitle): (WebCore::ChromiumDataObject::containsTextPlain): (WebCore::ChromiumDataObject::containsTextHTML): (WebCore::ChromiumDataObject::containsHTMLBaseURL): (WebCore::ChromiumDataObject::containsValidHTMLBaseURL): (WebCore::ChromiumDataObject::containsContent): (WebCore::ChromiumDataObject::containsContentFileExtension): (WebCore::ChromiumDataObject::containsContentFileName): (WebCore::ChromiumDataObject::setContentFileName): (WebCore::ChromiumDataObject::containsFileNames): (WebCore::ChromiumDataObject::fileNames): (WebCore::ChromiumDataObject::clearFileNames): (WebCore::ChromiumDataObject::countFileNames): (WebCore::ChromiumDataObject::fileNameAt): (WebCore::ChromiumDataObject::setFileNames): (WebCore::ChromiumDataObject::appendToFileNames): (WebCore::ChromiumDataObject::popFileName):
- 16:05 Changeset [49523] by
-
Merge r49111.
- 16:03 Changeset [49522] by
-
Merge r47534.
- 15:57 Changeset [49521] by
-
Merge r49133.
- 15:53 Changeset [49520] by
-
2009-10-13 Simon Fraser < simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Visibility:visible inside a compositing layer doesn't make the element visible
https://bugs.webkit.org/show_bug.cgi?id=30339
When deciding if a layer had any renderable content, RenderLayerBacking::paintIntoLayer()
only consulted hasVisibleContent(), which does not take into a account child layers which
may be visible. We also have to consult hasVisibleDescendant() as well.
Test: compositing/compositing-visible-descendant.html
- rendering/RenderLayer.h: (WebCore::RenderLayer::hasVisibleDescendant):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
- 15:51 Changeset [49519] by
-
2009-10-13 Andras Becsi < becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
This is done in preparation of implementing missing features in DRT.
No functionality changes made yet.
- DumpRenderTree/qt/DumpRenderTree.cpp:
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/EventSenderQt.cpp: Added. (EventSender::EventSender): (EventSender::mouseDown): (EventSender::mouseUp): (EventSender::mouseMoveTo): (EventSender::leapForward): (EventSender::keyDown): (EventSender::contextClick): (EventSender::scheduleAsynchronousClick): (EventSender::frameUnderMouse):
- DumpRenderTree/qt/EventSenderQt.h: Added. (EventSender::clearKillRing):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added. (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::processWork): (LayoutTestController::maybeDump): (LayoutTestController::waitUntilDone): (LayoutTestController::notifyDone): (LayoutTestController::windowCount): (LayoutTestController::clearBackForwardList): (LayoutTestController::dumpEditingCallbacks): (LayoutTestController::dumpResourceLoadCallbacks): (LayoutTestController::queueBackNavigation): (LayoutTestController::queueForwardNavigation): (LayoutTestController::queueLoad): (LayoutTestController::queueReload): (LayoutTestController::queueScript): (LayoutTestController::provisionalLoad): (LayoutTestController::timerEvent): (LayoutTestController::encodeHostName): (LayoutTestController::decodeHostName): (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setFixedContentsSize): (LayoutTestController::setPrivateBrowsingEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::numberOfActiveAnimations): (LayoutTestController::disableImageLoading): (LayoutTestController::dispatchPendingLoadRequests): (LayoutTestController::setDatabaseQuota): (LayoutTestController::clearAllDatabases): (LayoutTestController::whiteListAccessFromOrigin): (LayoutTestController::waitForPolicyDelegate): (LayoutTestController::overridePreference):
- DumpRenderTree/qt/LayoutTestControllerQt.h: Added. (LayoutTestController::isLoading): (LayoutTestController::setLoading): (LayoutTestController::shouldDumpAsText): (LayoutTestController::shouldDumpBackForwardList): (LayoutTestController::shouldDumpChildrenAsText): (LayoutTestController::shouldDumpDatabaseCallbacks): (LayoutTestController::shouldDumpStatusCallbacks): (LayoutTestController::shouldWaitUntilDone): (LayoutTestController::canOpenWindows): (LayoutTestController::shouldDumpTitleChanges): (LayoutTestController::waitForPolicy): (LayoutTestController::dumpAsText): (LayoutTestController::dumpChildFramesAsText): (LayoutTestController::dumpDatabaseCallbacks): (LayoutTestController::dumpStatusCallbacks): (LayoutTestController::setCanOpenWindows): (LayoutTestController::dumpBackForwardList): (LayoutTestController::setCloseRemainingWindowsWhenComplete): (LayoutTestController::display): (LayoutTestController::dumpTitleChanges): (LayoutTestController::dumpSelectionRect):
- DumpRenderTree/qt/TextInputControllerQt.cpp: Added. (TextInputController::TextInputController): (TextInputController::doCommand):
- DumpRenderTree/qt/TextInputControllerQt.h: Added.
- DumpRenderTree/qt/WorkQueue.cpp:
- DumpRenderTree/qt/WorkQueue.h:
- DumpRenderTree/qt/WorkQueueItem.h:
- DumpRenderTree/qt/WorkQueueItemQt.cpp: Added. (findFrameNamed): (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke):
- DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
- DumpRenderTree/qt/jsobjects.h:
- 15:50 Changeset [49518] by
-
Merge r49433.
- 15:50 Changeset [49517] by
-
Merge r48492.
- 15:37 Changeset [49516] by
-
Merge r49026.
- 15:17 Changeset [49515] by
-
2009-10-13 Laszlo Gombos < laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
https://bugs.webkit.org/show_bug.cgi?id=30278
Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
from the make system into common code.
Enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH if NETSCAPE_PLUGIN_API
support is not enabled.
Remove notImplemented() from PluginPackageNone.cpp and
PluginDataNone.cpp make them just empty functions.
- GNUmakefile.am:
- WebCore.pro:
- plugins/PluginDataNone.cpp: (WebCore::PluginData::initPlugins): (WebCore::PluginData::refresh):
- plugins/PluginPackageNone.cpp: (WebCore::PluginPackage::determineQuirks): (WebCore::PluginPackage::fetchInfo): (WebCore::PluginPackage::load):
2009-10-13 Laszlo Gombos < laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
https://bugs.webkit.org/show_bug.cgi?id=30278
Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
from the make system into common code.
- wtf/Platform.h:
- 15:02 Changeset [49514] by
-
Not reviewed, adding myself to the list of reviewers.
* Scripts/modules/committers.py:
- 15:02 Changeset [49513] by
-
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=30150
< rdar://problem/7283540> REGRESSION: Crash when accessing clipboardData.types
Test: editing/pasteboard/crash-accessing-clipboardData-types.html
- platform/mac/ClipboardMac.mm: (WebCore::addHTMLClipboardTypesForCocoaType): The String class doesn't have operator bool, it's operator NSString* that is invoked instead, and it converts null strings to non-null @"".
- 14:59 Changeset [49512] by
-
< rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
Reviewed by Sam Weinig.
WebKit/mac:
Listen for WebPreferences notifications and update the _isPrivateBrowsingEnabled ivar
when the value changes. Also call -[WebBaseNetscapePluginView privateBrowsingModeDidChange] when the
value changes. In process this just calls NPP_SetValue, and OOP it sends a MIG message to the plug-in host.
* Plugins/Hosted/NetscapePluginHostManager.h:
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
* Plugins/Hosted/NetscapePluginInstanceProxy.h:
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::privateBrowsingModeDidChange):
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
(-[WebHostedNetscapePluginView privateBrowsingModeDidChange]):
* Plugins/Hosted/WebKitPluginHost.defs:
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView privateBrowsingModeDidChange]):
(-[WebBaseNetscapePluginView viewDidMoveToWindow]):
(-[WebBaseNetscapePluginView preferencesHaveChanged:]):
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView privateBrowsingModeDidChange]):
(-[WebNetscapePluginView getVariable:value:]):
WebKitTools:
Make the private browsing mode testable by the test plug-in.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginGetProperty):
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
(NPP_SetValue):
LayoutTests:
Add test.
* platform/mac-snowleopard/Skipped:
Remove now passing tests that was fixed by https://bugs.webkit.org/show_bug.cgi?id=30295.
* plugins/private-browsing-mode-expected.txt: Added.
* plugins/private-browsing-mode.html: Added.
- 14:54 Changeset [49511] by
-
Merge r47494.
- 14:44 Changeset [49510] by
-
window attributes (like localStorage) that are disabled at runtime are still visible
https://bugs.webkit.org/show_bug.cgi?id=30240
Patch by Drew Wilson < atwilson@atwilson-macpro.local> on 2009-10-13
Reviewed by Dimitri Glazkov.
Adding codegen/bindings to support runtime disabling of attributes.
No new tests (only supported by chrome currently)
* bindings/scripts/CodeGeneratorV8.pm:
Refactored the guts of GenerateBatchedAttributeData into a separate GenerateSingleBatchedAttribute with a passed-in indentation level to allow generating a single BatchedAttribute struct.
Added support for the EnabledAtRuntime extended attribute, which generates a call to the appropriate XXXXEnabled() API before adding the attribute to the instance.
* bindings/v8/V8Proxy.cpp:
(WebCore::batchConfigureAttributes):
Refactored attribute setting code into a common inline routine.
* bindings/v8/V8Proxy.h:
(WebCore::configureAttribute):
Inline function which configures a single attribute given a BatchedAttribute struct.
* bindings/v8/custom/V8CustomBinding.h:
Added (DECLARE_)ACCESSOR_RUNTIME_ENABLER to allow enabling attributes at runtime.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
Added code to enable window.Audio only if MediaPlayer.isAvailable() == true
* page/DOMWindow.idl:
Added [EnabledAtRuntime] extended attribute to the Audio attribute.
- 14:24 Changeset [49509] by
-
2009-10-13 Laszlo Gombos < laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
ARM compiler does not understand reinterpret_cast<void*>
https://bugs.webkit.org/show_bug.cgi?id=29034
Change reinterpret_cast<void*> to regular C style (void*) cast
for the ARM RVCT compiler.
- assembler/MacroAssemblerCodeRef.h: (JSC::FunctionPtr::FunctionPtr):
- jit/JITOpcodes.cpp: Cast to FunctionPtr first
instead of directly casting to reinterpret_cast
- jit/JITStubCall.h: Ditto + change the type of m_stub from void* to FunctionPtr. (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::call):
- jit/JITStubs.cpp: Ditto. (JSC::DEFINE_STUB_FUNCTION(EncodedJSValue, op_throw)):
- 13:53 Changeset [49508] by
-
2009-10-13 Michelangelo De Simone < micdesim@gmail.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=27457
Test case for static email validation on type=email input elements as
per HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#e-mail-state
- fast/forms/ValidityState-typeMismatch-email-expected.txt: Added.
- fast/forms/ValidityState-typeMismatch-email.html: Added.
- fast/forms/resources/ValidityState-typeMismatch-email.js: Added. ():
2009-10-13 Michelangelo De Simone < micdesim@gmail.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=27457
Added support for static validation on type=email input elements as per
HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#e-mail-state
Test: fast/forms/ValidityState-typeMismatch-email.html
- html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch): ValidityState.typeMismatch performs validation on type=email input elements now. (WebCore::ValidityState::isValidEmailAddress): simple validation method
- html/ValidityState.h:
- 13:27 Changeset [49507] by
-
2009-10-13 Dmitry Titov < dimich@chromium.org>
Reviewed by Adam Barth.
Event listeners installed on a window object returned from window.open() don't work
https://bugs.webkit.org/show_bug.cgi?id=28716
- http/tests/security/resources/has-window-events.html: Added.
- http/tests/security/window-events-clear-domain-expected.txt: Added.
- http/tests/security/window-events-clear-domain.html: Added.
- http/tests/security/window-events-clear-port-expected.txt: Added.
- http/tests/security/window-events-clear-port.html: Added.
- http/tests/security/window-events-pass-expected.txt: Added.
- http/tests/security/window-events-pass.html: Added.
2009-10-13 Dmitry Titov < dimich@chromium.org>
Reviewed by Adam Barth.
Event listeners installed on a window object returned from window.open() don't work
https://bugs.webkit.org/show_bug.cgi?id=28716
Tests: http/tests/security/window-events-clear-domain.html
http/tests/security/window-events-clear-port.html
http/tests/security/window-events-pass.html
- dom/Document.cpp: Split code of Document::clear() in a way to avoid removing all window event handlers when implicitOpen is called. It is called in 2 cases - on committing loaded content (no need to clean handlers) and on document.open() (needs to remove handlers).
(WebCore::Document::open): in addition to calling implicitOpen it also removes window
event handlers, to preserve the behavior of document.open().
(WebCore::Document::implicitOpen): includes the part of removed Document::clear() that
does not remove window event handlers.
- dom/Document.h: Removed clear().
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): add check to avoid removing window event handlers if we transition from temporary empty document to a loaded one.
(WebCore::FrameLoader::didOpenURL): Remove closeURL() which was called twice when loading.
(WebCore::FrameLoader::finishedLoadingDocument): add closeURL() to compensate for change above.
- 13:03 Changeset [49506] by
-
Fix a leak in the inspector by calling didRemoveNode with
an error code when it fails, instead of returning from the
Backend.
Reviewed by Pavel Feldman.
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::removeNode):
* inspector/front-end/ElementsTreeOutline.js:
- 12:01 Changeset [49505] by
-
Fixes < https://bugs.webkit.org/show_bug.cgi?id=30337>.
Web Inspector: Should be able to delete nodes from the Elements Tree.
Reviewed by Timothy Hatcher.
When the delete key is pressed and a element is selected in the tree,
the element should be deleted from the Elements Tree and the DOM.
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::removeNode):
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::didRemoveNode):
* inspector/InspectorFrontend.h:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._updateModifiedNodes):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.handleKeyEvent):
- 10:08 Changeset [49504] by
-
Fix REGRESSION(49479): Mouseover on resources graph doesn't show timings.
Reviewed by Timothy Hatcher.
Set pointer-events: none on the new overlay so mouseover events are passed
to the resources graph so we can show timings.
* inspector/front-end/inspector.css:
- 10:04 Changeset [49503] by
-
2009-10-13 Pavel Feldman < pfeldman@chromium.org>
No review, just adding self to the list of reviewers.
- Scripts/modules/committers.py:
- 07:27 Changeset [49502] by
-
2009-10-13 Girish Ramakrishnan < girish@forwardbias.in>
Reviewed by Simon Hausmann.
[Qt] Plugins : Remove all traces of winId. Use ownerWidget() instead.
This is a bug for two reasons:
- Everytime we use winId(), we end up creating a native widget. This causes an unnecessary copy of contents from the backing store to the native widget.
- Neither windowed nor windowless plugins require the winId of the QWebView or QGraphicsView.
Introduce ownerWidget() which returns a QWidget * without creating a native widget
(as opposed to QWidget::find(winId)).
- platform/qt/PlatformScreenQt.cpp: (WebCore::screenDepthPerComponent):
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::show):
- platform/qt/QWebPageClient.h:
- plugins/qt/PluginViewQt.cpp: (WebCore::setSharedXEventFields): (WebCore::PluginView::initXEvent): (WebCore::PluginView::getValue): (WebCore::PluginView::platformStart):
2009-10-13 Girish Ramakrishnan < girish@forwardbias.in>
Reviewed by Simon Hausmann.
[Qt] Plugins : Remove all traces of winId. Use ownerWidget() instead.
This is a bug for two reasons:
- Everytime we use winId(), we end up creating a native widget. This causes an unnecessary copy of contents from the backing store to the native widget.
- Neither windowed nor windowless plugins require the winId of the QWebView or QGraphicsView.
Introduce ownerWidget() which returns a QWidget * without creating a native widget
(as opposed to QWidget::find(winId)).
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::ownerWidget):
- Api/qwebview.cpp: (QWebViewPrivate::ownerWidget):
- 06:26 Changeset [49501] by
-
Unreviewed fix for typo in filename
- 05:14 Changeset [49500] by
-
2009-10-13 Pavel Feldman < pfeldman@chromium.org>
Layout test fix, reverting previous change.
Reverting r49499 as it caused several layout test failures.
- inspector/console-tests-expected.txt: Removed.
- inspector/console-tests.html: Removed.
- inspector/elements-panel-structure-expected.txt: Removed.
- inspector/elements-panel-structure.html: Removed.
- inspector/evaluate-in-frontend-expected.txt: Removed.
- inspector/evaluate-in-frontend.html: Removed.
- inspector/evaluate-in-frontend.js: Removed.
- 04:53 Changeset [49499] by
-
2009-10-13 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add initial layout tests for web inspector.
- inspector/console-tests-expected.txt: Added.
- inspector/console-tests.html: Added.
- inspector/elements-panel-structure-expected.txt: Added.
- inspector/elements-panel-structure.html: Added.
- inspector/evaluate-in-frontend-expected.txt: Added.
- inspector/evaluate-in-frontend.html: Added.
- inspector/evaluate-in-frontend.js: Added.
- 04:35 Changeset [49498] by
-
[Qt] Add some initial autotests for QWebPage's ErrorPageExtention
https://bugs.webkit.org/show_bug.cgi?id=30296
Patch by Antonio Gomes < tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.
* tests/qwebpage/tst_qwebpage.cpp:
(ErrorPage::ErrorPage):
(ErrorPage::supportsExtension):
(ErrorPage::extension):
(tst_QWebPage::errorPageExtension):
- 03:57 Changeset [49497] by
-
[Qt] better handle possible edge cases on qwebframe::requestedUrl use
https://bugs.webkit.org/show_bug.cgi?id=30216
Patch by Antonio Gomes < tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.
QWebFrame::requestedUrl can be called at any time during the load
process, including:
* An error handling (whereas an alternate error page for unsuccessful
load is being set);
* A ssl error exception call;
* Navigation notifications (titleChanged, urlChanged, progresses,
addHistoryEntry, etc);
* Among others.
This patch makes requestedUrl calls to fallback to FrameLoaderClient
m_loadError's failingURL when an error has occurred, unless it is
null/empty.
Also, m_loadError is now being reset at each the main frame starts a
load, in order to avoid previous load errors footprints.
* Api/qwebframe.cpp:
(QWebFrame::requestedUrl):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::postProgressStartedNotification):
- 01:28 Changeset [49496] by
-
2009-10-12 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Adam Roben.
Web Inspector: Use proper web view in inspector layout
tests for windows.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
- 01:26 Changeset [49495] by
-
2009-10-12 Alexander Pavlov < apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Alter profile link format to enable multiple profile types
https://bugs.webkit.org/show_bug.cgi?id=30253
The new profile URL includes the profile type along with the
profile title and uid.
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole):
- inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.linkifyStringAsFragment):
- 01:19 Changeset [49494] by
-
2009-10-12 Alexander Pavlov < apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Fix same-named profiles grouping in the Profiles panel.
The tree node re-parenting while adding a new group node was broken.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfile):
- 01:16 Changeset [49493] by
-
2009-10-12 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Enforce async interaction between inspector controller and frontend.
- inspector/front-end/inspector.js: (WebInspector.dispatch.delayDispatch): (WebInspector.dispatch):
10/12/09:
- 23:11 Changeset [49492] by
-
2009-10-12 Jakub Wieczorek < faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Missing default value for the default text encoding.
https://bugs.webkit.org/show_bug.cgi?id=30311
QtWebKit has provided a default, hardcoded value for default charset but since
the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
value has had no effect.
Added a regression test and unskipped fast/dom/Document/document-charset.html,
which is passing now.
- platform/qt/Skipped:
2009-10-12 Jakub Wieczorek < faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Missing default value for the default text encoding.
https://bugs.webkit.org/show_bug.cgi?id=30311
QtWebKit has provided a default, hardcoded value for default charset but since
the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
value has had no effect.
Added a regression test and unskipped fast/dom/Document/document-charset.html,
which is passing now.
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
- Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::defaultTextEncoding):
- 22:38 Changeset [49491] by
-
Change <a name> to id="" to fix styling problems
https://bugs.webkit.org/show_bug.cgi?id=30283
Reviewed by Eric Seidel.
This prevents the headings from being styled like links.
* coding/contributing.html:
- 21:59 Changeset [49490] by
-
2009-10-12 Xiaomei Ji < xji@chromium.org>
Reviewed by Sam Weinig.
Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30034
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
- fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
- fast/dom/elementFromPoint-relative-to-viewport.html:
2009-10-12 Xiaomei Ji < xji@chromium.org>
Reviewed by Sam Weinig.
Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30034
- dom/Document.cpp: (WebCore::Document::elementFromPoint): calculate the correct point relative to document when the page is zoomed and scrolled. (WebCore::Document::caretRangeFromPoint): calculate the correct point relative to document when the page is zoomed and scrolled.
- 21:22 Changeset [49489] by
-
2009-10-12 Fumitoshi Ukai < ukai@chromium.org>
Unreviewed. Fix 4 layout test failures by webkit r49488
WebKit r49488 enables window.WebSocket back.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- 18:44 Changeset [49488] by
-
WebCore: JavaScript bindings of WebSocket addEventListener/removeEventListener
https://bugs.webkit.org/show_bug.cgi?id=29841
Patch by Fumitoshi Ukai < ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).
Test: fast/websockets/websocket-event-target.html
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
* bindings/v8/custom/V8CustomBinding.h:
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* websockets/WebSocket.idl:
WebKitTools: Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
https://bugs.webkit.org/show_bug.cgi?id=29841
Patch by Fumitoshi Ukai < ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
LayoutTests: Add a test to verify WebSocket's EventTarget methods.
https://bugs.webkit.org/show_bug.cgi?id=29841
Patch by Fumitoshi Ukai < ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).
* fast/websockets/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/canvas/script-tests/TEMPLATE.html.
* fast/websockets/script-tests/websocket-event-target.js: Added.
(openListener):
(messageListener):
(closeListener):
* fast/websockets/websocket-event-target-expected.txt: Added.
* fast/websockets/websocket-event-target.html: Added.
- 17:47 Changeset [49487] by
-
Fix for https://bugs.webkit.org/show_bug.cgi?id=29078
< rdar://problem/7288221>
Reviewed by Darin Adler.
WebCore:
Add a mechanism to blacklist certain codecs. Initially, just blacklist UTF-7 as HTML5 encourages.
* platform/text/TextEncodingRegistry.cpp:
(WebCore::pruneBlacklistedCodecs):
(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):
LayoutTests:
Test the lack of UTF-7 support. Remove old UTF-7 tests.
* fast/encoding/char-decoding-expected.txt:
* fast/encoding/char-decoding.html:
* http/tests/misc/submit-get-in-utf7-expected.txt: Removed.
* http/tests/misc/submit-get-in-utf7.html: Removed.
* http/tests/misc/submit-post-in-utf7-expected.txt: Removed.
* http/tests/misc/submit-post-in-utf7.html: Removed.
* http/tests/misc/url-in-utf7-expected.txt: Removed.
* http/tests/misc/url-in-utf7.html: Removed.
* http/tests/security/xssAuditor/http-equiv-utf-7-encoded-expected.txt: Removed.
* http/tests/security/xssAuditor/http-equiv-utf-7-encoded.html: Removed.
* http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Removed.
* http/tests/security/xssAuditor/script-tag-utf-7-encoded-expected.txt: Removed.
* http/tests/security/xssAuditor/script-tag-utf-7-encoded.html: Removed.
* http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Removed.
* http/tests/security/xssAuditor/script-tag-utf-7.html: Removed.
- 17:37 Changeset [49486] by
-
Add support for the beforeload event to frames. Complete support of the beforeload event by making sure
its wrapper gets properly constructed (so that the URL field of the event can be accessed). Add support
for the Objective-C wrapper class as well.
Reviewed by Darin Adler.
Added fast/dom/beforeload/frame-before-load.html
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/objc/DOMEvents.mm:
(kitClass):
* dom/BeforeLoadEvent.h:
(WebCore::BeforeLoadEvent::isBeforeLoadEvent):
* dom/Event.cpp:
(WebCore::Event::isBeforeLoadEvent):
* dom/Event.h:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseMappedAttribute):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithDocumentLoader):
- 17:27 Changeset [49485] by
-
2009-10-12 Yaar Schnitman < yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium Port - Windows
https://bugs.webkit.org/show_bug.cgi?id=29969
- chromium/DEPS: Added gtest dep required by windows and incremented some of the deps revisions.
2009-10-12 Yaar Schnitman < yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium Port - Windows
https://bugs.webkit.org/show_bug.cgi?id=29969
- Scripts/pdevenv: removed msvc's /useenv for chromium builds
- Scripts/webkitdirs.pm:
- 17:15 BuildingQtOnLinux edited by
- added error relating to phonon (diff)
- 16:49 Changeset [49484] by
-
WebCore: Fix < rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()
Reviewed by Simon Fraser.
Test: fast/dynamic/position-absolute-to-fixed-crash.html
The crash was caused by stale positioned objects lists following an
object transitioning from being absolutely position to being fixed
positioned.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange): In case of a transition between
absolute and fixed position, mark the parent as having a child needing
layout, so that this object will get inserted into its new container's
positioned objects list.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange): Changed a condition to cover
this transition, so that this object gets removed from its current
container's positioned objects list.
LayoutTests: Test for < rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()
Reviewed by Simon Fraser.
* fast/dynamic/position-absolute-to-fixed-crash-expected.txt: Added.
* fast/dynamic/position-absolute-to-fixed-crash.html: Added.
- 16:20 Changeset [49483] by
-
2009-10-12 Kenneth Rohde Christiansen < kenneth@webkit.org>
Reviewed by Simon Hausmann.
Add a palette() method that is needed by our RenderTheme.
- platform/qt/QWebPageClient.h:
2009-10-12 Kenneth Rohde Christiansen < kenneth@webkit.org>
Reviewed by Simon Hausmann.
Implement the new palette() methods on the page clients
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::palette):
- Api/qwebview.cpp: (QWebViewPrivate::palette):
- 16:16 Changeset [49482] by
-
Fix release builds.
- 16:05 Changeset [49481] by
-
2009-10-12 Dirk Schulze < krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Three old test results give back the absolute position instead of the realtive position.
The new test will check the correct behavior of gradients in userSpaceOnUse mode and
values in percentage.
- platform/mac/svg/custom/gradient-attr-update-expected.txt:
- platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
- platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum: Added.
- platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Added.
- platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt: Added.
- platform/mac/svg/custom/text-gradient-no-content-expected.txt:
- svg/custom/gradient-userSpaceOnUse-with-percentage.svg: Added.
2009-10-12 Dirk Schulze < krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Gradients can't handle percentage values in userSpaceOnUse mode
https://bugs.webkit.org/show_bug.cgi?id=30286
Fixed *GradientAttributes to take SVGLength instead of double. This casues
the problem, that we can't calculate the correct size of a gradient on
userSpaceOnUse mode with percentage values.
Test: svg/custom/gradient-userSpaceOnUse-with-percentage.svg
- svg/LinearGradientAttributes.h: (WebCore::LinearGradientAttributes::LinearGradientAttributes): (WebCore::LinearGradientAttributes::x1): (WebCore::LinearGradientAttributes::y1): (WebCore::LinearGradientAttributes::x2): (WebCore::LinearGradientAttributes::y2): (WebCore::LinearGradientAttributes::setX1): (WebCore::LinearGradientAttributes::setY1): (WebCore::LinearGradientAttributes::setX2): (WebCore::LinearGradientAttributes::setY2):
- svg/RadialGradientAttributes.h: (WebCore::RadialGradientAttributes::RadialGradientAttributes): (WebCore::RadialGradientAttributes::cx): (WebCore::RadialGradientAttributes::cy): (WebCore::RadialGradientAttributes::r): (WebCore::RadialGradientAttributes::fx): (WebCore::RadialGradientAttributes::fy): (WebCore::RadialGradientAttributes::setCx): (WebCore::RadialGradientAttributes::setCy): (WebCore::RadialGradientAttributes::setR): (WebCore::RadialGradientAttributes::setFx): (WebCore::RadialGradientAttributes::setFy):
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient): (WebCore::SVGLinearGradientElement::collectGradientProperties):
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient): (WebCore::SVGRadialGradientElement::collectGradientProperties):
- 15:39 Changeset [49480] by
-
Merge r49218.
- 15:33 Changeset [49479] by
-
Fixes < http://webkit.org/b/30315>.
Web Inspector: DOM Content and Load lines in Resources are unclear what they mean.
Reviewed by Timothy Hatcher.
Add tooltip text to the Load event and DOM Content event lines through
a new layer that allows these lines to be on top of the view.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
(WebInspector.ResourcesPanel.prototype._updateDividersLabelBarPosition):
* inspector/front-end/inspector.css:
- 15:32 Changeset [49478] by
-
Merge r48946.
- 15:32 Changeset [49477] by
-
Merge r47883.
- 15:25 Changeset [49476] by
-
jsc scripts cleanup and Qt/GTK fix
https://bugs.webkit.org/show_bug.cgi?id=30288
Patch by Csaba Osztrogonac < ossy@webkit.org> on 2009-10-12
Reviewed by Darin Adler.
Duplicated jscPath() moved to webkitdirs.pm.
New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
Configuration added (release/debug) to path for Qt-port on Windows.
* Scripts/run-javascriptcore-tests:
* Scripts/run-jsc:
* Scripts/run-sunspider:
* Scripts/sunspider-compare-results:
* Scripts/webkitdirs.pm:
- 15:25 Changeset [49475] by
-
Merge r48787.
- 15:25 Changeset [49474] by
-
Merge r48775.
- 14:30 Changeset [49473] by
-
2009-10-12 Dimitri Glazkov < dglazkov@chromium.org>
No review, rolling out r49429, because it broke layout tests.
http://trac.webkit.org/changeset/49429
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
- 14:15 Changeset [49472] by
-
2009-10-12 Dirk Schulze < krit@webkit.org>
Reviewed by Eric Seidel.
SVG - crash on feMerge when input not available
https://bugs.webkit.org/show_bug.cgi?id=30297
Make a early return in SVGFEMergeElement if the needed
filter effect doesn't exist.
Test: svg/filters/feMerge-wrong-input.svg
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
2009-10-12 Dirk Schulze < krit@webkit.org>
Reviewed by Eirc Seidel.
feMergeNod has a reference to an effect that doesn't exist. This test will
check if SVGFEMergeElement handles this correctly and stops the filter process.
- svg/filters/feMerge-wrong-input-expected.checksum: Added.
- svg/filters/feMerge-wrong-input-expected.png: Added.
- svg/filters/feMerge-wrong-input-expected.txt: Added.
- svg/filters/feMerge-wrong-input.svg: Added.
- 14:07 Changeset [49471] by
-
Merge r48572.
- 14:07 Changeset [49470] by
-
Merge r47801.
- 14:07 Changeset [49469] by
-
Merge r47771.
- 14:00 Changeset [49468] by
-
Merge r48848.
- 14:00 Changeset [49467] by
-
Merge r48547.
- 14:00 Changeset [49466] by
-
Merge r48546.
- 14:00 Changeset [49465] by
-
Merge r47900.
- 14:00 Changeset [49464] by
-
Merge r48743.
- 13:49 Changeset [49463] by
-
Merge r46136.
- 13:49 Changeset [49462] by
-
Merge r47509.
- 13:42 Changeset [49461] by
-
2009-10-12 Csaba Osztrogonac < ossy@webkit.org>
Unreviewed. Added myself to committers.py.
- Scripts/modules/committers.py:
- 13:42 Changeset [49460] by
-
Merge r48647.
- 13:42 Changeset [49459] by
-
Merge r46521.
- 13:38 Changeset [49458] by
-
Merge r47551.
- 13:38 Changeset [49457] by
-
Merge r47300.
- 13:34 Changeset [49456] by
-
Merge r48957.
- 13:34 Changeset [49455] by
-
Merge r48956.
- 13:34 Changeset [49454] by
-
Merge r48953.
- 13:33 Changeset [49453] by
-
Merge r46548.
- 13:19 Changeset [49452] by
-
Merge r48369.
- 13:19 Changeset [49451] by
-
Merge r47657.
- 13:19 Changeset [49450] by
-
Merge r46058.
- 13:19 Changeset [49449] by
-
Merge r45945.
- 13:19 Changeset [49448] by
-
Merge r48725.
- 13:03 WebKit Team edited by
- (diff)
- 13:00 Changeset [49447] by
-
Added automatic flush before compositing
https://bugs.webkit.org/show_bug.cgi?id=30236
This causes image to always render correctly. In writing a testcase
I needed to implement readPixels. This exposed a bug in reading back
values from a CanvasArray subclass, so I fixed that as well. Now when
you wrap a CanvasArray in a JSValue it actually wraps the specific
subclass. To do this I need to add virtual methods to each CanvasArray
subclass to determine the type and a custom toJS method for CanvasArray
to create the proper wrapper.
Test: fast/canvas/webgl/triangle.html
- 12:38 Changeset [49446] by
-
2009-10-12 Jan Michael Alonzo < jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Update Fedora httpd.conf settings to closely match the generic httpd.conf
https://bugs.webkit.org/show_bug.cgi?id=30302
Closely match the default httpd.conf for layout tests.
- http/conf/fedora-httpd.conf:
- 11:09 Changeset [49445] by
-
2009-10-12 Sebastian Dröge < sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Fix 0 sentinel for g_object_set() function call.
- platform/graphics/gtk/DataSourceGStreamer.cpp: (webkit_data_src_uri_set_uri): 0 is passed as 32 bit value on x86-64 in vararg functions, but g_object_set() expects a 64 bit 0. This will cause crashes.
- 11:05 Changeset [49444] by
-
2009-10-12 Gustavo Noronha Silva < gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Remove unnecessary self-include.
- webkit/webkitsecurityorigin.h:
- 09:29 Changeset [49443] by
-
2009-10-12 Simon Fraser < simon.fraser@apple.com>
Reviewed by Darin Adler.
Video keeps playing after going fullscreen, then closing window
https://bugs.webkit.org/show_bug.cgi?id=30164
Clear the QTMovie on the QTMovieView when coming out of fullscreen,
to fix issue where the underlying movie keeps playing.
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidExitFullscreen]):
- 08:52 Changeset [49442] by
-
2009-10-12 Andras Becsi < becsi.andras@stud.u-szeged.hu>
Reviewed by Tor Arne Vestbø.
[Qt] Add expected files for new passing fast tests.
- platform/qt/fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
- platform/qt/fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.
- platform/qt/fast/css/text-rendering-expected.txt: Added.
- platform/qt/fast/forms/basic-buttons-expected.txt: Added.
- platform/qt/fast/forms/basic-inputs-expected.txt: Added.
- platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt: Added.
- platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt: Added.
- platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Added.
- 08:26 Changeset [49441] by
-
2009-10-12 Cameron McCormack < cam@mcc.id.au>
Reviewed by Eric Seidel.
Drop in="" from <feFlood>
https://bugs.webkit.org/show_bug.cgi?id=29001
This makes <feFlood in="bogus"> have an effect, too.
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute
Test: svg/dom/feFlood-no-in1.html
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::build):
- svg/SVGFEFloodElement.h:
- svg/SVGFEFloodElement.idl:
- svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::FEFlood): (WebCore::FEFlood::create):
- svg/graphics/filters/SVGFEFlood.h:
LayoutTest:
Drop in="" from <feFlood>
https://bugs.webkit.org/show_bug.cgi?id=29001
This makes <feFlood in="bogus"> have an effect, too.
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute
- svg/dom/feFlood-no-in1-expected.txt: Added.
- svg/dom/feFlood-no-in1.html: Added.
- svg/dom/script-tests/feFlood-no-in1.js: Added.
- 08:05 Changeset [49440] by
-
2009-10-12 Jedrzej Nowacki < jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
QWebPage's createViewlessPlugin autotest crash fix.
It is possible that plugins that are QWidgets or QGraphicsWidgets
are created before a view has been assigned to a QWebPage. The
plug-ins won't be fully functional, as by design, they should
visualise something, but they won't crash and will stay in memory.
An autotest that covers this use-case, is included.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
- tests/qwebpage/tst_qwebpage.cpp: (PluginTrackedPageWidget::PluginTrackedPageWidget): (PluginTrackedPageGraphicsWidget::PluginTrackedPageGraphicsWidget): (PluginTrackedPageGraphicsWidget::createPlugin): (tst_QWebPage::destroyPlugin): (tst_QWebPage::createViewlessPlugin):
- 07:34 Changeset [49439] by
-
2009-10-12 Sebastian Dröge < sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Scale video to completely fill the target surface while
keeping the aspect ratio. This fixes displaying of the
YouTube HTML5 sample website.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Scale video to completely fill the target surface, keep the aspect ratio and center it.
- 07:18 Changeset [49438] by
-
2009-10-12 Sebastian Dröge < sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Fixes double memcpy of all rendered video frames.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateRepaintCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::duration):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_timeout_func): (webkit_video_sink_dispose): (unlock_buffer_mutex): (webkit_video_sink_unlock): (marshal_VOIDMINIOBJECT): (webkit_video_sink_class_init): (webkit_video_sink_new):
- platform/graphics/gtk/VideoSinkGStreamer.h: Directly pass the buffers up to the MediaPlayerPrivate::paint() method instead of rendering them first to an intermediate cairo surface. This should increase performance and peak memory usage.
- 07:15 Changeset [49437] by
-
2009-10-12 Christian Dywan < christian@twotoasts.de>
Reviewed by Gustavo Noronha.
[GTK] Crash when right-clicking misspelled word
https://bugs.webkit.org/show_bug.cgi?id=29772
Make sure the dictionary exist before adding it to the list of
dictionaries.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::checkSpellingOfString):
- webkit/webkitwebsettings.cpp: (webkit_web_settings_set_property):
- 04:56 Changeset [49436] by
-
2009-10-12 Jan Michael Alonzo < jmalonzo@webkit.org>
Rubberstamped by Eric Seidel.
[Gtk] Fix icu CFLAG for Darwin
https://bugs.webkit.org/show_bug.cgi?id=29517
Don't escape the srcdir variable. Also use $host instead of the
os_foo variables.
- autotools/webkit.m4:
- 04:55 Changeset [49435] by
-
2009-10-12 Jan Michael Alonzo < jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[Gtk] Use the SQLite3 headers from WebKitLibraries if sqlite3 is undetected
https://bugs.webkit.org/show_bug.cgi?id=29518
- configure.ac:
- 03:14 QtBackLog edited by
- Add new items and pointers to them (diff)
