Timeline


and

10/22/09:

23:22 Changeset [49969] by mrowe@apple.com
  • 16 edits in trunk

Update configurations to support the mysterious future.

Rubber-stamped by Brady Eidson.

22:27 Changeset [49968] by barraclough@apple.com
  • 2 edits in trunk/WebKitTools

Build fix following bug #30696.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::evaluateScriptInIsolatedWorld):

22:16 Changeset [49967] by mrowe@apple.com
  • 23 edits
    2 deletes in trunk/WebKitSite

Update to WordPress 2.8.5.

  • blog:
22:06 Changeset [49966] by barraclough@apple.com
  • 3 edits in trunk/WebKit/qt

Build fix following bug #30696.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (speculative build fix - qt is currently already broken!)

  • Api/qwebelement.cpp:

(setupScriptContext):

  • Api/qwebframe.cpp:

(QWebFrame::evaluateJavaScript):

21:57 Changeset [49965] by barraclough@apple.com
  • 2 edits in trunk/WebKit/mac

Build fix following bug #30696.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
(WebKit::NetscapePluginInstanceProxy::evaluate):
(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):
(WebKit::NetscapePluginInstanceProxy::getProperty):
(WebKit::NetscapePluginInstanceProxy::setProperty):
(WebKit::NetscapePluginInstanceProxy::removeProperty):
(WebKit::NetscapePluginInstanceProxy::hasProperty):
(WebKit::NetscapePluginInstanceProxy::hasMethod):
(WebKit::NetscapePluginInstanceProxy::enumerate):

21:48 Changeset [49964] by barraclough@apple.com
  • 3 edits in trunk/WebKit/gtk

Build fix following bug #30696.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::windowObjectCleared):

  • webkit/webkitwebframe.cpp:

(webkit_web_frame_get_global_context):

21:33 Changeset [49963] by barraclough@apple.com
  • 101 edits in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=30696
Add support for IsolatedWorlds to JSC bindings.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-16
Reviewed by Sam Weinig & Geoff Garen.

An IsolatedWorld is basically a parallel, separate copy of the window shells and DOM wrapper objects for
a given document. To support isolation this patch:

  • Adds support to the ScriptController to track multiple window shells, one per world.
  • Adds support to Document to support multiple separate wrapper-maps, one per world.
  • Replaces the single global DOM wrapper map (on the WebCoreJSClientData) with separate maps, stored on the (new) IsolatedWorld objects.

In addition to supporting separate copies of these objects, two other features are supported:

  • It is necessary to track the current world on entry into JSC, so that within callbacks out to WebCore we can determine which world (and as such, set of DOM bindings) we should be operating on.
  • EventListeners & Callbacks are run in the world they were registered in. This requires the handler to retain a reference to the world.

No new tests. (Enabled existing isolated world layout tests.)

  • WebCore.base.exp:
  • bindings/js/JSAbstractWorkerCustom.cpp:

(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCallbackData.h:

(WebCore::JSCallbackData::JSCallbackData):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSDOMApplicationCacheCustom.cpp:

(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::removeWrappers):
(WebCore::DOMObjectWrapperMap::get):
(WebCore::DOMObjectWrapperMap::set):
(WebCore::DOMObjectWrapperMap::remove):
(WebCore::DOMObjectWrapperMap::take):
(WebCore::IsolatedWorld::IsolatedWorld):
(WebCore::IsolatedWorld::~IsolatedWorld):
(WebCore::EnterIsolatedWorld::EnterIsolatedWorld):
(WebCore::EnterIsolatedWorld::~EnterIsolatedWorld):
(WebCore::JSGlobalDataWorldIterator::JSGlobalDataWorldIterator):
(WebCore::JSGlobalDataWorldIterator::operator bool):
(WebCore::JSGlobalDataWorldIterator::operator*):
(WebCore::JSGlobalDataWorldIterator::operator->):
(WebCore::JSGlobalDataWorldIterator::operator++):
(WebCore::getCurrentWorld):
(WebCore::getNormalWorld):
(WebCore::commonNormalWorld):
(WebCore::commonCurrentWorld):
(WebCore::DOMObjectHashTableMap::mapFor):
(WebCore::DOMObjectWrapperMap::mapFor):
(WebCore::forgetDOMObject):
(WebCore::getCachedDOMNodeWrapper):
(WebCore::forgetDOMNode):
(WebCore::cacheDOMNodeWrapper):
(WebCore::forgetAllDOMNodesForDocument):
(WebCore::forgetWorldOfDOMNodesForDocument):
(WebCore::isObservableThroughDOM):
(WebCore::markDOMNodesForDocument):
(WebCore::markActiveObjectsForContext):
(WebCore::takeWrappers):
(WebCore::updateDOMNodeDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::allowsAccessFromFrame):
(WebCore::printErrorMessageForFrame):
(WebCore::JSC_DebuggerCallFrame_evaluateInWorld):
(WebCore::JSC_callInWorld):
(WebCore::JSC_constructInWorld):
(WebCore::JSC_evaluateInWorld):

  • bindings/js/JSDOMBinding.h:

(WebCore::IsolatedWorld::rememberDocument):
(WebCore::IsolatedWorld::forgetDocument):
(WebCore::IsolatedWorld::rememberScriptController):
(WebCore::IsolatedWorld::forgetScriptController):
(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
(WebCore::DOMObjectHashTableMap::get):
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::currentWorld):
(WebCore::WebCoreJSClientData::normalWorld):
(WebCore::WebCoreJSClientData::rememberWorld):
(WebCore::WebCoreJSClientData::forgetWorld):
(WebCore::debuggerWorld):
(WebCore::pluginWorld):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
(WebCore::toJSDOMGlobalObject):

  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::printErrorMessage):
(WebCore::JSDOMWindowBase::commonJSGlobalData):
(WebCore::toJS):
(WebCore::toJSDOMWindow):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::createWindow):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::showModalDialog):
(WebCore::JSDOMWindow::setTimeout):
(WebCore::JSDOMWindow::setInterval):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::toJS):
(WebCore::toJSDOMWindowShell):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSDesktopNotificationsCustom.cpp:

(WebCore::JSNotification::addEventListener):
(WebCore::):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::create):

  • bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):

  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::open):

  • bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::nameGetter):

  • bindings/js/JSInspectorBackendCustom.cpp:

(WebCore::JSInspectorBackend::databaseForId):
(WebCore::JSInspectorBackend::inspectedWindow):
(WebCore::JSInspectorBackend::nodeForId):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::parseCode):

  • bindings/js/JSLazyEventListener.h:

(WebCore::JSLazyEventListener::create):

  • bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannel::markChildren):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::markChildren):
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
(WebCore::JSNode::markChildren):

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode):

  • bindings/js/JSQuarantinedObjectWrapper.cpp:

(WebCore::JSQuarantinedObjectWrapper::construct):
(WebCore::JSQuarantinedObjectWrapper::call):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):

  • bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorker::markChildren):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):
(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::setInterval):

  • bindings/js/JSXMLHttpRequestConstructor.cpp:

(WebCore::constructXMLHttpRequest):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):

  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:

(WebCore::JSXMLHttpRequestUpload::markChildren):
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::executeFunctionInContext):
(WebCore::ScheduledAction::execute):

  • bindings/js/ScheduledAction.h:

(WebCore::ScheduledAction::ScheduledAction):

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::processingUserGestureEvent):
(WebCore::ScriptController::attachDebugger):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::bindingRootObject):
(WebCore::ScriptController::createRootObject):
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::jsObjectForPluginElement):

  • bindings/js/ScriptController.h:

(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::globalObject):
(WebCore::ScriptController::forgetWorld):

  • bindings/js/ScriptControllerMac.mm:

(WebCore::ScriptController::windowScriptObject):

  • bindings/js/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener):

  • bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):

  • bindings/js/ScriptObjectQuarantine.cpp:

(WebCore::getQuarantinedScriptObject):

  • bindings/js/ScriptState.cpp:

(WebCore::scriptStateFromNode):
(WebCore::scriptStateFromPage):

  • bindings/js/ScriptState.h:
  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::evaluate):

  • bindings/objc/DOMInternal.mm:

(-[WebScriptObject _initializeScriptDOMNodeImp]):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp:

(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_Construct):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::call):
(JavaJSObject::eval):

  • dom/Document.cpp:

(WebCore::Document::createWrapperCache):

  • dom/Document.h:

(WebCore::Document::wrapperCacheMap):
(WebCore::Document::getWrapperCache):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):

  • inspector/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::evaluate):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchWindowObjectAvailable):

  • platform/network/mac/AuthenticationMac.mm:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::dropProtection):

  • xml/XMLHttpRequest.h:

(WebCore::XMLHttpRequest::create):

WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=30696
Update to incorporate support for IsolatedWorlds in JSC bindings.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-16
Reviewed by Sam Weinig & Geoff Garen.

  • WebView/WebFrame.mm:

(-[WebFrame _attachScriptDebugger]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame globalContext]):

  • WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame evaluateWebScript:]):

  • WebView/WebView.mm:

(-[WebView aeDescByEvaluatingJavaScriptFromString:]):

WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=30696
Update to incorporate support for IsolatedWorlds in JSC bindings.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by Sam Weinig & Geoff Garen.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp:

(WebFrame::globalContext):
(WebFrame::windowObjectCleared):
(WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld):

  • WebFrame.h:

WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=30696
Enable isolated-worlds tests on mac.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by Sam Weinig & Geoff Garen.

Add private interface for DRT to invoke execution in a given world.

  • DumpRenderTree/LayoutTestController.cpp:

(evaluateScriptInIsolatedWorldCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::evaluateScriptInIsolatedWorld):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::evaluateScriptInIsolatedWorld):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=30696
Enable isolated-worlds tests on mac.

  • Update the results to switch from windows to unix line-endings.
  • Update all-window-prototypes.html to allow for properties on the global object with null prototypes (just skip over them).

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-19
Reviewed by Sam Weinig & Geoff Garen.

  • http/tests/security/isolatedWorld/all-window-properties-expected.txt:
  • http/tests/security/isolatedWorld/all-window-prototypes-expected.txt:
  • http/tests/security/isolatedWorld/all-window-prototypes.html:
  • http/tests/security/isolatedWorld/body-properties-expected.txt:
  • http/tests/security/isolatedWorld/body-prototype-expected.txt:
  • http/tests/security/isolatedWorld/document-properties-expected.txt:
  • http/tests/security/isolatedWorld/document-prototype-expected.txt:
  • http/tests/security/isolatedWorld/global-variables-expected.txt:
  • http/tests/security/isolatedWorld/image-properties-expected.txt:
  • http/tests/security/isolatedWorld/image-prototype-expected.txt:
  • http/tests/security/isolatedWorld/location-properties-expected.txt:
  • http/tests/security/isolatedWorld/location-prototype-expected.txt:
  • http/tests/security/isolatedWorld/number-prototype-expected.txt:
  • http/tests/security/isolatedWorld/object-prototype-expected.txt:
  • http/tests/security/isolatedWorld/storage-properties-expected.txt:
  • http/tests/security/isolatedWorld/storage-prototype-expected.txt:
  • http/tests/security/isolatedWorld/string-prototype-expected.txt:
  • http/tests/security/isolatedWorld/window-properties-expected.txt:
  • platform/mac/Skipped:
21:12 Changeset [49962] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2009-10-22 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: EventListenersSidebarPane TODO No Longer Needed
https://bugs.webkit.org/show_bug.cgi?id=30705

  • inspector/front-end/EventListenersSidebarPane.js:
17:22 Changeset [49961] by bweinstein@apple.com
  • 3 edits in trunk/LayoutTests

Updating expected results - unreviewed.

Updated expected computed style results on Windows after r49959.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
17:00 Changeset [49960] by ap@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=30506
<rdar://problem/7319845> Resources that the server sent as 304 not modified are not shown
in the inspectors resource pane

I don't know how to make a test for this.

The issue here was that preloaded resources weren't added to DocLoader document resource set,
but Web Inspector asked DocLoader to fetch data from CachedResource. Even when (if) document
parser eventually requested the same resource for real and it got added to resource set, it
was too late - the Inspector wasn't updated.

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
  • inspector/InspectorResource.h: Fix the issue by trying to fetch corresponding CachedResource harder - also look in global cache. This seems safe, and easier than updating the Inspector on transitions between resource states (revalidate vs. revalidate done and preload vs. non-preload).
16:34 Changeset [49959] by bdakin@apple.com
  • 17 edits
    36 adds in trunk

WebCore: Fix for <rdar://problem/6942706> ER: Add a CSS property that allows
shadows to work for SVG content
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=30479

Reviewed by Dan Bernstein.

This patch adds a new SVG-specific CSS property called -webkit-
shadow that has the same syntax as -webkit-box-shadow

Add CSSPropertyWebkitShadow to the list of SVG CSS properties, and
make valueForShadow a member function rather than a static function

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSComputedStyleDeclaration.h:

Call valueForShadow for CSSPropertyWebkitShadow

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

Do standard CSS stuff for CSSPropertyWebkitShadow

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

Set the appropriate shadow on the paint context if we have one.
This seems to be all we have to do to have an SVG-shaped shadow.

  • rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent):

Add shadow to SVGRenderStyle. I added a new macro that I don't like
just because that's the way things are done here right now.

  • rendering/style/SVGRenderStyle.cpp:

(WebCore::SVGRenderStyle::SVGRenderStyle):
(WebCore::SVGRenderStyle::operator==):

  • rendering/style/SVGRenderStyle.h:
  • rendering/style/SVGRenderStyleDefs.cpp:

(StyleShadowSVGData::StyleShadowSVGData):
(StyleShadowSVGData::operator==):

  • rendering/style/SVGRenderStyleDefs.h:

(WebCore::StyleShadowSVGData::create):
(WebCore::StyleShadowSVGData::copy):
(WebCore::StyleShadowSVGData::operator!=):

LayoutTests: Tests for <rdar://problem/6942706> ER: Add a CSS property that
allows shadows to work for SVG content
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=30479

Reviewed by Dan Bernstein.

New results that include -webkit-shadow:

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

New tests and their results.

  • platform/mac/svg/css/arrow-with-shadow-expected.checksum: Added.
  • platform/mac/svg/css/arrow-with-shadow-expected.png: Added.
  • platform/mac/svg/css/arrow-with-shadow-expected.txt: Added.
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.checksum: Added.
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.png: Added.
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
  • platform/mac/svg/css/clippath-with-shadow-expected.checksum: Added.
  • platform/mac/svg/css/clippath-with-shadow-expected.png: Added.
  • platform/mac/svg/css/clippath-with-shadow-expected.txt: Added.
  • platform/mac/svg/css/group-with-shadow-expected.checksum: Added.
  • platform/mac/svg/css/group-with-shadow-expected.png: Added.
  • platform/mac/svg/css/group-with-shadow-expected.txt: Added.
  • platform/mac/svg/css/mask-with-shadow-expected.checksum: Added.
  • platform/mac/svg/css/mask-with-shadow-expected.png: Added.
  • platform/mac/svg/css/mask-with-shadow-expected.txt: Added.
  • platform/mac/svg/css/path-with-shadow-expected.checksum: Added.
  • platform/mac/svg/css/path-with-shadow-expected.png: Added.
  • platform/mac/svg/css/path-with-shadow-expected.txt: Added.
  • platform/mac/svg/css/stars-with-shadow-expected.checksum: Added.
  • platform/mac/svg/css/stars-with-shadow-expected.png: Added.
  • platform/mac/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/mac/svg/filters/shadow-on-filter-expected.checksum: Added.
  • platform/mac/svg/filters/shadow-on-filter-expected.png: Added.
  • platform/mac/svg/filters/shadow-on-filter-expected.txt: Added.
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.checksum: Added.
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt: Added.
  • svg/css/arrow-with-shadow.svg: Added.
  • svg/css/circle-in-mask-with-shadow.svg: Added.
  • svg/css/clippath-with-shadow.svg: Added.
  • svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/group-with-shadow.svg: Added.
  • svg/css/mask-with-shadow.svg: Added.
  • svg/css/path-with-shadow.svg: Added.
  • svg/css/stars-with-shadow.html: Added.
  • svg/filters/shadow-on-filter.svg: Added.
  • svg/filters/shadow-on-rect-with-filter.svg: Added.
16:07 Changeset [49958] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-10-22 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25530
[Gtk] Implement LABEL_FOR/LABELLED_BY relationship pair for labels

Implements atk_object_ref_relation_set and LABEL_FOR/LABELLED_BY.
Also causes the accessible name for labeled controls to be based on
the label as expected, rather than based on the contents.

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityRenderObject.cpp: (correspondingLabelForControlElement):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkRelationSetFromCoreObject): (webkit_accessible_ref_relation_set): (webkit_accessible_class_init): (webkit_accessible_get_name):
14:32 Changeset [49957] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2009-10-22 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Added expected result for clicked-link-is-visited.html.
Removed test case from qt/Skipped as it works now.

  • platform/qt/Skipped:
  • platform/qt/fast/history: Added.
  • platform/qt/fast/history/clicked-link-is-visited-expected.txt: Added.

2009-10-22 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Enable track visited links in QWebPage
https://bugs.webkit.org/show_bug.cgi?id=30574

Test: fast/history/clicked-link-is-visited.html

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
14:08 Changeset [49956] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2009-10-22 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: windowFocused and windowBlured Fail to Clear/Mark Inspector as "inactive"
https://bugs.webkit.org/show_bug.cgi?id=30663

Correctly handle focusing/blurring on inner <iframe>'s such as Source Frames.

  • inspector/front-end/inspector.js: (WebInspector.windowFocused): fix for inner iframes (WebInspector.windowBlurred): fix for inner iframes (WebInspector.addMainEventListeners): change useCapture to false
13:33 Changeset [49955] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

Fixed ASSERT when opening Safari's Caches window while the Web Inspector
is open.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-22
Reviewed by Alexey Proskuryakov.

  • runtime/Collector.cpp:

(JSC::typeName): Added two new types to the type name list in the Collector.
These types have been around for a while, but nobody remembered to consider them here.

  • runtime/JSCell.h:

(JSC::JSCell::isPropertyNameIterator):

  • runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::isPropertyNameIterator): Give the Collector
a way to tell if a cell is a JSPropertyNameIterator.

13:19 Changeset [49954] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-22 Jaime Yap <jaimeyap@google.com>

Reviewed by Timothy Hatcher.

Makes a page reload optional when activating resource monitoring in
InspectorController. It leaves the default behavior as performing the reload.
Reload is an optional param so callsites do not have to change.

https://bugs.webkit.org/show_bug.cgi?id=30684

No new tests added.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking):
  • inspector/InspectorController.h:
13:10 Changeset [49953] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-10-22 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Eric Seidel.

[Qt] Add Print Shortcut to QtLauncher

https://bugs.webkit.org/show_bug.cgi?id=30682

  • QtLauncher/main.cpp: (MainWindow::setupUI):
13:06 Changeset [49952] by sfalken@apple.com
  • 2 edits
    1 delete in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=30686
Remove debug-specific def file.
Only Debug_All target uses JavaScriptCore_debug.dll naming, and since
that target is only used internally, maintaining two files just to
suppress a single link warning isn't worthwhile.

Reviewed by Jon Honeycutt.

12:56 Changeset [49951] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-22 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Fix memory leak in QNetworkReplyHandler::abort().
In QNetworkReplyHandler::release(), m_reply should no longer point to its parent
after being released.
https://bugs.webkit.org/show_bug.cgi?id=30167

No layout test available as a non-functional fix.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::abort): (WebCore::QNetworkReplyHandler::release):
12:15 Changeset [49950] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-10-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Fix DOMAgent leak.

https://bugs.webkit.org/show_bug.cgi?id=30615

  • inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::releaseDOMAgent):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
11:35 Changeset [49949] by dglazkov@chromium.org
  • 19 edits in trunk/WebCore

2009-10-22 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

[V8] Rework event listeners to not hold references to frame or V8 context.

https://bugs.webkit.org/show_bug.cgi?id=30648

Covered by existing layout tests: fast/events/attribute-listener*

  • bindings/scripts/CodeGeneratorV8.pm: Added passing ScriptExecutionContext*

to event listener handling code.

  • bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep): Changed to use currentContext().
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Reworked to match JSC logic. (WebCore::getEventListenerHandlerBody): Added ScriptExecutionContext* param.
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): Removed Frame* param

and usage.

(WebCore::V8AbstractEventListener::handleEvent): Chaged to use ScriptExecutionContext*.
(WebCore::V8AbstractEventListener::invokeEventHandler): Ditto.

  • bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::getListenerObject): Ditto. (WebCore::V8AbstractEventListener::prepareListenerObject): Ditto.
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Added ScriptExecutionContext* param. (WebCore::V8DOMWrapper::getEventListener): Ditto.
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Ditto.
  • bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper): Removed ContextType* template param,

because it's no longer needed.

  • bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::sharedContext): Renamed from shared_context.
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): Removed Frame* param and usage. (WebCore::V8LazyEventListener::callListenerFunction): Added ScriptExecutionContext* param. (WebCore::V8LazyEventListener::prepareListenerObject): Ditto.
  • bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create): Reordered params to match JSC impl.
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): Adjusted formatting to match WebKit style. (WebCore::V8Proxy::evaluateInNewContext): Changed to use m_context directly. (WebCore::V8Proxy::setInjectedScriptContextDebugId): Ditto. (WebCore::V8Proxy::createWrapperFromCacheSlowCase): Ditto. (WebCore::V8Proxy::isContextInitialized): Ditto. (WebCore::V8Proxy::updateDocumentWrapperCache): Ditto. (WebCore::V8Proxy::clearDocumentWrapperCache): Ditto. (WebCore::V8Proxy::disposeContextHandles): Added explicit disposing of m_context. (WebCore::V8Proxy::clearForClose): Changed to use m_context directly. (WebCore::V8Proxy::clearForNavigation): Ditto. (WebCore::V8Proxy::setSecurityToken): Ditto. (WebCore::V8Proxy::updateDocument): Ditto. (WebCore::V8Proxy::initContextIfNeeded): Ditto. (WebCore::V8Proxy::context): Changed to use v8::Local. (WebCore::V8Proxy::mainWorldContext): Changed to use m_context directly. (WebCore::V8Proxy::setContextDebugId): Ditto. (WebCore::toV8Context):
  • bindings/v8/V8Proxy.h: Removed shared_context decl, changed to use straight

v8::Persistent for m_context.

  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::workerProxy): Added. (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener): Removed

WorkerContextExecutionProxy* param.

(WebCore::V8WorkerContextEventListener::handleEvent): Started using ScriptExecutionContext*.
(WebCore::V8WorkerContextEventListener::reportError): Ditto.
(WebCore::V8WorkerContextEventListener::callListenerFunction): Ditto.
(WebCore::V8WorkerContextEventListener::getReceiverObject): Ditto.

  • bindings/v8/V8WorkerContextEventListener.h: (WebCore::V8WorkerContextEventListener::create): Removed

WorkerContextExecutionProxy* param.

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener): Removed ContextType*

template param.

  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener): Removed Frame* param. (WebCore::V8EventListener::getListenerFunction): Started using ScriptExecutionContext*. (WebCore::V8EventListener::callListenerFunction): Ditto.
  • bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create): Removed Frame* param.
11:10 Changeset [49948] by eric.carlson@apple.com
  • 4 edits in trunk/WebKit/mac

2009-10-22 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein & Simon Fraser.

<rdar://problem/7297717>
https://bugs.webkit.org/show_bug.cgi?id=30323
Play/pause button in full-screen video controller does not reflect current state

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController setMediaElement:WebCore::]): Register for QTMovieRateDidChangeNotification (-[WebVideoFullscreenController rateChanged:]): Call HUD controller when rate changes.
  • WebView/WebVideoFullscreenHUDWindowController.h:
  • WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Call updateRate so play button reflects playback state. (-[WebVideoFullscreenHUDWindowController updateRate]): New, set play button state according to movie state. (-[WebVideoFullscreenHUDWindowController playingChanged:]): Only call [self playing] once.
10:49 Changeset [49947] by darin@chromium.org
  • 5 edits in trunk/WebCore

2009-10-14 Gaurav Shah <gauravsh@google.com>

Reviewed by Darin Fisher.

Replaces temporary link stub for <keygen> tag handler for the Chromium
browser with a call via the Chromium Bridge.

https://bugs.webkit.org/show_bug.cgi?id=30360

  • platform/SSLKeyGenerator.h:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/SSLKeyGeneratorChromium.cpp: (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
  • platform/chromium/TemporaryLinkStubs.cpp: (WebCore::KURL::fileSystemPath): (WebCore::SharedBuffer::createWithContentsOfFile):
10:48 Changeset [49946] by atwilson@chromium.org
  • 3 edits in trunk/WebCore

Fixes Chromium Mac pasteboard handling to flow through the same code paths as other platforms.

Patch by Avi Drissman <avi@chromium.org> on 2009-10-22
Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30591

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeImage):

10:33 Changeset [49945] by simon.fraser@apple.com
  • 6 edits in trunk/WebCore

2009-10-20 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Make accelerated compositing debug indicators work in release builds
https://bugs.webkit.org/show_bug.cgi?id=30588

Allow some debug indicators, that show which page elements go into compositing layers,
to work in release builds, when the runtime prefs are set.

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer): (WebCore::GraphicsLayer::setZPosition):
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::clearBorderColor): (WebCore::GraphicsLayer::showRepaintCounter): (WebCore::GraphicsLayerCA::GraphicsLayerCA): (WebCore::GraphicsLayerCA::updateMasksToBounds): (WebCore::GraphicsLayerCA::updateLayerDrawsContent): (WebCore::GraphicsLayerCA::setDebugBorder): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): (WebCore::GraphicsLayerCA::setupContentsLayer):
  • platform/graphics/mac/WebLayer.mm:
10:30 Changeset [49944] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-22 Xan Lopez <xlopez@igalia.com>

Skip failing tests that seems to be somewhat tied to the Mac
platform. See https://bugs.webkit.org/show_bug.cgi?id=30680

  • platform/gtk/Skipped:
09:42 Changeset [49943] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

Code standarlization for QGVLauncher.

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-22
RubberStamped by Tor Arne Vestbø.

1) Made member initilization lists in constructors

to be per line.

2) Made applyProxy method inline as all other methods in

WebPage class.

  • QGVLauncher/main.cpp:

(WebPage::WebPage):
(WebPage::applyProxy):
(MainView::MainView):
(MainWindow::MainWindow):
(MainWindow::init):

09:34 Changeset [49942] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

Add a Y-Axis rotation to QGVLauncher.

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-22
Reviewed by Tor Arne Vestbø.

It uses the QStateMachine API from Qt 4.6.

  • QGVLauncher/main.cpp:

(WebView::WebView):
(WebView::setYRotation):
(WebView::yRotation):
(MainView::flip):
(MainView::animatedYFlip):
(SharedScene::SharedScene):
(SharedScene::webView):
(MainWindow::init):
(MainWindow::animatedYFlip):
(MainWindow::buildUI):

08:53 Changeset [49941] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-22 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Fix video-played.js to use an error timeout based on time rather than function call count.

https://bugs.webkit.org/show_bug.cgi?id=30657

  • media/video-played.js: (nowInSecs): Returns the current time in seconds. (playForMillisecs.callPauseIfTimeIsReached): Change from call counts to using elapsed time. (playForMillisecs): Ditto.
08:45 Changeset [49940] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-22 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Inspector should support monitorEvents/un monitorEvents() in the command line
https://bugs.webkit.org/show_bug.cgi?id=19879

  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update.callback): Ignores event listeners generated by monitorEvent
  • inspector/front-end/InjectedScript.js: (InjectedScript._ensureCommandLineAPIInstalled): Added _inspectorCommandLineAPI._logEvent, _allEventTypes, _normalizeEventTypes, monitorEvent, unmonitorEvent.
08:28 Changeset [49939] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2009-10-21 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: windowFocused and windowBlurred Fail to Clear/Mark Inspector as "inactive"
https://bugs.webkit.org/show_bug.cgi?id=30663

08:23 Changeset [49938] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2009-10-22 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Error - requestContentType [undefined] is not an object
https://bugs.webkit.org/show_bug.cgi?id=30666

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshFormData):
04:52 Changeset [49937] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-22 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Holger Freyther.

[Haiku] Correction of the accented letter width (they were 2 characters long).
https://bugs.webkit.org/show_bug.cgi?id=30629

  • platform/graphics/haiku/SimpleFontDataHaiku.cpp: (WebCore::SimpleFontData::platformWidthForGlyph):
03:49 Changeset [49936] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-22 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

m_webView should be private attribute of the EditorClientGtk.
https://bugs.webkit.org/show_bug.cgi?id=30664

  • WebKit/gtk/WebCoreSupport/EditorClientGtk.h:
03:39 Changeset [49935] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-22 Xan Lopez <xlopez@igalia.com>

libsoup can reconstruct URIs with empty querys now, so unskip
another bunch of tests.

  • platform/gtk/Skipped:
03:24 Changeset [49934] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-22 Xan Lopez <xlopez@igalia.com>

Unskip a couple of working tests.

  • platform/gtk/Skipped:
00:15 Changeset [49933] by jhoneycutt@apple.com
  • 6 edits in trunk

<rdar://problem/7270320> Screenshots of off-screen plug-ins are blank
<rdar://problem/7270314> After halting a transparent PluginView on
Windows, the transparency is applied twice

JavaScriptCore:

Reviewed by Dan Bernstein.

Export WTF::deleteOwnedPtr(HDC).

Ditto.

WebCore:

Replace use of Frame::nodeImage() with a function that takes a snapshot
of a PluginView.

Reviewed by Dan Bernstein.

  • plugins/PluginView.h:

Made paintWindowedPluginIntoContext() non-const, as it now calls
paintIntoTransformedContext(). Declare paintIntoTransformedContext()
and snapshot() for Windows platforms.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paintIntoTransformedContext):
Paints into the passed HDC without applying any coordinate translations.
Code moved from paintWindowedPluginIntoContext() and paint(). Removed
the memset() of windowpos in lieu of assignment.
(WebCore::PluginView::paintWindowedPluginIntoContext):
Code moved to paintIntoTransformedContext().
(WebCore::PluginView::paint):
Ditto.
(WebCore::PluginView::snapshot):
Create a context, and if the plug-in is windowless, translate it so the
plug-in will draw at the correct location. Create a bitmap, and select
it into the context. Paint the plug-in, and create a BitmapImage from
the bitmap.
(WebCore::PluginView::halt):
Use snapshot().

00:11 Changeset [49932] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-22 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix calculation of length in WebSocketChannel.cpp
https://bugs.webkit.org/show_bug.cgi?id=30656

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):

10/21/09:

23:20 Changeset [49931] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-10-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool's "patch failed to download an apply" error should give more information
https://bugs.webkit.org/show_bug.cgi?id=30632

  • Scripts/modules/scm.py:
    • Use the common run_command method instead of custom POpen code.
    • Make run_command know how to take pipes as input.
  • Scripts/modules/scm_unittest.py:
    • Add new tests to cover change.
    • Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
21:32 Changeset [49930] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

committers

16:57 Changeset [49929] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Adding the ability to enable/disable functions in V8 at runtime.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-21
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=30650

  • bindings/scripts/CodeGeneratorV8.pm:
16:47 Changeset [49928] by jorlow@chromium.org
  • 6 edits
    11 adds
    21 deletes in trunk/LayoutTests

Combine local and session storage tests into one and use script-tests properly
https://bugs.webkit.org/show_bug.cgi?id=30640

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-21
Reviewed by Darin Adler.

I was apparently misusing the script-tests stuff. I changed all the tests to
test both local storage and session storage so that we can use the
make-test-script-wrappers stuff as is.

  • storage/domstorage/clear-expected.txt: Added.
  • storage/domstorage/clear.html: Added.
  • storage/domstorage/complex-keys-expected.txt: Added.
  • storage/domstorage/complex-keys.html: Added.
  • storage/domstorage/complex-values-expected.txt: Added.
  • storage/domstorage/complex-values.html: Added.
  • storage/domstorage/localstorage/clear-expected.txt: Removed.
  • storage/domstorage/localstorage/clear.html: Removed.
  • storage/domstorage/localstorage/complex-keys-expected.txt: Removed.
  • storage/domstorage/localstorage/complex-keys.html: Removed.
  • storage/domstorage/localstorage/complex-values-expected.txt: Removed.
  • storage/domstorage/localstorage/complex-values.html: Removed.
  • storage/domstorage/localstorage/quota-expected.txt: Removed.
  • storage/domstorage/localstorage/quota.html: Removed.
  • storage/domstorage/localstorage/remove-item-expected.txt: Removed.
  • storage/domstorage/localstorage/remove-item.html: Removed.
  • storage/domstorage/quota-expected.txt: Added.
  • storage/domstorage/quota.html: Added.
  • storage/domstorage/remove-item-expected.txt: Added.
  • storage/domstorage/remove-item.html: Added.
  • storage/domstorage/script-tests/TEMPLATE.html: Added.
  • storage/domstorage/script-tests/clear.js:

(test):
(runTest):

  • storage/domstorage/script-tests/complex-keys.js:

(test):
(runTest):

  • storage/domstorage/script-tests/complex-values.js:

(test):
(runTest):

  • storage/domstorage/script-tests/no-quota.js: Removed.
  • storage/domstorage/script-tests/quota.js:

(testQuota):
(testNoQuota):
(runTest):

  • storage/domstorage/script-tests/remove-item.js:

(test):
(runTest):

  • storage/domstorage/sessionstorage/clear-expected.txt: Removed.
  • storage/domstorage/sessionstorage/clear.html: Removed.
  • storage/domstorage/sessionstorage/complex-keys-expected.txt: Removed.
  • storage/domstorage/sessionstorage/complex-keys.html: Removed.
  • storage/domstorage/sessionstorage/complex-values-expected.txt: Removed.
  • storage/domstorage/sessionstorage/complex-values.html: Removed.
  • storage/domstorage/sessionstorage/no-quota-expected.txt: Removed.
  • storage/domstorage/sessionstorage/no-quota.html: Removed.
  • storage/domstorage/sessionstorage/remove-item-expected.txt: Removed.
  • storage/domstorage/sessionstorage/remove-item.html: Removed.
16:39 Changeset [49927] by kevino@webkit.org
  • 5 edits in trunk/WebKitTools

Reviewed by Kevin Ollivier.

Update the Windows installer builder to work with Vista / Win 7 and with git.

https://bugs.webkit.org/show_bug.cgi?id=30649

16:10 Changeset [49926] by darin@apple.com
  • 4 edits in trunk

WebCore: Swedish search (and other languages as well) is broken while fixing Japanese search
https://bugs.webkit.org/show_bug.cgi?id=30646

Patch by Darin Adler <darin@apple.com> on 2009-10-21
Rolled Japanese tailoring out that was done to fix
https://bugs.webkit.org/show_bug.cgi?id=30437 earlier.
It was overriding the locale-specific tailoring.
We'll land a fix once we figure out how to add the
Japanese tailoring without removing anything.

  • editing/TextIterator.cpp: Rolled out r49924.

LayoutTests: Update since we rolled Japanese tailoring out that was done to fix
https://bugs.webkit.org/show_bug.cgi?id=30437 earlier.

Patch by Darin Adler <darin@apple.com> on 2009-10-21

  • fast/text/international/japanese-kana-letters-expected.txt: Update

test results to expect failure. We'll land results that expect
success once we re-fix the bug.

16:06 Changeset [49925] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-10-21 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Seidel.

Update more media layout tests to use findMediaFile().

https://bugs.webkit.org/show_bug.cgi?id=30644

  • media/controls-drag-timebar.html: Switch to using findMediaFile().
  • media/video-currentTime-set.html: Remove src attribute and rely on findMediaFile() instead.
15:16 Changeset [49924] by bweinstein@apple.com
  • 6 edits
    3 deletes in trunk

Roll out r49922 because it broke Tiger and SL in strange ways.

14:59 Changeset [49923] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-21 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium build fix - add missing image to gypi.

  • WebCore.gypi:
14:51 Changeset [49922] by bweinstein@apple.com
  • 8 edits
    3 adds in trunk

WebCore: Fixes part of <http://webkit.org/b/30522>.
Web Inspector: DOM Exceptions throughout the Inspector should be more human readable.

Reviewed by Eric Seidel.

Expose the description attribute that is now a member of
ExceptionBase as of r49723, so when a user logs an exception, they
can see the description in the Web Inspector.

Test: fast/dom/dom-exception-description.html

  • dom/DOMCoreException.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • svg/SVGException.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XPathException.idl:

LayoutTests: Fixes part of <http://webkit.org/b/30522>.
Web Inspector: DOM Exceptions throughout the Inspector should be more human readable.

Reviewed by Eric Seidel.

Adds a test to check the name and description of some DOM Exceptions.

  • fast/dom/dom-exception-description-expected.txt: Added.
  • fast/dom/dom-exception-description.html: Added.
  • fast/dom/script-tests/dom-exception-description.js: Added.
13:47 Changeset [49921] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-21 Alejandro G. Castro <alex@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Added conditional code to avoid using
gdk_window_get_root_coords if we do not have a gtk+ release newer
than 2.17.3.
https://bugs.webkit.org/show_bug.cgi?id=30636

  • WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
13:28 Writing Layout Tests for DumpRenderTree edited by jorlow@chromium.org
(diff)
13:22 WebKit Team edited by tkent@chromium.org
(diff)
13:02 Changeset [49920] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

Rubber-stamped by Dan Bernstein.

  • WebView/WebDynamicScrollBarsView.h:

Corrected a couple of long-obsolete comments regarding Safari's use of this class.

12:53 Changeset [49919] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Fixes <https://bugs.webkit.org/show_bug.cgi?id=30616>.
REGRESSION (r49036): Web Inspector: Summary graph no longer switching to size summary.

Reviewed by Timothy Hatcher.

Add a check to make sure a function we need to calculate percentages is
defined before we use it.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):

12:43 Changeset [49918] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2009-10-21 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Removed 5333725.html from Skipped and modified the expected
result of 5232159-expected.txt and fake-drag-expected.txt, this
modifications come from the changes in EventSender (bug 30633 and
bug 30636).
https://bugs.webkit.org/show_bug.cgi?id=30593

  • LayoutTests/platform/gtk/Skipped:
  • LayoutTests/platform/gtk/editing/selection/5232159-expected.txt:
  • LayoutTests/platform/gtk/editing/selection/fake-drag-expected.tx :
12:36 Changeset [49917] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-21 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

REGRESSION: Clicking on nodes in the console should take you to the element in the DOM
https://bugs.webkit.org/show_bug.cgi?id=27231

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._formatnode): Turns on ElementsTreeOutline.showInElementsPanelEnabled
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline): Added ElementsTreeOutline.showInElementsPanelEnabled (WebInspector.ElementsTreeElement.prototype.onmousedown): Reveals the node in the Elements panel if treeOutline.showInElementsPanelEnabled is true.
12:22 Changeset [49916] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=30637
Fix a compiler warning in windows.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-21
Reviewed by Eric Seidel.

  • loader/ResourceLoadNotifier.h:
12:18 Changeset [49915] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-10-21 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Added dummy implementation for keepWebHistory()
https://bugs.webkit.org/show_bug.cgi?id=30592

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::keepWebHistory):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
12:10 Changeset [49914] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-21 Victor Wang <victorw@chromium.org>

Reviewed by Eric Seidel.

Fix click-focus-anchor layout test to mimic click event.

https://bugs.webkit.org/show_bug.cgi?id=30610

  • fast/events/click-focus-anchor.html:
12:03 Changeset [49913] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-21 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fixed the double click condition, it is not double click if
we move in just in one direction.
https://bugs.webkit.org/show_bug.cgi?id=30636

  • WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
11:55 Changeset [49912] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-21 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Initialize the events completly before emitting them.
https://bugs.webkit.org/show_bug.cgi?id=30633

  • WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
11:32 Changeset [49911] by dimich@chromium.org
  • 3 edits
    2 adds in trunk

Fix the crash when a node not in a document receives dispatchEvent.
https://bugs.webkit.org/show_bug.cgi?id=30611

Reviewed by Darin Adler.

WebCore:

Test: fast/events/dispatch-event-no-document.html

  • dom/EventTarget.cpp: Check for scriptExecutionContext() at the moment of dispatchEvent; do nothing if no context.

(WebCore::EventTarget::dispatchEvent):

LayoutTests:

  • fast/events/dispatch-event-no-document-expected.txt: Added.
  • fast/events/dispatch-event-no-document.html: Added.
11:25 Changeset [49910] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix. Fix for when linking using --as-needed with gcc.

11:23 Changeset [49909] by agl@chromium.org
  • 2 edits in trunk/WebCore

2009-10-21 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium Linux: disable subpixel text on layers.

https://bugs.webkit.org/show_bug.cgi?id=30635
http://code.google.com/p/chromium/issues/detail?id=25365

With the addition of layers for drawing rounded corners in r49641,
subpixel text on rounded rectangles broke. This is because the layer
only contains a single alpha channel and this is insufficient to
compose subpixel text correctly.

On Windows, a large body of code in TransparencyWin.cpp exists to try
to deal with this. Even then, in some cases, it downgrades to
anti-aliased text. We need a fix for the grevious effects quickly thus
this patch disables subpixel text when rendering into a layer.

This would be covered by existing tests except that subpixel text is
disabled for pixel tests on Chromium Linux.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::isCanvasMultiLayered): (WebCore::adjustTextRenderMode): (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
11:13 Changeset [49908] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Include 'WebFrame.h' declared classes in wxPython bindings.

https://bugs.webkit.org/show_bug.cgi?id=30504

11:06 Changeset [49907] by kevino@webkit.org
  • 5 edits in trunk

wxMac build fixes. Fix issues with linking against wrong versions of sqlite3 and curl on Mac 10.4.

09:47 Changeset [49906] by mitz@apple.com
  • 4 edits
    1 copy
    4 adds in trunk

WebCore: Fixed background-clip parsing regressions introduced in r46240.

Reviewed by Sam Weinig.

Test: fast/css/background-clip-text.html

  • css/CSSParser.cpp:

(WebCore::parseBackgroundClip): Added this helper method.
(WebCore::CSSParser::parseFillShorthand): Use parseBackgroundClip() to
reparse the value. The old code called parseFillProperty() again, which
didn’t work, because parseFillProperty() advances the value list.
(WebCore::CSSParser::parseFillProperty): Changed to use
parseBackgroundClip().

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator EFillBox): Added a case for
CSSValueWebkitText.

LayoutTests: Added a background-clip parsing test that would have caught some
regressions that were introduced in r46240.

Reviewed by Sam Weinig.

  • fast/css/background-clip-text-expected.txt: Added.
  • fast/css/background-clip-text.html: Added.
  • fast/css/script-tests: Added.
  • fast/css/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/backgrounds/repeat/script-tests/TEMPLATE.html.
  • fast/css/script-tests/background-clip-text.js: Added.

(test):

06:57 Changeset [49905] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-21 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Enable creation of custom SidebarTreeElements for different ProfileTypes

ProfileTypes can now create sidebar tree elements of custom types.
https://bugs.webkit.org/show_bug.cgi?id=30520

  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType.prototype.setRecordingProfile): (WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile): (WebInspector.CPUProfileType.prototype.createView): (WebInspector.CPUProfile.prototype.get head):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileType.prototype.buttonClicked): (WebInspector.ProfileType.prototype.viewForProfile): (WebInspector.ProfileType.prototype.createView): (WebInspector.ProfileType.prototype.createSidebarTreeElementForProfile): (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.showProfile):
06:45 Changeset [49904] by joepeck@webkit.org
  • 4 edits in trunk/WebCore

2009-10-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Selectors in the Styles pane should trigger a search for that selector when clicked
https://bugs.webkit.org/show_bug.cgi?id=17126

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.addNodesToSearchResult): only change focusedDOMNode on a manual search
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype._clickSelector): trigger a search
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._startEditing): correctly start editing attribute value instead of name
06:33 Changeset [49903] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Fix DOM Agent leak.

https://bugs.webkit.org/show_bug.cgi?id=30615

  • inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController):
06:08 Changeset [49902] by eric@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

2009-10-21 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Holger Freyther.

Plugins: Create manual tests for testing plugins

Create two test files:

  1. windowed.html - Test plugin in windowed mode.
  2. windowless.html - Test plugin in windowless mode.

https://bugs.webkit.org/show_bug.cgi?id=30503

  • manual-tests/plugins/windowed.html: Added.
  • manual-tests/plugins/windowless.html: Added.
02:10 Changeset [49901] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-21 Xan Lopez <xlopez@igalia.com>

Skip another failing test.

  • platform/gtk/Skipped:
00:52 Changeset [49900] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-21 Xan Lopez <xlopez@igalia.com>

Skip a few more libxml2 related tests.

  • platform/gtk/Skipped:
00:11 Changeset [49899] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-10-21 Satoshi Nakagawa <psychs@limechat.net>

Reviewed by Darin Adler.

Fixed Japanese text search problems.
Treat small kana letters and kana letters as different characters in search.
Do not ignore diacritic marks in search for Japanese texts.

https://bugs.webkit.org/show_bug.cgi?id=30437

  • fast/text/international/japanese-kana-letters-expected.txt: Added.
  • fast/text/international/japanese-kana-letters.html: Added.

2009-10-21 Satoshi Nakagawa <psychs@limechat.net>

Reviewed by Darin Adler.

Fixed Japanese text search problems.
Treat small kana letters and kana letters as different characters in search.
Do not ignore diacritic marks in search for Japanese texts.

https://bugs.webkit.org/show_bug.cgi?id=30437

Test: fast/text/international/japanese-kana-letters.html

  • editing/TextIterator.cpp: (WebCore::createCollator): (WebCore::collator): (WebCore::createSearcher):

10/20/09:

21:56 Changeset [49898] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-20 Eric Z. Ayers <zundel@google.com>

Reviewed by Timothy Hatcher.

Changes TimelineItems to be created with raw timestamps as opposed
to a time relative to a start of session. Normalized timestamps cause
problems when monitoring a browsing session across multiple page
transitions.

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
  • inspector/InspectorTimelineAgent.h:
20:37 Changeset [49897] by pfeldman@chromium.org
  • 7 edits in trunk/LayoutTests

2009-10-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: simple console tests do not require testing harness.

https://bugs.webkit.org/show_bug.cgi?id=30478

  • inspector/uncaught-dom1-exception-expected.txt:
  • inspector/uncaught-dom1-exception.html:
  • inspector/uncaught-dom3-exception-expected.txt:
  • inspector/uncaught-dom3-exception.html:
  • inspector/uncaught-dom8-exception-expected.txt:
  • inspector/uncaught-dom8-exception.html:
19:31 Changeset [49896] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix leak of WebSocketChannel by adopting the newly-created reference.

Reviewed by Oliver Hunt.

  • websockets/WebSocketChannel.h:

(WebCore::WebSocketChannel::create):

17:42 Changeset [49895] by mrowe@apple.com
  • 3 edits
    2 deletes in trunk

Roll out r49876 as it causes many assertion failures during regression tests on SnowLeopard.

17:40 Changeset [49894] by jorlow@chromium.org
  • 6 edits in trunk/WebCore

DOM Storage runtime flag changes
https://bugs.webkit.org/show_bug.cgi?id=30602

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-20
Reviewed by Adam Barth.

Part 1/2. Removing sessionStorageEnabled in next patch after the
Chromium side of the changes lands.

Revert my changes to Settings and instead implement DOM Storage enabling via
the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240

This stuff was (intentionally) never exposed to web pages or DRT, so there's no
LayoutTest visible changes and thus no tests.

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::ACCESSOR_RUNTIME_ENABLER):

  • page/DOMWindow.idl:
  • storage/Storage.cpp:

(WebCore::Storage::setLocalStorageAvailable):
(WebCore::Storage::localStorageAvailable):
(WebCore::Storage::setSessionStorageAvailable):
(WebCore::Storage::sessionStorageAvailable):

  • storage/Storage.h:
17:22 Changeset [49893] by atwilson@chromium.org
  • 8 edits in trunk/WebCore

Need to turn off notifications properly at runtime
https://bugs.webkit.org/show_bug.cgi?id=30409

Patch by John Gregg <johnnyg@google.com> on 2009-10-20
Reviewed by David Levin.

This code only affects chromium, and is all behind a compile time
flag current turned off, so no new tests.

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::ACCESSOR_RUNTIME_ENABLER):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::ACCESSOR_RUNTIME_ENABLER):

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::setIsAvailable):
(WebCore::NotificationCenter::isAvailable):

  • notifications/NotificationCenter.h:
  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:
17:08 Changeset [49892] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-20 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

Fixes RefPtr initialization in the V8 implementation of WebCore::ScriptString to use the ::create() idiom and
use adoptRef() properly. I failed to read the RefPtr docs the first time through :(

No new tests, error was caught by valgrind on the Chromium builders.

  • bindings/v8/ScriptString.h: (WebCore::ScriptString::ScriptString): (WebCore::ScriptString::operator=):
  • bindings/v8/ScriptStringImpl.h: (WebCore::ScriptStringImpl::create):
16:10 Changeset [49891] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-10-20 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: populate child nodes before sorting them.

https://bugs.webkit.org/show_bug.cgi?id=29673

  • inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode): Swapped with BottomUpProfileDataGridTree to be consistent with TopDownProfileDataGridNode. (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild): (WebInspector.BottomUpProfileDataGridNode.prototype._exclude): (WebInspector.BottomUpProfileDataGridNode.prototype._merge): (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate): (WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
  • inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.sort): Added missing parentheses. (WebInspector.ProfileDataGridNode.prototype.get _parent): (WebInspector.ProfileDataGridNode.prototype._populate):
  • inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):
14:56 Changeset [49890] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

Remove redundant String ref/deref calls in generated V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30579

Patch by Jens Alfke <snej@chromium.org> on 2009-10-20
Reviewed by Eric Seidel.

  • bindings/v8/V8Binding.h:

(WebCore::toString): Fix return type of 'toString' to make it truly a no-op

instead of constructing/destructing a String.

14:56 Changeset [49889] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: updated variable name.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-20

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

14:55 Changeset [49888] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_next_pname): Slightly tweaked this #ifdef to match the
size of a JSValue because m_jsStrings is an array of JSValues.

Reviewed by Mark Rowe.

14:49 Changeset [49887] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed a 64-bit regression caused by the fix for
https://bugs.webkit.org/show_bug.cgi?id=30570.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-20
Reviewed by Mark Rowe.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_next_pname): Use TimesEight stepping on 64-bit, since
64-bit pointers are eight bytes long.

14:39 Changeset [49886] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

Refactored DateInstance::msToGregorianDateTime so that a DateInstance's
caller doesn't need to supply the DateInstance's own internal value to
the DateInstance.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-20
Reviewed by Sam Weinig.

  • runtime/DateInstance.cpp:

(JSC::DateInstance::getGregorianDateTime): Renamed from "msToGregorianDateTime".

  • runtime/DateInstance.h:
  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToLocaleString):
(JSC::dateProtoFuncToLocaleDateString):
(JSC::dateProtoFuncToLocaleTimeString):
(JSC::dateProtoFuncGetTime):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Also renamed "utc" to "outputIsUTC", for clarity.

14:20 Changeset [49885] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-20 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25411
[GTK] ATK accessible ancestry broken

Work around for the problem of bogus additional objects in the ancestry.
We now set the parent when we ref the child, then ask the Atk child if
it knows its parent. This solves the bulk of the cases. For those it
doesn't, fall back to the existing logic.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent): (webkit_accessible_ref_child):
13:56 Changeset [49884] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Rubber-stamped by Mark Rowe.

<rdar://problem/7319749> REGRESSION(r49806): Contextual Menu items missing
https://bugs.webkit.org/show_bug.cgi?id=30568

Revert accidental change from r49806.

  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::getCustomMenuFromDefaultItems):

13:50 Changeset [49883] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Fixes <http://webkit.org/b/30421>.
Web Inpsector: Local Files can show up on Cookies List with Cookies from other Domain.

Reviewed by Alice Liu.

When a page like Google generates an about:blank, it shows up as a local file on
the list of Cookie domains, but has all of the cookies of Google. When we are adding
cookie domains to the inspector, we should only add the domain is the URL of the resource
is in the HTTP protocol family or a file URL.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::populateScriptObjects):
(WebCore::InspectorController::didFinishLoading):

13:38 Changeset [49882] by japhet@chromium.org
  • 2 edits
    3 adds in trunk/WebCore

2009-10-20 Mark Mentovai <mark@chromium.org>

Reviewed by Darin Fisher.

Use a version of libWebKitSystemInterface with global symbols marked
private_extern for Chromium Mac.

https://bugs.webkit.org/show_bug.cgi?id=30590

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/mac: Added.
  • WebCore.gyp/mac/Empty.cpp: Added.
  • WebCore.gyp/mac/adjust_visibility.sh: Added.
13:12 Changeset [49881] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2009-10-20 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

Allow custom memory allocation control for WebCore's CSSProperty
https://bugs.webkit.org/show_bug.cgi?id=30564

Inherits CSSProperty class from FastAllocBase because it has been
instantiated by 'new' in WebCore/css/CSSParser.cpp:367.

  • css/CSSProperty.h:
13:03 Changeset [49880] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Another batch of skipped tests with links to their bugs.

  • platform/gtk/Skipped:
12:52 Changeset [49879] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Reviewed By Adam Barth.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Add some actions to the menu for cursor debugging.

GraphicsView based launcher only.

  • QGVLauncher/main.cpp:

(MainView::setWaitCursor):
(MainView::resetCursor):
(MainView::flip):
(MainWindow::setWaitCursor):
(MainWindow::resetCursor):
(MainWindow::buildUI):

12:08 Changeset [49878] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-20 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Seidel.

Hide Chromium's media slider thumb if no source has been loaded.

https://bugs.webkit.org/show_bug.cgi?id=30529

Covered by existing layout tests, notably:

LayoutTests/media/controls-rendering.html
LayoutTests/media/unsupported-tracks.html
LayoutTests/media/video-src-none.html

  • rendering/RenderMediaControlsChromium.cpp: (WebCore::hasSource): Returns true if an HTMLMediaElement has a valid source set. (WebCore::paintMediaMuteButton): Refactored to use hasSource(). (WebCore::paintMediaPlayButton): Ditto. (WebCore::paintMediaSliderThumb): Add call to hasSource() to determine if we should paint the thumb.
12:02 Changeset [49877] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Another batch of skipped tests with links to their bugs.

  • platform/gtk/Skipped:
12:00 Changeset [49876] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-10-20 Satoshi Nakagawa <psychs@limechat.net>

Reviewed by Darin Adler.

Fixed Japanese text search problems.
Treat small kana letters and kana letters as different characters in search.
Do not ignore diacritic marks in search for Japanese texts.

https://bugs.webkit.org/show_bug.cgi?id=30437

  • fast/text/international/japanese-kana-letters-expected.txt: Added.
  • fast/text/international/japanese-kana-letters.html: Added.

2009-10-20 Satoshi Nakagawa <psychs@limechat.net>

Reviewed by Darin Adler.

Fixed Japanese text search problems.
Treat small kana letters and kana letters as different characters in search.
Do not ignore diacritic marks in search for Japanese texts.

https://bugs.webkit.org/show_bug.cgi?id=30437

Test: fast/text/international/japanese-kana-letters.html

  • editing/TextIterator.cpp: (WebCore::createCollator): (WebCore::collator): (WebCore::createSearcher):
11:46 Changeset [49875] by hamaji@chromium.org
  • 1 edit
    2 adds
    4 deletes in trunk/LayoutTests

2009-10-20 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

fast/css/getComputedStyle/marginComputedStyle is missing
https://bugs.webkit.org/show_bug.cgi?id=30566

  • fast/css/getComputedStyle/marginComputedStyle-expected.txt: Added.
  • fast/css/getComputedStyle/marginComputedStyle.html: Added.
  • platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.checksum: Removed.
  • platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.png: Removed.
  • platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Removed.
  • platform/qt/fast/css/marginComputedStyle-expected.txt: Removed.
11:41 Changeset [49874] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-10-20 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Geoffrey Garen.

The op_next_pname should use 4 bytes addressing mode in case of JSValue32
https://bugs.webkit.org/show_bug.cgi?id=30570

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_next_pname):
11:20 Changeset [49873] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Another batch of skipped tests with links to their bugs.

  • platform/gtk/Skipped:
11:17 Changeset [49872] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2009-10-20 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Added getter for FrameLoader:m_suppressOpenerInNewFrame.
This will allow Chromium to more intelligently detect
noreferrer links and therefore open them in a new process.

https://bugs.webkit.org/show_bug.cgi?id=30581

  • loader/FrameLoader.h: (WebCore::FrameLoader::suppressOpenerInNewFrame): Added.
10:46 Changeset [49871] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-20 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Add {ager,antonm,yurys}@chromium.org into committers.py
https://bugs.webkit.org/show_bug.cgi?id=30560

  • Scripts/modules/committers.py:
10:45 Changeset [49870] by kenneth@webkit.org
  • 4 edits in trunk/WebKit/qt

Remove clipRenderToViewport as agreed upon in
https://bugs.webkit.org/show_bug.cgi?id=29843

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Rubberstamped by Adam Barth.

  • Api/qwebframe.cpp:
  • Api/qwebframe.h:
  • Api/qwebframe_p.h:

(QWebFramePrivate::QWebFramePrivate):

10:37 Changeset [49869] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Skip 3 failing xmlhttprequest tests.

https://bugs.webkit.org/show_bug.cgi?id=30582

  • platform/gtk/Skipped:
10:22 Changeset [49868] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Skip two failing security canvas tests.

https://bugs.webkit.org/show_bug.cgi?id=30580

  • platform/gtk/Skipped:
10:10 Changeset [49867] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Skip failing editing test.

  • platform/gtk/Skipped:
10:03 Changeset [49866] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Update the tests to test the new render functionality, and take
into consideration that render() clips to the frame itself as well
as the viewport.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Reviewed by Adam Barth.

QWebFrame::render() now always clips, so the old tests were bogus.

Rendering pure contents (no scrollbars etc) without clipping can now
be accomplished using QWebFrame::documentElement()->render(...)

  • Api/qwebframe.cpp:
  • Api/qwebframe.h:
  • Api/qwebframe_p.h:

(QWebFramePrivate::QWebFramePrivate):

  • tests/qwebframe/tst_qwebframe.cpp:
10:03 Changeset [49865] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

As we do not support rendering a QWebFrame without it being clipped
the the frame as well as the viewport, we now set the viewport size
to the size of the contents.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Reviewed by Adam Barth.

Rendering pure contents (no scrollbars etc) without clipping can be
acomplished using QWebFrame::documentElement()->render(...)

  • tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::render):

09:43 Changeset [49864] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Skip a bunch of failing DnD tests.

  • platform/gtk/Skipped:
09:40 Changeset [49863] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2009-10-20 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for WebCore's CSSParserFunction
https://bugs.webkit.org/show_bug.cgi?id=30563

Inherits CSSParserFunction struct from FastAllocBase because it has been
instantiated by 'new' in WebCore/css/CSSParser.cpp:4827.

  • css/CSSProperty.h:
09:29 Changeset [49862] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Skip two zoom related tests.

  • platform/gtk/Skipped:
08:55 Changeset [49861] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Skip a couple of failing media tests.

  • platform/gtk/Skipped:
08:47 Changeset [49860] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Skip failing a11y test while we investigate what's going on.

  • platform/gtk/Skipped:
08:41 Changeset [49859] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Skip tests expecting new results.

  • platform/gtk/Skipped:
08:30 Changeset [49858] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2009-10-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Watched Expressions Buttons Do Not Match Inspector Styles
https://bugs.webkit.org/show_bug.cgi?id=30554

  • inspector/front-end/inspector.css: added style to pane buttons
08:29 Changeset [49857] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Skip media/restore-from-page-cache.html since we are missing some
of the needed API for the test.

  • platform/gtk/Skipped:
08:06 Changeset [49856] by yurys@chromium.org
  • 3 edits in trunk/WebCore

=fix for 30559

08:00 Changeset [49855] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Skip another failing test because we don't currently support
changing the locale after gtk_init has been called.

Also, add another test to the list of libxml2 issues.

  • platform/gtk/Skipped:
07:25 Changeset [49854] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Remove http/tests/xmlhttprequest tests
from skiplist, and add only now failing tests.

  • platform/qt/Skipped:
07:18 Changeset [49853] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Skip a bunch of tests failing in the debug bots because WebKit
does not work correctly with very recent versions of libxml2. The
tracker bug for the issue is
https://bugs.webkit.org/show_bug.cgi?id=30508

  • platform/gtk/Skipped:
07:15 Changeset [49852] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

Make the Netscape Test plugin available to the Qt launcher.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Reviewed by Tor Arne Vestbø

  • Scripts/run-launcher:
07:14 Changeset [49851] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Add menu item to dump the plugin list to the console,
which can be handy for debugging.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Reviewed by Tor Arne Vestbø.

  • QtLauncher/main.cpp:

(MainWindow::dumpPlugins):
(MainWindow::setupUI):

07:14 Changeset [49850] by kenneth@webkit.org
  • 4 edits in trunk/WebKit/qt

Introduce new render method on QWebFrame, which supports specifying
which layers to render (scrollbars, contents, pan-icon).

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-19
Reviewed by Tor Arne Vestbø.

Deprecate render().

  • Api/qwebframe.cpp:

(QWebFramePrivate::renderPrivate):
(QWebFrame::render):

  • Api/qwebframe.h:
  • Api/qwebframe_p.h:
05:16 Changeset [49849] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Enable previously disabled fast/css tests after r48873 landed which
fixed https://bugs.webkit.org/show_bug.cgi?id=28288

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-20
Reviewed by Ariya Hidayat.

  • platform/qt/Skipped:
04:18 Changeset [49848] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Skip failing test, with comment pointing to the bug to track it.

  • platform/gtk/Skipped:
03:44 Changeset [49847] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-20 Xan Lopez <xlopez@igalia.com>

Skip plugins/private-browsing-mode.html, since our plugin
implementation lacks that feature.

  • platform/gtk/Skipped:
02:54 Changeset [49846] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit/qt

[Qt] Infinite loop (leading to crash) when setting cursor in QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=30549

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-19
Reviewed by Ariya Hidayat.

Patch reimplements QGraphicsItem's itemChange method, and make
CursorChange event to be emitted after cursor has already been
set.

QWidget::setCursor send the event just after it sets the cursor,
then patch makes both behaviors compatible.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::itemChange):

  • Api/qgraphicswebview.h:
02:42 Changeset [49845] by ossy@webkit.org
  • 3 edits in trunk/JavaScriptCore

Move OverridesMarkChildren flag from DatePrototype to its parent class
https://bugs.webkit.org/show_bug.cgi?id=30372

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-10-20
Reviewed by Oliver Hunt.

  • runtime/DateInstance.h:

(JSC::DateInstance::createStructure):

  • runtime/DatePrototype.h:
01:52 Changeset [49844] by ossy@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed buildfix.
[Qt] Add FEGaussianBlur.h and FEGaussianBlur.cpp which were refactored in r49778 to WebCore.pro.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-20

  • WebCore.pro:
00:36 Changeset [49843] by ukai@chromium.org
  • 27 edits in trunk

2009-10-20 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

Set EnabledAtRuntime for WebSocket in DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=29896

Supported by chromium/v8 only.
Add WebSocket::isAvailable()/setIsAvailable(bool) to control v8
bindings.
Remove Settings::experimentalWebSocketsEnabled() and
setExperimentalWebSocketsEnabled(bool).

  • WebCore.base.exp:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webSocket):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor):
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
  • page/DOMWindow.idl:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::setIsAvailable): (WebCore::WebSocket::isAvailable):
  • websockets/WebSocket.h:

2009-10-20 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

Removed WebSocket runtime settings.
https://bugs.webkit.org/show_bug.cgi?id=29896

WebSocket runtime configuration is supported by chromium/v8 only.

  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):

2009-10-20 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

Removed WebSocket runtime settings.
https://bugs.webkit.org/show_bug.cgi?id=29896

WebSocket runtime configuration is supported by chromium/v8 only.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2009-10-20 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

Removed WebSocket runtime settings.
https://bugs.webkit.org/show_bug.cgi?id=29896

WebSocket runtime configuration is supported by chromium/v8 only.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::experimentalNotificationsEnabled):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

2009-10-20 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

Removed WebSocket runtime settings.
https://bugs.webkit.org/show_bug.cgi?id=29896

WebSocket runtime configuration is supported by chromium/v8 only.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
00:23 Changeset [49842] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Tor Arne Vestbø.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-20
[Qt] Skip failing tests introduced by disabling Phonon support in Buildbot's Qt version
until a proper solution for the Phonon related craches and timeouts is found.

  • platform/qt/Skipped:

10/19/09:

23:56 Changeset [49841] by oliver@apple.com
  • 2 edits in trunk/WebCore

REGRESSION: Dromaeo DOM test is 14% slower
https://bugs.webkit.org/show_bug.cgi?id=30273

Reviewed by Sam Weinig.

Whoops, make prototype bindings actually use the StructureFlags.

22:01 Changeset [49840] by abarth@webkit.org
  • 4 edits
    2 copies in trunk/WebCore

2009-10-19 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

Better implementation of WebCore::ScriptString for the V8 bindings.

https://bugs.webkit.org/show_bug.cgi?id=29909

WebCore::ScriptString is used for XMLHttpRequest's responseText attribute which is
shared with JavaScript. Thus, simply using a WebCore::String and copying the value
is pretty inefficient, especially since responseText is built up with a sequence of
operator+= calls. JSC builds use a JSC::UString to share the buffer when possible,
this patch adopts a similar approach for V8.

No new tests, behavior is unchanged and covered by LayoutTests/http/tests/xmlhttprequest

  • WebCore.gypi:
  • bindings/v8/ScriptString.h: (WebCore::ScriptString::ScriptString): (WebCore::ScriptString::operator String): (WebCore::ScriptString::isNull): (WebCore::ScriptString::size): (WebCore::ScriptString::operator=): (WebCore::ScriptString::operator+=): (WebCore::ScriptString::v8StringOrNull):
  • bindings/v8/ScriptStringImpl.cpp: Added. (WebCore::ScriptStringImpl::ScriptStringImpl): (WebCore::ScriptStringImpl::~ScriptStringImpl): (WebCore::ScriptStringImpl::toString): (WebCore::ScriptStringImpl::isNull): (WebCore::ScriptStringImpl::size): (WebCore::ScriptStringImpl::append):
  • bindings/v8/ScriptStringImpl.h: Added. (WebCore::ScriptStringImpl::ScriptStringImpl): (WebCore::ScriptStringImpl::v8StringHandle):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::ACCESSOR_GETTER):
21:46 Changeset [49839] by abarth@webkit.org
  • 3 edits
    1 delete in trunk/WebCore

2009-10-19 Adam Barth <abarth@webkit.org>

No review, rolling out r49837.
http://trac.webkit.org/changeset/49837

  • page/Settings.cpp: (WebCore::Settings::setStandardFontFamily): (WebCore::Settings::setFixedFontFamily): (WebCore::Settings::setSerifFontFamily): (WebCore::Settings::setSansSerifFontFamily): (WebCore::Settings::setCursiveFontFamily): (WebCore::Settings::setFantasyFontFamily):
  • page/Settings.h: (WebCore::Settings::standardFontFamily): (WebCore::Settings::fixedFontFamily): (WebCore::Settings::serifFontFamily): (WebCore::Settings::sansSerifFontFamily): (WebCore::Settings::cursiveFontFamily): (WebCore::Settings::fantasyFontFamily):
  • platform/text/UScriptCode.h: Removed.
21:39 Changeset [49838] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-10-19 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

Check COMPILER(MSVC) instead of PLATFORM(WIN_OS) to avoid the use of vasprintf.
https://bugs.webkit.org/show_bug.cgi?id=30473

vasprintf is missing in MSVC. Use COMPILER(MSVC) guards instead of
PLALTFORM(WIN_OS) guards.

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):
21:37 Changeset [49837] by abarth@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2009-10-19 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=20797

Make generic font family getters/setters accept an additional
argument (script code). It has a default value so that if an embedder
does not have/want a per-script font family setting, call-sites
don't have to be changed.
This is to prepare for fixing bug 10874 (font selection is not
language-dependent) and bug 18085.

There should be no change in layout and no new layout test
is added.

  • WebCore.base.exp:
  • page/Settings.cpp:
  • page/Settings.h:
  • platform/text/UScriptCode.h: Added. This is for ports that do not use ICU. the part of ICU's common/unicode/uscript.h that defines script code enum was copied. To keep enums compatible with those in ICU, we don't generate the list out of Scripts.txt of the Unicode Data base or CLDR's data.
21:28 Changeset [49836] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-10-19 Evan Stade <estade@chromium.org>

Reviewed by Darin Adler.

Clarify usage of SuddenTermination API. No code change.

  • platform/SuddenTermination.h:
21:05 Changeset [49835] by oliver@apple.com
  • 10 edits in trunk/WebCore

REGRESSION: Dromaeo DOM test is 14% slower
https://bugs.webkit.org/show_bug.cgi?id=30273

Reviewed by Gavin Barraclough.

Make DOM bindings automatically inherit correct structure
flags rather than being needlessly conservative. This is
done by making the bindings generator use the same model
for TypeInfo flags that we now use in JSC.

This gains us about 1% of this regression back.

21:01 Changeset [49834] by abarth@webkit.org
  • 2 edits in trunk/WebKit

2009-10-19 John Gregg <johnnyg@google.com>

Reviewed by Dimitri Glazkov.

set ENABLE_NOTIFICATIONS=1 for Chromium
https://bugs.webkit.org/show_bug.cgi?id=29949

  • chromium/features.gypi:
20:19 Changeset [49833] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-10-19 Robin Qiu <robin.qiu@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Add a layout test for nested SVG <use> element which has a child.
https://bugs.webkit.org/show_bug.cgi?id=26117

  • svg/custom/use-on-use-with-child-expected.txt: Added.
  • svg/custom/use-on-use-with-child.svg: Added.

2009-10-19 Robin Qiu <robin.qiu@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Fixed a bug on nested SVG <use> elements.
https://bugs.webkit.org/show_bug.cgi?id=26117
When a <use> element refer to another <use> element which has
child/children, the instance tree built for this <use> element
is incorrect (more nodes than expected).

Test: svg/dom/use-on-use-with-child.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree):
19:59 Changeset [49832] by timothy@apple.com
  • 2 edits in trunk/WebCore

Small changes to fully invalidate and update the JavaScriptCallFrame.

Patch by Oliver Hunt <oliver@apple.com> on 2009-10-19
<rdar://problem/7020755> JSDebugger crashes after reloading from a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=27146

Reviewed by Timothy Hatcher.

  • inspector/JavaScriptCallFrame.h:

(WebCore::JavaScriptCallFrame::invalidate):
(WebCore::JavaScriptCallFrame::update):

19:51 Changeset [49831] by jorlow@chromium.org
  • 3 edits in trunk/LayoutTests

2009-10-19 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

Fix fallout from last change.
https://bugs.webkit.org/show_bug.cgi?id=30550

Update init-events to match reality. I only ran the domstorage layout tests
and thus missed one in fast/events/. This addresses fallout from
https://bugs.webkit.org/show_bug.cgi?id=30536

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
18:32 Changeset [49830] by jorlow@chromium.org
  • 17 edits in trunk

2009-10-19 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dmitri Titov.

Remove "source" from storage events
https://bugs.webkit.org/show_bug.cgi?id=30536

Remove "source" from storage events per
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html

This was removed because it makes it introduces synchronous access that can
cross the event loop boundry (since a storage event can fire from one process
and be handled in another).

  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::handleEvent):
  • storage/StorageEvent.cpp: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent): (WebCore::StorageEvent::initStorageEvent):
  • storage/StorageEvent.h: (WebCore::StorageEvent::uri):
  • storage/StorageEvent.idl:
  • storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):

2009-10-19 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dmitri Titov.

Remove "source" from storage events
https://bugs.webkit.org/show_bug.cgi?id=30536

Remove "source" from storage events per
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html

  • storage/domstorage/localstorage/iframe-events-expected.txt:
  • storage/domstorage/localstorage/iframe-events.html:
  • storage/domstorage/localstorage/resources/iframe-events-second.html:
  • storage/domstorage/localstorage/simple-events-expected.txt:
  • storage/domstorage/localstorage/simple-events.html:
  • storage/domstorage/sessionstorage/iframe-events-expected.txt:
  • storage/domstorage/sessionstorage/iframe-events.html:
  • storage/domstorage/sessionstorage/resources/iframe-events-second.html:
  • storage/domstorage/sessionstorage/simple-events-expected.txt:
  • storage/domstorage/sessionstorage/simple-events.html:
18:29 Changeset [49829] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2009-10-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove ResourceLoadNotifier::activeDocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=30533

Removing this method from ResourceLoadNotifier better decouples the
notifier from FrameLoader.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::requestFromDelegate):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveResponse):
  • loader/ResourceLoadNotifier.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest):
18:28 Changeset [49828] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2009-10-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move sendRemainingDelegateMessages to ResourceLoadNotifier
https://bugs.webkit.org/show_bug.cgi?id=30531

This method is about notifying folks and doesn't interact with the rest
of FrameLoader.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::willLoadMediaElementURL): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  • loader/FrameLoader.h:
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  • loader/ResourceLoadNotifier.h:
18:19 Changeset [49827] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

2009-10-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Bypass popup blocker using click event
https://bugs.webkit.org/show_bug.cgi?id=21501

Test that a fake event can't get around the popup blocker.

  • http/tests/security/popup-blocked-from-fake-event-expected.txt: Added.
  • http/tests/security/popup-blocked-from-fake-event.html: Added.

2009-10-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Bypass popup blocker using click event
https://bugs.webkit.org/show_bug.cgi?id=21501

Keep track of which events were generated by JavaScript and use that
inforation when figuring out if we're processing a user gesture.

Test: http/tests/security/popup-blocked-from-fake-event.html

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGestureEvent):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
  • dom/Document.cpp: (WebCore::Document::createEvent):
  • dom/Event.cpp: (WebCore::Event::Event):
  • dom/Event.h: (WebCore::Event::createdByDOM): (WebCore::Event::setCreatedByDOM):
18:09 Changeset [49826] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Fixing a typo.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-19
Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30543

  • platform/sql/SQLiteDatabase.h:
18:05 Changeset [49825] by dumi@chromium.org
  • 1 edit in trunk/WebKitTools/Scripts/modules/committers.py

Adding myself to committers.py.

17:41 Changeset [49824] by dimich@chromium.org
  • 1 edit
    1 add in trunk/WebCore

Manual Test for crash caused by JS accessing DOMWindow which is disconnected from the Frame.
https://bugs.webkit.org/show_bug.cgi?id=30544

Reviewed by Darin Adler.

  • manual-tests/crash-on-accessing-domwindow-without-frame.html: Added.
17:38 Changeset [49823] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-10-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Flash at end of opacity/transform transition sometimes
https://bugs.webkit.org/show_bug.cgi?id=30501

When a transition finishes, there window of time between when the animation is
removed, and the final style set on the GraphicsLayer. This caused the layer to revert
to its old appearance for one or two frames. To avoid this, we set the final
transform or opacity at the start of the transition; we know that the animation
will override the final value for as long as its running.

No test because this is a very transient effect that can't be captured
in a test.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::updateLayerOpacity): (WebCore::RenderLayerBacking::updateLayerTransform): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::startTransition):
  • rendering/RenderLayerBacking.h:
17:12 Changeset [49822] by cmarrin@apple.com
  • 1 edit in trunk/WebKitSite/blog-files/webgl/resources/blogpost.css

Added one more style rule

17:03 Changeset [49821] by cmarrin@apple.com
  • 1 add in trunk/WebKitSite/blog-files/webgl/resources/blogpost.css

Moved WebGL blog CSS to a separate file

15:59 Changeset [49820] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Tightened up some put_by_id_transition code generation.
https://bugs.webkit.org/show_bug.cgi?id=30539

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-19
Reviewed by Oliver Hunt.

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::testPrototype):
(JSC::JIT::privateCompilePutByIdTransition): No need to do object type
checks or read Structures and prototypes from objects: they're all known
constants at compile time.

15:44 Changeset [49819] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-10-19 Jason Yan <tailofthesun@gmail.com>

Reviewed by Eric Seidel.

Fixed issue with LayoutTests/fast/cookies/local-file-can-set-cookies.html
which can fail when the system under test has local file cookies set already.
https://bugs.webkit.org/show_bug.cgi?id=30281

  • fast/cookies/local-file-can-set-cookies-expected.txt: Modified. Updated expected results.
  • fast/cookies/local-file-can-set-cookies.html: Modified. Check for existing cookie and set non-persistent cookie.
15:36 Changeset [49818] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-10-19 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

Language tag should include both language and country sub-tags,
case insensitive.
https://bugs.webkit.org/show_bug.cgi?id=30440

  • fast/js/navigator-language-expected.txt:
  • fast/js/navigator-language.html:
15:28 Changeset [49817] by eric@webkit.org
  • 2 edits in trunk/WebKitLibraries

2009-10-19 Marshall Culpepper <mculpepper@appcelerator.com>

Reviewed by Eric Seidel.

added cairo include and lib directories to debug_wincairo.vsprops
https://bugs.webkit.org/show_bug.cgi?id=29831

  • win/tools/vsprops/debug_wincairo.vsprops:
15:10 Changeset [49816] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2009-10-19 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Seidel.

Replace boolean operator indentation example with an if statement.

https://bugs.webkit.org/show_bug.cgi?id=30538

  • coding/coding-style.html: Replace boolean indenting example to use "if"
15:00 Changeset [49815] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add more stop characters into console completions.

https://bugs.webkit.org/show_bug.cgi?id=30477

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._reportCompletions):
15:00 Changeset [49814] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Fix crashes/assertions when calling WebLocalizedString from multiple threads concurrently

Fixes <http://webkit.org/b/30534> WebLocalizedString asserts if called
from multiple threads concurrently

Reviewed by John Sullivan.

  • WebLocalizableStrings.cpp:

(mainBundleLocStringsMutex):
(frameworkLocStringsMutex):
Added these new getters.

(findCachedString):
(cacheString):
Lock the relevant mutex before accessing each string map. Otherwise
bad things could happen if two threads end up here at the same time.

15:00 Changeset [49813] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Get rid of a few static initializers/exit-time destructors in WebLocalizableStrings

Reviewed by Dan Bernstein.

  • WebLocalizableStrings.cpp:

(mainBundleLocStrings):
(frameworkLocStrings):
Added these functions instead of file-scope variables.

(findCachedString):
(cacheString):
Updated to use the new functions.

14:41 Changeset [49812] by japhet@chromium.org
  • 4 edits in trunk/WebKit

2009-10-19 Nate Chapin <japhet@chromium.org>

Unreviewed, build fix.

Update call to FrameLoader::loadFrameRequest() in qt and
FrameLoader::urlSelected() in win.

14:39 Changeset [49811] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-19 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30266


Added the test case for bug #30266 to the Windows skip list because
event.dataTransfer.types does not behave correctly. See bug #30527.

  • platform/win/Skipped: Added test case to Windows skipped list.
14:31 Changeset [49810] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-19 Marshall Culpepper <mculpepper@appcelerator.com>

Reviewed by Adam Roben.

implemented ClipboardWin::files()
https://bugs.webkit.org/show_bug.cgi?id=29666

  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::files):
14:15 Changeset [49809] by japhet@chromium.org
  • 13 edits
    11 adds in trunk

2009-10-19 Nate Chapin <japhet@chromium.org>

Reviewed by Alexey Proskuryakov.

Add support for link relations in HTMLAnchorElement and implement rel="noreferrer".

https://bugs.webkit.org/show_bug.cgi?id=28986

14:08 Changeset [49808] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

Documentation fix for -[NSObject(WebResourceLoadDelegate) webView:resource:willSendRequest:redirectResponse:fromDataSource:]

Reviewed by Dan Bernstein.

  • WebView/WebResourceLoadDelegate.h: Prepended "webView:" to the

@method declaration of
-webView:resource:willSendRequest:redirectResponse:fromDataSource:
which was absent before r3953 and was missed during the great
documentation clean up of r4269.

14:01 Changeset [49807] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix build.

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):

13:30 Changeset [49806] by mitz@apple.com
  • 8 edits in trunk/WebKit/mac

Split assertions of conjunctions into separate statements or remove
redundant assertions.

Reviewed by Anders Carlsson.

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::deadNameNotificationCallback):

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView setAttributeKeys:andValues:]):
(-[WebHostedNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]):

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView halt]):
(-[WebBaseNetscapePluginView resumeFromHalt]):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
(-[WebNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]):

  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::getCustomMenuFromDefaultItems):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::checkGrammarOfString):
(WebEditorClient::checkTextOfParagraph):

  • WebView/WebTextCompletionController.mm:

(-[WebTextCompletionController _reflectSelection]):

13:25 Changeset [49805] by japhet@chromium.org
  • 2 edits in trunk/LayoutTests

2009-10-19 Nate Chapin <japhet@chromium.org>

Reviewed by Geoffrey Garen.

Add plugins/netscape-invoke-failures.html to Snow Leopard skipped list.

https://bugs.webkit.org/show_bug.cgi?id=30528

  • platform/mac-snowleopard/Skipped: Add plugins/netscape-invoke-failures.html.
13:25 Changeset [49804] by kenneth@webkit.org
  • 3 edits in trunk/WebCore

Refactor out some of the code in paint() into paintPanScrollIcon()
and paintScrollbars() in preparation of some Qt API changes.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-19
Reviewed by David Hyatt.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::paint):

  • platform/ScrollView.h:
13:18 Changeset [49803] by hclam@chromium.org
  • 4 edits in trunk/WebCore

[v8] typeof(HTMLMediaElement) should return undefined if media
engine is not available
https://bugs.webkit.org/show_bug.cgi?id=30343

Patch by Alpha Lam <hclam@chromium.org> on 2009-10-19
Reviewed by Dimitri Glazkov (dglazkov@chromium.org).

Check for availability of the media engine to disable
HTMLMediaElement, HTMLAudioElement, HTMLVideoElement, MediaError
in runtime.

Try runs and review in Chromium:
http://codereview.chromium.org/276011

Test: manual-tests/chromium/media-player-not-available.html

The above test can work work in Chromium. Testing procedures:

  1. Remove all media support libraries in Chromium (e.g. ffmpeg libraries)
  2. Open Chromium with above test page
  3. Verify the test results according to the test page
  • bindings/v8/custom/V8CustomBinding.h:

Declare enabler methods.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

Report enabled only if media player is available.

  • manual-tests/chromium/media-player-not-available.html: Added.

Manual test, following instruction in this test for procedures.

  • page/DOMWindow.idl:

Mark HTMLMediaElement, HTMLAudioElement, HTMLVideElement, MediaError
as enabled at runtime.

12:59 Changeset [49802] by ggaren@apple.com
  • 9 edits
    1 add in trunk/JavaScriptCore

Added a private API for getting a global context from a context, for
clients who want to preserve a context for a later callback.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-19
Reviewed by Sam Weinig.

  • API/APICast.h:

(toGlobalRef): Added an ASSERT, since this function is used more often
than before.

  • API/JSContextRef.cpp:
  • API/JSContextRefPrivate.h: Added. The new API.
  • API/tests/testapi.c:

(print_callAsFunction):
(main): Test the new API.

12:38 Changeset [49801] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-19 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Alexey Proskuryakov.

[Gtk] ApplicationCacheStorage error while compiling WebKit/gtk/webkit/webkitapplicationcache.cpp
https://bugs.webkit.org/show_bug.cgi?id=30358

Guard calls to cacheStorage() with ENABLE(OFFLINE_WEB_APPLICATIONS).

  • webkit/webkitapplicationcache.cpp:
12:24 Changeset [49800] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Make the local static panScrollIcon into a Image* instead
of a RefPtr<Image>.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-19
Reviewed by Adam Roben.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

12:19 Changeset [49799] by ajwong@chromium.org
  • 2 edits in trunk/WebCore

Forcefully set antialiasing for Chromium media controls.

Patch by Andrew Scherkus <scherkus@chromium.org> on 2009-10-19
Reviewed by NOBODY (OOPS!).

https://bugs.webkit.org/show_bug.cgi?id=30521

Before it was nondeterministiacally being enabled based on the previous state of GraphicsContext.

Covered by existing layout tests.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaSlider): Added setShouldAntialias(true).

12:11 Changeset [49798] by eric@webkit.org
  • 11 edits in trunk/WebCore

2009-10-19 Jens Alfke <jens@mooseyard.com>

Reviewed by Darin Adler.

Optimize string upper/lowercasing
https://bugs.webkit.org/show_bug.cgi?id=30261

  • Added AtomicString::upper() and lower()
  • Further optimized StringImpl::lower()
  • Removed StringImpl::isLower()
  • Added QualifiedName::localNameUpper(), which is cached, thereby saving thousands of upper() calls and string allocations.
  • dom/Element.cpp: (WebCore::Element::setAttribute): Call AtomicString::lower()
  • dom/QualifiedName.cpp: (WebCore::QualifiedName::localNameUpper): New method
  • dom/QualifiedName.h: Added localNameUpper() method
  • dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Call AtomicString::lower()
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createElement): Call AtomicString::lower()
  • html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): Call localNameUpper()
  • platform/text/AtomicString.cpp: (WebCore::AtomicString::lower): New method (WebCore::AtomicString::upper): New method
  • platform/text/AtomicString.h: Added lower() and upper()
  • platform/text/StringImpl.cpp: Removed isLower() (WebCore::StringImpl::lower): Further optimization of initial loop
  • platform/text/StringImpl.h: Removed isLower()
11:59 Changeset [49797] by eric@webkit.org
  • 19 edits
    1 delete in trunk/LayoutTests

2009-10-19 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

Update test results and Skipped list after changes in r49791.

Some test results were accidentally committed in r49192. At that time
results were incorrect, but testing still succeeded because of
unimplemented features. After r49791 tests, though generating semantically
equal output to Mac's render trees, started to fail and need to have
generated results updated. This patch does just that.

  • platform/gtk/Skipped: Skip a test that does not generate semantically equal render trees.
  • platform/gtk/editing/inserting/insert-3907422-fix-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-2-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-3-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-expected.txt:
  • platform/gtk/editing/pasteboard/paste-table-001-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-002-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-007-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-010-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-015-expected.txt:
  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
  • platform/gtk/editing/pasteboard/select-element-1-expected.txt: Removed.
11:50 Changeset [49796] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2009-10-19 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Test that the proper exception is thrown into JS when a plugin
invoke call returns false.

https://bugs.webkit.org/show_bug.cgi?id=30239

  • plugins/netscape-invoke-failure-expected.txt: Added.
  • plugins/netscape-invoke-failure.html: Added.

2009-10-19 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

If a call to a plugin's invokeMethod, invokeDefault or construct
returns false, throw an exception into JS.

https://bugs.webkit.org/show_bug.cgi?id=30239

Test: plugins/netscape-invoke-failure.html

  • bindings/v8/V8NPObject.cpp: Check return values of invokeMethod, invokeDefault and construct. (npObjectInvokeImpl):
  • bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::invokeMethod): Check return value (JSC::Bindings::CInstance::invokeDefaultMethod): Check return value (JSC::Bindings::CInstance::invokeConstruct): Check return value

2009-10-19 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Add testFail() to test plugin so we can test our handling of a
plugin invoke call returning false.

https://bugs.webkit.org/show_bug.cgi?id=30239

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail(). (pluginInvoke): (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
11:47 Changeset [49795] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Tightened up some instanceof code generation.
https://bugs.webkit.org/show_bug.cgi?id=30488

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-17
Reviewed by Oliver Hunt.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof): No need to do object type checks -
cell type checks and ImplementsDefaultHasIntance checks implicitly
supersede object type checks.

11:38 Changeset [49794] by senorblanco@chromium.org
  • 3 edits
    4 adds in trunk

WebCore: Fix for chromium/skia canvas arc start/end positions, when the arc is

360 degrees.

https://bugs.webkit.org/show_bug.cgi?id=30449

Reviewed by Adam Barth.

Covered by new test:
LayoutTests/fast/canvas/arc360.html

  • platform/graphics/skia/PathSkia.cpp:

(WebCore::Path::addArc):

LayoutTests: New test for 360 degree arc endpoints, and expected results.
http://bugs.webkit.org/show_bug.cgi?id=30449

Reviewed by Adam Barth.

  • fast/canvas/arc360.html: Added.
  • platform/mac/fast/canvas/arc360-expected.checksum: Added.
  • platform/mac/fast/canvas/arc360-expected.png: Added.
  • platform/mac/fast/canvas/arc360-expected.txt: Added.
11:14 Changeset [49793] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

Add tests that have never passed on Windows to the Skipped list, and reopen
bugs.

  • platform/win/Skipped:
10:35 Changeset [49792] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-19 Kent Tamura <tkent@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix uninitialized variable reference in Element::removeAttribute().
https://bugs.webkit.org/show_bug.cgi?id=30502

  • dom/Element.cpp: (WebCore::Element::removeAttribute):
10:25 Changeset [49791] by eric@webkit.org
  • 7 edits in trunk

2009-10-19 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

Enable tests that pass when DOM pasting is allowed.

  • platform/gtk/Skipped:

2009-10-19 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

Add a settings to allow DOM pastes to be performed.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):

2009-10-19 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

Enable DOM pasting when running layout tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
10:13 Changeset [49790] by eric.carlson@apple.com
  • 11 edits in trunk

2009-10-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=30463
Remove HTML5 media element 'loadend' event

  • dom/EventNames.h:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute): Remove 'loadend'. (WebCore::HTMLMediaElement::loadInternal): Ditto. (WebCore::HTMLMediaElement::noneSupported): Ditto. (WebCore::HTMLMediaElement::mediaEngineError): Ditto. (WebCore::HTMLMediaElement::setNetworkState): Ditto. (WebCore::HTMLMediaElement::userCancelledLoad): Ditto.

2009-10-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=30463
Remove HTML5 media element 'loadend' event

  • media/event-attributes-expected.txt:
  • media/event-attributes.html: Switch from 'loadend' to 'canplaythrough'.
  • media/media-load-event-expected.txt:
  • media/media-load-event.html: Ditto.
  • media/progress-event-at-least-one-expected.txt:
  • media/progress-event-at-least-one.html: Ditto.
09:26 Changeset [49789] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Adam Barth.

[Qt] Remove deletion of outgoing FormData object when reply is finished.
The buffers will be destroyed a bit later, when the QNetworkReply is deleted.
Bug: https://bugs.webkit.org/show_bug.cgi?id=29551

  • platform/network/qt/QNetworkReplyHandler.cpp:
  • platform/network/qt/QNetworkReplyHandler.h:
09:18 Changeset [49788] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-19 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Fix hard-to-reproduce crash in HTMLTokenizer by avoiding a rare
fastRealloc edge case.
https://bugs.webkit.org/show_bug.cgi?id=29313

No test, the crash shows up occasionally in crash dumps, we weren't able
to reproduce it locally.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::enlargeScriptBuffer): Added an early exit to

avoid calling fastRealloc with the size of 0.

09:08 Changeset [49787] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-19 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Seidel.

Use fillRect() instead of drawRect() to fix Chromium media controls rendering.

https://bugs.webkit.org/show_bug.cgi?id=30371

Chromium Mac layout tests will need to be rebaselined. Existing layout tests for Linux/Win still pass.

  • rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaSlider): Use fillRect() instead of drawRect().
09:00 Changeset [49786] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-19 Dmitry Titov <dimich@chromium.org>

Reviewed by Adam Barth.

Crash in DOMWindow::clearTimeout etc when DOMWindow is not connected to a frame.
https://bugs.webkit.org/show_bug.cgi?id=29832

Need to make sure the script caches are reset when frame gets disconnected from still-alive DOMWindow.
This will prevent JS from calling DOMWindow methods that can not be completed w/o the frame.

I am not sure it's possible to test this since the only file that repros the problem need ~10 seconds to cause crash.

  • page/Frame.cpp: (WebCore::Frame::~Frame): Right after frame disconnects from DOMWindow, clear WindowShell.
08:53 Changeset [49785] by laszlo.1.gombos@nokia.com
  • 5 edits
    1 add in trunk/WebKit/qt

2009-10-19 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Ariya Hidayat.

Add QWebElement::render API which allows rendering of single
element.

  • Api/qwebelement.cpp: (QWebElement::render):
  • Api/qwebelement.h:
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::render):
  • tests/qwebelement/qwebelement.qrc:
  • tests/qwebelement/image.png: Added.
08:16 Changeset [49784] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

QWebPage: Doc: setNetworkAccessManager should only be called once.

Patch by Markus Goetz <Markus.Goetz@nokia.com> on 2009-10-19
Reviewed by Ariya Hidayat.

08:02 Changeset [49783] by ossy@webkit.org
  • 2 edits in trunk/WebCore

2009-10-19 Csaba Osztrogonác <ossy@webkit.org>

Unreviewed build warning fix.
[Qt] Apply changes to WebCore.pro introduced in r49778

  • WebCore.pro: Removed svg/graphics/filters/SVGFEGaussianBlur.h from HEADERS
08:01 Changeset [49782] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

Wrong ifdef combination in QGraphicsWebView's event method.

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-19
Reviewed by Tor Arne.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::event):

07:42 Changeset [49781] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip failing tests for now and add test-specific information about the cause to the Skipped list.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-19
Reviewed by Tor Arne Vestbø.

  • platform/qt/Skipped:
07:16 Changeset [49780] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

Make WebKitHitTestResult actually appear in the index

07:00 Changeset [49779] by ossy@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] Add platform expected file for canvas test.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-19
Reviewed by Tor Arne Vestbø.

  • platform/qt/fast/canvas/canvas-empty-image-pattern-expected.txt: Added.
05:57 Changeset [49778] by krit@webkit.org
  • 7 edits
    2 moves in trunk/WebCore

2009-10-19 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

Move feGaussianBlur from WebCore/svg to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=30495

This patch moves SVGFRGaussianBlur from svg/graphics/filters
to platform/graphics/filters/FEGaussianBlur. This is needed
for shadow support on Qt and Cairo.
No change in functionality, therfore no new test case needed.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/FEGaussianBlur.cpp: Added.
  • platform/graphics/filters/FEGaussianBlur.h: Added.
  • svg/SVGFEGaussianBlurElement.h:
  • svg/graphics/filters/SVGFEGaussianBlur.cpp: Removed.
  • svg/graphics/filters/SVGFEGaussianBlur.h: Removed.
05:49 Changeset [49777] by yael.aharon@nokia.com
  • 1 edit in trunk/WebCore/ChangeLog

Unreviewed.

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-10-19
Added reviewer name to r49574.

05:48 Changeset [49776] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

2009-10-19 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Tor Arne Vestbø.

[Qt] Update outdated metrics for these passing tests.

  • platform/qt/css1/font_properties/font-expected.txt:
  • platform/qt/fast/xsl/document-function-expected.txt:
04:58 Changeset [49775] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-19 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30489
[Gtk] The document frame/html container claims to be parentless

Work around for the parentless claim made by the accessible associated
with the embedded WebView. When we identify this condition, get the
widget's parent, and then get the AtkObject from that. Admittedly an ugly
hack, but we'll need it for Yelp and other Gtk+/GNOME applications which
plan to switch over to WebKit.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent):
04:51 Changeset [49774] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-10-19 Benjamin Otte <otte@gnome.org>

Reviewed by Jan Alonzo.

Handle duration queries properly
https://bugs.webkit.org/show_bug.cgi?id=29999

Previously duration queries failed to handle unknown duration
and didn't treat the returned duration as an unsigned.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration):
04:50 Changeset [49773] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2009-10-19 Daniel Macks <dmacks@netspace.org>

Reviewed by Adam Barth.

Inconsistent handling of gettext domain can cause compile failure
https://bugs.webkit.org/show_bug.cgi?id=30292

  • GNUmakefile.am: Use DOMAIN variable instead of hard-coded value
04:28 Changeset [49772] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Fix build on Windows.

  • plugins/win/PluginViewWin.cpp: (windowHandleForPageClient):
04:17 Changeset [49771] by zecke@webkit.org
  • 5 edits
    2 adds in trunk

Windowed Plugins: Don't crash when client is 0.

Client is 0 when we use QWebPage without a QWebView or QGraphicsWebView.
In addition, setFrameRect()/updatePluginWidget() is called even if the
plugin was not succesfully loaded. updatePluginWidget() updates the
window rect which is, in theory, useful to draw something that indicates
that we didn't load successfully.

So, a status check is added to setNPWindowIfNeeded.

03:44 Changeset [49770] by eric@webkit.org
  • 7 edits in trunk

2009-10-19 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Holger Freyther.

[Qt] Windowed Plugins: Fix crash when QWebPage is deleted after QWebView.

Fixes various sources of crashes:

  1. The PluginContainer is a child of QWebView. When the view gets deleted, the PluginView is not notified about the deletion of PluginContainer.
  2. QWebView destructor does not set client to 0.
  3. Sometimes pending paint events are sent after the plugin has died, so add a check in PluginView::setNPWindowIfNeeded.

https://bugs.webkit.org/show_bug.cgi?id=30354

  • plugins/qt/PluginContainerQt.cpp: (PluginContainerQt::~PluginContainerQt):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):

2009-10-19 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Holger Freyther.

[Qt] Windowed Plugins: Fix crash when QWebPage is deleted after QWebView.

Fixes various sources of crashes:

  1. The PluginContainer is a child of QWebView. When the view gets deleted, the PluginView is not notified about the deletion of PluginContainer.
  2. QWebView destructor does not set client to 0.
  3. Sometimes pending paint events are sent after the plugin has died, so add a check in PluginView::setNPWindowIfNeeded.

https://bugs.webkit.org/show_bug.cgi?id=30354

  • Api/qwebview.cpp: (QWebView::~QWebView):
  • tests/qwebview/qwebview.pro:
  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::reusePage_data): (tst_QWebView::reusePage):
00:17 Changeset [49769] by eric@webkit.org
  • 7 edits in trunk

2009-10-19 Jakob Truelsen <antialize@gmail.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=29042
Allow one to customize the minimal and maximal shrink factors used when printing.

  • page/PrintContext.cpp: (WebCore::PrintContext::begin):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setPrintingMinimumShrinkFactor): (WebCore::Settings::setPrintingMaximumShrinkFactor):
  • page/Settings.h: (WebCore::Settings::printingMinimumShrinkFactor): (WebCore::Settings::printingMaximumShrinkFactor):

2009-10-19 Jakob Truelsen <antialize@gmail.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=29042

Allow one to costumize the minimal and maximal shrink factors,
Added methods setPrintingMinimumShrinkFactor, printingMinimumShrinkFactor,
setPrintingMaximumShrinkFactor, printingMaximumShrinkFactor to QWebSettings.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings): (QWebSettings::setPrintingMinimumShrinkFactor): (QWebSettings::printingMinimumShrinkFactor): (QWebSettings::setPrintingMaximumShrinkFactor): (QWebSettings::printingMaximumShrinkFactor):
  • Api/qwebsettings.h:
00:04 Changeset [49768] by abarth@webkit.org
  • 1 edit in trunk/WebKit/qt/ChangeLog

Fix ChangeLog spelling.

10/18/09:

23:59 Changeset [49767] by eric@webkit.org
  • 3 edits
    10 adds in trunk

2009-10-18 Erik Arvidsson <arv@chromium.org>

Reviewed by Adam Barth.

Fixes issue where doubleclicking a word could select following adjacent newlines.
https://bugs.webkit.org/show_bug.cgi?id=30234

  • platform/mac/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
  • platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
  • platform/mac/editing/selection/script-tests/TEMPLATE.html: Added.
  • platform/mac/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added. (description.doubleClickOnElement): (doubleClickAt): (selectionShouldBe):
  • platform/win/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
  • platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
  • platform/win/editing/selection/script-tests/TEMPLATE.html: Added.
  • platform/win/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added. (description.doubleClickOnElement): (doubleClickAt): (selectionShouldBe):

2009-10-18 Erik Arvidsson <arv@chromium.org>

Reviewed by Adam Barth.

Fixes issue where doubleclicking a word could select following adjacent newlines.
https://bugs.webkit.org/show_bug.cgi?id=30234

Tests: platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html

platform/mac/editing/selection/script-tests/TEMPLATE.html
platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html
platform/win/editing/selection/script-tests/TEMPLATE.html

  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::appendTrailingWhitespace):
23:51 Changeset [49766] by eric@webkit.org
  • 7 edits in trunk

2009-10-18 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

Rename fixedContentsSize property to preferredContentsSize as
agreed upon with Siman Hausmann and Matthias Ettrich.

  • Api/qwebpage.cpp: (QWebPage::preferredContentsSize): (QWebPage::setPreferredContentsSize):
  • Api/qwebpage.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

2009-10-18 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

Use the setPreferredContentsSize method instead
of setFixedContentsSize, as the method has been renamed.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setFixedContentsSize):
23:50 QtBackLog edited by zecke@selfish.org
(diff)
23:46 QtBackLog edited by zecke@selfish.org
Move QtWebKit problems into a table. (diff)
23:43 Changeset [49765] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-10-18 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Use _stricmp and _strnicmp instead of deprecated stricmp and strnicmp.
https://bugs.webkit.org/show_bug.cgi?id=30474

stricmp and strnicmp are deprecated beginning in Visual
C++ 2005. Use _stricmp and _strnicmp instead in StringExtras.h.

  • wtf/StringExtras.h: (strncasecmp): (strcasecmp):
23:42 QtBackLog edited by zecke@selfish.org
Change Qt items into a table (diff)
23:34 QtBackLog edited by zecke@selfish.org
Add completed items to the bottom (diff)
20:53 Changeset [49764] by kevino@webkit.org
  • 2 edits in trunk/WebCore

CURL build fix, use proper header name.

19:38 Changeset [49763] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/7309062> Crashes in WebCore::DocumentLoader::isStopping below WebKit::NetscapePluginInstanceProxy::loadRequest.

Reviewed by Dan Bernstein.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::loadRequest): Null-check the DocumentLoader before deferencing it.

19:09 Changeset [49762] by pfeldman@chromium.org
  • 9 edits in trunk

2009-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Properties on Arrays and NodeLists are not logged correctly.

https://bugs.webkit.org/show_bug.cgi?id=30485

WebCore:

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._formatarray): (WebInspector.ConsoleView.prototype._printArray):

LayoutTests:

  • inspector/console-format-expected.txt:
  • inspector/console-format.html:
18:20 Changeset [49761] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-18 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: touching WebCore so that it
initiated inspector frontend deployment on Windows.

Web Inspector: frontend files are not deployed in Windows
incremental build.

  • inspector/InspectorDOMAgent.cpp:
17:20 Changeset [49760] by pfeldman@chromium.org
  • 6 edits
    6 adds in trunk/LayoutTests

2009-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make console tests more granular.

https://bugs.webkit.org/show_bug.cgi?id=30496

  • inspector/console-dir-expected.txt: Added.
  • inspector/console-dir.html: Added.
  • inspector/console-dirxml-expected.txt: Added.
  • inspector/console-dirxml.html: Added.
  • inspector/console-format-expected.txt: Added.
  • inspector/console-format.html: Added.
  • inspector/console-tests-expected.txt:
  • inspector/console-tests.html:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
16:48 Changeset [49759] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

16:17 Changeset [49758] by pfeldman@chromium.org
  • 4 edits in trunk

2009-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Title of dir(["test", "test2"]) should be Array

https://bugs.webkit.org/show_bug.cgi?id=30486

Test: inspector/console-tests.html

  • inspector/front-end/InjectedScript.js:
14:15 Changeset [49757] by krit@webkit.org
  • 9 edits in trunk

2009-10-18 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

REGRESSION: SVG Mask doesn't work for maskContentUnits="objectBoundingBox"
https://bugs.webkit.org/show_bug.cgi?id=30480

Patch for SVGMaskElement landed in r49598 should correct the location of
the mask image graphics context. It only corrects the location for userSpaceOnUse
mode in maskContentUnits but breaks objectBoundingBoxMode.
The maskDestRect shouldn't be moved. It is not responsible for the correct context
postioin but for the correct position of the mask image.
This patch calculates the context postion independently from the maskDestRect.
It also uses lineareRGB color space for masking on CG now. This is the default
color space for masking operations.
We already have tests for both maskContentUnits modes.

*svg/W3C-SVG-1.1/masking-intro-01-f.svg
*svg/custom/mask-with-default-value.svg

Some tests needed new pixel tests because of the new color space.

  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):

The color space of masking operations in SVG changed to linearSVG.
This needs an update of some masking pixel tests.

  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.checksum:
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
12:55 Changeset [49756] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-18 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Use v8::Integer::NewFromUnsigned when converting unsigneds into V8's numbers.
That is notably faster for small numbers (most common case).
https://bugs.webkit.org/show_bug.cgi?id=30493

  • bindings/scripts/CodeGeneratorV8.pm:
12:29 Changeset [49755] by jmalonzo@webkit.org
  • 5 edits
    5 adds in trunk

2009-10-18 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[GTK] Add MathML to the build system
https://bugs.webkit.org/show_bug.cgi?id=30487

Add --enable-mathml to configure.

  • configure.ac:

Add MathML sources if MathML support is enabled.

  • GNUmakefile.am:

Include layout test baseline for Gtk.

  • platform/gtk/mathml/presentation/sub-expected.txt: Added.
  • platform/gtk/mathml/presentation/sup-expected.txt: Added.
  • platform/gtk/mathml/presentation/tables-expected.txt: Added.
11:21 Changeset [49754] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Non-PCH build fix. Added missing header.

10:17 Changeset [49753] by simon.fraser@apple.com
  • 7 edits
    4 adds in trunk

2009-10-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Compositing layers not correctly updated after partial layout
https://bugs.webkit.org/show_bug.cgi?id=30425

When a partial layout happened, for example as the result of a postion-change-only
layout, then some compositing layer positions were not correctly updated. To fix
this, updateLayerPositions() now carries along a flag that is set at the rootmost
layer being updated, and used to determine when we hit the first compositing layer
in this update. RenderLayerBacking::updateAfterLayout() makes use of this information
to do a full geometry update on that layer, which is thus the rootmost compositing
layer that is being updated.

Test: compositing/geometry/partial-layout-update.html

  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::scrollToOffset):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout):
  • rendering/RenderLayerBacking.h:
10:02 Changeset [49752] by kevino@webkit.org
  • 6 edits in trunk

Reviewed by Kevin Ollivier.

Add the ability to specify a proxy for wxWebKit.

https://bugs.webkit.org/show_bug.cgi?id=30446

09:23 Changeset [49751] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-18 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez

https://bugs.webkit.org/show_bug.cgi?id=25901
Use ATK_ROLE_SECTION for divTag and ATK_ROLE_LABEL for labelTag

Replaces the use of ATK_ROLE_PANEL with the expected accessible roles.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
09:08 Changeset [49750] by kevino@webkit.org
  • 4 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Add basic database support to wx API

https://bugs.webkit.org/show_bug.cgi?id=30445

09:00 Changeset [49749] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2009-10-18 Eric Carlson <eric.carlson@apple.com>

Skip media/video-empty-source.html until <rdar://problem/6563117> has been fixed.

  • platform/mac/Skipped:
07:50 QtBackLog edited by zecke@selfish.org
(diff)
02:35 QtWebKitPlugins edited by girish@forwardbias.in
(diff)
Note: See TracTimeline for information about the timeline view.