Timeline


and

10/26/09:

21:48 Changeset [50130] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-26 Eric Seidel <eric@webkit.org>

No review, just adding Mike Belshe to the committers list.

  • Scripts/modules/committers.py:
21:48 Changeset [50129] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

21:47 Changeset [50128] by mrowe@apple.com
  • 1 copy in tags/Safari-532.3

New tag.

20:57 Changeset [50127] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/WebCore

2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed.

[Qt] Build fix for QtWebKit after r50125.

  • WebCore.pro: Rename TimelineItem to TimelineRecord.
20:38 Changeset [50126] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-26 Matt Mueller <mattm@chromium.org>

Reviewed by Darin Adler.

Refactor synchronizable property handling to store one shouldSynchronize flag per set of properties rather than one per property.

Fixes reading uninitialized memory in SynchronizableProperty hash function as well as simplifying the code.

https://bugs.webkit.org/show_bug.cgi?id=30658

Covered by running various svg tests under valgrind, ex:
LayoutTests/svg/custom/js-late-mask-and-object-creation.svg

  • svg/SynchronizablePropertyController.cpp: (WebCore::SynchronizableProperties::addProperty): (WebCore::SynchronizableProperties::synchronize): (WebCore::SynchronizableProperties::startAnimation): (WebCore::SynchronizableProperties::stopAnimation): (WebCore::SynchronizablePropertyController::registerProperty): (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization): (WebCore::SynchronizablePropertyController::synchronizeProperty): (WebCore::SynchronizablePropertyController::synchronizeAllProperties): (WebCore::SynchronizablePropertyController::startAnimation): (WebCore::SynchronizablePropertyController::stopAnimation):
  • svg/SynchronizablePropertyController.h: (WebCore::SynchronizableProperties::SynchronizableProperties): (WebCore::SynchronizableProperties::setNeedsSynchronization):
20:24 Changeset [50125] by eric@webkit.org
  • 11 edits
    2 moves in trunk/WebCore

2009-10-26 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Renames TimelineItem to TimelineRecord and updates all call sites.
https://bugs.webkit.org/show_bug.cgi?id=30785

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addRecordToTimeline):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willFireTimer): (WebCore::InspectorTimelineAgent::didFireTimer): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
  • inspector/InspectorTimelineAgent.h: (WebCore::): (WebCore::InspectorTimelineAgent::RecordEntry::RecordEntry):
  • inspector/TimelineItemFactory.cpp: Removed.
  • inspector/TimelineItemFactory.h: Removed.
  • inspector/TimelineRecordFactory.cpp: Added. (WebCore::TimelineRecordFactory::createGenericRecord): (WebCore::TimelineRecordFactory::createDOMDispatchRecord): (WebCore::TimelineRecordFactory::createGenericTimerRecord): (WebCore::TimelineRecordFactory::createTimerInstallRecord):
  • inspector/TimelineRecordFactory.h: Added. (WebCore::TimelineRecordFactory::TimelineRecordFactory):
  • inspector/front-end/TimelineAgent.js: (WebInspector.addRecordToTimeline):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype.getRecordTypeName): (WebInspector.TimelineRecordTreeElement.prototype.onattach):
19:56 Changeset [50124] by zecke@webkit.org
  • 1 edit in trunk/WebCore/plugins/qt/PluginViewQt.cpp

Unreviewed spelling fix in the PluginViewQt.cpp

This error was pointed out in the bug report and it was agreed to
do the spelling fix when landing the patch. Fix it now.

19:50 Changeset [50123] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-26 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Antti Koivisto.

[Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled

When printing, QPrinter's preview mode uses a QPicture to capture the output. The
QPicture holds a reference to the X Pixmap. As a result, the print preview would
update itself when the X Pixmap changes. To prevent the print preview from updating
whenever m_drawable is updated (i.e when the view updates), we create a copy.

We require that a QPixmap::copy() result in a QPixmap backed by a XPixmap
regardless of the graphicssystem. This is taken care of by
commit d310f7c710ecb331a9689861f0551eabd38e946e in Qt (4.6)

The beauty of this patch is that the newly created X Pixmap is managed by Qt and
it will free the Pixmap whenever the user closes the print preview dialog and
handles the case of displaying multiple preview dialogs nicely.

All credit to Samuel Rødal for suggesting usage of QPixmap::copy().

https://bugs.webkit.org/show_bug.cgi?id=30714

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint):
19:42 Changeset [50122] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-26 Benjamin Otte <otte@gnome.org>

Reviewed by Gustavo Noronha.

Don't store properties in the MediaPlayerPrivate class

Access them via the MediaPlayer class instead.
https://bugs.webkit.org/show_bug.cgi?id=30462

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
19:27 Changeset [50121] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Fixes <http://webkit.org/b/30801>.
Web Inspector: Control + ]/[ on Windows doesn't change Panels.

Reviewed by Timothy Hatcher.

In my testing, Windows uses "U+00DB" and "U+00DD" to represent
[ and ], so we should honor those as well.

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

19:10 Changeset [50120] by laszlo.1.gombos@nokia.com
  • 9 edits in trunk

2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

Make .rc files compile on Windows without depending on MFC headers
https://bugs.webkit.org/show_bug.cgi?id=30750

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc: Use winresrc.h because it exists even when MFC is not installed, and is all that's needed here.
  • WebCore.vcproj/QTMovieWin.rc: Ditto.
  • WebKit.vcproj/WebKit.rc: Ditto.
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use windows.h instead of afxres.h because it exists even when MFC is not installed, and is all that's needed here.
  • FindSafari/FindSafari.rc: Ditto
18:56 Changeset [50119] by bweinstein@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed - Updating getComputedStyle results for Windows.

Updating getComputedStyle results for Windows.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
18:09 Changeset [50118] by bfulgham@webkit.org
  • 4 edits in trunk/WebCore

Build corrections for ENABLE_FILTERS in Windows.
https://bugs.webkit.org/show_bug.cgi?id=30797

Reviewed by Darin Adler.

Build correction for ENABLE_FILTERS feature. No new tests needed.

  • platform/graphics/filters/FEColorMatrix.cpp: Use MathExtras.h and its piDouble constant.
  • platform/graphics/filters/FEGaussianBlur.cpp: Use MathExtras.h and its piDouble constant. Remove unnecessary call to floor used in the division of an unsigned, converting to int.
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: Correct include style for MathExtras.h.
18:04 WikiStart edited by timothy@apple.com
Remove some other old pages. (diff)
18:01 WikiStart edited by timothy@apple.com
Remove some old pages for Developer Tools. (diff)
17:53 Changeset [50117] by mitz@apple.com
  • 2 edits in trunk/WebKitSite

Updated BSD License

Reviewed by Adele Peterson.

  • coding/bsd-license.html: Updated to the latest version.
17:19 Changeset [50116] by beidson@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/7289467> and http://webkit.org/b/30798 - REGRESSION (r48687): www.myuhc.com doesn't load.

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/grandparent-completion-starts-redirect.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::completed): Notify all descendants that the load completed, not just direct children.

LayoutTests:

  • fast/loader/grandparent-completion-starts-redirect-expected.txt: Added.
  • fast/loader/grandparent-completion-starts-redirect.html: Added.
  • fast/loader/resources/meta-redirect-to-notify-done.html: Added.
  • fast/loader/resources/parent-of-redirect.html: Added.
16:56 Changeset [50115] by mitz@apple.com
  • 4 edits in trunk

WebCore: Re-add CSSPropertyWebkitBackgroundSize in one more place

Reviewed by Beth Dakin.

Fixes transitions/multiple-background-size-transitions.html, transitions/background-transitions.html

  • page/animation/AnimationBase.cpp:

(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):

LayoutTests: Use -webkit-background-size as the transition property in this test now
that it is distinct from background-size.

Reviewed by Sam Weinig.

  • transitions/multiple-background-size-transitions.html:
16:56 Changeset [50114] by mrowe@apple.com
  • 2 edits in trunk/WebKitLibraries

Clean up the regex madness in auto-version.sh to make it obvious what the script is doing.

Reviewed by Adam Roben.

Also teaches auto-version.sh to handle RC_PROJECTSOURCEVERSION that has more than three digits
in the major component of the version number.

  • win/tools/scripts/auto-version.sh:
16:44 Changeset [50113] by jorlow@chromium.org
  • 6 edits in trunk/WebCore

2009-10-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Tidy up the DOM Storage runtime flag stuff
https://bugs.webkit.org/show_bug.cgi?id=30794

Clean up the DOM Storage runtime flag stuff to match the new way of doing
things. No behavioral changes.

  • bindings/v8/RuntimeEnabledFeatures.cpp:
  • bindings/v8/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setDatabaseEnabled): (WebCore::RuntimeEnabledFeatures::databaseEnabled): (WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled): (WebCore::RuntimeEnabledFeatures::localStorageEnabled): (WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled): (WebCore::RuntimeEnabledFeatures::sessionStorageEnabled):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
  • storage/Storage.cpp:
  • storage/Storage.h:
16:27 Changeset [50112] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Beth Dakin.

Update expedted results after r50108.

  • svg/css/getComputedStyle-basic-expected.txt:
16:20 Changeset [50111] by beidson@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/7308952> and http://webkit.org/b/30424 - REGRESSION (r48687): Pages on ucas.com appear blank.

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/history-forward-in-head.html

  • loader/RedirectScheduler.cpp:

(WebCore::RedirectScheduler::scheduleHistoryNavigation): Restore the moved canGoBackOrForward() check.

This restores the side effect of an invalid history navigation canceling previous scheduled redirects
and also fixes the bug of scheduling an invalid history navigation canceling parsing of the current document.

(WebCore::RedirectScheduler::timerFired): Removed the canGoBackOrForward() check as it is now made before

the redirect is scheduled.

LayoutTests:

  • fast/loader/history-forward-in-head-expected.txt: Added.
  • fast/loader/history-forward-in-head.html: Added.
16:11 Changeset [50110] by ap@apple.com
  • 6 edits
    4 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30049
<rdar://problem/7286002> Manipulating DOM from a script while parsing XHTML can cause a crash

Tests: fast/parser/remove-current-node-parent-x-2.xhtml

fast/parser/remove-current-node-parent-x.xhtml

  • dom/XMLTokenizer.h: Store the whole stack of parent nodes - element.parentNode() is unreliable after DOM manipulation.
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::pushCurrentNode): Push the new node onto stack. (WebCore::XMLTokenizer::popCurrentNode): This is now called instead of setCurrentNode when exiting a node. (WebCore::XMLTokenizer::clearCurrentNodeStack): We're aborting; or just done parsing. This replaces setCurrentNode(0). (WebCore::XMLTokenizer::enterText): Call pushCurrentNode(). (WebCore::XMLTokenizer::exitText): Call popCurrentNode(), removing a long-standing FIXME (not sure if it was ever practical though - how can a parent become null while adding text?)
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::~XMLTokenizer): Call clearCurrentNodeStack(). (WebCore::XMLTokenizer::startElementNs): Call pushCurrentNode(). (WebCore::XMLTokenizer::endElementNs): Call popCurrentNode() to safely get to a parent. Also added a check fo script element still being in document - Firefox parses those that aren't, but doesn't execute them.
  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::~XMLTokenizer): (WebCore::XMLTokenizer::parseStartElement): (WebCore::XMLTokenizer::parseEndElement): Match libxml2 version changes.
15:49 Changeset [50109] by eric@webkit.org
  • 8 edits in trunk/JavaScriptCore

2009-10-26 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

The thunkReturnAddress is on JITStackFrame on ARM JIT as well
https://bugs.webkit.org/show_bug.cgi?id=30782

Move the thunkReturnAddress from top of the stack into the JITStackFrame
structure. This is a requirement for JSValue32_64 support on ARM.

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::ret): Return with link register (JSC::MacroAssemblerARM::prepareCall): Store the return address in link register
  • jit/JIT.h: Remove unused ctiReturnRegister
  • jit/JITInlineMethods.h: Same as ARMv7 (JSC::JIT::restoreArgumentReference): Ditto. (JSC::JIT::restoreArgumentReferenceForTrampoline): Ditto.
  • jit/JITOpcodes.cpp: Remove ctiReturnRegister related instruction
  • jit/JITStubs.cpp: Store thunkReturnAddress on JITStackFrame. Use small trampoline functions which handle return addresses for each CTI_STUB_FUNCTION.
  • jit/JITStubs.h: Store thunkReturnAddress on JITStackFrame (JSC::JITStackFrame::returnAddressSlot): Return with the address of thunkReturnAddress
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): Remove the unnecessary instruction
15:41 Changeset [50108] by mitz@apple.com
  • 13 edits in trunk

background-size: X treated as background-size: X X, not background-size: X auto
https://bugs.webkit.org/show_bug.cgi?id=28440

Reviewed by Beth Dakin.

WebCore:

Updated fast/backgrounds/size/resources/parsing-background-size-values.js
and fast/backgrounds/size/resources/parsing-inherit.js

Reinstated -webkit-background-size and kept its behavior of filling in
the second value with the first one; and changed background-size to have
the behavior of filling in the second value with 'auto'.

  • css/CSSComputedStyleDeclaration.cpp:

(computedProperties): Re-added CSSPropertyWebkitBackgroundSize.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Ditto.
(WebCore::CSSParser::parseFillSize): Adapted for the new parsing rule.
(WebCore::CSSParser::parseFillProperty): Re-added
CSSPropertyWebkitBackgroundSize.
(WebCore::cssPropertyID): Removed mapping of -webkit-background-size to
background-size.

  • css/CSSParser.h:
  • css/CSSPropertyNames.in: Re-added -webkit-background-size.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Re-added
CSSPropertyWebkitBackgroundSize.

LayoutTests:

  • fast/backgrounds/size/parsing-background-size-values-expected.txt:
  • fast/backgrounds/size/parsing-inherit-expected.txt:
  • fast/backgrounds/size/resources/parsing-background-size-values.js:

(test):

  • fast/backgrounds/size/resources/parsing-inherit.js:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
15:41 Changeset [50107] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-10-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool post-diff should know how to mark commit-queue=?
https://bugs.webkit.org/show_bug.cgi?id=29202

  • Scripts/bugzilla-tool:
    • Add --commit-queue option to post-diff, post-commits and create-bug.
  • Scripts/modules/bugzilla.py:
    • Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
    • Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
15:37 Changeset [50106] by weinig@apple.com
  • 5 edits
    1 add in trunk/WebKit

Move some WebView event handling code into its own file, WebViewEventHandling.mm

Reviewed by Anders Carlsson.

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _close]):
(-[WebView _selectedOrMainFrame]):

  • WebView/WebViewEventHandling.mm: Added.

(-[WebView _closingEventHandling]):
(-[WebView _setMouseDownEvent:]):
(-[WebView mouseDown:]):
(-[WebView mouseUp:]):
(+[WebView _updateMouseoverWithEvent:]):
(-[WebView _updateMouseoverWithFakeEvent]):
(_updateMouseoverWithEvent:fakeEvent::if):
(-[WebView _stopAutoscrollTimer]):
(-[WebView _setToolTip:]):

  • WebView/WebViewInternal.h:
15:34 Changeset [50105] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool commit-queue does not notice modifications to committers.py
https://bugs.webkit.org/show_bug.cgi?id=30084

  • Scripts/bugzilla-tool:
    • Make commit-queue re-exec itself instead of using while(1).
    • Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
    • Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
15:32 Changeset [50104] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue will get stuck on patches if land-patches terminates unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=30634

  • Scripts/bugzilla-tool:
    • Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
    • Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
15:22 Changeset [50103] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Use "%lli" to format "long long" on WIN_OS to fix HTML5 WebDB crash
https://bugs.webkit.org/show_bug.cgi?id=30777

No new tests as the crash can be reproduced by existing storage
LayoutTests (by hitting an assert in debug mode Webkit on WIN_OS).

  • platform/text/String.cpp: (WebCore::String::number): Qt's QString::vsprintf does not understand the "%I64u" format string. Always use the "%lli" format string for Qt port.
15:10 Changeset [50102] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2009-10-26 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.

https://bugs.webkit.org/show_bug.cgi?id=30763

  • pywebsocket/mod_pywebsocket/init.py:
  • pywebsocket/mod_pywebsocket/dispatch.py:
  • pywebsocket/mod_pywebsocket/headerparserhandler.py:
  • pywebsocket/mod_pywebsocket/standalone.py:
  • pywebsocket/setup.py:
  • pywebsocket/test/test_dispatch.py:
15:04 Changeset [50101] by tony@chromium.org
  • 6 edits in trunk/WebCore

2009-10-26 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Roll back r50073 because r50041-50043 were reverted. r50073 was
a chromium side fix for r50041.
https://bugs.webkit.org/show_bug.cgi?id=30789

  • bindings/v8/V8Collection.h:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
15:02 Changeset [50100] by ggaren@apple.com
  • 5 edits
    3 adds in trunk

WebCore: Fixed https://bugs.webkit.org/show_bug.cgi?id=30765
REGRESSION (r48701): Removing an event listener causes the one added just after it not to fire

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-26
Reviewed by Dimitri Glazkov.

and related bugs.

If the event listener being removed is prior to the current firing event
iterator, we need to decrement the current firing event iterator in
addition to the endpoint. (Otherwise, shrinking the event listener vector
by one implicity moves the current firing event iterator forward by one.
It's like relativity, only without the planets.)

Also took the opportunity to change some pointers to references, since
they can't be null.

  • dom/EventTarget.cpp:

(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::removeAllEventListeners): Update iterator in addition
to end, if need be.
(WebCore::EventTarget::fireEventListeners): Updated for interface changes.
Added a comment to explain a behavior that was implicit enough to be
confusing.

  • dom/EventTarget.h:

(WebCore::FiringEventIterator::FiringEventIterator):
(WebCore::EventTarget::isFiringEventListeners): Updated for interface changes.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=30765
REGRESSION (r48701): Removing an event listener causes one added after it to not fire

Patch by Dimitri Glazkov <dglazkov@chromium.org> on 2009-10-26
Reviewed by Geoffrey Garen.

  • fast/events/event-listener-list-mutation-expected.txt: Added.
  • fast/events/event-listener-list-mutation.html: Added.
  • fast/events/script-tests/event-listener-list-mutation.js: Added.

(TestMutation.listeners):
(TestMutation.mutateList):

14:52 Changeset [50099] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Unreviewed documentation fix from David Boddie (Qt Doc Team)

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
Removes the check around the RenderHints property documentation
that was clearly added to synchronize the source and header files
when the #if !defined(Q_OS_SYMBIAN) guards was added to the
property.

The documentation has also been updated to ensure that Symbian
users know that there is no actual RenderHints property on their
platform.

  • Api/qwebview.cpp:
14:50 Changeset [50098] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Fixes <http://webkit.org/b/30792>.
Web Inspector: When changing resource scope, resource graph can get in weird state.

Reviewed by Timothy Hatcher.

If the user was scrolled down while looking at All resources, and then just
selects Fonts, or something that doesn't have many resources, then the graph
will stay scrolled down, even when there is no content there.

When the filter is updated, scroll to the top of the graph view, so this won't
happen.

  • inspector/front-end/AbstractTimelinePanel.js:

(WebInspector.AbstractTimelinePanel.prototype._updateFilter):

14:46 Changeset [50097] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix mac clean build.

  • html/HTMLOptionsCollection.idl:
14:42 Changeset [50096] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Unreviewed documentation fix from David Boddie (Qt Doc Team)

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
Ensure that qdoc will always see the RenderHints property.

The property was only defined in the header file if the Q_OS_SYMBIAN
symbol was not defined, resulting in the property not showing up
in the Qt documentation just because one platform doesn't support it.

A follow up commit will improve the documentation for the property
and note that it is not supported on the Symbiam platform.

  • Api/qwebview.h:
14:35 Changeset [50095] by pfeldman@chromium.org
  • 9 edits
    1 add in trunk/WebCore

2009-10-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Extract AbstractTimelinePanel that will be a base
class for ResourcesPanel and TimelinePanel.

https://bugs.webkit.org/show_bug.cgi?id=30776

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/AbstractTimelinePanel.js: Added. (WebInspector.AbstractTimelinePanel): (WebInspector.AbstractTimelinePanel.prototype.get categories): (WebInspector.AbstractTimelinePanel.prototype.showCategory): (WebInspector.AbstractTimelinePanel.prototype.hideCategory): (WebInspector.AbstractTimelinePanel.prototype.createTimelinePanels): (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel.createFilterElement): (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel): (WebInspector.AbstractTimelinePanel.prototype.filter): (WebInspector.AbstractTimelinePanel.prototype._updateFilter): (WebInspector.AbstractTimelinePanel.prototype._createGraph): (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded): (WebInspector.AbstractTimelinePanel.prototype._updateSummaryGraph): (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition): (WebInspector.AbstractTimelinePanel.prototype.get needsRefresh): (WebInspector.AbstractTimelinePanel.prototype.set needsRefresh): (WebInspector.AbstractTimelinePanel.prototype.refreshIfNeeded): (WebInspector.AbstractTimelinePanel.prototype.show): (WebInspector.AbstractTimelinePanel.prototype.resize): (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.computeSummaryValues): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels): (WebInspector.TimelineCalculator.prototype.get boundarySpan): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.reset): (WebInspector.TimelineCalculator.prototype._value): (WebInspector.TimelineCalculator.prototype.formatValue):
  • inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.ResourcesPanel.prototype.get statusBarItems): (WebInspector.ResourcesPanel.prototype.get categories): (WebInspector.ResourcesPanel.prototype.showCategory): (WebInspector.ResourcesPanel.prototype.hideCategory): (WebInspector.ResourcesPanel.prototype.isCategoryVisible): (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourcesPanel.prototype.createPanelEnabler): (WebInspector.ResourcesPanel.prototype.createStatusbarButtons): (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime): (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime): (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.resize): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded): (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): (WebInspector.ResourceTimeCalculator): (WebInspector.ResourceTransferSizeCalculator): (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels):
  • inspector/front-end/SummaryBar.js: (WebInspector.SummaryBar.prototype.update):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded):
14:09 Changeset [50094] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-26 Avi Drissman <avi@google.com>

Reviewed by Darin Adler.

Use Helvetica in the Inspector as intended.
https://bugs.webkit.org/show_bug.cgi?id=30787

  • inspector/front-end/inspector.css:
14:05 Changeset [50093] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-26 Xan Lopez <xlopez@igalia.com>

Skip test fast/loader/opaque-base-url.html with a reference to the
bug tracking it, https://bugs.webkit.org/show_bug.cgi?id=30724

  • platform/gtk/Skipped:
14:02 Changeset [50092] by eric@webkit.org
  • 5 edits in trunk

2009-10-26 Nate Chapin <japhet@chromium.org>

Reviewed by Alexey Proskuryakov.

Update no-referrer-reset for https://bugs.webkit.org/show_bug.cgi?id=30781.

  • http/tests/navigation/no-referrer-reset-expected.txt: Expect window.opener to still be set.
  • http/tests/navigation/no-referrer-reset.html: Update text to reflect what the test actually does.

2009-10-26 Nate Chapin <japhet@chromium.org>

Reviewed by Alexey Proskuryakov.

Don't set window.opener to 0 for the current FrameLoader if a noreferrer link was clicked, only suppress opener in a new frame.
https://bugs.webkit.org/show_bug.cgi?id=30781

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): Don't suppress opener in the current frame for noreferrer navigations.
13:53 Changeset [50091] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-26 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Levin.

REGRESSION: 2 failures in run-webkit-unittests
https://bugs.webkit.org/show_bug.cgi?id=30645

  • Scripts/modules/cpp_style_unittest.py: Fixed a few test scenarios which apparently lost some spaces from text literals.
13:48 Changeset [50090] by rniwa@webkit.org
  • 3 edits
    3 adds in trunk

Data loss occurs when unbolding nested bold tags.
https://bugs.webkit.org/show_bug.cgi?id=30083

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-26
Reviewed by Eric Seidel.

WebCore:

Fixes the loop in swapInNodePreservingAttributesAndChildren by saving nextSibling() of child
to a temporary valuable. It was originally calling nextSibling() after appending the child
to new parent, in which case, nextSibling is always 0.

Test: editing/style/unbolding-nested-b.html

  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

LayoutTests:

Adds a test to make sure WebKit can remove nested b, i, & s tags properly
without loosing the content of inner elements.

  • editing/style/remove-nested-inline-styles-expected.txt: Added.
  • editing/style/remove-nested-inline-styles.html: Added.
  • editing/style/script-tests/remove-nested-inline-styles.js: Added.

(removeStyleAndExpect):

13:16 Changeset [50089] by kov@webkit.org
  • 2 edits in trunk

Reviewed by Jan Alonzo.

Alternative solution to regression introduced in r48672.

13:11 Changeset [50088] by jorlow@chromium.org
  • 4 edits
    3 adds in trunk

2009-10-21 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Storage events should use Document::url() rather than documentURI()
https://bugs.webkit.org/show_bug.cgi?id=30535

Storage events should use Document::url() rather than Document::documentURI()
per http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html

Test: storage/domstorage/documentURI.html

  • storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):

2009-10-26 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Adler.

Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
inherit from HTMLCollection.

  • fast/dom/wrapper-classes-expected.txt:
13:04 Changeset [50087] by weinig@apple.com
  • 19 edits
    1 delete in trunk

Rubber-stamped by Darin Adler.

Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
inherit from HTMLCollection.

WebCore:

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):
(WebCore::toJS):

  • bindings/js/JSHTMLCollectionFunctions.h: Removed.
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::length):
(WebCore::JSHTMLOptionsCollection::indexSetter):

  • bindings/objc/DOMHTML.mm:

(kitClass):

  • bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLCollection.idl:
  • html/HTMLOptionsCollection.idl:

WebKit/win:

  • DOMCreateInstance.cpp:

LayoutTests:

  • fast/dom/wrapper-classes-expected.txt:
12:46 Changeset [50086] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.

12:34 Changeset [50085] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

Build fix for ENABLE_FILTERS under Windows.
https://bugs.webkit.org/show_bug.cgi?id=30762

Reviewed by Adam Roben.

Build correction for ENABLE_FILTERS feature. No new tests needed.

  • WebCore.vcproj/WebCore.vcproj: Make the following changes: (1) Create a new 'filters' sub-folder of the platform/graphics

folder to properly show the sources held in this directory.

(2) Move the files that are currently shown in svn/graphics/filters

to platform/graphics/filters (where they actually live on disk).

(3) Add the missing SVGFilter, SVGFilterBuilder, and SVGFETile to

the project so they are built.

(4) Remove SVGFEFloodElement.cpp from the build, since it is already

being compiled by SVGAllInOne.cpp. Its presence as a separate
entity is causing a linker warning for duplicate symbols.

(5) Add ImageBuffer.cpp to the build to support color space

calculations for non-CG builds.

  • WebCore.vcproj/WebCoreCommon.vsprops: Add the platform/graphics/filters path to the search paths in the project.
12:30 Changeset [50084] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-10-26 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

console.assert should prefix messages with "Assertion failed: "
https://bugs.webkit.org/show_bug.cgi?id=19135

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype.toMessageElement): Append "Assertion failed: " for AssertMessageType. (WebInspector.ConsoleMessage.prototype.toString):
  • page/Console.cpp: (WebCore::Console::assertCondition): Use AssertMessageType.
  • page/Console.h: (WebCore::MessageType): Added AssertMessageType.
12:19 Changeset [50083] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-10-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Eric Seidel.

Prevent crash when optgroup element is empty.

https://bugs.webkit.org/show_bug.cgi?id=30365

  • fast/forms/select-empty-optgroup-expected.txt: Added.
  • fast/forms/select-empty-optgroup.html: Added.

2009-10-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Eric Seidel.

Prevent crash when optgroup element is empty by adding a NULL check.

https://bugs.webkit.org/show_bug.cgi?id=30365

Test: fast/forms/select-empty-optgroup.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::appendFormData):
12:11 Changeset [50082] by tony@chromium.org
  • 3 edits in trunk/WebCore

2009-10-21 Steven Knight <sgk@chromium.org>

Reviewed by David Levin.

Refactor gyp for separate webcore_bindings{,_sources} targets.

https://bugs.webkit.org/show_bug.cgi?id=30447

Handle long link lines by building .idl-generated bindings in a
separate webcore_bindings library target. Avoid Visual Studio
dependency issues by building additional generated .cpp and .h files
in a separate webcore_bindings_sources target.

Chrome should still build and test successfully.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:10 Changeset [50081] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.16

Tagging 1.1.16.

11:57 Changeset [50080] by ossy@webkit.org
  • 9 edits in trunk/WebKitTools

Unification of using null device in perl scripts.
https://bugs.webkit.org/show_bug.cgi?id=30572

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
Reviewed by Darin Adler.

  • Scripts/VCSUtils.pm:
  • Scripts/bisect-builds:
  • Scripts/resolve-ChangeLogs:
  • Scripts/run-iexploder-tests:
  • Scripts/run-jsc:
  • Scripts/run-mangleme-tests:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:

Using File::Spec->devnull() instead of hard coded /dev/null.

11:40 Changeset [50079] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2009-10-26 Mike Belshe <mike@belshe.com>

Reviewed by Darin Fisher.

Make the number of connections for chromium controlled by
chromium rather than by ResourceRequestBase.
https://bugs.webkit.org/show_bug.cgi?id=30661

  • platform/network/ResourceRequestBase.cpp:
  • platform/network/chromium/ResourceRequest.cpp:
11:38 Changeset [50078] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-26 Eric Seidel <eric@webkit.org>

Reviewed by Holger Freyther.

Reviewers are missing from committers.py
https://bugs.webkit.org/show_bug.cgi?id=30733

  • Scripts/modules/committers.py:
11:38 Web Inspector edited by casey.hattori@gmail.com
(diff)
11:33 Changeset [50077] by eric@webkit.org
  • 2 edits in trunk/BugsSite

2009-10-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

PrettyPatch should show images even when they have the wrong mime type
https://bugs.webkit.org/show_bug.cgi?id=29506

  • PrettyPatch/PrettyPatch.rb:
10:55 HackingGtk edited by kov@webkit.org
(diff)
10:54 Changeset [50076] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26

  • platform/qt/Skipped: shared-workers-close.html replaced with shared-worker-close.html
10:45 Changeset [50075] by kov@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed. make distcheck build fixes.

10:44 Changeset [50074] by kov@webkit.org
  • 2 edits in trunk

Unreviewed. Fix make dist regression introduced by r48672.

10:35 Changeset [50073] by eric@webkit.org
  • 6 edits in trunk/WebCore

2009-10-26 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Unbreak Chromium build: that requires adding custom implementations
for HTMLOptionsCollection's item and namedItem. Keep v8 binding
close to JSC bindings as well.
https://bugs.webkit.org/show_bug.cgi?id=30780

  • bindings/v8/V8Collection.h: (WebCore::getNamedItemsFromCollection): (WebCore::getItemFromCollection):
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
10:26 Changeset [50072] by ap@apple.com
  • 3 edits
    3 adds in trunk

Reviewed by Adam Barth and Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30723
<rdar://problem/6189415> Input names added to multipart/form-data headers need to be escaped.

Test: http/tests/security/escape-form-data-field-names.html

  • platform/network/FormDataBuilder.cpp: (WebCore::appendQuotedString): (WebCore::FormDataBuilder::beginMultiPartHeader): (WebCore::FormDataBuilder::addFilenameToMultiPartHeader): Percent-escape line breaks and quotation marks.
10:10 Changeset [50071] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip two flakey tests because of sporadic timeouts.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

  • platform/qt/Skipped:
10:06 Changeset [50070] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skipping two other tests because of missing features on our platform.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

  • platform/qt/Skipped:
10:00 Changeset [50069] by ossy@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] Add platform-dependent expected file for test added in r49875.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

  • platform/qt/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Added.
09:46 Changeset [50068] by eric@webkit.org
  • 8 edits in trunk/WebCore

2009-10-26 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Adds DOMTimer support to InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=30467

  • inspector/InspectorTimelineAgent.cpp: Added timer support and fixed some method names. (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): Added. (WebCore::InspectorTimelineAgent::didRemoveTimer): Added. (WebCore::InspectorTimelineAgent::willFireTimer): Added. (WebCore::InspectorTimelineAgent::didFireTimer): Added. (WebCore::InspectorTimelineAgent::addItemToTimeline): Added. (WebCore::InspectorTimelineAgent::didCompleteCurrentTimelineItem): Renamed.
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineItemFactory.cpp: Add methods for timer-related ScriptObjects. (WebCore::TimelineItemFactory::createGenericTimerTimelineItem): (WebCore::TimelineItemFactory::createTimerInstallTimelineItem):
  • inspector/TimelineItemFactory.h:
  • page/DOMTimer.cpp: Added instrumentation points. (WebCore::DOMTimer::install): (WebCore::DOMTimer::removeById): (WebCore::DOMTimer::fired):
09:31 Changeset [50067] by simon.fraser@apple.com
  • 6 edits in trunk

2009-10-26 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6988966> Hardware layers do not show up in page snapshots

  • WebView/WebHTMLViewPrivate.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _compositingLayersHostingView]): Add a private method that returns the NSView used to host compositing layers.
  • platform/graphics/mac/Canvas3DLayer.h:
  • platform/graphics/mac/Canvas3DLayer.mm: (-[Canvas3DLayer copyImageSnapshotWithColorSpace:]): Add a method that gets called when snapshotting Canvas3DLayers for page snapshots, that allows the layer to return a CGImageRef of its contents.
09:22 Changeset [50066] by ossy@webkit.org
  • 7 edits in trunk/LayoutTests

[Qt] Update outdated expected files which expected wrong color values.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

  • platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
09:17 Changeset [50065] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Pass "console" as object group when evaluating selection.

https://bugs.webkit.org/show_bug.cgi?id=30738

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
09:10 Changeset [50064] by eric@webkit.org
  • 10 edits in trunk

2009-10-26 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Fix for Console not showing repeat count when repeatedly logging an Event
https://bugs.webkit.org/show_bug.cgi?id=30324

  • inspector/console-tests-expected.txt:

2009-10-26 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Fix for Console not showing repeat count when repeatedly logging an Event
https://bugs.webkit.org/show_bug.cgi?id=30324

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::updateRepeatCountInConsole): Added.
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addConsoleMessage): Calls updateRepeatCountInConsole if it is a repeating message.
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage): Renamed WebCore::InspectorFrontend::addMessageToConsole (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): Added. Called when repeatCount is incremented.
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): Removed calls to msg.isEqual. (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): Added. (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): Added. Updates the error/warning count. (WebInspector.ConsoleView.prototype.clearMessages): (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): Use ConsoleMessage._updateRepeatCount (WebInspector.ConsoleMessage.prototype._updateRepeatCount):
  • inspector/front-end/inspector.js: (WebInspector.addConsoleMessage): Renamed WebInspector.addMessageToConsole. (WebInspector.updateConsoleMessageRepeatCount): Added.
08:27 Changeset [50063] by eric.carlson@apple.com
  • 63 edits in trunk/LayoutTests

2009-10-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

Remove HTML5 media element 'load' event
https://bugs.webkit.org/show_bug.cgi?id=30464


Part 1, change layout tests to not use the event.

  • media/audio-constructor-autobuffer-expected.txt:
  • media/audio-constructor-autobuffer.html:
  • media/audio-constructor-expected.txt:
  • media/audio-constructor-src-expected.txt:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/audio-controls-rendering.html:
  • media/audio-data-url-expected.txt:
  • media/audio-data-url.html:
  • media/audio-mpeg-supported-expected.txt:
  • media/audio-mpeg-supported.html:
  • media/media-load-event-expected.txt:
  • media/media-load-event.html:
  • media/progress-event-expected.txt:
  • media/progress-event-total-expected.txt:
  • media/progress-event-total.html:
  • media/progress-event.html:
  • media/remove-from-document-expected.txt:
  • media/remove-from-document-no-load-expected.txt:
  • media/remove-from-document-no-load.html:
  • media/remove-from-document.html:
  • media/restore-from-page-cache-expected.txt:
  • media/restore-from-page-cache.html:
  • media/video-append-source-expected.txt:
  • media/video-append-source.html:
  • media/video-buffered-expected.txt:
  • media/video-buffered.html:
  • media/video-canvas-source-expected.txt:
  • media/video-canvas-source.html:
  • media/video-controls-expected.txt:
  • media/video-controls-transformed-expected.txt:
  • media/video-controls-transformed.html:
  • media/video-controls-zoomed-expected.txt:
  • media/video-controls-zoomed.html:
  • media/video-controls.html:
  • media/video-currentTime-expected.txt:
  • media/video-currentTime-set-expected.txt:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2-expected.txt:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-dom-src-expected.txt:
  • media/video-dom-src.html:
  • media/video-error-abort-expected.txt:
  • media/video-error-abort.html:
  • media/video-error-does-not-exist.html:
  • media/video-muted-expected.txt:
  • media/video-muted.html:
  • media/video-no-autoplay-expected.txt:
  • media/video-no-autoplay.html:
  • media/video-seek-past-end-paused-expected.txt:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing-expected.txt:
  • media/video-seek-past-end-playing.html:
  • media/video-seekable-expected.txt:
  • media/video-seekable.html:
  • media/video-seeking-expected.txt:
  • media/video-seeking.html:
  • media/video-src-change-expected.txt:
  • media/video-src-change.html:
  • media/video-volume-expected.txt:
  • media/video-volume.html:
07:49 Changeset [50062] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

crash with AX on when an image map contains an anchor tag
https://bugs.webkit.org/show_bug.cgi?id=30739

Reviewed by Darin Adler.

WebCore:

Tests: accessibility/crashing-a-tag-in-map.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::addChildren):

LayoutTests:

  • accessibility/crashing-a-tag-in-map-expected.txt: Added.
  • accessibility/crashing-a-tag-in-map.html: Added.
06:51 Changeset [50061] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-10-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Update documentation control files for 1.1.16.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
06:49 Changeset [50060] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30759
[GTK] Should use WebKitNetworkResponse, and expose it

WebKitDownload now uses our WebKitNetworkResponse instead of using
ResourceResponse directly. By exposing the response, like we do
with the request, we give our users the ability to look at the
response headers, status code, and so on, through the SoupMessage
object.

06:25 Changeset [50059] by xan@webkit.org
  • 4 edits in trunk

2009-10-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.1.16 release.

  • configure.ac:

WebKit/gtk:

2009-10-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.1.16 release.

  • NEWS:
06:06 Changeset [50058] by eric@webkit.org
  • 8 edits in trunk/WebKit/qt

2009-10-26 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Reintroduce QWebElementCollection

Revert the patch that has replaced QWebElementCollection
with QList<QWebElement>. Update the tests accordingly.

Remove the constness of the return type of QWebElement operator[].

https://bugs.webkit.org/show_bug.cgi?id=30767

  • Api/qwebelement.cpp: (QWebElement::findAll): (QWebElementCollectionPrivate::QWebElementCollectionPrivate): (QWebElementCollectionPrivate::create): (QWebElementCollection::QWebElementCollection): (QWebElementCollection::operator=): (QWebElementCollection::~QWebElementCollection): (QWebElementCollection::operator+): (QWebElementCollection::append): (QWebElementCollection::count): (QWebElementCollection::at): (QWebElementCollection::toList):
  • Api/qwebelement.h: (const_iterator::begin): (const_iterator::end): (const_iterator::operator[]):
  • Api/qwebframe.cpp: (QWebFrame::findAllElements):
  • Api/qwebframe.h:
  • QtLauncher/main.cpp: (MainWindow::selectElements):
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::simpleCollection): (tst_QWebElement::iteration): (tst_QWebElement::emptyCollection): (tst_QWebElement::appendCollection): (tst_QWebElement::nullSelect): (tst_QWebElement::hasSetFocus): (tst_QWebElement::render):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
05:44 Changeset [50057] by benm@google.com
  • 5 edits in trunk/WebCore

Adds feature ENABLE guards to V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30697

Patch by Steve Block <steveblock@google.com> on 2009-10-26
Reviewed by Eric Seidel.

This adds guards for the following features to the V8 bindings,
to allow builds with V8 to succeed when these features are not enabled.

  • DATABASE
  • WORKERS
  • SHARED_WORKERS
  • SVG
  • XPATH
  • XSLT
  • INSPECTOR

This is a build fix only, no new tests required.

  • bindings/v8/DOMObjectsInclude.h: Modified.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Modified.
  • bindings/v8/V8Index.cpp: Modified.
  • bindings/v8/V8Index.h: Modified.
05:32 Changeset [50056] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Tor Arne Vestbø.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
http/tests/cookies/simple-cookies-max-age.html moved to flakey tests group.
http/tests/xmlhttprequest/workers/close.html added to flakey tests group.

  • platform/qt/Skipped:
04:58 Changeset [50055] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix for r49854.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26

  • platform/qt/Skipped: Missing html extension added.
04:42 Changeset [50054] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25679
[Gtk] Improve accessibility of focusable lists

Fixes the issues with the Atk states exposed for ListBoxOption

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject):
04:35 Changeset [50053] by eric@webkit.org
  • 9 edits in trunk/WebCore

2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=27085
[Gtk] Incorrect rendering of list

Adds a way for platforms to indicate that a particular object
should not be ignored.

  • accessibility/AccessibilityObject.h:
  • accessibility/chromium/AccessibilityObjectChromium.cpp:
  • accessibility/gtk/AccessibilityObjectAtk.cpp:
  • accessibility/mac/AccessibilityObjectMac.mm:
  • accessibility/qt/AccessibilityObjectQt.cpp:
  • accessibility/win/AccessibilityObjectWin.cpp:
  • accessibility/wx/AccessibilityObjectWx.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
  • accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::accessibilityIsIgnored):
03:46 Changeset [50052] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

2009-10-26 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Adds ability to disable ReadWriteLock on platforms (eg Android) that use pthreads but do not support pthread_rwlock.
https://bugs.webkit.org/show_bug.cgi?id=30713

  • wtf/Platform.h: Modified. Defines HAVE_PTHREAD_RWLOCK for all platforms currently using pthreads.
  • wtf/Threading.h: Modified. Use pthread_rwlock_t only when HAVE_PTHREAD_RWLOCK is defined.
  • wtf/ThreadingPthreads.cpp: Modified. Build ReadWriteLock methods only when HAVE_PTHREAD_RWLOCK is defined.
03:29 Changeset [50051] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2009-10-26 Kinuko Yasuda <kinuko@google.com>

Reviewed by Jan Alonzo.

Bug 30619: [Linux] Menu key doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30619

Test: manual-tests/keyboard-menukey-event.html
No new layout tests: testing this will require changes in the test
controller in a platform-specific way.

  • platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for GDK_Menu to return VKEY_APPS instead of VKEY_MENU.
  • platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for GDK_Menu to return V_APPS instead of VK_MENU.
03:07 Changeset [50050] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-26 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[Gtk] Reenable mod_rewrite in Fedora's httpd.conf
https://bugs.webkit.org/show_bug.cgi?id=30741

  • http/conf/fedora-httpd.conf:
01:52 QtBackLog edited by zecke@selfish.org
(diff)
01:45 QtBackLog edited by zecke@selfish.org
(diff)

10/25/09:

21:33 Changeset [50049] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-25 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Reuse already fetched proxy.
https://bugs.webkit.org/show_bug.cgi?id=30747

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
21:14 QtBackLog edited by zecke@selfish.org
(diff)
21:07 QtBackLog edited by zecke@selfish.org
(diff)
21:03 QtBackLog edited by zecke@selfish.org
Mention the bug report and commits of this work (diff)
17:45 Changeset [50048] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Rebaseline test after 49998.

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
15:39 Changeset [50047] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/WebCore

2009-10-25 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed build fix.

Build fix for WIN_OS if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=30753

  • plugins/PluginDatabase.cpp:
13:15 Changeset [50046] by eric@webkit.org
  • 3 edits
    4 adds in trunk

2009-10-25 Hironori Bono <hbono@chromium.org>

Reviewed by Darin Adler.

A quick fix for Bug 29103.
Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
and the option string before calling String::startsWith().
https://bugs.webkit.org/show_bug.cgi?id=29103

  • fast/forms/listbox-typeahead-cyrillic-expected.txt: Added.
  • fast/forms/listbox-typeahead-cyrillic.html: Added.
  • fast/forms/listbox-typeahead-greek-expected.txt: Added.
  • fast/forms/listbox-typeahead-greek.html: Added.

2009-10-25 Hironori Bono <hbono@chromium.org>

Reviewed by Darin Adler.

A quick fix for Bug 29103.
Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
and the option string before calling String::startsWith().
https://bugs.webkit.org/show_bug.cgi?id=29103

Tests: fast/forms/listbox-typeahead-cyrillic.html

fast/forms/listbox-typeahead-greek.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::typeAheadFind):
10:28 Changeset [50045] by mitz@apple.com
  • 3 edits in trunk/WebKit/win

Add contextForWorldID to the IWebFramePrivate interface.

Reviewed by John Sullivan.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.h:
08:06 Web Inspector edited by casey.hattori@gmail.com
(diff)
06:56 Web Inspector edited by casey.hattori@gmail.com
(diff)
06:54 Web Inspector edited by casey.hattori@gmail.com
(diff)
01:54 Changeset [50044] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-25 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Expanding a node in the Console should not show the element in Elements panel
https://bugs.webkit.org/show_bug.cgi?id=30749

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.onmousedown): Check if inside disclosure triangle.
01:22 Changeset [50043] by weinig@apple.com
  • 2 edits in trunk/WebKit/win

Another try at fixing windows.

  • DOMCreateInstance.cpp:
00:52 Changeset [50042] by weinig@apple.com
  • 2 edits in trunk/WebKit/win

Touch WebKit.idl in an effort to try and regenerate the COM bindings.

  • Interfaces/WebKit.idl:
00:52 Changeset [50041] by weinig@apple.com
  • 18 edits
    1 add in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLOptionsCollection::getCallData):
(WebCore::JSHTMLOptionsCollection::canGetItemsForName):
(WebCore::JSHTMLOptionsCollection::nameGetter):
(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::item):
(WebCore::JSHTMLOptionsCollection::namedItem):
Refactor to use generic implementation of HTMLCollection bindings functions
from JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLCollectionFunctions.h: Added.

(WebCore::getCollectionNamedItems):
(WebCore::getCollectionItems):
(WebCore::callHTMLCollectionGeneric):
Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
JSHTMLOptionsCollection can all use.

  • bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h

for toJS on document.all.

  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):
Remove special cases for HTMLOptionsCollection.

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLAllCollection.idl:
  • html/HTMLCollection.idl:
  • html/HTMLOptionsCollection.idl:

LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • fast/dom/wrapper-classes-expected.txt:
00:08 Changeset [50040] by bweinstein@apple.com
  • 18 edits
    1 delete in trunk

Roll out r50037 as it broke the Windows build.

10/24/09:

21:56 Changeset [50039] by timothy@apple.com
  • 5 edits in trunk/WebCore

WebInspector: Fixed issue with IME inside console
https://bugs.webkit.org/show_bug.cgi?id=30660

Patch by Keishi Hattori <casey.hattori@gmail.com> on 2009-10-24
Reviewed by Timothy Hatcher.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._promptKeyDown):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype._promptKeyDown):

  • inspector/front-end/inspector.js:

(WebInspector.loaded):
(WebInspector.searchKeyDown): Moved performSearch here from WebInspector.searchKeyUp.
(WebInspector.startEditing.element.handleKeyEvent):
(WebInspector.startEditing):

  • inspector/front-end/utilities.js:

(isEnterKey): Added. Check if in IME.

21:13 Changeset [50038] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

Fixes <https://bugs.webkit.org/show_bug.cgi?id=30752>.
Web Inspector: Multiple Selection on Scope Bars by default Conflicts with other behavior on OSX.

Reviewed by Timothy Hatcher.

Have the scope bars select one scope by default, but if the multiple selection key
is pressed, allow for multiple selection.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype._updateFilter):
(WebInspector.ConsoleView.prototype.filter):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter):
(WebInspector.ResourcesPanel.prototype._updateFilter):

19:44 Changeset [50037] by weinig@apple.com
  • 18 edits
    1 add in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLOptionsCollection::getCallData):
(WebCore::JSHTMLOptionsCollection::canGetItemsForName):
(WebCore::JSHTMLOptionsCollection::nameGetter):
(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::item):
(WebCore::JSHTMLOptionsCollection::namedItem):
Refactor to use generic implementation of HTMLCollection bindings functions
from JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLCollectionFunctions.h: Added.

(WebCore::getCollectionNamedItems):
(WebCore::getCollectionItems):
(WebCore::callHTMLCollectionGeneric):
Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
JSHTMLOptionsCollection can all use.

  • bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h

for toJS on document.all.

  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):
Remove special cases for HTMLOptionsCollection.

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLAllCollection.idl:
  • html/HTMLCollection.idl:
  • html/HTMLOptionsCollection.idl:

LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • fast/dom/wrapper-classes-expected.txt:
16:08 Changeset [50036] by timothy@apple.com
  • 4 edits in trunk/WebCore

Make the scope bars in the Web Inspector match other scope bars in Mac OS X.
Also cleans up the CSS to use classes instead of ID selectors.

https://bugs.webkit.org/show_bug.cgi?id=28186

Reviewed by Dan Bernstein.

  • inspector/front-end/ResourcesPanel.js: Add the scope-bar class.
  • inspector/front-end/inspector.css: Lots of changes to make it look right.
  • inspector/front-end/inspector.html: Add the scope-bar class.
16:08 Changeset [50035] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fix selecting Resources in the Web Inspector's Resources panel.

https://bugs.webkit.org/show_bug.cgi?id=30743

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.isCategoryVisible): Added.
(WebInspector.ResourceSidebarTreeElement.prototype.get selectable): Call
isCategoryVisible on the ResourcesPanel.

16:08 Changeset [50034] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fix the Scope Bar in the Web Inspector's Resource panel, so that selecting
All will deselect the other filters.

https://bugs.webkit.org/show_bug.cgi?id=30744

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.createFilterElement): Better syntax.
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter): Use a normal for loop,
and the child variable instead of target in the loop. Other clean up.

16:08 Changeset [50033] by timothy@apple.com
  • 6 edits in trunk/WebCore

Make resizing the Web Inspector's Elements panel sidebar work again.
Also makes Resources panel use the sidebar code in Panel.

https://bugs.webkit.org/show_bug.cgi?id=30742

Reviewed by Pavel Feldman.

  • inspector/front-end/Panel.js:

(WebInspector.Panel): Don't create the sidebar with an argument.
(WebInspector.Panel.prototype.show): Call updateSidebarWidth.
(WebInspector.Panel.prototype.handleKeyEvent): Call handleSidebarKeyEvent.
(WebInspector.Panel.prototype.handleSidebarKeyEvent): Added.
(WebInspector.Panel.prototype.createSidebar): Renamed from _createSidebar.
(WebInspector.Panel.prototype._sidebarDragging): Call updateSidebarWidth.
(WebInspector.Panel.prototype.updateSidebarWidth): Renamed from _updateSidebarWidth.
(WebInspector.Panel.prototype.setSidebarWidth): Added. Called by updateSidebarWidth.
(WebInspector.Panel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel): Call createSidebar.
(WebInspector.ProfilesPanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.show): Remove call to _updateSidebarWidth.
(WebInspector.ResourcesPanel.prototype.showResource): Call updateSidebarWidth
(WebInspector.ResourcesPanel.prototype.closeVisibleResource): Ditto.
(WebInspector.ResourcesPanel.prototype.setSidebarWidth): Added.
(WebInspector.ResourcesPanel.prototype.updateMainViewWidth): Added.

  • inspector/front-end/StoragePanel.js:

(WebInspector.StoragePanel): Call createSidebar.
(WebInspector.StoragePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel): Call createSidebar.
(WebInspector.TimelinePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

16:08 Changeset [50032] by timothy@apple.com
  • 3 edits in trunk/WebCore

Call updateSelection() in a few places so hovering in the Web Inspector's
Elements panel always has the correct row selection height.

https://bugs.webkit.org/show_bug.cgi?id=30735

Reviewed by Pavel Feldman.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton): Call updateSelection().
(WebInspector.ElementsTreeElement.prototype._insertInLastAttributePosition): Ditto.

  • inspector/front-end/inspector.css: Prevent text wrapping in the middle of the add attribute text.
16:02 Changeset [50031] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-24 Timothy Hatcher <timothy@apple.com>

Remove the re-root tree feature from the Web Inspector's
Elements panel. This feature wasn't super useful and gets
in the way of double-click to edit.

https://bugs.webkit.org/show_bug.cgi?id=30736

Reviewed by Pavel Feldman.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.ondblclick):
15:40 Changeset [50030] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-24 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Implements ReturnsNew hint for V8 bindings generation code.
https://bugs.webkit.org/show_bug.cgi?id=30745

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
15:16 Changeset [50029] by mitz@apple.com
  • 3 edits
    1 copy
    4 adds in trunk

Missing images at 350.org due to wrong URLs
https://bugs.webkit.org/show_bug.cgi?id=30748

Reviewed by Sam Weinig.

WebCore:

Test: fast/dom/HTMLImageElement/parse-src.html

  • dom/Element.cpp:

(WebCore::Element::getURLAttribute): Pass the attribute value through deprecateParseURL().
This matches what the Objective-C bindings do, as well as what HTMLImageLoader::sourceURI()
and SVGImageLoader::sourceURI() do.

LayoutTests:

  • fast/dom/HTMLImageElement/parse-src-expected.txt: Added.
  • fast/dom/HTMLImageElement/parse-src.html: Added.
  • fast/dom/HTMLImageElement/script-tests: Added.
  • fast/dom/HTMLImageElement/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Document/script-tests/TEMPLATE.html.
  • fast/dom/HTMLImageElement/script-tests/parse-src.js: Added.
13:55 Changeset [50028] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/WebCore

2009-10-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed.

[Qt] Build fix for QtWebKit after r50013.

  • WebCore.pro:
09:12 Changeset [50027] by dglazkov@chromium.org
  • 5 edits
    1 add in trunk/WebCore

2009-10-24 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[V8] Fix up to accommodate for HTMLAllCollection changes in
http://trac.webkit.org/changeset/49998.

  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
08:28 Changeset [50026] by eric@webkit.org
  • 17 edits in trunk

2009-10-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
https://bugs.webkit.org/show_bug.cgi?id=30476

Set the stack size to 80 Kb and heap size to the 128kB - 32MB range
to all executables linking against WebKit library.

  • WebKit.pri:

2009-10-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
https://bugs.webkit.org/show_bug.cgi?id=30476

Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
to jsc.exe.

  • jsc.pro:

2009-10-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
https://bugs.webkit.org/show_bug.cgi?id=30476

Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
to all QtWebkit executables.

  • QGVLauncher/QGVLauncher.pro:
  • QtLauncher/QtLauncher.pro:
  • tests/benchmarks/loading/tst_loading.pro:
  • tests/benchmarks/painting/tst_painting.pro:
  • tests/qgraphicswebview/qgraphicswebview.pro:
  • tests/qwebelement/qwebelement.pro:
  • tests/qwebframe/qwebframe.pro:
  • tests/qwebhistory/qwebhistory.pro:
  • tests/qwebhistoryinterface/qwebhistoryinterface.pro:
  • tests/qwebpage/qwebpage.pro:
  • tests/qwebplugindatabase/qwebplugindatabase.pro:
  • tests/qwebview/qwebview.pro:
05:56 QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
(diff)
05:48 QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
(diff)
05:23 QtBackLog edited by zecke@selfish.org
(diff)
05:21 QtBackLog edited by zecke@selfish.org
(diff)

10/23/09:

23:55 QtBackLog edited by zecke@selfish.org
(diff)
23:55 QtBackLog edited by zecke@selfish.org
(diff)
23:41 QtBackLog edited by zecke@selfish.org
(diff)
21:42 QtWebKitPerformanceUtilities edited by zecke@selfish.org
(diff)
21:12 Changeset [50025] by mitz@apple.com
  • 4 edits in trunk/WebCore

<rdar://problem/7294131> Assertion failure in AuthenticationMac at
mac(const Credential&) after authenticating to MobileMe Gallery movie

Reviewed by Alexey Proskuryakov.

  • platform/network/Credential.cpp:

(WebCore::Credential::Credential): Initialize m_persistence.
(WebCore::Credential::isEmpty): Made this method const.

  • platform/network/Credential.h:
  • platform/network/mac/AuthenticationMac.mm:

(WebCore::mac): Return nil if the Credential is empty.

20:16 Changeset [50024] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix engineering builds in the mysterious future.

  • Configurations/DebugRelease.xcconfig:
20:06 Changeset [50023] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

20:05 Changeset [50022] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.21.5

New tag.

20:05 Changeset [50021] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

Fixes <https://bugs.webkit.org/show_bug.cgi?id=30617>.
Web Inspector: Resources Scope Bar Should Allow Combinations.

Reviewed by Timothy Hatcher.

Refactor the filtering in ResourcePanel to make it match ConsoleView,
and add a divider between All, and the other choices of Resource types.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter):
(WebInspector.ResourcesPanel.prototype._updateFilter):

  • inspector/front-end/inspector.css:
20:03 Changeset [50020] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebKit/win

Merge r50019.

20:01 Changeset [50019] by mrowe@apple.com
  • 2 edits in trunk/WebKit/win

Build fix. Include config.h before including other files.

  • AccessibleImage.cpp:
19:06 Changeset [50018] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-10-23 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Added test for bug 27239 (ignore Refresh for view source mode).
https://bugs.webkit.org/show_bug.cgi?id=27239

  • http/tests/security/view-source-no-refresh.html: Added
  • http/tests/security/view-source-no-refresh-expected.txt: Added
  • http/tests/security/resources/view-source-no-refresh.php: Added

2009-10-23 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Ignore the Refresh header if we're in view source mode.

https://bugs.webkit.org/show_bug.cgi?id=27239

Test: http/tests/security/view-source-no-refresh.html

  • loader/FrameLoader.cpp: ignore Refresh in view-source mode.
18:10 Changeset [50017] by ap@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=30734
Remove XMLTokenizer::m_currentNodeIsReferenced

No change in behavior, no tests.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::setCurrentNode):
  • dom/XMLTokenizer.h: Don't store a boolean for the current node being the document - we can always check for that.
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::XMLTokenizer):
  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::XMLTokenizer): A fragment passed to XMLTokenizer is never null - in fact, the first thing we do is dereference it unconditionally, and then begin checking it for null, as if it could help.
18:09 Changeset [50016] by bdakin@apple.com
  • 3 edits in trunk/WebCore

No review since this is a build fix.

Build fix for the Mac. (Build is only broken when SVG filters are
enabled.)

Labelled these function static.

  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::identity):
(WebCore::table):
(WebCore::discrete):
(WebCore::linear):
(WebCore::gamma):

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::boxBlur):

17:40 Changeset [50015] by pfeldman@chromium.org
  • 9 edits
    2 adds in trunk/WebCore

2009-10-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement a Timeline panel.

https://bugs.webkit.org/show_bug.cgi?id=30725

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/Images/timelineIcon.png: Added.
  • inspector/front-end/TimelineAgent.js: (WebInspector.addItemToTimeline): (WebInspector.timelineProfilerWasStarted): (WebInspector.timelineProfilerWasStopped):
  • inspector/front-end/TimelinePanel.js: Added. (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype.handleKeyEvent): (WebInspector.TimelinePanel.prototype.timelineWasStarted): (WebInspector.TimelinePanel.prototype.timelineWasStopped): (WebInspector.TimelinePanel.prototype.addItemToTimeline): (WebInspector.TimelinePanel.prototype._innerAddItemToTimeline): (WebInspector.TimelinePanel.prototype._toggleTimelineButton): (WebInspector.TimelinePanel.prototype.setMainViewWidth): (WebInspector.TimelinePanel.prototype.getItemTypeName): (WebInspector.TimelineRecordTreeElement): (WebInspector.TimelineRecordTreeElement.prototype.onattach):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
17:26 Changeset [50014] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2009-10-23 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Clash Between Search's onkeyup and incremental search events
https://bugs.webkit.org/show_bug.cgi?id=30731

  • inspector/front-end/inspector.js: (WebInspector.performSearch): prevent incremental search event from clobbering a forced search
17:24 Changeset [50013] by pfeldman@chromium.org
  • 11 edits
    2 adds in trunk/WebCore

2009-10-23 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Removes the need for C++ Timeline types in InspectorTimelineAgent in favor
of ScriptObjects.
https://bugs.webkit.org/show_bug.cgi?id=30707

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/DOMDispatchTimelineItem.cpp: Removed.
  • inspector/DOMDispatchTimelineItem.h: Removed.
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentTimelineItem):
  • inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::TimelineItemEntry::TimelineItemEntry):
  • inspector/TimelineItem.cpp: Removed.
  • inspector/TimelineItem.h: Removed.
  • inspector/TimelineItemFactory.cpp: Added. (WebCore::TimelineItemFactory::createGenericTimelineItem): (WebCore::TimelineItemFactory::createDOMDispatchTimelineItem):
  • inspector/TimelineItemFactory.h: Added. (WebCore::): (WebCore::TimelineItemFactory::TimelineItemFactory):
17:13 Changeset [50012] by barraclough@apple.com
  • 10 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=30729
Provide private API to request the global context for a specific world.
Used to initialize parameters on the global object.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-23
Reviewed by Geoff Garen.

WebCore:

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::globalObject):

  • bindings/js/ScriptController.h:

WebKit/mac:

  • WebView/WebFramePrivate.h:
  • WebView/WebFrame.mm:

(-[WebFrame contextForWorldID:]):

WebKit/win:

  • WebFrame.cpp:

(WebFrame::contextForWorldID):

  • WebFrame.h:
16:44 Changeset [50011] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

16:44 Changeset [50010] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.21.4

New tag.

16:40 Changeset [50009] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-4-branch

Merge r50004.

16:40 Changeset [50008] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r47534.

16:35 Changeset [50007] by bweinstein@apple.com
  • 2 edits in trunk/WebKit/win

Pan-scrolling pointer shows up in other tabs or windows, can't "fix" it.
<http://webkit.org/b/30732> and <rdar://7332018>.

Reviewed by John Sullivan.

Turns off pan-scrolling on a WebView when it is about to lose focus.

  • WebView.cpp:

(WebViewWndProc):

15:40 Changeset [50006] by eric@webkit.org
  • 9 edits in trunk/WebCore

2009-10-23 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

Fixes style problems in Android-specific files.
https://bugs.webkit.org/show_bug.cgi?id=30717

Style changes only, no new tests possible.

  • page/android/EventHandlerAndroid.cpp: Modified. (WebCore::EventHandler::passMouseDownEventToWidget): Fixes whitespace in method signature. (WebCore::EventHandler::passSubframeEventToSubframe): Fixes whitespace in method signature. (WebCore::EventHandler::passWheelEventToWidget): Fixes whitespace in method signature. (WebCore::EventHandler::passMouseMoveEventToSubframe): Fixes whitespace in method signature.
  • platform/android/ClipboardAndroid.h: Modified. Fixes header include order and indenting.
  • platform/android/CursorAndroid.cpp: Modified. (WebCore::grabCursor): Fixes function braces. (WebCore::grabbingCursor): Fixes function braces.
  • platform/android/FileChooserAndroid.cpp: Modified. (WebCore::FileChooser::basenameForWidth): Fixes braces on while statement, and updates String::copy to String::threadsafeCopy.
  • platform/android/FileSystemAndroid.cpp: Modified. Fixes header include order. (WebCore::unloadModule): Fixes zero test. (WebCore::writeToFile): Fixes if statement structure.
  • platform/android/KeyEventAndroid.cpp: Modified. (WebCore::windowsKeyCodeForKeyEvent): Fixes switch statement indenting. (WebCore::keyIdentifierForAndroidKeyCode): Fixes switch statement indenting.
  • platform/android/ScreenAndroid.cpp: Modified. Fixes header include order and switch statement indenting.
  • platform/android/TemporaryLinkStubs.cpp: Modified. Fixes header include order.
15:25 Changeset [50005] by eric@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

2009-10-23 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Modified the tests results according to the last changes due
to the fixes of the bug (r49985):
https://bugs.webkit.org/show_bug.cgi?id=29697.

  • platform/gtk/editing/execCommand/4916541-expected.txt:
  • platform/gtk/editing/execCommand/5138441-expected.txt:
  • platform/gtk/editing/execCommand/5481523-expected.txt:
  • platform/gtk/editing/execCommand/indent-paragraphs-expected.txt: Added.
15:16 Changeset [50004] by jhoneycutt@apple.com
  • 4 edits
    4 adds in trunk

MSAA: Name for image elements should use alt attribute text

https://bugs.webkit.org/show_bug.cgi?id=30727
<rdar://problem/7328291>

Reviewed by Alice Liu.

WebKit/win:

  • AccessibleBase.cpp:

(AccessibleBase::createInstance):
If the AccessibilityObject is an image, return an AccessibleImage.

  • AccessibleImage.cpp: Added.

(AccessibleImage::AccessibleImage):
Call the base constructor.
(AccessibleImage::name):
If the object is not an AccessibilityRenderObject, return the base's
name(). Look first for an ARIA "labeled-by" attribute, then look for an
alternate text attribute. Fall back to the base's name().

  • AccessibleImage.h: Added.

(AccessibleImage::~AccessibleImage):

  • WebKit.vcproj/WebKit.vcproj:

Add AccessibleImage to the project.

LayoutTests:

  • platform/win/accessibility/img-alt-attribute-expected.txt: Added.
  • platform/win/accessibility/img-alt-attribute.html: Added.
14:49 Changeset [50003] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-23 Eric Seidel <eric@webkit.org>

No review, only adding Alice to the list of reviewers.

  • Scripts/modules/committers.py:
14:45 Changeset [50002] by weinig@apple.com
  • 2 edits in trunk/WebCore

Another shot at a fixed build.

  • DerivedSources.cpp:
14:33 Changeset [50001] by weinig@apple.com
  • 2 edits in trunk/WebCore

Another shot at a fixed build.

  • html/HTMLOptionsCollection.idl:
14:25 Changeset [50000] by beidson@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

50,000!

  • ChangeLog: Point out revision 50,000.
14:25 Changeset [49999] by weinig@apple.com
  • 2 edits in trunk/WebKit/win

Try and fix the windows build.

  • Interfaces/WebKit.idl:
14:12 Changeset [49998] by weinig@apple.com
  • 26 edits
    8 adds
    3 deletes in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30695
Drop .tags() support from HTMLCollection

Reviewed by Anders Carlsson.

  • Make .tags() only work for HTMLAllCollections in JS. .tags() is still available for all HTMLCollection like objects in Objective-C since that is API.
  • Auto-generate HTMLAllCollection.

Test: fast/dom/HTMLDocument/document-all.html

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAllCollection.cpp: Removed.
  • bindings/js/JSHTMLAllCollection.h: Removed.
  • bindings/js/JSHTMLAllCollectionCustom.cpp: Added.

(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::getCallData):
(WebCore::JSHTMLAllCollection::canGetItemsForName):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.cpp:

(WebCore::Document::all):

  • dom/Document.h:
  • dom/HTMLAllCollection.idl: Removed.
  • html/HTMLAllCollection.cpp: Added.

(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::HTMLAllCollection):
(WebCore::HTMLAllCollection::~HTMLAllCollection):

  • html/HTMLAllCollection.h: Added.
  • html/HTMLAllCollection.idl: Added.
  • html/HTMLCollection.h:
  • html/HTMLCollection.idl:
  • html/HTMLDocument.idl:
  • page/DOMWindow.idl:

LayoutTests: Update and add test for https://bugs.webkit.org/show_bug.cgi?id=30695
Drop .tags() support from HTMLCollection

Reviewed by Anders Carlsson.

  • fast/dom/HTMLDocument/document-all-expected.txt: Added.
  • fast/dom/HTMLDocument/document-all.html: Added.
  • fast/dom/HTMLDocument/script-tests: Added.
  • fast/dom/HTMLDocument/script-tests/document-all.js: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/script-tests/domListEnumeration.js:
  • fast/dom/undetectable-document-all-expected.txt:
  • fast/js/global-constructors-expected.txt:
13:47 Changeset [49997] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-10-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: pull basic sidebar implementation into the Panel.

https://bugs.webkit.org/show_bug.cgi?id=30720

13:43 Changeset [49996] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-23 Jens Alfke <snej@chromium.org>

Reviewed by Dimitri Glazkov.

Slight optimizations to object returning and exception handling in generated V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30599

  • bindings/scripts/CodeGeneratorV8.pm: Generate better code
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertToV8Object): Added overload that takes a Ref<>
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Remove unnecessary template param to prevent compile error
13:35 Changeset [49995] by eric@webkit.org
  • 8 edits
    1 add in trunk

2009-10-23 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

Volume slider always starts at half volume
https://bugs.webkit.org/show_bug.cgi?id=28322

  • media/video-volume-slider.html: Added. Pixel test for the volume slider of the media control. This test assumes volume slider is implemented and usable. It moves the mouse over the right bottom corner of a video element to trigger the volume slider. If volume slider is not implemented at all, you'll only see a video element with the first frame.
  • platform/gtk/Skipped: The above test requires a volume slider so it's skipped.
  • platform/mac/Skipped: ditto.
  • platform/win/Skipped: ditto.

2009-10-23 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

Volume slider always starts at half volume
https://bugs.webkit.org/show_bug.cgi?id=28322

Sets the value attribute of volume slider to the volume attribute
of the media element. Also update the value attribute of the
input element for the volume slider when the volume attribute
of the media element is updated.

Test: media/video-volume-slider.html

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderElement::update): Set the value attribute of the input element for the volume slider using the current volume of the media element.
  • rendering/MediaControlElements.h: Add method definition of update().
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider): Creates a volume slider with value attribute equals to the current volume attribute of the media element.
13:26 Changeset [49994] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-23 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel.

Chrome Linux: fix caret positioning in LTR complex languages
The caret is positioned off by one in languages like Thai.

https://bugs.webkit.org/show_bug.cgi?id=28284

A group of us spent a while trying various approaches to write a test
for this; however, since it is only that the blinking cursor is
displayed incorrectly, we concluded it can not be tested.

(Patch by Hironori Bono.)

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::selectionRectForComplexText):
13:13 Changeset [49993] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-10-23 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Add a layout test to assert that media element implementors do not
advance currentTime after being paused.

https://bugs.webkit.org/show_bug.cgi?id=30699

  • media/video-pause-immediately-expected.txt: Added.
  • media/video-pause-immediately.html: Added.
13:09 Changeset [49992] by tony@chromium.org
  • 10 edits in trunk/WebCore

2009-10-23 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

Fix Chromium build after IsoldatedWorld change (r49963).
https://bugs.webkit.org/show_bug.cgi?id=30719

  • bindings/ScriptControllerBase.cpp:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInIsolatedWorld):
  • bindings/v8/ScriptController.cpp: (WebCore::mainThreadNormalWorld):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell):
  • dom/Document.cpp: (WebCore::Document::createWrapperCache):
  • dom/ScriptExecutionContext.cpp:
  • dom/ScriptExecutionContext.h:
  • xml/XMLHttpRequest.cpp:
  • xml/XMLHttpRequest.h:
13:05 Changeset [49991] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-10-23 Victor Wang <victorw@chromium.org>

Reviewed by Eric Seidel.

Update the expected pixel result for test svg-as-background-6.html

The old result is incorrect because of the wrong SVG masking offset calculation.
Patch http://trac.webkit.org/changeset/49598 fixed the issue.
The pixel result of this layout test needs to be updated.

https://bugs.webkit.org/show_bug.cgi?id=30692

  • platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.png:
12:48 Changeset [49990] by eric@webkit.org
  • 7 edits
    2 adds in trunk

2009-10-23 Xiaomei Ji <xji@chromium.org>

Reviewed by Sam Weinig.

Fix caretRangeFromPoint()/elementFromPoint() returns wrong result
for a zoomed and scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30689.

The real cause is the wrong calculation of event.clientX/Y when
page is zoomed and scolled.
After Sam fixed the event.clientX/Y in r49551, the hit test point
should be recalculated (revert r49490).

  • fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll-expected.txt: Added.
  • fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html: Added.
  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
  • fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
  • fast/dom/elementFromPoint-relative-to-viewport.html:

2009-10-23 Xiaomei Ji <xji@chromium.org>

Reviewed by Sam Weinig.

Fix caretRangeFromPoint()/elementFromPoint() returns wrong result
for a zoomed and scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30689.

The real cause is the wrong calculation of event.clientX/Y when
page is zoomed and scolled.
After Sam fixed the event.clientX/Y in r49551, the hit test point
should be recalculated (revert r49490).

Test: fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html

  • dom/Document.cpp: (WebCore::Document::elementFromPoint): calculate the correct point relative to document when page is zoomed and scrolled. (WebCore::Document::caretRangeFromPoint): calculate the correct point relative to document when page is zoomed and scrolled.
12:38 Changeset [49989] by dumi@chromium.org
  • 5 edits
    2 adds in trunk/WebCore

Adding a class that allows us to enable/disable features at
runtime. Adding a flag to enable database support.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-22
Reviewed by Dmitry Titov.

https://bugs.webkit.org/show_bug.cgi?id=30653

  • WebCore.gypi:
  • bindings/v8/RuntimeEnabledFeatures.cpp: Added.
  • bindings/v8/RuntimeEnabledFeatures.h: Added.

(WebCore::RuntimeEnabledFeatures::setDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::databaseEnabled):
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::ACCESSOR_RUNTIME_ENABLER):

  • page/DOMWindow.idl:
12:30 Changeset [49988] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-23 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Inspector injects _inspectorCommandLineAPI into global object when opened
https://bugs.webkit.org/show_bug.cgi?id=30675

  • inspector/front-end/InjectedScript.js: (InjectedScript.getCompletions): (InjectedScript._evaluateOn): (InjectedScript.addInspectedNode): (InjectedScript._ensureCommandLineAPIInstalled): Moved _inspectorCommandLineAPI from window to console.
12:23 Changeset [49987] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-23 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Tor Arne Vestbø.

[Qt] don't undef NULL in Symbian emulator

npapi.h way of defining mwerks compiler,intel
and win32 are all true for Symbian emulator.
Changed the definions so that NULL won't be undefined
when compiling for Symbian emulator nor target HW.

  • bridge/npapi.h:
12:14 Changeset [49986] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-23 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Correct linking of sqlite3 for Symbian
https://bugs.webkit.org/show_bug.cgi?id=30569

".lib" will try to include library as static library
causing the library to be searched from wrong directory and if found
will be statically linked instead of the inteded dynamic linking.

  • WebCore.pro:
12:00 Changeset [49985] by adele@apple.com
  • 21 edits
    2 adds in trunk

REGRESSION: Copy is copying incorrect background-color
<rdar://problem/7248529>
https://bugs.webkit.org/show_bug.cgi?id=29697

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-23
Reviewed by Adele Peterson.

WebCore:

Test: editing/execCommand/indent-paragraphs.html

This change removes the BackgroundColor from the list
of inheritable CSS properties and changes significantly
the way we perform indentation.
The new implementation of IndentOutdentCommand uses a new method
defined in CompositeEditCommand called moveParagraphWithClones.
This is an improved version of the original moveParagraph that
is aimed at preserving the original markup of the paragraph being
moved.

  • editing/ApplyStyleCommand.cpp:

(WebCore::): removed CSSPropertyBackgroundColor from editingStyleProperties.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::CompositeEditCommand): Removed trailing blanks.
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Removed trailing blanks.
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Added.
(WebCore::CompositeEditCommand::cleanupAfterDeletion): Added.
(WebCore::CompositeEditCommand::moveParagraphWithClones): Added.
(WebCore::CompositeEditCommand::moveParagraphs): Modified to use cleanupAfterDeletion.
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Removed trailing blanks.
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Removed trailing blanks.
(WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Removed trailing blanks.

  • editing/CompositeEditCommand.h: Added three new methods.
  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::tryIndentingAsListItem): Changed to use moveParagraphWithClones.
(WebCore::IndentOutdentCommand::indentIntoBlockquote): Changed to use moveParagraphWithClones.
(WebCore::IndentOutdentCommand::indentRegion): Removed comment.

  • editing/IndentOutdentCommand.h: Removed prepareBlockquoteLevelForInsertion method.

LayoutTests:

All the following tests have been re-baselined because
the indent command now preserves the original markup.
A new test (indent-paragraph.html) has been added to test
several indent combinations not covered by the existing tests.

  • editing/execCommand/19087-expected.txt:
  • editing/execCommand/19653-1-expected.txt:
  • editing/execCommand/indent-div-inside-list-expected.txt:
  • editing/execCommand/indent-nested-blockquotes-expected.txt:
  • editing/execCommand/indent-nested-div-expected.txt:
  • editing/execCommand/indent-paragraphs.html: Added.
  • editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt:
  • editing/execCommand/indent-with-style-expected.txt:
  • editing/inserting/5994480-2-expected.txt:
  • platform/mac/editing/execCommand/4641880-2-expected.txt:
  • platform/mac/editing/execCommand/4916541-expected.txt:
  • platform/mac/editing/execCommand/5138441-expected.txt:
  • platform/mac/editing/execCommand/5481523-expected.txt:
  • platform/mac/editing/execCommand/indent-paragraphs-expected.txt: Added.
  • platform/mac/editing/execCommand/indent-selection-expected.txt:
  • platform/mac/editing/pasteboard/select-element-1-expected.txt:
11:57 Changeset [49984] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-23 Eric Seidel <eric@webkit.org>

Reviewed by Eric Carlson.

fast/media/mq-transform-02.html failed on Leopard Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=30700

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Update QuickTime version check.
10:34 Changeset [49983] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

Isolated worlds tests now pass, removing then from the Skipped
list.

  • platform/win/Skipped:
09:45 Changeset [49982] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
character measurement APIs that are private on Tiger.

09:42 Changeset [49981] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

wx build fix. Update the globalObject calls after changes.

09:34 Changeset [49980] by cmarrin@apple.com
  • 1 edit in trunk/WebKitSite/blog-files/webgl/resources/blogpost.css

Changed anchor style to take a class name

08:53 Changeset [49979] by eric.carlson@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-22 Eric Carlson <eric.carlson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/7322847>
Pressing space bar key in full screen mode should pause movie but doesn't

  • WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController keyDown:]): New, toggle playback on space key. (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Play button action is now called togglePlaying. (-[WebVideoFullscreenHUDWindowController togglePlaying:]): Rename from playingChanged.
07:30 Changeset [49978] by vestbo@webkit.org
  • 1 edit in trunk/WebKit/qt/Api/qwebframe.cpp

Qt build fix

07:07 Changeset [49977] by benm@google.com
  • 2 edits in trunk/JavaScriptCore

Fixes a leak in createThreadInternal on Android.
https://bugs.webkit.org/show_bug.cgi?id=30698

Patch by Steve Block <steveblock@google.com> on 2009-10-23
Reviewed by Dmitry Titov.

  • wtf/ThreadingPthreads.cpp: Modified.

(WTF::createThreadInternal): Avoid leaking a ThreadData object on failure.

05:45 Changeset [49976] by benm@google.com
  • 3 edits in trunk/WebCore

Adds missing UnusedParam.h includes, required when INSPECTOR is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=30677

Patch by Steve Block <steveblock@google.com> on 2009-10-23
Reviewed by Eric Seidel.

Build fix, no new tests required.

  • page/Console.cpp: Modified. Added UnusedParam.h include.
  • workers/WorkerContext.cpp: Modified. Added UnusedParam.h include.
05:02 Changeset [49975] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Plugins : Use window's winId() instead of the widget's.

2009-10-23 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Holger Freyther.

[Qt] Plugins : Use window's winId() instead of the widget's.

As per, https://developer.mozilla.org/en/NPN_GetValue
NPNVnetscapeWindow on Unix/X11: "Gets the browser toplevel window in which the
plug-in is displayed; returns Window".

The issue was found because NPNVNetscapeWindow winId() ends up creating
a native window resulting in flicker.

https://bugs.webkit.org/show_bug.cgi?id=30706

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::getValue):
05:02 Changeset [49974] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Windowless Plugins : Don't use m_clipRect when painting.

2009-10-23 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Holger Freyther.

[Qt] Windowless Plugins : Don't use m_clipRect when painting.

Though it works, it is not correct to use m_clipRect for painting
in Windowless mode. Instead, the rect paramater that is passed
as a part of PluginView::paint() must be used. This change will
also result in some speedup since previously we used to paint all
the visible parts of a windowless plugin (even if those parts were
not dirty).

Also, fix invalidateRect() to compute the correct width and height.

https://bugs.webkit.org/show_bug.cgi?id=30711

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint): (WebCore::PluginView::invalidateRect):
05:02 Changeset [49973] by zecke@webkit.org
  • 4 edits
    1 add in trunk/WebCore

Plugins : Use test.swf in the plugins manual tests.

They previously referenced youtube videos which among other things are
cumbersome to use without internet connection. The old youtube link is
just commented out so that testing with youtube can be done with
little effort.

04:47 Changeset [49972] by xan@webkit.org
  • 3 edits in trunk/LayoutTests

2009-10-23 Xan Lopez <xlopez@igalia.com>

Use the correct Skipped file ...

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
04:43 Changeset [49971] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-23 Xan Lopez <xlopez@igalia.com>

Skip new tests missing expected results.

  • platform/mac/Skipped:
01:14 Changeset [49970] by bweinstein@apple.com
  • 2 edits
    1 add in trunk/WebCore

Fix the Windows Release build by moving Accessibility files
into all-in-one file and excluding them from the build.

Reviewed by Jon Honeycutt.

  • WebCore.vcproj/WebCore.vcproj:
  • accessibility/AccessibilityAllInOne.cpp: Added.

10/22/09:

23:22 Changeset [49969] by mrowe@apple.com
  • 16 edits in trunk

Update configurations to support the mysterious future.

Rubber-stamped by Brady Eidson.

22:27 Changeset [49968] by barraclough@apple.com
  • 2 edits in trunk/WebKitTools

Build fix following bug #30696.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::evaluateScriptInIsolatedWorld):

22:16 Changeset [49967] by mrowe@apple.com
  • 23 edits
    2 deletes in trunk/WebKitSite

Update to WordPress 2.8.5.

  • blog:
22:06 Changeset [49966] by barraclough@apple.com
  • 3 edits in trunk/WebKit/qt

Build fix following bug #30696.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (speculative build fix - qt is currently already broken!)

  • Api/qwebelement.cpp:

(setupScriptContext):

  • Api/qwebframe.cpp:

(QWebFrame::evaluateJavaScript):

21:57 Changeset [49965] by barraclough@apple.com
  • 2 edits in trunk/WebKit/mac

Build fix following bug #30696.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
(WebKit::NetscapePluginInstanceProxy::evaluate):
(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):
(WebKit::NetscapePluginInstanceProxy::getProperty):
(WebKit::NetscapePluginInstanceProxy::setProperty):
(WebKit::NetscapePluginInstanceProxy::removeProperty):
(WebKit::NetscapePluginInstanceProxy::hasProperty):
(WebKit::NetscapePluginInstanceProxy::hasMethod):
(WebKit::NetscapePluginInstanceProxy::enumerate):

21:48 Changeset [49964] by barraclough@apple.com
  • 3 edits in trunk/WebKit/gtk

Build fix following bug #30696.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::windowObjectCleared):

  • webkit/webkitwebframe.cpp:

(webkit_web_frame_get_global_context):

21:33 Changeset [49963] by barraclough@apple.com
  • 101 edits in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=30696
Add support for IsolatedWorlds to JSC bindings.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-16
Reviewed by Sam Weinig & Geoff Garen.

An IsolatedWorld is basically a parallel, separate copy of the window shells and DOM wrapper objects for
a given document. To support isolation this patch:

  • Adds support to the ScriptController to track multiple window shells, one per world.
  • Adds support to Document to support multiple separate wrapper-maps, one per world.
  • Replaces the single global DOM wrapper map (on the WebCoreJSClientData) with separate maps, stored on the (new) IsolatedWorld objects.

In addition to supporting separate copies of these objects, two other features are supported:

  • It is necessary to track the current world on entry into JSC, so that within callbacks out to WebCore we can determine which world (and as such, set of DOM bindings) we should be operating on.
  • EventListeners & Callbacks are run in the world they were registered in. This requires the handler to retain a reference to the world.

No new tests. (Enabled existing isolated world layout tests.)

  • WebCore.base.exp:
  • bindings/js/JSAbstractWorkerCustom.cpp:

(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCallbackData.h:

(WebCore::JSCallbackData::JSCallbackData):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSDOMApplicationCacheCustom.cpp:

(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::removeWrappers):
(WebCore::DOMObjectWrapperMap::get):
(WebCore::DOMObjectWrapperMap::set):
(WebCore::DOMObjectWrapperMap::remove):
(WebCore::DOMObjectWrapperMap::take):
(WebCore::IsolatedWorld::IsolatedWorld):
(WebCore::IsolatedWorld::~IsolatedWorld):
(WebCore::EnterIsolatedWorld::EnterIsolatedWorld):
(WebCore::EnterIsolatedWorld::~EnterIsolatedWorld):
(WebCore::JSGlobalDataWorldIterator::JSGlobalDataWorldIterator):
(WebCore::JSGlobalDataWorldIterator::operator bool):
(WebCore::JSGlobalDataWorldIterator::operator*):
(WebCore::JSGlobalDataWorldIterator::operator->):
(WebCore::JSGlobalDataWorldIterator::operator++):
(WebCore::getCurrentWorld):
(WebCore::getNormalWorld):
(WebCore::commonNormalWorld):
(WebCore::commonCurrentWorld):
(WebCore::DOMObjectHashTableMap::mapFor):
(WebCore::DOMObjectWrapperMap::mapFor):
(WebCore::forgetDOMObject):
(WebCore::getCachedDOMNodeWrapper):
(WebCore::forgetDOMNode):
(WebCore::cacheDOMNodeWrapper):
(WebCore::forgetAllDOMNodesForDocument):
(WebCore::forgetWorldOfDOMNodesForDocument):
(WebCore::isObservableThroughDOM):
(WebCore::markDOMNodesForDocument):
(WebCore::markActiveObjectsForContext):
(WebCore::takeWrappers):
(WebCore::updateDOMNodeDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::allowsAccessFromFrame):
(WebCore::printErrorMessageForFrame):
(WebCore::JSC_DebuggerCallFrame_evaluateInWorld):
(WebCore::JSC_callInWorld):
(WebCore::JSC_constructInWorld):
(WebCore::JSC_evaluateInWorld):

  • bindings/js/JSDOMBinding.h:

(WebCore::IsolatedWorld::rememberDocument):
(WebCore::IsolatedWorld::forgetDocument):
(WebCore::IsolatedWorld::rememberScriptController):
(WebCore::IsolatedWorld::forgetScriptController):
(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
(WebCore::DOMObjectHashTableMap::get):
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::currentWorld):
(WebCore::WebCoreJSClientData::normalWorld):
(WebCore::WebCoreJSClientData::rememberWorld):
(WebCore::WebCoreJSClientData::forgetWorld):
(WebCore::debuggerWorld):
(WebCore::pluginWorld):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
(WebCore::toJSDOMGlobalObject):

  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::printErrorMessage):
(WebCore::JSDOMWindowBase::commonJSGlobalData):
(WebCore::toJS):
(WebCore::toJSDOMWindow):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::createWindow):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::showModalDialog):
(WebCore::JSDOMWindow::setTimeout):
(WebCore::JSDOMWindow::setInterval):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::toJS):
(WebCore::toJSDOMWindowShell):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSDesktopNotificationsCustom.cpp:

(WebCore::JSNotification::addEventListener):
(WebCore::):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::create):

  • bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):

  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::open):

  • bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::nameGetter):

  • bindings/js/JSInspectorBackendCustom.cpp:

(WebCore::JSInspectorBackend::databaseForId):
(WebCore::JSInspectorBackend::inspectedWindow):
(WebCore::JSInspectorBackend::nodeForId):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::parseCode):

  • bindings/js/JSLazyEventListener.h:

(WebCore::JSLazyEventListener::create):

  • bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannel::markChildren):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::markChildren):
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
(WebCore::JSNode::markChildren):

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode):

  • bindings/js/JSQuarantinedObjectWrapper.cpp:

(WebCore::JSQuarantinedObjectWrapper::construct):
(WebCore::JSQuarantinedObjectWrapper::call):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):

  • bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorker::markChildren):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):
(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::setInterval):

  • bindings/js/JSXMLHttpRequestConstructor.cpp:

(WebCore::constructXMLHttpRequest):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):

  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:

(WebCore::JSXMLHttpRequestUpload::markChildren):
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::executeFunctionInContext):
(WebCore::ScheduledAction::execute):

  • bindings/js/ScheduledAction.h:

(WebCore::ScheduledAction::ScheduledAction):

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::processingUserGestureEvent):
(WebCore::ScriptController::attachDebugger):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::bindingRootObject):
(WebCore::ScriptController::createRootObject):
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::jsObjectForPluginElement):

  • bindings/js/ScriptController.h:

(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::globalObject):
(WebCore::ScriptController::forgetWorld):

  • bindings/js/ScriptControllerMac.mm:

(WebCore::ScriptController::windowScriptObject):

  • bindings/js/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener):

  • bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):

  • bindings/js/ScriptObjectQuarantine.cpp:

(WebCore::getQuarantinedScriptObject):

  • bindings/js/ScriptState.cpp:

(WebCore::scriptStateFromNode):
(WebCore::scriptStateFromPage):

  • bindings/js/ScriptState.h:
  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::evaluate):

  • bindings/objc/DOMInternal.mm:

(-[WebScriptObject _initializeScriptDOMNodeImp]):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp:

(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_Construct):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::call):
(JavaJSObject::eval):

  • dom/Document.cpp:

(WebCore::Document::createWrapperCache):

  • dom/Document.h:

(WebCore::Document::wrapperCacheMap):
(WebCore::Document::getWrapperCache):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):

  • inspector/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::evaluate):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchWindowObjectAvailable):

  • platform/network/mac/AuthenticationMac.mm:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::dropProtection):

  • xml/XMLHttpRequest.h:

(WebCore::XMLHttpRequest::create):

WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=30696
Update to incorporate support for IsolatedWorlds in JSC bindings.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-16
Reviewed by Sam Weinig & Geoff Garen.

  • WebView/WebFrame.mm:

(-[WebFrame _attachScriptDebugger]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame globalContext]):

  • WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame evaluateWebScript:]):

  • WebView/WebView.mm:

(-[WebView aeDescByEvaluatingJavaScriptFromString:]):

WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=30696
Update to incorporate support for IsolatedWorlds in JSC bindings.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by Sam Weinig & Geoff Garen.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp:

(WebFrame::globalContext):
(WebFrame::windowObjectCleared):
(WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld):

  • WebFrame.h:

WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=30696
Enable isolated-worlds tests on mac.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by Sam Weinig & Geoff Garen.

Add private interface for DRT to invoke execution in a given world.

  • DumpRenderTree/LayoutTestController.cpp:

(evaluateScriptInIsolatedWorldCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::evaluateScriptInIsolatedWorld):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::evaluateScriptInIsolatedWorld):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=30696
Enable isolated-worlds tests on mac.

  • Update the results to switch from windows to unix line-endings.
  • Update all-window-prototypes.html to allow for properties on the global object with null prototypes (just skip over them).

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-19
Reviewed by Sam Weinig & Geoff Garen.

  • http/tests/security/isolatedWorld/all-window-properties-expected.txt:
  • http/tests/security/isolatedWorld/all-window-prototypes-expected.txt:
  • http/tests/security/isolatedWorld/all-window-prototypes.html:
  • http/tests/security/isolatedWorld/body-properties-expected.txt:
  • http/tests/security/isolatedWorld/body-prototype-expected.txt:
  • http/tests/security/isolatedWorld/document-properties-expected.txt:
  • http/tests/security/isolatedWorld/document-prototype-expected.txt:
  • http/tests/security/isolatedWorld/global-variables-expected.txt:
  • http/tests/security/isolatedWorld/image-properties-expected.txt:
  • http/tests/security/isolatedWorld/image-prototype-expected.txt:
  • http/tests/security/isolatedWorld/location-properties-expected.txt:
  • http/tests/security/isolatedWorld/location-prototype-expected.txt:
  • http/tests/security/isolatedWorld/number-prototype-expected.txt:
  • http/tests/security/isolatedWorld/object-prototype-expected.txt:
  • http/tests/security/isolatedWorld/storage-properties-expected.txt:
  • http/tests/security/isolatedWorld/storage-prototype-expected.txt:
  • http/tests/security/isolatedWorld/string-prototype-expected.txt:
  • http/tests/security/isolatedWorld/window-properties-expected.txt:
  • platform/mac/Skipped:
21:12 Changeset [49962] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2009-10-22 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: EventListenersSidebarPane TODO No Longer Needed
https://bugs.webkit.org/show_bug.cgi?id=30705

  • inspector/front-end/EventListenersSidebarPane.js:
17:22 Changeset [49961] by bweinstein@apple.com
  • 3 edits in trunk/LayoutTests

Updating expected results - unreviewed.

Updated expected computed style results on Windows after r49959.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
17:00 Changeset [49960] by ap@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=30506
<rdar://problem/7319845> Resources that the server sent as 304 not modified are not shown
in the inspectors resource pane

I don't know how to make a test for this.

The issue here was that preloaded resources weren't added to DocLoader document resource set,
but Web Inspector asked DocLoader to fetch data from CachedResource. Even when (if) document
parser eventually requested the same resource for real and it got added to resource set, it
was too late - the Inspector wasn't updated.

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
  • inspector/InspectorResource.h: Fix the issue by trying to fetch corresponding CachedResource harder - also look in global cache. This seems safe, and easier than updating the Inspector on transitions between resource states (revalidate vs. revalidate done and preload vs. non-preload).
16:34 Changeset [49959] by bdakin@apple.com
  • 17 edits
    36 adds in trunk

WebCore: Fix for <rdar://problem/6942706> ER: Add a CSS property that allows
shadows to work for SVG content
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=30479

Reviewed by Dan Bernstein.

This patch adds a new SVG-specific CSS property called -webkit-
shadow that has the same syntax as -webkit-box-shadow

Add CSSPropertyWebkitShadow to the list of SVG CSS properties, and
make valueForShadow a member function rather than a static function

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSComputedStyleDeclaration.h:

Call valueForShadow for CSSPropertyWebkitShadow

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

Do standard CSS stuff for CSSPropertyWebkitShadow

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

Set the appropriate shadow on the paint context if we have one.
This seems to be all we have to do to have an SVG-shaped shadow.

  • rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent):

Add shadow to SVGRenderStyle. I added a new macro that I don't like
just because that's the way things are done here right now.

  • rendering/style/SVGRenderStyle.cpp:

(WebCore::SVGRenderStyle::SVGRenderStyle):
(WebCore::SVGRenderStyle::operator==):

  • rendering/style/SVGRenderStyle.h:
  • rendering/style/SVGRenderStyleDefs.cpp:

(StyleShadowSVGData::StyleShadowSVGData):
(StyleShadowSVGData::operator==):

  • rendering/style/SVGRenderStyleDefs.h:

(WebCore::StyleShadowSVGData::create):
(WebCore::StyleShadowSVGData::copy):
(WebCore::StyleShadowSVGData::operator!=):

LayoutTests: Tests for <rdar://problem/6942706> ER: Add a CSS property that
allows shadows to work for SVG content
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=30479

Reviewed by Dan Bernstein.

New results that include -webkit-shadow:

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

New tests and their results.

  • platform/mac/svg/css/arrow-with-shadow-expected.checksum: Added.
  • platform/mac/svg/css/arrow-with-shadow-expected.png: Added.
  • platform/mac/svg/css/arrow-with-shadow-expected.txt: Added.
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.checksum: Added.
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.png: Added.
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
  • platform/mac/svg/css/clippath-with-shadow-expected.checksum: Added.
  • platform/mac/svg/css/clippath-with-shadow-expected.png: Added.
  • platform/mac/svg/css/clippath-with-shadow-expected.txt: Added.
  • platform/mac/svg/css/group-with-shadow-expected.checksum: Added.
  • platform/mac/svg/css/group-with-shadow-expected.png: Added.
  • platform/mac/svg/css/group-with-shadow-expected.txt: Added.
  • platform/mac/svg/css/mask-with-shadow-expected.checksum: Added.
  • platform/mac/svg/css/mask-with-shadow-expected.png: Added.
  • platform/mac/svg/css/mask-with-shadow-expected.txt: Added.
  • platform/mac/svg/css/path-with-shadow-expected.checksum: Added.
  • platform/mac/svg/css/path-with-shadow-expected.png: Added.
  • platform/mac/svg/css/path-with-shadow-expected.txt: Added.
  • platform/mac/svg/css/stars-with-shadow-expected.checksum: Added.
  • platform/mac/svg/css/stars-with-shadow-expected.png: Added.
  • platform/mac/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/mac/svg/filters/shadow-on-filter-expected.checksum: Added.
  • platform/mac/svg/filters/shadow-on-filter-expected.png: Added.
  • platform/mac/svg/filters/shadow-on-filter-expected.txt: Added.
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.checksum: Added.
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt: Added.
  • svg/css/arrow-with-shadow.svg: Added.
  • svg/css/circle-in-mask-with-shadow.svg: Added.
  • svg/css/clippath-with-shadow.svg: Added.
  • svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/group-with-shadow.svg: Added.
  • svg/css/mask-with-shadow.svg: Added.
  • svg/css/path-with-shadow.svg: Added.
  • svg/css/stars-with-shadow.html: Added.
  • svg/filters/shadow-on-filter.svg: Added.
  • svg/filters/shadow-on-rect-with-filter.svg: Added.
16:07 Changeset [49958] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-10-22 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25530
[Gtk] Implement LABEL_FOR/LABELLED_BY relationship pair for labels

Implements atk_object_ref_relation_set and LABEL_FOR/LABELLED_BY.
Also causes the accessible name for labeled controls to be based on
the label as expected, rather than based on the contents.

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityRenderObject.cpp: (correspondingLabelForControlElement):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkRelationSetFromCoreObject): (webkit_accessible_ref_relation_set): (webkit_accessible_class_init): (webkit_accessible_get_name):
14:32 Changeset [49957] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2009-10-22 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Added expected result for clicked-link-is-visited.html.
Removed test case from qt/Skipped as it works now.

  • platform/qt/Skipped:
  • platform/qt/fast/history: Added.
  • platform/qt/fast/history/clicked-link-is-visited-expected.txt: Added.

2009-10-22 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Enable track visited links in QWebPage
https://bugs.webkit.org/show_bug.cgi?id=30574

Test: fast/history/clicked-link-is-visited.html

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
14:08 Changeset [49956] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2009-10-22 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: windowFocused and windowBlured Fail to Clear/Mark Inspector as "inactive"
https://bugs.webkit.org/show_bug.cgi?id=30663

Correctly handle focusing/blurring on inner <iframe>'s such as Source Frames.

  • inspector/front-end/inspector.js: (WebInspector.windowFocused): fix for inner iframes (WebInspector.windowBlurred): fix for inner iframes (WebInspector.addMainEventListeners): change useCapture to false
13:33 Changeset [49955] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

Fixed ASSERT when opening Safari's Caches window while the Web Inspector
is open.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-22
Reviewed by Alexey Proskuryakov.

  • runtime/Collector.cpp:

(JSC::typeName): Added two new types to the type name list in the Collector.
These types have been around for a while, but nobody remembered to consider them here.

  • runtime/JSCell.h:

(JSC::JSCell::isPropertyNameIterator):

  • runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::isPropertyNameIterator): Give the Collector
a way to tell if a cell is a JSPropertyNameIterator.

13:19 Changeset [49954] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-22 Jaime Yap <jaimeyap@google.com>

Reviewed by Timothy Hatcher.

Makes a page reload optional when activating resource monitoring in
InspectorController. It leaves the default behavior as performing the reload.
Reload is an optional param so callsites do not have to change.

https://bugs.webkit.org/show_bug.cgi?id=30684

No new tests added.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking):
  • inspector/InspectorController.h:
13:10 Changeset [49953] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-10-22 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Eric Seidel.

[Qt] Add Print Shortcut to QtLauncher

https://bugs.webkit.org/show_bug.cgi?id=30682

  • QtLauncher/main.cpp: (MainWindow::setupUI):
13:06 Changeset [49952] by sfalken@apple.com
  • 2 edits
    1 delete in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=30686
Remove debug-specific def file.
Only Debug_All target uses JavaScriptCore_debug.dll naming, and since
that target is only used internally, maintaining two files just to
suppress a single link warning isn't worthwhile.

Reviewed by Jon Honeycutt.

12:56 Changeset [49951] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-22 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Fix memory leak in QNetworkReplyHandler::abort().
In QNetworkReplyHandler::release(), m_reply should no longer point to its parent
after being released.
https://bugs.webkit.org/show_bug.cgi?id=30167

No layout test available as a non-functional fix.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::abort): (WebCore::QNetworkReplyHandler::release):
12:15 Changeset [49950] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-10-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Fix DOMAgent leak.

https://bugs.webkit.org/show_bug.cgi?id=30615

  • inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::releaseDOMAgent):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
11:35 Changeset [49949] by dglazkov@chromium.org
  • 19 edits in trunk/WebCore

2009-10-22 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

[V8] Rework event listeners to not hold references to frame or V8 context.

https://bugs.webkit.org/show_bug.cgi?id=30648

Covered by existing layout tests: fast/events/attribute-listener*

  • bindings/scripts/CodeGeneratorV8.pm: Added passing ScriptExecutionContext*

to event listener handling code.

  • bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep): Changed to use currentContext().
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Reworked to match JSC logic. (WebCore::getEventListenerHandlerBody): Added ScriptExecutionContext* param.
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): Removed Frame* param

and usage.

(WebCore::V8AbstractEventListener::handleEvent): Chaged to use ScriptExecutionContext*.
(WebCore::V8AbstractEventListener::invokeEventHandler): Ditto.

  • bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::getListenerObject): Ditto. (WebCore::V8AbstractEventListener::prepareListenerObject): Ditto.
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Added ScriptExecutionContext* param. (WebCore::V8DOMWrapper::getEventListener): Ditto.
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Ditto.
  • bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper): Removed ContextType* template param,

because it's no longer needed.

  • bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::sharedContext): Renamed from shared_context.
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): Removed Frame* param and usage. (WebCore::V8LazyEventListener::callListenerFunction): Added ScriptExecutionContext* param. (WebCore::V8LazyEventListener::prepareListenerObject): Ditto.
  • bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create): Reordered params to match JSC impl.
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): Adjusted formatting to match WebKit style. (WebCore::V8Proxy::evaluateInNewContext): Changed to use m_context directly. (WebCore::V8Proxy::setInjectedScriptContextDebugId): Ditto. (WebCore::V8Proxy::createWrapperFromCacheSlowCase): Ditto. (WebCore::V8Proxy::isContextInitialized): Ditto. (WebCore::V8Proxy::updateDocumentWrapperCache): Ditto. (WebCore::V8Proxy::clearDocumentWrapperCache): Ditto. (WebCore::V8Proxy::disposeContextHandles): Added explicit disposing of m_context. (WebCore::V8Proxy::clearForClose): Changed to use m_context directly. (WebCore::V8Proxy::clearForNavigation): Ditto. (WebCore::V8Proxy::setSecurityToken): Ditto. (WebCore::V8Proxy::updateDocument): Ditto. (WebCore::V8Proxy::initContextIfNeeded): Ditto. (WebCore::V8Proxy::context): Changed to use v8::Local. (WebCore::V8Proxy::mainWorldContext): Changed to use m_context directly. (WebCore::V8Proxy::setContextDebugId): Ditto. (WebCore::toV8Context):
  • bindings/v8/V8Proxy.h: Removed shared_context decl, changed to use straight

v8::Persistent for m_context.

  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::workerProxy): Added. (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener): Removed

WorkerContextExecutionProxy* param.

(WebCore::V8WorkerContextEventListener::handleEvent): Started using ScriptExecutionContext*.
(WebCore::V8WorkerContextEventListener::reportError): Ditto.
(WebCore::V8WorkerContextEventListener::callListenerFunction): Ditto.
(WebCore::V8WorkerContextEventListener::getReceiverObject): Ditto.

  • bindings/v8/V8WorkerContextEventListener.h: (WebCore::V8WorkerContextEventListener::create): Removed

WorkerContextExecutionProxy* param.

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener): Removed ContextType*

template param.

  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener): Removed Frame* param. (WebCore::V8EventListener::getListenerFunction): Started using ScriptExecutionContext*. (WebCore::V8EventListener::callListenerFunction): Ditto.
  • bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create): Removed Frame* param.
11:10 Changeset [49948] by eric.carlson@apple.com
  • 4 edits in trunk/WebKit/mac

2009-10-22 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein & Simon Fraser.

<rdar://problem/7297717>
https://bugs.webkit.org/show_bug.cgi?id=30323
Play/pause button in full-screen video controller does not reflect current state

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController setMediaElement:WebCore::]): Register for QTMovieRateDidChangeNotification (-[WebVideoFullscreenController rateChanged:]): Call HUD controller when rate changes.
  • WebView/WebVideoFullscreenHUDWindowController.h:
  • WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Call updateRate so play button reflects playback state. (-[WebVideoFullscreenHUDWindowController updateRate]): New, set play button state according to movie state. (-[WebVideoFullscreenHUDWindowController playingChanged:]): Only call [self playing] once.
10:49 Changeset [49947] by darin@chromium.org
  • 5 edits in trunk/WebCore

2009-10-14 Gaurav Shah <gauravsh@google.com>

Reviewed by Darin Fisher.

Replaces temporary link stub for <keygen> tag handler for the Chromium
browser with a call via the Chromium Bridge.

https://bugs.webkit.org/show_bug.cgi?id=30360

  • platform/SSLKeyGenerator.h:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/SSLKeyGeneratorChromium.cpp: (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
  • platform/chromium/TemporaryLinkStubs.cpp: (WebCore::KURL::fileSystemPath): (WebCore::SharedBuffer::createWithContentsOfFile):
10:48 Changeset [49946] by atwilson@chromium.org
  • 3 edits in trunk/WebCore

Fixes Chromium Mac pasteboard handling to flow through the same code paths as other platforms.

Patch by Avi Drissman <avi@chromium.org> on 2009-10-22
Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30591

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeImage):

10:33 Changeset [49945] by simon.fraser@apple.com
  • 6 edits in trunk/WebCore

2009-10-20 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Make accelerated compositing debug indicators work in release builds
https://bugs.webkit.org/show_bug.cgi?id=30588

Allow some debug indicators, that show which page elements go into compositing layers,
to work in release builds, when the runtime prefs are set.

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer): (WebCore::GraphicsLayer::setZPosition):
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::clearBorderColor): (WebCore::GraphicsLayer::showRepaintCounter): (WebCore::GraphicsLayerCA::GraphicsLayerCA): (WebCore::GraphicsLayerCA::updateMasksToBounds): (WebCore::GraphicsLayerCA::updateLayerDrawsContent): (WebCore::GraphicsLayerCA::setDebugBorder): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): (WebCore::GraphicsLayerCA::setupContentsLayer):
  • platform/graphics/mac/WebLayer.mm:
10:30 Changeset [49944] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-22 Xan Lopez <xlopez@igalia.com>

Skip failing tests that seems to be somewhat tied to the Mac
platform. See https://bugs.webkit.org/show_bug.cgi?id=30680

  • platform/gtk/Skipped:
09:42 Changeset [49943] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

Code standarlization for QGVLauncher.

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-22
RubberStamped by Tor Arne Vestbø.

1) Made member initilization lists in constructors

to be per line.

2) Made applyProxy method inline as all other methods in

WebPage class.

  • QGVLauncher/main.cpp:

(WebPage::WebPage):
(WebPage::applyProxy):
(MainView::MainView):
(MainWindow::MainWindow):
(MainWindow::init):

09:34 Changeset [49942] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

Add a Y-Axis rotation to QGVLauncher.

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-22
Reviewed by Tor Arne Vestbø.

It uses the QStateMachine API from Qt 4.6.

  • QGVLauncher/main.cpp:

(WebView::WebView):
(WebView::setYRotation):
(WebView::yRotation):
(MainView::flip):
(MainView::animatedYFlip):
(SharedScene::SharedScene):
(SharedScene::webView):
(MainWindow::init):
(MainWindow::animatedYFlip):
(MainWindow::buildUI):

08:53 Changeset [49941] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-22 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Fix video-played.js to use an error timeout based on time rather than function call count.

https://bugs.webkit.org/show_bug.cgi?id=30657

  • media/video-played.js: (nowInSecs): Returns the current time in seconds. (playForMillisecs.callPauseIfTimeIsReached): Change from call counts to using elapsed time. (playForMillisecs): Ditto.
08:45 Changeset [49940] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-22 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Inspector should support monitorEvents/un monitorEvents() in the command line
https://bugs.webkit.org/show_bug.cgi?id=19879

  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update.callback): Ignores event listeners generated by monitorEvent
  • inspector/front-end/InjectedScript.js: (InjectedScript._ensureCommandLineAPIInstalled): Added _inspectorCommandLineAPI._logEvent, _allEventTypes, _normalizeEventTypes, monitorEvent, unmonitorEvent.
08:28 Changeset [49939] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2009-10-21 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: windowFocused and windowBlurred Fail to Clear/Mark Inspector as "inactive"
https://bugs.webkit.org/show_bug.cgi?id=30663

08:23 Changeset [49938] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2009-10-22 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Error - requestContentType [undefined] is not an object
https://bugs.webkit.org/show_bug.cgi?id=30666

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshFormData):
04:52 Changeset [49937] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-22 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Holger Freyther.

[Haiku] Correction of the accented letter width (they were 2 characters long).
https://bugs.webkit.org/show_bug.cgi?id=30629

  • platform/graphics/haiku/SimpleFontDataHaiku.cpp: (WebCore::SimpleFontData::platformWidthForGlyph):
03:49 Changeset [49936] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-22 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

m_webView should be private attribute of the EditorClientGtk.
https://bugs.webkit.org/show_bug.cgi?id=30664

  • WebKit/gtk/WebCoreSupport/EditorClientGtk.h:
03:39 Changeset [49935] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-22 Xan Lopez <xlopez@igalia.com>

libsoup can reconstruct URIs with empty querys now, so unskip
another bunch of tests.

  • platform/gtk/Skipped:
03:24 Changeset [49934] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-22 Xan Lopez <xlopez@igalia.com>

Unskip a couple of working tests.

  • platform/gtk/Skipped:
00:15 Changeset [49933] by jhoneycutt@apple.com
  • 6 edits in trunk

<rdar://problem/7270320> Screenshots of off-screen plug-ins are blank
<rdar://problem/7270314> After halting a transparent PluginView on
Windows, the transparency is applied twice

JavaScriptCore:

Reviewed by Dan Bernstein.

Export WTF::deleteOwnedPtr(HDC).

Ditto.

WebCore:

Replace use of Frame::nodeImage() with a function that takes a snapshot
of a PluginView.

Reviewed by Dan Bernstein.

  • plugins/PluginView.h:

Made paintWindowedPluginIntoContext() non-const, as it now calls
paintIntoTransformedContext(). Declare paintIntoTransformedContext()
and snapshot() for Windows platforms.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paintIntoTransformedContext):
Paints into the passed HDC without applying any coordinate translations.
Code moved from paintWindowedPluginIntoContext() and paint(). Removed
the memset() of windowpos in lieu of assignment.
(WebCore::PluginView::paintWindowedPluginIntoContext):
Code moved to paintIntoTransformedContext().
(WebCore::PluginView::paint):
Ditto.
(WebCore::PluginView::snapshot):
Create a context, and if the plug-in is windowless, translate it so the
plug-in will draw at the correct location. Create a bitmap, and select
it into the context. Paint the plug-in, and create a BitmapImage from
the bitmap.
(WebCore::PluginView::halt):
Use snapshot().

00:11 Changeset [49932] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-22 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix calculation of length in WebSocketChannel.cpp
https://bugs.webkit.org/show_bug.cgi?id=30656

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):
Note: See TracTimeline for information about the timeline view.