Timeline


and

10/27/09:

23:50 Changeset [50200] by mitz@apple.com

Rubber-stamped by Sam Weinig.

Changed this test to use -webkit-box-shadow instead of box-shadow after r49003.

  • fast/box-shadow/inset.html:
23:43 Changeset [50199] by joepeck@webkit.org

2009-10-27 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Move runAfterPendingDispatches to TestController for Clarity
https://bugs.webkit.org/show_bug.cgi?id=30844

  • inspector/front-end/TestController.js: (WebInspector.TestController.prototype.runAfterPendingDispatches):
  • inspector/front-end/inspector.js: moved runAfterPendingDispatches
22:19 Changeset [50198] by darin@chromium.org

2009-10-27 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

Add missing forward declaration of FramelessScrollView.
https://bugs.webkit.org/show_bug.cgi?id=30824

  • platform/chromium/FramelessScrollViewClient.h:
20:44 Changeset [50197] by cfleizach@apple.com

No review.

ARIA menu/menu item need AXRoleDescription
https://bugs.webkit.org/show_bug.cgi?id=30804

Layout test fix for Tiger/Leopard.

  • platform/mac-leopard/accessibility/table-with-aria-role-expected.txt:
20:39 Changeset [50196] by cfleizach@apple.com

WAI-ARIA: add support for 'presentation' role
https://bugs.webkit.org/show_bug.cgi?id=30806

Reviewed by Adele Peterson.

WebCore:

Test: accessibility/aria-presentational-role.html

  • accessibility/AccessibilityObject.h:

(WebCore::):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::RoleEntry::):

LayoutTests:

  • accessibility/aria-presentational-role-expected.txt: Added.
  • accessibility/aria-presentational-role.html: Added.
19:56 Changeset [50195] by cfleizach@apple.com

ARIA menu/menu item need AXRoleDescription
https://bugs.webkit.org/show_bug.cgi?id=30804

Reviewed by Darin Adler.

WebCore:

Make sure that role descriptions will default to the system's first, before
returning an unknown role.

Test: platform/mac/accessibility/aria-menu-role-descriptions.html

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper roleDescription]):

LayoutTests:

  • platform/mac/accessibility/aria-menu-role-descriptions-expected.txt: Added.
  • platform/mac/accessibility/aria-menu-role-descriptions.html: Added.
  • platform/mac/accessibility/table-with-aria-role-expected.txt:
19:20 Changeset [50194] by ggaren@apple.com

Qt build fix: migrated away from API that no longer exists.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

18:37 Changeset [50193] by ggaren@apple.com

Qt build fix: migrated away from API that no longer exists.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

18:30 Changeset [50192] by oliver@apple.com

Fix wording in comment.

18:26 Changeset [50191] by oliver@apple.com

Crash occurs after launching Newsfire 1.6 for the first time
https://bugs.webkit.org/show_bug.cgi?id=30807

Reviewed by Darin Adler.

We allocate an autorelease pool but then store it off the stack. In a
GC environment this led to it being collected, and thus caused badness
to ensue. To work around this we simply avoid using a pool at all in
a GC environment as it would be a no-op anyway.

18:07 Changeset [50190] by eric@webkit.org

2009-10-27 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

When a Geolocation method is called, immediately calls the error calback asynchronously if permissions have already been denied.
https://bugs.webkit.org/show_bug.cgi?id=27944.

  • fast/dom/Geolocation/resources/permission-denied-already-error.js: Added. Tests that when permission has already been denied, the error callback is invoked with code PERMISSION_DENIED, when the Geolocation service reports an error.
  • fast/dom/Geolocation/permission-denied-already-error.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/permission-denied-already-error-expected.txt: Added. Expected result for above test.
  • fast/dom/Geolocation/resources/permission-denied-already-success.js: Added. Tests that when permission has already been denied, the error callback is invoked with code PERMISSION_DENIED, when the Geolocation service has a good position fix.
  • fast/dom/Geolocation/permission-denied-already-success.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/permission-denied-already-success-expected.txt: Added. Expected result for above test.
  • fast/dom/Geolocation/resources/permission-denied.js: Modified. Updates error string.
  • fast/dom/Geolocation/permission-denied-expected.txt: Modified. Expected result for above test.
  • fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Modified. Updates error string.
  • fast/dom/Geolocation/permission-denied-expected-stops-watches.txt: Modified. Expected result for above test.
  • platform/gtk/Skipped: Modified. Adds above tests to skipped list.

2009-10-27 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

When a Geolocation method is called, immediately calls the error calback asynchronously if permissions
have already been denied.
https://bugs.webkit.org/show_bug.cgi?id=27944.

Tests: fast/dom/Geolocation/permission-denied-already-error.html

fast/dom/Geolocation/permission-denied-already-success.html

  • page/Geolocation.cpp: Modified. (WebCore::Geolocation::GeoNotifier::GeoNotifier): Modified. GeoNotifier takes Geolocation object as constructor argument. (WebCore::Geolocation::GeoNotifier::setFatalError): Added. Sets a fatal error for this notifier, causing it to terminate immediately and call the error callback asynchronously. (WebCore::Geolocation::GeoNotifier::timerFired): Added. Used to call the error callback asynchronously on fatal error. (WebCore::Geolocation::getCurrentPosition): Modified. Calls startRequest. (WebCore::Geolocation::watchPosition): Modified. Calls startRequest. (WebCore::Geolocation::startRequest): Added. Common functionality for starting a one-shot or watch request. Sets a fatal error on the notifier if permissions have already been denied. (WebCore::Geolocation::fatalErrorOccurred): Added. Registers that a notifier has encountered a fatal error and should be destroyed. (WebCore::Geolocation::setIsAllowed): Modified. Uses a standard error message for the error callback when permissions are denied.
  • page/Geolocation.h: Modified. (WebCore::Geolocation::isDenied): Added. Determines whether permissions have been denied.
17:58 Changeset [50189] by mrowe@apple.com

Versioning.

17:58 Changeset [50188] by mrowe@apple.com

New tag.

17:57 Changeset [50187] by mrowe@apple.com

Merge r50165.

17:21 Changeset [50186] by simon.fraser@apple.com

2009-10-27 Chris Marrin <cmarrin@apple.com>

Reviewed by Oliver Hunt.

Fixed a bug where I was using the wrong Canvas pointer to do a cross-domain check
https://bugs.webkit.org/show_bug.cgi?id=30840

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
17:18 Changeset [50185] by eric@webkit.org

2009-10-27 Eric Seidel <eric@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGStyledElement::getPresentationAttribute() can return a shared CSSValue (some SVG tests randomly fail on the bot, and in release builds)
https://bugs.webkit.org/show_bug.cgi?id=29620

  • svg/dom/getPresentationAttribute-cache-corruption-expected.txt: Added.
  • svg/dom/getPresentationAttribute-cache-corruption.svg: Added.

2009-10-27 Eric Seidel <eric@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGStyledElement::getPresentationAttribute() can return a shared CSSValue (some SVG tests randomly fail on the bot, and in release builds)
https://bugs.webkit.org/show_bug.cgi?id=29620

SVG was modifying CSSValues cached of off CSSMappedAttributeDeclarations.
This patch fixes the check to make sure that a new CSSMappedAttributeDeclaration is
created before returning a CSSValue that JavaScript can modify.

Test: svg/dom/getPresentationAttribute-cache-corruption.svg

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute):
16:32 Changeset [50184] by mitz@apple.com

Incomplete repaint of text field in relative positioned inline at imdb.com
https://bugs.webkit.org/show_bug.cgi?id=30047

Reviewed by Simon Fraser.

WebCore:

Test: fast/repaint/inline-relative-positioned.html

Implemented offsetFromContainer(), mapLocalToContainer() and
mapAbsoluteToLocalPoint() in RenderInline.

  • rendering/RenderBox.h: Fixed argument names in the declaration of

mapLocalToContainer().

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::offsetFromContainer):
(WebCore::RenderInline::mapLocalToContainer):
(WebCore::RenderInline::mapAbsoluteToLocalPoint):

  • rendering/RenderInline.h:

LayoutTests:

  • fast/repaint/inline-relative-positioned-expected.checksum: Added.
  • fast/repaint/inline-relative-positioned-expected.png: Added.
  • fast/repaint/inline-relative-positioned-expected.txt: Added.
  • fast/repaint/inline-relative-positioned.html: Added.
16:29 Changeset [50183] by ggaren@apple.com

JavaScriptCore: A little bit of refactoring in the date code.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27
Reviewed by Sam Weinig.

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

  • runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):

  • runtime/DateInstance.h: Removed some unused functions. Changed the default

constructor to ensure that a DateInstance is always initialized.

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype): Pass an initializer to our constructor,
since it now requires one.

  • wtf/DateMath.cpp:

(WTF::msToGregorianDateTime): Only compute our offset from UTC if our
output will require it. Otherwise, our offset is 0.

WebKit/mac: Updated for refactoring in the date code.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27
Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(aeDescFromJSValue): Since we just want a number of milliseconds, do that
instead of something more complicated.

16:22 Changeset [50182] by jorlow@chromium.org

Speculative build fix for Chromium.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-27

  • platform/graphics/GraphicsContext3D.h:
15:41 Changeset [50181] by cmarrin@apple.com

Make WebGL context failure more robust and make it succeed in more cases
https://bugs.webkit.org/show_bug.cgi?id=30349

Bubble a failure to get a CGLContext up to HTMLContextElement so it can
return null from getContext. Also added a more robust pixel format choosing
mechanism and can render correctly when a SW renderer is chosen.

15:20 Changeset [50180] by ggaren@apple.com

Mac build fix: a forwarding header.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

  • ForwardingHeaders/wtf/DateInstanceCache.h: Added.
15:12 Changeset [50179] by ggaren@apple.com

Build fix: Mark DateInstaceCache.h private, so other frameworks can see it.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

15:09 Changeset [50178] by ggaren@apple.com

Build fix: Updated for JavaScriptCore export changes.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

  • ForwardingHeaders/wtf/DateInstanceCache.h: Added.
15:09 Changeset [50177] by rniwa@webkit.org

No Review.

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-27
Making fontWeightIsBold static to fix Snow Leopard build.

  • editing/ApplyStyleCommand.cpp:

(WebCore::fontWeightIsBold):

15:04 Changeset [50176] by eric@webkit.org

2009-10-27 Kinuko Yasuda <kinuko@google.com>

Reviewed by Darin Adler.

Fixing a test case that yields FAIL results. Also updating
the corresponding expected results.
https://bugs.webkit.org/show_bug.cgi?id=30821

  • storage/domstorage/complex-values-expected.txt:
  • storage/domstorage/script-tests/complex-values.js:
15:04 Changeset [50175] by ggaren@apple.com

Build fix: re-readded this file.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

  • runtime/DateInstanceCache.h: Added.

(JSC::DateInstanceData::create):
(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::DateInstanceCache):
(JSC::DateInstanceCache::add):
(JSC::DateInstanceCache::lookup):

15:01 Changeset [50174] by ggaren@apple.com

JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=30800
Cache recently computed date data.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27
Reviewed by Darin Adler and Oliver Hunt.

SunSpider reports a ~0.5% speedup, mostly from date-format-tofte.js.

  • runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):
(JSC::DateInstance::getGregorianDateTime): Use the shared cache.

  • runtime/DateInstance.h: Renamed m_cache to m_data, to avoid the confusion

of a "cache cache".

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Pass an ExecState to these functions, so they
can access the DateInstanceCache.

  • runtime/JSGlobalData.h: Keep a DateInstanceCache.

JavaScriptGlue: Updated for JavaScriptCore export changes.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27
Reviewed by Oliver Hunt.

  • ForwardingHeaders/wtf/DateMath.h: Added.
14:51 Changeset [50173] by darin@chromium.org

2009-10-27 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Ensures that JavaScriptCore/wtf/CurrentTime.cpp is not built in PLATFORM(CHROMIUM) builds.

Chromium uses a different method to calculate the current time than is used in
JavaScriptCore/wtf/CurrentTime.cpp. This can lead to time skew when calls to currentTime() and Chromium's time
function are mixed. In particular, timers can get scheduled in the past which leads to 100% CPU use.
See http://code.google.com/p/chromium/issues/detail?id=25892 for an example.

https://bugs.webkit.org/show_bug.cgi?id=30833

14:50 Changeset [50172] by rniwa@webkit.org

WebKit cannot remove nested bold tags
https://bugs.webkit.org/show_bug.cgi?id=30784

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-27
Reviewed by Eric Seidel.

WebCore:

This patch modifies getPropertiesNotInComputedStyle so that it compares font-weight
more flexibly. Instead of comparing cssText, it uses fontWeightIsBold which converts
all font weights to either bold or unbold state.

  • editing/ApplyStyleCommand.cpp:

(WebCore::fontWeightIsBold):
(WebCore::getPropertiesNotInComputedStyle): Removes font-weight property
if two style have the same value under getFontWeightValue

LayoutTests:

Adds two more edge cases to remove-nested-inline-styles.js:
<b><b><b>12</b></b></b> and <b><b><b>1</b></b>2</b>
WebKit now passes the one existing test used to fail.

  • editing/style/remove-nested-inline-styles-expected.txt: Added two tests.
  • editing/style/script-tests/remove-nested-inline-styles.js: Added two tests.
14:04 Changeset [50171] by eric@webkit.org

2009-10-27 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

Give an ability to WebKit to free statically allocated pointers
before quit.
https://bugs.webkit.org/show_bug.cgi?id=27980

No new tests for this as the change does not affect WebKit
functionality, but only memory usage.

  • JavaScriptCore/wtf/StdLibExtras.h: Allowed for the override of DEFINE_STATIC_LOCAL via compiler commandline options or elsewhere in the code. Useful for implementing custom builds that free resources allocated via DEFINE_STATIC_LOCAL.
14:02 WebKit Team edited by joepeck@webkit.org
Added Myself (diff)
13:42 Changeset [50170] by dumi@chromium.org

Build fix, no review needed.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-27
Fixing the BUILD. m_estimatedSize in Database.h should be of type
'unsigned long' instead of 'unsigned long long'.

No tests required.

  • storage/Database.h:
13:14 Changeset [50169] by dumi@chromium.org

Refactoring the Database class to not depend on
OriginQuotaManager. Also, adding a SecurityOrigin copy to each
Database instance, that is safe to use on the file
thread. Finally, adding new simple fields and getters to the
Database object for storing/getting the display name and estimated
size specified by the user in the openDatabase() call.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-27
Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=30548

  • page/SecurityOrigin.h:
  • storage/Database.cpp:

(WebCore::Database::openDatabase): Storing the display name and
the estimated size in the Database object.
(WebCore::Database::Database): Storing the display name and the
estimated size in the Database object, as well as a SecurityOrigin
instance that is safe to use on the DB thread.
(WebCore::Database::maximumSize): Delegate the call to
DatabaseTracker::getMaxSizeForDatabase().
(WebCore::Database::databaseThreadSecurityOrigin): Return the
SecurityOrigin instance that's safe to use on the DB thread.
(WebCore::Database::threadSafeSecurityOrigin): Return the
SecurityOrigin instance that's safe to use on the current thread.
(WebCore::Database::displayName): Return the display name
specified by the user in the openDatabase() call.
(WebCore::Database::estimatedSize): Return the estimated size
specified by the user in the openDatabase() call.
(WebCore::Database::fileName): Return the name of the file where
the current Database is tored.

  • storage/Database.h:
  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase): Returns the
maximum size for a DB file based on the current size of that file
and the space available for that origin.

  • storage/DatabaseTracker.h:
  • storage/SQLTransaction.cpp:
  • storage/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didCommitTransaction): Use the
correct SecurityOrigin instance.

12:37 Changeset [50168] by joepeck@webkit.org

2009-10-27 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Pretty Print all HTML Collection Types like we do for NodeList
https://bugs.webkit.org/show_bug.cgi?id=30709

Test: inspector/console-format-collections.html

  • inspector/front-end/InjectedScript.js: (Object.type): check for instances of HTMLCollection like we do for NodeList
  • inspector/front-end/inspector.js: added WebInspector.pendingDispatches counter (WebInspector.dispatch): increment and decrement dispatch counter (WebInspector.runAfterPendingDispatches): run when there are no more dispatches
12:30 Changeset [50167] by eric@webkit.org

2009-10-27 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Adds XMLHttpRequest support to InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=30578

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willChangeXHRReadyState): (WebCore::InspectorTimelineAgent::didChangeXHRReadyState): (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::didLoadXHR):
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createXHRReadyStateChangeTimelineRecord): (WebCore::TimelineRecordFactory::createXHRLoadTimelineRecord):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
12:23 Changeset [50166] by kenneth@webkit.org

Rubberstamped by Oliver Hunt.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-27
Change two methods to be internal for DRT use only.

Part of [Qt] Review all new API in Qt 4.6
https://bugs.webkit.org/show_bug.cgi?id=29843#c11

WebKit/qt:

  • Api/qwebsecurityorigin.cpp:

(qt_drt_whiteListAccessFromOrigin):
(qt_drt_resetOriginAccessWhiteLists):
(QWebSecurityOrigin::localSchemes):

  • Api/qwebsecurityorigin.h:

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::whiteListAccessFromOrigin):

11:54 Changeset [50165] by adele@apple.com

WebCore: REGRESSION (Safari 4.0.3-ToT): After pressing Shift-PageDown, pressing Shift-Up
extends the top of the selection upwards (but should shrink the selection instead)
<rdar://problem/7269075>
https://bugs.webkit.org/show_bug.cgi?id=29981

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-27
Reviewed by Adele Peterson.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::modify): Added setting m_lastChangeWasHorizontalExtension.

LayoutTests: Test for <rdar://problem/7269075> REGRESSION (Safari 4.0.3-ToT): After pressing Shift-PageDown, pressing Shift-Up
extends the top of the selection upwards (but should shrink the selection instead)
https://bugs.webkit.org/show_bug.cgi?id=29981

  • editing/selection/shrink-selection-after-shift-pagedown-expected.txt: Added.
  • editing/selection/shrink-selection-after-shift-pagedown.html: Added.
11:45 Changeset [50164] by kenneth@webkit.org

Make sure that initiating a rotation while rotating won't make
it end up at rotation positions that are not a multiply of
180 degrees.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-27
Reviewed by Tor Arne Vestbø.

  • QGVLauncher/main.cpp:

(MainView::animatedFlip):

11:37 Changeset [50163] by bweinstein@apple.com

Rubber-stamped by Tim Hatcher.

Removed an extra console.log from ElementsTreeOutline.

  • inspector/front-end/ElementsTreeOutline.js:
11:26 Changeset [50162] by timothy@apple.com

WebCore: Rewrote JavaScriptSourceSyntaxHighlighter to be more accurate
https://bugs.webkit.org/show_bug.cgi?id=27147

Patch by Keishi Hattori <casey.hattori@gmail.com> on 2009-10-27
Reviewed by Timothy Hatcher.

Tests: LayoutTests/inspector/javascript-syntax-highlight.html

  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/SourceFrame.js:

(WebInspector.JavaScriptSourceSyntaxHighlighter.process): Added. Processes 100 tokens at a time.
(WebInspector.JavaScriptSourceSyntaxHighlighter.lex): Added. Scans for a token.
(WebInspector.JavaScriptSourceSyntaxHighlighter.appendNonToken): Added. Appends the non-token characters that lex ignored.
(WebInspector.JavaScriptSourceSyntaxHighlighter.syntaxHighlightNode): Added. To syntax highlight node in ElementsTreeOutline.

LayoutTests: Tests for JavaScript syntax highlighter.
https://bugs.webkit.org/show_bug.cgi?id=27147

Patch by Keishi Hattori <casey.hattori@gmail.com> on 2009-10-27
Reviewed by Timothy Hatcher.

  • inspector/javascript-syntax-highlight-expected.txt: Added.
  • inspector/javascript-syntax-highlight.html: Added.
11:21 Changeset [50161] by xan@webkit.org

2009-10-27 Xan Lopez <xlopez@igalia.com>

Skip a few more tests that are failing on and off.

  • platform/gtk/Skipped:
11:03 Changeset [50160] by eric@webkit.org

2009-10-27 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

[V8] Missing null check after string conversion in error reporting
https://bugs.webkit.org/show_bug.cgi?id=30774

Test case for toString conversion failure on an error object in
stack overflow situations. Test passes if it doesn't crash.

  • fast/dom/error-to-string-stack-overflow-expected.txt: Added.
  • fast/dom/error-to-string-stack-overflow.html: Added.

2009-10-27 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

[V8] Missing null check after string conversion in error reporting
https://bugs.webkit.org/show_bug.cgi?id=30774

Add null check after string conversion in error reporting code.
ToString conversion can fail for instance when an exception is
thrown during conversion.

Test: fast/dom/error-to-string-stack-overflow.html

  • bindings/v8/V8Utilities.cpp: (WebCore::reportException):
10:54 Changeset [50159] by steveblock@google.com

Use a pair of maps to store Geolocation watchers.
https://bugs.webkit.org/show_bug.cgi?id=29178

Reviewed by Darin Adler.

The pair of maps allows us to look up a watcher either by its ID or by its GeoNotifier object.
The ability to look up by a watcher by its GeoNotifier object will be required when implementing
Geolocation::fatalErrorOccurred. See https://bugs.webkit.org/show_bug.cgi?id=27944

  • page/Geolocation.cpp: Modified.

(WebCore::Geolocation::Watchers::set): Added. Adds a watcher with the given ID.
(WebCore::Geolocation::Watchers::remove): Added. Removes a watcher by ID.
(WebCore::Geolocation::Watchers::remove): Added. Removes a watcher by GeoNotifier object.
(WebCore::Geolocation::Watchers::clear): Added. Removes all watchers.
(WebCore::Geolocation::Watchers::isEmpty): Added. Determines if there are no watchers.
(WebCore::Geolocation::Watchers::getNotifiersVector): Added. Gets a vector of the GeoNotifier objects.
(WebCore::Geolocation::watchPosition): Modified. Rename watcher identifier static variable.
(WebCore::Geolocation::stopTimersForWatchers): Modified. Use Watchers::getNotifiersVector.
(WebCore::Geolocation::handleError): Modified. Use Watchers::getNotifiersVector.
(WebCore::Geolocation::makeSuccessCallbacks): Modified. Use Watchers::getNotifiersVector.

  • page/Geolocation.h: Modified. Adds Geolocation::Watchers class.
10:45 Changeset [50158] by jorlow@chromium.org

2009-10-27 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] DOM Storage runtime flag should default to on
https://bugs.webkit.org/show_bug.cgi?id=30828

The DOM Storage runtime flag was supposed to default to on. I accidentally
changed the logic to default to false when I moved the flag.

  • bindings/v8/RuntimeEnabledFeatures.cpp:
10:38 Changeset [50157] by eric@webkit.org

2009-10-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION: svn-apply exits(1) when applying a patch with a file add
https://bugs.webkit.org/show_bug.cgi?id=30826

  • Scripts/svn-apply:
    • Add () around all system() calls.
    • Use the correct system() == 0 or die instead of system() or die
    • Add descriptive messages to all die statements.
10:35 Changeset [50156] by steveblock@google.com

Adds steveblock@google.com to list of committers.

Reviewed by NOBODY.

10:00 Changeset [50155] by eric@webkit.org

2009-10-27 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Dimitri Glazkov.

Fix crash found in chromium test_shell.
https://bugs.webkit.org/show_bug.cgi?id=30808

When WebSocket is deleted without close, webkit would crash
when it handles didClose.

Check scriptExecutionContext before post task for event.
Use WebSocketChannel::disconnect() instead of close() in WebSocket
destructor, so that WebSocketChannel should not call deleted WebSocket
back in didClose().
To make sure WebSocketChannel alive while it is processing WebSocket
protocol over SocketStreamHandle, ref() in connect() and deref() in
didClose().

  • websockets/WebSocket.cpp: (WebCore::WebSocket::~WebSocket): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): (WebCore::WebSocket::didClose):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::connect): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData):
  • websockets/WebSocketChannel.h:
09:49 Changeset [50154] by mitz@apple.com

JavaScriptGlue: Updated license

Reviewed by Darin Adler.

  • LICENSE:

WebCore: Updated Apple license

Reviewed by Darin Adler.

  • LICENSE-APPLE:

WebKit: Updated license

Reviewed by Darin Adler.

  • LICENSE:
09:43 Changeset [50153] by beidson@apple.com

Rubberstamped by Sam Weinig.

Re-enable the check that disallows pages with unload handlers in the page cache.

<rdar://problem/7196485> and http://webkit.org/b/29021

WebCore:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):

LayoutTests:

  • platform/mac/Skipped:
  • platform/win/Skipped:
09:30 Changeset [50152] by timothy@apple.com

Remove more empty files that didn't get removed earlier.

  • inspector/DOMDispatchTimelineItem.cpp: Removed.
  • inspector/DOMDispatchTimelineItem.h: Removed.
08:34 Changeset [50151] by ossy@webkit.org

[Qt] Fix assertion crashes introduced by changes made in r50110.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-27
Reviewed by Tor Arne Vestbø.

  • dom/XMLTokenizerQt.cpp:

(WebCore::XMLTokenizer::parseEndElement): only call popCurrentNode() if there are nodes left in the stack.

08:27 Changeset [50150] by timothy@apple.com

Remove empty files that didn't get removed earlier.

  • inspector/TimelineItem.cpp: Removed.
  • inspector/TimelineItem.h: Removed.
07:44 Changeset [50149] by kenneth@webkit.org

Unreviewed Qt build fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-27
Update the tests as well to the new API change.

  • tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::clear):

07:28 Changeset [50148] by xan@webkit.org

2009-10-27 Xan Lopez <xlopez@igalia.com>

Another typo.

  • platform/gtk/Skipped:
07:22 Changeset [50147] by kenneth@webkit.org

Rubberstamped by Tor Arne Vestbø.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-27
[Qt] QWebElement::removeChildren() should be
QWebElement::removeAllChildren()
https://bugs.webkit.org/show_bug.cgi?id=30630

  • Api/qwebelement.cpp:

(QWebElement::removeAllChildren):

  • Api/qwebelement.h:
07:18 Changeset [50146] by xan@webkit.org

2009-10-27 Xan Lopez <xlopez@igalia.com>

Fix typo in test names.

  • platform/gtk/Skipped:
07:02 Changeset [50145] by xan@webkit.org

2009-10-27 Xan Lopez <xlopez@igalia.com>

Skip a few tests with links to their tracking bugs.

  • platform/gtk/Skipped:
06:57 Changeset [50144] by tonikitoo@webkit.org

This reverts commit r50141 that wrongly messed up the WebCore/ChangeLog

06:51 Changeset [50143] by ossy@webkit.org

Rubber-stamped by Tor Arne Vestbø.

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2009-10-27
Fix typo in RegexInterpreter.cpp and RegexJIT.cpp alterantive to
alternative.

  • yarr/RegexInterpreter.cpp:

(JSC::Yarr::ByteCompiler::alternativeBodyDisjunction):
(JSC::Yarr::ByteCompiler::alternativeDisjunction):
(JSC::Yarr::ByteCompiler::emitDisjunction):

  • yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::generateDisjunction):

06:38 Changeset [50142] by tonikitoo@webkit.org

Make QWebPagePrivate's (QWidget) view to be a QWeakPointer.
https://bugs.webkit.org/show_bug.cgi?id=30779

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-27
Reviewed by Antti Koivisto and Holger Freyther.

The fact that it was been set from external objects of qwebpage
and not being deleted internally can lead to dangling references.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::~QGraphicsWebView):

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::createContextMenu):
(QWebPagePrivate::handleSoftwareInputPanel):
(QWebPagePrivate::keyPressEvent):
(QWebPage::setView):
(QWebPage::view):
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
(QWebPage::shouldInterruptJavaScript):
(QWebPage::createWindow):
(QWebPage::extension):
(QWebPage::chooseFile):
(QWebPage::userAgentForUrl):

  • Api/qwebpage_p.h:
  • Api/qwebview.cpp:

(QWebView::~QWebView):

06:37 Changeset [50141] by tonikitoo@webkit.org

2009-10-20 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: populate child nodes before sorting them.

https://bugs.webkit.org/show_bug.cgi?id=29673

  • inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode): Swapped with BottomUpProfileDataGridTree to be consistent with TopDownProfileDataGridNode. (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild): (WebInspector.BottomUpProfileDataGridNode.prototype._exclude): (WebInspector.BottomUpProfileDataGridNode.prototype._merge): (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate): (WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
  • inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.sort): Added missing parentheses. (WebInspector.ProfileDataGridNode.prototype.get _parent): (WebInspector.ProfileDataGridNode.prototype._populate):
  • inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):
05:20 Changeset [50140] by xan@webkit.org

2009-10-27 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25534
[GTK] Objects of ROLE_TABLE should implement the accessible table interface

First part of the implementation of AtkTable.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getCell): (getCellIndex): (webkit_accessible_table_ref_at): (webkit_accessible_table_get_index_at): (webkit_accessible_table_get_n_columns): (webkit_accessible_table_get_n_rows): (webkit_accessible_table_get_column_extent_at): (webkit_accessible_table_get_row_extent_at): (webkit_accessible_table_get_row_header): (atk_table_interface_init): (AtkInterfacesInitFunctions): (GetAtkInterfaceTypeFromWAIType):
04:33 Changeset [50139] by vestbo@webkit.org

[Qt] Don't lose remainder when computing wheel event deltas

Reviewed by Lars Knoll.

  • platform/qt/WheelEventQt.cpp:
03:17 Changeset [50138] by eric@webkit.org

2009-10-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Antti Koivisto.

Fix QtWebKit build for WIN_OS if Netscape plug-in support
is turned off and refactor some related code
https://bugs.webkit.org/show_bug.cgi?id=30786

No new tests as there is no new functionality introduced.

  • platform/FileSystem.h: Refactor to make sure that each different type definition is only repeated once.
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::compareFileVersion): Move it out from the ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH guard and combine it with the function body from PluginPackageWin.
  • plugins/win/PluginPackageWin.cpp: Remove compareFileVersion as it is now in PluginPackage.cpp.
03:09 Changeset [50137] by eric@webkit.org

2009-10-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

svn-apply can exit(0) even on patch failure
https://bugs.webkit.org/show_bug.cgi?id=29622

  • Scripts/svn-apply:
    • Add a bunch of "or die" statements, hopefully catching all possible cases where failure could still exit(0).
03:01 Changeset [50136] by eric@webkit.org

2009-10-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

svn-* scripts should share code through VCSUtils.pm
https://bugs.webkit.org/show_bug.cgi?id=30791

Just moving code into a shared location.

  • Scripts/VCSUtils.pm:
  • Scripts/prepare-ChangeLog:
  • Scripts/resolve-ChangeLogs:
  • Scripts/svn-apply:
  • Scripts/svn-create-patch:
  • Scripts/svn-unapply:
  • Scripts/update-webkit:
02:54 Changeset [50135] by eric@webkit.org

2009-10-27 Vadim Zeitlin <vadim@wxwidgets.org>

Suppress a huge number of MSVC warnings when building wxWebKit.

  • wx/build/settings.py:
02:20 Changeset [50134] by xan@webkit.org

2009-10-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=27011
[Gtk] Implement support for get_index_in_parent

Implement atk_object_get_index_in_parent.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_index_in_parent):
02:07 Changeset [50133] by eric@webkit.org

2009-10-27 Eric Seidel <eric@webkit.org>

No review, rolling out r50131.
http://trac.webkit.org/changeset/50131

  • bridge/objc/objc_instance.h:
  • bridge/objc/objc_instance.mm: (ObjcInstance::ObjcInstance): (ObjcInstance::virtualEnd):
00:12 Changeset [50132] by dbates@webkit.org

2009-10-26 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30491

Fixes an issue where pressing return/enter on the keyboard
in <isindex> does not submit it if is not within a <form>.

According to the HTML 2.0 thru HTML 4.01 spec
(http://www.w3.org/MarkUp/html-spec/html-spec_7.html#SEC7.5), the
<isindex> element does not need to be within a <form> element in
order to submit it. It can submitted on its own. Also, if present,
the href property of the <base> element will dictate where to submit
the value of the <isindex> element (this is analogous to the action
property of the <form> element).

Tests: http/tests/misc/isindex-with-no-form-base-href.html

http/tests/misc/isindex-with-no-form.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Calls createTemporaryFormForIsIndex() to create a <form> if none is present and we are an <isindex> element. (WebCore::HTMLInputElement::createTemporaryFormForIsIndex): Added.
  • html/HTMLInputElement.h:

2009-10-26 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30491

Test that the <isindex> element can be submitted without being enclosed
within a <form> element. Also tests that the href property of the <base>
element can be used to direct where the submission is sent.

  • http/tests/misc/isindex-with-no-form-base-href-expected.txt: Added.
  • http/tests/misc/isindex-with-no-form-base-href.html: Added.
  • http/tests/misc/isindex-with-no-form-expected.txt: Added.
  • http/tests/misc/isindex-with-no-form.html: Added.
  • http/tests/misc/resources/isindex-with-no-form-base-href-submit.html: Added.
  • http/tests/misc/resources/isindex-with-no-form-base-href.html: Added.
00:10 Changeset [50131] by oliver@apple.com

Crash occurs after launching Newsfire 1.6 for the first time
https://bugs.webkit.org/show_bug.cgi?id=30807

Reviewed by Maciej Stachowiak.

Use a RetainPtr in ObjcBinding to ensure that we adequately
protect the autorelease pool from GC in GC'd applications.

10/26/09:

21:48 Changeset [50130] by eric@webkit.org

2009-10-26 Eric Seidel <eric@webkit.org>

No review, just adding Mike Belshe to the committers list.

  • Scripts/modules/committers.py:
21:48 Changeset [50129] by mrowe@apple.com

Versioning.

21:47 Changeset [50128] by mrowe@apple.com

New tag.

20:57 Changeset [50127] by laszlo.1.gombos@nokia.com

2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed.

[Qt] Build fix for QtWebKit after r50125.

  • WebCore.pro: Rename TimelineItem to TimelineRecord.
20:38 Changeset [50126] by eric@webkit.org

2009-10-26 Matt Mueller <mattm@chromium.org>

Reviewed by Darin Adler.

Refactor synchronizable property handling to store one shouldSynchronize flag per set of properties rather than one per property.

Fixes reading uninitialized memory in SynchronizableProperty hash function as well as simplifying the code.

https://bugs.webkit.org/show_bug.cgi?id=30658

Covered by running various svg tests under valgrind, ex:
LayoutTests/svg/custom/js-late-mask-and-object-creation.svg

  • svg/SynchronizablePropertyController.cpp: (WebCore::SynchronizableProperties::addProperty): (WebCore::SynchronizableProperties::synchronize): (WebCore::SynchronizableProperties::startAnimation): (WebCore::SynchronizableProperties::stopAnimation): (WebCore::SynchronizablePropertyController::registerProperty): (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization): (WebCore::SynchronizablePropertyController::synchronizeProperty): (WebCore::SynchronizablePropertyController::synchronizeAllProperties): (WebCore::SynchronizablePropertyController::startAnimation): (WebCore::SynchronizablePropertyController::stopAnimation):
  • svg/SynchronizablePropertyController.h: (WebCore::SynchronizableProperties::SynchronizableProperties): (WebCore::SynchronizableProperties::setNeedsSynchronization):
20:24 Changeset [50125] by eric@webkit.org

2009-10-26 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Renames TimelineItem to TimelineRecord and updates all call sites.
https://bugs.webkit.org/show_bug.cgi?id=30785

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addRecordToTimeline):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willFireTimer): (WebCore::InspectorTimelineAgent::didFireTimer): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
  • inspector/InspectorTimelineAgent.h: (WebCore::): (WebCore::InspectorTimelineAgent::RecordEntry::RecordEntry):
  • inspector/TimelineItemFactory.cpp: Removed.
  • inspector/TimelineItemFactory.h: Removed.
  • inspector/TimelineRecordFactory.cpp: Added. (WebCore::TimelineRecordFactory::createGenericRecord): (WebCore::TimelineRecordFactory::createDOMDispatchRecord): (WebCore::TimelineRecordFactory::createGenericTimerRecord): (WebCore::TimelineRecordFactory::createTimerInstallRecord):
  • inspector/TimelineRecordFactory.h: Added. (WebCore::TimelineRecordFactory::TimelineRecordFactory):
  • inspector/front-end/TimelineAgent.js: (WebInspector.addRecordToTimeline):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype.getRecordTypeName): (WebInspector.TimelineRecordTreeElement.prototype.onattach):
19:56 Changeset [50124] by zecke@webkit.org

Unreviewed spelling fix in the PluginViewQt.cpp

This error was pointed out in the bug report and it was agreed to
do the spelling fix when landing the patch. Fix it now.

19:50 Changeset [50123] by eric@webkit.org

2009-10-26 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Antti Koivisto.

[Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled

When printing, QPrinter's preview mode uses a QPicture to capture the output. The
QPicture holds a reference to the X Pixmap. As a result, the print preview would
update itself when the X Pixmap changes. To prevent the print preview from updating
whenever m_drawable is updated (i.e when the view updates), we create a copy.

We require that a QPixmap::copy() result in a QPixmap backed by a XPixmap
regardless of the graphicssystem. This is taken care of by
commit d310f7c710ecb331a9689861f0551eabd38e946e in Qt (4.6)

The beauty of this patch is that the newly created X Pixmap is managed by Qt and
it will free the Pixmap whenever the user closes the print preview dialog and
handles the case of displaying multiple preview dialogs nicely.

All credit to Samuel Rødal for suggesting usage of QPixmap::copy().

https://bugs.webkit.org/show_bug.cgi?id=30714

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint):
19:42 Changeset [50122] by eric@webkit.org

2009-10-26 Benjamin Otte <otte@gnome.org>

Reviewed by Gustavo Noronha.

Don't store properties in the MediaPlayerPrivate class

Access them via the MediaPlayer class instead.
https://bugs.webkit.org/show_bug.cgi?id=30462

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
19:27 Changeset [50121] by bweinstein@apple.com

Fixes <http://webkit.org/b/30801>.
Web Inspector: Control + ]/[ on Windows doesn't change Panels.

Reviewed by Timothy Hatcher.

In my testing, Windows uses "U+00DB" and "U+00DD" to represent
[ and ], so we should honor those as well.

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

19:10 Changeset [50120] by laszlo.1.gombos@nokia.com

2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

Make .rc files compile on Windows without depending on MFC headers
https://bugs.webkit.org/show_bug.cgi?id=30750

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc: Use winresrc.h because it exists even when MFC is not installed, and is all that's needed here.
  • WebCore.vcproj/QTMovieWin.rc: Ditto.
  • WebKit.vcproj/WebKit.rc: Ditto.
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use windows.h instead of afxres.h because it exists even when MFC is not installed, and is all that's needed here.
  • FindSafari/FindSafari.rc: Ditto
18:56 Changeset [50119] by bweinstein@apple.com

Unreviewed - Updating getComputedStyle results for Windows.

Updating getComputedStyle results for Windows.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
18:09 Changeset [50118] by bfulgham@webkit.org

Build corrections for ENABLE_FILTERS in Windows.
https://bugs.webkit.org/show_bug.cgi?id=30797

Reviewed by Darin Adler.

Build correction for ENABLE_FILTERS feature. No new tests needed.

  • platform/graphics/filters/FEColorMatrix.cpp: Use MathExtras.h and its piDouble constant.
  • platform/graphics/filters/FEGaussianBlur.cpp: Use MathExtras.h and its piDouble constant. Remove unnecessary call to floor used in the division of an unsigned, converting to int.
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: Correct include style for MathExtras.h.
18:04 WikiStart edited by timothy@apple.com
Remove some other old pages. (diff)
18:01 WikiStart edited by timothy@apple.com
Remove some old pages for Developer Tools. (diff)
17:53 Changeset [50117] by mitz@apple.com

Updated BSD License

Reviewed by Adele Peterson.

  • coding/bsd-license.html: Updated to the latest version.
17:19 Changeset [50116] by beidson@apple.com

<rdar://problem/7289467> and http://webkit.org/b/30798 - REGRESSION (r48687): www.myuhc.com doesn't load.

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/grandparent-completion-starts-redirect.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::completed): Notify all descendants that the load completed, not just direct children.

LayoutTests:

  • fast/loader/grandparent-completion-starts-redirect-expected.txt: Added.
  • fast/loader/grandparent-completion-starts-redirect.html: Added.
  • fast/loader/resources/meta-redirect-to-notify-done.html: Added.
  • fast/loader/resources/parent-of-redirect.html: Added.
16:56 Changeset [50115] by mitz@apple.com

WebCore: Re-add CSSPropertyWebkitBackgroundSize in one more place

Reviewed by Beth Dakin.

Fixes transitions/multiple-background-size-transitions.html, transitions/background-transitions.html

  • page/animation/AnimationBase.cpp:

(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):

LayoutTests: Use -webkit-background-size as the transition property in this test now
that it is distinct from background-size.

Reviewed by Sam Weinig.

  • transitions/multiple-background-size-transitions.html:
16:56 Changeset [50114] by mrowe@apple.com

Clean up the regex madness in auto-version.sh to make it obvious what the script is doing.

Reviewed by Adam Roben.

Also teaches auto-version.sh to handle RC_PROJECTSOURCEVERSION that has more than three digits
in the major component of the version number.

  • win/tools/scripts/auto-version.sh:
16:44 Changeset [50113] by jorlow@chromium.org

2009-10-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Tidy up the DOM Storage runtime flag stuff
https://bugs.webkit.org/show_bug.cgi?id=30794

Clean up the DOM Storage runtime flag stuff to match the new way of doing
things. No behavioral changes.

  • bindings/v8/RuntimeEnabledFeatures.cpp:
  • bindings/v8/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setDatabaseEnabled): (WebCore::RuntimeEnabledFeatures::databaseEnabled): (WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled): (WebCore::RuntimeEnabledFeatures::localStorageEnabled): (WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled): (WebCore::RuntimeEnabledFeatures::sessionStorageEnabled):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
  • storage/Storage.cpp:
  • storage/Storage.h:
16:27 Changeset [50112] by mitz@apple.com

Rubber-stamped by Beth Dakin.

Update expedted results after r50108.

  • svg/css/getComputedStyle-basic-expected.txt:
16:20 Changeset [50111] by beidson@apple.com

<rdar://problem/7308952> and http://webkit.org/b/30424 - REGRESSION (r48687): Pages on ucas.com appear blank.

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/history-forward-in-head.html

  • loader/RedirectScheduler.cpp:

(WebCore::RedirectScheduler::scheduleHistoryNavigation): Restore the moved canGoBackOrForward() check.

This restores the side effect of an invalid history navigation canceling previous scheduled redirects
and also fixes the bug of scheduling an invalid history navigation canceling parsing of the current document.

(WebCore::RedirectScheduler::timerFired): Removed the canGoBackOrForward() check as it is now made before

the redirect is scheduled.

LayoutTests:

  • fast/loader/history-forward-in-head-expected.txt: Added.
  • fast/loader/history-forward-in-head.html: Added.
16:11 Changeset [50110] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30049
<rdar://problem/7286002> Manipulating DOM from a script while parsing XHTML can cause a crash

Tests: fast/parser/remove-current-node-parent-x-2.xhtml

fast/parser/remove-current-node-parent-x.xhtml

  • dom/XMLTokenizer.h: Store the whole stack of parent nodes - element.parentNode() is unreliable after DOM manipulation.
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::pushCurrentNode): Push the new node onto stack. (WebCore::XMLTokenizer::popCurrentNode): This is now called instead of setCurrentNode when exiting a node. (WebCore::XMLTokenizer::clearCurrentNodeStack): We're aborting; or just done parsing. This replaces setCurrentNode(0). (WebCore::XMLTokenizer::enterText): Call pushCurrentNode(). (WebCore::XMLTokenizer::exitText): Call popCurrentNode(), removing a long-standing FIXME (not sure if it was ever practical though - how can a parent become null while adding text?)
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::~XMLTokenizer): Call clearCurrentNodeStack(). (WebCore::XMLTokenizer::startElementNs): Call pushCurrentNode(). (WebCore::XMLTokenizer::endElementNs): Call popCurrentNode() to safely get to a parent. Also added a check fo script element still being in document - Firefox parses those that aren't, but doesn't execute them.
  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::~XMLTokenizer): (WebCore::XMLTokenizer::parseStartElement): (WebCore::XMLTokenizer::parseEndElement): Match libxml2 version changes.
15:49 Changeset [50109] by eric@webkit.org

2009-10-26 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

The thunkReturnAddress is on JITStackFrame on ARM JIT as well
https://bugs.webkit.org/show_bug.cgi?id=30782

Move the thunkReturnAddress from top of the stack into the JITStackFrame
structure. This is a requirement for JSValue32_64 support on ARM.

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::ret): Return with link register (JSC::MacroAssemblerARM::prepareCall): Store the return address in link register
  • jit/JIT.h: Remove unused ctiReturnRegister
  • jit/JITInlineMethods.h: Same as ARMv7 (JSC::JIT::restoreArgumentReference): Ditto. (JSC::JIT::restoreArgumentReferenceForTrampoline): Ditto.
  • jit/JITOpcodes.cpp: Remove ctiReturnRegister related instruction
  • jit/JITStubs.cpp: Store thunkReturnAddress on JITStackFrame. Use small trampoline functions which handle return addresses for each CTI_STUB_FUNCTION.
  • jit/JITStubs.h: Store thunkReturnAddress on JITStackFrame (JSC::JITStackFrame::returnAddressSlot): Return with the address of thunkReturnAddress
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): Remove the unnecessary instruction
15:41 Changeset [50108] by mitz@apple.com

background-size: X treated as background-size: X X, not background-size: X auto
https://bugs.webkit.org/show_bug.cgi?id=28440

Reviewed by Beth Dakin.

WebCore:

Updated fast/backgrounds/size/resources/parsing-background-size-values.js
and fast/backgrounds/size/resources/parsing-inherit.js

Reinstated -webkit-background-size and kept its behavior of filling in
the second value with the first one; and changed background-size to have
the behavior of filling in the second value with 'auto'.

  • css/CSSComputedStyleDeclaration.cpp:

(computedProperties): Re-added CSSPropertyWebkitBackgroundSize.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Ditto.
(WebCore::CSSParser::parseFillSize): Adapted for the new parsing rule.
(WebCore::CSSParser::parseFillProperty): Re-added
CSSPropertyWebkitBackgroundSize.
(WebCore::cssPropertyID): Removed mapping of -webkit-background-size to
background-size.

  • css/CSSParser.h:
  • css/CSSPropertyNames.in: Re-added -webkit-background-size.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Re-added
CSSPropertyWebkitBackgroundSize.

LayoutTests:

  • fast/backgrounds/size/parsing-background-size-values-expected.txt:
  • fast/backgrounds/size/parsing-inherit-expected.txt:
  • fast/backgrounds/size/resources/parsing-background-size-values.js:

(test):

  • fast/backgrounds/size/resources/parsing-inherit.js:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
15:41 Changeset [50107] by eric@webkit.org

2009-10-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool post-diff should know how to mark commit-queue=?
https://bugs.webkit.org/show_bug.cgi?id=29202

  • Scripts/bugzilla-tool:
    • Add --commit-queue option to post-diff, post-commits and create-bug.
  • Scripts/modules/bugzilla.py:
    • Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
    • Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
15:37 Changeset [50106] by weinig@apple.com

Move some WebView event handling code into its own file, WebViewEventHandling.mm

Reviewed by Anders Carlsson.

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _close]):
(-[WebView _selectedOrMainFrame]):

  • WebView/WebViewEventHandling.mm: Added.

(-[WebView _closingEventHandling]):
(-[WebView _setMouseDownEvent:]):
(-[WebView mouseDown:]):
(-[WebView mouseUp:]):
(+[WebView _updateMouseoverWithEvent:]):
(-[WebView _updateMouseoverWithFakeEvent]):
(_updateMouseoverWithEvent:fakeEvent::if):
(-[WebView _stopAutoscrollTimer]):
(-[WebView _setToolTip:]):

  • WebView/WebViewInternal.h:
15:34 Changeset [50105] by eric@webkit.org

2009-10-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool commit-queue does not notice modifications to committers.py
https://bugs.webkit.org/show_bug.cgi?id=30084

  • Scripts/bugzilla-tool:
    • Make commit-queue re-exec itself instead of using while(1).
    • Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
    • Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
15:32 Changeset [50104] by eric@webkit.org

2009-10-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue will get stuck on patches if land-patches terminates unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=30634

  • Scripts/bugzilla-tool:
    • Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
    • Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
15:22 Changeset [50103] by eric@webkit.org

2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Use "%lli" to format "long long" on WIN_OS to fix HTML5 WebDB crash
https://bugs.webkit.org/show_bug.cgi?id=30777

No new tests as the crash can be reproduced by existing storage
LayoutTests (by hitting an assert in debug mode Webkit on WIN_OS).

  • platform/text/String.cpp: (WebCore::String::number): Qt's QString::vsprintf does not understand the "%I64u" format string. Always use the "%lli" format string for Qt port.
15:10 Changeset [50102] by eric@webkit.org

2009-10-26 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.

https://bugs.webkit.org/show_bug.cgi?id=30763

  • pywebsocket/mod_pywebsocket/init.py:
  • pywebsocket/mod_pywebsocket/dispatch.py:
  • pywebsocket/mod_pywebsocket/headerparserhandler.py:
  • pywebsocket/mod_pywebsocket/standalone.py:
  • pywebsocket/setup.py:
  • pywebsocket/test/test_dispatch.py:
15:04 Changeset [50101] by tony@chromium.org

2009-10-26 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Roll back r50073 because r50041-50043 were reverted. r50073 was
a chromium side fix for r50041.
https://bugs.webkit.org/show_bug.cgi?id=30789

  • bindings/v8/V8Collection.h:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
15:02 Changeset [50100] by ggaren@apple.com

WebCore: Fixed https://bugs.webkit.org/show_bug.cgi?id=30765
REGRESSION (r48701): Removing an event listener causes the one added just after it not to fire

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-26
Reviewed by Dimitri Glazkov.

and related bugs.

If the event listener being removed is prior to the current firing event
iterator, we need to decrement the current firing event iterator in
addition to the endpoint. (Otherwise, shrinking the event listener vector
by one implicity moves the current firing event iterator forward by one.
It's like relativity, only without the planets.)

Also took the opportunity to change some pointers to references, since
they can't be null.

  • dom/EventTarget.cpp:

(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::removeAllEventListeners): Update iterator in addition
to end, if need be.
(WebCore::EventTarget::fireEventListeners): Updated for interface changes.
Added a comment to explain a behavior that was implicit enough to be
confusing.

  • dom/EventTarget.h:

(WebCore::FiringEventIterator::FiringEventIterator):
(WebCore::EventTarget::isFiringEventListeners): Updated for interface changes.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=30765
REGRESSION (r48701): Removing an event listener causes one added after it to not fire

Patch by Dimitri Glazkov <dglazkov@chromium.org> on 2009-10-26
Reviewed by Geoffrey Garen.

  • fast/events/event-listener-list-mutation-expected.txt: Added.
  • fast/events/event-listener-list-mutation.html: Added.
  • fast/events/script-tests/event-listener-list-mutation.js: Added.

(TestMutation.listeners):
(TestMutation.mutateList):

14:52 Changeset [50099] by kenneth@webkit.org

Unreviewed documentation fix from David Boddie (Qt Doc Team)

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
Removes the check around the RenderHints property documentation
that was clearly added to synchronize the source and header files
when the #if !defined(Q_OS_SYMBIAN) guards was added to the
property.

The documentation has also been updated to ensure that Symbian
users know that there is no actual RenderHints property on their
platform.

  • Api/qwebview.cpp:
14:50 Changeset [50098] by bweinstein@apple.com

Fixes <http://webkit.org/b/30792>.
Web Inspector: When changing resource scope, resource graph can get in weird state.

Reviewed by Timothy Hatcher.

If the user was scrolled down while looking at All resources, and then just
selects Fonts, or something that doesn't have many resources, then the graph
will stay scrolled down, even when there is no content there.

When the filter is updated, scroll to the top of the graph view, so this won't
happen.

  • inspector/front-end/AbstractTimelinePanel.js:

(WebInspector.AbstractTimelinePanel.prototype._updateFilter):

14:46 Changeset [50097] by weinig@apple.com

Fix mac clean build.

  • html/HTMLOptionsCollection.idl:
14:42 Changeset [50096] by kenneth@webkit.org

Unreviewed documentation fix from David Boddie (Qt Doc Team)

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
Ensure that qdoc will always see the RenderHints property.

The property was only defined in the header file if the Q_OS_SYMBIAN
symbol was not defined, resulting in the property not showing up
in the Qt documentation just because one platform doesn't support it.

A follow up commit will improve the documentation for the property
and note that it is not supported on the Symbiam platform.

  • Api/qwebview.h:
14:35 Changeset [50095] by pfeldman@chromium.org

2009-10-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Extract AbstractTimelinePanel that will be a base
class for ResourcesPanel and TimelinePanel.

https://bugs.webkit.org/show_bug.cgi?id=30776

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/AbstractTimelinePanel.js: Added. (WebInspector.AbstractTimelinePanel): (WebInspector.AbstractTimelinePanel.prototype.get categories): (WebInspector.AbstractTimelinePanel.prototype.showCategory): (WebInspector.AbstractTimelinePanel.prototype.hideCategory): (WebInspector.AbstractTimelinePanel.prototype.createTimelinePanels): (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel.createFilterElement): (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel): (WebInspector.AbstractTimelinePanel.prototype.filter): (WebInspector.AbstractTimelinePanel.prototype._updateFilter): (WebInspector.AbstractTimelinePanel.prototype._createGraph): (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded): (WebInspector.AbstractTimelinePanel.prototype._updateSummaryGraph): (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition): (WebInspector.AbstractTimelinePanel.prototype.get needsRefresh): (WebInspector.AbstractTimelinePanel.prototype.set needsRefresh): (WebInspector.AbstractTimelinePanel.prototype.refreshIfNeeded): (WebInspector.AbstractTimelinePanel.prototype.show): (WebInspector.AbstractTimelinePanel.prototype.resize): (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.computeSummaryValues): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels): (WebInspector.TimelineCalculator.prototype.get boundarySpan): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.reset): (WebInspector.TimelineCalculator.prototype._value): (WebInspector.TimelineCalculator.prototype.formatValue):
  • inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.ResourcesPanel.prototype.get statusBarItems): (WebInspector.ResourcesPanel.prototype.get categories): (WebInspector.ResourcesPanel.prototype.showCategory): (WebInspector.ResourcesPanel.prototype.hideCategory): (WebInspector.ResourcesPanel.prototype.isCategoryVisible): (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourcesPanel.prototype.createPanelEnabler): (WebInspector.ResourcesPanel.prototype.createStatusbarButtons): (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime): (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime): (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.resize): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded): (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): (WebInspector.ResourceTimeCalculator): (WebInspector.ResourceTransferSizeCalculator): (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels):
  • inspector/front-end/SummaryBar.js: (WebInspector.SummaryBar.prototype.update):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded):
14:09 Changeset [50094] by eric@webkit.org

2009-10-26 Avi Drissman <avi@google.com>

Reviewed by Darin Adler.

Use Helvetica in the Inspector as intended.
https://bugs.webkit.org/show_bug.cgi?id=30787

  • inspector/front-end/inspector.css:
14:05 Changeset [50093] by xan@webkit.org

2009-10-26 Xan Lopez <xlopez@igalia.com>

Skip test fast/loader/opaque-base-url.html with a reference to the
bug tracking it, https://bugs.webkit.org/show_bug.cgi?id=30724

  • platform/gtk/Skipped:
14:02 Changeset [50092] by eric@webkit.org

2009-10-26 Nate Chapin <japhet@chromium.org>

Reviewed by Alexey Proskuryakov.

Update no-referrer-reset for https://bugs.webkit.org/show_bug.cgi?id=30781.

  • http/tests/navigation/no-referrer-reset-expected.txt: Expect window.opener to still be set.
  • http/tests/navigation/no-referrer-reset.html: Update text to reflect what the test actually does.

2009-10-26 Nate Chapin <japhet@chromium.org>

Reviewed by Alexey Proskuryakov.

Don't set window.opener to 0 for the current FrameLoader if a noreferrer link was clicked, only suppress opener in a new frame.
https://bugs.webkit.org/show_bug.cgi?id=30781

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): Don't suppress opener in the current frame for noreferrer navigations.
13:53 Changeset [50091] by eric@webkit.org

2009-10-26 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Levin.

REGRESSION: 2 failures in run-webkit-unittests
https://bugs.webkit.org/show_bug.cgi?id=30645

  • Scripts/modules/cpp_style_unittest.py: Fixed a few test scenarios which apparently lost some spaces from text literals.
13:48 Changeset [50090] by rniwa@webkit.org

Data loss occurs when unbolding nested bold tags.
https://bugs.webkit.org/show_bug.cgi?id=30083

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-26
Reviewed by Eric Seidel.

WebCore:

Fixes the loop in swapInNodePreservingAttributesAndChildren by saving nextSibling() of child
to a temporary valuable. It was originally calling nextSibling() after appending the child
to new parent, in which case, nextSibling is always 0.

Test: editing/style/unbolding-nested-b.html

  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

LayoutTests:

Adds a test to make sure WebKit can remove nested b, i, & s tags properly
without loosing the content of inner elements.

  • editing/style/remove-nested-inline-styles-expected.txt: Added.
  • editing/style/remove-nested-inline-styles.html: Added.
  • editing/style/script-tests/remove-nested-inline-styles.js: Added.

(removeStyleAndExpect):

13:16 Changeset [50089] by kov@webkit.org

Reviewed by Jan Alonzo.

Alternative solution to regression introduced in r48672.

13:11 Changeset [50088] by jorlow@chromium.org

2009-10-21 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Storage events should use Document::url() rather than documentURI()
https://bugs.webkit.org/show_bug.cgi?id=30535

Storage events should use Document::url() rather than Document::documentURI()
per http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html

Test: storage/domstorage/documentURI.html

  • storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):

2009-10-26 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Adler.

Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
inherit from HTMLCollection.

  • fast/dom/wrapper-classes-expected.txt:
13:04 Changeset [50087] by weinig@apple.com

Rubber-stamped by Darin Adler.

Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
inherit from HTMLCollection.

WebCore:

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):
(WebCore::toJS):

  • bindings/js/JSHTMLCollectionFunctions.h: Removed.
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::length):
(WebCore::JSHTMLOptionsCollection::indexSetter):

  • bindings/objc/DOMHTML.mm:

(kitClass):

  • bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLCollection.idl:
  • html/HTMLOptionsCollection.idl:

WebKit/win:

  • DOMCreateInstance.cpp:

LayoutTests:

  • fast/dom/wrapper-classes-expected.txt:
12:46 Changeset [50086] by kevino@webkit.org

wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.

12:34 Changeset [50085] by bfulgham@webkit.org

Build fix for ENABLE_FILTERS under Windows.
https://bugs.webkit.org/show_bug.cgi?id=30762

Reviewed by Adam Roben.

Build correction for ENABLE_FILTERS feature. No new tests needed.

  • WebCore.vcproj/WebCore.vcproj: Make the following changes: (1) Create a new 'filters' sub-folder of the platform/graphics

folder to properly show the sources held in this directory.

(2) Move the files that are currently shown in svn/graphics/filters

to platform/graphics/filters (where they actually live on disk).

(3) Add the missing SVGFilter, SVGFilterBuilder, and SVGFETile to

the project so they are built.

(4) Remove SVGFEFloodElement.cpp from the build, since it is already

being compiled by SVGAllInOne.cpp. Its presence as a separate
entity is causing a linker warning for duplicate symbols.

(5) Add ImageBuffer.cpp to the build to support color space

calculations for non-CG builds.

  • WebCore.vcproj/WebCoreCommon.vsprops: Add the platform/graphics/filters path to the search paths in the project.
12:30 Changeset [50084] by eric@webkit.org

2009-10-26 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

console.assert should prefix messages with "Assertion failed: "
https://bugs.webkit.org/show_bug.cgi?id=19135

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype.toMessageElement): Append "Assertion failed: " for AssertMessageType. (WebInspector.ConsoleMessage.prototype.toString):
  • page/Console.cpp: (WebCore::Console::assertCondition): Use AssertMessageType.
  • page/Console.h: (WebCore::MessageType): Added AssertMessageType.
12:19 Changeset [50083] by eric@webkit.org

2009-10-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Eric Seidel.

Prevent crash when optgroup element is empty.

https://bugs.webkit.org/show_bug.cgi?id=30365

  • fast/forms/select-empty-optgroup-expected.txt: Added.
  • fast/forms/select-empty-optgroup.html: Added.

2009-10-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Eric Seidel.

Prevent crash when optgroup element is empty by adding a NULL check.

https://bugs.webkit.org/show_bug.cgi?id=30365

Test: fast/forms/select-empty-optgroup.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::appendFormData):
12:11 Changeset [50082] by tony@chromium.org

2009-10-21 Steven Knight <sgk@chromium.org>

Reviewed by David Levin.

Refactor gyp for separate webcore_bindings{,_sources} targets.

https://bugs.webkit.org/show_bug.cgi?id=30447

Handle long link lines by building .idl-generated bindings in a
separate webcore_bindings library target. Avoid Visual Studio
dependency issues by building additional generated .cpp and .h files
in a separate webcore_bindings_sources target.

Chrome should still build and test successfully.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:10 Changeset [50081] by kov@webkit.org

Tagging 1.1.16.

11:57 Changeset [50080] by ossy@webkit.org

Unification of using null device in perl scripts.
https://bugs.webkit.org/show_bug.cgi?id=30572

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
Reviewed by Darin Adler.

  • Scripts/VCSUtils.pm:
  • Scripts/bisect-builds:
  • Scripts/resolve-ChangeLogs:
  • Scripts/run-iexploder-tests:
  • Scripts/run-jsc:
  • Scripts/run-mangleme-tests:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:

Using File::Spec->devnull() instead of hard coded /dev/null.

11:40 Changeset [50079] by eric@webkit.org

2009-10-26 Mike Belshe <mike@belshe.com>

Reviewed by Darin Fisher.

Make the number of connections for chromium controlled by
chromium rather than by ResourceRequestBase.
https://bugs.webkit.org/show_bug.cgi?id=30661

  • platform/network/ResourceRequestBase.cpp:
  • platform/network/chromium/ResourceRequest.cpp:
11:38 Changeset [50078] by eric@webkit.org

2009-10-26 Eric Seidel <eric@webkit.org>

Reviewed by Holger Freyther.

Reviewers are missing from committers.py
https://bugs.webkit.org/show_bug.cgi?id=30733

  • Scripts/modules/committers.py:
11:38 Web Inspector edited by casey.hattori@gmail.com
(diff)
11:33 Changeset [50077] by eric@webkit.org

2009-10-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

PrettyPatch should show images even when they have the wrong mime type
https://bugs.webkit.org/show_bug.cgi?id=29506

  • PrettyPatch/PrettyPatch.rb:
10:55 HackingGtk edited by kov@webkit.org
(diff)
10:54 Changeset [50076] by ossy@webkit.org

Unreviewed typo fix.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26

  • platform/qt/Skipped: shared-workers-close.html replaced with shared-worker-close.html
10:45 Changeset [50075] by kov@webkit.org

Unreviewed. make distcheck build fixes.

10:44 Changeset [50074] by kov@webkit.org

Unreviewed. Fix make dist regression introduced by r48672.

10:35 Changeset [50073] by eric@webkit.org

2009-10-26 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Unbreak Chromium build: that requires adding custom implementations
for HTMLOptionsCollection's item and namedItem. Keep v8 binding
close to JSC bindings as well.
https://bugs.webkit.org/show_bug.cgi?id=30780

  • bindings/v8/V8Collection.h: (WebCore::getNamedItemsFromCollection): (WebCore::getItemFromCollection):
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
10:26 Changeset [50072] by ap@apple.com

Reviewed by Adam Barth and Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30723
<rdar://problem/6189415> Input names added to multipart/form-data headers need to be escaped.

Test: http/tests/security/escape-form-data-field-names.html

  • platform/network/FormDataBuilder.cpp: (WebCore::appendQuotedString): (WebCore::FormDataBuilder::beginMultiPartHeader): (WebCore::FormDataBuilder::addFilenameToMultiPartHeader): Percent-escape line breaks and quotation marks.
10:10 Changeset [50071] by ossy@webkit.org

[Qt] Skip two flakey tests because of sporadic timeouts.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

  • platform/qt/Skipped:
10:06 Changeset [50070] by ossy@webkit.org

[Qt] Skipping two other tests because of missing features on our platform.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

  • platform/qt/Skipped:
10:00 Changeset [50069] by ossy@webkit.org

[Qt] Add platform-dependent expected file for test added in r49875.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

  • platform/qt/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Added.
09:46 Changeset [50068] by eric@webkit.org

2009-10-26 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Adds DOMTimer support to InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=30467

  • inspector/InspectorTimelineAgent.cpp: Added timer support and fixed some method names. (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): Added. (WebCore::InspectorTimelineAgent::didRemoveTimer): Added. (WebCore::InspectorTimelineAgent::willFireTimer): Added. (WebCore::InspectorTimelineAgent::didFireTimer): Added. (WebCore::InspectorTimelineAgent::addItemToTimeline): Added. (WebCore::InspectorTimelineAgent::didCompleteCurrentTimelineItem): Renamed.
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineItemFactory.cpp: Add methods for timer-related ScriptObjects. (WebCore::TimelineItemFactory::createGenericTimerTimelineItem): (WebCore::TimelineItemFactory::createTimerInstallTimelineItem):
  • inspector/TimelineItemFactory.h:
  • page/DOMTimer.cpp: Added instrumentation points. (WebCore::DOMTimer::install): (WebCore::DOMTimer::removeById): (WebCore::DOMTimer::fired):
09:31 Changeset [50067] by simon.fraser@apple.com

2009-10-26 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6988966> Hardware layers do not show up in page snapshots

  • WebView/WebHTMLViewPrivate.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _compositingLayersHostingView]): Add a private method that returns the NSView used to host compositing layers.
  • platform/graphics/mac/Canvas3DLayer.h:
  • platform/graphics/mac/Canvas3DLayer.mm: (-[Canvas3DLayer copyImageSnapshotWithColorSpace:]): Add a method that gets called when snapshotting Canvas3DLayers for page snapshots, that allows the layer to return a CGImageRef of its contents.
09:22 Changeset [50066] by ossy@webkit.org

[Qt] Update outdated expected files which expected wrong color values.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

  • platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
09:17 Changeset [50065] by eric@webkit.org

2009-10-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Pass "console" as object group when evaluating selection.

https://bugs.webkit.org/show_bug.cgi?id=30738

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
09:10 Changeset [50064] by eric@webkit.org

2009-10-26 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Fix for Console not showing repeat count when repeatedly logging an Event
https://bugs.webkit.org/show_bug.cgi?id=30324

  • inspector/console-tests-expected.txt:

2009-10-26 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Fix for Console not showing repeat count when repeatedly logging an Event
https://bugs.webkit.org/show_bug.cgi?id=30324

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::updateRepeatCountInConsole): Added.
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addConsoleMessage): Calls updateRepeatCountInConsole if it is a repeating message.
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage): Renamed WebCore::InspectorFrontend::addMessageToConsole (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): Added. Called when repeatCount is incremented.
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): Removed calls to msg.isEqual. (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): Added. (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): Added. Updates the error/warning count. (WebInspector.ConsoleView.prototype.clearMessages): (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): Use ConsoleMessage._updateRepeatCount (WebInspector.ConsoleMessage.prototype._updateRepeatCount):
  • inspector/front-end/inspector.js: (WebInspector.addConsoleMessage): Renamed WebInspector.addMessageToConsole. (WebInspector.updateConsoleMessageRepeatCount): Added.
08:27 Changeset [50063] by eric.carlson@apple.com

2009-10-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

Remove HTML5 media element 'load' event
https://bugs.webkit.org/show_bug.cgi?id=30464


Part 1, change layout tests to not use the event.

  • media/audio-constructor-autobuffer-expected.txt:
  • media/audio-constructor-autobuffer.html:
  • media/audio-constructor-expected.txt:
  • media/audio-constructor-src-expected.txt:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/audio-controls-rendering.html:
  • media/audio-data-url-expected.txt:
  • media/audio-data-url.html:
  • media/audio-mpeg-supported-expected.txt:
  • media/audio-mpeg-supported.html:
  • media/media-load-event-expected.txt:
  • media/media-load-event.html:
  • media/progress-event-expected.txt:
  • media/progress-event-total-expected.txt:
  • media/progress-event-total.html:
  • media/progress-event.html:
  • media/remove-from-document-expected.txt:
  • media/remove-from-document-no-load-expected.txt:
  • media/remove-from-document-no-load.html:
  • media/remove-from-document.html:
  • media/restore-from-page-cache-expected.txt:
  • media/restore-from-page-cache.html:
  • media/video-append-source-expected.txt:
  • media/video-append-source.html:
  • media/video-buffered-expected.txt:
  • media/video-buffered.html:
  • media/video-canvas-source-expected.txt:
  • media/video-canvas-source.html:
  • media/video-controls-expected.txt:
  • media/video-controls-transformed-expected.txt:
  • media/video-controls-transformed.html:
  • media/video-controls-zoomed-expected.txt:
  • media/video-controls-zoomed.html:
  • media/video-controls.html:
  • media/video-currentTime-expected.txt:
  • media/video-currentTime-set-expected.txt:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2-expected.txt:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-dom-src-expected.txt:
  • media/video-dom-src.html:
  • media/video-error-abort-expected.txt:
  • media/video-error-abort.html:
  • media/video-error-does-not-exist.html:
  • media/video-muted-expected.txt:
  • media/video-muted.html:
  • media/video-no-autoplay-expected.txt:
  • media/video-no-autoplay.html:
  • media/video-seek-past-end-paused-expected.txt:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing-expected.txt:
  • media/video-seek-past-end-playing.html:
  • media/video-seekable-expected.txt:
  • media/video-seekable.html:
  • media/video-seeking-expected.txt:
  • media/video-seeking.html:
  • media/video-src-change-expected.txt:
  • media/video-src-change.html:
  • media/video-volume-expected.txt:
  • media/video-volume.html:
07:49 Changeset [50062] by cfleizach@apple.com

crash with AX on when an image map contains an anchor tag
https://bugs.webkit.org/show_bug.cgi?id=30739

Reviewed by Darin Adler.

WebCore:

Tests: accessibility/crashing-a-tag-in-map.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::addChildren):

LayoutTests:

  • accessibility/crashing-a-tag-in-map-expected.txt: Added.
  • accessibility/crashing-a-tag-in-map.html: Added.
06:51 Changeset [50061] by kov@webkit.org

2009-10-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Update documentation control files for 1.1.16.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
06:49 Changeset [50060] by kov@webkit.org

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30759
[GTK] Should use WebKitNetworkResponse, and expose it

WebKitDownload now uses our WebKitNetworkResponse instead of using
ResourceResponse directly. By exposing the response, like we do
with the request, we give our users the ability to look at the
response headers, status code, and so on, through the SoupMessage
object.

06:25 Changeset [50059] by xan@webkit.org

2009-10-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.1.16 release.

  • configure.ac:

WebKit/gtk:

2009-10-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.1.16 release.

  • NEWS:
06:06 Changeset [50058] by eric@webkit.org

2009-10-26 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Reintroduce QWebElementCollection

Revert the patch that has replaced QWebElementCollection
with QList<QWebElement>. Update the tests accordingly.

Remove the constness of the return type of QWebElement operator[].

https://bugs.webkit.org/show_bug.cgi?id=30767

  • Api/qwebelement.cpp: (QWebElement::findAll): (QWebElementCollectionPrivate::QWebElementCollectionPrivate): (QWebElementCollectionPrivate::create): (QWebElementCollection::QWebElementCollection): (QWebElementCollection::operator=): (QWebElementCollection::~QWebElementCollection): (QWebElementCollection::operator+): (QWebElementCollection::append): (QWebElementCollection::count): (QWebElementCollection::at): (QWebElementCollection::toList):
  • Api/qwebelement.h: (const_iterator::begin): (const_iterator::end): (const_iterator::operator[]):
  • Api/qwebframe.cpp: (QWebFrame::findAllElements):
  • Api/qwebframe.h:
  • QtLauncher/main.cpp: (MainWindow::selectElements):
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::simpleCollection): (tst_QWebElement::iteration): (tst_QWebElement::emptyCollection): (tst_QWebElement::appendCollection): (tst_QWebElement::nullSelect): (tst_QWebElement::hasSetFocus): (tst_QWebElement::render):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
05:44 Changeset [50057] by benm@google.com

Adds feature ENABLE guards to V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30697

Patch by Steve Block <steveblock@google.com> on 2009-10-26
Reviewed by Eric Seidel.

This adds guards for the following features to the V8 bindings,
to allow builds with V8 to succeed when these features are not enabled.

  • DATABASE
  • WORKERS
  • SHARED_WORKERS
  • SVG
  • XPATH
  • XSLT
  • INSPECTOR

This is a build fix only, no new tests required.

  • bindings/v8/DOMObjectsInclude.h: Modified.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Modified.
  • bindings/v8/V8Index.cpp: Modified.
  • bindings/v8/V8Index.h: Modified.
05:32 Changeset [50056] by ossy@webkit.org

Rubber-stamped by Tor Arne Vestbø.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
http/tests/cookies/simple-cookies-max-age.html moved to flakey tests group.
http/tests/xmlhttprequest/workers/close.html added to flakey tests group.

  • platform/qt/Skipped:
04:58 Changeset [50055] by ossy@webkit.org

Unreviewed trivial fix for r49854.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26

  • platform/qt/Skipped: Missing html extension added.
04:42 Changeset [50054] by eric@webkit.org

2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25679
[Gtk] Improve accessibility of focusable lists

Fixes the issues with the Atk states exposed for ListBoxOption

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject):
04:35 Changeset [50053] by eric@webkit.org

2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=27085
[Gtk] Incorrect rendering of list

Adds a way for platforms to indicate that a particular object
should not be ignored.

  • accessibility/AccessibilityObject.h:
  • accessibility/chromium/AccessibilityObjectChromium.cpp:
  • accessibility/gtk/AccessibilityObjectAtk.cpp:
  • accessibility/mac/AccessibilityObjectMac.mm:
  • accessibility/qt/AccessibilityObjectQt.cpp:
  • accessibility/win/AccessibilityObjectWin.cpp:
  • accessibility/wx/AccessibilityObjectWx.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
  • accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::accessibilityIsIgnored):
03:46 Changeset [50052] by eric@webkit.org

2009-10-26 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Adds ability to disable ReadWriteLock on platforms (eg Android) that use pthreads but do not support pthread_rwlock.
https://bugs.webkit.org/show_bug.cgi?id=30713

  • wtf/Platform.h: Modified. Defines HAVE_PTHREAD_RWLOCK for all platforms currently using pthreads.
  • wtf/Threading.h: Modified. Use pthread_rwlock_t only when HAVE_PTHREAD_RWLOCK is defined.
  • wtf/ThreadingPthreads.cpp: Modified. Build ReadWriteLock methods only when HAVE_PTHREAD_RWLOCK is defined.
03:29 Changeset [50051] by eric@webkit.org

2009-10-26 Kinuko Yasuda <kinuko@google.com>

Reviewed by Jan Alonzo.

Bug 30619: [Linux] Menu key doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30619

Test: manual-tests/keyboard-menukey-event.html
No new layout tests: testing this will require changes in the test
controller in a platform-specific way.

  • platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for GDK_Menu to return VKEY_APPS instead of VKEY_MENU.
  • platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for GDK_Menu to return V_APPS instead of VK_MENU.
03:07 Changeset [50050] by jmalonzo@webkit.org

2009-10-26 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[Gtk] Reenable mod_rewrite in Fedora's httpd.conf
https://bugs.webkit.org/show_bug.cgi?id=30741

  • http/conf/fedora-httpd.conf:
01:52 QtBackLog edited by zecke@selfish.org
(diff)
01:45 QtBackLog edited by zecke@selfish.org
(diff)

10/25/09:

21:33 Changeset [50049] by eric@webkit.org

2009-10-25 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Reuse already fetched proxy.
https://bugs.webkit.org/show_bug.cgi?id=30747

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
21:14 QtBackLog edited by zecke@selfish.org
(diff)
21:07 QtBackLog edited by zecke@selfish.org
(diff)
21:03 QtBackLog edited by zecke@selfish.org
Mention the bug report and commits of this work (diff)
17:45 Changeset [50048] by kov@webkit.org

2009-10-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Rebaseline test after 49998.

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
15:39 Changeset [50047] by laszlo.1.gombos@nokia.com

2009-10-25 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed build fix.

Build fix for WIN_OS if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=30753

  • plugins/PluginDatabase.cpp:
13:15 Changeset [50046] by eric@webkit.org

2009-10-25 Hironori Bono <hbono@chromium.org>

Reviewed by Darin Adler.

A quick fix for Bug 29103.
Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
and the option string before calling String::startsWith().
https://bugs.webkit.org/show_bug.cgi?id=29103

  • fast/forms/listbox-typeahead-cyrillic-expected.txt: Added.
  • fast/forms/listbox-typeahead-cyrillic.html: Added.
  • fast/forms/listbox-typeahead-greek-expected.txt: Added.
  • fast/forms/listbox-typeahead-greek.html: Added.

2009-10-25 Hironori Bono <hbono@chromium.org>

Reviewed by Darin Adler.

A quick fix for Bug 29103.
Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
and the option string before calling String::startsWith().
https://bugs.webkit.org/show_bug.cgi?id=29103

Tests: fast/forms/listbox-typeahead-cyrillic.html

fast/forms/listbox-typeahead-greek.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::typeAheadFind):
10:28 Changeset [50045] by mitz@apple.com

Add contextForWorldID to the IWebFramePrivate interface.

Reviewed by John Sullivan.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.h:
08:06 Web Inspector edited by casey.hattori@gmail.com
(diff)
06:56 Web Inspector edited by casey.hattori@gmail.com
(diff)
06:54 Web Inspector edited by casey.hattori@gmail.com
(diff)
01:54 Changeset [50044] by eric@webkit.org

2009-10-25 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Expanding a node in the Console should not show the element in Elements panel
https://bugs.webkit.org/show_bug.cgi?id=30749

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.onmousedown): Check if inside disclosure triangle.
01:22 Changeset [50043] by weinig@apple.com

Another try at fixing windows.

  • DOMCreateInstance.cpp:
00:52 Changeset [50042] by weinig@apple.com

Touch WebKit.idl in an effort to try and regenerate the COM bindings.

  • Interfaces/WebKit.idl:
00:52 Changeset [50041] by weinig@apple.com

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLOptionsCollection::getCallData):
(WebCore::JSHTMLOptionsCollection::canGetItemsForName):
(WebCore::JSHTMLOptionsCollection::nameGetter):
(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::item):
(WebCore::JSHTMLOptionsCollection::namedItem):
Refactor to use generic implementation of HTMLCollection bindings functions
from JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLCollectionFunctions.h: Added.

(WebCore::getCollectionNamedItems):
(WebCore::getCollectionItems):
(WebCore::callHTMLCollectionGeneric):
Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
JSHTMLOptionsCollection can all use.

  • bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h

for toJS on document.all.

  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):
Remove special cases for HTMLOptionsCollection.

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLAllCollection.idl:
  • html/HTMLCollection.idl:
  • html/HTMLOptionsCollection.idl:

LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • fast/dom/wrapper-classes-expected.txt:
00:08 Changeset [50040] by bweinstein@apple.com

Roll out r50037 as it broke the Windows build.

10/24/09:

21:56 Changeset [50039] by timothy@apple.com

WebInspector: Fixed issue with IME inside console
https://bugs.webkit.org/show_bug.cgi?id=30660

Patch by Keishi Hattori <casey.hattori@gmail.com> on 2009-10-24
Reviewed by Timothy Hatcher.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._promptKeyDown):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype._promptKeyDown):

  • inspector/front-end/inspector.js:

(WebInspector.loaded):
(WebInspector.searchKeyDown): Moved performSearch here from WebInspector.searchKeyUp.
(WebInspector.startEditing.element.handleKeyEvent):
(WebInspector.startEditing):

  • inspector/front-end/utilities.js:

(isEnterKey): Added. Check if in IME.

21:13 Changeset [50038] by bweinstein@apple.com

Fixes <https://bugs.webkit.org/show_bug.cgi?id=30752>.
Web Inspector: Multiple Selection on Scope Bars by default Conflicts with other behavior on OSX.

Reviewed by Timothy Hatcher.

Have the scope bars select one scope by default, but if the multiple selection key
is pressed, allow for multiple selection.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype._updateFilter):
(WebInspector.ConsoleView.prototype.filter):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter):
(WebInspector.ResourcesPanel.prototype._updateFilter):

19:44 Changeset [50037] by weinig@apple.com

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLOptionsCollection::getCallData):
(WebCore::JSHTMLOptionsCollection::canGetItemsForName):
(WebCore::JSHTMLOptionsCollection::nameGetter):
(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::item):
(WebCore::JSHTMLOptionsCollection::namedItem):
Refactor to use generic implementation of HTMLCollection bindings functions
from JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLCollectionFunctions.h: Added.

(WebCore::getCollectionNamedItems):
(WebCore::getCollectionItems):
(WebCore::callHTMLCollectionGeneric):
Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
JSHTMLOptionsCollection can all use.

  • bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h

for toJS on document.all.

  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):
Remove special cases for HTMLOptionsCollection.

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLAllCollection.idl:
  • html/HTMLCollection.idl:
  • html/HTMLOptionsCollection.idl:

LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • fast/dom/wrapper-classes-expected.txt:
16:08 Changeset [50036] by timothy@apple.com

Make the scope bars in the Web Inspector match other scope bars in Mac OS X.
Also cleans up the CSS to use classes instead of ID selectors.

https://bugs.webkit.org/show_bug.cgi?id=28186

Reviewed by Dan Bernstein.

  • inspector/front-end/ResourcesPanel.js: Add the scope-bar class.
  • inspector/front-end/inspector.css: Lots of changes to make it look right.
  • inspector/front-end/inspector.html: Add the scope-bar class.
16:08 Changeset [50035] by timothy@apple.com

Fix selecting Resources in the Web Inspector's Resources panel.

https://bugs.webkit.org/show_bug.cgi?id=30743

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.isCategoryVisible): Added.
(WebInspector.ResourceSidebarTreeElement.prototype.get selectable): Call
isCategoryVisible on the ResourcesPanel.

16:08 Changeset [50034] by timothy@apple.com

Fix the Scope Bar in the Web Inspector's Resource panel, so that selecting
All will deselect the other filters.

https://bugs.webkit.org/show_bug.cgi?id=30744

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.createFilterElement): Better syntax.
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter): Use a normal for loop,
and the child variable instead of target in the loop. Other clean up.

16:08 Changeset [50033] by timothy@apple.com

Make resizing the Web Inspector's Elements panel sidebar work again.
Also makes Resources panel use the sidebar code in Panel.

https://bugs.webkit.org/show_bug.cgi?id=30742

Reviewed by Pavel Feldman.

  • inspector/front-end/Panel.js:

(WebInspector.Panel): Don't create the sidebar with an argument.
(WebInspector.Panel.prototype.show): Call updateSidebarWidth.
(WebInspector.Panel.prototype.handleKeyEvent): Call handleSidebarKeyEvent.
(WebInspector.Panel.prototype.handleSidebarKeyEvent): Added.
(WebInspector.Panel.prototype.createSidebar): Renamed from _createSidebar.
(WebInspector.Panel.prototype._sidebarDragging): Call updateSidebarWidth.
(WebInspector.Panel.prototype.updateSidebarWidth): Renamed from _updateSidebarWidth.
(WebInspector.Panel.prototype.setSidebarWidth): Added. Called by updateSidebarWidth.
(WebInspector.Panel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel): Call createSidebar.
(WebInspector.ProfilesPanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.show): Remove call to _updateSidebarWidth.
(WebInspector.ResourcesPanel.prototype.showResource): Call updateSidebarWidth
(WebInspector.ResourcesPanel.prototype.closeVisibleResource): Ditto.
(WebInspector.ResourcesPanel.prototype.setSidebarWidth): Added.
(WebInspector.ResourcesPanel.prototype.updateMainViewWidth): Added.

  • inspector/front-end/StoragePanel.js:

(WebInspector.StoragePanel): Call createSidebar.
(WebInspector.StoragePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel): Call createSidebar.
(WebInspector.TimelinePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

16:08 Changeset [50032] by timothy@apple.com

Call updateSelection() in a few places so hovering in the Web Inspector's
Elements panel always has the correct row selection height.

https://bugs.webkit.org/show_bug.cgi?id=30735

Reviewed by Pavel Feldman.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton): Call updateSelection().
(WebInspector.ElementsTreeElement.prototype._insertInLastAttributePosition): Ditto.

  • inspector/front-end/inspector.css: Prevent text wrapping in the middle of the add attribute text.
16:02 Changeset [50031] by eric@webkit.org

2009-10-24 Timothy Hatcher <timothy@apple.com>

Remove the re-root tree feature from the Web Inspector's
Elements panel. This feature wasn't super useful and gets
in the way of double-click to edit.

https://bugs.webkit.org/show_bug.cgi?id=30736

Reviewed by Pavel Feldman.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.ondblclick):
15:40 Changeset [50030] by eric@webkit.org

2009-10-24 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Implements ReturnsNew hint for V8 bindings generation code.
https://bugs.webkit.org/show_bug.cgi?id=30745

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
15:16 Changeset [50029] by mitz@apple.com

Missing images at 350.org due to wrong URLs
https://bugs.webkit.org/show_bug.cgi?id=30748

Reviewed by Sam Weinig.

WebCore:

Test: fast/dom/HTMLImageElement/parse-src.html

  • dom/Element.cpp:

(WebCore::Element::getURLAttribute): Pass the attribute value through deprecateParseURL().
This matches what the Objective-C bindings do, as well as what HTMLImageLoader::sourceURI()
and SVGImageLoader::sourceURI() do.

LayoutTests:

  • fast/dom/HTMLImageElement/parse-src-expected.txt: Added.
  • fast/dom/HTMLImageElement/parse-src.html: Added.
  • fast/dom/HTMLImageElement/script-tests: Added.
  • fast/dom/HTMLImageElement/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Document/script-tests/TEMPLATE.html.
  • fast/dom/HTMLImageElement/script-tests/parse-src.js: Added.
13:55 Changeset [50028] by laszlo.1.gombos@nokia.com

2009-10-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed.

[Qt] Build fix for QtWebKit after r50013.

  • WebCore.pro:
09:12 Changeset [50027] by dglazkov@chromium.org

2009-10-24 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[V8] Fix up to accommodate for HTMLAllCollection changes in
http://trac.webkit.org/changeset/49998.

  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
08:28 Changeset [50026] by eric@webkit.org

2009-10-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
https://bugs.webkit.org/show_bug.cgi?id=30476

Set the stack size to 80 Kb and heap size to the 128kB - 32MB range
to all executables linking against WebKit library.

  • WebKit.pri:

2009-10-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
https://bugs.webkit.org/show_bug.cgi?id=30476

Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
to jsc.exe.

  • jsc.pro:

2009-10-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
https://bugs.webkit.org/show_bug.cgi?id=30476

Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
to all QtWebkit executables.

  • QGVLauncher/QGVLauncher.pro:
  • QtLauncher/QtLauncher.pro:
  • tests/benchmarks/loading/tst_loading.pro:
  • tests/benchmarks/painting/tst_painting.pro:
  • tests/qgraphicswebview/qgraphicswebview.pro:
  • tests/qwebelement/qwebelement.pro:
  • tests/qwebframe/qwebframe.pro:
  • tests/qwebhistory/qwebhistory.pro:
  • tests/qwebhistoryinterface/qwebhistoryinterface.pro:
  • tests/qwebpage/qwebpage.pro:
  • tests/qwebplugindatabase/qwebplugindatabase.pro:
  • tests/qwebview/qwebview.pro:
05:56 QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
(diff)
05:48 QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
(diff)
05:23 QtBackLog edited by zecke@selfish.org
(diff)
05:21 QtBackLog edited by zecke@selfish.org
(diff)

10/23/09:

23:55 QtBackLog edited by zecke@selfish.org
(diff)
23:55 QtBackLog edited by zecke@selfish.org
(diff)
23:41 QtBackLog edited by zecke@selfish.org
(diff)
21:42 QtWebKitPerformanceUtilities edited by zecke@selfish.org
(diff)
21:12 Changeset [50025] by mitz@apple.com

<rdar://problem/7294131> Assertion failure in AuthenticationMac at
mac(const Credential&) after authenticating to MobileMe Gallery movie

Reviewed by Alexey Proskuryakov.

  • platform/network/Credential.cpp:

(WebCore::Credential::Credential): Initialize m_persistence.
(WebCore::Credential::isEmpty): Made this method const.

  • platform/network/Credential.h:
  • platform/network/mac/AuthenticationMac.mm:

(WebCore::mac): Return nil if the Credential is empty.

20:16 Changeset [50024] by mrowe@apple.com

Fix engineering builds in the mysterious future.

  • Configurations/DebugRelease.xcconfig:
20:06 Changeset [50023] by mrowe@apple.com

Versioning.

20:05 Changeset [50022] by mrowe@apple.com

New tag.

20:05 Changeset [50021] by bweinstein@apple.com

Fixes <https://bugs.webkit.org/show_bug.cgi?id=30617>.
Web Inspector: Resources Scope Bar Should Allow Combinations.

Reviewed by Timothy Hatcher.

Refactor the filtering in ResourcePanel to make it match ConsoleView,
and add a divider between All, and the other choices of Resource types.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter):
(WebInspector.ResourcesPanel.prototype._updateFilter):

  • inspector/front-end/inspector.css:
20:03 Changeset [50020] by mrowe@apple.com

Merge r50019.

20:01 Changeset [50019] by mrowe@apple.com

Build fix. Include config.h before including other files.

  • AccessibleImage.cpp:
19:06 Changeset [50018] by eric@webkit.org

2009-10-23 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Added test for bug 27239 (ignore Refresh for view source mode).
https://bugs.webkit.org/show_bug.cgi?id=27239

  • http/tests/security/view-source-no-refresh.html: Added
  • http/tests/security/view-source-no-refresh-expected.txt: Added
  • http/tests/security/resources/view-source-no-refresh.php: Added

2009-10-23 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Ignore the Refresh header if we're in view source mode.

https://bugs.webkit.org/show_bug.cgi?id=27239

Test: http/tests/security/view-source-no-refresh.html

  • loader/FrameLoader.cpp: ignore Refresh in view-source mode.
18:10 Changeset [50017] by ap@apple.com

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=30734
Remove XMLTokenizer::m_currentNodeIsReferenced

No change in behavior, no tests.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::setCurrentNode):
  • dom/XMLTokenizer.h: Don't store a boolean for the current node being the document - we can always check for that.
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::XMLTokenizer):
  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::XMLTokenizer): A fragment passed to XMLTokenizer is never null - in fact, the first thing we do is dereference it unconditionally, and then begin checking it for null, as if it could help.
18:09 Changeset [50016] by bdakin@apple.com

No review since this is a build fix.

Build fix for the Mac. (Build is only broken when SVG filters are
enabled.)

Labelled these function static.

  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::identity):
(WebCore::table):
(WebCore::discrete):
(WebCore::linear):
(WebCore::gamma):

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::boxBlur):

17:40 Changeset [50015] by pfeldman@chromium.org

2009-10-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement a Timeline panel.

https://bugs.webkit.org/show_bug.cgi?id=30725

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/Images/timelineIcon.png: Added.
  • inspector/front-end/TimelineAgent.js: (WebInspector.addItemToTimeline): (WebInspector.timelineProfilerWasStarted): (WebInspector.timelineProfilerWasStopped):
  • inspector/front-end/TimelinePanel.js: Added. (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype.handleKeyEvent): (WebInspector.TimelinePanel.prototype.timelineWasStarted): (WebInspector.TimelinePanel.prototype.timelineWasStopped): (WebInspector.TimelinePanel.prototype.addItemToTimeline): (WebInspector.TimelinePanel.prototype._innerAddItemToTimeline): (WebInspector.TimelinePanel.prototype._toggleTimelineButton): (WebInspector.TimelinePanel.prototype.setMainViewWidth): (WebInspector.TimelinePanel.prototype.getItemTypeName): (WebInspector.TimelineRecordTreeElement): (WebInspector.TimelineRecordTreeElement.prototype.onattach):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
17:26 Changeset [50014] by joepeck@webkit.org

2009-10-23 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Clash Between Search's onkeyup and incremental search events
https://bugs.webkit.org/show_bug.cgi?id=30731

  • inspector/front-end/inspector.js: (WebInspector.performSearch): prevent incremental search event from clobbering a forced search
17:24 Changeset [50013] by pfeldman@chromium.org

2009-10-23 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Removes the need for C++ Timeline types in InspectorTimelineAgent in favor
of ScriptObjects.
https://bugs.webkit.org/show_bug.cgi?id=30707

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/DOMDispatchTimelineItem.cpp: Removed.
  • inspector/DOMDispatchTimelineItem.h: Removed.
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentTimelineItem):
  • inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::TimelineItemEntry::TimelineItemEntry):
  • inspector/TimelineItem.cpp: Removed.
  • inspector/TimelineItem.h: Removed.
  • inspector/TimelineItemFactory.cpp: Added. (WebCore::TimelineItemFactory::createGenericTimelineItem): (WebCore::TimelineItemFactory::createDOMDispatchTimelineItem):
  • inspector/TimelineItemFactory.h: Added. (WebCore::): (WebCore::TimelineItemFactory::TimelineItemFactory):
17:13 Changeset [50012] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=30729
Provide private API to request the global context for a specific world.
Used to initialize parameters on the global object.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-23
Reviewed by Geoff Garen.

WebCore:

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::globalObject):

  • bindings/js/ScriptController.h:

WebKit/mac:

  • WebView/WebFramePrivate.h:
  • WebView/WebFrame.mm:

(-[WebFrame contextForWorldID:]):

WebKit/win:

  • WebFrame.cpp:

(WebFrame::contextForWorldID):

  • WebFrame.h:
16:44 Changeset [50011] by mrowe@apple.com

Versioning.

16:44 Changeset [50010] by mrowe@apple.com

New tag.

16:40 Changeset [50009] by mrowe@apple.com

Merge r50004.

16:40 Changeset [50008] by mrowe@apple.com

Merge r47534.

16:35 Changeset [50007] by bweinstein@apple.com

Pan-scrolling pointer shows up in other tabs or windows, can't "fix" it.
<http://webkit.org/b/30732> and <rdar://7332018>.

Reviewed by John Sullivan.

Turns off pan-scrolling on a WebView when it is about to lose focus.

  • WebView.cpp:

(WebViewWndProc):

15:40 Changeset [50006] by eric@webkit.org

2009-10-23 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

Fixes style problems in Android-specific files.
https://bugs.webkit.org/show_bug.cgi?id=30717

Style changes only, no new tests possible.

  • page/android/EventHandlerAndroid.cpp: Modified. (WebCore::EventHandler::passMouseDownEventToWidget): Fixes whitespace in method signature. (WebCore::EventHandler::passSubframeEventToSubframe): Fixes whitespace in method signature. (WebCore::EventHandler::passWheelEventToWidget): Fixes whitespace in method signature. (WebCore::EventHandler::passMouseMoveEventToSubframe): Fixes whitespace in method signature.
  • platform/android/ClipboardAndroid.h: Modified. Fixes header include order and indenting.
  • platform/android/CursorAndroid.cpp: Modified. (WebCore::grabCursor): Fixes function braces. (WebCore::grabbingCursor): Fixes function braces.
  • platform/android/FileChooserAndroid.cpp: Modified. (WebCore::FileChooser::basenameForWidth): Fixes braces on while statement, and updates String::copy to String::threadsafeCopy.
  • platform/android/FileSystemAndroid.cpp: Modified. Fixes header include order. (WebCore::unloadModule): Fixes zero test. (WebCore::writeToFile): Fixes if statement structure.
  • platform/android/KeyEventAndroid.cpp: Modified. (WebCore::windowsKeyCodeForKeyEvent): Fixes switch statement indenting. (WebCore::keyIdentifierForAndroidKeyCode): Fixes switch statement indenting.
  • platform/android/ScreenAndroid.cpp: Modified. Fixes header include order and switch statement indenting.
  • platform/android/TemporaryLinkStubs.cpp: Modified. Fixes header include order.
15:25 Changeset [50005] by eric@webkit.org

2009-10-23 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Modified the tests results according to the last changes due
to the fixes of the bug (r49985):
https://bugs.webkit.org/show_bug.cgi?id=29697.

  • platform/gtk/editing/execCommand/4916541-expected.txt:
  • platform/gtk/editing/execCommand/5138441-expected.txt:
  • platform/gtk/editing/execCommand/5481523-expected.txt:
  • platform/gtk/editing/execCommand/indent-paragraphs-expected.txt: Added.
15:16 Changeset [50004] by jhoneycutt@apple.com

MSAA: Name for image elements should use alt attribute text

https://bugs.webkit.org/show_bug.cgi?id=30727
<rdar://problem/7328291>

Reviewed by Alice Liu.

WebKit/win:

  • AccessibleBase.cpp:

(AccessibleBase::createInstance):
If the AccessibilityObject is an image, return an AccessibleImage.

  • AccessibleImage.cpp: Added.

(AccessibleImage::AccessibleImage):
Call the base constructor.
(AccessibleImage::name):
If the object is not an AccessibilityRenderObject, return the base's
name(). Look first for an ARIA "labeled-by" attribute, then look for an
alternate text attribute. Fall back to the base's name().

  • AccessibleImage.h: Added.

(AccessibleImage::~AccessibleImage):

  • WebKit.vcproj/WebKit.vcproj:

Add AccessibleImage to the project.

LayoutTests:

  • platform/win/accessibility/img-alt-attribute-expected.txt: Added.
  • platform/win/accessibility/img-alt-attribute.html: Added.
14:49 Changeset [50003] by eric@webkit.org

2009-10-23 Eric Seidel <eric@webkit.org>

No review, only adding Alice to the list of reviewers.

  • Scripts/modules/committers.py:
14:45 Changeset [50002] by weinig@apple.com

Another shot at a fixed build.

  • DerivedSources.cpp:
14:33 Changeset [50001] by weinig@apple.com

Another shot at a fixed build.

  • html/HTMLOptionsCollection.idl:
14:25 Changeset [50000] by beidson@apple.com

50,000!

  • ChangeLog: Point out revision 50,000.
14:25 Changeset [49999] by weinig@apple.com

Try and fix the windows build.

  • Interfaces/WebKit.idl:
14:12 Changeset [49998] by weinig@apple.com

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30695
Drop .tags() support from HTMLCollection

Reviewed by Anders Carlsson.

  • Make .tags() only work for HTMLAllCollections in JS. .tags() is still available for all HTMLCollection like objects in Objective-C since that is API.
  • Auto-generate HTMLAllCollection.

Test: fast/dom/HTMLDocument/document-all.html

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAllCollection.cpp: Removed.
  • bindings/js/JSHTMLAllCollection.h: Removed.
  • bindings/js/JSHTMLAllCollectionCustom.cpp: Added.

(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::getCallData):
(WebCore::JSHTMLAllCollection::canGetItemsForName):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.cpp:

(WebCore::Document::all):

  • dom/Document.h:
  • dom/HTMLAllCollection.idl: Removed.
  • html/HTMLAllCollection.cpp: Added.

(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::HTMLAllCollection):
(WebCore::HTMLAllCollection::~HTMLAllCollection):

  • html/HTMLAllCollection.h: Added.
  • html/HTMLAllCollection.idl: Added.
  • html/HTMLCollection.h:
  • html/HTMLCollection.idl:
  • html/HTMLDocument.idl:
  • page/DOMWindow.idl:

LayoutTests: Update and add test for https://bugs.webkit.org/show_bug.cgi?id=30695
Drop .tags() support from HTMLCollection

Reviewed by Anders Carlsson.

  • fast/dom/HTMLDocument/document-all-expected.txt: Added.
  • fast/dom/HTMLDocument/document-all.html: Added.
  • fast/dom/HTMLDocument/script-tests: Added.
  • fast/dom/HTMLDocument/script-tests/document-all.js: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/script-tests/domListEnumeration.js:
  • fast/dom/undetectable-document-all-expected.txt:
  • fast/js/global-constructors-expected.txt:
13:47 Changeset [49997] by pfeldman@chromium.org

2009-10-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: pull basic sidebar implementation into the Panel.

https://bugs.webkit.org/show_bug.cgi?id=30720

13:43 Changeset [49996] by eric@webkit.org

2009-10-23 Jens Alfke <snej@chromium.org>

Reviewed by Dimitri Glazkov.

Slight optimizations to object returning and exception handling in generated V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30599

  • bindings/scripts/CodeGeneratorV8.pm: Generate better code
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertToV8Object): Added overload that takes a Ref<>
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Remove unnecessary template param to prevent compile error
13:35 Changeset [49995] by eric@webkit.org

2009-10-23 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

Volume slider always starts at half volume
https://bugs.webkit.org/show_bug.cgi?id=28322

  • media/video-volume-slider.html: Added. Pixel test for the volume slider of the media control. This test assumes volume slider is implemented and usable. It moves the mouse over the right bottom corner of a video element to trigger the volume slider. If volume slider is not implemented at all, you'll only see a video element with the first frame.
  • platform/gtk/Skipped: The above test requires a volume slider so it's skipped.
  • platform/mac/Skipped: ditto.
  • platform/win/Skipped: ditto.

2009-10-23 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

Volume slider always starts at half volume
https://bugs.webkit.org/show_bug.cgi?id=28322

Sets the value attribute of volume slider to the volume attribute
of the media element. Also update the value attribute of the
input element for the volume slider when the volume attribute
of the media element is updated.

Test: media/video-volume-slider.html

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderElement::update): Set the value attribute of the input element for the volume slider using the current volume of the media element.
  • rendering/MediaControlElements.h: Add method definition of update().
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider): Creates a volume slider with value attribute equals to the current volume attribute of the media element.
13:26 Changeset [49994] by eric@webkit.org

2009-10-23 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel.

Chrome Linux: fix caret positioning in LTR complex languages
The caret is positioned off by one in languages like Thai.

https://bugs.webkit.org/show_bug.cgi?id=28284

A group of us spent a while trying various approaches to write a test
for this; however, since it is only that the blinking cursor is
displayed incorrectly, we concluded it can not be tested.

(Patch by Hironori Bono.)

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::selectionRectForComplexText):
13:13 Changeset [49993] by eric@webkit.org

2009-10-23 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Add a layout test to assert that media element implementors do not
advance currentTime after being paused.

https://bugs.webkit.org/show_bug.cgi?id=30699

  • media/video-pause-immediately-expected.txt: Added.
  • media/video-pause-immediately.html: Added.
13:09 Changeset [49992] by tony@chromium.org

2009-10-23 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

Fix Chromium build after IsoldatedWorld change (r49963).
https://bugs.webkit.org/show_bug.cgi?id=30719

  • bindings/ScriptControllerBase.cpp:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInIsolatedWorld):
  • bindings/v8/ScriptController.cpp: (WebCore::mainThreadNormalWorld):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell):
  • dom/Document.cpp: (WebCore::Document::createWrapperCache):
  • dom/ScriptExecutionContext.cpp:
  • dom/ScriptExecutionContext.h:
  • xml/XMLHttpRequest.cpp:
  • xml/XMLHttpRequest.h:
13:05 Changeset [49991] by eric@webkit.org

2009-10-23 Victor Wang <victorw@chromium.org>

Reviewed by Eric Seidel.

Update the expected pixel result for test svg-as-background-6.html

The old result is incorrect because of the wrong SVG masking offset calculation.
Patch http://trac.webkit.org/changeset/49598 fixed the issue.
The pixel result of this layout test needs to be updated.

https://bugs.webkit.org/show_bug.cgi?id=30692

  • platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.png:
12:48 Changeset [49990] by eric@webkit.org

2009-10-23 Xiaomei Ji <xji@chromium.org>

Reviewed by Sam Weinig.

Fix caretRangeFromPoint()/elementFromPoint() returns wrong result
for a zoomed and scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30689.

The real cause is the wrong calculation of event.clientX/Y when
page is zoomed and scolled.
After Sam fixed the event.clientX/Y in r49551, the hit test point
should be recalculated (revert r49490).

  • fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll-expected.txt: Added.
  • fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html: Added.
  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
  • fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
  • fast/dom/elementFromPoint-relative-to-viewport.html:

2009-10-23 Xiaomei Ji <xji@chromium.org>

Reviewed by Sam Weinig.

Fix caretRangeFromPoint()/elementFromPoint() returns wrong result
for a zoomed and scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30689.

The real cause is the wrong calculation of event.clientX/Y when
page is zoomed and scolled.
After Sam fixed the event.clientX/Y in r49551, the hit test point
should be recalculated (revert r49490).

Test: fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html

  • dom/Document.cpp: (WebCore::Document::elementFromPoint): calculate the correct point relative to document when page is zoomed and scrolled. (WebCore::Document::caretRangeFromPoint): calculate the correct point relative to document when page is zoomed and scrolled.
12:38 Changeset [49989] by dumi@chromium.org

Adding a class that allows us to enable/disable features at
runtime. Adding a flag to enable database support.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-22
Reviewed by Dmitry Titov.

https://bugs.webkit.org/show_bug.cgi?id=30653

  • WebCore.gypi:
  • bindings/v8/RuntimeEnabledFeatures.cpp: Added.
  • bindings/v8/RuntimeEnabledFeatures.h: Added.

(WebCore::RuntimeEnabledFeatures::setDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::databaseEnabled):
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::ACCESSOR_RUNTIME_ENABLER):

  • page/DOMWindow.idl:
12:30 Changeset [49988] by eric@webkit.org

2009-10-23 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Inspector injects _inspectorCommandLineAPI into global object when opened
https://bugs.webkit.org/show_bug.cgi?id=30675

  • inspector/front-end/InjectedScript.js: (InjectedScript.getCompletions): (InjectedScript._evaluateOn): (InjectedScript.addInspectedNode): (InjectedScript._ensureCommandLineAPIInstalled): Moved _inspectorCommandLineAPI from window to console.
12:23 Changeset [49987] by eric@webkit.org

2009-10-23 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Tor Arne Vestbø.

[Qt] don't undef NULL in Symbian emulator

npapi.h way of defining mwerks compiler,intel
and win32 are all true for Symbian emulator.
Changed the definions so that NULL won't be undefined
when compiling for Symbian emulator nor target HW.

  • bridge/npapi.h:
12:14 Changeset [49986] by eric@webkit.org

2009-10-23 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Correct linking of sqlite3 for Symbian
https://bugs.webkit.org/show_bug.cgi?id=30569

".lib" will try to include library as static library
causing the library to be searched from wrong directory and if found
will be statically linked instead of the inteded dynamic linking.

  • WebCore.pro:
12:00 Changeset [49985] by adele@apple.com

REGRESSION: Copy is copying incorrect background-color
<rdar://problem/7248529>
https://bugs.webkit.org/show_bug.cgi?id=29697

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-23
Reviewed by Adele Peterson.

WebCore:

Test: editing/execCommand/indent-paragraphs.html

This change removes the BackgroundColor from the list
of inheritable CSS properties and changes significantly
the way we perform indentation.
The new implementation of IndentOutdentCommand uses a new method
defined in CompositeEditCommand called moveParagraphWithClones.
This is an improved version of the original moveParagraph that
is aimed at preserving the original markup of the paragraph being
moved.

  • editing/ApplyStyleCommand.cpp:

(WebCore::): removed CSSPropertyBackgroundColor from editingStyleProperties.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::CompositeEditCommand): Removed trailing blanks.
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Removed trailing blanks.
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Added.
(WebCore::CompositeEditCommand::cleanupAfterDeletion): Added.
(WebCore::CompositeEditCommand::moveParagraphWithClones): Added.
(WebCore::CompositeEditCommand::moveParagraphs): Modified to use cleanupAfterDeletion.
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Removed trailing blanks.
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Removed trailing blanks.
(WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Removed trailing blanks.

  • editing/CompositeEditCommand.h: Added three new methods.
  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::tryIndentingAsListItem): Changed to use moveParagraphWithClones.
(WebCore::IndentOutdentCommand::indentIntoBlockquote): Changed to use moveParagraphWithClones.
(WebCore::IndentOutdentCommand::indentRegion): Removed comment.

  • editing/IndentOutdentCommand.h: Removed prepareBlockquoteLevelForInsertion method.

LayoutTests:

All the following tests have been re-baselined because
the indent command now preserves the original markup.
A new test (indent-paragraph.html) has been added to test
several indent combinations not covered by the existing tests.

  • editing/execCommand/19087-expected.txt:
  • editing/execCommand/19653-1-expected.txt:
  • editing/execCommand/indent-div-inside-list-expected.txt:
  • editing/execCommand/indent-nested-blockquotes-expected.txt:
  • editing/execCommand/indent-nested-div-expected.txt:
  • editing/execCommand/indent-paragraphs.html: Added.
  • editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt:
  • editing/execCommand/indent-with-style-expected.txt:
  • editing/inserting/5994480-2-expected.txt:
  • platform/mac/editing/execCommand/4641880-2-expected.txt:
  • platform/mac/editing/execCommand/4916541-expected.txt:
  • platform/mac/editing/execCommand/5138441-expected.txt:
  • platform/mac/editing/execCommand/5481523-expected.txt:
  • platform/mac/editing/execCommand/indent-paragraphs-expected.txt: Added.
  • platform/mac/editing/execCommand/indent-selection-expected.txt:
  • platform/mac/editing/pasteboard/select-element-1-expected.txt:
11:57 Changeset [49984] by eric@webkit.org

2009-10-23 Eric Seidel <eric@webkit.org>

Reviewed by Eric Carlson.

fast/media/mq-transform-02.html failed on Leopard Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=30700

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Update QuickTime version check.
10:34 Changeset [49983] by bweinstein@apple.com

Rubber-stamped by Sam Weinig.

Isolated worlds tests now pass, removing then from the Skipped
list.

  • platform/win/Skipped:
09:45 Changeset [49982] by kevino@webkit.org

wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
character measurement APIs that are private on Tiger.

09:42 Changeset [49981] by kevino@webkit.org

wx build fix. Update the globalObject calls after changes.

09:34 Changeset [49980] by cmarrin@apple.com

Changed anchor style to take a class name

08:53 Changeset [49979] by eric.carlson@apple.com

2009-10-22 Eric Carlson <eric.carlson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/7322847>
Pressing space bar key in full screen mode should pause movie but doesn't

  • WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController keyDown:]): New, toggle playback on space key. (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Play button action is now called togglePlaying. (-[WebVideoFullscreenHUDWindowController togglePlaying:]): Rename from playingChanged.
07:30 Changeset [49978] by vestbo@webkit.org

Qt build fix

07:07 Changeset [49977] by benm@google.com

Fixes a leak in createThreadInternal on Android.
https://bugs.webkit.org/show_bug.cgi?id=30698

Patch by Steve Block <steveblock@google.com> on 2009-10-23
Reviewed by Dmitry Titov.

  • wtf/ThreadingPthreads.cpp: Modified.

(WTF::createThreadInternal): Avoid leaking a ThreadData object on failure.

05:45 Changeset [49976] by benm@google.com

Adds missing UnusedParam.h includes, required when INSPECTOR is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=30677

Patch by Steve Block <steveblock@google.com> on 2009-10-23
Reviewed by Eric Seidel.

Build fix, no new tests required.

  • page/Console.cpp: Modified. Added UnusedParam.h include.
  • workers/WorkerContext.cpp: Modified. Added UnusedParam.h include.
05:02 Changeset [49975] by zecke@webkit.org

[Qt] Plugins : Use window's winId() instead of the widget's.

2009-10-23 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Holger Freyther.

[Qt] Plugins : Use window's winId() instead of the widget's.

As per, https://developer.mozilla.org/en/NPN_GetValue
NPNVnetscapeWindow on Unix/X11: "Gets the browser toplevel window in which the
plug-in is displayed; returns Window".

The issue was found because NPNVNetscapeWindow winId() ends up creating
a native window resulting in flicker.

https://bugs.webkit.org/show_bug.cgi?id=30706

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::getValue):
05:02 Changeset [49974] by zecke@webkit.org

[Qt] Windowless Plugins : Don't use m_clipRect when painting.

2009-10-23 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Holger Freyther.

[Qt] Windowless Plugins : Don't use m_clipRect when painting.

Though it works, it is not correct to use m_clipRect for painting
in Windowless mode. Instead, the rect paramater that is passed
as a part of PluginView::paint() must be used. This change will
also result in some speedup since previously we used to paint all
the visible parts of a windowless plugin (even if those parts were
not dirty).

Also, fix invalidateRect() to compute the correct width and height.

https://bugs.webkit.org/show_bug.cgi?id=30711

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint): (WebCore::PluginView::invalidateRect):
05:02 Changeset [49973] by zecke@webkit.org

Plugins : Use test.swf in the plugins manual tests.

They previously referenced youtube videos which among other things are
cumbersome to use without internet connection. The old youtube link is
just commented out so that testing with youtube can be done with
little effort.

04:47 Changeset [49972] by xan@webkit.org

2009-10-23 Xan Lopez <xlopez@igalia.com>

Use the correct Skipped file ...

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
04:43 Changeset [49971] by xan@webkit.org

2009-10-23 Xan Lopez <xlopez@igalia.com>

Skip new tests missing expected results.

  • platform/mac/Skipped:
01:14 Changeset [49970] by bweinstein@apple.com

Fix the Windows Release build by moving Accessibility files
into all-in-one file and excluding them from the build.

Reviewed by Jon Honeycutt.

  • WebCore.vcproj/WebCore.vcproj:
  • accessibility/AccessibilityAllInOne.cpp: Added.
Note: See TracTimeline for information about the timeline view.