Timeline


and

10/29/09:

23:51 Changeset [50319] by abarth@webkit.org

2009-10-29 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Out-of-memory crash in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=30906

We need to handle the fact that creating a V8:Context might fail. I
don't know how to test this change because creating a context usually
only fails when V8 decides it's using too much memory.

  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext):
23:29 QtBackLog edited by zecke@selfish.org
(diff)
23:26 QtBackLog edited by zecke@selfish.org
(diff)
23:12 Changeset [50318] by mitz@apple.com

Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
from the two scripts that define it but don’t use it to the script that uses it but doesn’t
define it.

Reviewed by Mark Rowe.

  • Scripts/VCSUtils.pm:
  • Scripts/svn-apply:
  • Scripts/svn-unapply:
22:57 Changeset [50317] by mrowe@apple.com

Validate the stopSpeaking: selector so that is not always enabled when a WebView is first responder.

Reviewed by Oliver Hunt.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):

21:07 Changeset [50316] by mrowe@apple.com

<http://webkit.org/b/30938> REGRESSION(r50233): Windows nightlies crash on launch due to changes
to IWebFramePrivate vtable ordering

Rubber-stamped by Dan Bernstein.

  • Interfaces/IWebFramePrivate.idl: Move the newly-added method to the end of the interface so that

it doesn't affect the ordering of the vtable.

19:39 Changeset [50315] by eric@webkit.org

2009-10-29 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Make links mouse focusable only on GTK and QT.

Links are now always mouse focusable on GTK and QT. On other platforms
the link needs a tabIndex or it needs to be contentEditable.

https://bugs.webkit.org/show_bug.cgi?id=26856

  • fast/events/click-focus-anchor-expected.txt:
  • fast/events/click-focus-anchor.html:
  • platform/gtk/fast/events/click-focus-anchor-expected.txt: Added.
  • platform/mac/fast/events/click-focus-anchor-expected.txt: Removed.
  • platform/qt/fast/events/click-focus-anchor-expected.txt: Added.

2009-10-29 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Make links mouse focusable only on GTK and QT.

Links are now always mouse focusable on GTK and QT. On other platforms
the link needs a tabIndex or it needs to be contentEditable.

https://bugs.webkit.org/show_bug.cgi?id=26856

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isMouseFocusable):
19:30 Changeset [50314] by eric@webkit.org

2009-10-29 Jonathan Dixon <joth@chromium.org>

Reviewed by Eric Seidel.

Add expected files for GTK and QT builds, for test text-input-webkit-radius.html
Expected fils collected from buildbot:
http://build.webkit.org/results/Qt%20Linux%20Release/r50286%20(3257)/fast/css/
http://build.webkit.org/results/GTK%20Linux%20Release/r50286%20(5308)/fast/css/

  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
19:00 Changeset [50313] by mitz@apple.com

Updated Tiger-specific result now that Tiger matches current behavior. A Tiger-specific
result is still needed because of the difference in Thai fonts.

  • platform/mac-tiger/fast/text/atsui-multiple-renderers-expected.txt:
17:49 Changeset [50312] by mitz@apple.com

WebCore: Complete the fix for hit-testing and selection highlighting in ligatures for the ATSUI
code path.

Reviewed by Sam Weinig.

  • platform/graphics/mac/ComplexTextController.h: Added m_ltr member to ComplexTextRun.
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Skip over deleted
glyphs, but update indexes and advances correctly.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_ltr.

LayoutTests: Updated a test to account for font metric differences between Mac OS X versions. Removed
Leopard-specific results for another test now that Leopard matches current behavior.

Reviewed by Sam Weinig.

  • platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.checksum: Removed.
  • platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.png: Removed.
  • platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.txt: Removed.
  • platform/mac/fast/text/ligature-subdivision-expected.txt:
  • platform/mac/fast/text/script-tests/ligature-subdivision.js:
17:26 Changeset [50311] by adele@apple.com

Updating Radar numbers

16:37 Changeset [50310] by adele@apple.com

REGRESSION(3.2.3 - 4.0.2): Message composing: when I undo a color change to text in Mail, undo/redo behaves strangely
<rdar://problem/7067033>
https://bugs.webkit.org/show_bug.cgi?id=30892

WebCore:

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-29
Reviewed by Darin Adler.

This problem shows in any scenario where it is necessary to split a text
node to apply a style. SplitElementCommand and WrapContentsInDummySpanCommand both
have member variables initialized in the constructor to keep reference to elements
they need to operate upon. These reference are not updated when reapplying the command.
For this reason it is necessary to guarantee that unapply doesn not delete the references
and that these commands implement doReapply to correctly reuse the existing
elements.

Test: editing/undo/redo-style.html

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::executeApply): Added.
(WebCore::SplitElementCommand::doApply): Modified to call executeApply.
(WebCore::SplitElementCommand::doUnapply): Doesn't release m_element1.
(WebCore::SplitElementCommand::doReapply): Added.

  • editing/SplitElementCommand.h: Added doReapply and executeApply.
  • editing/WrapContentsInDummySpanCommand.cpp:

(WebCore::WrapContentsInDummySpanCommand::executeApply): Added.
(WebCore::WrapContentsInDummySpanCommand::doApply): Modified to call executeApply.
(WebCore::WrapContentsInDummySpanCommand::doUnapply): Doesn't release m_dummySpan.
(WebCore::WrapContentsInDummySpanCommand::doReapply): Added.

  • editing/WrapContentsInDummySpanCommand.h: Added doReapply and executeApply.

LayoutTests:

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-29

  • editing/undo/redo-style-expected.txt: Added.
  • editing/undo/redo-style.html: Added.
16:22 Changeset [50309] by jorlow@chromium.org

2009-10-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

DOM Storage's condition variable needs to handle spurious wakeups
https://bugs.webkit.org/show_bug.cgi?id=30920

Add a boolean to keep track of whether it's been terminated. Clean
up the locking code a tiny bit to make it easier to read. There's
no way to reproduce this reliably in a LayoutTest.

  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::terminate): (WebCore::LocalStorageThread::performTerminate):
  • storage/LocalStorageThread.h:
16:22 Changeset [50308] by andersca@apple.com

https://bugs.webkit.org/show_bug.cgi?id=30932
<rdar://problem/7350269>

Reviewed by Sam Weinig.

REGRESSION: Crash when turning on Private Browsing on site with flash.

Null check setValue.

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView privateBrowsingModeDidChange]):

15:49 Changeset [50307] by kenneth@webkit.org

WebKitTools: Implement the Qt version of DRT dumpBackForwardList().

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Oliver Hunt.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::dumpHistoryItem):
(WebCore::DumpRenderTree::dumpBackForwardList):

LayoutTests: Removed test that passes after implementing the Qt DRT version
of dumpBackForwardList().

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Oliver Hunt.

  • platform/qt/Skipped:
15:43 Changeset [50306] by dglazkov@chromium.org

2009-10-29 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[Chromium] Include ComplextTextController into Chromium Mac project.

  • WebCore.gyp/WebCore.gyp: Added include rule for ComplextText* files.
15:32 Changeset [50305] by eric.carlson@apple.com

2009-10-29 Eric Carlson <eric.carlson@apple.com>

Reviewed by Kevin Decker.

Refactor some duplicate plug-in clean up code into shared functions.

  • Plugins/WebPluginController.mm: (-[WebPluginController stopOnePlugin:]): New, stop a plug-in. (-[WebPluginController destroyOnePlugin:]): New, destroy plug-in. (-[WebPluginController stopAllPlugins]): Call stopOnePlugin. (-[WebPluginController destroyPlugin:]): Call stopOnePlugin and destroyOnePlugin. (-[WebPluginController destroyAllPlugins]): Call destroyOnePlugin.
15:32 Changeset [50304] by hamaji@chromium.org

2009-10-29 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

fast/css/counters/invalidate-cached-counter-node can be dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=30931

  • fast/css/counters/invalidate-cached-counter-node-expected.txt: Added.
  • fast/css/counters/invalidate-cached-counter-node.html:
  • platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.checksum: Removed.
  • platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.png: Removed.
  • platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.txt: Removed.
14:59 Changeset [50303] by timothy@apple.com

Fix tabbing through element attributes in the Web Insector.

https://bugs.webkit.org/show_bug.cgi?id=30429

Reviewed by Pavel Feldman.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): Don't call _updateTitle,
it is called for us when removeAttribute succeeds in the back-end.
(WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): Ditto except for nodeValue.
(WebInspector.ElementsTreeElement.prototype._editingCancelled): Don't call _updateTitle, editing code reverts.
(WebInspector.ElementsTreeElement.prototype._updateTitle): Return early if we are editing.

14:54 Changeset [50302] by ossy@webkit.org

[Qt] Remove some tests that now pass.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-29

  • platform/qt/Skipped:
14:25 Changeset [50301] by mitz@apple.com

Problem editing or selecting text containing ligatures
https://bugs.webkit.org/show_bug.cgi?id=30025

Reviewed by Sam Weinig.

WebCore:

Test: platform/mac/fast/text/ligature-subdivision.html

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController): Initialize
m_characterInCurrentGlyph.
(WebCore::ComplexTextController::offsetForPosition): If the hit glyph spans multiple
characters, compute the hit character based on dividing the glyph’s total advance into
a number of equal intervals equal to the number of characters and assigning the hit to the
character corresponding to the hit interval.
(WebCore::ComplexTextController::advance): If the final offset occurs mid-glyph, advance
by a fraction of the glyph’s total advance.

  • platform/graphics/mac/ComplexTextController.h: Added m_characterInCurrentGlyph.

LayoutTests:

  • platform/mac/fast/text/ligature-subdivision-expected.txt: Added.
  • platform/mac/fast/text/ligature-subdivision.html: Added.
  • platform/mac/fast/text/script-tests: Added.
  • platform/mac/fast/text/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/js/script-tests/TEMPLATE.html.
  • platform/mac/fast/text/script-tests/ligature-subdivision.js: Added.
14:25 Changeset [50300] by bweinstein@apple.com

Fixes <http://webkit.org/b/30918>.
Web Inspector: Datagrid Rows on Windows not properly aligned.

Reviewed by Timothy Hatcher.

Use line-height for the table rows to make sure the height
of our text and the height of the table rows are consistent.

  • inspector/front-end/inspector.css:
13:33 Changeset [50299] by abarth@webkit.org

2009-10-29 Adam Barth <abarth@webkit.org>

No review, rolling out r50296.
http://trac.webkit.org/changeset/50296

  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext):
13:25 Changeset [50298] by xan@webkit.org

2009-10-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Use the GTK+ main loop instead of rolling our own mini-version of
it.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): (runTest): (webViewLoadFinished):
13:21 Changeset [50297] by kenneth@webkit.org

Rubberstamped by Adam Roben.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Remove two tests that pass on the buildbot.

  • platform/qt/Skipped:
13:15 Changeset [50296] by eric@webkit.org

2009-10-29 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Out-of-memory crash in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=30906

We need to handle the fact that creating a V8:Context might fail. I
don't know how to test this change because creating a context usually
only fails when V8 decides it's using too much memory.

  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext):
13:05 Changeset [50295] by kov@webkit.org

Reviewed by Xan Lopez.

Remove build warning introduced by r50284.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration):
13:05 Changeset [50294] by kenneth@webkit.org

Unreviewed Qt buildbot fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Add some files to skipped that depend on phonon support,
which is disabled on the Qt buildbot for now.

  • platform/qt/Skipped:
13:01 Changeset [50293] by dglazkov@chromium.org

2009-10-29 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

[V8] Remove random crashes by removing retrieval of V8 context during garbage collection.

https://bugs.webkit.org/show_bug.cgi?id=30919

Unfortunately, I haven't been able to trigger this crash explicitly, so no test :(.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::jsWrapperForDOMObject): Added new "assume-it's-there" getter.
  • bindings/v8/V8DOMWrapper.h: Added getter decl.
  • bindings/v8/V8GCController.cpp: (WebCore::GCPrologueVisitor::visitDOMWrapper): Changed to use explicit getter.
12:43 Changeset [50292] by dglazkov@chromium.org

2009-10-29 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[Chromium] Adjust the project files to sync up with
http://trac.webkit.org/changeset/50259

  • WebCore.gypi: Renamed and added files.
12:41 Changeset [50291] by mitz@apple.com

Updated expected result for Tiger

  • platform/mac-tiger/fast/text/international/thai-line-breaks-expected.txt:
12:24 Changeset [50290] by kenneth@webkit.org

Rubberstamped by Adam Roben.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Remove tests that pass after the change introduced in r50289.

  • platform/qt/Skipped:
12:06 Changeset [50289] by kenneth@webkit.org

Implement DRT functionality for Qt introduced in
r28690 and r28705.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Adam Roben.

  • Implemented pathToLocalResource which exposes the functionality of

converting a given unix path to the correct location on Windows.

  • Implemented a way to remove machine-dependent information from paths

in layout test results.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::urlSuitableForTestResult):
(WebCore::WebPage::javaScriptConsoleMessage):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::pathToLocalResource):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:
11:29 Changeset [50288] by eric@webkit.org

2009-10-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Implement DELETE HTTP method for XmlHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=30894

No new tests as this functionality is already tested by the
xmlhttprequest LayoutTests. As this patch depends on an unreleased
version of the dependent QtNetwork library and the tests will be
enabled later once the dependent library is released (and the
buildbot is updated).

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::start):

2009-10-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Implement DELETE HTTP method for XmlHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=30894

No new tests as this functionality is already tested by the
xmlhttprequest LayoutTests. As this patch depends on an unreleased
version of the dependent QtNetwork library and the tests will be
enabled later once the dependent library is released (and the
buildbot is updated).

  • Api/qwebframe.cpp: (QWebFrame::load):
11:15 Changeset [50287] by bweinstein@apple.com

Part of <http://webkit.org/b/30483>.
Web Inspector: Always show the Local and Session Storage Views.

Reviewed by Timothy Hatcher.

Even if the length of the DOM Storage entry array is 0, still
generate the Datagrid because users can add things storage items
through the UI, so we should allow them to even if there isn't
anything there currently.

  • English.lproj/localizedStrings.js: Removed "This Storage is Empty".
  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):

10:58 Changeset [50286] by pfeldman@chromium.org

2009-10-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add TimelinePanel into the panels enum.

https://bugs.webkit.org/show_bug.cgi?id=30915

  • inspector/InspectorController.cpp: (WebCore::InspectorController::specialPanelForJSName):
  • inspector/InspectorController.h: (WebCore::InspectorController::):
10:53 Changeset [50285] by xan@webkit.org

2009-10-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Oliver Hunt.

[GTK] Threading problems with some of the tests
https://bugs.webkit.org/show_bug.cgi?id=30814

Create strings shared among threads with crossThreadString
constructor method.

  • storage/Database.cpp: (WebCore::Database::Database):
10:50 Changeset [50284] by eric@webkit.org

2009-10-29 Sebastian Dröge <sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=30308

Add support for ARGB videos.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint): Create the Cairo image surface for ARGB32 or RGB24 depending on the buffer's caps.
  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_timeout_func): (webkit_video_sink_render): Handle ARGB video and convert GStreamer's ARGB to Cairo's for displaying.
10:42 Changeset [50283] by eric@webkit.org

2009-10-29 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

[chromium] expose a method to access memory usage information in ChromiumBridge
Declare a static method to be implemented by http://codereview.chromium.org/332010/
https://bugs.webkit.org/show_bug.cgi?id=30829

  • platform/chromium/ChromiumBridge.h:
10:34 Changeset [50282] by eric@webkit.org

2009-10-29 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25679
[Gtk] Improve accessibility of focusable lists

Implements the AtkSelection interface and enables the corresponding
(and expected) object:selection-changed event.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (optionFromList): (optionFromSelection): (atk_selection_interface_init): (webkit_accessible_selection_add_selection): (webkit_accessible_selection_clear_selection): (webkit_accessible_selection_ref_selection): (webkit_accessible_selection_get_selection_count): (webkit_accessible_selection_is_child_selected): (webkit_accessible_selection_remove_selection): (webkit_accessible_selection_select_all_selection): (GetAtkInterfaceTypeFromWAIType):
  • accessibility/gtk/AXObjectCacheAtk.cpp: (AXObjectCache::postPlatformNotification):
10:27 Changeset [50281] by sfalken@apple.com

Touch WebKit.idl to force a rebuild.

10:26 Changeset [50280] by bweinstein@apple.com

Rubber-stamped by Steve Falkenburg.

Windows Release bots are having problems in xmlhttprequest tests, Skipping them temporarily
to see if this eliminates the problem, and it is a test causing httpd problems.

  • platform/win/Skipped:
10:18 Changeset [50279] by jianli@chromium.org

Bug 30655 - Only plain text should be copied to clipboard for TextArea.
https://bugs.webkit.org/show_bug.cgi?id=30655

Reviewed by Darin Adler.

  • editing/Editor.cpp:

(WebCore::nodeIsInTextFormControl):
(WebCore::Editor::cut):
(WebCore::Editor::copy):

09:58 Changeset [50278] by pfeldman@chromium.org

2009-10-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: hide timeline for now - not yet ready.

https://bugs.webkit.org/show_bug.cgi?id=30912

  • inspector/front-end/inspector.js: (WebInspector._createPanels):
09:46 Changeset [50277] by pfeldman@chromium.org

2009-10-29 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: deploy Web Inspector's images in WebCore.gypi.

  • WebCore.gypi:
09:36 Changeset [50276] by pfeldman@chromium.org

2009-10-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: get rid of timelineProfilerEnabled method.

https://bugs.webkit.org/show_bug.cgi?id=30911

  • inspector/InspectorBackend.cpp:
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible):
  • inspector/InspectorController.h:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
09:12 Changeset [50275] by pfeldman@chromium.org

2009-10-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Darin Fisher.

Create stub methods for raw cookies access in ChromiumBridge.h

https://bugs.webkit.org/show_bug.cgi?id=30910

  • platform/chromium/ChromiumBridge.h:
08:58 QtWebKitContrib edited by vestbo@webkit.org
(diff)
08:55 QtWebKitContrib edited by vestbo@webkit.org
(diff)
08:44 Changeset [50274] by zoltan@webkit.org

Allow custom memory allocation control for WebCore's RareData
https://bugs.webkit.org/show_bug.cgi?id=30858

Reviewed by Darin Adler.

Inherits RareData struct from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSSelector.h:259 and
it is no need to be copyable.

  • css/CSSSelector.h:
08:41 Changeset [50273] by zoltan@webkit.org

Allow custom memory allocation control for WebCore's ShorthandScope
https://bugs.webkit.org/show_bug.cgi?id=30859

Reviewed by Darin Adler.

Inherits ShorthandScope class from FastAllocBase because it is
instantiated by 'new' in WebCore/css/CSSParser.cpp:902 and
it is no need to be copyable.

  • css/CSSParser.h:
08:38 Changeset [50272] by zoltan@webkit.org

Allow custom memory allocation control for WebCore's AXObjectCache
https://bugs.webkit.org/show_bug.cgi?id=30848

Reviewed by Darin Adler.

Inherits AXObjectCache class from FastAllocBase because it is
instantiated by 'new' in WebCore/dom/Document.cpp:1537 and
it is no need to be copyable.

  • accessibility/AXObjectCache.h:
08:18 Changeset [50271] by abarth@webkit.org

2009-10-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't run JavaScript URLs in view source mode
https://bugs.webkit.org/show_bug.cgi?id=30881

Test that we don't run JavaScript URLs in view source mode.

This test actually passes before this change. I don't know how to
actually run JavaScript URLs in view source frames using DRT, but it's
possible in an abitrary embedding of WebKit.

  • http/tests/security/view-source-no-javascript-url-expected.txt: Added.
  • http/tests/security/view-source-no-javascript-url.html: Added.

2009-10-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't run JavaScript URLs in view source mode
https://bugs.webkit.org/show_bug.cgi?id=30881

Just say no.

Test: http/tests/security/view-source-no-javascript-url.html

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
07:43 Changeset [50270] by kenneth@webkit.org

Remove QWebView::guessUrlFromString() and replace its use
with the new QUrl::fromUserInput() if using Qt 4.6 or newer.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Tor Arne Vestbø.

  • Api/qwebview.cpp:
  • Api/qwebview.h:
  • QGVLauncher/main.cpp:

(urlFromUserInput):
(WebPage::applyProxy):
(MainWindow::load):

  • QtLauncher/main.cpp:

(urlFromUserInput):
(MainWindow::MainWindow):
(MainWindow::changeLocation):

  • tests/qwebview/tst_qwebview.cpp:
06:23 Changeset [50269] by kenneth@webkit.org

Serialize directly to the stream, and not first to an QByteArray,
that is later serialized. That is slower and also uses more bytes.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
Reviewed by Tor Arne Vestbø.

  • Api/qwebhistory.cpp:

(operator<<):
(operator>>):

05:48 Changeset [50268] by kov@webkit.org

Unreviewed. Fixes style problems pointed out by Evan Martin.

05:46 Changeset [50267] by kov@webkit.org

Unreviewed. Trivial fix - move public API declaration into the
public subsection of the doc.

  • docs/webkitgtk-sections.txt:
02:21 Changeset [50266] by mitz@apple.com

Rubber-stamped by Mark Rowe.

64-bit Leopard build fix after r50259

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

Declared ATSUTextInserted in 64-bit.
(WebCore::fontHasMirroringInfo): Use %d format and cast to int.
(WebCore::disableLigatures): Ditto.
(WebCore::initializeATSUStyle): Ditto.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Ditto.

00:32 Changeset [50265] by zoltan@webkit.org

Add cacheFlush support for Thumb-2 on Linux
https://bugs.webkit.org/show_bug.cgi?id=30865

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-10-29
Reviewed by Gavin Barraclough.

  • jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

00:23 Changeset [50264] by mitz@apple.com

Tiger build fix after r50259

  • platform/graphics/mac/ComplexTextController.h:
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:
00:12 Changeset [50263] by mitz@apple.com

Tiger build fix after r50259

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

10/28/09:

23:07 Changeset [50262] by sfalken@apple.com

Fix changelog

23:06 Changeset [50261] by sfalken@apple.com

https://bugs.webkit.org/show_bug.cgi?id=30899
WebKit fails to build release on 32-bit Windows systems

Reviewed by Mark Rowe.

  • WebCore.vcproj/WebCore.vcproj: Excluded files from project.
  • bindings/js/JSBindingsAllInOne.cpp: Added.
23:04 Changeset [50260] by mitz@apple.com

Fixed typos in color names.

Reviewed by Jon Honeycutt.

  • inspector/front-end/Color.js:
22:35 Changeset [50259] by mitz@apple.com

WebCore: Share code between the ATSUI- and Core Text-based Font implementations by doing the
following:

  • Generalize CoreTextController as ComplexTextController, keeping the Core Text-specific parts in ComplexTextControllerCoreText.cpp.
  • Generalize FontMacCoreText as FontComplexTextMac using ComplexTextController
  • Implement ATSUI-specific parts of ComplexTextController in ComplexTextControllerATSUI.
  • Remove FontMacATSUI.

Reviewed by Sam Weinig.

  • WebCore.xcodeproj/project.pbxproj: Removed CoreTextController.{cpp,h}, FontMacATSUI.mm,

and FontMacCoreText.cpp, and added ComplexTextController.{cpp,h},
ComplexTextControllerATSUI.cpp, ComplexTextControllerCoreText.cpp, and
FontComplexTextMac.cpp.

  • platform/graphics/mac/ComplexTextController.cpp: Copied from CoreTextController.cpp and

kept the non-Core Text-specific bits.
(WebCore::ComplexTextController::ComplexTextController): Updated for renames, including
its own.
(WebCore::ComplexTextController::offsetForPosition): Updated for renames and for
m_complexTextRuns holding references instead of objects.
(WebCore::ComplexTextController::collectComplexTextRuns): Updated for renames, including
its own.
(WebCore::ComplexTextController::advance): Updated for renames.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Updated for renames and for
m_complexTextRuns holding references instead of objects, and changed to use the glyphs()
and advances() accessors.

  • platform/graphics/mac/ComplexTextController.h: Copied from CoreTextController.h and

renamed CoreTextController to ComplexTextController and CoreTextRun to ComplexTextRun. Made
the latter RefCounted, added ATSUI-specific members to it, and made some other members
Core Text-specific. Renamed m_coreTextRuns to m_complexTextRuns and made it hold references
rather than objects.
(WebCore::ComplexTextController::ComplexTextRun::create):
(WebCore::ComplexTextController::ComplexTextRun::glyphs):
(WebCore::ComplexTextController::ComplexTextRun::advances):

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp: Added. Includes ATSUI-specific

parts of the ComplexTextController implementation.
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): This ATSUI
callback populates the ComplexTextRun’s glyphs, advances and indices vectors. It is invoked
when the ComplexTextRun constructor calls ATSUGetGlyphBounds().
(WebCore::isArabicLamWithAlefLigature): Helper function, copied from FontMacATSUI.mm.
(WebCore::shapeArabic): Helper function, adapted from FontMacATSUI.mm.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Sets up the
ATSUTextLayout, substituting the text buffer if necessary for things like shaping Arabic,
mirroring glyphs or directionality overrides, then calls ATSUGetGlyphBounds() in order to
get the glyphs, advances and indices vectors populated.
(WebCore::fontHasMirroringInfo): Helper function, copied from FontMacATSUI.mm.
(WebCore::disableLigatures): Ditto.
(WebCore::initializeATSUStyle): Ditto, somewhat cleaned up and simplified.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Constructs
ComplexTextRuns, either missing-glyphs ones or ATSUTextLayout-based ones.

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: Copied from

CoreTextController.cpp and kept the Core Text-specific bits.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Updated for renames,
including its own, and moved the code to initialize m_glyphs and m_advances here. Previously
this was done in adjustGlyphsAndAdvances().
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Updated for renames,
including its own.

  • platform/graphics/mac/CoreTextController.cpp: Removed.
  • platform/graphics/mac/CoreTextController.h: Removed.
  • platform/graphics/mac/FontComplexTextMac.cpp: Renamed FontMacCoreText.cpp to this.

(WebCore::Font::selectionRectForComplexText): Changed to use ComplexTextController instead
of CoreTextController.
(WebCore::Font::drawComplexText): Ditto.
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::Font::offsetForPositionForComplexText): Ditto.

  • platform/graphics/mac/FontMacATSUI.mm: Removed.
  • platform/graphics/mac/FontMacCoreText.cpp: Removed.

LayoutTests: Removed Leopard-specific result after changing ATSUI missing-glyph behavior to match the
Core Text and fast code paths' behavior.

  • platform/mac-leopard/fast/text/international/khmer-selection-expected.txt: Removed.
22:23 Changeset [50258] by rolandsteiner@chromium.org

2009-10-28 Roland Steiner <rolandsteiner@chromium.org>

Adding myself to the committers list.

  • Scripts/modules/committers.py:
21:20 Changeset [50257] by cfleizach@apple.com

Adding myself to the committers list.

19:48 Changeset [50256] by cfleizach@apple.com

WebCore: WAI-ARIA: add support for 'option' role
https://bugs.webkit.org/show_bug.cgi?id=30843

Reviewed by Darin Adler.

Test: accessibility/aria-option-role.html

  • accessibility/AccessibilityListBoxOption.h:

(WebCore::AccessibilityListBoxOption::canHaveChildren):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::RoleEntry::):
(WebCore::AccessibilityRenderObject::canHaveChildren):

LayoutTests: Fix video-pause-immediately.html to avoid using setTimeout().

Patch by Andrew Scherkus <scherkus@chromium.org> on 2009-10-28
Reviewed by Eric Carlson.

This also addresses the flakiness on Windows, where 200ms was not enough time to advance the clock past zero.

https://bugs.webkit.org/show_bug.cgi?id=30889

  • media/video-pause-immediately.html: Replace setTimeout() with timeupdate events.
18:40 Changeset [50255] by barraclough@apple.com

JSC JIT on ARMv7 cannot link jumps >16Mb range
https://bugs.webkit.org/show_bug.cgi?id=30891

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-28
Reviewed by Oliver Hunt.

Start planing all relative jumps as move-32-bit-immediate-to-register-BX.
In the cases where the jump would fall within a relative jump range, use a relative jump.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::~ARMv7Assembler):
(JSC::ARMv7Assembler::LinkRecord::LinkRecord):
(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::executableCopy):
(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::relinkJump):
(JSC::ARMv7Assembler::setInt32):
(JSC::ARMv7Assembler::isB):
(JSC::ARMv7Assembler::isBX):
(JSC::ARMv7Assembler::isMOV_imm_T3):
(JSC::ARMv7Assembler::isMOVT):
(JSC::ARMv7Assembler::isNOP_T1):
(JSC::ARMv7Assembler::isNOP_T2):
(JSC::ARMv7Assembler::linkJumpAbsolute):
(JSC::ARMv7Assembler::twoWordOp5i6Imm4Reg4EncodedImmFirst):
(JSC::ARMv7Assembler::twoWordOp5i6Imm4Reg4EncodedImmSecond):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp5i6Imm4Reg4EncodedImm):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::makeJump):
(JSC::MacroAssemblerARMv7::makeBranch):

  • jit/JIT.h:
  • wtf/Platform.h:
18:25 Changeset [50254] by oliver@apple.com

Improve for..in enumeration performance
https://bugs.webkit.org/show_bug.cgi?id=30887

Reviewed by Geoff Garen.

Improve indexing of an object with a for..in iterator by
identifying cases where get_by_val is being used with a iterator
as the subscript and replace it with a new get_by_pname
bytecode. get_by_pname then optimizes lookups that directly access
the base object.

17:54 Changeset [50253] by eric@webkit.org

2009-10-28 Jens Alfke <snej@chromium.org>

Reviewed by Eric Seidel.

Fix GCC compiler warnings in WebCore, and enable -Wall and -Werror for Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=30716

  • WebCore.gyp/WebCore.gyp: Enable "chromium_code" flag, just on Mac build for now.
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::createARIARoleMap): Fix struct visibiity warning.
  • bindings/v8/ScriptCallStack.h: Fix out-of-order member initialization warning.
  • bindings/v8/V8Collection.h: (WebCore::getV8Object): Function in header should not be 'static' (fixes unused-static warning.)
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertNewNodeToV8Object): Fix signed/unsigned comparison warning.
  • bindings/v8/V8GCController.cpp: (WebCore::ObjectGrouperVisitor::applyGrouping): Fix unused-variable warning.
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Enable ListButtonPart case to avoid

warning about missing cases in 'switch' statement.

  • editing/EditorCommand.cpp: (WebCore::createCommandMap): Fix struct visibiity warning.
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): Fix out-of-order member initialization warning.
  • rendering/RenderMediaControlsChromium.cpp: (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart): Add empty 'default' case in

'switch' statement to avoid missing-case warning.

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Ditto.

  • xml/XPathFunctions.cpp: (WebCore::XPath::createFunctionMap): Fix struct visibiity warning.
17:45 Changeset [50252] by eric@webkit.org

2009-10-28 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Fix video-pause-immediately.html to avoid using setTimeout().

This also addresses the flakiness on Windows, where 200ms was not enough time to advance the clock past zero.

https://bugs.webkit.org/show_bug.cgi?id=30889

  • media/video-pause-immediately.html: Replace setTimeout() with timeupdate events.
17:22 Changeset [50251] by eric@webkit.org

2009-10-28 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION: crashes in WebCore::RedirectScheduler::timerFired(WebCore::Timer<WebCore::RedirectScheduler>*)
https://bugs.webkit.org/show_bug.cgi?id=30839

Added null check for the case when the frame is detached from the page.

  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::timerFired):
17:12 Changeset [50250] by eric@webkit.org

2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30817
Use parentObjectUnignored instead of parentObject in webkit_accessible_get_parent

Also removes the hack I had originally added to solve bug 25411, because
the fix here is what I should have done in the first place.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent):
17:08 Changeset [50249] by bweinstein@apple.com

Rubber-stamped by Ada Chan.

Add accessibility test to the list of Windows Skipped tests.

  • platform/win/Skipped:
16:37 Changeset [50248] by dimich@chromium.org

Not reviewed, attemp to fix Windows build.

Touch the cpp file to cause recompile.

  • wtf/Threading.cpp:

(WTF::threadEntryPoint):

16:21 Changeset [50247] by dimich@chromium.org

JavaScriptCore: Add MessageQueue::removeIf(Predicate&) to remove certain tasks without pulling them from the queue.
Existing Database tests cover this since Database removes tasks when it is stopped.
https://bugs.webkit.org/show_bug.cgi?id=30805

Reviewed by David Levin.

  • wtf/MessageQueue.h:

(WTF::::removeIf):

WebCore: Add MessageQueue::removeIf(Predicate&) to remove certain tasks without pulling them from the queue.
Existing Database tests cover this, no change in functionality.
https://bugs.webkit.org/show_bug.cgi?id=30805

Reviewed by David Levin.

  • storage/DatabaseThread.cpp:

(WebCore::SameDatabasePredicate::SameDatabasePredicate): Added predicate that flags the tasks belonging to a specified database.
(WebCore::SameDatabasePredicate::operator()):
(WebCore::DatabaseThread::unscheduleDatabaseTasks): changed to use the new removeIf method.

16:19 Changeset [50246] by pfeldman@chromium.org

2009-10-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Glue subsequent timeline records with same category
and title together. Enable Timeline Panel!!!

https://bugs.webkit.org/show_bug.cgi?id=30885

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelineRecordTreeElement.prototype.onattach): (WebInspector.TimelineRecordTreeElement.prototype.refresh):
15:56 Changeset [50245] by kov@webkit.org

LayoutTests

Reviewed by Jan Alonzo.

[GTK] API to start inspector for a WebView
https://bugs.webkit.org/show_bug.cgi?id=22551

Unskip inspector tests that we are now able to run.

  • platform/gtk/Skipped:

WebKit/gtk

Reviewed by Jan Alonzo.

[GTK] API to start inspector for a WebView
https://bugs.webkit.org/show_bug.cgi?id=22551

Provide a simple, coordinates-based API to start the inspector.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::createPage): Use files from the source tree when running from the top of the source directory. (WebKit::InspectorClient::localizedStringsURL): Ditto.
  • webkit/webkitprivate.h:
  • webkit/webkitwebinspector.cpp: (webkit_web_inspector_inspect_coordinates): (webkit_web_inspector_close): (webkit_web_inspector_execute_script):
  • webkit/webkitwebinspector.h:

WebKitTools

Reviewed by Jan Alonzo.

[GTK] API to start inspector for a WebView
https://bugs.webkit.org/show_bug.cgi?id=22551

Use the new inspector API to implement the LayoutTestController
interfaces used to test the inspector.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webInspectorInspectWebView): (createWebView):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
15:42 Changeset [50244] by kov@webkit.org

LayoutTests

Reviewed by Xan Lopez.

[GTK] Fails new test fast/js/navigator-language.html
https://bugs.webkit.org/show_bug.cgi?id=30440

Unskip the test that now passes.

  • platform/gtk/Skipped:

WebCore

Reviewed by Xan Lopez.

[GTK] Fails new test fast/js/navigator-language.html
https://bugs.webkit.org/show_bug.cgi?id=30440

Reimplement WebCore::defaultLanguage to account for changes in
locale done by setLocale.

Already existing test: fast/js/navigator-language.html

  • platform/gtk/Language.cpp: (WebCore::defaultLanguage):
15:40 Changeset [50243] by sfalken@apple.com

Should not generate/build COM DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=30880

Reviewed by Sam "Horatio" Weinig.

  • Interfaces/WebKit.idl: Remove generated interfaces.
  • WebKit.vcproj/InterfacesGenerated.vcproj: Removed.
  • WebKit.vcproj/WebKit.sln: Remove InterfacesGenerated.vcproj.
  • WebKit.vcproj/WebKit.submit.sln: Remove InterfacesGenerated.vcproj.
  • WebKit.vcproj/WebKit.vcproj: Remove generated interfaces.
15:36 Changeset [50242] by eric.carlson@apple.com

2009-10-28 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7303145>
Can't exit full screen mode or restart movie after pressing command -R.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::removedFromDocument): (WebCore::HTMLMediaElement::documentWillBecomeInactive):

Exit from fullscreen if necessary.

  • html/HTMLMediaElement.h:

2009-10-28 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7303145>
Can't exit full screen mode or restart movie after pressing command -R.

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController _requestExit]):

New, call media element's exitFullscreen method.

(-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):

Call mediaElement->exitFullscreen() after a delay as it turns around and calls
WebVideoFullscreenController:exitFullscreen.

  • WebView/WebVideoFullscreenHUDWindowController.h:
  • WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindow resignFirstResponder]):

New, don't give up responder status.

(-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):

New, block all command key events.

(-[WebVideoFullscreenHUDWindowController exitFullscreen:]):

Remember when we are in the process of exiting fullscreen, don't allow recursion.

  • WebView/WebView.mm: (-[WebView _exitFullscreen]):

Early return if fullscreen controller is nil.

  • WebView/WebWindowAnimation.h:

Correct comment about _window retain status.

  • WebView/WebWindowAnimation.m: (-[WebWindowScaleAnimation dealloc]):

Don't release _window, we never reatained it.

15:19 Changeset [50241] by hamaji@chromium.org

2009-10-28 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

[Qt] WebFrame::counterValueForElementById must not be exposed
https://bugs.webkit.org/show_bug.cgi?id=30882

  • Api/qwebframe.cpp: (qt_drt_counterValueForElementById):
  • Api/qwebframe.h:

2009-10-28 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

[Qt] WebFrame::counterValueForElementById must not be exposed
https://bugs.webkit.org/show_bug.cgi?id=30882

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::counterValueForElementById):
14:45 Changeset [50240] by ap@apple.com

Unreviewed - a trivial fix to get Windows bots running.

https://bugs.webkit.org/show_bug.cgi?id=30841
<rdar://problem/7342730> WebKit should not pass Referer header through a redirect to a non-secure site

  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::setHeaderFields): Don't try to access empty vector's data.
14:44 Changeset [50239] by eric@webkit.org

2009-10-28 Afonso R. Costa Jr. <afonso.costa@openbossa.org>

Reviewed by Oliver Hunt.

[Qt] Enable YARR when YARR_JIT is enabled
https://bugs.webkit.org/show_bug.cgi?id=30730

When enabling or disabling JIT using JAVASCRIPTCORE_JIT, the ENABLE_YARR should
be toggled also.

14:36 Changeset [50238] by eric@webkit.org

2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25897
[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries

Remove the extraneous object of ROLE_PANEL.

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
14:29 Changeset [50237] by eric@webkit.org

2009-10-28 Jonathan Dixon <joth@chromium.org>

Reviewed by Eric Seidel.

Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius
https://bugs.webkit.org/show_bug.cgi?id=30547

  • fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.
  • fast/css/text-input-with-webkit-border-radius-expected.png: Added.
  • fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
  • fast/css/text-input-with-webkit-border-radius.html: Added.

2009-10-28 Jonathan Dixon <joth@chromium.org>

Reviewed by Eric Seidel.

Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius
https://bugs.webkit.org/show_bug.cgi?id=30547

Test: fast/css/text-input-with-webkit-border-radius.html

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): Implemented rounded border rendering in Chromium Windows theme renderer.
14:17 Changeset [50236] by pfeldman@chromium.org

2009-10-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Pull items collections from resources panel and
timeline panel into AbstractTimelinePanel.

https://bugs.webkit.org/show_bug.cgi?id=30875

  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel): (WebInspector.AbstractTimelinePanel.prototype.populateSidebar): (WebInspector.AbstractTimelinePanel.prototype.createItemTreeElement): (WebInspector.AbstractTimelinePanel.prototype.createItemGraph): (WebInspector.AbstractTimelinePanel.prototype._showCategory): (WebInspector.AbstractTimelinePanel.prototype._hideCategory): (WebInspector.AbstractTimelinePanel.prototype.filter): (WebInspector.AbstractTimelinePanel.prototype._createGraph): (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth): (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelinePanel.prototype.reset): (WebInspector.AbstractTimelinePanel.prototype.get calculator): (WebInspector.AbstractTimelinePanel.prototype.set calculator): (WebInspector.AbstractTimelinePanel.prototype.addItem): (WebInspector.AbstractTimelinePanel.prototype.removeItem): (WebInspector.AbstractTimelinePanel.prototype.refreshItem): (WebInspector.AbstractTimelinePanel.prototype.revealAndSelectItem): (WebInspector.AbstractTimelinePanel.prototype.sortItems): (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition): (WebInspector.AbstractTimelineCategory): (WebInspector.AbstractTimelineCategory.prototype.toString):
  • inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.createItemTreeElement): (WebInspector.ResourcesPanel.prototype.createItemGraph): (WebInspector.ResourcesPanel.prototype.isCategoryVisible): (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourcesPanel.prototype.get searchableViews): (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction.sortFuction): (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction): (WebInspector.ResourcesPanel.prototype.searchMatchFound): (WebInspector.ResourcesPanel.prototype.searchCanceled): (WebInspector.ResourcesPanel.prototype.performSearch): (WebInspector.ResourcesPanel.prototype.refresh): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.removeResource): (WebInspector.ResourcesPanel.prototype.addMessageToResource): (WebInspector.ResourcesPanel.prototype.clearMessages): (WebInspector.ResourcesPanel.prototype.refreshResource): (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded): (WebInspector.ResourcesPanel.prototype._toggleLargerResources): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking): (WebInspector.ResourcesPanel.prototype.get _resources): (WebInspector.ResourceTimeCalculator.prototype._upperBound):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get categories): (WebInspector.TimelinePanel.prototype.populateSidebar): (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype.createItemTreeElement): (WebInspector.TimelinePanel.prototype.createItemGraph): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelineCategory):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
14:05 Changeset [50235] by kenneth@webkit.org

Rubberstamped by Oliver Hunt.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
Fix the warning:

"warning: ignoring return value of 'char* getcwd(char*, size_t)',
declared with attribute warn_unused_result".

by actually checking the result. In the case it is null, an
error has occoured, so treat it as the other fatal errors.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::initializeFonts):

13:45 Changeset [50234] by eric@webkit.org

2009-10-28 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Resets InspectorFrontend in InspectorTimelineAgent instead of removing it so
that it remains active on refreshs and page transitions.
https://bugs.webkit.org/show_bug.cgi?id=30874

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::resetFrontendProxyObject):
  • inspector/InspectorTimelineAgent.h:
13:14 Changeset [50233] by hamaji@chromium.org

2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555

  • Api/qwebframe.cpp: (QWebFrame::counterValueForElementById): (QWebHitTestResult::frame):
  • Api/qwebframe.h:

2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_counter_value_for_element_by_id):

2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp: (WebFrame::counterValueForElementById):
  • WebFrame.h:

2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555

Add counterValueForElement in WebFrame to call WebCore::counterValueForElement.

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame counterValueForElement:]):

2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555

Expose WebCore::counterValueForElement as a WebCore API.

  • WebCore.base.exp:
  • rendering/RenderTreeAsText.cpp: (WebCore::writeCounterValuesFromChildren): (WebCore::counterValueForElement):
  • rendering/RenderTreeAsText.h:

2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555

Convert two pixel tests to dumpAsText tests using counterValueForElementById.

  • fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
  • fast/css/counters/t1204-increment-00-c-o.html:
  • fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.
  • fast/css/counters/t1204-increment-01-c-o.html:
  • platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.checksum: Removed.
  • platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.png: Removed.
  • platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.txt: Removed.
  • platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.checksum: Removed.
  • platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.png: Removed.
  • platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.txt: Removed.
  • platform/qt/fast/css/counters/t1204-increment-00-c-o-expected.txt: Removed.
  • platform/qt/fast/css/counters/t1204-increment-01-c-o-expected.txt: Removed.

2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555

Define layoutTestContoller.counterValueForElementById.

  • DumpRenderTree/LayoutTestController.cpp: (counterValueForElementByIdCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::counterValueForElementById):
13:07 Changeset [50232] by oliver@apple.com

2009-10-24 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Oliver Hunt.

Fix strict aliasing warning by switching reinterpret_cast to bitwise_cast.

strict-aliasing warnings in JSFunction.h
https://bugs.webkit.org/show_bug.cgi?id=27869

  • runtime/JSFunction.h: (JSC::JSFunction::nativeFunction): (JSC::JSFunction::scopeChain): (JSC::JSFunction::setScopeChain): (JSC::JSFunction::setNativeFunction):
12:57 Changeset [50231] by japhet@chromium.org

2009-10-28 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium build fix for r50225.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType):
12:52 Changeset [50230] by eric@webkit.org

2009-10-28 Eric Z. Ayers <zundel@google.com>

Reviewed by Pavel Feldman.

Adds InspectorTimelineAgent instrumentation for encountering a
<SCRIPT> tag when parsing an HTML document.

https://bugs.webkit.org/show_bug.cgi?id=30861

  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::startLine): (WebCore::ScriptSourceCode::url):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::willScriptTag): (WebCore::InspectorTimelineAgent::didScriptTag):
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createScriptTagTimelineRecord):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
12:23 Changeset [50229] by eric@webkit.org

2009-10-28 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Makes sure that Geolocation watch IDs remain positive on overflow.
https://bugs.webkit.org/show_bug.cgi?id=30122

No new tests possible.

  • page/Geolocation.cpp: Modified. (WebCore::Geolocation::watchPosition): Modified. Reset the watch ID to 1 on overflow.
12:03 Changeset [50228] by staikos@webkit.org

2009-10-28 George Staikos <george.staikos@torchmobile.com>

Attempt to fix the Mac debug build after 50225.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType):
11:35 Changeset [50227] by bweinstein@apple.com

Windows build fix, add missing #include.

11:15 Changeset [50226] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30841
<rdar://problem/7342730> WebKit should not pass Referer header through a redirect to a non-secure site

Tests: http/tests/ssl/referer-301.html

http/tests/ssl/referer-303.html

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Remove Referer header if redirecting from https to another protocol.
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::clearHTTPReferrer): Update request counterparts, as it is always done when changing or adding header fields. (WebCore::ResourceRequestBase::clearHTTPOrigin): Ditto.
  • platform/network/ResourceRequestBase.h: clearHTTPReferrer() and clearHTTPOrigin() are no longer inline, since they have non-trivial implementations.
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Fixed to synchronize header field removals. (WebCore::ResourceRequest::doUpdateResourceRequest): Ditto.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::setHeaderFields): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest): Match Mac changes.
11:12 Changeset [50225] by staikos@webkit.org

2009-10-28 Joe Mason <jmason@rim.com>

Reviewed by Adam Treat.

Add FrameLoader::defaultObjectContentType, containing common code for
implementing FrameLoaderClient::objectContentType. (Currently the gtk
and win ports have copied this code, and the qt port uses similar code
with a few extra clauses. Moving this to a utility function cuts down
on copied code.) This causes no behavioural change.

https://bugs.webkit.org/show_bug.cgi?id=30868

11:00 Changeset [50224] by kenneth@webkit.org

[Qt] QWebHistory::saveState() is inconsistent with the Qt API
https://bugs.webkit.org/show_bug.cgi?id=30710

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
Reviewed by Tor Arne Vestbø.

WebCore:

Enforce the versioning, by ignoring any version different
from 1.

  • history/qt/HistoryItemQt.cpp:

(WebCore::HistoryItem::restoreState):
(WebCore::HistoryItem::saveState):

WebKit/qt:

Make the versioning internal and enforce it in the WebCore
part. Adjust the comments, as well as remove now dead code.

  • Api/qwebhistory.cpp:

(operator<<):
(operator>>):

  • Api/qwebhistory.h:
10:10 Changeset [50223] by eric@webkit.org

2009-10-28 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

Added special expected test result for Tiger to fix regression tests.
https://bugs.webkit.org/show_bug.cgi?id=30811

  • platform/mac-tiger/fast/js/navigator-language-expected.txt: Added.
10:09 Changeset [50222] by pfeldman@chromium.org

2009-10-28 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: follow up fix to InspectorControllerStub.
Define it after inspector.js due to namespace

https://bugs.webkit.org/show_bug.cgi?id=30866

  • inspector/front-end/inspector.html:
10:03 Changeset [50221] by pfeldman@chromium.org

2009-10-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add InspectorController stub in order to
support opening in standalone mode.

https://bugs.webkit.org/show_bug.cgi?id=30866

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/InspectorControllerStub.js: Added. (.WebInspector.InspectorControllerStub):
10:02 Changeset [50220] by eric@webkit.org

2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25897
[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries

Expands upon the new funtionality which allows platforms to indicate
that a particular object should not be ignored, so that they can
specify that an object should be ignored or that it should be left up
to the default handling to decide.

  • accessibility/AccessibilityObject.h:
  • accessibility/chromium/AccessibilityObjectChromium.cpp:
  • accessibility/gtk/AccessibilityObjectAtk.cpp:
  • accessibility/mac/AccessibilityObjectMac.mm:
  • accessibility/qt/AccessibilityObjectQt.cpp:
  • accessibility/win/AccessibilityObjectWin.cpp:
  • accessibility/wx/AccessibilityObjectWx.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
  • accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::accessibilityIsIgnored):
09:53 Changeset [50219] by eric@webkit.org

2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25534
[GTK] Objects of ROLE_TABLE should implement the accessible table interface

Expose the table summary as the accessible description because there is no summary object.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_description):
09:14 Changeset [50218] by vestbo@webkit.org

Use JSVALUE64 on 64-bit Windows

Patch by Jan-Arve Sæther <jan-arve.saether@nokia.com> on 2009-10-28
Reviewed by Tor Arne Vestbø.

  • wtf/Platform.h: Make sure WTF_USE_JSVALUE64 is defined
08:10 Changeset [50217] by tonikitoo@webkit.org

Pushing missing WebKit/qt/tests/qwebframe/resources/ dir from bug 29248.

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-28
[Qt] [API] Make it possible to have 'invisible' loads
https://bugs.webkit.org/show_bug.cgi?id=29248

  • tests/qwebframe/resources/image2.png: Copied from WebKit/qt/tests/qwebelement/image.png.
06:54 Changeset [50216] by ossy@webkit.org

Rubber-stamped by Holger Freyther.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-28
[Qt] Remove http/tests/security tests from
skiplist, and add only now failing tests.

  • platform/qt/Skipped:
06:54 Changeset [50215] by steveblock@google.com

Adds ScriptController::intializeThreading(), with both JSC and V8 implementations.
https://bugs.webkit.org/show_bug.cgi?id=30678

Reviewed by Eric Seidel.

This new method is used from common code, rather than calling JSC::initializeThreading() (or the V8 equivalent) directly.

Build fix, no new tests required.

  • bindings/js/ScriptController.cpp: Modified.

(WebCore::ScriptController::initializeThreading): Added.

  • bindings/js/ScriptController.h: Modified. Adds ScriptController::initializeThreading().
  • bindings/v8/ScriptController.cpp: Modified.

(WebCore::ScriptController::initializeThreading): Added.

  • bindings/v8/ScriptController.h: Modified. Adds ScriptController::initializeThreading().
  • loader/icon/IconDatabase.cpp: Modified.

(WebCore::iconDatabase): Call ScriptController::initializeThreading(), rather than JSC::initializeThreading().

  • storage/Database.cpp: Modified.

(WebCore::Database::Database): Call ScriptController::initializeThreading(), rather than JSC::initializeThreading().

06:18 Changeset [50214] by kenneth@webkit.org

[Qt] QWebHistory::saveState() is inconsistent with the Qt API
https://bugs.webkit.org/show_bug.cgi?id=30710

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
Reviewed by Holger Freyther.

Remove the QWebHistory::saveState() and ::restoreState() as
they are inconsistent with the Qt API.

Update unittests to reflect the change.

  • Api/qwebhistory.cpp:

(operator<<):
(operator>>):

  • Api/qwebhistory.h:
  • tests/qwebhistory/tst_qwebhistory.cpp:

(saveHistory):
(restoreHistory):
(tst_QWebHistory::saveAndRestore_crash_1):
(tst_QWebHistory::saveAndRestore_crash_2):
(tst_QWebHistory::saveAndRestore_crash_3):
(tst_QWebHistory::clear):

04:44 Changeset [50213] by zecke@webkit.org

Document a feature of the m_liveDecodedResources list.

https://bugs.webkit.org/show_bug.cgi?id=30209
Reviewed by Darin Adler.

Document a feature of the m_liveDecodedResources list.
https://bugs.webkit.org/show_bug.cgi?id=30209

The code made the assumption that the list is sorted by
the m_lastDecodedAccessTime property of the CachedResource.
The above is not true when CachedResource::setDecodedSize
is called and the item is inserted the first time. In this
case the m_lastDecodedAccessTime is still zero and the
m_liveDecodedResources list becomes unsorted.

It is impossible that Cache::pruneLiveResources will
stop to process the list too early due this feature and
the alternatives of updating m_lastDecodedAccessTime in
CachedResource::setDecodedSize or changing the insert
to search the right position have a negative impact on
performance. The best solution for now is to document
this feature.

  • loader/Cache.cpp:

(WebCore::Cache::pruneLiveResources):

  • loader/CachedResource.cpp:

(WebCore::CachedResource::setDecodedSize):

04:24 Changeset [50212] by zecke@webkit.org

Speculative build-fix for WebElementPropertyBag.cpp

  • WebElementPropertyBag.cpp: Include RenderObject.h
04:06 Changeset [50211] by barraclough@apple.com
  • jit/JIT.h:

Reviewed by NOBODY (build fix!).

04:05 Changeset [50210] by ossy@webkit.org

[Qt] Remove http/tests/misc tests from
skiplist, and add only now failing tests.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-28

  • platform/qt/Skipped:
03:23 Changeset [50209] by tonikitoo@webkit.org

Complementary fix to bug 30779.

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-27
Reviewed by Holger Freyther.

By mistake I used QWeakPointer's toStrongRef() method which docs
explicitly say to not be used in this situation (when the tracked
pointer is devired from QObject). Instead QWeakPointer's data()
is recommended.

  • Api/qwebpage.cpp:

(QWebPage::view):

03:18 Changeset [50208] by xan@webkit.org

WebCore:

2009-10-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
https://bugs.webkit.org/show_bug.cgi?id=25897

Make text controls always implement the text interface, and the
editable text interface when they are not read only. This is what
ATK-users expect.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getInterfaceMaskFromObject):

WebKit/gtk:

2009-10-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
https://bugs.webkit.org/show_bug.cgi?id=25897

Update test to also check that entries implement the AtkText
interface.

  • tests/testatk.c: (run_get_text_tests): (test_webkit_atk_get_text_at_offset_forms): (test_webkit_atk_get_text_at_offset): (main):
03:16 Changeset [50207] by zecke@webkit.org

Fix assertion in SVGRenderBase::mapLocalToContainer resulting from HitTestResult::boundinBox()

https://bugs.webkit.org/show_bug.cgi?id=27347

The current HitTestResult methods are not using the (3d)
transformation aware routines. This can lead to an assertion
SVGRenderBase::mapLocalToContainer method.

Remove HitTestResult::boundingBox() as it is only used in
two places and conceptually doesn't belong into a HitTest
which is operating on points. Update the Qt and Win code
to determine the rect themselves in a (3d) transformation
fashion.

Change HitTestResult::imageRect to use the (3d) transformation
aware RenderBox::absoluteContentQuad to avoid running into
an assertion with SVG content.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::imageRect):

  • rendering/HitTestResult.h:
  • WebElementPropertyBag.cpp:

(WebElementPropertyBag::Read):

  • Api/qwebframe.cpp:

(QWebHitTestResultPrivate::QWebHitTestResultPrivate):

03:16 Changeset [50206] by zecke@webkit.org

[Qt] Custom Cursor doesn't use hotspot.

Cursors loaded from a QPixmap didn't specifiy the
hotspot. Take the hotspot values from the mac
implementation.

  • platform/qt/CursorQt.cpp:
03:16 Changeset [50205] by zecke@webkit.org

Export fastMalloc, fastCalloc, fastRealloc and fastFree

Export the FastMalloc functions outside of the libwebkit library
to be able to instrument memory allocations. These are C++ symbols
but do not require the C++ runtime to be useful and should be of
no harm to plain C code.

  • autotools/symbols.filter:
03:14 Changeset [50204] by zecke@webkit.org

Export fastMalloc, fastCalloc, fastRealloc and fastFree on GCC/Unix

https://bugs.webkit.org/show_bug.cgi?id=30769

When using -fvisibility=hidden to hide all internal symbols by default
the malloc symbols will be hidden as well. For memory instrumentation
it is needed to provide an instrumented version of these symbols and
override the normal routines and by changing the visibility back to
default this becomes possible.

The only other solution would be to use system malloc instead of the
TCmalloc implementation but this will not allow to analyze memory
behavior with the default allocator.

  • wtf/FastMalloc.h: Define WTF_FAST_MALLOC_EXPORT for GCC and !darwin
02:59 Changeset [50203] by pfeldman@chromium.org

2009-10-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by NOBODY (OOPS!).

Web Inspector: Initial revision of the Timeline grid.

https://bugs.webkit.org/show_bug.cgi?id=30834

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.populateSidebar): (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelineCalculator):
  • inspector/front-end/Images/timelineBarBlue.png: Added.
  • inspector/front-end/Images/timelineBarGray.png: Added.
  • inspector/front-end/Images/timelineBarGreen.png: Added.
  • inspector/front-end/Images/timelineBarOrange.png: Added.
  • inspector/front-end/Images/timelineBarPurple.png: Added.
  • inspector/front-end/Images/timelineBarRed.png: Added.
  • inspector/front-end/Images/timelineBarYellow.png: Added.
  • inspector/front-end/Images/timelineCheckmarks.png: Added.
  • inspector/front-end/Images/timelineDots.png: Added.
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceTimeCalculator): (WebInspector.ResourceTransferSizeCalculator):
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype.get categories): (WebInspector.TimelinePanel.prototype.populateSidebar): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype.addItemToTimeline): (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClick): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype.showCategory): (WebInspector.TimelinePanel.prototype.hideCategory): (WebInspector.TimelineRecordTreeElement): (WebInspector.TimelineRecordTreeElement.prototype.onattach): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.computePercentageFromEventTime): (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.formatValue): (WebInspector.TimelineGraph): (WebInspector.TimelineGraph.prototype.get graphElement): (WebInspector.TimelineGraph.prototype.refreshLabelPositions): (WebInspector.TimelineGraph.prototype.refresh):
  • inspector/front-end/inspector.css:
00:48 Changeset [50202] by ossy@webkit.org

Put tests into skiplist added in r50168 and r50162 because
layoutTestController.showWebInspector() is unimplemented now.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-28
Reviewed by Holger Freyther.

  • platform/qt/Skipped:

inspector/console-format-collections.html added
inspector/javascript-syntax-highlight.html added

00:13 Changeset [50201] by barraclough@apple.com

Rubber Stamped by Samuel Q. Weinig.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-27
Make the asserts protecting the offsets in the JIT more descriptive.

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):

10/27/09:

23:50 Changeset [50200] by mitz@apple.com

Rubber-stamped by Sam Weinig.

Changed this test to use -webkit-box-shadow instead of box-shadow after r49003.

  • fast/box-shadow/inset.html:
23:43 Changeset [50199] by joepeck@webkit.org

2009-10-27 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Move runAfterPendingDispatches to TestController for Clarity
https://bugs.webkit.org/show_bug.cgi?id=30844

  • inspector/front-end/TestController.js: (WebInspector.TestController.prototype.runAfterPendingDispatches):
  • inspector/front-end/inspector.js: moved runAfterPendingDispatches
22:19 Changeset [50198] by darin@chromium.org

2009-10-27 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

Add missing forward declaration of FramelessScrollView.
https://bugs.webkit.org/show_bug.cgi?id=30824

  • platform/chromium/FramelessScrollViewClient.h:
20:44 Changeset [50197] by cfleizach@apple.com

No review.

ARIA menu/menu item need AXRoleDescription
https://bugs.webkit.org/show_bug.cgi?id=30804

Layout test fix for Tiger/Leopard.

  • platform/mac-leopard/accessibility/table-with-aria-role-expected.txt:
20:39 Changeset [50196] by cfleizach@apple.com

WAI-ARIA: add support for 'presentation' role
https://bugs.webkit.org/show_bug.cgi?id=30806

Reviewed by Adele Peterson.

WebCore:

Test: accessibility/aria-presentational-role.html

  • accessibility/AccessibilityObject.h:

(WebCore::):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::RoleEntry::):

LayoutTests:

  • accessibility/aria-presentational-role-expected.txt: Added.
  • accessibility/aria-presentational-role.html: Added.
19:56 Changeset [50195] by cfleizach@apple.com

ARIA menu/menu item need AXRoleDescription
https://bugs.webkit.org/show_bug.cgi?id=30804

Reviewed by Darin Adler.

WebCore:

Make sure that role descriptions will default to the system's first, before
returning an unknown role.

Test: platform/mac/accessibility/aria-menu-role-descriptions.html

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper roleDescription]):

LayoutTests:

  • platform/mac/accessibility/aria-menu-role-descriptions-expected.txt: Added.
  • platform/mac/accessibility/aria-menu-role-descriptions.html: Added.
  • platform/mac/accessibility/table-with-aria-role-expected.txt:
19:20 Changeset [50194] by ggaren@apple.com

Qt build fix: migrated away from API that no longer exists.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

18:37 Changeset [50193] by ggaren@apple.com

Qt build fix: migrated away from API that no longer exists.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

18:30 Changeset [50192] by oliver@apple.com

Fix wording in comment.

18:26 Changeset [50191] by oliver@apple.com

Crash occurs after launching Newsfire 1.6 for the first time
https://bugs.webkit.org/show_bug.cgi?id=30807

Reviewed by Darin Adler.

We allocate an autorelease pool but then store it off the stack. In a
GC environment this led to it being collected, and thus caused badness
to ensue. To work around this we simply avoid using a pool at all in
a GC environment as it would be a no-op anyway.

18:07 Changeset [50190] by eric@webkit.org

2009-10-27 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

When a Geolocation method is called, immediately calls the error calback asynchronously if permissions have already been denied.
https://bugs.webkit.org/show_bug.cgi?id=27944.

  • fast/dom/Geolocation/resources/permission-denied-already-error.js: Added. Tests that when permission has already been denied, the error callback is invoked with code PERMISSION_DENIED, when the Geolocation service reports an error.
  • fast/dom/Geolocation/permission-denied-already-error.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/permission-denied-already-error-expected.txt: Added. Expected result for above test.
  • fast/dom/Geolocation/resources/permission-denied-already-success.js: Added. Tests that when permission has already been denied, the error callback is invoked with code PERMISSION_DENIED, when the Geolocation service has a good position fix.
  • fast/dom/Geolocation/permission-denied-already-success.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/permission-denied-already-success-expected.txt: Added. Expected result for above test.
  • fast/dom/Geolocation/resources/permission-denied.js: Modified. Updates error string.
  • fast/dom/Geolocation/permission-denied-expected.txt: Modified. Expected result for above test.
  • fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Modified. Updates error string.
  • fast/dom/Geolocation/permission-denied-expected-stops-watches.txt: Modified. Expected result for above test.
  • platform/gtk/Skipped: Modified. Adds above tests to skipped list.

2009-10-27 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

When a Geolocation method is called, immediately calls the error calback asynchronously if permissions
have already been denied.
https://bugs.webkit.org/show_bug.cgi?id=27944.

Tests: fast/dom/Geolocation/permission-denied-already-error.html

fast/dom/Geolocation/permission-denied-already-success.html

  • page/Geolocation.cpp: Modified. (WebCore::Geolocation::GeoNotifier::GeoNotifier): Modified. GeoNotifier takes Geolocation object as constructor argument. (WebCore::Geolocation::GeoNotifier::setFatalError): Added. Sets a fatal error for this notifier, causing it to terminate immediately and call the error callback asynchronously. (WebCore::Geolocation::GeoNotifier::timerFired): Added. Used to call the error callback asynchronously on fatal error. (WebCore::Geolocation::getCurrentPosition): Modified. Calls startRequest. (WebCore::Geolocation::watchPosition): Modified. Calls startRequest. (WebCore::Geolocation::startRequest): Added. Common functionality for starting a one-shot or watch request. Sets a fatal error on the notifier if permissions have already been denied. (WebCore::Geolocation::fatalErrorOccurred): Added. Registers that a notifier has encountered a fatal error and should be destroyed. (WebCore::Geolocation::setIsAllowed): Modified. Uses a standard error message for the error callback when permissions are denied.
  • page/Geolocation.h: Modified. (WebCore::Geolocation::isDenied): Added. Determines whether permissions have been denied.
17:58 Changeset [50189] by mrowe@apple.com

Versioning.

17:58 Changeset [50188] by mrowe@apple.com

New tag.

17:57 Changeset [50187] by mrowe@apple.com

Merge r50165.

17:21 Changeset [50186] by simon.fraser@apple.com

2009-10-27 Chris Marrin <cmarrin@apple.com>

Reviewed by Oliver Hunt.

Fixed a bug where I was using the wrong Canvas pointer to do a cross-domain check
https://bugs.webkit.org/show_bug.cgi?id=30840

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
17:18 Changeset [50185] by eric@webkit.org

2009-10-27 Eric Seidel <eric@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGStyledElement::getPresentationAttribute() can return a shared CSSValue (some SVG tests randomly fail on the bot, and in release builds)
https://bugs.webkit.org/show_bug.cgi?id=29620

  • svg/dom/getPresentationAttribute-cache-corruption-expected.txt: Added.
  • svg/dom/getPresentationAttribute-cache-corruption.svg: Added.

2009-10-27 Eric Seidel <eric@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGStyledElement::getPresentationAttribute() can return a shared CSSValue (some SVG tests randomly fail on the bot, and in release builds)
https://bugs.webkit.org/show_bug.cgi?id=29620

SVG was modifying CSSValues cached of off CSSMappedAttributeDeclarations.
This patch fixes the check to make sure that a new CSSMappedAttributeDeclaration is
created before returning a CSSValue that JavaScript can modify.

Test: svg/dom/getPresentationAttribute-cache-corruption.svg

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute):
16:32 Changeset [50184] by mitz@apple.com

Incomplete repaint of text field in relative positioned inline at imdb.com
https://bugs.webkit.org/show_bug.cgi?id=30047

Reviewed by Simon Fraser.

WebCore:

Test: fast/repaint/inline-relative-positioned.html

Implemented offsetFromContainer(), mapLocalToContainer() and
mapAbsoluteToLocalPoint() in RenderInline.

  • rendering/RenderBox.h: Fixed argument names in the declaration of

mapLocalToContainer().

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::offsetFromContainer):
(WebCore::RenderInline::mapLocalToContainer):
(WebCore::RenderInline::mapAbsoluteToLocalPoint):

  • rendering/RenderInline.h:

LayoutTests:

  • fast/repaint/inline-relative-positioned-expected.checksum: Added.
  • fast/repaint/inline-relative-positioned-expected.png: Added.
  • fast/repaint/inline-relative-positioned-expected.txt: Added.
  • fast/repaint/inline-relative-positioned.html: Added.
16:29 Changeset [50183] by ggaren@apple.com

JavaScriptCore: A little bit of refactoring in the date code.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27
Reviewed by Sam Weinig.

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

  • runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):

  • runtime/DateInstance.h: Removed some unused functions. Changed the default

constructor to ensure that a DateInstance is always initialized.

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype): Pass an initializer to our constructor,
since it now requires one.

  • wtf/DateMath.cpp:

(WTF::msToGregorianDateTime): Only compute our offset from UTC if our
output will require it. Otherwise, our offset is 0.

WebKit/mac: Updated for refactoring in the date code.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27
Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(aeDescFromJSValue): Since we just want a number of milliseconds, do that
instead of something more complicated.

16:22 Changeset [50182] by jorlow@chromium.org

Speculative build fix for Chromium.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-27

  • platform/graphics/GraphicsContext3D.h:
15:41 Changeset [50181] by cmarrin@apple.com

Make WebGL context failure more robust and make it succeed in more cases
https://bugs.webkit.org/show_bug.cgi?id=30349

Bubble a failure to get a CGLContext up to HTMLContextElement so it can
return null from getContext. Also added a more robust pixel format choosing
mechanism and can render correctly when a SW renderer is chosen.

15:20 Changeset [50180] by ggaren@apple.com

Mac build fix: a forwarding header.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

  • ForwardingHeaders/wtf/DateInstanceCache.h: Added.
15:12 Changeset [50179] by ggaren@apple.com

Build fix: Mark DateInstaceCache.h private, so other frameworks can see it.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

15:09 Changeset [50178] by ggaren@apple.com

Build fix: Updated for JavaScriptCore export changes.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

  • ForwardingHeaders/wtf/DateInstanceCache.h: Added.
15:09 Changeset [50177] by rniwa@webkit.org

No Review.

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-27
Making fontWeightIsBold static to fix Snow Leopard build.

  • editing/ApplyStyleCommand.cpp:

(WebCore::fontWeightIsBold):

15:04 Changeset [50176] by eric@webkit.org

2009-10-27 Kinuko Yasuda <kinuko@google.com>

Reviewed by Darin Adler.

Fixing a test case that yields FAIL results. Also updating
the corresponding expected results.
https://bugs.webkit.org/show_bug.cgi?id=30821

  • storage/domstorage/complex-values-expected.txt:
  • storage/domstorage/script-tests/complex-values.js:
15:04 Changeset [50175] by ggaren@apple.com

Build fix: re-readded this file.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

  • runtime/DateInstanceCache.h: Added.

(JSC::DateInstanceData::create):
(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::DateInstanceCache):
(JSC::DateInstanceCache::add):
(JSC::DateInstanceCache::lookup):

15:01 Changeset [50174] by ggaren@apple.com

JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=30800
Cache recently computed date data.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27
Reviewed by Darin Adler and Oliver Hunt.

SunSpider reports a ~0.5% speedup, mostly from date-format-tofte.js.

  • runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):
(JSC::DateInstance::getGregorianDateTime): Use the shared cache.

  • runtime/DateInstance.h: Renamed m_cache to m_data, to avoid the confusion

of a "cache cache".

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Pass an ExecState to these functions, so they
can access the DateInstanceCache.

  • runtime/JSGlobalData.h: Keep a DateInstanceCache.

JavaScriptGlue: Updated for JavaScriptCore export changes.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27
Reviewed by Oliver Hunt.

  • ForwardingHeaders/wtf/DateMath.h: Added.
14:51 Changeset [50173] by darin@chromium.org

2009-10-27 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Ensures that JavaScriptCore/wtf/CurrentTime.cpp is not built in PLATFORM(CHROMIUM) builds.

Chromium uses a different method to calculate the current time than is used in
JavaScriptCore/wtf/CurrentTime.cpp. This can lead to time skew when calls to currentTime() and Chromium's time
function are mixed. In particular, timers can get scheduled in the past which leads to 100% CPU use.
See http://code.google.com/p/chromium/issues/detail?id=25892 for an example.

https://bugs.webkit.org/show_bug.cgi?id=30833

14:50 Changeset [50172] by rniwa@webkit.org

WebKit cannot remove nested bold tags
https://bugs.webkit.org/show_bug.cgi?id=30784

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-27
Reviewed by Eric Seidel.

WebCore:

This patch modifies getPropertiesNotInComputedStyle so that it compares font-weight
more flexibly. Instead of comparing cssText, it uses fontWeightIsBold which converts
all font weights to either bold or unbold state.

  • editing/ApplyStyleCommand.cpp:

(WebCore::fontWeightIsBold):
(WebCore::getPropertiesNotInComputedStyle): Removes font-weight property
if two style have the same value under getFontWeightValue

LayoutTests:

Adds two more edge cases to remove-nested-inline-styles.js:
<b><b><b>12</b></b></b> and <b><b><b>1</b></b>2</b>
WebKit now passes the one existing test used to fail.

  • editing/style/remove-nested-inline-styles-expected.txt: Added two tests.
  • editing/style/script-tests/remove-nested-inline-styles.js: Added two tests.
14:04 Changeset [50171] by eric@webkit.org

2009-10-27 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

Give an ability to WebKit to free statically allocated pointers
before quit.
https://bugs.webkit.org/show_bug.cgi?id=27980

No new tests for this as the change does not affect WebKit
functionality, but only memory usage.

  • JavaScriptCore/wtf/StdLibExtras.h: Allowed for the override of DEFINE_STATIC_LOCAL via compiler commandline options or elsewhere in the code. Useful for implementing custom builds that free resources allocated via DEFINE_STATIC_LOCAL.
14:02 WebKit Team edited by joepeck@webkit.org
Added Myself (diff)
13:42 Changeset [50170] by dumi@chromium.org

Build fix, no review needed.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-27
Fixing the BUILD. m_estimatedSize in Database.h should be of type
'unsigned long' instead of 'unsigned long long'.

No tests required.

  • storage/Database.h:
13:14 Changeset [50169] by dumi@chromium.org

Refactoring the Database class to not depend on
OriginQuotaManager. Also, adding a SecurityOrigin copy to each
Database instance, that is safe to use on the file
thread. Finally, adding new simple fields and getters to the
Database object for storing/getting the display name and estimated
size specified by the user in the openDatabase() call.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-27
Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=30548

  • page/SecurityOrigin.h:
  • storage/Database.cpp:

(WebCore::Database::openDatabase): Storing the display name and
the estimated size in the Database object.
(WebCore::Database::Database): Storing the display name and the
estimated size in the Database object, as well as a SecurityOrigin
instance that is safe to use on the DB thread.
(WebCore::Database::maximumSize): Delegate the call to
DatabaseTracker::getMaxSizeForDatabase().
(WebCore::Database::databaseThreadSecurityOrigin): Return the
SecurityOrigin instance that's safe to use on the DB thread.
(WebCore::Database::threadSafeSecurityOrigin): Return the
SecurityOrigin instance that's safe to use on the current thread.
(WebCore::Database::displayName): Return the display name
specified by the user in the openDatabase() call.
(WebCore::Database::estimatedSize): Return the estimated size
specified by the user in the openDatabase() call.
(WebCore::Database::fileName): Return the name of the file where
the current Database is tored.

  • storage/Database.h:
  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase): Returns the
maximum size for a DB file based on the current size of that file
and the space available for that origin.

  • storage/DatabaseTracker.h:
  • storage/SQLTransaction.cpp:
  • storage/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didCommitTransaction): Use the
correct SecurityOrigin instance.

12:37 Changeset [50168] by joepeck@webkit.org

2009-10-27 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Pretty Print all HTML Collection Types like we do for NodeList
https://bugs.webkit.org/show_bug.cgi?id=30709

Test: inspector/console-format-collections.html

  • inspector/front-end/InjectedScript.js: (Object.type): check for instances of HTMLCollection like we do for NodeList
  • inspector/front-end/inspector.js: added WebInspector.pendingDispatches counter (WebInspector.dispatch): increment and decrement dispatch counter (WebInspector.runAfterPendingDispatches): run when there are no more dispatches
12:30 Changeset [50167] by eric@webkit.org

2009-10-27 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Adds XMLHttpRequest support to InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=30578

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willChangeXHRReadyState): (WebCore::InspectorTimelineAgent::didChangeXHRReadyState): (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::didLoadXHR):
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createXHRReadyStateChangeTimelineRecord): (WebCore::TimelineRecordFactory::createXHRLoadTimelineRecord):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
12:23 Changeset [50166] by kenneth@webkit.org

Rubberstamped by Oliver Hunt.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-27
Change two methods to be internal for DRT use only.

Part of [Qt] Review all new API in Qt 4.6
https://bugs.webkit.org/show_bug.cgi?id=29843#c11

WebKit/qt:

  • Api/qwebsecurityorigin.cpp:

(qt_drt_whiteListAccessFromOrigin):
(qt_drt_resetOriginAccessWhiteLists):
(QWebSecurityOrigin::localSchemes):

  • Api/qwebsecurityorigin.h:

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::whiteListAccessFromOrigin):

11:54 Changeset [50165] by adele@apple.com

WebCore: REGRESSION (Safari 4.0.3-ToT): After pressing Shift-PageDown, pressing Shift-Up
extends the top of the selection upwards (but should shrink the selection instead)
<rdar://problem/7269075>
https://bugs.webkit.org/show_bug.cgi?id=29981

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-27
Reviewed by Adele Peterson.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::modify): Added setting m_lastChangeWasHorizontalExtension.

LayoutTests: Test for <rdar://problem/7269075> REGRESSION (Safari 4.0.3-ToT): After pressing Shift-PageDown, pressing Shift-Up
extends the top of the selection upwards (but should shrink the selection instead)
https://bugs.webkit.org/show_bug.cgi?id=29981

  • editing/selection/shrink-selection-after-shift-pagedown-expected.txt: Added.
  • editing/selection/shrink-selection-after-shift-pagedown.html: Added.
11:45 Changeset [50164] by kenneth@webkit.org

Make sure that initiating a rotation while rotating won't make
it end up at rotation positions that are not a multiply of
180 degrees.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-27
Reviewed by Tor Arne Vestbø.

  • QGVLauncher/main.cpp:

(MainView::animatedFlip):

11:37 Changeset [50163] by bweinstein@apple.com

Rubber-stamped by Tim Hatcher.

Removed an extra console.log from ElementsTreeOutline.

  • inspector/front-end/ElementsTreeOutline.js:
11:26 Changeset [50162] by timothy@apple.com

WebCore: Rewrote JavaScriptSourceSyntaxHighlighter to be more accurate
https://bugs.webkit.org/show_bug.cgi?id=27147

Patch by Keishi Hattori <casey.hattori@gmail.com> on 2009-10-27
Reviewed by Timothy Hatcher.

Tests: LayoutTests/inspector/javascript-syntax-highlight.html

  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/SourceFrame.js:

(WebInspector.JavaScriptSourceSyntaxHighlighter.process): Added. Processes 100 tokens at a time.
(WebInspector.JavaScriptSourceSyntaxHighlighter.lex): Added. Scans for a token.
(WebInspector.JavaScriptSourceSyntaxHighlighter.appendNonToken): Added. Appends the non-token characters that lex ignored.
(WebInspector.JavaScriptSourceSyntaxHighlighter.syntaxHighlightNode): Added. To syntax highlight node in ElementsTreeOutline.

LayoutTests: Tests for JavaScript syntax highlighter.
https://bugs.webkit.org/show_bug.cgi?id=27147

Patch by Keishi Hattori <casey.hattori@gmail.com> on 2009-10-27
Reviewed by Timothy Hatcher.

  • inspector/javascript-syntax-highlight-expected.txt: Added.
  • inspector/javascript-syntax-highlight.html: Added.
11:21 Changeset [50161] by xan@webkit.org

2009-10-27 Xan Lopez <xlopez@igalia.com>

Skip a few more tests that are failing on and off.

  • platform/gtk/Skipped:
11:03 Changeset [50160] by eric@webkit.org

2009-10-27 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

[V8] Missing null check after string conversion in error reporting
https://bugs.webkit.org/show_bug.cgi?id=30774

Test case for toString conversion failure on an error object in
stack overflow situations. Test passes if it doesn't crash.

  • fast/dom/error-to-string-stack-overflow-expected.txt: Added.
  • fast/dom/error-to-string-stack-overflow.html: Added.

2009-10-27 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

[V8] Missing null check after string conversion in error reporting
https://bugs.webkit.org/show_bug.cgi?id=30774

Add null check after string conversion in error reporting code.
ToString conversion can fail for instance when an exception is
thrown during conversion.

Test: fast/dom/error-to-string-stack-overflow.html

  • bindings/v8/V8Utilities.cpp: (WebCore::reportException):
10:54 Changeset [50159] by steveblock@google.com

Use a pair of maps to store Geolocation watchers.
https://bugs.webkit.org/show_bug.cgi?id=29178

Reviewed by Darin Adler.

The pair of maps allows us to look up a watcher either by its ID or by its GeoNotifier object.
The ability to look up by a watcher by its GeoNotifier object will be required when implementing
Geolocation::fatalErrorOccurred. See https://bugs.webkit.org/show_bug.cgi?id=27944

  • page/Geolocation.cpp: Modified.

(WebCore::Geolocation::Watchers::set): Added. Adds a watcher with the given ID.
(WebCore::Geolocation::Watchers::remove): Added. Removes a watcher by ID.
(WebCore::Geolocation::Watchers::remove): Added. Removes a watcher by GeoNotifier object.
(WebCore::Geolocation::Watchers::clear): Added. Removes all watchers.
(WebCore::Geolocation::Watchers::isEmpty): Added. Determines if there are no watchers.
(WebCore::Geolocation::Watchers::getNotifiersVector): Added. Gets a vector of the GeoNotifier objects.
(WebCore::Geolocation::watchPosition): Modified. Rename watcher identifier static variable.
(WebCore::Geolocation::stopTimersForWatchers): Modified. Use Watchers::getNotifiersVector.
(WebCore::Geolocation::handleError): Modified. Use Watchers::getNotifiersVector.
(WebCore::Geolocation::makeSuccessCallbacks): Modified. Use Watchers::getNotifiersVector.

  • page/Geolocation.h: Modified. Adds Geolocation::Watchers class.
10:45 Changeset [50158] by jorlow@chromium.org

2009-10-27 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] DOM Storage runtime flag should default to on
https://bugs.webkit.org/show_bug.cgi?id=30828

The DOM Storage runtime flag was supposed to default to on. I accidentally
changed the logic to default to false when I moved the flag.

  • bindings/v8/RuntimeEnabledFeatures.cpp:
10:38 Changeset [50157] by eric@webkit.org

2009-10-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION: svn-apply exits(1) when applying a patch with a file add
https://bugs.webkit.org/show_bug.cgi?id=30826

  • Scripts/svn-apply:
    • Add () around all system() calls.
    • Use the correct system() == 0 or die instead of system() or die
    • Add descriptive messages to all die statements.
10:35 Changeset [50156] by steveblock@google.com

Adds steveblock@google.com to list of committers.

Reviewed by NOBODY.

10:00 Changeset [50155] by eric@webkit.org

2009-10-27 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Dimitri Glazkov.

Fix crash found in chromium test_shell.
https://bugs.webkit.org/show_bug.cgi?id=30808

When WebSocket is deleted without close, webkit would crash
when it handles didClose.

Check scriptExecutionContext before post task for event.
Use WebSocketChannel::disconnect() instead of close() in WebSocket
destructor, so that WebSocketChannel should not call deleted WebSocket
back in didClose().
To make sure WebSocketChannel alive while it is processing WebSocket
protocol over SocketStreamHandle, ref() in connect() and deref() in
didClose().

  • websockets/WebSocket.cpp: (WebCore::WebSocket::~WebSocket): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): (WebCore::WebSocket::didClose):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::connect): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData):
  • websockets/WebSocketChannel.h:
09:49 Changeset [50154] by mitz@apple.com

JavaScriptGlue: Updated license

Reviewed by Darin Adler.

  • LICENSE:

WebCore: Updated Apple license

Reviewed by Darin Adler.

  • LICENSE-APPLE:

WebKit: Updated license

Reviewed by Darin Adler.

  • LICENSE:
09:43 Changeset [50153] by beidson@apple.com

Rubberstamped by Sam Weinig.

Re-enable the check that disallows pages with unload handlers in the page cache.

<rdar://problem/7196485> and http://webkit.org/b/29021

WebCore:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):

LayoutTests:

  • platform/mac/Skipped:
  • platform/win/Skipped:
09:30 Changeset [50152] by timothy@apple.com

Remove more empty files that didn't get removed earlier.

  • inspector/DOMDispatchTimelineItem.cpp: Removed.
  • inspector/DOMDispatchTimelineItem.h: Removed.
08:34 Changeset [50151] by ossy@webkit.org

[Qt] Fix assertion crashes introduced by changes made in r50110.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-27
Reviewed by Tor Arne Vestbø.

  • dom/XMLTokenizerQt.cpp:

(WebCore::XMLTokenizer::parseEndElement): only call popCurrentNode() if there are nodes left in the stack.

08:27 Changeset [50150] by timothy@apple.com

Remove empty files that didn't get removed earlier.

  • inspector/TimelineItem.cpp: Removed.
  • inspector/TimelineItem.h: Removed.
07:44 Changeset [50149] by kenneth@webkit.org

Unreviewed Qt build fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-27
Update the tests as well to the new API change.

  • tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::clear):

07:28 Changeset [50148] by xan@webkit.org

2009-10-27 Xan Lopez <xlopez@igalia.com>

Another typo.

  • platform/gtk/Skipped:
07:22 Changeset [50147] by kenneth@webkit.org

Rubberstamped by Tor Arne Vestbø.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-27
[Qt] QWebElement::removeChildren() should be
QWebElement::removeAllChildren()
https://bugs.webkit.org/show_bug.cgi?id=30630

  • Api/qwebelement.cpp:

(QWebElement::removeAllChildren):

  • Api/qwebelement.h:
07:18 Changeset [50146] by xan@webkit.org

2009-10-27 Xan Lopez <xlopez@igalia.com>

Fix typo in test names.

  • platform/gtk/Skipped:
07:02 Changeset [50145] by xan@webkit.org

2009-10-27 Xan Lopez <xlopez@igalia.com>

Skip a few tests with links to their tracking bugs.

  • platform/gtk/Skipped:
06:57 Changeset [50144] by tonikitoo@webkit.org

This reverts commit r50141 that wrongly messed up the WebCore/ChangeLog

06:51 Changeset [50143] by ossy@webkit.org

Rubber-stamped by Tor Arne Vestbø.

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2009-10-27
Fix typo in RegexInterpreter.cpp and RegexJIT.cpp alterantive to
alternative.

  • yarr/RegexInterpreter.cpp:

(JSC::Yarr::ByteCompiler::alternativeBodyDisjunction):
(JSC::Yarr::ByteCompiler::alternativeDisjunction):
(JSC::Yarr::ByteCompiler::emitDisjunction):

  • yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::generateDisjunction):

06:38 Changeset [50142] by tonikitoo@webkit.org

Make QWebPagePrivate's (QWidget) view to be a QWeakPointer.
https://bugs.webkit.org/show_bug.cgi?id=30779

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-27
Reviewed by Antti Koivisto and Holger Freyther.

The fact that it was been set from external objects of qwebpage
and not being deleted internally can lead to dangling references.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::~QGraphicsWebView):

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::createContextMenu):
(QWebPagePrivate::handleSoftwareInputPanel):
(QWebPagePrivate::keyPressEvent):
(QWebPage::setView):
(QWebPage::view):
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
(QWebPage::shouldInterruptJavaScript):
(QWebPage::createWindow):
(QWebPage::extension):
(QWebPage::chooseFile):
(QWebPage::userAgentForUrl):

  • Api/qwebpage_p.h:
  • Api/qwebview.cpp:

(QWebView::~QWebView):

06:37 Changeset [50141] by tonikitoo@webkit.org

2009-10-20 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: populate child nodes before sorting them.

https://bugs.webkit.org/show_bug.cgi?id=29673

  • inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode): Swapped with BottomUpProfileDataGridTree to be consistent with TopDownProfileDataGridNode. (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild): (WebInspector.BottomUpProfileDataGridNode.prototype._exclude): (WebInspector.BottomUpProfileDataGridNode.prototype._merge): (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate): (WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
  • inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.sort): Added missing parentheses. (WebInspector.ProfileDataGridNode.prototype.get _parent): (WebInspector.ProfileDataGridNode.prototype._populate):
  • inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):
05:20 Changeset [50140] by xan@webkit.org

2009-10-27 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25534
[GTK] Objects of ROLE_TABLE should implement the accessible table interface

First part of the implementation of AtkTable.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getCell): (getCellIndex): (webkit_accessible_table_ref_at): (webkit_accessible_table_get_index_at): (webkit_accessible_table_get_n_columns): (webkit_accessible_table_get_n_rows): (webkit_accessible_table_get_column_extent_at): (webkit_accessible_table_get_row_extent_at): (webkit_accessible_table_get_row_header): (atk_table_interface_init): (AtkInterfacesInitFunctions): (GetAtkInterfaceTypeFromWAIType):
04:33 Changeset [50139] by vestbo@webkit.org

[Qt] Don't lose remainder when computing wheel event deltas

Reviewed by Lars Knoll.

  • platform/qt/WheelEventQt.cpp:
03:17 Changeset [50138] by eric@webkit.org

2009-10-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Antti Koivisto.

Fix QtWebKit build for WIN_OS if Netscape plug-in support
is turned off and refactor some related code
https://bugs.webkit.org/show_bug.cgi?id=30786

No new tests as there is no new functionality introduced.

  • platform/FileSystem.h: Refactor to make sure that each different type definition is only repeated once.
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::compareFileVersion): Move it out from the ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH guard and combine it with the function body from PluginPackageWin.
  • plugins/win/PluginPackageWin.cpp: Remove compareFileVersion as it is now in PluginPackage.cpp.
03:09 Changeset [50137] by eric@webkit.org

2009-10-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

svn-apply can exit(0) even on patch failure
https://bugs.webkit.org/show_bug.cgi?id=29622

  • Scripts/svn-apply:
    • Add a bunch of "or die" statements, hopefully catching all possible cases where failure could still exit(0).
03:01 Changeset [50136] by eric@webkit.org

2009-10-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

svn-* scripts should share code through VCSUtils.pm
https://bugs.webkit.org/show_bug.cgi?id=30791

Just moving code into a shared location.

  • Scripts/VCSUtils.pm:
  • Scripts/prepare-ChangeLog:
  • Scripts/resolve-ChangeLogs:
  • Scripts/svn-apply:
  • Scripts/svn-create-patch:
  • Scripts/svn-unapply:
  • Scripts/update-webkit:
02:54 Changeset [50135] by eric@webkit.org

2009-10-27 Vadim Zeitlin <vadim@wxwidgets.org>

Suppress a huge number of MSVC warnings when building wxWebKit.

  • wx/build/settings.py:
02:20 Changeset [50134] by xan@webkit.org

2009-10-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=27011
[Gtk] Implement support for get_index_in_parent

Implement atk_object_get_index_in_parent.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_index_in_parent):
02:07 Changeset [50133] by eric@webkit.org

2009-10-27 Eric Seidel <eric@webkit.org>

No review, rolling out r50131.
http://trac.webkit.org/changeset/50131

  • bridge/objc/objc_instance.h:
  • bridge/objc/objc_instance.mm: (ObjcInstance::ObjcInstance): (ObjcInstance::virtualEnd):
00:12 Changeset [50132] by dbates@webkit.org

2009-10-26 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30491

Fixes an issue where pressing return/enter on the keyboard
in <isindex> does not submit it if is not within a <form>.

According to the HTML 2.0 thru HTML 4.01 spec
(http://www.w3.org/MarkUp/html-spec/html-spec_7.html#SEC7.5), the
<isindex> element does not need to be within a <form> element in
order to submit it. It can submitted on its own. Also, if present,
the href property of the <base> element will dictate where to submit
the value of the <isindex> element (this is analogous to the action
property of the <form> element).

Tests: http/tests/misc/isindex-with-no-form-base-href.html

http/tests/misc/isindex-with-no-form.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Calls createTemporaryFormForIsIndex() to create a <form> if none is present and we are an <isindex> element. (WebCore::HTMLInputElement::createTemporaryFormForIsIndex): Added.
  • html/HTMLInputElement.h:

2009-10-26 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30491

Test that the <isindex> element can be submitted without being enclosed
within a <form> element. Also tests that the href property of the <base>
element can be used to direct where the submission is sent.

  • http/tests/misc/isindex-with-no-form-base-href-expected.txt: Added.
  • http/tests/misc/isindex-with-no-form-base-href.html: Added.
  • http/tests/misc/isindex-with-no-form-expected.txt: Added.
  • http/tests/misc/isindex-with-no-form.html: Added.
  • http/tests/misc/resources/isindex-with-no-form-base-href-submit.html: Added.
  • http/tests/misc/resources/isindex-with-no-form-base-href.html: Added.
00:10 Changeset [50131] by oliver@apple.com

Crash occurs after launching Newsfire 1.6 for the first time
https://bugs.webkit.org/show_bug.cgi?id=30807

Reviewed by Maciej Stachowiak.

Use a RetainPtr in ObjcBinding to ensure that we adequately
protect the autorelease pool from GC in GC'd applications.

10/26/09:

21:48 Changeset [50130] by eric@webkit.org

2009-10-26 Eric Seidel <eric@webkit.org>

No review, just adding Mike Belshe to the committers list.

  • Scripts/modules/committers.py:
21:48 Changeset [50129] by mrowe@apple.com

Versioning.

21:47 Changeset [50128] by mrowe@apple.com

New tag.

20:57 Changeset [50127] by laszlo.1.gombos@nokia.com

2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed.

[Qt] Build fix for QtWebKit after r50125.

  • WebCore.pro: Rename TimelineItem to TimelineRecord.
20:38 Changeset [50126] by eric@webkit.org

2009-10-26 Matt Mueller <mattm@chromium.org>

Reviewed by Darin Adler.

Refactor synchronizable property handling to store one shouldSynchronize flag per set of properties rather than one per property.

Fixes reading uninitialized memory in SynchronizableProperty hash function as well as simplifying the code.

https://bugs.webkit.org/show_bug.cgi?id=30658

Covered by running various svg tests under valgrind, ex:
LayoutTests/svg/custom/js-late-mask-and-object-creation.svg

  • svg/SynchronizablePropertyController.cpp: (WebCore::SynchronizableProperties::addProperty): (WebCore::SynchronizableProperties::synchronize): (WebCore::SynchronizableProperties::startAnimation): (WebCore::SynchronizableProperties::stopAnimation): (WebCore::SynchronizablePropertyController::registerProperty): (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization): (WebCore::SynchronizablePropertyController::synchronizeProperty): (WebCore::SynchronizablePropertyController::synchronizeAllProperties): (WebCore::SynchronizablePropertyController::startAnimation): (WebCore::SynchronizablePropertyController::stopAnimation):
  • svg/SynchronizablePropertyController.h: (WebCore::SynchronizableProperties::SynchronizableProperties): (WebCore::SynchronizableProperties::setNeedsSynchronization):
20:24 Changeset [50125] by eric@webkit.org

2009-10-26 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Renames TimelineItem to TimelineRecord and updates all call sites.
https://bugs.webkit.org/show_bug.cgi?id=30785

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addRecordToTimeline):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willFireTimer): (WebCore::InspectorTimelineAgent::didFireTimer): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
  • inspector/InspectorTimelineAgent.h: (WebCore::): (WebCore::InspectorTimelineAgent::RecordEntry::RecordEntry):
  • inspector/TimelineItemFactory.cpp: Removed.
  • inspector/TimelineItemFactory.h: Removed.
  • inspector/TimelineRecordFactory.cpp: Added. (WebCore::TimelineRecordFactory::createGenericRecord): (WebCore::TimelineRecordFactory::createDOMDispatchRecord): (WebCore::TimelineRecordFactory::createGenericTimerRecord): (WebCore::TimelineRecordFactory::createTimerInstallRecord):
  • inspector/TimelineRecordFactory.h: Added. (WebCore::TimelineRecordFactory::TimelineRecordFactory):
  • inspector/front-end/TimelineAgent.js: (WebInspector.addRecordToTimeline):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype.getRecordTypeName): (WebInspector.TimelineRecordTreeElement.prototype.onattach):
19:56 Changeset [50124] by zecke@webkit.org

Unreviewed spelling fix in the PluginViewQt.cpp

This error was pointed out in the bug report and it was agreed to
do the spelling fix when landing the patch. Fix it now.

19:50 Changeset [50123] by eric@webkit.org

2009-10-26 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Antti Koivisto.

[Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled

When printing, QPrinter's preview mode uses a QPicture to capture the output. The
QPicture holds a reference to the X Pixmap. As a result, the print preview would
update itself when the X Pixmap changes. To prevent the print preview from updating
whenever m_drawable is updated (i.e when the view updates), we create a copy.

We require that a QPixmap::copy() result in a QPixmap backed by a XPixmap
regardless of the graphicssystem. This is taken care of by
commit d310f7c710ecb331a9689861f0551eabd38e946e in Qt (4.6)

The beauty of this patch is that the newly created X Pixmap is managed by Qt and
it will free the Pixmap whenever the user closes the print preview dialog and
handles the case of displaying multiple preview dialogs nicely.

All credit to Samuel Rødal for suggesting usage of QPixmap::copy().

https://bugs.webkit.org/show_bug.cgi?id=30714

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint):
19:42 Changeset [50122] by eric@webkit.org

2009-10-26 Benjamin Otte <otte@gnome.org>

Reviewed by Gustavo Noronha.

Don't store properties in the MediaPlayerPrivate class

Access them via the MediaPlayer class instead.
https://bugs.webkit.org/show_bug.cgi?id=30462

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
19:27 Changeset [50121] by bweinstein@apple.com

Fixes <http://webkit.org/b/30801>.
Web Inspector: Control + ]/[ on Windows doesn't change Panels.

Reviewed by Timothy Hatcher.

In my testing, Windows uses "U+00DB" and "U+00DD" to represent
[ and ], so we should honor those as well.

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

19:10 Changeset [50120] by laszlo.1.gombos@nokia.com

2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

Make .rc files compile on Windows without depending on MFC headers
https://bugs.webkit.org/show_bug.cgi?id=30750

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc: Use winresrc.h because it exists even when MFC is not installed, and is all that's needed here.
  • WebCore.vcproj/QTMovieWin.rc: Ditto.
  • WebKit.vcproj/WebKit.rc: Ditto.
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use windows.h instead of afxres.h because it exists even when MFC is not installed, and is all that's needed here.
  • FindSafari/FindSafari.rc: Ditto
18:56 Changeset [50119] by bweinstein@apple.com

Unreviewed - Updating getComputedStyle results for Windows.

Updating getComputedStyle results for Windows.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
18:09 Changeset [50118] by bfulgham@webkit.org

Build corrections for ENABLE_FILTERS in Windows.
https://bugs.webkit.org/show_bug.cgi?id=30797

Reviewed by Darin Adler.

Build correction for ENABLE_FILTERS feature. No new tests needed.

  • platform/graphics/filters/FEColorMatrix.cpp: Use MathExtras.h and its piDouble constant.
  • platform/graphics/filters/FEGaussianBlur.cpp: Use MathExtras.h and its piDouble constant. Remove unnecessary call to floor used in the division of an unsigned, converting to int.
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: Correct include style for MathExtras.h.
18:04 WikiStart edited by timothy@apple.com
Remove some other old pages. (diff)
18:01 WikiStart edited by timothy@apple.com
Remove some old pages for Developer Tools. (diff)
17:53 Changeset [50117] by mitz@apple.com

Updated BSD License

Reviewed by Adele Peterson.

  • coding/bsd-license.html: Updated to the latest version.
17:19 Changeset [50116] by beidson@apple.com

<rdar://problem/7289467> and http://webkit.org/b/30798 - REGRESSION (r48687): www.myuhc.com doesn't load.

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/grandparent-completion-starts-redirect.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::completed): Notify all descendants that the load completed, not just direct children.

LayoutTests:

  • fast/loader/grandparent-completion-starts-redirect-expected.txt: Added.
  • fast/loader/grandparent-completion-starts-redirect.html: Added.
  • fast/loader/resources/meta-redirect-to-notify-done.html: Added.
  • fast/loader/resources/parent-of-redirect.html: Added.
16:56 Changeset [50115] by mitz@apple.com

WebCore: Re-add CSSPropertyWebkitBackgroundSize in one more place

Reviewed by Beth Dakin.

Fixes transitions/multiple-background-size-transitions.html, transitions/background-transitions.html

  • page/animation/AnimationBase.cpp:

(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):

LayoutTests: Use -webkit-background-size as the transition property in this test now
that it is distinct from background-size.

Reviewed by Sam Weinig.

  • transitions/multiple-background-size-transitions.html:
16:56 Changeset [50114] by mrowe@apple.com

Clean up the regex madness in auto-version.sh to make it obvious what the script is doing.

Reviewed by Adam Roben.

Also teaches auto-version.sh to handle RC_PROJECTSOURCEVERSION that has more than three digits
in the major component of the version number.

  • win/tools/scripts/auto-version.sh:
16:44 Changeset [50113] by jorlow@chromium.org

2009-10-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Tidy up the DOM Storage runtime flag stuff
https://bugs.webkit.org/show_bug.cgi?id=30794

Clean up the DOM Storage runtime flag stuff to match the new way of doing
things. No behavioral changes.

  • bindings/v8/RuntimeEnabledFeatures.cpp:
  • bindings/v8/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setDatabaseEnabled): (WebCore::RuntimeEnabledFeatures::databaseEnabled): (WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled): (WebCore::RuntimeEnabledFeatures::localStorageEnabled): (WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled): (WebCore::RuntimeEnabledFeatures::sessionStorageEnabled):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
  • storage/Storage.cpp:
  • storage/Storage.h:
16:27 Changeset [50112] by mitz@apple.com

Rubber-stamped by Beth Dakin.

Update expedted results after r50108.

  • svg/css/getComputedStyle-basic-expected.txt:
16:20 Changeset [50111] by beidson@apple.com

<rdar://problem/7308952> and http://webkit.org/b/30424 - REGRESSION (r48687): Pages on ucas.com appear blank.

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/history-forward-in-head.html

  • loader/RedirectScheduler.cpp:

(WebCore::RedirectScheduler::scheduleHistoryNavigation): Restore the moved canGoBackOrForward() check.

This restores the side effect of an invalid history navigation canceling previous scheduled redirects
and also fixes the bug of scheduling an invalid history navigation canceling parsing of the current document.

(WebCore::RedirectScheduler::timerFired): Removed the canGoBackOrForward() check as it is now made before

the redirect is scheduled.

LayoutTests:

  • fast/loader/history-forward-in-head-expected.txt: Added.
  • fast/loader/history-forward-in-head.html: Added.
16:11 Changeset [50110] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30049
<rdar://problem/7286002> Manipulating DOM from a script while parsing XHTML can cause a crash

Tests: fast/parser/remove-current-node-parent-x-2.xhtml

fast/parser/remove-current-node-parent-x.xhtml

  • dom/XMLTokenizer.h: Store the whole stack of parent nodes - element.parentNode() is unreliable after DOM manipulation.
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::pushCurrentNode): Push the new node onto stack. (WebCore::XMLTokenizer::popCurrentNode): This is now called instead of setCurrentNode when exiting a node. (WebCore::XMLTokenizer::clearCurrentNodeStack): We're aborting; or just done parsing. This replaces setCurrentNode(0). (WebCore::XMLTokenizer::enterText): Call pushCurrentNode(). (WebCore::XMLTokenizer::exitText): Call popCurrentNode(), removing a long-standing FIXME (not sure if it was ever practical though - how can a parent become null while adding text?)
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::~XMLTokenizer): Call clearCurrentNodeStack(). (WebCore::XMLTokenizer::startElementNs): Call pushCurrentNode(). (WebCore::XMLTokenizer::endElementNs): Call popCurrentNode() to safely get to a parent. Also added a check fo script element still being in document - Firefox parses those that aren't, but doesn't execute them.
  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::~XMLTokenizer): (WebCore::XMLTokenizer::parseStartElement): (WebCore::XMLTokenizer::parseEndElement): Match libxml2 version changes.
15:49 Changeset [50109] by eric@webkit.org

2009-10-26 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

The thunkReturnAddress is on JITStackFrame on ARM JIT as well
https://bugs.webkit.org/show_bug.cgi?id=30782

Move the thunkReturnAddress from top of the stack into the JITStackFrame
structure. This is a requirement for JSValue32_64 support on ARM.

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::ret): Return with link register (JSC::MacroAssemblerARM::prepareCall): Store the return address in link register
  • jit/JIT.h: Remove unused ctiReturnRegister
  • jit/JITInlineMethods.h: Same as ARMv7 (JSC::JIT::restoreArgumentReference): Ditto. (JSC::JIT::restoreArgumentReferenceForTrampoline): Ditto.
  • jit/JITOpcodes.cpp: Remove ctiReturnRegister related instruction
  • jit/JITStubs.cpp: Store thunkReturnAddress on JITStackFrame. Use small trampoline functions which handle return addresses for each CTI_STUB_FUNCTION.
  • jit/JITStubs.h: Store thunkReturnAddress on JITStackFrame (JSC::JITStackFrame::returnAddressSlot): Return with the address of thunkReturnAddress
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): Remove the unnecessary instruction
15:41 Changeset [50108] by mitz@apple.com

background-size: X treated as background-size: X X, not background-size: X auto
https://bugs.webkit.org/show_bug.cgi?id=28440

Reviewed by Beth Dakin.

WebCore:

Updated fast/backgrounds/size/resources/parsing-background-size-values.js
and fast/backgrounds/size/resources/parsing-inherit.js

Reinstated -webkit-background-size and kept its behavior of filling in
the second value with the first one; and changed background-size to have
the behavior of filling in the second value with 'auto'.

  • css/CSSComputedStyleDeclaration.cpp:

(computedProperties): Re-added CSSPropertyWebkitBackgroundSize.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Ditto.
(WebCore::CSSParser::parseFillSize): Adapted for the new parsing rule.
(WebCore::CSSParser::parseFillProperty): Re-added
CSSPropertyWebkitBackgroundSize.
(WebCore::cssPropertyID): Removed mapping of -webkit-background-size to
background-size.

  • css/CSSParser.h:
  • css/CSSPropertyNames.in: Re-added -webkit-background-size.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Re-added
CSSPropertyWebkitBackgroundSize.

LayoutTests:

  • fast/backgrounds/size/parsing-background-size-values-expected.txt:
  • fast/backgrounds/size/parsing-inherit-expected.txt:
  • fast/backgrounds/size/resources/parsing-background-size-values.js:

(test):

  • fast/backgrounds/size/resources/parsing-inherit.js:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
15:41 Changeset [50107] by eric@webkit.org

2009-10-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool post-diff should know how to mark commit-queue=?
https://bugs.webkit.org/show_bug.cgi?id=29202

  • Scripts/bugzilla-tool:
    • Add --commit-queue option to post-diff, post-commits and create-bug.
  • Scripts/modules/bugzilla.py:
    • Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
    • Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
15:37 Changeset [50106] by weinig@apple.com

Move some WebView event handling code into its own file, WebViewEventHandling.mm

Reviewed by Anders Carlsson.

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _close]):
(-[WebView _selectedOrMainFrame]):

  • WebView/WebViewEventHandling.mm: Added.

(-[WebView _closingEventHandling]):
(-[WebView _setMouseDownEvent:]):
(-[WebView mouseDown:]):
(-[WebView mouseUp:]):
(+[WebView _updateMouseoverWithEvent:]):
(-[WebView _updateMouseoverWithFakeEvent]):
(_updateMouseoverWithEvent:fakeEvent::if):
(-[WebView _stopAutoscrollTimer]):
(-[WebView _setToolTip:]):

  • WebView/WebViewInternal.h:
15:34 Changeset [50105] by eric@webkit.org

2009-10-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool commit-queue does not notice modifications to committers.py
https://bugs.webkit.org/show_bug.cgi?id=30084

  • Scripts/bugzilla-tool:
    • Make commit-queue re-exec itself instead of using while(1).
    • Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
    • Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
15:32 Changeset [50104] by eric@webkit.org

2009-10-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue will get stuck on patches if land-patches terminates unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=30634

  • Scripts/bugzilla-tool:
    • Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
    • Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
15:22 Changeset [50103] by eric@webkit.org

2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Use "%lli" to format "long long" on WIN_OS to fix HTML5 WebDB crash
https://bugs.webkit.org/show_bug.cgi?id=30777

No new tests as the crash can be reproduced by existing storage
LayoutTests (by hitting an assert in debug mode Webkit on WIN_OS).

  • platform/text/String.cpp: (WebCore::String::number): Qt's QString::vsprintf does not understand the "%I64u" format string. Always use the "%lli" format string for Qt port.
15:10 Changeset [50102] by eric@webkit.org

2009-10-26 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.

https://bugs.webkit.org/show_bug.cgi?id=30763

  • pywebsocket/mod_pywebsocket/init.py:
  • pywebsocket/mod_pywebsocket/dispatch.py:
  • pywebsocket/mod_pywebsocket/headerparserhandler.py:
  • pywebsocket/mod_pywebsocket/standalone.py:
  • pywebsocket/setup.py:
  • pywebsocket/test/test_dispatch.py:
15:04 Changeset [50101] by tony@chromium.org

2009-10-26 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Roll back r50073 because r50041-50043 were reverted. r50073 was
a chromium side fix for r50041.
https://bugs.webkit.org/show_bug.cgi?id=30789

  • bindings/v8/V8Collection.h:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
15:02 Changeset [50100] by ggaren@apple.com

WebCore: Fixed https://bugs.webkit.org/show_bug.cgi?id=30765
REGRESSION (r48701): Removing an event listener causes the one added just after it not to fire

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-26
Reviewed by Dimitri Glazkov.

and related bugs.

If the event listener being removed is prior to the current firing event
iterator, we need to decrement the current firing event iterator in
addition to the endpoint. (Otherwise, shrinking the event listener vector
by one implicity moves the current firing event iterator forward by one.
It's like relativity, only without the planets.)

Also took the opportunity to change some pointers to references, since
they can't be null.

  • dom/EventTarget.cpp:

(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::removeAllEventListeners): Update iterator in addition
to end, if need be.
(WebCore::EventTarget::fireEventListeners): Updated for interface changes.
Added a comment to explain a behavior that was implicit enough to be
confusing.

  • dom/EventTarget.h:

(WebCore::FiringEventIterator::FiringEventIterator):
(WebCore::EventTarget::isFiringEventListeners): Updated for interface changes.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=30765
REGRESSION (r48701): Removing an event listener causes one added after it to not fire

Patch by Dimitri Glazkov <dglazkov@chromium.org> on 2009-10-26
Reviewed by Geoffrey Garen.

  • fast/events/event-listener-list-mutation-expected.txt: Added.
  • fast/events/event-listener-list-mutation.html: Added.
  • fast/events/script-tests/event-listener-list-mutation.js: Added.

(TestMutation.listeners):
(TestMutation.mutateList):

14:52 Changeset [50099] by kenneth@webkit.org

Unreviewed documentation fix from David Boddie (Qt Doc Team)

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
Removes the check around the RenderHints property documentation
that was clearly added to synchronize the source and header files
when the #if !defined(Q_OS_SYMBIAN) guards was added to the
property.

The documentation has also been updated to ensure that Symbian
users know that there is no actual RenderHints property on their
platform.

  • Api/qwebview.cpp:
14:50 Changeset [50098] by bweinstein@apple.com

Fixes <http://webkit.org/b/30792>.
Web Inspector: When changing resource scope, resource graph can get in weird state.

Reviewed by Timothy Hatcher.

If the user was scrolled down while looking at All resources, and then just
selects Fonts, or something that doesn't have many resources, then the graph
will stay scrolled down, even when there is no content there.

When the filter is updated, scroll to the top of the graph view, so this won't
happen.

  • inspector/front-end/AbstractTimelinePanel.js:

(WebInspector.AbstractTimelinePanel.prototype._updateFilter):

14:46 Changeset [50097] by weinig@apple.com

Fix mac clean build.

  • html/HTMLOptionsCollection.idl:
14:42 Changeset [50096] by kenneth@webkit.org

Unreviewed documentation fix from David Boddie (Qt Doc Team)

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
Ensure that qdoc will always see the RenderHints property.

The property was only defined in the header file if the Q_OS_SYMBIAN
symbol was not defined, resulting in the property not showing up
in the Qt documentation just because one platform doesn't support it.

A follow up commit will improve the documentation for the property
and note that it is not supported on the Symbiam platform.

  • Api/qwebview.h:
14:35 Changeset [50095] by pfeldman@chromium.org

2009-10-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Extract AbstractTimelinePanel that will be a base
class for ResourcesPanel and TimelinePanel.

https://bugs.webkit.org/show_bug.cgi?id=30776

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/AbstractTimelinePanel.js: Added. (WebInspector.AbstractTimelinePanel): (WebInspector.AbstractTimelinePanel.prototype.get categories): (WebInspector.AbstractTimelinePanel.prototype.showCategory): (WebInspector.AbstractTimelinePanel.prototype.hideCategory): (WebInspector.AbstractTimelinePanel.prototype.createTimelinePanels): (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel.createFilterElement): (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel): (WebInspector.AbstractTimelinePanel.prototype.filter): (WebInspector.AbstractTimelinePanel.prototype._updateFilter): (WebInspector.AbstractTimelinePanel.prototype._createGraph): (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded): (WebInspector.AbstractTimelinePanel.prototype._updateSummaryGraph): (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition): (WebInspector.AbstractTimelinePanel.prototype.get needsRefresh): (WebInspector.AbstractTimelinePanel.prototype.set needsRefresh): (WebInspector.AbstractTimelinePanel.prototype.refreshIfNeeded): (WebInspector.AbstractTimelinePanel.prototype.show): (WebInspector.AbstractTimelinePanel.prototype.resize): (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.computeSummaryValues): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels): (WebInspector.TimelineCalculator.prototype.get boundarySpan): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.reset): (WebInspector.TimelineCalculator.prototype._value): (WebInspector.TimelineCalculator.prototype.formatValue):
  • inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.ResourcesPanel.prototype.get statusBarItems): (WebInspector.ResourcesPanel.prototype.get categories): (WebInspector.ResourcesPanel.prototype.showCategory): (WebInspector.ResourcesPanel.prototype.hideCategory): (WebInspector.ResourcesPanel.prototype.isCategoryVisible): (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourcesPanel.prototype.createPanelEnabler): (WebInspector.ResourcesPanel.prototype.createStatusbarButtons): (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime): (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime): (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.resize): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded): (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): (WebInspector.ResourceTimeCalculator): (WebInspector.ResourceTransferSizeCalculator): (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels):
  • inspector/front-end/SummaryBar.js: (WebInspector.SummaryBar.prototype.update):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded):
14:09 Changeset [50094] by eric@webkit.org

2009-10-26 Avi Drissman <avi@google.com>

Reviewed by Darin Adler.

Use Helvetica in the Inspector as intended.
https://bugs.webkit.org/show_bug.cgi?id=30787

  • inspector/front-end/inspector.css:
14:05 Changeset [50093] by xan@webkit.org

2009-10-26 Xan Lopez <xlopez@igalia.com>

Skip test fast/loader/opaque-base-url.html with a reference to the
bug tracking it, https://bugs.webkit.org/show_bug.cgi?id=30724

  • platform/gtk/Skipped:
14:02 Changeset [50092] by eric@webkit.org

2009-10-26 Nate Chapin <japhet@chromium.org>

Reviewed by Alexey Proskuryakov.

Update no-referrer-reset for https://bugs.webkit.org/show_bug.cgi?id=30781.

  • http/tests/navigation/no-referrer-reset-expected.txt: Expect window.opener to still be set.
  • http/tests/navigation/no-referrer-reset.html: Update text to reflect what the test actually does.

2009-10-26 Nate Chapin <japhet@chromium.org>

Reviewed by Alexey Proskuryakov.

Don't set window.opener to 0 for the current FrameLoader if a noreferrer link was clicked, only suppress opener in a new frame.
https://bugs.webkit.org/show_bug.cgi?id=30781

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): Don't suppress opener in the current frame for noreferrer navigations.
13:53 Changeset [50091] by eric@webkit.org

2009-10-26 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Levin.

REGRESSION: 2 failures in run-webkit-unittests
https://bugs.webkit.org/show_bug.cgi?id=30645

  • Scripts/modules/cpp_style_unittest.py: Fixed a few test scenarios which apparently lost some spaces from text literals.
13:48 Changeset [50090] by rniwa@webkit.org

Data loss occurs when unbolding nested bold tags.
https://bugs.webkit.org/show_bug.cgi?id=30083

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-26
Reviewed by Eric Seidel.

WebCore:

Fixes the loop in swapInNodePreservingAttributesAndChildren by saving nextSibling() of child
to a temporary valuable. It was originally calling nextSibling() after appending the child
to new parent, in which case, nextSibling is always 0.

Test: editing/style/unbolding-nested-b.html

  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

LayoutTests:

Adds a test to make sure WebKit can remove nested b, i, & s tags properly
without loosing the content of inner elements.

  • editing/style/remove-nested-inline-styles-expected.txt: Added.
  • editing/style/remove-nested-inline-styles.html: Added.
  • editing/style/script-tests/remove-nested-inline-styles.js: Added.

(removeStyleAndExpect):

13:16 Changeset [50089] by kov@webkit.org

Reviewed by Jan Alonzo.

Alternative solution to regression introduced in r48672.

13:11 Changeset [50088] by jorlow@chromium.org

2009-10-21 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Storage events should use Document::url() rather than documentURI()
https://bugs.webkit.org/show_bug.cgi?id=30535

Storage events should use Document::url() rather than Document::documentURI()
per http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html

Test: storage/domstorage/documentURI.html

  • storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):

2009-10-26 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Adler.

Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
inherit from HTMLCollection.

  • fast/dom/wrapper-classes-expected.txt:
13:04 Changeset [50087] by weinig@apple.com

Rubber-stamped by Darin Adler.

Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
inherit from HTMLCollection.

WebCore:

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):
(WebCore::toJS):

  • bindings/js/JSHTMLCollectionFunctions.h: Removed.
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::length):
(WebCore::JSHTMLOptionsCollection::indexSetter):

  • bindings/objc/DOMHTML.mm:

(kitClass):

  • bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLCollection.idl:
  • html/HTMLOptionsCollection.idl:

WebKit/win:

  • DOMCreateInstance.cpp:

LayoutTests:

  • fast/dom/wrapper-classes-expected.txt:
12:46 Changeset [50086] by kevino@webkit.org

wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.

12:34 Changeset [50085] by bfulgham@webkit.org

Build fix for ENABLE_FILTERS under Windows.
https://bugs.webkit.org/show_bug.cgi?id=30762

Reviewed by Adam Roben.

Build correction for ENABLE_FILTERS feature. No new tests needed.

  • WebCore.vcproj/WebCore.vcproj: Make the following changes: (1) Create a new 'filters' sub-folder of the platform/graphics

folder to properly show the sources held in this directory.

(2) Move the files that are currently shown in svn/graphics/filters

to platform/graphics/filters (where they actually live on disk).

(3) Add the missing SVGFilter, SVGFilterBuilder, and SVGFETile to

the project so they are built.

(4) Remove SVGFEFloodElement.cpp from the build, since it is already

being compiled by SVGAllInOne.cpp. Its presence as a separate
entity is causing a linker warning for duplicate symbols.

(5) Add ImageBuffer.cpp to the build to support color space

calculations for non-CG builds.

  • WebCore.vcproj/WebCoreCommon.vsprops: Add the platform/graphics/filters path to the search paths in the project.
12:30 Changeset [50084] by eric@webkit.org

2009-10-26 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

console.assert should prefix messages with "Assertion failed: "
https://bugs.webkit.org/show_bug.cgi?id=19135

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype.toMessageElement): Append "Assertion failed: " for AssertMessageType. (WebInspector.ConsoleMessage.prototype.toString):
  • page/Console.cpp: (WebCore::Console::assertCondition): Use AssertMessageType.
  • page/Console.h: (WebCore::MessageType): Added AssertMessageType.
12:19 Changeset [50083] by eric@webkit.org

2009-10-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Eric Seidel.

Prevent crash when optgroup element is empty.

https://bugs.webkit.org/show_bug.cgi?id=30365

  • fast/forms/select-empty-optgroup-expected.txt: Added.
  • fast/forms/select-empty-optgroup.html: Added.

2009-10-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Eric Seidel.

Prevent crash when optgroup element is empty by adding a NULL check.

https://bugs.webkit.org/show_bug.cgi?id=30365

Test: fast/forms/select-empty-optgroup.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::appendFormData):
12:11 Changeset [50082] by tony@chromium.org

2009-10-21 Steven Knight <sgk@chromium.org>

Reviewed by David Levin.

Refactor gyp for separate webcore_bindings{,_sources} targets.

https://bugs.webkit.org/show_bug.cgi?id=30447

Handle long link lines by building .idl-generated bindings in a
separate webcore_bindings library target. Avoid Visual Studio
dependency issues by building additional generated .cpp and .h files
in a separate webcore_bindings_sources target.

Chrome should still build and test successfully.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:10 Changeset [50081] by kov@webkit.org

Tagging 1.1.16.

11:57 Changeset [50080] by ossy@webkit.org

Unification of using null device in perl scripts.
https://bugs.webkit.org/show_bug.cgi?id=30572

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
Reviewed by Darin Adler.

  • Scripts/VCSUtils.pm:
  • Scripts/bisect-builds:
  • Scripts/resolve-ChangeLogs:
  • Scripts/run-iexploder-tests:
  • Scripts/run-jsc:
  • Scripts/run-mangleme-tests:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:

Using File::Spec->devnull() instead of hard coded /dev/null.

11:40 Changeset [50079] by eric@webkit.org

2009-10-26 Mike Belshe <mike@belshe.com>

Reviewed by Darin Fisher.

Make the number of connections for chromium controlled by
chromium rather than by ResourceRequestBase.
https://bugs.webkit.org/show_bug.cgi?id=30661

  • platform/network/ResourceRequestBase.cpp:
  • platform/network/chromium/ResourceRequest.cpp:
11:38 Changeset [50078] by eric@webkit.org

2009-10-26 Eric Seidel <eric@webkit.org>

Reviewed by Holger Freyther.

Reviewers are missing from committers.py
https://bugs.webkit.org/show_bug.cgi?id=30733

  • Scripts/modules/committers.py:
11:38 Web Inspector edited by casey.hattori@gmail.com
(diff)
11:33 Changeset [50077] by eric@webkit.org

2009-10-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

PrettyPatch should show images even when they have the wrong mime type
https://bugs.webkit.org/show_bug.cgi?id=29506

  • PrettyPatch/PrettyPatch.rb:
10:55 HackingGtk edited by kov@webkit.org
(diff)
10:54 Changeset [50076] by ossy@webkit.org

Unreviewed typo fix.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26

  • platform/qt/Skipped: shared-workers-close.html replaced with shared-worker-close.html
10:45 Changeset [50075] by kov@webkit.org

Unreviewed. make distcheck build fixes.

10:44 Changeset [50074] by kov@webkit.org

Unreviewed. Fix make dist regression introduced by r48672.

10:35 Changeset [50073] by eric@webkit.org

2009-10-26 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Unbreak Chromium build: that requires adding custom implementations
for HTMLOptionsCollection's item and namedItem. Keep v8 binding
close to JSC bindings as well.
https://bugs.webkit.org/show_bug.cgi?id=30780

  • bindings/v8/V8Collection.h: (WebCore::getNamedItemsFromCollection): (WebCore::getItemFromCollection):
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
10:26 Changeset [50072] by ap@apple.com

Reviewed by Adam Barth and Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30723
<rdar://problem/6189415> Input names added to multipart/form-data headers need to be escaped.

Test: http/tests/security/escape-form-data-field-names.html

  • platform/network/FormDataBuilder.cpp: (WebCore::appendQuotedString): (WebCore::FormDataBuilder::beginMultiPartHeader): (WebCore::FormDataBuilder::addFilenameToMultiPartHeader): Percent-escape line breaks and quotation marks.
10:10 Changeset [50071] by ossy@webkit.org

[Qt] Skip two flakey tests because of sporadic timeouts.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

  • platform/qt/Skipped:
10:06 Changeset [50070] by ossy@webkit.org

[Qt] Skipping two other tests because of missing features on our platform.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

  • platform/qt/Skipped:
10:00 Changeset [50069] by ossy@webkit.org

[Qt] Add platform-dependent expected file for test added in r49875.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

  • platform/qt/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Added.
09:46 Changeset [50068] by eric@webkit.org

2009-10-26 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Adds DOMTimer support to InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=30467

  • inspector/InspectorTimelineAgent.cpp: Added timer support and fixed some method names. (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): Added. (WebCore::InspectorTimelineAgent::didRemoveTimer): Added. (WebCore::InspectorTimelineAgent::willFireTimer): Added. (WebCore::InspectorTimelineAgent::didFireTimer): Added. (WebCore::InspectorTimelineAgent::addItemToTimeline): Added. (WebCore::InspectorTimelineAgent::didCompleteCurrentTimelineItem): Renamed.
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineItemFactory.cpp: Add methods for timer-related ScriptObjects. (WebCore::TimelineItemFactory::createGenericTimerTimelineItem): (WebCore::TimelineItemFactory::createTimerInstallTimelineItem):
  • inspector/TimelineItemFactory.h:
  • page/DOMTimer.cpp: Added instrumentation points. (WebCore::DOMTimer::install): (WebCore::DOMTimer::removeById): (WebCore::DOMTimer::fired):
09:31 Changeset [50067] by simon.fraser@apple.com

2009-10-26 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6988966> Hardware layers do not show up in page snapshots

  • WebView/WebHTMLViewPrivate.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _compositingLayersHostingView]): Add a private method that returns the NSView used to host compositing layers.
  • platform/graphics/mac/Canvas3DLayer.h:
  • platform/graphics/mac/Canvas3DLayer.mm: (-[Canvas3DLayer copyImageSnapshotWithColorSpace:]): Add a method that gets called when snapshotting Canvas3DLayers for page snapshots, that allows the layer to return a CGImageRef of its contents.
09:22 Changeset [50066] by ossy@webkit.org

[Qt] Update outdated expected files which expected wrong color values.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

  • platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
09:17 Changeset [50065] by eric@webkit.org

2009-10-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Pass "console" as object group when evaluating selection.

https://bugs.webkit.org/show_bug.cgi?id=30738

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
09:10 Changeset [50064] by eric@webkit.org

2009-10-26 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Fix for Console not showing repeat count when repeatedly logging an Event
https://bugs.webkit.org/show_bug.cgi?id=30324

  • inspector/console-tests-expected.txt:

2009-10-26 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Fix for Console not showing repeat count when repeatedly logging an Event
https://bugs.webkit.org/show_bug.cgi?id=30324

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::updateRepeatCountInConsole): Added.
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addConsoleMessage): Calls updateRepeatCountInConsole if it is a repeating message.
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage): Renamed WebCore::InspectorFrontend::addMessageToConsole (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): Added. Called when repeatCount is incremented.
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): Removed calls to msg.isEqual. (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): Added. (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): Added. Updates the error/warning count. (WebInspector.ConsoleView.prototype.clearMessages): (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): Use ConsoleMessage._updateRepeatCount (WebInspector.ConsoleMessage.prototype._updateRepeatCount):
  • inspector/front-end/inspector.js: (WebInspector.addConsoleMessage): Renamed WebInspector.addMessageToConsole. (WebInspector.updateConsoleMessageRepeatCount): Added.
08:27 Changeset [50063] by eric.carlson@apple.com

2009-10-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

Remove HTML5 media element 'load' event
https://bugs.webkit.org/show_bug.cgi?id=30464


Part 1, change layout tests to not use the event.

  • media/audio-constructor-autobuffer-expected.txt:
  • media/audio-constructor-autobuffer.html:
  • media/audio-constructor-expected.txt:
  • media/audio-constructor-src-expected.txt:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/audio-controls-rendering.html:
  • media/audio-data-url-expected.txt:
  • media/audio-data-url.html:
  • media/audio-mpeg-supported-expected.txt:
  • media/audio-mpeg-supported.html:
  • media/media-load-event-expected.txt:
  • media/media-load-event.html:
  • media/progress-event-expected.txt:
  • media/progress-event-total-expected.txt:
  • media/progress-event-total.html:
  • media/progress-event.html:
  • media/remove-from-document-expected.txt:
  • media/remove-from-document-no-load-expected.txt:
  • media/remove-from-document-no-load.html:
  • media/remove-from-document.html:
  • media/restore-from-page-cache-expected.txt:
  • media/restore-from-page-cache.html:
  • media/video-append-source-expected.txt:
  • media/video-append-source.html:
  • media/video-buffered-expected.txt:
  • media/video-buffered.html:
  • media/video-canvas-source-expected.txt:
  • media/video-canvas-source.html:
  • media/video-controls-expected.txt:
  • media/video-controls-transformed-expected.txt:
  • media/video-controls-transformed.html:
  • media/video-controls-zoomed-expected.txt:
  • media/video-controls-zoomed.html:
  • media/video-controls.html:
  • media/video-currentTime-expected.txt:
  • media/video-currentTime-set-expected.txt:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2-expected.txt:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-dom-src-expected.txt:
  • media/video-dom-src.html:
  • media/video-error-abort-expected.txt:
  • media/video-error-abort.html:
  • media/video-error-does-not-exist.html:
  • media/video-muted-expected.txt:
  • media/video-muted.html:
  • media/video-no-autoplay-expected.txt:
  • media/video-no-autoplay.html:
  • media/video-seek-past-end-paused-expected.txt:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing-expected.txt:
  • media/video-seek-past-end-playing.html:
  • media/video-seekable-expected.txt:
  • media/video-seekable.html:
  • media/video-seeking-expected.txt:
  • media/video-seeking.html:
  • media/video-src-change-expected.txt:
  • media/video-src-change.html:
  • media/video-volume-expected.txt:
  • media/video-volume.html:
07:49 Changeset [50062] by cfleizach@apple.com

crash with AX on when an image map contains an anchor tag
https://bugs.webkit.org/show_bug.cgi?id=30739

Reviewed by Darin Adler.

WebCore:

Tests: accessibility/crashing-a-tag-in-map.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::addChildren):

LayoutTests:

  • accessibility/crashing-a-tag-in-map-expected.txt: Added.
  • accessibility/crashing-a-tag-in-map.html: Added.
06:51 Changeset [50061] by kov@webkit.org

2009-10-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Update documentation control files for 1.1.16.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
06:49 Changeset [50060] by kov@webkit.org

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30759
[GTK] Should use WebKitNetworkResponse, and expose it

WebKitDownload now uses our WebKitNetworkResponse instead of using
ResourceResponse directly. By exposing the response, like we do
with the request, we give our users the ability to look at the
response headers, status code, and so on, through the SoupMessage
object.

06:25 Changeset [50059] by xan@webkit.org

2009-10-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.1.16 release.

  • configure.ac:

WebKit/gtk:

2009-10-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.1.16 release.

  • NEWS:
06:06 Changeset [50058] by eric@webkit.org

2009-10-26 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Reintroduce QWebElementCollection

Revert the patch that has replaced QWebElementCollection
with QList<QWebElement>. Update the tests accordingly.

Remove the constness of the return type of QWebElement operator[].

https://bugs.webkit.org/show_bug.cgi?id=30767

  • Api/qwebelement.cpp: (QWebElement::findAll): (QWebElementCollectionPrivate::QWebElementCollectionPrivate): (QWebElementCollectionPrivate::create): (QWebElementCollection::QWebElementCollection): (QWebElementCollection::operator=): (QWebElementCollection::~QWebElementCollection): (QWebElementCollection::operator+): (QWebElementCollection::append): (QWebElementCollection::count): (QWebElementCollection::at): (QWebElementCollection::toList):
  • Api/qwebelement.h: (const_iterator::begin): (const_iterator::end): (const_iterator::operator[]):
  • Api/qwebframe.cpp: (QWebFrame::findAllElements):
  • Api/qwebframe.h:
  • QtLauncher/main.cpp: (MainWindow::selectElements):
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::simpleCollection): (tst_QWebElement::iteration): (tst_QWebElement::emptyCollection): (tst_QWebElement::appendCollection): (tst_QWebElement::nullSelect): (tst_QWebElement::hasSetFocus): (tst_QWebElement::render):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
05:44 Changeset [50057] by benm@google.com

Adds feature ENABLE guards to V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30697

Patch by Steve Block <steveblock@google.com> on 2009-10-26
Reviewed by Eric Seidel.

This adds guards for the following features to the V8 bindings,
to allow builds with V8 to succeed when these features are not enabled.

  • DATABASE
  • WORKERS
  • SHARED_WORKERS
  • SVG
  • XPATH
  • XSLT
  • INSPECTOR

This is a build fix only, no new tests required.

  • bindings/v8/DOMObjectsInclude.h: Modified.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Modified.
  • bindings/v8/V8Index.cpp: Modified.
  • bindings/v8/V8Index.h: Modified.
05:32 Changeset [50056] by ossy@webkit.org

Rubber-stamped by Tor Arne Vestbø.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
http/tests/cookies/simple-cookies-max-age.html moved to flakey tests group.
http/tests/xmlhttprequest/workers/close.html added to flakey tests group.

  • platform/qt/Skipped:
04:58 Changeset [50055] by ossy@webkit.org

Unreviewed trivial fix for r49854.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26

  • platform/qt/Skipped: Missing html extension added.
04:42 Changeset [50054] by eric@webkit.org

2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25679
[Gtk] Improve accessibility of focusable lists

Fixes the issues with the Atk states exposed for ListBoxOption

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject):
04:35 Changeset [50053] by eric@webkit.org

2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=27085
[Gtk] Incorrect rendering of list

Adds a way for platforms to indicate that a particular object
should not be ignored.

  • accessibility/AccessibilityObject.h:
  • accessibility/chromium/AccessibilityObjectChromium.cpp:
  • accessibility/gtk/AccessibilityObjectAtk.cpp:
  • accessibility/mac/AccessibilityObjectMac.mm:
  • accessibility/qt/AccessibilityObjectQt.cpp:
  • accessibility/win/AccessibilityObjectWin.cpp:
  • accessibility/wx/AccessibilityObjectWx.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
  • accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::accessibilityIsIgnored):
03:46 Changeset [50052] by eric@webkit.org

2009-10-26 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Adds ability to disable ReadWriteLock on platforms (eg Android) that use pthreads but do not support pthread_rwlock.
https://bugs.webkit.org/show_bug.cgi?id=30713

  • wtf/Platform.h: Modified. Defines HAVE_PTHREAD_RWLOCK for all platforms currently using pthreads.
  • wtf/Threading.h: Modified. Use pthread_rwlock_t only when HAVE_PTHREAD_RWLOCK is defined.
  • wtf/ThreadingPthreads.cpp: Modified. Build ReadWriteLock methods only when HAVE_PTHREAD_RWLOCK is defined.
03:29 Changeset [50051] by eric@webkit.org

2009-10-26 Kinuko Yasuda <kinuko@google.com>

Reviewed by Jan Alonzo.

Bug 30619: [Linux] Menu key doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30619

Test: manual-tests/keyboard-menukey-event.html
No new layout tests: testing this will require changes in the test
controller in a platform-specific way.

  • platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for GDK_Menu to return VKEY_APPS instead of VKEY_MENU.
  • platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for GDK_Menu to return V_APPS instead of VK_MENU.
03:07 Changeset [50050] by jmalonzo@webkit.org

2009-10-26 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[Gtk] Reenable mod_rewrite in Fedora's httpd.conf
https://bugs.webkit.org/show_bug.cgi?id=30741

  • http/conf/fedora-httpd.conf:
01:52 QtBackLog edited by zecke@selfish.org
(diff)
01:45 QtBackLog edited by zecke@selfish.org
(diff)

10/25/09:

21:33 Changeset [50049] by eric@webkit.org

2009-10-25 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Reuse already fetched proxy.
https://bugs.webkit.org/show_bug.cgi?id=30747

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
21:14 QtBackLog edited by zecke@selfish.org
(diff)
21:07 QtBackLog edited by zecke@selfish.org
(diff)
21:03 QtBackLog edited by zecke@selfish.org
Mention the bug report and commits of this work (diff)
17:45 Changeset [50048] by kov@webkit.org

2009-10-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Rebaseline test after 49998.

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
15:39 Changeset [50047] by laszlo.1.gombos@nokia.com

2009-10-25 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed build fix.

Build fix for WIN_OS if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=30753

  • plugins/PluginDatabase.cpp:
13:15 Changeset [50046] by eric@webkit.org

2009-10-25 Hironori Bono <hbono@chromium.org>

Reviewed by Darin Adler.

A quick fix for Bug 29103.
Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
and the option string before calling String::startsWith().
https://bugs.webkit.org/show_bug.cgi?id=29103

  • fast/forms/listbox-typeahead-cyrillic-expected.txt: Added.
  • fast/forms/listbox-typeahead-cyrillic.html: Added.
  • fast/forms/listbox-typeahead-greek-expected.txt: Added.
  • fast/forms/listbox-typeahead-greek.html: Added.

2009-10-25 Hironori Bono <hbono@chromium.org>

Reviewed by Darin Adler.

A quick fix for Bug 29103.
Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
and the option string before calling String::startsWith().
https://bugs.webkit.org/show_bug.cgi?id=29103

Tests: fast/forms/listbox-typeahead-cyrillic.html

fast/forms/listbox-typeahead-greek.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::typeAheadFind):
10:28 Changeset [50045] by mitz@apple.com

Add contextForWorldID to the IWebFramePrivate interface.

Reviewed by John Sullivan.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.h:
08:06 Web Inspector edited by casey.hattori@gmail.com
(diff)
06:56 Web Inspector edited by casey.hattori@gmail.com
(diff)
06:54 Web Inspector edited by casey.hattori@gmail.com
(diff)
01:54 Changeset [50044] by eric@webkit.org

2009-10-25 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Expanding a node in the Console should not show the element in Elements panel
https://bugs.webkit.org/show_bug.cgi?id=30749

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.onmousedown): Check if inside disclosure triangle.
01:22 Changeset [50043] by weinig@apple.com

Another try at fixing windows.

  • DOMCreateInstance.cpp:
00:52 Changeset [50042] by weinig@apple.com

Touch WebKit.idl in an effort to try and regenerate the COM bindings.

  • Interfaces/WebKit.idl:
00:52 Changeset [50041] by weinig@apple.com

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLOptionsCollection::getCallData):
(WebCore::JSHTMLOptionsCollection::canGetItemsForName):
(WebCore::JSHTMLOptionsCollection::nameGetter):
(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::item):
(WebCore::JSHTMLOptionsCollection::namedItem):
Refactor to use generic implementation of HTMLCollection bindings functions
from JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLCollectionFunctions.h: Added.

(WebCore::getCollectionNamedItems):
(WebCore::getCollectionItems):
(WebCore::callHTMLCollectionGeneric):
Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
JSHTMLOptionsCollection can all use.

  • bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h

for toJS on document.all.

  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):
Remove special cases for HTMLOptionsCollection.

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLAllCollection.idl:
  • html/HTMLCollection.idl:
  • html/HTMLOptionsCollection.idl:

LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • fast/dom/wrapper-classes-expected.txt:
00:08 Changeset [50040] by bweinstein@apple.com

Roll out r50037 as it broke the Windows build.

Note: See TracTimeline for information about the timeline view.