Timeline
11/01/09:
- 22:38 Web Inspector Redesign.ja created by
- 22:36 newpage edited by
- (diff)
- 22:34 newpage created by
- 22:21 Changeset [50405] by
-
Rubber-stamped by Mark Rowe.
Fix for loop to use an size_t instead of unsigned and some spacing
style fixes.
* dom/Node.cpp:
(WebCore::eventHasListeners):
- 22:07 QtBackLog edited by
- (diff)
- 22:03 Changeset [50404] by
-
Re-fix the Mac build. Sorry :-(.
- 21:57 Changeset [50403] by
-
Change ssize_t to unsigned to try and fix Windows build.
- 19:53 Changeset [50402] by
-
Made the space bar toggle playing state in full-screen video when
modifier keys are down. Made it do so without highlighting the
Play/Pause button.
Reviewed by Mark Rowe.
* WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController keyDown:]):
- 19:30 Changeset [50401] by
-
2009-11-01 Eric Seidel < eric@webkit.org>
Reviewed by David Levin.
buildbots should use --exit-after-N-failures
https://bugs.webkit.org/show_bug.cgi?id=30809
Make the bots exit after 20 failures to prevent never-ending
test runs where every test spends a minute crashing.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 19:23 Changeset [50400] by
-
2009-11-01 Kelly Norton < knorton@google.com>
Reviewed by Timothy Hatcher.
Does not send DOM dispatches to the InspectorTimelineAgent if there
are no event listeners.
https://bugs.webkit.org/show_bug.cgi?id=30995
- dom/Node.cpp: (WebCore::eventHasListeners): (WebCore::Node::dispatchGenericEvent):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
- 19:14 Changeset [50399] by
-
Made the full-screen video HUD respond to the up and down arrow keys by
increasing and decreasing the volume by 1/10 of the range or, when
combined with the Option key, all the way up or down.
Reviewed by Mark Rowe.
Made the volume buttons in the full-screen video HUD match the behavior
of their equivalents in the QuickTime Player HUD by turning the volume
all the way up or down.
Made the volume slider update immediately when the keyboard or volume
buttons are used to change the volume, rather than at the nearest 1/4
second interval.
Made the elapsed and remaining time displays update immediately when the
play head is dragged across the timeline, rather than at 1/4 second
intervals.
* WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController keyDown:]): Handle the up and
down arrow keys.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
actions of the volume up and volume down buttons.
(-[WebVideoFullscreenHUDWindowController setCurrentTime:]): Call
-updateTime.
(-[WebVideoFullscreenHUDWindowController setVolumeToZero:]): Added this
action for the volume down button.
(-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]): Added
this action for the volume up button.
(-[WebVideoFullscreenHUDWindowController decrementVolume]): No longer
and action method.
(-[WebVideoFullscreenHUDWindowController incrementVolume]): Ditto.
(-[WebVideoFullscreenHUDWindowController setVolume:]): Call
-updateVolume.
- 18:50 Changeset [50398] by
-
No review (build fix).
Add missing files for Ruby implementation to WebCore.vcproj
(Fix build break after 50397)
https://bugs.webkit.org/show_bug.cgi?id=31001
No new tests. (No functional change)
* WebCore.vcproj/WebCore.vcproj:
- 17:52 Changeset [50397] by
-
Bug 28420 - Implement HTML5 <ruby> rendering
( https://bugs.webkit.org/show_bug.cgi?id=28420)
Reviewed by Dave Hyatt.
First rudimentary implementation of HTML5 ruby rendering support.
WebCore:
Following the HTML 5 spec, the box object model for a <ruby> element allows several runs of ruby
bases with their respective ruby texts looks as follows:
1 RenderRuby object, corresponding to the whole <ruby> HTML element
1+ RenderRubyRun (anonymous)
0 or 1 RenderRubyText - shuffled to the front in order to re-use existing block layouting
0-n inline object(s)
0 or 1 RenderRubyBase - contains the inline objects that make up the ruby base
1-n inline object(s)
Note: <rp> elements are defined as having 'display:none' and thus normally are not assigned a renderer.
New layout tests will be committed in a follow-up patch under fast/ruby.
Makefiles, etc.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
CSS
* css/html.css: Added <ruby> and <rt>
Existing render files:
* rendering/RenderBlock.cpp: make moveChild a member function moveChildTo
(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::RenderBlock::removeChild):
* rendering/RenderBlock.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject): instantiate ruby renderers based on element name
* rendering/RenderObject.h: add query methods for ruby renderers
(WebCore::RenderObject::isRuby):
(WebCore::RenderObject::isRubyBase):
(WebCore::RenderObject::isRubyRun):
(WebCore::RenderObject::isRubyText):
New ruby renderers:
* rendering/RenderRuby.cpp: Added.
(WebCore::lastRubyRun):
(WebCore::findRubyRunParent):
(WebCore::RenderRubyAsInline::RenderRubyAsInline):
(WebCore::RenderRubyAsInline::~RenderRubyAsInline):
(WebCore::RenderRubyAsInline::isChildAllowed):
(WebCore::RenderRubyAsInline::addChild):
(WebCore::RenderRubyAsInline::removeChild):
(WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
(WebCore::RenderRubyAsBlock::~RenderRubyAsBlock):
(WebCore::RenderRubyAsBlock::isChildAllowed):
(WebCore::RenderRubyAsBlock::addChild):
(WebCore::RenderRubyAsBlock::removeChild):
* rendering/RenderRuby.h: Added.
(WebCore::RenderRubyAsInline::renderName):
(WebCore::RenderRubyAsInline::isRuby):
(WebCore::RenderRubyAsBlock::renderName):
(WebCore::RenderRubyAsBlock::isRuby):
* rendering/RenderRubyBase.cpp: Added.
(WebCore::RenderRubyBase::RenderRubyBase):
(WebCore::RenderRubyBase::~RenderRubyBase):
(WebCore::RenderRubyBase::isChildAllowed):
(WebCore::RenderRubyBase::splitToLeft):
(WebCore::RenderRubyBase::mergeWithRight):
* rendering/RenderRubyBase.h: Added.
(WebCore::RenderRubyBase::renderName):
(WebCore::RenderRubyBase::isRubyBase):
* rendering/RenderRubyRun.cpp: Added.
(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::~RenderRubyRun):
(WebCore::RenderRubyRun::hasRubyText):
(WebCore::RenderRubyRun::hasRubyBase):
(WebCore::RenderRubyRun::isEmpty):
(WebCore::RenderRubyRun::rubyText):
(WebCore::RenderRubyRun::rubyBase):
(WebCore::RenderRubyRun::rubyBaseSafe):
(WebCore::RenderRubyRun::firstLineBlock):
(WebCore::RenderRubyRun::updateFirstLetter):
(WebCore::RenderRubyRun::isChildAllowed):
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::removeChild):
(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):
* rendering/RenderRubyRun.h: Added.
(WebCore::RenderRubyRun::renderName):
(WebCore::RenderRubyRun::isRubyRun):
* rendering/RenderRubyText.cpp: Added.
(WebCore::RenderRubyText::RenderRubyText):
(WebCore::RenderRubyText::~RenderRubyText):
(WebCore::RenderRubyText::isChildAllowed):
* rendering/RenderRubyText.h: Added.
(WebCore::RenderRubyText::renderName):
(WebCore::RenderRubyText::isRubyText):
LayoutTests:
Further layout tests will be committed in a follow-up patch under fast/ruby.
* fast/ruby/parse-rp-expected.txt: result changed due to <rt> being rendered as block within <ruby>
- 17:00 Changeset [50396] by
-
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=30992
Node.isDefaultNamespace doesn't convert empty strings to null
Test: fast/dom/Node/default-namespace-empty-argument.html
- dom/Node.cpp: (WebCore::Node::isDefaultNamespace): Per DOM 3 Core, treat empty input as null.
- 13:38 Changeset [50395] by
-
2009-11-01 Yael Aharon < yael.aharon@nokia.com>
Reviewed by Darin Adler.
Don't add '/' to the URL path if the it does not include '/' after the protocol component
https://bugs.webkit.org/show_bug.cgi?id=30971
Updating the expected result to reflect the change.
- fast/loader/url-parse-1-expected.txt:
2009-11-01 Yael Aharon < yael.aharon@nokia.com>
Reviewed by Darin Adler.
Don't add '/' to the URL path if the it does not include '/' after the protocol component
https://bugs.webkit.org/show_bug.cgi?id=30971
Match IE8 behaviour, that does not add '/' if there is none after the protocol component.
- platform/KURL.cpp: (WebCore::KURL::parse):
- 13:30 Changeset [50394] by
-
Fix layering violations in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=30986
Reviewed by Darin Adler.
Remove uses of HTMLImageElement and HTMLCanvasElement
- 13:22 Changeset [50393] by
-
2009-11-01 Joanmarie Diggs < joanmarie.diggs@gmail.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=30964
[Gtk] Implemment AtkDocument
Implements what has been implemented in AT-SPI.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (GetAtkInterfaceTypeFromWAIType): (getInterfaceMaskFromObject): (atk_document_interface_init): (webkit_accessible_document_get_document_attribute_value): (webkit_accessible_document_get_document_attributes): (webkit_accessible_document_get_locale):
- 12:49 Changeset [50392] by
-
2009-11-01 Laszlo Gombos < laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958
- WebKit.pri: Turn on warnings for the GCC compiler
2009-11-01 Laszlo Gombos < laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958
No new tests as there is no functional change.
- platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::RGBA32Buffer): Reorder initialization list to fix compiler warnings.
2009-11-01 Laszlo Gombos < laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): Reorder initialization list to fix compiler warnings.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Ditto.
2009-11-01 Laszlo Gombos < laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958
- DumpRenderTree/qt/main.cpp: (crashHandler): Mark function NO_RETURN
- 12:41 Changeset [50391] by
-
2009-11-01 Keishi Hattori < casey.hattori@gmail.com>
Reviewed by Pavel Feldman.
[Regression] monitorEvent doesn't work
- inspector/front-end/InjectedScript.js: (InjectedScript._ensureCommandLineAPIInstalled):
- 12:33 Changeset [50390] by
-
2009-11-01 Keishi Hattori < casey.hattori@gmail.com>
Reviewed by Pavel Feldman.
Fix Web Inspector: Bug with Message Bubble in Syntax Highlighter
https://bugs.webkit.org/show_bug.cgi?id=30990
- inspector/front-end/SourceFrame.js:
- 12:04 Changeset [50389] by
-
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=30982
createHTMLDocument doesn't escape ampersand and less-than in title
Test: fast/dom/DOMImplementation/createHTMLDocument-title.html
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createHTMLDocument): Set document title after creating the document, avoiding parser intricacies.
- 08:18 Changeset [50388] by
-
2009-11-01 Hironori Bono < hbono@chromium.org>
Reviewed by Darin Adler.
Bug 30902: Need a layout test for Bug 28284
This change just adds a simple test that calls TextInputController.firstRectForCharacterRange()
before and after inserting a Thai character and compare their results.
https://bugs.webkit.org/show_bug.cgi?id=30902
- fast/text/international/thai-cursor-position-expected.txt: Added.
- fast/text/international/thai-cursor-position.html: Added.
- platform/gtk/Skipped: Skip this test because TextInputController is not implemented.
- platform/qt/Skipped: ditto.
- platform/win/Skipped: ditto.
- 08:11 Changeset [50387] by
-
2009-11-01 Keishi Hattori < casey.hattori@gmail.com>
Reviewed by Timothy Hatcher.
Web Inspector: Double clicking on a breakpoints should not select text
https://bugs.webkit.org/show_bug.cgi?id=30950
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._documentMouseDown):
- 08:03 Changeset [50386] by
-
2009-11-01 Yuta Kitamura < yutak@chromium.org>
Reviewed by Darin Adler.
Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent().
[Crash (debug)] Combination of list-item and :after causes assertion failure
https://bugs.webkit.org/show_bug.cgi?id=30944
- fast/css/list-item-pseudo-nocrash-expected.txt: Added.
- fast/css/list-item-pseudo-nocrash.html: Added.
2009-11-01 Yuta Kitamura < yutak@chromium.org>
Reviewed by Darin Adler.
Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent().
[Crash (debug)] Combination of list-item and :after causes assertion failure
https://bugs.webkit.org/show_bug.cgi?id=30944
Test: fast/css/list-item-pseudo-nocrash.html
- rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent):
- 07:54 Changeset [50385] by
-
2009-11-01 Philippe Normand < pnormand@igalia.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=30586
[GTK] Failing test media/video-src-empty.html
- platform/gtk/Skipped: Unskip fixed test.
2009-11-01 Philippe Normand < pnormand@igalia.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=30586
[GTK] Failing test media/video-src-empty.html
Correctly set network/ready state depending on GStreamer errors
received on the bus.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback):
- 07:25 Changeset [50384] by
-
2009-11-01 Jessie Berlin < jberlin@webkit.org>
Adding myself to the committers list.
- Scripts/modules/committers.py:
10/31/09:
- 16:22 Changeset [50383] by
-
Build fix
- 16:10 Changeset [50382] by
-
Remove obsolete null checks from CanvasRenderingContext3DMac
https://bugs.webkit.org/show_bug.cgi?id=30983
Reviewed by Darin Adler
- 15:19 Changeset [50381] by
-
WebGL allows objects to be used with the wrong context
https://bugs.webkit.org/show_bug.cgi?id=30981
Reviewed by Jon Honeycutt.
Simply add null checks and a few context guards to ensure we don't
deref null or attempt to use an object from a different context.
Tests: fast/canvas/webgl/incorrect-context-object-behaviour.html
fast/canvas/webgl/null-object-behaviour.html
- 14:54 BuildingOnWindows edited by
- (diff)
10/30/09:
- 20:48 Changeset [50380] by
-
Versioning.
- 20:48 Changeset [50379] by
-
New tag.
- 20:47 Changeset [50378] by
-
Fix the build.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA):
- 19:11 Changeset [50377] by
-
Fixed failing layout test: restore a special case I accidentally deleted.
Patch by Geoffrey Garen < ggaren@apple.com> on 2009-10-30
Reviewed by Oliver Hunt.
* runtime/DatePrototype.cpp:
(JSC::setNewValueFromDateArgs): In the case of applying a change to a date
that is NaN, reset the date to 0 *and* then apply the change; don't just
reset the date to 0.
- 17:51 Changeset [50376] by
-
Fix an issue that Adam noticed in DRT.
Reviewed by Darin Adler.
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::role):
Get the length of the role text, and create a buffer dynamically.
- 17:26 Changeset [50375] by
-
Versioning.
- 17:25 Changeset [50374] by
-
New tag.
- 17:23 Changeset [50373] by
-
Merge r50356.
- 17:23 Changeset [50372] by
-
Merge r50355.
- 17:23 Changeset [50371] by
-
Merge r50354.
- 17:23 Changeset [50370] by
-
Merge r50353.
- 16:18 Changeset [50369] by
-
Allow custom memory allocation control for WebCore's MediaQueryResult
https://bugs.webkit.org/show_bug.cgi?id=30857
Reviewed by Darin Adler.
Inherits MediaQueryResult class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:5984 and
it is no need to be copyable.
* css/CSSStyleSelector.h:
- 16:16 Changeset [50368] by
-
Allow custom memory allocation control for WebCore's MediaQueryEvaluator
https://bugs.webkit.org/show_bug.cgi?id=30854
Reviewed by Darin Adler.
Inherits MediaQueryEvaluator class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:401 and
it is no need to be copyable.
* css/MediaQueryEvaluator.h:
- 16:10 Changeset [50367] by
-
Allow custom memory allocation control for WebCore's MediaQueryEvaluator
https://bugs.webkit.org/show_bug.cgi?id=30854
Reviewed by Darin Adler.
Inherits MediaQueryEvaluator class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:401 and
it is no need to be copyable.
* css/MediaQueryEvaluator.h:
- 16:08 Changeset [50366] by
-
Allow custom memory allocation control for WebCore's CSSRuleSet
https://bugs.webkit.org/show_bug.cgi?id=30852
Reviewed by Darin Adler.
Inherits CSSRuleSet class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:455 and
it is no need to be copyable.
* css/CSSStyleSelector.cpp:
- 16:06 Changeset [50365] by
-
Allow custom memory allocation control for WebCore's CSSRuleData
https://bugs.webkit.org/show_bug.cgi?id=30851
Reviewed by Darin Adler.
Inherits CSSRuleData class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.h:320 and
it is no need to be copyable.
* css/CSSStyleSelector.h:
- 16:02 Changeset [50364] by
-
Allow custom memory allocation control for WebCore's CSSRuleDataList
https://bugs.webkit.org/show_bug.cgi?id=30850
Reviewed by Darin Adler.
Inherits CSSRuleDataList class from Noncopyable because it has been
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:2715 and
it is no need to be copyable.
* css/CSSStyleSelector.h:
- 15:59 Changeset [50363] by
-
Allow custom memory allocation control for WebCore's CSSNamespace
https://bugs.webkit.org/show_bug.cgi?id=30849
Reviewed by Darin Adler.
Inherits CSSNamespace struct from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSheet.cpp:141 and
it is no need to be copyable.
* css/CSSNamespace.h:
- 15:41 Changeset [50362] by
-
2009-10-30 Eric Seidel < eric@webkit.org>
No review, rolling out r50105.
http://trac.webkit.org/changeset/50105
This commit was causing:
https://bugs.webkit.org/show_bug.cgi?id=30869
We'll re-implement the feature a different way.
- Scripts/bugzilla-tool:
- 15:35 Changeset [50361] by
-
Windows build fix: update for object-to-pointer change.
Patch by Geoffrey Garen < ggaren@apple.com> on 2009-10-30
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
- 15:26 Changeset [50360] by
-
Refactor DatabaseTask in preparation for removing threadsafe refcounting from it.
Move the synchronizer object out of the DatabaseTask so there is no need to keep
the pointer to Databasetask around after passing it to MessageQueue.
Also pass the references to return parameters to the task so it can update them.
https://bugs.webkit.org/show_bug.cgi?id=30941
Reviewed by David Levin.
No new tests, since this is just moving the code around, no change in functionality.
* storage/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::openAndVerifyVersion): Use new DatabaseTaskSynchronizer to wait for task completion.
(WebCore::Database::markAsDeletedAndClose): Ditto.
(WebCore::Database::tableNames): Ditto.
(WebCore::Database::stop): Use the boolean flag rather then 'killed' flag built into MessageQueue.
(WebCore::Database::scheduleTransaction): Transaction queue is a Deque now, change the way to fetch the transaction.
* storage/Database.h: Change the SQLTransaction queue to be a Deque rather then a MessageQueue.
* storage/DatabaseTask.cpp:
(WebCore::DatabaseTaskSynchronizer::DatabaseTaskSynchronizer):
(WebCore::DatabaseTaskSynchronizer::waitForTaskCompletion):
(WebCore::DatabaseTaskSynchronizer::taskCompleted):
(WebCore::DatabaseTask::DatabaseTask): Ctor takes DatabaseTaskSynchronizer which can be 0.
(WebCore::DatabaseTask::performTask): Signal completion. m_synchronizer should still be around since main thread is waiting on it.
(WebCore::DatabaseOpenTask::DatabaseOpenTask): Pass synchronizer and return parameters via constructor.
(WebCore::DatabaseCloseTask::DatabaseCloseTask): Ditto.
(WebCore::DatabaseTransactionTask::DatabaseTransactionTask): Ditto.
(WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask): Ditto.
* storage/DatabaseTask.h:
(WebCore::DatabaseOpenTask::create):
(WebCore::DatabaseCloseTask::create):
(WebCore::DatabaseTransactionTask::create):
(WebCore::DatabaseTableNamesTask::create):
- 15:23 Changeset [50359] by
-
https://bugs.webkit.org/show_bug.cgi?id=30942
Use pointers instead of copies to pass GregorianDateTime objects around.
Patch by Geoffrey Garen < ggaren@apple.com> on 2009-10-29
Reviewed by Darin Adler.
SunSpider reports a shocking 4.5% speedup on date-format-xparb, and 1.3%
speedup on date-format-tofte.
* runtime/DateInstance.cpp:
(JSC::DateInstance::gregorianDateTime):
* runtime/DateInstance.h:
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Renamed getGregorianDateTime to gregorianDateTime,
since it no longer has an out parameter. Uses 0 to indicate invalid dates.
- 15:09 Changeset [50358] by
-
REGRESSION: In Mail, Undo does not restore some characters I have deleted at the end of a line
https://bugs.webkit.org/show_bug.cgi?id=30955
< rdar://problem/7067033>
Patch by Enrica Casucci < enrica@apple.com> on 2009-10-30
Reviewed by Darin Adler.
WebCore:
When the command is deleteWordBackward or deleteWordForward
we should not add to the open typing command, but
create a new one.
Test: editing/undo/undo-deleteWord.html
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Always start a new command if the granularity is
not CharacterGranularity.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Always start a new command if the granularity is
not CharacterGranularity.
LayoutTests:
* editing/undo/undo-deleteWord-expected.txt: Added.
* editing/undo/undo-deleteWord.html: Added.
- 15:03 Changeset [50357] by
-
2009-10-30 Eric Carlson < eric.carlson@apple.com>
Reviewed by Darin Adler.
Make MediaPlayer constructor private
https://bugs.webkit.org/show_bug.cgi?id=30965
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::finishParsingChildren): Use MediaPlayer::create.
- platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::create): New.
- 14:38 Changeset [50356] by
-
Test for MSAA: Accessibility of headings is not correct
https://bugs.webkit.org/show_bug.cgi?id=30937
Reviewed by Adam Roben.
WebKitTools:
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::role):
Allow the role returned to be a BSTR.
(AccessibilityUIElement::description):
Fix a copy/paste error.
LayoutTests:
* platform/win/accessibility/heading-elements-expected.txt: Added.
* platform/win/accessibility/heading-elements.html: Added.
- 14:38 Changeset [50355] by
-
Test for MSAA: Accessibility of links is wrong
https://bugs.webkit.org/show_bug.cgi?id=30928
Reviewed by Darin Adler.
WebKitTools:
* DumpRenderTree/AccessibilityUIElement.cpp:
(getAccessibilityValueCallback):
Return the accessibility value.
(AccessibilityUIElement::getJSClass):
Added "accessibilityValue" value.
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::accessibilityValue):
Stubbed.
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::accessibilityValue):
Stubbed.
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::accessibilityValue):
Get the object's value, and return it as a JS string.
LayoutTests:
* platform/win/accessibility/linked-elements-expected.txt: Added.
* platform/win/accessibility/linked-elements.html: Added.
- 14:38 Changeset [50354] by
-
MSAA: Accessibility of headings is not correct
https://bugs.webkit.org/show_bug.cgi?id=30937
Reviewed by Alice Liu.
WebCore:
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::stringRoleForMSAA):
(WebCore::AccessibilityObject::descriptionForMSAA):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::shouldReturnTagNameAsRoleForMSAA):
If the element's tag name is one of h1, h2, h3, h4, h5, h6, return
true.
(WebCore::AccessibilityRenderObject::stringRoleForMSAA):
If the element should return its tag name as the role, return the tag
name.
(WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA):
If the object is a heading, return the string "L" followed by the
heading level.
(WebCore::AccessibilityRenderObject::descriptionForMSAA):
If the object has a positional description, return it. Otherwise, get
the accessibility description, and prefix it with "Description" so that
MSAA clients know that it's not a positional description.
* accessibility/AccessibilityRenderObject.h:
WebKit/win:
* AccessibleBase.cpp:
(AccessibleBase::get_accDescription):
Call the object's descriptionForMSAA(). Moved the comment to the
WebCore file.
(AccessibleBase::get_accRole):
If the object has a string role, return that. Otherwise, return the
integer role.
* AccessibleBase.h:
Removed description(), as this was moved to WebCore.
- 14:37 Changeset [50353] by
-
MSAA: Accessibility of links is wrong
https://bugs.webkit.org/show_bug.cgi?id=30928
Reviewed by Darin Adler.
WebCore:
* accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::stringValueForMSAA):
Return the URL.
(WebCore::AccessibilityImageMapLink::nameForMSAA):
Return the alt text.
* accessibility/AccessibilityImageMapLink.h:
(WebCore::AccessibilityImageMapLink::isLinked):
Return true.
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isLinked):
(WebCore::AccessibilityObject::stringValueForMSAA):
(WebCore::AccessibilityObject::nameForMSAA):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::isLinkable):
Return true if the element is considered "linkable" with respect to
accessibility.
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
If the element is linkable, check whether it has a parent anchor
element. If so, return the anchor element's href.
(WebCore::AccessibilityRenderObject::isLinked):
Return true if the element is linkable and if it's parent anchor tag's
href is non-empty.
(WebCore::AccessibilityRenderObject::nameForMSAA):
For text nodes, return the text.
* accessibility/AccessibilityRenderObject.h:
WebKit/win:
* AccessibleBase.cpp:
(AccessibleBase::get_accState):
Check whether the element is linked, instead of whether the node is an
anchor, so the child "linkable" elements of anchor elements will also
be "linked".
(AccessibleBase::name):
Return the name for MSAA.
(AccessibleBase::value):
Return the string value for MSAA.
- 14:20 Changeset [50352] by
-
Touch WebKitPrefix to force rebuild of WebKit.
- 13:59 Changeset [50351] by
-
Notify the chrome when the focused node has changed.
https://bugs.webkit.org/show_bug.cgi?id=30832
Patch by Evan Stade < estade@chromium.org> on 2009-10-30
Reviewed by David Levin.
WebCore:
This is similar to AX code that is already in place, except that this also informs the
chrome when there stops being a focused node. This is needed for a browser to show the
anchor for links that have keyboard focus.
* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::focusedNodeChanged):
* page/Chrome.cpp:
(WebCore::Chrome::focusedNodeChanged):
* page/Chrome.h:
* page/ChromeClient.h:
WebKit/gtk:
Added stub implementation for new ChromeClient function.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::focusedNodeChanged):
* WebCoreSupport/ChromeClientGtk.h:
WebKit/haiku:
Added stub implementation for new ChromeClient function.
* WebCoreSupport/ChromeClientHaiku.cpp:
(WebCore::ChromeClientHaiku::focusedNodeChanged):
* WebCoreSupport/ChromeClientHaiku.h:
WebKit/mac:
Added stub implementation for new ChromeClient function.
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::focusedNodeChanged):
WebKit/qt:
Added stub implementation for new ChromeClient function.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::focusedNodeChanged):
* WebCoreSupport/ChromeClientQt.h:
WebKit/win:
Added stub implementation for new ChromeClient function.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::focusedNodeChanged):
* WebCoreSupport/WebChromeClient.h:
WebKit/wx:
Added stub implementation for new ChromeClient function.
* WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::focusedNodeChanged):
* WebKitSupport/ChromeClientWx.h:
- 13:20 Changeset [50350] by
-
2009-10-30 Ben Murdoch < benm@google.com>
Reviewed by David Kilzer.
openDatabase() with empty version sets db version up incorrectly
https://bugs.webkit.org/show_bug.cgi?id=28417
- storage/open-database-set-empty-version-expected.txt: Added.
- storage/open-database-set-empty-version.html: Added.
2009-10-30 Ben Murdoch < benm@google.com>
Reviewed by David Kilzer.
openDatabase() with empty version sets db version up incorrectly
https://bugs.webkit.org/show_bug.cgi?id=28417
Test: storage/open-database-set-empty-version.html
- storage/Database.cpp: (WebCore::Database::performOpenAndVerify): Raise an exception if the current database version does not match the expected version when the current version is the empty string.
- 12:52 Changeset [50349] by
-
Fix typo in command name used by wx build system.
- 12:37 Changeset [50348] by
-
2009-10-30 John Gregg < johnnyg@google.com>
Reviewed by David Levin.
Need to turn off notifications properly at runtime
https://bugs.webkit.org/show_bug.cgi?id=30409
Moving the notificationsEnabled bit from NotificationCenter
to the new V8 RuntimeEnabledFeatures object.
Just moving a bit around, so no new tests.
- bindings/v8/RuntimeEnabledFeatures.cpp:
- bindings/v8/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setNotificationsEnabled): (WebCore::RuntimeEnabledFeatures::notificationsEnabled):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
- notifications/NotificationCenter.cpp:
- notifications/NotificationCenter.h:
- 11:31 Changeset [50347] by
-
[V8] More cleanup after r49949: remove ListenerGuard.
ListenerGuard is no longer needed since EventListeners do not depend on frame or v8 context.
https://bugs.webkit.org/show_bug.cgi?id=30943
Reviewed by Dimitri Glazkov.
Covered by fast/events/add-event-without-document.html which will now pass in Chromium.
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::handleEvent):
* bindings/v8/V8AbstractEventListener.h:
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getEventListener):
* bindings/v8/V8EventListenerList.h:
(WebCore::V8EventListenerList::findOrCreateWrapper):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::V8LazyEventListener):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::V8Proxy):
(WebCore::V8Proxy::disconnectFrame):
(WebCore::V8Proxy::clearForNavigation):
* bindings/v8/V8Proxy.h:
* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener):
(WebCore::V8WorkerContextEventListener::handleEvent):
(WebCore::V8WorkerContextEventListener::reportError):
* bindings/v8/V8WorkerContextEventListener.h:
(WebCore::V8WorkerContextEventListener::create):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::dispose):
(WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
* bindings/v8/WorkerContextExecutionProxy.h:
* bindings/v8/custom/V8CustomEventListener.cpp:
(WebCore::V8EventListener::V8EventListener):
* bindings/v8/custom/V8CustomEventListener.h:
(WebCore::V8EventListener::create):
- 11:19 Changeset [50346] by
-
2009-10-30 Adam Barth < abarth@webkit.org>
Reviewed by Darin Adler.
Patch v1 is a dumb default name for patches
https://bugs.webkit.org/show_bug.cgi?id=30952
Let's use "Patch" instead.
- Scripts/bugzilla-tool:
- 10:57 Changeset [50345] by
-
2009-10-30 Shinichiro Hamaji < hamaji@chromium.org>
Reviewed by Darin Adler.
counterValueForElementById should return space-separated string for multiple counters
https://bugs.webkit.org/show_bug.cgi?id=30939
Test: fast/css/counters/counterValueForElementById.html
- rendering/RenderTreeAsText.cpp: (WebCore::writeCounterValuesFromChildren): (WebCore::counterValueForElement):
2009-10-30 Shinichiro Hamaji < hamaji@chromium.org>
Reviewed by Darin Adler.
counterValueForElementById should return space-separated string for multiple counters
https://bugs.webkit.org/show_bug.cgi?id=30939
- fast/css/counters/counterValueForElementById-expected.txt: Added.
- fast/css/counters/counterValueForElementById.html: Added.
- 10:50 Changeset [50344] by
-
2009-10-30 Jocelyn Turcotte < jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Remove the QWebInspector::windowTitleChanged signal,
QEvent::WindowTitleChange can be used to achieve the same.
https://bugs.webkit.org/show_bug.cgi?id=30927
- Api/qwebinspector.cpp:
- Api/qwebinspector.h:
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::updateWindowTitle):
- 10:43 Changeset [50343] by
-
2009-10-30 Sebastian Dröge < sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint): Add some comments to explain what is happening here.
- 10:35 Changeset [50342] by
-
2009-10-30 Alexander Pavlov < apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Fix Web Inspector crash on the errors/warnings counter click
RenderObject::createVisiblePosition(const Position& position)
understands "null Positions", so we can construct such a Position manually.
- rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
- 10:27 Changeset [50341] by
-
2009-10-30 Alexander Pavlov < apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Fix Web Inspector crash on the errors/warnings counter click
RenderObject::createVisiblePosition(const Position& position)
understands "null Positions", so we can construct such a Position manually.
- rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
- 10:26 Changeset [50340] by
-
2009-10-30 Shinichiro Hamaji < hamaji@chromium.org>
Reviewed by Mark Rowe.
fast/css/counters/t1204* are not asynchronous anymore
https://bugs.webkit.org/show_bug.cgi?id=30940
- fast/css/counters/t1204-increment-00-c-o.html:
- fast/css/counters/t1204-increment-01-c-o.html:
- 10:19 Changeset [50339] by
-
2009-10-30 Joanmarie Diggs < joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25534
[GTK] Objects of ROLE_TABLE should implement the accessible table interface
Second part of the implementation of AtkTable.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (cellAtIndex): (webkit_accessible_table_get_column_at_index): (webkit_accessible_table_get_row_at_index): (webkit_accessible_table_get_caption): (atk_table_interface_init):
- 09:40 Changeset [50338] by
-
Touch WebCorePrefix to try and force a clean build.
- 09:18 Changeset [50337] by
-
2009-10-30 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add TimelinePanel into the panels enum.
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::showPanel):
- inspector/front-end/inspector.js: (WebInspector.showTimelinePanel):
- 08:48 Changeset [50336] by
-
Unreviewed trivial buildfix.
Patch by Andras Becsi < becsi.andras@stud.u-szeged.hu> on 2009-10-30
[Qt] Buildfix for r50333.
* DumpRenderTree/qt/DumpRenderTree.pro:
- 08:00 Changeset [50335] by
-
Unreviewed layout test fixes.
Patch by Kenneth Rohde Christiansen < kenneth@webkit.org> on 2009-10-30
The existing excepted results were wrong, due to the visited links not
being reset between tests.
This was fixed in r50329, so updating the results.
* platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
- 07:13 Changeset [50334] by
-
[Qt] Add expected files for new svg tests we pass.
Compared to the Mac expected png files.
Patch by Andras Becsi < becsi.andras@stud.u-szeged.hu> on 2009-10-30
Reviewed by Holger Hans Peter Freyther.
* platform/qt/svg/css/arrow-with-shadow-expected.txt: Added.
* platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
* platform/qt/svg/css/clippath-with-shadow-expected.txt: Added.
* platform/qt/svg/css/mask-with-shadow-expected.txt: Added.
* platform/qt/svg/css/path-with-shadow-expected.txt: Added.
* platform/qt/svg/css/stars-with-shadow-expected.txt: Added.
* platform/qt/svg/filters/shadow-on-filter-expected.txt: Added.
* platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt: Added.
- 07:02 Changeset [50333] by
-
[Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
https://bugs.webkit.org/show_bug.cgi?id=30953
Patch by Antonio Gomes < tonikitoo@webkit.org> on 2009-10-30
Reviewed by Holger Freyther.
DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
makes qt DRT to share this implementation (as gtk and mac ports do).
* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/WorkQueue.cpp: Removed.
* DumpRenderTree/qt/WorkQueue.h: Removed.
- 06:51 Changeset [50332] by
-
Unreviewed potential buildbot fix.
Patch by Kenneth Rohde Christiansen < kenneth@webkit.org> on 2009-10-30
Second try: Reset page history before running each test.
Apparently the QWebHistory::clear() keeps the current page
in history which is not what we want, so we not additionally
sets the history capacity to 0 (forces removing everything)
and then sets it back to its original value.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- 06:38 Changeset [50331] by
-
changelog date
- 06:29 Changeset [50330] by
-
If the owner widget of the page has a palette set, we
should use that one. This was only working when the
owner was a QWebView. This patch fixes that.
Patch by Kenneth Rohde Christiansen < kenneth@webkit.org> on 2009-10-30
Reviewed by Holger Hans Peter Freyther.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::applyTheme):
- 06:07 Changeset [50329] by
-
Unreviewed potential buildbot fix.
Patch by Kenneth Rohde Christiansen < kenneth@webkit.org> on 2009-10-30
Reset page history before running each test.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- 05:12 QtWebKitPerformanceToolBackLog: edited by
- (diff)
- 03:50 Changeset [50328] by
-
2009-10-30 Pavel Feldman < pfeldman@chromium.org>
Not reviewed: Wire CookieJarChromium to the cookies
backend. This is a final step of a 3-steps raw cookies
access implementation in Chromium.
- platform/network/chromium/CookieJarChromium.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- 03:32 Changeset [50327] by
-
2009-10-30 Yury Semikhatsky < yurys@chromium.org>
Reviewed by Pavel Feldman.
Fix Chromium crash in console.log in "deeply recursive" function
Check that result of 'frameSourceName' is not null handle
before casting it to String.
Allow V8Proxy::sourceName/sourceLineNumber() to report
that they have failed due to JavaScript stack overflow.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptCallStack.h:
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::sourceLineNumber): (WebCore::V8Proxy::sourceName):
- bindings/v8/V8Proxy.h:
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- 02:27 Changeset [50326] by
-
Allow custom memory allocation control for WebCore's MediaQueryExp
https://bugs.webkit.org/show_bug.cgi?id=30855
Reviewed by Darin Adler.
Inherits MediaQueryExp class from FastAllocBase because it is
instantiated by 'new' in WebCore/css/CSSParser.cpp:4874.
* css/MediaQueryExp.h:
- 01:55 Changeset [50325] by
-
2009-10-30 Adam Barth < abarth@webkit.org>
Reviewed by Mark Rowe.
Teach git to ignore some files
https://bugs.webkit.org/show_bug.cgi?id=30951
Ignore WebKitBuild because we never want to version that directory.
Also, ignore the xcode project files so git clean doesn't blow away
your project settings. Finally, ignore the compiled python files in
WebKitTools/Script modules because they clutter up git status.
- .gitignore: Added.
- 01:53 Changeset [50324] by
-
Allow custom memory allocation control for JavaScriptCore's ListHashSet
https://bugs.webkit.org/show_bug.cgi?id=30853
Reviewed by Darin Adler.
Inherits ListHashSet class from FastAllocBase because it is
instantiated by 'new' in WebCore/rendering/RenderBlock.cpp:1813.
* wtf/ListHashSet.h:
- 01:13 Changeset [50323] by
-
Regression: crash enumerating properties of an object with getters or setters
https://bugs.webkit.org/show_bug.cgi?id=30948
Reviewed by Gavin Barraclough
Add a guard to prevent us trying to cache property enumeration on
objects with getters or setters.
- 00:55 Changeset [50322] by
-
Commit patch 1 of ruby implementation, reviewed by Eric Seidel. (see issue 28420)
- 00:24 Changeset [50321] by
-
Removed test for an impossible condition (a glyph in a right-to-left run not having
the RTL flag 0x800)
Reviewed by Adele Peterson.
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation):
- 00:13 Changeset [50320] by
-
REGRESSION (r50218-r50262): E*TRADE accounts page is missing content
https://bugs.webkit.org/show_bug.cgi?id=30947
< rdar://problem/7348833>
Reviewed by Maciej Stachowiak
The logic for flagging that a structure has non-enumerable properties
was in addPropertyWithoutTransition, rather than in the core Structure::put
method. Despite this I was unable to produce a testcase that caused
the failure that etrade was experiencing, but the new assertion in
getEnumerablePropertyNames triggers on numerous layout tests without
the fix, so in effecti all for..in enumeration in any test ends up
doing the required consistency check.
10/29/09:
- 23:51 Changeset [50319] by
-
2009-10-29 Adam Barth < abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Out-of-memory crash in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=30906
We need to handle the fact that creating a V8:Context might fail. I
don't know how to test this change because creating a context usually
only fails when V8 decides it's using too much memory.
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext):
- 23:29 QtBackLog edited by
- (diff)
- 23:26 QtBackLog edited by
- (diff)
- 23:12 Changeset [50318] by
-
Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
from the two scripts that define it but don’t use it to the script that uses it but doesn’t
define it.
Reviewed by Mark Rowe.
* Scripts/VCSUtils.pm:
* Scripts/svn-apply:
* Scripts/svn-unapply:
- 22:57 Changeset [50317] by
-
Validate the stopSpeaking: selector so that is not always enabled when a WebView is first responder.
Reviewed by Oliver Hunt.
* WebView/WebHTMLView.mm:
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
- 21:07 Changeset [50316] by
-
< http://webkit.org/b/30938> REGRESSION(r50233): Windows nightlies crash on launch due to changes
to IWebFramePrivate vtable ordering
Rubber-stamped by Dan Bernstein.
* Interfaces/IWebFramePrivate.idl: Move the newly-added method to the end of the interface so that
it doesn't affect the ordering of the vtable.
- 19:39 Changeset [50315] by
-
2009-10-29 Erik Arvidsson < arv@chromium.org>
Reviewed by Eric Seidel.
Make links mouse focusable only on GTK and QT.
Links are now always mouse focusable on GTK and QT. On other platforms
the link needs a tabIndex or it needs to be contentEditable.
- fast/events/click-focus-anchor-expected.txt:
- fast/events/click-focus-anchor.html:
- platform/gtk/fast/events/click-focus-anchor-expected.txt: Added.
- platform/mac/fast/events/click-focus-anchor-expected.txt: Removed.
- platform/qt/fast/events/click-focus-anchor-expected.txt: Added.
2009-10-29 Erik Arvidsson < arv@chromium.org>
Reviewed by Eric Seidel.
Make links mouse focusable only on GTK and QT.
Links are now always mouse focusable on GTK and QT. On other platforms
the link needs a tabIndex or it needs to be contentEditable.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isMouseFocusable):
- 19:30 Changeset [50314] by
-
2009-10-29 Jonathan Dixon < joth@chromium.org>
Reviewed by Eric Seidel.
Add expected files for GTK and QT builds, for test text-input-webkit-radius.html
Expected fils collected from buildbot:
http://build.webkit.org/results/Qt%20Linux%20Release/r50286%20(3257)/fast/css/
http://build.webkit.org/results/GTK%20Linux%20Release/r50286%20(5308)/fast/css/
- platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
- platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
- 19:00 Changeset [50313] by
-
Updated Tiger-specific result now that Tiger matches current behavior. A Tiger-specific
result is still needed because of the difference in Thai fonts.
* platform/mac-tiger/fast/text/atsui-multiple-renderers-expected.txt:
- 17:49 Changeset [50312] by
-
WebCore: Complete the fix for hit-testing and selection highlighting in ligatures for the ATSUI
code path.
Reviewed by Sam Weinig.
* platform/graphics/mac/ComplexTextController.h: Added m_ltr member to ComplexTextRun.
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Skip over deleted
glyphs, but update indexes and advances correctly.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_ltr.
LayoutTests: Updated a test to account for font metric differences between Mac OS X versions. Removed
Leopard-specific results for another test now that Leopard matches current behavior.
Reviewed by Sam Weinig.
* platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.checksum: Removed.
* platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.png: Removed.
* platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.txt: Removed.
* platform/mac/fast/text/ligature-subdivision-expected.txt:
* platform/mac/fast/text/script-tests/ligature-subdivision.js:
- 17:26 Changeset [50311] by
-
Updating Radar numbers
- 16:37 Changeset [50310] by
-
REGRESSION(3.2.3 - 4.0.2): Message composing: when I undo a color change to text in Mail, undo/redo behaves strangely
< rdar://problem/7067033>
https://bugs.webkit.org/show_bug.cgi?id=30892
WebCore:
Patch by Enrica Casucci < enrica@apple.com> on 2009-10-29
Reviewed by Darin Adler.
This problem shows in any scenario where it is necessary to split a text
node to apply a style. SplitElementCommand and WrapContentsInDummySpanCommand both
have member variables initialized in the constructor to keep reference to elements
they need to operate upon. These reference are not updated when reapplying the command.
For this reason it is necessary to guarantee that unapply doesn not delete the references
and that these commands implement doReapply to correctly reuse the existing
elements.
Test: editing/undo/redo-style.html
* editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::executeApply): Added.
(WebCore::SplitElementCommand::doApply): Modified to call executeApply.
(WebCore::SplitElementCommand::doUnapply): Doesn't release m_element1.
(WebCore::SplitElementCommand::doReapply): Added.
* editing/SplitElementCommand.h: Added doReapply and executeApply.
* editing/WrapContentsInDummySpanCommand.cpp:
(WebCore::WrapContentsInDummySpanCommand::executeApply): Added.
(WebCore::WrapContentsInDummySpanCommand::doApply): Modified to call executeApply.
(WebCore::WrapContentsInDummySpanCommand::doUnapply): Doesn't release m_dummySpan.
(WebCore::WrapContentsInDummySpanCommand::doReapply): Added.
* editing/WrapContentsInDummySpanCommand.h: Added doReapply and executeApply.
LayoutTests:
Patch by Enrica Casucci < enrica@apple.com> on 2009-10-29
* editing/undo/redo-style-expected.txt: Added.
* editing/undo/redo-style.html: Added.
- 16:22 Changeset [50309] by
-
2009-10-29 Jeremy Orlow < jorlow@chromium.org>
Reviewed by Darin Fisher.
DOM Storage's condition variable needs to handle spurious wakeups
https://bugs.webkit.org/show_bug.cgi?id=30920
Add a boolean to keep track of whether it's been terminated. Clean
up the locking code a tiny bit to make it easier to read. There's
no way to reproduce this reliably in a LayoutTest.
- storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::terminate): (WebCore::LocalStorageThread::performTerminate):
- storage/LocalStorageThread.h:
- 16:22 Changeset [50308] by
-
https://bugs.webkit.org/show_bug.cgi?id=30932
< rdar://problem/7350269>
Reviewed by Sam Weinig.
REGRESSION: Crash when turning on Private Browsing on site with flash.
Null check setValue.
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView privateBrowsingModeDidChange]):
- 15:49 Changeset [50307] by
-
WebKitTools: Implement the Qt version of DRT dumpBackForwardList().
Patch by Kenneth Rohde Christiansen < kenneth@webkit.org> on 2009-10-29
Reviewed by Oliver Hunt.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::dumpHistoryItem):
(WebCore::DumpRenderTree::dumpBackForwardList):
LayoutTests: Removed test that passes after implementing the Qt DRT version
of dumpBackForwardList().
Patch by Kenneth Rohde Christiansen < kenneth@webkit.org> on 2009-10-29
Reviewed by Oliver Hunt.
* platform/qt/Skipped:
- 15:43 Changeset [50306] by
-
2009-10-29 Dimitri Glazkov < dglazkov@chromium.org>
Unreviewed, build fix.
[Chromium] Include ComplextTextController into Chromium Mac project.
- WebCore.gyp/WebCore.gyp: Added include rule for ComplextText* files.
- 15:32 Changeset [50305] by
-
2009-10-29 Eric Carlson < eric.carlson@apple.com>
Reviewed by Kevin Decker.
Refactor some duplicate plug-in clean up code into shared functions.
- Plugins/WebPluginController.mm: (-[WebPluginController stopOnePlugin:]): New, stop a plug-in. (-[WebPluginController destroyOnePlugin:]): New, destroy plug-in. (-[WebPluginController stopAllPlugins]): Call stopOnePlugin. (-[WebPluginController destroyPlugin:]): Call stopOnePlugin and destroyOnePlugin. (-[WebPluginController destroyAllPlugins]): Call destroyOnePlugin.
- 15:32 Changeset [50304] by
-
2009-10-29 Shinichiro Hamaji < hamaji@chromium.org>
Reviewed by Darin Adler.
fast/css/counters/invalidate-cached-counter-node can be dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=30931
- fast/css/counters/invalidate-cached-counter-node-expected.txt: Added.
- fast/css/counters/invalidate-cached-counter-node.html:
- platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.checksum: Removed.
- platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.png: Removed.
- platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.txt: Removed.
- 14:59 Changeset [50303] by
-
Fix tabbing through element attributes in the Web Insector.
https://bugs.webkit.org/show_bug.cgi?id=30429
Reviewed by Pavel Feldman.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): Don't call _updateTitle,
it is called for us when removeAttribute succeeds in the back-end.
(WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): Ditto except for nodeValue.
(WebInspector.ElementsTreeElement.prototype._editingCancelled): Don't call _updateTitle, editing code reverts.
(WebInspector.ElementsTreeElement.prototype._updateTitle): Return early if we are editing.
- 14:54 Changeset [50302] by
-
[Qt] Remove some tests that now pass.
Patch by Csaba Osztrogonác < ossy@webkit.org> on 2009-10-29
* platform/qt/Skipped:
- 14:25 Changeset [50301] by
-
Problem editing or selecting text containing ligatures
https://bugs.webkit.org/show_bug.cgi?id=30025
Reviewed by Sam Weinig.
WebCore:
Test: platform/mac/fast/text/ligature-subdivision.html
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController): Initialize
m_characterInCurrentGlyph.
(WebCore::ComplexTextController::offsetForPosition): If the hit glyph spans multiple
characters, compute the hit character based on dividing the glyph’s total advance into
a number of equal intervals equal to the number of characters and assigning the hit to the
character corresponding to the hit interval.
(WebCore::ComplexTextController::advance): If the final offset occurs mid-glyph, advance
by a fraction of the glyph’s total advance.
* platform/graphics/mac/ComplexTextController.h: Added m_characterInCurrentGlyph.
LayoutTests:
* platform/mac/fast/text/ligature-subdivision-expected.txt: Added.
* platform/mac/fast/text/ligature-subdivision.html: Added.
* platform/mac/fast/text/script-tests: Added.
* platform/mac/fast/text/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/js/script-tests/TEMPLATE.html.
* platform/mac/fast/text/script-tests/ligature-subdivision.js: Added.
- 14:25 Changeset [50300] by
-
Fixes < http://webkit.org/b/30918>.
Web Inspector: Datagrid Rows on Windows not properly aligned.
Reviewed by Timothy Hatcher.
Use line-height for the table rows to make sure the height
of our text and the height of the table rows are consistent.
* inspector/front-end/inspector.css:
- 13:33 Changeset [50299] by
-
2009-10-29 Adam Barth < abarth@webkit.org>
No review, rolling out r50296.
http://trac.webkit.org/changeset/50296
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext):
- 13:25 Changeset [50298] by
-
2009-10-29 Xan Lopez < xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Use the GTK+ main loop instead of rolling our own mini-version of
it.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): (runTest): (webViewLoadFinished):
- 13:21 Changeset [50297] by
-
Rubberstamped by Adam Roben.
Patch by Kenneth Rohde Christiansen < kenneth@webkit.org> on 2009-10-29
Remove two tests that pass on the buildbot.
* platform/qt/Skipped:
- 13:15 Changeset [50296] by
-
2009-10-29 Adam Barth < abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Out-of-memory crash in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=30906
We need to handle the fact that creating a V8:Context might fail. I
don't know how to test this change because creating a context usually
only fails when V8 decides it's using too much memory.
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext):
- 13:05 Changeset [50295] by
-
Reviewed by Xan Lopez.
Remove build warning introduced by r50284.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration):
- 13:05 Changeset [50294] by
-
Unreviewed Qt buildbot fix.
Patch by Kenneth Rohde Christiansen < kenneth@webkit.org> on 2009-10-29
Add some files to skipped that depend on phonon support,
which is disabled on the Qt buildbot for now.
* platform/qt/Skipped:
- 13:01 Changeset [50293] by
-
2009-10-29 Dimitri Glazkov < dglazkov@chromium.org>
Reviewed by Adam Barth.
[V8] Remove random crashes by removing retrieval of V8 context during garbage collection.
Unfortunately, I haven't been able to trigger this crash explicitly, so no test :(.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::jsWrapperForDOMObject): Added new "assume-it's-there" getter.
- bindings/v8/V8DOMWrapper.h: Added getter decl.
- bindings/v8/V8GCController.cpp: (WebCore::GCPrologueVisitor::visitDOMWrapper): Changed to use explicit getter.
- 12:43 Changeset [50292] by
-
2009-10-29 Dimitri Glazkov < dglazkov@chromium.org>
Unreviewed, build fix.
[Chromium] Adjust the project files to sync up with
http://trac.webkit.org/changeset/50259
- WebCore.gypi: Renamed and added files.
- 12:41 Changeset [50291] by
-
Updated expected result for Tiger
* platform/mac-tiger/fast/text/international/thai-line-breaks-expected.txt:
- 12:24 Changeset [50290] by
-
Rubberstamped by Adam Roben.
Patch by Kenneth Rohde Christiansen < kenneth@webkit.org> on 2009-10-29
Remove tests that pass after the change introduced in r50289.
* platform/qt/Skipped:
- 12:06 Changeset [50289] by
-
Implement DRT functionality for Qt introduced in
r28690 and r28705.
Patch by Kenneth Rohde Christiansen < kenneth@webkit.org> on 2009-10-29
Reviewed by Adam Roben.
- Implemented pathToLocalResource which exposes the functionality of
converting a given unix path to the correct location on Windows.
- Implemented a way to remove machine-dependent information from paths
in layout test results.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::urlSuitableForTestResult):
(WebCore::WebPage::javaScriptConsoleMessage):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::pathToLocalResource):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
- 11:29 Changeset [50288] by
-
2009-10-29 Laszlo Gombos < laszlo.1.gombos@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Implement DELETE HTTP method for XmlHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=30894
No new tests as this functionality is already tested by the
xmlhttprequest LayoutTests. As this patch depends on an unreleased
version of the dependent QtNetwork library and the tests will be
enabled later once the dependent library is released (and the
buildbot is updated).
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::start):
2009-10-29 Laszlo Gombos < laszlo.1.gombos@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Implement DELETE HTTP method for XmlHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=30894
No new tests as this functionality is already tested by the
xmlhttprequest LayoutTests. As this patch depends on an unreleased
version of the dependent QtNetwork library and the tests will be
enabled later once the dependent library is released (and the
buildbot is updated).
- Api/qwebframe.cpp: (QWebFrame::load):
- 11:15 Changeset [50287] by
-
Part of < http://webkit.org/b/30483>.
Web Inspector: Always show the Local and Session Storage Views.
Reviewed by Timothy Hatcher.
Even if the length of the DOM Storage entry array is 0, still
generate the Datagrid because users can add things storage items
through the UI, so we should allow them to even if there isn't
anything there currently.
* English.lproj/localizedStrings.js: Removed "This Storage is Empty".
* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
- 10:58 Changeset [50286] by
-
2009-10-29 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add TimelinePanel into the panels enum.
- inspector/InspectorController.cpp: (WebCore::InspectorController::specialPanelForJSName):
- inspector/InspectorController.h: (WebCore::InspectorController::):
- 10:53 Changeset [50285] by
-
2009-10-29 Xan Lopez < xlopez@igalia.com>
Reviewed by Oliver Hunt.
[GTK] Threading problems with some of the tests
https://bugs.webkit.org/show_bug.cgi?id=30814
Create strings shared among threads with crossThreadString
constructor method.
- storage/Database.cpp: (WebCore::Database::Database):
- 10:50 Changeset [50284] by
-
2009-10-29 Sebastian Dröge < sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Add support for ARGB videos.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint): Create the Cairo image surface for ARGB32 or RGB24 depending on the buffer's caps.
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_timeout_func): (webkit_video_sink_render): Handle ARGB video and convert GStreamer's ARGB to Cairo's for displaying.
- 10:42 Changeset [50283] by
-
2009-10-29 Anton Muhin < antonm@chromium.org>
Reviewed by David Levin.
[chromium] expose a method to access memory usage information in ChromiumBridge
Declare a static method to be implemented by http://codereview.chromium.org/332010/
https://bugs.webkit.org/show_bug.cgi?id=30829
- platform/chromium/ChromiumBridge.h:
- 10:34 Changeset [50282] by
-
2009-10-29 Joanmarie Diggs < joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25679
[Gtk] Improve accessibility of focusable lists
Implements the AtkSelection interface and enables the corresponding
(and expected) object:selection-changed event.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (optionFromList): (optionFromSelection): (atk_selection_interface_init): (webkit_accessible_selection_add_selection): (webkit_accessible_selection_clear_selection): (webkit_accessible_selection_ref_selection): (webkit_accessible_selection_get_selection_count): (webkit_accessible_selection_is_child_selected): (webkit_accessible_selection_remove_selection): (webkit_accessible_selection_select_all_selection): (GetAtkInterfaceTypeFromWAIType):
- accessibility/gtk/AXObjectCacheAtk.cpp: (AXObjectCache::postPlatformNotification):
- 10:27 Changeset [50281] by
-
Touch WebKit.idl to force a rebuild.
- 10:26 Changeset [50280] by
-
Rubber-stamped by Steve Falkenburg.
Windows Release bots are having problems in xmlhttprequest tests, Skipping them temporarily
to see if this eliminates the problem, and it is a test causing httpd problems.
* platform/win/Skipped:
- 10:18 Changeset [50279] by
-
Bug 30655 - Only plain text should be copied to clipboard for TextArea.
https://bugs.webkit.org/show_bug.cgi?id=30655
Reviewed by Darin Adler.
* editing/Editor.cpp:
(WebCore::nodeIsInTextFormControl):
(WebCore::Editor::cut):
(WebCore::Editor::copy):
- 09:58 Changeset [50278] by
-
2009-10-29 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: hide timeline for now - not yet ready.
- inspector/front-end/inspector.js: (WebInspector._createPanels):
- 09:46 Changeset [50277] by
-
2009-10-29 Pavel Feldman < pfeldman@chromium.org>
Not reviewed: deploy Web Inspector's images in WebCore.gypi.
- WebCore.gypi:
- 09:36 Changeset [50276] by
-
2009-10-29 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: get rid of timelineProfilerEnabled method.
- inspector/InspectorBackend.cpp:
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible):
- inspector/InspectorController.h:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
- 09:12 Changeset [50275] by
-
2009-10-29 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Darin Fisher.
Create stub methods for raw cookies access in ChromiumBridge.h
- platform/chromium/ChromiumBridge.h:
- 08:58 QtWebKitContrib edited by
- (diff)
- 08:55 QtWebKitContrib edited by
- (diff)
- 08:44 Changeset [50274] by
-
Allow custom memory allocation control for WebCore's RareData
https://bugs.webkit.org/show_bug.cgi?id=30858
Reviewed by Darin Adler.
Inherits RareData struct from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSSelector.h:259 and
it is no need to be copyable.
* css/CSSSelector.h:
- 08:41 Changeset [50273] by
-
Allow custom memory allocation control for WebCore's ShorthandScope
https://bugs.webkit.org/show_bug.cgi?id=30859
Reviewed by Darin Adler.
Inherits ShorthandScope class from FastAllocBase because it is
instantiated by 'new' in WebCore/css/CSSParser.cpp:902 and
it is no need to be copyable.
* css/CSSParser.h:
- 08:38 Changeset [50272] by
-
Allow custom memory allocation control for WebCore's AXObjectCache
https://bugs.webkit.org/show_bug.cgi?id=30848
Reviewed by Darin Adler.
Inherits AXObjectCache class from FastAllocBase because it is
instantiated by 'new' in WebCore/dom/Document.cpp:1537 and
it is no need to be copyable.
* accessibility/AXObjectCache.h:
- 08:18 Changeset [50271] by
-
2009-10-29 Adam Barth < abarth@webkit.org>
Reviewed by Eric Seidel.
Don't run JavaScript URLs in view source mode
https://bugs.webkit.org/show_bug.cgi?id=30881
Test that we don't run JavaScript URLs in view source mode.
This test actually passes before this change. I don't know how to
actually run JavaScript URLs in view source frames using DRT, but it's
possible in an abitrary embedding of WebKit.
- http/tests/security/view-source-no-javascript-url-expected.txt: Added.
- http/tests/security/view-source-no-javascript-url.html: Added.
2009-10-28 Adam Barth < abarth@webkit.org>
Reviewed by Eric Seidel.
Don't run JavaScript URLs in view source mode
https://bugs.webkit.org/show_bug.cgi?id=30881
Just say no.
Test: http/tests/security/view-source-no-javascript-url.html
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
- 07:43 Changeset [50270] by
-
Remove QWebView::guessUrlFromString() and replace its use
with the new QUrl::fromUserInput() if using Qt 4.6 or newer.
Patch by Kenneth Rohde Christiansen < kenneth@webkit.org> on 2009-10-29
Reviewed by Tor Arne Vestbø.
* Api/qwebview.cpp:
* Api/qwebview.h:
* QGVLauncher/main.cpp:
(urlFromUserInput):
(WebPage::applyProxy):
(MainWindow::load):
* QtLauncher/main.cpp:
(urlFromUserInput):
(MainWindow::MainWindow):
(MainWindow::changeLocation):
* tests/qwebview/tst_qwebview.cpp:
- 06:23 Changeset [50269] by
-
Serialize directly to the stream, and not first to an QByteArray,
that is later serialized. That is slower and also uses more bytes.
Patch by Kenneth Rohde Christiansen < kenneth@webkit.org> on 2009-10-28
Reviewed by Tor Arne Vestbø.
* Api/qwebhistory.cpp:
(operator<<):
(operator>>):
- 05:48 Changeset [50268] by
-
Unreviewed. Fixes style problems pointed out by Evan Martin.
- 05:46 Changeset [50267] by
-
Unreviewed. Trivial fix - move public API declaration into the
public subsection of the doc.
- docs/webkitgtk-sections.txt:
- 02:21 Changeset [50266] by
-
Rubber-stamped by Mark Rowe.
64-bit Leopard build fix after r50259
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
Declared ATSUTextInserted in 64-bit.
(WebCore::fontHasMirroringInfo): Use %d format and cast to int.
(WebCore::disableLigatures): Ditto.
(WebCore::initializeATSUStyle): Ditto.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Ditto.
- 00:32 Changeset [50265] by
-
Add cacheFlush support for Thumb-2 on Linux
https://bugs.webkit.org/show_bug.cgi?id=30865
Patch by Gabor Loki < loki@inf.u-szeged.hu> on 2009-10-29
Reviewed by Gavin Barraclough.
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
- 00:23 Changeset [50264] by
-
Tiger build fix after r50259
* platform/graphics/mac/ComplexTextController.h:
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
- 00:12 Changeset [50263] by
-
Tiger build fix after r50259
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
10/28/09:
- 23:07 Changeset [50262] by
-
Fix changelog
- 23:06 Changeset [50261] by
-
https://bugs.webkit.org/show_bug.cgi?id=30899
WebKit fails to build release on 32-bit Windows systems
Reviewed by Mark Rowe.
* WebCore.vcproj/WebCore.vcproj: Excluded files from project.
* bindings/js/JSBindingsAllInOne.cpp: Added.
- 23:04 Changeset [50260] by
-
Fixed typos in color names.
Reviewed by Jon Honeycutt.
* inspector/front-end/Color.js:
- 22:35 Changeset [50259] by
-
WebCore: Share code between the ATSUI- and Core Text-based Font implementations by doing the
following:
- Generalize CoreTextController as ComplexTextController, keeping the Core Text-specific
parts in ComplexTextControllerCoreText.cpp.
- Generalize FontMacCoreText as FontComplexTextMac using ComplexTextController
- Implement ATSUI-specific parts of ComplexTextController in ComplexTextControllerATSUI.
- Remove FontMacATSUI.
Reviewed by Sam Weinig.
* WebCore.xcodeproj/project.pbxproj: Removed CoreTextController.{cpp,h}, FontMacATSUI.mm,
and FontMacCoreText.cpp, and added ComplexTextController.{cpp,h},
ComplexTextControllerATSUI.cpp, ComplexTextControllerCoreText.cpp, and
FontComplexTextMac.cpp.
* platform/graphics/mac/ComplexTextController.cpp: Copied from CoreTextController.cpp and
kept the non-Core Text-specific bits.
(WebCore::ComplexTextController::ComplexTextController): Updated for renames, including
its own.
(WebCore::ComplexTextController::offsetForPosition): Updated for renames and for
m_complexTextRuns holding references instead of objects.
(WebCore::ComplexTextController::collectComplexTextRuns): Updated for renames, including
its own.
(WebCore::ComplexTextController::advance): Updated for renames.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Updated for renames and for
m_complexTextRuns holding references instead of objects, and changed to use the glyphs()
and advances() accessors.
* platform/graphics/mac/ComplexTextController.h: Copied from CoreTextController.h and
renamed CoreTextController to ComplexTextController and CoreTextRun to ComplexTextRun. Made
the latter RefCounted, added ATSUI-specific members to it, and made some other members
Core Text-specific. Renamed m_coreTextRuns to m_complexTextRuns and made it hold references
rather than objects.
(WebCore::ComplexTextController::ComplexTextRun::create):
(WebCore::ComplexTextController::ComplexTextRun::glyphs):
(WebCore::ComplexTextController::ComplexTextRun::advances):
* platform/graphics/mac/ComplexTextControllerATSUI.cpp: Added. Includes ATSUI-specific
parts of the ComplexTextController implementation.
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): This ATSUI
callback populates the ComplexTextRun’s glyphs, advances and indices vectors. It is invoked
when the ComplexTextRun constructor calls ATSUGetGlyphBounds().
(WebCore::isArabicLamWithAlefLigature): Helper function, copied from FontMacATSUI.mm.
(WebCore::shapeArabic): Helper function, adapted from FontMacATSUI.mm.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Sets up the
ATSUTextLayout, substituting the text buffer if necessary for things like shaping Arabic,
mirroring glyphs or directionality overrides, then calls ATSUGetGlyphBounds() in order to
get the glyphs, advances and indices vectors populated.
(WebCore::fontHasMirroringInfo): Helper function, copied from FontMacATSUI.mm.
(WebCore::disableLigatures): Ditto.
(WebCore::initializeATSUStyle): Ditto, somewhat cleaned up and simplified.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Constructs
ComplexTextRuns, either missing-glyphs ones or ATSUTextLayout-based ones.
* platform/graphics/mac/ComplexTextControllerCoreText.cpp: Copied from
CoreTextController.cpp and kept the Core Text-specific bits.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Updated for renames,
including its own, and moved the code to initialize m_glyphs and m_advances here. Previously
this was done in adjustGlyphsAndAdvances().
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Updated for renames,
including its own.
* platform/graphics/mac/CoreTextController.cpp: Removed.
* platform/graphics/mac/CoreTextController.h: Removed.
* platform/graphics/mac/FontComplexTextMac.cpp: Renamed FontMacCoreText.cpp to this.
(WebCore::Font::selectionRectForComplexText): Changed to use ComplexTextController instead
of CoreTextController.
(WebCore::Font::drawComplexText): Ditto.
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::Font::offsetForPositionForComplexText): Ditto.
* platform/graphics/mac/FontMacATSUI.mm: Removed.
* platform/graphics/mac/FontMacCoreText.cpp: Removed.
LayoutTests: Removed Leopard-specific result after changing ATSUI missing-glyph behavior to match the
Core Text and fast code paths' behavior.
* platform/mac-leopard/fast/text/international/khmer-selection-expected.txt: Removed.
- 22:23 Changeset [50258] by
-
2009-10-28 Roland Steiner < rolandsteiner@chromium.org>
Adding myself to the committers list.
- Scripts/modules/committers.py:
- 21:20 Changeset [50257] by
-
Adding myself to the committers list.
- 19:48 Changeset [50256] by
-
WebCore: WAI-ARIA: add support for 'option' role
https://bugs.webkit.org/show_bug.cgi?id=30843
Reviewed by Darin Adler.
Test: accessibility/aria-option-role.html
* accessibility/AccessibilityListBoxOption.h:
(WebCore::AccessibilityListBoxOption::canHaveChildren):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::RoleEntry::):
(WebCore::AccessibilityRenderObject::canHaveChildren):
LayoutTests: Fix video-pause-immediately.html to avoid using setTimeout().
Patch by Andrew Scherkus < scherkus@chromium.org> on 2009-10-28
Reviewed by Eric Carlson.
This also addresses the flakiness on Windows, where 200ms was not enough time to advance the clock past zero.
https://bugs.webkit.org/show_bug.cgi?id=30889
* media/video-pause-immediately.html: Replace setTimeout() with timeupdate events.
- 18:40 Changeset [50255] by
-
JSC JIT on ARMv7 cannot link jumps >16Mb range
https://bugs.webkit.org/show_bug.cgi?id=30891
Patch by Gavin Barraclough < barraclough@apple.com> on 2009-10-28
Reviewed by Oliver Hunt.
Start planing all relative jumps as move-32-bit-immediate-to-register-BX.
In the cases where the jump would fall within a relative jump range, use a relative jump.
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::~ARMv7Assembler):
(JSC::ARMv7Assembler::LinkRecord::LinkRecord):
(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::executableCopy):
(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::relinkJump):
(JSC::ARMv7Assembler::setInt32):
(JSC::ARMv7Assembler::isB):
(JSC::ARMv7Assembler::isBX):
(JSC::ARMv7Assembler::isMOV_imm_T3):
(JSC::ARMv7Assembler::isMOVT):
(JSC::ARMv7Assembler::isNOP_T1):
(JSC::ARMv7Assembler::isNOP_T2):
(JSC::ARMv7Assembler::linkJumpAbsolute):
(JSC::ARMv7Assembler::twoWordOp5i6Imm4Reg4EncodedImmFirst):
(JSC::ARMv7Assembler::twoWordOp5i6Imm4Reg4EncodedImmSecond):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp5i6Imm4Reg4EncodedImm):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::makeJump):
(JSC::MacroAssemblerARMv7::makeBranch):
* jit/JIT.h:
* wtf/Platform.h:
- 18:25 Changeset [50254] by
-
Improve for..in enumeration performance
https://bugs.webkit.org/show_bug.cgi?id=30887
Reviewed by Geoff Garen.
Improve indexing of an object with a for..in iterator by
identifying cases where get_by_val is being used with a iterator
as the subscript and replace it with a new get_by_pname
bytecode. get_by_pname then optimizes lookups that directly access
the base object.
- 17:54 Changeset [50253] by
-
2009-10-28 Jens Alfke < snej@chromium.org>
Reviewed by Eric Seidel.
Fix GCC compiler warnings in WebCore, and enable -Wall and -Werror for Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=30716
- WebCore.gyp/WebCore.gyp: Enable "chromium_code" flag, just on Mac build for now.
- accessibility/AccessibilityRenderObject.cpp: (WebCore::createARIARoleMap): Fix struct visibiity warning.
- bindings/v8/ScriptCallStack.h: Fix out-of-order member initialization warning.
- bindings/v8/V8Collection.h: (WebCore::getV8Object): Function in header should not be 'static' (fixes unused-static warning.)
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertNewNodeToV8Object): Fix signed/unsigned comparison warning.
- bindings/v8/V8GCController.cpp: (WebCore::ObjectGrouperVisitor::applyGrouping): Fix unused-variable warning.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Enable ListButtonPart case to avoid
warning about missing cases in 'switch' statement.
- editing/EditorCommand.cpp: (WebCore::createCommandMap): Fix struct visibiity warning.
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): Fix out-of-order member initialization warning.
- rendering/RenderMediaControlsChromium.cpp: (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart): Add empty 'default' case in
'switch' statement to avoid missing-case warning.
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Ditto.
- xml/XPathFunctions.cpp: (WebCore::XPath::createFunctionMap): Fix struct visibiity warning.
- 17:45 Changeset [50252] by
-
2009-10-28 Andrew Scherkus < scherkus@chromium.org>
Reviewed by Eric Carlson.
Fix video-pause-immediately.html to avoid using setTimeout().
This also addresses the flakiness on Windows, where 200ms was not enough time to advance the clock past zero.
- media/video-pause-immediately.html: Replace setTimeout() with timeupdate events.
- 17:22 Changeset [50251] by
-
2009-10-28 Adam Barth < abarth@webkit.org>
Reviewed by Darin Adler.
REGRESSION: crashes in WebCore::RedirectScheduler::timerFired(WebCore::Timer<WebCore::RedirectScheduler>*)
https://bugs.webkit.org/show_bug.cgi?id=30839
Added null check for the case when the frame is detached from the page.
- loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::timerFired):
- 17:12 Changeset [50250] by
-
2009-10-28 Joanmarie Diggs < joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30817
Use parentObjectUnignored instead of parentObject in webkit_accessible_get_parent
Also removes the hack I had originally added to solve bug 25411, because
the fix here is what I should have done in the first place.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent):
- 17:08 Changeset [50249] by
-
Rubber-stamped by Ada Chan.
Add accessibility test to the list of Windows Skipped tests.
* platform/win/Skipped:
- 16:37 Changeset [50248] by
-
Not reviewed, attemp to fix Windows build.
Touch the cpp file to cause recompile.
* wtf/Threading.cpp:
(WTF::threadEntryPoint):
- 16:21 Changeset [50247] by
-
JavaScriptCore: Add MessageQueue::removeIf(Predicate&) to remove certain tasks without pulling them from the queue.
Existing Database tests cover this since Database removes tasks when it is stopped.
https://bugs.webkit.org/show_bug.cgi?id=30805
Reviewed by David Levin.
* wtf/MessageQueue.h:
(WTF::::removeIf):
WebCore: Add MessageQueue::removeIf(Predicate&) to remove certain tasks without pulling them from the queue.
Existing Database tests cover this, no change in functionality.
https://bugs.webkit.org/show_bug.cgi?id=30805
Reviewed by David Levin.
* storage/DatabaseThread.cpp:
(WebCore::SameDatabasePredicate::SameDatabasePredicate): Added predicate that flags the tasks belonging to a specified database.
(WebCore::SameDatabasePredicate::operator()):
(WebCore::DatabaseThread::unscheduleDatabaseTasks): changed to use the new removeIf method.
- 16:19 Changeset [50246] by
-
2009-10-28 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Glue subsequent timeline records with same category
and title together. Enable Timeline Panel!!!
- English.lproj/localizedStrings.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelineRecordTreeElement.prototype.onattach): (WebInspector.TimelineRecordTreeElement.prototype.refresh):
- 15:56 Changeset [50245] by
-
LayoutTests
Reviewed by Jan Alonzo.
[GTK] API to start inspector for a WebView
https://bugs.webkit.org/show_bug.cgi?id=22551
Unskip inspector tests that we are now able to run.
- platform/gtk/Skipped:
WebKit/gtk
Reviewed by Jan Alonzo.
[GTK] API to start inspector for a WebView
https://bugs.webkit.org/show_bug.cgi?id=22551
Provide a simple, coordinates-based API to start the inspector.
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::createPage): Use files from the source tree when running from the top of the source directory. (WebKit::InspectorClient::localizedStringsURL): Ditto.
- webkit/webkitprivate.h:
- webkit/webkitwebinspector.cpp: (webkit_web_inspector_inspect_coordinates): (webkit_web_inspector_close): (webkit_web_inspector_execute_script):
- webkit/webkitwebinspector.h:
WebKitTools
Reviewed by Jan Alonzo.
[GTK] API to start inspector for a WebView
https://bugs.webkit.org/show_bug.cgi?id=22551
Use the new inspector API to implement the LayoutTestController
interfaces used to test the inspector.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webInspectorInspectWebView): (createWebView):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
- 15:42 Changeset [50244] by
-
LayoutTests
Reviewed by Xan Lopez.
[GTK] Fails new test fast/js/navigator-language.html
https://bugs.webkit.org/show_bug.cgi?id=30440
Unskip the test that now passes.
- platform/gtk/Skipped:
WebCore
Reviewed by Xan Lopez.
[GTK] Fails new test fast/js/navigator-language.html
https://bugs.webkit.org/show_bug.cgi?id=30440
Reimplement WebCore::defaultLanguage to account for changes in
locale done by setLocale.
Already existing test: fast/js/navigator-language.html
- platform/gtk/Language.cpp: (WebCore::defaultLanguage):
- 15:40 Changeset [50243] by
-
Should not generate/build COM DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=30880
Reviewed by Sam "Horatio" Weinig.
* Interfaces/WebKit.idl: Remove generated interfaces.
* WebKit.vcproj/InterfacesGenerated.vcproj: Removed.
* WebKit.vcproj/WebKit.sln: Remove InterfacesGenerated.vcproj.
* WebKit.vcproj/WebKit.submit.sln: Remove InterfacesGenerated.vcproj.
* WebKit.vcproj/WebKit.vcproj: Remove generated interfaces.
- 15:36 Changeset [50242] by
-
2009-10-28 Eric Carlson < eric.carlson@apple.com>
Reviewed by Simon Fraser.
< rdar://problem/7303145>
Can't exit full screen mode or restart movie after pressing command -R.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::removedFromDocument): (WebCore::HTMLMediaElement::documentWillBecomeInactive):
Exit from fullscreen if necessary.
- html/HTMLMediaElement.h:
2009-10-28 Eric Carlson < eric.carlson@apple.com>
Reviewed by Simon Fraser.
< rdar://problem/7303145>
Can't exit full screen mode or restart movie after pressing command -R.
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController _requestExit]):
New, call media element's exitFullscreen method.
(-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
Call mediaElement->exitFullscreen() after a delay as it turns around and calls
WebVideoFullscreenController:exitFullscreen.
- WebView/WebVideoFullscreenHUDWindowController.h:
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
New, don't give up responder status.
(-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
New, block all command key events.
(-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
Remember when we are in the process of exiting fullscreen, don't allow recursion.
- WebView/WebView.mm: (-[WebView _exitFullscreen]):
Early return if fullscreen controller is nil.
- WebView/WebWindowAnimation.h:
Correct comment about _window retain status.
- WebView/WebWindowAnimation.m: (-[WebWindowScaleAnimation dealloc]):
Don't release _window, we never reatained it.
- 15:19 Changeset [50241] by
-
2009-10-28 Shinichiro Hamaji < hamaji@chromium.org>
Reviewed by Eric Seidel.
[Qt] WebFrame::counterValueForElementById must not be exposed
https://bugs.webkit.org/show_bug.cgi?id=30882
- Api/qwebframe.cpp: (qt_drt_counterValueForElementById):
- Api/qwebframe.h:
2009-10-28 Shinichiro Hamaji < hamaji@chromium.org>
Reviewed by Eric Seidel.
[Qt] WebFrame::counterValueForElementById must not be exposed
https://bugs.webkit.org/show_bug.cgi?id=30882
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::counterValueForElementById):
- 14:45 Changeset [50240] by
-
Unreviewed - a trivial fix to get Windows bots running.
https://bugs.webkit.org/show_bug.cgi?id=30841
< rdar://problem/7342730> WebKit should not pass Referer header through a redirect to a non-secure site
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::setHeaderFields): Don't try to access empty vector's data.
- 14:44 Changeset [50239] by
-
2009-10-28 Afonso R. Costa Jr. < afonso.costa@openbossa.org>
Reviewed by Oliver Hunt.
[Qt] Enable YARR when YARR_JIT is enabled
https://bugs.webkit.org/show_bug.cgi?id=30730
When enabling or disabling JIT using JAVASCRIPTCORE_JIT, the ENABLE_YARR should
be toggled also.
- JavaScriptCore.pri:
- 14:36 Changeset [50238] by
-
2009-10-28 Joanmarie Diggs < joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25897
[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
Remove the extraneous object of ROLE_PANEL.
- accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
- 14:29 Changeset [50237] by
-
2009-10-28 Jonathan Dixon < joth@chromium.org>
Reviewed by Eric Seidel.
Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius
https://bugs.webkit.org/show_bug.cgi?id=30547
- fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.
- fast/css/text-input-with-webkit-border-radius-expected.png: Added.
- fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
- fast/css/text-input-with-webkit-border-radius.html: Added.
2009-10-28 Jonathan Dixon < joth@chromium.org>
Reviewed by Eric Seidel.
Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius
https://bugs.webkit.org/show_bug.cgi?id=30547
Test: fast/css/text-input-with-webkit-border-radius.html
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): Implemented rounded border rendering in Chromium Windows theme renderer.
- 14:17 Changeset [50236] by
-
2009-10-28 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Pull items collections from resources panel and
timeline panel into AbstractTimelinePanel.
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel): (WebInspector.AbstractTimelinePanel.prototype.populateSidebar): (WebInspector.AbstractTimelinePanel.prototype.createItemTreeElement): (WebInspector.AbstractTimelinePanel.prototype.createItemGraph): (WebInspector.AbstractTimelinePanel.prototype._showCategory): (WebInspector.AbstractTimelinePanel.prototype._hideCategory): (WebInspector.AbstractTimelinePanel.prototype.filter): (WebInspector.AbstractTimelinePanel.prototype._createGraph): (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth): (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelinePanel.prototype.reset): (WebInspector.AbstractTimelinePanel.prototype.get calculator): (WebInspector.AbstractTimelinePanel.prototype.set calculator): (WebInspector.AbstractTimelinePanel.prototype.addItem): (WebInspector.AbstractTimelinePanel.prototype.removeItem): (WebInspector.AbstractTimelinePanel.prototype.refreshItem): (WebInspector.AbstractTimelinePanel.prototype.revealAndSelectItem): (WebInspector.AbstractTimelinePanel.prototype.sortItems): (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition): (WebInspector.AbstractTimelineCategory): (WebInspector.AbstractTimelineCategory.prototype.toString):
- inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.createItemTreeElement): (WebInspector.ResourcesPanel.prototype.createItemGraph): (WebInspector.ResourcesPanel.prototype.isCategoryVisible): (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourcesPanel.prototype.get searchableViews): (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction.sortFuction): (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction): (WebInspector.ResourcesPanel.prototype.searchMatchFound): (WebInspector.ResourcesPanel.prototype.searchCanceled): (WebInspector.ResourcesPanel.prototype.performSearch): (WebInspector.ResourcesPanel.prototype.refresh): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.removeResource): (WebInspector.ResourcesPanel.prototype.addMessageToResource): (WebInspector.ResourcesPanel.prototype.clearMessages): (WebInspector.ResourcesPanel.prototype.refreshResource): (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded): (WebInspector.ResourcesPanel.prototype._toggleLargerResources): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking): (WebInspector.ResourcesPanel.prototype.get _resources): (WebInspector.ResourceTimeCalculator.prototype._upperBound):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get categories): (WebInspector.TimelinePanel.prototype.populateSidebar): (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype.createItemTreeElement): (WebInspector.TimelinePanel.prototype.createItemGraph): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelineCategory):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- 14:05 Changeset [50235] by
-
Rubberstamped by Oliver Hunt.
Patch by Kenneth Rohde Christiansen < kenneth@webkit.org> on 2009-10-28
Fix the warning:
"warning: ignoring return value of 'char* getcwd(char*, size_t)',
declared with attribute warn_unused_result".
by actually checking the result. In the case it is null, an
error has occoured, so treat it as the other fatal errors.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::initializeFonts):
- 13:45 Changeset [50234] by
-
2009-10-28 Kelly Norton < knorton@google.com>
Reviewed by Pavel Feldman.
Resets InspectorFrontend in InspectorTimelineAgent instead of removing it so
that it remains active on refreshs and page transitions.
https://bugs.webkit.org/show_bug.cgi?id=30874
- inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::resetFrontendProxyObject):
- inspector/InspectorTimelineAgent.h:
- 13:14 Changeset [50233] by
-
2009-10-27 Shinichiro Hamaji < hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555
- Api/qwebframe.cpp: (QWebFrame::counterValueForElementById): (QWebHitTestResult::frame):
- Api/qwebframe.h:
2009-10-27 Shinichiro Hamaji < hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_counter_value_for_element_by_id):
2009-10-27 Shinichiro Hamaji < hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp: (WebFrame::counterValueForElementById):
- WebFrame.h:
2009-10-27 Shinichiro Hamaji < hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555
Add counterValueForElement in WebFrame to call WebCore::counterValueForElement.
- Misc/WebCoreStatistics.h:
- Misc/WebCoreStatistics.mm: (-[WebFrame counterValueForElement:]):
2009-10-27 Shinichiro Hamaji < hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555
Expose WebCore::counterValueForElement as a WebCore API.
- WebCore.base.exp:
- rendering/RenderTreeAsText.cpp: (WebCore::writeCounterValuesFromChildren): (WebCore::counterValueForElement):
- rendering/RenderTreeAsText.h:
2009-10-27 Shinichiro Hamaji < hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555
Convert two pixel tests to dumpAsText tests using counterValueForElementById.
- fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
- fast/css/counters/t1204-increment-00-c-o.html:
- fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.
- fast/css/counters/t1204-increment-01-c-o.html:
- platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.checksum: Removed.
- platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.png: Removed.
- platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.txt: Removed.
- platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.checksum: Removed.
- platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.png: Removed.
- platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.txt: Removed.
- platform/qt/fast/css/counters/t1204-increment-00-c-o-expected.txt: Removed.
- platform/qt/fast/css/counters/t1204-increment-01-c-o-expected.txt: Removed.
2009-10-27 Shinichiro Hamaji < hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555
Define layoutTestContoller.counterValueForElementById.
- DumpRenderTree/LayoutTestController.cpp: (counterValueForElementByIdCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::counterValueForElementById):
- 13:07 Changeset [50232] by
-
2009-10-24 Martin Robinson < martin.james.robinson@gmail.com>
Reviewed by Oliver Hunt.
Fix strict aliasing warning by switching reinterpret_cast to bitwise_cast.
strict-aliasing warnings in JSFunction.h
https://bugs.webkit.org/show_bug.cgi?id=27869
- runtime/JSFunction.h: (JSC::JSFunction::nativeFunction): (JSC::JSFunction::scopeChain): (JSC::JSFunction::setScopeChain): (JSC::JSFunction::setNativeFunction):
- 12:57 Changeset [50231] by
-
2009-10-28 Nate Chapin < japhet@chromium.org>
Unreviewed, Chromium build fix for r50225.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType):
- 12:52 Changeset [50230] by
-
2009-10-28 Eric Z. Ayers < zundel@google.com>
Reviewed by Pavel Feldman.
Adds InspectorTimelineAgent instrumentation for encountering a
<SCRIPT> tag when parsing an HTML document.
- bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::startLine): (WebCore::ScriptSourceCode::url):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::willScriptTag): (WebCore::InspectorTimelineAgent::didScriptTag):
- inspector/InspectorTimelineAgent.h: (WebCore::):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createScriptTagTimelineRecord):
- inspector/TimelineRecordFactory.h:
- inspector/front-end/TimelineAgent.js:
- 12:23 Changeset [50229] by
-
2009-10-28 Steve Block < steveblock@google.com>
Reviewed by Darin Adler.
Makes sure that Geolocation watch IDs remain positive on overflow.
https://bugs.webkit.org/show_bug.cgi?id=30122
No new tests possible.
- page/Geolocation.cpp: Modified. (WebCore::Geolocation::watchPosition): Modified. Reset the watch ID to 1 on overflow.
- 12:03 Changeset [50228] by
-
2009-10-28 George Staikos < george.staikos@torchmobile.com>
Attempt to fix the Mac debug build after 50225.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType):
- 11:35 Changeset [50227] by
-
Windows build fix, add missing #include.
- 11:15 Changeset [50226] by
-
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30841
< rdar://problem/7342730> WebKit should not pass Referer header through a redirect to a non-secure site
Tests: http/tests/ssl/referer-301.html
http/tests/ssl/referer-303.html
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Remove Referer header if redirecting from https to another protocol.
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::clearHTTPReferrer): Update request counterparts, as it is always done when changing or adding header fields. (WebCore::ResourceRequestBase::clearHTTPOrigin): Ditto.
- platform/network/ResourceRequestBase.h: clearHTTPReferrer() and clearHTTPOrigin() are no longer inline, since they have non-trivial implementations.
- platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Fixed to synchronize header field removals. (WebCore::ResourceRequest::doUpdateResourceRequest): Ditto.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest):
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::setHeaderFields): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest): Match Mac changes.
- 11:12 Changeset [50225] by
-
2009-10-28 Joe Mason < jmason@rim.com>
Reviewed by Adam Treat.
Add FrameLoader::defaultObjectContentType, containing common code for
implementing FrameLoaderClient::objectContentType. (Currently the gtk
and win ports have copied this code, and the qt port uses similar code
with a few extra clauses. Moving this to a utility function cuts down
on copied code.) This causes no behavioural change.
- 11:00 Changeset [50224] by
-
[Qt] QWebHistory::saveState() is inconsistent with the Qt API
https://bugs.webkit.org/show_bug.cgi?id=30710
Patch by Kenneth Rohde Christiansen < kenneth@webkit.org> on 2009-10-28
Reviewed by Tor Arne Vestbø.
WebCore:
Enforce the versioning, by ignoring any version different
from 1.
* history/qt/HistoryItemQt.cpp:
(WebCore::HistoryItem::restoreState):
(WebCore::HistoryItem::saveState):
WebKit/qt:
Make the versioning internal and enforce it in the WebCore
part. Adjust the comments, as well as remove now dead code.
* Api/qwebhistory.cpp:
(operator<<):
(operator>>):
* Api/qwebhistory.h:
- 10:10 Changeset [50223] by
-
2009-10-28 Shu Chang < Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
Added special expected test result for Tiger to fix regression tests.
https://bugs.webkit.org/show_bug.cgi?id=30811
- platform/mac-tiger/fast/js/navigator-language-expected.txt: Added.
- 10:09 Changeset [50222] by
-
2009-10-28 Pavel Feldman < pfeldman@chromium.org>
Not reviewed: follow up fix to InspectorControllerStub.
Define it after inspector.js due to namespace
- inspector/front-end/inspector.html:
- 10:03 Changeset [50221] by
-
2009-10-28 Pavel Feldman < pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add InspectorController stub in order to
support opening in standalone mode.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/InspectorControllerStub.js: Added. (.WebInspector.InspectorControllerStub):
- 10:02 Changeset [50220] by
-
2009-10-28 Joanmarie Diggs < joanmarie.diggs@gmail.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25897
[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
Expands upon the new funtionality which allows platforms to indicate
that a particular object should not be ignored, so that they can
specify that an object should be ignored or that it should be left up
to the default handling to decide.
- accessibility/AccessibilityObject.h:
- accessibility/chromium/AccessibilityObjectChromium.cpp:
- accessibility/gtk/AccessibilityObjectAtk.cpp:
- accessibility/mac/AccessibilityObjectMac.mm:
- accessibility/qt/AccessibilityObjectQt.cpp:
- accessibility/win/AccessibilityObjectWin.cpp:
- accessibility/wx/AccessibilityObjectWx.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::accessibilityIsIgnored):
- 09:53 Changeset [50219] by
-
2009-10-28 Joanmarie Diggs < joanmarie.diggs@gmail.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25534
[GTK] Objects of ROLE_TABLE should implement the accessible table interface
Expose the table summary as the accessible description because there is no summary object.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_description):
- 09:14 Changeset [50218] by
-
Use JSVALUE64 on 64-bit Windows
Patch by Jan-Arve Sæther < jan-arve.saether@nokia.com> on 2009-10-28
Reviewed by Tor Arne Vestbø.
* wtf/Platform.h: Make sure WTF_USE_JSVALUE64 is defined
- 08:10 Changeset [50217] by
-
Pushing missing WebKit/qt/tests/qwebframe/resources/ dir from bug 29248.
Patch by Antonio Gomes < tonikitoo@webkit.org> on 2009-10-28
[Qt] [API] Make it possible to have 'invisible' loads
https://bugs.webkit.org/show_bug.cgi?id=29248
* tests/qwebframe/resources/image2.png: Copied from WebKit/qt/tests/qwebelement/image.png.
- 06:54 Changeset [50216] by
-
Rubber-stamped by Holger Freyther.
Patch by Csaba Osztrogonác < ossy@webkit.org> on 2009-10-28
[Qt] Remove http/tests/security tests from
skiplist, and add only now failing tests.
* platform/qt/Skipped:
- 06:54 Changeset [50215] by
-
Adds ScriptController::intializeThreading(), with both JSC and V8 implementations.
https://bugs.webkit.org/show_bug.cgi?id=30678
Reviewed by Eric Seidel.
This new method is used from common code, rather than calling JSC::initializeThreading() (or the V8 equivalent) directly.
Build fix, no new tests required.
* bindings/js/ScriptController.cpp: Modified.
(WebCore::ScriptController::initializeThreading): Added.
* bindings/js/ScriptController.h: Modified. Adds ScriptController::initializeThreading().
* bindings/v8/ScriptController.cpp: Modified.
(WebCore::ScriptController::initializeThreading): Added.
* bindings/v8/ScriptController.h: Modified. Adds ScriptController::initializeThreading().
* loader/icon/IconDatabase.cpp: Modified.
(WebCore::iconDatabase): Call ScriptController::initializeThreading(), rather than JSC::initializeThreading().
* storage/Database.cpp: Modified.
(WebCore::Database::Database): Call ScriptController::initializeThreading(), rather than JSC::initializeThreading().
- 06:18 Changeset [50214] by
-
[Qt] QWebHistory::saveState() is inconsistent with the Qt API
https://bugs.webkit.org/show_bug.cgi?id=30710
Patch by Kenneth Rohde Christiansen < kenneth@webkit.org> on 2009-10-28
Reviewed by Holger Freyther.
Remove the QWebHistory::saveState() and ::restoreState() as
they are inconsistent with the Qt API.
Update unittests to reflect the change.
* Api/qwebhistory.cpp:
(operator<<):
(operator>>):
* Api/qwebhistory.h:
* tests/qwebhistory/tst_qwebhistory.cpp:
(saveHistory):
(restoreHistory):
(tst_QWebHistory::saveAndRestore_crash_1):
(tst_QWebHistory::saveAndRestore_crash_2):
(tst_QWebHistory::saveAndRestore_crash_3):
(tst_QWebHistory::clear):
- 04:44 Changeset [50213] by
-
Document a feature of the m_liveDecodedResources list.
https://bugs.webkit.org/show_bug.cgi?id=30209
Reviewed by Darin Adler.
Document a feature of the m_liveDecodedResources list.
https://bugs.webkit.org/show_bug.cgi?id=30209
The code made the assumption that the list is sorted by
the m_lastDecodedAccessTime property of the CachedResource.
The above is not true when CachedResource::setDecodedSize
is called and the item is inserted the first time. In this
case the m_lastDecodedAccessTime is still zero and the
m_liveDecodedResources list becomes unsorted.
It is impossible that Cache::pruneLiveResources will
stop to process the list too early due this feature and
the alternatives of updating m_lastDecodedAccessTime in
CachedResource::setDecodedSize or changing the insert
to search the right position have a negative impact on
performance. The best solution for now is to document
this feature.
* loader/Cache.cpp:
(WebCore::Cache::pruneLiveResources):
* loader/CachedResource.cpp:
(WebCore::CachedResource::setDecodedSize):
- 04:24 Changeset [50212] by
-
Speculative build-fix for WebElementPropertyBag.cpp
* WebElementPropertyBag.cpp: Include RenderObject.h
- 04:06 Changeset [50211] by
-
* jit/JIT.h:
Reviewed by NOBODY (build fix!).
- 04:05 Changeset [50210] by
-
[Qt] Remove http/tests/misc tests from
skiplist, and add only now failing tests.
Patch by Csaba Osztrogonác < ossy@webkit.org> on 2009-10-28
* platform/qt/Skipped:
- 03:23 Changeset [50209] by
-
Complementary fix to bug 30779.
Patch by Antonio Gomes < tonikitoo@webkit.org> on 2009-10-27
Reviewed by Holger Freyther.
By mistake I used QWeakPointer's toStrongRef() method which docs
explicitly say to not be used in this situation (when the tracked
pointer is devired from QObject). Instead QWeakPointer's data()
is recommended.
* Api/qwebpage.cpp:
(QWebPage::view):
- 03:18 Changeset [50208] by
-
WebCore:
2009-10-28 Xan Lopez < xlopez@igalia.com>
Reviewed by Jan Alonzo.
[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
https://bugs.webkit.org/show_bug.cgi?id=25897
Make text controls always implement the text interface, and the
editable text interface when they are not read only. This is what
ATK-users expect.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getInterfaceMaskFromObject):
WebKit/gtk:
2009-10-28 Xan Lopez < xlopez@igalia.com>
Reviewed by Jan Alonzo.
[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
https://bugs.webkit.org/show_bug.cgi?id=25897
Update test to also check that entries implement the AtkText
interface.
- tests/testatk.c: (run_get_text_tests): (test_webkit_atk_get_text_at_offset_forms): (test_webkit_atk_get_text_at_offset): (main):
- 03:16 Changeset [50207] by
-
Fix assertion in SVGRenderBase::mapLocalToContainer resulting from HitTestResult::boundinBox()
https://bugs.webkit.org/show_bug.cgi?id=27347
The current HitTestResult methods are not using the (3d)
transformation aware routines. This can lead to an assertion
SVGRenderBase::mapLocalToContainer method.
Remove HitTestResult::boundingBox() as it is only used in
two places and conceptually doesn't belong into a HitTest
which is operating on points. Update the Qt and Win code
to determine the rect themselves in a (3d) transformation
fashion.
Change HitTestResult::imageRect to use the (3d) transformation
aware RenderBox::absoluteContentQuad to avoid running into
an assertion with SVG content.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::imageRect):
* rendering/HitTestResult.h:
* WebElementPropertyBag.cpp:
(WebElementPropertyBag::Read):
* Api/qwebframe.cpp:
(QWebHitTestResultPrivate::QWebHitTestResultPrivate):
- 03:16 Changeset [50206] by
-
[Qt] Custom Cursor doesn't use hotspot.
Cursors loaded from a QPixmap didn't specifiy the
hotspot. Take the hotspot values from the mac
implementation.
* platform/qt/CursorQt.cpp:
- 03:16 Changeset [50205] by
-
Export fastMalloc, fastCalloc, fastRealloc and fastFree
Export the FastMalloc functions outside of the libwebkit library
to be able to instrument memory allocations. These are C++ symbols
but do not require the C++ runtime to be useful and should be of
no harm to plain C code.
* autotools/symbols.filter:
- 03:14 Changeset [50204] by
-
Export fastMalloc, fastCalloc, fastRealloc and fastFree on GCC/Unix
https://bugs.webkit.org/show_bug.cgi?id=30769
When using -fvisibility=hidden to hide all internal symbols by default
the malloc symbols will be hidden as well. For memory instrumentation
it is needed to provide an instrumented version of these symbols and
override the normal routines and by changing the visibility back to
default this becomes possible.
The only other solution would be to use system malloc instead of the
TCmalloc implementation but this will not allow to analyze memory
behavior with the default allocator.
* wtf/FastMalloc.h: Define WTF_FAST_MALLOC_EXPORT for GCC and !darwin
- 02:59 Changeset [50203] by
-
2009-10-27 Pavel Feldman < pfeldman@chromium.org>
Reviewed by NOBODY (OOPS!).
Web Inspector: Initial revision of the Timeline grid.
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.populateSidebar): (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelineCalculator):
- inspector/front-end/Images/timelineBarBlue.png: Added.
- inspector/front-end/Images/timelineBarGray.png: Added.
- inspector/front-end/Images/timelineBarGreen.png: Added.
- inspector/front-end/Images/timelineBarOrange.png: Added.
- inspector/front-end/Images/timelineBarPurple.png: Added.
- inspector/front-end/Images/timelineBarRed.png: Added.
- inspector/front-end/Images/timelineBarYellow.png: Added.
- inspector/front-end/Images/timelineCheckmarks.png: Added.
- inspector/front-end/Images/timelineDots.png: Added.
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceTimeCalculator): (WebInspector.ResourceTransferSizeCalculator):
- inspector/front-end/TimelineAgent.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype.get categories): (WebInspector.TimelinePanel.prototype.populateSidebar): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype.addItemToTimeline): (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClick): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype.showCategory): (WebInspector.TimelinePanel.prototype.hideCategory): (WebInspector.TimelineRecordTreeElement): (WebInspector.TimelineRecordTreeElement.prototype.onattach): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.computePercentageFromEventTime): (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.formatValue): (WebInspector.TimelineGraph): (WebInspector.TimelineGraph.prototype.get graphElement): (WebInspector.TimelineGraph.prototype.refreshLabelPositions): (WebInspector.TimelineGraph.prototype.refresh):
- inspector/front-end/inspector.css:
