Timeline


and

11/03/09:

23:50 Changeset [50500] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

2009-11-03 Yuzo Fujishima <yuzo@google.com>

Reviewed by David Levin.

Start/Stop Web Socket and Web Socket Secure servers for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27491

The test path determination logic is changed to handle websocket and websocket/ssl cases.
The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.

Functions to start or stop Web Socket servers are added.

  • Scripts/run-webkit-tests:
22:09 Changeset [50499] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed build fix for WebInspector with Qt build.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-03
Simply re-generate the Qt resource file by running
WebKitTools/Scripts/generate-qt-inspector-resource

  • inspector/front-end/WebKit.qrc:
21:52 Changeset [50498] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

(on IRC)

Reviewed by Mark Rowe.

add ruby layout tests to the Skipped list on mac, since they somehow cause
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html to fail.

no new tests.

  • platform/mac/Skipped:
20:29 Changeset [50497] by darin@apple.com
  • 190 edits in trunk/WebKitSite

Set the MIME type for all PNG files in this directory.

WebKitSite:

Patch by Darin Adler <darin@apple.com> on 2009-11-03

  • blog-files/3d-transforms/mighty-cubes.png: Added property svn:mime-type.
  • blog-files/3d-transforms/poster-circle.png: Added property svn:mime-type.
  • blog-files/InspectorDatabaseBrowser.png: Modified property svn:mime-type.
  • blog-files/acid3-100.png: Modified property svn:mime-type.
  • blog-files/acid3-full-rendering-pass.png: Modified property svn:mime-type.
  • blog-files/acid3-rendering-reference.png: Modified property svn:mime-type.
  • blog-files/acid3-screenshot.png: Modified property svn:mime-type.
  • blog-files/acid3-timing-screenshot.png: Modified property svn:mime-type.
  • blog-files/acid3-timing.png: Modified property svn:mime-type.
  • blog-files/bounce.png: Added property svn:mime-type.
  • blog-files/gebcnwebkitonly.png: Modified property svn:mime-type.
  • blog-files/inspector-closure-scope.png: Added property svn:mime-type.
  • blog-files/inspector-console-autocomplete.png: Added property svn:mime-type.
  • blog-files/inspector-databases-panel-query-view.png: Added property svn:mime-type.
  • blog-files/inspector-databases-panel.png: Added property svn:mime-type.
  • blog-files/inspector-disabling-properties.png: Added property svn:mime-type.
  • blog-files/inspector-elements-panel.png: Added property svn:mime-type.
  • blog-files/inspector-event-scope.png: Added property svn:mime-type.
  • blog-files/inspector-profiles-panel.png: Added property svn:mime-type.
  • blog-files/inspector-resources-panel.png: Added property svn:mime-type.
  • blog-files/inspector-scripts-panel.png: Added property svn:mime-type.
  • blog-files/inspector-searching-elements.png: Added property svn:mime-type.
  • blog-files/inspector-searching-profiles.png: Added property svn:mime-type.
  • blog-files/inspector-status-bar-with-errors.png: Added property svn:mime-type.
  • blog-files/inspector-toolbar.png: Added property svn:mime-type.
  • blog-files/inspector-with-scope.png: Added property svn:mime-type.
  • blog-files/inspector/breakpoints.png: Added property svn:mime-type.
  • blog-files/inspector/colors.png: Added property svn:mime-type.
  • blog-files/inspector/cookies.png: Added property svn:mime-type.
  • blog-files/inspector/css_selectors.png: Added property svn:mime-type.
  • blog-files/inspector/css_syntax_highlight.png: Added property svn:mime-type.
  • blog-files/inspector/dom_storage.png: Added property svn:mime-type.
  • blog-files/inspector/edit_attributes.png: Added property svn:mime-type.
  • blog-files/inspector/enable.png: Added property svn:mime-type.
  • blog-files/inspector/event_listeners.png: Added property svn:mime-type.
  • blog-files/inspector/form_data.png: Added property svn:mime-type.
  • blog-files/inspector/inline_highlight.png: Added property svn:mime-type.
  • blog-files/inspector/inorder.png: Added property svn:mime-type.
  • blog-files/inspector/inspect_inspector.png: Added property svn:mime-type.
  • blog-files/inspector/inspect_inspector_small.png: Added property svn:mime-type.
  • blog-files/inspector/load_lines.png: Added property svn:mime-type.
  • blog-files/inspector/nodelist.png: Added property svn:mime-type.
  • blog-files/inspector/scope_bar.png: Added property svn:mime-type.
  • blog-files/inspector/watched_expression.png: Added property svn:mime-type.
  • blog-files/kate-circle.png: Modified property svn:mime-type.
  • blog-files/kate-gradient-rounded.png: Modified property svn:mime-type.
  • blog-files/kate-gradient.png: Modified property svn:mime-type.
  • blog-files/kate-reflected.png: Modified property svn:mime-type.
  • blog-files/kate-vignette-mask.png: Modified property svn:mime-type.
  • blog-files/kate.png: Modified property svn:mime-type.
  • blog-files/leaves/images/apple-touch-icon.png: Added property svn:mime-type.
  • blog-files/leaves/images/realLeaf1.png: Added property svn:mime-type.
  • blog-files/leaves/images/realLeaf2.png: Added property svn:mime-type.
  • blog-files/leaves/images/realLeaf3.png: Added property svn:mime-type.
  • blog-files/leaves/images/realLeaf4.png: Added property svn:mime-type.
  • blog-files/leaves/images/textBackground.png: Added property svn:mime-type.
  • blog-files/maskspeedracer.png: Modified property svn:mime-type.
  • blog-files/pulse.png: Added property svn:mime-type.
  • blog-files/scrollbarpicture.png: Modified property svn:mime-type.
  • blog-files/sfx-perf.png: Modified property svn:mime-type.
  • blog-files/squirrelfish-webkit-graph.png: Modified property svn:mime-type.
  • blog-files/squirrelfish.png: Modified property svn:mime-type.
  • blog-files/vignette-mask.png: Modified property svn:mime-type.
  • blog-files/webgl/resources/mars500x250.png: Modified property svn:mime-type.
  • blog-files/wsj-nopreload.png: Modified property svn:mime-type.
  • blog-files/wsj-preload.png: Modified property svn:mime-type.
  • blog-files/wsj-vs.png: Modified property svn:mime-type.
  • blog/wp-admin/images/align-center.png: Added property svn:mime-type.
  • blog/wp-admin/images/align-left.png: Added property svn:mime-type.
  • blog/wp-admin/images/align-none.png: Added property svn:mime-type.
  • blog/wp-admin/images/align-right.png: Added property svn:mime-type.
  • blog/wp-admin/images/archive-link.png: Added property svn:mime-type.
  • blog/wp-admin/images/blue-grad.png: Added property svn:mime-type.
  • blog/wp-admin/images/button-grad-active-vs.png: Added property svn:mime-type.
  • blog/wp-admin/images/button-grad-active.png: Added property svn:mime-type.
  • blog/wp-admin/images/button-grad-vs.png: Added property svn:mime-type.
  • blog/wp-admin/images/button-grad.png: Added property svn:mime-type.
  • blog/wp-admin/images/comment-grey-bubble.png: Added property svn:mime-type.
  • blog/wp-admin/images/fade-butt.png: Modified property svn:mime-type.
  • blog/wp-admin/images/fav-top.png: Added property svn:mime-type.
  • blog/wp-admin/images/fav-vs.png: Added property svn:mime-type.
  • blog/wp-admin/images/fav.png: Added property svn:mime-type.
  • blog/wp-admin/images/generic.png: Added property svn:mime-type.
  • blog/wp-admin/images/gray-grad.png: Added property svn:mime-type.
  • blog/wp-admin/images/icons32-vs.png: Added property svn:mime-type.
  • blog/wp-admin/images/icons32.png: Added property svn:mime-type.
  • blog/wp-admin/images/list-vs.png: Added property svn:mime-type.
  • blog/wp-admin/images/list.png: Added property svn:mime-type.
  • blog/wp-admin/images/logo-ghost.png: Added property svn:mime-type.
  • blog/wp-admin/images/marker.png: Added property svn:mime-type.
  • blog/wp-admin/images/mask.png: Added property svn:mime-type.
  • blog/wp-admin/images/menu-vs.png: Added property svn:mime-type.
  • blog/wp-admin/images/menu.png: Added property svn:mime-type.
  • blog/wp-admin/images/no.png: Added property svn:mime-type.
  • blog/wp-admin/images/se.png: Added property svn:mime-type.
  • blog/wp-admin/images/wheel.png: Added property svn:mime-type.
  • blog/wp-admin/images/white-grad-active.png: Added property svn:mime-type.
  • blog/wp-admin/images/white-grad.png: Added property svn:mime-type.
  • blog/wp-admin/images/wordpress-logo.png: Modified property svn:mime-type.
  • blog/wp-admin/images/yes.png: Added property svn:mime-type.
  • blog/wp-content/Picture9.png: Modified property svn:mime-type.
  • blog/wp-content/chucknorris.png: Modified property svn:mime-type.
  • blog/wp-content/databaseexample.png: Modified property svn:mime-type.
  • blog/wp-content/drosera.png: Modified property svn:mime-type.
  • blog/wp-content/hitlist.png: Modified property svn:mime-type.
  • blog/wp-content/rotate.png: Modified property svn:mime-type.
  • blog/wp-content/svgtext.png: Modified property svn:mime-type.
  • blog/wp-content/svgtextmini.png: Modified property svn:mime-type.
  • blog/wp-content/svgtextmini_01.png: Modified property svn:mime-type.
  • blog/wp-content/themes/classic/screenshot.png: Modified property svn:mime-type.
  • blog/wp-content/themes/default/screenshot.png: Modified property svn:mime-type.
  • blog/wp-content/uploads/2007/06/newinspector.png: Modified property svn:mime-type.
  • blog/wp-content/webInspector.png: Modified property svn:mime-type.
  • blog/wp-includes/images/crystal/archive.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/audio.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/code.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/default.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/document.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/interactive.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/spreadsheet.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/text.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/video.png: Added property svn:mime-type.
  • blog/wp-includes/images/rss.png: Modified property svn:mime-type.
  • blog/wp-includes/images/upload.png: Added property svn:mime-type.
  • blog/wp-includes/images/wlw/wp-comments.png: Added property svn:mime-type.
  • blog/wp-includes/images/wlw/wp-icon.png: Added property svn:mime-type.
  • blog/wp-includes/images/wlw/wp-watermark.png: Added property svn:mime-type.
  • blog/wp-includes/js/codepress/images/line-numbers.png: Added property svn:mime-type.
  • blog/wp-includes/js/thickbox/macFFBgHack.png: Added property svn:mime-type.
  • blog/wp-includes/js/thickbox/tb-close.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/plugins/wpeditimage/img/delete.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/plugins/wpeditimage/img/image.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/plugins/wpgallery/img/delete.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/plugins/wpgallery/img/edit.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/plugins/wpgallery/img/gallery.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/img/gotmoxie.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/img/sflogo.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/skins/default/img/buttons.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg_black.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg_silver.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/skins/wp_theme/img/butt2.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/skins/wp_theme/img/button_bg.png: Added property svn:mime-type.
  • demos/calendar/Images/AirPort4.png: Modified property svn:mime-type.
  • demos/calendar/Images/AirPortError.png: Modified property svn:mime-type.
  • demos/calendar/Images/disclosureTriangleSmallDown.png: Modified property svn:mime-type.
  • demos/calendar/Images/disclosureTriangleSmallRight.png: Modified property svn:mime-type.
  • demos/calendar/Images/statusbarBackground.png: Modified property svn:mime-type.
  • demos/calendar/Images/statusbarResizerVertical.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/button.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/buttonLeft.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/buttonMiddle.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/buttonPressed.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/buttonPressedLeft.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/buttonPressedMiddle.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/buttonPressedRight.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/buttonRight.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/camera.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/link.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/textAlign.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutline.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottom.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomLeft.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomRight.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineLeft.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineRight.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineTop.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopLeft.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopRight.png: Modified property svn:mime-type.
  • demos/editingToolbar/images/safari.png: Modified property svn:mime-type.
  • demos/sticky-notes/deleteButton.png: Added property svn:mime-type.
  • demos/sticky-notes/deleteButtonPressed.png: Added property svn:mime-type.
  • demos/transitions-and-transforms/Horsehead.png: Modified property svn:mime-type.
  • demos/transitions-and-transforms/Spaces.png: Modified property svn:mime-type.
  • demos/transitions-and-transforms/Stacks.png: Modified property svn:mime-type.
  • images/DroseraPic.png: Modified property svn:mime-type.
  • misc/drosera/drosera.png: Modified property svn:mime-type.
  • perf/slickspeed/logo.png: Modified property svn:mime-type.

WebKitSite/specs/CSSVisualEffects:

Patch by Darin Adler <darin@apple.com> on 2009-11-03

  • css3-2d-transforms/compound_transform.png: Modified property svn:mime-type.
  • css3-2d-transforms/transform1.png: Modified property svn:mime-type.
  • css3-2d-transforms/transform2.png: Modified property svn:mime-type.
  • css3-3d-transforms/compound_transform.png: Modified property svn:mime-type.
  • css3-3d-transforms/transform1.png: Modified property svn:mime-type.
  • css3-3d-transforms/transform2.png: Modified property svn:mime-type.
  • css3-animations/animation1.png: Modified property svn:mime-type.
  • css3-animations/sandwich.png: Modified property svn:mime-type.
  • css3-transitions/TimingFunction.png: Modified property svn:mime-type.
  • css3-transitions/transition1.png: Modified property svn:mime-type.
19:37 Changeset [50496] by hausmann@webkit.org
  • 6 edits
    4 adds
    1 delete in trunk

WebCore: [Qt] Handle fonts like the other ports

Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2009-11-02
Reviewed by Simon Hausmann.

Remove FontFallbackListQt and rely on the common FontFallbackList
to handle the fonts. FontCache and FontPlatformData have been
updated to work with the common FontFallbackList.

In the previous implementation, FontPlatformDataCacheKey
was a clone of FontPlatformData with the hashing
capabilities added in order to use it as a key in the cache's
hashmap. FontPlatformData has been modified to handle the hashing
function directly so the data are not copied twice in memory.

FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
code from FontCache::getFontData() and FontFallbackList::fontDataAt().
The behavior is similar except currFamily->family().length() was
not tested and the fallback fonts selector were not used.

https://bugs.webkit.org/show_bug.cgi?id=29856

Test: svg/text/text-font-invalid.html

  • WebCore.pro:
  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::FontCache::platformInit):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/qt/FontFallbackListQt.cpp:

Removed. We now use the implementation from FontFallbackList.cpp

  • platform/graphics/qt/FontPlatformData.h:

Add hashing capabilities to be able to use the data with the FontCache.
This was previously done in FontCacheQt.cpp
(WebCore::FontPlatformData::FontPlatformData):
Added a boolean to identify deleted value in the hash table.
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):

  • platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):

LayoutTests: Add a new test to reproduce 29856. The bug only happen
when the SVG file is used as an image.
https://bugs.webkit.org/show_bug.cgi?id=29856

Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2009-11-02
Reviewed by Simon Hausmann.

  • svg/text/text-font-invalid-expected.txt: Added.
  • svg/text/resources/text-font-invalid.svg: Added.
  • svg/text/text-font-invalid.html: Added.
19:26 Changeset [50495] by rolandsteiner@chromium.org
  • 1 edit
    65 adds in trunk/LayoutTests

Bug 28420 - Implement HTML5 <ruby> rendering
(https://bugs.webkit.org/show_bug.cgi?id=28420)

Reviewed by Dave Hyatt.

First rudimentary implementation of HTML5 ruby rendering support - layout tests.

New layout tests: basic rendering:

  • fast/ruby/ruby-empty-rt.html: Added.
  • fast/ruby/ruby-length.html: Added.
  • fast/ruby/ruby-run-break.html: Added.
  • fast/ruby/ruby-runs-spans.html: Added.
  • fast/ruby/ruby-runs.html: Added.
  • fast/ruby/ruby-simple-rp.html: Added.
  • fast/ruby/ruby-simple.html: Added.
  • fast/ruby/ruby-trailing.html: Added.


New layout tests: DOM manipulation within <ruby>

  • fast/ruby/rubyDOM-insert-rt.html: Added.
  • fast/ruby/rubyDOM-insert-text1.html: Added.
  • fast/ruby/rubyDOM-insert-text2.html: Added.
  • fast/ruby/rubyDOM-insert-text3.html: Added.
  • fast/ruby/rubyDOM-remove-rt1.html: Added.
  • fast/ruby/rubyDOM-remove-rt2.html: Added.
  • fast/ruby/rubyDOM-remove-text1.html: Added.
  • fast/ruby/rubyDOM-remove-text2.html: Added.


New layout tests results:

  • platform/mac/fast/ruby: Added.
  • platform/mac/fast/ruby/ruby-empty-rt-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-empty-rt-expected.png: Added.
  • platform/mac/fast/ruby/ruby-empty-rt-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-length-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-length-expected.png: Added.
  • platform/mac/fast/ruby/ruby-length-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-run-break-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-run-break-expected.png: Added.
  • platform/mac/fast/ruby/ruby-run-break-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-runs-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-runs-expected.png: Added.
  • platform/mac/fast/ruby/ruby-runs-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-runs-spans-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-runs-spans-expected.png: Added.
  • platform/mac/fast/ruby/ruby-runs-spans-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-simple-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-simple-expected.png: Added.
  • platform/mac/fast/ruby/ruby-simple-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-simple-rp-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-simple-rp-expected.png: Added.
  • platform/mac/fast/ruby/ruby-simple-rp-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-trailing-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-trailing-expected.png: Added.
  • platform/mac/fast/ruby/ruby-trailing-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-text2-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-text2-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt: Added.
18:18 Web Inspector Update.ja created by casey.hattori@gmail.com
18:09 Changeset [50494] by joepeck@webkit.org
  • 1 edit
    19 adds in trunk/WebKitSite

2009-11-03 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Adding images for an upcoming blog post.

  • blog-files/inspector/breakpoints.png: Added.
  • blog-files/inspector/colors.png: Added.
  • blog-files/inspector/cookies.png: Added.
  • blog-files/inspector/css_selectors.png: Added.
  • blog-files/inspector/css_syntax_highlight.png: Added.
  • blog-files/inspector/dom_storage.png: Added.
  • blog-files/inspector/edit_attributes.png: Added.
  • blog-files/inspector/enable.png: Added.
  • blog-files/inspector/event_listeners.png: Added.
  • blog-files/inspector/form_data.png: Added.
  • blog-files/inspector/inline_highlight.png: Added.
  • blog-files/inspector/inorder.png: Added.
  • blog-files/inspector/inspect_inspector.png: Added.
  • blog-files/inspector/inspect_inspector_small.png: Added.
  • blog-files/inspector/load_lines.png: Added.
  • blog-files/inspector/nodelist.png: Added.
  • blog-files/inspector/scope_bar.png: Added.
  • blog-files/inspector/watched_expression.png: Added.
17:34 Changeset [50493] by mitz@apple.com
  • 2 edits in trunk/WebCore

Leopard build fix

  • platform/network/mac/AuthenticationMac.mm:

(WebCore::mac):
(WebCore::core):

17:25 Changeset [50492] by oliver@apple.com
  • 6 edits
    1 move in trunk/LayoutTests

2009-11-03 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Add overridePreference call to all WebGL layout tests
https://bugs.webkit.org/show_bug.cgi?id=31088

  • fast/canvas/webgl/array-unit-tests.html:
  • fast/canvas/webgl/getActiveTest.html:
  • fast/canvas/webgl/gl-get-calls.html:
  • fast/canvas/webgl/incorrect-context-object-behaviour.html:
  • fast/canvas/webgl/null-object-behaviour.html:
  • fast/canvas/webgl/resources/shader-test.js: Removed.
  • fast/canvas/webgl/resources/webgl-test.js: Copied from LayoutTests/fast/canvas/webgl/resources/shader-test.js.
17:11 Changeset [50491] by bweinstein@apple.com
  • 2 edits in trunk/WebKit/win

WebActionModifierFlagsKey should return an unsigned, because
flags imply a bitmask, and that is what other classes expect from
it.

Reviewed by Steve Falkenburg.

  • WebActionPropertyBag.cpp:

(WebActionPropertyBag::Read):

17:02 Changeset [50490] by mitz@apple.com
  • 2 edits in trunk/WebCore

Fix an assertion failure in core(NSURLProtectionSpace *) by handling NTLM
authentication in AuthenticationMac

Reviewed by Alexey Proskuryakov.

  • platform/network/mac/AuthenticationMac.mm:
16:00 Changeset [50489] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2009-11-03 Eric Z. Ayers <zundel@google.com>

Reviewed by Timothy Hatcher.

Adds a test for turning on the timeline profiler. This caused
a crash because profiling was enabled in the middle of processing
an event.

https://bugs.webkit.org/show_bug.cgi?id=31080

  • inspector/timeline-trivial-expected.txt: Added.
  • inspector/timeline-trivial.html: Added.

2009-11-03 Eric Z. Ayers <zundel@google.com>

Reviewed by Timothy Hatcher.

Fixes a problem where the timeline instrumentation crashes if
timeline profiling is enabled or disabled in the middle of an
event dispatch.

https://bugs.webkit.org/show_bug.cgi?id=31080

Test: inspector/timeline-trivial.html

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::processingUserGestureEvent):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
  • page/DOMTimer.cpp: (WebCore::DOMTimer::fired):
15:34 Changeset [50488] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-03 Eric Seidel <eric@webkit.org>

No review, just changing wording of log message.

Change log string to say "failed" instead of "rejected"
when a commit fails due to an out of date checkout.
This makes grepping the commit-queue log for rejected patches easier.

  • Scripts/bugzilla-tool:
14:14 Changeset [50487] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-03 Eric Seidel <eric@webkit.org>

No review, adding commonly known committers missing from the file.

  • Scripts/modules/committers.py: Add committers found by looking at SVN records.
14:07 Changeset [50486] by mitz@apple.com
  • 4 edits in trunk/WebCore

Allow a frame to go back to copy-on-scroll when it ceases being overlapped

Reviewed by Dave Hyatt.

The code was not testing slow-scrolling frames for overlappedness, thinking the answer
would not matter. That is not the case if the only reason for the slow-scrolling is
being overlapped.

  • page/FrameView.cpp:

(WebCore::FrameView::useSlowRepaintsIfNotOverlapped): Added. Returns whether there is any
reason besides being overlapped that the frame would need to fully repaint on scroll.

  • page/FrameView.h:
  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint): Use useSlowRepaintsIfNotOverlapped().

14:04 Changeset [50485] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-03 Eric Seidel <eric@webkit.org>

No review, just sort-order cleanup.

  • Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
14:04 Changeset [50484] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to try and fix Windows nightlies.

13:39 Changeset [50483] by dimich@chromium.org
  • 2 edits in trunk/WebCore

Not reviewed, Qt build fix.

Need to use right capitalization for include file.

  • page/Navigator.cpp:
13:34 Changeset [50482] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Migrate from top bar filters to check boxes in Timeline.

https://bugs.webkit.org/show_bug.cgi?id=31081

  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.showCategory): (WebInspector.AbstractTimelinePanel.prototype.hideCategory): (WebInspector.AbstractTimelinePanel.prototype.filter):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelineCategoryTreeElement.prototype.onattach): (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClick): (WebInspector.TimelineCategoryGraph.prototype.clearChunks): (WebInspector.TimelineCategoryGraph.prototype.set dimmed):
  • inspector/front-end/inspector.css:
13:30 Changeset [50481] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: clear overview on Clear action and panel reset.

https://bugs.webkit.org/show_bug.cgi?id=31078

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelinePanel.prototype.reset):
13:24 Changeset [50480] by eric@webkit.org
  • 2 edits
    9 adds in trunk/WebCore

2009-11-03 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Imported action and rules python files that WebCore.gyp depends on.
These files used to live in chromium.org and deal mostly with auto-generation
of code by wrapping existing webkit perl scripts.

https://bugs.webkit.org/show_bug.cgi?id=31071

  • WebCore.gyp/WebCore.gyp: Fixed paths in actions and rules.
  • WebCore.gyp/scripts/action_csspropertynames.py: Added.
  • WebCore.gyp/scripts/action_cssvaluekeywords.py: Added.
  • WebCore.gyp/scripts/action_makenames.py: Added.
  • WebCore.gyp/scripts/action_maketokenizer.py: Added.
  • WebCore.gyp/scripts/action_useragentstylesheets.py: Added.
  • WebCore.gyp/scripts/rule_binding.py: Added.
  • WebCore.gyp/scripts/rule_bison.py: Added.
  • WebCore.gyp/scripts/rule_gperf.py: Added.
13:18 Changeset [50479] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

13:18 Changeset [50478] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.21.9

New tag.

13:12 Changeset [50477] by dimich@chromium.org
  • 14 edits
    4 adds in trunk

WebCore: Implement window.navigator.registerProtocolHandler in webkit,
https://bugs.webkit.org/b/29651

Patch by Bradley Green <brg@chromium.org> on 2009-11-03
Reviewed by Dmitry Titov.

Also implemented its sister API window.navigator.registerContentHandler.

These methods are as described in the HTML5 specification which can be
found here,
http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler
http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registercontenthandler

As specified in the document, the behavior of the browser is determined
by the current registered handler. The state of a registered handler
can change at any time, with the user clearing a registered handler,
registering a different page as handler, or deferring the hander to the
OS. If webkit was to track the state of the currently registered
handlers, it would need more APIs and complexity to keep in sync with
user actions reported to webkit from the UA. For simplicity, the state
of protocol handlers should be kept isolated from webkit and webkit only
notifies the UA that a page has made the call. The UA is then
responsible for correctly handling the registerProtocolHandler call and
the redirects which result from registration.

We do however follow the specification in insuring that the reserved
schemes and mimeTypes are not passed to the UA as custom handler
registration tests. We also insure that the "%s" token is present as
required by the specification.

Updated test expectations for window.clientInformation and navigator
objects.

Tests: fast/dom/registerContentHandler.html

fast/dom/registerProtocolHandler.html

  • page/Chrome.cpp:

(WebCore::Chrome::registerProtocolHandler):
(WebCore::Chrome::registerContentHandler):

  • page/Chrome.h:
  • page/ChromeClient.h:

(WebCore::ChromeClient::registerProtocolHandler):
(WebCore::ChromeClient::registerContentHandler):

  • page/Navigator.cpp:

(WebCore::verifyCustomHandlerURL):
(WebCore::verifyProtocolHandlerScheme):
(WebCore::Navigator::registerProtocolHandler):
(WebCore::verifyProtocolHandlerMimeType):
(WebCore::Navigator::registerContentHandler):

  • page/Navigator.h:
  • page/Navigator.idl:

LayoutTests: Updating test expectations for implementation of
window.navigator.registerProtocolHandler and
window.navigator.registerContentHandler.

Patch by Bradley Green <brg@chromium.org> on 2009-11-03
Reviewed by Dmitry Titov.

There is a default implimentation for these APIs, hence all platforms
with the navigator-detached-no-crash-expect and
window-properties-expected tests needed to be updated. While
isolatedWorlds has a window-properties-expected test, it has no window
object and hence does not need to be updaetd.

We add two fast/dom tests to insure that the proper exceptions are
thrown when bad syntax or security violations are made by calling the
methods.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/navigator-detached-no-crash-expected.txt:
  • fast/dom/navigator-detached-no-crash.html:
  • fast/dom/registerContentHandler-expected.txt: Added.
  • fast/dom/registerContentHandler.html: Added.
  • fast/dom/registerProtocolHandler-expected.txt: Added.
  • fast/dom/registerProtocolHandler.html: Added.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt:
13:06 Changeset [50476] by beidson@apple.com
  • 8 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=31079 - Remove #include "Page.h" from Document.h

Reviewed by Darin Adler.

No new tests. (No change in functionality)

  • dom/Document.cpp:

(WebCore::Document::inspectorTimelineAgent): Moved from Document.h

  • dom/Document.h:

Include "Page.h" directly:

  • html/HTMLVideoElement.cpp:
  • loader/RedirectScheduler.cpp:
  • page/History.cpp:
  • rendering/MediaControlElements.cpp:
  • storage/StorageAreaImpl.cpp:
12:59 Changeset [50475] by senorblanco@chromium.org
  • 2 edits in trunk/WebKitTools

(Unreviewed).

Add myself to committers.py.

  • Scripts/modules/committers.py:
12:56 Changeset [50474] by mrowe@apple.com
  • 6 edits in branches/safari-4-branch

Merge r50443.

12:04 Changeset [50473] by kevino@webkit.org
  • 1 edit
    8 adds in trunk/WebKitTools

Reviewed by Kevin Ollviier.

Add packaging scripts for Debian-based Linux distros.

https://bugs.webkit.org/show_bug.cgi?id=31075

11:38 Changeset [50472] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-03 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: hover over JS "things" in source and see their values
https://bugs.webkit.org/show_bug.cgi?id=30913

  • inspector/front-end/SourceFrame.js:
11:24 Changeset [50471] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: update timeline content boundaries on timer.

https://bugs.webkit.org/show_bug.cgi?id=31072

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelinePanel.prototype._setWindowPosition):
11:07 Changeset [50470] by mitz@apple.com
  • 10 edits
    4 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=31070
Fix <rdar://problem/7194735> Crashes at RenderText::RenderText()
Fix <rdar://problem/6937089> Crashes at RenderWidget::destroy()

Reviewed by Anders Carlsson and Beth Dakin.

Tests: plugins/attach-during-destroy.html

plugins/destroy-reentry.html

These crashes were caused by plug-in code running during detach(),
causing re-entry into RenderWidget::destroy() in one case and a call
into attach() in the other. The fix is to prevent plug-in code from
being called at certain unsafe times (during attach(), detach(), and
recalcStyle()) by deferring changes to the widget hierarchy.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle): Suspend widget hierarchy updates

during style recalculation.

  • dom/Element.cpp:

(WebCore::Element::attach): Suspend widget hierarchy updates during

attach().

(WebCore::Element::detach): Suspend widget hierarchy updates during

detach().

  • rendering/RenderWidget.cpp:

(WebCore::widgetNewParentMap): Returns a static map of pending changes

to the widget hierarchy.

(WebCore::RenderWidget::suspendWidgetHierarchyUpdates): Increments the

suspend count.

(WebCore::RenderWidget::resumeWidgetHierarchyUpdates): Decrements the

suspend count. If the count is going to be zero, updates the widget
hierarchy by executing the pending changes stored in the map.

(WebCore::moveWidgetToParentSoon): Updates the widget hierarchy

immediately or makes or updates an entry in the map, depending on
whether updates are suspended.

(WebCore::RenderWidget::destroy): Removed earlier bandaid fix for

<rdar://problem/6937089>.

(WebCore::RenderWidget::setWidgetGeometry): Assert that widget updates

are not suspended, because this function updates the widget’s
bounds, which can result in arbitrary native and JavaScript code
execution. I think this assertion is true thanks to some deferred-
update mechanisms that have already been deployed in other places
in the code.

(WebCore::RenderWidget::setWidget): Call moveWidgetToParentSoon instead

of changing the widget hierarchy directly.

  • rendering/RenderWidget.h: Declared suspendWidgetHierarchyUpdates()

and resumeWidgetHierarchyUpdates().

WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=31070

Reviewed by Anders Carlsson and Beth Dakin.

Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
destroyed, it executes the value of the 'ondestroy' parameter as a
script.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:

(pluginAllocate): Initialize onDestroy.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define

onDestroy.

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:

(NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
specified.
(NPP_Destroy): Execute the value of 'ondestroy' as a script.

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=31070
Test for <rdar://problem/7194735> Crashes at RenderText::RenderText()
Test for <rdar://problem/6937089> Crashes at RenderWidget::destroy()

Reviewed by Anders Carlsson and Beth Dakin.

  • plugins/attach-during-destroy-expected.txt: Added.
  • plugins/attach-during-destroy.html: Added.
  • plugins/destroy-reentry-expected.txt: Added.
  • plugins/destroy-reentry.html: Added.
11:06 Changeset [50469] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: only show timeline records that contribute
to the current window.

https://bugs.webkit.org/show_bug.cgi?id=31069

10:45 Changeset [50468] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-03 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Watch expression editor should stay open after Add button was clicked
https://bugs.webkit.org/show_bug.cgi?id=31049

No new tests, was a regression, use existing manual test.

  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionsSection.prototype.addExpression):
10:37 Changeset [50467] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-11-03 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

A test that reproduces a hard-to-trigger memory corruption in the
CSS lexer.

https://bugs.webkit.org/show_bug.cgi?id=30827

  • fast/css/end-of-buffer-crash.html: Added.

2009-11-03 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

Fix an off-by-one in the CSS lexer that causes memory corruption in
hard-to-trigger circumstances.

https://bugs.webkit.org/show_bug.cgi?id=30827

Test: fast/css/end-of-buffer-crash.html

  • css/maketokenizer: Add comments, fix off-by-one.
10:23 Changeset [50466] by darin@apple.com
  • 4 edits
    2 adds in trunk

Crash due to double-destroy related to CSS run-in property
https://bugs.webkit.org/show_bug.cgi?id=31034
rdar://problem/7328458

Patch by Darin Adler <darin@apple.com> on 2009-11-02
Reviewed by Dan Bernstein.

WebCore:

Test: fast/css/run-in-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::destroy): Reorder destruction so the
continuation is destroyed after anonymous children. See comment
in the code for more details of why this is right.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::destroy): Ditto.

LayoutTests:

  • fast/css/run-in-crash-expected.txt: Added.
  • fast/css/run-in-crash.html: Added.
10:22 Changeset [50465] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-03 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Fix exception in ElementsPanel.js when moving pointer out of crumbs and window

There might be no new node under mouse if the pointer is moved out of the window
in which case we get an exception.
https://bugs.webkit.org/show_bug.cgi?id=31061

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs):
10:09 Changeset [50464] by zoltan@webkit.org
  • 7 edits in trunk/WebCore

Allow custom memory allocation control for the dom directory of WebCore
https://bugs.webkit.org/show_bug.cgi?id=31053

Reviewed by Darin Adler.

Inherits the following classes from Noncopyable because these are
instantiated by 'new' and these are no need to be copyable:

class EventNames - 'new' call: WebCore/platform/ThreadGlobalData.cpp:73
struct PerformTaskContext - 'new' call: WebCore/dom/Document.cpp:4581
class EventData - 'new' call: WebCore/dom/MessagePortChannel.cpp:38
struct NodeListsNodeData - 'new' call: WebCore/dom/NodeRareData.h:51
struct EventTargetData - 'new' call: WebCore/dom/NodeRareData.h:100
class NodeRareData - 'new' call: WebCore/dom/Node.cpp:552

Inherits QualifiedName class from FastAllocBase because it is
instantiated by 'new' in WebCore/editing/markup.cpp:319

  • dom/Document.cpp:
  • dom/EventNames.h:
  • dom/EventTarget.h:
  • dom/MessagePortChannel.h:
  • dom/NodeRareData.h:
  • dom/QualifiedName.h:
09:59 Changeset [50463] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement timeline summary panel.

https://bugs.webkit.org/show_bug.cgi?id=31064

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._createOverview): (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelineCategoryGraph): (WebInspector.TimelineCategoryGraph.prototype.get graphElement): (WebInspector.TimelineCategoryGraph.prototype.addChunk): (WebInspector.TimelineCategoryGraph.prototype.clearChunks): (WebInspector.TimelineGraph.prototype.refresh):
  • inspector/front-end/inspector.css:
09:56 Changeset [50462] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-03 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Toggle off 'Search for node' when the Inspector window is closing

Searching for node should be toggled off when the Inspector window is closed,
in a platform-independent manner.
https://bugs.webkit.org/show_bug.cgi?id=31059

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible):
09:49 Changeset [50461] by japhet@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2009-11-03 Victor Wang <victorw@chromium.org>

Reviewed by Eric Seidel.

"http://trac.webkit.org/changeset/50315" makes links mouse
focusable only on GTK and QT, so win has same behavior as mac now
Remove the win specific expected results for tests failed
due to the patch.

https://bugs.webkit.org/show_bug.cgi?id=30968

  • platform/win/fast/events/click-focus-anchor-expected.txt: Removed.
  • platform/win/fast/inline: Removed.
  • platform/win/fast/inline/dirtyLinesForInline-expected.txt: Removed.
09:47 Changeset [50460] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-11-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Prepare for heap profiles upstreaming:

  • pass profile type id from InspectorController;
  • this makes WebInspector.CPUProfile redundant---removed;
  • support multiple profile types when populating profiles.

https://bugs.webkit.org/show_bug.cgi?id=31052

  • inspector/InspectorController.cpp: (WebCore::InspectorController::createProfileHeader):
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView.profileCallback): (WebInspector.CPUProfileView): (WebInspector.CPUProfileView.prototype._sortData):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader):
  • inspector/front-end/inspector.js: (WebInspector.addProfileHeader):
09:26 Changeset [50459] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-11-03 Dan Kegel <dank@chromium.org>

Reviewed by Dimitri Glazkov.

UMR in WebCore::AccessibilityRenderObject::children(); m_childrenDirty uninitialized in constructor
https://bugs.webkit.org/show_bug.cgi?id=31063

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
09:06 Changeset [50458] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2009-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement Timeline Window, wire it to the bottom timeline.

https://bugs.webkit.org/show_bug.cgi?id=31056

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.get items): (WebInspector.AbstractTimelinePanel.prototype.createInterface): (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded): (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition): (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems): (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition): (WebInspector.AbstractTimelinePanel.prototype.addExtraDivider): (WebInspector.TimelineGrid): (WebInspector.TimelineGrid.prototype.get itemsGraphsElement): (WebInspector.TimelineGrid.prototype.updateDividers): (WebInspector.TimelineGrid.prototype.addExtraDivider): (WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded): (WebInspector.ResourcesPanel.prototype.get _resources):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get categories): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype._createOverview): (WebInspector.TimelinePanel.prototype.setSidebarWidth): (WebInspector.TimelinePanel.prototype.updateMainViewWidth): (WebInspector.TimelinePanel.prototype.updateGraphDividersIfNeeded): (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelinePanel.prototype._resizeWindow): (WebInspector.TimelinePanel.prototype._windowResizeDragging): (WebInspector.TimelinePanel.prototype._dragWindow): (WebInspector.TimelinePanel.prototype._windowDragging): (WebInspector.TimelinePanel.prototype._resizeWindowLeft): (WebInspector.TimelinePanel.prototype._resizeWindowRight): (WebInspector.TimelinePanel.prototype._setWindowPosition): (WebInspector.TimelinePanel.prototype._endWindowDragging): (WebInspector.TimelineCategoryTreeElement): (WebInspector.TimelineCategoryTreeElement.prototype.onattach): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.get minimumBoundary): (WebInspector.TimelineCalculator.prototype.get maximumBoundary): (WebInspector.TimelineCalculator.prototype.reset): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.formatValue):
  • inspector/front-end/inspector.css:
08:13 Changeset [50457] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Fix build of unit-test after r50454.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-11-03
Reviewed by Simon Hausmann.

  • tests/qwebpage/tst_qwebpage.cpp:
07:54 Changeset [50456] by hausmann@webkit.org
  • 9 edits
    1 move in trunk

Make QWebPluginDatabase private API for now.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-03
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=30775

WebCore:

  • WebCore.pro:

WebKit/qt:

  • Api/headers.pri:
  • Api/qwebplugindatabase.cpp:
  • Api/qwebplugindatabase_p.h: Renamed from WebKit/qt/Api/qwebplugindatabase.h.
  • Api/qwebsettings.cpp:
  • Api/qwebsettings.h:
  • QtLauncher/main.cpp:

(MainWindow::setupUI):

  • tests/tests.pro:
07:06 Changeset [50455] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Rubber-stamped by Tor Arne Vestbø.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-03
Oops, also remove the API docs of the removed networkRequestStarted() signal.

  • Api/qwebpage.cpp:
06:50 Changeset [50454] by hausmann@webkit.org
  • 8 edits in trunk

WebCore: Extended the conversion of the WebCore ResourceRequest to the
QNetworkRequest with a mandatory originating object argument,
which is meant to be the QWebFrame the request belongs to.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-03
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=29975

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::start):

  • platform/network/qt/ResourceRequest.h:
  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

WebKit/qt: Replace the QWebPage::networkRequestStarted() signal with the originatingObject
property set to the QWebFrame that belongs to the request.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-03
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=29975

  • Api/qwebpage.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientQt::startDownload):

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::loadFinished):
(TestNetworkManager::createRequest):
(tst_QWebPage::originatingObjectInNetworkRequests):

06:48 Changeset [50453] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-03 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: monitorEvent should be monitorEvents
https://bugs.webkit.org/show_bug.cgi?id=31042

  • inspector/front-end/InjectedScript.js: (InjectedScript._ensureCommandLineAPIInstalled):
05:04 Changeset [50452] by vestbo@webkit.org
  • 1 edit in trunk/WebCore/plugins/PluginDatabase.cpp

[Qt] Windows CE build fix

04:32 Changeset [50451] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Add files to skiplist depend on phonon support,
which is disabled on the Qt buildbot for now.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-11-03

  • platform/qt/Skipped:
04:12 Changeset [50450] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Tor Arne Vestbø.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-11-03
Remove now passing tests from skiplist.

  • platform/qt/Skipped:
03:56 Changeset [50449] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Build fix for Windows CE

Rubber-stamped by Antti Koivisto.

  • plugins/PluginDatabase.cpp:
03:50 Changeset [50448] by vestbo@webkit.org
  • 1 edit in trunk/WebKitTools/DumpRenderTree/qt/DumpRenderTree.pro

[Qt] Build fix for Mac OS X when building as framework

WTFReportAssertionFailure is not exported, so building DRT in debug
mode against QtWebKit built as a framework failes to link.

02:40 Changeset [50447] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Put test into skiplist added in r50411 because
layoutTestController.showWebInspector() is unimplemented now.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-11-03

  • platform/qt/Skipped: inspector/css-syntax-highlight.html added
02:00 Changeset [50446] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-02 Chris Fleizach <cfleizach@apple.com>

Reviewed by David Levin.

fix accessibility webkit-style-check errors
https://bugs.webkit.org/show_bug.cgi?id=29672

  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate): (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::platformGenerateAXID): (WebCore::AXObjectCache::removeAXID):
  • accessibility/AXObjectCache.h: (WebCore::AXObjectCache::enableAccessibility): (WebCore::AXObjectCache::enableEnhancedUserInterfaceAccessibility): (WebCore::AXObjectCache::accessibilityEnabled): (WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled): (WebCore::AXObjectCache::isIDinUse): (WebCore::AXObjectCache::objectFromAXID): (WebCore::AXObjectCache::): (WebCore::AXObjectCache::handleActiveDescendantChanged): (WebCore::AXObjectCache::handleAriaRoleChanged): (WebCore::AXObjectCache::detachWrapper): (WebCore::AXObjectCache::attachWrapper): (WebCore::AXObjectCache::selectedChildrenChanged): (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::postPlatformNotification): (WebCore::AXObjectCache::handleFocusedUIElementChanged): (WebCore::AXObjectCache::handleScrolledToAnchor):
  • accessibility/AccessibilityARIAGrid.cpp: (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
  • accessibility/AccessibilityAllInOne.cpp:
  • accessibility/AccessibilityImageMapLink.cpp:
  • accessibility/AccessibilityList.h: (WebCore::AccessibilityList::isList):
  • accessibility/AccessibilityListBox.cpp:
  • accessibility/AccessibilityListBox.h: (WebCore::AccessibilityListBox::isListBox):
  • accessibility/AccessibilityListBoxOption.cpp:
  • accessibility/AccessibilityListBoxOption.h: (WebCore::AccessibilityListBoxOption::isListBoxOption):
  • accessibility/AccessibilityMediaControls.h: (WebCore::AccessibilityMediaControl::~AccessibilityMediaControl): (WebCore::AccessibilityMediaTimeline::~AccessibilityMediaTimeline): (WebCore::AccessibilityMediaTimeline::isMediaTimeline): (WebCore::AccessibilityMediaControlsContainer::~AccessibilityMediaControlsContainer): (WebCore::AccessibilityMediaControlsContainer::roleValue): (WebCore::AccessibilityMediaControlsContainer::accessibilityIsIgnored): (WebCore::AccessibilityMediaTimeDisplay::~AccessibilityMediaTimeDisplay): (WebCore::AccessibilityMediaTimeDisplay::roleValue):
  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::parentObjectUnignored): (WebCore::AccessibilityObject::rightLineVisiblePositionRange): (WebCore::replacedNodeNeedsCharacter): (WebCore::AccessibilityObject::stringForVisiblePositionRange): (WebCore::AccessibilityObject::lengthForVisiblePositionRange): (WebCore::AccessibilityObject::actionVerb):
  • accessibility/AccessibilityObject.h: (WebCore::PlainTextRange::isNull): (WebCore::AccessibilityObject::isAccessibilityRenderObject): (WebCore::AccessibilityObject::isAnchor): (WebCore::AccessibilityObject::isAttachment): (WebCore::AccessibilityObject::isHeading): (WebCore::AccessibilityObject::isLink): (WebCore::AccessibilityObject::isImage): (WebCore::AccessibilityObject::isNativeImage): (WebCore::AccessibilityObject::isImageButton): (WebCore::AccessibilityObject::isPasswordField): (WebCore::AccessibilityObject::isTextControl): (WebCore::AccessibilityObject::isNativeTextControl): (WebCore::AccessibilityObject::isWebArea): (WebCore::AccessibilityObject::isCheckboxOrRadio): (WebCore::AccessibilityObject::isListBox): (WebCore::AccessibilityObject::isFileUploadButton): (WebCore::AccessibilityObject::isProgressIndicator): (WebCore::AccessibilityObject::isSlider): (WebCore::AccessibilityObject::isControl): (WebCore::AccessibilityObject::isList): (WebCore::AccessibilityObject::isDataTable): (WebCore::AccessibilityObject::isTableRow): (WebCore::AccessibilityObject::isTableColumn): (WebCore::AccessibilityObject::isTableCell): (WebCore::AccessibilityObject::isFieldset): (WebCore::AccessibilityObject::isGroup): (WebCore::AccessibilityObject::isChecked): (WebCore::AccessibilityObject::isEnabled): (WebCore::AccessibilityObject::isSelected): (WebCore::AccessibilityObject::isFocused): (WebCore::AccessibilityObject::isHovered): (WebCore::AccessibilityObject::isIndeterminate): (WebCore::AccessibilityObject::isLoaded): (WebCore::AccessibilityObject::isMultiSelect): (WebCore::AccessibilityObject::isOffScreen): (WebCore::AccessibilityObject::isPressed): (WebCore::AccessibilityObject::isReadOnly): (WebCore::AccessibilityObject::isVisited): (WebCore::AccessibilityObject::isRequired): (WebCore::AccessibilityObject::canSetFocusAttribute): (WebCore::AccessibilityObject::canSetTextRangeAttributes): (WebCore::AccessibilityObject::canSetValueAttribute): (WebCore::AccessibilityObject::hasIntValue): (WebCore::AccessibilityObject::accessibilityShouldUseUniqueId): (WebCore::AccessibilityObject::accessibilityIsIgnored):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::parentObjectIfExists): (WebCore::AccessibilityRenderObject::parentObject): (WebCore::AccessibilityRenderObject::isMenuRelated): (WebCore::AccessibilityRenderObject::accessibilityDescription): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): (WebCore::AccessibilityRenderObject::isFocused): (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange): (WebCore::AccessibilityRenderObject::doAXRangeForLine): (WebCore::AccessibilityRenderObject::doAXStringForRange): (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest): (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute): (WebCore::AccessibilityRenderObject::determineAccessibilityRole): (WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole): (WebCore::AccessibilityRenderObject::canSetFocusAttribute): (WebCore::AccessibilityRenderObject::canHaveChildren): (WebCore::AccessibilityRenderObject::actionVerb): (WebCore::shouldReturnTagNameAsRoleForMSAA):
  • accessibility/AccessibilityRenderObject.h: (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
  • accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation):
  • accessibility/AccessibilitySlider.h: (WebCore::AccessibilitySlider::~AccessibilitySlider): (WebCore::AccessibilitySlider::roleValue): (WebCore::AccessibilitySlider::accessibilityIsIgnored): (WebCore::AccessibilitySlider::isSlider): (WebCore::AccessibilitySlider::canSetValueAttribute): (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::roleValue): (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored): (WebCore::AccessibilitySliderThumb::setParentObject): (WebCore::AccessibilitySliderThumb::parentObject):
  • accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
  • accessibility/AccessibilityTableColumn.cpp:
  • accessibility/AccessibilityTableHeaderContainer.cpp: (WebCore::AccessibilityTableHeaderContainer::addChildren):
  • accessibility/AccessibilityTableRow.cpp:
  • accessibility/mac/AccessibilityObjectWrapper.h:
01:44 CommitterTips edited by ossy@webkit.org
(diff)
00:52 CommitterTips edited by eric@webkit.org
(diff)
00:50 CommitterTips created by eric@webkit.org
00:27 WikiStart edited by eric@webkit.org
(diff)

11/02/09:

23:51 Changeset [50445] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-02 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=31035
[GTK] some accessibility tests hitting assertion in debug builds

Get the correct Gtk+ object before attempting to turn it into an AtkObject.

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: (AccessibilityController::rootElement):
23:01 Changeset [50444] by cfleizach@apple.com
  • 23 edits in trunk/WebCore

fix accessibility webkit-style-check errors
https://bugs.webkit.org/show_bug.cgi?id=29672

Reviewed by David Levin.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::platformGenerateAXID):
(WebCore::AXObjectCache::removeAXID):

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::enableAccessibility):
(WebCore::AXObjectCache::enableEnhancedUserInterfaceAccessibility):
(WebCore::AXObjectCache::accessibilityEnabled):
(WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled):
(WebCore::AXObjectCache::isIDinUse):
(WebCore::AXObjectCache::objectFromAXID):
(WebCore::AXObjectCache::):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::detachWrapper):
(WebCore::AXObjectCache::attachWrapper):
(WebCore::AXObjectCache::selectedChildrenChanged):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::handleScrolledToAnchor):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::cellForColumnAndRow):

  • accessibility/AccessibilityAllInOne.cpp:
  • accessibility/AccessibilityImageMapLink.cpp:
  • accessibility/AccessibilityList.h:

(WebCore::AccessibilityList::isList):

  • accessibility/AccessibilityListBox.cpp:
  • accessibility/AccessibilityListBox.h:

(WebCore::AccessibilityListBox::isListBox):

  • accessibility/AccessibilityListBoxOption.cpp:
  • accessibility/AccessibilityListBoxOption.h:

(WebCore::AccessibilityListBoxOption::isListBoxOption):

  • accessibility/AccessibilityMediaControls.h:

(WebCore::AccessibilityMediaControl::~AccessibilityMediaControl):
(WebCore::AccessibilityMediaTimeline::~AccessibilityMediaTimeline):
(WebCore::AccessibilityMediaTimeline::isMediaTimeline):
(WebCore::AccessibilityMediaControlsContainer::~AccessibilityMediaControlsContainer):
(WebCore::AccessibilityMediaControlsContainer::roleValue):
(WebCore::AccessibilityMediaControlsContainer::accessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::~AccessibilityMediaTimeDisplay):
(WebCore::AccessibilityMediaTimeDisplay::roleValue):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::parentObjectUnignored):
(WebCore::AccessibilityObject::rightLineVisiblePositionRange):
(WebCore::replacedNodeNeedsCharacter):
(WebCore::AccessibilityObject::stringForVisiblePositionRange):
(WebCore::AccessibilityObject::lengthForVisiblePositionRange):
(WebCore::AccessibilityObject::actionVerb):

  • accessibility/AccessibilityObject.h:

(WebCore::PlainTextRange::isNull):
(WebCore::AccessibilityObject::isAccessibilityRenderObject):
(WebCore::AccessibilityObject::isAnchor):
(WebCore::AccessibilityObject::isAttachment):
(WebCore::AccessibilityObject::isHeading):
(WebCore::AccessibilityObject::isLink):
(WebCore::AccessibilityObject::isImage):
(WebCore::AccessibilityObject::isNativeImage):
(WebCore::AccessibilityObject::isImageButton):
(WebCore::AccessibilityObject::isPasswordField):
(WebCore::AccessibilityObject::isTextControl):
(WebCore::AccessibilityObject::isNativeTextControl):
(WebCore::AccessibilityObject::isWebArea):
(WebCore::AccessibilityObject::isCheckboxOrRadio):
(WebCore::AccessibilityObject::isListBox):
(WebCore::AccessibilityObject::isFileUploadButton):
(WebCore::AccessibilityObject::isProgressIndicator):
(WebCore::AccessibilityObject::isSlider):
(WebCore::AccessibilityObject::isControl):
(WebCore::AccessibilityObject::isList):
(WebCore::AccessibilityObject::isDataTable):
(WebCore::AccessibilityObject::isTableRow):
(WebCore::AccessibilityObject::isTableColumn):
(WebCore::AccessibilityObject::isTableCell):
(WebCore::AccessibilityObject::isFieldset):
(WebCore::AccessibilityObject::isGroup):
(WebCore::AccessibilityObject::isChecked):
(WebCore::AccessibilityObject::isEnabled):
(WebCore::AccessibilityObject::isSelected):
(WebCore::AccessibilityObject::isFocused):
(WebCore::AccessibilityObject::isHovered):
(WebCore::AccessibilityObject::isIndeterminate):
(WebCore::AccessibilityObject::isLoaded):
(WebCore::AccessibilityObject::isMultiSelect):
(WebCore::AccessibilityObject::isOffScreen):
(WebCore::AccessibilityObject::isPressed):
(WebCore::AccessibilityObject::isReadOnly):
(WebCore::AccessibilityObject::isVisited):
(WebCore::AccessibilityObject::isRequired):
(WebCore::AccessibilityObject::canSetFocusAttribute):
(WebCore::AccessibilityObject::canSetTextRangeAttributes):
(WebCore::AccessibilityObject::canSetValueAttribute):
(WebCore::AccessibilityObject::hasIntValue):
(WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
(WebCore::AccessibilityObject::accessibilityIsIgnored):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::isMenuRelated):
(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::isFocused):
(WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
(WebCore::AccessibilityRenderObject::doAXRangeForLine):
(WebCore::AccessibilityRenderObject::doAXStringForRange):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole):
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
(WebCore::AccessibilityRenderObject::canHaveChildren):
(WebCore::AccessibilityRenderObject::actionVerb):
(WebCore::shouldReturnTagNameAsRoleForMSAA):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::orientation):

  • accessibility/AccessibilitySlider.h:

(WebCore::AccessibilitySlider::~AccessibilitySlider):
(WebCore::AccessibilitySlider::roleValue):
(WebCore::AccessibilitySlider::accessibilityIsIgnored):
(WebCore::AccessibilitySlider::isSlider):
(WebCore::AccessibilitySlider::canSetValueAttribute):
(WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb):
(WebCore::AccessibilitySliderThumb::roleValue):
(WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
(WebCore::AccessibilitySliderThumb::setParentObject):
(WebCore::AccessibilitySliderThumb::parentObject):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):

  • accessibility/AccessibilityTableColumn.cpp:
  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::addChildren):

  • accessibility/AccessibilityTableRow.cpp:
  • accessibility/mac/AccessibilityObjectWrapper.h:
22:49 Changeset [50443] by oliver@apple.com
  • 6 edits in trunk

REGRESSION (r48573): JSC may incorrectly cache chain lookups with a dictionary at the head of the chain
https://bugs.webkit.org/show_bug.cgi?id=31045

Reviewed by Gavin Barraclough.

Add guards to prevent caching of prototype chain lookups with dictionaries at the
head of the chain. Also add a few tighter assertions to cached prototype lookups
to catch this in future.

21:51 Changeset [50442] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-11-02 Darin Fisher <darin@chromium.org>

Fixing JSC build bustage.

  • bindings/js/ScriptController.cpp: Added missing #include
21:47 Changeset [50441] by darin@chromium.org
  • 7 edits in trunk/WebCore

2009-10-30 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

Give the FrameLoaderClient the ability to override Settings::isJavaScriptEnabled.
https://bugs.webkit.org/show_bug.cgi?id=30967

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::isEnabled):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::isEnabled):
  • bindings/v8/V8Proxy.cpp: Move implementation of isEnabled to ScriptController
  • bindings/v8/V8Proxy.h: Ditto
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::allowJavaScript):
  • platform/chromium/ChromiumBridge.h: Delete uiResourceProtocol function
20:40 Changeset [50440] by beidson@apple.com
  • 2 edits in trunk/WebCore

Rubberstamped by Mark Rowe.

Fix a typo in Mark's last commit.

  • loader/archive/ArchiveFactory.cpp:

(WebCore::archiveMIMETypes):

20:00 Changeset [50439] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Re-enable support for web archives on Windows. It was mistakenly disabled in r50438.

Rubber-stamped by Brady Eidson.

  • loader/archive/ArchiveFactory.cpp:

(WebCore::archiveMIMETypes):

19:24 Changeset [50438] by eric@webkit.org
  • 10 edits in trunk

2009-11-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

PLATFORM(CF) should be set when building for Qt on Darwin
https://bugs.webkit.org/show_bug.cgi?id=23671

  • wtf/Platform.h: Turn on CF support if both QT and DARWIN platforms are defined.

2009-11-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

PLATFORM(CF) should be set when building for Qt on Darwin
https://bugs.webkit.org/show_bug.cgi?id=23671

  • WebCore.pro: Add SharedBufferCF.cpp and SmartReplaceCF.cpp to the Darwin build.
  • loader/archive/ArchiveFactory.cpp: Change the support for legacy WebArchive from all CF platforms to Mac and Chromium CF platforms. (WebCore::archiveMIMETypes):
  • platform/text/AtomicString.h: Remove PLATFORM(QT) && PLATFORM(DARWIN) test as it is redundant now.
  • platform/text/PlatformString.h: Ditto.
  • platform/text/StringImpl.h: Ditto.
  • platform/text/cf/StringCF.cpp: Ditto.
  • platform/text/cf/StringImplCF.cpp: Ditto.
18:35 Changeset [50437] by eric@webkit.org
  • 5 edits
    1 add in trunk/WebCore

2009-11-02 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[Chromium] Actually declare getPluginMimeTypeFromExtension in a header.
https://bugs.webkit.org/show_bug.cgi?id=30985

Our current code does not conform to our style guide.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/MIMETypeRegistryChromium.cpp:
  • plugins/chromium/PluginDataChromium.cpp:
  • plugins/chromium/PluginDataChromium.h: Added.
18:07 Changeset [50436] by adele@apple.com
  • 3 edits in trunk/WebCore

Fix for <rdar://problem/7038305> REGRESSION (Safari 4.0.2 - ToT): After navigating back to a known phishy page, the "Ignore warning" button appears highlighted (along with the "Go Back" button)

Reviewed by Darin Adler.

This bug is timing dependent, and not always reproducible. I could not think of a way to add a
layout test that would demonstrate the problem and fix.

  • platform/mac/ThemeMac.mm:

(WebCore::checkbox): Update style.
(WebCore::paintCheckbox): ditto.
(WebCore::radio): ditto.
(WebCore::paintRadio): ditto.
(WebCore::setupButtonCell): Added convenience method.
(WebCore::button): Use a separate NSButtonCell for defaultButtons and regular buttons.
(WebCore::paintButton): Don't check for the key window here. Consider that when deciding if the button should have the default style in RenderTheme.

  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isDefault): Only consider a button to be default if the page is active. This fixes

a problem I noticed where the button would flicker crazily if the page with the default button was in the background.

17:44 Changeset [50435] by mitz@apple.com
  • 3 edits in trunk/WebCore

Minor RenderWidget clean-up in preparation for deferring widget tree
mutation when it is not safe.

Reviewed by Anders Carlsson.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::RenderWidget): Initialize m_refCount to 1
instead of calling ref().
(WebCore::RenderWidget::destroy): Call setWidget(0) instead of
repeating what it does.
(WebCore::RenderWidget::setWidgetGeometry): Now returns a boolean
indicating whether the bounds have changed.
(WebCore::RenderWidget::setWidget): Replaced all-encompassing if
statement with an early return.
(WebCore::RenderWidget::updateWidgetPosition): Call setWidgetGeometry().

  • rendering/RenderWidget.h:
17:39 QtBackLog edited by zecke@selfish.org
Mention #31009 (diff)
17:38 Changeset [50434] by dumi@chromium.org
  • 1 edit
    6 adds in trunk/WebCore

Adding Chromium's DatabaseTracker and SQLTransactionClient
implementations.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-11-02
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=30701

  • storage/chromium: Added.
  • storage/chromium/DatabaseObserver.h: Added.
  • storage/chromium/DatabaseTrackerChromium.cpp: Added.
  • storage/chromium/QuotaTracker.cpp: Added.
  • storage/chromium/QuotaTracker.h: Added.
  • storage/chromium/SQLTransactionClientChromium.cpp: Added.
17:06 Changeset [50433] by enrica@apple.com
  • 4 edits
    2 adds in trunk

Safari crashes when calling execCommand on formatted html in special case
<rdar://problem/7318656>
https://bugs.webkit.org/show_bug.cgi?id=31023

Reviewed by Adele Peterson and Dan Bernstein.

WebCore:

Test: editing/execCommand/align-in-span.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock): Modified comment on containingBlock returning NULL.

  • rendering/RenderText.cpp:

(WebCore::RenderText::setSelectionState): Added check for NULL return from containingBlock,
since it is possible when dealing with orphaned trees.

LayoutTests:

  • editing/execCommand/align-in-span-expected.txt: Added.
  • editing/execCommand/align-in-span.html: Added.
16:04 Changeset [50432] by cmarrin@apple.com
  • 8 edits in trunk

Exception checks were being too aggressive
https://bugs.webkit.org/show_bug.cgi?id=31005

Several calls in CanvasRenderingContext3D are allowed to
have a null value passed, which indicated that the
object is being unbound. Handle this case and the corresponding
null handling in GraphicsContext3DMac.

14:53 Changeset [50431] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2009-11-02 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Each JS execution in console adds extra item into "scripts" combo
https://bugs.webkit.org/show_bug.cgi?id=30212

Added manual test

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  • manual-tests/inspector/hidden-evals.html: Added.
14:26 Changeset [50430] by eric@webkit.org
  • 2 edits in trunk

2009-11-02 Estêvão Samuel Procópio <tevaum@gmail.com>

Reviewed by Gustavo Noronha.

[Build] make install ignores --prefix option for gobject-introspection.
https://bugs.webkit.org/show_bug.cgi?id=31025

Make the build system use the --prefix path also when installing
gobject-introspection files.

  • configure.ac: use --prefix path in GITDIR and GIRTYPELIBDIR
14:03 Changeset [50429] by eric.carlson@apple.com
  • 6 edits in trunk/WebKit

2009-11-02 Eric Carlson <eric.carlson@apple.com>

Reviewed by John Sullivan and Mark Rowe.

<rdar://problem/7356733> Voiceover does not read correct media controller time values


Fix localized strings for media controller time values.

  • English.lproj/Localizable.strings:

2009-11-02 Eric Carlson <eric.carlson@apple.com>

Reviewed by John Sullivan and Mark Rowe.

<rdar://problem/7356733> Voiceover does not read correct media controller time values

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory localizedMediaTimeDescription:]):

2009-11-02 Eric Carlson <eric.carlson@apple.com>

Reviewed by John Sullivan and Mark Rowe.

<rdar://problem/7356733> Voiceover does not read correct media controller time values

  • WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaTimeDescription):
14:02 Changeset [50428] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-02 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Adds a missed case for InspectorTimeline, DOMWindow dispatch of DOM events.
https://bugs.webkit.org/show_bug.cgi?id=31030

  • dom/Node.cpp: (WebCore::eventHasListeners): Checks DOMWindow for listeners. (WebCore::Node::dispatchGenericEvent):
13:31 Changeset [50427] by dimich@chromium.org
  • 29 edits in trunk

Remove threadsafe refcounting from tasks used with WTF::MessageQueue.
https://bugs.webkit.org/show_bug.cgi?id=30612

Reviewed by David Levin.

JavaScriptCore:

  • wtf/MessageQueue.h:

(WTF::MessageQueue::alwaysTruePredicate):
(WTF::MessageQueue::~MessageQueue):
(WTF::MessageQueue::append):
(WTF::MessageQueue::appendAndCheckEmpty):
(WTF::MessageQueue::prepend):
(WTF::MessageQueue::waitForMessage):
(WTF::MessageQueue::waitForMessageFilteredWithTimeout):
(WTF::MessageQueue::tryGetMessage):
(WTF::MessageQueue::removeIf):
The MessageQueue is changed to act as a queue of OwnPtr<DataType>. It takes ownership
of posted tasks and passes it to the new owner (in another thread) when the task is fetched.
All methods have arguments of type PassOwnPtr<DataType> and return the same type.

  • wtf/Threading.cpp:

(WTF::createThread):
Superficial change to trigger rebuild of JSC project on Windows,
workaround for https://bugs.webkit.org/show_bug.cgi?id=30890

WebCore:

No new tests since no new functionality. Storage, MessagePorts and Workers tests cover this.

There are a lot of files but most changes are simply replace RefPtr and PassRefPtr with
OwnPtr and PassOwnPtr when dealing with Tasks.

ScriptExecutionContext::Task, DatabaseTask and WorkerRunLoop::Task are no longer
threadsafe refcounted, but simply Noncopyable.

  • dom/Document.cpp:

(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):

  • dom/Document.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ProcessMessagesSoonTask::create):

  • dom/ScriptExecutionContext.h:
  • dom/default/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):

  • dom/default/PlatformMessagePortChannel.h:

(WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
(WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):

  • loader/FrameLoader.cpp:

(WebCore::HashChangeEventTask::create):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::CallCacheListenerTask::create):

  • storage/Database.cpp:

(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::scheduleTransaction):
(WebCore::Database::scheduleTransactionStep):
(WebCore::Database::tableNames):

  • storage/DatabaseTask.h:

(WebCore::DatabaseOpenTask::create):
(WebCore::DatabaseCloseTask::create):
(WebCore::DatabaseTransactionTask::create):
(WebCore::DatabaseTableNamesTask::create):

  • storage/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::scheduleTask):
(WebCore::DatabaseThread::scheduleImmediateTask):
(WebCore::SameDatabasePredicate::operator()):

  • storage/DatabaseThread.h:
  • storage/LocalStorageTask.h:

(WebCore::LocalStorageTask::createImport):
(WebCore::LocalStorageTask::createSync):
(WebCore::LocalStorageTask::createTerminate):

  • storage/LocalStorageThread.cpp:

(WebCore::LocalStorageThread::localStorageThread):

  • storage/LocalStorageThread.h:
  • websockets/WebSocket.cpp:

(WebCore::ProcessWebSocketEventTask::create):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):
(WebCore::SharedWorkerConnectTask::create):

  • workers/GenericWorkerTask.h:

(WebCore::GenericWorkerTask1::create):
(WebCore::GenericWorkerTask2::create):
(WebCore::GenericWorkerTask3::create):
(WebCore::GenericWorkerTask4::create):
(WebCore::GenericWorkerTask5::create):
(WebCore::GenericWorkerTask6::create):
(WebCore::GenericWorkerTask7::create):
(WebCore::GenericWorkerTask8::create):
(WebCore::createCallbackTask):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::postTask):

  • workers/WorkerContext.h:
  • workers/WorkerLoaderProxy.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::MessageWorkerContextTask::create):
(WebCore::MessageWorkerTask::create):
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerContextDestroyedTask::create):
(WebCore::WorkerTerminateTask::create):
(WebCore::WorkerThreadActivityReportTask::create):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::workerThreadCreated):

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerRunLoop.cpp:

(WebCore::ModePredicate::operator()):
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::performTask):
(WebCore::WorkerRunLoop::Task::Task):

  • workers/WorkerRunLoop.h:

(WebCore::WorkerRunLoop::Task::~Task):
(WebCore::WorkerRunLoop::Task::mode):

13:14 Changeset [50426] by mitz@apple.com
  • 3 edits in trunk/WebKit/mac

Made the remaining time display show negative zero at the end of the
video.

Reviewed by Anders Carlsson.

Made other cleanup.

  • WebView/WebVideoFullscreenHUDWindowController.h: Reverted the types of

_timeline and _volumeSlider to the more generic NSControl.

  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Cleaned
up style.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Added an
assertion that the cast to NSButton * is legal. Removed casts.
(-[WebVideoFullscreenHUDWindowController updateTime]): Use
-setValue:forKey: instead of an NSSlider method.
(timeToString): Changed to support only non-negative values and
simplified.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Always
prepend a “-” to the time.

12:14 Changeset [50425] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-11-02 Philippe Normand <pnormand@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Failing media/video-played-reset.html
https://bugs.webkit.org/show_bug.cgi?id=30589

  • platform/gtk/Skipped: Unskip fixed test.
11:34 Changeset [50424] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-02 Philippe Normand <pnormand@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Failing media/video-played-reset.html
https://bugs.webkit.org/show_bug.cgi?id=30589

new m_seekTime attribute to keep track of the seek position

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
11:25 Changeset [50423] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-11-02 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Remove Referer when redirecting to non-secure site
https://bugs.webkit.org/show_bug.cgi?id=31021

Remove referer from HTTP headers when redirecting to a non-secure
site.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
11:10 Changeset [50422] by xan@webkit.org
  • 2 edits in trunk

2009-11-02 Xan Lopez <xlopez@igalia.com>

Bump version before release (or post-release, depending on your
point of view) so that we can make applications depending on
unreleased APIs in WebKit svn fail at configure time when the
requirements are not met.

  • configure.ac:
11:00 Changeset [50421] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=18539
multipart/form-data not being parsed correctly on server due to '+' in boundary string

No test - the characters that the boundary is made of are not deterministic.

  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::generateUniqueBoundaryString): Don't ever put a '+' in boundary string, either. Removed a FIXME to bring '/' back once GMail is fixed - I don't think we'll ever want to allow non-alphanumeric characters, as they cause problems on many web sites.
10:52 Changeset [50420] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-11-02 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Increase the timeout of media/video-currentTime-set.html from 800ms to 2000ms.

Also fix call to logResult() as parameters were reversed, resulting in
printing an error message of "false".

https://bugs.webkit.org/show_bug.cgi?id=31017

  • media/video-currentTime-set.html: Timeout increased to 2000ms.
10:41 Changeset [50419] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30969
A no-prefix XPath node test should not match no-namespace elements in HTML document

Test: fast/xpath/null-namespace-in-html.html

  • xml/XPathStep.cpp: (WebCore::XPath::nodeMatchesBasicTest): Special case non-HTML elements in HTML documents (as these are the ones that can have null namespace).
10:32 Changeset [50418] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] No timeline marks on resources panel.

https://bugs.webkit.org/show_bug.cgi?id=31013

  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
10:26 Changeset [50417] by levin@chromium.org
  • 2 edits in trunk/WebCore

Possible crash in RenderSlider::layout.
https://bugs.webkit.org/show_bug.cgi?id=31016

Patch by David Levin <levin@chromium.org> on 2009-11-02
Reviewed by Dan Bernstein.

Fix out of place line of code.

Test: scrollbars/overflow-scrollbar-combinations.html
This crash only seems to repro when WebKit draws the play controls,
so the crash repros in chromium running this test but not WebKit
nightlies which use QuickTime to draw the controls.

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::layout):

10:17 Changeset [50416] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-11-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Fix Qt build on Windows.
https://bugs.webkit.org/show_bug.cgi?id=30905

  • WebCore.pro:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::create):
10:09 Changeset [50415] by eric@webkit.org
  • 5 edits
    4 adds in trunk

2009-11-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Adam Barth.

QWebView crash fix.

The QWebView should not crash if the stop() method is called from
a function triggered by the loadProgress signal.

A null pointer protection was added in the ProgressTracker::incrementProgress.

New autotest was created.

https://bugs.webkit.org/show_bug.cgi?id=29425

  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress):

2009-11-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Adam Barth.

QWebView crash fix.

The QWebView should not crash if the stop() method is called from
a function triggered by the loadProgress signal.

A null pointer protection was added in the ProgressTracker::incrementProgress.

New autotest was created.

https://bugs.webkit.org/show_bug.cgi?id=29425

  • tests/qwebview/tst_qwebview.cpp: (WebViewCrashTest::WebViewCrashTest): (WebViewCrashTest::loading): (tst_QWebView::crashTests):
10:01 Changeset [50414] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-02 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Fix a leftover from profiles panel generalization.

https://bugs.webkit.org/show_bug.cgi?id=31010

  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.get searchableViews):
09:53 Changeset [50413] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-02 Kai Koehne <kai.koehne@nokia.com>

Reviewed by Holger Freyther.

Remove implementation of ImageDecocerQt::clearFrameBufferCache.
The implementation was buggy, and will visually break repeating
animations anyway.

https://bugs.webkit.org/show_bug.cgi?id=31009

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::clearFrameBufferCache):
09:35 Changeset [50412] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-02 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=30964
[Gtk] Implemment AtkDocument

Provides access to the reported content language.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_document_get_locale):
09:27 Changeset [50411] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2009-11-02 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
https://bugs.webkit.org/show_bug.cgi?id=30907

  • inspector/css-syntax-highlight-expected.txt: Added.
  • inspector/css-syntax-highlight.html: Added.
  • inspector/javascript-syntax-highlight-expected.txt:

2009-11-02 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
https://bugs.webkit.org/show_bug.cgi?id=30907

Test: inspector/css-syntax-highlight.html

  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.syntaxHighlightCSS): (WebInspector.SourceSyntaxHighlighter): (WebInspector.SourceSyntaxHighlighter.prototype.process.processChunk): (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): (WebInspector.SourceSyntaxHighlighter.prototype.process): (WebInspector.SourceSyntaxHighlighter.prototype.lex): (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken): (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode): (WebInspector.CSSSourceSyntaxHighlighter):
  • inspector/front-end/inspectorSyntaxHighlight.css:
09:03 Changeset [50410] by mitz@apple.com
  • 7 edits in trunk

WebKit/mac: WebKit part of making the appearance of the full-screen video HUD match
QuickTime Player X’s HUD.

Reviewed by John Sullivan.

  • WebView/WebVideoFullscreenHUDWindowController.h: Removed unnecessary

#import statements, cleaned up style, and changed _timeline,
_volumeSlider and _playButton to have more specific types.

  • WebView/WebVideoFullscreenHUDWindowController.mm: Updated #import

statements.
(webkit_CGFloor): Added this helper function.
(-[WebVideoFullscreenHUDWindowController init]): Cleaned up style.
(createTimeTextField): Changed to use the bold system font.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
subviews’ metrics and the text fields’ text alignment.
(-[WebVideoFullscreenHUDWindowController updateTime]): Avoid conversion
from double to float.
(stringToTimeTextAttributed): Removed this useless function that
returned an NSAttributedString masquerading as an NSString.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Removed
call to stringToTimeTextAttributed().
(-[WebVideoFullscreenHUDWindowController elapsedTimeText]): Ditto.

WebKitLibraries: WebKitSystemInterface part of making the appearance of the full-screen video HUD match
QuickTime Player X’s HUD.

Reviewed by John Sullivan.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
08:57 Changeset [50409] by cfleizach@apple.com
  • 21 edits
    4 adds in trunk

Support ARIA "tab" roles
https://bugs.webkit.org/show_bug.cgi?id=30842

Reviewed by Beth Dakin.

WebCore:

Implement support for ARIA "tab", "tabpanel" and "tablist".
As a consequence, we also needed to implement aria-selected
and aria-controls.

Tests: accessibility/aria-controls-with-tabs.html

accessibility/aria-tab-roles.html

  • accessibility/AXObjectCache.cpp:
  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:
  • html/HTMLAttributeNames.in:

WebKit:

Add a localizable string for tab panel.

  • English.lproj/Localizable.strings:
  • StringsNotToBeLocalized.txt:

WebKit/mac:

  • WebCoreSupport/WebViewFactory.mm:

(-[WebViewFactory AXARIAContentGroupText:]):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

LayoutTests:

  • accessibility/aria-controls-with-tabs-expected.txt: Added.
  • accessibility/aria-controls-with-tabs.html: Added.
  • accessibility/aria-tab-roles.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/accessibility/aria-tab-roles-expected.txt: Added.
  • platform/win/Skipped:
07:27 Changeset [50408] by senorblanco@chromium.org
  • 2 edits in trunk/WebCore

This is the WebKit-side change needed to fix canvas.getImageData() for
Chromium. The unpremultiply code in Skia assumes that unpremultiplied
values should be rounded, while CG does not. In addition, the fixed
point inversion used by Skia introduces slight inaccuracies that make
us fail this test. This change brings Chromium in line with
the CG path.
https://bugs.webkit.org/show_bug.cgi?id=30825

Reviewed by Dmitry Titov.

Covered by LayoutTests/fast/canvas/canvas-getImageData.html

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):

04:36 BuildingQtOnOSX edited by vestbo@webkit.org
(diff)
01:37 Changeset [50407] by pfeldman@chromium.org
  • 10 edits in trunk/WebCore

2009-11-01 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Adds window event dispatches to InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=31002

  • English.lproj/localizedStrings.js:
  • dom/Node.cpp: Updated call site to willDispatchEvent and didDispatchEvent. (WebCore::Node::dispatchGenericEvent):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willDispatchEvent): Renamed. (WebCore::InspectorTimelineAgent::didDispatchEvent): Renamed.
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createEventDispatchRecord): Renamed.
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):
01:25 Surfin' Safari Translations edited by casey.hattori@gmail.com
(diff)
01:25 Changeset [50406] by pfeldman@chromium.org
  • 10 edits in trunk/WebCore

2009-11-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Convert script tag event into a more generic
script eval event in timeline.

https://bugs.webkit.org/show_bug.cgi?id=30999

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::didEvaluateScript):
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createEvaluateScriptTimelineRecord):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails):
01:22 Surfin' Safari Translations created by casey.hattori@gmail.com

11/01/09:

22:36 newpage edited by casey.hattori@gmail.com
(diff)
22:34 newpage created by casey.hattori@gmail.com
22:21 Changeset [50405] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Rubber-stamped by Mark Rowe.

Fix for loop to use an size_t instead of unsigned and some spacing
style fixes.

  • dom/Node.cpp:

(WebCore::eventHasListeners):

22:07 QtBackLog edited by zecke@selfish.org
(diff)
22:03 Changeset [50404] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/dom/Node.cpp

Re-fix the Mac build. Sorry :-(.

21:57 Changeset [50403] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/dom/Node.cpp

Change ssize_t to unsigned to try and fix Windows build.

19:53 Changeset [50402] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Made the space bar toggle playing state in full-screen video when
modifier keys are down. Made it do so without highlighting the
Play/Pause button.

Reviewed by Mark Rowe.

  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController keyDown:]):

19:30 Changeset [50401] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-01 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

buildbots should use --exit-after-N-failures
https://bugs.webkit.org/show_bug.cgi?id=30809

Make the bots exit after 20 failures to prevent never-ending
test runs where every test spends a minute crashing.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
19:23 Changeset [50400] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-01 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Does not send DOM dispatches to the InspectorTimelineAgent if there
are no event listeners.
https://bugs.webkit.org/show_bug.cgi?id=30995

  • dom/Node.cpp: (WebCore::eventHasListeners): (WebCore::Node::dispatchGenericEvent):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
19:14 Changeset [50399] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Made the full-screen video HUD respond to the up and down arrow keys by
increasing and decreasing the volume by 1/10 of the range or, when
combined with the Option key, all the way up or down.

Reviewed by Mark Rowe.

Made the volume buttons in the full-screen video HUD match the behavior
of their equivalents in the QuickTime Player HUD by turning the volume
all the way up or down.

Made the volume slider update immediately when the keyboard or volume
buttons are used to change the volume, rather than at the nearest 1/4
second interval.

Made the elapsed and remaining time displays update immediately when the
play head is dragged across the timeline, rather than at 1/4 second
intervals.

  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController keyDown:]): Handle the up and
down arrow keys.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
actions of the volume up and volume down buttons.
(-[WebVideoFullscreenHUDWindowController setCurrentTime:]): Call
-updateTime.
(-[WebVideoFullscreenHUDWindowController setVolumeToZero:]): Added this
action for the volume down button.
(-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]): Added
this action for the volume up button.
(-[WebVideoFullscreenHUDWindowController decrementVolume]): No longer
and action method.
(-[WebVideoFullscreenHUDWindowController incrementVolume]): Ditto.
(-[WebVideoFullscreenHUDWindowController setVolume:]): Call
-updateVolume.

18:50 Changeset [50398] by rolandsteiner@chromium.org
  • 2 edits in trunk/WebCore

No review (build fix).

Add missing files for Ruby implementation to WebCore.vcproj
(Fix build break after 50397)
https://bugs.webkit.org/show_bug.cgi?id=31001

No new tests. (No functional change)

  • WebCore.vcproj/WebCore.vcproj:
17:52 Changeset [50397] by rolandsteiner@chromium.org
  • 12 edits
    8 adds in trunk

Bug 28420 - Implement HTML5 <ruby> rendering
(https://bugs.webkit.org/show_bug.cgi?id=28420)

Reviewed by Dave Hyatt.

First rudimentary implementation of HTML5 ruby rendering support.

WebCore:

Following the HTML 5 spec, the box object model for a <ruby> element allows several runs of ruby
bases with their respective ruby texts looks as follows:

1 RenderRuby object, corresponding to the whole <ruby> HTML element

1+ RenderRubyRun (anonymous)

0 or 1 RenderRubyText - shuffled to the front in order to re-use existing block layouting

0-n inline object(s)

0 or 1 RenderRubyBase - contains the inline objects that make up the ruby base

1-n inline object(s)

Note: <rp> elements are defined as having 'display:none' and thus normally are not assigned a renderer.

New layout tests will be committed in a follow-up patch under fast/ruby.

Makefiles, etc.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:

CSS

  • css/html.css: Added <ruby> and <rt>

Existing render files:

  • rendering/RenderBlock.cpp: make moveChild a member function moveChildTo

(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::RenderBlock::removeChild):

  • rendering/RenderBlock.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject): instantiate ruby renderers based on element name

  • rendering/RenderObject.h: add query methods for ruby renderers

(WebCore::RenderObject::isRuby):
(WebCore::RenderObject::isRubyBase):
(WebCore::RenderObject::isRubyRun):
(WebCore::RenderObject::isRubyText):

New ruby renderers:

  • rendering/RenderRuby.cpp: Added.

(WebCore::lastRubyRun):
(WebCore::findRubyRunParent):
(WebCore::RenderRubyAsInline::RenderRubyAsInline):
(WebCore::RenderRubyAsInline::~RenderRubyAsInline):
(WebCore::RenderRubyAsInline::isChildAllowed):
(WebCore::RenderRubyAsInline::addChild):
(WebCore::RenderRubyAsInline::removeChild):
(WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
(WebCore::RenderRubyAsBlock::~RenderRubyAsBlock):
(WebCore::RenderRubyAsBlock::isChildAllowed):
(WebCore::RenderRubyAsBlock::addChild):
(WebCore::RenderRubyAsBlock::removeChild):

  • rendering/RenderRuby.h: Added.

(WebCore::RenderRubyAsInline::renderName):
(WebCore::RenderRubyAsInline::isRuby):
(WebCore::RenderRubyAsBlock::renderName):
(WebCore::RenderRubyAsBlock::isRuby):

  • rendering/RenderRubyBase.cpp: Added.

(WebCore::RenderRubyBase::RenderRubyBase):
(WebCore::RenderRubyBase::~RenderRubyBase):
(WebCore::RenderRubyBase::isChildAllowed):
(WebCore::RenderRubyBase::splitToLeft):
(WebCore::RenderRubyBase::mergeWithRight):

  • rendering/RenderRubyBase.h: Added.

(WebCore::RenderRubyBase::renderName):
(WebCore::RenderRubyBase::isRubyBase):

  • rendering/RenderRubyRun.cpp: Added.

(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::~RenderRubyRun):
(WebCore::RenderRubyRun::hasRubyText):
(WebCore::RenderRubyRun::hasRubyBase):
(WebCore::RenderRubyRun::isEmpty):
(WebCore::RenderRubyRun::rubyText):
(WebCore::RenderRubyRun::rubyBase):
(WebCore::RenderRubyRun::rubyBaseSafe):
(WebCore::RenderRubyRun::firstLineBlock):
(WebCore::RenderRubyRun::updateFirstLetter):
(WebCore::RenderRubyRun::isChildAllowed):
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::removeChild):
(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):

  • rendering/RenderRubyRun.h: Added.

(WebCore::RenderRubyRun::renderName):
(WebCore::RenderRubyRun::isRubyRun):

  • rendering/RenderRubyText.cpp: Added.

(WebCore::RenderRubyText::RenderRubyText):
(WebCore::RenderRubyText::~RenderRubyText):
(WebCore::RenderRubyText::isChildAllowed):

  • rendering/RenderRubyText.h: Added.

(WebCore::RenderRubyText::renderName):
(WebCore::RenderRubyText::isRubyText):

LayoutTests:

Further layout tests will be committed in a follow-up patch under fast/ruby.

  • fast/ruby/parse-rp-expected.txt: result changed due to <rt> being rendered as block within <ruby>
17:00 Changeset [50396] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=30992
Node.isDefaultNamespace doesn't convert empty strings to null

Test: fast/dom/Node/default-namespace-empty-argument.html

  • dom/Node.cpp: (WebCore::Node::isDefaultNamespace): Per DOM 3 Core, treat empty input as null.
13:38 Changeset [50395] by eric@webkit.org
  • 4 edits in trunk

2009-11-01 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Don't add '/' to the URL path if the it does not include '/' after the protocol component
https://bugs.webkit.org/show_bug.cgi?id=30971

Updating the expected result to reflect the change.

  • fast/loader/url-parse-1-expected.txt:

2009-11-01 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Don't add '/' to the URL path if the it does not include '/' after the protocol component
https://bugs.webkit.org/show_bug.cgi?id=30971

Match IE8 behaviour, that does not add '/' if there is none after the protocol component.

  • platform/KURL.cpp: (WebCore::KURL::parse):
13:30 Changeset [50394] by oliver@apple.com
  • 4 edits in trunk/WebCore

Fix layering violations in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=30986

Reviewed by Darin Adler.

Remove uses of HTMLImageElement and HTMLCanvasElement

13:22 Changeset [50393] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-01 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=30964
[Gtk] Implemment AtkDocument

Implements what has been implemented in AT-SPI.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (GetAtkInterfaceTypeFromWAIType): (getInterfaceMaskFromObject): (atk_document_interface_init): (webkit_accessible_document_get_document_attribute_value): (webkit_accessible_document_get_document_attributes): (webkit_accessible_document_get_locale):
12:49 Changeset [50392] by eric@webkit.org
  • 9 edits in trunk

2009-11-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

  • WebKit.pri: Turn on warnings for the GCC compiler

2009-11-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

No new tests as there is no functional change.

  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::RGBA32Buffer): Reorder initialization list to fix compiler warnings.

2009-11-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): Reorder initialization list to fix compiler warnings.
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Ditto.

2009-11-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

  • DumpRenderTree/qt/main.cpp: (crashHandler): Mark function NO_RETURN
12:41 Changeset [50391] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-01 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

[Regression] monitorEvent doesn't work

  • inspector/front-end/InjectedScript.js: (InjectedScript._ensureCommandLineAPIInstalled):
12:33 Changeset [50390] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-01 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Fix Web Inspector: Bug with Message Bubble in Syntax Highlighter
https://bugs.webkit.org/show_bug.cgi?id=30990

  • inspector/front-end/SourceFrame.js:
12:04 Changeset [50389] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=30982
createHTMLDocument doesn't escape ampersand and less-than in title

Test: fast/dom/DOMImplementation/createHTMLDocument-title.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createHTMLDocument): Set document title after creating the document, avoiding parser intricacies.
08:18 Changeset [50388] by eric@webkit.org
  • 4 edits
    2 adds in trunk/LayoutTests

2009-11-01 Hironori Bono <hbono@chromium.org>

Reviewed by Darin Adler.

Bug 30902: Need a layout test for Bug 28284
This change just adds a simple test that calls TextInputController.firstRectForCharacterRange()
before and after inserting a Thai character and compare their results.
https://bugs.webkit.org/show_bug.cgi?id=30902

  • fast/text/international/thai-cursor-position-expected.txt: Added.
  • fast/text/international/thai-cursor-position.html: Added.
  • platform/gtk/Skipped: Skip this test because TextInputController is not implemented.
  • platform/qt/Skipped: ditto.
  • platform/win/Skipped: ditto.
08:11 Changeset [50387] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-01 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Double clicking on a breakpoints should not select text
https://bugs.webkit.org/show_bug.cgi?id=30950

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._documentMouseDown):
08:03 Changeset [50386] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-11-01 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent().

[Crash (debug)] Combination of list-item and :after causes assertion failure
https://bugs.webkit.org/show_bug.cgi?id=30944

  • fast/css/list-item-pseudo-nocrash-expected.txt: Added.
  • fast/css/list-item-pseudo-nocrash.html: Added.

2009-11-01 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent().

[Crash (debug)] Combination of list-item and :after causes assertion failure
https://bugs.webkit.org/show_bug.cgi?id=30944

Test: fast/css/list-item-pseudo-nocrash.html

  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent):
07:54 Changeset [50385] by eric@webkit.org
  • 4 edits in trunk

2009-11-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30586
[GTK] Failing test media/video-src-empty.html

  • platform/gtk/Skipped: Unskip fixed test.

2009-11-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30586
[GTK] Failing test media/video-src-empty.html

Correctly set network/ready state depending on GStreamer errors
received on the bus.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback):
07:25 Changeset [50384] by jberlin@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-01 Jessie Berlin <jberlin@webkit.org>

Adding myself to the committers list.

  • Scripts/modules/committers.py:

10/31/09:

16:22 Changeset [50383] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix

16:10 Changeset [50382] by oliver@apple.com
  • 2 edits in trunk/WebCore

Remove obsolete null checks from CanvasRenderingContext3DMac
https://bugs.webkit.org/show_bug.cgi?id=30983

Reviewed by Darin Adler

15:19 Changeset [50381] by oliver@apple.com
  • 6 edits
    6 adds in trunk

WebGL allows objects to be used with the wrong context
https://bugs.webkit.org/show_bug.cgi?id=30981

Reviewed by Jon Honeycutt.

Simply add null checks and a few context guards to ensure we don't
deref null or attempt to use an object from a different context.

Tests: fast/canvas/webgl/incorrect-context-object-behaviour.html

fast/canvas/webgl/null-object-behaviour.html

14:54 BuildingOnWindows edited by jberlin@webkit.org
(diff)

10/30/09:

20:48 Changeset [50380] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

20:48 Changeset [50379] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.21.8

New tag.

20:47 Changeset [50378] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Fix the build.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA):

19:11 Changeset [50377] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed failing layout test: restore a special case I accidentally deleted.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-30
Reviewed by Oliver Hunt.

  • runtime/DatePrototype.cpp:

(JSC::setNewValueFromDateArgs): In the case of applying a change to a date
that is NaN, reset the date to 0 *and* then apply the change; don't just
reset the date to 0.

17:51 Changeset [50376] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKitTools

Fix an issue that Adam noticed in DRT.

Reviewed by Darin Adler.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::role):
Get the length of the role text, and create a buffer dynamically.

17:26 Changeset [50375] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

17:25 Changeset [50374] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.21.7

New tag.

17:23 Changeset [50373] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r50356.

17:23 Changeset [50372] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-4-branch

Merge r50355.

17:23 Changeset [50371] by mrowe@apple.com
  • 7 edits in branches/safari-4-branch

Merge r50354.

17:23 Changeset [50370] by mrowe@apple.com
  • 8 edits in branches/safari-4-branch

Merge r50353.

16:18 Changeset [50369] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's MediaQueryResult
https://bugs.webkit.org/show_bug.cgi?id=30857

Reviewed by Darin Adler.

Inherits MediaQueryResult class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:5984 and
it is no need to be copyable.

  • css/CSSStyleSelector.h:
16:16 Changeset [50368] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's MediaQueryEvaluator
https://bugs.webkit.org/show_bug.cgi?id=30854

Reviewed by Darin Adler.

Inherits MediaQueryEvaluator class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:401 and
it is no need to be copyable.

  • css/MediaQueryEvaluator.h:
16:10 Changeset [50367] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's MediaQueryEvaluator
https://bugs.webkit.org/show_bug.cgi?id=30854

Reviewed by Darin Adler.

Inherits MediaQueryEvaluator class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:401 and
it is no need to be copyable.

  • css/MediaQueryEvaluator.h:
16:08 Changeset [50366] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CSSRuleSet
https://bugs.webkit.org/show_bug.cgi?id=30852

Reviewed by Darin Adler.

Inherits CSSRuleSet class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:455 and
it is no need to be copyable.

  • css/CSSStyleSelector.cpp:
16:06 Changeset [50365] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CSSRuleData
https://bugs.webkit.org/show_bug.cgi?id=30851

Reviewed by Darin Adler.

Inherits CSSRuleData class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.h:320 and
it is no need to be copyable.

  • css/CSSStyleSelector.h:
16:02 Changeset [50364] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CSSRuleDataList
https://bugs.webkit.org/show_bug.cgi?id=30850

Reviewed by Darin Adler.

Inherits CSSRuleDataList class from Noncopyable because it has been
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:2715 and
it is no need to be copyable.

  • css/CSSStyleSelector.h:
15:59 Changeset [50363] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CSSNamespace
https://bugs.webkit.org/show_bug.cgi?id=30849

Reviewed by Darin Adler.

Inherits CSSNamespace struct from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSheet.cpp:141 and
it is no need to be copyable.

  • css/CSSNamespace.h:
15:41 Changeset [50362] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-30 Eric Seidel <eric@webkit.org>

No review, rolling out r50105.
http://trac.webkit.org/changeset/50105

This commit was causing:
https://bugs.webkit.org/show_bug.cgi?id=30869
We'll re-implement the feature a different way.

  • Scripts/bugzilla-tool:
15:35 Changeset [50361] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: update for object-to-pointer change.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-30

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

15:26 Changeset [50360] by dimich@chromium.org
  • 5 edits in trunk/WebCore

Refactor DatabaseTask in preparation for removing threadsafe refcounting from it.
Move the synchronizer object out of the DatabaseTask so there is no need to keep
the pointer to Databasetask around after passing it to MessageQueue.
Also pass the references to return parameters to the task so it can update them.
https://bugs.webkit.org/show_bug.cgi?id=30941

Reviewed by David Levin.

No new tests, since this is just moving the code around, no change in functionality.

  • storage/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::openAndVerifyVersion): Use new DatabaseTaskSynchronizer to wait for task completion.
(WebCore::Database::markAsDeletedAndClose): Ditto.
(WebCore::Database::tableNames): Ditto.
(WebCore::Database::stop): Use the boolean flag rather then 'killed' flag built into MessageQueue.
(WebCore::Database::scheduleTransaction): Transaction queue is a Deque now, change the way to fetch the transaction.

  • storage/Database.h: Change the SQLTransaction queue to be a Deque rather then a MessageQueue.
  • storage/DatabaseTask.cpp:

(WebCore::DatabaseTaskSynchronizer::DatabaseTaskSynchronizer):
(WebCore::DatabaseTaskSynchronizer::waitForTaskCompletion):
(WebCore::DatabaseTaskSynchronizer::taskCompleted):
(WebCore::DatabaseTask::DatabaseTask): Ctor takes DatabaseTaskSynchronizer which can be 0.
(WebCore::DatabaseTask::performTask): Signal completion. m_synchronizer should still be around since main thread is waiting on it.
(WebCore::DatabaseOpenTask::DatabaseOpenTask): Pass synchronizer and return parameters via constructor.
(WebCore::DatabaseCloseTask::DatabaseCloseTask): Ditto.
(WebCore::DatabaseTransactionTask::DatabaseTransactionTask): Ditto.
(WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask): Ditto.

  • storage/DatabaseTask.h:

(WebCore::DatabaseOpenTask::create):
(WebCore::DatabaseCloseTask::create):
(WebCore::DatabaseTransactionTask::create):
(WebCore::DatabaseTableNamesTask::create):

15:23 Changeset [50359] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=30942
Use pointers instead of copies to pass GregorianDateTime objects around.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-29
Reviewed by Darin Adler.

SunSpider reports a shocking 4.5% speedup on date-format-xparb, and 1.3%
speedup on date-format-tofte.

  • runtime/DateInstance.cpp:

(JSC::DateInstance::gregorianDateTime):

  • runtime/DateInstance.h:
  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Renamed getGregorianDateTime to gregorianDateTime,
since it no longer has an out parameter. Uses 0 to indicate invalid dates.

15:09 Changeset [50358] by adele@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION: In Mail, Undo does not restore some characters I have deleted at the end of a line
https://bugs.webkit.org/show_bug.cgi?id=30955
<rdar://problem/7067033>

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-30
Reviewed by Darin Adler.

WebCore:

When the command is deleteWordBackward or deleteWordForward
we should not add to the open typing command, but
create a new one.

Test: editing/undo/undo-deleteWord.html

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteKeyPressed): Always start a new command if the granularity is
not CharacterGranularity.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Always start a new command if the granularity is
not CharacterGranularity.

LayoutTests:

  • editing/undo/undo-deleteWord-expected.txt: Added.
  • editing/undo/undo-deleteWord.html: Added.
15:03 Changeset [50357] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2009-10-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Make MediaPlayer constructor private
https://bugs.webkit.org/show_bug.cgi?id=30965

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::finishParsingChildren): Use MediaPlayer::create.
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::create): New.
14:38 Changeset [50356] by jhoneycutt@apple.com
  • 3 edits
    2 adds in trunk

Test for MSAA: Accessibility of headings is not correct

https://bugs.webkit.org/show_bug.cgi?id=30937

Reviewed by Adam Roben.

WebKitTools:

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::role):
Allow the role returned to be a BSTR.
(AccessibilityUIElement::description):
Fix a copy/paste error.

LayoutTests:

  • platform/win/accessibility/heading-elements-expected.txt: Added.
  • platform/win/accessibility/heading-elements.html: Added.
14:38 Changeset [50355] by jhoneycutt@apple.com
  • 7 edits
    2 adds in trunk

Test for MSAA: Accessibility of links is wrong

https://bugs.webkit.org/show_bug.cgi?id=30928

Reviewed by Darin Adler.

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(getAccessibilityValueCallback):
Return the accessibility value.
(AccessibilityUIElement::getJSClass):
Added "accessibilityValue" value.

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::accessibilityValue):
Stubbed.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::accessibilityValue):
Stubbed.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::accessibilityValue):
Get the object's value, and return it as a JS string.

LayoutTests:

  • platform/win/accessibility/linked-elements-expected.txt: Added.
  • platform/win/accessibility/linked-elements.html: Added.
14:38 Changeset [50354] by jhoneycutt@apple.com
  • 7 edits in trunk

MSAA: Accessibility of headings is not correct

https://bugs.webkit.org/show_bug.cgi?id=30937

Reviewed by Alice Liu.

WebCore:

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::stringRoleForMSAA):
(WebCore::AccessibilityObject::descriptionForMSAA):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::shouldReturnTagNameAsRoleForMSAA):
If the element's tag name is one of h1, h2, h3, h4, h5, h6, return
true.
(WebCore::AccessibilityRenderObject::stringRoleForMSAA):
If the element should return its tag name as the role, return the tag
name.
(WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA):
If the object is a heading, return the string "L" followed by the
heading level.
(WebCore::AccessibilityRenderObject::descriptionForMSAA):
If the object has a positional description, return it. Otherwise, get
the accessibility description, and prefix it with "Description" so that
MSAA clients know that it's not a positional description.

  • accessibility/AccessibilityRenderObject.h:

WebKit/win:

  • AccessibleBase.cpp:

(AccessibleBase::get_accDescription):
Call the object's descriptionForMSAA(). Moved the comment to the
WebCore file.
(AccessibleBase::get_accRole):
If the object has a string role, return that. Otherwise, return the
integer role.

  • AccessibleBase.h:

Removed description(), as this was moved to WebCore.

14:37 Changeset [50353] by jhoneycutt@apple.com
  • 8 edits in trunk

MSAA: Accessibility of links is wrong

https://bugs.webkit.org/show_bug.cgi?id=30928

Reviewed by Darin Adler.

WebCore:

  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::stringValueForMSAA):
Return the URL.
(WebCore::AccessibilityImageMapLink::nameForMSAA):
Return the alt text.

  • accessibility/AccessibilityImageMapLink.h:

(WebCore::AccessibilityImageMapLink::isLinked):
Return true.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isLinked):
(WebCore::AccessibilityObject::stringValueForMSAA):
(WebCore::AccessibilityObject::nameForMSAA):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::isLinkable):
Return true if the element is considered "linkable" with respect to
accessibility.
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
If the element is linkable, check whether it has a parent anchor
element. If so, return the anchor element's href.
(WebCore::AccessibilityRenderObject::isLinked):
Return true if the element is linkable and if it's parent anchor tag's
href is non-empty.
(WebCore::AccessibilityRenderObject::nameForMSAA):
For text nodes, return the text.

  • accessibility/AccessibilityRenderObject.h:

WebKit/win:

  • AccessibleBase.cpp:

(AccessibleBase::get_accState):
Check whether the element is linked, instead of whether the node is an
anchor, so the child "linkable" elements of anchor elements will also
be "linked".
(AccessibleBase::name):
Return the name for MSAA.
(AccessibleBase::value):
Return the string value for MSAA.

14:20 Changeset [50352] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/WebKitPrefix.cpp

Touch WebKitPrefix to force rebuild of WebKit.

13:59 Changeset [50351] by levin@chromium.org
  • 24 edits in trunk

Notify the chrome when the focused node has changed.
https://bugs.webkit.org/show_bug.cgi?id=30832

Patch by Evan Stade <estade@chromium.org> on 2009-10-30
Reviewed by David Levin.

WebCore:

This is similar to AX code that is already in place, except that this also informs the
chrome when there stops being a focused node. This is needed for a browser to show the
anchor for links that have keyboard focus.

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::focusedNodeChanged):

  • page/Chrome.cpp:

(WebCore::Chrome::focusedNodeChanged):

  • page/Chrome.h:
  • page/ChromeClient.h:

WebKit/gtk:

Added stub implementation for new ChromeClient function.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::focusedNodeChanged):

  • WebCoreSupport/ChromeClientGtk.h:

WebKit/haiku:

Added stub implementation for new ChromeClient function.

  • WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientHaiku::focusedNodeChanged):

  • WebCoreSupport/ChromeClientHaiku.h:

WebKit/mac:

Added stub implementation for new ChromeClient function.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::focusedNodeChanged):

WebKit/qt:

Added stub implementation for new ChromeClient function.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::focusedNodeChanged):

  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

Added stub implementation for new ChromeClient function.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::focusedNodeChanged):

  • WebCoreSupport/WebChromeClient.h:

WebKit/wx:

Added stub implementation for new ChromeClient function.

  • WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::focusedNodeChanged):

  • WebKitSupport/ChromeClientWx.h:
13:20 Changeset [50350] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-10-30 Ben Murdoch <benm@google.com>

Reviewed by David Kilzer.

openDatabase() with empty version sets db version up incorrectly
https://bugs.webkit.org/show_bug.cgi?id=28417

  • storage/open-database-set-empty-version-expected.txt: Added.
  • storage/open-database-set-empty-version.html: Added.

2009-10-30 Ben Murdoch <benm@google.com>

Reviewed by David Kilzer.

openDatabase() with empty version sets db version up incorrectly
https://bugs.webkit.org/show_bug.cgi?id=28417

Test: storage/open-database-set-empty-version.html

  • storage/Database.cpp: (WebCore::Database::performOpenAndVerify): Raise an exception if the current database version does not match the expected version when the current version is the empty string.
12:52 Changeset [50349] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

Fix typo in command name used by wx build system.

12:37 Changeset [50348] by eric@webkit.org
  • 8 edits in trunk/WebCore

2009-10-30 John Gregg <johnnyg@google.com>

Reviewed by David Levin.

Need to turn off notifications properly at runtime
https://bugs.webkit.org/show_bug.cgi?id=30409

Moving the notificationsEnabled bit from NotificationCenter
to the new V8 RuntimeEnabledFeatures object.

Just moving a bit around, so no new tests.

  • bindings/v8/RuntimeEnabledFeatures.cpp:
  • bindings/v8/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setNotificationsEnabled): (WebCore::RuntimeEnabledFeatures::notificationsEnabled):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
  • notifications/NotificationCenter.cpp:
  • notifications/NotificationCenter.h:
11:31 Changeset [50347] by dimich@chromium.org
  • 14 edits in trunk/WebCore

[V8] More cleanup after r49949: remove ListenerGuard.
ListenerGuard is no longer needed since EventListeners do not depend on frame or v8 context.
https://bugs.webkit.org/show_bug.cgi?id=30943

Reviewed by Dimitri Glazkov.

Covered by fast/events/add-event-without-document.html which will now pass in Chromium.

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::handleEvent):

  • bindings/v8/V8AbstractEventListener.h:
  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getEventListener):

  • bindings/v8/V8EventListenerList.h:

(WebCore::V8EventListenerList::findOrCreateWrapper):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::V8Proxy):
(WebCore::V8Proxy::disconnectFrame):
(WebCore::V8Proxy::clearForNavigation):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/V8WorkerContextEventListener.cpp:

(WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener):
(WebCore::V8WorkerContextEventListener::handleEvent):
(WebCore::V8WorkerContextEventListener::reportError):

  • bindings/v8/V8WorkerContextEventListener.h:

(WebCore::V8WorkerContextEventListener::create):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::dispose):
(WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):

  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/custom/V8CustomEventListener.cpp:

(WebCore::V8EventListener::V8EventListener):

  • bindings/v8/custom/V8CustomEventListener.h:

(WebCore::V8EventListener::create):

11:19 Changeset [50346] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-30 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Patch v1 is a dumb default name for patches
https://bugs.webkit.org/show_bug.cgi?id=30952

Let's use "Patch" instead.

  • Scripts/bugzilla-tool:
10:57 Changeset [50345] by hamaji@chromium.org
  • 3 edits
    2 adds in trunk

2009-10-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

counterValueForElementById should return space-separated string for multiple counters
https://bugs.webkit.org/show_bug.cgi?id=30939

Test: fast/css/counters/counterValueForElementById.html

  • rendering/RenderTreeAsText.cpp: (WebCore::writeCounterValuesFromChildren): (WebCore::counterValueForElement):

2009-10-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

counterValueForElementById should return space-separated string for multiple counters
https://bugs.webkit.org/show_bug.cgi?id=30939

  • fast/css/counters/counterValueForElementById-expected.txt: Added.
  • fast/css/counters/counterValueForElementById.html: Added.
10:50 Changeset [50344] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-10-30 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Remove the QWebInspector::windowTitleChanged signal,
QEvent::WindowTitleChange can be used to achieve the same.
https://bugs.webkit.org/show_bug.cgi?id=30927

  • Api/qwebinspector.cpp:
  • Api/qwebinspector.h:
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::updateWindowTitle):
10:43 Changeset [50343] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-30 Sebastian Dröge <sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint): Add some comments to explain what is happening here.
10:35 Changeset [50342] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-30 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Fix Web Inspector crash on the errors/warnings counter click

RenderObject::createVisiblePosition(const Position& position)
understands "null Positions", so we can construct such a Position manually.

https://bugs.webkit.org/show_bug.cgi?id=30499

  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
10:27 Changeset [50341] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-30 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Fix Web Inspector crash on the errors/warnings counter click

RenderObject::createVisiblePosition(const Position& position)
understands "null Positions", so we can construct such a Position manually.

https://bugs.webkit.org/show_bug.cgi?id=30499

  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
10:26 Changeset [50340] by hamaji@chromium.org
  • 3 edits in trunk/LayoutTests

2009-10-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Mark Rowe.

fast/css/counters/t1204* are not asynchronous anymore
https://bugs.webkit.org/show_bug.cgi?id=30940

  • fast/css/counters/t1204-increment-00-c-o.html:
  • fast/css/counters/t1204-increment-01-c-o.html:
10:19 Changeset [50339] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-30 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25534
[GTK] Objects of ROLE_TABLE should implement the accessible table interface

Second part of the implementation of AtkTable.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (cellAtIndex): (webkit_accessible_table_get_column_at_index): (webkit_accessible_table_get_row_at_index): (webkit_accessible_table_get_caption): (atk_table_interface_init):
09:40 Changeset [50338] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/WebCorePrefix.cpp

Touch WebCorePrefix to try and force a clean build.

09:18 Changeset [50337] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-10-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add TimelinePanel into the panels enum.

https://bugs.webkit.org/show_bug.cgi?id=30915

  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::showPanel):
  • inspector/front-end/inspector.js: (WebInspector.showTimelinePanel):
08:48 Changeset [50336] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed trivial buildfix.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-30
[Qt] Buildfix for r50333.

  • DumpRenderTree/qt/DumpRenderTree.pro:
08:00 Changeset [50335] by kenneth@webkit.org
  • 7 edits in trunk/LayoutTests

Unreviewed layout test fixes.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-30
The existing excepted results were wrong, due to the visited links not
being reset between tests.

This was fixed in r50329, so updating the results.

  • platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
07:13 Changeset [50334] by ossy@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

[Qt] Add expected files for new svg tests we pass.
Compared to the Mac expected png files.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-30
Reviewed by Holger Hans Peter Freyther.

  • platform/qt/svg/css/arrow-with-shadow-expected.txt: Added.
  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
  • platform/qt/svg/css/clippath-with-shadow-expected.txt: Added.
  • platform/qt/svg/css/mask-with-shadow-expected.txt: Added.
  • platform/qt/svg/css/path-with-shadow-expected.txt: Added.
  • platform/qt/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/qt/svg/filters/shadow-on-filter-expected.txt: Added.
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt: Added.
07:02 Changeset [50333] by tonikitoo@webkit.org
  • 2 edits
    2 deletes in trunk/WebKitTools

[Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
https://bugs.webkit.org/show_bug.cgi?id=30953

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-30
Reviewed by Holger Freyther.

DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
makes qt DRT to share this implementation (as gtk and mac ports do).

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/WorkQueue.cpp: Removed.
  • DumpRenderTree/qt/WorkQueue.h: Removed.
06:51 Changeset [50332] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed potential buildbot fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-30
Second try: Reset page history before running each test.

Apparently the QWebHistory::clear() keeps the current page
in history which is not what we want, so we not additionally
sets the history capacity to 0 (forces removing everything)
and then sets it back to its original value.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

06:38 Changeset [50331] by yurys@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

changelog date

06:29 Changeset [50330] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

If the owner widget of the page has a palette set, we
should use that one. This was only working when the
owner was a QWebView. This patch fixes that.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-30
Reviewed by Holger Hans Peter Freyther.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::applyTheme):

06:07 Changeset [50329] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed potential buildbot fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-30
Reset page history before running each test.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

05:12 QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
(diff)
03:50 Changeset [50328] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-30 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Wire CookieJarChromium to the cookies
backend. This is a final step of a 3-steps raw cookies
access implementation in Chromium.

  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
03:32 Changeset [50327] by yurys@chromium.org
  • 7 edits in trunk/WebCore

2009-10-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Fix Chromium crash in console.log in "deeply recursive" function

Check that result of 'frameSourceName' is not null handle
before casting it to String.


Allow V8Proxy::sourceName/sourceLineNumber() to report
that they have failed due to JavaScript stack overflow.

https://bugs.webkit.org/show_bug.cgi?id=30904

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::sourceLineNumber): (WebCore::V8Proxy::sourceName):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
02:27 Changeset [50326] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's MediaQueryExp
https://bugs.webkit.org/show_bug.cgi?id=30855

Reviewed by Darin Adler.

Inherits MediaQueryExp class from FastAllocBase because it is
instantiated by 'new' in WebCore/css/CSSParser.cpp:4874.

  • css/MediaQueryExp.h:
01:55 Changeset [50325] by abarth@webkit.org
  • 1 edit
    1 add in trunk

2009-10-30 Adam Barth <abarth@webkit.org>

Reviewed by Mark Rowe.

Teach git to ignore some files
https://bugs.webkit.org/show_bug.cgi?id=30951

Ignore WebKitBuild because we never want to version that directory.
Also, ignore the xcode project files so git clean doesn't blow away
your project settings. Finally, ignore the compiled python files in
WebKitTools/Script modules because they clutter up git status.

  • .gitignore: Added.
01:53 Changeset [50324] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

Allow custom memory allocation control for JavaScriptCore's ListHashSet
https://bugs.webkit.org/show_bug.cgi?id=30853

Reviewed by Darin Adler.

Inherits ListHashSet class from FastAllocBase because it is
instantiated by 'new' in WebCore/rendering/RenderBlock.cpp:1813.

  • wtf/ListHashSet.h:
01:13 Changeset [50323] by oliver@apple.com
  • 5 edits in trunk

Regression: crash enumerating properties of an object with getters or setters
https://bugs.webkit.org/show_bug.cgi?id=30948

Reviewed by Gavin Barraclough

Add a guard to prevent us trying to cache property enumeration on
objects with getters or setters.

Note: See TracTimeline for information about the timeline view.