Timeline


and

11/12/09:

23:52 Changeset [50930] by mitz@apple.com
  • 4 edits in trunk/WebKit/mac

When exiting full-screen video, rather than resetting the system UI
mode, restore it to what it was when full-screen mode was entered.

Reviewed by Adele Peterson.

  • WebView/WebVideoFullscreenController.h: Cleaned up style, removed

unnecessary imports, and added _savedUIMode and _savedUIOptions ivars.

  • WebView/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController delegate]): Cleaned up style.
(-[WebVideoFullscreenController setDelegate:]): Ditto.
(-[WebVideoFullscreenController windowDidExitFullscreen]): Restore the
system UI mode.
(-[WebVideoFullscreenController windowDidEnterFullscreen]): Save the
system UI mode.

  • WebView/WebView.mm: Added now-necessary import.
22:42 Changeset [50929] by eric@webkit.org
  • 7 edits in trunk

2009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org>

Reviewed by Adam Barth.

The document-html and window-html tests don't use a setTimeout to notify that the
test is completed. The layout test plugin now issues the notifyDone call via
javascript.

https://bugs.webkit.org/show_bug.cgi?id=31067

  • plugins/document-open.html:
  • plugins/window-open.html:

2009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org>

Reviewed by Adam Barth.

The document-open.html test was flaky at times. The test invokes the layout test plugin
which in its destroy stream handler opens a new document. This basically tears down the
stream and the associated plugin instance, which causes a crash when the plugin stream
dereferences an invalid m_client pointer which points to the PluginView instance which
is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
and check for the same.

https://bugs.webkit.org/show_bug.cgi?id=31067

  • plugins/PluginStream.cpp: (WebCore::PluginStream::stop): (WebCore::PluginStream::destroyStream):

2009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org>

Reviewed by Adam Barth.

The document-open.html test was flaky at times. The test invokes the layout test plugin
which in its destroy stream handler opens a new document. This basically tears down the
stream and the associated plugin instance. The pluginLog function in the layout test
plugin attempts to retrieve the window script object on a torn down plugin instance
which crashed consistently on windows in the debugger. The functions which issue
these logs already have a valid window script object. We now have variants of the pluginLog
function which take in a window script object with and without variable arguments.

https://bugs.webkit.org/show_bug.cgi?id=31067

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginLogWithWindowObject): (pluginLogWithWindowObjectVariableArgs): (pluginLog): (notifyTestCompletion): (testDocumentOpen): (testWindowOpen):
21:17 Changeset [50928] by dumi@chromium.org
  • 5 edits in trunk

Renaming some parameters passed to DB-related methods to better
indicate their purpose.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31449

WebCore:

  • platform/chromium/ChromiumBridge.h:

WebKit/chromium:

  • public/WebKitClient.h:
  • src/ChromiumBridge.cpp:

(WebCore::ChromiumBridge::databaseOpenFile):
(WebCore::ChromiumBridge::databaseDeleteFile):
(WebCore::ChromiumBridge::databaseGetFileAttributes):
(WebCore::ChromiumBridge::databaseGetFileSize):

21:08 Changeset [50927] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-11-12 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by Adam Barth.

Calculate the time offset only if we were able to parse
the date string. This saves an IPC in Chromium for
invalid date strings.
https://bugs.webkit.org/show_bug.cgi?id=31416

  • wtf/DateMath.cpp: (WTF::parseDateFromNullTerminatedCharacters): (JSC::parseDateFromNullTerminatedCharacters):
20:59 Changeset [50926] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-11-12 Kinuko Yasuda <kinuko@google.com>

Reviewed by Adam Barth.

Makes the output of fast/events/mouse-click-events.html independent
of the window size.
https://bugs.webkit.org/show_bug.cgi?id=31405

  • fast/events/mouse-click-events-expected.txt:
  • fast/events/script-tests/mouse-click-events.js:
20:36 Changeset [50925] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2009-11-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Transformed reflected elements are clipped inside element with opacity
https://bugs.webkit.org/show_bug.cgi?id=30957

transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
each clip rect into painting space before taking the unions. This, however, did not work
correctly with combinations of reflections and transforms. Fixed by unioning the
clipRect and mapping through transforms along the way.

Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
where the transparency layers are.

Test: fast/reflections/opacity-reflection-transform.html

  • rendering/RenderLayer.cpp: (WebCore::expandClipRectForDescendantsAndReflection): (WebCore::transparencyClipBox): (WebCore::RenderLayer::beginTransparencyLayers):
19:17 QtWebKitPlugins edited by yael.aharon@nokia.com
(diff)
19:05 Changeset [50924] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-12 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Improve SecurityOrigin::toString comment
https://bugs.webkit.org/show_bug.cgi?id=31041

  • page/SecurityOrigin.h:
18:37 Changeset [50923] by hamaji@chromium.org
  • 12 edits in trunk

2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393

No new tests as this is just a refactoring.

  • WebCore.base.exp:
  • rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation):
  • rendering/RenderTreeAsText.h:

2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393

No new tests as this is just a refactoring.

  • webkit/webkitwebframe.cpp: (webkit_web_frame_dump_render_tree):

2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393

No new tests as this is just a refactoring.

  • Misc/WebCoreStatistics.mm: (-[WebFrame renderTreeAsExternalRepresentation]):

2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393

No new tests as this is just a refactoring.

  • Api/qwebframe.cpp: (QWebFrame::renderTreeDump):

2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393

No new tests as this is just a refactoring.

  • WebFrame.cpp: (WebFrame::renderTreeAsExternalRepresentation):
18:22 Changeset [50922] by benm@google.com
  • 3 edits
    1 delete in trunk/WebCore

[Android] The Android specific files in page/Android are out of date.
https://bugs.webkit.org/show_bug.cgi?id=31437

Reviewed by Dimitri Glazkov.

No tests required.

  • page/android/DragControllerAndroid.cpp:

(WebCore::DragController::dragOperation): Added.
(WebCore::DragController::cleanupAfterSystemDrag):

  • page/android/EventHandlerAndroid.cpp:

(WebCore::EventHandler::accessKeyModifiers): Added.

  • page/android/InspectorControllerAndroid.cpp: Removed.
17:59 Changeset [50921] by eric@webkit.org
  • 9 edits
    2 adds in trunk

2009-11-12 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Gustavo Noronha Silva.

https://bugs.webkit.org/show_bug.cgi?id=30997
[Gtk] Implemment AtkDocument

Added testing support for AtkDocument implementation.

  • accessibility/document-attributes.html: Added.
  • accessibility/document-attributes-expected.txt: Added.
  • platform/mac/Skipped:
  • platform/win/Skipped:

2009-11-12 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Gustavo Noronha Silva.

https://bugs.webkit.org/show_bug.cgi?id=30997
[Gtk] Implemment AtkDocument

Added testing support.

  • DumpRenderTree/AccessibilityUIElement.cpp:
  • DumpRenderTree/AccessibilityUIElement.h: (getDocumentEncodingCallback): (getDocumentURICallback): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::documentEncoding): (AccessibilityUIElement::documentURI):
17:47 Changeset [50920] by bfulgham@webkit.org
  • 10 edits
    5 adds in trunk

WebCore: [CAIRO] shadow support for Canvas and SVG.
https://bugs.webkit.org/show_bug.cgi?id=30960

Reviewed by Simon Fraser.

Implement Canvas/SVG shadow support for Cairo. This patch
uses the filter code from SVG Filters. That means that it is
necessary to activate filters to see the shadows.

Test: fast/canvas/canvas-shadow.html

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(GraphicsContext::calculateShadowBufferDimensions): New helper routine.
(WebCore::setPlatformFill):
(WebCore::setPlatformStroke):
(WebCore::copyContextProperties):
(WebCore::drawPathShadow):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::createPlatformShadow):

  • platform/graphics/cairo/ImageCairo.cpp:

(WebCore::BitmapImage::draw): Add filter effect.

  • platform/graphics/filters/Filter.h: Correct 'const' signatures.
  • platform/graphics/filters/ImageBufferFilter.cpp: Added.
  • platform/graphics/filters/ImageBufferFilter.h: Added.
  • svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
  • svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.

LayoutTests: Some tests for canvas shadow.

Patch by Dirk Schulze <krit@webkit.org> on 2009-11-11
Reviewed by Simon Fraser.

  • fast/canvas/canvas-shadow-expected.txt: Added.
  • fast/canvas/canvas-shadow.html: Added.
  • fast/canvas/script-tests/canvas-shadow.js: Added.
17:12 Changeset [50919] by dimich@chromium.org
  • 4 edits in trunk/WebCore

Add postTaskToMainThread to ScriptExecutionContext.
Move the code to post task to the main thread into a new method on ScriptExecutionContext,
to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
contexts that live on the main thread.
https://bugs.webkit.org/show_bug.cgi?id=31427

Reviewed by Alexey Proskuryakov.

No new tests - simply moving the code.

  • dom/Document.cpp:

(WebCore::Document::postTask):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::ScriptExecutionContextTaskTimer::fired):
(WebCore::PerformTaskData::PerformTaskData):
(WebCore::PerformTaskData::performTask):
(WebCore::ScriptExecutionContext::postTaskToMainThread):

  • dom/ScriptExecutionContext.h:
16:44 Changeset [50918] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-11-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Fix crash when removing compositing layers when GC is enabled
https://bugs.webkit.org/show_bug.cgi?id=31429

Workaround <rdar://problem/7390716> by special-casing the removal
of all sublayers when GC is enabled.

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::safeSetSublayers): (WebCore::GraphicsLayerCA::updateSublayerList): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
16:38 Changeset [50917] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Steve Falkenburg.

Add failing tests to Skipped list.

  • platform/win/Skipped:
16:28 Changeset [50916] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

Rollout r50896 until i can work out why it causes failures.

16:23 Changeset [50915] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Remove LIBRARY directive from def file to fix Debug_All target.

Reviewed by Stephanie Lewis.

16:17 Changeset [50914] by snej@chromium.org
  • 4 edits in trunk/WebCore

The last of the V8 binding optimizations.

  • Replace string-valued element accessors with a shared getter/setter function.
  • Change error handling flow of control to avoid extra branches and function calls.

https://bugs.webkit.org/show_bug.cgi?id=31443

Reviewed by Dimitri Glazkov.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Binding.cpp:

(WebCore::getElementStringAttr): Body of string-valued Element getter function.
(WebCore::setElementStringAttr): Body of string-valued Element setter function.

  • bindings/v8/V8Binding.h:
15:48 Changeset [50913] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping tests that fail intermitently.

15:46 Changeset [50912] by kov@webkit.org
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Add ChangeLog entry to the last commit

15:39 Changeset [50911] by kov@webkit.org
  • 1 edit in trunk/JavaScriptCore/wtf/FastMalloc.h

Revert "Export fastMalloc, fastCalloc, fastRealloc and fastFree on GCC/Unix"

This reverts commit d3f6ad156fc2ba883fdff85e7121bee9537cd021.

Conflicts:

JavaScriptCore/ChangeLog

15:21 Changeset [50910] by weinig@apple.com
  • 3 edits
    3 adds in trunk

WebCore: Fix for <rdar://problem/7267951>
Canvas methods should reject uses of NaN and Infinity.

Reviewed by Oliver Hunt.

Test: fast/canvas/canvas-with-illegal-args.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::scale):
(WebCore::CanvasRenderingContext2D::rotate):
(WebCore::CanvasRenderingContext2D::translate):
(WebCore::CanvasRenderingContext2D::transform):
(WebCore::CanvasRenderingContext2D::setTransform):

LayoutTests: Test for <rdar://problem/7267951>
Canvas methods should reject uses of NaN and Infinity.

Reviewed by Oliver Hunt.

  • fast/canvas/canvas-with-illegal-args-expected.txt: Added.
  • fast/canvas/canvas-with-illegal-args.html: Added.
  • fast/canvas/script-tests/canvas-with-illegal-args.js: Added.
15:07 Changeset [50909] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-11-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: profile timeline panel, fix obvious problems.

https://bugs.webkit.org/show_bug.cgi?id=31432

  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._setWindowPosition): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.get minimumBoundary): (WebInspector.TimelineCalculator.prototype.get maximumBoundary): (WebInspector.TimelineCalculator.prototype.reset): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.formatValue): (WebInspector.TimelineGraph): (WebInspector.TimelineGraph.prototype.refresh):
  • inspector/front-end/utilities.js: (Element.prototype.hasStyleClass):
15:04 Changeset [50908] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: preload status bar button glyphs
in order to prevent them from flickering.

https://bugs.webkit.org/show_bug.cgi?id=31439

  • inspector/front-end/inspector.js: (preloadImages):
14:41 Changeset [50907] by aroben@apple.com
  • 36 edits
    6 adds in trunk

Replace worldIDs with world objects

Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
user scripts/stylesheets and isolated worlds

Reviewed by Sam Weinig.

WebCore:

Covered by existing tests.

  • WebCore.base.exp: Update exported symbols to match what now exists

and is needed by WebKit.

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute): Updated for function rename.

  • bindings/js/ScriptController.cpp: Removed code that dealt with

worldIDs.
(WebCore::ScriptController::createWorld): Added. Returns a new world
suitable for use on the main thread.
(WebCore::ScriptController::executeScriptInWorld): Renamed from
executeScriptInIsolatedWorld, since this works just fine with a
"normal" world.

  • bindings/js/ScriptController.h: Added createWorld, removed functions

that took worldIDs, renamed executeScriptInIsolatedWorld to
executeScriptInWorld.

  • page/Frame.cpp:

(WebCore::Frame::injectUserScripts):
(WebCore::Frame::injectUserScriptsForWorld):
Updated for changes to UserScriptMap and ScriptController.

  • page/Frame.h: Changed injectUserScriptsForWorld to take a

DOMWrapperWorld* instead of a worldID.

  • page/PageGroup.cpp:

(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):

  • page/PageGroup.h:

Changed these functions to take a DOMWrapperWorld* instead of a
worldID. Also updated for changes to UserScript and UserStyleSheet.

  • page/UserScript.h:
  • page/UserStyleSheet.h: Changed not to hold a worldID, since it was

never used.

  • page/UserScriptTypes.h:
  • page/UserStyleSheetTypes.h: Changed UserScriptMap and

UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
worldID as their key type.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Added WebScriptWorld to the project.

WebKit/mac:

WebScriptWorld is the new object that represents a world. The only
place worldID is still used is in -[WebFrame
_stringByEvaluatingJavaScriptInIsolatedWorld:WithGlobalObject:FromString:],
but that will change soon.

  • WebKit.exp: Export WebScriptWorld.
  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptInIsolatedWorld:WithGlobalObject:FromString:]):
Moved the bizarre world caching/creation logic that DRT depends on
here from the findWorld function in ScriptController.cpp. Updated to
use ScriptController::executeScriptInWorld instead of
ScriptController::executeScriptInIsolatedWorld.
(-[WebFrame _contextForWorld:]): Renamed from contextForWorldID:. Now
takes a WebScriptWorld.

  • WebView/WebFramePrivate.h: Replaced contextForWorldID: with

_contextForWorld:.

  • WebView/WebScriptWorld.h: Added.
  • WebView/WebScriptWorld.mm: Added.

(-[WebScriptWorld initWithWorld:]): Store the passed-in world in our
_private member.
(-[WebScriptWorld init]): Create a new DOMWrapperWorld and pass it to
-initWithWorld:.
(-[WebScriptWorld dealloc]): Release _private.
(+[WebScriptWorld standardWorld]): Returns a shared instance that
represents WebCore's mainThreadNormalWorld().
(+[WebScriptWorld world]): Returns a new instance.
(core): Returns the DOMWrapperWorld for this WebScriptWorld.

  • WebView/WebScriptWorldInternal.h: Added.
  • WebView/WebView.mm:

(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:]):
(+[WebView _removeUserScriptFromGroup:world:url:]):
(+[WebView _removeUserStyleSheetFromGroup:world:url:]):
(+[WebView _removeUserScriptsFromGroup:world:]):
(+[WebView _removeUserStyleSheetsFromGroup:world:]):

  • WebView/WebViewPrivate.h:

Changed these functions to take a WebScriptWorld instead of a worldID.

WebKit/win:

WebScriptWorld is the new object that represents a world. The only
place worldID is still used is in
IWebFramePrivate::stringByEvaluatingJavaScriptInIsolatedWorld, but
that will change soon.

  • ForEachCoClass.h: Added WebScriptWorld.
  • Interfaces/IWebFramePrivate.idl: Replaced contextForWorldID with

contextForWorld.

  • Interfaces/IWebScriptWorld.idl: Added.
  • Interfaces/IWebViewPrivate.idl: Changed the user script/stylesheet

functions to take an IWebScriptWorld instead of a worldID.

  • Interfaces/WebKit.idl: Added WebScriptWorld.
  • WebFrame.cpp:

(WebFrame::contextForWorld): Renamed from contextForWorldID. Now takes
an IWebScriptWorld.
(WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld): Moved the
bizarre world caching/creation logic that DRT depends on here from the
findWorld function in ScriptController.cpp. Updated to use
ScriptController::executeScriptInWorld instead of
ScriptController::executeScriptInIsolatedWorld.

  • WebFrame.h: Replaced contextForWorldID with contextForWorld.
  • WebScriptWorld.cpp: Added.

(WebScriptWorld::WebScriptWorld):
(WebScriptWorld::~WebScriptWorld):
(WebScriptWorld::createInstance):
(WebScriptWorld::AddRef):
(WebScriptWorld::Release):
(WebScriptWorld::QueryInterface):
Standard COM class implementations.

(WebScriptWorld::standardWorld): Returns a shared instance that represents
WebCore's mainThreadNormalWorld().

  • WebScriptWorld.h: Added.

(WebScriptWorld::world): Simple getter.

  • WebKit.vcproj/Interfaces.vcproj: Added IWebScriptWorld.idl.
  • WebKit.vcproj/WebKit.vcproj: Added WebScriptWorld.
  • WebKitClassFactory.cpp: Added WebScriptWorld.
  • WebView.cpp:

(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):

  • WebView.h:

Changed these functions to take an IWebScriptWorld instead of a worldID.

WebKitTools:

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
Changed these functions to create a new WebJSWorld each time they're
called and to pass that world to WebKit.

14:40 Changeset [50906] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Small clean-up in WebView's user content functions

Preparation for <http://webkit.org/b/31414> Implement new SPI for
dealing with user scripts/stylesheets and isolated worlds

Reviewed by Dave Hyatt.

  • WebView.cpp:

(toString):
(toKURL):
Added these helper functions to convert BSTRs to WebCore types.

(toStringVector):
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
(WebView::removeAllUserContentFromGroup):
Use the new helper functions.

14:24 Changeset [50905] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

Fixes <http://webkit.org/b/31260>.
Web Inspector: Main Resources Other than HTML are mis-detected.

Reviewed by Tim Hatcher.

Even if the resource is a main resource, look at its CachedResource type,
because it might be an image, stylesheet, or JavaScript file, and we
want to show them all correctly.

  • inspector/InspectorResource.cpp:

(WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
(WebCore::InspectorResource::type):

  • inspector/InspectorResource.h:
14:13 Changeset [50904] by mrowe@apple.com
  • 3 edits in trunk/LayoutTests

Skip an accessibility test that covers functionality not available on Tiger or Leopard.

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
14:07 Changeset [50903] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping one more new test, and a number of other tests, with bugs
filled.

13:33 Changeset [50902] by mrowe@apple.com
  • 1 delete in trunk/LayoutTests/platform/mac-snowleopard/accessibility

Remove a now-empty directory that I missed.

13:32 Changeset [50901] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Fix results for fast/dom/Window/window-properties.html after r50893.

  • fast/dom/Window/window-properties-expected.txt:
13:32 Changeset [50900] by mrowe@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

Move a misplaced accessibility test from platform/mac-snowleopard/accessibility to accessibility,
and the results from platform/mac-snowleopard/accessibility to platform/mac/accessibility.

Rubber-stamped by Anders Carlsson.

  • accessibility/aria-list-and-listitem.html: Renamed from LayoutTests/platform/mac-snowleopard/accessibility/aria-list-and-listitem.html.
  • platform/mac/accessibility/aria-list-and-listitem-expected.txt: Renamed from LayoutTests/platform/mac-snowleopard/accessibility/aria-list-and-listitem-expected.txt.
13:32 Changeset [50899] by mrowe@apple.com
  • 3 edits
    2 copies
    4 adds in trunk/LayoutTests

Land updated results for file-url-mimetypes-2.html and file-url-mimetypes-3.html.

Rubber-stamped by Brady Eidson.

  • platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Copied from LayoutTests/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt.
  • platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Copied from LayoutTests/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt.
  • platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes-3-expected.txt:
13:28 Changeset [50898] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-11-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Skipped new tests, a test that keeps failing despite
not failing locally, and a new DnD test.

  • platform/gtk/Skipped:
13:17 Changeset [50897] by snej@chromium.org
  • 6 edits in trunk/WebCore

Table-driven setup for V8 binding template callback functions. 100k in code savings.
https://bugs.webkit.org/show_bug.cgi?id=31420

Reviewed by Dimitri Glazkov.

  • bindings/scripts/CodeGeneratorV8.pm: Change generated ConfigureXXXTemplate fn

to call configureTemplate().

  • bindings/v8/V8Binding.cpp:

(WebCore::configureTemplate): New function; does all the standard configuration work.
(WebCore::createCallback): De-inlined wrapper for FunctionTemplate creation.

  • bindings/v8/V8Binding.h:
  • bindings/v8/V8Proxy.cpp:

(WebCore::batchConfigureAttributes): Just wrapped the very long fn parameter list.
(WebCore::batchConfigureCallbacks): New function, used by configureTemplate.
(WebCore::batchConfigureConstants): Just wrapped the very long fn parameter list.

  • bindings/v8/V8Proxy.h:
13:07 Changeset [50896] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

Start unifying entry logic for function and eval code.

Reviewed by Gavin Barraclough.

Eval now uses a ret instruction to end execution, and sets up
a callframe more in line with what we do for function entry.

13:03 Changeset [50895] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.

  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
13:02 Changeset [50894] by eric.carlson@apple.com
  • 5 edits in trunk/LayoutTests

2009-11-12 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Skipped tests need path relative to LayoutTests folder, not just
test name.

  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
12:23 Changeset [50893] by eric.carlson@apple.com
  • 13 edits
    5 adds in trunk

2009-11-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7388969> Add DOM API for fullscreen video


DOM API for fullscreen <video>.

Tests: media/media-fullscreen-inline.html

media/media-fullscreen-not-in-document.html

  • dom/EventNames.h:

Add webkitbeginfullscreen and webkitendfullscreen.

  • html/HTMLAttributeNames.in:

Add onwebkitbeginfullscreen and onwebkitendfullscreen.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute):

Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.

(WebCore::HTMLMediaElement::enterFullscreen):

Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
actually do enter fullscreen.

(WebCore::HTMLMediaElement::exitFullscreen):

Schedule webkitendfullscreenEvent event.

(WebCore::HTMLMediaElement::webkitEnterFullScreen):
(WebCore::HTMLMediaElement::webkitExitFullScreen):
(WebCore::HTMLMediaElement::webkitSupportsFullscreen):
(WebCore::HTMLMediaElement::webkitDisplayingFullscreen):

New, access to fullscreen properties and methods.

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:

Declare methods needed for fullscreen API.

  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::supportsFullscreen):

Return false if a movie does not have video.

  • page/DOMWindow.h:

Add webkitbeginfullscreen and webkitendfullscreen.

2009-11-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7388969> Add DOM API for fullscreen video


Tests for fullscreen <video> DOM API.

  • media/media-fullscreen-inline-expected.txt: Added.
  • media/media-fullscreen-inline.html: Added.
  • media/media-fullscreen-not-in-document-expected.txt: Added.
  • media/media-fullscreen-not-in-document.html: Added.
  • media/media-fullscreen.js: Added.
  • platform/gtk/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:

Skipped on platforms that don't support fullscreen yet.

12:16 Changeset [50892] by ap@apple.com
  • 9 edits in trunk/LayoutTests

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=31426
Some WebSocket tests don't properly listen to close event

  • websocket/tests/script-tests/handshake-error.js:
  • websocket/tests/script-tests/simple.js: Made the tests clear second-chance timer on finish, avoiding confusing output when running them in Safari.
  • websocket/tests/script-tests/frame-length-longer-than-buffer.js:
  • websocket/tests/script-tests/frame-length-skip.js:
  • websocket/tests/frame-length-longer-than-buffer-expected.txt:
  • websocket/tests/frame-length-skip-expected.txt: These tests now finish properly.
  • websocket/tests/handshake-error-expected.txt:
  • websocket/tests/simple-expected.txt: I'm getting an extra empty line for these tests, which is surprising. But since I didn't change anything, I assume that it should be there.
12:03 Changeset [50891] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-11-12 Adam Barth <abarth>

Reviewed by Dimitri Glazkov.

[Chromium] reload-subframe-object.html fails
https://bugs.webkit.org/show_bug.cgi?id=31398

More closely match FrameLoaderClient.mm. Turns out we don't want to
use MIMETypeRegistry::getMIMETypeForPath because we can't distinguish
between application/octet-stream and lack of knowledge of the MIME
type.

Covered by reload-subframe-object.html.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::objectContentType):
11:56 Changeset [50890] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-11-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[Chromium] Sify compose button alerts error
https://bugs.webkit.org/show_bug.cgi?id=31394

Test that we're using the calling security context in a simple case.

  • http/tests/security/calling-versus-current-expected.txt: Added.
  • http/tests/security/calling-versus-current.html: Added.

2009-11-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[Chromium] Sify compose button alerts error
https://bugs.webkit.org/show_bug.cgi?id=31394

Test: http/tests/security/calling-versus-current.html

We're supposed to use the calling context for security checks. In JSC
land, this is the lexicalGlobalObject.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::canAccessPrivate):
11:24 Changeset [50889] by japhet@chromium.org
  • 3 edits in trunk/WebKit/chromium

2009-11-12 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium build fix.

Add new accessibility enum values to Chromium enums from
http://trac.webkit.org/changeset/50865 and
http://trac.webkit.org/changeset/50883.

https://bugs.webkit.org/show_bug.cgi?id=31424

  • public/WebAccessibilityRole.h: (WebKit::):
  • src/AssertMatchingEnums.cpp:
11:21 Changeset [50888] by dbates@webkit.org
  • 5 edits in trunk

2009-11-12 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30291

Fixes an issue where the returned drop effect is incorrect when
effectAllowed == "uninitialized".

According to section 7.9.2 of the HTML 5 spec.
<http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
when effectAllowed = "uninitialized" the resulting dropEffect should be the
user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
other case.


No test cases are included because we have an existing test case from
bug #24731.

  • dom/Clipboard.cpp: (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".

2009-11-12 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30291

Rebased results for existing test case fast/events/drag-and-drop.html
from bug #24731.

Now, we can run the part of the test when effectAllowed == "uninitialized".

  • fast/events/drag-and-drop-expected.txt: Rebased results.
  • fast/events/drag-and-drop.html: Removed notice about this bug (#30291).
10:46 Changeset [50887] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-11-12 Nicolas Weber <thakis@chromium.org>

Reviewed by Dimitri Glazkov.

Send |keypress()| events for keys with cmd down, like safari.
Test: Hit cmd-shift-a on unixpapa.com/js/testkey.html , should show a
keypress() event.

  • src/mac/WebInputEventFactory.mm: (WebKit::WebInputEventFactory::keyboardEvent):
10:35 Changeset [50886] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not highlight node on refresh.

https://bugs.webkit.org/show_bug.cgi?id=31419

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset):
10:23 Changeset [50885] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Minor timeline fixes.

https://bugs.webkit.org/show_bug.cgi?id=31417

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelineRecordTreeElement.prototype.onattach): (WebInspector.TimelineRecordTreeElement.prototype._updateDetails): (WebInspector.TimelineRecordTreeElement.prototype.refresh):
09:44 Changeset [50884] by ap@apple.com
  • 2 edits in trunk/WebCore

SnowLeopard build fix.

Renamed initWithClient to initWithAuthenticationClient.

  • platform/network/mac/AuthenticationMac.mm: (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]): (WebCore::AuthenticationChallenge::setAuthenticationClient):
09:37 Changeset [50883] by eric@webkit.org
  • 10 edits
    2 adds in trunk

2009-11-12 Chris Fleizach <cfleizach@apple.com>

Reviewed by Darin Adler.

ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392

  • platform/mac/accessibility/aria-alerts-expected.txt: Added.
  • platform/mac/accessibility/aria-alerts.html: Added.

2009-11-12 Chris Fleizach <cfleizach@apple.com>

Reviewed by Darin Adler.

ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392

Test: platform/mac/accessibility/aria-alerts.html

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

2009-11-12 Chris Fleizach <cfleizach@apple.com>

Reviewed by Darin Adler.

ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392

  • English.lproj/Localizable.strings:
  • StringsNotToBeLocalized.txt:

2009-11-12 Chris Fleizach <cfleizach@apple.com>

Reviewed by Darin Adler.

ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory AXARIAContentGroupText:]):
09:18 Changeset [50882] by ap@apple.com
  • 8 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=31386
Make Mac AuthenticationChallenge usable from cross-platform code

No change in behavior, so no tests.

  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::clearAuthentication):
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge is identical.
  • platform/network/cf/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to be already set.
  • platform/network/mac/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the best of my understanding. (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent confusion with "mac" and "web" challenges in ResourceHandleInternal.
  • platform/network/mac/AuthenticationMac.mm: (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient, making it possible to use the latter with NSURLAuthenticationChallenge. (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge -> m_nsChallenge renaming. (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and set it as sender (or unset, if client is null).
  • platform/network/mac/ResourceHandleMac.mm: (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as authentication challenge sender. (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an authentication sheet. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge using the new setAuthenticationClient() method. (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion. Since didCancelAuthenticationChallenge is called by connection, the passed challenge is the original Mac one, not the one we created for use with authentication sheet. I don't know when a connection would cancel authentication in practice, so I haven't tested this.
09:08 Changeset [50881] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-12 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Web Inspector: breakpoint sidebar entries should allow click over entire list item
https://bugs.webkit.org/show_bug.cgi?id=31411

No new tests; no new functionality, small usability change.

  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
09:00 Changeset [50880] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2009-11-12 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Web Inspector: breakpoints in named evals are not restored after a reload
https://bugs.webkit.org/show_bug.cgi?id=31375

Manual test added

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.addScript):
  • manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
07:14 BuildingGtk edited by zundel@google.com
(diff)
06:37 Changeset [50879] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Various doc fixes
https://bugs.webkit.org/show_bug.cgi?id=31358

Reviewed by Jan Alonzo.

QWebPage's constructor docs are mentioning "QWebView":
"Constructs an empty QWebView with parent".

  • Api/qwebpage.cpp:
06:13 Changeset [50878] by zoltan@webkit.org
  • 416 edits in trunk/LayoutTests

Rubber-stamped by Tor Arne Vestbø.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-11-12
[Qt] Update outdated metrics in layout tests after change to Qt 4.6 on the buildbot.

  • platform/qt/css1/basic/class_as_selector-expected.txt:
  • platform/qt/css1/basic/comments-expected.txt:
  • platform/qt/css1/basic/containment-expected.txt:
  • platform/qt/css1/basic/contextual_selectors-expected.txt:
  • platform/qt/css1/basic/grouping-expected.txt:
  • platform/qt/css1/basic/id_as_selector-expected.txt:
  • platform/qt/css1/basic/inheritance-expected.txt:
  • platform/qt/css1/box_properties/acid_test-expected.txt:
  • platform/qt/css1/box_properties/border-expected.txt:
  • platform/qt/css1/box_properties/border_bottom-expected.txt:
  • platform/qt/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/qt/css1/box_properties/border_bottom_width-expected.txt:
  • platform/qt/css1/box_properties/border_bottom_width_inline-expected.txt:
  • platform/qt/css1/box_properties/border_color-expected.txt:
  • platform/qt/css1/box_properties/border_color_inline-expected.txt:
  • platform/qt/css1/box_properties/border_inline-expected.txt:
  • platform/qt/css1/box_properties/border_left-expected.txt:
  • platform/qt/css1/box_properties/border_left_inline-expected.txt:
  • platform/qt/css1/box_properties/border_left_width-expected.txt:
  • platform/qt/css1/box_properties/border_left_width_inline-expected.txt:
  • platform/qt/css1/box_properties/border_right-expected.txt:
  • platform/qt/css1/box_properties/border_right_inline-expected.txt:
  • platform/qt/css1/box_properties/border_right_width-expected.txt:
  • platform/qt/css1/box_properties/border_right_width_inline-expected.txt:
  • platform/qt/css1/box_properties/border_style-expected.txt:
  • platform/qt/css1/box_properties/border_style_inline-expected.txt:
  • platform/qt/css1/box_properties/border_top-expected.txt:
  • platform/qt/css1/box_properties/border_top_inline-expected.txt:
  • platform/qt/css1/box_properties/border_top_width-expected.txt:
  • platform/qt/css1/box_properties/border_top_width_inline-expected.txt:
  • platform/qt/css1/box_properties/border_width-expected.txt:
  • platform/qt/css1/box_properties/border_width_inline-expected.txt:
  • platform/qt/css1/box_properties/clear-expected.txt:
  • platform/qt/css1/box_properties/clear_float-expected.txt:
  • platform/qt/css1/box_properties/float-expected.txt:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/qt/css1/box_properties/float_margin-expected.txt:
  • platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/qt/css1/box_properties/height-expected.txt:
  • platform/qt/css1/box_properties/margin-expected.txt:
  • platform/qt/css1/box_properties/margin_bottom-expected.txt:
  • platform/qt/css1/box_properties/margin_bottom_inline-expected.txt:
  • platform/qt/css1/box_properties/margin_inline-expected.txt:
  • platform/qt/css1/box_properties/margin_left-expected.txt:
  • platform/qt/css1/box_properties/margin_left_inline-expected.txt:
  • platform/qt/css1/box_properties/margin_right-expected.txt:
  • platform/qt/css1/box_properties/margin_right_inline-expected.txt:
  • platform/qt/css1/box_properties/margin_top-expected.txt:
  • platform/qt/css1/box_properties/margin_top_inline-expected.txt:
  • platform/qt/css1/box_properties/padding-expected.txt:
  • platform/qt/css1/box_properties/padding_bottom-expected.txt:
  • platform/qt/css1/box_properties/padding_bottom_inline-expected.txt:
  • platform/qt/css1/box_properties/padding_inline-expected.txt:
  • platform/qt/css1/box_properties/padding_left-expected.txt:
  • platform/qt/css1/box_properties/padding_left_inline-expected.txt:
  • platform/qt/css1/box_properties/padding_right-expected.txt:
  • platform/qt/css1/box_properties/padding_right_inline-expected.txt:
  • platform/qt/css1/box_properties/padding_top-expected.txt:
  • platform/qt/css1/box_properties/padding_top_inline-expected.txt:
  • platform/qt/css1/box_properties/width-expected.txt:
  • platform/qt/css1/cascade/cascade_order-expected.txt:
  • platform/qt/css1/cascade/important-expected.txt:
  • platform/qt/css1/classification/display-expected.txt:
  • platform/qt/css1/classification/list_style-expected.txt:
  • platform/qt/css1/classification/list_style_image-expected.txt:
  • platform/qt/css1/classification/list_style_position-expected.txt:
  • platform/qt/css1/classification/list_style_type-expected.txt:
  • platform/qt/css1/classification/white_space-expected.txt:
  • platform/qt/css1/color_and_background/background-expected.txt:
  • platform/qt/css1/color_and_background/background_attachment-expected.txt:
  • platform/qt/css1/color_and_background/background_color-expected.txt:
  • platform/qt/css1/color_and_background/background_image-expected.txt:
  • platform/qt/css1/color_and_background/background_position-expected.txt:
  • platform/qt/css1/color_and_background/background_repeat-expected.txt:
  • platform/qt/css1/color_and_background/color-expected.txt:
  • platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/qt/css1/font_properties/font-expected.txt:
  • platform/qt/css1/font_properties/font_family-expected.txt:
  • platform/qt/css1/font_properties/font_size-expected.txt:
  • platform/qt/css1/font_properties/font_style-expected.txt:
  • platform/qt/css1/font_properties/font_variant-expected.txt:
  • platform/qt/css1/font_properties/font_weight-expected.txt:
  • platform/qt/css1/formatting_model/canvas-expected.txt:
  • platform/qt/css1/formatting_model/floating_elements-expected.txt:
  • platform/qt/css1/formatting_model/height_of_lines-expected.txt:
  • platform/qt/css1/formatting_model/horizontal_formatting-expected.txt:
  • platform/qt/css1/formatting_model/inline_elements-expected.txt:
  • platform/qt/css1/formatting_model/replaced_elements-expected.txt:
  • platform/qt/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/qt/css1/pseudo/anchor-expected.txt:
  • platform/qt/css1/pseudo/firstletter-expected.txt:
  • platform/qt/css1/pseudo/firstline-expected.txt:
  • platform/qt/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/qt/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • platform/qt/css1/text_properties/letter_spacing-expected.txt:
  • platform/qt/css1/text_properties/line_height-expected.txt:
  • platform/qt/css1/text_properties/text_align-expected.txt:
  • platform/qt/css1/text_properties/text_decoration-expected.txt:
  • platform/qt/css1/text_properties/text_indent-expected.txt:
  • platform/qt/css1/text_properties/text_transform-expected.txt:
  • platform/qt/css1/text_properties/vertical_align-expected.txt:
  • platform/qt/css1/text_properties/word_spacing-expected.txt:
  • platform/qt/css1/units/color_units-expected.txt:
  • platform/qt/css1/units/length_units-expected.txt:
  • platform/qt/css1/units/percentage_units-expected.txt:
  • platform/qt/css1/units/urls-expected.txt:
  • platform/qt/css2.1/t040102-keywords-00-b-expected.txt:
  • platform/qt/css2.1/t040102-keywords-01-b-expected.txt:
  • platform/qt/css2.1/t040103-case-00-b-expected.txt:
  • platform/qt/css2.1/t040103-case-01-c-expected.txt:
  • platform/qt/css2.1/t040103-escapes-00-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-01-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-02-d-expected.txt:
  • platform/qt/css2.1/t040103-escapes-03-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-04-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-05-c-expected.txt:
  • platform/qt/css2.1/t040103-escapes-06-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-07-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-08-b-expected.txt:
  • platform/qt/css2.1/t040103-ident-00-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-01-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-02-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-03-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-04-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-05-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-06-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-07-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-08-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-09-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-10-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-11-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-12-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-13-c-expected.txt:
  • platform/qt/css2.1/t040105-atkeyw-00-b-expected.txt:
  • platform/qt/css2.1/t040105-atkeyw-01-b-expected.txt:
  • platform/qt/css2.1/t040105-atkeyw-02-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-00-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-01-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-02-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-03-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-04-b-expected.txt:
  • platform/qt/css2.1/t040105-import-00-b-expected.txt:
  • platform/qt/css2.1/t040105-import-01-b-expected.txt:
  • platform/qt/css2.1/t040109-c17-comments-00-b-expected.txt:
  • platform/qt/css2.1/t040109-c17-comments-01-b-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-01-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-03-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-04-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-01-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-02-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-03-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-04-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-05-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-06-f-expected.txt:
  • platform/qt/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
  • platform/qt/css2.1/t040302-c61-phys-len-00-b-expected.txt:
  • platform/qt/css2.1/t040302-c61-rel-len-00-b-ag-expected.txt:
  • platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.txt:
  • platform/qt/css2.1/t040306-c63-color-00-b-ag-expected.txt:
  • platform/qt/css2.1/t040306-syntax-01-f-expected.txt:
  • platform/qt/css2.1/t040307-syntax-01-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-00-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-01-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-02-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-03-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-04-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-05-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-06-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-07-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-08-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-09-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-11-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-12-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-13-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-14-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-15-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-16-f-expected.txt:
  • platform/qt/css2.1/t1202-counters-00-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-01-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-02-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-03-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-05-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-06-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-07-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-08-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-09-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-11-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-12-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-13-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-14-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-15-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-16-c-expected.txt:
  • platform/qt/css2.1/t1202-counters-17-d-expected.txt:
  • platform/qt/css2.1/t1202-counters-18-f-expected.txt:
  • platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c563-list-type-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c563-list-type-01-b-expected.txt:
  • platform/qt/css2.1/t1205-c564-list-img-00-b-g-expected.txt:
  • platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c566-list-stl-01-c-g-expected.txt:
  • platform/qt/css2.1/t140201-c532-bgcolor-00-a-expected.txt:
  • platform/qt/css2.1/t140201-c532-bgcolor-01-b-expected.txt:
  • platform/qt/css2.1/t140201-c533-bgimage-00-a-expected.txt:
  • platform/qt/css2.1/t140201-c533-bgimage-01-b-g-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgre-00-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
  • platform/qt/css2.1/t140201-c536-bgpos-00-b-ag-expected.txt:
  • platform/qt/css2.1/t1503-c522-font-family-00-b-expected.txt:
  • platform/qt/css2.1/t1504-c523-font-style-00-b-expected.txt:
  • platform/qt/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt:
  • platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt:
  • platform/qt/css2.1/t1506-c525-font-wt-00-b-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-00-b-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-01-b-a-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-00-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-01-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-02-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-03-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-04-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-05-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-08-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-09-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-10-c-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
  • platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt:
  • platform/qt/fast/backgrounds/001-expected.txt:
  • platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt:
  • platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
  • platform/qt/fast/backgrounds/background-origin-root-element-expected.txt:
  • platform/qt/fast/backgrounds/background-position-1-expected.txt:
  • platform/qt/fast/backgrounds/background-position-rounding-expected.txt:
  • platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
  • platform/qt/fast/backgrounds/mask-composite-expected.txt:
  • platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
  • platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
  • platform/qt/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/qt/fast/backgrounds/size/zero-expected.txt:
  • platform/qt/fast/backgrounds/solid-color-context-restore-expected.txt:
  • platform/qt/fast/backgrounds/svg-as-background-1-expected.txt:
  • platform/qt/fast/backgrounds/svg-as-background-2-expected.txt:
  • platform/qt/fast/backgrounds/svg-as-background-3-expected.txt:
  • platform/qt/fast/backgrounds/svg-as-background-4-expected.txt:
  • platform/qt/fast/backgrounds/svg-as-background-5-expected.txt:
  • platform/qt/fast/backgrounds/svg-as-background-6-expected.txt:
  • platform/qt/fast/block/float/avoidance-percent-width-compat-expected.txt:
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
  • platform/qt/fast/borders/border-radius-constraints-expected.txt:
  • platform/qt/fast/borders/border-radius-split-inline-expected.txt:
  • platform/qt/fast/box-shadow/basic-shadows-expected.txt:
  • platform/qt/fast/box-shadow/inset-expected.txt:
  • platform/qt/fast/box-shadow/transform-fringing-expected.txt:
  • platform/qt/fast/canvas/canvas-before-css-expected.txt:
  • platform/qt/fast/canvas/canvas-composite-expected.txt:
  • platform/qt/fast/canvas/canvas-empty-image-pattern-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-identity-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-infinity-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-multiply-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-nan-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-non-invertible-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-skewed-expected.txt:
  • platform/qt/fast/canvas/canvas-transforms-during-path-expected.txt:
  • platform/qt/fast/canvas/canvas-zoom-expected.txt:
  • platform/qt/fast/canvas/drawImage-expected.txt:
  • platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.txt:
  • platform/qt/fast/canvas/image-pattern-rotate-expected.txt:
  • platform/qt/fast/canvas/shadow-offset-1-expected.txt:
  • platform/qt/fast/canvas/shadow-offset-2-expected.txt:
  • platform/qt/fast/canvas/shadow-offset-3-expected.txt:
  • platform/qt/fast/canvas/shadow-offset-4-expected.txt:
  • platform/qt/fast/canvas/shadow-offset-5-expected.txt:
  • platform/qt/fast/canvas/shadow-offset-6-expected.txt:
  • platform/qt/fast/canvas/shadow-offset-7-expected.txt:
  • platform/qt/fast/css/attribute-selector-dynamic-expected.txt:
  • platform/qt/fast/css/font-smoothing-expected.txt:
  • platform/qt/fast/css/getComputedStyle/marginComputedStyle-expected.txt:
  • platform/qt/fast/css/nested-floating-relative-position-percentages-expected.txt:
  • platform/qt/fast/css/nth-child-dynamic-expected.txt:
  • platform/qt/fast/css/pseudo-cache-stale-expected.txt:
  • platform/qt/fast/css/rem-dynamic-scaling-expected.txt:
  • platform/qt/fast/css/rem-units-on-root-expected.txt:
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/qt/fast/css/text-rendering-expected.txt:
  • platform/qt/fast/doctypes/001-expected.txt:
  • platform/qt/fast/doctypes/002-expected.txt:
  • platform/qt/fast/doctypes/004-expected.txt:
  • platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/qt/fast/dynamic/anchor-lock-expected.txt:
  • platform/qt/fast/dynamic/genContentDestroyChildren-expected.txt:
  • platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/qt/fast/dynamic/window-scrollbars-test-expected.txt:
  • platform/qt/fast/forms/basic-buttons-expected.txt:
  • platform/qt/fast/forms/basic-inputs-expected.txt:
  • platform/qt/fast/forms/button-style-color-expected.txt:
  • platform/qt/fast/forms/isindex-placeholder-expected.txt:
  • platform/qt/fast/forms/menulist-style-color-expected.txt:
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt:
  • platform/qt/fast/forms/text-style-color-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt:
  • platform/qt/fast/frames/frame-navigation-expected.txt:
  • platform/qt/fast/frames/frame-scrolling-attribute-expected.txt:
  • platform/qt/fast/frames/frameset-style-recalc-expected.txt:
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/qt/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/qt/fast/gradients/crash-on-zero-radius-expected.txt:
  • platform/qt/fast/history/clicked-link-is-visited-expected.txt:
  • platform/qt/fast/images/animated-gif-with-offsets-expected.txt:
  • platform/qt/fast/images/image-in-map-expected.txt:
  • platform/qt/fast/images/svg-as-background-expected.txt:
  • platform/qt/fast/images/svg-width-100p-as-background-expected.txt:
  • platform/qt/fast/lists/ol-start-parsing-expected.txt:
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.txt:
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
  • platform/qt/fast/reflections/abs-position-in-reflection-expected.txt:
  • platform/qt/fast/reflections/transparent-reflected-sublayers-expected.txt:
  • platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.txt:
  • platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.txt:
  • platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt:
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt:
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.txt:
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt:
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt:
  • platform/qt/fast/table/fixed-table-with-small-percent-width-expected.txt:
  • platform/qt/fast/text/international/hindi-whitespace-expected.txt:
  • platform/qt/fast/text/international/khmer-selection-expected.txt:
  • platform/qt/fast/text/shadow-translucent-fill-expected.txt:
  • platform/qt/fast/text/text-letter-spacing-expected.txt:
  • platform/qt/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/qt/fast/xsl/document-function-expected.txt:
  • platform/qt/plugins/netscape-dom-access-expected.txt:
  • platform/qt/svg/custom/createImageElement2-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug196870-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug56201-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/qt/tables/mozilla/other/slashlogo-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
06:05 Changeset [50877] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-11-12 Richard Moe Gustavsen <richard.gustavsen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable pthread_setname_np.

This allows Qt builds on Mac from 10.6 to run on earlier version
where this symbol is not present.
https://bugs.webkit.org/show_bug.cgi?id=31403

  • wtf/Platform.h:
05:52 Changeset [50876] by eric@webkit.org
  • 7 edits in trunk

2009-11-12 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Custom printing shrink factors
https://bugs.webkit.org/show_bug.cgi?id=29042

This reverts commit r49769. The public API for this needs to be reviewed
before its inclusion in Qt.

  • page/PrintContext.cpp: (WebCore::PrintContext::begin):
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:

2009-11-12 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Custom printing shrink factors
https://bugs.webkit.org/show_bug.cgi?id=29042

This reverts commit r49769. The public API for this needs to be reviewed
before its inclusion in Qt.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
  • Api/qwebsettings.h:
05:28 Changeset [50875] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-12 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Resource errors/warnings not shown in the Resource tree.

Error/Warning bubbles are not displayed next to the resource in the
Resources panel if those occur before the resource is attached to the tree.
https://bugs.webkit.org/show_bug.cgi?id=31404

Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html

  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.removeItem):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
04:44 Changeset [50874] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-11-12 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix linking on Linux 32-bit.

It was missing the ".text" directive at the top of the file,
indicating that code would follow. Without it, the assembler created
"NOTYPE" symbols, which would result in linker errors.
https://bugs.webkit.org/show_bug.cgi?id=30863

  • jit/JITStubs.cpp:
02:39 Changeset [50873] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-12 Philippe Normand <pnormand@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=31047
[GTK] Failing test media/video-played-ranges-1.html

Follow-up of r50726, don't block the UI thread when calling
gst_element_get_state(). Also fixed a compilation warning and some
static casts.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::playbackPosition): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::setRate):
02:32 Changeset [50872] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-12 Philippe Normand <pnormand@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=31047
[GTK] Failing test media/video-played-ranges-1.html

don't pause pipeline if already paused, same for play()

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause):
01:03 Changeset [50871] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-12 Kinuko Yasuda <kinuko@google.com>

Reviewed by David Levin.

Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
Chromium too.
https://bugs.webkit.org/show_bug.cgi?id=31292

No new tests. (Corresponding test for Gtk+ is
platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)

  • page/EventHandler.cpp:
  • page/chromium/EventHandlerChromium.cpp:
00:37 Changeset [50870] by hamaji@chromium.org
  • 4 edits in trunk/LayoutTests

2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed test fix by skipping a new test introduced in
https://bugs.webkit.org/show_bug.cgi?id=22249

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
00:15 Changeset [50869] by hamaji@chromium.org
  • 6 edits
    4 adds in trunk

2009-11-12 Yuta Kitamura <yutak@chromium.org>

Reviewed by Eric Seidel.

Prevent text inside a multi-column block from being split into columns.

If the tentative height of a multi-column block was too small, we need to
expand the block height and try to layout again, in order to prevent text
from being split into different columns.

CSS Multicolumn text is split awkwardly
https://bugs.webkit.org/show_bug.cgi?id=22249

  • fast/multicol/single-line.html: Added.
  • fast/multicol/single-line-expected.checksum: Added.
  • fast/multicol/single-line-expected.png: Added.
  • fast/multicol/single-line-expected.txt: Added.

2009-11-12 Yuta Kitamura <yutak@chromium.org>

Reviewed by Eric Seidel.

Prevent text inside a multi-column block from being split into columns.

If the tentative height of a multi-column block was too small, we need to
expand the block height and try to layout again, in order to prevent text
from being split into different columns.

CSS Multicolumn text is split awkwardly
https://bugs.webkit.org/show_bug.cgi?id=22249

Test: fast/multicol/single-line.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutColumns):
  • rendering/RenderBlock.h:
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint):
  • rendering/RenderView.h: (WebCore::RenderView::setTruncatedAt): (WebCore::RenderView::setMinimumColumnHeight): (WebCore::RenderView::minimumColumnHeight):

11/11/09:

22:43 Changeset [50868] by tkent@chromium.org
  • 6 edits
    2 adds in trunk

2009-11-11 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

A test for a bug that RenderFileUploadControl isn't initialized with
multiple files. This test is skipped on ports which have no
eventSender.beginDragWithFiles().
https://bugs.webkit.org/show_bug.cgi?id=31195

  • fast/forms/input-file-re-render.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/fast/forms/input-file-re-render-expected.checksum: Added.
  • platform/mac/fast/forms/input-file-re-render-expected.png: Added.
  • platform/mac/fast/forms/input-file-re-render-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2009-11-11 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
https://bugs.webkit.org/show_bug.cgi?id=31195

Test: fast/forms/input-file-re-render.html

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl):
21:58 Changeset [50867] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Fixing Chromium's POSIX VFS implementation, by adding the required
"used file descriptors" logic.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31275

  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
21:46 Changeset [50866] by dbates@webkit.org
  • 3 edits in trunk/LayoutTests

2009-11-11 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31326

Makes the output for test fast/events/drag-and-drop.html pretty.
Now, it is easier to read for a human to read understand the results.

  • fast/events/drag-and-drop-expected.txt: Rebased result.
  • fast/events/drag-and-drop.html: Modified to make the output pretty.
21:26 Changeset [50865] by cfleizach@apple.com
  • 20 edits
    4 adds in trunk

need to implement aria tree roles
https://bugs.webkit.org/show_bug.cgi?id=31284

Reviewed by Oliver Hunt.

WebCore:

Tests: platform/mac/accessibility/aria-multiselectable.html

platform/mac/accessibility/aria-tree.html

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::accessibilityIsIgnored):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::ariaTreeRows):
(WebCore::AccessibilityObject::ariaTreeItemContent):
(WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):

  • accessibility/AccessibilityObject.h:

(WebCore::):
(WebCore::AccessibilityObject::isTree):
(WebCore::AccessibilityObject::isTreeItem):
(WebCore::AccessibilityObject::setIsExpanded):
(WebCore::AccessibilityObject::canSetExpandedAttribute):
(WebCore::AccessibilityObject::hierarchicalLevel):
(WebCore::AccessibilityObject::setSelectedRows):
(WebCore::AccessibilityObject::performDefaultAction):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::hierarchicalLevel):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::isExpanded):
(WebCore::AccessibilityRenderObject::setElementAttributeValue):
(WebCore::AccessibilityRenderObject::elementAttributeValue):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::isSelected):
(WebCore::AccessibilityRenderObject::setSelected):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::createARIARoleMap):
(WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
(WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::selectedChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(RoleEntry::):
(-[AccessibilityObjectWrapper subrole]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):

  • html/HTMLAttributeNames.in:

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(disclosedRowAtIndexCallback):
(selectedRowAtIndexCallback):
(isEqualCallback):
(isAttributeSettableCallback):
(isActionSupportedCallback):
(disclosedByRowCallback):
(hierarchicalLevelCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:

(AccessibilityUIElement::isEqual):

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::hierarchicalLevel):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::disclosedByRow):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::hierarchicalLevel):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::hierarchicalLevel):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::disclosedByRow):

LayoutTests:

  • accessibility/aria-readonly-expected.txt:
  • accessibility/aria-readonly.html:
  • platform/mac/accessibility/aria-multiselectable-expected.txt: Added.
  • platform/mac/accessibility/aria-multiselectable.html: Added.
  • platform/mac/accessibility/aria-tree-expected.txt: Added.
  • platform/mac/accessibility/aria-tree.html: Added.
  • platform/mac/accessibility/content-editable-expected.txt:
  • platform/mac/accessibility/radio-button-group-members-expected.txt:
20:31 Changeset [50864] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

Build fix after @r50760 with ENABLE_FILTERS.

  • platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.

  • svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument to fillRect.
20:19 Changeset [50863] by hamaji@chromium.org
  • 4 edits in trunk/WebKitTools

2009-11-11 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

svn-apply can not handle git binary diffs
https://bugs.webkit.org/show_bug.cgi?id=26830

Support "literal" type git binary diffs.

  • Scripts/VCSUtils.pm:
  • Scripts/modules/scm_unittest.py:
  • Scripts/svn-apply:
20:17 Changeset [50862] by ukai@chromium.org
  • 3 edits
    8 adds in trunk

2009-11-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix WebSocket frame parser of frame_type with high-order bit set.
https://bugs.webkit.org/show_bug.cgi?id=30668

  • websocket/tests/frame-length-longer-than-buffer-expected.txt: Added.
  • websocket/tests/frame-length-longer-than-buffer.html: Added.
  • websocket/tests/frame-length-longer-than-buffer_wsh.py: Added.
  • websocket/tests/frame-length-skip-expected.txt: Added.
  • websocket/tests/frame-length-skip.html: Added.
  • websocket/tests/frame-length-skip_wsh.py: Added.
  • websocket/tests/script-tests/frame-length-longer-than-buffer.js: Added.
  • websocket/tests/script-tests/frame-length-skip.js: Added.

2009-11-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix WebSocket frame parser of frame_type with high-order bit set.
https://bugs.webkit.org/show_bug.cgi?id=30668

If buffer is smaller than frame's length, it should break the loop
instead of reading next byte.

Tests: websocket/tests/frame-length-longer-than-buffer.html

websocket/tests/frame-length-skip.html

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):
20:03 QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
(diff)
19:38 Changeset [50861] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Put tests into skiplist added in r50830 and r50839 because
layoutTestController.showWebInspector() is unimplemented now.

  • platform/qt/Skipped:
19:20 Changeset [50860] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Various doc fixes
https://bugs.webkit.org/show_bug.cgi?id=31358

Reviewed by Kenneth Christiansen.

Fixed wrong documentation: item's dimensions do fit to Web page
content by default.

Kenneth agreed to land this as a followup patch to the
just landed documentation patch.

  • Api/qgraphicswebview.cpp:
19:20 Changeset [50859] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-11 Yusuke Sato <yusukes@chromium.org>

Reviewed by Adam Barth.

[chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
https://bugs.webkit.org/show_bug.cgi?id=31345

Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.

  • platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx(). (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call. (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
19:20 Changeset [50858] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit/qt

[Qt] Various doc fixes
https://bugs.webkit.org/show_bug.cgi?id=31323

Patch by David Boddie <dboddie@trolltech.com> on 2009-11-11
Reviewed by Kenneth Christiansen.

Fixed and synchronized QWebView related documentation.

  • Api/qgraphicswebview.cpp:
  • Api/qwebview.cpp:
19:02 Changeset [50857] by eric@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

2009-11-11 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dmitry Titov.

Rewrite the test to run on a wider variety of screen configurations
(and pixel depths).

https://bugs.webkit.org/show_bug.cgi?id=31373

  • fast/dom/Window/window-screen-properties-expected.txt:
  • fast/dom/Window/window-screen-properties.html:
  • platform/win/fast/dom/Window/window-screen-properties-expected.txt: Removed.
18:31 Changeset [50856] by bdakin@apple.com
  • 2 edits in trunk/WebKit/win

Build fix. No review needed.

  • WebKitGraphics.cpp:

(WebDrawText):

18:30 Changeset [50855] by bdakin@apple.com
  • 2 edits in trunk/WebCore

Build fix. No review needed.

  • platform/graphics/gtk/FontGtk.cpp:

(WebCore::Font::drawComplexText):

18:19 Changeset [50854] by bdakin@apple.com
  • 2 edits in trunk/WebCore

Build fix. No review needed.

  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::Font::drawGlyphs):

18:13 Changeset [50853] by bdakin@apple.com
  • 2 edits in trunk/WebCore

Windows build fix. No review needed.

  • platform/graphics/win/FontCGWin.cpp:

(WebCore::Font::drawGlyphs):

17:51 Changeset [50852] by bdakin@apple.com
  • 19 edits
    8 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
Make -webkit-color-correction work with shadows

Reviewed by Simon Fraser.

From canvas, just send DeviceColorSpace to setShadow() for now.
Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::applyShadow):

setShadow() and setPlatformShadow() now take a ColorSpace.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setShadow):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::createCGColorWithColorSpace): New helper to create a
color in a ColorSpace.
(WebCore::setCGFillColor): Call new helper.
(WebCore::setCGStrokeColor): Call new helper.
(WebCore::GraphicsContext::setPlatformShadow): Call new helper.

  • platform/graphics/haiku/GraphicsContextHaiku.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

Send appropriate ColorSpace to setShadow().

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineTextBox.cpp:

(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paintDecoration):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow):

  • rendering/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintCharacters):

  • rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent):

Attempt to keep ports building.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

  • platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=31382
Make -webkit-color-correction work with shadows

Reviewed by Simon Fraser.

  • fast/css/color-correction-on-box-shadow.html: Added.
  • fast/css/color-correction-on-text-shadow.html: Added.
  • platform/mac/fast/css/color-correction-on-box-shadow-expected.checksum: Added.
  • platform/mac/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/mac/fast/css/color-correction-on-box-shadow-expected.txt: Added.
  • platform/mac/fast/css/color-correction-on-text-shadow-expected.checksum: Added.
  • platform/mac/fast/css/color-correction-on-text-shadow-expected.png: Added.
  • platform/mac/fast/css/color-correction-on-text-shadow-expected.txt: Added.
17:46 Changeset [50851] by eric@webkit.org
  • 18 edits in trunk

2009-11-11 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Print the file text of a file upload control in DumpRenderTree for ease of tests.
https://bugs.webkit.org/show_bug.cgi?id=31195

  • platform/mac-leopard/fast/forms/file-input-disabled-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/file-input-direction-expected.txt:
  • platform/mac/fast/forms/file-input-disabled-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/hidden-input-file-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/win/fast/forms/box-shadow-override-expected.txt:
  • platform/win/fast/forms/file-input-disabled-expected.txt:
  • platform/win/fast/forms/input-appearance-height-expected.txt:
  • platform/win/fast/forms/input-value-expected.txt:

2009-11-11 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Print the file text of a file upload control in DumpRenderTree for ease of tests.
https://bugs.webkit.org/show_bug.cgi?id=31195

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::fileTextValue):
  • rendering/RenderFileUploadControl.h: (WebCore::RenderFileUploadControl::isFileUploadControl): (WebCore::toRenderFileUploadControl):
  • rendering/RenderObject.h: (WebCore::RenderObject::isFileUploadControl):
  • rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
17:36 QtBackLog edited by zecke@selfish.org
(diff)
17:00 Changeset [50850] by barraclough@apple.com
  • 8 edits in trunk/WebCore

DOM Wrappers for some nodes may not be marked.
https://bugs.webkit.org/show_bug.cgi?id=31380

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-11
Reviewed by Sam Weinig.

Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
the wrapper for the current world only. This means that wrappers may be GC'ed
prematurely, and properties lost.

Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.

  • bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::markChildren):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::markDOMNodeWrapper):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::markChildren):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::markChildren):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::markChildren):

  • bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::markChildren):

16:55 Changeset [50849] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/chromium

Not reviewed. Build fix. Will be cleaned up in subsequent patch once we know exaclty what's going on.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-11-11

  • src/WebBindings.cpp:
16:39 Changeset [50848] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-11 Ben Murdoch <benm@google.com>

Reviewed by Darin Adler.

bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
https://bugs.webkit.org/show_bug.cgi?id=31384

No functionality change so no tests required.

  • bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
16:19 Changeset [50847] by dimich@chromium.org
  • 2 edits in trunk/WebKitTools

Not reviewed, removing duplicate entry for myself in committers.py.

  • Scripts/modules/committers.py:
16:11 Changeset [50846] by snej@chromium.org
  • 4 edits in trunk/WebCore

The Big De-Inlining. 450k code size reduction (32-bit x86.)

  • Various inline functions in V8Binding.h made non-inline.
  • Some renaming for consistency.
  • New function createRawTemplate().

https://bugs.webkit.org/show_bug.cgi?id=31383

Reviewed by Dimitri Glazkov.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Binding.cpp:

(WebCore::v8DOMWrapperToNative):
(WebCore::v8ValueToWebCoreString):
(WebCore::v8ValueToAtomicWebCoreString):
(WebCore::toInt32):
(WebCore::toWebCoreString):
(WebCore::toWebCoreStringWithNullCheck):
(WebCore::toAtomicWebCoreStringWithNullCheck):
(WebCore::toWebCoreStringWithNullOrUndefinedCheck):
(WebCore::isUndefinedOrNull):
(WebCore::v8Boolean):
(WebCore::v8UndetectableString):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):
(WebCore::v8StringOrFalse):
(WebCore::v8StringToWebCoreString):
(WebCore::v8ExternalString):
(WebCore::createRawTemplate): New function.

  • bindings/v8/V8Binding.h:

(WebCore::v8DOMWrapperTo):
(WebCore::v8DOMWrapperToNode):
(WebCore::v8StringToWebCoreString):
(WebCore::v8StringToAtomicWebCoreString):

15:56 Changeset [50845] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-11-11 Erik Arvidsson <arv@chromium.org>

Reviewed by Dmitri Titov.

Fix layout test to not call onload on the wrong window after image has
been dropped onto the iframe.
https://bugs.webkit.org/show_bug.cgi?id=30893

  • editing/selection/drag-to-contenteditable-iframe.html:
15:12 WebKit Team edited by dimich@chromium.org
(diff)
14:54 Changeset [50844] by snej@chromium.org
  • 4 edits in trunk/WebCore

More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
event-listener setter into a new subroutine transferHiddenDependency().
https://bugs.webkit.org/show_bug.cgi?id=31377

Reviewed by Dimitri Glazkov.

  • bindings/scripts/CodeGeneratorV8.pm: Replace boilerplate with call to transferHiddenDependency().
  • bindings/v8/V8Utilities.cpp:

(WebCore::transferHiddenDependency): New.

  • bindings/v8/V8Utilities.h: Declaration of transferHiddenDependency.
14:49 Changeset [50843] by bweinstein@apple.com
  • 4 edits in trunk

WebCore: If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
because there is a CG bug preventing this from working.

Reviewed by Beth Dakin.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::sRGBColorSpaceRef):

LayoutTests: Unskip the webkit-color-correction tests because the workaround of using
the deviceRGBColorSpace allows the tests to pass on Windows.

Reviewed by Beth Dakin.

  • platform/win/Skipped:
14:07 Changeset [50842] by ap@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Darin Adler and Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=31200
Tests in http/tests/security/mixedContent start to fail when new tests are added

  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
13:57 Changeset [50841] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip the webkit-color-correction tests because they crash on Windows
due to a CoreGraphics bug.

Reviewed by Darin Adler.

  • platform/win/Skipped:
13:37 Changeset [50840] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Check that if Storage panel exists before calling its methods

https://bugs.webkit.org/show_bug.cgi?id=31343

13:35 Changeset [50839] by eric@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

2009-11-11 Eric Z. Ayers <zundel@google.com>

Reviewed by Pavel Feldman.

Timeline tests for records generated for
Layout, Paint, ParseHTML, MarkTimeline, and Style Recalculation

https://bugs.webkit.org/show_bug.cgi?id=31361

  • inspector/timeline-layout-expected.txt: Added.
  • inspector/timeline-layout.html: Added.
  • inspector/timeline-mark-timeline-expected.txt: Added.
  • inspector/timeline-mark-timeline.html: Added.
  • inspector/timeline-paint-expected.txt: Added.
  • inspector/timeline-paint.html: Added.
  • inspector/timeline-parse-html-expected.txt: Added.
  • inspector/timeline-parse-html.html: Added.
  • inspector/timeline-recalculate-styles-expected.txt: Added.
  • inspector/timeline-recalculate-styles.html: Added.
13:23 Changeset [50838] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-11-11 Drew Wilson <atwilson@chromium.org>

Reviewed by Dimitri Glazkov.

SharedWorkerRepository.connect() does not call WebSharedWorkerRepository
https://bugs.webkit.org/show_bug.cgi?id=31371

Test: Unit tests can be enabled downstream when this lands.

  • src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerRepository::connect): Added missing call to WebSharedWorkerRepository.addSharedWorker().
13:10 Changeset [50837] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

Create, and display a window for the inspector, for inspector tests.

13:10 Changeset [50836] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2009-11-11 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Tiny path fixes in Chromium API includes.

https://bugs.webkit.org/show_bug.cgi?id=31369

  • public/linux/WebSandboxSupport.h: Fixed path.
  • src/WebBindings.cpp: Fixed path.
13:09 Changeset [50835] by snej@chromium.org
  • 3 edits in trunk/WebCore

De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
times in the generated V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=31368

Reviewed by Dimitri Glazkov.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertNodeToV8Object): Moved body here from .h file

  • bindings/v8/V8DOMWrapper.h: Removed inline method body.
12:20 Changeset [50834] by jberlin@webkit.org
  • 3 edits
    2 adds in trunk

WebCore: Display the correct summary in the web inspector for the shorthands
border-color, border-width, border-style, margin, and padding.
https://bugs.webkit.org/show_bug.cgi?id=7987

Reviewed by Timothy Hatcher.

Test: fast/css/shorthands-four-values.html

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::get4Values):
Display the summary information in the same way the shorthand would be
specified in a css rule.

LayoutTests:

  • fast/css/shorthands-four-values-expected.txt: Added.
  • fast/css/shorthands-four-values.html: Added.
12:00 Changeset [50833] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-11-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Alexey Proskuryakov.

Refactor multiple JavaScriptCore threads
https://bugs.webkit.org/show_bug.cgi?id=31328

Remove the id field from the PlatformThread structure
as it is not used.

  • runtime/Collector.cpp: (JSC::getCurrentPlatformThread): (JSC::suspendThread): (JSC::resumeThread): (JSC::getPlatformThreadRegisters):
11:57 Changeset [50832] by kenneth@webkit.org
  • 4 edits in trunk

WebKit/qt: Unreviewed buildbot fix.

Export a method to the DRT to know if the document has a
document element.

  • Api/qwebframe.cpp:

(qt_drt_hasDocumentElement):

WebKitTools: Unreviewed Qt buildbot fix.

My previous fix was wrong, so revert that change and fix it by
returning when the document of the frame has no document element.
Idea is borrowed from mac and win DRT.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::dumpFramesAsText):

11:53 Changeset [50831] by snej@chromium.org
  • 2 edits in trunk/WebCore

Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
meaning to the caller, saves code, and appears to save a few cycles at runtime too.
https://bugs.webkit.org/show_bug.cgi?id=31367

Reviewed by Dimitri Glazkov.

  • bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
11:51 Changeset [50830] by eric@webkit.org
  • 3 edits
    1 copy
    2 adds in trunk/LayoutTests

2009-11-11 Eric Z. Ayers <zundel@google.com>

Reviewed by Pavel Feldman.

Added a test of an externally loaded script tag for Inspector
timeline records.
Fixed identity comparisons.

https://bugs.webkit.org/show_bug.cgi?id=31365

  • inspector/timeline-script-tag-1.html:
  • inspector/timeline-script-tag-2-expected.txt: Added.
  • inspector/timeline-script-tag-2.html: Added.
  • inspector/timeline-script-tag-2.js: Added.
  • inspector/timeline-test.js: (): (timelineAgentTypeToString):
11:46 Changeset [50829] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-11 Eric Seidel <eric@webkit.org>

Reviewed byg Kenneth Rohde Christiansen.

Update Kenneth's committer record to include the email he
uses on lists.webkit.org.

  • Scripts/modules/committers.py:
11:23 Changeset [50828] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-11 Eric Seidel <eric@webkit.org>

Reviewed by Gustavo Noronha Silva.

Several committers use separate email addresses for bugzilla and svn.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=31364

Update records for existing committers to include email addresses
used in svn.webkit.org and lists.webkit.org.
Most committers use the same email address in all 3 places, but some use
separate addresses. committers.py needs record of each of these addresses.

  • Scripts/modules/committers.py:
11:21 Changeset [50827] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Christiansen.

Grouping some of the current skipped plugin tests that fail
due to the same reason: no support for objective-c functions.

  • platform/qt/Skipped:
11:19 Changeset [50826] by snej@chromium.org
  • 6 edits in trunk/WebCore

Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.

Reviewed by Dimitri Glazkov.

  • bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrent): Moved getCurrentMainThread to MainThreadDOMData::getCurrent

so it can be inlined by its caller.

  • bindings/v8/DOMData.h:
  • bindings/v8/MainThreadDOMData.cpp:

(WebCore::MainThreadDOMData::getCurrent): Moved here from DOMData.cpp.
(WebCore::MainThreadDOMData::getMainThreadStore): Added UNLIKELY macro to improve codegen.
(WebCore::MainThreadDOMData::getCurrentMainThreadStore): Combination of getCurrentMainThread

and getStore, which inline both calls together.

  • bindings/v8/MainThreadDOMData.h:

(WebCore::MainThreadDOMData::getStore): Broke out nonvirtual getMainThreadStore for inlineability.

  • bindings/v8/V8DOMMap.cpp:

(WebCore::getDOMNodeMap): Call new getCurrentMainThreadStore, which is faster.

11:04 Changeset [50825] by dbates@webkit.org
  • 3 edits in trunk/LayoutTests

2009-11-11 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31334


We should skip the test case /fast/events/drag-and-drop-fire-drag-dragover.html
on both the Qt and GTK builds since there are issues with drag-and-drop support
in these builds.


For Qt: https://bugs.webkit.org/show_bug.cgi?id=31332
For GTK: https://bugs.webkit.org/show_bug.cgi?id=30576

  • platform/gtk/Skipped: Skip test case /fast/events/drag-and-drop-fire-drag-dragover.html since there are issues with drag-and-drop support in both GTK and Qt.
  • platform/qt/Skipped: Ditto.
10:45 Changeset [50824] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

If the frame has no innerText don't append it, and
do not add a newline which breaks some cross platform
results.

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::dumpFramesAsText):

10:44 Changeset [50823] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Fix a crash in the layout test plugins/document-open.html

Reviewed by Simon Hausmann.

  • Api/qwebframe.cpp:

(QWebFrame::toPlainText):

10:43 Changeset [50822] by eric@webkit.org
  • 5 edits in trunk/WebKit/qt

2009-11-11 Liang QI <liang.qi@nokia.com>

[Qt] Fix tst_qwebpage and tst_qwebframe compilation on Symbian.

  • tests/qwebframe/qwebframe.pro:
  • tests/qwebframe/tst_qwebframe.cpp:
  • tests/qwebpage/qwebpage.pro:
  • tests/qwebpage/tst_qwebpage.cpp:
10:39 Changeset [50821] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-11 Eric Seidel <eric@webkit.org>

No review, adding second email address for an existing committer.

Add Yong Li's second bugzilla account to his committer record.
See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27

  • Scripts/modules/committers.py:
10:36 Changeset [50820] by japhet@chromium.org
  • 3 edits in trunk/WebKit/chromium

2009-11-11 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

http://trac.webkit.org/changeset/50811 removed some methods from
platform/network/SocketStreamHandleClient.h, so remove them
here too.

https://bugs.webkit.org/show_bug.cgi?id=31360

  • public/WebSocketStreamHandleClient.h:
  • src/SocketStreamHandle.cpp: (WebCore::SocketStreamHandleInternal::send):
10:32 Changeset [50819] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2009-11-11 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.

https://bugs.webkit.org/show_bug.cgi?id=31357

  • platform/KURLGoogle.cpp: (WebCore::isSchemeFirstChar): (WebCore::isSchemeChar): (WebCore::KURL::hasPort): (WebCore::KURL::removePort): (WebCore::protocolIsValid):
10:31 Changeset [50818] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

[Qt] Regression: Preserve the parent of plugin objects when using
QtWebKit with only a QWebPage.

Reviewed by Tor Arne Vestbø.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createPlugin): Don't reparent
plugins to 0.

  • tests/qwebpage/tst_qwebpage.cpp:

(PluginCounterPage::PluginCounterPage): Initialize m_pluginParent to 0.
(PluginCounterPage::~PluginCounterPage): Delete the plugin parent later
(after the page)
(PluginTracerPage::createPlugin): Assign a dummy parent to the plugin.
(PluginTracerPage::PluginTracerPage): Set up the plugin parent.
(tst_QWebPage::createViewlessPlugin): Verify that for viewless pages the
plugin parent remains unchanged.

10:21 Changeset [50817] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-11-11 David Boddie <dboddie@trolltech.com>

[Qt] Doc: Added internal or hidden placeholder documentation.

  • Api/qwebpage.cpp:
10:15 Changeset [50816] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Build fix, no reviewed.

Correct setPlatformFillColor and setPlatformStrokeColor calls
to match new ColorSpace-supporting signatures.

  • platform/graphics/win/GraphicsContextCairoWin.cpp: Add the color space to the set[...]Color calls.
10:14 Changeset [50815] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-11-11 Martin Smith <msmith@trolltech.com>

[Qt] doc: Changed Trolltech to Nokia

  • Api/qwebview.cpp:
10:06 Changeset [50814] by japhet@chromium.org
  • 3 edits in trunk/WebKit/chromium

2009-11-11 Nate Chapin <japhet@chromium.org>

Reviewed by Eric Seidel.

Remove some additional references to dragSourceMovedTo() not
needed after http://trac.webkit.org/changeset/50786.

https://bugs.webkit.org/show_bug.cgi?id=31354

  • public/WebView.h:
  • src/WebViewImpl.h:
09:51 Changeset [50813] by eric@webkit.org
  • 2 edits
    1 add
    3 deletes in trunk/LayoutTests

2009-11-11 Yuta Kitamura <yutak@chromium.org>

Reviewed by Eric Seidel.

Convert LayoutTests/fast/inline/dirtyLinesForInline.html into dumpAsText.

This test checks if the browser crashes after some operations. It doesn't test
any other interesting features, so we can safely make it a dumpAsText test.

https://bugs.webkit.org/show_bug.cgi?id=31335

  • fast/inline/dirtyLinesForInline-expected.txt: Added.
  • fast/inline/dirtyLinesForInline.html: Added dumpAsText().
  • platform/mac/fast/inline/dirtyLinesForInline-expected.checksum: Removed.
  • platform/mac/fast/inline/dirtyLinesForInline-expected.png: Removed.
  • platform/mac/fast/inline/dirtyLinesForInline-expected.txt: Removed.
09:33 Changeset [50812] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

Implement missing functionality in the Gtk/Qt TestNetscapePlugin.

Reviewed by Simon Hausmann.

  • DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:

(webkit_test_plugin_new_instance):
(webkit_test_plugin_destroy_instance):
(webkit_test_plugin_destroy_stream):

09:22 Changeset [50811] by ap@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=31327
Clean up SocketStreamHandleClient interface

No change in behavior.

  • platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData. (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by the only client (WebSocketChannel), and it's not clear what this callback's semantics should be. (WebCore::SocketStreamHandleClient::willSendData): Ditto. (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced. For ResourceHandle, this method is called when the user cancels authentication sheet, not when something happens with the stream.
  • websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
  • websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related callbacks have no real implementation yet.
09:06 Changeset [50810] by zoltan@webkit.org
  • 11 edits in trunk/WebCore

Allow custom memory allocation control for the part of page directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31350

Reviewed by Eric Seidel.

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and these are no need to be copyable:

class DragController - instantiated at: WebCore/page/Page.cpp:107
class FocusController - instantiated at: WebCore/page/Page.cpp:109
class Settings - instantiated at: WebCore/page/Page.cpp:116
class PluginHalter - instantiated at: WebCore/page/Page.cpp:160
struct ScheduledEvent - instantiated at: WebCore/page/FrameView.cpp:1275
class UserScript - instantiated at: WebCore/page/PageGroup.cpp:208
struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
class XSSAuditor - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
class UserStyleSheet - instantiated at: WebCore/page/PageGroup.cpp:222

Inherits PropertyWrapperBase class from Noncopyable because (its child class)
PropertyWrapper is instantiated by 'new' in
WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.

  • page/DragController.h:
  • page/EventHandler.h:
  • page/FocusController.h:
  • page/FrameView.cpp:
  • page/PluginHalter.h:
  • page/Settings.h:
  • page/UserScript.h:
  • page/UserStyleSheet.h:
  • page/XSSAuditor.h:
  • page/animation/AnimationBase.cpp:
09:05 Changeset [50809] by eric@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2009-11-11 Eric Z. Ayers <zundel@google.com>

Reviewed by Timothy Hatcher.

Adds a test that dumps the timeline data for a simple script tag.

https://bugs.webkit.org/show_bug.cgi?id=31204

  • inspector/inspector-test.js: (onload):
  • inspector/timeline-script-tag-1-expected.txt: Added.
  • inspector/timeline-script-tag-1.html: Added.
  • inspector/timeline-test.js: Added. (retrieveTimelineData): (): (dumpTimelineRecords): (printTimelineRecordProperties): (isNonDeterministicProp): (printProps): (isTimelineOverheadRecord): (markTimelineRecordAsOverhead): (timelineAgentTypeToString): (frontend_startTimelineProfiler.window.WebInspector.addRecordToTimeline): (frontend_startTimelineProfiler): (frontend_getTimelineResults): (frontend_setup):
09:03 Changeset [50808] by japhet@chromium.org
  • 2 edits in trunk/WebKit/chromium

2009-11-11 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Remove WebViewImpl::dragSourceMovedTo(), as it is no longer
needed after http://trac.webkit.org/changeset/50786.

https://bugs.webkit.org/show_bug.cgi?id=31354

  • src/WebViewImpl.cpp:
08:02 Changeset [50807] by vestbo@webkit.org
  • 1 edit in trunk/JavaScriptCore/jsc.pro

Qt build fix on Mac OS X

06:45 Changeset [50806] by eric@webkit.org
  • 4 edits in trunk

2009-11-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=31323
Fix a few compiler warnings

No new tests as there is no new functionality.

  • editing/htmlediting.cpp: (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings

2009-11-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=31323
Fix a few compiler warnings

  • tests/qwebframe/tst_qwebframe.cpp: Add extra brackets to make it explicit where the else case belongs
06:19 Changeset [50805] by vestbo@webkit.org
  • 3 edits in trunk/WebKitTools

[Qt] Force -graphicssystem raster and -style windows when running DRT

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/main.cpp:
  • Scripts/run-webkit-tests:
06:11 Changeset [50804] by kenneth@webkit.org
  • 4 edits in trunk

WebCore: Set m_hasPendingGeometryChange to true by default, so that
at least one call to NPP_SetWindow is executed, which is
needed by the DRT plugin testing framework.

Reviewed by Mark Rowe.

  • plugins/PluginView.cpp:

(WebCore::PluginView::PluginView):

WebKitTools: Implement the functionality needed by plugins/window-open.html

Reviewed by Mark Rowe.

  • DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:

(webkit_test_plugin_new_instance):
(webkit_test_plugin_set_window):

06:00 Changeset [50803] by ossy@webkit.org
  • 2 edits in trunk/WebCore

Rubber-stamped by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=31348
[Qt] Remove unnecessary LUT creator from WebCore.pro

  • WebCore.pro:
05:31 Changeset [50802] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

Compute correct library paths for Qt

Reviewed by Simon Hausmann.

  • Scripts/webkitdirs.pm:
05:19 Changeset [50801] by hausmann@webkit.org
  • 6 edits in trunk

WebCore: Introduce a function for querying the input method status
in QWebPageClient.

Reviewed by Tor Arne Vestbø.

  • platform/qt/QWebPageClient.h:

WebKit/qt: Fix enabling of software input panel when activating editable elements
in QGraphicsWebView.

Reviewed by Tor Arne Vestbø.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::inputMethodEnabled): Implement method to
query for input method support.

  • Api/qwebpage.cpp:

(QWebPageWidgetClient::inputMethodEnabled): Ditto for QWidget.
(QWebPagePrivate::handleSoftwareInputPanel): Don't use view() to
test for input method support. Instead query using QWebPageClient
and send the SIPR event to the ownerWidget() instead of the view().
The latter is null for QGraphicsWebView.

  • tests/qwebpage/tst_qwebpage.cpp:

(EventSpy::EventSpy):
(EventSpy::eventFilter):
(tst_QWebPage::inputMethods): Modify the test to verify that SIPR
events are dispatched when activating focusable content.

04:57 Changeset [50800] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Skipping new tests.

04:44 Changeset [50799] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

Reviewed by Holger Freyther.

Should not print javascript console messages to stdout
https://bugs.webkit.org/show_bug.cgi?id=31346

  • webkit/webkitwebview.cpp:

(webkit_web_view_real_console_message): Print console messages to
stderr instead, using the recommended method (a g_log variant).

04:34 QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
(diff)
03:24 Changeset [50798] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-11 Benjamin Otte <otte@gnome.org>

Reviewed by Jan Alonzo.

[GTK] Black artifacts in youtube.com/html5

Paint the video to the given size. It's the job of the callers to keep
track of aspect ratio. RenderVideo.cpp does it for the <video>
element.
https://bugs.webkit.org/show_bug.cgi?id=30925

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint):
03:17 Changeset [50797] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-11 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=30901
[Gtk] Need to de-lint the Atk a11y code

Cleaned up some missed capitalization style-guideline violations.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
01:38 Changeset [50796] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Eric Seidel.

[Qt] Make the default style background color valid.
Currently the color is transparent but invalid, this causes
list boxes in QtWebKit to be drawn with a black background
since r49242.
https://bugs.webkit.org/show_bug.cgi?id=31295

  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::initialBackgroundColor):
  • rendering/style/StyleBackgroundData.cpp: (WebCore::StyleBackgroundData::StyleBackgroundData):
01:23 Changeset [50795] by eric@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2009-11-11 Yuzo Fujishima <yuzo@google.com>

Reviewed by David Levin.

Add a test for web socket handshake error.

https://bugs.webkit.org/show_bug.cgi?id=31336

  • websocket/tests/handshake-error-expected.txt: Added.
  • websocket/tests/handshake-error.html: Added.
  • websocket/tests/handshake-error_wsh.py: Added.
  • websocket/tests/script-tests/handshake-error.js: Added. (endTest): (ws.onopen): (ws.onmessage): (ws.onclose): (timeOutCallback):
00:45 Changeset [50794] by eric@webkit.org
  • 5 edits
    8 adds in trunk/LayoutTests

2009-11-11 Yuzo Fujishima <yuzo@google.com>

Reviewed by David Levin.

Add a simple web socket test. This tests basic features of Web Socket.
This also serves as an example of Web Socket tests.

https://bugs.webkit.org/show_bug.cgi?id=27492

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • websocket/tests/resources/simple.js: Added. (ws.onopen): (ws.onmessage): (ws.onclose): (timeOutCallback):
  • websocket/tests/simple-expected.txt: Added.
  • websocket/tests/simple.html: Added.
  • websocket/tests/simple_wsh.py: Added.
00:36 Changeset [50793] by eric@webkit.org
  • 4 edits in trunk

2009-11-11 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30221
[GTK] fails to load media embedded in iframe element

  • platform/gtk/Skipped: Unskip fixed tests.

2009-11-11 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30221
[GTK] fails to load media embedded in iframe element

The FrameLoader can show Media if the audio/video support is
enabled at compile time.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::canShowMIMEType):

11/10/09:

23:56 Changeset [50792] by barraclough@apple.com
  • 8 edits in trunk/WebCore

Simplify the ownership model for worlds - rather than having a pair of weak references
between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
ref pointer to the former. This reduces complexity & cost of the caching entries in the
back forward cache.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-10
Reviewed by Geoff Garen.

  • WebCore.base.exp:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::DOMWrapperWorld::~DOMWrapperWorld):

  • bindings/js/JSDOMBinding.h:

(WebCore::DOMWrapperWorld::forgetDocument):

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):

  • bindings/js/ScriptCachedFrameData.h:
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):

  • bindings/js/ScriptController.h:
23:30 Changeset [50791] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Linux build fix: Added an #include for UINT_MAX.

  • runtime/WeakRandom.h:
23:27 Changeset [50790] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

JavaScriptGlue build fix: Marked a file 'private' instead of 'project'.

23:22 Changeset [50789] by ggaren@apple.com
  • 8 edits
    1 add in trunk/JavaScriptCore

Faster Math.random, based on GameRand.

Reviewed by Gavin "avGni arBalroguch" Barraclough.

SunSpider says 1.4% faster.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h: Use an object to track random number generation

state, initialized to the current time.

  • runtime/MathObject.cpp:

(JSC::MathObject::MathObject):
(JSC::mathProtoFuncRandom): Use the new hotness.

  • runtime/WeakRandom.h: Added.

(JSC::WeakRandom::WeakRandom):
(JSC::WeakRandom::get):
(JSC::WeakRandom::advance): The new hotness.

21:51 Changeset [50788] by rolandsteiner@chromium.org
  • 1 edit
    49 adds in trunk/LayoutTests

Re-baselined layout test results for Windows for tests in fast/ruby.
(see https://bugs.webkit.org/show_bug.cgi?id=28420)

Reviewed by Eric Seidel.

  • platform/win/fast/ruby: Added.
  • platform/win/fast/ruby/ruby-empty-rt-expected.checksum: Added.
  • platform/win/fast/ruby/ruby-empty-rt-expected.png: Added.
  • platform/win/fast/ruby/ruby-empty-rt-expected.txt: Added.
  • platform/win/fast/ruby/ruby-length-expected.checksum: Added.
  • platform/win/fast/ruby/ruby-length-expected.png: Added.
  • platform/win/fast/ruby/ruby-length-expected.txt: Added.
  • platform/win/fast/ruby/ruby-run-break-expected.checksum: Added.
  • platform/win/fast/ruby/ruby-run-break-expected.png: Added.
  • platform/win/fast/ruby/ruby-run-break-expected.txt: Added.
  • platform/win/fast/ruby/ruby-runs-expected.checksum: Added.
  • platform/win/fast/ruby/ruby-runs-expected.png: Added.
  • platform/win/fast/ruby/ruby-runs-expected.txt: Added.
  • platform/win/fast/ruby/ruby-runs-spans-expected.checksum: Added.
  • platform/win/fast/ruby/ruby-runs-spans-expected.png: Added.
  • platform/win/fast/ruby/ruby-runs-spans-expected.txt: Added.
  • platform/win/fast/ruby/ruby-simple-expected.checksum: Added.
  • platform/win/fast/ruby/ruby-simple-expected.png: Added.
  • platform/win/fast/ruby/ruby-simple-expected.txt: Added.
  • platform/win/fast/ruby/ruby-simple-rp-expected.checksum: Added.
  • platform/win/fast/ruby/ruby-simple-rp-expected.png: Added.
  • platform/win/fast/ruby/ruby-simple-rp-expected.txt: Added.
  • platform/win/fast/ruby/ruby-trailing-expected.checksum: Added.
  • platform/win/fast/ruby/ruby-trailing-expected.png: Added.
  • platform/win/fast/ruby/ruby-trailing-expected.txt: Added.
  • platform/win/fast/ruby/rubyDOM-insert-rt-expected.checksum: Added.
  • platform/win/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
  • platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
  • platform/win/fast/ruby/rubyDOM-insert-text1-expected.checksum: Added.
  • platform/win/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
  • platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
  • platform/win/fast/ruby/rubyDOM-insert-text2-expected.checksum: Added.
  • platform/win/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
  • platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt: Added.
  • platform/win/fast/ruby/rubyDOM-insert-text3-expected.checksum: Added.
  • platform/win/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
  • platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
  • platform/win/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Added.
  • platform/win/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
  • platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
  • platform/win/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Added.
  • platform/win/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
  • platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt: Added.
  • platform/win/fast/ruby/rubyDOM-remove-text1-expected.checksum: Added.
  • platform/win/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
  • platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
  • platform/win/fast/ruby/rubyDOM-remove-text2-expected.checksum: Added.
  • platform/win/fast/ruby/rubyDOM-remove-text2-expected.png: Added.
  • platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt: Added.
19:08 Changeset [50787] by hamaji@chromium.org
  • 2 edits in trunk/WebCore

2009-11-10 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

rename counter to makeCounterNode in RenderCounter.cpp
https://bugs.webkit.org/show_bug.cgi?id=31289

No new test because this is just a small refactoring.

  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): (WebCore::makeCounterNode): (WebCore::RenderCounter::originalText):
18:52 Changeset [50786] by dbates@webkit.org
  • 12 edits
    2 adds in trunk

2009-11-10 Daniel Bates <dbates@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=30754

Patch 2 of 2.

Removed method EventHandler::dragSourceMovedTo, since it is no longer
needed. This method fired a drag event whenever the mouse moved, but
section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
model independent of when the mouse moves. See "Among other changes..."
in the change log for patch 1 for more details.

  • WebCore.DragSupport.exp:
  • page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo. (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
  • page/EventHandler.h:

2009-11-10 Daniel Bates <dbates@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=30754

Removed method draggedImage:movedTo:

  • WebView/WebFrame.mm:
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm:

2009-11-10 Daniel Bates <dbates@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=30754

Modified WebDropSource::QueryContinueDrag so as to not call EventHandler::dragSourceMovedTo.

  • WebDropSource.cpp: (WebDropSource::QueryContinueDrag): Removed call to EventHandler::dragSourceMovedTo.

2009-11-10 Daniel Bates <dbates@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=30754

Patch 1 of 2.

As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
the drag event should always fire before the dragover event.

In fixing this bug, this patch also makes our drag processing model
conform to the HTML 5 spec.

Among the changes, this patch ensures that the drag event isn't fired outside
of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
Currently, the drag event is fired whenever the mouse button is down and the OS
detects the mouse moved. But, as per the spec, the drag event should
fire approx. every 350ms so long as the mouse button is down.

Test: fast/events/drag-and-drop-fire-drag-dragover.html

  • page/EventHandler.cpp: (WebCore::EventHandler::clear): (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget. Modified to determine when we are in the correct instance of EventHandler to service the drag and drop operation. (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo into this method. (WebCore::EventHandler::cancelDragAndDrop): (WebCore::EventHandler::performDragAndDrop): (WebCore::EventHandler::clearDragState):
  • page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether we should fire both drag and dragover events or only the dragover event.

2009-11-10 Daniel Bates <dbates@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=30754

Tests that the drag event always fires before the dragover event.

Also, re-bases the result for test fast/events/drag-in-frames.html, since
we now conform to the HTML 5 spec.

  • fast/events/drag-and-drop-fire-drag-dragover-expected.txt: Added.
  • fast/events/drag-and-drop-fire-drag-dragover.html: Added.
  • fast/events/drag-in-frames-expected.txt: Rebased result.
18:15 Changeset [50785] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2009-11-10 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
https://bugs.webkit.org/show_bug.cgi?id=31301

  • fast/xpath/xpath-detached-iframe-resolver-crash-expected.txt: Added.
  • fast/xpath/xpath-detached-iframe-resolver-crash.html: Added.

2009-11-10 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
https://bugs.webkit.org/show_bug.cgi?id=31301

Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.

Allowed passing V8Proxy for the calling JS context:

  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::getXPathNSResolver):
  • bindings/v8/custom/V8CustomXPathNSResolver.cpp: (WebCore::V8CustomXPathNSResolver::create): (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver): (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
  • bindings/v8/custom/V8CustomXPathNSResolver.h:
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
18:07 Changeset [50784] by eric@webkit.org
  • 10 edits
    24 adds in trunk

2009-11-10 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Timothy Hatcher.

Implement URL decomposition IDL attributes for HTMLAnchorElement.
https://bugs.webkit.org/show_bug.cgi?id=29972

Testcases for setting and getting different parts of the URL.

  • fast/dom/HTMLAnchorElement: Added.
  • fast/dom/HTMLAnchorElement/script-tests: Added.
  • fast/dom/HTMLAnchorElement/script-tests/TEMPLATE.html: Added.
  • fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js: Added.
  • fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js: Added.
  • fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js: Added.
  • fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js: Added.
  • fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-port.js: Added.
  • fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js: Added.
  • fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-hash.html: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-host.html: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-port.html: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-search.html: Added.

2009-11-10 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Timothy Hatcher.

Implement URL decomposition IDL attributes for HTMLAnchorElement.
https://bugs.webkit.org/show_bug.cgi?id=29972.

Add methods for setting different parts of the URL in href attribute.

Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html

fast/dom/HTMLAnchorElement/set-href-attribute-host.html
fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
fast/dom/HTMLAnchorElement/set-href-attribute-port.html
fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
fast/dom/HTMLAnchorElement/set-href-attribute-search.html

  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setPort):
  • html/HTMLAnchorElement.cpp: (WebCore::parsePortFromStringPosition): (WebCore::HTMLAnchorElement::setHash): (WebCore::HTMLAnchorElement::setHost): (WebCore::HTMLAnchorElement::setHostname): (WebCore::HTMLAnchorElement::setPathname): (WebCore::HTMLAnchorElement::setPort): (WebCore::HTMLAnchorElement::setProtocol): (WebCore::HTMLAnchorElement::setSearch):
  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.idl:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL):
  • platform/KURL.cpp: (WebCore::KURL::removePort): (WebCore::KURL::setPort): (WebCore::KURL::prettyURL): (WebCore::protocolIsValid):
  • platform/KURL.h: (WebCore::KURL::canSetHostOrPort): (WebCore::KURL::canSetPathname): (WebCore::KURL::hasPort):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
17:29 Changeset [50783] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

<http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added

Reviewed by Sam Weinig.

The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
about the validity of the self-signed certificates used in the regression tests. We would then add the
host to the ignore list for SSL certificate errors and retry the request. If this happened during a test
that had enabled frame load delegate logging this would result in extra log messages being generated,
causing the test to fail.

We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
tests.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree):

  • DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):

17:24 Changeset [50782] by bweinstein@apple.com
  • 3 edits in trunk/LayoutTests

Update getComputedStyle results for Windows to add -webkit-color-correction.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
17:14 Changeset [50781] by japhet@chromium.org
  • 8 edits in trunk

2009-11-10 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium build fix for http://trac.webkit.org/changeset/50760.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::paintBorder): (WebCore::PopupListBox::paint): (WebCore::PopupListBox::paintRow):
  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::setupLayerForWhiteLayer):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformStrokeColor):
  • rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaSlider): (WebCore::paintMediaVolumeSlider): (WebCore::paintMediaTimelineContainer):
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMenuListButton):
17:00 QtWebKitPerformanceUtilities edited by zecke@selfish.org
(diff)
16:56 Changeset [50780] by eric@webkit.org
  • 1 edit
    2 adds
    1 delete in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Modified WebKit.gyp to build the webkit api.

https://bugs.webkit.org/show_bug.cgi?id=31320

  • README: Added.
  • WebKit.gyp: Added.
  • webkit.gyp: Removed.
16:46 Changeset [50779] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Made a small change to my test then didn't update the results before landing.

Reviewed by NOBODY (Fix my own layout-test snafu)

  • http/tests/webarchive/cross-origin-stylesheet-crash-expected.webarchive:
15:36 Changeset [50778] by beidson@apple.com
  • 4 edits
    3 adds in trunk

Repro crash saving pcmag.com article as a webarchive.
<rdar://problem/7381219> and https://webkit.org/b/31322

Reviewed by Sam Weinig.

WebCore:

Test: http/tests/webarchive/cross-origin-stylesheet-crash.html

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead

of creating a CSSRuleList (and subjecting ourselves to the security origin check)

LayoutTests:

  • http/tests/webarchive/cross-origin-stylesheet-crash.html: Added.
  • http/tests/webarchive/cross-origin-stylesheet-crash-expected.webarchive: Added.
  • http/tests/webarchive/resources/localhost-stylesheet.css: Added.
  • platform/gtk/Skipped: Add this test to the gtk Skipped list which tracks all individual skipped tests instead of directories.
15:31 Changeset [50777] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Add sanity checks to RunScript to ensure it doesn't run when the document hasn't yet
loaded nor when JavaScript is disabled.

https://bugs.webkit.org/show_bug.cgi?id=31309

15:16 Changeset [50776] by bdakin@apple.com
  • 2 edits in trunk/WebCore

Attempt 2 to fix Tiger build. No review needed.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::deviceRGBColorSpaceRef):
(WebCore::sRGBColorSpaceRef):

15:16 Changeset [50775] by kevino@webkit.org
  • 3 edits in trunk/WebCore

wx build fix. Changes needed after r50760.

15:03 Changeset [50774] by ap@apple.com
  • 2 edits in trunk/WebCore

Qt build fix.

  • platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).
14:52 Changeset [50773] by bdakin@apple.com
  • 2 edits in trunk/WebCore

Tiger build fix. No review needed.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::sRGBColorSpaceRef):

14:38 Changeset [50772] by ap@apple.com
  • 17 edits
    1 add in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=31312
Decouple authentication panel callbacks from ResourceHandle

No change in functionality.

SocketStreamHandle also needs to request credentials, so it's not appropriate to store
ResourceHandle as delegate.

WebCore:

  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/AuthenticationClient.h: Added. Added a new interface for listening to authentication panel notifications.
  • WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what it wants with the project file.

(WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
interface class.
(WebCore::AuthenticationClient::deref): Ditto.

  • platform/network/ResourceHandle.h: (WebCore::ResourceHandle::refAuthenticationClient): Ditto. (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.
  • platform/network/cf/AuthenticationCF.cpp: (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::platformCompare):
  • platform/network/cf/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::authenticationClient):
  • platform/network/chromium/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::authenticationClient):
  • platform/network/curl/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::authenticationClient): Keeping a reference to AuthenticationClient, not to ResourceHandle.

WebKit:

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
  • WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::initWithAuthenticationChallenge): (WebURLAuthenticationChallenge::sender):
  • WebURLAuthenticationChallengeSender.cpp: (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender): (WebURLAuthenticationChallengeSender::createInstance): (WebURLAuthenticationChallengeSender::authenticationClient):
  • WebURLAuthenticationChallengeSender.h:
  • WebURLAuthenticationChallengeSenderCFNet.cpp: (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge): (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge): (WebURLAuthenticationChallengeSender::useCredential): Adjusted for WebCore changes.
14:35 Changeset [50771] by bdakin@apple.com
  • 2 edits in trunk/WebCore

Second attempted gtk build fix. No review needed.

  • html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::applyStrokeColor):

14:28 Changeset [50770] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

14:27 Changeset [50769] by mrowe@apple.com
  • 1 copy in tags/Safari-532.4

New tag.

14:22 Changeset [50768] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Anders Carlsson.

Add timing out test to Windows Skipped list.

  • platform/win/Skipped:
14:21 Changeset [50767] by barraclough@apple.com
  • 6 edits in trunk/WebCore

Fix back/forwards cache with JSC isolated worlds.
https://bugs.webkit.org/show_bug.cgi?id=31310
<rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-10
Reviewed by Geoff Garen.

Store the global object for all worlds, not just the normal world.
Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
so we can forget global objects if a world goes away.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::DOMWrapperWorld::~DOMWrapperWorld):

  • bindings/js/JSDOMBinding.h:

(WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
(WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::forgetWorld):
(WebCore::ScriptCachedFrameData::domWindow):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):

  • bindings/js/ScriptCachedFrameData.h:
  • bindings/js/ScriptController.h:
14:20 Changeset [50766] by ossy@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Unreviewed buildfix after r50760.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::GraphicsContext):

14:14 Changeset [50765] by bdakin@apple.com
  • 2 edits in trunk/WebCore

Attempted build fix. (No review needed.)

  • GNUmakefile.am: Adding ColorSpace.h
14:05 Changeset [50764] by bweinstein@apple.com
  • 9 edits in trunk

WebCore: Updated function calls to take a ColorSpace argument, passing
in DeviceColorSpace for now - this should be fixed. Also added
ColorSpace.h to WebCore project.

Reviewed by NOBODY - Build Fix.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/win/FontCGWin.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::GraphicsContext):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::paint):

  • platform/win/WebCoreTextRenderer.cpp:

(WebCore::doDrawTextAtPoint):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintMenuListButton):

WebKit/win: Updated fillRoundedRect to take a ColorSpace argument.

Reviewed by NOBODY - Build Fix.

  • WebCoreSupport/WebDragClient.cpp:

(WebDragClient::createDragImageForLink):

14:03 Changeset [50763] by snej@chromium.org
  • 4 edits in trunk/WebCore

Optimizations to Element::getAttribute
https://bugs.webkit.org/show_bug.cgi?id=30926

Reviewed by Darin Adler.

  • dom/Element.cpp:

(WebCore::Element::getAttribute): User case-insensitive compare instead of lowercasing the name.

  • dom/NamedAttrMap.cpp:

(WebCore::NamedNodeMap::getAttributeItem): Avoid redundant compares, and do fast/likely compares first.

  • platform/text/PlatformString.h:

(WebCore::equalPossiblyIgnoringCase): New inline method, used by both of the above.

13:52 Changeset [50762] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Put test into skiplist added in r50758 because
layoutTestController.showWebInspector() is unimplemented now.

  • platform/qt/Skipped: inspector/timeline-enum-stability.html added.
13:48 Changeset [50761] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip another test that requires implementing editing
callbacks.

13:44 Changeset [50760] by bdakin@apple.com
  • 59 edits
    21 adds in trunk

WebCore: Fix for <rdar://problem/7059710>
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
color-correction for CSS colors

Reviewed by Darin Adler.

New exported symbol for GraphicsContext::fillColor() which now
accepts a ColorSpace as an optional parameter.

  • WebCore.base.exp:

Added a new file, ColorSpace.h, to define the ColorSpace enum.

  • WebCore.xcodeproj/project.pbxproj:

Computed Style for -webkit-color-correction

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

Parse -webkit-color-correction

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

Map CSS identifiers to the appropriate values of the ColorSpace enum

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ColorSpace):

New property -webkit-color-correction

  • css/CSSPropertyNames.in:

Map -webkit-color-correction into the RenderStyle.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

Add new value sRGB.

  • css/CSSValueKeywords.in:

Comment out the reference to sRGB since it will now be inherited as
a value from CSSValueKeywords.

  • css/SVGCSSValueKeywords.in:

Definition of the ColorSpace enum.

  • platform/graphics/ColorSpace.h: Added.

(WebCore::):

These functions all now take a ColorSpace as a parameter.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setStrokeColor):
(WebCore::GraphicsContext::setFillColor):
(WebCore::GraphicsContext::drawHighlightForText):

Return the appropriate ColorSpace.
(WebCore::GraphicsContext::strokeColorSpace):
(WebCore::GraphicsContext::fillColorSpace):

These functions all call other functions which require a ColorSpace
as a parameter.
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):

All of the GraphicsContext functions that take a Color should now
also take a ColorSpace.

  • platform/graphics/GraphicsContext.h:

Added new member variables stokeColorSpace and fillColorSpace.

  • platform/graphics/GraphicsContextPrivate.h:

(WebCore::GraphicsContextState::GraphicsContextState):

Attempt to keep the Cairo port building with all of the massive
changes to GraphicsContext.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::fillRoundedRect):


  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::sRGBColorSpaceRef): New static function that returns a
CGColorSpaceRef for the sRGB color space.
(WebCore::deviceRGBColorSpaceRef): New static function that returns
a CGColorSpaceRef for the device RGB color space.

(WebCore::setCGFillColor): Now takes a ColorSpace parameter and
sets the fill color to the specified color in the given ColorSpace.
(WebCore::setCGStrokeColor): Same, but for stroke.

(WebCore::setCGFillColorSpace): New static to set the
CGFillColorSpace to the given ColorSpace
(WebCore::setCGStrokeColorSpace): Same, but for stroke.

Send ColorSpaces when appropriate, set ColorSpaces when
appropriate, and check ColorSpaces when appropriate.
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):

Attempt to keep Haiku building.

  • platform/graphics/haiku/GraphicsContextHaiku.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):

Attempt to keep QT building.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):

Attempt to keep Wince building.

  • platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformShadow):

Attempt to keep WX building.

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):

Added functions colorSpace() and setColorSpace()

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::colorSpace):
(WebCore::InheritedFlags::setColorSpace):

The ColorSpace is stored here.

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

All of these call sites call GraphicsContext functions which now
require ColorSpaces.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::paintCaret):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):

  • inspector/InspectorController.cpp:

(WebCore::drawOutlinedQuad):

  • page/FrameView.cpp:

(WebCore::FrameView::paintContents):

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::paintScrollCorner):

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paintScrollCorner):

  • platform/graphics/Image.cpp:

(WebCore::Image::fillWithSolidColor):

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivate::paint):

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineTextBox.cpp:

(WebCore::updateGraphicsContext):
(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):

  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::fillHorizontalSelectionGap):
(WebCore::RenderBlock::fillVerticalSelectionGap):
(WebCore::RenderBlock::fillLeftSelectionGap):
(WebCore::RenderBlock::fillRightSelectionGap):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintBoxShadow):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::paintResizer):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::drawArcForBoxSide):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint):

  • rendering/RenderScrollbarTheme.cpp:

(WebCore::RenderScrollbarTheme::paintScrollCorner):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuListButton):

  • rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):

  • rendering/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintSelection):

  • svg/graphics/SVGPaintServerGradient.cpp:

(WebCore::SVGPaintServerGradient::setup):

  • svg/graphics/SVGPaintServerSolid.cpp:

(WebCore::SVGPaintServerSolid::setup):

WebKit/mac: Small WebKit part of:
Fix for <rdar://problem/7059710>
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
color-correction for CSS colors

Reviewed by Darin Adler.

  • Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:]): setFillColor now
requires callers to pass a ColorSpace.

LayoutTests: Tests for <rdar://problem/7059710>
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
color-correction for CSS colors

Reviewed by Darin Adler.

New tests.

  • fast/css/color-correction-backgrounds-and-text.html: Added.
  • fast/css/color-correction-on-backgrounds.html: Added.
  • fast/css/color-correction-on-text.html: Added.
  • fast/css/color-correction.html: Added.
  • fast/css/parsing-color-correction-expected.txt: Added.
  • fast/css/parsing-color-correction.html: Added.
  • fast/css/resources/parsing-color-correction.js: Added.

(test):

  • fast/css/resources/purple-srgb.png: Added.
  • platform/mac/fast/css/color-correction-backgrounds-and-text-expected.checksum: Added.
  • platform/mac/fast/css/color-correction-backgrounds-and-text-expected.png: Added.
  • platform/mac/fast/css/color-correction-backgrounds-and-text-expected.txt: Added.
  • platform/mac/fast/css/color-correction-expected.checksum: Added.
  • platform/mac/fast/css/color-correction-expected.png: Added.
  • platform/mac/fast/css/color-correction-expected.txt: Added.
  • platform/mac/fast/css/color-correction-on-backgrounds-expected.checksum: Added.
  • platform/mac/fast/css/color-correction-on-backgrounds-expected.png: Added.
  • platform/mac/fast/css/color-correction-on-backgrounds-expected.txt: Added.
  • platform/mac/fast/css/color-correction-on-text-expected.checksum: Added.
  • platform/mac/fast/css/color-correction-on-text-expected.png: Added.
  • platform/mac/fast/css/color-correction-on-text-expected.txt: Added.

New and improved results.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
13:37 Changeset [50759] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-11-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Skip new tests.

  • platform/gtk/Skipped:
13:20 Changeset [50758] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-11-10 Eric Z. Ayers <zundel@google.com>

Reviewed by Timothy Hatcher.

Adds a test to flag changes to values of the WebInspector Timeline record types.
Downstream apps depend on these mappings remaining stable.

https://bugs.webkit.org/show_bug.cgi?id=31303

  • inspector/timeline-enum-stability-expected.txt: Added.
  • inspector/timeline-enum-stability.html: Added.
13:12 Changeset [50757] by eric@webkit.org
  • 106 edits in trunk

2009-11-10 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Update outdated metrics in these tests after r50665 enabled the previously missing scrollbar.
This fixes https://bugs.webkit.org/show_bug.cgi?id=31281.

  • platform/qt/css1/basic/class_as_selector-expected.txt:
  • platform/qt/css1/basic/comments-expected.txt:
  • platform/qt/css1/basic/containment-expected.txt:
  • platform/qt/css1/basic/id_as_selector-expected.txt:
  • platform/qt/css1/basic/inheritance-expected.txt:
  • platform/qt/css1/box_properties/border-expected.txt:
  • platform/qt/css1/box_properties/border_bottom-expected.txt:
  • platform/qt/css1/box_properties/border_bottom_width-expected.txt:
  • platform/qt/css1/box_properties/border_left-expected.txt:
  • platform/qt/css1/box_properties/border_left_width-expected.txt:
  • platform/qt/css1/box_properties/border_right_inline-expected.txt:
  • platform/qt/css1/box_properties/border_right_width-expected.txt:
  • platform/qt/css1/box_properties/border_style-expected.txt:
  • platform/qt/css1/box_properties/border_top-expected.txt:
  • platform/qt/css1/box_properties/border_top_width-expected.txt:
  • platform/qt/css1/box_properties/border_width-expected.txt:
  • platform/qt/css1/box_properties/clear-expected.txt:
  • platform/qt/css1/box_properties/clear_float-expected.txt:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/qt/css1/box_properties/float_margin-expected.txt:
  • platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/qt/css1/box_properties/height-expected.txt:
  • platform/qt/css1/box_properties/margin-expected.txt:
  • platform/qt/css1/box_properties/margin_bottom-expected.txt:
  • platform/qt/css1/box_properties/margin_inline-expected.txt:
  • platform/qt/css1/box_properties/margin_left-expected.txt:
  • platform/qt/css1/box_properties/margin_right-expected.txt:
  • platform/qt/css1/box_properties/margin_top-expected.txt:
  • platform/qt/css1/box_properties/padding-expected.txt:
  • platform/qt/css1/box_properties/padding_bottom-expected.txt:
  • platform/qt/css1/box_properties/padding_inline-expected.txt:
  • platform/qt/css1/box_properties/padding_left-expected.txt:
  • platform/qt/css1/box_properties/padding_right-expected.txt:
  • platform/qt/css1/box_properties/padding_top-expected.txt:
  • platform/qt/css1/box_properties/width-expected.txt:
  • platform/qt/css1/cascade/cascade_order-expected.txt:
  • platform/qt/css1/cascade/important-expected.txt:
  • platform/qt/css1/classification/display-expected.txt:
  • platform/qt/css1/classification/list_style_type-expected.txt:
  • platform/qt/css1/classification/white_space-expected.txt:
  • platform/qt/css1/color_and_background/background-expected.txt:
  • platform/qt/css1/color_and_background/background_attachment-expected.txt:
  • platform/qt/css1/color_and_background/background_color-expected.txt:
  • platform/qt/css1/color_and_background/background_image-expected.txt:
  • platform/qt/css1/color_and_background/background_position-expected.txt:
  • platform/qt/css1/color_and_background/background_repeat-expected.txt:
  • platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/qt/css1/font_properties/font-expected.txt:
  • platform/qt/css1/font_properties/font_family-expected.txt:
  • platform/qt/css1/font_properties/font_size-expected.txt:
  • platform/qt/css1/font_properties/font_weight-expected.txt:
  • platform/qt/css1/formatting_model/floating_elements-expected.txt:
  • platform/qt/css1/formatting_model/height_of_lines-expected.txt:
  • platform/qt/css1/formatting_model/horizontal_formatting-expected.txt:
  • platform/qt/css1/formatting_model/inline_elements-expected.txt:
  • platform/qt/css1/formatting_model/replaced_elements-expected.txt:
  • platform/qt/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/qt/css1/pseudo/anchor-expected.txt:
  • platform/qt/css1/pseudo/firstletter-expected.txt:
  • platform/qt/css1/pseudo/firstline-expected.txt:
  • platform/qt/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/qt/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • platform/qt/css1/text_properties/letter_spacing-expected.txt:
  • platform/qt/css1/text_properties/line_height-expected.txt:
  • platform/qt/css1/text_properties/text_decoration-expected.txt:
  • platform/qt/css1/text_properties/text_indent-expected.txt:
  • platform/qt/css1/text_properties/text_transform-expected.txt:
  • platform/qt/css1/text_properties/vertical_align-expected.txt:
  • platform/qt/css1/text_properties/word_spacing-expected.txt:
  • platform/qt/css1/units/color_units-expected.txt:
  • platform/qt/css1/units/length_units-expected.txt:
  • platform/qt/css1/units/percentage_units-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
  • platform/qt/css2.1/t1202-counter-09-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-08-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-09-b-expected.txt:
  • platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
  • platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
  • platform/qt/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/qt/fast/block/float/008-expected.txt:
  • platform/qt/fast/block/float/019-expected.txt:
  • platform/qt/fast/block/float/033-expected.txt:
  • platform/qt/fast/block/float/035-expected.txt:
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt:
  • platform/qt/fast/box-shadow/basic-shadows-expected.txt:
  • platform/qt/fast/canvas/canvas-bg-expected.txt:
  • platform/qt/fast/css/nested-floating-relative-position-percentages-expected.txt:
  • platform/qt/fast/css/nth-child-dynamic-expected.txt:
  • platform/qt/fast/css/text-rendering-expected.txt:
  • platform/qt/fast/dynamic/anchor-lock-expected.txt:
  • platform/qt/fast/flexbox/flex-hang-expected.txt:
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt:
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/qt/fast/lists/ol-start-parsing-expected.txt:
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
  • platform/qt/fast/table/height-percent-test-expected.txt:
  • platform/qt/fast/table/wide-colspan-expected.txt:
  • platform/qt/fast/table/wide-column-expected.txt:
  • platform/qt/fast/text/text-letter-spacing-expected.txt:
  • platform/qt/svg/css/stars-with-shadow-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29314-expected.txt:

2009-11-10 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove obsolete scrollbar policy settings from DRT constructor.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
13:04 Changeset [50756] by japhet@chromium.org
  • 2 edits in trunk/WebKit/chromium

2009-11-10 Nate Chapin <japhet@chromium.org>

Reviewed by Eric Seidel.

Update references to Canvas 3D classes to use the WebGL prefix
introduced in http://trac.webkit.org/changeset/50725.

https://bugs.webkit.org/show_bug.cgi?id=31276

13:04 Changeset [50755] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-10 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Speed up syntax highlighter
https://bugs.webkit.org/show_bug.cgi?id=31291

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded): (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node. (WebInspector.SourceSyntaxHighlighter.prototype.process): (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken): (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode): (WebInspector.CSSSourceSyntaxHighlighter): (WebInspector.JavaScriptSourceSyntaxHighlighter):
12:52 Changeset [50754] by jorlow@chromium.org
  • 4 edits in trunk/WebCore

2009-11-09 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Eric Seidel.

Remove session storage setting
https://bugs.webkit.org/show_bug.cgi?id=31279

Remove session storage from Settings. It was added temporarily so we could
disable it by default at runtime in Chromium. We now disable these things in a
different way, so it's time to remove it. Qt also depended on this setting for
a short period of time, but after talking to them we agreed that it should be
removed.

This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602

  • page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage):
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:
12:06 Changeset [50753] by mitz@apple.com
  • 5 edits in trunk

WebCore: WebCore part of making full-screen video pause during scrubbing.

Reviewed by Eric Carlson and Darin Adler.

  • WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()

and HTMLMediaElement::endScrubbing().

WebKit/mac: WebKit part of making full-screen video pause during scrubbing.

Reviewed by Eric Carlson and Darin Adler.

  • WebView/WebVideoFullscreenHUDWindowController.h: Added _isScrubbing

ivar.

  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController dealloc]): Assert that
_isScrubbing is NO.
(-[WebVideoFullscreenHUDWindowController endScrubbing]): Call
HTMLMediaElement::endScrubbing().
(-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
If scrubbing has just begun, call HTMLMediaElement::beginScrubbing()
and schedule -endScrubbing to be called when mouse tracking ends.

12:00 Changeset [50752] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-11-10 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
https://bugs.webkit.org/show_bug.cgi?id=31051

  • bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcEpilogue): (WebCore::V8GCController::checkMemoryUsage):
  • bindings/v8/V8GCController.h:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate): (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction):
11:52 Changeset [50751] by eric@webkit.org
  • 1 edit
    6 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebWorker and friends.

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/WebWorkerBase.cpp: Added. (WebKit::WorkerWebFrameClient::didCreateDataSource): (WebKit::WorkerWebFrameClient::sharedInstance): (WebKit::WorkerWebFrameClient::WorkerWebFrameClient): (WebKit::initializeWebKitStaticValues): (WebKit::WebWorkerBase::WebWorkerBase): (WebKit::WebWorkerBase::~WebWorkerBase): (WebKit::WebWorkerBase::stopWorkerThread): (WebKit::WebWorkerBase::initializeLoader): (WebKit::WebWorkerBase::dispatchTaskToMainThread): (WebKit::WebWorkerBase::invokeTaskMethod): (WebKit::WebWorkerBase::postMessageToWorkerObject): (WebKit::WebWorkerBase::postMessageTask): (WebKit::WebWorkerBase::postExceptionToWorkerObject): (WebKit::WebWorkerBase::postExceptionTask): (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject): (WebKit::WebWorkerBase::postConsoleMessageTask): (WebKit::WebWorkerBase::confirmMessageFromWorkerObject): (WebKit::WebWorkerBase::confirmMessageTask): (WebKit::WebWorkerBase::reportPendingActivity): (WebKit::WebWorkerBase::reportPendingActivityTask): (WebKit::WebWorkerBase::workerContextClosed): (WebKit::WebWorkerBase::workerContextClosedTask): (WebKit::WebWorkerBase::workerContextDestroyed): (WebKit::WebWorkerBase::workerContextDestroyedTask): (WebKit::WebWorkerBase::postTaskToLoader): (WebKit::WebWorkerBase::postTaskForModeToWorkerContext):
  • src/WebWorkerBase.h: Added. (WebKit::WebWorkerBase::setWorkerThread): (WebKit::WebWorkerBase::workerThread):
  • src/WebWorkerClientImpl.cpp: Added. (WebKit::WebWorkerClientImpl::createWorkerContextProxy): (WebKit::WebWorkerClientImpl::WebWorkerClientImpl): (WebKit::WebWorkerClientImpl::~WebWorkerClientImpl): (WebKit::WebWorkerClientImpl::setWebWorker): (WebKit::WebWorkerClientImpl::startWorkerContext): (WebKit::WebWorkerClientImpl::terminateWorkerContext): (WebKit::WebWorkerClientImpl::postMessageToWorkerContext): (WebKit::WebWorkerClientImpl::hasPendingActivity): (WebKit::WebWorkerClientImpl::workerObjectDestroyed): (WebKit::WebWorkerClientImpl::postMessageToWorkerObject): (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject): (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject): (WebKit::WebWorkerClientImpl::reportPendingActivity): (WebKit::WebWorkerClientImpl::workerContextDestroyed): (WebKit::WebWorkerClientImpl::workerContextClosed): (WebKit::WebWorkerClientImpl::startWorkerContextTask): (WebKit::WebWorkerClientImpl::terminateWorkerContextTask): (WebKit::WebWorkerClientImpl::postMessageToWorkerContextTask): (WebKit::WebWorkerClientImpl::workerObjectDestroyedTask): (WebKit::WebWorkerClientImpl::postMessageToWorkerObjectTask): (WebKit::WebWorkerClientImpl::postExceptionToWorkerObjectTask): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObjectTask): (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObjectTask): (WebKit::WebWorkerClientImpl::reportPendingActivityTask):
  • src/WebWorkerClientImpl.h: Added. (WebKit::WebWorkerClientImpl::createWorker): (WebKit::WebWorkerClientImpl::notificationPresenter):
  • src/WebWorkerImpl.cpp: Added. (WebKit::WebWorker::create): (WebKit::WebWorkerImpl::WebWorkerImpl): (WebKit::WebWorkerImpl::~WebWorkerImpl): (WebKit::WebWorkerImpl::commonClient): (WebKit::WebWorkerImpl::postMessageToWorkerContextTask): (WebKit::WebWorkerImpl::startWorkerContext): (WebKit::WebWorkerImpl::terminateWorkerContext): (WebKit::WebWorkerImpl::postMessageToWorkerContext): (WebKit::WebWorkerImpl::workerObjectDestroyed): (WebKit::WebWorkerImpl::clientDestroyed):
  • src/WebWorkerImpl.h: Added. (WebKit::WebWorkerImpl::client):
11:45 Changeset [50750] by eric@webkit.org
  • 1 edit
    14 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: Platform specific files.

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/gtk/WebFontInfo.cpp: Added. (WebKit::WebFontInfo::familyForChars):
  • src/gtk/WebInputEventFactory.cpp: Added. (WebKit::gdkEventTimeToWebEventTime): (WebKit::gdkStateToWebEventModifiers): (WebKit::gdkEventToWindowsKeyCode): (WebKit::getControlCharacter): (WebKit::WebInputEventFactory::keyboardEvent): (WebKit::WebInputEventFactory::mouseEvent): (WebKit::WebInputEventFactory::mouseWheelEvent):
  • src/gtk/WebScreenInfoFactory.cpp: Added. (WebKit::WebScreenInfoFactory::screenInfo):
  • src/linux/WebFontRendering.cpp: Added. (WebKit::WebFontRendering::setHinting): (WebKit::WebFontRendering::setAntiAlias): (WebKit::WebFontRendering::setSubpixelGlyphs): (WebKit::WebFontRendering::setLCDOrder): (WebKit::WebFontRendering::setLCDOrientation):
  • src/mac/WebInputEventFactory.mm: Added. (WebKit::isKeyUpEvent): (WebKit::isKeypadEvent): (WebKit::windowsKeyCodeForKeyEvent): (WebKit::textFromEvent): (WebKit::unmodifiedTextFromEvent): (WebKit::keyIdentifierForKeyEvent): (WebKit::modifiersFromEvent): (WebKit::WebInputEventFactory::keyboardEvent): (WebKit::WebInputEventFactory::mouseEvent): (WebKit::WebInputEventFactory::mouseWheelEvent):
  • src/mac/WebScreenInfoFactory.mm: Added. (WebKit::screenForWindow): (WebKit::toUserSpace): (WebKit::WebScreenInfoFactory::screenInfo):
  • src/win/WebInputEventFactory.cpp: Added. (WebKit::isKeyPad): (WebKit::WebInputEventFactory::keyboardEvent): (WebKit::GetRelativeCursorPos): (WebKit::WebInputEventFactory::resetLastClickState): (WebKit::WebInputEventFactory::mouseEvent): (WebKit::WebInputEventFactory::mouseWheelEvent):
  • src/win/WebScreenInfoFactory.cpp: Added. (WebKit::toWebRect): (WebKit::WebScreenInfoFactory::screenInfo):
  • src/x11/WebScreenInfoFactory.cpp: Added. (WebKit::WebScreenInfoFactory::screenInfo):
11:37 Changeset [50749] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Eric Seidel.

Up-streaming Chromium API src files: WrapperResourceRequest and Response

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/WrappedResourceRequest.h: Added. (WebKit::WrappedResourceRequest::~WrappedResourceRequest): (WebKit::WrappedResourceRequest::WrappedResourceRequest): (WebKit::WrappedResourceRequest::bind): (WebKit::WrappedResourceRequest::Handle::dispose):
  • src/WrappedResourceResponse.h: Added. (WebKit::WrappedResourceResponse::~WrappedResourceResponse): (WebKit::WrappedResourceResponse::WrappedResourceResponse): (WebKit::WrappedResourceResponse::bind): (WebKit::WrappedResourceResponse::Handle::dispose):
11:24 Changeset [50748] by eric@webkit.org
  • 9 edits in trunk/WebCore

2009-11-10 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for the part of loader directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31161

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and these are no need to be copyable:

class Request - WebCore/loader/loader.cpp:100
struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
class ApplicationCacheHost - WebCore/loader/DocumentLoader.cpp:151
class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169

Inherits ThreadableLoaderClient class from Noncopyable because (its child class)
MainThreadBridge is instantiated by 'new' in
WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.

ThreadableLoaderClient's inheriting has been changed to public.

  • loader/ImageLoader.cpp:
  • loader/ProgressTracker.cpp:
  • loader/RedirectScheduler.cpp:
  • loader/Request.h:
  • loader/ThreadableLoaderClient.h:
  • loader/WorkerThreadableLoader.h:
  • loader/appcache/ApplicationCacheHost.h:
  • loader/appcache/ApplicationCacheStorage.h:
10:57 Changeset [50747] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Unreviewed documentation fixes.

Added a few improvements from Jocelyn Turcotte to the
createWindow docs.

  • Api/qwebview.cpp:
10:56 Changeset [50746] by eric@webkit.org
  • 1 edit
    8 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: StorageStreamHandlers...StorageNamespaceProxy

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/SocketStreamHandle.cpp: Added. (WebCore::SocketStreamHandleInternal::create): (WebCore::SocketStreamHandleInternal::SocketStreamHandleInternal): (WebCore::SocketStreamHandleInternal::~SocketStreamHandleInternal): (WebCore::SocketStreamHandleInternal::connect): (WebCore::SocketStreamHandleInternal::send): (WebCore::SocketStreamHandleInternal::close): (WebCore::SocketStreamHandleInternal::willOpenStream): (WebCore::SocketStreamHandleInternal::didOpenStream): (WebCore::SocketStreamHandleInternal::didSendData): (WebCore::SocketStreamHandleInternal::didReceiveData): (WebCore::SocketStreamHandleInternal::didClose): (WebCore::SocketStreamHandleInternal::didFail): (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::~SocketStreamHandle): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::platformClose): (WebCore::SocketStreamHandle::didReceiveAuthenticationChallenge): (WebCore::SocketStreamHandle::receivedCredential): (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential): (WebCore::SocketStreamHandle::receivedCancellation):
  • src/StorageAreaProxy.cpp: Added. (WebCore::StorageAreaProxy::StorageAreaProxy): (WebCore::StorageAreaProxy::~StorageAreaProxy): (WebCore::StorageAreaProxy::length): (WebCore::StorageAreaProxy::key): (WebCore::StorageAreaProxy::getItem): (WebCore::StorageAreaProxy::setItem): (WebCore::StorageAreaProxy::removeItem): (WebCore::StorageAreaProxy::clear): (WebCore::StorageAreaProxy::contains):
  • src/StorageAreaProxy.h: Added.
  • src/StorageEventDispatcherChromium.cpp: Added. (WebCore::StorageEventDispatcher::dispatch):
  • src/StorageEventDispatcherImpl.cpp: Added. (WebCore::StorageEventDispatcherImpl::StorageEventDispatcherImpl): (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent):
  • src/StorageEventDispatcherImpl.h: Added.
  • src/StorageNamespaceProxy.cpp: Added. (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace): (WebCore::StorageNamespaceProxy::StorageNamespaceProxy): (WebCore::StorageNamespaceProxy::~StorageNamespaceProxy): (WebCore::StorageNamespaceProxy::copy): (WebCore::StorageNamespaceProxy::storageArea): (WebCore::StorageNamespaceProxy::close): (WebCore::StorageNamespaceProxy::unlock):
  • src/StorageNamespaceProxy.h: Added.
10:52 Changeset [50745] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Unreviewed documentation fix.

[Qt] Make qwebpage's createWindow not qwebview dependent.
https://bugs.webkit.org/show_bug.cgi?id=30771

Update documentation to make it clear that a reimplementation
of the createWindow method of the associated QWebPage can
result in the QWebView::createWindow method to never be called.

  • Api/qwebview.cpp:
10:49 Changeset [50744] by eric@webkit.org
  • 1 edit
    6 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: NotificationPresenterImpl...SharedWorkerRepository

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/NotificationPresenterImpl.cpp: Added. (WebKit::VoidCallbackClient::VoidCallbackClient): (WebKit::VoidCallbackClient::permissionRequestComplete): (WebKit::NotificationPresenterImpl::initialize): (WebKit::NotificationPresenterImpl::isInitialized): (WebKit::NotificationPresenterImpl::show): (WebKit::NotificationPresenterImpl::cancel): (WebKit::NotificationPresenterImpl::notificationObjectDestroyed): (WebKit::NotificationPresenterImpl::checkPermission): (WebKit::NotificationPresenterImpl::requestPermission):
  • src/NotificationPresenterImpl.h: Added. (WebKit::NotificationPresenterImpl::NotificationPresenterImpl):
  • src/PlatformMessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::create): (WebCore::MessagePortChannel::createChannel): (WebCore::MessagePortChannel::MessagePortChannel): (WebCore::MessagePortChannel::~MessagePortChannel): (WebCore::MessagePortChannel::entangleIfOpen): (WebCore::MessagePortChannel::disentangle): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::MessagePortChannel::close): (WebCore::MessagePortChannel::isConnectedTo): (WebCore::MessagePortChannel::hasPendingActivity): (WebCore::MessagePortChannel::locallyEntangledPort): (WebCore::PlatformMessagePortChannel::create): (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::createChannel): (WebCore::PlatformMessagePortChannel::messageAvailable): (WebCore::PlatformMessagePortChannel::entangleIfOpen): (WebCore::PlatformMessagePortChannel::disentangle): (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote): (WebCore::PlatformMessagePortChannel::close): (WebCore::PlatformMessagePortChannel::isConnectedTo): (WebCore::PlatformMessagePortChannel::hasPendingActivity): (WebCore::PlatformMessagePortChannel::setEntangledChannel): (WebCore::PlatformMessagePortChannel::webChannelRelease):
  • src/PlatformMessagePortChannel.h: Added.
  • src/ResourceHandle.cpp: Added. (WebCore::ResourceHandleInternal::ResourceHandleInternal): (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandleInternal::cancel): (WebCore::ResourceHandleInternal::setDefersLoading): (WebCore::ResourceHandleInternal::allowStoredCredentials): (WebCore::ResourceHandleInternal::willSendRequest): (WebCore::ResourceHandleInternal::didSendData): (WebCore::ResourceHandleInternal::didReceiveResponse): (WebCore::ResourceHandleInternal::didReceiveData): (WebCore::ResourceHandleInternal::didFinishLoading): (WebCore::ResourceHandleInternal::didFail): (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create): (WebCore::ResourceHandle::request): (WebCore::ResourceHandle::client): (WebCore::ResourceHandle::setClient): (WebCore::ResourceHandle::setDefersLoading): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::clearAuthentication): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::loadsBlocked): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::ResourceHandle::willLoadFromCache):
  • src/SharedWorkerRepository.cpp: Added. (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): (WebCore::SharedWorkerScriptLoader::load): (WebCore::getWebPort): (WebCore::SharedWorkerScriptLoader::notifyFinished): (WebCore::SharedWorkerScriptLoader::sendConnect): (WebCore::SharedWorkerScriptLoader::contextDestroyed): (WebCore::SharedWorkerScriptLoader::connected): (WebCore::SharedWorkerRepository::isAvailable): (WebCore::getId): (WebCore::SharedWorkerRepository::connect): (WebCore::SharedWorkerRepository::documentDetached): (WebCore::SharedWorkerRepository::hasSharedWorkers):
10:34 Changeset [50743] by eric@webkit.org
  • 1 edit
    5 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: GraphicContext3D...MediaPlaterPrivateChromium

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/GraphicsContext3D.cpp: Added. (WebCore::GraphicsContext3DInternal::): (WebCore::GraphicsContext3DInternal::VertexAttribPointerState::VertexAttribPointerState): (WebCore::tryLoad): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::checkError): (WebCore::GraphicsContext3DInternal::makeContextCurrent): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::createTextureObject): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::flipVertically): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::validateTextureTarget): (WebCore::GraphicsContext3DInternal::validateTextureParameter): (WebCore::GraphicsContext3DInternal::activeTexture): (WebCore::GraphicsContext3DInternal::bindBuffer): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferDataImpl): (WebCore::GraphicsContext3DInternal::disableVertexAttribArray): (WebCore::GraphicsContext3DInternal::enableVertexAttribArray): (WebCore::GraphicsContext3DInternal::vertexAttribPointer): (WebCore::GraphicsContext3DInternal::viewportImpl): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::checkError): (WebCore::GraphicsContext3D::makeContextCurrent): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::endPaint): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getBoolean): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteri): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getFloat): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteri): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getInteger): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgrami): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteri): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderi): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::getTexParameterf): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteri): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformf): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformi): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribf): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribi): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::releaseShaderCompiler): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::texImage2D): (WebCore::unmultiplyAlpha): (WebCore::texImage2DHelper): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport):
  • src/InspectorClientImpl.cpp: Added. (WebKit::InspectorClientImpl::InspectorClientImpl): (WebKit::InspectorClientImpl::~InspectorClientImpl): (WebKit::InspectorClientImpl::inspectorDestroyed): (WebKit::InspectorClientImpl::createPage): (WebKit::InspectorClientImpl::showWindow): (WebKit::InspectorClientImpl::closeWindow): (WebKit::InspectorClientImpl::windowVisible): (WebKit::InspectorClientImpl::attachWindow): (WebKit::InspectorClientImpl::detachWindow): (WebKit::InspectorClientImpl::setAttachedWindowHeight): (WebKit::invalidateNodeBoundingRect): (WebKit::InspectorClientImpl::highlight): (WebKit::InspectorClientImpl::hideHighlight): (WebKit::InspectorClientImpl::inspectedURLChanged): (WebKit::InspectorClientImpl::localizedStringsURL): (WebKit::InspectorClientImpl::hiddenPanels): (WebKit::InspectorClientImpl::populateSetting): (WebKit::InspectorClientImpl::storeSetting): (WebKit::InspectorClientImpl::removeSetting): (WebKit::InspectorClientImpl::inspectorWindowObjectCleared): (WebKit::InspectorClientImpl::loadSettings): (WebKit::InspectorClientImpl::saveSettings):
  • src/InspectorClientImpl.h: Added.
  • src/LocalizedStrings.cpp: Added. (WebCore::query): (WebCore::searchableIndexIntroduction): (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText): (WebCore::AXDefinitionListTermText): (WebCore::AXDefinitionListDefinitionText): (WebCore::AXButtonActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::multipleFileUploadText): (WebCore::unknownFileSizeText): (WebCore::keygenMenuHighGradeKeySize): (WebCore::keygenMenuMediumGradeKeySize): (WebCore::imageTitle): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagTextDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::mediaElementLiveBroadcastStateText): (WebCore::mediaElementLoadingStateText): (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):
  • src/MediaPlayerPrivateChromium.cpp: Added. (WebCore::MediaPlayerPrivate::registerMediaEngine):
10:27 Changeset [50742] by eric@webkit.org
  • 1 edit
    8 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: DOMUtilities...FrameLoaderClientImpl

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/DOMUtilitiesPrivate.cpp: Added. (WebCore::toHTMLElement): (WebKit::toHTMLInputElement): (WebKit::toHTMLLinkElement): (WebKit::toHTMLMetaElement): (WebKit::toHTMLOptionElement): (WebKit::nameOfInputElement):
  • src/DOMUtilitiesPrivate.h: Added.
  • src/DragClientImpl.cpp: Added. (WebKit::DragClientImpl::willPerformDragDestinationAction): (WebKit::DragClientImpl::willPerformDragSourceAction): (WebKit::DragClientImpl::actionMaskForDrag): (WebKit::DragClientImpl::dragSourceActionMaskForPoint): (WebKit::DragClientImpl::startDrag): (WebKit::DragClientImpl::createDragImageForLink): (WebKit::DragClientImpl::dragControllerDestroyed):
  • src/DragClientImpl.h: Added. (WebKit::DragClientImpl::DragClientImpl):
  • src/EditorClientImpl.cpp: Added. (WebKit::EditorClientImpl::EditorClientImpl): (WebKit::EditorClientImpl::~EditorClientImpl): (WebKit::EditorClientImpl::pageDestroyed): (WebKit::EditorClientImpl::shouldShowDeleteInterface): (WebKit::EditorClientImpl::smartInsertDeleteEnabled): (WebKit::EditorClientImpl::isSelectTrailingWhitespaceEnabled): (WebKit::EditorClientImpl::shouldSpellcheckByDefault): (WebKit::EditorClientImpl::isContinuousSpellCheckingEnabled): (WebKit::EditorClientImpl::toggleContinuousSpellChecking): (WebKit::EditorClientImpl::isGrammarCheckingEnabled): (WebKit::EditorClientImpl::toggleGrammarChecking): (WebKit::EditorClientImpl::spellCheckerDocumentTag): (WebKit::EditorClientImpl::isEditable): (WebKit::EditorClientImpl::shouldBeginEditing): (WebKit::EditorClientImpl::shouldEndEditing): (WebKit::EditorClientImpl::shouldInsertNode): (WebKit::EditorClientImpl::shouldInsertText): (WebKit::EditorClientImpl::shouldDeleteRange): (WebKit::EditorClientImpl::shouldChangeSelectedRange): (WebKit::EditorClientImpl::shouldApplyStyle): (WebKit::EditorClientImpl::shouldMoveRangeAfterDelete): (WebKit::EditorClientImpl::didBeginEditing): (WebKit::EditorClientImpl::respondToChangedSelection): (WebKit::EditorClientImpl::respondToChangedContents): (WebKit::EditorClientImpl::didEndEditing): (WebKit::EditorClientImpl::didWriteSelectionToPasteboard): (WebKit::EditorClientImpl::didSetSelectionTypesForPasteboard): (WebKit::EditorClientImpl::registerCommandForUndo): (WebKit::EditorClientImpl::registerCommandForRedo): (WebKit::EditorClientImpl::clearUndoRedoOperations): (WebKit::EditorClientImpl::canUndo): (WebKit::EditorClientImpl::canRedo): (WebKit::EditorClientImpl::undo): (WebKit::EditorClientImpl::redo): (WebKit::): (WebKit::EditorClientImpl::interpretKeyEvent): (WebKit::EditorClientImpl::handleEditingKeyboardEvent): (WebKit::EditorClientImpl::handleKeyboardEvent): (WebKit::EditorClientImpl::handleInputMethodKeydown): (WebKit::EditorClientImpl::textFieldDidBeginEditing): (WebKit::EditorClientImpl::textFieldDidEndEditing): (WebKit::EditorClientImpl::textDidChangeInTextField): (WebKit::EditorClientImpl::showFormAutofillForNode): (WebKit::EditorClientImpl::autofill): (WebKit::EditorClientImpl::doAutofill): (WebKit::EditorClientImpl::cancelPendingAutofill): (WebKit::EditorClientImpl::onAutofillSuggestionAccepted): (WebKit::EditorClientImpl::doTextFieldCommandFromEvent): (WebKit::EditorClientImpl::textWillBeDeletedInTextField): (WebKit::EditorClientImpl::textDidChangeInTextArea): (WebKit::EditorClientImpl::ignoreWordInSpellDocument): (WebKit::EditorClientImpl::learnWord): (WebKit::EditorClientImpl::checkSpellingOfString): (WebKit::EditorClientImpl::getAutoCorrectSuggestionForMisspelledWord): (WebKit::EditorClientImpl::checkGrammarOfString): (WebKit::EditorClientImpl::updateSpellingUIWithGrammarString): (WebKit::EditorClientImpl::updateSpellingUIWithMisspelledWord): (WebKit::EditorClientImpl::showSpellingUI): (WebKit::EditorClientImpl::spellingUIIsShowing): (WebKit::EditorClientImpl::getGuessesForWord): (WebKit::EditorClientImpl::setInputMethodState):
  • src/EditorClientImpl.h: Added. (WebKit::EditorClientImpl::):
  • src/FrameLoaderClientImpl.cpp: Added. (WebKit::): (WebKit::FrameLoaderClientImpl::FrameLoaderClientImpl): (WebKit::FrameLoaderClientImpl::~FrameLoaderClientImpl): (WebKit::FrameLoaderClientImpl::frameLoaderDestroyed): (WebKit::FrameLoaderClientImpl::windowObjectCleared): (WebKit::FrameLoaderClientImpl::documentElementAvailable): (WebKit::FrameLoaderClientImpl::didCreateScriptContextForFrame): (WebKit::FrameLoaderClientImpl::didDestroyScriptContextForFrame): (WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext): (WebKit::FrameLoaderClientImpl::didPerformFirstNavigation): (WebKit::FrameLoaderClientImpl::registerForIconNotification): (WebKit::FrameLoaderClientImpl::didChangeScrollOffset): (WebKit::FrameLoaderClientImpl::allowJavaScript): (WebKit::FrameLoaderClientImpl::hasWebView): (WebKit::FrameLoaderClientImpl::hasFrameView): (WebKit::FrameLoaderClientImpl::makeDocumentView): (WebKit::FrameLoaderClientImpl::makeRepresentation): (WebKit::FrameLoaderClientImpl::forceLayout): (WebKit::FrameLoaderClientImpl::forceLayoutForNonHTML): (WebKit::FrameLoaderClientImpl::setCopiesOnScroll): (WebKit::FrameLoaderClientImpl::detachedFromParent2): (WebKit::FrameLoaderClientImpl::detachedFromParent3): (WebKit::FrameLoaderClientImpl::assignIdentifierToInitialRequest): (WebKit::determineTargetTypeFromLoader): (WebKit::FrameLoaderClientImpl::dispatchWillSendRequest): (WebKit::FrameLoaderClientImpl::shouldUseCredentialStorage): (WebKit::FrameLoaderClientImpl::dispatchDidReceiveAuthenticationChallenge): (WebKit::FrameLoaderClientImpl::dispatchDidCancelAuthenticationChallenge): (WebKit::FrameLoaderClientImpl::dispatchDidReceiveResponse): (WebKit::FrameLoaderClientImpl::dispatchDidReceiveContentLength): (WebKit::FrameLoaderClientImpl::dispatchDidFinishLoading): (WebKit::FrameLoaderClientImpl::dispatchDidFailLoading): (WebKit::FrameLoaderClientImpl::dispatchDidFinishDocumentLoad): (WebKit::FrameLoaderClientImpl::dispatchDidLoadResourceFromMemoryCache): (WebKit::FrameLoaderClientImpl::dispatchDidLoadResourceByXMLHttpRequest): (WebKit::FrameLoaderClientImpl::dispatchDidHandleOnloadEvents): (WebKit::FrameLoaderClientImpl::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebKit::FrameLoaderClientImpl::dispatchDidCancelClientRedirect): (WebKit::FrameLoaderClientImpl::dispatchWillPerformClientRedirect): (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClientImpl::dispatchWillClose): (WebKit::FrameLoaderClientImpl::dispatchDidReceiveIcon): (WebKit::FrameLoaderClientImpl::dispatchDidStartProvisionalLoad): (WebKit::FrameLoaderClientImpl::dispatchDidReceiveTitle): (WebKit::FrameLoaderClientImpl::dispatchDidCommitLoad): (WebKit::FrameLoaderClientImpl::dispatchDidFailProvisionalLoad): (WebKit::FrameLoaderClientImpl::dispatchDidFailLoad): (WebKit::FrameLoaderClientImpl::dispatchDidFinishLoad): (WebKit::FrameLoaderClientImpl::dispatchDidFirstLayout): (WebKit::FrameLoaderClientImpl::dispatchDidFirstVisuallyNonEmptyLayout): (WebKit::FrameLoaderClientImpl::dispatchCreatePage): (WebKit::FrameLoaderClientImpl::dispatchShow): (WebKit::shouldTreatAsAttachment): (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction): (WebKit::FrameLoaderClientImpl::cancelPolicyCheck): (WebKit::FrameLoaderClientImpl::dispatchUnableToImplementPolicy): (WebKit::FrameLoaderClientImpl::dispatchWillSubmitForm): (WebKit::FrameLoaderClientImpl::dispatchDidLoadMainResource): (WebKit::FrameLoaderClientImpl::revertToProvisionalState): (WebKit::FrameLoaderClientImpl::setMainDocumentError): (WebKit::FrameLoaderClientImpl::postProgressStartedNotification): (WebKit::FrameLoaderClientImpl::postProgressEstimateChangedNotification): (WebKit::FrameLoaderClientImpl::postProgressFinishedNotification): (WebKit::FrameLoaderClientImpl::setMainFrameDocumentReady): (WebKit::FrameLoaderClientImpl::startDownload): (WebKit::FrameLoaderClientImpl::willChangeTitle): (WebKit::FrameLoaderClientImpl::didChangeTitle): (WebKit::FrameLoaderClientImpl::committedLoad): (WebKit::FrameLoaderClientImpl::finishedLoading): (WebKit::FrameLoaderClientImpl::updateGlobalHistory): (WebKit::FrameLoaderClientImpl::updateGlobalHistoryRedirectLinks): (WebKit::FrameLoaderClientImpl::shouldGoToHistoryItem): (WebKit::FrameLoaderClientImpl::didDisplayInsecureContent): (WebKit::FrameLoaderClientImpl::didRunInsecureContent): (WebKit::FrameLoaderClientImpl::blockedError): (WebKit::FrameLoaderClientImpl::cancelledError): (WebKit::FrameLoaderClientImpl::cannotShowURLError): (WebKit::FrameLoaderClientImpl::interruptForPolicyChangeError): (WebKit::FrameLoaderClientImpl::cannotShowMIMETypeError): (WebKit::FrameLoaderClientImpl::fileDoesNotExistError): (WebKit::FrameLoaderClientImpl::pluginWillHandleLoadError): (WebKit::FrameLoaderClientImpl::shouldFallBack): (WebKit::FrameLoaderClientImpl::canHandleRequest): (WebKit::FrameLoaderClientImpl::canShowMIMEType): (WebKit::FrameLoaderClientImpl::representationExistsForURLScheme): (WebKit::FrameLoaderClientImpl::generatedMIMETypeForURLScheme): (WebKit::FrameLoaderClientImpl::frameLoadCompleted): (WebKit::FrameLoaderClientImpl::saveViewStateToItem): (WebKit::FrameLoaderClientImpl::restoreViewState): (WebKit::FrameLoaderClientImpl::provisionalLoadStarted): (WebKit::FrameLoaderClientImpl::didFinishLoad): (WebKit::FrameLoaderClientImpl::prepareForDataSourceReplacement): (WebKit::FrameLoaderClientImpl::createDocumentLoader): (WebKit::FrameLoaderClientImpl::setTitle): (WebKit::FrameLoaderClientImpl::userAgent): (WebKit::FrameLoaderClientImpl::savePlatformDataToCachedFrame): (WebKit::FrameLoaderClientImpl::transitionToCommittedFromCachedFrame): (WebKit::FrameLoaderClientImpl::transitionToCommittedForNewPage): (WebKit::FrameLoaderClientImpl::canCachePage): (WebKit::FrameLoaderClientImpl::download): (WebKit::FrameLoaderClientImpl::createFrame): (WebKit::FrameLoaderClientImpl::createPlugin): (WebKit::FrameLoaderClientImpl::redirectDataToPlugin): (WebKit::FrameLoaderClientImpl::createJavaAppletWidget): (WebKit::FrameLoaderClientImpl::objectContentType): (WebKit::FrameLoaderClientImpl::overrideMediaType): (WebKit::FrameLoaderClientImpl::actionSpecifiesNavigationPolicy): (WebKit::FrameLoaderClientImpl::handleBackForwardNavigation): (WebKit::FrameLoaderClientImpl::pluginLoadObserver):
  • src/FrameLoaderClientImpl.h: Added. (WebKit::FrameLoaderClientImpl::webFrame): (WebKit::FrameLoaderClientImpl::willChangeEstimatedProgress): (WebKit::FrameLoaderClientImpl::didChangeEstimatedProgress):
10:19 Changeset [50741] by eric@webkit.org
  • 1 edit
    7 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: ChromeClientImpl...ContextMenuClientImpl

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/ChromeClientImpl.cpp: Added. (WebKit::ChromeClientImpl::ChromeClientImpl): (WebKit::ChromeClientImpl::~ChromeClientImpl): (WebKit::ChromeClientImpl::chromeDestroyed): (WebKit::ChromeClientImpl::setWindowRect): (WebKit::ChromeClientImpl::windowRect): (WebKit::ChromeClientImpl::pageRect): (WebKit::ChromeClientImpl::scaleFactor): (WebKit::ChromeClientImpl::focus): (WebKit::ChromeClientImpl::unfocus): (WebKit::ChromeClientImpl::canTakeFocus): (WebKit::ChromeClientImpl::takeFocus): (WebKit::ChromeClientImpl::focusedNodeChanged): (WebKit::ChromeClientImpl::createWindow): (WebKit::currentEventShouldCauseBackgroundTab): (WebKit::ChromeClientImpl::show): (WebKit::ChromeClientImpl::canRunModal): (WebKit::ChromeClientImpl::runModal): (WebKit::ChromeClientImpl::setToolbarsVisible): (WebKit::ChromeClientImpl::toolbarsVisible): (WebKit::ChromeClientImpl::setStatusbarVisible): (WebKit::ChromeClientImpl::statusbarVisible): (WebKit::ChromeClientImpl::setScrollbarsVisible): (WebKit::ChromeClientImpl::scrollbarsVisible): (WebKit::ChromeClientImpl::setMenubarVisible): (WebKit::ChromeClientImpl::menubarVisible): (WebKit::ChromeClientImpl::setResizable): (WebKit::ChromeClientImpl::addMessageToConsole): (WebKit::ChromeClientImpl::canRunBeforeUnloadConfirmPanel): (WebKit::ChromeClientImpl::runBeforeUnloadConfirmPanel): (WebKit::ChromeClientImpl::closeWindowSoon): (WebKit::ChromeClientImpl::runJavaScriptAlert): (WebKit::ChromeClientImpl::runJavaScriptConfirm): (WebKit::ChromeClientImpl::runJavaScriptPrompt): (WebKit::ChromeClientImpl::setStatusbarText): (WebKit::ChromeClientImpl::shouldInterruptJavaScript): (WebKit::ChromeClientImpl::tabsToLinks): (WebKit::ChromeClientImpl::windowResizerRect): (WebKit::ChromeClientImpl::repaint): (WebKit::ChromeClientImpl::scroll): (WebKit::ChromeClientImpl::screenToWindow): (WebKit::ChromeClientImpl::windowToScreen): (WebKit::ChromeClientImpl::contentsSizeChanged): (WebKit::ChromeClientImpl::scrollbarsModeDidChange): (WebKit::ChromeClientImpl::mouseDidMoveOverElement): (WebKit::ChromeClientImpl::setToolTip): (WebKit::ChromeClientImpl::print): (WebKit::ChromeClientImpl::exceededDatabaseQuota): (WebKit::ChromeClientImpl::reachedMaxAppCacheSize): (WebKit::ChromeClientImpl::runOpenPanel): (WebKit::ChromeClientImpl::popupOpened): (WebKit::ChromeClientImpl::setCursor): (WebKit::ChromeClientImpl::setCursorForPlugin): (WebKit::ChromeClientImpl::formStateDidChange): (WebKit::ChromeClientImpl::getPopupMenuInfo): (WebKit::ChromeClientImpl::notificationPresenter):
  • src/ChromeClientImpl.h: Added. (WebKit::ChromeClientImpl::webView): (WebKit::ChromeClientImpl::platformPageClient): (WebKit::ChromeClientImpl::scrollRectIntoView): (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame): (WebKit::ChromeClientImpl::setCursor): (WebKit::ChromeClientImpl::createHTMLParserQuirks):
  • src/ChromiumBridge.cpp: Added. (WebCore::toChromeClientImpl): (WebCore::toWebWidgetClient): (WebCore::ChromiumBridge::clipboardIsFormatAvailable): (WebCore::ChromiumBridge::clipboardReadPlainText): (WebCore::ChromiumBridge::clipboardReadHTML): (WebCore::ChromiumBridge::clipboardWriteSelection): (WebCore::ChromiumBridge::clipboardWritePlainText): (WebCore::ChromiumBridge::clipboardWriteURL): (WebCore::ChromiumBridge::clipboardWriteImage): (WebCore::ChromiumBridge::setCookies): (WebCore::ChromiumBridge::cookies): (WebCore::ChromiumBridge::rawCookies): (WebCore::ChromiumBridge::deleteCookie): (WebCore::ChromiumBridge::prefetchDNS): (WebCore::ChromiumBridge::fileExists): (WebCore::ChromiumBridge::deleteFile): (WebCore::ChromiumBridge::deleteEmptyDirectory): (WebCore::ChromiumBridge::getFileSize): (WebCore::ChromiumBridge::getFileModificationTime): (WebCore::ChromiumBridge::directoryName): (WebCore::ChromiumBridge::pathByAppendingComponent): (WebCore::ChromiumBridge::makeAllDirectories): (WebCore::ChromiumBridge::getAbsolutePath): (WebCore::ChromiumBridge::isDirectory): (WebCore::ChromiumBridge::filePathToURL): (WebCore::ChromiumBridge::ensureFontLoaded): (WebCore::ChromiumBridge::getFontFamilyForCharacters): (WebCore::ChromiumBridge::databaseOpenFile): (WebCore::ChromiumBridge::databaseDeleteFile): (WebCore::ChromiumBridge::databaseGetFileAttributes): (WebCore::ChromiumBridge::databaseGetFileSize): (WebCore::ChromiumBridge::signedPublicKeyAndChallengeString): (WebCore::ChromiumBridge::computedDefaultLanguage): (WebCore::ChromiumBridge::layoutTestMode): (WebCore::ChromiumBridge::isSupportedImageMIMEType): (WebCore::ChromiumBridge::isSupportedJavaScriptMIMEType): (WebCore::ChromiumBridge::isSupportedNonImageMIMEType): (WebCore::ChromiumBridge::mimeTypeForExtension): (WebCore::ChromiumBridge::mimeTypeFromFile): (WebCore::ChromiumBridge::preferredExtensionForMIMEType): (WebCore::ChromiumBridge::plugins): (WebCore::ChromiumBridge::pluginScriptableObject): (WebCore::ChromiumBridge::loadPlatformImageResource): (WebCore::ChromiumBridge::sandboxEnabled): (WebCore::ChromiumBridge::setSharedTimerFiredFunction): (WebCore::ChromiumBridge::setSharedTimerFireTime): (WebCore::ChromiumBridge::stopSharedTimer): (WebCore::ChromiumBridge::decrementStatsCounter): (WebCore::ChromiumBridge::incrementStatsCounter): (WebCore::ChromiumBridge::suddenTerminationChanged): (WebCore::ChromiumBridge::currentTime): (WebCore::ChromiumBridge::paintButton): (WebCore::ChromiumBridge::paintMenuList): (WebCore::ChromiumBridge::paintScrollbarArrow): (WebCore::ChromiumBridge::paintScrollbarThumb): (WebCore::ChromiumBridge::paintScrollbarTrack): (WebCore::ChromiumBridge::paintTextField): (WebCore::ChromiumBridge::paintTrackbar): (WebCore::ChromiumBridge::traceEventBegin): (WebCore::ChromiumBridge::traceEventEnd): (WebCore::ChromiumBridge::visitedLinkHash): (WebCore::ChromiumBridge::isLinkVisited): (WebCore::ChromiumBridge::notifyJSOutOfMemory): (WebCore::ChromiumBridge::memoryUsageMB): (WebCore::ChromiumBridge::screenDepth): (WebCore::ChromiumBridge::screenDepthPerComponent): (WebCore::ChromiumBridge::screenIsMonochrome): (WebCore::ChromiumBridge::screenRect): (WebCore::ChromiumBridge::screenAvailableRect): (WebCore::ChromiumBridge::popupsAllowed): (WebCore::ChromiumBridge::widgetSetCursor): (WebCore::ChromiumBridge::widgetSetFocus): (WebCore::WorkerContextProxy::create):
  • src/ChromiumCurrentTime.cpp: Added. (WTF::currentTime):
  • src/ChromiumThreading.cpp: Added. (WTF::ChromiumThreading::initializeMainThread): (WTF::ChromiumThreading::scheduleDispatchFunctionsOnMainThread):
  • src/ContextMenuClientImpl.cpp: Added. (WebKit::urlFromFrame): (WebKit::isASingleWord): (WebKit::selectMisspelledWord): (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/ContextMenuClientImpl.h: Added. (WebKit::ContextMenuClientImpl::ContextMenuClientImpl): (WebKit::ContextMenuClientImpl::~ContextMenuClientImpl): (WebKit::ContextMenuClientImpl::copyImageToClipboard): (WebKit::ContextMenuClientImpl::contextMenuDestroyed): (WebKit::ContextMenuClientImpl::contextMenuItemSelected): (WebKit::ContextMenuClientImpl::downloadURL): (WebKit::ContextMenuClientImpl::isSpeaking): (WebKit::ContextMenuClientImpl::lookUpInDictionary): (WebKit::ContextMenuClientImpl::searchWithGoogle): (WebKit::ContextMenuClientImpl::shouldIncludeInspectElementItem): (WebKit::ContextMenuClientImpl::speak): (WebKit::ContextMenuClientImpl::stopSpeaking):
10:12 Changeset [50740] by eric@webkit.org
  • 1 edit
    6 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: AppCach...BackForwardListClientImpl

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/ApplicationCacheHost.cpp: Added. (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal): (WebCore::ApplicationCacheHostInternal::notifyEventListener): (WebCore::ApplicationCacheHost::ApplicationCacheHost): (WebCore::ApplicationCacheHost::~ApplicationCacheHost): (WebCore::ApplicationCacheHost::maybeLoadMainResource): (WebCore::ApplicationCacheHost::selectCacheWithoutManifest): (WebCore::ApplicationCacheHost::selectCacheWithManifest): (WebCore::ApplicationCacheHost::maybeLoadFallbackForMainResponse): (WebCore::ApplicationCacheHost::maybeLoadFallbackForMainError): (WebCore::ApplicationCacheHost::mainResourceDataReceived): (WebCore::ApplicationCacheHost::failedLoadingMainResource): (WebCore::ApplicationCacheHost::finishedLoadingMainResource): (WebCore::ApplicationCacheHost::maybeLoadResource): (WebCore::ApplicationCacheHost::maybeLoadFallbackForRedirect): (WebCore::ApplicationCacheHost::maybeLoadFallbackForResponse): (WebCore::ApplicationCacheHost::maybeLoadFallbackForError): (WebCore::ApplicationCacheHost::maybeLoadSynchronously): (WebCore::ApplicationCacheHost::maybeLoadFallbackSynchronously): (WebCore::ApplicationCacheHost::canCacheInPageCache): (WebCore::ApplicationCacheHost::setDOMApplicationCache): (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): (WebCore::ApplicationCacheHost::status): (WebCore::ApplicationCacheHost::update): (WebCore::ApplicationCacheHost::swapCache): (WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
  • src/AssertMatchingEnums.cpp: Added.
  • src/AutocompletePopupMenuClient.cpp: Added. (WebKit::AutocompletePopupMenuClient::AutocompletePopupMenuClient): (WebKit::AutocompletePopupMenuClient::~AutocompletePopupMenuClient): (WebKit::AutocompletePopupMenuClient::initialize): (WebKit::AutocompletePopupMenuClient::valueChanged): (WebKit::AutocompletePopupMenuClient::itemText): (WebKit::AutocompletePopupMenuClient::itemStyle): (WebKit::AutocompletePopupMenuClient::menuStyle): (WebKit::AutocompletePopupMenuClient::clientPaddingLeft): (WebKit::AutocompletePopupMenuClient::clientPaddingRight): (WebKit::AutocompletePopupMenuClient::popupDidHide): (WebKit::AutocompletePopupMenuClient::setTextFromItem): (WebKit::AutocompletePopupMenuClient::fontSelector): (WebKit::AutocompletePopupMenuClient::hostWindow): (WebKit::AutocompletePopupMenuClient::createScrollbar): (WebKit::AutocompletePopupMenuClient::setSuggestions): (WebKit::AutocompletePopupMenuClient::removeItemAtIndex): (WebKit::AutocompletePopupMenuClient::textFieldStyle):
  • src/AutocompletePopupMenuClient.h: Added. (WebKit::AutocompletePopupMenuClient::textField): (WebKit::AutocompletePopupMenuClient::itemToolTip): (WebKit::AutocompletePopupMenuClient::itemIsEnabled): (WebKit::AutocompletePopupMenuClient::clientInsetLeft): (WebKit::AutocompletePopupMenuClient::clientInsetRight): (WebKit::AutocompletePopupMenuClient::listSize): (WebKit::AutocompletePopupMenuClient::selectedIndex): (WebKit::AutocompletePopupMenuClient::itemIsSeparator): (WebKit::AutocompletePopupMenuClient::itemIsLabel): (WebKit::AutocompletePopupMenuClient::itemIsSelected): (WebKit::AutocompletePopupMenuClient::shouldPopOver): (WebKit::AutocompletePopupMenuClient::valueShouldChangeOnHotTrack):
  • src/BackForwardListClientImpl.cpp: Added. (WebKit::BackForwardListClientImpl::BackForwardListClientImpl): (WebKit::BackForwardListClientImpl::~BackForwardListClientImpl): (WebKit::BackForwardListClientImpl::setCurrentHistoryItem): (WebKit::BackForwardListClientImpl::previousHistoryItem): (WebKit::BackForwardListClientImpl::addItem): (WebKit::BackForwardListClientImpl::goToItem): (WebKit::BackForwardListClientImpl::currentItem): (WebKit::BackForwardListClientImpl::itemAtIndex): (WebKit::BackForwardListClientImpl::backListCount): (WebKit::BackForwardListClientImpl::forwardListCount): (WebKit::BackForwardListClientImpl::close):
  • src/BackForwardListClientImpl.h: Added.
10:04 Changeset [50739] by eric@webkit.org
  • 1 edit
    9 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebString...WebViewImpl

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/WebString.cpp: Added. (WebKit::WebString::reset): (WebKit::WebString::assign): (WebKit::WebString::length): (WebKit::WebString::data): (WebKit::WebString::utf8): (WebKit::WebString::fromUTF8): (WebKit::WebString::WebString): (WebKit::WebString::operator=): (WebKit::WebString::operator WebCore::String): (WebKit::WebString::operator WebCore::AtomicString):
  • src/WebURL.cpp: Added. (WebKit::WebURL::WebURL): (WebKit::WebURL::operator=): (WebKit::WebURL::operator WebCore::KURL):
  • src/WebURLError.cpp: Added. (WebKit::WebURLError::WebURLError): (WebKit::WebURLError::operator=): (WebKit::WebURLError::operator ResourceError):
  • src/WebURLRequest.cpp: Added. (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl): (WebKit::WebURLRequestPrivateImpl::dispose): (WebKit::WebURLRequest::initialize): (WebKit::WebURLRequest::reset): (WebKit::WebURLRequest::assign): (WebKit::WebURLRequest::isNull): (WebKit::WebURLRequest::url): (WebKit::WebURLRequest::setURL): (WebKit::WebURLRequest::firstPartyForCookies): (WebKit::WebURLRequest::setFirstPartyForCookies): (WebKit::WebURLRequest::allowCookies): (WebKit::WebURLRequest::setAllowCookies): (WebKit::WebURLRequest::allowStoredCredentials): (WebKit::WebURLRequest::setAllowStoredCredentials): (WebKit::WebURLRequest::cachePolicy): (WebKit::WebURLRequest::setCachePolicy): (WebKit::WebURLRequest::httpMethod): (WebKit::WebURLRequest::setHTTPMethod): (WebKit::WebURLRequest::httpHeaderField): (WebKit::WebURLRequest::setHTTPHeaderField): (WebKit::WebURLRequest::addHTTPHeaderField): (WebKit::WebURLRequest::clearHTTPHeaderField): (WebKit::WebURLRequest::visitHTTPHeaderFields): (WebKit::WebURLRequest::httpBody): (WebKit::WebURLRequest::setHTTPBody): (WebKit::WebURLRequest::reportUploadProgress): (WebKit::WebURLRequest::setReportUploadProgress): (WebKit::WebURLRequest::targetType): (WebKit::WebURLRequest::setTargetType): (WebKit::WebURLRequest::requestorID): (WebKit::WebURLRequest::setRequestorID): (WebKit::WebURLRequest::requestorProcessID): (WebKit::WebURLRequest::setRequestorProcessID): (WebKit::WebURLRequest::appCacheHostID): (WebKit::WebURLRequest::setAppCacheHostID): (WebKit::WebURLRequest::toMutableResourceRequest): (WebKit::WebURLRequest::toResourceRequest):
  • src/WebURLRequestPrivate.h: Added. (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
  • src/WebURLResponse.cpp: Added. (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl): (WebKit::WebURLResponsePrivateImpl::dispose): (WebKit::WebURLResponse::initialize): (WebKit::WebURLResponse::reset): (WebKit::WebURLResponse::assign): (WebKit::WebURLResponse::isNull): (WebKit::WebURLResponse::url): (WebKit::WebURLResponse::setURL): (WebKit::WebURLResponse::mimeType): (WebKit::WebURLResponse::setMIMEType): (WebKit::WebURLResponse::expectedContentLength): (WebKit::WebURLResponse::setExpectedContentLength): (WebKit::WebURLResponse::textEncodingName): (WebKit::WebURLResponse::setTextEncodingName): (WebKit::WebURLResponse::suggestedFileName): (WebKit::WebURLResponse::setSuggestedFileName): (WebKit::WebURLResponse::httpStatusCode): (WebKit::WebURLResponse::setHTTPStatusCode): (WebKit::WebURLResponse::httpStatusText): (WebKit::WebURLResponse::setHTTPStatusText): (WebKit::WebURLResponse::httpHeaderField): (WebKit::WebURLResponse::setHTTPHeaderField): (WebKit::WebURLResponse::addHTTPHeaderField): (WebKit::WebURLResponse::clearHTTPHeaderField): (WebKit::WebURLResponse::visitHTTPHeaderFields): (WebKit::WebURLResponse::lastModifiedDate): (WebKit::WebURLResponse::setLastModifiedDate): (WebKit::WebURLResponse::isContentFiltered): (WebKit::WebURLResponse::setIsContentFiltered): (WebKit::WebURLResponse::appCacheID): (WebKit::WebURLResponse::setAppCacheID): (WebKit::WebURLResponse::appCacheManifestURL): (WebKit::WebURLResponse::setAppCacheManifestURL): (WebKit::WebURLResponse::securityInfo): (WebKit::WebURLResponse::setSecurityInfo): (WebKit::WebURLResponse::toMutableResourceResponse): (WebKit::WebURLResponse::toResourceResponse):
  • src/WebURLResponsePrivate.h: Added. (WebKit::WebURLResponsePrivate::WebURLResponsePrivate):
  • src/WebViewImpl.cpp: Added. (WebKit::): (WebKit::WebView::create): (WebKit::WebView::updateVisitedLinkState): (WebKit::WebView::resetVisitedLinkState): (WebKit::WebViewImpl::initializeMainFrame): (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::~WebViewImpl): (WebKit::WebViewImpl::theme): (WebKit::WebViewImpl::mainFrameImpl): (WebKit::WebViewImpl::tabKeyCyclesThroughElements): (WebKit::WebViewImpl::setTabKeyCyclesThroughElements): (WebKit::WebViewImpl::mouseMove): (WebKit::WebViewImpl::mouseLeave): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::mouseContextMenu): (WebKit::WebViewImpl::mouseUp): (WebKit::WebViewImpl::mouseWheel): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::charEvent): (WebKit::WebViewImpl::sendContextMenuEvent): (WebKit::WebViewImpl::keyEventDefault): (WebKit::WebViewImpl::scrollViewWithKeyboard): (WebKit::WebViewImpl::propagateScroll): (WebKit::WebViewImpl::focusedWebCoreFrame): (WebKit::WebViewImpl::fromPage): (WebKit::WebViewImpl::close): (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::handleInputEvent): (WebKit::WebViewImpl::mouseCaptureLost): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::handleCompositionEvent): (WebKit::WebViewImpl::queryCompositionStatus): (WebKit::WebViewImpl::setTextDirection): (WebKit::WebViewImpl::settings): (WebKit::WebViewImpl::pageEncoding): (WebKit::WebViewImpl::setPageEncoding): (WebKit::WebViewImpl::dispatchBeforeUnloadEvent): (WebKit::WebViewImpl::dispatchUnloadEvent): (WebKit::WebViewImpl::mainFrame): (WebKit::WebViewImpl::findFrameByName): (WebKit::WebViewImpl::focusedFrame): (WebKit::WebViewImpl::setFocusedFrame): (WebKit::WebViewImpl::setInitialFocus): (WebKit::WebViewImpl::clearFocusedNode): (WebKit::WebViewImpl::zoomIn): (WebKit::WebViewImpl::zoomOut): (WebKit::WebViewImpl::zoomDefault): (WebKit::WebViewImpl::performMediaPlayerAction): (WebKit::WebViewImpl::copyImageAt): (WebKit::WebViewImpl::dragSourceEndedAt): (WebKit::WebViewImpl::dragSourceMovedTo): (WebKit::WebViewImpl::dragSourceSystemDragEnded): (WebKit::WebViewImpl::dragTargetDragEnter): (WebKit::WebViewImpl::dragTargetDragOver): (WebKit::WebViewImpl::dragTargetDragLeave): (WebKit::WebViewImpl::dragTargetDrop): (WebKit::WebViewImpl::dragIdentity): (WebKit::WebViewImpl::inspectElementAt): (WebKit::WebViewImpl::inspectorSettings): (WebKit::WebViewImpl::setInspectorSettings): (WebKit::WebViewImpl::devToolsAgent): (WebKit::WebViewImpl::setDevToolsAgent): (WebKit::WebViewImpl::accessibilityObject): (WebKit::WebViewImpl::applyAutofillSuggestions): (WebKit::WebViewImpl::hideAutofillPopup): (WebKit::WebViewImpl::setDropEffect): (WebKit::WebViewImpl::setIsTransparent): (WebKit::WebViewImpl::isTransparent): (WebKit::WebViewImpl::setIsActive): (WebKit::WebViewImpl::isActive): (WebKit::WebViewImpl::didCommitLoad): (WebKit::WebViewImpl::navigationPolicyFromMouseEvent): (WebKit::WebViewImpl::startDragging): (WebKit::WebViewImpl::setCurrentHistoryItem): (WebKit::WebViewImpl::previousHistoryItem): (WebKit::WebViewImpl::observeNewNavigation): (WebKit::WebViewImpl::hideAutoCompletePopup): (WebKit::WebViewImpl::autoCompletePopupDidHide): (WebKit::WebViewImpl::setIgnoreInputEvents): (WebKit::WebViewImpl::notificationPresenterImpl): (WebKit::WebViewImpl::refreshAutofillPopup): (WebKit::WebViewImpl::focusedWebCoreNode): (WebKit::WebViewImpl::hitTestResultForWindowPos): (WebKit::WebViewImpl::setTabsToLinks): (WebKit::WebViewImpl::tabsToLinks):
  • src/WebViewImpl.h: Added. (WebKit::WebViewImpl::size): (WebKit::WebViewImpl::devToolsAgentPrivate): (WebKit::WebViewImpl::lastMouseDownPoint): (WebKit::WebViewImpl::client): (WebKit::WebViewImpl::page): (WebKit::WebViewImpl::contextMenuAllowed): (WebKit::WebViewImpl::setInitialNavigationPolicy): (WebKit::WebViewImpl::initialNavigationPolicy): (WebKit::WebViewImpl::currentInputEvent): (WebKit::WebViewImpl::):
08:35 Changeset [50738] by japhet@chromium.org
  • 1 edit in trunk/WebKit/chromium/ChangeLog

2009-11-09 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

WebPa*.h and WebPl*.h Chromium API headers.

https://bugs.webkit.org/show_bug.cgi?id=28394

04:38 QtWebKitContrib edited by hausmann@webkit.org
(diff)
03:42 Changeset [50737] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-10 Philippe Normand <pnormand@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Remove WebSocket configuration from WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=31244

Follow-up of r50724. Don't set the enable-web-socket property
anymore.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
03:34 Changeset [50736] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-10 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31047
[GTK] Failing test media/video-played-ranges-1.html

WebKit coding style fixes.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::paint): (WebCore::mimeTypeCache):
03:27 Changeset [50735] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-11-10 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31047
[GTK] Failing test media/video-played-ranges-1.html

  • platform/gtk/Skipped: Unskip fixed tests.
02:59 Changeset [50734] by oliver@apple.com
  • 2 edits in trunk/WebCore

Remove build failure introduced by earlier build fix.

02:54 Changeset [50733] by oliver@apple.com
  • 2 edits in trunk/WebCore

Is this the last build fix? grep tells me yes.

02:51 Changeset [50732] by oliver@apple.com
  • 2 edits in trunk/WebCore

Hopefully the last chrome build fix

02:47 Changeset [50731] by oliver@apple.com
  • 2 edits in trunk/WebCore

Another chrome build fix.

02:44 Changeset [50730] by oliver@apple.com
  • 11 edits in trunk/WebCore

Yet another chrome buildfix

02:20 Changeset [50729] by oliver@apple.com
  • 2 edits in trunk/WebCore

Chrome build fix

01:57 Changeset [50728] by oliver@apple.com
  • 10 edits in trunk/WebKitSite

Fix WebGL demos to work with renamed WebGL primitives

Reviewed by Maciej Stachowiak

01:53 Changeset [50727] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-10 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=30901
[Gtk] Need to de-lint the Atk a11y code

Removal of various and sundry style-violating nits.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
01:45 Changeset [50726] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-10 Philippe Normand <pnormand@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=31047
[GTK] Failing test media/video-played-ranges-1.html

Fix playback rate setter by remembering the rate was changed. Also
correctly handle reverse playback by doing a seek from end to
beginning of the media.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::hasAudio): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::updateStates):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
01:19 Changeset [50725] by oliver@apple.com
  • 42 edits
    3 copies
    82 moves
    3 deletes in trunk

Rename 3D Canvas related classes to use WebGL prefix
https://bugs.webkit.org/show_bug.cgi?id=29095

Reviewed by Maciej Stachowiak.

Automatic rename of all WebGL related types from Canvas* to
WebGL* per more recent version of the WebGL spec.

01:15 Changeset [50724] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-11-10 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Remove WebSocket configuration from WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=31244

Remove non-functional enable-web-sockets property from WebKitWebSettings.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
00:16 Changeset [50723] by eric@webkit.org
  • 1 edit
    14 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebScriptController...WebStorageNamespaceImpl

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/WebScriptController.cpp: Added. (WebKit::WebScriptController::registerExtension): (WebKit::WebScriptController::enableV8SingleThreadMode): (WebKit::WebScriptController::flushConsoleMessages):
  • src/WebSearchableFormData.cpp: Added. (WebCore::GetFormEncoding): (WebCore::IsHTTPFormSubmit): (WebCore::GetButtonToActivate): (WebCore::IsSelectInDefaultState): (WebCore::IsInDefaultState): (WebCore::HasSuitableTextElement): (WebKit::WebSearchableFormData::WebSearchableFormData):
  • src/WebSecurityOrigin.cpp: Added. (WebKit::WebSecurityOrigin::reset): (WebKit::WebSecurityOrigin::assign): (WebKit::WebSecurityOrigin::protocol): (WebKit::WebSecurityOrigin::host): (WebKit::WebSecurityOrigin::port): (WebKit::WebSecurityOrigin::isEmpty): (WebKit::WebSecurityOrigin::toString): (WebKit::WebSecurityOrigin::databaseIdentifier): (WebKit::WebSecurityOrigin::WebSecurityOrigin): (WebKit::WebSecurityOrigin::operator=): (WebKit::WebSecurityOrigin::operator WTF::PassRefPtr<WebCore::SecurityOrigin>):
  • src/WebSecurityPolicy.cpp: Added. (WebKit::WebSecurityPolicy::registerURLSchemeAsLocal): (WebKit::WebSecurityPolicy::registerURLSchemeAsNoAccess): (WebKit::WebSecurityPolicy::whiteListAccessFromOrigin): (WebKit::WebSecurityPolicy::resetOriginAccessWhiteLists):
  • src/WebSettingsImpl.cpp: Added. (WebKit::WebSettingsImpl::WebSettingsImpl): (WebKit::WebSettingsImpl::setStandardFontFamily): (WebKit::WebSettingsImpl::setFixedFontFamily): (WebKit::WebSettingsImpl::setSerifFontFamily): (WebKit::WebSettingsImpl::setSansSerifFontFamily): (WebKit::WebSettingsImpl::setCursiveFontFamily): (WebKit::WebSettingsImpl::setFantasyFontFamily): (WebKit::WebSettingsImpl::setDefaultFontSize): (WebKit::WebSettingsImpl::setDefaultFixedFontSize): (WebKit::WebSettingsImpl::setMinimumFontSize): (WebKit::WebSettingsImpl::setMinimumLogicalFontSize): (WebKit::WebSettingsImpl::setDefaultTextEncodingName): (WebKit::WebSettingsImpl::setJavaScriptEnabled): (WebKit::WebSettingsImpl::setWebSecurityEnabled): (WebKit::WebSettingsImpl::setJavaScriptCanOpenWindowsAutomatically): (WebKit::WebSettingsImpl::setLoadsImagesAutomatically): (WebKit::WebSettingsImpl::setPluginsEnabled): (WebKit::WebSettingsImpl::setDOMPasteAllowed): (WebKit::WebSettingsImpl::setDeveloperExtrasEnabled): (WebKit::WebSettingsImpl::setShrinksStandaloneImagesToFit): (WebKit::WebSettingsImpl::setUsesEncodingDetector): (WebKit::WebSettingsImpl::setTextAreasAreResizable): (WebKit::WebSettingsImpl::setJavaEnabled): (WebKit::WebSettingsImpl::setAllowScriptsToCloseWindows): (WebKit::WebSettingsImpl::setUserStyleSheetLocation): (WebKit::WebSettingsImpl::setUsesPageCache): (WebKit::WebSettingsImpl::setDownloadableBinaryFontsEnabled): (WebKit::WebSettingsImpl::setXSSAuditorEnabled): (WebKit::WebSettingsImpl::setLocalStorageEnabled): (WebKit::WebSettingsImpl::setEditableLinkBehaviorNeverLive): (WebKit::WebSettingsImpl::setFontRenderingModeNormal): (WebKit::WebSettingsImpl::setShouldPaintCustomScrollbars): (WebKit::WebSettingsImpl::setDatabasesEnabled): (WebKit::WebSettingsImpl::setAllowUniversalAccessFromFileURLs): (WebKit::WebSettingsImpl::setTextDirectionSubmenuInclusionBehaviorNeverIncluded): (WebKit::WebSettingsImpl::setOfflineWebApplicationCacheEnabled): (WebKit::WebSettingsImpl::setExperimentalWebGLEnabled):
  • src/WebSettingsImpl.h: Added. (WebKit::WebSettingsImpl::~WebSettingsImpl):
  • src/WebSharedWorkerImpl.cpp: Added. (WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl): (WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl): (WebKit::WebSharedWorkerImpl::isStarted): (WebKit::WebSharedWorkerImpl::connect): (WebKit::WebSharedWorkerImpl::connectTask): (WebKit::WebSharedWorkerImpl::startWorkerContext): (WebKit::WebSharedWorkerImpl::terminateWorkerContext): (WebKit::WebSharedWorkerImpl::clientDestroyed): (WebKit::WebSharedWorkerImpl::client): (WebKit::WebSharedWorker::create):
  • src/WebSharedWorkerImpl.h: Added. (WebKit::WebSharedWorkerImpl::commonClient):
  • src/WebStorageAreaImpl.cpp: Added. (WebKit::WebStorageAreaImpl::WebStorageAreaImpl): (WebKit::WebStorageAreaImpl::~WebStorageAreaImpl): (WebKit::WebStorageAreaImpl::length): (WebKit::WebStorageAreaImpl::key): (WebKit::WebStorageAreaImpl::getItem): (WebKit::WebStorageAreaImpl::setItem): (WebKit::WebStorageAreaImpl::removeItem): (WebKit::WebStorageAreaImpl::clear):
  • src/WebStorageAreaImpl.h: Added. (WebKit::WebStorageAreaImpl::currentStorageEventURL): (WebKit::WebStorageAreaImpl::ScopedStorageEventURL::ScopedStorageEventURL): (WebKit::WebStorageAreaImpl::ScopedStorageEventURL::~ScopedStorageEventURL):
  • src/WebStorageEventDispatcherImpl.cpp: Added. (WebKit::WebStorageEventDispatcher::create): (WebKit::WebStorageEventDispatcherImpl::WebStorageEventDispatcherImpl): (WebKit::WebStorageEventDispatcherImpl::dispatchStorageEvent):
  • src/WebStorageEventDispatcherImpl.h: Added.
  • src/WebStorageNamespaceImpl.cpp: Added. (WebKit::WebStorageNamespace::createLocalStorageNamespace): (WebKit::WebStorageNamespace::createSessionStorageNamespace): (WebKit::WebStorageNamespaceImpl::WebStorageNamespaceImpl): (WebKit::WebStorageNamespaceImpl::~WebStorageNamespaceImpl): (WebKit::WebStorageNamespaceImpl::createStorageArea): (WebKit::WebStorageNamespaceImpl::copy): (WebKit::WebStorageNamespaceImpl::close):
  • src/WebStorageNamespaceImpl.h: Added.
00:09 Changeset [50722] by eric@webkit.org
  • 1 edit
    13 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebPasswordFormData...WebRuntimeFeatures

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/WebPasswordFormData.cpp: Added. (WebKit::): (WebKit::WebPasswordFormData::WebPasswordFormData):
  • src/WebPasswordFormUtils.cpp: Added. (WebKit::findPasswordFormFields):
  • src/WebPasswordFormUtils.h: Added. (WebKit::PasswordFormFields::PasswordFormFields):
  • src/WebPluginContainerImpl.cpp: Added. (WebKit::WebPluginContainerImpl::setFrameRect): (WebKit::WebPluginContainerImpl::paint): (WebKit::WebPluginContainerImpl::invalidateRect): (WebKit::WebPluginContainerImpl::setFocus): (WebKit::WebPluginContainerImpl::show): (WebKit::WebPluginContainerImpl::hide): (WebKit::WebPluginContainerImpl::handleEvent): (WebKit::WebPluginContainerImpl::frameRectsChanged): (WebKit::WebPluginContainerImpl::setParentVisible): (WebKit::WebPluginContainerImpl::setParent): (WebKit::WebPluginContainerImpl::invalidate): (WebKit::WebPluginContainerImpl::reportGeometry): (WebKit::WebPluginContainerImpl::clearScriptObjects): (WebKit::WebPluginContainerImpl::scriptableObjectForElement): (WebKit::WebPluginContainerImpl::executeScriptURL): (WebKit::WebPluginContainerImpl::loadFrameRequest): (WebKit::WebPluginContainerImpl::didReceiveResponse): (WebKit::WebPluginContainerImpl::didReceiveData): (WebKit::WebPluginContainerImpl::didFinishLoading): (WebKit::WebPluginContainerImpl::didFailLoading): (WebKit::WebPluginContainerImpl::scriptableObject): (WebKit::WebPluginContainerImpl::willDestroyPluginLoadObserver): (WebKit::WebPluginContainerImpl::~WebPluginContainerImpl): (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleKeyboardEvent): (WebKit::WebPluginContainerImpl::calculateGeometry): (WebKit::WebPluginContainerImpl::windowClipRect): (WebKit::getObjectStack): (WebKit::checkStackOnTop): (WebKit::WebPluginContainerImpl::windowCutOutRects):
  • src/WebPluginContainerImpl.h: Added. (WebKit::WebPluginContainerImpl::create): (WebKit::WebPluginContainerImpl::plugin): (WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
  • src/WebPluginListBuilderImpl.cpp: Added. (WebKit::WebPluginListBuilderImpl::addPlugin): (WebKit::WebPluginListBuilderImpl::addMediaTypeToLastPlugin): (WebKit::WebPluginListBuilderImpl::addFileExtensionToLastMediaType):
  • src/WebPluginListBuilderImpl.h: Added. (WebKit::WebPluginListBuilderImpl::WebPluginListBuilderImpl):
  • src/WebPluginLoadObserver.cpp: Added. (WebKit::WebPluginLoadObserver::~WebPluginLoadObserver): (WebKit::WebPluginLoadObserver::didFinishLoading): (WebKit::WebPluginLoadObserver::didFailLoading):
  • src/WebPluginLoadObserver.h: Added. (WebKit::WebPluginLoadObserver::WebPluginLoadObserver): (WebKit::WebPluginLoadObserver::url): (WebKit::WebPluginLoadObserver::clearPluginContainer):
  • src/WebPopupMenuImpl.cpp: Added. (WebKit::WebPopupMenu::create): (WebKit::WebPopupMenuImpl::WebPopupMenuImpl): (WebKit::WebPopupMenuImpl::~WebPopupMenuImpl): (WebKit::WebPopupMenuImpl::Init): (WebKit::WebPopupMenuImpl::MouseMove): (WebKit::WebPopupMenuImpl::MouseLeave): (WebKit::WebPopupMenuImpl::MouseDown): (WebKit::WebPopupMenuImpl::MouseUp): (WebKit::WebPopupMenuImpl::MouseWheel): (WebKit::WebPopupMenuImpl::KeyEvent): (WebKit::WebPopupMenuImpl::close): (WebKit::WebPopupMenuImpl::resize): (WebKit::WebPopupMenuImpl::layout): (WebKit::WebPopupMenuImpl::paint): (WebKit::WebPopupMenuImpl::handleInputEvent): (WebKit::WebPopupMenuImpl::mouseCaptureLost): (WebKit::WebPopupMenuImpl::setFocus): (WebKit::WebPopupMenuImpl::handleCompositionEvent): (WebKit::WebPopupMenuImpl::queryCompositionStatus): (WebKit::WebPopupMenuImpl::setTextDirection): (WebKit::WebPopupMenuImpl::repaint): (WebKit::WebPopupMenuImpl::scroll): (WebKit::WebPopupMenuImpl::screenToWindow): (WebKit::WebPopupMenuImpl::windowToScreen): (WebKit::WebPopupMenuImpl::scrollRectIntoView): (WebKit::WebPopupMenuImpl::scrollbarsModeDidChange): (WebKit::WebPopupMenuImpl::popupClosed):
  • src/WebPopupMenuImpl.h: Added. (WebKit::WebPopupMenuImpl::size): (WebKit::WebPopupMenuImpl::client): (WebKit::WebPopupMenuImpl::platformPageClient):
  • src/WebRange.cpp: Added. (WebKit::WebRange::reset): (WebKit::WebRange::assign): (WebKit::WebRange::startOffset): (WebKit::WebRange::endOffset): (WebKit::WebRange::startContainer): (WebKit::WebRange::endContainer): (WebKit::WebRange::toHTMLText): (WebKit::WebRange::toPlainText): (WebKit::WebRange::WebRange): (WebKit::WebRange::operator=): (WebKit::WebRange::operator WTF::PassRefPtr<WebCore::Range>):
  • src/WebRuntimeFeatures.cpp: Added. (WebKit::WebRuntimeFeatures::enableDatabase): (WebKit::WebRuntimeFeatures::isDatabaseEnabled): (WebKit::WebRuntimeFeatures::enableLocalStorage): (WebKit::WebRuntimeFeatures::isLocalStorageEnabled): (WebKit::WebRuntimeFeatures::enableSessionStorage): (WebKit::WebRuntimeFeatures::isSessionStorageEnabled): (WebKit::WebRuntimeFeatures::enableMediaPlayer): (WebKit::WebRuntimeFeatures::isMediaPlayerEnabled): (WebKit::WebRuntimeFeatures::enableSockets): (WebKit::WebRuntimeFeatures::isSocketsEnabled): (WebKit::WebRuntimeFeatures::enableNotifications): (WebKit::WebRuntimeFeatures::isNotificationsEnabled): (WebKit::WebRuntimeFeatures::enableApplicationCache): (WebKit::WebRuntimeFeatures::isApplicationCacheEnabled):
00:01 Changeset [50721] by eric@webkit.org
  • 1 edit
    9 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebFileInputElement...WebNotifications

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/WebInputElement.cpp: Added. (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::operator WTF::PassRefPtr<HTMLInputElement>): (WebKit::WebInputElement::setActivatedSubmit): (WebKit::WebInputElement::setValue): (WebKit::WebInputElement::value): (WebKit::WebInputElement::setAutofilled): (WebKit::WebInputElement::dispatchFormControlChangeEvent): (WebKit::WebInputElement::setSelectionRange):
  • src/WebInputEvent.cpp: Added. (WebKit::staticKeyIdentifiers): (WebKit::WebKeyboardEvent::setKeyIdentifierFromWindowsKeyCode):
  • src/WebInputEventConversion.cpp: Added. (WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder): (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder): (WebKit::toPlatformKeyboardEventType): (WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder): (WebKit::PlatformKeyboardEventBuilder::setKeyType): (WebKit::PlatformKeyboardEventBuilder::isCharacterKey): (WebKit::getWebInputModifiers): (WebKit::WebMouseEventBuilder::WebMouseEventBuilder): (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
  • src/WebInputEventConversion.h: Added.
  • src/WebKit.cpp: Added. (WebKit::initialize): (WebKit::shutdown): (WebKit::webKitClient): (WebKit::setLayoutTestMode): (WebKit::layoutTestMode): (WebKit::resetPluginCache):
  • src/WebMediaPlayerClientImpl.cpp: Added. (WebKit::createWebMediaPlayer): (WebKit::WebMediaPlayerClientImpl::isEnabled): (WebKit::WebMediaPlayerClientImpl::setIsEnabled): (WebKit::WebMediaPlayerClientImpl::registerSelf): (WebKit::WebMediaPlayerClientImpl::networkStateChanged): (WebKit::WebMediaPlayerClientImpl::readyStateChanged): (WebKit::WebMediaPlayerClientImpl::volumeChanged): (WebKit::WebMediaPlayerClientImpl::timeChanged): (WebKit::WebMediaPlayerClientImpl::repaint): (WebKit::WebMediaPlayerClientImpl::durationChanged): (WebKit::WebMediaPlayerClientImpl::rateChanged): (WebKit::WebMediaPlayerClientImpl::sizeChanged): (WebKit::WebMediaPlayerClientImpl::sawUnsupportedTracks): (WebKit::WebMediaPlayerClientImpl::load): (WebKit::WebMediaPlayerClientImpl::cancelLoad): (WebKit::WebMediaPlayerClientImpl::play): (WebKit::WebMediaPlayerClientImpl::pause): (WebKit::WebMediaPlayerClientImpl::naturalSize): (WebKit::WebMediaPlayerClientImpl::hasVideo): (WebKit::WebMediaPlayerClientImpl::hasAudio): (WebKit::WebMediaPlayerClientImpl::setVisible): (WebKit::WebMediaPlayerClientImpl::duration): (WebKit::WebMediaPlayerClientImpl::currentTime): (WebKit::WebMediaPlayerClientImpl::seek): (WebKit::WebMediaPlayerClientImpl::seeking): (WebKit::WebMediaPlayerClientImpl::setEndTime): (WebKit::WebMediaPlayerClientImpl::setRate): (WebKit::WebMediaPlayerClientImpl::paused): (WebKit::WebMediaPlayerClientImpl::supportsFullscreen): (WebKit::WebMediaPlayerClientImpl::supportsSave): (WebKit::WebMediaPlayerClientImpl::setVolume): (WebKit::WebMediaPlayerClientImpl::networkState): (WebKit::WebMediaPlayerClientImpl::readyState): (WebKit::WebMediaPlayerClientImpl::maxTimeSeekable): (WebKit::WebMediaPlayerClientImpl::buffered): (WebKit::WebMediaPlayerClientImpl::dataRate): (WebKit::WebMediaPlayerClientImpl::totalBytesKnown): (WebKit::WebMediaPlayerClientImpl::totalBytes): (WebKit::WebMediaPlayerClientImpl::bytesLoaded): (WebKit::WebMediaPlayerClientImpl::setSize): (WebKit::WebMediaPlayerClientImpl::paint): (WebKit::WebMediaPlayerClientImpl::setAutobuffer): (WebKit::WebMediaPlayerClientImpl::hasSingleSecurityOrigin): (WebKit::WebMediaPlayerClientImpl::movieLoadType): (WebKit::WebMediaPlayerClientImpl::create): (WebKit::WebMediaPlayerClientImpl::getSupportedTypes): (WebKit::WebMediaPlayerClientImpl::supportsType): (WebKit::WebMediaPlayerClientImpl::WebMediaPlayerClientImpl):
  • src/WebMediaPlayerClientImpl.h: Added.
  • src/WebNode.cpp: Added. (WebKit::WebNode::reset): (WebKit::WebNode::assign): (WebKit::WebNode::parentNode): (WebKit::WebNode::nodeName): (WebKit::WebNode::WebNode): (WebKit::WebNode::operator=): (WebKit::WebNode::operator WTF::PassRefPtr<WebCore::Node>): (WebKit::WebNode::frame):
  • src/WebNotification.cpp: Added. (WebKit::WebNotification::reset): (WebKit::WebNotification::assign): (WebKit::WebNotification::lessThan): (WebKit::WebNotification::isHTML): (WebKit::WebNotification::url): (WebKit::WebNotification::icon): (WebKit::WebNotification::title): (WebKit::WebNotification::body): (WebKit::WebNotification::dispatchDisplayEvent): (WebKit::WebNotification::dispatchErrorEvent): (WebKit::WebNotification::dispatchCloseEvent): (WebKit::WebNotification::WebNotification): (WebKit::WebNotification::operator=): (WebKit::WebNotification::operator WTF::PassRefPtr<Notification>):

11/09/09:

23:54 Changeset [50720] by eric@webkit.org
  • 1 edit
    10 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebFileChooser...WebImageSkia

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/WebFileChooserCompletionImpl.cpp: Added. (WebKit::WebFileChooserCompletionImpl::WebFileChooserCompletionImpl): (WebKit::WebFileChooserCompletionImpl::~WebFileChooserCompletionImpl): (WebKit::WebFileChooserCompletionImpl::didChooseFile):
  • src/WebFileChooserCompletionImpl.h: Added.
  • src/WebFontCache.cpp: Added. (WebKit::WebFontCache::fontDataCount): (WebKit::WebFontCache::inactiveFontDataCount): (WebKit::WebFontCache::clear):
  • src/WebFormElement.cpp: Added. (WebKit::WebFormElement::WebFormElement): (WebKit::WebFormElement::operator=): (WebKit::WebFormElement::operator WTF::PassRefPtr<WebCore::HTMLFormElement>): (WebKit::WebFormElement::autoComplete): (WebKit::WebFormElement::action): (WebKit::WebFormElement::submit): (WebKit::WebFormElement::getNamedElements):
  • src/WebFrameImpl.cpp: Added. (WebKit::frameContentAsPlainText): (WebKit::ChromePrintContext::ChromePrintContext): (WebKit::ChromePrintContext::begin): (WebKit::ChromePrintContext::getPageShrink): (WebKit::ChromePrintContext::spoolPage): (WebKit::DataSourceForDocLoader): (WebKit::WebFrameImpl::DeferredScopeStringMatches::DeferredScopeStringMatches): (WebKit::WebFrameImpl::DeferredScopeStringMatches::doTimeout): (WebKit::WebFrame::frameForEnteredContext): (WebKit::WebFrame::frameForCurrentContext): (WebKit::WebFrameImpl::name): (WebKit::WebFrameImpl::url): (WebKit::WebFrameImpl::favIconURL): (WebKit::WebFrameImpl::openSearchDescriptionURL): (WebKit::WebFrameImpl::scrollOffset): (WebKit::WebFrameImpl::contentsSize): (WebKit::WebFrameImpl::contentsPreferredWidth): (WebKit::WebFrameImpl::hasVisibleContent): (WebKit::WebFrameImpl::view): (WebKit::WebFrameImpl::opener): (WebKit::WebFrameImpl::parent): (WebKit::WebFrameImpl::top): (WebKit::WebFrameImpl::firstChild): (WebKit::WebFrameImpl::lastChild): (WebKit::WebFrameImpl::nextSibling): (WebKit::WebFrameImpl::previousSibling): (WebKit::WebFrameImpl::traverseNext): (WebKit::WebFrameImpl::traversePrevious): (WebKit::WebFrameImpl::findChildByName): (WebKit::WebFrameImpl::findChildByExpression): (WebKit::WebFrameImpl::forms): (WebKit::WebFrameImpl::securityOrigin): (WebKit::WebFrameImpl::grantUniversalAccess): (WebKit::WebFrameImpl::windowObject): (WebKit::WebFrameImpl::bindToWindowObject): (WebKit::WebFrameImpl::executeScript): (WebKit::WebFrameImpl::executeScriptInNewContext): (WebKit::WebFrameImpl::executeScriptInIsolatedWorld): (WebKit::WebFrameImpl::addMessageToConsole): (WebKit::WebFrameImpl::collectGarbage): (WebKit::WebFrameImpl::mainWorldScriptContext): (WebKit::WebFrameImpl::insertStyleText): (WebKit::WebFrameImpl::reload): (WebKit::WebFrameImpl::loadRequest): (WebKit::WebFrameImpl::loadHistoryItem): (WebKit::WebFrameImpl::loadData): (WebKit::WebFrameImpl::loadHTMLString): (WebKit::WebFrameImpl::isLoading): (WebKit::WebFrameImpl::stopLoading): (WebKit::WebFrameImpl::provisionalDataSource): (WebKit::WebFrameImpl::dataSource): (WebKit::WebFrameImpl::previousHistoryItem): (WebKit::WebFrameImpl::currentHistoryItem): (WebKit::WebFrameImpl::enableViewSourceMode): (WebKit::WebFrameImpl::isViewSourceModeEnabled): (WebKit::WebFrameImpl::setReferrerForRequest): (WebKit::WebFrameImpl::dispatchWillSendRequest): (WebKit::WebFrameImpl::commitDocumentData): (WebKit::WebFrameImpl::unloadListenerCount): (WebKit::WebFrameImpl::isProcessingUserGesture): (WebKit::WebFrameImpl::willSuppressOpenerInNewFrame): (WebKit::WebFrameImpl::replaceSelection): (WebKit::WebFrameImpl::insertText): (WebKit::WebFrameImpl::setMarkedText): (WebKit::WebFrameImpl::unmarkText): (WebKit::WebFrameImpl::hasMarkedText): (WebKit::WebFrameImpl::markedRange): (WebKit::WebFrameImpl::executeCommand): (WebKit::WebFrameImpl::isCommandEnabled): (WebKit::WebFrameImpl::enableContinuousSpellChecking): (WebKit::WebFrameImpl::isContinuousSpellCheckingEnabled): (WebKit::WebFrameImpl::hasSelection): (WebKit::WebFrameImpl::selectionRange): (WebKit::WebFrameImpl::selectionAsText): (WebKit::WebFrameImpl::selectionAsMarkup): (WebKit::WebFrameImpl::printBegin): (WebKit::WebFrameImpl::getPrintPageShrink): (WebKit::WebFrameImpl::printPage): (WebKit::WebFrameImpl::printEnd): (WebKit::WebFrameImpl::find): (WebKit::WebFrameImpl::stopFinding): (WebKit::WebFrameImpl::scopeStringMatches): (WebKit::WebFrameImpl::cancelPendingScopingEffort): (WebKit::WebFrameImpl::increaseMatchCount): (WebKit::WebFrameImpl::reportFindInPageSelection): (WebKit::WebFrameImpl::resetMatchCount): (WebKit::WebFrameImpl::completeURL): (WebKit::WebFrameImpl::contentAsText): (WebKit::WebFrameImpl::contentAsMarkup): (WebKit::WebFrameImpl::create): (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::~WebFrameImpl): (WebKit::WebFrameImpl::initializeAsMainFrame): (WebKit::WebFrameImpl::createChildFrame): (WebKit::WebFrameImpl::layout): (WebKit::WebFrameImpl::paint): (WebKit::WebFrameImpl::createFrameView): (WebKit::WebFrameImpl::fromFrame): (WebKit::WebFrameImpl::viewImpl): (WebKit::WebFrameImpl::dataSourceImpl): (WebKit::WebFrameImpl::provisionalDataSourceImpl): (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection): (WebKit::WebFrameImpl::didFail): (WebKit::WebFrameImpl::setAllowsScrolling): (WebKit::WebFrameImpl::registerPasswordListener): (WebKit::WebFrameImpl::getPasswordListener): (WebKit::WebFrameImpl::closing): (WebKit::WebFrameImpl::invalidateArea): (WebKit::WebFrameImpl::addMarker): (WebKit::WebFrameImpl::setMarkerActive): (WebKit::WebFrameImpl::ordinalOfFirstMatchForFrame): (WebKit::WebFrameImpl::shouldScopeMatches): (WebKit::WebFrameImpl::scopeStringMatchesSoon): (WebKit::WebFrameImpl::callScopeStringMatches): (WebKit::WebFrameImpl::invalidateIfNecessary): (WebKit::WebFrameImpl::clearPasswordListeners): (WebKit::WebFrameImpl::loadJavaScriptURL):
  • src/WebFrameImpl.h: Added. (WebKit::WebFrameImpl::liveObjectCount): (WebKit::WebFrameImpl::frame): (WebKit::WebFrameImpl::frameView): (WebKit::WebFrameImpl::activeMatchFrame): (WebKit::WebFrameImpl::client): (WebKit::WebFrameImpl::dropClient): (WebKit::WebFrameImpl::ClientHandle::create): (WebKit::WebFrameImpl::ClientHandle::client): (WebKit::WebFrameImpl::ClientHandle::dropClient): (WebKit::WebFrameImpl::ClientHandle::ClientHandle): (WebKit::WebFrameImpl::):
  • src/WebHTTPBody.cpp: Added. (WebKit::WebHTTPBody::initialize): (WebKit::WebHTTPBody::reset): (WebKit::WebHTTPBody::assign): (WebKit::WebHTTPBody::elementCount): (WebKit::WebHTTPBody::elementAt): (WebKit::WebHTTPBody::appendData): (WebKit::WebHTTPBody::appendFile): (WebKit::WebHTTPBody::identifier): (WebKit::WebHTTPBody::setIdentifier): (WebKit::WebHTTPBody::WebHTTPBody): (WebKit::WebHTTPBody::operator=): (WebKit::WebHTTPBody::operator PassRefPtr<FormData>): (WebKit::WebHTTPBody::ensureMutable):
  • src/WebHistoryItem.cpp: Added. (WebKit::WebHistoryItem::initialize): (WebKit::WebHistoryItem::reset): (WebKit::WebHistoryItem::assign): (WebKit::WebHistoryItem::urlString): (WebKit::WebHistoryItem::setURLString): (WebKit::WebHistoryItem::originalURLString): (WebKit::WebHistoryItem::setOriginalURLString): (WebKit::WebHistoryItem::referrer): (WebKit::WebHistoryItem::setReferrer): (WebKit::WebHistoryItem::target): (WebKit::WebHistoryItem::setTarget): (WebKit::WebHistoryItem::parent): (WebKit::WebHistoryItem::setParent): (WebKit::WebHistoryItem::title): (WebKit::WebHistoryItem::setTitle): (WebKit::WebHistoryItem::alternateTitle): (WebKit::WebHistoryItem::setAlternateTitle): (WebKit::WebHistoryItem::lastVisitedTime): (WebKit::WebHistoryItem::setLastVisitedTime): (WebKit::WebHistoryItem::scrollOffset): (WebKit::WebHistoryItem::setScrollOffset): (WebKit::WebHistoryItem::isTargetItem): (WebKit::WebHistoryItem::setIsTargetItem): (WebKit::WebHistoryItem::visitCount): (WebKit::WebHistoryItem::setVisitCount): (WebKit::WebHistoryItem::documentState): (WebKit::WebHistoryItem::setDocumentState): (WebKit::WebHistoryItem::httpContentType): (WebKit::WebHistoryItem::setHTTPContentType): (WebKit::WebHistoryItem::httpBody): (WebKit::WebHistoryItem::setHTTPBody): (WebKit::WebHistoryItem::children): (WebKit::WebHistoryItem::setChildren): (WebKit::WebHistoryItem::appendToChildren): (WebKit::WebHistoryItem::WebHistoryItem): (WebKit::WebHistoryItem::operator=): (WebKit::WebHistoryItem::operator PassRefPtr<HistoryItem>): (WebKit::WebHistoryItem::ensureMutable):
  • src/WebImageCG.cpp: Added. (WebKit::WebImage::fromData): (WebKit::WebImage::reset): (WebKit::WebImage::assign): (WebKit::WebImage::isNull): (WebKit::WebImage::size): (WebKit::WebImage::WebImage): (WebKit::WebImage::operator=):
  • src/WebImageSkia.cpp: Added. (WebKit::WebImage::fromData): (WebKit::WebImage::reset): (WebKit::WebImage::assign): (WebKit::WebImage::isNull): (WebKit::WebImage::size): (WebKit::WebImage::WebImage): (WebKit::WebImage::operator=):
23:46 Changeset [50719] by eric@webkit.org
  • 1 edit
    7 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.src>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebData...WebElement

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/WebData.cpp: Added. (WebKit::WebData::reset): (WebKit::WebData::assign): (WebKit::WebData::size): (WebKit::WebData::data): (WebKit::WebData::WebData): (WebKit::WebData::operator=): (WebKit::WebData::operator PassRefPtr<SharedBuffer>):
  • src/WebDataSourceImpl.cpp: Added. (WebKit::WebDataSourceImpl::create): (WebKit::WebDataSourceImpl::originalRequest): (WebKit::WebDataSourceImpl::request): (WebKit::WebDataSourceImpl::response): (WebKit::WebDataSourceImpl::hasUnreachableURL): (WebKit::WebDataSourceImpl::unreachableURL): (WebKit::WebDataSourceImpl::redirectChain): (WebKit::WebDataSourceImpl::pageTitle): (WebKit::WebDataSourceImpl::navigationType): (WebKit::WebDataSourceImpl::triggeringEventTime): (WebKit::WebDataSourceImpl::extraData): (WebKit::WebDataSourceImpl::setExtraData): (WebKit::WebDataSourceImpl::toWebNavigationType): (WebKit::WebDataSourceImpl::endOfRedirectChain): (WebKit::WebDataSourceImpl::clearRedirectChain): (WebKit::WebDataSourceImpl::appendRedirect): (WebKit::WebDataSourceImpl::setNextPluginLoadObserver): (WebKit::WebDataSourceImpl::WebDataSourceImpl): (WebKit::WebDataSourceImpl::~WebDataSourceImpl):
  • src/WebDataSourceImpl.h: Added. (WebKit::WebDataSourceImpl::fromDocumentLoader): (WebKit::WebDataSourceImpl::hasRedirectChain): (WebKit::WebDataSourceImpl::releasePluginLoadObserver):
  • src/WebDatabase.cpp: Added. (WebKit::WebDatabase::reset): (WebKit::WebDatabase::assign): (WebKit::WebDatabase::name): (WebKit::WebDatabase::displayName): (WebKit::WebDatabase::estimatedSize): (WebKit::WebDatabase::securityOrigin): (WebKit::WebDatabase::setObserver): (WebKit::WebDatabase::observer): (WebKit::WebDatabase::updateDatabaseSize): (WebKit::WebDatabase::WebDatabase): (WebKit::WebDatabase::operator=): (WebKit::WebDatabase::operator WTF::PassRefPtr<Database>):
  • src/WebDevToolsAgentPrivate.h: Added.
  • src/WebDragData.cpp: Added. (WebKit::WebDragData::initialize): (WebKit::WebDragData::reset): (WebKit::WebDragData::assign): (WebKit::WebDragData::url): (WebKit::WebDragData::setURL): (WebKit::WebDragData::urlTitle): (WebKit::WebDragData::setURLTitle): (WebKit::WebDragData::fileExtension): (WebKit::WebDragData::setFileExtension): (WebKit::WebDragData::hasFileNames): (WebKit::WebDragData::fileNames): (WebKit::WebDragData::setFileNames): (WebKit::WebDragData::appendToFileNames): (WebKit::WebDragData::plainText): (WebKit::WebDragData::setPlainText): (WebKit::WebDragData::htmlText): (WebKit::WebDragData::setHTMLText): (WebKit::WebDragData::htmlBaseURL): (WebKit::WebDragData::setHTMLBaseURL): (WebKit::WebDragData::fileContentFileName): (WebKit::WebDragData::setFileContentFileName): (WebKit::WebDragData::fileContent): (WebKit::WebDragData::setFileContent): (WebKit::WebDragData::WebDragData): (WebKit::WebDragData::operator=): (WebKit::WebDragData::operator WTF::PassRefPtr<WebCore::ChromiumDataObject>): (WebKit::WebDragData::ensureMutable):
  • src/WebElement.cpp: Added. (WebKit::WebElement::WebElement): (WebKit::WebElement::operator=): (WebKit::WebElement::operator WTF::PassRefPtr<Element>):
23:23 Changeset [50718] by krit@webkit.org
  • 3 edits
    4 adds in trunk

2009-11-09 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

SVG feDisplacementMap is not implemented
https://bugs.webkit.org/show_bug.cgi?id=31255

This is the implementation of the SVG filter effect
feDisplacementMap.

Test: svg/filters/feDisplacementMap.svg

  • svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):

Test for SVG filter effect feDisplacementMap.

  • platform/mac/svg/filters/feDisplacementMap-expected.checksum: Added.
  • platform/mac/svg/filters/feDisplacementMap-expected.png: Added.
  • platform/mac/svg/filters/feDisplacementMap-expected.txt: Added.
  • svg/filters/feDisplacementMap.svg: Added.
21:05 Changeset [50717] by eric@webkit.org
  • 1 edit
    4 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

WebPo*.h and WebRunetimeFeatures.h Chromium API headers.

https://bugs.webkit.org/show_bug.cgi?id=28394

  • public/WebPoint.h: Added. (WebKit::WebPoint::WebPoint): (WebKit::WebPoint::operator=): (WebKit::WebPoint::operator WebCore::IntPoint): (WebKit::WebPoint::operator gfx::Point): (WebKit::operator==): (WebKit::operator!=):
  • public/WebPopupMenu.h: Added.
  • public/WebPopupMenuInfo.h: Added. (WebKit::WebPopupMenuInfo::Item::):
  • public/WebRuntimeFeatures.h: Added.
20:58 Changeset [50716] by eric@webkit.org
  • 1 edit
    6 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

WebPa*.h and WebPl*.h Chromium API headers.

https://bugs.webkit.org/show_bug.cgi?id=28394

  • public/WebPasswordAutocompleteListener.h: Added. (WebKit::WebPasswordAutocompleteListener::~WebPasswordAutocompleteListener):
  • public/WebPasswordFormData.h: Added. (WebKit::WebPasswordFormData::isValid):
  • public/WebPlugin.h: Added. (WebKit::WebPlugin::~WebPlugin):
  • public/WebPluginContainer.h: Added. (WebKit::WebPluginContainer::~WebPluginContainer):
  • public/WebPluginListBuilder.h: Added.
  • public/WebPluginParams.h: Added.
20:50 Changeset [50715] by eric@webkit.org
  • 1 edit
    6 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebBindging ... WebCursorInfo

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/WebBindings.cpp: Added. (WebKit::WebBindings::construct): (WebKit::WebBindings::createObject): (WebKit::WebBindings::enumerate): (WebKit::WebBindings::evaluate): (WebKit::WebBindings::evaluateHelper): (WebKit::WebBindings::getIntIdentifier): (WebKit::WebBindings::getProperty): (WebKit::WebBindings::getStringIdentifier): (WebKit::WebBindings::getStringIdentifiers): (WebKit::WebBindings::hasMethod): (WebKit::WebBindings::hasProperty): (WebKit::WebBindings::identifierIsString): (WebKit::WebBindings::intFromIdentifier): (WebKit::WebBindings::initializeVariantWithStringCopy): (WebKit::WebBindings::invoke): (WebKit::WebBindings::invokeDefault): (WebKit::WebBindings::releaseObject): (WebKit::WebBindings::releaseVariantValue): (WebKit::WebBindings::removeProperty): (WebKit::WebBindings::retainObject): (WebKit::WebBindings::setException): (WebKit::WebBindings::setProperty): (WebKit::WebBindings::unregisterObject): (WebKit::WebBindings::utf8FromIdentifier): (WebKit::WebBindings::extractIdentifierData): (WebKit::getEvent): (WebKit::getDragDataImpl): (WebKit::getRangeImpl): (WebKit::WebBindings::getDragData): (WebKit::WebBindings::isDragEvent): (WebKit::WebBindings::getRange):
  • src/WebCString.cpp: Added. (WebKit::WebCString::reset): (WebKit::WebCString::assign): (WebKit::WebCString::length): (WebKit::WebCString::data): (WebKit::WebCString::utf16): (WebKit::WebCString::fromUTF16): (WebKit::WebCString::WebCString): (WebKit::WebCString::operator=): (WebKit::WebCString::operator WebCore::CString):
  • src/WebCache.cpp: Added. (WebKit::ToResourceTypeStat): (WebKit::WebCache::setCapacities): (WebKit::WebCache::clear): (WebKit::WebCache::getUsageStats): (WebKit::WebCache::getResourceTypeStats):
  • src/WebColor.cpp: Added. (WebKit::toCSSValueKeyword): (WebKit::setNamedColors):
  • src/WebCrossOriginPreflightResultCache.cpp: Added. (WebKit::WebCrossOriginPreflightResultCache::clear):
  • src/WebCursorInfo.cpp: Added. (WebKit::WebCursorInfo::WebCursorInfo):
20:43 Changeset [50714] by eric@webkit.org
  • 1 edit
    5 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebAccessibilty

https://bugs.webkit.org/show_bug.cgi?id=31276

  • src/WebAccessibilityCache.cpp: Added. (WebKit::WebAccessibilityCache::enableAccessibility):
  • src/WebAccessibilityCacheImpl.cpp: Added. (WebKit::toAccessibilityObject): (WebKit::WebAccessibilityCache::create): (WebKit::WebAccessibilityCacheImpl::WeakHandle::create): (WebKit::WebAccessibilityCacheImpl::WeakHandle::WeakHandle): (WebKit::WebAccessibilityCacheImpl::WeakHandle::detach): (WebKit::WebAccessibilityCacheImpl::WebAccessibilityCacheImpl): (WebKit::WebAccessibilityCacheImpl::~WebAccessibilityCacheImpl): (WebKit::WebAccessibilityCacheImpl::initialize): (WebKit::WebAccessibilityCacheImpl::getObjectById): (WebKit::WebAccessibilityCacheImpl::isValidId): (WebKit::WebAccessibilityCacheImpl::remove): (WebKit::WebAccessibilityCacheImpl::clear): (WebKit::WebAccessibilityCacheImpl::addOrGetId):
  • src/WebAccessibilityCacheImpl.h: Added. (WebKit::WebAccessibilityCacheImpl::isInitialized):
  • src/WebAccessibilityObject.cpp: Added. (WebKit::WebAccessibilityObject::reset): (WebKit::WebAccessibilityObject::assign): (WebKit::WebAccessibilityObject::accessibilityDescription): (WebKit::WebAccessibilityObject::actionVerb): (WebKit::WebAccessibilityObject::canSetFocusAttribute): (WebKit::WebAccessibilityObject::childCount): (WebKit::WebAccessibilityObject::childAt): (WebKit::WebAccessibilityObject::firstChild): (WebKit::WebAccessibilityObject::focusedChild): (WebKit::WebAccessibilityObject::lastChild): (WebKit::WebAccessibilityObject::nextSibling): (WebKit::WebAccessibilityObject::parentObject): (WebKit::WebAccessibilityObject::previousSibling): (WebKit::WebAccessibilityObject::isAnchor): (WebKit::WebAccessibilityObject::isChecked): (WebKit::WebAccessibilityObject::isFocused): (WebKit::WebAccessibilityObject::isEnabled): (WebKit::WebAccessibilityObject::isHovered): (WebKit::WebAccessibilityObject::isIndeterminate): (WebKit::WebAccessibilityObject::isMultiSelect): (WebKit::WebAccessibilityObject::isOffScreen): (WebKit::WebAccessibilityObject::isPasswordField): (WebKit::WebAccessibilityObject::isPressed): (WebKit::WebAccessibilityObject::isReadOnly): (WebKit::WebAccessibilityObject::isVisited): (WebKit::WebAccessibilityObject::boundingBoxRect): (WebKit::WebAccessibilityObject::helpText): (WebKit::WebAccessibilityObject::hitTest): (WebKit::WebAccessibilityObject::keyboardShortcut): (WebKit::WebAccessibilityObject::performDefaultAction): (WebKit::WebAccessibilityObject::roleValue): (WebKit::WebAccessibilityObject::stringValue): (WebKit::WebAccessibilityObject::title): (WebKit::WebAccessibilityObject::WebAccessibilityObject): (WebKit::WebAccessibilityObject::operator=): (WebKit::WebAccessibilityObject::operator WTF::PassRefPtr<WebCore::AccessibilityObject>):
20:25 Changeset [50713] by oliver@apple.com
  • 2 edits in trunk/WebKitTools

Make do-webcore-rename work with git.

Reviewed by Geoff Garen.

20:25 Changeset [50712] by eric@webkit.org
  • 1 edit
    17 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Upstreaming Chromium API: Platform specific files

https://bugs.webkit.org/show_bug.cgi?id=28394

  • public/gtk/WebFontInfo.h: Added.
  • public/gtk/WebInputEventFactory.h: Added.
  • public/gtk/WebScreenInfoFactory.h: Added.
  • public/linux/WebFontRendering.h: Added.
  • public/linux/WebSandboxSupport.h: Added.
  • public/mac/WebInputEventFactory.h: Added.
  • public/mac/WebScreenInfoFactory.h: Added.
  • public/win/WebInputEventFactory.h: Added.
  • public/win/WebSandboxSupport.h: Added.
  • public/win/WebScreenInfoFactory.h: Added.
  • public/win/WebThemeEngine.h: Added.
  • public/x11/WebScreenInfoFactory.h: Added.
20:14 Changeset [50711] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

Imported the v8 DST cache.

Reviewed by Oliver Hunt.

SunSpider says 1.5% faster.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::resetDateCache): Reset the DST cache when resetting
other date data.

  • runtime/JSGlobalData.h:

(JSC::DSTOffsetCache::DSTOffsetCache):
(JSC::DSTOffsetCache::reset): Added a struct for the DST cache.

  • wtf/DateMath.cpp:

(WTF::calculateDSTOffsetSimple):
(WTF::calculateDSTOffset):
(WTF::parseDateFromNullTerminatedCharacters):
(JSC::getDSTOffset):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):

  • wtf/DateMath.h: The imported code for probing and updating the cache.
20:06 Changeset [50710] by hamaji@chromium.org
  • 4 edits in trunk/LayoutTests

2009-11-03 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

wrong expected images after Bug 8736
https://bugs.webkit.org/show_bug.cgi?id=31094

  • platform/mac/fast/borders/border-radius-huge-assert-expected.png:
  • platform/mac/fast/box-shadow/border-radius-big-expected.checksum:
  • platform/mac/fast/box-shadow/border-radius-big-expected.png:
19:58 Changeset [50709] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Fixed an edge case that could cause the engine not to notice a timezone
change.

Reviewed by Oliver Hunt.

No test because this case would require manual intervention to change
the timezone during the test.

SunSpider reports no change.

  • runtime/DateInstanceCache.h:

(JSC::DateInstanceCache::DateInstanceCache):
(JSC::DateInstanceCache::reset): Added a helper function for resetting
this cache. Also, shrank the cache, since we'll be resetting it often.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::resetDateCache): Include resetting the DateInstanceCache
in resetting Date data. (Otherwise, a cache hit could bypass a necessary
timezone update check.)

19:39 Changeset [50708] by ggaren@apple.com
  • 7 edits in trunk/JavaScriptCore

Some manual inlining and constant propogation in Date code.

Reviewed by Sam Weinig.

SunSpider reports a 0.4% speedup on date-*, no overall speedup. Shark
says some previously evident stalls are now gone.

  • runtime/DateConstructor.cpp:

(JSC::callDate):

  • runtime/DateConversion.cpp:

(JSC::formatTime):
(JSC::formatTimeUTC): Split formatTime into UTC and non-UTC variants.

  • runtime/DateConversion.h:
  • runtime/DateInstance.cpp:

(JSC::DateInstance::calculateGregorianDateTime):
(JSC::DateInstance::calculateGregorianDateTimeUTC):

  • runtime/DateInstance.h:

(JSC::DateInstance::gregorianDateTime):
(JSC::DateInstance::gregorianDateTimeUTC): Split gregorianDateTime into
a UTC and non-UTC variant, and split each variant into a fast inline
case and a slow out-of-line case.

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Updated for the gregorianDateTime change above.

19:35 Changeset [50707] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Reviewed by Oliver Hunt.

Can cache prototype lookups on uncacheable dictionaries.
https://bugs.webkit.org/show_bug.cgi?id=31198

Fixed wrong expectation file committed.

  • fast/js/dictionary-prototype-caching-expected.txt:
19:31 Changeset [50706] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix: export a new symbol.

19:14 Changeset [50705] by ggaren@apple.com
  • 7 edits in trunk/JavaScriptCore

Added a tiny cache for Date parsing.

Reviewed by Sam "Home Wrecker" Weinig.

SunSpider says 1.2% faster.

  • runtime/DateConversion.cpp:

(JSC::parseDate): Try to reuse the last parsed Date, if present.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::resetDateCache):

  • runtime/JSGlobalData.h: Added storage for last parsed Date. Refactored

this code to make resetting the date cache easier.

  • runtime/JSGlobalObject.h:

(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Updated for
refactoring.

  • wtf/DateMath.cpp:

(JSC::parseDateFromNullTerminatedCharacters):

  • wtf/DateMath.h: Changed ExecState to be first parameter, as is the JSC custom.
18:50 WebKit Team edited by tonikitoo@webkit.org
(diff)
18:19 Changeset [50704] by oliver@apple.com
  • 9 edits
    3 adds in trunk

Can cache prototype lookups on uncacheable dictionaries.
https://bugs.webkit.org/show_bug.cgi?id=31198

Reviewed by Gavin Barraclough.

Replace fromDictionaryTransition with flattenDictionaryObject and
flattenDictionaryStructure. This change is necessary as we need to
guarantee that our attempt to convert away from a dictionary structure
will definitely succeed, and in some cases this requires mutating the
object storage itself.

17:51 Changeset [50703] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/JavaScriptCore

2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Not reviewed, build fix.

Remove extra character from r50701.

17:46 Changeset [50702] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-09 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Add a comment about null strings and hash functions.
https://bugs.webkit.org/show_bug.cgi?id=29118

  • platform/text/StringHash.h:
17:39 Changeset [50701] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/JavaScriptCore

2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Not reviewed, build fix.

Revert r50695 because it broke QtWebKit (clean builds).

17:24 Changeset [50700] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Darin Adler.

Compiler warnings in InspectorResource.h
https://bugs.webkit.org/show_bug.cgi?id=29231

Fix compilation warnings by removing addition operation on an enum type.

  • inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::Changes::hasChange): (WebCore::InspectorResource::Changes::set): (WebCore::InspectorResource::Changes::setAll):
17:12 Changeset [50699] by eric@webkit.org
  • 2 edits in trunk

2009-11-09 Priit Laes <plaes@plaes.org>

Reviewed by Oliver Hunt.

[Gtk] Build from tarball fails with --enable-introspection
https://bugs.webkit.org/show_bug.cgi?id=31261

We need to enable gobject-introspection during distcheck otherwise
some of the required files are missing in tarball.

  • GNUmakefile.am:
16:46 Changeset [50698] by andersca@apple.com
  • 3 edits
    2 adds in trunk

WebCore: <rdar://problem/7328395>
https://bugs.webkit.org/show_bug.cgi?id=31277

Reviewed by Darin Adler and Dan Bernstein.

When an object tag's style changes (for example when child nodes are added/removed),
reuse its Frame (if it has one) instead of creating multiple Frames.

Test: fast/dom/HTMLObjectElement/children-changed.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::requestObject):

LayoutTests: <rdar://problem/7328395>
https://bugs.webkit.org/show_bug.cgi?id=31277

Reviewed by Darin Adler and Dan Bernstein.

When an object tag's style changes (for example when child nodes are added/removed),
reuse its Frame (if it has one) instead of creating multiple Frames.

  • fast/dom/HTMLObjectElement/children-changed-expected.txt: Added.
  • fast/dom/HTMLObjectElement/children-changed.html: Added.
15:18 Changeset [50697] by levin@chromium.org
  • 2 edits in trunk/WebKit/chromium

Change struct ResourceRequest to class ResourceRequest per
http://trac.webkit.org/changeset/50625.

Reviewed by Dmitry Titov.

  • public/WebURLRequest.h:
14:41 Changeset [50696] by japhet@chromium.org
  • 1 edit
    4 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream remaining Chromium API WebN*.h headers.

https://bugs.webkit.org/show_bug.cgi?id=28394

14:34 Changeset [50695] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-11-09 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Prepended $$PWD to GENERATED_SOURCES_DIR to avoid potential ambiguities when included from WebCore.pro.
Some preprocessors consider this GENERATED_SOURCES_DIR relative to current invoking dir (e.g., ./WebCore),
and not the working dir of JavaCriptCore.pri (i.e., ../JavaScriptCore/).

14:34 Changeset [50694] by japhet@chromium.org
  • 1 edit
    5 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream Chromium API headers WebMessage through WebNavigation.

https://bugs.webkit.org/show_bug.cgi?id=28394

14:27 Changeset [50693] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-09 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
since adjustment of RW-section base address will be needed for all new symbian
tool chains, specifically for arm and gcc compilation targets.
Also, change target address to 0xE00000 to be sufficient for all targets.

  • WebCore.pro:
14:19 Changeset [50692] by eric@webkit.org
  • 1 edit
    9 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Upstreaming the Chromium WebKit API: WebScreenInfo to WebSharedWorkerRepo.

https://bugs.webkit.org/show_bug.cgi?id=28394

  • public/WebScreenInfo.h: Added. (WebKit::WebScreenInfo::WebScreenInfo):
  • public/WebScriptController.h: Added.
  • public/WebScriptSource.h: Added. (WebKit::WebScriptSource::WebScriptSource):
  • public/WebSearchableFormData.h: Added. (WebKit::WebSearchableFormData::isValid): (WebKit::WebSearchableFormData::url): (WebKit::WebSearchableFormData::encoding):
  • public/WebSecurityOrigin.h: Added. (WebKit::WebSecurityOrigin::~WebSecurityOrigin): (WebKit::WebSecurityOrigin::WebSecurityOrigin): (WebKit::WebSecurityOrigin::operator=): (WebKit::WebSecurityOrigin::isNull):
  • public/WebSecurityPolicy.h: Added.
  • public/WebSettings.h: Added. (WebKit::WebSettings::~WebSettings):
  • public/WebSharedWorker.h: Added. (WebKit::WebSharedWorker::~WebSharedWorker):
  • public/WebSharedWorkerRepository.h: Added.
14:11 Changeset [50691] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Crash when inspecting
WebCore\manual-tests\inspector\dom-mutation.html

https://bugs.webkit.org/show_bug.cgi?id=31259

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::handleEvent):
14:08 Changeset [50690] by japhet@chromium.org
  • 1 edit
    6 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream Chromium API headers Webkit.h thru WebMediaPlayerClient.h.

https://bugs.webkit.org/show_bug.cgi?id=28394

14:00 Changeset [50689] by japhet@chromium.org
  • 1 edit
    5 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream rest of WebH*.h and WebI*.h Chromium API headers.

https://bugs.webkit.org/show_bug.cgi?id=28394

13:55 Changeset [50688] by eric@webkit.org
  • 1 edit
    6 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Eric Seidel.

Upstreaming the Chromium WebKit API: WebSockets and WebStorage.

https://bugs.webkit.org/show_bug.cgi?id=28394

  • public/WebSocketStreamError.h: Added.
  • public/WebSocketStreamHandle.h: Added. (WebKit::WebSocketStreamHandle::~WebSocketStreamHandle):
  • public/WebSocketStreamHandleClient.h: Added.
  • public/WebStorageArea.h: Added. (WebKit::WebStorageArea::~WebStorageArea):
  • public/WebStorageEventDispatcher.h: Added. (WebKit::WebStorageEventDispatcher::~WebStorageEventDispatcher):
  • public/WebStorageNamespace.h: Added. (WebKit::WebStorageNamespace::~WebStorageNamespace):
13:47 Changeset [50687] by eric@webkit.org
  • 1 edit
    4 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Upstreaming the Chromium WebKit API: WebString and other basic objects.

https://bugs.webkit.org/show_bug.cgi?id=28394

  • public/WebRange.h: Added. (WebKit::WebRange::~WebRange): (WebKit::WebRange::WebRange): (WebKit::WebRange::operator=): (WebKit::WebRange::isNull):
  • public/WebRect.h: Added. (WebKit::WebRect::isEmpty): (WebKit::WebRect::WebRect): (WebKit::WebRect::operator=): (WebKit::WebRect::operator WebCore::IntRect): (WebKit::WebRect::operator gfx::Rect): (WebKit::operator==): (WebKit::operator!=):
  • public/WebSize.h: Added. (WebKit::WebSize::isEmpty): (WebKit::WebSize::WebSize): (WebKit::WebSize::operator=): (WebKit::WebSize::operator WebCore::IntSize): (WebKit::WebSize::operator gfx::Size): (WebKit::operator==): (WebKit::operator!=):
  • public/WebString.h: Added. (WebKit::WebString::~WebString): (WebKit::WebString::WebString): (WebKit::WebString::operator=): (WebKit::WebString::isEmpty): (WebKit::WebString::isNull): (WebKit::WebString::operator string16): (WebKit::WebString::operator NullableString16): (WebKit::WebString::fromUTF8):
13:40 Changeset [50686] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Eric Seidel.

Upstreaming the Chromium WebKit API: WebText*

https://bugs.webkit.org/show_bug.cgi?id=28394

  • public/WebTextAffinity.h: Added. (WebKit::):
  • public/WebTextDirection.h: Added. (WebKit::):
13:28 Changeset [50685] by japhet@chromium.org
  • 1 edit
    6 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream remainder of WebE*.h and WebF*.h Chromium API headers.

https://bugs.webkit.org/show_bug.cgi?id=28394

13:27 Changeset [50684] by eric@webkit.org
  • 4 edits in trunk

2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Few classes have virtual functions but non-virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=31269

No new tests as there is no functional change.

  • platform/qt/QWebPageClient.h: (QWebPageClient::~QWebPageClient): Add virtual destructor.

2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Few classes have virtual functions but non-virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=31269

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate): Add virtual destructor.
13:19 Changeset [50683] by japhet@chromium.org
  • 1 edit
    6 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream WebDevTools*.h and WebDrag*.h Chromium API headers.

https://bugs.webkit.org/show_bug.cgi?id=28394

  • public/WebDevToolsAgent.h: Added. (WebKit::WebDevToolsAgent::~WebDevToolsAgent):
  • public/WebDevToolsAgentClient.h: Added. (WebKit::WebDevToolsAgentClient::~WebDevToolsAgentClient):
  • public/WebDevToolsFrontend.h: Added. (WebKit::WebDevToolsFrontend::~WebDevToolsFrontend):
  • public/WebDevToolsFrontendClient.h: Added. (WebKit::WebDevToolsFrontendClient::WebDevToolsFrontendClient): (WebKit::WebDevToolsFrontendClient::~WebDevToolsFrontendClient):
  • public/WebDragData.h: Added. (WebKit::WebDragData::~WebDragData): (WebKit::WebDragData::WebDragData): (WebKit::WebDragData::operator=): (WebKit::WebDragData::isNull):
  • public/WebDragOperation.h: Added.
13:14 Changeset [50682] by eric@webkit.org
  • 1 edit
    6 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Upstreaming the Chromium WebKit API: WebURL and friends.

https://bugs.webkit.org/show_bug.cgi?id=28394

  • public/WebURL.h: Added. (WebKit::WebURL::~WebURL): (WebKit::WebURL::WebURL): (WebKit::WebURL::operator=): (WebKit::WebURL::assign): (WebKit::WebURL::spec): (WebKit::WebURL::parsed): (WebKit::WebURL::isValid): (WebKit::WebURL::isEmpty): (WebKit::WebURL::isNull): (WebKit::WebURL::operator GURL):
  • public/WebURLError.h: Added. (WebKit::WebURLError::WebURLError):
  • public/WebURLLoader.h: Added. (WebKit::WebURLLoader::~WebURLLoader):
  • public/WebURLLoaderClient.h: Added. (WebKit::WebURLLoaderClient::~WebURLLoaderClient):
  • public/WebURLRequest.h: Added. (WebKit::WebURLRequest::): (WebKit::WebURLRequest::~WebURLRequest): (WebKit::WebURLRequest::WebURLRequest): (WebKit::WebURLRequest::operator=):
  • public/WebURLResponse.h: Added. (WebKit::WebURLResponse::~WebURLResponse): (WebKit::WebURLResponse::WebURLResponse): (WebKit::WebURLResponse::operator=):
13:06 Changeset [50681] by eric@webkit.org
  • 1 edit
    7 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Upstreaming the Chromium WebKit API: WebVector to WebWorkerClient

https://bugs.webkit.org/show_bug.cgi?id=28394

  • public/WebVector.h: Added. (WebKit::WebVector::~WebVector): (WebKit::WebVector::WebVector): (WebKit::WebVector::operator=): (WebKit::WebVector::assign): (WebKit::WebVector::size): (WebKit::WebVector::isEmpty): (WebKit::WebVector::operator[]): (WebKit::WebVector::data): (WebKit::WebVector::swap): (WebKit::WebVector::initialize): (WebKit::WebVector::initializeFrom): (WebKit::WebVector::destroy):
  • public/WebView.h: Added. (WebKit::WebView::~WebView):
  • public/WebViewClient.h: Added. (WebKit::WebViewClient::createView): (WebKit::WebViewClient::createPopupMenu): (WebKit::WebViewClient::didAddMessageToConsole): (WebKit::WebViewClient::printPage): (WebKit::WebViewClient::notificationPresenter): (WebKit::WebViewClient::didStartLoading): (WebKit::WebViewClient::didStopLoading): (WebKit::WebViewClient::shouldBeginEditing): (WebKit::WebViewClient::shouldEndEditing): (WebKit::WebViewClient::shouldInsertNode): (WebKit::WebViewClient::shouldInsertText): (WebKit::WebViewClient::shouldChangeSelectedRange): (WebKit::WebViewClient::shouldDeleteRange): (WebKit::WebViewClient::shouldApplyStyle): (WebKit::WebViewClient::isSmartInsertDeleteEnabled): (WebKit::WebViewClient::isSelectTrailingWhitespaceEnabled): (WebKit::WebViewClient::setInputMethodEnabled): (WebKit::WebViewClient::didBeginEditing): (WebKit::WebViewClient::didChangeSelection): (WebKit::WebViewClient::didChangeContents): (WebKit::WebViewClient::didExecuteCommand): (WebKit::WebViewClient::didEndEditing): (WebKit::WebViewClient::handleCurrentKeyboardEvent): (WebKit::WebViewClient::spellCheck): (WebKit::WebViewClient::autoCorrectWord): (WebKit::WebViewClient::showSpellingUI): (WebKit::WebViewClient::isShowingSpellingUI): (WebKit::WebViewClient::updateSpellingUIWithMisspelledWord): (WebKit::WebViewClient::runFileChooser): (WebKit::WebViewClient::runModalAlertDialog): (WebKit::WebViewClient::runModalConfirmDialog): (WebKit::WebViewClient::runModalPromptDialog): (WebKit::WebViewClient::runModalBeforeUnloadDialog): (WebKit::WebViewClient::setStatusText): (WebKit::WebViewClient::setMouseOverURL): (WebKit::WebViewClient::setKeyboardFocusURL): (WebKit::WebViewClient::setToolTipText): (WebKit::WebViewClient::showContextMenu): (WebKit::WebViewClient::startDragging): (WebKit::WebViewClient::acceptsLoadDrops): (WebKit::WebViewClient::focusNext): (WebKit::WebViewClient::focusPrevious): (WebKit::WebViewClient::navigateBackForwardSoon): (WebKit::WebViewClient::historyBackListCount): (WebKit::WebViewClient::historyForwardListCount): (WebKit::WebViewClient::didAddHistoryItem): (WebKit::WebViewClient::focusAccessibilityObject): (WebKit::WebViewClient::didUpdateInspectorSettings): (WebKit::WebViewClient::queryAutofillSuggestions): (WebKit::WebViewClient::removeAutofillSuggestions): (WebKit::WebViewClient::~WebViewClient):
  • public/WebWidget.h: Added. (WebKit::WebWidget::~WebWidget):
  • public/WebWidgetClient.h: Added. (WebKit::WebWidgetClient::didInvalidateRect): (WebKit::WebWidgetClient::didScrollRect): (WebKit::WebWidgetClient::didFocus): (WebKit::WebWidgetClient::didBlur): (WebKit::WebWidgetClient::didChangeCursor): (WebKit::WebWidgetClient::closeWidgetSoon): (WebKit::WebWidgetClient::show): (WebKit::WebWidgetClient::runModal): (WebKit::WebWidgetClient::windowRect): (WebKit::WebWidgetClient::setWindowRect): (WebKit::WebWidgetClient::windowResizerRect): (WebKit::WebWidgetClient::rootWindowRect): (WebKit::WebWidgetClient::screenInfo): (WebKit::WebWidgetClient::~WebWidgetClient):
  • public/WebWorker.h: Added. (WebKit::WebWorker::~WebWorker):
  • public/WebWorkerClient.h: Added. (WebKit::WebWorkerClient::~WebWorkerClient):
12:55 Changeset [50680] by japhet@chromium.org
  • 1 edit
    4 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream WebData*.h Chromium API files.

https://bugs.webkit.org/show_bug.cgi?id=28394

12:46 Changeset [50679] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-11-09 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
https://bugs.webkit.org/show_bug.cgi?id=31140

Test that XHR request can set http headers with no value.

  • http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html: Added.

2009-11-09 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
https://bugs.webkit.org/show_bug.cgi?id=31140

QtNetwork interprets null string as request to remove the header, not add it.
Replace null values with empty values before passing them to QtNetwork.

Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html

  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
12:43 Changeset [50678] by japhet@chromium.org
  • 1 edit
    5 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream the last of the Chromium API WebC*.h files.

https://bugs.webkit.org/show_bug.cgi?id=28394

12:32 Changeset [50677] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
simply ignored before resulting in transparent areas being black in PNG
images for example.

https://bugs.webkit.org/show_bug.cgi?id=30823

12:22 Changeset [50676] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-11-09 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=30628
Add an API to get all the attributes from a QWebElement.

  • Api/qwebelement.cpp: (QWebElement::attributesName):
  • Api/qwebelement.h:
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::listAttributes):
12:04 Changeset [50675] by eric@webkit.org
  • 19 edits in trunk

2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
https://bugs.webkit.org/show_bug.cgi?id=31040

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):

2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
https://bugs.webkit.org/show_bug.cgi?id=31040

No new tests as there is no functional change.

  • dom/Document.cpp: (WebCore::Document::recalcStyleSelector):
  • editing/TextIterator.cpp: (WebCore::pushFullyClippedState):
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::appendTrailingWhitespace):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::mustLockBackForwardList):
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::computeHash):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
  • svg/SVGAnimateElement.cpp: (WebCore::parseNumberValueAndUnit):
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::startedActiveInterval):
  • svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::getCTM):

2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
https://bugs.webkit.org/show_bug.cgi?id=31040

  • Api/qwebpage.cpp: (QWebPagePrivate::handleScrolling):
11:50 Changeset [50674] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-09 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dimitri Glazkov.

Win chromium is slow to draw transparent texts
https://bugs.webkit.org/show_bug.cgi?id=31258

Clip graphics context to reduce calculation.

No new tests because this change only affects performance.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
11:43 Changeset [50673] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-09 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

showTree(CounterNode*) generates too little info and has too many spaces.
https://bugs.webkit.org/show_bug.cgi?id=31212

No new tests as the change has no functional effect it is just for
improved debugging.

  • rendering/CounterNode.cpp: (WebCore::showTreeAndMark): Changed to also show addresses of parent, next and previous siblings.
11:34 Changeset [50672] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-09 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Adler.

Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).

https://bugs.webkit.org/show_bug.cgi?id=31083

No new tests; implementation is unchanged.

  • page/Frame.cpp: (WebCore::Frame::setUseSecureKeyboardEntry):
  • page/mac/FrameMac.mm:
11:32 Changeset [50671] by japhet@chromium.org
  • 1 edit
    5 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

More WebC*.h upstreaming.

https://bugs.webkit.org/show_bug.cgi?id=28394

11:26 Changeset [50670] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Jan Alonzo.

Make XP_UNIX tests consistent
https://bugs.webkit.org/show_bug.cgi?id=31250

No new tests as there is no functional change.

  • plugins/PluginView.cpp: (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined instead of the value of the macro
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is defined instead of using the PLATFORM macro to be consistent (WebCore::PluginView::getValue): Ditto.
11:18 Changeset [50669] by eric@webkit.org
  • 1 edit
    4 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Upstreaming the Chromium WebKit API: WebNode.h and friends are thin wrappers around WebCore::Nodes

https://bugs.webkit.org/show_bug.cgi?id=28394

  • public/WebElement.h: Added. (WebKit::WebElement::WebElement): (WebKit::WebElement::operator=): (WebKit::WebElement::assign):
  • public/WebFormElement.h: Added. (WebKit::WebFormElement::~WebFormElement): (WebKit::WebFormElement::WebFormElement): (WebKit::WebFormElement::operator=): (WebKit::WebFormElement::assign):
  • public/WebInputElement.h: Added. (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::assign):
  • public/WebNode.h: Added. (WebKit::WebNode::~WebNode): (WebKit::WebNode::WebNode): (WebKit::WebNode::operator=): (WebKit::WebNode::isNull): (WebKit::WebNode::toElement): (WebKit::WebNode::unwrap): (WebKit::WebNode::constUnwrap):
11:08 Changeset [50668] by japhet@chromium.org
  • 1 edit
    5 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

WebKit Chromium API upstreaming, WebBindings.h through WebColor.h.

  • public/WebBindings.h: Added.
  • public/WebCache.h: Added.
  • public/WebCanvas.h: Added.
  • public/WebClipboard.h: Added. (WebKit::WebClipboard::): (WebKit::WebClipboard::~WebClipboard):
  • public/WebColor.h: Added.
10:48 Changeset [50667] by japhet@chromium.org
  • 7 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Starting upstreaming the Chromium WebKit API. public/ contains header files only.

https://bugs.webkit.org/show_bug.cgi?id=28394

  • ChangeLog: First!!
  • public: Added.
  • public/WebAccessibilityCache.h: Added. (WebKit::WebAccessibilityCache::WebAccessibilityCache): (WebKit::WebAccessibilityCache::~WebAccessibilityCache):
  • public/WebAccessibilityObject.h: Added. (WebKit::WebAccessibilityObject::~WebAccessibilityObject): (WebKit::WebAccessibilityObject::WebAccessibilityObject): (WebKit::WebAccessibilityObject::operator=): (WebKit::WebAccessibilityObject::isNull):
  • public/WebAccessibilityRole.h: Added. (WebKit::):
  • public/WebApplicationCacheHost.h: Added. (WebKit::WebApplicationCacheHost::): (WebKit::WebApplicationCacheHost::~WebApplicationCacheHost):
  • public/WebApplicationCacheHostClient.h: Added. (WebKit::WebApplicationCacheHostClient::~WebApplicationCacheHostClient):
10:23 Changeset [50666] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-09 Kevin Watters <kevinwatters@gmail.com>

Reviewed by Darin Adler.

Thunk to the main thread from ~Database to deref Database's m_document.

If the Database was the Document's last referrer, then ~Document occurs on the
Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
ASSERT in debug builds.

  • storage/Database.cpp: (WebCore::derefDocument): (WebCore::Database::~Database):
09:54 Changeset [50665] by eric@webkit.org
  • 10 edits
    2 adds in trunk

2009-11-09 Mark Mentovai <mark@chromium.org>

Reviewed by Dan Bernstein.

rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
REGRESSION (r48064): mint.com loses scrollbars after coming out of
edit mode.

rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.

  • fast/overflow/scrollbar-restored-expected.txt: Added.
  • fast/overflow/scrollbar-restored.html: Added.

2009-11-09 Mark Mentovai <mark@chromium.org>

Reviewed by Dan Bernstein.

Track "can have scrollbar" state within FrameView independently of the
individual scrollbar states in ScrollView.

rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
REGRESSION (r48064): mint.com loses scrollbars after coming out of
edit mode.

rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.

Test: fast/overflow/scrollbar-restored.html

  • WebCore.base.exp:
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::setCanHaveScrollbars): (WebCore::FrameView::updateCanHaveScrollbars): (WebCore::FrameView::layout):
  • page/FrameView.h:
  • platform/ScrollView.h:

2009-11-09 Mark Mentovai <mark@chromium.org>

Reviewed by Dan Bernstein.

Track "can have scrollbar" state within FrameView independently of the
individual scrollbar states in ScrollView.

rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
REGRESSION (r48064): mint.com loses scrollbars after coming out of
edit mode.

rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.

Test: fast/overflow/scrollbar-restored.html

  • WebView/WebFrameView.mm: (-[WebFrameView _install]):

2009-11-09 Mark Mentovai <mark@chromium.org>

Reviewed by Dan Bernstein.

Track "can have scrollbar" state within FrameView independently of the
individual scrollbar states in ScrollView.

rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
REGRESSION (r48064): mint.com loses scrollbars after coming out of
edit mode.

rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.

Test: fast/overflow/scrollbar-restored.html

  • Api/qwebframe.cpp: (QWebFrame::setScrollBarPolicy):
09:44 Changeset [50664] by eric@webkit.org
  • 5 edits in trunk

2009-11-09 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
https://bugs.webkit.org/show_bug.cgi?id=31257

  • inspector/syntax-highlight-css-expected.txt:
  • inspector/syntax-highlight-css.html:

2009-11-09 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
https://bugs.webkit.org/show_bug.cgi?id=31257

  • inspector/front-end/SourceFrame.js:
09:37 Changeset [50663] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2009-11-09 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
https://bugs.webkit.org/show_bug.cgi?id=31252

Route F1-F12 keypresses in the Console view to the current panel if there is one.

Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._promptKeyDown):
  • inspector/front-end/utilities.js: ():
  • manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
09:26 Changeset [50662] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

2009-11-09 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Pass credentials provided by XMLHTTPRequest to the network request.
https://bugs.webkit.org/show_bug.cgi?id=31208

After r42483, the credentials are no longer passed to the network request
in the URL of the request.
Pass the credentials from XMLHTTPRequest to the network request, the same
way that other ports do.

After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.

  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::loadResourceSynchronously):
09:22 Changeset [50661] by kenneth@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-11-09 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=30772
Add a non-const iterator to QWebElementCollection.
Move the two attributes of the iterator to private.

  • Api/qwebelement.h: (const_iterator::begin): (const_iterator::end): (const_iterator::constBegin): (const_iterator::constEnd): (const_iterator::iterator::iterator): (const_iterator::iterator::operator*): (const_iterator::iterator::operator==): (const_iterator::iterator::operator!=): (const_iterator::iterator::operator<): (const_iterator::iterator::operator<=): (const_iterator::iterator::operator>): (const_iterator::iterator::operator>=): (const_iterator::iterator::operator++): (const_iterator::iterator::operator--): (const_iterator::iterator::operator+=): (const_iterator::iterator::operator-=): (const_iterator::iterator::operator+): (const_iterator::iterator::operator-):
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::nonConstIterator): (tst_QWebElement::constIterator):
09:11 ImprovingLifeOnWindows edited by aroben@apple.com
Added bug number for setting environment variables automatically (diff)
08:12 Changeset [50660] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

Adding Kenneth to the reviewers list.

  • Scripts/modules/committers.py:
07:38 Changeset [50659] by laszlo.1.gombos@nokia.com
  • 4 edits in trunk/WebKit/qt

2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Christiansen.

[Qt] Remove the sessionStorage setting (per Page)
https://bugs.webkit.org/show_bug.cgi?id=31249

This setting allows to run sessionStorage on/off on a per page
basis. Remove this prematurely exposed API.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::database): (tst_QWebPage::testOptionalJSObjects):
07:34 Changeset [50658] by zoltan@webkit.org
  • 10 edits in trunk/WebCore

Unreviewed.

https://bugs.webkit.org/show_bug.cgi?id=31161

Roll back r50657 because it breaks the MAC builds.

  • loader/ImageLoader.cpp:
  • loader/ProgressTracker.cpp:
  • loader/RedirectScheduler.cpp:
  • loader/Request.h:
  • loader/ThreadableLoaderClient.h:
  • loader/WorkerThreadableLoader.h:
  • loader/appcache/ApplicationCacheHost.h:
  • loader/appcache/ApplicationCacheStorage.h:
  • loader/icon/IconDatabaseClient.h:
07:22 Changeset [50657] by zoltan@webkit.org
  • 10 edits in trunk/WebCore

Allow custom memory allocation control for the part of loader directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31161

Reviewed by Darin Adler.

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and these are no need to be copyable:

class Request - WebCore/loader/loader.cpp:100
struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
class ApplicationCacheHost - WebCore/loader/DocumentLoader.cpp:151
class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169

Inherits ThreadableLoaderClient class from Noncopyable because (its child class)
MainThreadBridge is instantiated by 'new' in
WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.

ThreadableLoaderClient's inheriting has been changed to public.

  • loader/ImageLoader.cpp:
  • loader/ProgressTracker.cpp:
  • loader/RedirectScheduler.cpp:
  • loader/Request.h:
  • loader/ThreadableLoaderClient.h:
  • loader/WorkerThreadableLoader.h:
  • loader/appcache/ApplicationCacheHost.h:
  • loader/appcache/ApplicationCacheStorage.h:
  • loader/icon/IconDatabaseClient.h:
06:59 Changeset [50656] by hausmann@webkit.org
  • 5 edits in trunk/WebKit/qt

[Qt] Remove the QWebPage:webInspectorTriggered signal.
User customization of the communication between QWebPage
and QWebInspector will be properly designed in the next version.
https://bugs.webkit.org/show_bug.cgi?id=30773

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-11-09
Reviewed by Simon Hausmann.

  • Api/qwebinspector.cpp:
  • Api/qwebpage.cpp:

(QWebPagePrivate::getOrCreateInspector):
(QWebPage::triggerAction):

  • Api/qwebpage.h:
  • QtLauncher/main.cpp:

(MainWindow::MainWindow):

06:27 Changeset [50655] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's DocLoader
https://bugs.webkit.org/show_bug.cgi?id=31163

Reviewed by Darin Adler.

Inherits DocLoader class from Noncopyable because it is
instantiated by 'new' in WebCore/dom/Document.cpp:370 and
it is no need to be copyable.

  • loader/DocLoader.h:
06:22 Changeset [50654] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=31162

Reviewed by Darin Adler.

Inherits Tokenizer class from Noncopyable because (its child class)
ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178
and it is no need to be copyable.

  • dom/Tokenizer.h:
06:14 Changeset [50653] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's DeleteButtonController
https://bugs.webkit.org/show_bug.cgi?id=31105

Reviewed by Darin Adler.

Inherits DeleteButtonController class from Noncopyable because it is
instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
it is no need to be copyable.

  • editing/DeleteButtonController.h:
05:10 Changeset [50652] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

Added a missing re-implementation of QGraphicsItem::inputMethodQuery().

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-05
Reviewed by Tor Arne Vestbø.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::inputMethodQuery):

  • Api/qgraphicswebview.h:
05:09 Changeset [50651] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

Provide a dummy re-implementation of QGraphicsLayoutItem::sizeHint(),
similar to QWebView.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::sizeHint):

  • Api/qgraphicswebview.h:
05:08 Changeset [50650] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

Removed zoomFactoryChanged() signal and added
linkClicked() to QGraphicsWebView, for consistency with
QWebView.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::setPage):
(QGraphicsWebView::setZoomFactor):

  • Api/qgraphicswebview.h:
05:07 Changeset [50649] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

Added QGraphicsWebView::findText() for convenience and consistency
with QWebView.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::findText):

  • Api/qgraphicswebview.h:
05:06 Changeset [50648] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

Added QGraphicsWebView::pageAction() and triggerPageAction(), for
consistency with QWebView.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::pageAction):
(QGraphicsWebView::triggerPageAction):

  • Api/qgraphicswebview.h:
04:35 Changeset [50647] by vestbo@webkit.org
  • 4 edits in trunk/WebKit/qt

Removed QGraphicsWebView::toHtml() after API review.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.

That's consistent with QWebView and also based on the assumption that
toHtml() is called less frequently than setHtml().

  • Api/qgraphicswebview.cpp:
  • Api/qgraphicswebview.h:
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::qgraphicswebview):

04:31 Changeset [50646] by vestbo@webkit.org
  • 4 edits in trunk/WebKit/qt

Removed the interactive property of QGraphicsWebView.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.

There are clearly use-cases for this feature, but it will require
more work to make this fully work with an enum to have fine-grained
control over the interactivity levels. For now it is easy to achieve
in user-code what the boolean property did.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
(QGraphicsWebView::hoverMoveEvent):
(QGraphicsWebView::mouseMoveEvent):
(QGraphicsWebView::mousePressEvent):
(QGraphicsWebView::mouseReleaseEvent):
(QGraphicsWebView::mouseDoubleClickEvent):
(QGraphicsWebView::keyPressEvent):
(QGraphicsWebView::keyReleaseEvent):
(QGraphicsWebView::dragLeaveEvent):
(QGraphicsWebView::dragMoveEvent):
(QGraphicsWebView::dropEvent):
(QGraphicsWebView::wheelEvent):
(QGraphicsWebView::inputMethodEvent):

  • Api/qgraphicswebview.h:
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::qgraphicswebview):

04:29 Changeset [50645] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

Make the QGraphicsWebView constructor explicit.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.

  • Api/qgraphicswebview.h:
03:08 Changeset [50644] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Holger Hans Peter Freyther.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-11-09
[Qt] Skip new japanese ruby annotation tests because of missing japanese font support.

  • platform/qt/Skipped:
02:12 Changeset [50643] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed trivial fix.

Removed previously (r50589) deleted test case from skiplists.

  • platform/gtk/Skipped: fast/events/drag-and-drop-none.html removed.
  • platform/qt/Skipped: fast/events/drag-and-drop-none.html removed.
01:16 Changeset [50642] by eric@webkit.org
  • 9 edits in trunk

2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Expose Page::tabKeyCyclesThroughElements in the API
https://bugs.webkit.org/show_bug.cgi?id=30482

Unskip fast/events/keypress-insert-tab.html as it now passes.

  • platform/gtk/Skipped:

2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Expose Page::tabKeyCyclesThroughElements in the API
https://bugs.webkit.org/show_bug.cgi?id=30482

Expose Page::tabKeyCyclesThroughElements as a property of
WebKitWebView.

No new tests; fast/events/keypress-insert-tab.html is no longer skipped.

  • platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses. (WebCore::singleCharacterString):

2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Expose Page::tabKeyCyclesThroughElements in the API
https://bugs.webkit.org/show_bug.cgi?id=30482

Expose Page::tabKeyCyclesThroughElements as a property of
WebKitWebSettings.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):

2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Expose Page::tabKeyCyclesThroughElements in the API
https://bugs.webkit.org/show_bug.cgi?id=30482

LayoutTestControllerGtk now uses the exposed
Page::tabKeyCyclesThroughElements API

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setTabKeyCyclesThroughElements):
00:18 Changeset [50641] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-09 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Fix a crasher that occurred with text which included newline
chars in the markup.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (convertUniCharToUTF8):
00:15 QtBackLog edited by zecke@selfish.org
Mention the ARM changes (diff)

11/08/09:

23:34 Changeset [50640] by zecke@webkit.org
  • 4 edits
    1 add in trunk

The XML tokenizer reports a parse error twice if it occurs before the document element is found.

https://bugs.webkit.org/show_bug.cgi?id=31144

XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
documents that end prematurely but are not considered invalid by QXmlStream.
This is to stay compatible with the libxml2 implementation.
However, that code path would be also hit in situations when it should not,
i.e. the error would have already been caught and handled. As a result, the
same error would be reported twice.

No new tests, because the problem is already covered by
fast/parser/xml-declaration-missing-ending-mark.html.

Add the Qt-specific result for that test and unskip it.

22:39 Changeset [50639] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-11-08 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: Inspector should support copy() in the command line
https://bugs.webkit.org/show_bug.cgi?id=31238

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::copyText): Added.
  • inspector/InspectorBackend.h: Added copyText
  • inspector/InspectorBackend.idl: Added copyText
  • inspector/front-end/InjectedScript.js: (InjectedScript._copy): Added. (InjectedScript._ensureCommandLineAPIInstalled):
22:00 Changeset [50638] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-08 Drew Wilson <atwilson@chromium.org>

Reviewed by Dimitri Glazkov.

V8 WorkerContextExecutionProxy does not handle SharedWorkers
https://bugs.webkit.org/show_bug.cgi?id=31226

Now checks to see what type of context is active and creates the
appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).

Added support for converting to SharedWorkers and SharedWorkerContexts.

Test: Existing layout tests cover this case (start passing in Chrome).

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Now generates the right type of DOMWrapper for SharedWorkerContexts. (WebCore::WorkerContextExecutionProxy::convertToV8Object): Added support for SHAREDWORKERCONTEXT. (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object): Added support for SharedWorker and SharedWorkerContext.
21:52 Changeset [50637] by eric@webkit.org
  • 3 edits
    4 adds in trunk

2009-11-08 Johnny Ding <johnnyding.webkit@gmail.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31224
[V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.

  • fast/dom/StyleSheet/get-stylesheet-byname-expected.txt: Added.
  • fast/dom/StyleSheet/get-stylesheet-byname.html: Added.
  • fast/dom/StyleSheet/script-tests: Added.
  • fast/dom/StyleSheet/script-tests/get-stylesheet-byname.js: Added.

2009-11-08 Johnny Ding <johnnyding.webkit@gmail.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31224
[V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.

Test: fast/dom/StyleSheet/get-stylesheet-byname.html

  • bindings/v8/custom/V8StyleSheetListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
20:52 Changeset [50636] by mitz@apple.com
  • 3 edits in trunk/WebKit/mac

Made the full-screen video HUD appear when playback stops, such as when
the end of the video is reached.

Reviewed by Eric Carlson.

  • WebView/WebVideoFullscreenHUDWindowController.h: Cleaned up.
  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Updated
for the renaming of -updateRate to -updatePlayButton.
(-[WebVideoFullscreenHUDWindowController updatePlayButton]): Renamed
-updateRate to this.
(-[WebVideoFullscreenHUDWindowController updateRate]): This method now
responds to changes to the playback rate by updating the play button
and showing or hiding the HUD as necessary.
(-[WebVideoFullscreenHUDWindowController togglePlaying:]): Now only
toggles playing. UI updates are driven by -updateRate being called.
(-[WebVideoFullscreenHUDWindowController playing]): Cleaned up.

20:46 Changeset [50635] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-08 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: "Search again" on scripts panel switches
to the script this search started with.

https://bugs.webkit.org/show_bug.cgi?id=31243

  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.jumpToNextSearchResult):
18:43 Changeset [50634] by levin@chromium.org
  • 3 edits in trunk/JavaScriptCore
  • wtf/DateMath.cpp:

(WTF::parseDateFromNullTerminatedCharacters):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):

  • wtf/DateMath.h:

(JSC::GregorianDateTime::GregorianDateTime):

Reviewed by NOBODY (speculative snow leopard and windows build fixes).

18:33 Changeset [50633] by levin@chromium.org
  • 9 edits in trunk

JavaScriptCore: Hopefully, the last build fix.

Reviewed by NOBODY (chromium build fix).

Create better separation in DateMath about the JSC
and non-JSC portions. Also, only expose the non-JSC
version in the exports.

(WTF::parseDateFromNullTerminatedCharacters):
(JSC::getUTCOffset):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):

  • wtf/DateMath.h:

(JSC::gmtoffset):

JavaScriptGlue: Added the use jsc define for files that use
this config file and DateMath.h. This should
be able to go away when DateMath is properly
split into wtf and jsc portions which is this bug:
https://bugs.webkit.org/show_bug.cgi?id=31246

Reviewed by NOBODY (chromium build fix).

  • config.h:

WebCore: * platform/network/HTTPParsers.cpp:
(WebCore::parseDate): Changed this to not
use a date parser that needs ExecState passed.

Reviewed by NOBODY (chromium build fix).

17:28 Changeset [50632] by eric@webkit.org
  • 14 edits in trunk/WebCore

2009-11-08 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Simplify Icon interface.
https://bugs.webkit.org/show_bug.cgi?id=31154

  • Remove Icon::createIconForFile(). createIconForFiles() covers createIconForFile()'s role.
  • Remove FileChooser::chooseIcon()
  • Change the parameter types of FileChooser constructor and the factory method, String -> const Vector<String>&, in order to support initialization with multiple files.
  • Remove the icon loading code in IconChromiumWin.cpp, which doesn't work because of the sandbox.

No tests because it's just a refactoring.

  • platform/FileChooser.cpp: (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::create): (WebCore::FileChooser::chooseFile): (WebCore::FileChooser::chooseFiles):
  • platform/FileChooser.h:
  • platform/graphics/Icon.h:
  • platform/graphics/chromium/IconChromiumLinux.cpp:
  • platform/graphics/chromium/IconChromiumMac.cpp:
  • platform/graphics/chromium/IconChromiumWin.cpp: (WebCore::Icon::createIconForFiles):
  • platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::createIconForFiles):
  • platform/graphics/haiku/IconHaiku.cpp:
  • platform/graphics/mac/IconMac.mm: (WebCore::Icon::createIconForFiles):
  • platform/graphics/qt/IconQt.cpp: (WebCore::Icon::createIconForFiles):
  • platform/graphics/win/IconWin.cpp: (WebCore::Icon::createIconForFiles):
  • platform/graphics/wx/IconWx.cpp:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl):
17:18 Changeset [50631] by dbates@webkit.org
  • 4 edits
    3 adds in trunk

2009-11-08 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=31098

Allows same-origin plugin-based content to load.

Test: http/tests/security/xssAuditor/object-src-inject.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource. (WebCore::XSSAuditor::canLoadObject): Ditto. (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. (WebCore::XSSAuditor::isSameOriginResource): Added.
  • page/XSSAuditor.h:

2009-11-08 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=31098

Tests that the XSSAuditor prevents loading plugin-based content that is not
from the same-origin as the enclosing page.

  • http/tests/security/xssAuditor/object-src-inject-expected.txt: Added.
  • http/tests/security/xssAuditor/object-src-inject.html: Added.
  • http/tests/security/xssAuditor/resources/echo-object-src.pl: Added.
15:54 Changeset [50630] by levin@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed build fix for chromium.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):

15:42 Changeset [50629] by levin@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed build fix for chromium.

Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
Clean up GraphicsContext's current concept of ColorSpace

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):

13:02 Changeset [50628] by levin@chromium.org
  • 3 edits in trunk/JavaScriptCore

For the change in DateMath.

Reviewed by NOBODY (chromium build fix).

  • config.h:
  • wtf/DateMath.cpp:
11:47 Changeset [50627] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-11-08 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] committing style edit
clears elements panel selection.

https://bugs.webkit.org/show_bug.cgi?id=31242

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.update):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
11:09 Changeset [50626] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-11-08 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Holger Freyther.

Update texts in test description after test case change in r50579.
https://bugs.webkit.org/show_bug.cgi?id=31122

  • editing/selection/shrink-selection-after-shift-pagedown-expected.txt:
  • editing/selection/shrink-selection-after-shift-pagedown.html:
11:01 Changeset [50625] by eric@webkit.org
  • 27 edits in trunk

2009-11-08 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Holger Freyther.

ResourceRequest to be class instead of struct
https://bugs.webkit.org/show_bug.cgi?id=30670

Started as a compilation fix for Symbian where the compiler makes a distinction between
class and struct in function argument signatures.
Changed all forward declarations of ResourceRequest to have class in the forward
declaration instead of struct and changed the definition of ResourceRequest to be class
and added access qualifiers where missing. Additionally two references of friend
struct ResourceRequestBase changed to class instead.

  • history/HistoryItem.h:
  • inspector/InspectorController.h:
  • inspector/InspectorResource.h:
  • loader/DocumentThreadableLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.h:
  • loader/ResourceLoadNotifier.h:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:
  • loader/ThreadableLoader.h:
  • loader/WorkerThreadableLoader.h:
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheHost.h:
  • platform/CrossThreadCopier.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceRequestBase.h:
  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/ResourceRequestCFNet.h:
  • platform/network/chromium/ResourceRequest.h:
  • platform/network/curl/ResourceRequest.h:
  • platform/network/qt/ResourceRequest.h:
  • platform/network/soup/ResourceRequest.h:
  • xml/XMLHttpRequest.h:

2009-11-08 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Holger Freyther.

ResourceRequest to be class instead of struct
https://bugs.webkit.org/show_bug.cgi?id=30670

Started as a compilation fix for Symbian where the compiler makes a distinction between
class and struct in function argument signatures.
Changed forward declaration of ResourceRequest to have class in the forward
declaration instead of struct.

  • WebDownload.h:
10:51 Changeset [50624] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-08 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Holger Freyther.

[Qt] Added support for key code 8 (backspace) in EventSenderQt.
This helps to pass the test case below. Also replaced hardcoded
code numbers with defined constants.
https://bugs.webkit.org/show_bug.cgi?id=31185

Test: editing/undo/undo-deleteWord.html

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown):
09:32 Changeset [50623] by mitz@apple.com
  • 6 edits
    4 adds in trunk

<rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
below FrameView::layout
https://bugs.webkit.org/show_bug.cgi?id=31093

Reviewed by Simon Fraser.

WebCore:

Test: fast/block/positioning/relative-positioned-inline-container.html

In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
to mark the object for layout, doing so without marking its ancestors.
However, RenderBlock::skipLeadingWhitespace and
RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
positioned inline container, causing it to be marked for layout without
ever going back to give it layout, and thus layout could end with a
dirty object still in the tree, leading to all sorts of badness.

The fix is to revert setStaticY() to not marking the object dirty, and
instead do it in the call sites that require it, which are in
RenderBlock and RenderFlexibleBox.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPositionedBlock):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:

(WebCore::RenderLayer::setStaticY):

LayoutTests:

  • fast/block/positioning/relative-positioned-inline-container-expected.checksum: Added.
  • fast/block/positioning/relative-positioned-inline-container-expected.png: Added.
  • fast/block/positioning/relative-positioned-inline-container-expected.txt: Added.
  • fast/block/positioning/relative-positioned-inline-container.html: Added.
09:26 Changeset [50622] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKitTools

[Qt] [DRT] Fix wrong logic in LayoutTestController processWork
https://bugs.webkit.org/show_bug.cgi?id=31164

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-11-05
Reviewed by Holger Freyther.

Fixed wrong logic to assume WorkQueue is done in QT's DRT.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::processWork):

09:25 Changeset [50621] by tonikitoo@webkit.org
  • 4 edits in trunk/WebKitTools

[Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
https://bugs.webkit.org/show_bug.cgi?id=31158

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-11-07
Reviewed by Holger Freyther.

By invoking a script queue'd by queueScript(), 'true' was beeing returned
always, which from WorkQueue prospective means that a load has been started
and the queue processing should stop and wait for the load to finish.
Spinning it off into a loading and a non-loading variants was the solution
adopted by Mac's DRT to work around this problem. The former keeps returning
'true' while the later executes the script synchronously and returns 'false'
making it possible to the WorkQueue to proceed right away.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::processWork):
(LayoutTestController::queueLoadingScript):
(LayoutTestController::queueNonLoadingScript):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/qt/WorkQueueItem.h:

(LoadingScriptItem::LoadingScriptItem):
(LoadingScriptItem::invoke):
(NonLoadingScriptItem::NonLoadingScriptItem):
(NonLoadingScriptItem::invoke):

Note: See TracTimeline for information about the timeline view.