Timeline


and

11/18/09:

23:18 Changeset [51177] by laszlo.1.gombos@nokia.com

2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed.

[Qt] Build fix for QtWebKit after r51172.

  • platform/qt/Localizations.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
22:18 Changeset [51176] by eric@webkit.org

2009-11-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Normalize ' and " in bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=31655

We decided " is better than ' and we should be consistent.

  • Scripts/bugzilla-tool:
22:17 Changeset [51175] by mitz@apple.com

WebCore: Fixed <rdar://problem/7398987> Assertion failure in
RenderLayer::updateClipRects when a plug-in’s enclosing layer is
enclosed by a transformed layer

Reviewed by Simon Fraser.

Tests: fast/layers/clip-rects-transformed-2.html

fast/layers/clip-rects-transformed.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clippingRoot): Added. Finds the nearest ancestor
that is either transformed or composited. During painting and hit
testing, when a transformed or composited layer is hit, it becomes the
new root layer, which ultimately gets passed to calculateRects().
(WebCore::RenderLayer::childrenClipRect): Pass the clipping root as the
root layer to calculateRects(), and return the bounding box of the
transformed rectangle.
(WebCore::RenderLayer::selfClipRect): Ditto.

  • rendering/RenderLayer.h:

LayoutTests: Test for <rdar://problem/7398987> Assertion failure in
RenderLayer::updateClipRects when a plug-in’s enclosing layer is
enclosed by a transformed layer

Reviewed by Simon Fraser.

  • fast/layers/clip-rects-transformed-2-expected.txt: Added.
  • fast/layers/clip-rects-transformed-2.html: Added.
  • fast/layers/clip-rects-transformed-expected.txt: Added.
  • fast/layers/clip-rects-transformed.html: Added.
22:03 Changeset [51174] by laszlo.1.gombos@nokia.com

2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469

2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469

  • Api/qcookiejar.cpp: Removed.
  • Api/qcookiejar.h: Removed.
  • Api/qgraphicswebview.cpp: (QGraphicsWebView::event):
  • Api/qwebframe.cpp: (QWebFrame::load):
  • Api/qwebframe.h:
  • Api/qwebkitglobal.h:
  • Api/qwebnetworkinterface.cpp: Removed.
  • Api/qwebnetworkinterface.h: Removed.
  • Api/qwebnetworkinterface_p.h: Removed.
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::acceptNavigationRequest): (QWebPage::acceptNavigationRequest): (QWebPage::action): (QWebPage::userAgentForUrl):
  • Api/qwebpage.h:
  • Api/qwebpage_p.h:
  • Api/qwebview.cpp: (QWebView::load): (QWebView::event):
  • Api/qwebview.h:
  • QtLauncher/main.cpp: (MainWindow::print): (MainWindow::setupUI): (main):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::download): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientQt::startDownload): (WebCore::FrameLoaderClientQt::createPlugin):

2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469

No new tests as there is no change if compiled with
Qt v4.4 or later version.

  • WebCore.pro:
  • dom/XMLTokenizerQt.cpp: (WebCore::EntityResolver::resolveUndeclaredEntity): (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::~XMLTokenizer): (WebCore::XMLTokenizer::doWrite): (WebCore::XMLTokenizer::startDocument): (WebCore::XMLTokenizer::parseDtd):
  • platform/graphics/qt/FontQt.cpp:
  • platform/graphics/qt/FontQt43.cpp: Removed.
  • platform/graphics/qt/ImageQt.cpp:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/qt/QNetworkReplyHandler.cpp:
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::ResourceHandle::setDefersLoading):
  • platform/network/qt/ResourceRequest.h:
  • platform/network/qt/ResourceRequestQt.cpp:
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::clearData):
  • platform/qt/CookieJarQt.cpp: (WebCore::cookieJar): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode): (WebCore::windowsKeyCodeForKeyEvent):
  • platform/text/qt/TextBoundaries.cpp:
  • platform/text/qt/TextBreakIteratorQt.cpp:
  • plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):

2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/ImageDiff.pro:
21:47 Changeset [51173] by hamaji@chromium.org

2009-11-18 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

GitTest.test_create_binary_patch fails if /tmp is symlink
https://bugs.webkit.org/show_bug.cgi?id=31536

  • Scripts/modules/scm_unittest.py:
21:38 Changeset [51172] by tkent@chromium.org

2009-11-18 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

  • fast/dom/domListEnumeration-expected.txt: updated with new property
  • fast/dom/script-tests/domListEnumeration.js: ditto
  • fast/forms/script-tests/validationMessage.js: Added.
  • fast/forms/validationMessage-expected.txt: Added.
  • fast/forms/validationMessage.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2009-11-18 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

Test: fast/forms/validationMessage.html

  • html/HTMLButtonElement.idl: validationMessage attribute
  • html/HTMLFieldSetElement.idl: validationMessage attribute
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.idl: validationMessage attribute
  • html/HTMLSelectElement.idl: validationMessage attribute
  • html/HTMLTextAreaElement.idl: validationMessage attribute
  • html/ValidityState.cpp: new method to retrieve pertinent localized text
  • html/ValidityState.h:
  • page/mac/WebCoreViewFactory.h:
  • platform/LocalizedStrings.h:
  • platform/android/LocalizedStringsAndroid.cpp:
  • platform/gtk/LocalizedStringsGtk.cpp:
  • platform/haiku/LocalizedStringsHaiku.cpp:
  • platform/mac/LocalizedStringsMac.mm:
  • platform/wx/LocalizedStringsWx.cpp:

2009-11-18 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

  • English.lproj/Localizable.strings: new localizable strings

2009-11-18 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

  • src/LocalizedStrings.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):

2009-11-18 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory validationMessageValueMissingText]): (-[WebViewFactory validationMessageTypeMismatchText]): (-[WebViewFactory validationMessagePatternMismatchText]): (-[WebViewFactory validationMessageTooLongText]): (-[WebViewFactory validationMessageRangeUnderflowText]): (-[WebViewFactory validationMessageRangeOverflowText]): (-[WebViewFactory validationMessageStepMismatchText]):

2009-11-18 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

  • WebCoreLocalizedStrings.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
21:09 Changeset [51171] by laszlo.1.gombos@nokia.com

2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed.

Fix a typo. Remove the trailing semicolon
from an include directive after r51137.

No new tests as there is no functional change.

  • platform/qt/QWebPageClient.h:
20:52 Changeset [51170] by laszlo.1.gombos@nokia.com

2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed.

[Qt] Build fix for QtWebKit after r51159.

Include float.h for DBL_MANT_DIG. Not sure why this
is not a problem for other ports.

  • html/HTMLInputElement.cpp:
19:15 Changeset [51169] by rolandsteiner@chromium.org

WebCore: Bug 31574 - Crashing bug when removing <ruby> element
(https://bugs.webkit.org/show_bug.cgi?id=31574)

Reviewed by Darin Adler.

Cause of the bug:
1.) RenderBlock::destroy() of the RenderRubyRun called destroyLeftoverChildren()
2.) that called destroy() of the RenderRubyBase(), which in RenderObject::destroy() calls remove()
3.) remove() is being redirected as parent()->removeChild() in RenderObject.h
4.) this triggers the special handling of child removal in RenderRubyRun that

causes it to destroy itself

5.) On returning from all this the renderer crashes when accessing a member

or virtual function on this now illegal object.

I therefore added a flag that tracks if the ruby run is being destroyed.
If so, avoid doing the special handling in removeChild that caused this.
It's not the most elegant solution, but the easiest to implement without
touching unrelated code. Also, it's self-documenting.

Test: fast/ruby/ruby-remove.html

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::destroy):
(WebCore::RenderRubyRun::removeChild):

  • rendering/RenderRubyRun.h:

LayoutTests: Bug 31574 - Crashing bug when removing <ruby> element
(https://bugs.webkit.org/show_bug.cgi?id=31574)

Reviewed by Darin Adler.

Layout test to verify it no longer crashes when the <ruby> element
is being removed.

  • fast/ruby/ruby-remove-expected.txt: Added.
  • fast/ruby/ruby-remove.html: Added.
19:12 Changeset [51168] by tkent@chromium.org

2009-11-18 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Move UString::from(double) implementation to new
WTF::doubleToStringInJavaScriptFormat(), and expose it because WebCore
code will use it.
https://bugs.webkit.org/show_bug.cgi?id=31330

  • Introduce new function createRep(const char*, unsigned) and UString::UString(const char*, unsigned) to reduce 2 calls to strlen().
  • Fix a bug that dtoa() doesn't update *rve if the input value is NaN or Infinity.

No new tests because this doesn't change the behavior.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/UString.cpp: (JSC::createRep): (JSC::UString::UString): (JSC::UString::from): Move the code to doubleToStringInJavaScriptFormat().
  • runtime/UString.h:
  • wtf/dtoa.cpp: (WTF::dtoa): Fix a bug about rve. (WTF::append): A helper for doubleToStringInJavaScriptFormat(). (WTF::doubleToStringInJavaScriptFormat): Move the code from UString::from(double).
  • wtf/dtoa.h:
18:53 Changeset [51167] by eric@webkit.org

2009-11-18 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Adler.

Configuration for Chromium Build Slaves.

https://bugs.webkit.org/show_bug.cgi?id=31442

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
18:46 Changeset [51166] by eric@webkit.org

2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=31643

2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=31643

No new tests as there is no functional change.

  • WebCore.pro:
18:38 Changeset [51165] by eric@webkit.org

2009-11-18 Yong Li <yong.li@torchmobile.com>

Reviewed by Eric Seidel.

Implement TextBoundaries for WINCE port.
https://bugs.webkit.org/show_bug.cgi?id=27371

  • platform/text/wince/TextBoundariesWince.cpp: Added.
18:30 Changeset [51164] by eric@webkit.org

2009-11-18 Yong Li <yong.li@torchmobile.com>

Reviewed by Eric Seidel.

Implement TextBreakIterator for WINCE port.
https://bugs.webkit.org/show_bug.cgi?id=27371

  • platform/text/wince/TextBreakIteratorWince.cpp: Added.
18:15 Changeset [51163] by tkent@chromium.org

2009-11-18 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Tests for ValidityState.typeMismatch for the following types of INPUT element:

date, datetime, datetime-local, month, time and week

https://bugs.webkit.org/show_bug.cgi?id=31342

  • fast/forms/ValidityState-typeMismatch-date-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-date.html: Added.
  • fast/forms/ValidityState-typeMismatch-datetime-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-datetime.html: Added.
  • fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-datetimelocal.html: Added.
  • fast/forms/ValidityState-typeMismatch-month-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-month.html: Added.
  • fast/forms/ValidityState-typeMismatch-time-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-time.html: Added.
  • fast/forms/ValidityState-typeMismatch-week-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-week.html: Added.
  • fast/forms/script-tests/ValidityState-typeMismatch-date.js: Added.
  • fast/forms/script-tests/ValidityState-typeMismatch-datetime.js: Added.
  • fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js: Added.
  • fast/forms/script-tests/ValidityState-typeMismatch-month.js: Added.
  • fast/forms/script-tests/ValidityState-typeMismatch-time.js: Added.
  • fast/forms/script-tests/ValidityState-typeMismatch-week.js: Added.

2009-11-18 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Add support for ValidityState.typeMismatch for the following INPUT types:

date datetime datetime-local month time week

https://bugs.webkit.org/show_bug.cgi?id=31342

Tests: fast/forms/ValidityState-typeMismatch-date.html

fast/forms/ValidityState-typeMismatch-datetime.html
fast/forms/ValidityState-typeMismatch-datetimelocal.html
fast/forms/ValidityState-typeMismatch-month.html
fast/forms/ValidityState-typeMismatch-time.html
fast/forms/ValidityState-typeMismatch-week.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::formStringToISODateTime): Check the type validity of the specified type and string using the ISODateTime class.
  • html/HTMLInputElement.h:
  • html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch): Check the type validity for date, datetime, datetime-local, month, time and week with HTMLInputElemtn::formStringToISODateTime()
18:13 Changeset [51162] by mjs@apple.com

2009-11-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.

Fix REGRESSION (r47022): Performance of DocumentFragment.appendChild is 1000x slower sometimes
https://bugs.webkit.org/show_bug.cgi?id=31237


Also speeds up Dromaeo DOM Core tests by 1.31x.

  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Change marking algorithm to avoid O(N2) behavior. The subtree mark bit was no longer effective; instead I changed things so only a node that has no ancestors with wrappers would do marking; there should be only one in the typical case (the root of the detached subtree).
  • dom/Node.cpp: (WebCore::Node::Node): Remove now useless m_inSubtreeMark bit and related functions.
  • dom/Node.h: ditto
18:07 Changeset [51161] by darin@apple.com

Get rid of the redundant strokeType and fillType data members on
a GraphicsContext as well as the FillOrStrokeType enum. Use
null pointers instead.

Reviewed by Sam Weinig.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setStrokeColor): Null out the pattern
and gradient.
(WebCore::GraphicsContext::setFillColor): Ditto.
(WebCore::GraphicsContext::setStrokePattern): Null out the graident.
(WebCore::GraphicsContext::setFillPattern): Ditto.
(WebCore::GraphicsContext::setStrokeGradient): Null out the pattern.
(WebCore::GraphicsContext::setFillGradient): Ditto.

  • platform/graphics/GraphicsContextPrivate.h: Remove all that stuff.
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::setPlatformFill): Use null checks on fillPattern and
fillGraident instead of a switch statement.
(WebCore::setPlatformStroke): Ditto.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::applyStrokePattern): Removed unneeded get.
(WebCore::GraphicsContext::applyFillPattern): Ditto.
(WebCore::calculateDrawingMode): Use fillPattern and strokePattern
to see if there is a pattern instead of fillType and strokeType.
(WebCore::GraphicsContext::drawPath): Use fillGradient, strokeGradient,
fillPattern, and strokePattern instead of fillType and strokeType.
(WebCore::GraphicsContext::fillPath): Added FIXME about color space that
is used in the pattern and gradient case probably erroneously. Moved
gradient code inside an if statement. Streamlined pattern code and
use an if statement. No switch any more.
(WebCore::GraphicsContext::strokePath): Ditto.
(WebCore::GraphicsContext::fillRect): Ditto.
(WebCore::GraphicsContext::strokeRect): Ditto.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillPath): Use null checks on fillPattern and
fillGraident instead of a switch statement.
(WebCore::GraphicsContext::strokePath): Ditto.
(WebCore::GraphicsContext::fillRect): Ditto.

  • platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::fillPath): Removed unneeded check of fillType.
(WebCore::GraphicsContext::fillRect): Ditto.

18:01 Changeset [51160] by eric@webkit.org

2009-11-18 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

workqueue.py results in totally broken commit-queue UI
https://bugs.webkit.org/show_bug.cgi?id=31645

  • Scripts/bugzilla-tool:
    • Remove unneeded use of PatchCollection.
    • Grab a new copy of the cq'd patches every run of the queue.
17:48 Changeset [51159] by eric@webkit.org

2009-11-18 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Add tests for ValidityState.stepMismatch.
https://bugs.webkit.org/show_bug.cgi?id=31331

  • fast/forms/ValidityState-stepMismatch-number-expected.txt: Added.
  • fast/forms/ValidityState-stepMismatch-number.html: Added.
  • fast/forms/ValidityState-stepMismatch-range-expected.txt: Added.
  • fast/forms/ValidityState-stepMismatch-range.html: Added.
  • fast/forms/ValidityState-stepMismatch-unsupported-expected.txt: Added.
  • fast/forms/ValidityState-stepMismatch-unsupported.html: Added.
  • fast/forms/input-step-expected.txt: Added.
  • fast/forms/input-step.html: Added.
  • fast/forms/script-tests/ValidityState-stepMismatch-number.js: Added.
  • fast/forms/script-tests/ValidityState-stepMismatch-range.js: Added.
  • fast/forms/script-tests/ValidityState-stepMismatch-unsupported.js: Added.
  • fast/forms/script-tests/input-step.js: Added.

2009-11-18 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Support for step attribute and ValidityStae.stepMismatch for
type=number and range. stepMismatch will be false if the
difference between the current value and a multiple of the step
value is very small.

Change the behavior of RenderSlider so that it always has a value
rounded to the step attribute value.

https://bugs.webkit.org/show_bug.cgi?id=31331

Tests: fast/forms/ValidityState-stepMismatch-number.html

fast/forms/ValidityState-stepMismatch-range.html
fast/forms/ValidityState-stepMismatch-unsupported.html
fast/forms/input-step.html

  • html/HTMLAttributeNames.in: Add "step".
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepMismatch): (WebCore::HTMLInputElement::getStepParameters): (WebCore::HTMLInputElement::getAllowedValueStep):
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl: Add "step".
  • html/ValidityState.cpp: (WebCore::ValidityState::stepMismatch): Forward to HTMLInputElement::stepMismatch().
  • html/ValidityState.h:
  • rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): (WebCore::SliderRange::clampValue):
17:27 Changeset [51158] by dimich@chromium.org

Need to ASSERT(isMainThread()) in ThreadShared methods.
https://bugs.webkit.org/show_bug.cgi?id=31637

Reviewed by Darin Adler.

Added ASSERT(IsMainThread()) to all following methods:

  • platform/TreeShared.h:

(WebCore::TreeShared::TreeShared):
(WebCore::TreeShared::~TreeShared):
(WebCore::TreeShared::ref):
(WebCore::TreeShared::deref):
(WebCore::TreeShared::setParent):
(WebCore::TreeShared::parent):

17:00 Changeset [51157] by eric@webkit.org

2009-11-18 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Eric Seidel.

Add plugin visibility manual test

https://bugs.webkit.org/show_bug.cgi?id=31542

  • manual-tests/plugins/windowed.html:
  • manual-tests/plugins/windowless.html:
16:52 Changeset [51156] by eric@webkit.org

2009-11-18 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Pavel Feldman.

Web Inspector - remember last script displayed in Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=27552

Manual test added

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.showScript): (WebInspector.ScriptsPanel.prototype.showResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.ScriptsPanel.prototype._goBack): (WebInspector.ScriptsPanel.prototype._goForward):
  • manual-tests/inspector/remember-last-script.html: Added.
16:43 Changeset [51155] by eric@webkit.org

2009-11-18 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dimitri Glazkov.

Win chromium is slow to draw transparent texts
https://bugs.webkit.org/show_bug.cgi?id=31258

Create bounded transparency layers instead of just clipping.

No new tests because this is just a performance improvement.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
16:35 Changeset [51154] by eric@webkit.org

2009-11-18 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Update expected result after Qt4.6 upgrade.
https://bugs.webkit.org/show_bug.cgi?id=31560

Test: LayoutTests/editing/deleting/5408255.html

  • platform/qt/editing/deleting/5408255-expected.txt:

2009-11-18 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Add support for displaying deleteButton.
https://bugs.webkit.org/show_bug.cgi?id=31560

Test: LayoutTests/editing/deleting/5408255.html

  • WebCore.qrc:
  • platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap):

2009-11-18 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Add support for displaying deleteButton.
https://bugs.webkit.org/show_bug.cgi?id=31560

Test: LayoutTests/editing/deleting/5408255.html

  • Api/qwebsettings.cpp: (graphics):
  • Api/qwebsettings.h:
16:26 Changeset [51153] by eric@webkit.org

2009-11-18 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Eric Seidel.

Fix Qt build without JavaScript debugger.

https://bugs.webkit.org/show_bug.cgi?id=31575

  • page/Console.idl:
16:18 Changeset [51152] by eric@webkit.org

2009-11-18 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

Make 80 patches a formal requirement for reviewership
https://bugs.webkit.org/show_bug.cgi?id=31313
Per discussion on the webkit-reviewers list:
http://lists.webkit.org/mailman/private.cgi/webkit-reviewers/2009-November/000795.html

  • coding/commit-review-policy.html:
16:05 Changeset [51151] by dbates@webkit.org

2009-11-18 Daniel Bates <dbates@webkit.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24971
And
<rdar://problem/7138265>

Fixes an issue where setting the height of a table row programmatically
(via JavaScript) causes the table to be improperly rendered because the
height of each row in the table is not recalculated with respect to the
CSS height property.

In particular, programmatically setting the height of some table row causes
the rows of that table to be rendered with a height equal to the minimum
height required by the cells in that row, regardless of any specified cell
heights. Instead, when RenderTableSection::recalcCells is called, the height
of each row should be set to the CSS height property just as we do in
RenderTableSection::addChild.

Test: fast/table/row-height-recalc2.html

  • rendering/RenderTableSection.cpp: (WebCore::setRowHeightToRowStyleHeightIfNotRelative): Added. (WebCore::RenderTableSection::addChild): Moved code that set row height into method WebCore::setRowHeightToRowStyleHeightIfNotRelative. (WebCore::RenderTableSection::recalcCells): Modified to call WebCore::setRowHeightToRowStyleHeightIfNotRelative.

2009-11-18 Daniel Bates <dbates@webkit.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24971
And
<rdar://problem/7138265>

Tests that setting the height of a table row programmatically (via JavaScript)
recalculates the height of the rows in the table.

  • fast/table/row-height-recalc2.html: Added.
  • platform/mac/fast/table/row-height-recalc2-expected.checksum: Added.
  • platform/mac/fast/table/row-height-recalc2-expected.png: Added.
  • platform/mac/fast/table/row-height-recalc2-expected.txt: Added.
  • platform/qt/fast/table/row-height-recalc2-expected.checksum: Added.
  • platform/qt/fast/table/row-height-recalc2-expected.png: Added.
  • platform/qt/fast/table/row-height-recalc2-expected.txt: Added.
  • platform/win/fast/table/row-height-recalc2-expected.checksum: Added.
  • platform/win/fast/table/row-height-recalc2-expected.png: Added.
  • platform/win/fast/table/row-height-recalc2-expected.txt: Added.
15:57 Changeset [51150] by jparent@chromium.org

Reduce flakiness in zero-duration-with-non-zero-delay-end.html by
increasing a timeout.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31646

  • transitions/zero-duration-with-non-zero-delay-end.html:
15:47 Changeset [51149] by zoltan@webkit.org

Allow custom memory allocation control for the part of platform directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31473

Reviewed by Darin Adler.

Inherits the following classes from FastAllocBase because these are
instantiated by 'new':

class AnimationList - instantiated at WebCore/rendering/style/StyleRareNonInheritedData.cpp:85
class Color - instantiated at WebCore/rendering/RenderTheme.cpp:48
struct Length - instantiated at WebCore/platform/Length.cpp:103
class PlatformKeyboardEvent - instantiated at WebCore/dom/KeyboardEvent.cpp:63
class ContextMenuItem - instantiated at WebCore/platform/ContextMenu.cpp:70
class DeprecatedPtrList - instantiated at WebCore/rendering/RenderBlock.cpp:2284

Inherits the following classes from Noncopyable because these are
instantiated by 'new' and no need to be copyable:

class GraphicsContextPrivate - instantiated at WebCore/platform/graphics/GraphicsContext.cpp:78
class FontCache - instantiated at WebCore/platform/graphics/qt/FontCacheQt.cpp:43
struct MediaPlayerFactory - instantiated at WebCore/platform/graphics/MediaPlayer.cpp:163
class DeprecatedPtrListNode - instantiated at WebCore/platform/DeprecatedPtrListImpl.cpp:53

  • platform/ContextMenuItem.h:
  • platform/DeprecatedPtrList.h:
  • platform/DeprecatedPtrListImpl.cpp:
  • platform/Length.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/animation/AnimationList.h:
  • platform/graphics/Color.h:
  • platform/graphics/FontCache.h:
  • platform/graphics/GraphicsContextPrivate.h:
  • platform/graphics/MediaPlayer.cpp:
15:46 Changeset [51148] by eric@webkit.org

2009-11-18 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=31186

Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
These are more descriptive names so as to clear an ambiguity surrounding
their usage. Also, renames associated setters and getters so that they
coincide with the renamed fields.

No functionality was changed. So, no tests were included.

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited. (WebCore::RenderTextControl::subtreeHasChanged):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited. (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited. (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):

2009-11-18 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=31186

Changes associated with renaming RenderTextControl::isUserEdited.

  • DOMHTMLClasses.cpp: (DOMHTMLInputElement::isUserEdited): Formerly named isUserEdited. (DOMHTMLTextAreaElement::isUserEdited): Ditto.
15:44 Changeset [51147] by weinig@apple.com

Make the Mac Geolocation API async.

Reviewed by Anders Carlsson.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Remove WebGeolocation.

WebKit/mac:

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::requestGeolocationPermissionForFrame):
(-[WebGeolocationPolicyListener initWithGeolocation:]):
(-[WebGeolocationPolicyListener allow]):
(-[WebGeolocationPolicyListener deny]):
Add WebGeolocationPolicyListener implementation of the new WebGeolocationPolicyListener
protocol and use if to implement requestGeolocationPermissionForFrame using the new async
API.

  • WebCoreSupport/WebGeolocation.mm: Removed.
  • WebCoreSupport/WebGeolocationInternal.h: Removed.
  • WebCoreSupport/WebGeolocationMock.mm: Remove bogus include.
  • WebCoreSupport/WebGeolocationPrivate.h: Removed.
  • WebView/WebUIDelegatePrivate.h: Remove requestGeolocationPermission and add

WebGeolocationPolicyListener protocol and decidePolicyForGeolocationRequestFromOrigin delegate
method.

WebKitTools:

Update DRT to use the new async Mac Geolocation API.

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):

15:36 Changeset [51146] by eric@webkit.org

2009-11-18 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

Remove V8CanvasPixelArrayCustom.cpp because it is no longer used by V8.
https://bugs.webkit.org/show_bug.cgi?id=31499

No new tests, just a build cleanup.

  • WebCore.gypi:
  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8CustomBinding.h:
15:29 Changeset [51145] by eric@webkit.org

2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add and option to toggle HTML5 datalist support to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=31599

  • Scripts/build-webkit:
15:25 Changeset [51144] by japhet@chromium.org

2009-11-18 Nate Chapin <japhet@chromium.org>

Reviewed by Darin Fisher.

Remove Chromium's unnecessary dependency on wtf's tcmalloc files.

https://bugs.webkit.org/show_bug.cgi?id=31648

15:23 Applications using WebKit edited by blythe_yee@apple.com
(diff)
15:18 Changeset [51143] by kevino@webkit.org

Reviewed by Kevin Ollivier.

Enable wx plugin support using the Windows implementation as a base.

https://bugs.webkit.org/show_bug.cgi?id=31636

15:10 Changeset [51142] by eric@webkit.org

2009-11-18 Evan Stade <estade@chromium.org>

Reviewed by Darin Fisher.

Menu button shows wrong content in Chromium
https://bugs.webkit.org/show_bug.cgi?id=31448

Make context menu button (VK_APPS) show context menu for node that has
keyboard focus. This affects both the content and the positioning.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::sendContextMenuEvent):
15:02 Changeset [51141] by eric@webkit.org

2009-11-18 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Gavin Barraclough.

[Qt] Implement symbol hiding for JSC's JIT functions.

These functions are implemented directly in assembly, so they need the
proper directives to enable/disable visibility. On ELF systems, it's
.hidden, whereas on Mach-O systems (Mac) it's .private_extern. On
Windows, it's not necessary since you have to explicitly export. I
also implemented the AIX idiom, though it's unlikely anyone will
implement AIX/POWER JIT.
https://bugs.webkit.org/show_bug.cgi?id=30864

  • jit/JITStubs.cpp:
14:49 Changeset [51140] by eric@webkit.org

2009-11-18 Andrei Popescu <andreip@google.com>

Reviewed by Dimitri Glazkov.

[Android] Add shared timer and sound utilities to platform/android
https://bugs.webkit.org/show_bug.cgi?id=31584

No new tests required, this is platform specific code.

  • platform/android/SharedTimerAndroid.cpp: Added. (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
  • platform/android/SoundAndroid.cpp: Added. (WebCore::systemBeep):
14:41 Changeset [51139] by eric@webkit.org

2009-11-18 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Fix profile tree nodes loss after focus / restore actions.

Focusing on a node is currently implemented via nodes reattaching
with some caching involved. It seems that not all code was updated
to handle this scenario correctly.

https://bugs.webkit.org/show_bug.cgi?id=31553

  • inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._restore): (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate): (WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.insertChild): (WebInspector.DataGridNode.prototype._detach): (WebInspector.DataGridNode.prototype.savePosition): (WebInspector.DataGridNode.prototype.restorePosition):
  • inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridTree.prototype.focus): (WebInspector.TopDownProfileDataGridTree.prototype.restore):
14:37 Changeset [51138] by dbates@webkit.org

2009-11-18 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31610

Adds property "min-width" to #title so that the width of the title
element on each page is at least 790px. In particular, this makes
the page <http://webkit.org/security/security-group-members.html>
consistent, in appearance, to the rest of the site.

  • css/main.css:
14:33 Changeset [51137] by eric@webkit.org

2009-11-18 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPageClient.h needs in some cases QCursor, but it does not
include it
https://bugs.webkit.org/show_bug.cgi?id=31527

No new tests as this is just a coding style fix that affects the
build of some not yet submitted patches (i.e. for bug 30173).

  • platform/qt/QWebPageClient.h:
14:25 Changeset [51136] by eric@webkit.org

2009-11-18 Nicolas Roard <nicolas@roard.com>

Reviewed by Dimitri Glazkov.

InspectorTimelineAgent.h should be guarded by ENABLE(INSPECTOR)
https://bugs.webkit.org/show_bug.cgi?id=31504

  • inspector/InspectorTimelineAgent.h:Added the guard.
14:08 Changeset [51135] by snej@chromium.org

Build fix to my previous checkin, for Windows Chromium

  • svg/SVGAnimatedProperty.h:

(WebCore::PropertySynchronizer::synchronize): Fix implicit-conversion error on AtomicString.

14:05 Changeset [51134] by joepeck@webkit.org

2009-11-18 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Directly Access <head> Instead of Searching for It
https://bugs.webkit.org/show_bug.cgi?id=31641

Changed old access of the head element (document.getElementsByTagName)
to just use the document.head accessor.

  • inspector/front-end/FontView.js: (WebInspector.FontView):
  • inspector/front-end/InjectedScript.js: (InjectedScript.addStyleSelector):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
  • inspector/front-end/inspector.js: (windowLoaded):
14:04 Changeset [51133] by weinig@apple.com

Fix two Geolocation assertions.

Reviewed by Anders Carlsson.

  • page/Chrome.cpp:

(WebCore::Chrome::requestGeolocationPermissionForFrame): No need to use PageGroupLoadDeferrer since this
is not called from JS.

  • page/Geolocation.cpp:

(WebCore::Geolocation::Watchers::set): The PassRefPtr was getting nulled out, so we need to put it in
a RefPtr first.

14:02 Changeset [51132] by ap@apple.com

Case sensitive file system build fix.

  • platform/network/Credential.h: It's not WTF, just wtf.
13:54 Changeset [51131] by agolden@apple.com

Add support for certificates to WebCore::Credential so we can convert between NSURLCredential
objects and WebCore::Credential objects without losing certificate information.

Reviewed by Alexey Proskuryakov

13:49 Changeset [51130] by darin@chromium.org

2009-11-17 Darin Fisher <darin@chromium.org>

Reviewed by Dmitry Titov.

Minor cleanup in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=31616

  • public/WebFormElement.h: Add missing WEBKIT_API prefix.
  • public/WebNode.h: Add missing WEBKIT_API prefix.
  • src/WebFormElement.cpp: (WebKit::WebFormElement::action): Make action getter const.
  • src/WebNode.cpp: (WebKit::WebNode::frame): Utilize WebFrameImpl::fromFrame.
13:31 Changeset [51129] by oliver@apple.com

Update expected results of fixed test.

12:46 Changeset [51128] by oliver@apple.com

Interpreter may do an out of range access when throwing an exception in the profiler.
https://bugs.webkit.org/show_bug.cgi?id=31635

Reviewed by Alexey Proskuryakov.

Add bounds check.

12:25 Changeset [51127] by dimich@chromium.org

Reverting r50919 that has introduced a non-thread-safe refcounting in ScriptExecutionContext::postTaskToMainThread.
https://bugs.webkit.org/show_bug.cgi?id=31615

Reviewed by Eric Seidel.

  • dom/Document.cpp:

(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::ScriptExecutionContextTaskTimer::fired):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::performTask):
(WebCore::Document::postTask):

  • dom/ScriptExecutionContext.cpp:
  • dom/ScriptExecutionContext.h:
12:09 Changeset [51126] by ap@apple.com

Disabling WebSocket tests on Tiger back, they still hang.

  • platform/mac-tiger/Skipped:
11:57 Changeset [51125] by snej@chromium.org

Eliminate unnecessary String-->AtomicString conversions from generated V8 bindings,
by causing the right v8-to-WebCore conversion function to be called for every parameter.
This no longer requires any IDL metadata, so I've removed the [HintAtomic] annotations.
To enforce correctness, I added a mode that disables implicit
String-->AtomicString conversions while compiling the generated bindings.
https://bugs.webkit.org/show_bug.cgi?id=31168

Reviewed by Darin Adler.

  • bindings/scripts/CodeGeneratorV8.pm: Generate usage of V8Parameter class.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Enable NO_IMPLICIT_ATOMICSTRING.
  • bindings/v8/V8Binding.h: Add V8Parameter class.
  • css/WebKitCSSKeyframesRule.h: Make AtomicString conversions explicit.
  • dom/Document.idl: Remove obsolete [HintAtomic] annotation.
  • platform/text/AtomicString.h: Added NO_IMPLICIT_ATOMICSTRING option.
  • svg/SVGAnimatedTemplate.h: Change some return types to String to avoid implicit conversion.
  • svg/SVGAnimatedProperty.h: Adapt to changed return types in SVGAnimatedTemplate.
11:49 Changeset [51124] by darin@apple.com

Move FillOrStrokeType out of public header.

Reviewed by Dan Bernstein.

  • platform/graphics/GraphicsContext.h: Updated copyright date to cover

some years we published Apple changes, sorted forward declarations,
removed FillOrStrokeType enum.

  • platform/graphics/GraphicsContextPrivate.h: Updated copyright date

to cover some years we published Apple changes, sorted includes,
moved FillOrStrokeType enum here.

11:37 Changeset [51123] by ossy@webkit.org

Fix the clobber list of cacheFlush for ARM and Thumb2 on Linux
https://bugs.webkit.org/show_bug.cgi?id=31631

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-11-18
Reviewed by Darin Adler.

  • jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

11:23 Changeset [51122] by cmarrin@apple.com

Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter
https://bugs.webkit.org/show_bug.cgi?id=31601

These are used to debug accelerated compositing layers. I removed
the platform specific code from GraphicsLayerCA.mm and added calls
to GraphicsLayerClient to get it from the higher levels. The values
now get cached in RenderLayerCompositing and are queried from there
by RenderLayerBacking (which implements the GraphicsLayerClient interface).

10:26 Changeset [51121] by pfeldman@chromium.org

2009-11-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Get rid of metrics and properties sidebars'
flickering.

https://bugs.webkit.org/show_bug.cgi?id=31629

  • inspector/front-end/MetricsSidebarPane.js:
  • inspector/front-end/PropertiesSidebarPane.js:
10:21 Changeset [51120] by jparent@chromium.org

Eliminate flakiness in file-URL-with-port-number by removing a setTimeout.
The timeout caused the test to fail about 2% of the time on the Chromium builders.
The timeout exists to catch cases where the iframe does not load, but the test
framework already will handle this (albeit with a longer timeout).

Reviewed by Dmitry Titov.

  • fast/loader/file-URL-with-port-number.html:
10:12 Changeset [51119] by bweinstein@apple.com

Fixes <http://webkit.org/b/31606>.
Web Inspector: Enter/Return key should enter edit mode for Editable Fields.

Reviewed by Pavel Feldman.

This implements Enter starting editing mode in an editable DataGrid. If the
DataGrid is editable and the user hits return, startEditing the first child
of the selected node. Also refactored some editing functions to take an
event target instead of the event itself, because the functions only needed
the target. Lastly, added had return in editing mode stop propogation, because
when enter was hit to confirm text, it would propagate back to the datagrid
and try to start editing again.

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._ondblclick):
(WebInspector.DataGrid.prototype._startEditing):
(WebInspector.DataGrid.prototype.handleKeyEvent):
(WebInspector.DataGrid.prototype.dataGridNodeFromEvent):
(WebInspector.DataGrid.prototype._mouseDownInDataTable):
(WebInspector.DataGrid.prototype._clickInDataTable):

  • inspector/front-end/inspector.js:

(WebInspector.startEditing.element.handleKeyEvent):
(WebInspector.startEditing):

09:57 Changeset [51118] by benm@google.com

HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
https://bugs.webkit.org/show_bug.cgi?id=31593

Reviewed by Darin Adler.

WebCore:

Test: fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::href): Add call to deprecatedParseURL.

LayoutTests:

  • fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-whitespace.js: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-whitespace-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html: Added.
09:38 Changeset [51117] by pfeldman@chromium.org

2009-11-18 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Touch InspectorController so that frontend
JS files are deployed on Windows.

  • inspector/InspectorController.cpp:
09:30 Changeset [51116] by ap@apple.com

Trying to enable WebSocket tests on Tiger again, now that bug 31603 is fixed.

  • platform/mac-tiger/Skipped:
09:25 Changeset [51115] by pfeldman@chromium.org

2009-11-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: clone timeline records array instead of
copying reference on invalidate all.

https://bugs.webkit.org/show_bug.cgi?id=31596

  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
08:38 Changeset [51114] by kenneth@webkit.org

Change the initialization order so that the controllers
will be created before exporting them to the JS DOM window.

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):

08:17 QtWebKitAPI edited by hausmann@webkit.org
(diff)
08:16 Changeset [51113] by kenneth@webkit.org

Fix a code copy and paste error. m_page should be page.

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::createWindow):

08:15 QtWebKitAPI edited by hausmann@webkit.org
(diff)
08:14 QtWebKitAPI edited by hausmann@webkit.org
(diff)
08:05 QtWebKitAPI created by hausmann@webkit.org
07:49 QtWebKitContrib edited by hausmann@webkit.org
(diff)
07:02 Changeset [51112] by simon.fraser@apple.com

2009-11-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Elements don't drop out of compositing layers when animation ends
https://bugs.webkit.org/show_bug.cgi?id=31613
<rdar://problem/7402913>

Avoid setting the mustOverlapCompositedLayers flag on RenderLayers which
are compositing anyway for other reasons. Doing so can cause those layers
to stay in compositing mode even after animations finish, because needsToBeComposited()
continues to return true.

No new tests because it's not possible to determine which elements are in
compositing layers from DRT output.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
06:27 Changeset [51111] by hausmann@webkit.org

[Qt] Make the QWebElement::render() test pass when pixmaps aren't 32 bit.

Patch by Paul Olav Tvete <paul.tvete@nokia.com> on 2009-11-18
Reviewed by Simon Hausmann.

  • tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::render):

05:22 Changeset [51110] by hausmann@webkit.org

[Qt] Fix detection of linux-g++

Patch by Harald Fernengel <harald.fernengel@nokia.com> on 2009-11-18
Reviewed by Simon Hausmann.

Never use "linux-g++*" to check for linux-g++, since this will break embedded
builds which use linux-arm-g++ and friends. Use 'linux*-g++*' to check for any
g++ on linux mkspec.

05:20 Changeset [51109] by kov@webkit.org

Properly localize documentation strings for the tab-key-cycles-through-elements property.

05:20 Changeset [51108] by kov@webkit.org

Ensure that tabKeyCyclesThroughElements is true by default.

05:19 Changeset [51107] by hausmann@webkit.org

Clarify and simplify the legal section in the overview documentation,
after review with our legal team.

Reviewed by Tor Arne Vestbø.

  • docs/qtwebkit.qdoc:
04:58 Changeset [51106] by vestbo@webkit.org

[Qt] Add QtLauncher support for opening links in the default browser

Reviewed by Simon Hausmann.

This can be triggered by either the context menu or by clicking a link
while holding down the Alt key. Opening a link in a new windows is
triggered by holding down Shift.

  • QtLauncher/main.cpp:
04:53 Changeset [51105] by girish@forwardbias.in

[Qt] Mac Plugins: Remove null timer

Reviewed by Tor Arne Vestbø.

A null timer was used to send mouse move events. Instead, we now use
move events to send nullEvent. This brings down CPU usage by 20-30%.

https://bugs.webkit.org/show_bug.cgi?id=31624

04:48 Changeset [51104] by kov@webkit.org

Reviewed by Xan Lopez.

[GTK] Failing test media/video-document-types.html
https://bugs.webkit.org/show_bug.cgi?id=31352

Match what Mac has been doing since r36001: cancel the main load,
and handle failures caused by 'will be handled by plugin' errors.

Covered by test media/video-document-types.html

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::committedLoad):
(WebKit::FrameLoaderClient::shouldFallBack):

02:29 Changeset [51103] by hausmann@webkit.org

[Qt] WebKit crashes when loading certain SVG images

Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2009-11-18
Reviewed by Simon Hausmann.

WebCore:

Check if the familly exist before creating the PlatformData from it.

https://bugs.webkit.org/show_bug.cgi?id=29443

Test: svg/text/text-font-invalid.html

  • platform/graphics/qt/FontFallbackListQt.cpp:

(WebCore::FontFallbackList::fontDataAt):

LayoutTests:

Added a test for a crash of QtWebkit when loading SVG images.

https://bugs.webkit.org/show_bug.cgi?id=29443

  • svg/text/resources/text-font-invalid.svg: Added.
  • svg/text/text-font-invalid-expected.txt: Added.
  • svg/text/text-font-invalid.html: Added.

11/17/09:

22:51 Changeset [51102] by darin@chromium.org

2009-11-17 Nicolas Weber <thakis@chromium.org>

Reviewed by Darin Fisher.

Fix crash in Chromium/Mac where dropdowns weren't dismissed correctly
after navigation.
https://bugs.webkit.org/show_bug.cgi?id=31609

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showExternal): Set parent for external dropdowns, so that |PopupListBox::hidePopup()| can successfully notify its parent's client.
21:19 Changeset [51101] by tkent@chromium.org

2009-11-17 Hayato Ito <hayato@google.com>

Reviewed by Darin Adler.

Avoid infinite mutual recursion when deeply nested tags are loaded
https://bugs.webkit.org/show_bug.cgi?id=30651

  • fast/parser/block-nesting-cap-table-expected.txt: Added.
  • fast/parser/block-nesting-cap-table.html: Added.
  • fast/parser/script-tests/block-nesting-cap-table.js: Added.

2009-11-17 Hayato Ito <hayato@google.com>

Reviewed by Darin Adler.

Avoid infinite mutual recursion when deeply nested tags are loaded
https://bugs.webkit.org/show_bug.cgi?id=30651

Test: fast/parser/block-nesting-cap-table.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken): (WebCore::tagPriorityOfNode): (WebCore::HTMLParser::limitBlockDepth): (WebCore::HTMLParser::insertNodeAfterLimitBlockDepth): (WebCore::HTMLParser::insertNode):
  • html/HTMLParser.h:
20:18 Changeset [51100] by jhoneycutt@apple.com

Add JSContextRefPrivate.h to list of copied files.

Reviewed by Mark Rowe.

17:12 Changeset [51099] by mrowe@apple.com

<http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X

Reviewed by Alexey Proskuryakov.

  • pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.

This prevents symlinks from confusing the descendant check.

17:08 Changeset [51098] by bfulgham@webkit.org

Rubber-stamped by Alexey Proskuryakov.

Final clean-ups for minor coding standard violations.
https://bugs.webkit.org/show_bug.cgi?id=26102.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:
16:35 Changeset [51097] by dimich@chromium.org

WebCore: In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
https://bugs.webkit.org/show_bug.cgi?id=31567

Patch by Johnny Ding <jnd@chromium.org> on 2009-11-17
Reviewed by Darin Adler.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElementData::shouldExecuteAsJavaScript):

LayoutTests: In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
Change the original test to pure js test, and test the situation about script tags which have text or language attribute.
https://bugs.webkit.org/show_bug.cgi?id=31567

Patch by Johnny Ding <jnd@chromium.org> on 2009-11-17
Reviewed by Darin Adler.

  • fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution-expected.txt:
  • fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html:
  • fast/dom/HTMLScriptElement/script-tests: Added.
  • fast/dom/HTMLScriptElement/script-tests/script-for-attribute-unexpected-execution.js: Added.

(ScriptForAttributeExecute):

16:31 Changeset [51096] by mrowe@apple.com

<http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run

Reviewed by Alexey Proskuryakov.

WebKitTools:

If the WebSocket server fails to start have DRT load an error page in place of tests that require the
server to be up rather than having run-webkit-tests abort immediately.

  • Scripts/run-webkit-tests:

LayoutTests:

  • websocket/resources/server-failed-to-start.html: Error page that will be loaded in place of websocket

tests when the server fails to start.

16:24 Changeset [51095] by dimich@chromium.org

Revert r50887, it regressed handling of cmd-left when a text box is focused.
https://bugs.webkit.org/show_bug.cgi?id=31566

Patch by Nicolas Weber <thakis@chromium.org> on 2009-11-17
Reviewed by Darin Fisher, Dmitry Titov.

  • src/mac/WebInputEventFactory.mm:

(WebKit::WebInputEventFactory::keyboardEvent):

16:08 CommitQueue edited by thakis@chromium.org
(diff)
15:38 Changeset [51094] by jhoneycutt@apple.com

Implement DOMHTMLInputElement::replaceCharactersInRange().

https://bugs.webkit.org/show_bug.cgi?id=31492

Reviewed by Dan Bernstein.

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::replaceCharactersInRange):
Get the text of the input field. Replace the given range with the
replacement text, and set this new string as the input element's value.
Select from index to the end of the field. This matches the
implementation in the Obj-C bindings.

15:37 Changeset [51093] by jhoneycutt@apple.com

DOMHTMLOptionElement is missing some functionality.

https://bugs.webkit.org/show_bug.cgi?id=31491

Reviewed by Dan Bernstein.

  • DOMHTMLClasses.cpp:

(DOMHTMLOptionElement::text):
Cast m_element to an HTMLOptionElement, and call its text() function.
(DOMHTMLOptionElement::label):
Ditto, for label().

15:37 Changeset [51092] by jhoneycutt@apple.com

DOMHTMLSelectElement is missing some implementation.

https://bugs.webkit.org/show_bug.cgi?id=31489

Reviewed by Dan Bernstein.

  • DOMHTMLClasses.cpp:

(DOMHTMLSelectElement::options):
Cast m_element to an HTMLSelectElement. If it has no options, return
E_FAIL. Otherwise, create a DOMHTMLOptionsCollection to wrap the
options, and return it.
(DOMHTMLSelectElement::activateItemAtIndex):
If the index is out of bounds, return E_FAIL. Otherwise, select the
item.

15:37 Changeset [51091] by jhoneycutt@apple.com

DOMHTMLOptionsCollection is missing some implementation.

https://bugs.webkit.org/show_bug.cgi?id=31488

Reviewed by Dan Bernstein.

  • DOMHTMLClasses.cpp:

(DOMHTMLOptionsCollection::DOMHTMLOptionsCollection):
Initialize m_collection.
(DOMHTMLOptionsCollection::createInstance):
Create a DOMHTMLOptionsCollection. If we fail to query for
IDOMHTMLOptionsCollection, delete it, and return 0. Otherwise, return
the result.
(DOMHTMLOptionsCollection::length):
(DOMHTMLOptionsCollection::item):
Create a DOMNode for the WebCore Node. If this is 0, return E_FAIL.
(DOMHTMLOptionsCollection::namedItem):
Correct the signature of this function.

  • DOMHTMLClasses.h:

Declare DOMHTMLOptionsCollection::createInstance(). Correct the
signature of namedItem() to match IDOMHTMLOptionsCollection. Add a
member to DOMHTMLOptionsCollection to hold the WebCore object.

15:37 Changeset [51090] by jhoneycutt@apple.com

DOMHTMLInputElement::rectOnScreen() returns the wrong rect

https://bugs.webkit.org/show_bug.cgi?id=31487

Reviewed by Darin Adler.

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::rectOnScreen):
Return the rect on screen, not the rect in the window.

14:07 Changeset [51089] by bweinstein@apple.com

Rubber-stamped by Pavel Feldman.

Skip inspector tests that are flaky on Windows Release - this is being tracked by:
https://bugs.webkit.org/show_bug.cgi?id=31596.

  • platform/win/Skipped:
13:40 Changeset [51088] by jparent@chromium.org

Eliminate flakiness in char-encoding tests by removing setTimeout,
that was working around an old issue.
https://bugs.webkit.org/show_bug.cgi?id=31571

Reviewed by Darin Adler.

  • fast/encoding/char-encoding-mac.html:
  • fast/encoding/char-encoding.html:
  • fast/encoding/resources/char-encoding-utils.js:
13:30 Changeset [51087] by kenneth@webkit.org

Unreviewed buildbot fix.

Revert part of earlier patch and add comment, as it
was causing timeouts on the buildbot.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::notifyDone):

12:38 Changeset [51086] by eric@webkit.org

2009-11-17 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Adam Barth.

[GTK] Style cleanup for GOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=31506

Remove forward declaration in GOwnPtr and do some style cleanup.

  • wtf/GOwnPtr.cpp:
  • wtf/GOwnPtr.h: (WTF::GOwnPtr::GOwnPtr): (WTF::GOwnPtr::~GOwnPtr): (WTF::GOwnPtr::get): (WTF::GOwnPtr::release): (WTF::GOwnPtr::outPtr): (WTF::GOwnPtr::set): (WTF::GOwnPtr::clear): (WTF::GOwnPtr::operator*): (WTF::GOwnPtr::operator->): (WTF::GOwnPtr::operator!): (WTF::GOwnPtr::operator UnspecifiedBoolType): (WTF::GOwnPtr::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::getPtr): (WTF::freeOwnedGPtr):
12:11 Changeset [51085] by eric@webkit.org

2009-11-17 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

commit-queue is failing to set reviewer in ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=31592

  • Scripts/bugzilla-tool: Clarify the "applying" log message.
  • Scripts/modules/bugzilla.py:
    • Add a new _validate_committer_and_reviewer function as a temporary solution until we can make a real Attachment object which knows how to fill in its committer/reviewer fields automatically.
12:05 Changeset [51084] by kenneth@webkit.org

Make the timeout 15 sec as for the other DRT's and make
it print out the same output when a test timeout.

Reviewed by Oliver Hunt.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::waitUntilDone):
(LayoutTestController::notifyDone):
(LayoutTestController::timerEvent):

11:56 Changeset [51083] by yael.aharon@nokia.com

[Qt] QGLLauncher does not support drag&drop of local files
https://bugs.webkit.org/show_bug.cgi?id=31057

Reviewed by Kenneth Rohde Christiansen.

Enable accepting files in QGraphicsWebView.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::QGraphicsWebView):
(QGraphicsWebView::dragEnterEvent):

11:33 Changeset [51082] by bfulgham@webkit.org

Correct build error in Debug_Cairo target after @49705.

Reviewed by NOBODY - Build Fix.

  • WebKit.vcproj/WebKit.vcproj: Revise JavaScriptCore.lib dependency to have proper "_debug" suffix needed by the Debug_Cairo target.
11:27 Web Inspector edited by timothy@apple.com
(diff)
11:26 WebInspector created by timothy@apple.com
Copied from Web Inspector
11:11 Changeset [51081] by bweinstein@apple.com

Touch InspectorController to force the Inspector HTML and JS files to be
updated.

10:57 Changeset [51080] by ossy@webkit.org

Not reviewed, follow up to r51072: rename skipped entries

  • platform/qt/Skipped:
10:52 Changeset [51079] by joepeck@webkit.org

2009-11-17 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Fixed typos in comments.

  • Scripts/modules/committers.py:
10:42 Changeset [51078] by ossy@webkit.org

[Qt] Crashing tests after updating to Qt-4.6.0
https://bugs.webkit.org/show_bug.cgi?id=31591

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/Skipped: Put tests into skiplist temporarily.
10:37 Changeset [51077] by bweinstein@apple.com

Touch files to try to fix the build.

Reviewed by NOBODY - Build Fix.

  • Interfaces/IWebInspector.idl:
  • Interfaces/WebKit.idl:
  • WebKit.vcproj/Interfaces.vcproj:
09:55 Changeset [51076] by tonikitoo@webkit.org

[Qt] better test coverage for ErrorPageExtension
https://bugs.webkit.org/show_bug.cgi?id=31583

Reviewed by Kenneth Christiansen.

Improved the coverage of current ErrorPageExtension tests by
adding autotests involving frameset and iframes.

  • tests/qwebpage/tst_qwebpage.cpp:

(ErrorPage::extension): Make the ErrorPageExtension
to work for all frames, not only the main frame.
(tst_QWebPage::errorPageExtension): Stop using
the 'frameset.html' resouce in this method since
an autotest specific for frameset's is being added.
(tst_QWebPage::errorPageExtensionInIFrames): Added.
(tst_QWebPage::errorPageExtensionInFrameset): Added.

06:14 Changeset [51075] by pfeldman@chromium.org

2009-11-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed, tests fix. Follow up to r51072: move
platform-specific results for fast/inspector into
fast/inspector-support.

  • platform/mac/fast/inspector-support/matchedrules-expected.checksum: Renamed from LayoutTests/platform/mac/fast/inspector/matchedrules-expected.checksum.
  • platform/mac/fast/inspector-support/matchedrules-expected.png: Renamed from LayoutTests/platform/mac/fast/inspector/matchedrules-expected.png.
  • platform/mac/fast/inspector-support/matchedrules-expected.txt: Renamed from LayoutTests/platform/mac/fast/inspector/matchedrules-expected.txt.
  • platform/mac/fast/inspector-support/style-expected.txt: Renamed from LayoutTests/platform/mac/fast/inspector/style-expected.txt.
  • platform/qt/fast/inspector-support/matchedrules-expected.txt: Renamed from LayoutTests/platform/qt/fast/inspector/matchedrules-expected.txt.
  • platform/qt/fast/inspector-support/style-expected.txt: Renamed from LayoutTests/platform/qt/fast/inspector/style-expected.txt.
05:54 Changeset [51074] by kov@webkit.org

Actually skip the inspector console tests while the problem
discussed in https://bugs.webkit.org/show_bug.cgi?id=31472 is
fixed.

05:38 Changeset [51073] by pfeldman@chromium.org

2009-11-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed, build fix. Follow up to r51072: rename skipped entries
for the tests that were moved. Also skipped console tests on GTK
while investigating and touched Interfaces.vcproj to clobber win bot.


  • platform/gtk/Skipped:
  • platform/qt/Skipped:
05:11 Changeset [51072] by pfeldman@chromium.org

2009-11-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Make DRT show web inspector for tests in inspector/ folder.

  • Updated DRT to show/close inspector for all tests under /inspector
  • Introduced LayoutTestController::setTimelineProfilingEnabled and WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
  • Removed reload on each inspector test
  • Renamed fast/inspector to fast/inspector-support in order not to trigger inspector for those.
  • Reimplemented timeline tests in order to get rid of reload there.
  • Moved tests that don't require harness into the fast group.

https://bugs.webkit.org/show_bug.cgi?id=31472

WebCore:

  • WebCore.Inspector.exp:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._formatRecord):

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp: (setTimelineProfilingEnabledCallback): (closeWebInspectorCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldOpenWebInspector): (runTest):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setTimelineProfilingEnabled):
  • DumpRenderTree/mac/DumpRenderTree.mm: (shouldOpenWebInspector): (runTest):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setTimelineProfilingEnabled):
  • DumpRenderTree/win/DumpRenderTree.cpp: (shouldOpenWebInspector): (runTest):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setTimelineProfilingEnabled):

LayoutTests:

  • fast/inspector-support/cssURLQuotes-expected.txt: Renamed from LayoutTests/fast/inspector/cssURLQuotes-expected.txt.
  • fast/inspector-support/cssURLQuotes.html: Renamed from LayoutTests/fast/inspector/cssURLQuotes.html.
  • fast/inspector-support/matchedrules.html: Renamed from LayoutTests/fast/inspector/matchedrules.html.
  • fast/inspector-support/style.html: Renamed from LayoutTests/fast/inspector/style.html.
  • fast/inspector-support/uncaught-dom1-exception-expected.txt: Renamed from LayoutTests/inspector/uncaught-dom1-exception-expected.txt.
  • fast/inspector-support/uncaught-dom1-exception.html: Renamed from LayoutTests/inspector/uncaught-dom1-exception.html.
  • fast/inspector-support/uncaught-dom3-exception-expected.txt: Renamed from LayoutTests/inspector/uncaught-dom3-exception-expected.txt.
  • fast/inspector-support/uncaught-dom3-exception.html: Renamed from LayoutTests/inspector/uncaught-dom3-exception.html.
  • fast/inspector-support/uncaught-dom8-exception-expected.txt: Renamed from LayoutTests/inspector/uncaught-dom8-exception-expected.txt.
  • fast/inspector-support/uncaught-dom8-exception.html: Renamed from LayoutTests/inspector/uncaught-dom8-exception.html.
  • inspector/inspector-test.js: (onload): (evaluateInWebInspector): (notifyDone):
  • inspector/resources/timeline-iframe-data.html: Added.
  • inspector/timeline-layout-expected.txt:
  • inspector/timeline-layout.html:
  • inspector/timeline-mark-timeline.html:
  • inspector/timeline-paint.html:
  • inspector/timeline-parse-html-expected.txt:
  • inspector/timeline-parse-html.html:
  • inspector/timeline-recalculate-styles-expected.txt:
  • inspector/timeline-recalculate-styles.html:
  • inspector/timeline-script-tag-1-expected.txt:
  • inspector/timeline-script-tag-1.html:
  • inspector/timeline-script-tag-2-expected.txt:
  • inspector/timeline-script-tag-2.html:
  • inspector/timeline-script-tag-2.js:
  • inspector/timeline-test.js: (printTimelineRecords): (): (dumpTimelineRecords): (printProps): (frontend_getTimelineResults):

WebKit/mac:

WebKit/win:

  • Interfaces/IWebInspector.idl:
  • WebInspector.cpp: (WebInspector::isTimelineProfilingEnabled): (WebInspector::setTimelineProfilingEnabled):
  • WebInspector.h:

WebKit/gtk:

  • webkit/webkitwebinspector.cpp: (webkit_web_inspector_class_init): (webkit_web_inspector_set_property): (webkit_web_inspector_get_property):
04:40 Changeset [51071] by benm@google.com

[Android] Android is missing the implementation of the GeolocationService iface.
https://bugs.webkit.org/show_bug.cgi?id=31554

Patch by Andrei Popescu <andreip@google.com> on 2009-11-17
Reviewed by Dimitri Glazkov.

No new tests required as this is platform specific code.

  • platform/android/GeolocationServiceAndroid.cpp: Added.

(WebCore::GeolocationServiceAndroid::create):
(WebCore::GeolocationServiceAndroid::GeolocationServiceAndroid):
(WebCore::GeolocationServiceAndroid::startUpdating):
(WebCore::GeolocationServiceAndroid::stopUpdating):
(WebCore::GeolocationServiceAndroid::suspend):
(WebCore::GeolocationServiceAndroid::resume):
(WebCore::GeolocationServiceAndroid::newPositionAvailable):
(WebCore::GeolocationServiceAndroid::newErrorAvailable):
(WebCore::GeolocationServiceAndroid::timerFired):
(WebCore::GeolocationServiceAndroid::isPositionMovement):
(WebCore::GeolocationServiceAndroid::isPositionMoreAccurate):
(WebCore::GeolocationServiceAndroid::isPositionMoreTimely):

  • platform/android/GeolocationServiceAndroid.h: Added.

(WebCore::GeolocationServiceAndroid::~GeolocationServiceAndroid):
(WebCore::GeolocationServiceAndroid::lastPosition):
(WebCore::GeolocationServiceAndroid::lastError):

  • platform/android/GeolocationServiceBridge.cpp: Added.

(WebCore::):
(WebCore::GeolocationServiceBridge::GeolocationServiceBridge):
(WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
(WebCore::GeolocationServiceBridge::start):
(WebCore::GeolocationServiceBridge::stop):
(WebCore::GeolocationServiceBridge::setEnableGps):
(WebCore::GeolocationServiceBridge::newLocationAvailable):
(WebCore::GeolocationServiceBridge::newErrorAvailable):
(WebCore::GeolocationServiceBridge::toGeoposition):
(WebCore::GeolocationServiceBridge::startJavaImplementation):
(WebCore::GeolocationServiceBridge::stopJavaImplementation):

  • platform/android/GeolocationServiceBridge.h: Added.
01:36 Changeset [51070] by hamaji@chromium.org

2009-11-17 Yuta Kitamura <yutak@chromium.org>

Reviewed by Eric Seidel.

Fix http tests so that they do not submit a GET form to about:blank.

Original tests expected that submitting an empty form to <about:blank> navigates
the browser to <about:blank?>, not <about:blank>. However, some other browsers
do not act like Safari, and in fact the layout test runner of Chromium was
failing to run these tests.

Prior to this patch, a test that only checks this behavior was added, so now
we can remove the dependency on it from these tests.

Some HTTP tests submit a GET form to about:blank
https://bugs.webkit.org/show_bug.cgi?id=30423

  • http/tests/navigation/onload-navigation-iframe-2-expected.txt:
  • http/tests/navigation/onload-navigation-iframe-2.html:
  • http/tests/navigation/onload-navigation-iframe-expected.txt:
  • http/tests/navigation/onload-navigation-iframe-timeout-expected.txt:
  • http/tests/navigation/onload-navigation-iframe-timeout.html:
  • http/tests/navigation/onload-navigation-iframe.html:
  • http/tests/navigation/resources/blank.txt: Added.
01:27 Changeset [51069] by hamaji@chromium.org

2009-11-17 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Add a test to check the behavior of submitting a GET form to <about:blank>.

Currently Safari redirects the browser to <about:blank?>, while some other
browsers do not (including Firefox and Chromium). The objective of this test is
to express the current behavior of Safari and to become ready to remove
unintentional dependency on it from several tests.

Some HTTP tests submit a GET form to about:blank
https://bugs.webkit.org/show_bug.cgi?id=30423

  • fast/forms/get-forms-to-about-blank-expected.txt: Added.
  • fast/forms/get-forms-to-about-blank.html: Added.
00:41 Changeset [51068] by oliver@apple.com

Incorrect use of JavaScriptCore API in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=31577

Reviewed by Maciej Stachowiak

Return undefined rather than a literal null.

11/16/09:

23:16 Changeset [51067] by zoltan@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=31050

Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2009-11-16
Reviewed by Gavin Barraclough.

Minor fixes for JSVALUE32_64: branchConvertDoubleToInt32
failed on a CortexA8 CPU, but not on a simulator; and
JITCall.cpp modifications was somehow not committed to mainline.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::fmrs_r):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

22:31 Changeset [51066] by tkent@chromium.org

2009-11-16 Kent Tamura <tkent@chromium.org>

Unreviewd build fix.

  • Fix typo in WebCore.vcproj.
  • Intlude limits.h for INT_MAX.
  • Enclose with parenthesis to suspress warning.
  • WebCore.vcproj/WebCore.vcproj:
  • html/ISODateTime.cpp: (WebCore::ISODateTime::addDay):
21:50 Changeset [51065] by kevino@webkit.org

Reviewed by Kevin Ollivier.

Make sure wx scrollbar drawing code factors in transforms when switching backends,
fix calcs for scrollbar length, and tweak the Mac scrollbar tracking rects.

https://bugs.webkit.org/show_bug.cgi?id=31570

21:39 Changeset [51064] by girish@forwardbias.in

Add myself to commiters.py

21:13 Changeset [51063] by tkent@chromium.org

2009-11-16 Kent Tamura <tkent@chromium.org>

Reviewed by David Levin.

Introduce WebCore::ISODateTime class.
https://bugs.webkit.org/show_bug.cgi?id=31340

This class represents a value of date/time types of the HTML5 INPUT
element, and has some parsing methods for ISO 8601.

This change has no tests because the class is not used yet.

  • GNUmakefile.am: Add ISODateTime.cpp and ISODateTime.h.
  • WebCore.gypi: ditto.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • WebCoreSources.bkl: ditto.
  • html/ISODateTime.cpp: Added. Implementation of WebCore::ISODateTime class. (WebCore::isLeapYear): (WebCore::maxDayOfMonth): (WebCore::dayOfWeek): (WebCore::ISODateTime::maxWeekNumberInYear): (WebCore::countDigits): (WebCore::toInt): (WebCore::ISODateTime::parseYear): Private helper for parseDate() and parseWeek(). (WebCore::ISODateTime::addDay): Private helper for parseTimeZone(). (WebCore::ISODateTime::addMinute): ditto. (WebCore::ISODateTime::parseTimeZone): Private helper for parseDateTime(). (WebCore::ISODateTime::parseMonth): Parser for <input type=month>. (WebCore::ISODateTime::parseDate): Parser for <input type=date>. (WebCore::ISODateTime::parseWeek): Parser for <input type=week>. (WebCore::ISODateTime::parseTime): Parser for <input type=time>. (WebCore::ISODateTime::parseDateTimeLocal): Parser for <input type=datetime-local>. (WebCore::ISODateTime::parseDateTime): Parser for <input type=datetime>.
  • html/ISODateTime.h: Added. Declare WebCore::ISODateTime class. (WebCore::ISODateTime::ISODateTime): (WebCore::ISODateTime::millisecond): (WebCore::ISODateTime::second): (WebCore::ISODateTime::minute): (WebCore::ISODateTime::hour): (WebCore::ISODateTime::monthDay): (WebCore::ISODateTime::month): (WebCore::ISODateTime::fullYear): (WebCore::ISODateTime::week):
19:05 BuildingQtOnLinux edited by dbates@webkit.org
Added missing "libsqlite3-dev" dependency for Ubuntu (diff)
16:09 Changeset [51062] by ap@apple.com

Fix a typo in previous commit.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: #ifdef, not #if.
16:04 Changeset [51061] by ap@apple.com

Fix a typo in previous commit.

  • platform/network/cf/SocketStreamHandleCFNet.cpp:
15:57 Changeset [51060] by ap@apple.com

Tiger build fix.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: Define CFN_EXPORT, as this macro was named differently in Tiger CFNetwork.
15:32 Changeset [51059] by ap@apple.com

Disabling WebSocket tests on Tiger and Windows again, as they still time out.

  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
15:08 Changeset [51058] by dglazkov@chromium.org

2009-11-16 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

[KURLGoogle] setHostAndPort doesn't handle arguments without port correctly.

Fix a bug in the code that was dormant until http://trac.webkit.org/changeset/50784.

Covered by existing test: LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host.html

  • platform/KURLGoogle.cpp: (WebCore::KURL::setHostAndPort): Added handling of arguments without port specified.
14:58 Changeset [51057] by ap@apple.com

Rubber-stamped by Jon Honeycutt.

A better Windows build fix

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams): Use a macro that inserts declspec(dllimport) when appropriate for CFNetwork imports.
14:57 Changeset [51056] by yael.aharon@nokia.com

Rename protocolIsValid to isValidProtocol.
https://bugs.webkit.org/show_bug.cgi?id=31503

Reviewed by Darin Adler.

This name change was suggested in https://bugs.webkit.org/show_bug.cgi?id=29972#c19.

No new tests since no new functionality was introduced.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::setProtocol):

  • platform/KURL.cpp:

(WebCore::isValidProtocol):

  • platform/KURL.h:
  • platform/KURLGoogle.cpp:

(WebCore::isValidProtocol):

14:41 Changeset [51055] by cfleizach@apple.com

AX: aria-labelledby duplicates some of its WAI-ARIA label
https://bugs.webkit.org/show_bug.cgi?id=31565

Reviewed by Beth Dakin.

WebCore:

Test: accessibility/aria-labelledby-overrides-label.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::hasTextAlternative):
(WebCore::AccessibilityRenderObject::exposesTitleUIElement):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

  • accessibility/AccessibilityRenderObject.h:

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(titleUIElementCallback):
(getIsValidCallback):
(AccessibilityUIElement::getJSClass):

LayoutTests:

  • accessibility/aria-labelledby-overrides-label-expected.txt: Added.
  • accessibility/aria-labelledby-overrides-label.html: Added.
  • platform/gtk/Skipped:
  • platform/win/Skipped:
14:40 Changeset [51054] by japhet@chromium.org

2009-11-16 Nate Chapin <japhet@chromium.org>

Reviewed by Darin Fisher.

Handle the case of a null NPObject* in NPN_SetException in
the V8 bindings. This allow out of process plugins calling
NPN_SetException to just send null instead of sending an
NPObject* that would be an address in a different
process's memory space.

https://bugs.webkit.org/show_bug.cgi?id=31561

  • bindings/v8/NPV8Object.cpp: (_NPN_SetException): Allow null NPObject* and just throw a general error.
14:30 Changeset [51053] by ap@apple.com

Windows build fix.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams): Disable CONNECT proxies on Windows until WebKitSupportLibrary includes support for those.
14:21 Changeset [51052] by yael.aharon@nokia.com

[Qt] ASSERT failure while running DRT
https://bugs.webkit.org/show_bug.cgi?id=30978

Reviewed by Kenneth Rohde Christiansen.

Add needed Structure typeInfo flags to QtRuntimeObjectImpl and QtRuntimeMethod.
These flags are needed after r49649, where HasDefaultmark was changed to OverrideMarkChildren.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObjectImp::createStructure):

  • bridge/qt/qt_runtime.h:

(JSC::Bindings::QtRuntimeMethod::createStructure):

13:51 Changeset [51051] by mrowe@apple.com

Attempt to fix the build. Land a file that was missing from r51049.

  • bindings/js/JSWebGLArrayHelper.h: Copied from WebCore/html/canvas/WebGLByteArray.idl.

(WebCore::setWebGLArrayFromArray):

13:31 Changeset [51050] by kenneth@webkit.org

r50942 broke output from created windows. Make the
m_enableTextOutput a member of the DRT and not the
WebPage.

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::WebPage):
(WebCore::WebPage::javaScriptAlert):
(WebCore::WebPage::javaScriptConsoleMessage):
(WebCore::WebPage::javaScriptConfirm):
(WebCore::WebPage::javaScriptPrompt):
(WebCore::WebPage::acceptNavigationRequest):
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::createWindow):

  • DumpRenderTree/qt/DumpRenderTree.h:

(WebCore::DumpRenderTree::setTextOutputEnabled):
(WebCore::DumpRenderTree::isTextOutputEnabled):
(WebCore::WebPage::shouldInterruptJavaScript):
(WebCore::WebPage::isTextOutputEnabled):
(WebCore::WebPage::setViewGeometry):

13:30 Changeset [51049] by cmarrin@apple.com

Update API of WebGLArray and friends
https://bugs.webkit.org/show_bug.cgi?id=31175

13:28 Changeset [51048] by ap@apple.com

Windows build fix.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: Declare constants as extern "C".
13:28 Changeset [51047] by hausmann@webkit.org

API documentation fixes.

Reviewed by Kenneth Rohde Christiansen.

  • Api/qgraphicswebview.cpp: Removed duplicate docs.
  • Api/qwebelement.cpp: Added missing docs.
  • Api/qwebsettings.cpp: Ditto.
13:01 Changeset [51046] by bfulgham@webkit.org

Enable support for webkit-box-shadow in Cairo builds.
https://bugs.webkit.org/show_bug.cgi?id=26102.

Reviewed by Oliver Hunt.

Covered by existing fast/box-shadow tests.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: Add support for fillRect shadows.
12:36 Changeset [51045] by ap@apple.com

Windows build fix.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: Don't try to include a file that's not in WebKitSupportLibrary.
12:05 Changeset [51044] by kenneth@webkit.org

Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
as the implementation is being used by at least Qt and Gtk+.

Reviewed by Gustavo Noronha Silva.

Update buildsystems as well.

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
  • DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
  • DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
  • GNUmakefile.am:
11:08 Changeset [51043] by weinig@apple.com

Update Security Group Members list.

Reviewed by Anders Carlsson.

  • security/security-group-members.html:
10:58 Changeset [51042] by weinig@apple.com

Update Security Group Members list.

Reviewed by Adele Peterson.

  • security/security-group-members.html:
10:40 Changeset [51041] by ap@apple.com

WebKitTools:
2009-11-16 Yuzo Fujishima <yuzo@google.com>

Reviewed by Alexey Proskuryakov.

Disable wss until all platforms support pyOpenSSL

https://bugs.webkit.org/show_bug.cgi?id=31479

  • Scripts/run-webkit-tests:

LayoutTests:

Re-enabling WebSocket tests on Tiger and Windows, now that SSL is disabled.

  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
09:59 Changeset [51040] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=31494
Add unauthenticated proxy support to SocketStreamHandleCFNet

Cannot be tested in DRT.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::chooseProxy): Fetch proxy information from OS. (WebCore::SocketStreamHandle::createStreams): Apply it to the newly created streams.
08:54 WebKit Team edited by keishi@webkit.org
(diff)
08:51 Changeset [51039] by keishi@webkit.org

Adding myself to committers.py.

07:38 Changeset [51038] by tonikitoo@webkit.org

[Qt] Broken back/forward after using ErrorPageExtension to set error page
https://bugs.webkit.org/show_bug.cgi?id=30573

Reviewed by Antti Koivisto.

WebCore:

Make FrameLoader::checkLoadCompleteForThisFrame method
to check for any working DocumentLoader instance (through
activeDocumentLoader()) instead of only checking for
'm_provisionalDocumentLoader' in order to decide to if
it is going to reset of not the back and forward history.
after an error page has been loaded.

Test: LayoutTests/fast/history/back-forward-reset-after-error-handling.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

WebKit/qt:

Implemented autotests for covering the back/forward
reset problem involving error pages.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::errorPageExtension):

LayoutTests:

Skipped fast/history/back-forward-reset-after-error-handling.html
in mac, gtk and win DRT, because their DRT do not support yet
error pages handling.

  • fast/history/back-forward-reset-after-error-handling.html:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
07:37 Changeset [51037] by tonikitoo@webkit.org

[Qt] Implement load error pages support for Qt's DRT.
https://bugs.webkit.org/show_bug.cgi?id=31509

Reviewed by Kenneth Christiansen.

For now, it will not be a default feature, and layout tests
that want to make use of this have to explicitily call
'handleErrorPages();' for the test source.

Any of the other DumpRenderTree's (mac, win and gtk)
support handling error pages. Qt's will be the first.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::supportsExtension):
(WebCore::WebPage::extension):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::reset):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController::shouldHandleErrorPages):
(LayoutTestController::handleErrorPages):

07:05 QtWebKitContrib edited by hausmann@webkit.org
(diff)
06:59 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:58 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:30 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:26 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:24 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:18 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:12 QtWebKit edited by kenneth@webkit.org
(diff)
06:06 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:05 QtWebKit edited by kenneth@webkit.org
(diff)
06:04 QtWebKit edited by hausmann@webkit.org
(diff)
05:59 QtWebKitJournal edited by hausmann@webkit.org
(diff)
05:47 Changeset [51036] by eric@webkit.org

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
https://bugs.webkit.org/show_bug.cgi?id=31549

Renamed --commit-queue to --non-interactive in most places
and remove the code in land-patches which is no longer needed.

  • Scripts/bugzilla-tool:
05:43 Changeset [51035] by kenneth@webkit.org

Rubberstamped by Simon Hausmann.

Added new Qt expected results for animation tests.

  • platform/qt/animations/change-transform-in-end-event-expected.txt: Added.
  • platform/qt/animations/state-at-end-event-expected.txt: Added.
  • platform/qt/animations/state-at-end-event-transform-expected.txt: Added.
05:34 Changeset [51034] by eric@webkit.org

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

The commit-queue should use land-attachment
https://bugs.webkit.org/show_bug.cgi?id=31548

  • Scripts/bugzilla-tool:
05:25 Changeset [51033] by eric@webkit.org

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Convert CommitQueue over to PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31547

Also fixes a bug in workqueue and adds a test!

  • Scripts/bugzilla-tool:
  • Scripts/modules/workqueue.py:
  • Scripts/modules/workqueue_unittest.py:
05:20 Changeset [51032] by hausmann@webkit.org

Fix Qt build on Windows CE 6.

Patch by Joerg Bornemann <joerg.bornemann@trolltech.com> on 2009-11-16
Reviewed by Simon Hausmann.

  • JavaScriptCore.pri: Add missing include path.
  • wtf/Platform.h: Include ce_time.h for Windows CE 6.
05:05 Changeset [51031] by abarth@webkit.org

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Convert CommitQueue over to PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31547

Also fixes a bug in workqueue and adds a test!

  • Scripts/bugzilla-tool:
  • Scripts/modules/workqueue.py:
  • Scripts/modules/workqueue_unittest.py:
04:29 Changeset [51030] by abarth@webkit.org

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move StyleQueue over to using PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31544

That's what the class it's for.

  • Scripts/bugzilla-tool:
  • Scripts/modules/patchcollection.py:
  • Scripts/modules/patchcollection_unittest.py:
04:11 Changeset [51029] by eric@webkit.org

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
https://bugs.webkit.org/show_bug.cgi?id=31543

Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.

  • Scripts/bugzilla-tool:
04:04 Changeset [51028] by eric@webkit.org

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Disable the style queue from posting to the commit queue status page.

  • Scripts/bugzilla-tool:
03:54 Changeset [51027] by eric@webkit.org

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31541

This class holds a set of patches and lets clients iterate through
them. Optionally, clients can install a filter.

  • Scripts/modules/patchcollection.py: Added.
  • Scripts/modules/patchcollection_unittest.py: Added.
  • Scripts/run-webkit-unittests:
03:47 Changeset [51026] by abarth@webkit.org

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31541

This class holds a set of patches and lets clients iterate through
them. Optionally, clients can install a filter.

  • Scripts/modules/patchcollection.py: Added.
  • Scripts/modules/patchcollection_unittest.py: Added.
  • Scripts/run-webkit-unittests:
03:31 Changeset [51025] by eric@webkit.org

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool check-style should work with attachment ids instead of bug ids
https://bugs.webkit.org/show_bug.cgi?id=31540

  • Scripts/bugzilla-tool:
03:04 Changeset [51024] by eric@webkit.org

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

WorkQueue is the only place that should know about special exit codes
https://bugs.webkit.org/show_bug.cgi?id=31534

Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
and add tests for handling exit codes.
I also cleaned up workqueue_unittest.py more.

  • Scripts/bugzilla-tool:
  • Scripts/modules/workqueue.py:
  • Scripts/modules/workqueue_unittest.py:
03:02 Changeset [51023] by eric@webkit.org

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Re-factor workqueue_unittest to allow for more than one test.
https://bugs.webkit.org/show_bug.cgi?id=31535

  • Scripts/modules/workqueue_unittest.py:
03:00 Changeset [51022] by eric@webkit.org

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

land-patches needs to be re-factored into smaller chunks
https://bugs.webkit.org/show_bug.cgi?id=31532

  • Scripts/bugzilla-tool: fix a couple obvious typos.
02:50 Changeset [51021] by eric@webkit.org

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

land-patches needs to be re-factored into smaller chunks
https://bugs.webkit.org/show_bug.cgi?id=31532

The next patch will move these methods into WebKitLandingScripts.

  • Scripts/bugzilla-tool:
    • Split out _land_patch and _close_bug_if_no_active_patches.
02:45 Changeset [51020] by abarth@webkit.org

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix silly copy-and-paste code. I am a terrible coder.

  • Scripts/modules/bugzilla.py:
02:34 Changeset [51019] by abarth@webkit.org

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement a StyleQueue
https://bugs.webkit.org/show_bug.cgi?id=31537

The first iteration of the style queue only produces output locally.
There is also a limit of 10 patches because it's not that useful to
iterate through the entire review queue at this point. We can remove
the limit later.

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
01:25 Changeset [51018] by abarth@webkit.org

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Unit test WorkQueue
https://bugs.webkit.org/show_bug.cgi?id=31531

Adds basic unit testing for WorkQueue. Just runs through one cycle.

  • Scripts/bugzilla-tool:
  • Scripts/modules/statusbot.py:
  • Scripts/modules/workqueue.py:
  • Scripts/modules/workqueue_unittest.py: Added.
  • Scripts/run-webkit-unittests:
00:49 Changeset [51017] by eric@webkit.org

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=31530

  • Scripts/bugzilla-tool:
00:39 Changeset [51016] by eric@webkit.org

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool needs apply-attachment
https://bugs.webkit.org/show_bug.cgi?id=31528

  • Scripts/bugzilla-tool:
    • Add ApplyAttachment command.
    • Abstract applying code into WebKitApplyingScripts.
    • Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
  • Scripts/modules/bugzilla.py:
    • Add fetch_attachment and bug_id_for_attachment_id.
  • Scripts/modules/bugzilla_unittest.py:
    • Add test for new parsing.
    • Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
00:38 Changeset [51015] by eric@webkit.org

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Document check-style's use of force_clean.

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
00:28 Changeset [51014] by abarth@webkit.org

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move WorkQueue to its own file
https://bugs.webkit.org/show_bug.cgi?id=31529

WorkQueue and WorkQueueDelegate are separate concerns from
bugzilla-tool. Also added a missing include to logging.py.

  • Scripts/bugzilla-tool:
  • Scripts/modules/logging.py:
  • Scripts/modules/workqueue.py:
00:11 Changeset [51013] by abarth@webkit.org

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Siedel.

Move OutputTee to logging.py.

  • Scripts/bugzilla-tool:
  • Scripts/modules/logging.py:
00:07 Changeset [51012] by abarth@webkit.org

2009-11-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Refactor bugzilla-tool to allow for multiple queues
https://bugs.webkit.org/show_bug.cgi?id=31513

Divide the commit queue class into three class to make creating
additional queues easier.

  • Scripts/bugzilla-tool:

11/15/09:

22:19 Changeset [51011] by cfleizach@apple.com

Fixing broken layout test.

Need to implement ARIA role="directory"
https://bugs.webkit.org/show_bug.cgi?id=31516

Lists are not supported on Leopard or Tiger, so the test for this
bug needs to be skipped.

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
22:02 Changeset [51010] by hamaji@chromium.org

2009-11-15 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

svn-apply may not handle git patches created by bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=31457

  • Scripts/modules/scm.py:
  • Scripts/modules/scm_unittest.py:
20:44 Changeset [51009] by dglazkov@chromium.org

2009-11-15 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

Correct an error in the previous commit

  • public/WebAccessibilityRole.h: It should be WebAccessibilityRoleDirectory, not WebAccessibilityDirectoryRole.
19:48 Changeset [51008] by dglazkov@chromium.org

2009-11-15 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

Bring WebAccessibilityRole up to sync after
http://trac.webkit.org/changeset/51007.

  • public/WebAccessibilityRole.h: Added WebAccessibilityRoleDirectory.
  • src/AssertMatchingEnums.cpp: Added a match between DirectoryRole and WebAccessibilityRoleDirectory.
18:05 Changeset [51007] by cfleizach@apple.com

Need to implement ARIA role="directory"
https://bugs.webkit.org/show_bug.cgi?id=31516

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/aria-directory.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::isOrderedList):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::createARIARoleMap):

WebKit/mac:

Fix a spelling error in the comment of a localized (accessibility) string.

  • WebCoreSupport/WebViewFactory.mm:

(-[WebViewFactory AXARIAContentGroupText:]):

LayoutTests:

  • platform/mac/accessibility/aria-directory-expected.txt: Added.
  • platform/mac/accessibility/aria-directory.html: Added.
15:34 Changeset [51006] by abarth@webkit.org

2009-11-15 Dave Tapuska <dtapuska@rim.com>

Reviewed by George Staikos.


Compare UChars single unit at a time as opposed to the uint32_t
approach as casting to unaligned addresses may cause a bus failure
on ARMv5 and below. This change replicates the same defines that
exists in AtomicString.cpp

https://bugs.webkit.org/show_bug.cgi?id=31475


  • platform/text/StringHash.h: (WebCore::StringHash::equal):
15:32 Changeset [51005] by abarth@webkit.org

2009-11-15 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

bugzilla-tool should post git binary diff
https://bugs.webkit.org/show_bug.cgi?id=31458

Add --binary option to Git.create_patch.

  • Scripts/modules/scm.py:
  • Scripts/modules/scm_unittest.py:
15:29 Changeset [51004] by abarth@webkit.org

2009-11-15 Evan Martin <evan@chromium.org>

Reviewed by Adam Barth.

Wrap some SVG code in V8DOMWrapper with an ENABLE(SVG) test.

https://bugs.webkit.org/show_bug.cgi?id=31490

  • bindings/v8/V8DOMWrapper.cpp:
15:28 Changeset [51003] by abarth@webkit.org

2009-11-15 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Adam Barth.

[Haiku] Build fix. The FileChooser constructor doesn't need to be redefined.

  • platform/haiku/FileChooserHaiku.cpp:
15:26 Changeset [51002] by abarth@webkit.org

2009-11-15 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Adam Barth.

[Haiku] Build fix. ColorSpace name had a wrong CamelCase.

  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformStrokeColor):
15:24 Changeset [51001] by abarth@webkit.org

2009-11-15 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Add bugzilla-tool check-style
https://bugs.webkit.org/show_bug.cgi?id=31515

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
15:15 Changeset [51000] by dbates@webkit.org

2009-11-15 Daniel Bates <dbates@webkit.org>

No review, rolling out r50999.
http://trac.webkit.org/changeset/50999

Need to fix some issues in the Windows build. Missed some places where
RenderTextControl::isEdited is called.

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::setUserEdited): (WebCore::RenderTextControl::subtreeHasChanged):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::isEdited): (WebCore::RenderTextControl::setEdited): (WebCore::RenderTextControl::isUserEdited):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
14:55 Changeset [50999] by dbates@webkit.org

2009-11-15 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=31186

Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
These are more descriptive names so as to clear an ambiguity surrounding
their usage. Also, renames associated setters and getters so that they
coincide with the renamed fields.

No functionality was changed. So, no tests were included.

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited. (WebCore::RenderTextControl::subtreeHasChanged):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited. (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited. (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):

11/14/09:

12:55 Changeset [50998] by adele@apple.com

WebCore: Fix for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp

Reviewed by Dan Bernstein.

Test: fast/overflow/line-clamp.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to handle different types of values.
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):

Use the line count value if available. Otherwise, convert the percentage to the line count, as we did before. Also,
if there is anchor as the last child box, still allow adding the ellipsis.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollByRecursively): Call isNone on the LineClampValue to see if the line-clamp property has been set.
(WebCore::RenderLayer::scrollRectToVisible): ditto.

  • WebCore.xcodeproj/project.pbxproj: Added LineClampValue.h
  • rendering/style/LineClampValue.h: Added.

(WebCore::LineClampValue::LineClampValue):
(WebCore::LineClampValue::value):
(WebCore::LineClampValue::isPercentage):
(WebCore::LineClampValue::isNone):
(WebCore::LineClampValue::operator==):
(WebCore::LineClampValue::operator!=):

  • rendering/style/RenderStyleConstants.h: (WebCore::): Define ELineClampType enum for percentage or line count.
  • rendering/style/RenderStyle.h: Use LineClampValue.

(WebCore::InheritedFlags::lineClamp):
(WebCore::InheritedFlags::setLineClamp):
(WebCore::InheritedFlags::initialLineClamp):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests: Test for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp

Reviewed by Dan Bernstein.

  • fast/overflow/line-clamp.html: Added.
  • platform/mac/fast/overflow/line-clamp-expected.checksum: Added.
  • platform/mac/fast/overflow/line-clamp-expected.png: Added.
  • platform/mac/fast/overflow/line-clamp-expected.txt: Added.
12:24 QtBackLog edited by zecke@selfish.org
Mention individual commits (diff)
09:53 Changeset [50997] by eric.carlson@apple.com

2009-11-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/7287487>
Do not use QuickTime version to detect media controller theme

  • WebCore.base.exp: Export wkMediaControllerThemeAvailable
  • platform/mac/WebCoreSystemInterface.h: Ditto.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme): Use wkMediaControllerThemeAvailable instead of the QuickTime version to see if it is possible to use MediaControllerThemeQuickTime.

2009-11-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/7287487>
Do not use QuickTime version to detect media controller theme

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize wkMediaControllerThemeAvailable.
07:21 Changeset [50996] by tkent@chromium.org

2009-11-14 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Add tests for reading/writing .type property of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=29004

  • fast/forms/input-type-change3-expected.txt: Added.
  • fast/forms/input-type-change3.html: Added.
  • fast/forms/script-tests/input-type-change3.js: Added.

2009-11-14 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

  • Recognizes date/datetime/datetime-local/month/time/week types of INPUT element. They have no dedicated UI and no type validation for now.
  • Clean up setInputType() and formControlType() of HTMLInputElement. https://bugs.webkit.org/show_bug.cgi?id=29004

Test: fast/forms/input-type-change3.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueMissing): (WebCore::HTMLInputElement::patternMismatch): (WebCore::HTMLInputElement::tooLong): (WebCore::createTypeMap): Initializer for a static local variable. (WebCore::HTMLInputElement::setInputType): (WebCore::createFormControlTypes): Initializer for a static local variable. (WebCore::HTMLInputElement::formControlType): (WebCore::HTMLInputElement::saveFormControlState): (WebCore::HTMLInputElement::restoreFormControlState): (WebCore::HTMLInputElement::accessKeyAction): (WebCore::HTMLInputElement::rendererIsNeeded): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::appendFormData): (WebCore::HTMLInputElement::isTextField): (WebCore::HTMLInputElement::valueWithDefault): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::isRequiredFormControl): (WebCore::HTMLInputElement::dataList):
  • html/HTMLInputElement.h: Add new values to InputType enum, and define numberOfTypes.
06:08 Changeset [50995] by kov@webkit.org

Skip new test that needs new DRT infrastructure, with bug filled.

Note: See TracTimeline for information about the timeline view.