Timeline


and

11/25/09:

22:16 Changeset [51406] by eric@webkit.org

2009-11-25 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

Update pywebsocket to 0.4.2

Update pywebsocket to 0.4.2
https://bugs.webkit.org/show_bug.cgi?id=31861

  • pywebsocket/example/echo_client.py:
  • pywebsocket/example/echo_wsh.py:
  • pywebsocket/mod_pywebsocket/init.py:
  • pywebsocket/mod_pywebsocket/dispatch.py:
  • pywebsocket/mod_pywebsocket/msgutil.py:
  • pywebsocket/mod_pywebsocket/standalone.py:
  • pywebsocket/setup.py:
  • pywebsocket/test/test_dispatch.py:
  • pywebsocket/test/test_msgutil.py:
19:02 Changeset [51405] by abarth@webkit.org

2009-11-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add unit test for mark-fixed
https://bugs.webkit.org/show_bug.cgi?id=31896

  • Scripts/modules/commands/commandtest.py: Added.
  • Scripts/modules/commands/queries_unittest.py:
  • Scripts/modules/commands/upload_unittest.py: Added.
  • Scripts/modules/mock_bugzillatool.py:
  • Scripts/run-webkit-unittests:
18:25 Changeset [51404] by abarth@webkit.org

2009-11-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool should have a mark-fixed command
https://bugs.webkit.org/show_bug.cgi?id=31853

Pretty simple stuff.

  • Scripts/modules/commands/upload.py:
18:22 Changeset [51403] by eric@webkit.org

2009-11-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

'bugzilla-tool help' should only show common commands like how 'git help' does
https://bugs.webkit.org/show_bug.cgi?id=31772

I also took this opportunity to make 'help' a real Command.
Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).

  • Scripts/bugzilla-tool:
    • change should_show_command_help to should_show_in_main_help
  • Scripts/modules/commands/download.py:
    • Mark commands as being shown in main help or not.
    • show_in_main_help = False is not required (default is false), but it seemed to make the commands more self-documenting.
  • Scripts/modules/commands/queries.py: ditto
  • Scripts/modules/commands/queues.py: ditto
  • Scripts/modules/commands/upload.py: ditto
  • Scripts/modules/multicommandtool.py:
    • Make Command hold a pointer to tool in self.tool. Most Command subclasses do not take advantage of this yet, but it was required for HelpCommand to be able to reach the tool from _help_epilog().
    • Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
    • Move MultiCommandTool._help_epilog to Command._help_epilog
    • Move "help" logic into HelpCommand.execute()
    • Change should_show_command_help to should_show_in_main_help and add a default implementation.
  • Scripts/modules/multicommandtool_unittest.py:
    • Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
16:57 Changeset [51402] by dglazkov@chromium.org

WebCore:

2009-11-25 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by David Levin.

[Chromium] Implement canSetValueAttribute in the API, the clean-up part.
https://bugs.webkit.org/show_bug.cgi?id=31894

  • accessibility/chromium/AccessibilityObjectWrapper.h: Added RefCounted decl. (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Removed mis-refcountingness.

WebKit/chromium:

2009-11-25 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by David Levin.

[Chromium] Implement canSetValueAttribute in the API.
https://bugs.webkit.org/show_bug.cgi?id=31894

  • public/WebAccessibilityObject.h: Added decl.
  • src/WebAccessibilityCacheImpl.h: Cleaned up mis-include.
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::canSetValueAttribute): Added impl.
16:51 Changeset [51401] by ossy@webkit.org

[Qt] Audio related layout tests are failing on the buildbot
https://bugs.webkit.org/show_bug.cgi?id=27910

  • platform/qt/Skipped: fast/js/global-constructors.html added.
16:44 Changeset [51400] by eric@webkit.org

2009-11-25 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Off-by-one error in index validation for drawElements and drawArrays
https://bugs.webkit.org/show_bug.cgi?id=31891

Fixed computation of number of elements for bound array objects.

Test: fast/canvas/webgl/index-validation.html

  • fast/canvas/webgl/index-validation-expected.txt: Added.
  • fast/canvas/webgl/index-validation.html: Added.
  • fast/canvas/webgl/script-tests/index-validation.js: Added.

2009-11-25 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Off-by-one error in index validation for drawElements and drawArrays
https://bugs.webkit.org/show_bug.cgi?id=31891

Fixed computation of number of elements for bound array objects.

Test: fast/canvas/webgl/index-validation.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::vertexAttribPointer):
16:41 Changeset [51399] by bweinstein@apple.com

Patch by Mark Rowe.

Reviewed by Dan Bernstein.

The buildbots are failing on Windows because when they were upgraded
to 4.0.4, Apple Application Support was not in their path. Add it to
the path to fix the buildots.

  • Scripts/webkitdirs.pm:
16:29 Changeset [51398] by ossy@webkit.org

[Qt] Remove a bunch of now passing fast tests from skiplist.
And add a crasher/crashed pair into skiplist.

  • platform/qt/Skipped:
15:44 Changeset [51397] by dimich@chromium.org

Update SharedScript to use eventNames() instead of EventNames()
https://bugs.webkit.org/show_bug.cgi?id=31890

Reviewed by David Levin.

  • SharedScript/WebKitSharedScript.cpp:

(WebCore::LoadEventTask::performTask):

15:29 Changeset [51396] by ossy@webkit.org

[Qt] Put tests into skiplist because of missing layoutTestController feature.

  • platform/qt/Skipped:
  • http/tests/cache/subresource-failover-to-network.html added.
  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html added.
  • "3D_RENDERING and ACCELERATED_COMPOSITING" block moved to good place.
14:26 Changeset [51395] by ossy@webkit.org

run-webkit-tests doesn't accept directories/files with --skipped=only parameter
https://bugs.webkit.org/show_bug.cgi?id=31799

Reviewed by David Kilzer.

  • Scripts/run-webkit-tests: Fixed.
13:09 Changeset [51394] by darin@chromium.org

2009-11-25 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Unable to repost form data by hitting reload
https://bugs.webkit.org/show_bug.cgi?id=31882

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadData):
13:08 Changeset [51393] by eric.carlson@apple.com

2009-11-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7409331> Windows: Support closed caption in <video> element

Enable closed captions in QuickTime/Windows media engine.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::hasClosedCaptions): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):

New, all through to m_qtMovie.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:

Make all but the destructor private since MediaPlayer call through the media
engine interface.

  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::disableUnsupportedTracks):

Use handy new constants for QuickTime track types.

(QTMovieWin::hasClosedCaptions):
(QTMovieWin::setClosedCaptionsVisible):

New, closed caption support.

  • platform/graphics/win/QTMovieWin.h:
  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart):

Deal with closed caption buttons.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::shouldRenderMediaControlPart):

New, don't ask the media engine if it has closed captions unless the Safari theme will
be able to render the button.

(WebCore::RenderThemeWin::paintMediaToggleClosedCaptionsButton):

New.

  • rendering/RenderThemeWin.h:

2009-11-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7409331> Windows: Support closed caption in <video> element

  • platform/win/Skipped:

Enable the closed caption test.

12:04 Changeset [51392] by eric@webkit.org

2009-11-25 Drew Wilson <atwilson@chromium.org>

Reviewed by David Levin.

MessagePorts always look remotely entangled even when closed.
https://bugs.webkit.org/show_bug.cgi?id=31698

Tests: Existing tests suffice, Chromium soak test passes now.

  • bindings/v8/custom/V8CustomBinding.h: Removed kMessagePortEntangledPortIndex which is no longer used.
  • bindings/v8/V8GCController.cpp: (WebCore::GCPrologueVisitor::visitDOMWrapper): Simplified GC code to reflect the Chromium MessagePort implementation (locallyEntangledPort() always returns false). (WebCore::GCEpilogueVisitor::visitDOMWrapper): Cleaned up epilogue code to handle the case where the port gets closed in mid-GC (due to the parent context being freed).
  • dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::close): Now sets the closed flag. (WebCore::MessagePort::disentanglePorts): Updated to use new isCloned() API instead of relying on isEntangled(), which was incorrect.
  • dom/MessagePort.h: Added a m_closed flag and updated isEntangled() to check it. (WebCore::MessagePort::isEntangled): Now returns false if the port has been closed. (WebCore::MessagePort::isCloned): Added new API to differentiate between cloned and closed ports (closed ports can still be passed to postMessage).
12:02 Changeset [51391] by zoltan@webkit.org

2009-11-25 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

Change run_command to give back stderr by default
https://bugs.webkit.org/show_bug.cgi?id=31734

Change run_command to give back stderr by default.
Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
Change the related unittest call.

  • Scripts/modules/scm.py:
  • Scripts/modules/scm_unittest.py:
10:22 Changeset [51390] by kov@webkit.org

Skip test that needs structure we do not provide yet

10:03 Changeset [51389] by dglazkov@chromium.org

2009-11-25 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Plumb setNeedsSiteSpecificQuirks throught WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=31878

  • public/WebSettings.h: Added decl.
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setNeedsSiteSpecificQuirks): Added impl.
  • src/WebSettingsImpl.h:
09:12 Changeset [51388] by hausmann@webkit.org

[Qt] Fix crash of QtWebKit on any page with Flash when compiled with MinGW.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-11-25
Reviewed by Simon Hausmann.

Fix inline assembly, don't dereference the function pointer twice.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::hookedBeginPaint):
(WebCore::PluginView::hookedEndPaint):

09:02 Changeset [51387] by hausmann@webkit.org

[Qt] Remove the Referer header when redirecting to a non-secure site
https://bugs.webkit.org/show_bug.cgi?id=31785

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-11-22
Reviewed by Adam Barth.

This makes Qt pass two tests introduced in r50226.

WebCore:

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

LayoutTests:

  • platform/qt/Skipped:
08:50 Changeset [51386] by benm@google.com

The select elements do not reflect the actual choice the user makes.
https://bugs.webkit.org/show_bug.cgi?id=31831

Patch by Andrei Popescu <andreip@google.com> on 2009-11-25
Reviewed by Dimitri Glazkov.

Handle the drawing of the listboxes in Android code.

No new features, just fixing an Android problem. Existing layout tests are sufficient.

  • platform/android/RenderThemeAndroid.cpp:

(WebCore::theme):
(WebCore::RenderThemeAndroid::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeAndroid::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeAndroid::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeAndroid::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeAndroid::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeAndroid::adjustButtonStyle):
(WebCore::RenderThemeAndroid::paintTextArea):
(WebCore::RenderThemeAndroid::adjustListboxStyle):

  • platform/android/RenderThemeAndroid.h:
08:15 Changeset [51385] by eric@webkit.org

2009-11-25 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Load InspectorResource mime type from CachedResource for 304 responses

For network libraries that do not merge cache data into 304 ResourceResponses,
the mime type for cached resources is unknown.
https://bugs.webkit.org/show_bug.cgi?id=31868

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateResponse): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::type):
08:06 Changeset [51384] by eric@webkit.org

2009-11-25 Andrei Popescu <andreip@google.com>

Reviewed by Eric Seidel.

Android is missing implementation of SSL Key generator functions.
https://bugs.webkit.org/show_bug.cgi?id=31825

This change adds the PlatformBridge class to platform/android.
PlarformBridge is used to access the embedding layer for things
such as key generator, cookies, plugins, etc.

No new tests required, this is platform code.

  • platform/android/PlatformBridge.h: Added.
  • platform/android/SSLKeyGeneratorAndroid.cpp: Added. (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
08:05 Changeset [51383] by eric@webkit.org

2009-11-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Centralize required argument parsing in Command
https://bugs.webkit.org/show_bug.cgi?id=31872

  • Scripts/modules/commands/download.py: remove custom required arg message.
  • Scripts/modules/commands/upload.py: ditto.
  • Scripts/modules/multicommandtool.py:
    • Add _parse_required_arguments.
    • Pass program name off to OptionParser.
    • Add name() for access to tool name.
    • Add check_arguments_and_execute and make it return a return code.
    • Replace a couple uses of + with %.
  • Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
07:59 Changeset [51382] by eric@webkit.org

2009-11-25 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GTK] use gst_init_check() instead of gst_init()
https://bugs.webkit.org/show_bug.cgi?id=31864

Use gst_init_check() instead of gst_init() to prevent eventual
unexpected exit of the application.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::do_gst_init): (WebCore::MediaPlayerPrivate::isAvailable):
07:46 Changeset [51381] by eric@webkit.org

2009-11-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
https://bugs.webkit.org/show_bug.cgi?id=31870

  • Scripts/modules/commands/queries_unittest.py: Use the new class.
  • Scripts/modules/multicommandtool_unittest.py: Ditto.
  • Scripts/modules/outputcapture.py: Added.
05:01 Changeset [51380] by kov@webkit.org

Reviewed by Xan Lopez.

Some tests are crashing from time to time
https://bugs.webkit.org/show_bug.cgi?id=31866

Make sure we do not notify the client of a finished load, if the
load has been cancelled, or the client is gone.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
03:02 Changeset [51379] by benm@google.com

[Android] Upstream Android changes to WebCore/bridge/jni
https://bugs.webkit.org/show_bug.cgi?id=31824

Reviewed by Eric Seidel.

No new tests required as no new functionality.

  • bridge/jni/jni_class.cpp:

(JavaClass::JavaClass): Add calls to delete allocated references, to avoid potential leaks.

  • bridge/jni/jni_instance.cpp: Add an Android include path.
  • bridge/jni/jni_instance.h: Add getter/setter for JObjectWrapper::_instance and make the JavaInstance ctor and member variables protected. Both needed for the Android port, see bug for discussion.

(JSC::Bindings::JObjectWrapper::instance): Added.
(JSC::Bindings::JObjectWrapper::setInstance): Added.

  • bridge/jni/jni_runtime.cpp:

(JavaMethod::JavaMethod): Delete an allocated reference to avoid a potential leak.

  • bridge/jni/jni_utility.h:

(JSC::Bindings::callJNIMethodV): Delete an allocated reference to avoid a potential leak.

01:40 QtWebKitContrib edited by hausmann@webkit.org
(diff)
00:25 Changeset [51378] by zoltan@webkit.org

Allow custom memory allocation control for classes of the plugins and rendering directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31827

Reviewed by Eric Seidel.

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

class PluginRequest - plugins/PluginView.cpp:521
class PluginMainThreadScheduler - plugins/PluginMainThreadScheduler.cpp:34
class PluginDatabase - plugins/PluginDatabase.cpp:50
struct MimeClassInfo - plugins/PluginInfoStore.cpp:50
struct PluginInfo - plugins/PluginInfoStore.cpp:40
class RenderArena - dom/Document.cpp:1401
class RenderImageScaleData - rendering/RenderImage.cpp:149
class TableLayout - (its child class) rendering/RenderTable.cpp:82
struct ColumnInfo - rendering/RenderBlock.cpp:3590
struct FloatingObject - rendering/RenderBlock.cpp:2300
struct MaxMargin - rendering/RenderBlock.cpp:4794
class RenderMarquee - rendering/RenderLayer.cpp:3277

  • plugins/PluginData.h:
  • plugins/PluginDatabase.h:
  • plugins/PluginMainThreadScheduler.h:
  • plugins/PluginView.h:
  • rendering/RenderArena.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderImage.cpp:
  • rendering/RenderMarquee.h:
  • rendering/TableLayout.h:

11/24/09:

23:32 Changeset [51377] by bweinstein@apple.com

Un-roll out the roll out that was committed in r51376 because it didn't help the Windows bots,
even though it seemed to in my testing. Sorry.

23:04 Changeset [51376] by bweinstein@apple.com

Roll out r51354, r51460, and r51461 to see if removing them will fix
the Windows test bots, which are currently not very happy.

22:04 Changeset [51375] by cmarrin@apple.com

Another Windows build fix


Got rid of d3d.lib and d3dx9.lib dependency. Not needed until
we turn on ACCELERATED_COMPOSITING

22:01 Changeset [51374] by dimich@chromium.org

Initial implementation of WebKitSharedScript and SharedScriptContext
https://bugs.webkit.org/show_bug.cgi?id=31569

Reviewed by David Levin.

No new tests since there are no bindings yet (soon to come).

  • DerivedSources.make: Add WebKitSharedScript and SharedScriptContext to a list of idl files.
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::detach): Notify WebKitSharedScriptRepository that document is detaching.

  • dom/EventTarget.cpp: Add new casting methods, since the new types are EventTargets.

(WebCore::EventTarget::toWebKitSharedScript):
(WebCore::EventTarget::toSharedScriptContext):

  • dom/EventTarget.h: Ditto
  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::isSharedScriptContext): New virtual method, since there is a new type of context.

  • SharedScript/SharedScriptContext.cpp: Added. Similar to WorkerContext, but w/o threading.

(WebCore::SharedScriptContext::SharedScriptContext):
(WebCore::SharedScriptContext::~SharedScriptContext):
(WebCore::SharedScriptContext::clearScript):
(WebCore::SharedScriptContext::virtualURL):
(WebCore::SharedScriptContext::virtualCompleteURL):
(WebCore::SharedScriptContext::reportException):
(WebCore::SharedScriptContext::addMessage):
(WebCore::SharedScriptContext::resourceRetrievedByXMLHttpRequest):
(WebCore::SharedScriptContext::scriptImported):
(WebCore::SharedScriptContext::matches):
(WebCore::SharedScriptContext::addToDocumentsList):
(WebCore::SharedScriptContext::destructionTimerFired):
(WebCore::SharedScriptContext::removeFromDocumentList):
(WebCore::SharedScriptContext::load):
(WebCore::SharedScriptContext::postTask):
(WebCore::SharedScriptContext::eventTargetData):
(WebCore::SharedScriptContext::ensureEventTargetData):
(WebCore::SharedScriptContext::scriptExecutionContext):

  • SharedScript/SharedScriptContext.h: Added.

(WebCore::SharedScriptContext::create):
(WebCore::SharedScriptContext::isSharedScriptContext):
(WebCore::SharedScriptContext::userAgent):
(WebCore::SharedScriptContext::toSharedScriptContext):
(WebCore::SharedScriptContext::self):
(WebCore::SharedScriptContext::script):
(WebCore::SharedScriptContext::loaded):
(WebCore::SharedScriptContext::name):
(WebCore::SharedScriptContext::refEventTarget):
(WebCore::SharedScriptContext::derefEventTarget):
(WebCore::SharedScriptContext::refScriptExecutionContext):
(WebCore::SharedScriptContext::derefScriptExecutionContext):

  • SharedScript/SharedScriptContext.idl: Added.
  • SharedScript/SharedScriptController.h:

Added. Empty implementation of a ScriptController, will come later as part of bindings. Needed to compile.

  • SharedScript/WebKitSharedScript.cpp: Added. EventTarget-based DOM object.

(WebCore::WebKitSharedScript::WebKitSharedScript):
(WebCore::WebKitSharedScript::~WebKitSharedScript):
(WebCore::WebKitSharedScript::setContext):
(WebCore::LoadEventTask::create): Fires asynchronous 'load' event when underlying SharedScriptContext is initialized.
(WebCore::LoadEventTask::performTask):
(WebCore::LoadEventTask::LoadEventTask):
(WebCore::WebKitSharedScript::scheduleLoadEvent):

  • SharedScript/WebKitSharedScript.h: Added.

(WebCore::WebKitSharedScript::create):
(WebCore::WebKitSharedScript::scriptExecutionContext):
(WebCore::WebKitSharedScript::toWebKitSharedScript):
(WebCore::WebKitSharedScript::context):
(WebCore::WebKitSharedScript::refEventTarget):
(WebCore::WebKitSharedScript::derefEventTarget):
(WebCore::WebKitSharedScript::eventTargetData):
(WebCore::WebKitSharedScript::ensureEventTargetData):

  • SharedScript/WebKitSharedScript.idl: Added.
  • SharedScript/WebKitSharedScriptRepository.cpp: Added. Implements a list of running SharedScriptContexts.

(WebCore::ScriptLoader::ScriptLoader): The helper class to load an initial script of SharedScriptContext.
(WebCore::ScriptLoader::load):
(WebCore::ScriptLoader::notifyFinished):
(WebCore::WebKitSharedScriptRepository::instance): Repository has a static global instance.
(WebCore::WebKitSharedScriptRepository::connect):
(WebCore::WebKitSharedScriptRepository::documentDetached): Called from Document::detach().
(WebCore::WebKitSharedScriptRepository::removeSharedScriptContext): Called from ~SharedScriptContext().
(WebCore::WebKitSharedScriptRepository::connectToSharedScript):
(WebCore::WebKitSharedScriptRepository::getSharedScriptContext):

  • SharedScript/WebKitSharedScriptRepository.h: Added.

(WebCore::WebKitSharedScriptRepository::WebKitSharedScriptRepository):

21:38 Changeset [51373] by dimich@chromium.org

Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
https://bugs.webkit.org/show_bug.cgi?id=31444

Reviewed by Eric Seidel.

  • configure.ac:

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pro:

WebKit:

  • chromium/features.gypi:

WebKit/chromium:

  • features.gypi:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKitTools:

  • Scripts/build-webkit:
21:22 Changeset [51372] by cmarrin@apple.com

Fixed Windows build


Got rid of QuartzCore.lib dependency. Not needed until
we turn on ACCELERATED_COMPOSITING

20:29 Changeset [51371] by cmarrin@apple.com

Implement accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=27314

Initial implementation, but disabled in this checkin.
To enable ENABLE_3D_RENDERING and USE_ACCELERATED_COMPOSITING
must be turned on. Also d3d9.lib and d3d9x.lib must be added
to the build.

19:13 Changeset [51370] by cmarrin@apple.com

Do error checking of parameter to createShader
https://bugs.webkit.org/show_bug.cgi?id=31808

18:45 Changeset [51369] by eric@webkit.org

2009-11-24 Jason Smith <dark.panda@gmail.com>

Reviewed by Alexey Proskuryakov.

RegExp#exec's returned Array-like object behaves differently from
regular Arrays
https://bugs.webkit.org/show_bug.cgi?id=31689

  • LayoutTests/fast/js/regexp-in-and-foreach-handling.html: Added.
  • LayoutTests/fast/js/script-tests/regexp-in-and-foreach-handling.js: Added.
  • LayoutTests/fast/js/regexp-in-and-foreach-handling-expected.txt: Added.

2009-11-24 Jason Smith <dark.panda@gmail.com>

Reviewed by Alexey Proskuryakov.

RegExp#exec's returned Array-like object behaves differently from
regular Arrays
https://bugs.webkit.org/show_bug.cgi?id=31689

  • JavaScriptCore/runtime/RegExpConstructor.cpp: ensure that undefined values are added to the returned RegExpMatchesArray
18:16 Changeset [51368] by eric@webkit.org

2009-11-24 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Ignore line-height CSS property specified to a search field on
Windows and Linux.
https://bugs.webkit.org/show_bug.cgi?id=31820

LayoutTests/fast/forms/control-restrict-line-height.html checks that the
following controls should ignore line-height CSS property.

  • <select>
  • <input type=button>
  • <input type=search>

This change addresses the <input type=search> issue with Chromium/Windows
and Chromium/Linux.

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::adjustSearchFieldStyle): Implement this to ignore line-height.
  • rendering/RenderThemeChromiumSkia.h: Declare adjustSearchFieldStyle().
17:22 Changeset [51367] by simon.fraser@apple.com

2009-11-24 Simon Fraser <simon.fraser@apple.com>

No review.

Stylistic fix: indent the member var initialisation.

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::GraphicsLayerCA):
16:24 Changeset [51366] by simon.fraser@apple.com

2009-11-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Oliver Hunt.

SVGUseElement::toClipPath can crash
<rdar://problem/7385270>

Null-test m_shadowTreeRootElement again, because the call to buildPendingResource() may not
actually initialize it.

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath):
16:06 Changeset [51365] by snej@chromium.org

Add Chromium's gyp-generated Xcode projects to the .gitignore file.

15:46 Changeset [51364] by eric@webkit.org

2009-11-24 Evan Stade <estade@chromium.org>

Reviewed by David Levin.

Linux Chromium sends too many click events
https://bugs.webkit.org/show_bug.cgi?id=31841

Manually count number of clicks for double/triple click events. This
makes us match Firefox on http://www.quirksmode.org/js/events_mouse.html
Chromium side of this patch is here:
http://codereview.chromium.org/431031/show

  • src/gtk/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::mouseEvent):
15:43 Changeset [51363] by barraclough@apple.com

Bug 31848 - Remove uses of mainThreadCurrentWorld, and of currentWorld using a globalData.

Reviewed by Geoff Garen.

These methods get the world from the global data rather than from an execstate.
If the current world is always read from an exec state then it can be read
from the global object, and world entry can become automagical, rather than
being explicitly set by an EnterDOMWrapperWorld.

  • bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::currentWorld):
(WebCore::DOMObjectWrapperMapFor):
(WebCore::hasCachedDOMObjectWrapper):
(WebCore::getCachedDOMObjectWrapper):
(WebCore::cacheDOMObjectWrapper):
(WebCore::hasCachedDOMNodeWrapper):
(WebCore::getCachedDOMNodeWrapper):
(WebCore::cacheDOMNodeWrapper):

  • bindings/js/JSDOMBinding.h:

(WebCore::createDOMObjectWrapper):
(WebCore::getDOMObjectWrapper):
(WebCore::createDOMNodeWrapper):
(WebCore::getDOMNodeWrapper):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::history):
(WebCore::JSDOMWindow::location):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::location):
(WebCore::toJS):

  • bindings/js/JSElementCustom.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::markChildren):
(WebCore::createWrapper):
(WebCore::toJS):

  • bindings/js/JSSVGPathSegCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSStyleSheetCustom.cpp:

(WebCore::toJS):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::dropProtection):

15:19 Changeset [51362] by eric@webkit.org

2009-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

queries_unittest.py should test command output
https://bugs.webkit.org/show_bug.cgi?id=31845

  • Scripts/modules/commands/queries_unittest.py:
    • Capture stdout and stderr and compare with expected strings.
14:41 Changeset [51361] by ap@apple.com

Windows build fix.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: Also, don't include the wrong one!
14:34 Changeset [51360] by ap@apple.com

Windows build fix.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: Include the proper WKSI header.
14:32 Changeset [51359] by simon.fraser@apple.com

2009-11-24 Simon Fraser <simon.fraser@apple.com>

Windows build fix.

  • page/win/FrameCGWin.cpp: (WebCore::imageFromRect): (WebCore::imageFromSelection):
14:21 Changeset [51358] by eric.carlson@apple.com

2009-11-24 Eric Carlson <eric.carlson@apple.com>

Not reviewed. Revert r51351 until a new WebKitSupportLibrary is available.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/win/QTMovieWin.cpp:
  • platform/graphics/win/QTMovieWin.h:
  • rendering/RenderMediaControls.cpp:
  • rendering/RenderThemeWin.cpp:
  • rendering/RenderThemeWin.h:
14:16 Changeset [51357] by simon.fraser@apple.com

2009-11-24 Simon Fraser <simon.fraser@apple.com>

No Review.

Fix spelling error ("depenedencies").

  • Scripts/build-webkit:
14:05 Changeset [51356] by mrowe@apple.com

Land the configuration that includes the two debug GTK Linux builders.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
13:54 Changeset [51355] by simon.fraser@apple.com

2009-11-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Find highlight is drawn incorrectly on pages with compositing layers
<rdar://problem/7413925>

Part 2: Add a new bit to the PaintBehavior flags, PaintBehaviorFlattenCompositingLayers,
and pass that down when painting into an image.

When set, it forces painting of compositing layers to go down a software paint path
when all layers are painted, irrespective of compositing status, and where
3d transforms are flattened to 2d. When doing this, we also need to use temporary
clip rects for layers which are normally composited.

  • page/FrameView.h: (WebCore::FrameView::paintBehavior):
  • page/mac/FrameMac.mm: (WebCore::Frame::imageFromRect):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::renderableTransform): (WebCore::expandClipRectForDescendantsAndReflection): (WebCore::transparencyClipBox): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintLayer):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::paintsWithTransparency): (WebCore::RenderLayer::paintsWithTransform):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds):
  • rendering/RenderObject.h:
13:50 Changeset [51354] by ap@apple.com

Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=31844
SocketStreamHandleCFNet should support CONNECT proxy credentials

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/CredentialStorage.h:
  • platform/network/mac/CredentialStorageMac.mm: Added. (WebCore::CredentialStorage::getFromPersistentStorage):
  • platform/network/cf/CredentialStorageCFNet.cpp: Added. (WebCore::CredentialStorage::getFromPersistentStorage): Add support for fetching credentials from persistent storage (CFNet version is currently a stub).
  • bindings/js/JSWebSocketCustom.cpp: Removed an unneeded include.
  • platform/network/cf/SocketStreamHandle.h:
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::createStreams): (WebCore::getStoredCONNECTProxyCredentials): (WebCore::authenticationSchemeFromAuthenticationMethod): (WebCore::SocketStreamHandle::addCONNECTCredentials): (WebCore::SocketStreamHandle::readStreamCallback): Check if connection attempt was resulted in 407, and try stored credentials if it did.
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • WebCore.base.exp: Updated WKSI.
13:44 Changeset [51353] by simon.fraser@apple.com

2009-11-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Find highlight is drawn incorrectly on pages with compositing layers
<rdar://problem/7413925>

Part 1: Rename PaintRestriction to PaintBehavior, and make it a bitmask, in
preparation for adding a new flag related to painting into an image.

PaintBehaviorSelectionOnly and PaintBehaviorForceBlackText are now separate flags.

  • page/FrameView.cpp: (WebCore::FrameView::reset): (WebCore::FrameView::paintContents): (WebCore::FrameView::setPaintBehavior):
  • page/FrameView.h:
  • page/mac/FrameMac.mm: (WebCore::Frame::selectionImage):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): (WebCore::RenderLayer::paintLayer):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer): (WebCore::RenderLayerBacking::paintContents):
  • rendering/RenderLayerBacking.h:
  • rendering/RenderObject.h:
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint):
13:41 Changeset [51352] by oliver@apple.com

JSON.stringify performance on undefined is very poor
https://bugs.webkit.org/show_bug.cgi?id=31839

Reviewed by Alexey Proskuryakov.

Switch from a UString to a Vector<UChar> when building
the JSON string, allowing us to safely remove the substr-copy
we otherwise did when unwinding an undefined property.

Also turns out to be a ~5% speedup on stringification.

13:31 Changeset [51351] by eric.carlson@apple.com

2009-11-24 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7409331> Windows: Support closed caption in <video> element

Enable closed captions in QuickTime/Windows media engine.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::hasClosedCaptions): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::hasClosedCaptions): (QTMovieWin::setClosedCaptionsVisible):
  • platform/graphics/win/QTMovieWin.h:
  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintMediaToggleClosedCaptionsButton):
  • rendering/RenderThemeWin.h:
13:22 Changeset [51350] by darin@chromium.org

2009-11-24 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Renderer hang when using www.expedia.com
https://bugs.webkit.org/show_bug.cgi?id=31822

Test: http/tests/cache/subresource-failover-to-network.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): Use the originalRequest when inheriting cache policy. This matches SubresourceLoader::create.

2009-11-24 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Renderer hang when using www.expedia.com
https://bugs.webkit.org/show_bug.cgi?id=31822

This test verifies that a synchronous XMLHttpRequest, generated from a
page that is the result of a form submission, loads properly when the
user navigates back to the page.

When navigating back to a page that resulted from a form submission,
the page is loaded with the ReturnCacheDataDontLoad cache policy. It
is important that subresources (including XMLHttpRequest instances) do
not inherit this cache policy.

  • http/tests/cache/resources/echo-no-store.cgi: Added.
  • http/tests/cache/resources/subresource-failover-to-network.cgi: Added.
  • http/tests/cache/subresource-failover-to-network-expected.txt: Added.
  • http/tests/cache/subresource-failover-to-network.html: Added.

2009-11-24 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Renderer hang when using www.expedia.com
https://bugs.webkit.org/show_bug.cgi?id=31822

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillSendRequest): Assign ReturnCacheDataDontLoad cache policy at the last moment to match Safari. This way the cache policy does not get stored in DocumentLoader's originalRequest preventing it from being inherited by subresource requests.
  • src/ResourceHandle.cpp: (WebCore::ResourceHandle::willLoadFromCache): Remove assignment of ReturnCacheDataDontLoad cache policy so that it doesn't end up applying to the DocumentLoader's originalRequest.
12:18 Changeset [51349] by cmarrin@apple.com

Didn't add these files to http://trac.webkit.org/changeset/51348

12:04 Changeset [51348] by cmarrin@apple.com

Change get... calls to latest spec
https://bugs.webkit.org/show_bug.cgi?id=30091

Removed old versions of get calls on WebGLRenderingContext and
added new ones per spec returning "any". New code simplifies
GraphicsContext3D and fixes previously unimplemented routines.
Added custom JS and V8 bindings. Added exhaustive test case
exercising all new code paths. Updated preexisting test cases for
new APIs. Fixed preexisting bugs in WebKit's and Chrome's WebGL
implementations.

Ran WebGL layout tests in WebKit (clean) and Chrome (couple of
preexisting known failures) and manual WebGL tests in both
browsers.

11:51 Changeset [51347] by sfalken@apple.com

Windows build fix.

  • WebCore.vcproj/QTMovieWin.vcproj: Add additional search path for QuickTime SDK.
11:50 Changeset [51346] by ddkilzer@apple.com

<http://webkit.org/b/31840> bisect-builds broke after r50080

Reviewed by Dan Bernstein.

  • Scripts/bisect-builds:

(mountAndRunNightly): Switched back to using backticks to run
the hdiutil command since exec() will terminate the existing
script, which is not what we want. Store the output of
File::Spec->devnull() in a variable for use in the hdiutil
detach commands.

11:38 Changeset [51345] by pfeldman@chromium.org

2009-11-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Darin Fisher.

Chromium: Expose method for reporting user stats
to the host. Also includes drive-by default implementation.

https://bugs.webkit.org/show_bug.cgi?id=31830

  • public/WebKitClient.h:
11:33 Changeset [51344] by dimich@chromium.org

Convert fast/table/row-height-recalc2.html to be 'dumpAsText()'
https://bugs.webkit.org/show_bug.cgi?id=31816

Reviewed by Eric Seidel.

  • fast/table/row-height-recalc2-expected.txt: Added.
  • fast/table/row-height-recalc2.html:
  • platform/mac/fast/table/row-height-recalc2-expected.checksum: Removed.
  • platform/mac/fast/table/row-height-recalc2-expected.png: Removed.
  • platform/mac/fast/table/row-height-recalc2-expected.txt: Removed.
  • platform/qt/fast/table/row-height-recalc2-expected.checksum: Removed.
  • platform/qt/fast/table/row-height-recalc2-expected.png: Removed.
  • platform/qt/fast/table/row-height-recalc2-expected.txt: Removed.
  • platform/win/fast/table/row-height-recalc2-expected.checksum: Removed.
  • platform/win/fast/table/row-height-recalc2-expected.png: Removed.
10:55 Changeset [51343] by eric@webkit.org

2009-11-24 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] GStreamer-CRITICAL's (and other warnings) on <video>
https://bugs.webkit.org/show_bug.cgi?id=26354

Implemented MediaPlayerPrivate::isAvailable by checking the
presence of the playbin2 GStreamer element.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::isAvailable):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
10:47 Changeset [51342] by eric@webkit.org

2009-11-24 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

When building up the pango layout from text boxes, only append a
newline char after verifying there are no more boxes on this line.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getPangoLayoutForAtk):

2009-11-24 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

When building up the pango layout from text boxes, only append a
newline char after verifying there are no more boxes on this line.

  • tests/testatk.c (test_webkit_atk_get_text_at_offset_newlines): (main):
09:53 Changeset [51341] by joepeck@webkit.org

2009-11-24 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Keyboard Shortcut to Clear Console Messages
https://bugs.webkit.org/show_bug.cgi?id=31780

All Platforms: Ctrl+L = Clear Console Messages
Mac Only: Cmd+K = Clear Console Messages

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): create shortcuts (WebInspector.ConsoleView.prototype._promptKeyDown): handle shortcuts
  • inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut.makeKey): convenience conversion of "a-z" character to keyCode
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): style fixes for keyboard shortcuts
09:20 Changeset [51340] by pfeldman@chromium.org

2009-11-24 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: touch inspector controller in order to
kick win bot inspector deploy. rs=aroben.

  • inspector/InspectorController.cpp:
09:15 Changeset [51339] by pfeldman@chromium.org

2009-11-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement expandable compartments on timeline panel.

https://bugs.webkit.org/show_bug.cgi?id=31796

  • inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelineRecordListRow): (WebInspector.TimelineRecordListRow.prototype.update): (WebInspector.TimelineRecordListRow.prototype.dispose): (WebInspector.TimelineRecordGraphRow): (WebInspector.TimelineRecordGraphRow.prototype.update): (WebInspector.TimelineRecordGraphRow.prototype._onClick): (WebInspector.TimelineRecordGraphRow.prototype.dispose):
  • inspector/front-end/inspector.css:
08:15 Changeset [51338] by eric@webkit.org

2009-11-24 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[Chromium] Fix DOM storage layout tests
https://bugs.webkit.org/show_bug.cgi?id=31833

The issue is, essentially, that this code assumes that
SecurityOrigin::createString can re-create a SecurityOrigin given
the string produced from SecurityOrigin::toString. This is a bogus
assumption in a number of corner cases (e.g., document.domain,
@sandbox). A recent patch (http://trac.webkit.org/changeset/51294)
make this assumption further invalid in the case of of file:// URLs.

The correct fix is for this code to use WebSecurityOrigin objects
(and not strings) to represent SecurityOrigin objects. However, the
expert on this code is on vacation, and I don't want to do major
surgery here without his involvement. This patch is a temporary fix
to get these tests passing again. We'll do the right fix once
jorlow gets back from vacation.

Tests: Covered by a number of existing DOM storage tests.

  • src/WebStorageNamespaceImpl.cpp: (WebKit::WebStorageNamespaceImpl::createStorageArea):
02:21 Changeset [51337] by mrowe@apple.com

Fix production builds where the source tree may be read-only.

11/23/09:

20:25 Changeset [51336] by laszlo.1.gombos@nokia.com

2009-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Include "config.h" to meet Coding Style Guidelines
https://bugs.webkit.org/show_bug.cgi?id=31792

  • wtf/unicode/UTF8.cpp:
  • wtf/unicode/glib/UnicodeGLib.cpp:
  • wtf/unicode/wince/UnicodeWince.cpp:

2009-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Include "config.h" to meet Coding Style Guidelines
https://bugs.webkit.org/show_bug.cgi?id=31792

  • GEN_DOMObject.cpp:
  • WebScriptObject.cpp:

2009-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Include "config.h" to meet Coding Style Guidelines
https://bugs.webkit.org/show_bug.cgi?id=31792

  • WebKitSupport/DragClientWx.cpp:

2009-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Include "config.h" to meet Coding Style Guidelines
https://bugs.webkit.org/show_bug.cgi?id=31792

No new tests as there is no new functionality.

  • platform/graphics/win/IntPointWin.cpp:
  • platform/graphics/win/IntRectWin.cpp:
  • platform/graphics/win/IntSizeWin.cpp:
  • platform/network/chromium/ResourceRequest.cpp:
  • platform/win/PlatformMouseEventWin.cpp:

2009-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Include "config.h" to meet Coding Style Guidelines
https://bugs.webkit.org/show_bug.cgi?id=31792

  • DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
  • DumpRenderTree/qt/jsobjects.cpp:
  • DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
18:33 Changeset [51335] by jianli@chromium.org

WebCore: * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):

  • platform/graphics/GraphicsContext3D.h:

Reviewed by NOBODY (Chromium build fix).

WebKit/chromium: * src/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::createShader):

Reviewed by NOBODY (Chromium build fix).

18:30 Changeset [51334] by ggaren@apple.com

Streamlined some Math functions where we expect or know the result not
to be representable as an int.

Reviewed by Oliver Hunt.

SunSpider says 0.6% faster.

  • runtime/JSNumberCell.h:

(JSC::JSValue::JSValue):

  • runtime/JSValue.h:

(JSC::JSValue::):
(JSC::jsDoubleNumber):
(JSC::JSValue::JSValue): Added a function for making a numeric JSValue
and skipping the "can I encode this as an int?" check, avoiding the
overhead of int <-> double roundtripping and double <-> double comparison
and branching.

  • runtime/MathObject.cpp:

(JSC::mathProtoFuncACos):
(JSC::mathProtoFuncASin):
(JSC::mathProtoFuncATan):
(JSC::mathProtoFuncATan2):
(JSC::mathProtoFuncCos):
(JSC::mathProtoFuncExp):
(JSC::mathProtoFuncLog):
(JSC::mathProtoFuncRandom):
(JSC::mathProtoFuncSin):
(JSC::mathProtoFuncSqrt):
(JSC::mathProtoFuncTan): For these functions, which we expect or know
to produce results not representable as ints, call jsDoubleNumber instead
of jsNumber.

18:24 Changeset [51333] by mrowe@apple.com

Unreviewed. Unbreak the regression tests after r51329.

  • API/JSBase.cpp:

(JSEvaluateScript): Null-check clientData before dereferencing it.

  • API/JSObjectRef.cpp:

(JSObjectCallAsFunction): Ditto.

17:31 Changeset [51332] by bweinstein@apple.com

Add exported functions to fix the Windows build.

17:07 Changeset [51331] by agolden@apple.com

Prevent ResourceHandleMac's version of ResourceHandle::receivedCredential from stripping
identity and certificate information from a WebCore::Credential when receivedCredential
needs to modify the credential's persistence.

Reviewed by Alexey Proskuryakov.

16:55 Changeset [51330] by barraclough@apple.com

Part 2/3 of <rdar://problem/7377477> REGRESSION: Many web pages fail to render after interesting script runs in isolated world

Reviewed by Geoff Garen.

Some clients of the JavaScriptCore API expect to be able to make callbacks over the JSC API,
and for this to automagically cause execution to take place in the world associated with the
global object associated with the ExecState (JSContextRef) passed. However this is not how
things work - the world must be explicitly set within WebCore.

Making this work just for API calls to evaluate & call will be a far from perfect solution,
since direct (non-API) use of JSC still relies on WebCore setting the current world correctly.
A better solution would be to make this all work automagically all throughout WebCore, but this
will require more refactoring.

Add references from the JSDOMWindowShell and the JSDOMGlobalObject to the world that owns them,
so that we can get to the world from the lexical global object of an ExecState. In the long-term
we should switch over to using this approach for all cases we want to get a world from an exec state.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::WebCoreJSClientData::beginningExecution):
(WebCore::WebCoreJSClientData::completedExecution):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMGlobalObject.h:

(WebCore::JSDOMGlobalObject::world):
(WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::JSDOMWindowShell):

  • bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::world):

  • bindings/js/JSWorkerContextBase.cpp:

(WebCore::JSWorkerContextBase::JSWorkerContextBase):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initScript):

16:54 Changeset [51329] by barraclough@apple.com

Part 1/3 of <rdar://problem/7377477> REGRESSION: Many web pages fail to render after interesting script runs in isolated world

Reviewed by Geoff Garen.

Some clients of the JavaScriptCore API expect to be able to make callbacks over the JSC API,
and for this to automagically cause execution to take place in the world associated with the
global object associated with the ExecState (JSContextRef) passed. However this is not how
things work - the world must be explicitly set within WebCore.

Making this work just for API calls to evaluate & call will be a far from perfect solution,
since direct (non-API) use of JSC still relies on WebCore setting the current world correctly.
A better solution would be to make this all work automagically all throughout WebCore, but this
will require more refactoring.

Since the API is in JSC but worlds only exist in WebCore, add callbacks on the JSGlobalData::ClientData
to allow it to update the current world on entry/exit via the JSC API. This is temporary duck
tape, and should be removed once the current world no longer needs to be explicitly tracked.

  • API/JSBase.cpp:

(JSEvaluateScript):

  • API/JSObjectRef.cpp:

(JSObjectCallAsFunction):

(JSC::JSGlobalData::ClientData::beginningExecution):
(JSC::JSGlobalData::ClientData::completedExecution):

  • runtime/JSGlobalData.h:
16:35 Changeset [51328] by cmarrin@apple.com

Forgot one file for https://bugs.webkit.org/show_bug.cgi?id=31239

16:33 Changeset [51327] by cmarrin@apple.com

Add range checks to rendering calls in WebGL
https://bugs.webkit.org/show_bug.cgi?id=31239

I am now tracking the size of the data in each CanvasBuffer object
and keeping track of the buffer size of each active vertex attrib.
In drawArrays and drawElements I make sure no attempt is made to
access elements outside the valid buffer ranges. The test at:

http://cs.helsinki.fi/u/ilmarihe/c3d/functions/drawArraysOutOfBounds.html

no longer crashes.

I also added all the WebGL enumerations to GraphicsContext3D to use them in the validation checks

16:30 Changeset [51326] by arv@chromium.org

2009-11-23 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

JSC bindings for HasIndexGetter generates incorrect code (affects
MediaList and CSSStyleDeclaration).
This cleans up the edge cases for indexing out of range for style and
computed style objects to return an empty string according to the spec.
MediaList now returns null when indexed out of range.
https://bugs.webkit.org/show_bug.cgi?id=31683

  • fast/dom/CSSStyleDeclaration/css-computed-style-item-expected.txt: Added.
  • fast/dom/CSSStyleDeclaration/css-computed-style-item.html: Added.
  • fast/dom/CSSStyleDeclaration/css-style-item-expected.txt: Added.
  • fast/dom/CSSStyleDeclaration/css-style-item.html: Added.
  • fast/dom/CSSStyleDeclaration/script-tests/css-computed-style-item.js: Added.
  • fast/dom/CSSStyleDeclaration/script-tests/css-style-item.js: Added.
  • fast/dom/StyleSheet/css-medialist-item-expected.txt: Added.
  • fast/dom/StyleSheet/css-medialist-item.html: Added.
  • fast/dom/StyleSheet/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/backgrounds/repeat/script-tests/TEMPLATE.html.
  • fast/dom/StyleSheet/script-tests/css-medialist-item.js: Added.

2009-11-23 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

JSC bindings for HasIndexGetter generates incorrect code (affects
MediaList and CSSStyleDeclaration).
This cleans up the edge cases for indexing out of range for style and
computed style objects to return an empty string according to the spec.
MediaList now returns null when indexed out of range.
https://bugs.webkit.org/show_bug.cgi?id=31683

Tests: fast/dom/CSSStyleDeclaration/css-computed-style-item.html

fast/dom/CSSStyleDeclaration/css-style-item.html
fast/dom/StyleSheet/css-medialist-item.html

  • bindings/scripts/CodeGeneratorJS.pm: If IndexGetterReturnsString then

we do not check the length before calling the item function.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::item):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::item):
  • css/CSSStyleDeclaration.idl:
16:16 Changeset [51325] by ossy@webkit.org

Unreviewed. Skip new test added in r51324.

  • platform/qt/Skipped: Added editing/selection/trransformed-selection-rects.html
15:30 Changeset [51324] by simon.fraser@apple.com

2009-11-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

DocumentMarkers need to be educated about transforms
https://bugs.webkit.org/show_bug.cgi?id=31751

Find highlight is incorrect with transforms
<rdar://problem/6358394>

Allow callers to specify that Frame::selectionTextRects() takes transforms into account
when computing the set of rects that encompass a selection. For transformed elemenets, the
selection rect will be the bounding box of the selected content.

Fix DocumentMarkers to cache rects in absolute coordinates, rather than painting coordinates.

Test: editing/selection/transformed-selection-rects.html

  • WebCore.base.exp: Frame::selectionTextRects() has a new parameter.
  • dom/Document.cpp: (WebCore::Document::setRenderedRectForMarker):
  • dom/Document.h: Pass the marker as a const reference.
  • dom/Range.h:
  • dom/Range.cpp: (WebCore::Range::textQuads): Add a new method, textQuads(), which returns a list of quads, respecting transforms.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::selectionTextRects): Add a new parameter, respectTransforms, and when that is RespectTransforms, use the quad method to get quads for ranges, and then take their bounding boxes.
  • rendering/InlineTextBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers): (WebCore::InlineTextBox::textPos): (WebCore::InlineTextBox::offsetForPosition):

Pass DocumentMarkers as a const references.
Convert the argument to setRenderedRectForMarker() into absolute coordinates.

  • rendering/RenderView.cpp: (WebCore::RenderView::selectionBounds):
14:55 Changeset [51323] by eric@webkit.org

2009-11-23 Steve Block <steveblock@google.com>

Reviewed by Dmitry Titov.

Adds MainThreadAndroid.cpp with Android-specific WTF threading functions.
https://bugs.webkit.org/show_bug.cgi?id=31807

  • wtf/android: Added.
  • wtf/android/MainThreadAndroid.cpp: Added. (WTF::timeoutFired): (WTF::initializeMainThreadPlatform): (WTF::scheduleDispatchFunctionsOnMainThread):
14:36 Changeset [51322] by krit@webkit.org

2009-11-23 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

[Cairo] support blurred test-shadow
https://bugs.webkit.org/show_bug.cgi?id=31797

Support for blurred text-shadows on Cairo. This patch
reuses the code of blurred box-shadows, introduced in
bug 26102. For a full textshadow support, a filters enabled
build is needed.

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
14:25 Changeset [51321] by snej@chromium.org

Change incorrect calls to the constructor "EventNames()" to the correct accessor
"eventNames()". This saves ~100 AtomicString lookups each time.
https://bugs.webkit.org/show_bug.cgi?id=31811

Reviewed by Geoffrey Garen.

  • dom/EventNames.h: Make constructor private to prevent this from happening again.
  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): EventNames() --> eventNames()

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::checkValidity): EventNames() --> eventNames()

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading): EventNames() --> eventNames()
(WebCore::FrameLoader::pageHidden): EventNames() --> eventNames()

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchAllPendingUnloadEvents): EventNames() --> eventNames()

14:22 Changeset [51320] by kov@webkit.org

Reviewed by Oliver Hunt.

Implement new required function to pass test we used to pass. This
change is required since r51294.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
14:10 Changeset [51319] by agl@chromium.org

2009-11-23 Adam Langley <agl@google.com>

Reviewed by Dmitry Titov.

Chromium Linux: Limit the stroke width and mitre limit.

Limit the stroke width and mitre limit that we'll pass into Skia to
avoid overflowing Skia's uint16_t glyph widths.

http://code.google.com/p/chromium/issues/detail?id=28250
https://bugs.webkit.org/show_bug.cgi?id=31747

  • platform/graphics/skia/PlatformContextSkia.cpp: (scalarBound): (PlatformContextSkia::setupPaintForStroking):
13:57 Changeset [51318] by ossy@webkit.org

Unreviewed. Skip new tests.

  • platform/qt/Skipped:
13:53 Changeset [51317] by ap@apple.com

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=31812
WebSocket code uses RefPtr::get() where it shouldn't

No change in funcitonality, just coding style correction.

  • websockets/WebSocket.cpp: (WebCore::WebSocket::~WebSocket):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::connect): (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::bufferedAmount): (WebCore::WebSocketChannel::close): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData): (WebCore::WebSocketChannel::didFail):
13:48 Changeset [51316] by eric@webkit.org

2009-11-23 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
https://bugs.webkit.org/show_bug.cgi?id=31775

LayoutTestController::dumpBackForwardList() should work with local URLs
as well as with normal URLs (in http tests for instance).
Currently it does not output the latter properly.

Unskip a bunch of passing http/navigation tests.

  • platform/qt/Skipped:

2009-11-23 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
https://bugs.webkit.org/show_bug.cgi?id=31775

LayoutTestController::dumpBackForwardList() should work with local URLs
as well as with normal URLs (in http tests for instance).
Currently it does not output the latter properly.

Unskip a bunch of passing http/navigation tests.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::dumpHistoryItem):
13:28 Changeset [51315] by ap@apple.com

Build fix.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::pacExecutionCallbackMainThread): pacExecutionCallbackMainThread is static, so it can't use member variables directly.
13:00 Changeset [51314] by ap@apple.com

Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=31748
Make WebSocketHandleCFNet respect proxy auto-configuration files via CFProxySupport

  • platform/network/cf/SocketStreamHandle.h: Removed names from some void* arguments, since they didn't carry useful information.
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): When we need an http-style URL, we actually always need https. (WebCore::SocketStreamHandle::scheduleStreams): Factored out from constructor, since streams only get scheduled after PAC is fetched and executed asynchronously. (WebCore::SocketStreamHandle::copyPACExecutionDescription): Return a description for event source. (WebCore::MainThreadPACCallbackInfo::MainThreadPACCallbackInfo): Forward callback to main thread. (WebCore::SocketStreamHandle::pacExecutionCallback): Ditto. (WebCore::SocketStreamHandle::pacExecutionCallbackMainThread): Ditto. To avoid code duplication, we make the call even on Mac. (WebCore::SocketStreamHandle::executePACFileURL): Make an async call to CFNetworkExecuteProxyAutoConfigurationURL. (WebCore::SocketStreamHandle::removePACRunLoopSource): Once PAC execution is done or aborted, we need to get rid of the event source. (WebCore::SocketStreamHandle::chooseProxy): Use stored m_httpsURL.get. (WebCore::SocketStreamHandle::chooseProxyFromArray): Factored out from chooseProxy - the array may come directly from system configuration, or from PAC. (WebCore::SocketStreamHandle::chooseProxy): Tiger version of this function is now completely separate. (WebCore::SocketStreamHandle::~SocketStreamHandle): Run loop source should be destroyed before we get to the destructor. (WebCore::SocketStreamHandle::platformClose): Destroy the run loop source, if PAC execution is still in progress.
12:10 Changeset [51313] by oliver@apple.com

Don't leak the CGImage we create when drawing a sub image.

Reviewed by Geoff Garen.

11:12 Changeset [51312] by abarth@webkit.org

2009-11-23 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Don't crash when OOM in creating isolated world
https://bugs.webkit.org/show_bug.cgi?id=31805

We need to add some more null checks to avoid crashing. No new tests
because we don't have a good way to test out-of-memory bugs.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::setInjectedScriptContextDebugId):
  • bindings/v8/V8Proxy.h:
11:07 Changeset [51311] by bweinstein@apple.com

Touch WebKit.idl to force a rebuild.

08:15 Changeset [51310] by krit@webkit.org

2009-11-23 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

This is the implementation of the filterRes attribute. It
helps the SVG developer to set the quality of a filter by
giving the width or height of filter.
This patch also sets the filter resolution to lower values
if a intermediate ImageBuffer size is bigger than the given
maximal size.
The maximal size is set to 5000x5000 by default. This is a
subjectiv decission. Everthing greater than this values gets
sensible slower. Values of 10000x10000 crashed on WebKitGtk.
For mobil devices a maximum size of 100x100 or 200x200 seems
to be reasonable.
The important fact on filter resolution is, that the output
size is still the size given by the <filter> element.

Tests: svg/filters/big-sized-filter-2.svg

svg/filters/big-sized-filter.svg
svg/filters/filterRes.svg

  • platform/graphics/FloatRect.cpp: (WebCore::FloatRect::scale): Add the abbility to scale a rect by x and y.
  • platform/graphics/FloatRect.h: (WebCore::FloatRect::scale): Add the abbility to scale a rect by x and y.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::createPlatformShadow): Use scaledSubRegion for calculation.
  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply): Use scaledSubRegion for effect intern calculations.
  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply): Use scaledSubRegion for effect intern calculations.
  • platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply): Use scaledSubRegion for effect intern calculations.
  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply): Use scaledSubRegion for effect intern calculations.
  • platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply): Use scaledSubRegion for effect intern calculations.
  • platform/graphics/filters/Filter.h: Add the abbility to change the quality of a filter output. (WebCore::Filter::filterResolution): (WebCore::Filter::setFilterResolution): (WebCore::Filter::calculateEffectSubRegion): Calculates the correct subRegion as well as the scaledSubRegion. It also searches for the biggest effect size. We have to change the filter resolution, if one intermediate ImageBuffer size doesn't fit in the maximal image size.
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::calculateDrawingIntRect): Use scaledSubRegion to get the right part of a previous effect result. (WebCore::FilterEffect::calculateDrawingRect): Use scaledSubRegion to get the right part of a previous effect result. (WebCore::FilterEffect::getEffectContext): Use scaledSubRegion to create a new intermediate ImageBuffer for the result of the current effect.
  • platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::scaledSubRegion): The scaled subRegion of a the filter effect. (WebCore::FilterEffect::setScaledSubRegion): (WebCore::FilterEffect::effectBoundaries): The original values of the EffectElement for a second subRegion calculation. (WebCore::FilterEffect::setEffectBoundaries):
  • platform/graphics/filters/ImageBufferFilter.cpp: (WebCore::ImageBufferFilter::ImageBufferFilter): Set the scale factor to one.
  • platform/graphics/filters/ImageBufferFilter.h: (WebCore::ImageBufferFilter::maxImageSize): (WebCore::ImageBufferFilter::calculateEffectSubRegion):
  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::calculateEffectRect): Use scaledSubRegion for effect intern calculations.
  • platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::calculateEffectRect): Use scaledSubRegion for effect intern calculations.
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::parseMappedAttribute): Parse filterRes attribute. (WebCore::SVGFilterElement::buildFilter): Give SVGResourceFilter the current filterResolution.
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes): Save values to effectBoundaries of the filter effect
  • svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::shouldProcessFilter): Return signal if a neccessary value is zero. (WebCore::SVGResourceFilter::fitsInMaximumImageSize): Checks if the given size fits into the maximal image size, modifys scale factors if not and return a bool: fits. (WebCore::SVGResourceFilter::prepareFilter): Scale the SourceImage to filterResolution (given by FilterElement or calculated on to big image sizes). Set the scale level to SVGFilter. (WebCore::SVGResourceFilter::applyFilter): Don't apply filters if shouldProcessFilter is wrong.
  • svg/graphics/SVGResourceFilter.h: (WebCore::SVGResourceFilter::setFilterResolution): FilterResolution of FilterElement. (WebCore::SVGResourceFilter::setHasFilterResolution): Does FilterElement provides a FilterResolution? (WebCore::SVGResourceFilter::scaleX): Current scale factor for horizontal. (WebCore::SVGResourceFilter::scaleY): Current scale factor for vertical.
  • svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply): Use scaledSubRegion for effect intern calculations. Kernel values are scaled to current filter resolution too.
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply): Use scaledSubRegion for effect intern calculations.
  • svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply): Use scaledSubRegion for effect intern calculations. Kernel values are scaled to current filter resolution too.
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply): Use scaledSubRegion for effect intern calculations. Kernel values are scaled to current filter resolution too.
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply): Use scaledSubRegion for effect intern calculations.
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply): Use scaledSubRegion for effect intern calculations.
  • svg/graphics/filters/SVGFilter.cpp: (WebCore::SVGFilter::calculateEffectSubRegion): Calculate subRegion for LayoutTests, scaledSubRegion according to the current filterResolution and get the maximal image size.
  • svg/graphics/filters/SVGFilter.h: (WebCore::SVGFilter::effectBoundingBoxMode): Original values of the FilterElement. (WebCore::SVGFilter::filterRegion): Use virtual for clarification. (WebCore::SVGFilter::sourceImageRect): Use virtual for clarification. (WebCore::SVGFilter::maxImageSize): Get the maximal image size.
08:05 Changeset [51309] by kdecker@apple.com

Reviewed by Adam Roben.


<rdar://problem/7401503>


Added a workaround for plug-ins not drawing immediately.


  • Plugins/WebBaseNetscapePluginView.mm: Added new constant. (-[WebBaseNetscapePluginView _clearSubstituteImage]): Added. (-[WebBaseNetscapePluginView resumeFromHalt]): Call above new method.
07:27 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
07:17 Changeset [51308] by eric@webkit.org

2009-11-23 David Boddie <dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Updated the QWebElement documentation with links to examples and
external resources.
Fixed the project file for the webelement snippet and tidied up the
markers used for quoting the code.

  • Api/qwebelement.cpp:
  • docs/webkitsnippets/webelement/main.cpp: (findAll):
  • docs/webkitsnippets/webelement/webelement.pro:
07:02 QtBackLog edited by zecke@selfish.org
Mention QtPlugin bug (diff)
07:00 QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
(diff)
06:37 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:31 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:29 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:29 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:25 QtWebKitJournal edited by hausmann@webkit.org
(diff)
05:04 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:02 Changeset [51307] by hausmann@webkit.org

[Symbian] Fix lastIndexOf() for Symbian
https://bugs.webkit.org/show_bug.cgi?id=31773

Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2009-11-23
Reviewed by Kenneth Rohde Christiansen.

Symbian soft floating point library has problems with operators
comparing NaN to numbers. Without a workaround lastIndexOf()
function does not work.

Patch developed by David Leong.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncLastIndexOf):Add an extra test
to check for NaN for Symbian.

04:58 Changeset [51306] by eric@webkit.org

2009-11-23 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Wrong runtime instance objects of wrapped QObjects may be used if
the wrapped object died before the gc removed the instance.

https://bugs.webkit.org/show_bug.cgi?id=31681

Before using a cached instance, verify that its wrapped QObject is
still alive.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getQtInstance):
  • bridge/qt/qt_instance.h: (JSC::Bindings::QtInstance::hashKey):

2009-11-23 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Wrong runtime instance objects of wrapped QObjects may be used if
the wrapped object died before the gc removed the instance.

https://bugs.webkit.org/show_bug.cgi?id=31681

Added a unit-test to verify that wrapping a QObject with the
same identity as a previously but now dead object works.

  • tests/qwebframe/tst_qwebframe.cpp:
03:29 Changeset [51305] by steveblock@google.com

Android port lacks implementation of atomicIncrement and atomicDecrement

11/22/09:

22:21 Changeset [51304] by eric@webkit.org

2009-11-22 Chris Fleizach <cfleizach@apple.com>

Reviewed by Oliver Hunt.

ARIA: support aria-flowto
https://bugs.webkit.org/show_bug.cgi?id=31762

  • platform/mac/accessibility/aria-flowto-expected.txt: Added.
  • platform/mac/accessibility/aria-flowto.html: Added.

2009-11-22 Chris Fleizach <cfleizach@apple.com>

Reviewed by Oliver Hunt.

ARIA: support aria-flowto
https://bugs.webkit.org/show_bug.cgi?id=31762

Test: platform/mac/accessibility/aria-flowto.html

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::ariaOwnsElements): (WebCore::AccessibilityObject::supportsARIAFlowTo): (WebCore::AccessibilityObject::ariaFlowToElements):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::linkedUIElements): (WebCore::AccessibilityRenderObject::supportsARIAFlowTo): (WebCore::AccessibilityRenderObject::ariaFlowToElements):
  • accessibility/AccessibilityRenderObject.h:
  • html/HTMLAttributeNames.in:

2009-11-22 Chris Fleizach <cfleizach@apple.com>

Reviewed by Oliver Hunt.

ARIA: support aria-flowto
https://bugs.webkit.org/show_bug.cgi?id=31762

  • DumpRenderTree/AccessibilityUIElement.cpp: (ariaFlowToElementAtIndexCallback): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::ariaFlowToElementAtIndex):
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::ariaFlowToElementAtIndex):
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::ariaFlowToElementAtIndex):
20:27 Changeset [51303] by mitz@apple.com

Updated WebKitSystemInterface.

Reviewed by Eric Carlson.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
19:45 Changeset [51302] by laszlo.1.gombos@nokia.com

2009-11-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed.

[Qt] Sort source lists and remove obsolete comments
from the build system.

17:38 HighLevelOverview edited by chris.jerdonek@gmail.com
Added information about JavaScriptGlue (diff)
17:33 Changeset [51301] by eric@webkit.org

2009-11-22 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Tests to the filterRes implementation for SVG Filters
https://bugs.webkit.org/show_bug.cgi?id=6021

big-sized-filter: tests if filter quality is scaled down on a too

big SourceImage (SourceGraphic, SourceAlpha)

big-sized-filter-2: tests if the filter quality is scaled down

on a too big filter effect size.

filterRes: Various tests of SVG Filters with different values for

filterRes attributes. Checks

  • that kernel values (if present) are scaled with the filterRes
  • subRegion calculation is correct for effects with deeper dependencies.
  • platform/mac/svg/filters/big-sized-filter-2-expected.txt: Added.
  • platform/mac/svg/filters/big-sized-filter-expected.checksum: Added.
  • platform/mac/svg/filters/big-sized-filter-expected.png: Added.
  • platform/mac/svg/filters/big-sized-filter-expected.txt: Added.
  • platform/mac/svg/filters/filterRes-expected.checksum: Added.
  • platform/mac/svg/filters/filterRes-expected.png: Added.
  • platform/mac/svg/filters/filterRes-expected.txt: Added.
  • svg/filters/big-sized-filter-2.svg: Added.
  • svg/filters/big-sized-filter.svg: Added.
  • svg/filters/filterRes.svg: Added.
17:29 Changeset [51300] by zimmermann@webkit.org

Not reviewed. Build fix for WML enabled builds.
Adopt WebCore API changes.

15:14 Changeset [51299] by tonikitoo@webkit.org

[Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
https://bugs.webkit.org/show_bug.cgi?id=31638

Reviewed by Kenneth Christiansen.

Unfreeze WorkQueue after each test execution.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

14:29 Changeset [51298] by eric@webkit.org

2009-11-22 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Barth.

[Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
for localhost and 127.0.0.1.
https://bugs.webkit.org/show_bug.cgi?id=31783

Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.

  • platform/qt/Skipped:

2009-11-22 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Barth.

[Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
for localhost and 127.0.0.1.
https://bugs.webkit.org/show_bug.cgi?id=31783

Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::NetworkAccessManager::NetworkAccessManager): (WebCore::NetworkAccessManager::sslErrorsEncountered): (WebCore::WebPage::WebPage):
  • DumpRenderTree/qt/DumpRenderTree.h:
12:54 BuildingQtOnLinux edited by faw217@gmail.com
libxslt is no longer required (diff)
12:05 Changeset [51297] by pfeldman@chromium.org

2009-11-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Introduce sidebar background on timeline panel in order
to prevent it from flickering on scroll.

https://bugs.webkit.org/show_bug.cgi?id=31789

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.setSidebarWidth): (WebInspector.TimelinePanel.prototype._onScroll): (WebInspector.TimelinePanel.prototype._scheduleRefresh):
  • inspector/front-end/inspector.css:
10:25 Changeset [51296] by pfeldman@chromium.org

2009-11-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Reimplement TimelinePanel to make it fast:

  • Extract grid and overview into separate files
  • Make timeline create only divs for visible rows

https://bugs.webkit.org/show_bug.cgi?id=31784

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.createInterface): (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelinePanel.prototype.set calculator):
  • inspector/front-end/TimelineGrid.js: Added. (WebInspector.TimelineGrid): (WebInspector.TimelineGrid.prototype.get itemsGraphsElement): (WebInspector.TimelineGrid.prototype.updateDividers): (WebInspector.TimelineGrid.prototype.addEventDivider): (WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
  • inspector/front-end/TimelineOverviewPane.js: Added. (WebInspector.TimelineOverviewPane): (WebInspector.TimelineOverviewPane.prototype._onCheckboxClicked): (WebInspector.TimelineOverviewPane.prototype.update): (WebInspector.TimelineOverviewPane.prototype.setSidebarWidth): (WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth): (WebInspector.TimelineOverviewPane.prototype.reset): (WebInspector.TimelineOverviewPane.prototype._resizeWindow): (WebInspector.TimelineOverviewPane.prototype._windowResizeDragging): (WebInspector.TimelineOverviewPane.prototype._dragWindow): (WebInspector.TimelineOverviewPane.prototype._windowDragging): (WebInspector.TimelineOverviewPane.prototype._resizeWindowLeft): (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight): (WebInspector.TimelineOverviewPane.prototype._setWindowPosition): (WebInspector.TimelineOverviewPane.prototype._endWindowDragging): (WebInspector.TimelineOverviewCalculator): (WebInspector.TimelineOverviewCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineOverviewCalculator.prototype.reset): (WebInspector.TimelineOverviewCalculator.prototype.updateBoundaries): (WebInspector.TimelineOverviewCalculator.prototype.get boundarySpan): (WebInspector.TimelineOverviewCalculator.prototype.formatValue): (WebInspector.TimelineCategoryTreeElement): (WebInspector.TimelineCategoryTreeElement.prototype.onattach): (WebInspector.TimelineCategoryGraph): (WebInspector.TimelineCategoryGraph.prototype.get graphElement): (WebInspector.TimelineCategoryGraph.prototype.addChunk): (WebInspector.TimelineCategoryGraph.prototype.clearChunks): (WebInspector.TimelineCategoryGraph.prototype.set dimmed):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked): (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype.setSidebarWidth): (WebInspector.TimelinePanel.prototype.updateMainViewWidth): (WebInspector.TimelinePanel.prototype.resize): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype.show): (WebInspector.TimelinePanel.prototype._onScroll): (WebInspector.TimelinePanel.prototype._scheduleRefresh): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelinePanel.prototype._adjustScrollPosition): (WebInspector.TimelineCategory): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.get boundarySpan): (WebInspector.TimelineRecordListRow): (WebInspector.TimelineRecordListRow.prototype.update): (WebInspector.TimelineRecordGraphRow): (WebInspector.TimelineRecordGraphRow.prototype.update):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
09:22 Changeset [51295] by abarth@webkit.org

2009-11-22 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Disable access to file:/// directory listings
https://bugs.webkit.org/show_bug.cgi?id=31329

Updates the test to make sure it is disabling universal access for
file:/// URLs (if the API is supported). This is required to do
effective intra-file:/// access tests.
Note that Safari only passes by virtual of supporting no directory
listings at all.

  • fast/xmlhttprequest/resources/xmlhttprequest-nonexistent-file-real.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html: Disable universal access for file:/// URLs (if API available). Run the real test in an iframe without universal access.

2009-11-22 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Disable access to file:/// directory listings
https://bugs.webkit.org/show_bug.cgi?id=31329

Deny access to directory listings. This needs doing in WebKit for
WebKit clients that do permit top-level navigation to file:///dir.
This matches Firefox, plus the existing Safari implementation (which
does not support any directory access at all). It will fix the
LayoutTest named below for Chromium.

Test: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html

  • page/SecurityOrigin.cpp: Deny access to directory listings. (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canRequest):

2009-11-22 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Disable access to file:/// directory listings
https://bugs.webkit.org/show_bug.cgi?id=31329

Implemented setAllowUniversalAccessFromFileURLs to support testing of
file URL security.

  • DumpRenderTree/LayoutTestController.cpp: (setAllowUniversalAccessFromFileURLsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
09:22 Changeset [51294] by abarth@webkit.org

2009-11-22 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Updates the test to make sure it is disabling universal access for
file:/// URLs (if the API is supported). This is required to do
effective intra-file:/// access tests.
Note that Safari only passes by virtual of supporting no directory
listings at all.

  • fast/xmlhttprequest/resources/xmlhttprequest-nonexistent-file-real.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html: Disable universal access for file:/// URLs (if API available). Run the real test in an iframe without universal access.

2009-11-22 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Deny access to directory listings. This needs doing in WebKit for
WebKit clients that do permit top-level navigation to file:///dir.
This matches Firefox, plus the existing Safari implementation (which
does not support any directory access at all). It will fix the
LayoutTest named below for Chromium.

Test: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html

  • page/SecurityOrigin.cpp: Deny access to directory listings. (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canRequest):

2009-11-22 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Implemented setAllowUniversalAccessFromFileURLs to support testing of
file URL security.

  • DumpRenderTree/LayoutTestController.cpp: (setAllowUniversalAccessFromFileURLsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
07:16 Changeset [51293] by eric@webkit.org

2009-11-22 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the timeout of fast/frames/frame-navigation.html
https://bugs.webkit.org/show_bug.cgi?id=31638

The test is timeouting, because it uses the WorkQueue to load a document in one
of the child frames and once the loading is finished, the DRT does not dump the
tree. This is because it waits for the QWebFrame::loadFinished() signal from
the main frame, while it should connect to QWebPage::loadFinished().

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
02:04 Changeset [51292] by mitz@apple.com

Fixed a leak in WKDrawMediaUIPart().

Reviewed by Cameron Zwarich.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

11/21/09:

19:39 Changeset [51291] by joepeck@webkit.org

2009-11-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Support Ctrl+P and Ctrl+N, Readline keyboard shortcuts in the Console
https://bugs.webkit.org/show_bug.cgi?id=31400

Handle the following when on a Mac:

Ctrl+P = Previous (like Up arrow)
Ctrl+N = Next (like Down arrow)

No longer rerun autocompletion when just pushing a modifier key
like Control, Alt, Shift, or Meta.

Improved arrow key behavior with Multiline code in the Console, with the following behavior:

Up = Previous Command if on First Line (caret moves to the end of the first line)

otherwise default caret movement in text.

Down = Next Command if on Last Line (caret naturally moves to the end)

otherwise default caret movement in text.

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.handleKeyEvent): handle new keyboard shortcuts (WebInspector.TextPrompt.prototype.isCaretOnFirstLine): check if the caret is on the top line (WebInspector.TextPrompt.prototype.isCaretOnLastLine): check if the caret is on the bottom line (WebInspector.TextPrompt.prototype._upKeyPressed): (WebInspector.TextPrompt.prototype._downKeyPressed): (WebInspector.TextPrompt.prototype._moveBackInHistory): (WebInspector.TextPrompt.prototype._moveForwardInHistory):
19:04 Changeset [51290] by jberlin@webkit.org

Adds a tooltip containing the full url of the resource to each element
in the Resources panel so that it is possible to quickly see the query
parameters.
https://bugs.webkit.org/show_bug.cgi?id=19103

Reviewed by Timothy Hatcher.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourceSidebarTreeElement.prototype.refresh):
Set the tooltip to be the resource's url.

16:18 Changeset [51289] by simon.fraser@apple.com

2009-11-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

CSSKeyframesRule::findRule() and deleteRule() should accept 'from' and 'to' as well as percentages
https://bugs.webkit.org/show_bug.cgi?id=31588

In WebKitCSSKeyframesRule::findRuleIndex(), map 'from' to 0% an 'to' to 100%
so that findRule() and deleteRule() work with these keywords.

  • css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
15:13 Changeset [51288] by eric@webkit.org

2009-11-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt][Mac] Turn on multiple JavaScript threads for QtWebkit on Mac
https://bugs.webkit.org/show_bug.cgi?id=31753

  • wtf/Platform.h:
13:34 Changeset [51287] by eric@webkit.org

2009-11-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool --help spews way too much text
https://bugs.webkit.org/show_bug.cgi?id=31771

  • Scripts/bugzilla-tool:
    • Remove self.cached_scm initialization hack.
  • Scripts/modules/buildbot.py:
    • Make default_host accessible to callers.
  • Scripts/modules/commands/download.py:
    • Phrase help for all commands consistently and remove spurious help text punctuation.
  • Scripts/modules/commands/queries.py: Ditto.
  • Scripts/modules/commands/queues.py: Ditto.
  • Scripts/modules/commands/upload.py: Ditto.
  • Scripts/modules/multicommandtool.py:
    • Add HelpPrintingOptionParser.format_epilog to replace NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
    • Make --help only show a list of commands like "svn help" and "git help" do -- previously --help was listing all commands and options.
    • Sort list of commands alphabetically.
13:32 Changeset [51286] by jhoneycutt@apple.com

2009-11-21 Jon Honeycutt <jhoneycutt@apple.com>

Windows build fix. Unreviewed.

  • Interfaces/IWebSerializedJSValue.idl:
13:26 Changeset [51285] by eric@webkit.org

2009-11-21 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31647

Changed KeyboardEvent::m_keyEvent from a raw pointer to an OwnPtr.

No functionality was changed. So, no new tests.

  • dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::~KeyboardEvent):
  • dom/KeyboardEvent.h: Changed m_keyEvent to OwnPtr. (WebCore::KeyboardEvent::keyEvent):
13:12 Changeset [51284] by eric@webkit.org

2009-11-21 Eric Seidel <eric@webkit.org>

No review. Fixing a typo from the previous patch for bug 31767.

AbstractQueue.run_bugzilla_tool throws an exception
https://bugs.webkit.org/show_bug.cgi?id=31769

  • Scripts/modules/commands/queues.py:
07:50 Changeset [51283] by eric@webkit.org

2009-11-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
https://bugs.webkit.org/show_bug.cgi?id=31767

What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
Since we don't have a good way to test BugzillaTool pieces, I've
left out a test for now.

  • Scripts/bugzilla-tool:
    • Add a path() implementation to expose bugzilla-tool's file path to commit-queue.
  • Scripts/modules/commands/queues.py:
    • Use tool.path() instead of file.
  • Scripts/modules/multicommandtool.py:
    • Add a new path() method to MultiComandTool.
  • Scripts/modules/multicommandtool_unittest.py:
    • Provide a path() method. Little point in testing this mock implementation.
07:37 Changeset [51282] by abarth@webkit.org

2009-11-21 Adam Barth <abarth@webkit.org>

Unreviewed "build" fix. Turns out I was testing the wrong copy of
WebKitTools.

  • Scripts/modules/commands/download.py:
07:29 Changeset [51281] by abarth@webkit.org

2009-11-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Convert check-style to use LandingSequence
https://bugs.webkit.org/show_bug.cgi?id=31763

Instead of manipulating the working copy by hand, we should use the
LandingSequence in CheckStyle. This will make this code eaiser to
test.

  • Scripts/modules/commands/download.py:
00:53 Web Inspector Update.ja edited by keishi@webkit.org
(diff)
00:52 WebKit nightlies support HTML5 noreferrer link relation.ja created by keishi@webkit.org
00:50 Web Inspector Update.ja edited by keishi@webkit.org
(diff)
00:48 Surfin' Safari Translations edited by keishi@webkit.org
(diff)
Note: See TracTimeline for information about the timeline view.