Timeline


and

11/30/09:

23:37 Changeset [51527] by hamaji@chromium.org

2009-11-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dan Bernstein.

css2.1/t1205-c566-list-stl-00-e-ag.html is failing
https://bugs.webkit.org/show_bug.cgi?id=23264
css2.1/t1205-c565-list-pos-00-b.html is failing
https://bugs.webkit.org/show_bug.cgi?id=23263

Ignore whitespaces after list markers.
Rendering of this was already done for the case where inside=false.
This fixes the rendering of inside=true case and calcInlinePrefWidths.

Test: fast/lists/calc-width-with-space.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):

2009-11-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dan Bernstein.

css2.1/t1205-c566-list-stl-00-e-ag.html is failing
https://bugs.webkit.org/show_bug.cgi?id=23264

  • editing/pasteboard/copy-crash-expected.txt:
  • fast/lists/calc-width-with-space-expected.txt: Added.
  • fast/lists/calc-width-with-space.html: Added.
  • platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.checksum:
  • platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.png:
  • platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.txt:
  • platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.checksum:
  • platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.png:
  • platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.txt:
  • platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.checksum:
  • platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.png:
  • platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
  • platform/mac/fast/block/positioning/complex-percentage-height-expected.checksum:
  • platform/mac/fast/block/positioning/complex-percentage-height-expected.png:
  • platform/mac/fast/block/positioning/complex-percentage-height-expected.txt:
  • platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.checksum:
  • platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.png:
  • platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.txt:
  • platform/mac/fast/repaint/list-marker-expected.checksum:
  • platform/mac/fast/repaint/list-marker-expected.png:
  • platform/mac/fast/repaint/list-marker-expected.txt:
  • platform/qt/Skipped:
23:25 Changeset [51526] by abarth@webkit.org

2009-11-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

check-webkit-style is slightly too verbose
https://bugs.webkit.org/show_bug.cgi?id=32010

check-webkit-style prints out a bunch of "done" lines that seem redundant,
especially for the style-queue.

  • Scripts/modules/cpp_style.py:
22:41 Changeset [51525] by eric@webkit.org

2009-11-30 Alejandro G. Castro <alex@igalia.com>

Reviewed by Eric Seidel.

[GTK] Moved the functions that are closing the result log of the
tests to the last line of the runTest function, this avoids
reporting crashes in the wrong test if there is a problem when
reseting the state after the test.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): (runTest):
19:33 Changeset [51524] by ukai@chromium.org

2009-11-30 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed Chromium build fix introduced by r51212

Fix scriptStateFromNode and ScriptStateFromPage to take DOMWrapperWorld
as the first argument.
Move mainThreadNormalWorld() to ScriptState.{h,cpp}.
Add debuggerWorld() and pluginWorld() in ScriptState.h.

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptState.cpp: (WebCore::scriptStateFromNode): (WebCore::scriptStateFromPage): (WebCore::mainThreadNormalWorld):
  • bindings/v8/ScriptState.h: (WebCore::debuggerWorld): (WebCore::pluginWorld):
17:18 Changeset [51523] by weinig@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
fast/js/date-proto-generic-invocation breaks another test

Reviewed by Geoffrey Garen.

Don't cache JSClassRefs, a change to the prototype chain will
last between tests.

  • DumpRenderTree/AccessibilityController.cpp:

(AccessibilityController::getJSClass):

  • DumpRenderTree/GCController.cpp:

(GCController::getJSClass):

  • DumpRenderTree/GCController.h:
  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::getJSClass):

16:44 Changeset [51522] by enrica@apple.com

WebCore: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
https://bugs.webkit.org/show_bug.cgi?id=31750

Reviewed by Darin Adler.

The goal is to change the way we choose a visible position
after hit detection, by preferring a visually equivalent editable
position if available. By doing this, it is possible to add content
to an editable block that initially contains only non editable elements.

Test: editing/selection/mixed-editability-10.html

  • WebCore.base.exp: Changed to match the new signature of downstream

and upstream in the Position class.

  • dom/Position.cpp:

(WebCore::Position::atEditingBoundary): Added.
(WebCore::Position::upstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::downstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.
(WebCore::Position::getInlineBoxAndOffset): Modified to retrieve the inline box
to be used in calculating the caret rectangle.

  • dom/Position.h:

(WebCore::Position::):

  • dom/PositionIterator.cpp:

(WebCore::PositionIterator::atEditingBoundary): Added.
(WebCore::PositionIterator::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.

  • dom/PositionIterator.h:
  • editing/htmlediting.cpp:

(WebCore::firstEditablePositionAfterPositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.
(WebCore::lastEditablePositionBeforePositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createVisiblePosition): Added logic to prefer an editable position,
if available.

  • rendering/RenderText.cpp:

(WebCore::RenderText::isAllCollapsibleWhitespace): Added.

  • rendering/RenderText.h:

LayoutTests: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
https://bugs.webkit.org/show_bug.cgi?id=31750

Reviewed by Darin Adler.

  • editing/selection/5825350-1-expected.txt:
  • editing/selection/5825350-1.html: Modified to use caret rectangle.
  • editing/selection/5825350-2-expected.txt:
  • editing/selection/5825350-2.html: Modified to use caret rectangle.
  • editing/selection/mixed-editability-10-expected.txt: Added.
  • editing/selection/mixed-editability-10.html: Added.
  • platform/mac/editing/deleting/5390681-2-expected.txt: Re-baselined

to account for the new possible caret position.

16:40 Changeset [51521] by eric@webkit.org

2009-11-30 Yuzo Fujishima <yuzo@google.com>

Reviewed by Alexey Proskuryakov.

Update pywebsocket to 0.4.2.1.
This is to fix a bug that some messages are logged to stderr even when the log file is specified.
https://bugs.webkit.org/show_bug.cgi?id=31976

  • pywebsocket/mod_pywebsocket/standalone.py:
  • pywebsocket/setup.py:
16:12 Changeset [51520] by kevino@webkit.org

wx build fix, add header needed for wx build.

16:08 Changeset [51519] by mrowe@apple.com

<rdar://problem/7424387> WebCore binary missing symbols when built for x86_64 from a machine that cannot run x86_64 binaries

Reviewed by David Kilzer.

The check for whether WTF_USE_PLUGIN_HOST_PROCESS is defined occurs under the native architecture of the build machine.
If that is 32-bit then WTF_USE_PLUGIN_HOST_PROCESS will not be defined. We work around this by forcing the check to
be performed against the x86_64 architecture.

  • DerivedSources.make:
16:07 Changeset [51518] by eric@webkit.org

2009-11-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Generate pass messages for style-queue
https://bugs.webkit.org/show_bug.cgi?id=31995

With this change, the style-queue posts "pass" messages to bugs as
well. Also, added more information to the state store w.r.t. passing
and failing.

  • Scripts/modules/commands/queues.py:
  • Scripts/modules/patchcollection.py:
15:55 Changeset [51517] by bdakin@apple.com

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in
Safari caused by extreme column-gap and column-width values
-and corresponding-
<rdar://problem/7425433>

Reviewed by Oliver Hunt.

Prevent desiredColumnCount from being less than 1 since it is used
as a divisor.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::calcColumnWidth):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in
Safari caused by extreme column-gap and column-width values
-and corresponding-
<rdar://problem/7425433>

Reviewed by Oliver Hunt.

  • fast/multicol/huge-column-gap-crash-expected.txt: Added.
  • fast/multicol/huge-column-gap-crash.html: Added.
15:48 Changeset [51516] by ap@apple.com

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=31659
Connection must be closed in case of Web Socket handshake error

The network connection was closed, but the close event wasn't dispatched.

Tested by websocket/tests/handshake-error.html, which is un-skipped now.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose): Call client didHandle() method. This looks strange in CFNetwork implementation, because it's the client that asked to close the stream, so it shouldn't need the callback. It makes more sense in cross-process implementation, because closing is async there.
15:45 UsingGitWithWebKit edited by eric@webkit.org
(diff)
15:20 Changeset [51515] by eric@webkit.org

2009-11-30 Abhinav Mithal <abhinav.mithal@nokia.com>

Reviewed by Simon Hausmann.

[Qt][Symbian] Report SymbianOS in user agent string for Symbian
https://bugs.webkit.org/show_bug.cgi?id=31961

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
14:10 Changeset [51514] by barraclough@apple.com

Windows Build fix. Reviewed by NOBODY.

14:02 Changeset [51513] by mrowe@apple.com

Use the correct path to Info.plist to avoid creating an empty file at the top of the WebKit directory.

  • WebKit.xcodeproj/project.pbxproj:
13:48 Changeset [51512] by barraclough@apple.com

Bug 31859 - Make world selection for JSC IsolatedWorlds automagical.

Reviewed by Geoff Garen.

JavaScriptCore:

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Remove the temporary duct tape of willExecute/didExecute virtual hooks on the JSGlobalData::ClientData - these are no longer necessary.

  • API/JSBase.cpp:

(JSEvaluateScript):

  • API/JSObjectRef.cpp:

(JSObjectCallAsFunction):

  • JavaScriptCore.exp:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalData.h:

WebCore:

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Remove the last uses of mainThreadCurrentWorld(), so the world is always obtained via
currentWorld(). Switch this to obtain the world from the ExecsState's lexical global
object instead. Remove the call/construct/evaluate 'InWorld' methods, since these
are no longer necessary.

  • WebCore.base.exp:
  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCallbackData.h:

(WebCore::JSCallbackData::JSCallbackData):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::currentWorld):
(WebCore::mainThreadNormalWorld):

  • bindings/js/JSDOMBinding.h:

(WebCore::WebCoreJSClientData::WebCoreJSClientData):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::updateDocument):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::open):

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode):

  • bindings/js/JSQuarantinedObjectWrapper.cpp:

(WebCore::JSQuarantinedObjectWrapper::construct):
(WebCore::JSQuarantinedObjectWrapper::call):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::executeFunctionInContext):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):

  • bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):

  • bindings/js/ScriptObjectQuarantine.cpp:

(WebCore::getQuarantinedScriptObject):

  • bindings/js/ScriptState.cpp:

(WebCore::scriptStateFromNode):
(WebCore::scriptStateFromPage):

  • bindings/js/ScriptState.h:
  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):

  • bridge/NP_jsobject.cpp:

(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_Construct):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::call):
(JavaJSObject::eval):

  • dom/NodeFilter.h:

(WebCore::NodeFilter::acceptNode):

  • dom/NodeIterator.h:

(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):

  • dom/TreeWalker.h:

(WebCore::TreeWalker::parentNode):
(WebCore::TreeWalker::firstChild):
(WebCore::TreeWalker::lastChild):
(WebCore::TreeWalker::previousSibling):
(WebCore::TreeWalker::nextSibling):
(WebCore::TreeWalker::previousNode):
(WebCore::TreeWalker::nextNode):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::didEvaluateForTestInFrontend):

  • inspector/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::evaluate):

WebKit/mac:

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Since WebCore no longer needs to explicitly specify the world on entry to JSC DebuggerCallFrame::evaluate can be called directly.

  • WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame evaluateWebScript:]):

13:43 Changeset [51511] by eric.carlson@apple.com

2009-11-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

All HTML5 media element events should be regular events
https://bugs.webkit.org/show_bug.cgi?id=30513

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectMediaResource): (WebCore::HTMLMediaElement::noneSupported): (WebCore::HTMLMediaElement::mediaEngineError): (WebCore::HTMLMediaElement::setNetworkState): (WebCore::HTMLMediaElement::userCancelledLoad):

Call scheduleEvent instead of scheduleProgressEvent.

(WebCore::HTMLMediaElement::progressEventTimerFired):

Call scheduleEvent instead of scheduleProgressEvent. Call renderer->updateFromElement
after scheduling a 'progress' event so the controller will update download
progress indicator.

  • html/HTMLMediaElement.h:

Remove scheduleProgressEvent prototype.

2009-11-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

All HTML5 media element events should be regular events
https://bugs.webkit.org/show_bug.cgi?id=30513


Remove progress event tests.

  • media/progress-event-at-least-one-expected.txt: Removed.
  • media/progress-event-at-least-one.html: Removed.
  • media/progress-event-expected.txt: Removed.
  • media/progress-event-total-expected.txt: Removed.
  • media/progress-event-total.html: Removed.
  • media/progress-event.html: Removed.
13:41 Changeset [51510] by aroben@apple.com

Fix double-free of BSTRs passed to WebNavigationData::createInstance

WebFrameLoaderClient::updateGlobalHistory was converting
WebCore::Strings to WebCore::BStrings, then passing them to
WebNavigationData::createInstance. But the latter function takes BSTR
parameters and adopts them into WebCore::BStrings. So the end result
was that two WebCore::BStrings would end up freeing each underlying
BSTR.

The fix is to only convert to WebCore::BString inside
WebNavigationData.

Fixes <http://webkit.org/b/31998> <rdar://problem/7383452> REGRESSION
(r49564): Crash in updateGlobalHistory when running Javascript iBench
test

I couldn't find a way to reproduce this in DumpRenderTree.

Reviewed by Steve Falkenburg.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::updateGlobalHistory): Pass WebCore::Strings to
WebNavigationData::createInstance.

  • WebNavigationData.cpp:

(WebNavigationData::WebNavigationData):
(WebNavigationData::createInstance):

  • WebNavigationData.h:

Changed to take const WebCore::String&s instead of BSTRs and to
convert the Strings to BStrings at this level.

13:38 Changeset [51509] by ap@apple.com

It was me who reviewed the patch, not Eric! Alas, some tools we use cause wrong reviewer information in Bugzilla.

13:35 Changeset [51508] by ap@apple.com

2009-11-30 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

In testing handshake-error case, web_socket_do_extra_handshake calls a non-existent method
https://bugs.webkit.org/show_bug.cgi?id=31465

  • platform/mac/Skipped: websocket/tests/handshake-error.html now fails on Mac, added to Skipped list, and filed bug 31659 to investigate.
  • websocket/tests/handshake-error_wsh.py: Call write() on a correct object.
13:27 Changeset [51507] by joepeck@webkit.org

Remove file git invisibly added

13:19 Changeset [51506] by joepeck@webkit.org

2009-11-30 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Wrong console output for Regexp escape sequence
https://bugs.webkit.org/show_bug.cgi?id=31538

Updated inspector/console-format.html

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createDividerElement): style issues. (WebInspector.ConsoleView.createFilterElement): style issues. (WebInspector.ConsoleView): added _customFormatters table. (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): style isses. (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): style issues. (WebInspector.ConsoleView.prototype._format): simplified delegation to formatter logic. (WebInspector.ConsoleView.prototype._formatobject): (WebInspector.ConsoleView.prototype._formatnode): (WebInspector.ConsoleView.prototype._printArray): (WebInspector.ConsoleMessage.prototype._format): commented and broke down the algorithm into parts. (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append): handle substitution string formatting. (WebInspector.ConsoleMessage.prototype._formatIndividualValue): handling individual value formatting. (WebInspector.ConsoleCommandResult):
  • inspector/front-end/InjectedScript.js: simplified regex formatting.
  • inspector/front-end/inspector.js: (WebInspector.linkifyStringAsFragment): converted new RegExp to literal for performance benefits.
  • inspector/front-end/utilities.js: (Element.prototype.hasStyleClass): update inaccurate comment. (String.prototype.trimURL): converted new RegExp to literal for performance benefits.
12:42 Changeset [51505] by eric@webkit.org

2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove obsolete PLATFORM(KDE) code
https://bugs.webkit.org/show_bug.cgi?id=31958

KDE is now using unpatched QtWebKit.

  • parser/Lexer.cpp: Remove obsolete KDE_USE_FINAL guard
  • wtf/Platform.h: Remove PLATFORM(KDE) definition and code section that is guarded with it.
11:55 Changeset [51504] by kov@webkit.org

Skipping test that fails because of broken DND, and some tests
requiring new results.

  • platform/gtk/Skipped:
11:31 Changeset [51503] by kov@webkit.org

Tagging 1.1.17.

11:27 Changeset [51502] by kov@webkit.org

Rubber-stamped by Xan Lopez.

Make sure we distribute and install GObject Introspection files.

  • GNUmakefile.am:
10:59 Changeset [51501] by eric@webkit.org

2009-11-30 Erik Arvidsson <arv@chromium.org>

Reviewed by Adam Barth.

Clean up V8 bindings for CSSStyleDeclaration and CSSVariableDeclaration
https://bugs.webkit.org/show_bug.cgi?id=31895

No new tests. This is already covered by:

fast/dom/CSSStyleDeclaration/css-computed-style-item.html
fast/dom/CSSStyleDeclaration/css-style-item.html

  • bindings/v8/V8Collection.h: (WebCore::collectionStringIndexedPropertyGetter): (WebCore::setCollectionStringIndexedGetter):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
10:50 Changeset [51500] by sfalken@apple.com

WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject
https://bugs.webkit.org/show_bug.cgi?id=31986

Reviewed by Adam Roben.

  • WebFrame.cpp:

(WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned.

10:36 QtBackLog edited by zecke@selfish.org
The first set of network changes landed, mark the item as completed. (diff)
09:54 Changeset [51499] by kov@webkit.org

Reviewed by Simon Fraser.

Check for WEBKIT_TESTFONTS environment variable in
run-webkit-tests, for GTK+, to have a more prominent error
message.

  • Scripts/run-webkit-tests:
09:41 Changeset [51498] by eric@webkit.org

2009-11-30 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

Adds include of wtf/StdLibExtras.h for DEFINE_STATIC_LOCAL in V8 ScriptController.
https://bugs.webkit.org/show_bug.cgi?id=31932

Build fix only, no new tests.

  • bindings/v8/ScriptController.cpp: Modified. Adds include of wtf/StdLibExtras.h.
09:34 Changeset [51497] by eric@webkit.org

2009-11-30 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

Adds PassOwnPtr include to ScriptExecutionContext.h.
https://bugs.webkit.org/show_bug.cgi?id=31929

Build fix only, no new tests.

  • dom/ScriptExecutionContext.h: Modified. Adds PassOwnPtr include.
09:25 Changeset [51496] by eric@webkit.org

2009-11-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Complex test of mask with every combination of maskUnits and maskContentUnits
as well as different values for size and position of the mask and it's content.

  • platform/mac/svg/custom/mask-with-all-units-expected.checksum: Added.
  • platform/mac/svg/custom/mask-with-all-units-expected.png: Added.
  • platform/mac/svg/custom/mask-with-all-units-expected.txt: Added.
  • svg/custom/mask-with-all-units.svg: Added.

2009-11-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly
https://bugs.webkit.org/show_bug.cgi?id=31980

It turns out, that we did not handle maskUnits="userSpaceOnUse"
correctly. We just need to move the context of the maskImage
if maskContentUnits="objectBoundingBox". The context gets scaled
on this unit combination, so we have to substract the position of
the targetRect. On userSpaceOnUse the position just depends on the
position of the mask element.
I added a test with some senseless and reasonable values for size
and postion of the mask and it's contents. I also used every
combination of maskUnits and maskContentUnits to be sure, that it
is fixed this time.

Test: svg/custom/mask-with-all-units.svg

  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
09:17 Changeset [51495] by eric@webkit.org

2009-11-30 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=31928

Build fix only, no new tests.

  • page/DOMWindow.cpp: Modified. Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
09:10 Changeset [51494] by eric@webkit.org

2009-11-30 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

update-webkit --chromium forces gclient sync

https://bugs.webkit.org/show_bug.cgi?id=31967

  • Scripts/update-webkit-chromium:
09:03 Changeset [51493] by eric@webkit.org

2009-11-30 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

Adds SHARED_WORKERS guards to V8 WorkerContextExecutionProxy.
https://bugs.webkit.org/show_bug.cgi?id=31926

Build fix only, no new tests.

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::convertToV8Object): (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
08:56 Changeset [51492] by eric@webkit.org

2009-11-30 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Chrome::contentsSizeChanged() is called when the content size has not changed
https://bugs.webkit.org/show_bug.cgi?id=31978

Do not trigger contentsSizeChaned() is the new size is the same as the old one.

  • page/FrameView.cpp: (WebCore::FrameView::setContentsSize):
08:49 Changeset [51491] by eric@webkit.org

2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix minor waning in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=31963

  • tests/qwebpage/tst_qwebpage.cpp: (ErrorPage::extension): Remove info wariable as it is not used.
08:42 Changeset [51490] by eric@webkit.org

2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix some compiler warnings seen on QtWebKit/Mac
https://bugs.webkit.org/show_bug.cgi?id=31962

No new tests as there is no functional change.

  • platform/network/ResourceHandle.h: Make destructor virtual as after r50772 ResourceHandle has virtual functions.
  • plugins/mac/PluginPackageMac.cpp: (WebCore::PluginPackage::fetchInfo): Fix typo WTF is a namespace not a label
  • plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::setNPWindowIfNeeded): Add l to the format specifier
07:36 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:31 Changeset [51489] by mrowe@apple.com

Versioning.

07:30 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:30 Changeset [51488] by mrowe@apple.com

New tag.

07:13 Changeset [51487] by kov@webkit.org

Build fix. Make sure JSCore-1.0.gir is added to the distributed
tarball.

07:09 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:00 QtWebKitJournal edited by hausmann@webkit.org
(diff)
05:53 Changeset [51486] by xan@webkit.org

2009-11-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump versions for 1.1.17 release.

  • configure.ac:

WebCore:

2009-11-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Add new headers to sources list.

  • GNUmakefile.am:

WebKit/gtk:

2009-11-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Prepare for 1.1.17 release.

  • NEWS:
  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
04:08 Changeset [51485] by girish@forwardbias.in

[Qt] Mac Plugins : Get context menu to work in QGraphicsView

Reviewed by Holger Freyther.

Flash expects the value in record.where to be the global position for
displaying the context menu.

https://bugs.webkit.org/show_bug.cgi?id=31979

03:27 Changeset [51484] by hausmann@webkit.org

[Qt] Fix compilation with win32-icc

Patch by Jan-Arve Sæther <jan-arve.saether@nokia.com> on 2009-11-30
Reviewed by Simon Hausmann.

.:

Include os-win32 for stdint.h since MS does not ship that in their PSDK.

  • WebKit.pri:

JavaScriptCore:

The Intel compiler does not support the has_trivial_constructor type
trait. The Intel Compiler can report itself as _MSC_VER >= 1400. The
reason for that is that the Intel Compiler depends on the Microsoft
Platform SDK, and in order to try to be "fully" MS compatible it will
"pretend" to be the same MS compiler as was shipped with the MS PSDK.
(Thus, compiling with win32-icc with VC8 SDK will make the source code
"think" the compiler at hand supports this type trait).

  • wtf/TypeTraits.h:
02:39 Changeset [51483] by steveblock@google.com

Adds PLATFORM(CHROMIUM) guards around memory usage code in V8GCController.
https://bugs.webkit.org/show_bug.cgi?id=31925

Reviewed by Eric Seidel.

This code uses ChromiumBridge and Chromium-specific constant values not
appropriate for other platforms such as Android.

Build fix only, no new tests.

  • bindings/v8/V8GCController.cpp: Modified. Adds PLATFORM(CHROMIUM) around Chromium-specific code.
01:41 Changeset [51482] by ossy@webkit.org

[Qt] Put tests into skiplist because of missing features.

  • platform/qt/Skipped:
  • fast/dom/Window/window-postmessage-clone.html added
  • inspector/elements-img-tooltip.html added.
00:58 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)

11/29/09:

20:50 Changeset [51481] by bfulgham@webkit.org

Build fix.

Correct draw signature used in ImageCairoWin.cpp.

  • platform/graphics/win/ImageCairoWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

20:15 Changeset [51480] by oliver@apple.com

postMessage should serialize File objects
https://bugs.webkit.org/show_bug.cgi?id=31955

Reviewed by Sam Weinig.

Update SerializedScriptValue to include support for
File objects in the serialized object graph.

19:54 Changeset [51479] by eric@webkit.org

2009-11-29 Eric Seidel <eric@webkit.org>

Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.

  • Scripts/modules/committers.py:
19:45 Changeset [51478] by simon.fraser@apple.com

2009-11-29 Simon Fraser <simon.fraser@apple.com>

Rubber-stamped by Eric Seidel.

Fix up some compositing layout tests.

  • compositing/layers-inside-overflow-scroll.html:
  • compositing/self-painting-layers.html: Use the 'loadeddata' event, instead of 'load', to know when the video loads.
  • platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
  • platform/mac/compositing/repaint/content-into-overflow-expected.png:
  • platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
  • platform/mac/compositing/repaint/overflow-into-content-expected.png:
  • platform/mac/compositing/self-painting-layers-expected.checksum:
  • platform/mac/compositing/self-painting-layers-expected.png: Update with correct pixel results.
19:26 Changeset [51477] by eric@webkit.org

2009-11-29 Eric Seidel <eric@webkit.org>

No review, just adding missing svn property.

Set svn:executable property on new scripts.
These were added by commit-queue commits, but the executable
property was lost due to a bug in svn-apply:
https://bugs.webkit.org/show_bug.cgi?id=27204

  • Scripts/update-webkit-chromium: Added property svn:executable.
  • Scripts/validate-committer-lists: Added property svn:executable.
19:21 Changeset [51476] by simon.fraser@apple.com

2009-11-29 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Optimize the hierarchy rebuilding of compositing layers
https://bugs.webkit.org/show_bug.cgi?id=31879

When updating the compositing layer hierarchy, instead of removing all
child layers and then re-adding them one by one, build a vector of child
layers, and set them in one go.

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setChildren): New method that takes a Vector of child GraphicsLayers.
  • platform/graphics/mac/GraphicsLayerCA.h: Override setChildren().
  • platform/graphics/win/GraphicsLayerCACF.h: Ditto.
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setChildren): Implement setChildren() to set the bit that notes that sublayers changed.
  • platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::GraphicsLayerCACF::setChildren): Implement setChildren() to udpate sublayers, with a note that this is not efficient.
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): When updating compositing layers, use the faster updateLayerTreeGeometry() if we know that no layer hierarchy changes are needed, and, at the root, use the vector returned from rebuildCompositingLayerTree() to attach the root layer. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Changed to collect child layers into Vectors of GraphicsLayers, which can be set as layer children in one go. (WebCore::RenderLayerCompositor::updateLayerTreeGeometry): Split out from rebuildCompositingLayerTree() for simplicity, and called when we just need to update layer geometry, without doing any reparenting.
19:12 Changeset [51475] by eric@webkit.org

2009-11-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Need a way to validate that committers.py includes all committers/reviewers
https://bugs.webkit.org/show_bug.cgi?id=30970

Add a script which knows how to compare our public committer/reviewer
lists and show discrepancies between them.

Validates mailing lists vs. committers.py:

  • committers.py committers missing from webkit-committers@lists
  • webkit-committers@lists members missing from committers.py
  • committers.py reviewers missing from webkit-reviewers@lists
  • webkit-reviewers@lists members missing from committers.py
  • webkit-reviewers@lists members missing from committers.py reviewer list

Validates committers.py vs. trunk/ SVN history:

  • committers who have not committed in over a year
  • SVN committers missing from committers.py
  • committers.py members who have no record in SVN.

All of these lists still show "false positives" until a few more committers.py updates are made, like:
https://bugs.webkit.org/show_bug.cgi?id=31366

  • Scripts/validate-committer-lists: Added.
19:10 Changeset [51474] by dbates@webkit.org

2009-11-29 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=31971

Updated comment to reflect latest XSSAuditor bindings.

No functionality was changed. So, no new tests.

  • page/XSSAuditor.h:
18:45 Changeset [51473] by dbates@webkit.org

2009-11-29 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31969

Removes unnecessary #include files.

No functionality was changed. So, no new tests.

  • css/CSSComputedStyleDeclaration.cpp: Removed include CachedImage.h, and Pair.h
  • css/CSSCursorImageValue.cpp: Removed include RenderStyle.h
  • css/CSSFontFaceSrcValue.cpp: Removed include Node.h
  • css/CSSFontSelector.cpp: Removed include NodeList.h
  • css/CSSGradientValue.cpp: Removed include GraphicsContext.h, ImageBuffer.h
  • css/CSSImageValue.cpp: Removed include RenderStyle.h
  • css/CSSImportRule.cpp: Removed include MediaList.h
  • css/CSSMutableStyleDeclaration.cpp: Removed include CSSProperty.h
  • css/CSSRule.cpp: Removed include CSSStyleSheet.h
  • css/CSSStyleSelector.cpp: Removed include CSSFontFace.h, CSSFontFaceSource.h, and CSSProperty.h
  • page/EventSource.h: Removed include EventListener.h
17:32 Changeset [51472] by dbates@webkit.org

2009-11-29 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31965

Removed #include KeyframeList.h from CSSStyleSelector.h. Instead,
forward declared it.

As a side effect, we need to #include KeyframeList.h in
RenderLayerBacking.cpp.

No functionality was changed. So, no new tests.

  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h: Removed #include KeyframeList.h
  • rendering/RenderLayerBacking.cpp: Added #include KeyframeList.h
17:02 Changeset [51471] by eric@webkit.org

2009-11-29 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

Test using Id as index of node list.
https://bugs.webkit.org/show_bug.cgi?id=31428

  • fast/dom/Element/id-in-node-list-index01-expected.txt: Added.
  • fast/dom/Element/id-in-node-list-index01.html: Added.

2009-11-29 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

Continue to search for matching node in the case where multiple nodes
have the same id.
https://bugs.webkit.org/show_bug.cgi?id=31428

Test: fast/dom/Element/id-in-node-list-index01.html

  • dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):
16:50 Changeset [51470] by dbates@webkit.org

2009-11-29 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31966

Removed #include RenderStyle.h from file KeyframeAnimation.h. Instead,
forward declared it.

No functionality was changed. So, no new tests.

  • page/animation/KeyframeAnimation.cpp:
  • page/animation/KeyframeAnimation.h:
16:06 Changeset [51469] by dbates@webkit.org

2009-11-29 Daniel Bates <dbates@webkit.org>

Unreviewed, fix change log entry date.

For some reason, bugzilla-tool did not update the date in the change
log entry for my last commit (r51468). So, this commit fixes the date
of that entry.

15:55 Changeset [51468] by dbates@webkit.org

2009-11-28 Daniel Bates <dbates@webkit.org>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=31964

Removed #include StringImpl, StyleImage. Instead, forward declared them.
Also, we can substitute #include <wtf/PassRefPtr.h> for #include PlatformString.h,
since it seems we only really used it to include PassRefPtr.h.

No functionality was changed. So, no new tests.

  • rendering/style/ContentData.h:
12:11 Changeset [51467] by eric@webkit.org

2009-11-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Mac build has JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=31828

  • wtf/Platform.h: Enable JIT for Qt Mac builds
07:57 Changeset [51466] by eric@webkit.org

2009-11-29 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

Allow custom memory allocation control for classes of the rendering and storage directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31906

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

class SQLTransactionClient - storage/DatabaseThread.cpp:45
class SQLTransactionCoordinator - storage/DatabaseThread.cpp:46
class OriginUsageRecord - storage/OriginQuotaManager.cpp:66
class DatabaseTracker - storage/DatabaseTracker.cpp:62
class ScrollbarTheme - (its child class) rendering/RenderScrollbarTheme.cpp:35
class RenderSelectionInfoBase - (its child class) rendering/RenderView.cpp:310
class RenderOverflow - rendering/RenderBox.cpp:2846

Inherits the following classes from FastAllocBase because these are instantiated by 'new':

struct FillLayer - css/CSSStyleSelector.cpp:197
struct ShadowData - rendering/style/ShadowData.cpp:35
class CounterContent - css/CSSStyleSelector.cpp:4111

  • platform/ScrollbarTheme.h:
  • rendering/RenderOverflow.h:
  • rendering/RenderSelectionInfo.h:
  • rendering/style/CounterContent.h:
  • rendering/style/FillLayer.h:
  • rendering/style/ShadowData.h:
  • storage/DatabaseTracker.h:
  • storage/OriginUsageRecord.h:
  • storage/SQLTransactionClient.h:
  • storage/SQLTransactionCoordinator.h:

11/28/09:

22:36 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
22:31 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
17:53 Changeset [51465] by abarth@webkit.org

2009-11-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
https://bugs.webkit.org/show_bug.cgi?id=31950

Now we cache the last status that we get back from QueueStatusServer.
Eventually we'll have to do something more fancy if we want to support
a "try again" button on QueueStatusServer, but we can cross that bridge
when we come to it.

  • Scripts/modules/patchcollection.py:
17:50 Changeset [51464] by abarth@webkit.org

2009-11-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

StyleQueue scans ~100 bug pages every 5 minutes
https://bugs.webkit.org/show_bug.cgi?id=31947

Instead of getting the pending-review attachment ids by scanning each
bug (which results in a network request), we should just get them all
from webkit.org/pending-review in one shot.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/bugzilla_unittest.py:
  • Scripts/modules/commands/queries.py:
  • Scripts/modules/commands/queries_unittest.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/mock_bugzillatool.py:
  • Scripts/modules/patchcollection.py:
16:20 Changeset [51463] by abarth@webkit.org

2009-11-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] CC webkit-bot-watchers whenever the bots touch bugs
https://bugs.webkit.org/show_bug.cgi?id=31952

The mailing list is open for anyone to subscribe.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/commands/queues.py:
16:17 Changeset [51462] by abarth@webkit.org

2009-11-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] style-queue should report style errors to bugzilla
https://bugs.webkit.org/show_bug.cgi?id=31945

Currently, we're just logging the style errors locally. With this
patch we'll actually log the errors to bugzilla. Note: I plan to run
with the "local-only" logging during development.

  • Scripts/modules/commands/queues.py:
  • Scripts/modules/scm.py:
13:48 Changeset [51461] by eric@webkit.org

2009-11-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Apply workaround for the limitation of VirtualFree with MEM_RELEASE to all ports running on Windows
https://bugs.webkit.org/show_bug.cgi?id=31943

  • runtime/MarkStack.h: (JSC::MarkStack::MarkStackArray::shrinkAllocation):
10:27 Changeset [51460] by abarth@webkit.org

2009-11-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] style-queue shouldn't reject patches from the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=31944

Currently the style-queue subprocess gets confused and thinks its the
commit-queue. If the patch has an error, it rejects it from the
commit-queue. Instead, we should have style-queue specific logic.
This patch doesn't add that logic, but it gives us a callback we can
use to add that logic.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/landingsequence.py:
08:39 Changeset [51459] by abarth@webkit.org

2009-11-28 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[Chromium] Sify compose button alerts error
https://bugs.webkit.org/show_bug.cgi?id=31394

Test: http/tests/security/calling-versus-current.html

We're supposed to use the calling context for security checks. In JSC
land, this is the lexicalGlobalObject.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::canAccessPrivate):

2009-11-28 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[Chromium] Sify compose button alerts error
https://bugs.webkit.org/show_bug.cgi?id=31394

Test that we're using the calling security context in a simple case.

  • http/tests/security/calling-versus-current-expected.txt: Added.
  • http/tests/security/calling-versus-current.html: Added.
07:21 BuildingGtk edited by pierre@alumni.utoronto.ca
(diff)
06:27 Changeset [51458] by eric@webkit.org

2009-11-28 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] SoftwareInputPanelRequest event sent when clicking in newly loaded page

https://bugs.webkit.org/show_bug.cgi?id=31401

Don't set the event unless there is a focused node we can use
for editing afterwards.

  • Api/qwebpage.cpp: (QWebPagePrivate::handleSoftwareInputPanel):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
02:31 Changeset [51457] by zoltan@webkit.org

2009-11-28 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

https://bugs.webkit.org/show_bug.cgi?id=31930

Seems a typo. We don't need ~270k memory to determine the vptrs.

  • runtime/JSGlobalData.cpp: (JSC::VPtrSet::VPtrSet):
01:09 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
01:07 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)

11/27/09:

23:39 Changeset [51456] by yurys@chromium.org

2009-11-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Add separate method for pause command to WebDevToolsAgent
and WebDevToolsFrontendClient interfaces so that pause command
can be processed on the IO thread.

https://bugs.webkit.org/show_bug.cgi?id=31934

  • public/WebDevToolsAgent.h:
  • public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendDebuggerCommandToAgent): (WebKit::WebDevToolsFrontendClient::sendDebuggerPauseScript): (WebKit::WebDevToolsFrontendClient::activateWindow): (WebKit::WebDevToolsFrontendClient::closeWindow): (WebKit::WebDevToolsFrontendClient::dockWindow): (WebKit::WebDevToolsFrontendClient::undockWindow):
22:15 Changeset [51455] by hamaji@chromium.org

2009-11-27 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed Chromium build fix introduced by r51428.

[Chromium] Ignore line-height CSS property for PushButton
https://bugs.webkit.org/show_bug.cgi?id=31712

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::adjustButtonStyle):
21:33 Changeset [51454] by hamaji@chromium.org

2009-11-27 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed Chromium test fix by reverting r51413.

[v8] Do not check the thread when accessing DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=31877

  • bindings/v8/V8DOMMap.cpp: (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap):
16:32 Changeset [51453] by dbates@webkit.org

2009-11-27 Daniel Bates <dbates@webkit.org>

Unreviewed, comment fix.

Corrected misspelling of the word "implemented".

  • inspector/front-end/InjectedScriptAccess.js:
16:18 Changeset [51452] by laszlo.1.gombos@nokia.com

2009-11-27 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed.

Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793

Build fix for chromium after r51423.
Exclude gtk directory from chromium build.

15:46 Changeset [51451] by abarth@webkit.org

Rubber stamped by Eric Seidel.

Rename CommitQueueStatus to QueueStatusServer to allow for more queues.

  • CommitQueueStatus: Removed.
  • CommitQueueStatus/app.yaml: Removed.
  • CommitQueueStatus/filters: Removed.
  • CommitQueueStatus/filters/init.py: Removed.
  • CommitQueueStatus/filters/webkit_extras.py: Removed.
  • CommitQueueStatus/index.html: Removed.
  • CommitQueueStatus/index.yaml: Removed.
  • CommitQueueStatus/queue_status.py: Removed.
  • CommitQueueStatus/stylesheets: Removed.
  • CommitQueueStatus/stylesheets/main.css: Removed.
  • CommitQueueStatus/update_status.html: Removed.
  • QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
15:39 Changeset [51450] by abarth@webkit.org

2009-11-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

style-queue should only process each patch once
https://bugs.webkit.org/show_bug.cgi?id=31939

Actually address reviewer comments!

  • Scripts/bugzilla-tool:
15:36 Changeset [51449] by abarth@webkit.org

2009-11-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] style-queue fails to apply a bunch of patches for no reason
https://bugs.webkit.org/show_bug.cgi?id=31942

By passing --non-interactive to check-style, we convince check-style
to pass --force to svn-apply, which lets it apply more patches.

  • Scripts/modules/commands/queues.py:
15:35 Changeset [51448] by abarth@webkit.org

2009-11-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Support --status-host in style-queue
https://bugs.webkit.org/show_bug.cgi?id=31941

  • Scripts/modules/commands/queues.py:
  • Scripts/modules/statusbot.py:
15:34 Changeset [51447] by abarth@webkit.org

2009-11-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

style-queue should only process each patch once
https://bugs.webkit.org/show_bug.cgi?id=31939

Before processing a patch, the try-queues now ask the web service
whether they have already processed the patch. This is an initial cut
of this functionality. I expect we're make it richer over time.

  • Scripts/bugzilla-tool:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/patchcollection.py:
15:34 Changeset [51446] by abarth@webkit.org

2009-11-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

PatchStatus does not return status
https://bugs.webkit.org/show_bug.cgi?id=31938

We need to parse attachment_id as an int. Otherwise, we can't find
anything in the datastore.

  • CommitQueueStatus/queue_status.py:
15:04 Changeset [51445] by dbates@webkit.org

2009-11-27 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=31940

Makes the error messages more descriptive when we refuse to load an object/embed or
refuse to load from the document base URL.

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadObject): Changed console message to be more descriptive. (WebCore::XSSAuditor::canSetBaseElementURL): Ditto.

2009-11-27 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=31940

Rebased results because of new error messages.

  • http/tests/security/xssAuditor/base-href-control-char-expected.txt:
  • http/tests/security/xssAuditor/base-href-expected.txt:
  • http/tests/security/xssAuditor/base-href-null-char-expected.txt:
  • http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/object-src-inject-expected.txt:
  • http/tests/security/xssAuditor/object-tag-expected.txt:
  • http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
10:49 Changeset [51444] by eric@webkit.org

2009-11-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make commit-queue status not throw an exception where there is not
status
https://bugs.webkit.org/show_bug.cgi?id=31936

We need to actually fetch the results of the query to see what's in the
datastore.

  • CommitQueueStatus/queue_status.py:
10:09 Changeset [51443] by abarth@webkit.org

2009-11-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] unit test ApplyPatches and ApplyAttachment
https://bugs.webkit.org/show_bug.cgi?id=31935

  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/download_unittest.py:
09:37 Changeset [51442] by abarth@webkit.org

2009-11-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Unit test download commands
https://bugs.webkit.org/show_bug.cgi?id=31923

Adds download_unittest and fixes a bug found while testing.

  • Scripts/modules/commands/commandtest.py:
  • Scripts/modules/commands/download.py:

Fixed a bug where we'd throw an error because [].append returns
None.

  • Scripts/modules/commands/download_unittest.py: Added.
  • Scripts/modules/mock_bugzillatool.py:
  • Scripts/run-webkit-unittests:
08:21 Changeset [51441] by eric@webkit.org

2009-11-27 Kenneth Russell <kbr@google.com>

Reviewed by Eric Seidel.

REGRESSION(51418): fast/canvas/webgl/gl-object-get-calls.html is failing on the Leopard commit bot
https://bugs.webkit.org/show_bug.cgi?id=31919

Temporarily disabled portion of test which is failing on some
machines but not others. Root cause will be investigated under
https://bugs.webkit.org/show_bug.cgi?id=31843 .

  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/script-tests/gl-object-get-calls.js:
05:07 Changeset [51440] by yurys@chromium.org

2009-11-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

This is a WebCore part of the fix that allows to view plugin
resources loaded by plugins.

https://bugs.webkit.org/show_bug.cgi?id=31832

  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::addLength):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didFailToLoad): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):

2009-11-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

WebCore part of the fix that allows to view plugin
resources loaded by plugins. Methods that for resource
loading notifications are exposed through WebDevToolsAgent
interface to the glue code to allow Chromium's plugin
implementation to notify InspectorController about resource
loading in plugins.

https://bugs.webkit.org/show_bug.cgi?id=31832

  • public/WebDevToolsAgent.h:
  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::createUniqueIdentifierForRequest):
  • src/WebViewImpl.h:
03:12 Changeset [51439] by yurys@chromium.org

2009-11-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Instead of generating negative identifiers for cached resources in
InspectorController and extending identifier type from 'unsigned long' to 'long
long' reuse progress tracker from the inspected page to generate those
identifiers. It guarantees that InspectorResources have unique ids since
all of them are generated by that progress tracker.

Added a couple new overloaded methods to Script* objects that accept
long and unsigned long arguments. These types of argumens have already
been passed as long long.

https://bugs.webkit.org/show_bug.cgi?id=31921

  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument):
  • bindings/js/ScriptFunctionCall.h:
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::set):
  • bindings/js/ScriptObject.h:
  • bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument):
  • bindings/v8/ScriptFunctionCall.h:
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::set):
  • bindings/v8/ScriptObject.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::getTrackedResource): (WebCore::InspectorController::didLoadResourceFromMemoryCache): Use inspected page's ProgressTracker to generate unique identifiers for cached resources in InspectorController.
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildObjectForEventListener):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addResource): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::updateFocusedNode):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::createCached):
  • inspector/InspectorResource.h: Change InspectorResource identifier type from 'long long' to 'unsigned long'. (WebCore::InspectorResource::create): (WebCore::InspectorResource::identifier):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createResourceSendRequestRecord): (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord): (WebCore::TimelineRecordFactory::createResourceFinishRecord):
00:45 Changeset [51438] by abarth@webkit.org

2009-11-27 Adam Barth <abarth@webkit.org>

Unreviewed "build" fix found while writing unit tests.

  • Scripts/modules/commands/download.py:
00:04 Changeset [51437] by abarth@webkit.org

2009-11-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904

Step 6: Kill the rest.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/queries.py:
  • Scripts/modules/commands/upload.py:
  • Scripts/modules/landingsequence.py:
  • Scripts/modules/scm.py:
  • Scripts/modules/webkitlandingscripts.py: Removed.
00:02 Changeset [51436] by abarth@webkit.org

2009-11-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Unit test upload commands
https://bugs.webkit.org/show_bug.cgi?id=31903

Adds unit tests for all but two of the upload commands. The two
remaining ones are more difficult. I'll return to them later. The
goal of these tests is just to run the commands. We can test more
detailed behavior later.

  • Scripts/modules/commands/commandtest.py:
  • Scripts/modules/commands/upload.py:
  • Scripts/modules/commands/upload_unittest.py:
  • Scripts/modules/mock.py: Added.
  • Scripts/modules/mock_bugzillatool.py:

11/26/09:

23:56 Changeset [51435] by abarth@webkit.org

2009-11-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904

Step 5: Kill run_and_throw_if_fail.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/processutils.py: Added.
  • Scripts/modules/webkitlandingscripts.py:
23:56 Changeset [51434] by abarth@webkit.org

2009-11-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904

Step 4: Kill run_webkit_script.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/webkitlandingscripts.py:
23:55 Changeset [51433] by abarth@webkit.org

2009-11-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904

Step 3: Kill build_webkit.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/landingsequence.py:
  • Scripts/modules/webkitlandingscripts.py:
23:55 Changeset [51432] by abarth@webkit.org

2009-11-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904

Step 2: Kill ensure_builders_are_green.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/landingsequence.py:
  • Scripts/modules/webkitlandingscripts.py:
23:54 Changeset [51431] by abarth@webkit.org

2009-11-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904

Step 1: Kill prepare_clean_working_directory and run_webkit_tests.

  • Scripts/bugzilla-tool:
  • Scripts/modules/buildsteps.py: Added.
  • Scripts/modules/commands/download.py:
  • Scripts/modules/landingsequence.py:
  • Scripts/modules/webkitlandingscripts.py:
23:51 Changeset [51430] by hamaji@chromium.org

2009-11-26 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed red bot fix.

Skip tests introduced by the previous change as it seems to be failing.

  • platform/qt/Skipped:
  • platform/win/Skipped:
22:11 Changeset [51429] by hamaji@chromium.org

2009-11-26 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dan Bernstein.

Assertion failure in RenderBlock::positionForPointWithInlineChildren when running fast/inline/relative-positioned-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=29966

A test case where a user drags the mouse from an empty inline
element to above texts.

  • editing/selection/last-empty-inline-expected.txt: Added.
  • editing/selection/last-empty-inline.html: Added.
  • platform/win/Skipped:

2009-11-26 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dan Bernstein.

Assertion failure in RenderBlock::positionForPointWithInlineChildren when running fast/inline/relative-positioned-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=29966

When an empty inline element is clicked, the root inline box has
no leaf children. Use the renderer of a normal child instead.

This change resolves Windows port's assertion failure in a layout test.
Also, this fixes the behavior when a user drags the mouse from an
empty inline element to above texts.

Test: editing/selection/last-empty-inline.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPointWithInlineChildren):
21:59 Changeset [51428] by eric@webkit.org

2009-11-26 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Ignore line-height CSS property specified to push buttons on
Windows and Linux.
https://bugs.webkit.org/show_bug.cgi?id=31712

LayoutTests/fast/forms/control-restrict-line-height.html checks that the
following controls should ignore line-height CSS property.

  • <select>
  • <input type=button>
  • <input type=search>

This change addresses the <input type=button> issue with Chromium/Windows
and Chromium/Linux.

  • rendering/RenderThemeChromiumSkia.cpp: Implement adjustButtonStyle() to ignore line-height.
  • rendering/RenderThemeChromiumSkia.h: Declare adjustButtonStyle().
21:53 Changeset [51427] by eric@webkit.org

2009-11-26 Kinuko Yasuda <kinuko@chromium.com>

Reviewed by Eric Seidel.

Rewrite the test fast/parser/comment-in-textarea to use dumpAsText
so that the expected results can be independent of platform differences.
https://bugs.webkit.org/show_bug.cgi?id=31580

  • fast/parser/comment-in-textarea-expected.txt: Added.
  • fast/parser/comment-in-textarea.html:
  • fast/parser/script-tests/comment-in-textarea.js: Added.
  • platform/mac/fast/parser/comment-in-textarea-expected.checksum: Removed.
  • platform/mac/fast/parser/comment-in-textarea-expected.png: Removed.
  • platform/mac/fast/parser/comment-in-textarea-expected.txt: Removed.
  • platform/win/fast/parser/comment-in-textarea-expected.txt: Removed.
21:46 Changeset [51426] by eric@webkit.org

2009-11-26 Kinuko Yasuda <kinuko@chromium.com>

Reviewed by Eric Seidel.

Remove the special charset meta tag in the clipboard so that
copy-and-paste with interchange breaklines/spaces works correctly
within WebKit.

No new tests. Layout tests that involve copy-and-paste with
interchange breaklines (like editing/pasteboard/paste-line-endings-00?)
should pass on Mac/Chromium with this fix.

  • platform/chromium/ClipboardChromium.cpp:
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::documentFragment):
21:33 Changeset [51425] by eric@webkit.org

2009-11-26 İsmail Dönmez <ismail@namtrac.org>

Reviewed by Eric Seidel.

Compile with QT_NO_WHEELEVENT defined.

  • platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::applyDelta):
21:20 Changeset [51424] by oliver@apple.com

Incorrect behaviour of jneq_null in the interpreter
https://bugs.webkit.org/show_bug.cgi?id=31901

Reviewed by Gavin Barraclough.

Correct the logic of jneq_null. This is already covered by existing tests.

20:06 Changeset [51423] by laszlo.1.gombos@nokia.com

2009-11-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Oliver Hunt.

Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793

  • GNUmakefile.am: Change the path for GOwnPtr.*.
  • JavaScriptCore.gyp/JavaScriptCore.gyp: Remove GOwnPtr.cpp from the exclude list.
  • JavaScriptCore.gypi: Change the path for GOwnPtr.*.
  • wscript: Remove GOwnPtr.cpp from the exclude list.
  • wtf/GOwnPtr.cpp: Removed.
  • wtf/GOwnPtr.h: Removed.
  • wtf/Threading.h: Change the path for GOwnPtr.h.
  • wtf/gtk/GOwnPtr.cpp: Copied from JavaScriptCore/wtf/GOwnPtr.cpp.
  • wtf/gtk/GOwnPtr.h: Copied from JavaScriptCore/wtf/GOwnPtr.h.
  • wtf/unicode/glib/UnicodeGLib.h: Change the path for GOwnPtr.h.

2009-11-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Oliver Hunt.

Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793

  • webkit/webkitwebview.cpp: Change the path for GOwnPtr.h.

2009-11-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Oliver Hunt.

Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793

No new tests as there is no functional change.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Change the path for GOwnPtr.h.
  • platform/text/TextEncoding.cpp: Ditto.
  • platform/text/gtk/TextCodecGtk.cpp: Ditto.

2009-11-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Oliver Hunt.

Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793

13:22 Changeset [51422] by yurys@chromium.org

2009-11-26 Yury Semikhatsky <yurys@chromium.org>

Not reviewed. Build fix: revert r51421.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::addLength):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didFailToLoad): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):

2009-11-26 Yury Semikhatsky <yurys@chromium.org>

Not reviewed. Build fix: revert r51421.

  • public/WebDevToolsAgent.h:
  • public/WebView.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
12:59 Changeset [51421] by yurys@chromium.org

2009-11-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

This is a WebCore part of the fix that allows to view plugin
resources loaded by plugins.

https://bugs.webkit.org/show_bug.cgi?id=31832

  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
  • inspector/InspectorController.h: Remove unused DocumentLoader parameters from inspector methods.
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::addLength): Update loading end time when new data are received.
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didFailToLoad): Notify InspectorController about the failure. (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):

2009-11-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

WebCore part of the fix that allows to view plugin
resources loaded by plugins. Methods that for resource
loading notifications are exposed through WebDevToolsAgent
interface to the glue code to allow Chromium's plugin
implementation to notify InspectorController about resource
loading in plugins.

https://bugs.webkit.org/show_bug.cgi?id=31832

  • public/WebDevToolsAgent.h:
  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::createUniqueIdentifierForRequest):
  • src/WebViewImpl.h:
12:27 Changeset [51420] by eric@webkit.org

2009-11-26 Daniel Bates <dbates@webkit.org>

Reviewed by Pavel Feldman.

https://bugs.webkit.org/show_bug.cgi?id=21554

Tests that the tooltip text for an image is its dimensions.

  • inspector/elements-img-tooltip-expected.txt: Added.
  • inspector/elements-img-tooltip.html: Added.

2009-11-26 Daniel Bates <dbates@webkit.org>

Reviewed by Pavel Feldman.

https://bugs.webkit.org/show_bug.cgi?id=21554

Implements support for hovering over <img> src to display the height and width of that image
in a tooltip. Displays both the displayable and natural dimensions of the image.

Test: inspector/elements-img-tooltip.html

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode): Added. (WebInspector.ElementsTreeElement.prototype._updateTitle.callback): (WebInspector.ElementsTreeElement.prototype._updateTitle): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
  • inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy.getPropertiesAsync): Added.
  • inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode): Added tooltipText argument. (WebInspector.linkifyURL): Ditto.
10:06 Changeset [51419] by kevino@webkit.org

wx build fix after drawPattern API change.

08:50 Changeset [51418] by cmarrin@apple.com

Missed checking in these files from https://bugs.webkit.org/show_bug.cgi?id=30091

08:50 Changeset [51417] by zoltan@webkit.org

2009-11-26 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Adam Barth.

Remove directory prefixes from linux commands

SCM unittests can cause errors on some systems if we use absolute reference to
the commands, so directory prefixes have been removed.

  • Scripts/modules/scm_unittest.py:
07:59 Changeset [51416] by eric@webkit.org

2009-11-26 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Use an internal field instead of hidden property to speedup lookup
of entered isolated world.

Plus some inlinings.
https://bugs.webkit.org/show_bug.cgi?id=31884

Covered by layout tests + manual running of some benchmarks as
content scripts.

  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::setDOMWrapper):
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
  • bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::getEntered): (WebCore::V8IsolatedWorld::getGlobalObject):
  • bindings/v8/custom/V8CustomBinding.h:
07:06 Changeset [51415] by hausmann@webkit.org

Rubber-stamped by Holger Freyther.

Removed unused ICO image plugin handler.

  • Plugins/ICOHandler.cpp: Removed.
  • Plugins/ICOHandler.h: Removed.
  • Plugins/Plugins.pro: Removed.
06:34 Changeset [51414] by eric@webkit.org

2009-11-26 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Corrects build break on Windows.

Rename platform/text/qt/TextBoundaries.cpp to TextBoundariesQt.cpp since
platform/text/TextBoundaries.cpp was compiled instead when compiling with nmake.

  • WebCore.pro:
  • platform/text/qt/TextBoundariesQt.cpp: Renamed from WebCore/platform/text/qt/TextBoundaries.cpp. (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):
05:20 Changeset [51413] by eric@webkit.org

2009-11-26 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Do not check if the thread is main or not when accessing DOMDataStore as currently in Chromium WebKit is used in main thread only.
https://bugs.webkit.org/show_bug.cgi?id=31877

Covered by layout tests and buildbots.

  • bindings/v8/V8DOMMap.cpp: (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap):
05:04 Changeset [51412] by girish@forwardbias.in

[Qt] Mac Plugins : Pass mouse position relative to the fake window

Reviewed by Holger Freyther.

When using off-screen rendering, we need to pass mouse events relative
to the fake window instead of the global position.

https://bugs.webkit.org/show_bug.cgi?id=31794

04:44 QtWebKitMirrorGuide edited by zecke@selfish.org
Mention the Math.random() problem with the test content. (diff)
04:33 QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
(diff)
04:31 QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
(diff)
04:26 QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
Fix the marking of completed items. (diff)
04:23 QtBackLog edited by zecke@selfish.org
Put the commits and date into the right column (diff)
04:21 QtBackLog edited by zecke@selfish.org
Mention the network change, and the issue that QtWebKit is using less … (diff)
04:18 QtBackLog edited by zecke@selfish.org
Complete the QtPlugin work (diff)
03:16 Changeset [51411] by zecke@webkit.org

[Qt] Use QNetworkReply::rawHeaderPairs

https://bugs.webkit.org/show_bug.cgi?id=31826

The QNetworkReply is internally storing the HTTP headers
as a list of pairs. Currently we have to ask the QNetworkReply
to put all header names into a QStringList. Afterwards we will
iterate over this QStringList and ask the QNetworkReply to
give us the value for this header name. The current Qt implementation
is doing a linear to find the header value.

Use a new API to directly access the list of pairs and push
this into WebCore. This avoids doing some allocations and doing
linear searches from within a loop.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

02:34 Changeset [51410] by zecke@webkit.org

[Qt] Add automatic test case for plugins that use QWidget

https://bugs.webkit.org/show_bug.cgi?id=31203

Change the RenderTreeAsText to look into the WebCore::Widget
and print the state of the platformWidget. Change the DRT to
use QtUiTools to be able to initiate QProgressBar and such
as a plugin. Add the test case, add the result, update the
other results due the new test.

WebCore:

  • rendering/RenderTreeAsText.cpp:

(WebCore::operator<<): Add special case for RenderPart

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::createPlugin):

  • DumpRenderTree/qt/DumpRenderTree.h:
  • DumpRenderTree/qt/DumpRenderTree.pro:

LayoutTest:

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/plugins/netscape-dom-access-expected.txt: Added
  • platform/qt/plugins/qt-qwidget-plugin-expected.txt: Added
  • platform/win/Skipped:
  • plugins/qt-qwidget-plugin.html: Added.
02:31 Changeset [51409] by zecke@webkit.org

[Qt] Call Widget::setSelfVisible from hide/show

https://bugs.webkit.org/show_bug.cgi?id=31203

Call Widget::setSelfVisible from Widget::show and
Widget::hide and use isParentVisible to decide
if the widget should be shown. This way client
code can rely on isVisible.

Change PluginViewQt::show, PluginViewQt::hide to
call the base class as it is doing the right thing
now. Add an assert verify that platfomWidget and
platformPluginWidget are the same.

  • manual-tests/qt/qtplugin.html: Modify manual test
  • platform/qt/WidgetQt.cpp:

(WebCore::Widget::show):
(WebCore::Widget::hide):

[Qt] Do not show the QWidget when the WebCore::Widget is hidden

https://bugs.webkit.org/show_bug.cgi?id=31203

The clipping code was making a QWidget visible even if the
WebCore::Widget was hidden. Fix the bug by calling setVisible
only if the WebCore::Widget Widget::isSelfVisible.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::QtPluginWidget::show): Override WebCore::Widget::show to call handleVisibility
(WebCore::QtPluginWidget::handleVisibility): New method to call setVisible when we are visible
(FrameLoaderClientQt::createPlugin): Hide the QWidget by default

02:31 Changeset [51408] by zecke@webkit.org

Fix compilation of REQUEST_DEBUG debug code

https://bugs.webkit.org/show_bug.cgi?id=31850

In r47907 the single parameter KURL constructor to parse
from a WebCore::String was replaced with a two parameter
constructor. I think in this debug case parsing the urls
again is no problem and I have changed the code to use the
two parameter version.

  • loader/loader.cpp:

(WebCore::Loader::Host::didFinishLoading):

00:43 Changeset [51407] by eric@webkit.org

2009-11-26 Søren Gjesse <sgjesse@chromium.org>

Reviewed by Pavel Feldman.

[V8] Avoid using JavaScript objects as context data
https://bugs.webkit.org/show_bug.cgi?id=31873

Change the context "data" from a JavaScript object holding the two properties type and value to
a string holding type and value separated by a comma.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::setContextDebugId): (WebCore::V8Proxy::contextDebugId):
Note: See TracTimeline for information about the timeline view.