Timeline


and

12/05/09:

17:50 Changeset [51734] by kov@webkit.org
  • 11 edits in trunk

WebCore

2009-12-03 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

Advertize audio/ogg correctly and refactored mime-type cache
building.

[GTK] Recognize oga as audio/ogg
https://bugs.webkit.org/show_bug.cgi?id=31990

Test: media/media-can-play-ogg.html

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):

LayoutTests

2009-12-05 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

New test for video.canPlayType and ogg containers.

[GTK] Recognize oga as audio/ogg
https://bugs.webkit.org/show_bug.cgi?id=31990

  • media/media-can-play-ogg-expected.txt: Added.
  • media/media-can-play-ogg.html: Added.
  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt-win/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
16:30 Changeset [51733] by eric@webkit.org
  • 7 edits
    1 add in trunk/WebKitSite

2009-12-05 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Darin Adler.

Refactored web site documentation so that advice to add
WebKitTools/Scripts to your shell path does not appear
on multiple pages.

https://bugs.webkit.org/show_bug.cgi?id=32112

  • building/build.html:
  • building/checkout.html:
  • building/run.html:
  • coding/coding-style.html:
  • coding/contributing.html:
  • coding/scripts.html: Added.
  • quality/testing.html:
15:59 Changeset [51732] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32175
REGRESSION: websocket/tests/url-parsing.html is crashing on Leopard Bot

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::readStreamCallback): Call platformClose() to unschedule both streams, guaranteeing that there will be no callbacks after SocketStreamHandle is destroyed. (WebCore::SocketStreamHandle::writeStreamCallback): Edited a comment a bit.
15:44 Changeset [51731] by mitz@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

Disabled a test because it puts the WebView into compositing mode,
which remains in effect for all subsequent repaint tests, causing them
to fail because DumpRenderTree always forces a full repaint when
generating the image of a WebView that is in compositing mode.

  • fast/repaint/block-selection-gap-in-composited-layer.html: Removed.
  • fast/repaint/block-selection-gap-in-composited-layer.html.disabled: Copied from LayoutTests/fast/repaint/block-selection-gap-in-composited-layer.html.
13:55 Changeset [51730] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Implement ChromiumPort
https://bugs.webkit.org/show_bug.cgi?id=32182

  • Scripts/modules/webkitport.py:
  • Scripts/modules/webkitport_unittest.py:
13:54 Changeset [51729] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2009-12-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move update-webkit into BuildSteps
https://bugs.webkit.org/show_bug.cgi?id=32181

We need to move update-webkit out of SCM.py because SCM isn't supposed to know
that WebKit exists. The proper place for the knowledge of the existence of
update-webkit is in WebKitPort because some ports have specialized update
scripts (analogous to build-webkit).

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/landingsequence.py:
  • Scripts/modules/scm.py:
  • Scripts/modules/webkitport.py:
13:54 Changeset [51728] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

update-webkit should call git svn rebase and resolve-ChangeLogs -f
https://bugs.webkit.org/show_bug.cgi?id=27162

Teach update-webkit about Git. I didn't add the call to
resolve-ChangeLogs -f because sometimes that script goes bananas. We
can iterate from here, however.

  • Scripts/update-webkit:
09:50 Changeset [51727] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2009-12-05 Adam Langley <agl@google.com>

Reviewed by Adam Barth.

Check that a CSS format() argument is of a valid type.

https://bugs.webkit.org/show_bug.cgi?id=31815
http://code.google.com/p/chromium/issues/detail?id=28582

  • fast/css/url-format-non-string-expected.txt: Added
  • fast/css/url-format-non-string.html: Added.

2009-12-05 Adam Langley <agl@google.com>

Reviewed by Adam Barth.

Check that a CSS format() argument is of a valid type.

https://bugs.webkit.org/show_bug.cgi?id=31815
http://code.google.com/p/chromium/issues/detail?id=28582

Test: fast/css/url-format-non-string.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseFontFaceSrc):
08:56 Changeset [51726] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

Use a better URI for the unreachable test. localhost:80 is very
likely to be open.

  • tests/testwebdatasource.c:

(load_finished_unreachable_cb):
(test_webkit_web_data_source_unreachable_uri):

07:35 Changeset [51725] by kov@webkit.org
  • 2 edits in trunk

2009-12-05 Vincent Untz <vuntz@gnome.org>

Reviewed by Gustavo Noronha.

Fixes race for builds with introspection enabled, and parallel
make.

  • GNUmakefile.am:

12/04/09:

17:21 Changeset [51724] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-12-04 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

JavaScript delete operator should return false for string properties
https://bugs.webkit.org/show_bug.cgi?id=32012

  • runtime/StringObject.cpp: (JSC::StringObject::deleteProperty):

2009-12-04 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

Add test for JavaScript string property deletion
https://bugs.webkit.org/show_bug.cgi?id=32012

  • fast/js/script-tests/string-property-deletion.js: Added.
  • fast/js/string-property-deletion-expected.txt: Added.
  • fast/js/string-property-deletion.html: Added.
16:46 Changeset [51723] by eric@webkit.org
  • 3 edits in trunk/WebKitSite

2009-12-04 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Eric Seidel.

Add reference to the GTK and QT build wiki pages

https://bugs.webkit.org/show_bug.cgi?id=32088

  • building/tools.html:
  • css/main.css:
16:39 Changeset [51722] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-04 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium: make rounded borders heavier.

Skia draws its rounded corners differently from the other ports.
Whereas they have anti-aliased clipping regions, Skia only has 1-bit
regions. (Which is technically more correct, but somewhat unhelpful
for us.) Instead, with Skia we use a layer and collect all the
clipping paths in effect. When the state is popped, we paint
transparency outside the clipping paths and merge the layer down.

This appears to cause rounded borders to look a little thin, which is
addressed in this patch.

This is well covered by existing tests but will require new baselines
in the Chromium tree.

https://bugs.webkit.org/show_bug.cgi?id=31778

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::addInnerRoundedRectClip):
16:31 Changeset [51721] by eric@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2009-12-04 Yuzo Fujishima <yuzo@google.com>

Reviewed by Alexey Proskuryakov.

Add test for web socket send.

https://bugs.webkit.org/show_bug.cgi?id=31337

  • websocket/tests/script-tests/send.js: Added. (endTest): (ws.onopen): (ws.onmessage.ws.onmessage): (ws.onmessage): (ws.onclose): (timeOutCallback):
  • websocket/tests/send-expected.txt: Added.
  • websocket/tests/send.html: Added.
  • websocket/tests/send_wsh.py: Added.
16:24 Changeset [51720] by eric@webkit.org
  • 3 edits
    3 adds in trunk/WebKit/chromium

2009-12-04 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=32095
Implement WebRegularExpression, a WebKit API for accessing
WebCore::RegularExpression.

  • WebKit.gyp:
  • public/WebRegularExpression.h: Added.
  • public/WebTextCaseSensitivity.h: Added. (WebKit::):
  • src/AssertMatchingEnums.cpp:
  • src/WebRegularExpression.cpp: Added. (WebKit::WebRegularExpression::WebRegularExpression): (WebKit::WebRegularExpression::~WebRegularExpression): (WebKit::WebRegularExpression::match):
15:56 Changeset [51719] by pkasting@chromium.org
  • 4 edits in trunk/WebKit/chromium

[Chromium] Simplify zoom-related APIs and add a zoom level getter,
part two: Remove deprecated APIs.
https://bugs.webkit.org/show_bug.cgi?id=31893

Reviewed by Darin Fisher.

  • public/WebView.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
15:18 Changeset [51718] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2009-12-04 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7441571> Hardware-backed layers are skipped when printing

When printing, set the PaintBehaviorFlattenCompositingLayers flag so that compositing layers
paint. This also causes 3D transforms to be flattened to 2D.

Test: printing/compositing-layer-printing.html

  • page/FrameView.cpp: (WebCore::FrameView::paintContents):
15:13 Changeset [51717] by oliver@apple.com
  • 2 edits in trunk/WebCore

Fix up some issues in my SVGListTraits change from yesterday.

Reviewed by Deth Bakin

14:10 Changeset [51716] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skip test that is failing because of new behaviour enforced by
libsoup. Bug reported.

  • platform/gtk/Skipped:
14:00 Changeset [51715] by kenneth@webkit.org
  • 5 edits in trunk/WebKitTools

Add some missing methods for showing and hiding the
Web Inspector.

Reviewed by Adam Treat.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::WebPage):
(WebCore::WebPage::~WebPage):
(WebCore::WebPage::webInspector):

  • DumpRenderTree/qt/DumpRenderTree.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::showWebInspector):
(LayoutTestController::hideWebInspector):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:
13:54 Changeset [51714] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skip tests that require support for frame loader callbacks
reporting, and a new test.

  • platform/gtk/Skipped:
13:45 BuildBot edited by maruel@chromium.org
(diff)
13:35 Changeset [51713] by yael.aharon@nokia.com
  • 2 edits in trunk/WebKitTools

Unreviewed build fix.

[Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.

  • DumpRenderTree/qt/DumpRenderTree.cpp:
13:19 Changeset [51712] by krit@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

2009-12-04 Dirk Schulze <krit@webkit.org>

Reviewed by Gustavo Noronha Silva.

Move the render result to svg/custom as a cross platform render result.

  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Removed.
  • svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
13:13 Changeset [51711] by ajwong@chromium.org
  • 2 edits in trunk/WebCore

Not reviewed: chromium build fix.

Fix Chromium build break caused by moving of isDefaultPortForProtocol() and
portAllowed() into KURL.h/KURL.cpp. Cloning code.

  • platform/KURLGoogle.cpp:

(WebCore::isDefaultPortForProtocol):
(WebCore::portAllowed):

13:03 Changeset [51710] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Remove suppress highlight when restoring selected node.

https://bugs.webkit.org/show_bug.cgi?id=32152

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setDocument.selectNode): (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode): (WebInspector.ElementsPanel.prototype.setDocument):
13:01 Changeset [51709] by kenneth@webkit.org
  • 6 edits in trunk

WebKitTools: Implement the setAllowUniversalAccessFromFileURLs method
for the Qt LayoutTestController.

Reviewed by Adam Treat.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setAllowUniversalAccessFromFileURLs):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests: Remove test that works after adding setAllowUniversalAccessFromFileURLs
to Qt's version of the LayoutTestController.

Reviewed by Adam Treat.

  • platform/qt/Skipped:
12:50 BuildBot edited by maruel@chromium.org
(diff)
12:24 BuildBot edited by maruel@chromium.org
(diff)
12:19 Changeset [51708] by krit@webkit.org
  • 5 edits
    4 adds in trunk

2009-12-04 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Gradient SVG animation demonstrates tearing at animation extremes
https://bugs.webkit.org/show_bug.cgi?id=11929

The focalPoint of a radial gradient is temporarly substracted by
the centralPoint, if the focalPoint is not in the radius of the
gradient. This is needed to calculate a new postion of the focalPoint
according to the specification. But the new focalPoint needs to be
moved by the centralPoint after this calculation, which is not the case
at the moment. This patch fixes this issue. It was also introduced a
deviation of maximal 0.2% for Cairo to get around the fixed point numbers
in Cairo.

W3C-SVG-1.1/pservers-grad-13-b needed an update. The missing adjustment
of the new focalPoint caused wrong results for the last three tests.

Test: svg/custom/radial-gradient-with-outstanding-focalPoint.svg

  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):

Gradient SVG animation demonstrates tearing at animation extremes
https://bugs.webkit.org/show_bug.cgi?id=11929

In SVG a focalPoint must be inside the radius of a radial gradient.
It this isn't the case, we have to move the focalPoint into the radius.
This checks the correct behavior of WebKit on false values for fx, fy.

  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
  • svg/custom/radial-gradient-with-outstanding-focalPoint.svg: Added.
12:16 Changeset [51707] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-04 Anton Muhin <antonm@chromium.org>

Reviewed by Dmitry Titov.

Do not use WebCore::String::String(const UChar*, int length) to convert
short v8 strings.

Plus added string traits.
https://bugs.webkit.org/show_bug.cgi?id=31415

  • bindings/v8/V8Binding.cpp: (WebCore::): (WebCore::v8StringToWebCoreString):
12:04 Changeset [51706] by cfleizach@apple.com
  • 12 edits
    2 adds in trunk

REGRESSION: AX: buttons now extremely repetitive
https://bugs.webkit.org/show_bug.cgi?id=32164

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/button-shouldnot-have-axvalue.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isButton):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(isAttributeSupportedCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::isAttributeSupported):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::isAttributeSupported):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::isAttributeSupported):

LayoutTests:

  • platform/mac-leopard/accessibility/table-with-aria-role-expected.txt:
  • platform/mac/accessibility/button-shouldnot-have-axvalue-expected.txt: Added.
  • platform/mac/accessibility/button-shouldnot-have-axvalue.html: Added.
  • platform/mac/accessibility/table-with-aria-role-expected.txt:
12:01 Changeset [51705] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-04 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Darin Adler.

Check whether the right side of a string append is non-empty
https://bugs.webkit.org/show_bug.cgi?id=32151

Especially beneficial for CachedScript::script() method
which usually appends an empty string returned by flush()
to its m_script member. m_script is often hundreds of kbytes
which is duplated without reason.

  • platform/text/String.cpp: (WebCore::String::append):
11:51 BuildBot edited by maruel@chromium.org
(diff)
11:49 Changeset [51704] by enrica@apple.com
  • 3 edits
    2 adds in trunk

Mail.app crashes when indenting table pasted from Numbers.app.
<rdar://problem/7209507>
https://bugs.webkit.org/show_bug.cgi?id=32166

Reviewed by John Sullivan.

WebCore:

Test: LayoutTests/editing/execCommand/indent-partial-table.html

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::indentRegion): Added test to verify that the end of the paragraph
after the selection has not been moved.

LayoutTests:

  • editing/execCommand/indent-partial-table-expected.txt: Added.
  • editing/execCommand/indent-partial-table.html: Added.
11:16 Changeset [51703] by ap@apple.com
  • 9 edits
    3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32085
WebSocket should block the same ports that are blocked for resource loading

Test: websocket/tests/url-parsing.html

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::localURLSchemes):
  • page/SecurityOrigin.h: Move isDefaultPortForProtocol() to KURL, because that's a better place for it (SecurityOrigin is not even in WebCore/platform directory).
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::host): (WebCore::HTMLAnchorElement::setHost): (WebCore::HTMLAnchorElement::setPort): Updated for the new location of isDefaultPortForProtocol().
  • platform/KURL.cpp: (WebCore::KURL::protocolIs): In an assertion, compare to "javascript" case-insensitively, since the function deosn't require lower case input. (WebCore::isDefaultPortForProtocol): Moved from SecurityOrigin. (WebCore::portAllowed): Moved from ResourceHandle.
  • platform/KURL.h:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::create): Updated for the new location of portAllowed().
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect): Per the spec, raise a SECURITY_ERR if trying to connect to a blocked port.
10:12 Changeset [51702] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Corrects QtLauncher style

  • QtLauncher/main.cpp: (WebPage::acceptNavigationRequest): (MainWindow::MainWindow): (MainWindow::webPage): (MainWindow::webView): (MainWindow::changeLocation): (MainWindow::loadFinished): (MainWindow::showLinkHover): (MainWindow::zoomIn): (MainWindow::zoomOut): (MainWindow::print): (MainWindow::setEditable): (MainWindow::dumpHtml): (MainWindow::selectElements): (MainWindow::newWindow): (MainWindow::setupUI): (WebPage::createWindow): (WebPage::createPlugin): (main):
10:04 Changeset [51701] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtLauncher: add a menu to show or hide the web inspector.
https://bugs.webkit.org/show_bug.cgi?id=32149

  • QtLauncher/main.cpp: (WebInspector::WebInspector): (WebInspector::showEvent): (WebInspector::hideEvent): (MainWindow::MainWindow): (MainWindow::setupUI):
09:57 Changeset [51700] by eric@webkit.org
  • 6 edits in trunk/LayoutTests

2009-12-04 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebKit crashes when loading certain SVG images
https://bugs.webkit.org/show_bug.cgi?id=29443

Update the test results for the new FontCache implementation.

  • platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/qt/css1/font_properties/font_variant-expected.txt:
  • platform/qt/css1/pseudo/firstline-expected.txt:
  • platform/qt/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt:
09:50 Changeset [51699] by eric@webkit.org
  • 6 edits
    1 delete in trunk/WebCore

2009-12-04 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebKit crashes when loading certain SVG images
https://bugs.webkit.org/show_bug.cgi?id=29443

Remove FontFallbackListQt and rely on the common FontFallbackList
to handle the fonts. FontCache and FontPlatformData have been
updated to work with the common FontFallbackList.

In the previous implementation, FontPlatformDataCacheKey
was a clone of FontPlatformData with the hashing
capabilities added in order to use it as a key in the cache's
hashmap. FontPlatformData has been modified to handle the hashing
function directly so the data are not copied twice in memory.

FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
code from FontCache::getFontData() and FontFallbackList::fontDataAt().
The behavior is similar except currFamily->family().length() was
not tested and the fallback fonts selector were not used.

Existing tests cover the change.

  • WebCore.pro:
  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::getTraitsInFamily): (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/qt/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/qt/FontFallbackListQt.cpp: Removed. We now use the implementation from FontFallbackList.cpp
  • platform/graphics/qt/FontPlatformData.h: Add hashing capabilities to be able to use the data with the FontCache. This was previously done in FontCacheQt.cpp (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::family): (WebCore::FontPlatformData::bold): (WebCore::FontPlatformData::italic): (WebCore::FontPlatformData::smallCaps): (WebCore::FontPlatformData::pixelSize):
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::hash):
09:43 Changeset [51698] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-12-04 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Antti Koivisto.

Split out the renderPrivate in two methods, one for working on
relative coordinates (relative to the viewport) and one for
working on absolute coordinates. The latter is more effecient
for implementing tiling, as you don't need translate the coords,
and because it avoid clipping to the viewport.

No behaviour changes, so no new tests.

  • Api/qwebframe.cpp: (QWebFramePrivate::renderContentsLayerAbsoluteCoords): (QWebFramePrivate::renderRelativeCoords): (QWebFrame::render):
  • Api/qwebframe_p.h:
09:14 Changeset [51697] by treat@webkit.org
  • 2 edits in trunk/WebCore

Fix wrong assert that was only working through sheer luck.
https://bugs.webkit.org/show_bug.cgi?id=32162

Patch by Adam Treat <atreat@rim.com> on 2009-12-04
Reviewed by Dan Bernstein.

  • platform/text/BidiContext.cpp:

(WebCore::BidiContext::create):

07:36 Changeset [51696] by vestbo@webkit.org
  • 4 edits in trunk

[Qt] Allow removing 'qrc' as a local security origin scheme

Reviewed by Simon Hausmann.

WebCore:

  • page/SecurityOrigin.cpp:

WebKit/qt:

  • tests/qwebpage/tst_qwebpage.cpp:
07:36 Changeset [51695] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Clean up argument parsing in the QtLauncher

Reviewed by Simon Hausmann.

  • QtLauncher/main.cpp:
05:43 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
04:56 Changeset [51694] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Prevent the inspector from closing its wrapping widget.
This is not necessary anymore since we now hide the embedded
close button.
https://bugs.webkit.org/show_bug.cgi?id=32149

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::showWindow): (WebCore::InspectorClientQt::closeWindow):
04:07 Changeset [51693] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CollectionCache
https://bugs.webkit.org/show_bug.cgi?id=32109

Reviewed by Eric Seidel.

Inherits the following class from FastAllocBase because it is
instantiated by 'new':

struct name - instantiated at: WebCore/'location'

struct CollectionCache - dom/Document.cpp:4029

  • html/CollectionCache.h:
03:30 Changeset [51692] by eric@webkit.org
  • 4 edits
    6 adds in trunk

2009-12-04 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Fixes a crashing bug in Geolocation when a watch is cleared from some callbacks.
https://bugs.webkit.org/show_bug.cgi?id=32111

  • fast/dom/Geolocation/resources/permission-denied-already-clear-watch.js: Added. Tests clearing the watch from the error callback after a permission denied message when permissions have already been denied.
  • fast/dom/Geolocation/permission-denied-already-clear-watch.html: Added. HTML wrapper for above test.
  • fast/dom/Geolocation/permission-denied-already-clear-watch-expected.txt: Added. Expected result for above test.
  • fast/dom/Geolocation/resources/timeout-clear-watch.js: Added. Tests clearing the watch from the error callback due to a timeout.
  • fast/dom/Geolocation/timeout-clear-watch.html: Added. HTML wrapper for above test.
  • fast/dom/Geolocation/timeout-clear-watch-expected.txt: Added. Expected result for above test.
  • platform/gtk/Skipped: Modified. Skips new tests.

2009-12-04 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Fixes a crashing bug in Geolocation when a watch is cleared from some callbacks.
https://bugs.webkit.org/show_bug.cgi?id=32111

In Geolocation::GeoNotifier::timerFired, a JS callback may be invoked if a
fatal error was registered on this GeoNotifier or if this request has timed
out. If the request is a watch, and is cleared by a call to clearWatch in the
callback, the GeoNotifier object will be destroyed. We must therefore cache the
m_geolocation member to allow us to call Geolocation::fatalErrorOccurred or
Geolocation::requestTimedOut.

Tests: fast/dom/Geolocation/permission-denied-already-clear-watch.html

fast/dom/Geolocation/timeout-clear-watch.html

  • page/Geolocation.cpp: Modified. (WebCore::Geolocation::GeoNotifier::timerFired): Modified. Cache the m_geolocation member before invoking the JS callback.
02:37 Changeset [51691] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Re-enable audio/video tests after updated buildbot's Qt
to Phonon supported one, and put 2 bad tests into skiplist.

Reviewed by Simon Hausmann.

  • platform/qt/Skipped:
02:33 Changeset [51690] by zoltan@webkit.org
  • 3 edits in trunk/WebCore

Allow custom memory allocation control for 2 classes of the platform directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=

Reviewed by Eric Seidel.

Inherits the following class from Noncopyable because it is instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

class SharedTimer - (its child class) workers/WorkerRunLoop.cpp:91

Inherits the following class from FastAllocBase because it is
instantiated by 'new':

class TransformOperations - rendering/style/RenderStyle.h:1175

Noncopyable.h's include added to SharedTimer.h.

  • platform/SharedTimer.h:
  • platform/graphics/transforms/TransformOperations.h:
02:18 Changeset [51689] by xan@webkit.org
  • 4 edits in trunk

2009-12-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK]Enable DNS prefetching
https://bugs.webkit.org/show_bug.cgi?id=23846

Bump libsoup required version to 2.29.3 for DNS prefetching.

  • configure.ac:

WebCore:

2009-12-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK]Enable DNS prefetching
https://bugs.webkit.org/show_bug.cgi?id=23846

Enable DNS prefetching.

Based on a patch by José Millán.

  • platform/network/soup/DNSSoup.cpp: (WebCore::prefetchDNS):
00:56 Changeset [51688] by zoltan@webkit.org
  • 3 edits in trunk/WebCore

Roll out r51687 because it breaks the Leopard builds.

00:38 Changeset [51687] by zoltan@webkit.org
  • 3 edits in trunk/WebCore

2009-12-04 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

Allow custom memory allocation control for 2 classes of the platform directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=

Inherits the following class from Noncopyable because it is instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

class SharedTimer - (its child class) workers/WorkerRunLoop.cpp:91

Inherits the following class from FastAllocBase because it is
instantiated by 'new':

class TransformOperations - rendering/style/RenderStyle.h:1175

  • platform/SharedTimer.h:
  • platform/graphics/transforms/TransformOperations.h:
00:25 Changeset [51686] by eric@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2009-12-04 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Fisher.

Add test to see if unicode messages can be sent over web socket.

https://bugs.webkit.org/show_bug.cgi?id=31341

  • websocket/tests/script-tests/unicode.js: Added. (endTest): (ws.onopen): (ws.onmessage): (ws.onclose): (timeOutCallback):
  • websocket/tests/unicode-expected.txt: Added.
  • websocket/tests/unicode.html: Added.
  • websocket/tests/unicode_wsh.py: Added.
00:15 Changeset [51685] by zoltan@webkit.org
  • 5 edits in trunk/WebCore

2009-12-04 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

Allow custom memory allocation control for the svg directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

struct ResourceSet - svg/graphics/SVGResource.cpp:148
class SVGFontData - css/CSSFontFaceSource.cpp:156
class SVGDocumentExtensions - dom/Document.cpp:3962
class SVGViewSpec - svg/SVGSVGElement.cpp:191

  • svg/SVGDocumentExtensions.h:
  • svg/SVGFontData.h:
  • svg/SVGViewSpec.h:
  • svg/graphics/SVGResource.cpp:

12/03/09:

23:50 Changeset [51684] by cfleizach@apple.com
  • 7 edits
    4 adds in trunk

WAI-ARIA: aria-activedescendant doesn't work as intended
https://bugs.webkit.org/show_bug.cgi?id=32100

Reviewed by Beth Dakin.

WebCore:

Fixes a number of issues regarding the "tree" role and aria-activedescendant.

  1. The indexes were being reported incorrectly by treeitems.
  2. aria-activedescendant changes were not being sent to the containing item.
  3. The tree's selected rows need to consult aria-activedescendant.
  4. Since a tree changes what it returns as its children (it returns its rows) the mac-specific array indexing methods need to correctly handle the tree case.

Tests: platform/mac/accessibility/aria-tree-activedescendant.html

platform/mac/accessibility/aria-tree-index-of-items.html

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
(WebCore::AccessibilityRenderObject::activeDescendant):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

  • platform/mac/accessibility/aria-tree-activedescendant-expected.txt: Added.
  • platform/mac/accessibility/aria-tree-activedescendant.html: Added.
  • platform/mac/accessibility/aria-tree-index-of-items-expected.txt: Added.
  • platform/mac/accessibility/aria-tree-index-of-items.html: Added.
23:48 Changeset [51683] by zoltan@webkit.org
  • 5 edits in trunk/WebCore

2009-12-03 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

Allow custom memory allocation control for the xml directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=

Inherits the following class from Noncopyable because it is instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

struct XMLHttpRequestStaticData - xml/XMLHttpRequest.cpp:134

Inherits the following classes from FastAllocBase because these are instantiated by 'new':

class NodeTest - xml/XPathGrammar.y:258
class NodeSet - xml/XPathValue.cpp:52
struct EvaluationContext - xml/XPathExpressionNode.cpp:40

  • xml/XMLHttpRequest.cpp:
  • xml/XPathExpressionNode.h:
  • xml/XPathNodeSet.h:
  • xml/XPathStep.h:
23:42 Changeset [51682] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2009-12-03 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

check-webkit-style should check for camelCase variable names
https://bugs.webkit.org/show_bug.cgi?id=32051

  • Scripts/modules/cpp_style.py:
  • Scripts/modules/cpp_style_unittest.py:
22:40 Changeset [51681] by atwilson@chromium.org
  • 4 edits
    1 add in trunk/WebCore

New History changes do not compile for Chromium/V8
https://bugs.webkit.org/show_bug.cgi?id=32148

Reviewed by Adam Barth.

Existing tests suffice (just trying to get code to compile).

  • WebCore.gypi:

Added V8HistoryCustom.cpp and other missing files.

  • bindings/v8/custom/V8CustomBinding.h:

Added custom handlers for History.pushState()/replaceState().

  • bindings/v8/custom/V8HistoryCustom.cpp: Added.

Added custom handlers for History.pushState()/replaceState().

  • history/BackForwardListChromium.cpp:

(WebCore::BackForwardList::pushStateItem):
Stubbed out this routine for now - will implement in the future.

22:19 Changeset [51680] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-12-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

OwnPtr<XBLBindingManager> Document::m_bindingManager;
https://bugs.webkit.org/show_bug.cgi?id=32147

The document actually owns the bindingManager. That's what the code
should say.

  • dom/Document.cpp: (WebCore::Document::~Document):
  • dom/Document.h: (WebCore::Document::bindingManager):
21:55 Changeset [51679] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-12-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

OwnPtr<Tokenizer> Document::m_tokenizer;
https://bugs.webkit.org/show_bug.cgi?id=32145

The document actually owns the tokenizer. That's what the code should say.

  • dom/Document.cpp: (WebCore::Document::removedLastRef): (WebCore::Document::~Document): (WebCore::Document::cancelParsing): (WebCore::Document::implicitOpen): (WebCore::Document::implicitClose):
  • dom/Document.h: (WebCore::Document::tokenizer):
21:54 Changeset [51678] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-12-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

OwnPtr<RenderArena> Document::m_renderArena;
https://bugs.webkit.org/show_bug.cgi?id=32146

The document owns the renderArena. That's what the code should say.

  • dom/Document.cpp: (WebCore::Document::Document): Also, removed a redundant initialization of the tokenizer that I missed in my previous patch. (WebCore::Document::~Document): (WebCore::Document::attach): (WebCore::Document::detach):
  • dom/Document.h: (WebCore::Document::renderArena):
21:54 Changeset [51677] by atwilson@chromium.org
  • 5 edits in trunk

Revert r51633

This reverts commit 4c9cc0b9a12d38654b9c687ffc1671c7307b397a.

21:33 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
21:28 Changeset [51676] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-12-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

The code should say that Document owns DocLoader
https://bugs.webkit.org/show_bug.cgi?id=32143

It's the truth.

  • dom/Document.cpp: (WebCore::Document::~Document):
  • dom/Document.h: (WebCore::Document::docLoader):
18:53 Changeset [51675] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Try and fix the Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export a symbol that should be exported.
18:35 Changeset [51674] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Try and fix the Mac build.

18:28 Changeset [51673] by cfleizach@apple.com
  • 3 edits in trunk/LayoutTests

Fixing layout test bustage on platforms.

AX: VO just says "term" on many web sites
https://bugs.webkit.org/show_bug.cgi?id=32139

  • platform/mac-leopard/accessibility/lists-expected.txt:
  • platform/mac/accessibility/radio-button-group-members-expected.txt:
18:17 Changeset [51672] by oliver@apple.com
  • 6 edits in trunk/JavaScriptCore

REGRESSION(4.0.3-48777): Crash in JSC::ExecState::propertyNames() (Debug-only?)
https://bugs.webkit.org/show_bug.cgi?id=32133

Reviewed by Gavin Barraclough.

Work around odd GCC-ism and correct the scopechain for use by
calls made while a cachedcall is active on the callstack.

18:15 Changeset [51671] by barraclough@apple.com
  • 9 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=32136
Add a rope representation to JSString. Presently JSString always holds its data in UString form.
Instead, allow the result of a string concatenation to be represented in a tree form - with a
variable sized, reference-counted rope node retaining a set of UString::Reps (or other rope nopes).

Reviewed by Oliver "Brraaaaiiiinnnnnzzzzzzzz" Hunt.

Strings must still currently be resolved down to a flat UString representation before being used,
but by holding the string in a rope representation during construction we can avoid copying data
until we know the final size of the string.

~2% progression on SunSpider (~25% on date-format-xparb, ~20% on string-validate-input).

  • Update exports.
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • Make use of new JSString::length() method to avoid prematurely resolving ropes.
  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • Switch the string length trampoline to read the length directly from JSString::m_length, rather than from the JSString's UString::Rep's 'len' property.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Modify op_add such that addition of two strings, where either or both strings are already in rope representation, produces a rope as a result.
  • runtime/JSString.cpp:

(JSC::JSString::Rope::~Rope):
(JSC::copyChars):
(JSC::JSString::resolveRope):
(JSC::JSString::getPrimitiveNumber):
(JSC::JSString::toBoolean):
(JSC::JSString::toNumber):
(JSC::JSString::toString):
(JSC::JSString::toThisString):
(JSC::JSString::getStringPropertyDescriptor):

  • runtime/JSString.h:

(JSC::JSString::Rope::Fiber::Fiber):
(JSC::JSString::Rope::Fiber::destroy):
(JSC::JSString::Rope::Fiber::isRope):
(JSC::JSString::Rope::Fiber::rope):
(JSC::JSString::Rope::Fiber::string):
(JSC::JSString::Rope::create):
(JSC::JSString::Rope::initializeFiber):
(JSC::JSString::Rope::ropeLength):
(JSC::JSString::Rope::stringLength):
(JSC::JSString::Rope::fibers):
(JSC::JSString::Rope::Rope):
(JSC::JSString::Rope::operator new):
(JSC::JSString::JSString):
(JSC::JSString::value):
(JSC::JSString::length):
(JSC::JSString::isRope):
(JSC::JSString::rope):
(JSC::JSString::string):
(JSC::JSString::canGetIndex):
(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSubstring):
(JSC::JSString::getStringPropertySlot):

  • Add rope form.
  • runtime/Operations.h:

(JSC::jsAdd):
(JSC::concatenateStrings):

  • Update string concatenation, and addition of ropes, to produce ropes.
  • runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertyNames):

  • Make use of new JSString::length() method to avoid prematurely resolving ropes.
18:06 Changeset [51670] by cfleizach@apple.com
  • 13 edits
    2 adds in trunk

AX: VO just says "term" on many web sites
https://bugs.webkit.org/show_bug.cgi?id=32139

Reviewed by Eric Seidel.

WebCore:

Test: platform/mac/accessibility/definition-list-term.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityDescription):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper subrole]):
(-[AccessibilityObjectWrapper roleDescription]):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(getRoleDescriptionCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::roleDescription):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::roleDescription):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::roleDescription):

LayoutTests:

  • platform/mac/accessibility/aria-grouping-roles-expected.txt:
  • platform/mac/accessibility/aria-grouping-roles.html:
  • platform/mac/accessibility/definition-list-term-expected.txt: Added.
  • platform/mac/accessibility/definition-list-term.html: Added.
  • platform/mac/accessibility/lists-expected.txt:
17:00 Changeset [51669] by cfleizach@apple.com
  • 16 edits
    2 adds in trunk

Implement WAI-ARIA scrollbar role and related property aria-orientation
https://bugs.webkit.org/show_bug.cgi?id=32126

Reviewed by Beth Dakin.

WebCore:

Test: accessibility/aria-scrollbar-role.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isScrollbar):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::valueForRange):
(WebCore::AccessibilityRenderObject::orientation):
(WebCore::AccessibilityRenderObject::canHaveChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/HTMLAttributeNames.in:

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(getOrientationCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::orientation):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::orientation):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::orientation):

LayoutTests:

  • accessibility/aria-scrollbar-role-expected.txt: Added.
  • accessibility/aria-scrollbar-role.html: Added.
  • platform/gtk/Skipped:
  • platform/win/Skipped:
16:16 Changeset [51668] by mitz@apple.com
  • 4 edits
    4 adds in trunk

Fixed <rdar://problem/7401617> Selection painting issue in hardware-
accelerated layers
which is another part of https://bugs.webkit.org/show_bug.cgi?id=23628
Fix selection painting to do container-relative repaints

Reviewed by Darin Adler.

Test: fast/repaint/block-selection-gap-in-composited-layer.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint): Compute and paint
gap rects in the coordinate space of the repaint container.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): Added a
FIXME.

  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection): Map block selection gap rects from
the repaint container’s coordinate space to the view’s coordinate space
before adding them to the cached selection bounds.
(WebCore::RenderView::clearSelection): Changed to use
repaintRectangleInViewAndCompositedLayers() so that the selection rect
is invalidated in composited layers as well.

16:07 Changeset [51667] by ap@apple.com
  • 4 edits in trunk/LayoutTests

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32132
websocket/tests/simple.html fails on Windows

  • websocket/tests/script-tests/simple.js:
  • websocket/tests/simple-expected.txt: Make the test weaker - readyState could already grow by the time a posted event gets dispatched.
  • platform/win/Skipped: Un-skip the test.
15:37 Changeset [51666] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Make shorthand-transitions.html less flaky.
The test currently allows for timing related differences by using a tolerance, but the tolerance
is inconsistent in the test, even for values read at the same time (some values are allowed a 100ms
difference, others are only allowed 50ms). This change makes all values have a 100ms tolerance.
(open question: is 100ms enough? I've looked through a bunch of logs of failures and it seems to be,
so this should definitely help reduce but this may not entirely eliminate flakiness).

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32134

  • transitions/shorthand-transitions.html:
15:24 Changeset [51665] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-12-03 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32135

[Qt] Add expected files for new tests we pass.
Compared to the Mac expected png files.

  • platform/qt/fast/css/namespaces/namespaces-escapes-expected.txt: Added.
  • platform/qt/fast/css/namespaces/namespaces-invalid-at-expected.txt: Added.
14:17 Changeset [51664] by eric.carlson@apple.com
  • 2 edits in trunk/WebKitTools

2009-12-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

Minor correction to r51663.

  • DumpRenderTree/win/DumpRenderTree.cpp: (addQTDirToPATH):

GetEnvironmentVariable -> GetEnvironmentVariableW.

14:10 Changeset [51663] by eric.carlson@apple.com
  • 2 edits in trunk/WebKitTools

2009-12-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
https://bugs.webkit.org/show_bug.cgi?id=30256

Add the QuickTime dll directory to the PATH environment variable so
inialization can succeed.

  • DumpRenderTree/win/DumpRenderTree.cpp: (addQTDirToPATH): (initialize):
14:08 Changeset [51662] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-03 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::maybeDump):
14:01 Changeset [51661] by eric@webkit.org
  • 8 edits in trunk/WebKitTools

2009-12-03 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

Update pywebsocket to 0.4.3
This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
Stack trace is logged now in INFO level.
https://bugs.webkit.org/show_bug.cgi?id=32097

  • pywebsocket/mod_pywebsocket/dispatch.py:
  • pywebsocket/mod_pywebsocket/msgutil.py:
  • pywebsocket/mod_pywebsocket/standalone.py:
  • pywebsocket/mod_pywebsocket/util.py:
  • pywebsocket/setup.py:
  • pywebsocket/test/test_dispatch.py:
  • pywebsocket/test/test_util.py:
13:54 Changeset [51660] by eric@webkit.org
  • 9 edits
    1 add in trunk

2009-12-03 Jonathan Dixon <joth@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 32066 - Add enable geolocation flag to WebCore::Settings for Chromium
https://bugs.webkit.org/show_bug.cgi?id=32066

Adds geolocationEnabled in Settings for runtime control of geolocaiton features. This defaults to ON
as it is intended as a development and testing aid, not a user control. To completely remove geolocation
from a given port, the compile time ENABLE_GEOLOCATION should still be used.
Adding placeholder GeolocationServiceChromium implementation, as this is required to allows
ENABLE_GEOLOCATION to be defined (in turn required for testing), even though this patch does not
make that the default just yet.

  • WebCore.gypi:
  • page/Settings.cpp: (WebCore::Settings::Settings): Add new m_geolocationEnabled flag default value (WebCore::Settings::setGeolocationEnabled): Setter for m_geolocationEnabled flag
  • page/Settings.h: (WebCore::Settings::geolocationEnabled): Add m_geolocationEnabled flag
  • platform/chromium/GeolocationServiceChromium.cpp: Added. (WebCore::GeolocationServiceChromium::GeolocationServiceChromium): Place holder GeolocationServiceChromium) (WebCore::createGeolocationService): factory function, only required when ENABLED(GEOLOCATION) is true

2009-12-03 Jonathan Dixon <joth@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 32066 - Add enable geolocation flag to WebCore::Settings for Chromium
https://bugs.webkit.org/show_bug.cgi?id=32066

Add the plumbing to map WebSettings through to WebCore::Settings

  • features.gypi:
  • public/WebSettings.h: Add setGeolocationEnabled API to interface
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setGeolocationEnabled): Calls through to WebCore::Settings::setGeolocationEnabled
  • src/WebSettingsImpl.h: Add setGeolocationEnabled interface function
13:43 Changeset [51659] by enrica@apple.com
  • 2 edits in trunk/WebCore

SpinTracer: 349 spins in Mail at WebCore::Editor::advanceToNextMisspelling(bool)
<rdar://problem/7198592>
https://bugs.webkit.org/show_bug.cgi?id=32129

Reviewed by John Sullivan.

Fixed the way the next paragraph is calculated.
I've added a repro case in Safari and attached it to the Bugzilla bug.

  • editing/Editor.cpp:

(WebCore::findFirstMisspellingOrBadGrammarInRange): Changed the way we move to the
next paragraph in the loop.

13:37 Changeset [51658] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-03 İsmail Dönmez <ismail@namtrac.org>

Reviewed by Eric Seidel.

Fix compilation when SVG is disabled.

  • Api/qwebframe.cpp: (qt_drt_pauseSVGAnimation):
13:27 Changeset [51657] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Alexey Proskuryakov.

Skip failing WebSocket test on Windows.

  • platform/win/Skipped:
13:25 Changeset [51656] by weinig@apple.com
  • 4 edits in trunk/WebKitTools

Fix JSClassRef leak.

Reviewed by Gavin Barraclough.

  • DumpRenderTree/AccessibilityController.cpp:

(AccessibilityController::makeWindowObject):

  • DumpRenderTree/GCController.cpp:

(GCController::makeWindowObject):

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::makeWindowObject):

13:19 Changeset [51655] by beidson@apple.com
  • 3 edits in trunk/LayoutTests

Rubberstamped by Oliver Hunt.

Fix layout tests by removing the full outputting of the Date object and just outputting the milliseconds since the epoch.

  • fast/loader/stateobjects/pushstate-object-types-expected.txt:
  • fast/loader/stateobjects/pushstate-object-types.html:
13:06 Changeset [51654] by ap@apple.com
  • 1 edit
    1 copy
    2 adds in trunk/LayoutTests

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32130
Add a test for sending non-trivial amount of data over WebSocket

  • websocket/tests/echo_wsh.py: Copied from WebKitTools/pywebsocket/example/echo_wsh.py.
  • websocket/tests/simple-stress-expected.txt: Added.
  • websocket/tests/simple-stress.html: Added.
12:59 Changeset [51653] by beidson@apple.com
  • 7 edits in trunk/LayoutTests

Rubberstamped by Sam Weinig.

Fix my absolute URL snafu by outputting only the last path component for these URLs,
which is all that is relevant.

  • fast/loader/stateobjects/document-destroyed-navigate-back-expected.txt:
  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll-expected.txt:
  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
  • fast/loader/stateobjects/document-destroyed-navigate-back.html:
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange-expected.txt:
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
12:38 Changeset [51652] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix

11:51 Changeset [51651] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix

11:39 Changeset [51650] by beidson@apple.com
  • 2 edits in trunk/WebCore

No wonder editing WebCore.exp repeatedly while I worked on this patch never seemed to stick.

Long live our auto-generated overlords that I didn't know about...

  • WebCore.base.exp:
11:34 Changeset [51649] by oliver@apple.com
  • 6 edits in trunk

REGRESSION (r51627): 3 SVG tests are failing
https://bugs.webkit.org/show_bug.cgi?id=32117

Reviewed by Dan Bernstein.

Null checking Items in the SVGList is insufficient as items may
be floats, etc so add SVGListTraits::isNull and add appropriate
specializations.

Test: svg/dom/svglist-exception-on-out-bounds-error.html

11:32 Changeset [51648] by beidson@apple.com
  • 2 edits in trunk/WebCore

No review - release build fix.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::documentDetached):

11:27 Changeset [51647] by beidson@apple.com
  • 2 edits in trunk/WebCore

No review - release build fix.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::pushState):

11:25 Changeset [51646] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force Interfaces rebuild and fix Windows build.

11:18 Changeset [51645] by enrica@apple.com
  • 12 edits
    2 adds in trunk

WebCore: Multiple Undos removes the last posted comment and/or the ones before it.
<rdar://problem/6557066>
https://bugs.webkit.org/show_bug.cgi?id=32079

Reviewed by Adele Peterson.

The fix consists in preventing Undos and Redos to be applied to elements that
are no longer editable. We do not attempt to remove the commands from the queue.
It is a relatively simple fix that comes with a little extra overhead for the apply
and unapply methods where we are now performing the editability check.

Test: editing/undo/undo-indent-noneditable.html

  • editing/AppendNodeCommand.cpp:

(WebCore::AppendNodeCommand::doApply):
(WebCore::AppendNodeCommand::doUnapply):

  • editing/DeleteFromTextNodeCommand.cpp:

(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):

  • editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):

  • editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):

  • editing/JoinTextNodesCommand.cpp:

(WebCore::JoinTextNodesCommand::doApply):
(WebCore::JoinTextNodesCommand::doUnapply):

  • editing/MergeIdenticalElementsCommand.cpp:

(WebCore::MergeIdenticalElementsCommand::doApply):
(WebCore::MergeIdenticalElementsCommand::doUnapply):

  • editing/RemoveNodeCommand.cpp:

(WebCore::RemoveNodeCommand::doApply):
(WebCore::RemoveNodeCommand::doUnapply):

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::executeApply):
(WebCore::SplitElementCommand::doUnapply):

  • editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::doApply):
(WebCore::SplitTextNodeCommand::doUnapply):

  • editing/WrapContentsInDummySpanCommand.cpp:

(WebCore::WrapContentsInDummySpanCommand::doUnapply):
(WebCore::WrapContentsInDummySpanCommand::doReapply):

LayoutTests: Multiple Undos removes the last posted comment and/or the ones before it.
<rdar://problem/6557066>
https://bugs.webkit.org/show_bug.cgi?id=32079

Reviewed by Adele Peterson.

Added test to verify that undo has no effect when an element is
no longer editable.

  • editing/undo/undo-indent-noneditable-expected.txt: Added.
  • editing/undo/undo-indent-noneditable.html: Added.
11:04 Changeset [51644] by beidson@apple.com
  • 67 edits
    29 adds in trunk

<rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API

Reviewed by Sam Weinig.

WebCore:

Tests: fast/loader/stateobjects/document-destroyed-navigate-back.html

fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html
fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html
fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html
fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html
fast/loader/stateobjects/pushstate-object-types.html
fast/loader/stateobjects/pushstate-then-replacestate.html
fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html
fast/loader/stateobjects/replacestate-then-pushstate.html
http/tests/loading/state-object-security-exception.html

Derived sources and project file changes:

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am
  • WebCore.pro
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Add the new PopStateEvent:

  • dom/PopStateEvent.cpp: Added.

(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::initPopStateEvent):

  • dom/PopStateEvent.h: Added.

(WebCore::PopStateEvent::create):
(WebCore::PopStateEvent::isPopStateEvent):
(WebCore::PopStateEvent::state):

  • dom/PopStateEvent.idl: Added.
  • bindings/js/JSPopStateEventCustom.cpp: Added.

(WebCore::JSPopStateEvent::initPopStateEvent):
(WebCore::JSPopStateEvent::state):

  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • dom/Event.cpp:

(WebCore::Event::isPopStateEvent):

  • dom/Event.h:
  • dom/EventNames.h:

Add the "onpopstate" attribute:

  • html/HTMLAttributeNames.in:
  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::parseMappedAttribute):

  • html/HTMLBodyElement.idl:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::parseMappedAttribute):

  • html/HTMLFrameSetElement.h:
  • html/HTMLFrameSetElement.idl:
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

Add pushState and replaceState management to the loader and history machinery:

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::updateForSameDocumentNavigation): Augmented from "scrollToAnchor()", combining

both the same-document fragment scroll case with the new same-document state object activation case.

(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):

  • loader/HistoryController.h:
  • history/BackForwardList.cpp:

(WebCore::BackForwardList::addItem): Use insertItemAfterCurrent.
(WebCore::BackForwardList::insertItemAfterCurrent): Optionally insert the item without clearing the forward

list, as pushStateItem might've selectively cleared only certain items, with the bulk of the forward list
meant to remain.

(WebCore::BackForwardList::pushStateItem): Clear the forward list *only* for the state item's document, then

insert the new item.

(WebCore::BackForwardList::removeItem):

  • history/BackForwardList.h:
  • page/History.cpp:

(WebCore::History::urlForState):
(WebCore::History::stateObjectAdded):

  • page/History.h:
  • page/History.idl:

Let HistoryItems and Documents associate with each other, as well as letting HistoryItems contain state objects:

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::~HistoryItem):
(WebCore::HistoryItem::setStateObject):
(WebCore::HistoryItem::setDocument):
(WebCore::HistoryItem::documentDetached):

  • history/HistoryItem.h:

(WebCore::HistoryItem::stateObject):
(WebCore::HistoryItem::document):

  • dom/Document.cpp:

(WebCore::Document::detach): Notify all back/forward history items owned by this Document that it

is going away.

(WebCore::Document::registerHistoryItem): Manage the list of back/forward history items this document owns.
(WebCore::Document::unregisterHistoryItem): Ditto.

  • dom/Document.h:

Add the ability for Documents, DocumentLoaders, and FrameLoaderClients to be notified when a Documents
URL changes as the result of pushState(), replaceState(), or a popstate navigation:

  • dom/Document.cpp:

(WebCore::Document::implicitClose): If there's a pending state object, dispatch the popstate event.
(WebCore::Document::updateURLForPushOrReplaceState):
(WebCore::Document::statePopped): If loading is complete, dispatch the popstate event. Otherwise, set

the pending state object.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::replaceRequestURLForSameDocumentNavigation):

  • loader/DocumentLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchDidChangeStateObjectForPageForFrame):

Change handling of "loading a HistoryItem" to distinguish between new-Document navigations and same-Document
navigations, combining the old concept of anchor scrolls with the new concept of state object navigations:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::navigateWithinDocument):
(WebCore::FrameLoader::navigateToDifferentDocument):
(WebCore::FrameLoader::loadItem):

  • loader/FrameLoader.h:
  • page/Page.cpp:

(WebCore::Page::goToItem): Changed to allow state object activations to pass through without the load stopping.

WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidPushStateWithinPage):
(WebKit::FrameLoaderClientImpl::dispatchDidReplaceStateWithinPage):
(WebKit::FrameLoaderClientImpl::dispatchDidPopStateWithinPage):

  • src/FrameLoaderClientImpl.h:

WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidPushStateWithinPage):
(WebKit::FrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebKit::FrameLoaderClient::dispatchDidPopStateWithinPage):

  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebFrameLoaderClient::dispatchDidPopStateWithinPage):

  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebFrameLoadDelegatePrivate.h:
  • WebView/WebView.mm:

(-[WebView _cacheFrameLoadDelegateImplementations]):

WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidPushStateWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidReplaceStateWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidPopStateWithinPage):

  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

  • Interfaces/IWebFrameLoadDelegatePrivate2.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebFrameLoaderClient::dispatchDidPopStateWithinPage):

  • WebCoreSupport/WebFrameLoaderClient.h:

WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::dispatchDidPushStateWithinPage):
(WebCore::FrameLoaderClientWx::dispatchDidReplaceStateWithinPage):
(WebCore::FrameLoaderClientWx::dispatchDidPopStateWithinPage):

  • WebKitSupport/FrameLoaderClientWx.h:

WebKitTools:

Keep DRT-win building...

  • DumpRenderTree/win/FrameLoadDelegate.h:

(FrameLoadDelegate::didPushStateWithinPageForFrame):
(FrameLoadDelegate::didReplaceStateWithinPageForFrame):
(FrameLoadDelegate::didPopStateWithinPageForFrame):

LayoutTests:

Update expected results of old tests:

  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/security/cross-frame-access-enumeration-expected.txt:

New tests:

  • fast/loader/stateobjects: Added.
  • fast/loader/stateobjects/document-destroyed-navigate-back-expected.txt: Added.
  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll-expected.txt: Added.
  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html: Added.
  • fast/loader/stateobjects/document-destroyed-navigate-back.html: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-addeventlistener-expected.txt: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-body-attribute-expected.txt: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute-expected.txt: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-window-attribute-expected.txt: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html: Added.
  • fast/loader/stateobjects/pushstate-object-types-expected.txt: Added.
  • fast/loader/stateobjects/pushstate-object-types.html: Added.
  • fast/loader/stateobjects/pushstate-then-replacestate-expected.txt: Added.
  • fast/loader/stateobjects/pushstate-then-replacestate.html: Added.
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange-expected.txt: Added.
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html: Added.
  • fast/loader/stateobjects/replacestate-then-pushstate-expected.txt: Added.
  • fast/loader/stateobjects/replacestate-then-pushstate.html: Added.
  • fast/loader/stateobjects/resources: Added.
  • fast/loader/stateobjects/resources/navigate-back.html: Added.
  • http/tests/loading/state-object-security-exception-expected.txt: Added.
  • http/tests/loading/state-object-security-exception.html: Added.
10:53 Changeset [51643] by kov@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Xan Lopez.

Platform-specific result for test. GIO identifies the file as
application/javascript, as opposed to other platforms identifying
it as application/x-javascript.

  • platform/gtk/inspector/timeline-network-resource-expected.txt: Added.
10:04 Changeset [51642] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-12-03 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium build fix.
r51621 changed JS bindings only, broke v8's.

  • bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument):
  • bindings/v8/ScriptFunctionCall.h:
09:16 Changeset [51641] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.

Re-baseline required after r51522.

  • platform/gtk/editing/deleting/5390681-2-expected.txt:
09:09 Changeset [51640] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping new tests, and tests that require new DRT functionality.

09:06 Changeset [51639] by zoltan@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed build fix.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-03
[Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.

  • DumpRenderTree/qt/DumpRenderTree.cpp:
08:57 Changeset [51638] by dglazkov@chromium.org
  • 6 edits in trunk/WebCore

2009-12-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

[V8] Attributes and NamedNodeMaps aren't tracked correctly and may be prematurely garbage-collected.
https://bugs.webkit.org/show_bug.cgi?id=32094

Covered by existing test: LayoutTests/fast/dom/Attr/access-after-element-destruction.html

  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object):
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8GCController.cpp: (WebCore::ObjectGrouperVisitor::visitDOMWrapper):
  • bindings/v8/custom/V8CustomBinding.h:
08:43 Changeset [51637] by pfeldman@chromium.org
  • 4 edits in trunk

2009-12-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Chromium: Add support for settings containing ":"

https://bugs.webkit.org/show_bug.cgi?id=32118

  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::loadSettings):
06:25 Changeset [51636] by kenneth@webkit.org
  • 4 edits in trunk/WebCore

repaint events from outside the viewport aren't received
https://bugs.webkit.org/show_bug.cgi?id=32081

Reviewed by Simon Fraser.

When using a tiled backing store for painting, you need to receive
event from outside the viewport. Setting the viewport to the size
of the contents is not an option if you want to make use of WebCore's
infrastructure for drawing scrollbars etc.

A new property, paintsEntireContents, has been introduced for the
above use-case. It is settable, as tiling will be optional for Qt,
and for the not yet upstreamed EFL port, there will be two different
views, where only one of them are tiled.

No change in behavior, so no new tests added.

  • page/FrameView.cpp:

(WebCore::FrameView::repaintContentRectangle):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::setPaintsEntireContents):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:

(WebCore::ScrollView::paintsEntireContents):

06:24 Changeset [51635] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip layoutTestController.notifyDone() related tests which got revealed in r51634
until there is a fix for the issue.
https://bugs.webkit.org/show_bug.cgi?id=31626

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-03
Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/Skipped:
06:20 Moving to Git edited by maruel@chromium.org
Add Gerrit2 link and the fact that cygwin is already a requirement on … (diff)
06:06 Changeset [51634] by ossy@webkit.org
  • 5 edits in trunk

WebKitTools: [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
Prevent DRT from showing the main view if these childs get deleted.
This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-03
Reviewed by Kenneth Rohde Christiansen.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::WebPage):
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::~DumpRenderTree):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::closeRemainingWindows):
(WebCore::DumpRenderTree::createWindow):
(WebCore::DumpRenderTree::windowCount):

  • DumpRenderTree/qt/DumpRenderTree.h:

LayoutTests: [Qt] Re-enable previously skipped tests.
https://bugs.webkit.org/show_bug.cgi?id=31591

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-03
Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/Skipped:
05:52 Changeset [51633] by jeremy@chromium.org
  • 5 edits in trunk

Reviewed by Eric Seidel.

Switch Chrome/Mac to use Core Text APIs rather than ATSUI APIs.
https://bugs.webkit.org/show_bug.cgi?id=31802

No test since this is already covered by existing pixel tests.

  • platform/graphics/SimpleFontData.h: Change #ifdef to define getNSFont() on Chrome/Mac .
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: Provide forward declarations

of Core Text functions that are public on 10.6 but SPI on 10.5.

05:15 Changeset [51632] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Put test into skiplist because of missing layoutTestController.evaluateInWebInspector().

  • platform/qt/Skipped:
  • inspector/settings-set-get.html added.
04:46 Changeset [51631] by pfeldman@chromium.org
  • 35 edits
    2 adds in trunk

2009-12-03 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

Reviewed by Timothy Hatcher.

Web Inspector: Simplify the settings support in inspector controller.

https://bugs.webkit.org/show_bug.cgi?id=32076

Test: inspector/settings-set-get.html

  • WebCore.Inspector.exp:
  • bindings/js/JSInspectorFrontendHostCustom.cpp:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::setting): (WebCore::InspectorController::setSetting): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::attachWindow): (WebCore::InspectorController::setAttachedWindowHeight): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::showWindow): (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking): (WebCore::InspectorController::ensureResourceTrackingSettingsLoaded): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setting): (WebCore::InspectorFrontendHost::setSetting):
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • loader/EmptyClients.h: (WebCore::EmptyInspectorClient::populateSetting): (WebCore::EmptyInspectorClient::storeSetting):

WebKit/chromium

  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::hiddenPanels): (WebKit::InspectorClientImpl::populateSetting): (WebKit::InspectorClientImpl::storeSetting): (WebKit::InspectorClientImpl::loadSettings): (WebKit::InspectorClientImpl::saveSettings):
  • src/InspectorClientImpl.h:

WebKit/cf

  • WebCoreSupport/WebInspectorClientCF.cpp: (WebInspectorClient::populateSetting): (WebInspectorClient::storeSetting):

WebKit/gtk

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::populateSetting): (WebKit::InspectorClient::storeSetting):
  • WebCoreSupport/InspectorClientGtk.h:

WebKit/haiku

  • WebCoreSupport/InspectorClientHaiku.cpp: (WebCore::InspectorClientHaiku::populateSetting): (WebCore::InspectorClientHaiku::storeSetting):
  • WebCoreSupport/InspectorClientHaiku.h:

WebKit/mac

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]):

WebKit/qt

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::populateSetting): (WebCore::InspectorClientQt::storeSetting): (WebCore::variantToSetting): (WebCore::settingToVariant):
  • WebCoreSupport/InspectorClientQt.h:

WebKit/win

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::attachWindow): (WebInspectorClient::detachWindow): (WebInspectorClient::showWindowWithoutNotifications):
  • WebCoreSupport/WebInspectorClient.h:

WebKit/wx

  • WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::populateSetting): (WebCore::InspectorClientWx::storeSetting):
  • WebKitSupport/InspectorClientWx.h:
04:31 Changeset [51630] by benm@google.com
  • 6 edits in trunk

[Android] notifyHistoryItemChanged() should pass a pointer to the HistoryItem that changed.
https://bugs.webkit.org/show_bug.cgi?id=31915

Reviewed by Brady Eidson.

WebCore:

No change in functionality so no new tests required.

  • history/HistoryItem.cpp:

(WebCore::defaultNotifyHistoryItemChanged): Update this function to pass the HistoryItem that is being changed.
(WebCore::HistoryItem::setAlternateTitle): Update call to notifyHistoryItemChanged to include the new parameter.
(WebCore::HistoryItem::setURLString): ditto.
(WebCore::HistoryItem::setOriginalURLString): ditto.
(WebCore::HistoryItem::setReferrer): ditto.
(WebCore::HistoryItem::setTitle): ditto.
(WebCore::HistoryItem::setTarget): ditto.
(WebCore::HistoryItem::setDocumentState): On Android, add a call to notifyHistoryItemChanged. See bug for a discussion of why this is needed.
(WebCore::HistoryItem::clearDocumentState): ditto.
(WebCore::HistoryItem::setIsTargetItem): ditto.
(WebCore::HistoryItem::addChildItem): ditto.
(WebCore::HistoryItem::setFormInfoFromRequest): ditto.

  • history/HistoryItem.h: Update signature of notifyHistoryItemChanged.

WebKit/mac:

  • History/WebHistoryItem.mm:

(WKNotifyHistoryItemChanged): Update WKNotifyHistoryItemChanged() to add the new HistoryItem parameter added in the WebCore portion of this patch.

  • History/WebHistoryItemInternal.h: ditto.
04:18 Changeset [51629] by benm@google.com
  • 25 edits in trunk

[Android] The FrameLoaderClient is unaware of BackForwardList changes.
https://bugs.webkit.org/show_bug.cgi?id=31914

Reviewed by Brady Eidson.

WebCore:

This change adds three new methods on the FrameLoaderClient interface to receive notifications when the BackForwardList changes.

No new tests required. Functionality on all platforms upstream remains the same. Android is the first platform to make use of these callbacks.

  • history/BackForwardList.cpp:

(WebCore::BackForwardList::addItem): Execute the callback.
(WebCore::BackForwardList::goBack): ditto.
(WebCore::BackForwardList::goForward): ditto.
(WebCore::BackForwardList::goToItem): ditto.
(WebCore::BackForwardList::setCapacity): dito.

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation for the callback that does nothing.
(WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::EmptyFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.

  • loader/FrameLoaderClient.h:

WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebKit::FrameLoaderClientImpl::dispatchDidRemoveBackForwardItem): ditto.
(WebKit::FrameLoaderClientImpl::dispatchDidChangeBackForwardIndex): dito.

  • src/FrameLoaderClientImpl.h:

WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebKit::FrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebKit::FrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.

  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/haiku:

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebCore::FrameLoaderClientHaiku::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::FrameLoaderClientHaiku::dispatchDidChangeBackForwardIndex): ditto.

  • WebCoreSupport/FrameLoaderClientHaiku.h:

WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.

WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebCore::FrameLoaderClientQt::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::FrameLoaderClientQt::dispatchDidChangeBackForwardIndex): ditto.

  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.

  • WebCoreSupport/WebFrameLoaderClient.h:

WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebCore::FrameLoaderClientWx::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::FrameLoaderClientWx::dispatchDidChangeBackForwardIndex): ditto.

  • WebKitSupport/FrameLoaderClientWx.h:
03:52 Changeset [51628] by benm@google.com
  • 2 edits
    3 adds in trunk/WebCore

[Android] Upstream WebCore/history/android: Require some platform specific state attached to HistoryItem.
https://bugs.webkit.org/show_bug.cgi?id=31913

Reviewed by Brady Eidson.

Android stores information such as the zoom scale factor and bridge back to the Java counterpart with HistoryItem.

No new tests required as this is Android specific code.

  • history/HistoryItem.h: Add Android specific member data to HistoryItem.
  • history/android: Added.
  • history/android/AndroidWebHistoryBridge.h: Added.
  • history/android/HistoryItemAndroid.cpp: Added, provides implementation for Android specific member functions in HistoryItem.

(WebCore::HistoryItem::bridge): Added.
(WebCore::HistoryItem::setBridge): Added.

01:22 Changeset [51627] by oliver@apple.com
  • 8 edits
    2 adds in trunk

NULL ptr in SVGPathSegList::getPathSegAtLength()
https://bugs.webkit.org/show_bug.cgi?id=30313

Reviewed by Maciej Stachowiak.

Add exception checks to SVGPathSegList's implementation to catch (and propagate) exceptions.
Add null checks to SVGList's content manipulation functions to prevent
null values from entering the list in the first place.

Test: svg/dom/svgpath-out-of-bounds-getPathSeg.html

12/02/09:

23:27 Changeset [51626] by eric@webkit.org
  • 4 edits
    2 adds
    8 deletes in trunk/LayoutTests

2009-12-02 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Rewrite two tests with dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=32014

  • fast/block/positioning/complex-percentage-height-expected.txt: Added.
  • fast/block/positioning/complex-percentage-height.html:
  • fast/lists/item-not-in-list-line-wrapping-expected.txt: Added.
  • fast/lists/item-not-in-list-line-wrapping.html:
  • platform/mac/fast/block/positioning/complex-percentage-height-expected.checksum: Removed.
  • platform/mac/fast/block/positioning/complex-percentage-height-expected.png: Removed.
  • platform/mac/fast/block/positioning/complex-percentage-height-expected.txt: Removed.
  • platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.checksum: Removed.
  • platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.png: Removed.
  • platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.txt: Removed.
  • platform/qt/Skipped:
  • platform/qt/fast/block/positioning/complex-percentage-height-expected.txt: Removed.
  • platform/qt/fast/lists/item-not-in-list-line-wrapping-expected.txt: Removed.
22:46 Changeset [51625] by oliver@apple.com
  • 1 edit
    2 adds in trunk/JavaScriptCore

Add files missed in prior patch.

Reviewed by Gavin Barraclough.

22:25 Changeset [51624] by oliver@apple.com
  • 9 edits in trunk/JavaScriptCore

Add zombies to JSC
https://bugs.webkit.org/show_bug.cgi?id=32103

Reviewed by Gavin Barraclough.

Add a compile time flag to make the JSC collector replace "unreachable"
objects with zombie objects. The zombie object is a JSCell subclass that
ASSERTs on any attempt to use the JSCell methods. In addition there are
a number of additional assertions in bottleneck code to catch zombie usage
as quickly as possible.

Grrr. Argh. Brains.

22:14 Changeset [51623] by eric@webkit.org
  • 9 edits
    2 adds in trunk

2009-12-02 Yusuke Sato <yusukes@chromium.org>

Reviewed by Eric Seidel.

Sanitize web fonts using the OTS library
https://bugs.webkit.org/show_bug.cgi?id=31106

Add support for OpenType sanitizer (OTS). It parses OpenType files (from @font-face)
and attempts to validate and sanitize them. We hope this reduces the attack surface
of the system font libraries.

  • WebCore.gyp/WebCore.gyp: Added dependency to (chromium_src_dir)/third_party/ots/ library.
  • WebCore.gypi: Added new files below.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/chromium/FontCustomPlatformData.cpp: Validate and transcode a web font. (WebCore::createFontCustomPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.cpp: Ditto. (WebCore::createFontCustomPlatformData):
  • platform/graphics/opentype/OpenTypeSanitizer.cpp: Added. (WebCore::OpenTypeSanitizer::sanitize):
  • platform/graphics/opentype/OpenTypeSanitizer.h: Added. (WebCore::OpenTypeSanitizer::OpenTypeSanitizer):

2009-12-02 Yusuke Sato <yusukes@chromium.org>

Reviewed by Eric Seidel.

Sanitize web fonts using the OTS library
https://bugs.webkit.org/show_bug.cgi?id=31106

  • DEPS: Added dependency to the OpenType sanitizer library.
  • features.gypi: Added ENABLE_OPENTYPE_SANITIZER=1.
21:31 Changeset [51622] by eric@webkit.org
  • 5 edits
    1 add in trunk/WebKitTools

2009-12-02 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(51595): commit-queue is throwing exceptions
https://bugs.webkit.org/show_bug.cgi?id=32083

  • Scripts/modules/commands/queues.py:
    • Don't use default value of [] as it ends up getting shared.
    • Make log_progress accept arrays of ints as well as strings.
    • Return an exit code from execute()
  • Scripts/modules/commands/queues_unittest.py: Added.
    • Test to make sure log_progress will accept ints.
    • Test to make sure run_bugzilla_tool will accept ints.
  • Scripts/modules/workqueue.py:
    • Print the stack trace on unexpected exceptions for easier debugging.
  • Scripts/run-webkit-unittests:
    • Add queues_unittest.
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
  • Scripts/modules/mock_bugzillatool.py:
  • Scripts/modules/workqueue.py:
  • Scripts/run-webkit-unittests:
21:20 Changeset [51621] by oliver@apple.com
  • 5 edits in trunk/WebCore

Web Inspector frontend heap allocates ScriptFunctionCall which is unsafe
https://bugs.webkit.org/show_bug.cgi?id=32098

Reviewed by Sam Weinig.

Fix is simply to make the ScriptFunctionCall stack allocated as nature intended
Doing this required adding an appendArgument(char*) to ScriptFunctionCall so
that an explicit String cast would not be necessary.

To prevent something like this happening again in future i've added private
operator new implementations to ScriptFunctionCall making this type of mistake
produce errors when compiling.

Test case: Inspector tests now pass with GC on every alloc enabled.

21:10 Changeset [51620] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Fix a mistake in the previous change

Reviewed by Mark Rowe.

  • WebView/WebView.mm:

(+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
Make sure to include the image types’ view and representation classes
even when plug-ins are not allowed.

21:08 Changeset [51619] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-02 David Levin <levin@chromium.org>

Reviewed by Adam Barth.

check-webkit-style is too noisy about namespace indenting issues.
https://bugs.webkit.org/show_bug.cgi?id=32096

  • Scripts/modules/cpp_style.py: Added a _FileState object to be able to track file level information. In this case, it simply tracks whether the error has already been given, so that it isn't done again.
  • Scripts/modules/cpp_style_unittest.py: Modified test cases to pass in the _FileState object and fix a test that expected to see the namespace error twice (now it only occurs once). No new tests because existing tests cover the change in functionality.
16:38 Changeset [51618] by kevino@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

Reviewed by Eric Seidel.

[wx] Get DumpRenderTree building after waf switch.

https://bugs.webkit.org/show_bug.cgi?id=32041

16:22 Changeset [51617] by mitz@apple.com
  • 8 edits in trunk/WebKit/mac

Fixed <rdar://problem/7254127> WebKit can load plug-ins even when
plug-ins are disabled

Reviewed by Anders Carlsson.

Ensure that the shared WebPluginDatabase is not instantiated if no
WebViews are used that have plug-ins enabled.

  • DefaultDelegates/WebDefaultPolicyDelegate.m:

(-[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
Call -[WebView _canShowMIMEType:] on the WebView instead of calling the
class method.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::canShowMIMEType): Ditto.
(WebFrameLoaderClient::transitionToCommittedForNewPage): Call
-[WebFrameView _viewClassForMIMEType:] on the WebView instead of calling
the class method.
(WebFrameLoaderClient::objectContentType): Ditto.

  • WebView/WebDataSource.mm:

(+[WebDataSource _representationClassForMIMEType:allowingPlugins:]):
Added the allowPlugins parameter, which is passed through to
+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:].
(-[WebDataSource _makeRepresentation]): Pass an allowPlugins value
based on the WebView’s preferences.

  • WebView/WebFrameView.mm:

(-[WebFrameView _makeDocumentViewForDataSource:]): Call
-[WebFrameView _viewClassForMIMEType:] instead of calling the class
method.
(+[WebFrameView _viewClassForMIMEType:allowingPlugins:]): Added the
allowPlugins parameter, which is passed through to
+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:].
(-[WebFrameView _viewClassForMIMEType:]): Added. Passes an allowPlugins
value based on the WebView’s preferences.

  • WebView/WebFrameViewInternal.h:
  • WebView/WebView.mm:

(+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
Added the allowPlugins parameter. If false, skip the instantiation of
the shared WebPluginDatabase.
(-[WebView _viewClass:andRepresentationClass:forMIMEType:]): Pass an
allowPlugins value based on the WebView’s preferences.
(+[WebView _canShowMIMEType:allowingPlugins:]): Passes allowPlugins to
+_viewClass:andRepresentationClass:forMIMEType:allowingPlugins:.
(+[WebView canShowMIMEType:]): Changed to pass YES to
+_canShowMIMEType:allowingPlugins:.
(-[WebView _canShowMIMEType:]): Added. Passes an allowPlugins value
based on the WebView’s preferences.
(-[WebView _pluginForMIMEType:]): Return nil if plug-ins are disabled.
(-[WebView _pluginForExtension:]): Ditto.
(-[WebView _isMIMETypeRegisteredAsPlugin:]): Return NO if plug-ins are
disabled.

  • WebView/WebViewInternal.h:
15:39 Changeset [51616] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Fixes a crash when scrolling a frame that goes away mid-scroll.

<rdar://problem/7400263>

Reviewed by John Sullivan.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView scrollWheel:]): Retain self incase the last
reference is released when calling super.

15:25 Changeset [51615] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=32089
Test that WebSocket.readyState is set correctly

  • websocket/tests/script-tests/simple.js: (ws.onopen): (ws.onmessage): (ws.onclose):
  • websocket/tests/simple-expected.txt: Added readyState logging.
15:21 Changeset [51614] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-12-02 Evan Stade <estade@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=32029
Mousewheel event delta has reversed sign on Linux Chrome.

No new tests (layout tests don't cover event conversion code).
Manual test: http://www.switchonthecode.com/tutorials/javascript-tutorial-the-scroll-wheel

  • src/gtk/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::mouseWheelEvent):
13:36 Changeset [51613] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Make change-values-during-transition less flaky. Transition is 1 sec duration,
translating 100px, starting at 0, so it should be at 50px at 500ms, not 600ms.

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=31997

  • transitions/change-values-during-transition.html:

isEqual: Remove unnecessary code - tolerance always passed in and always default value.
getXPosition: Extract into a function, since it is duplicated twice.
check2: Still run second check if the first fails, just give more debugging output.
start: Remove final setTimeout - nothing changes between the end of check2 and here,

so this is just making the test take 100ms longer.

13:24 Changeset [51612] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to fix the Safari build.

13:10 Changeset [51611] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

Skip http/tests/cache/subresource-failover-to-network.html because it
is flaky on Windows, fixing it is being tracked by
https://bugs.webkit.org/show_bug.cgi?id=32038.

  • platform/win/Skipped:
11:47 Changeset [51610] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Put tests into skiplist because of missing layoutTestController.evaluateInWebInspector().

  • platform/qt/Skipped:
  • inspector/elements-panel-selection-on-refresh.html added.
  • inspector/timeline-event-dispatch.html added.
11:34 Changeset [51609] by timothy@apple.com
  • 1 edit in trunk/WebKit/win/DOMHTMLClasses.h

Build fix.

11:27 Changeset [51608] by hyatt@apple.com
  • 7 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=32072, clean up invalid @-rule error handling so that we
pass more CSS test suite stuff. Make the grammar stop enforcing the ordering of @namespace vs.
@variables vs. @import. Just let the parser handle that instead. This simplifies the grammar and
makes error handling deal with more cases correctly.

Reviewed by Darin Adler.

Added fast/css/namespaces/namespaces-invalid-at-rules.xml

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::createCharsetRule):
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::addNamespace):
(WebCore::CSSParser::createVariablesRule):

  • css/CSSParser.h:
11:24 Changeset [51607] by timothy@apple.com
  • 2 edits in trunk/WebKit/win

Move setValueForUser to the end of the DOMHTMLInputElement interface
so it is fine for binary compatibility.

Directed by Steve Falkenburg.

  • Interfaces/DOMHTML.idl:
11:21 Changeset [51606] by timothy@apple.com
  • 3 edits in trunk/WebKit/win

Expose setValueForUser for the COM DOMHTMLInputElement.

<rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript

Reviewed by Dan Bernstein.

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::setValueForUser):

  • Interfaces/DOMHTML.idl:
11:17 Changeset [51605] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-02 Yusuke Sato <yusukes@chromium.org>

Reviewed by Dan Bernstein.

Safari/Chromium for Windows fails to load CJK WebFonts
https://bugs.webkit.org/show_bug.cgi?id=31804

  • platform/graphics/opentype/OpenTypeUtilities.cpp: (WebCore::renameAndActivateFont): Load a remote font even if the font has 2 or more faces.
11:10 Changeset [51604] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-12-02 Eric Z. Ayers <zundel@google.com>

Reviewed by Pavel Feldman.

Adds a timeline test for EventDispatch records.

https://bugs.webkit.org/show_bug.cgi?id=31376

  • inspector/timeline-event-dispatch-expected.txt: Added.
  • inspector/timeline-event-dispatch.html: Added.
11:03 Changeset [51603] by eric@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

2009-12-02 Avi Drissman <avi@chromium.org>

Reviewed by Darin Fisher.

Chromium: Need tickmarks in scrollbar
https://bugs.webkit.org/show_bug.cgi?id=32069

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/ScrollbarThemeChromiumMac.h: Added.
  • platform/chromium/ScrollbarThemeChromiumMac.mm: Added.
10:34 Changeset [51602] by timothy@apple.com
  • 10 edits in trunk

WebCore: Expose a function to set the value of an input element on behalf of the user.
This function will dispatch the change event so the page is notified when autofill
happens. Also dispatch a change event when a select element is changed by autofill.

<rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Added the DOMHTMLInputElementPrivate.h header.
  • bindings/objc/DOMHTML.mm:

(-[DOMHTMLSelectElement _activateItemAtIndex:]): Call setSelectedIndexByUser instead so
a change event is fired. This method is called by Safari autofill.

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode): Use dispatchFormControlChangeEvent instead
of dispatching the change event directly to be consistent.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLInputElement::setValueForUser): Added. Calls setValue with the sendChangeEvent
(WebCore::HTMLInputElement::setValue): Added the optional sendChangeEvent argument. Mimics setChecked.

  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl: Added setValueForUser for non-JS languages.
  • html/InputElement.h: Added setValueForUser.

WebKit/mac: Migrate DOMHTMLInputElementPrivate.h as a private header.

Reviewed by Darin Adler.

  • MigrateHeaders.make:
10:32 Changeset [51601] by pfeldman@chromium.org
  • 12 edits
    2 adds in trunk

2009-12-02 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

Reviewed by Timothy Hatcher.

Web Inspector: DOM tree selection disappears upon page refresh.

https://bugs.webkit.org/show_bug.cgi?id=31142

Test: inspector/elements-panel-selection-on-refresh.html

  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::pushNodeByPathToFrontend):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorBackend.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::close): (WebCore::InspectorController::releaseDOMAgent): (WebCore::InspectorController::resetScriptObjects):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::~InspectorDOMAgent): (WebCore::InspectorDOMAgent::reset): (WebCore::InspectorDOMAgent::setDocument): (WebCore::InspectorDOMAgent::pushDocumentToFrontend): (WebCore::InspectorDOMAgent::nodeForPath): (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMAgent.prototype._setDocument):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.setDocument.selectDefaultNode): (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode): (WebInspector.ElementsPanel.prototype.setDocument):
  • inspector/front-end/InjectedScript.js: (InjectedScript.pushNodeByPathToFrontend):
  • inspector/front-end/InjectedScriptAccess.js:
07:33 Changeset [51600] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=32045, make sure escape sequences work with
all the @-rules we support. When escape sequences are present, the lexical scanner
just returns a generic token name: ATKEYWORD. We have to process the escape sequences
and then recheck against the rules we support with the final processed name. If we
find a match, we mutate the token value to the appropriate rule name token, e.g.,
NAMESPACE_SYM.

Reviewed by Dan Bernstein.

Added fast/css/namespaces/namespaces-escapes.xml

  • css/CSSParser.cpp:

(WebCore::CSSParser::lex):
(WebCore::CSSParser::recheckAtKeyword):
(WebCore::CSSParser::text):

  • css/CSSParser.h:
06:52 Changeset [51599] by eric@webkit.org
  • 5 edits in trunk

2009-12-02 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.:w

Allow to skip thread checks when accessing DOMDataStore for processes
which run V8 in single thread mode.
https://bugs.webkit.org/show_bug.cgi?id=31877

Should be covered by buildbots.

  • bindings/v8/V8DOMMap.cpp: (WebCore::getDOMDataStore): (WebCore::enableFasterDOMStoreAccess): (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap):
  • bindings/v8/V8DOMMap.h:

2009-12-02 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Allow to skip thread checks when accessing DOMDataStore for processes
which run V8 in single thread mode.
https://bugs.webkit.org/show_bug.cgi?id=31877

  • src/WebScriptController.cpp: (WebKit::WebScriptController::enableV8SingleThreadMode):
05:12 Changeset [51598] by yurys@chromium.org
  • 15 edits
    4 deletes in trunk/WebCore

2009-12-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Code clean up: remove ScriptObjectQuarantine.* as a whole.

https://bugs.webkit.org/show_bug.cgi?id=32060

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/ScriptObjectQuarantine.cpp: Removed.
  • bindings/js/ScriptObjectQuarantine.h: Removed.
  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::quarantineValue):
  • bindings/js/ScriptValue.h:
  • bindings/v8/ScriptObjectQuarantine.cpp: Removed.
  • bindings/v8/ScriptObjectQuarantine.h: Removed.
  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::quarantineValue):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
  • inspector/InspectorController.cpp:
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
  • inspector/InspectorFrontend.cpp:
04:55 Changeset [51597] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] r51577 made fast/frames/sandboxed-iframe-plugins.html crash.

  • platform/qt/Skipped:
  • fast/frames/sandboxed-iframe-navigation-windowopen.html added. (crasher)
02:51 Changeset [51596] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] build-attachment shouldn't check whether the builders are red
https://bugs.webkit.org/show_bug.cgi?id=32062

build-attachment doesn't touch the remote repository, so there isn't a
need to hold off when the builders are red.

  • Scripts/modules/commands/download.py:
  • Scripts/modules/landingsequence.py:
02:44 Changeset [51595] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-02 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(51590): style-queue and build-queue think their empty when they are not
https://bugs.webkit.org/show_bug.cgi?id=32061

  • Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
  • Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
02:18 Changeset [51594] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed. Skip new tests.

  • platform/qt/Skipped:
  • svg/custom/mask-with-all-units.svg added.
  • fast/css/namespaces/namespaces-comments.xml added.
  • fast/css/namespaces/namespaces-empty.xml added.
01:59 Writing Layout Tests for DumpRenderTree edited by skylined@chromium.org
Document setCanOpenWindows (based on an example I found, not actual … (diff)
01:43 Changeset [51593] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-02 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

build-queue is throwing exceptions and complaining about
lack of --no-update on build-attachment. Make it stop.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
01:15 Changeset [51592] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-02 Adam Barth <abarth@webkit.org>

Unreviewed "build" fix. Forgot to declare my variables. :(

  • QueueStatusServer/queue_status.py:
01:11 Changeset [51591] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2009-12-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Implement status bubble view
https://bugs.webkit.org/show_bug.cgi?id=32057

The status bubble is a compact representation of the queue status for a
given patch. This will eventually help us reduce the comment spam from
the queues.

  • QueueStatusServer/index.html: Added HTML5 doctype for sanity.
  • QueueStatusServer/queue_status.py:
  • QueueStatusServer/status_bubble.html: Added.
01:04 Changeset [51590] by eric@webkit.org
  • 8 edits in trunk/WebKitTools

2009-12-02 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

trim commands/*.py includes now that commands are unit tested
https://bugs.webkit.org/show_bug.cgi?id=32056

In the course of ensuring that the unit tests still
passed after this change, I had to actually make them
pass in the first place.

  • Scripts/modules/bugzilla.py:
    • Fix _parse_attachment_ids_request_query to return ints instead of strings.
  • Scripts/modules/commands/download.py: Remove unneeded imports.
  • Scripts/modules/commands/queries.py: Ditto.
  • Scripts/modules/commands/queues.py: Ditto.
  • Scripts/modules/commands/upload.py: Ditto.
  • Scripts/modules/scm_unittest.py:
    • Fix to expect the \n after the path since echo adds an \n.
00:19 Changeset [51589] by ukai@chromium.org
  • 4 edits
    17 adds in trunk

2009-12-02 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket handshake check query component of URL
https://bugs.webkit.org/show_bug.cgi?id=31617

  • websocket/tests/echo-location_wsh.py: Added.
  • websocket/tests/no-query_wsh.py: Added.
  • websocket/tests/script-tests/url-with-credential.js: Added.
  • websocket/tests/script-tests/url-with-empty-query.js: Added.
  • websocket/tests/script-tests/url-with-fragment.js: Added.
  • websocket/tests/script-tests/url-with-query-for-no-query.js: Added.
  • websocket/tests/script-tests/url-with-query.js: Added.
  • websocket/tests/url-with-credential-expected.txt: Added.
  • websocket/tests/url-with-credential.html: Added.
  • websocket/tests/url-with-empty-query-expected.txt: Added.
  • websocket/tests/url-with-empty-query.html: Added.
  • websocket/tests/url-with-fragment-expected.txt: Added.
  • websocket/tests/url-with-fragment.html: Added.
  • websocket/tests/url-with-query-expected.txt: Added.
  • websocket/tests/url-with-query-for-no-query-expected.txt: Added.
  • websocket/tests/url-with-query-for-no-query.html: Added.
  • websocket/tests/url-with-query.html: Added.

2009-12-02 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket handshake check query component of URL
https://bugs.webkit.org/show_bug.cgi?id=31617

Tests: websocket/tests/url-with-credential.html

websocket/tests/url-with-empty-query.html
websocket/tests/url-with-fragment.html
websocket/tests/url-with-query-for-no-query.html
websocket/tests/url-with-query.html

  • platform/KURLGoogle.cpp: (WebCore::KURL::query): returns a null if query is not specified and returns an empty if query is specified but empty.
  • websockets/WebSocketHandshake.cpp: (WebCore::resourceName): added. add query component to path if specified. (WebCore::WebSocketHandshake::clientLocation): (WebCore::WebSocketHandshake::clientHandshakeMessage):

12/01/09:

22:26 Changeset [51588] by levin@chromium.org
  • 2 edits in trunk/WebCore

Incorrect code in WebGLRenderingContext.cpp
https://bugs.webkit.org/show_bug.cgi?id=32046

Reviewed by Eric Seidel.

Fix incorrect code that happened to work. != has higher precendence than &.
The simplest fix is to remove the "!= 0" which violates WebKit style
guidelines anyway.

Also added periods to few comments in the same function.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateIndexArray):

21:51 Changeset [51587] by eric@webkit.org
  • 4 edits in trunk/WebKitSite

2009-12-01 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Darin Adler.

Added clarifications to the web site regarding coding style and
code cleanup--

https://bugs.webkit.org/show_bug.cgi?id=31618

Changes include the following:

  • Expanded the style guidelines regarding "using" statements.
  • Made the style guidelines page validate as HTML.
  • Added that legacy WebKit components should not be cleaned up.
  • Added that it is more acceptable to update style when already touching code.
  • coding/coding-style.html:
  • coding/contributing.html:
  • projects/cleanup/index.html:
21:50 Changeset [51586] by hamaji@chromium.org
  • 5 edits in trunk/LayoutTests

2009-12-01 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Update expectations of css2.1/t1205-c56* for Qt
https://bugs.webkit.org/show_bug.cgi?id=32015

  • platform/qt/Skipped:
  • platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
21:44 Changeset [51585] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-01 Yaar Schnitman <yaar@chromium.org>

build-webkit: Remove flex,bison,gperf check for chromium
https://bugs.webkit.org/show_bug.cgi?id=32043

  • Scripts/webkitdirs.pm:
21:17 Changeset [51584] by eric@webkit.org
  • 7 edits
    3 adds in trunk

2009-12-01 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change [Reflect] to [ConvertNullToNullString, Reflect] for min, max,
pattern and step attributes of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=31708

  • fast/forms/input-minmax-expected.txt:
  • fast/forms/input-pattern-expected.txt: Added.
  • fast/forms/input-pattern.html: Added.
  • fast/forms/input-step-expected.txt:
  • fast/forms/script-tests/input-minmax.js: Add tests for null/undefined/non-string.
  • fast/forms/script-tests/input-pattern.js: Added.
  • fast/forms/script-tests/input-step.js: Change the result for null.

2009-12-01 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change [Reflect] to [ConvertNullToNullString, Reflect] for min, max,
pattern and step attributes of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=31708

  • html/HTMLInputElement.idl:
20:54 Changeset [51583] by cfleizach@apple.com
  • 3 edits in trunk/WebKitTools

Build fixage for Windows/GTK for DumpRenderTree.

WAI-ARIA: implement support for ARIA drag and drop
https://bugs.webkit.org/show_bug.cgi?id=32007

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):

20:40 Changeset [51582] by cfleizach@apple.com
  • 11 edits
    2 adds in trunk

WAI-ARIA: implement support for ARIA drag and drop
https://bugs.webkit.org/show_bug.cgi?id=32007

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/aria-drag-drop.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::supportsARIADropping):
(WebCore::AccessibilityObject::supportsARIADragging):
(WebCore::AccessibilityObject::isARIAGrabbed):
(WebCore::AccessibilityObject::setARIAGrabbed):
(WebCore::AccessibilityObject::determineARIADropEffects):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::supportsARIADropping):
(WebCore::AccessibilityRenderObject::supportsARIADragging):
(WebCore::AccessibilityRenderObject::isARIAGrabbed):
(WebCore::AccessibilityRenderObject::setARIAGrabbed):
(WebCore::AccessibilityRenderObject::determineARIADropEffects):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

  • html/HTMLAttributeNames.in:

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(getARIADropEffectsCallback):
(getARIAIsGrabbedCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):

LayoutTests:

  • platform/mac/accessibility/aria-drag-drop-expected.txt: Added.
  • platform/mac/accessibility/aria-drag-drop.html: Added.
19:49 Changeset [51581] by abarth@webkit.org
  • 1 edit in trunk/WebCore/bindings/v8/ScriptController.cpp

Typo fix.

19:44 Changeset [51580] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-12-01 Adam Barth <abarth@webkit.org>

https://bugs.webkit.org/show_bug.cgi?id=21288

Unreviewed port of @sandbox to V8.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::isEnabled):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::createWindow):
19:28 Changeset [51579] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=21288

Reviewed by Darin Adler.

Add sneaky test that has tabs.

  • fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Added.
  • fast/frames/sandboxed-iframe-attribute-parsing.html: Added.
19:02 Changeset [51578] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/loader/FrameLoaderTypes.h

Change unsigned to int to fix the Windows build.

18:40 Changeset [51577] by abarth@webkit.org
  • 23 edits
    55 adds in trunk

2009-12-01 Patrik Persson <patrik.j.persson@ericsson.com>

Reviewed by Darin Adler.

Implement HTML5 sandbox attribute for iframes.
http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
https://bugs.webkit.org/show_bug.cgi?id=21288

  • fast/frames/resources/non-sandboxed-iframe-navigation.html: Added.
  • fast/frames/resources/sandboxed-iframe-attribute-parsing-allowed.html: Added.
  • fast/frames/resources/sandboxed-iframe-attribute-parsing-disallowed.html: Added.
  • fast/frames/resources/sandboxed-iframe-form-allowed.html: Added.
  • fast/frames/resources/sandboxed-iframe-form-disallowed.html: Added.
  • fast/frames/resources/sandboxed-iframe-navigated.html: Added.
  • fast/frames/resources/sandboxed-iframe-navigation-child.html: Added.
  • fast/frames/resources/sandboxed-iframe-navigation-navigated.html: Added.
  • fast/frames/resources/sandboxed-iframe-navigation-parent.html: Added.
  • fast/frames/resources/sandboxed-iframe-navigation-source.html: Added.
  • fast/frames/resources/sandboxed-iframe-navigation-targetlink.html: Added.
  • fast/frames/resources/sandboxed-iframe-navigation-windowopen.html: Added.
  • fast/frames/resources/sandboxed-iframe-plugins-frame-applet.html: Added.
  • fast/frames/resources/sandboxed-iframe-plugins-frame-embed.html: Added.
  • fast/frames/resources/sandboxed-iframe-plugins-frame-object.html: Added.
  • fast/frames/resources/sandboxed-iframe-script-dynamic.html: Added.
  • fast/frames/resources/sandboxed-iframe-storage-allowed.html: Added.
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html: Added.
  • fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Added.
  • fast/frames/sandboxed-iframe-attribute-parsing.html: Added.
  • fast/frames/sandboxed-iframe-forms-expected.txt: Added.
  • fast/frames/sandboxed-iframe-forms.html: Added.
  • fast/frames/sandboxed-iframe-navigation-allowed-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-allowed.html: Added.
  • fast/frames/sandboxed-iframe-navigation-parent-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-parent.html: Added.
  • fast/frames/sandboxed-iframe-navigation-targetlink-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-targetlink.html: Added.
  • fast/frames/sandboxed-iframe-navigation-windowopen-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-windowopen.html: Added.
  • fast/frames/sandboxed-iframe-plugins-expected.txt: Added.
  • fast/frames/sandboxed-iframe-plugins.html: Added.
  • fast/frames/sandboxed-iframe-scripting-expected.txt: Added.
  • fast/frames/sandboxed-iframe-scripting.html: Added.
  • fast/frames/sandboxed-iframe-storage-expected.txt: Added.
  • fast/frames/sandboxed-iframe-storage.html: Added.
  • http/tests/security/resources/sandboxed-iframe-document-cookie-read-denied.html: Added.
  • http/tests/security/resources/sandboxed-iframe-modify-self.html: Added.
  • http/tests/security/resources/xss-DENIED-sandboxed-iframe-attacker.html: Added.
  • http/tests/security/sandboxed-iframe-document-cookie-expected.txt: Added.
  • http/tests/security/sandboxed-iframe-document-cookie.html: Added.
  • http/tests/security/sandboxed-iframe-modify-self-expected.txt: Added.
  • http/tests/security/sandboxed-iframe-modify-self.html: Added.
  • http/tests/security/xss-DENIED-sandboxed-iframe-expected.txt: Added.
  • http/tests/security/xss-DENIED-sandboxed-iframe.html: Added.
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html: Added.
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html: Added.
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-iframe.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow.cgi: Added.
  • http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-iframe.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-without-wildcard-iframe.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-without-wildcard.cgi: Added.
  • http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied.cgi: Added.

2009-12-01 Patrik Persson <patrik.j.persson@ericsson.com>

Reviewed by Darin Adler.

Implement HTML5 sandbox attribute for iframes.
http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
https://bugs.webkit.org/show_bug.cgi?id=21288

Tests: fast/frames/sandboxed-iframe-attribute-parsing.html

fast/frames/sandboxed-iframe-forms.html
fast/frames/sandboxed-iframe-navigation-allowed.html
fast/frames/sandboxed-iframe-navigation-parent.html
fast/frames/sandboxed-iframe-navigation-targetlink.html
fast/frames/sandboxed-iframe-navigation-windowopen.html
fast/frames/sandboxed-iframe-plugins.html
fast/frames/sandboxed-iframe-scripting.html
fast/frames/sandboxed-iframe-storage.html
http/tests/security/sandboxed-iframe-document-cookie.html
http/tests/security/sandboxed-iframe-modify-self.html
http/tests/security/xss-DENIED-sandboxed-iframe.html
http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html
http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html
http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html

  • bindings/js/JSDOMWindowCustom.cpp: sandboxing navigation (WebCore::createWindow):
  • bindings/js/ScriptController.cpp: sandboxing scripts (WebCore::ScriptController::isEnabled):
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::cookie): raise exception when accessed from sandbox (WebCore::Document::setCookie): raise exception when accessed from sandbox (WebCore::Document::initSecurityContext): updae sandbox status (WebCore::Document::updateSandboxFlags):
  • dom/Document.h:
  • dom/Document.idl:
  • html/HTMLAppletElement.cpp: sandboxing applets (WebCore::HTMLAppletElement::createRenderer): (WebCore::HTMLAppletElement::renderWidgetForJSBindings): (WebCore::HTMLAppletElement::canEmbedJava):
  • html/HTMLAppletElement.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLFrameOwnerElement.cpp: management of sandbox flags as stated in attribute (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): (WebCore::HTMLFrameOwnerElement::setSandboxFlags):
  • html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::sandboxFlags):
  • html/HTMLIFrameElement.cpp: sandbox attribute parsing (WebCore::parseSandboxAttribute): (WebCore::HTMLIFrameElement::parseMappedAttribute):
  • html/HTMLIFrameElement.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies):
  • loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::submitForm): sandboxing forms (WebCore::FrameLoader::requestObject): sandboxing plugins (WebCore::FrameLoader::shouldAllowNavigation): sandboxing navigation (WebCore::FrameLoader::updateSandboxFlags): propagation of sandbox flags
  • loader/FrameLoader.h: (WebCore::FrameLoader::ownerElementSandboxFlagsChanged): (WebCore::FrameLoader::isSandboxed): (WebCore::FrameLoader::sandboxFlags):
  • loader/FrameLoaderTypes.h: (WebCore::):
  • page/DOMWindow.cpp: disable storage and databases in sandboxed frames (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage): (WebCore::DOMWindow::openDatabase):
  • page/SecurityOrigin.cpp: added sandboxing status (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::toString):
  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::setSandboxFlags): (WebCore::SecurityOrigin::isSandboxed): (WebCore::SecurityOrigin::canAccessDatabase): (WebCore::SecurityOrigin::canAccessStorage):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):
18:04 Changeset [51576] by cfleizach@apple.com
  • 7 edits
    2 adds in trunk

ARIA: support a way to create a static text object
https://bugs.webkit.org/show_bug.cgi?id=32030

Reviewed by David Kilzer.

WebCore:

Test: accessibility/aria-text-role.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::isDescendantOfBarrenParent):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::text):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • accessibility/aria-text-role-expected.txt: Added.
  • accessibility/aria-text-role.html: Added.
  • platform/gtk/Skipped:
  • platform/win/Skipped:
17:56 Changeset [51575] by zimmermann@webkit.org
  • 2 edits in trunk/WebKitTools

Not reviewed. GTK DRT try 2.

17:51 Changeset [51574] by zimmermann@webkit.org
  • 2 edits in trunk/WebKitTools

Not reviewed. Try to fix gtk DRT build.

17:48 Changeset [51573] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to rebuild Interfaces and fix the Windows build.

17:41 Changeset [51572] by oliver@apple.com
  • 3 edits in trunk/WebCore

Inspector crashes when collecting on every allocation
https://bugs.webkit.org/show_bug.cgi?id=32044

Reviewed by Maciej Stachowiak.

The crash is caused by the prototype wrapper object getting collected
when allocating the object that is going to use it as a prototype.
Because the only reference to the prototype wrapper is through the
new object's Structure it does not get marked automatically.

17:40 Changeset [51571] by bweinstein@apple.com
  • 2 edits in trunk

Build fix by using DOMNode::node() to go from a DOMNode to a node, and
added svg/animation in the WebCore.vcproj list of headers to be copied
over on build.

17:26 Changeset [51570] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
https://bugs.webkit.org/show_bug.cgi?id=32033

Reviewed by Eric Seidel.

  • Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find

instead of startswith.

  • Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
17:03 Changeset [51569] by zimmermann@webkit.org
  • 2 edits in trunk/WebKitTools

Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.

16:53 Changeset [51568] by zimmermann@webkit.org
  • 4 edits in trunk/WebKit

Not reviewed. Try to fix qt/win builds.

16:41 Changeset [51567] by zimmermann@webkit.org
  • 29 edits
    8 adds in trunk

2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Simon Fraser.

Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897

Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.

Implemented just like the existing pauseAnimation* methods for CSS animations.

  • Api/qwebframe.cpp: (qt_drt_pauseSVGAnimation):

2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Simon Fraser.

Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897

Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.

Implemented just like the existing pauseAnimation* methods for CSS animations.

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_pause_svg_animation):

2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Simon Fraser.

Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897

Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.

Implemented just like the existing pauseAnimation* methods for CSS animations.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp: (WebFrame::pauseSVGAnimation):
  • WebFrame.h:

2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Simon Fraser.

Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897

Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.

Implemented just like the existing pauseAnimation* methods for CSS animations.

  • WebView/WebFrame.mm: (-[WebFrame _pauseSVGAnimation:onSMILNode:atTime:]):
  • WebView/WebFramePrivate.h:

2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Simon Fraser.

Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897

Add 'sampleSVGAnimationForElementAtTime' method to the LayoutTestController,
for the use within the new SVG animation test framework (LayoutTests/svg/animations/)

layoutTestController.sampleAnimationAtTime(<svg animation id>, <absolute time>, <svg element id>);
to sample a svg animateMotion/animateColor/animate/set element at certain times.

After the desired SVG animation starts and calling the method above, it's immediately forwarded to
the desired sampling time. After JS returns from the 'sampleSVGAnimationForElementAtTime' method
a callback is fired used to sample the animation value at the target time. It's modelled similar
to the CSS animation/transition testing framework, inspired by
LayoutTests/animations/animation-test-helpers.js.

Though it has been extended to integrate within the fast/js/js-test-* framework, that's used for
the SVG dynamic-updates tests, to simplify test creation, by utilizing script-tests/* only.

Adding a simple testcase testing the DRT methods, it will soon be extended to test animVal/baseVal
interaction, while animating.

Test: svg/animations/animVal-basics.html

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::sampleAnimationAtTime):
  • svg/SVGDocumentExtensions.h:
  • svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::SMILTimeContainer): (WebCore::SMILTimeContainer::sampleAnimationAtTime): (WebCore::SMILTimeContainer::updateAnimations):
  • svg/animation/SMILTimeContainer.h:

2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Simon Fraser.

Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897

Add LayoutTests/svg/animations directory, containing a new
framework for SVG animation test with sampling at certain times.

Added one example test, which will be extended soon to cover animVal
support, once basic support has been implemented.

  • svg/animations: Added.
  • svg/animations/animVal-basics-expected.txt: Added.
  • svg/animations/animVal-basics.html: Added.
  • svg/animations/resources: Added.
  • svg/animations/resources/SVGAnimationTestCase.js: Added. (isCloseEnough): (moveAnimationTimelineAndSample): (startTest): (sampleAnimation): (runAnimationTest):
  • svg/animations/script-tests: Added.
  • svg/animations/script-tests/TEMPLATE.html: Added.
  • svg/animations/script-tests/animVal-basics.js: Added. (sample1): (sample2): (sample3): (executeTest):

2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Simon Fraser.

Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897

Add new 'sampleSVGAnimationForElementAtTime' DRT method,
used by the new SVG animation testing framework, implemented
for qt/gtk/win/mac.

  • DumpRenderTree/LayoutTestController.cpp: (sampleSVGAnimationForElementAtTimeCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::sampleSVGAnimationForElementAtTime):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
16:05 Changeset [51566] by snej@chromium.org
  • 14 edits in trunk

JavaScriptCore: Added variants of find/contains/add that allow a foreign key type to be used.
This will allow AtomicString-keyed maps to be queried by C string without
having to create a temporary AtomicString (see HTTPHeaderMap.)
The code for this is adapted from the equivalent in HashSet.h.

WebCore: Add convenience methods to Element and QualifiedName that take
char* instead of AtomicString, in preparation for removing the
implicit conversion between the two types (30187).
https://bugs.webkit.org/show_bug.cgi?id=31749

Reviewed by Darin Adler.

15:59 Changeset [51565] by ap@apple.com
  • 2 edits in trunk/WebCore

More Windows build fix.

  • platform/network/cf/CredentialStorageCFNet.cpp: (WebCore::CredentialStorage::getFromPersistentStorage):
15:52 Changeset [51564] by ap@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • platform/network/cf/CredentialStorageCFNet.cpp: Include RetainPtr.h.
15:40 Changeset [51563] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip more tests that fail with specific versions of CFNetwork on Windows

Rubber-stamped in advance by Brady Eidson.

  • platform/win/Skipped:
15:36 Changeset [51562] by weinig@apple.com
  • 4 edits in trunk/WebKit/mac

Simplify [WebView userAgentForURL:]. No need to call into helper function.

Reviewed by Mark Rowe.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::userAgent):

  • WebView/WebView.mm:

(-[WebView userAgentForURL:]):

  • WebView/WebViewInternal.h:
15:35 Changeset [51561] by ap@apple.com
  • 6 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32036
Implement CredentialStorage::getFromPersistentStorage for CFNetwork

15:34 Changeset [51560] by pkasting@chromium.org
  • 4 edits in trunk/WebKit/chromium

[Chromium] Simplify zoom-related APIs and add a zoom level getter,
part one: Add new APIs. (Old APIs will be removed in a second pass.)
https://bugs.webkit.org/show_bug.cgi?id=31893

Reviewed by Darin Fisher.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):

  • src/WebViewImpl.h:
14:12 Changeset [51559] by eric@webkit.org
  • 6 edits in trunk

2009-12-01 Daniel Bates <dbates@webkit.org>

Reviewed by Pavel Feldman.

https://bugs.webkit.org/show_bug.cgi?id=32001

Updated layout test to reflect change to localized string and
rebased the result.

  • inspector/elements-img-tooltip-expected.txt:
  • inspector/elements-img-tooltip.html:

2009-12-01 Daniel Bates <dbates@webkit.org>

Reviewed by Pavel Feldman.

https://bugs.webkit.org/show_bug.cgi?id=32001

Added missing localized strings (that I left out of the patch for bug #21554):
%d × %d pixels
%d × %d pixels (Natural: %d × %d pixels)

Also, changed formatting of these stings to conform with existing ones (added
a space on both sides of the multiply sign).

  • English.lproj/localizedStrings.js: Added stings.
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
14:05 Changeset [51558] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-01 Daniel Bates <dbates@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=31898

Makes QtLauncher default to the http scheme for URLs.

  • QtLauncher/main.cpp: (MainWindow::MainWindow): (MainWindow::changeLocation): (main):
13:33 Changeset [51557] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip a test that fails with some versions of CFNetwork on Windows

Rubber-stamped by Brady Eidson.

  • platform/win/Skipped: Skip http/tests/plugins/post-url-file.html.
13:32 Changeset [51556] by hyatt@apple.com
  • 2 edits
    4 adds in trunk

Fix for bug 32032, empty namespaces should be allowed in @namespace directives in CSS.

Reviewed by Simon Fraser.

Added fast/css/namespaces/namespaces-empty.xml

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::addNamespace):
(WebCore::CSSStyleSheet::determineNamespace):

13:17 Changeset [51555] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

Revert 51551 because it broke GTK+.

12:59 Changeset [51554] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Remove user content before running each test on Windows

Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting): Remove all user content
before each test, which matches Mac.

12:08 Changeset [51553] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2009-12-01 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Escape key in the Search Field should be more User Friendly
https://bugs.webkit.org/show_bug.cgi?id=32005

  • inspector/front-end/inspector.js: (WebInspector.loaded): add mousedown listener on the search field (WebInspector.searchFieldManualFocus): user clicked to focus on the search field (WebInspector.searchKeyDown): handle escape
11:08 Changeset [51552] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Enabling WebSocket tests on Windows again - let's see what errors get logged.

  • platform/win/Skipped:
11:01 Changeset [51551] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-12-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

PLATFORM(CAIRO) should be defined by WIN_CAIRO define
https://bugs.webkit.org/show_bug.cgi?id=22250

  • wtf/Platform.h: Remove WTF_PLATFORM_CAIRO as it is already define in config.h
10:56 Changeset [51550] by ap@apple.com
  • 2 edits in trunk/WebKitTools

2009-12-01 Yuzo Fujishima <yuzo@google.com>

Reviewed by Alexey Proskuryakov.

Make pywebsocket log errors to a file
https://bugs.webkit.org/show_bug.cgi?id=31604

  • Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory (by passing the path to the server via a recently added -l option).
10:55 Changeset [51549] by hyatt@apple.com
  • 2 edits
    4 adds in trunk

@namespace directives need to use "maybe_space" in the "maybe_ns_prefix" portion of the grammar to match
the spec. Not doing so prevent comments from being used immmediately after the namespace prefix.

Reviewed by David Kilzer.

Added fast/css/namespaces-comments.xml

  • css/CSSGrammar.y:
10:41 Changeset [51548] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-12-01 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Darin Fisher.

Only fire start/stop events when main frame is not loading.

https://bugs.webkit.org/show_bug.cgi?id=31838

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage):
10:38 Changeset [51547] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Add a timing-out test to the Skipped file on Windows

Rubber-stamped by Ada Chan.

  • platform/win/Skipped: Added

fast/dom/Window/window-postmessage-clone.html, which was timing out
due to eventSender.beginDragFiles being unimplemented.

10:35 Changeset [51546] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Fix tests that use the TestNetscapePlugin in Debug_Internal builds

Reviewed by Ada Chan.

Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
TestNetscapePlugin fail in Debug_Internal builds

  • DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin

directory in Debug and Debug_All builds, but not in Debug_Internal
builds.

10:01 Changeset [51545] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Re-enable DRT's watchdog timer on Windows

It was accidentally disabled in r50907.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
into an if condition.

09:24 Changeset [51544] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-01 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Timothy Hatcher.

Reloading WebInspector from context menu is closing it instead of reloading.
https://bugs.webkit.org/show_bug.cgi?id=32004

When reloading WebInspector, don't delete its m_page.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::close):
09:20 Changeset [51543] by aroben@apple.com
  • 2 edits
    7 adds in trunk/LayoutTests

Add expected Windows failure results for tests that use textInputController

<http://webkit.org/b/32021> covers fixing these tests.

Rubber-stamped by Sam Weinig.

  • platform/win/Skipped: Removed tests that use textInputController.
  • platform/win/editing/selection/5825350-1-expected.txt: Added.
  • platform/win/editing/selection/5825350-2-expected.txt: Added.
  • platform/win/editing/selection/mixed-editability-10-expected.txt: Added.
  • platform/win/fast/events/ime-composition-events-001-expected.txt: Added.
  • platform/win/fast/forms/input-maxlength-ime-completed-expected.txt: Added.
  • platform/win/fast/forms/input-maxlength-ime-preedit-expected.txt: Added.
  • platform/win/fast/text/international/thai-cursor-position-expected.txt: Added.
08:51 Changeset [51542] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Put test into skiplist because of missing layoutTestController.evaluateInWebInspector().

  • platform/qt/Skipped: inspector/timeline-network-resource.html added.
08:46 Changeset [51541] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

check-webkit-style complains about #imports with / in them
https://bugs.webkit.org/show_bug.cgi?id=32022

We need to exclude #import directives in addition to #include from the
binary operator whitespace checks.

  • Scripts/modules/cpp_style.py:
  • Scripts/modules/cpp_style_unittest.py:
08:46 Changeset [51540] by eric@webkit.org
  • 8 edits
    6 adds in trunk/WebCore

2009-12-01 Steve Block <steveblock@google.com>

Reviewed by Dimitri Glazkov.

Adds V8 bindings for Geolocation.
https://bugs.webkit.org/show_bug.cgi?id=30206

Also adds Geolocation files to Chrome build files.

  • WebCore.gyp/WebCore.gyp: Modified. Corrects list of Geolocation IDL files.
  • WebCore.gypi: Modified. Adds Geolocation files.
  • bindings/v8/DOMObjectsInclude.h: Modified. Adds Geolocation includes.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Modified. Adds Geolocation files.
  • bindings/v8/V8Index.cpp: Modified. Includes Geolocation generated headers.
  • bindings/v8/V8Index.h: Modified. Adds Geolocation types to DOM_OBJECT_TYPES.
  • bindings/v8/custom/V8CoordinatesCustom.cpp: Added. Handles optional properties.
  • bindings/v8/custom/V8CustomBinding.h: Modified. Declares callbacks and getters.
  • bindings/v8/custom/V8CustomPositionCallback.cpp: Added. (WebCore::V8CustomPositionCallback::V8CustomPositionCallback): Added. Constructor. (WebCore::V8CustomPositionCallback::~V8CustomPositionCallback): Added. Destructor. (WebCore::V8CustomPositionCallback::handleEvent): Added. Invokes callback.
  • bindings/v8/custom/V8CustomPositionCallback.h: Added. (WebCore::V8CustomPositionCallback::create): Added. Factory method.
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp: Added. (WebCore::V8CustomPositionErrorCallback::V8CustomPositionErrorCallback): Added. Constructor. (WebCore::V8CustomPositionErrorCallback::~V8CustomPositionErrorCallback): Added. Destructor. (WebCore::V8CustomPositionErrorCallback::handleEvent): Added. Invokes callback.
  • bindings/v8/custom/V8CustomPositionErrorCallback.h: Added. (WebCore::V8CustomPositionErrorCallback::create): Added. Factory method.
  • bindings/v8/custom/V8GeolocationCustom.cpp: Added. (WebCore::throwTypeMismatchException): Added. Throws a type mismatch error. (WebCore::createPositionCallback): Added. Handles type checking for successCallback argument. (WebCore::createPositionErrorCallback): Added. Handles type checking for errorCallback argument. (WebCore::createPositionOptions): Added. Handles type checking for positionOptions argument.
08:19 Changeset [51539] by eric@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2009-12-01 Eric Z. Ayers <zundel@google.com>

Reviewed by Pavel Feldman.

Adds test for Timeline network resource records.

https://bugs.webkit.org/show_bug.cgi?id=31378

  • inspector/timeline-network-resource-expected.txt: Added.
  • inspector/timeline-network-resource.html: Added.
  • inspector/timeline-network-resource.js: Added.
  • inspector/timeline-test.js: (printTimelineRecords):
08:17 Changeset [51538] by yurys@chromium.org
  • 4 edits in trunk/WebCore

2009-12-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Provide a way to get ScriptState for the inspected page.

https://bugs.webkit.org/show_bug.cgi?id=32020

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptState.cpp: (WebCore::scriptStateFromPage):
08:09 Changeset [51537] by cmarrin@apple.com
  • 5 edits in trunk

Changed mallocs to fastMallocs and frees to fastFrees in GraphicsContext3D. Also added error returns
https://bugs.webkit.org/show_bug.cgi?id=30778

07:45 Changeset [51536] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-01 Mads Ager <ager@chromium.org>

Reviewed by Eric Seidel.

[V8] Don't crash in DOMWindow event getter in OOM situations
https://bugs.webkit.org/show_bug.cgi?id=32017

Add missing null handle checks in DOMWindow event property
accessors. V8Proxy::context(frame) can return a null handle in
OOM situations either if failing to initialize a context or if an
OOM is handled gracefully and javascript is disabled.

No new tests because we don't have a good way to test
out-of-memory bugs.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
06:44 Changeset [51535] by cmarrin@apple.com
  • 6 edits in trunk

Updated HTMLCanvasElement to accept "experimental-webgl" as the context name.
https://bugs.webkit.org/show_bug.cgi?id=31672

06:22 Changeset [51534] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-12-01 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

Not reviewed: chromium build fix, added missing import.

  • inspector/InspectorFrontendHost.cpp:
03:26 Changeset [51533] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Put tests into skiplist because of missing textInputController.selectedRange().

  • platform/qt/Skipped:
  • editing/selection/mixed-editability-10.html added.
  • editing/selection/5825350-1.html added.
  • editing/selection/5825350-2.html added.
01:45 Changeset [51532] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-12-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fix windows build via unexcluding generated files from
project.

  • WebCore.vcproj/WebCore.vcproj:
01:33 Changeset [51531] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Stop copying IDL files in to the WebCore framework wrapper.

  • WebCore.xcodeproj/project.pbxproj:
01:28 Changeset [51530] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the Tiger build by making the Xcode project compatible with Xcode 2.4.

This was probably broken by hand-editing the project file as Xcode itself
knows how to keep project files to a backwards-compatible subset of its format.

  • WebCore.xcodeproj/project.pbxproj:
00:45 Changeset [51529] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-12-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: windows build fix (bad vcproj in r51528).

  • WebCore.vcproj/WebCore.vcproj:
00:07 Changeset [51528] by pfeldman@chromium.org
  • 49 edits
    5 copies
    7 adds
    2 deletes in trunk/WebCore

2009-11-27 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

Reviewed by Timothy Hatcher.

Web Inspector: Split InspectorBackend into three parts: backend,
injected script host and frontend host.


https://bugs.webkit.org/show_bug.cgi?id=31888

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSInspectorBackendCustom.cpp: Removed.
  • bindings/js/JSInspectorFrontendHostCustom.cpp: Added. (WebCore::JSInspectorFrontendHost::search): (WebCore::JSInspectorFrontendHost::setting): (WebCore::JSInspectorFrontendHost::setSetting):
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/js/ScriptObject.h:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/v8/ScriptObject.h:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: Removed.
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • inspector/InjectedScriptHost.cpp: Added. (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::~InjectedScriptHost): (WebCore::InjectedScriptHost::copyText): (WebCore::InjectedScriptHost::nodeForId): (WebCore::InjectedScriptHost::wrapObject): (WebCore::InjectedScriptHost::unwrapObject): (WebCore::InjectedScriptHost::pushNodePathToFrontend): (WebCore::InjectedScriptHost::addNodesToSearchResult): (WebCore::InjectedScriptHost::currentCallFrame): (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript): (WebCore::InjectedScriptHost::inspectorDOMAgent): (WebCore::InjectedScriptHost::inspectorFrontend):
  • inspector/InjectedScriptHost.h: Added. (WebCore::InjectedScriptHost::create): (WebCore::InjectedScriptHost::inspectorController): (WebCore::InjectedScriptHost::disconnectController):
  • inspector/InjectedScriptHost.idl: Added.
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::InspectorBackend): (WebCore::InspectorBackend::storeLastActivePanel): (WebCore::InspectorBackend::toggleNodeSearch): (WebCore::InspectorBackend::resourceTrackingEnabled): (WebCore::InspectorBackend::debuggerEnabled): (WebCore::InspectorBackend::enableDebugger): (WebCore::InspectorBackend::disableDebugger): (WebCore::InspectorBackend::addBreakpoint): (WebCore::InspectorBackend::updateBreakpoint): (WebCore::InspectorBackend::removeBreakpoint): (WebCore::InspectorBackend::pauseInDebugger): (WebCore::InspectorBackend::resumeDebugger): (WebCore::InspectorBackend::stepOverStatementInDebugger): (WebCore::InspectorBackend::stepIntoStatementInDebugger): (WebCore::InspectorBackend::stepOutOfFunctionInDebugger): (WebCore::InspectorBackend::pauseOnExceptions): (WebCore::InspectorBackend::setPauseOnExceptions): (WebCore::InspectorBackend::profilerEnabled): (WebCore::InspectorBackend::enableProfiler): (WebCore::InspectorBackend::disableProfiler): (WebCore::InspectorBackend::startProfiling): (WebCore::InspectorBackend::stopProfiling): (WebCore::InspectorBackend::getProfileHeaders): (WebCore::InspectorBackend::getProfile): (WebCore::InspectorBackend::currentCallFrame): (WebCore::InspectorBackend::highlightDOMNode): (WebCore::InspectorBackend::hideDOMNodeHighlight): (WebCore::InspectorBackend::getCookies): (WebCore::InspectorBackend::deleteCookie): (WebCore::InspectorBackend::didEvaluateForTestInFrontend): (WebCore::InspectorBackend::nodeForId):
  • inspector/InspectorBackend.h: (WebCore::InspectorBackend::create):
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable):
  • inspector/InspectorController.h: (WebCore::InspectorController::inspectorFrontendHost): (WebCore::InspectorController::injectedScriptHost):
  • inspector/InspectorFrontendHost.cpp: Added. (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::~InspectorFrontendHost): (WebCore::InspectorFrontendHost::loaded): (WebCore::InspectorFrontendHost::attach): (WebCore::InspectorFrontendHost::detach): (WebCore::InspectorFrontendHost::closeWindow): (WebCore::InspectorFrontendHost::windowUnloading): (WebCore::InspectorFrontendHost::setAttachedWindowHeight): (WebCore::InspectorFrontendHost::moveWindowBy): (WebCore::InspectorFrontendHost::localizedStringsURL): (WebCore::InspectorFrontendHost::hiddenPanels): (WebCore::InspectorFrontendHost::platform): (WebCore::InspectorFrontendHost::port): (WebCore::InspectorFrontendHost::addResourceSourceToFrame): (WebCore::InspectorFrontendHost::addSourceToFrame):
  • inspector/InspectorFrontendHost.h: Added. (WebCore::InspectorFrontendHost::create): (WebCore::InspectorFrontendHost::inspectorController): (WebCore::InspectorFrontendHost::disconnectController):
  • inspector/InspectorFrontendHost.idl: Added.
  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set condition):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.clearMessages):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.getChildNodesAsync): (WebInspector.DOMAgent.prototype.setAttributeAsync): (WebInspector.DOMAgent.prototype.removeAttributeAsync): (WebInspector.DOMAgent.prototype.setTextNodeValueAsync): (WebInspector.Cookies.getCookiesAsync): (WebInspector.EventListeners.getEventListenersForNodeAsync):
  • inspector/front-end/DOMStorage.js: (WebInspector.DOMStorage.prototype.getEntries): (WebInspector.DOMStorage.prototype.setItem): (WebInspector.DOMStorage.prototype.removeItem):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.getTableNames):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.handleCopyEvent): (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode.restoreHighlightToHoveredNode): (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode): ():
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype):
  • inspector/front-end/InjectedScript.js: (InjectedScript._evaluateAndWrap): (InjectedScript.performSearch.addNodesToResults): (InjectedScript.getCallFrames): (InjectedScript._callFrameForId): (InjectedScript._clearConsoleMessages): (InjectedScript._inspectObject): (InjectedScript._copy): (InjectedScript._ensureCommandLineAPIInstalled): (InjectedScript._window): (InjectedScript._nodeForId): (InjectedScript._objectForId): (InjectedScript.pushNodeToFrontend): (InjectedScript.executeSql): (InjectedScript.executeSql.errorCallback): (InjectedScript.executeSql.queryTransaction):
  • inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName): (InjectedScriptAccess._installHandler):
  • inspector/front-end/InspectorBackendStub.js: Added. (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.wrapCallback): (.WebInspector.InspectorBackendStub.prototype.platform): (.WebInspector.InspectorBackendStub.prototype.port): (.WebInspector.InspectorBackendStub.prototype.closeWindow): (.WebInspector.InspectorBackendStub.prototype.attach): (.WebInspector.InspectorBackendStub.prototype.detach): (.WebInspector.InspectorBackendStub.prototype.storeLastActivePanel): (.WebInspector.InspectorBackendStub.prototype.clearMessages): (.WebInspector.InspectorBackendStub.prototype.searchingForNode): (.WebInspector.InspectorBackendStub.prototype.search): (.WebInspector.InspectorBackendStub.prototype.toggleNodeSearch): (.WebInspector.InspectorBackendStub.prototype.setAttachedWindowHeight): (.WebInspector.InspectorBackendStub.prototype.moveByUnrestricted): (.WebInspector.InspectorBackendStub.prototype.addResourceSourceToFrame): (.WebInspector.InspectorBackendStub.prototype.addSourceToFrame): (.WebInspector.InspectorBackendStub.prototype.getResourceDocumentNode): (.WebInspector.InspectorBackendStub.prototype.highlightDOMNode): (.WebInspector.InspectorBackendStub.prototype.hideDOMNodeHighlight): (.WebInspector.InspectorBackendStub.prototype.inspectedWindow): (.WebInspector.InspectorBackendStub.prototype.loaded): (.WebInspector.InspectorBackendStub.prototype.localizedStringsURL): (.WebInspector.InspectorBackendStub.prototype.windowUnloading): (.WebInspector.InspectorBackendStub.prototype.hiddenPanels): (.WebInspector.InspectorBackendStub.prototype.debuggerEnabled): (.WebInspector.InspectorBackendStub.prototype.enableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.disableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.resourceTrackingEnabled): (.WebInspector.InspectorBackendStub.prototype.enableDebugger): (.WebInspector.InspectorBackendStub.prototype.disableDebugger): (.WebInspector.InspectorBackendStub.prototype.addBreakpoint): (.WebInspector.InspectorBackendStub.prototype.removeBreakpoint): (.WebInspector.InspectorBackendStub.prototype.updateBreakpoint): (.WebInspector.InspectorBackendStub.prototype.pauseInDebugger): (.WebInspector.InspectorBackendStub.prototype.pauseOnExceptions): (.WebInspector.InspectorBackendStub.prototype.setPauseOnExceptions): (.WebInspector.InspectorBackendStub.prototype.resumeDebugger): (.WebInspector.InspectorBackendStub.prototype.profilerEnabled): (.WebInspector.InspectorBackendStub.prototype.enableProfiler): (.WebInspector.InspectorBackendStub.prototype.disableProfiler): (.WebInspector.InspectorBackendStub.prototype.startProfiling): (.WebInspector.InspectorBackendStub.prototype.stopProfiling): (.WebInspector.InspectorBackendStub.prototype.getProfileHeaders): (.WebInspector.InspectorBackendStub.prototype.getProfile): (.WebInspector.InspectorBackendStub.prototype.takeHeapSnapshot): (.WebInspector.InspectorBackendStub.prototype.databaseTableNames): (.WebInspector.InspectorBackendStub.prototype.stepIntoStatementInDebugger): (.WebInspector.InspectorBackendStub.prototype.stepOutOfFunctionInDebugger): (.WebInspector.InspectorBackendStub.prototype.stepOverStatementInDebugger): (.WebInspector.InspectorBackendStub.prototype.setSetting): (.WebInspector.InspectorBackendStub.prototype.dispatchOnInjectedScript): (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup): (.WebInspector.InspectorBackendStub.prototype.setting):
  • inspector/front-end/InspectorControllerStub.js:
  • inspector/front-end/InspectorFrontendHostStub.js: Added. (.WebInspector.InspectorFrontendHostStub): (.WebInspector.InspectorFrontendHostStub.prototype.platform): (.WebInspector.InspectorFrontendHostStub.prototype.port): (.WebInspector.InspectorFrontendHostStub.prototype.closeWindow): (.WebInspector.InspectorFrontendHostStub.prototype.attach): (.WebInspector.InspectorFrontendHostStub.prototype.detach): (.WebInspector.InspectorFrontendHostStub.prototype.search): (.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowHeight): (.WebInspector.InspectorFrontendHostStub.prototype.moveWindowBy): (.WebInspector.InspectorFrontendHostStub.prototype.addResourceSourceToFrame): (.WebInspector.InspectorFrontendHostStub.prototype.addSourceToFrame): (.WebInspector.InspectorFrontendHostStub.prototype.loaded): (.WebInspector.InspectorFrontendHostStub.prototype.localizedStringsURL): (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels): (.WebInspector.InspectorFrontendHostStub.prototype.setSetting): (.WebInspector.InspectorFrontendHostStub.prototype.setting):
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView): (WebInspector.CPUProfileType.prototype.buttonClicked):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._updateInterface): (WebInspector.ProfilesPanel.prototype._enableProfiling): (WebInspector.ProfilesPanel.prototype._toggleProfiling):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._toggleLargerResources): (WebInspector.ResourcesPanel.prototype._enableResourceTracking): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.addScript): (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._enableDebugging): (WebInspector.ScriptsPanel.prototype._toggleDebugging): (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions): (WebInspector.ScriptsPanel.prototype._togglePause): (WebInspector.ScriptsPanel.prototype._stepOverClicked): (WebInspector.ScriptsPanel.prototype._stepIntoClicked): (WebInspector.ScriptsPanel.prototype._stepOutClicked):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): (WebInspector.SourceView.prototype.performSearch.findSearchMatches): (WebInspector.SourceView.prototype.performSearch):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._changeColorFormat):
  • inspector/front-end/TestController.js: (WebInspector.TestController.prototype.notifyDone):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionsSection.prototype.loadSavedExpressions): (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.pendingDispatches.0.get platform): (WebInspector.get port): (WebInspector.set currentPanel): (WebInspector._createPanels): (WebInspector._loadPreferences): (WebInspector.set attached): (WebInspector._updateHoverHighlight): (WebInspector.loaded): (windowLoaded): (WebInspector.windowUnload): (WebInspector.close): (WebInspector.toolbarDrag): (WebInspector.UIString):
Note: See TracTimeline for information about the timeline view.