Timeline
12/14/09:
- 23:31 Changeset [52140] by
-
WAI-ARIA: implement treegrid
https://bugs.webkit.org/show_bug.cgi?id=31299
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/aria-treegrid.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
- accessibility/AccessibilityARIAGrid.h:
(WebCore::AccessibilityARIAGrid::supportsSelectedRows):
- accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::isARIATreeGridRow):
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isARIATreeGridRow):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMultiSelectable):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::selectedChildren):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTable.h:
(WebCore::AccessibilityTable::supportsSelectedRows):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
LayoutTests:
- platform/mac/accessibility/aria-treegrid-expected.txt: Added.
- platform/mac/accessibility/aria-treegrid.html: Added.
- 22:44 Changeset [52139] by
-
2009-12-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Some Browser-hosted SunSpider files are not valid HTML5
https://bugs.webkit.org/show_bug.cgi?id=32536
Made various fixes to validate as HTML5 with no warnings (mainly removing bogus
close tags and adding a meta charset declaration).
- hosted/sunspider.html:
- hosted/versions.html:
- resources/TEMPLATE.html:
- resources/driver-TEMPLATE.html:
- resources/results-TEMPLATE.html:
- 22:25 Changeset [52138] by
-
2009-12-14 Adam Barth <abarth@webkit.org>
Unreviewed. Fix failing unittest.
- Scripts/modules/bugzilla_unittest.py:
- 22:24 Changeset [52137] by
-
2009-12-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Eric Seidel.
Make sunspider-0.9.1 the default content set (both command-line and hosted)
https://bugs.webkit.org/show_bug.cgi?id=32537
- hosted/sunspider.html: Change default suite link.
- sunspider: Change default suite.
- sunspider-compare-results: Likewise.
- 22:16 Changeset [52136] by
-
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Kill _create_step_sequence
https://bugs.webkit.org/show_bug.cgi?id=32539
It's cleaner to represent not having these sequences as an empty
sequence instead of None.
- Scripts/modules/commands/download.py:
- Scripts/modules/stepsequence.py:
- 22:00 Changeset [52135] by
-
2009-12-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move Credential handling out into a separate module
https://bugs.webkit.org/show_bug.cgi?id=32531
- Scripts/modules/bugzilla.py:
- Scripts/modules/credentials.py: Added.
- Scripts/modules/credentials_unittest.py: Added.
- Scripts/run-webkit-unittests:
- 21:53 Changeset [52134] by
-
2009-12-14 Adam Barth <abarth@webkit.org>
Unreviewed. Address reviewer comments from an earlier patch. I didn't
do this earlier because I was worried about conflicts in dependent
patches.
- Scripts/modules/commands/download.py:
- 21:38 Changeset [52133] by
-
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Make download commands declarative
https://bugs.webkit.org/show_bug.cgi?id=32469
This patch "properly" factors most of the download commands. These
commands are now largely declarative, which is the final step of this
grand refactoring.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- 21:38 Changeset [52132] by
-
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Add AbstractPatchSequencingCommand to remove redundant code
https://bugs.webkit.org/show_bug.cgi?id=32468
Redundant code is bad. This patch moves us towards more declarative
commands.
- Scripts/modules/commands/download.py:
- 21:32 Changeset [52131] by
-
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitApplyingScripts
https://bugs.webkit.org/show_bug.cgi?id=32467
Ah! I've been wanting to do this for a long time. This patch brings
the applying commands into the patch processing fold.
- Scripts/bugzilla-tool:
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/download_unittest.py:
- Scripts/modules/mock_bugzillatool.py:
- 21:31 Changeset [52130] by
-
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Convert rollout to StepSequence
https://bugs.webkit.org/show_bug.cgi?id=32406
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/download_unittest.py:
- Scripts/modules/mock_bugzillatool.py:
- 21:21 Changeset [52129] by
-
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill LandingSequence
https://bugs.webkit.org/show_bug.cgi?id=32464
Removes LandingSequence in favor of StepSequence. This required
changing the Step API slightly to carry a general notion of state
instead of carrying patches specifically.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/landingsequence.py: Removed.
- Scripts/modules/stepsequence.py:
- 19:27 Changeset [52128] by
-
2009-12-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
in-browser SunSpider suffers excessive penalty under power management
https://bugs.webkit.org/show_bug.cgi?id=32505
I have made a few changes to address this:
1) Change how browser-hosted SunSpider loads tests - preload the content and write it in with
document.write to reduce triggering of progress UI.
2) Reduce time between tests to 10ms from 500ms, so that power management doesn't keep the CPU
stepped all the way down the whole time.
3) Run the test cycle an extra time for warmup before the runs that count.
- hosted/sunspider-record-result.js: Removed.
- make-hosted:
- resources/TEMPLATE.html:
- resources/driver-TEMPLATE.html:
- 19:05 Changeset [52127] by
-
<rdar://problem/7460655> REGRESSION (r47255): Content shifted down at software.opensuse.org
https://bugs.webkit.org/show_bug.cgi?id=32382
Reviewed by Darin Adler.
WebCore:
Test: fast/block/float/in-margin.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::getClearDelta): Floats that do not intrude into the line (because
they are in the margin) do not need to be cleared.
LayoutTests:
- fast/block/float/in-margin.html: Added.
- platform/mac/fast/block/float/in-margin-expected.checksum: Added.
- platform/mac/fast/block/float/in-margin-expected.png: Added.
- platform/mac/fast/block/float/in-margin-expected.txt: Added.
- 17:14 Changeset [52126] by
-
Pressing backspace inside a table cell erases all empty rows below it.
<rdar://problem/5565461>
https://bugs.webkit.org/show_bug.cgi?id=32526
Reviewed by John Sullivan.
WebCore:
No deletion is performed when the caret selection is on an empty table cell.
Test: editing/deleting/delete-empty-table.html
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Added check for empty table cells in
case of caret selection.
LayoutTests:
- editing/deleting/delete-empty-table-expected.txt: Added.
- editing/deleting/delete-empty-table.html: Added.
- 16:19 Changeset [52125] by
-
Rubber-stamped by Brady Eidson.
Add two http iFrame dynamic form tests to the Windows Skipped
list.
- platform/win/Skipped:
- 14:45 Changeset [52124] by
-
2009-12-14 Evan Stade <estade@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=32347
Chromium: Context menu launched by menu key has funky behavior
Make the context menu's position depend on the selection only when an
editable field has focus. Also, don't send multiple context menu events
for a single keypress.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::sendContextMenuEvent):
- 14:38 Changeset [52123] by
-
2009-12-14 Andrei Popescu <andreip@google.com>
Reviewed by Darin Adler.
[Android] Android needs ResourceHandle implementation
https://bugs.webkit.org/show_bug.cgi?id=32515
Adds implementation of ResourceHandle on Android.
No new tests needed, this is platform-specific code, so existing
tests are sufficient.
- platform/network/android/ResourceHandleAndroid.cpp: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::setDefersLoading): (WebCore::ResourceHandle::willLoadFromCache): (WebCore::ResourceHandle::loadsBlocked): (WebCore::SyncLoader::SyncLoader): (WebCore::SyncLoader::~SyncLoader): (WebCore::SyncLoader::didReceiveResponse): (WebCore::SyncLoader::didReceiveData): (WebCore::SyncLoader::didFail): (WebCore::ResourceHandle::loadResourceSynchronously):
- platform/network/android/ResourceLoaderAndroid.h: Added. (WebCore::ResourceLoaderAndroid::~ResourceLoaderAndroid): (WebCore::ResourceLoaderAndroid::ResourceLoaderAndroid):
- 14:30 Changeset [52122] by
-
2009-12-14 Marco Martin <notmart@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
In the Scrollbar painting of the Qt theme integration,
intersects any previous clip rects with the one needed to paint the scrollbar.
This fixes the painting in QGraphicsview, when the parent of the widget that
paints the QWebPage has the QGraphicsItem::ItemClipsChildrenToShape set and
a piece of the scrollbar should be cipped away
https://bugs.webkit.org/show_bug.cgi?id=30366
No new tests.
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paint):
- 14:23 Changeset [52121] by
-
Provide working printing support for WinCairo port.
Reviewed by Adam Roben.
- WebFrame.cpp:
(WebFrame::spoolPage): Conditionalize initialization of
PlatformGraphicsContext handling for CG vs. Cairo.
(scaleFactor): Add helper function.
(hdcFromContext): Add helper function.
(WebFrame::drawHeader): Correct Cairo variation.
(WebFrame::drawFooter): Correct Cairo variation.
(WebFrame::spoolPages): Correct Cairo variation.
- 14:17 Changeset [52120] by
-
2009-12-14 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
[V8] Generate bindings for trivial indexers.
https://bugs.webkit.org/show_bug.cgi?id=32455
Covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm:
Added detecting indexers and generating code for them.
- bindings/v8/V8Collection.h: Removed code that's now generated.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Ditto.
- 14:16 Changeset [52119] by
-
2009-12-14 Kinuko Yasuda <kinuko@chromium.com>
Reviewed by Darin Fisher.
Make changing-frame-hierarchy-in-onload.html less flaky and
platform-independent.
https://bugs.webkit.org/show_bug.cgi?id=32319
- http/tests/navigation/changing-frame-hierarchy-in-onload.html:
- 14:09 Changeset [52118] by
-
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Amend the behaviour of DRT::notifyDone to dump only when
the page has finished loading.
This fix permits removal of the following tests from the Qt skipped list:
fast/forms/textarea-linewrap-dynamic.html
fast/forms/textarea-setvalue-submit.html
fast/forms/textarea-hard-linewrap-empty.html
fast/forms/submit-to-url-fragment.html
http/tests/misc/percent-sign-in-form-field-name.html
http/tests/security/escape-form-data-field-names.html
However it also requires the following two to be added to the skipped list:
http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
svg/custom/use-instanceRoot-as-event-target.xhtml
It appears the behaviour of notifyDone was masking problems with these two
tests.
- platform/qt/Skipped:
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Amend the behaviour of DRT::notifyDone to dump only when
the page has finished loading.
This fix permits removal of the following tests from the Qt skipped list:
fast/forms/textarea-linewrap-dynamic.html
fast/forms/textarea-setvalue-submit.html
fast/forms/textarea-hard-linewrap-empty.html
fast/forms/submit-to-url-fragment.html
http/tests/misc/percent-sign-in-form-field-name.html
http/tests/security/escape-form-data-field-names.html
However it also requires the following two to be added to the skipped list:
http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
svg/custom/use-instanceRoot-as-event-target.xhtml
It appears the behaviour of notifyDone was masking problems with these two
tests.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::processWork): (LayoutTestController::maybeDump): (LayoutTestController::notifyDone): (LayoutTestController::provisionalLoad):
- DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::resetLoadFinished):
- 13:57 Changeset [52117] by
-
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Bug 32519 - mouseEvent fires mutiple times in
LayoutTests/svg/custom/use-instanceRoot-as-event-target.xhtml
Add test to Qt skipped list (was passing due to bug in DRT, see
https://bugs.webkit.org/show_bug.cgi?id=32437). Updated detail on bug
in gtk and win skipped lists.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 13:47 Changeset [52116] by
-
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=31660
REGRESSION (r49394): Image load event fires before the document fragment is attached.
Test: fast/images/image-load-event-in-fragment.html
We cannot fire load events immediately after parsing a fragment - an element inserted via
innerHTML or equivalent should be reachable via getElementById() by the time its load event
fires.
- dom/Document.cpp: (WebCore::Document::implicitClose): Call dispatchPendingBeforeLoadEvents() and dispatchPendingLoadEvents() individually. I'm not sure why these calls are here, just preserving existing behavior.
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write): Load events for elements that have just been parsed cannot be dispatched yet, we should give the elements a chance to be inserted into a document first. There is no compatibility baggage for beforeload, so it seems OK to dispatch it right away.
- loader/ImageLoader.cpp: (WebCore::ImageLoader::dispatchPendingBeforeLoadEvents): (WebCore::ImageLoader::dispatchPendingLoadEvents):
- loader/ImageLoader.h: Separated dispatchPendingEvents() into individual functions for each event kind.
- 13:27 Changeset [52115] by
-
2009-12-14 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Simon Fraser.
Add FloatQuad::isRectilinear() to check whether it can be represented as FloatRect.
https://bugs.webkit.org/show_bug.cgi?id=30442
This enables optimizations for distinguishing between
arbitrary FloatQuads and rectilinear ones.
- platform/graphics/FloatQuad.cpp: (WebCore::FloatQuad::isRectilinear):
- platform/graphics/FloatQuad.h:
- 13:08 Changeset [52114] by
-
Rubber-stamped by Adam Roben.
Add two XSS tests that intermittently time out to the Windows
Skipped list.
- platform/win/Skipped:
- 12:57 Changeset [52113] by
-
2009-12-14 Simon Hausmann <hausmann@webkit.org>
Reviewed by Holger Freyther.
[Qt] Extend basic touch event test with a simple keyboard modifier test.
- fast/events/basic-touch-events-expected.txt:
- fast/events/script-tests/basic-touch-events.js: (singleTouchSequence):
2009-12-14 Simon Hausmann <hausmann@webkit.org>
Reviewed by Holger Freyther.
[Qt] Add support for keyboard modifiers to TouchEvent
Similar to other ui events with keyboard state, get the alt, shift,
meta and ctrl modifiers straight from the platform event.
- dom/TouchEvent.cpp: (WebCore::TouchEvent::TouchEvent): (WebCore::TouchEvent::initTouchEvent):
- dom/TouchEvent.h: (WebCore::TouchEvent::create):
- dom/TouchEvent.idl:
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
- platform/PlatformTouchEvent.h: (WebCore::PlatformTouchEvent::PlatformTouchEvent): (WebCore::PlatformTouchEvent::shiftKey): (WebCore::PlatformTouchEvent::ctrlKey): (WebCore::PlatformTouchEvent::altKey): (WebCore::PlatformTouchEvent::metaKey):
- platform/qt/PlatformTouchEventQt.cpp: (WebCore::PlatformTouchEvent::PlatformTouchEvent):
2009-12-14 Simon Hausmann <hausmann@webkit.org>
Reviewed by Holger Freyther.
[Qt] Add support for keyboard modifiers to Qt DRT's EventSender for touch events
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::setTouchModifier): (EventSender::clearTouchPoints): (EventSender::sendTouchEvent):
- DumpRenderTree/qt/EventSenderQt.h:
- 12:49 Changeset [52112] by
-
2009-12-14 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] crash when clicking "Sign out" in GMail
https://bugs.webkit.org/show_bug.cgi?id=32300
When the ResourceLoader cancels the handle we have to make sure not to access
the resource handle afterwards again.
This complete r29515
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- 12:42 Changeset [52111] by
-
2009-12-14 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Improve the autotests of QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=32216
Refactor tst_qwebelement to remove the qWait()
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::style):
- 12:35 Changeset [52110] by
-
2009-12-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
Fix the QWebPage inputMethods() autotest after r51758
to compare the Qt::ImFont property's family against an explicitly
previously configured family.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
- 12:28 Changeset [52109] by
-
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
access-control-basic-denied-preflight-cache.html fails manual testing.
LayoutTests/http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
fails manual testing. It passes the automatic layout tests in Qt due to a bug with
notifyDone (see https://bugs.webkit.org/show_bug.cgi?id=32437).
Performing the test manually in QtLauncher shows that an exception is received.
Add access-control-basic-denied-preflight-cache.html to the Qt skipped list.
- platform/qt/Skipped:
- 12:21 Changeset [52108] by
-
2009-12-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Implement InjectedScript.evaluateOnSelf() that evaluates functions in the InjectedScript context.
https://bugs.webkit.org/show_bug.cgi?id=32517
- inspector/front-end/InjectedScript.js: (InjectedScript.evaluateOnSelf):
- inspector/front-end/InjectedScriptAccess.js:
- 12:13 Changeset [52107] by
-
2009-12-14 Nayan Kumar K <nayankk@gmail.com>
Reviewed by Darin Adler.
Fix for compilation errors in WML enabled builds.
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::setValueForUser):
- wml/WMLInputElement.h:
- 12:06 Changeset [52106] by
-
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Not reviewed, build fix.
Add missing newline at end of test result.
- platform/mac-tiger/media/video-no-audio-expected.txt:
- 12:01 Changeset [52105] by
-
[Android] Android needs ResourceError, ResourceResponse and
ResourceRequest implementation.
https://bugs.webkit.org/show_bug.cgi?id=32522
Patch by Andrei Popescu <andreip@google.com> on 2009-12-14
Reviewed by Darin Adler.
Add implementation of ResourceError, ResourceResponse and ResourceRequest.
No new tests needed, the existing tests should be sufficient.
- platform/network/android/ResourceError.h: Added.
(WebCore::ResourceError::ResourceError):
- platform/network/android/ResourceRequest.h: Added.
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::setUserGesture):
(WebCore::ResourceRequest::getUserGesture):
- platform/network/android/ResourceResponse.h: Added.
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::doUpdateResourceResponse):
- 11:38 Changeset [52104] by
-
Fix the build.
- page/Geolocation.cpp:
- page/Geolocation.h:
- 11:26 Changeset [52103] by
-
Fix for https://bugs.webkit.org/show_bug.cgi?id=32499
Add client based Geolocation provider
Reviewed by Dan Bernstein.
Add first cut of a client based Geolocation provider. This is guarded by
ENABLE(CLIENT_BASED_GEOLOCATION) and is off by default for now. This adds a
GeolocationControllerClient interface that no-one currently implements,
but will in a subsequent patch.
WebCore:
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- page/Geolocation.cpp:
(WebCore::createGeopositionFromGeolocationPosition):
(WebCore::createPositionErrorFromGeolocationError):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::disconnectFrame):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::fatalErrorOccurred):
(WebCore::Geolocation::requestTimedOut):
(WebCore::Geolocation::clearWatch):
(WebCore::Geolocation::handleError):
(WebCore::Geolocation::positionChanged):
(WebCore::Geolocation::makeSuccessCallbacks):
(WebCore::Geolocation::errorOccurred):
(WebCore::Geolocation::geolocationServicePositionChanged):
(WebCore::Geolocation::geolocationServiceErrorOccurred):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
- page/Geolocation.h:
- page/GeolocationController.cpp: Added.
(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::~GeolocationController):
(WebCore::GeolocationController::addObserver):
(WebCore::GeolocationController::removeObserver):
(WebCore::GeolocationController::positionChanged):
(WebCore::GeolocationController::errorOccurred):
(WebCore::GeolocationController::lastPosition):
- page/GeolocationController.h: Added.
- page/GeolocationControllerClient.h: Added.
(WebCore::GeolocationControllerClient::~GeolocationControllerClient):
- page/GeolocationError.h: Added.
(WebCore::GeolocationError::):
(WebCore::GeolocationError::create):
(WebCore::GeolocationError::code):
(WebCore::GeolocationError::message):
- page/GeolocationPosition.h: Added.
(WebCore::GeolocationPosition::create):
(WebCore::GeolocationPosition::timestamp):
(WebCore::GeolocationPosition::latitude):
(WebCore::GeolocationPosition::longitude):
(WebCore::GeolocationPosition::accuracy):
(WebCore::GeolocationPosition::altitude):
(WebCore::GeolocationPosition::altitudeAccuracy):
(WebCore::GeolocationPosition::heading):
(WebCore::GeolocationPosition::speed):
(WebCore::GeolocationPosition::canProvideAltitude):
(WebCore::GeolocationPosition::canProvideAltitudeAccuracy):
(WebCore::GeolocationPosition::canProvideHeading):
(WebCore::GeolocationPosition::canProvideSpeed):
(WebCore::GeolocationPosition::GeolocationPosition):
- page/Geoposition.h:
(WebCore::Geoposition::create):
- page/Page.cpp:
(WebCore::Page::Page):
- page/Page.h:
(WebCore::Page::geolocationController):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
WebKit/gtk:
- webkit/webkitwebview.cpp:
(webkit_web_view_init):
WebKit/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
WebKit/qt:
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
WebKit/win:
- WebView.cpp:
(WebView::initWithFrame):
- 11:10 QtWebKit/CodeCamp200912 edited by
- (diff)
- 10:45 Changeset [52102] by
-
2009-12-14 Adam Langley <agl@google.com>
Reviewed by Darin Adler.
Test that an image's size is valid before reading it.
Previously, an image that failed to load (m_failed == true) would
trigger an assertion failure when WebKit tried to get its size.
https://bugs.webkit.org/show_bug.cgi?id=32176
http://code.google.com/p/chromium/issues/detail?id=28566
Test: fast/images/size-failure.html
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::createFrameAtIndex):
- 10:40 Changeset [52101] by
-
https://bugs.webkit.org/show_bug.cgi?id=32524
REGRESSION(52084): fast/dom/prototypes.html failing two CSS tests
Reviewed by Simon Fraser.
- wtf/StdLibExtras.h:
(WTF::bitCount): The original patch put the parentheses in the wrong
place, completely changing the calculation and making it almost always
wrong. Moved the parentheses around the '+' operation, like the original
compiler warning suggested.
- 10:04 Changeset [52100] by
-
<rdar://problem/7458272> REGRESSION (r50470) Reproducible ASSERT in
RenderWidget::setWidgetGeometry()
Reviewed by Darin Adler.
WebCore:
Test: fast/forms/defer-updateFromElement.html
- html/HTMLFormControlElement.cpp:
(WebCore::updateFromElementCallback): Added this post-attach callback
that invokes updateFromElement().
(WebCore::HTMLFormControlElement::recalcStyle): Instead of calling
updateFromElement(), enqueue a post-attach (in this case, post-style
recalc) callback to do it. updateFromElement() can cause the selection
to change, and in turn trigger synchronous layout, so it must not be
called during style recalc.
LayoutTests:
- fast/forms/defer-updateFromElement-expected.txt: Added.
- fast/forms/defer-updateFromElement.html: Added.
- 10:01 Changeset [52099] by
-
2009-12-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: [regression] inspector deletes nodes when editing css.
Now all the treeoutlines are focusable, sections and their titles
are also focusable. Change contains couple of drive-by fixes such as
canceling of the attribute edit nuking attr info and maintaining proper
selection while deleting nodes.
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.handleShortcut):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._promptKeyDown):
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype._keyDown):
- inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView): (WebInspector.DatabaseQueryView.prototype._promptKeyDown):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.get defaultFocusedElement): (WebInspector.ElementsPanel.prototype.handleShortcut):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline): (WebInspector.ElementsTreeOutline.prototype._keyDown): (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): (WebInspector.ElementsTreeElement.prototype._editingCancelled):
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.show): (WebInspector.Panel.prototype.get defaultFocusedElement):
- inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get defaultFocusedElement): (WebInspector.ScriptsPanel.prototype.handleShortcut):
- inspector/front-end/SidebarPane.js: (WebInspector.SidebarPane): (WebInspector.SidebarPane.prototype.toggleExpanded): (WebInspector.SidebarPane.prototype._onTitleKeyDown):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector.documentCanCopy): (WebInspector.documentCopy): (WebInspector._searchFieldManualFocus): (WebInspector._searchKeyDown): (WebInspector.startEditing.cleanUpAfterEditing): (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):
- inspector/front-end/treeoutline.js: (TreeOutline): (TreeOutline._removeChildAtIndex): (TreeOutline.prototype._treeKeyDown): (TreeElement.prototype.deselect):
- inspector/front-end/utilities.js: ():
- 09:46 Changeset [52098] by
-
Change IWebFramePrivate's vtable to be compatible with Safari 4.0.4
Reviewed by Steve Falkenburg.
Fixes <http://webkit.org/b/32433> REGRESSION (r51567): Right click on
a link element crashes WebKit nightly
- Interfaces/IWebFramePrivate.idl: Moved pauseSVGAnimation to the end
of the interface so the vtable that Safari 4.0.4 sees is unchanged.
- 09:43 Changeset [52097] by
-
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Not reviewed, build fix.
Update Tiger media test results after r52094.
- platform/mac-tiger/accessibility: Added.
- platform/mac-tiger/accessibility/media-element-expected.txt: Added.
- platform/mac-tiger/media/audio-controls-rendering-expected.txt: Added.
- platform/mac-tiger/media/controls-after-reload-expected.txt: Added.
- platform/mac-tiger/media/controls-drag-timebar-expected.txt: Added.
- platform/mac-tiger/media/controls-strict-expected.txt: Added.
- platform/mac-tiger/media/controls-styling-expected.txt: Added.
- platform/mac-tiger/media/video-controls-rendering-expected.txt: Added.
- platform/mac-tiger/media/video-display-toggle-expected.txt: Added.
- platform/mac-tiger/media/video-no-audio-expected.txt: Added.
- platform/mac-tiger/media/video-zoom-controls-expected.txt: Added.
- 09:20 Changeset [52096] by
-
2009-12-14 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, build fix.
[Chromium] Guard all of JSC's wrapper cache-related members on Document.
- dom/Document.cpp: (WebCore::Document::createWrapperCache): Widened the guards to the whole method.
- dom/Document.h: Added JSC guards to wrapper cache-related members.
- 08:25 Changeset [52095] by
-
AX: there's an infinite loop going on for some webpages - facebook.com
https://bugs.webkit.org/show_bug.cgi?id=32501
Reviewed by Adele Peterson.
WebCore:
The problem is that parentObjectUnignored() cannot be called
while in accessibilityIsIgnored, because it leads to
recursiveness. Specifically, there were checks to determine
if an object was within a ARIA tree. That check should
1) be moved to all platforms, and 2) not call parentObjectUnignored().
Test: accessibility/hang-in-isignored.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isAllowedChildOfTree):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
LayoutTests:
- accessibility/hang-in-isignored-expected.txt: Added.
- accessibility/hang-in-isignored.html: Added.
- 08:16 Changeset [52094] by
-
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows
Use MediaControllerThemeQuickTime on Leopard.
- rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows
Regenerate layout and pixel test results for the new UI.
- platform/mac-leopard/Skipped:
- platform/mac-leopard/accessibility/media-element-expected.txt:
- platform/mac-leopard/media/audio-controls-rendering-expected.checksum:
- platform/mac-leopard/media/audio-controls-rendering-expected.txt:
- platform/mac-leopard/media/controls-after-reload-expected.checksum: Added.
- platform/mac-leopard/media/controls-after-reload-expected.png: Added.
- platform/mac-leopard/media/controls-after-reload-expected.txt:
- platform/mac-leopard/media/controls-drag-timebar-expected.txt:
- platform/mac-leopard/media/controls-strict-expected.checksum: Added.
- platform/mac-leopard/media/controls-strict-expected.png: Added.
- platform/mac-leopard/media/controls-strict-expected.txt:
- platform/mac-leopard/media/controls-strict-mode-expected.txt: Added.
- platform/mac-leopard/media/controls-styling-expected.checksum: Added.
- platform/mac-leopard/media/controls-styling-expected.png: Added.
- platform/mac-leopard/media/controls-styling-expected.txt:
- platform/mac-leopard/media/video-controls-rendering-expected.checksum:
- platform/mac-leopard/media/video-controls-rendering-expected.txt:
- platform/mac-leopard/media/video-display-toggle-expected.checksum:
- platform/mac-leopard/media/video-display-toggle-expected.txt:
- platform/mac-leopard/media/video-no-audio-expected.checksum: Added.
- platform/mac-leopard/media/video-no-audio-expected.png: Added.
- platform/mac-leopard/media/video-no-audio-expected.txt:
- platform/mac-leopard/media/video-zoom-controls-expected.checksum:
- platform/mac-leopard/media/video-zoom-controls-expected.txt:
- 07:44 Changeset [52093] by
-
Build fix
- WebKit.vcproj/WebKit.vcproj: Added $(DXSDK_DIR)\Lib\x86 to the
libpath for all non-Cairo configurations (it was missing from most of
them).
- 07:38 Changeset [52092] by
-
Move QuartzCore-related build settings into a vsprops file
Fixes <http://webkit.org/b/32518>
Reviewed by Dan Bernstein.
- WebCore.vcproj/WebCore.vcproj: Let VS reformat the files list, added
WebCoreQuartzCore.vsprops to the non-Cairo configurations, moved all
other QuartzCore-related build settings from here...
- WebCore.vcproj/WebCoreQuartzCore.vsprops: ...to here.
- 07:21 Changeset [52091] by
-
2009-12-14 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antti Koivisto.
handling scripts can block UI
https://bugs.webkit.org/show_bug.cgi?id=27612
Break execution of external scrips to smaller chunks.
No new tests since no new functionality was introduced.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished): (WebCore::HTMLTokenizer::executeExternalScriptsIfReady): (WebCore::HTMLTokenizer::executeExternalScriptsTimerFired): (WebCore::HTMLTokenizer::continueExecutingExternalScripts):
- html/HTMLTokenizer.h:
- 06:13 Changeset [52090] by
-
Unreviewed trivial buildfix.
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-12-14
Fix crosses initialization of usedPrimaryBlocks for JSValue32
- runtime/Collector.cpp:
(JSC::Heap::markConservatively):
- 03:09 Changeset [52089] by
-
[Qt] Connect QNetworkReply via direct connections.
https://bugs.webkit.org/show_bug.cgi?id=32113
In the past we have switched from auto connections to queued
connections to get some more stability. The problem with the
Queued connections is latency. Even when running simple loading
tests the time it takes to runs highly varies and by using
direct connections these tests produce a stable result.
We will have to look out for crashes coming from within the
QNetworkAccessManager due this patch and address them then.
- 03:03 Changeset [52088] by
-
2009-12-14 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Gustavo Noronha Silva.
media/video-played-collapse.html is failing
https://bugs.webkit.org/show_bug.cgi?id=31434
- platform/gtk/Skipped: Give this test another chance, we believe the bug above has been fixed in a previous commit.
- 02:51 Changeset [52087] by
-
Reviewed by Xan Lopez.
New setting to allow applications to completely supress the
default context menu that is generated by WebKit. This allows them
to still pass the vent to the default handler without needing to
use ugly hacks such as handling populate-popup, and removing all
the items from the default context menu.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_forward_context_menu_event):
- 02:48 Changeset [52086] by
-
[Qt] QtWebKit should use QImageReader::setQuality(49)
https://bugs.webkit.org/show_bug.cgi?id=30740
Using QImageReader::setQuality(49) will influence the JPEG
decoder of Qt to use the JDCT_IFAST routines for decompressing. This
is showing a 5% improvement in a reduction that decodes all images
used during the page loading test. The libjpeg documentation mentions
that the IFAST routine is not as accurate as other routines but in
our tests we couldn't see a difference.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
- 02:01 Changeset [52085] by
-
emit volumeChanged and durationChanged upon notification from GStreamer.
- 01:56 Changeset [52084] by
-
GCC 4.3.x warning fixed. Suggested parantheses added.
warning: ../../../JavaScriptCore/wtf/StdLibExtras.h:77: warning: suggest parentheses around + or - in operand of &
Reviewed by Simon Hausmann.
- wtf/StdLibExtras.h:
(WTF::bitCount):
- 00:39 Changeset [52083] by
-
RS by Maciej Stachowiak.
Adding platform specific results for these test as part of reverting changes from http://trac.webkit.org/changeset/49585 to fix:
<rdar://problem/7382815> REGRESSION (4.0.4-TOT): Home photo slider is too narrow at http://www.ziprealty.com/
https://bugs.webkit.org/show_bug.cgi?id=32078
- platform/win/fast/css/large-number-round-trip-expected.txt: Added.
- platform/win/fast/css/opacity-float-expected.txt: Added.
- 00:13 Changeset [52082] by
-
JavaScriptCore: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
Added WeakGCMap to keep WebCore blissfully ignorant about objects that
have become garbage but haven't run their destructors yet.
1% SunSpider speedup.
7.6% v8 speedup (37% splay speedup).
17% speedup on bench-alloc-nonretained.js.
18% speedup on bench-alloc-retained.js.
- API/JSBase.cpp:
(JSGarbageCollect):
- API/JSContextRef.cpp:
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj: Updated for renames and new
files.
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions): Updated to use the Collector
iterator abstraction.
- jsc.cpp:
(functionGC): Updated for rename.
- runtime/Collector.cpp: Slightly reduced the number of allocations per
collection, so that small workloads only allocate on collector block,
rather than two.
(JSC::Heap::Heap): Updated to use the new allocateBlock function.
(JSC::Heap::destroy): Updated to use the new freeBlocks function.
(JSC::Heap::allocateBlock): New function to initialize a block when
allocating it.
(JSC::Heap::freeBlock): Consolidated the responsibility for running
destructors into this function.
(JSC::Heap::freeBlocks): Updated to use freeBlock.
(JSC::Heap::recordExtraCost): Sweep the heap in this reporting function,
so that allocation, which is more common, doesn't have to check extraCost.
(JSC::Heap::heapAllocate): Run destructors right before recycling a
garbage cell. This has better cache utilization than a separate sweep phase.
(JSC::Heap::resizeBlocks):
(JSC::Heap::growBlocks):
(JSC::Heap::shrinkBlocks): New set of functions for managing the size of
the heap, now that the heap doesn't maintain any information about its
size.
(JSC::isPointerAligned):
(JSC::isHalfCellAligned):
(JSC::isPossibleCell):
(JSC::isCellAligned):
(JSC::Heap::markConservatively): Cleaned up this code a bit.
(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells): Some helper functions for examining the the mark
bitmap.
(JSC::Heap::sweep): Simplified this function by using a DeadObjectIterator.
(JSC::Heap::markRoots): Reordered some operations for clarity.
(JSC::Heap::objectCount):
(JSC::Heap::addToStatistics):
(JSC::Heap::statistics): Rewrote these functions to calculate an object
count on demand, since the heap doesn't maintain this information by
itself.
(JSC::Heap::reset): New function for resetting the heap once we've
exhausted heap space.
(JSC::Heap::collectAllGarbage): This function matches the old collect()
behavior, but it's now an uncommon function used only by API.
- runtime/Collector.h:
(JSC::CollectorBitmap::count):
(JSC::CollectorBitmap::isEmpty): Added some helper functions for managing
the collector mark bitmap.
(JSC::Heap::reportExtraMemoryCost): Changed reporting from cell equivalents
to bytes, so it's easier to understand.
- runtime/CollectorHeapIterator.h:
(JSC::CollectorHeapIterator::CollectorHeapIterator):
(JSC::CollectorHeapIterator::operator!=):
(JSC::CollectorHeapIterator::operator*):
(JSC::CollectorHeapIterator::advance):
(JSC::::LiveObjectIterator):
(JSC::::operator):
(JSC::::DeadObjectIterator):
(JSC::::ObjectIterator): New iterators for encapsulating details about
heap layout, and what's live and dead on the heap.
- runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength): Delay reporting extra cost until
we're fully constructed, so the heap mark phase won't visit us in an
invalid state.
- runtime/JSCell.h:
(JSC::JSCell::):
(JSC::JSCell::createDummyStructure):
(JSC::JSCell::JSCell):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h: Added a dummy cell to simplify allocation logic.
- runtime/JSString.h:
(JSC::jsSubstring): Don't report extra cost for substrings, since they
share a buffer that's already reported extra cost.
- runtime/Tracing.d:
- runtime/Tracing.h: Changed these dtrace hooks not to report object
counts, since they're no longer cheap to compute.
- runtime/UString.h: Updated for renames.
- runtime/WeakGCMap.h: Added.
(JSC::WeakGCMap::isEmpty):
(JSC::WeakGCMap::uncheckedGet):
(JSC::WeakGCMap::uncheckedBegin):
(JSC::WeakGCMap::uncheckedEnd):
(JSC::::get):
(JSC::::take):
(JSC::::set):
(JSC::::uncheckedRemove): Mentioned above.
- wtf/StdLibExtras.h:
(WTF::bitCount): Added a bit population count function, so the heap can
count live objects to fulfill statistics questions.
JavaScriptGlue: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
- JavaScriptGlue.cpp:
(JSCollect): Updated for rename. Fixed a bug where JSGlue would not check
to avoid nested GC calls.
WebCore: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
- ForwardingHeaders/runtime/WeakGCMap.h: Added.
- bindings/js/GCController.cpp:
(WebCore::collect):
(WebCore::GCController::gcTimerFired):
(WebCore::GCController::garbageCollectNow): Updated for rename.
- bindings/js/JSDOMBinding.cpp:
(WebCore::removeWrappers):
(WebCore::hasCachedDOMObjectWrapperUnchecked):
(WebCore::hasCachedDOMObjectWrapper):
(WebCore::hasCachedDOMNodeWrapperUnchecked):
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
(WebCore::isObservableThroughDOM):
(WebCore::markDOMNodesForDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::markDOMNodeWrapper):
- bindings/js/JSDOMBinding.h: Changed DOM wrapper maps to be WeakGCMaps.
Don't ASSERT that an item must be in the WeakGCMap when its destructor
runs, since it might have been overwritten in the map first.
- bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS): Changed Document from a DOM object wrapper to a DOM node
wrapper, to simplify some code.
- bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
(WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper):
- bindings/js/JSInspectorCallbackWrapper.cpp: Use a WeakGCMap for these
wrappers.
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren): Updated for WeakGCMap and Document using
a DOM node wrapper instead of a DOM object wrapper.
- bindings/js/JSSVGPODTypeWrapper.h:
(WebCore::JSSVGDynamicPODTypeWrapperCache::wrapperMap):
(WebCore::JSSVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
(WebCore::JSSVGDynamicPODTypeWrapperCache::forgetWrapper):
(WebCore::::~JSSVGDynamicPODTypeWrapper): Shined a small beam of sanity light
on this code. Use hashtable-based lookup in JSSVGPODTypeWrapper.h instead
of linear lookup through iteration, since that's what hashtables were
invented for. Make JSSVGPODTypeWrapper.h responsible for reomving itself
from the table, instead of its JS wrapper, to decouple these objects from
GC, and because these objects are refCounted, not solely owned by their
JS wrappers.
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.h: Adopted changes above.
12/13/09:
- 23:01 Changeset [52081] by
-
RS by Maciej Stachowiak.
Readding platform specific results for this test as part of reverting changes from http://trac.webkit.org/changeset/49585 to fix:
<rdar://problem/7382815> REGRESSION (4.0.4-TOT): Home photo slider is too narrow at http://www.ziprealty.com/
https://bugs.webkit.org/show_bug.cgi?id=32078
- platform/mac/fast/css/opacity-float-expected.txt: Added.
- 21:01 Changeset [52080] by
-
2009-12-13 Charles Reis <creis@chromium.org>
Reviewed by Adam Barth.
Refactor some security code out of V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=32326
No new tests. There should be no functionality changes in this patch,
since it is only refactoring code.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- bindings/BindingSecurity.h: Added. (WebCore::BindingSecurity::BindingSecurity): (WebCore::::canAccessWindow): (WebCore::::canAccessFrame): (WebCore::::checkNodeSecurity):
- bindings/BindingSecurityBase.cpp: Added. (WebCore::BindingSecurityBase::getDOMWindow): (WebCore::BindingSecurityBase::getFrame): (WebCore::BindingSecurityBase::canAccessWindow):
- bindings/BindingSecurityBase.h: Added.
- bindings/GenericBinding.h: Added. (WebCore::):
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::isSafeScript):
- bindings/v8/V8Binding.h:
- bindings/v8/V8BindingState.cpp: Added. (WebCore::::Only): (WebCore::::getActiveWindow): (WebCore::::immediatelyReportUnsafeAccessTo):
- bindings/v8/V8BindingState.h: Added. (WebCore::):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::reportUnsafeAccessTo): (WebCore::reportUnsafeJavaScriptAccess):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::):
- bindings/v8/custom/V8CustomBinding.cpp: (WebCore::allowSettingFrameSrcToJavascriptUrl): (WebCore::INDEXED_ACCESS_CHECK): (WebCore::NAMED_ACCESS_CHECK):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::V8Custom::ClearTimeoutImpl): (WebCore::NAMED_ACCESS_CHECK): (WebCore::INDEXED_ACCESS_CHECK):
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_ACCESS_CHECK): (WebCore::NAMED_ACCESS_CHECK):
2009-12-13 Charles Reis <creis@chromium.org>
Reviewed by Adam Barth.
Refactor some security code out of V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=32326
- src/WebBindings.cpp: (WebKit::getDragDataImpl):
- 19:10 Changeset [52079] by
-
[Qt] Implement initializeMaximumHTTPConnectionCountPerHost.
Qt allows to have three connections per host on Symbian, for
every other platform the limit is set to six connections per
host but the default implementation will only schedule four
connections per host.
In a manual test we seem to get the best loading speed by
going with Qt's limit and schedule two more jobs to allow Qt
to prepare them.
- platform/network/ResourceRequestBase.cpp:
- platform/network/qt/ResourceRequestQt.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost):
- 18:38 Changeset [52078] by
-
2009-12-13 Eric Seidel <eric@webkit.org>
Reviewed by Gavin Barraclough.
string-base64 test does not compute a valid base64 string
http://bugs.webkit.org/show_bug.cgi?id=16806
- tests/string-base64.js: change str[i] to str.charCodeAt(i)
2009-12-13 Maciej Stachowiak <mjs@apple.com>
Reviewed by Gavin Barraclough.
SunSpider/tests/string-base64.js does not compute a valid base64 encoded string
https://bugs.webkit.org/show_bug.cgi?id=16806
Based on a patch by Eric Seidel.
Fix the base64 computation to actually compute correct results. The impact on runtime of
the test is pretty small, but noticeable for some browsers. But at least it's not
doing a wrong and meaningless computation any more.
- tests/sunspider-0.9.1/string-base64.js: (): (base64ToString):
- 18:26 Changeset [52077] by
-
Fix minor problem in sunspider-compare-results which left it broken.
Reviewed by Gavin Barraclaugh.
- Scripts/sunspider-compare-results: Declare $parseonly
- 17:32 Changeset [52076] by
-
- runtime/JSGlobalObjectFunctions.cpp:
Reviewed by NOBODY (speculative Windows build fix).
- 16:27 Changeset [52075] by
-
https://bugs.webkit.org/show_bug.cgi?id=32496
Switch remaining cases of string construction to use StringBuilder.
Builds strings using a vector rather than using string append / addition.
Reviewed by Sam Weinig.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/Executable.cpp:
(JSC::FunctionExecutable::paramString):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):
- runtime/JSONObject.cpp:
(JSC::Stringifier::stringify):
(JSC::Stringifier::indent):
- runtime/JSString.h:
- runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lexString):
- runtime/NumberPrototype.cpp:
(JSC::integerPartNoExp):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
- runtime/Operations.h:
(JSC::jsString):
- runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::substituteBackreferences):
(JSC::stringProtoFuncConcat):
- 16:14 Changeset [52074] by
-
Add a style guideline concerning floating point literals
https://bugs.webkit.org/show_bug.cgi?id=32497
Reviewed by Sam Weinig.
- coding/coding-style.html:
- 16:12 Changeset [52073] by
-
<rdar://problem/7341364> Crash at HTMLParser::popOneBlockCommon() after
handling misnested residual style tags
Reviewed by Simon Fraser.
WebCore:
Test: fast/parser/residual-style-close-ref-clone.html
- html/HTMLParser.cpp:
(WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Gave the
block stack a strong reference to the cloned residual style element.
LayoutTests:
- fast/parser/residual-style-close-ref-clone-expected.txt: Added.
- fast/parser/residual-style-close-ref-clone.html: Added.
- 15:53 Changeset [52072] by
-
Fixing commit error...
I accidentally committed my last patch in a form that broke Web-hosted SunSpider. Fixing.
- resources/driver-TEMPLATE.html:
- 15:00 Changeset [52071] by
-
Reverting changes from http://trac.webkit.org/changeset/49585 to fix:
<rdar://problem/7382815> REGRESSION (4.0.4-TOT): Home photo slider is too narrow at http://www.ziprealty.com/
https://bugs.webkit.org/show_bug.cgi?id=32078
Reviewed by Sam Weinig.
WebCore:
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
LayoutTests:
- fast/css/large-number-round-trip-expected.txt:
- fast/css/large-number-round-trip.html: Updated to run in Firefox.
- fast/css/opacity-float-expected.txt:
- fast/css/opacity-float.html:
- transforms/2d/compound-2d-transforms-expected.txt:
- transforms/2d/compound-2d-transforms.html:
- 14:48 Changeset [52070] by
-
Reviewed by Xan Lopez.
Also give the right click event to the frame's event handler, if
there WebCore decides to not generate the default context
menu. This fixes some pages that handle right-button clicks for
things other than context menu creation.
- webkit/webkitwebview.cpp: (webkit_web_view_forward_context_menu_event):
- 14:34 Changeset [52069] by
-
2009-12-13 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Simon Hausmann.
Add a test in Qt for https://bugs.webkit.org/show_bug.cgi?id=29005
https://bugs.webkit.org/show_bug.cgi?id=29008
- tests/qwebframe/tst_qwebframe.cpp:
- 12:31 Changeset [52068] by
-
2009-12-13 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
Use JSON.parse instead of eval for Web-hosted SunSpider results processing
https://bugs.webkit.org/show_bug.cgi?id=32490
- hosted/json2.js: Added. Incorporated from json.org
- resources/driver-TEMPLATE.html: Fix an HTML validation bug I noticed.
- resources/results-TEMPLATE.html: Use JSON.parse instead of eval to process results.
- 05:33 Changeset [52067] by
-
Reviewed by Eric Seidel.
Add code to allow toggling ATSUI/Core Text rendering at runtime in ComplexTextController.
https://bugs.webkit.org/show_bug.cgi?id=31802
The goal here is to allow for a zero runtime hit for ports that decide to select
the API at compile time.
When both USE(ATSUI) and USE(CORE_TEXT) are true, the API is toggled
at runtime. Core Text is used for OS Versions >= 10.6.
No test since this is already covered by existing pixel tests.
- platform/graphics/SimpleFontData.h: Change #ifdef to define getNSFont() on Chrome/Mac .
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::shouldUseATSUIAPI): Cache decision about which API to use.
(WebCore::ComplexTextController::ComplexTextRun::indexAt):
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Stub function to call through
to ATSUI/Core text variants.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): The actual work for object construction
is delegate to createTextRunFromFontDataATSUI/createTextRunFromFontDataCoreText.
- platform/graphics/mac/ComplexTextController.h:
- platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Small style fix.
(WebCore::ComplexTextController::ComplexTextRun::createTextRunFromFontDataATSUI):
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):
- platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::ComplexTextRun::createTextRunFromFontDataCoreText):
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
- 03:32 Changeset [52066] by
-
2009-12-13 Christian Dywan <christian@twotoasts.de>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=31014
[Gtk] Build fails with gtk+-2.10 (no tested with older releases)
Guard GTK+ 2.12 specific tooltip code with #ifdef.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
- 01:31 Changeset [52065] by
-
2009-12-13 Simon Hausmann <hausmann@webkit.org>
Reviewed by Holger Freyther.
[Qt] Re-enable QWebView::renderHints property for Qt for Symbian
The bug in Qt's moc that triggered a linking error when declaring this
property has been fixed and we can remove the workaround.
- Api/qwebview.h:
- 00:44 Changeset [52064] by
-
2009-12-13 Eric Carlson <eric.carlson@apple.com>
No review, rolling out r52059 until I can generate new Tiger
test results.
- rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):
2009-12-13 Eric Carlson <eric.carlson@apple.com>
No review, rolling out r52059 until I can generate new Tiger test
results.
- platform/mac-leopard/Skipped:
- platform/mac-leopard/media/controls-after-reload-expected.txt:
- platform/mac-leopard/media/controls-drag-timebar-expected.txt:
- platform/mac-leopard/media/controls-strict-expected.txt:
- platform/mac-leopard/media/controls-styling-expected.txt:
- platform/mac-leopard/media/video-controls-rendering-expected.checksum:
- platform/mac-leopard/media/video-controls-rendering-expected.txt:
- platform/mac-leopard/media/video-display-toggle-expected.checksum:
- platform/mac-leopard/media/video-display-toggle-expected.txt:
- platform/mac-leopard/media/video-no-audio-expected.txt:
- platform/mac-leopard/media/video-zoom-controls-expected.checksum:
- platform/mac-leopard/media/video-zoom-controls-expected.txt:
- platform/mac/media/audio-controls-rendering-expected.checksum:
- platform/mac/media/video-zoom-expected.checksum:
12/12/09:
- 20:45 Changeset [52063] by
-
Rubber-stamped by Dan Bernstein.
Fix the EXPERIMENTAL_SINGLE_VIEW_MODE build.
- Configurations/WebCore.xcconfig:
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clearDragState):
- page/mac/DragControllerMac.mm:
(WebCore::DragController::isCopyKeyDown):
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::eventActivatedView):
- platform/PlatformKeyboardEvent.h:
- platform/PlatformMouseEvent.h:
- platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/mac/KeyEventMac.mm:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- platform/mac/PlatformMouseEventMac.mm:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
- platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::show):
- platform/mac/WidgetMac.mm:
- 20:26 Changeset [52062] by
-
2009-12-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Enable Web-hosted version of SunSpider to handle multiple versions
https://bugs.webkit.org/show_bug.cgi?id=32478
- make-hosted: Now generate the hosted version to be able to run both the 0.9 and the 0.9.1 test suites.
- hosted: Modified property svn:ignore.
- hosted/sunspider-driver.html: Removed.
- hosted/sunspider-results.html: Removed.
- hosted/sunspider.html:
- hosted/versions.html: Added.
- resources/TEMPLATE.html:
- resources/driver-TEMPLATE.html: Copied from hosted/sunspider-driver.html.
- resources/driver-TEMPLATE.html: Copied from hosted/sunspider-results.html.
- 19:59 Changeset [52061] by
-
Rubber-stamped by Dan Bernstein.
Fix the !ENABLE(VIDEO) build.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
- 19:56 Changeset [52060] by
-
Rubber-stamped by Dan Bernstein.
Fix the !ENABLE(DATABASE) build.
- storage/SQLTransactionClient.cpp:
- storage/SQLTransactionClient.h:
- storage/SQLTransactionCoordinator.cpp:
- storage/SQLTransactionCoordinator.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
- 19:28 Changeset [52059] by
-
2009-12-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows
Use MediaControllerThemeQuickTime on Leopard.
- rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):
2009-12-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows
Regenerate layout and pixel test results for the new UI.
- platform/mac-leopard/Skipped:
- platform/mac-leopard/media/controls-after-reload-expected.txt:
- platform/mac-leopard/media/controls-drag-timebar-expected.txt:
- platform/mac-leopard/media/controls-strict-expected.txt:
- platform/mac-leopard/media/controls-styling-expected.txt:
- platform/mac-leopard/media/video-controls-rendering-expected.checksum:
- platform/mac-leopard/media/video-controls-rendering-expected.png:
- platform/mac-leopard/media/video-controls-rendering-expected.txt:
- platform/mac-leopard/media/video-display-toggle-expected.checksum:
- platform/mac-leopard/media/video-display-toggle-expected.png:
- platform/mac-leopard/media/video-display-toggle-expected.txt:
- platform/mac-leopard/media/video-no-audio-expected.txt:
- platform/mac-leopard/media/video-zoom-controls-expected.checksum:
- platform/mac-leopard/media/video-zoom-controls-expected.png:
- platform/mac-leopard/media/video-zoom-controls-expected.txt:
- platform/mac/media/audio-controls-rendering-expected.checksum:
- platform/mac/media/audio-controls-rendering-expected.png:
- platform/mac/media/video-zoom-expected.checksum:
- platform/mac/media/video-zoom-expected.png:
- 19:02 Changeset [52058] by
-
2009-12-12 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Errors in WebGL[T]Array set() and get() methods
https://bugs.webkit.org/show_bug.cgi?id=32456
Test: fast/canvas/webgl/bug-32456.html
- fast/canvas/webgl/array-unit-tests.html:
- fast/canvas/webgl/bug-32456-expected.txt: Added.
- fast/canvas/webgl/bug-32456.html: Added.
2009-12-12 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Errors in WebGL[T]Array set() and get() methods
https://bugs.webkit.org/show_bug.cgi?id=32456
Test: fast/canvas/webgl/bug-32456.html
- bindings/js/JSWebGLFloatArrayCustom.cpp: (WebCore::JSWebGLFloatArray::set):
- bindings/js/JSWebGLIntArrayCustom.cpp: (WebCore::JSWebGLIntArray::set):
- bindings/js/JSWebGLShortArrayCustom.cpp: (WebCore::JSWebGLShortArray::set):
- bindings/js/JSWebGLUnsignedByteArrayCustom.cpp: (WebCore::JSWebGLUnsignedByteArray::set):
- bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: (WebCore::JSWebGLUnsignedIntArray::set):
- bindings/js/JSWebGLUnsignedShortArrayCustom.cpp: (WebCore::JSWebGLUnsignedShortArray::set):
- bindings/v8/custom/V8WebGLArrayCustom.h: (WebCore::setWebGLArray):
- html/canvas/WebGLFloatArray.idl:
- html/canvas/WebGLUnsignedIntArray.idl:
- 18:18 Changeset [52057] by
-
2009-12-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Give command-line sunspider the ability to handle multiple suites and versions
https://bugs.webkit.org/show_bug.cgi?id=32477
- Scripts/run-sunspider: Updated for changes to command-line parameters.
- Scripts/sunspider-compare-results: ditto
2009-12-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Give command-line sunspider the ability to handle multiple suites and versions
https://bugs.webkit.org/show_bug.cgi?id=32477
Each suite/version's set of tests are now in a separate subdirectory of tests/, with a file named LIST
enumerating the tests. Current suites are:
sunspider-0.9 - riginal SunSpider content
sunspider-0.9.1 - SunSpider suite with a few tests fixed (and a few more to come)
ubench - "ubench" microbenchmark suite
v8-v4 - version 4 of the v8 benchmark
parse-only - some parser tests
Sunspider can now be run with the --suite= parameter to select a
suite. The default is --suite=sunspider-0.9.
- .: Modified property svn:ignore to ignore new results directories.
- make-hosted: Generate based on sunspider-0.9 suite.
- resources/TEMPLATE.html: Fix an HTML compliance problem.
- resources/sunspider-standalone-driver.js: Become aware of suite names.
- sunspider: Modified to handle multiple suites as described above.
- sunspider-compare-results: ditto
- tests/LIST: Moved to tests/sunspider-0.9/ and tests/sunspider-0.9.1/
- tests/LIST-PARSE-ONLY: Moved to parse-only/LIST
- tests/LIST-UBENCH: Removed.
- tests/LIST-V8: Removed.
- tests/3d-cube.js: Moved to tests/sunspider-0.9 and tests/sunspider-0.9.1
- tests/3d-morph.js: ditto
- tests/3d-raytrace.js: ditto
- tests/access-binary-trees.js: ditto
- tests/access-fannkuch.js: ditto
- tests/access-nbody.js: ditto
- tests/access-nsieve.js: ditto
- tests/bitops-3bit-bits-in-byte.js: ditto
- tests/bitops-bits-in-byte.js: ditto
- tests/bitops-bitwise-and.js: ditto
- tests/bitops-nsieve-bits.js: ditto
- tests/controlflow-recursive.js: ditto
- tests/crypto-aes.js: ditto
- tests/crypto-md5.js: ditto
- tests/crypto-sha1.js: ditto
- tests/date-format-tofte.js: ditto
- tests/date-format-xparb.js: ditto
- tests/math-cordic.js: ditto
- tests/math-partial-sums.js: ditto
- tests/math-spectral-norm.js: ditto
- tests/regexp-dna.js: ditto
- tests/string-base64.js: ditto
- tests/string-fasta.js: ditto
- tests/string-tagcloud.js: ditto
- tests/string-unpack-code.js: ditto
- tests/string-validate-input.js: ditto
- tests/sunspider-0.9/: Added
- tests/sunspider-0.9/*.js: Moved from one level up
- tests/sunspider-0.9.1: Added.
- tests/sunspider-0.9.1/*.js: Moved from one level up.
- tests/v8-crypto.js: Moved to v8-v4/ directory.
- tests/v8-deltablue.js: ditto
- tests/v8-earley-boyer.js: ditto
- tests/v8-raytrace.js: ditto
- tests/v8-regexp.js: ditto
- tests/v8-richards.js: ditto
- tests/v8-splay.js: ditto
- tests/v8-v4: Added.
- 15:12 Changeset [52056] by
-
2009-12-12 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Update WebGL tests to released versions
https://bugs.webkit.org/show_bug.cgi?id=32457
- fast/canvas/webgl/resources/utils3d.js: (initWebGL.gl.console.window.console.log): (initWebGL): (loadShader): (makeBox): (makeSphere): (processLoadObj): (doLoadObj): (doLoadImageTexture):
2009-12-12 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Update WebGL tests to released versions
https://bugs.webkit.org/show_bug.cgi?id=32457
- manual-tests/webgl/Earth.html:
- manual-tests/webgl/ManyPlanetsDeep.html:
- manual-tests/webgl/SpinningBox.html:
- manual-tests/webgl/TeapotPerPixel.html:
- manual-tests/webgl/TeapotPerVertex.html:
- manual-tests/webgl/resources/CanvasMatrix.js: (CanvasMatrix4.prototype.getAsWebGLFloatArray):
- manual-tests/webgl/resources/utils3d.js: (initWebGL.gl.console.window.console.log): (initWebGL): (loadShader): (makeBox): (makeSphere): (processLoadObj): (doLoadObj): (doLoadImageTexture):
- 13:29 Changeset [52055] by
-
2009-12-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/7453726> Pull shared UI code into WebKit
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
2009-12-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/7453726> Pull shared UI code into WebKit
Update media tests for small change in timeline slider thumb position
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-styling-expected.txt:
- platform/mac/media/video-no-audio-expected.txt:
- platform/mac/media/video-zoom-controls-expected.txt:
- 11:10 Changeset [52054] by
-
2009-12-12 Christian Dywan <christian@twotoasts.de>
Reviewed by Dirk Schulze.
Remove the include to SVGFEDisplacementMap.h, it's not needed at all.
- platform/graphics/filters/FEComponentTransfer.h:
- 10:32 Changeset [52053] by
-
Not reviewed, fixing previous comment.
Remove accidental change to sunspider-compare-results
- Scripts/sunspider-compare-results:
- 10:24 Changeset [52052] by
-
2009-12-12 Christian Dywan <christian@twotoasts.de>
Rubber-stamped by Maciej Stachowiak.
Only include SVGFEDisplacementMap.h if SVG is enabled.
- platform/graphics/filters/FEComponentTransfer.h:
- 09:52 Changeset [52051] by
-
2009-12-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Unify codegen for forward and backward variants of branches
https://bugs.webkit.org/show_bug.cgi?id=32463
- jit/JIT.h: (JSC::JIT::emit_op_loop): Implemented in terms of forward variant. (JSC::JIT::emit_op_loop_if_true): ditto (JSC::JIT::emitSlow_op_loop_if_true): ditto (JSC::JIT::emit_op_loop_if_false): ditto (JSC::JIT::emitSlow_op_loop_if_false): ditto (JSC::JIT::emit_op_loop_if_less): ditto (JSC::JIT::emitSlow_op_loop_if_less): ditto
- jit/JITOpcodes.cpp:
- 09:14 Changeset [52050] by
-
2009-12-11 Christian Dywan <christian@twotoasts.de>
Reviewed by Eric Seidel.
[GTK] Build with --disable-svg is broken
http://bugs.webkit.org/show_bug.cgi?id=32361
- webkit/webkitwebframe.cpp: (webkit_web_frame_pause_svg_animation): Fix ENABLE(SVG) guards.
- 02:20 Changeset [52049] by
-
2009-12-12 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
[Cairo][Qt] Alpha blending in SVG filters is wrong
https://bugs.webkit.org/show_bug.cgi?id=32427
This patch is a follow-up to:
http://trac.webkit.org/changeset/51950
It fixes the alpha blending for Cairo and Qt on SVG Filters.
Covered by: * LayoutTests/svg/filters/feGaussianBlur.svg
- LayoutTests/svg/filters/feComposite.svg and others.
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
- 02:13 Changeset [52048] by
-
[Qt] Missing forward entries when dumping back/forward list
https://bugs.webkit.org/show_bug.cgi?id=32470
Failing tests added to skiplist until bug fixed.
- platform/qt/Skipped:
- http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html added
- http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html added
12/11/09:
- 23:20 Changeset [52047] by
-
Rolled out my last patch because the bots were crashing
- 22:30 Changeset [52046] by
-
Allow WTFs concept of the main thread to differ from pthreads when necessary.
Reviewed by Anders Carlsson.
- wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
(WTF::isMainThread):
- wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
- 22:22 Changeset [52045] by
-
Windows build fix: Export some new symbols.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 22:08 QtWebKit/CodeCamp200912 edited by
- Add another talk. I don't remember the name of this guy though. (diff)
- 22:02 Changeset [52044] by
-
Windows build fix: Removed an incorrect #ifdef.
- bindings/js/GCController.cpp:
- 21:50 Changeset [52043] by
-
Unreviewed build fix.
[V8] Add a method on ScriptController to get it compiling after http://trac.webkit.org/changeset/52033.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::anyPageIsProcessingUserGesture):
- bindings/v8/ScriptController.h:
- 21:49 Changeset [52042] by
-
Windows build fix: Removed some old exports.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 21:39 Changeset [52041] by
-
Windows build fix: Use unsigned instead of uint32_t to avoid dependencies.
- wtf/StdLibExtras.h:
(WTF::bitCount):
- 21:29 Changeset [52040] by
-
JavaScriptCore: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
Added WeakGCMap to keep WebCore blissfully ignorant about objects that
have become garbage but haven't run their destructors yet.
1% SunSpider speedup.
7.6% v8 speedup (37% splay speedup).
17% speedup on bench-alloc-nonretained.js.
18% speedup on bench-alloc-retained.js.
- API/JSBase.cpp:
(JSGarbageCollect):
- API/JSContextRef.cpp:
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj: Updated for renames and new
files.
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions): Updated to use the Collector
iterator abstraction.
- jsc.cpp:
(functionGC): Updated for rename.
- runtime/Collector.cpp: Slightly reduced the number of allocations per
collection, so that small workloads only allocate on collector block,
rather than two.
(JSC::Heap::Heap): Updated to use the new allocateBlock function.
(JSC::Heap::destroy): Updated to use the new freeBlocks function.
(JSC::Heap::allocateBlock): New function to initialize a block when
allocating it.
(JSC::Heap::freeBlock): Consolidated the responsibility for running
destructors into this function.
(JSC::Heap::freeBlocks): Updated to use freeBlock.
(JSC::Heap::recordExtraCost): Sweep the heap in this reporting function,
so that allocation, which is more common, doesn't have to check extraCost.
(JSC::Heap::heapAllocate): Run destructors right before recycling a
garbage cell. This has better cache utilization than a separate sweep phase.
(JSC::Heap::resizeBlocks):
(JSC::Heap::growBlocks):
(JSC::Heap::shrinkBlocks): New set of functions for managing the size of
the heap, now that the heap doesn't maintain any information about its
size.
(JSC::isPointerAligned):
(JSC::isHalfCellAligned):
(JSC::isPossibleCell):
(JSC::isCellAligned):
(JSC::Heap::markConservatively): Cleaned up this code a bit.
(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells): Some helper functions for examining the the mark
bitmap.
(JSC::Heap::sweep): Simplified this function by using a DeadObjectIterator.
(JSC::Heap::markRoots): Reordered some operations for clarity.
(JSC::Heap::objectCount):
(JSC::Heap::addToStatistics):
(JSC::Heap::statistics): Rewrote these functions to calculate an object
count on demand, since the heap doesn't maintain this information by
itself.
(JSC::Heap::reset): New function for resetting the heap once we've
exhausted heap space.
(JSC::Heap::collectAllGarbage): This function matches the old collect()
behavior, but it's now an uncommon function used only by API.
- runtime/Collector.h:
(JSC::CollectorBitmap::count):
(JSC::CollectorBitmap::isEmpty): Added some helper functions for managing
the collector mark bitmap.
(JSC::Heap::reportExtraMemoryCost): Changed reporting from cell equivalents
to bytes, so it's easier to understand.
- runtime/CollectorHeapIterator.h:
(JSC::CollectorHeapIterator::CollectorHeapIterator):
(JSC::CollectorHeapIterator::operator!=):
(JSC::CollectorHeapIterator::operator*):
(JSC::CollectorHeapIterator::advance):
(JSC::::LiveObjectIterator):
(JSC::::operator):
(JSC::::DeadObjectIterator):
(JSC::::ObjectIterator): New iterators for encapsulating details about
heap layout, and what's live and dead on the heap.
- runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength): Delay reporting extra cost until
we're fully constructed, so the heap mark phase won't visit us in an
invalid state.
- runtime/JSCell.h:
(JSC::JSCell::):
(JSC::JSCell::createDummyStructure):
(JSC::JSCell::JSCell):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h: Added a dummy cell to simplify allocation logic.
- runtime/JSString.h:
(JSC::jsSubstring): Don't report extra cost for substrings, since they
share a buffer that's already reported extra cost.
- runtime/Tracing.d:
- runtime/Tracing.h: Changed these dtrace hooks not to report object
counts, since they're no longer cheap to compute.
- runtime/UString.h: Updated for renames.
- runtime/WeakGCMap.h: Added.
(JSC::WeakGCMap::isEmpty):
(JSC::WeakGCMap::uncheckedGet):
(JSC::WeakGCMap::uncheckedBegin):
(JSC::WeakGCMap::uncheckedEnd):
(JSC::::get):
(JSC::::take):
(JSC::::set):
(JSC::::uncheckedRemove): Mentioned above.
- wtf/StdLibExtras.h:
(WTF::bitCount): Added a bit population count function, so the heap can
count live objects to fulfill statistics questions.
JavaScriptGlue: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
- JavaScriptGlue.cpp:
(JSCollect): Updated for rename. Fixed a bug where JSGlue would not check
to avoid nested GC calls.
WebCore: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
- ForwardingHeaders/runtime/WeakGCMap.h: Added.
- bindings/js/GCController.cpp:
(WebCore::collect):
(WebCore::GCController::gcTimerFired):
(WebCore::GCController::garbageCollectNow): Updated for rename.
- bindings/js/JSDOMBinding.cpp:
(WebCore::removeWrappers):
(WebCore::hasCachedDOMObjectWrapperUnchecked):
(WebCore::hasCachedDOMObjectWrapper):
(WebCore::hasCachedDOMNodeWrapperUnchecked):
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
(WebCore::isObservableThroughDOM):
(WebCore::markDOMNodesForDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::markDOMNodeWrapper):
- bindings/js/JSDOMBinding.h: Changed DOM wrapper maps to be WeakGCMaps.
Don't ASSERT that an item must be in the WeakGCMap when its destructor
runs, since it might have been overwritten in the map first.
- bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS): Changed Document from a DOM object wrapper to a DOM node
wrapper, to simplify some code.
- bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
(WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper):
- bindings/js/JSInspectorCallbackWrapper.cpp: Use a WeakGCMap for these
wrappers.
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren): Updated for WeakGCMap and Document using
a DOM node wrapper instead of a DOM object wrapper.
- bindings/js/JSSVGPODTypeWrapper.h:
(WebCore::JSSVGDynamicPODTypeWrapperCache::wrapperMap):
(WebCore::JSSVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
(WebCore::JSSVGDynamicPODTypeWrapperCache::forgetWrapper):
(WebCore::::~JSSVGDynamicPODTypeWrapper): Shined a small beam of sanity
on this code. Use hashtable-based lookup in JSSVGPODTypeWrapper.h instead
of linear lookup through iteration, since that's what hashtables were
invented for. Make JSSVGPODTypeWrapper.h responsible for reomving itself
from the table, instead of its JS wrapper, to decouple these objects from
GC, and because these objects are refCounted, not solely owned by their
JS wrappers.
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.h: Adopted changes above.
- 20:56 Changeset [52039] by
-
2009-12-11 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, build fix.
[V8] Change bindings to catch up with http://trac.webkit.org/changeset/52033.
- bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Added retrieval of calling frame and passing to the submit method.
- 18:43 Changeset [52038] by
-
Put -umbrella linker flag into a variable so that it can be overridden.
Reviewed by Mark Rowe.
- Configurations/WebCore.xcconfig:
- 18:31 Changeset [52037] by
-
WebKit/qt: Unreviewed build fix for Qt versions < 4.6.
- tests/qwebframe/tst_qwebframe.cpp:
- tests/qwebview/tst_qwebview.cpp:
WebKitTools: Unreviewed build fix for Qt versions < 4.6.
Guard every slot individually with #ifdef.
- DumpRenderTree/qt/EventSenderQt.cpp:
- DumpRenderTree/qt/EventSenderQt.h:
- 17:50 Changeset [52036] by
-
2009-12-11 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
body with display:inline causes crash
https://bugs.webkit.org/show_bug.cgi?id=32371
- fast/inline/inline-body-crash-expected.txt: Copied from LayoutTests/fast/css-generated-content/absolute-position-inside-inline-expected.txt.
- fast/inline/inline-body-crash.html: Added.
- fast/inline/inline-body-with-scrollbar-crash-expected.txt: Copied from LayoutTests/fast/css-generated-content/absolute-position-inside-inline-expected.txt.
- fast/inline/inline-body-with-scrollbar-crash.html: Added.
2009-12-11 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
body with display:inline causes crash
https://bugs.webkit.org/show_bug.cgi?id=32371
Tests: fast/inline/inline-body-crash.html
fast/inline/inline-body-with-scrollbar-crash.html
- page/FrameView.cpp: (WebCore::FrameView::createScrollbar): (WebCore::FrameView::layout):
- 17:40 Changeset [52035] by
-
Rubberstamped by Sam Weinig.
https://webkit.org/b/22851 - Remove defunct FIXME.
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::HTMLPlugInElement): This flag was removed completely
from the HTMLFrameOwnerElement chain of classes.
- 17:38 Changeset [52034] by
-
Small refactoring to get rid of some extra unneeded selection-related work
in RenderLayer::scrollToOffset and separate caret and range selection
logic in FrameView::layout. This may be useful later when changing how
the range selection logic works to fix layout reentrancy problems.
Reviewed by Dan Bernstein.
- page/Frame.cpp: Removed invalidateSelection.
- page/Frame.h: Ditto.
- page/FrameView.cpp:
(WebCore::FrameView::layout): Call SelectionController::setNeedsLayout
and Frame::selectionLayoutChanged instead of calling
Frame::invalidateSelection, which was just a function that called
both of those others.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset): Call
SelectionController::setNeedsLayout instead of calling
Frame::invalidateSelection. This call site only needs the caret-related
work in that first function, not the other work formerly done by
Frame::invalidateSelection. The caret works outside the normal
painting and rendering system, and the range selection highlight is
more or less inside it and doesn't need special handling when scrolling.
- 17:34 Changeset [52033] by
-
<rdar://problem/7342725> and https://webkit.org/b/32383
Selecting article text at sfgate.com results in spurious back/forward entries
Reviewed by Darin Adler.
WebCore:
If an iframe had a form and that form is submitted by javascript, IE and Opera don't add back/forward entries.
In the case where the frame was added dynamically via createElement(), Firefox would like to add a back entry
but has a bug that prevents this.
Therefore by a bizarre coincidence, WebKit is the loner and the only engine affected by sfgate.com's technique.
This patch changes us to willfully match IE and Opera and fixes sfgate.com in the process.
Tests: http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html
http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html
Capture whether the form was submitted by javascript:
- loader/FormState.cpp:
(WebCore::FormState::FormState):
(WebCore::FormState::create):
- loader/FormState.h:
(WebCore::FormState::formSubmissionTrigger):
When deciding the value of the lockBackForwardList variable, take formSubmissionTrigger() into account:
- loader/RedirectScheduler.cpp:
(WebCore::RedirectScheduler::scheduleFormSubmission):
Rearrange the public HTMLFormElement::submit() method to be called only from DOM or JS bindings,
and figure out the rest of the parameters for an internal submit() call including the formSubmissionTrigger:
- bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::submit):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::prepareSubmit):
(WebCore::HTMLFormElement::submit):
- html/HTMLFormElement.h:
LayoutTests:
- http/tests/navigation/dynamic-iframe-dynamic-form-back-entry-expected.txt: Added.
- http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html: Added.
- http/tests/navigation/parsed-iframe-dynamic-form-back-entry-expected.txt: Added.
- http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html: Added.
- http/tests/navigation/resources/notify-done.html: Added.
- http/tests/navigation/onload-navigation-iframe-timeout-expected.txt: Updated.
- 17:10 Changeset [52032] by
-
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32445
REGRESSION: http://www.mcafee.com/japan/ displays unstyled
- css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet): Add a quirk for mcafee.com/japan (http or https, with or without www).
- 17:09 Changeset [52031] by
-
Make PlatformWheelEvent.h private instead of project.
Reviewed by Dan Bernstein.
- WebCore.xcodeproj/project.pbxproj:
- 16:39 Changeset [52030] by
-
Added icons for full-screen video on Windows
https://bugs.webkit.org/show_bug.cgi?id=31318
- 15:49 Changeset [52029] by
-
2009-12-11 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Support reflections on composited layers
https://bugs.webkit.org/show_bug.cgi?id=31885
First part of supporting composited reflections on compositing layers.
Rename the m_transformLayer member variable to m_structuralLayer, since it
will get used both for transform layers (for preserve-3d) and to hold a flattening
layer related to reflections, both of which have similar requirements, and are
mutually exclusive.
- platform/graphics/mac/GraphicsLayerCA.h: primaryLayer(), hostLayerForSublayers() and layerForSuperlayer() all now return a CALayer, since m_structuralLayer isn't always a WebLayer.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::commitLayerChanges): updateLayerPreserves3D() renamed to updateStructuralLayer()
(WebCore::GraphicsLayerCA::updateLayerNames):
New "update" method for updating layer names.
(WebCore::GraphicsLayerCA::updateSublayerList):
m_transformLayer -> m_structuralLayer. Also minor refactor to only
allocate newSublayers in one place.
(WebCore::GraphicsLayerCA::updateLayerSize):
(WebCore::GraphicsLayerCA::removeAnimationFromLayer):
(WebCore::GraphicsLayerCA::hostLayerForSublayers):
(WebCore::GraphicsLayerCA::layerForSuperlayer):
m_transformLayer -> m_structuralLayer
(WebCore::GraphicsLayerCA::updateStructuralLayer):
Call ensureStructuralLayer() which handles any deltas to the
structural layer type.
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
Handle changes to the structural layer requirements
(WebCore::GraphicsLayerCA::structuralLayerPurpose):
Return an enum describing the purpose of the structural layer; for now
this only returns NoStructuralLayer or StructuralLayerForPreserves3D, but
will in future also have a value related to reflections.
- 15:34 Changeset [52028] by
-
https://bugs.webkit.org/show_bug.cgi?id=32454
Refactor construction of simple strings to avoid string concatenation.
Reviewed by Oliver Hunt.
Building strings through concatenation has a memory and performance cost -
a memory cost since we must over-allocate the buffer to leave space to append
into, and performance in that the string may still require reallocation (and
thus copying during construction). Instead move the full construction to
within a single function call (makeString), so that the arguments' lengths
can be calculated and an appropriate sized buffer allocated before copying
any characters.
~No performance change (~2% progression on date tests).
- bytecode/CodeBlock.cpp:
(JSC::escapeQuotes):
(JSC::valueToSourceString):
(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpToSourceString):
(JSC::regexpName):
- bytecompiler/NodesCodegen.cpp:
(JSC::substitute):
- profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
- runtime/DateConstructor.cpp:
(JSC::callDate):
- runtime/DateConversion.cpp:
(JSC::formatDate):
(JSC::formatDateUTCVariant):
(JSC::formatTime):
(JSC::formatTimeUTC):
- runtime/DateConversion.h:
(JSC::):
- runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToGMTString):
- runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
- runtime/ExceptionHelpers.cpp:
(JSC::createUndefinedVariableError):
(JSC::createErrorMessage):
(JSC::createInvalidParamError):
- runtime/FunctionPrototype.cpp:
(JSC::insertSemicolonIfNeeded):
(JSC::functionProtoFuncToString):
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
- runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::match):
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
- runtime/UString.h:
(JSC::):
(JSC::makeString):
- 15:03 Changeset [52027] by
-
2009-12-11 Nate Chapin <japhet@chromium.org>
Reviewed by Darin Fisher.
Expose shouldHideReferrer() in WebSecurityPolicy.
- public/WebSecurityPolicy.h: Add shouldHideReferrer().
- src/WebSecurityPolicy.cpp:
- (WebKit
- WebSecurityPolicy::shouldHideReferrer): Added.
- 14:57 Changeset [52026] by
-
https://bugs.webkit.org/show_bug.cgi?id=32400
Switch remaining cases of string addition to use ropes.
Reviewed by Oliver Hunt.
Re-landing r51975 - added toPrimitiveString method,
performs toPrimitive then subsequent toString operations.
~1% progression on Sunspidey.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/JSString.h:
(JSC::JSString::JSString):
(JSC::JSString::appendStringInConstruct):
- runtime/Operations.cpp:
(JSC::jsAddSlowCase):
- runtime/Operations.h:
(JSC::jsString):
(JSC::jsAdd):
- 14:39 Changeset [52025] by
-
2009-12-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
CommandsTest.assert_execute_outputs doesn't check stderr
https://bugs.webkit.org/show_bug.cgi?id=32352
Fix assert_execute_outputs to check stderr
and then fix all the unit tests which needed to
pass stderr output.
- Scripts/modules/commands/commandtest.py:
- Scripts/modules/commands/download_unittest.py:
- Scripts/modules/commands/upload_unittest.py:
- 14:29 Changeset [52024] by
-
Versioning.
- 14:28 Changeset [52023] by
-
New tag.
- 13:50 Changeset [52022] by
-
2009-12-11 Simon Fraser <simon.fraser@apple.com>
Build fix for platforms where ACCELERATED_COMPOSITING is not defined.
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::pauseAnimation):
- 13:35 Changeset [52021] by
-
2009-12-11 Simon Fraser <simon.fraser@apple.com>
Build fix, no review.
Build fix for platforms where ACCELERATED_COMPOSITING is not defined.
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::startAnimation):
- 13:31 Changeset [52020] by
-
Windows build fix
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added
$(WebKitOutputDir)/include/private to the include path.
WebCore:
- platform/graphics/win/WKCACFLayerRenderer.cpp: Removed #include of
non-existent header.
- 13:24 Changeset [52019] by
-
2009-12-11 Simon Fraser <simon.fraser@apple.com>
Build fix, no review.
Build fix for platforms where ACCELERATED_COMPOSITING is not defined.
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::startAnimation):
- 13:02 Changeset [52018] by
-
2009-12-11 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Negative values for animation-delay are ignored (treated as zero)
https://bugs.webkit.org/show_bug.cgi?id=26150
When we get the m_startTime for an animation or transition, subtract any negative
delay so the animation/transition behaves like it started in the past, per spec.
Tests: animations/negative-delay.html
transitions/negative-delay.html
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
- 12:57 Changeset [52017] by
-
2009-12-11 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Accelerated transitions broken when mixed with paused animations
https://bugs.webkit.org/show_bug.cgi?id=32387
Synchronization of a mixture of accelerated and software animations occurs via
a callback from GraphicsLayerCA, which ends up in
AnimationControllerPrivate::receivedStartTimeResponse(). The time passed in is
the exact time at which the accelerated animations started, so is used as the
start time for all animations and transitions which are marked as waiting.
The bug was that the callback called when re-starting animations that were
paused sent back an old time value, but this was used to start normal
transitions. Therefore the transition would start with a stale start time, and
thus end prematurely.
The fix is to change the way that GraphicsLayerCA handles paused animations.
Rather than setting the beginTime of the animation, it uses a beginTime of 0
and a timeOffset that gets passed down. Thus the callbacks always come with
beginTime for 'now'.
Also clarify the role of AnimationBase::endAnimation() by splitting it into
pauseAnimation() and endAnimation(), and pass down timeOffsets, rather than
beginTimes when starting and pausing.
Manual test only, because the bug requires a non-trivial combination of
animation pausing and transitions which take time, and the bug only shows in
pixel results.
- manual-tests/animation/transitions-and-paused-animations.html
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
- page/animation/AnimationBase.h: (WebCore::AnimationBase::startAnimation): (WebCore::AnimationBase::pauseAnimation): (WebCore::AnimationBase::endAnimation):
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::~ImplicitAnimation): (WebCore::ImplicitAnimation::startAnimation): (WebCore::ImplicitAnimation::endAnimation): (WebCore::ImplicitAnimation::onAnimationEnd):
- page/animation/ImplicitAnimation.h: (WebCore::ImplicitAnimation::pauseAnimation):
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::~KeyframeAnimation): (WebCore::KeyframeAnimation::startAnimation): (WebCore::KeyframeAnimation::pauseAnimation): (WebCore::KeyframeAnimation::endAnimation): (WebCore::KeyframeAnimation::onAnimationEnd):
- page/animation/KeyframeAnimation.h:
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::addAnimation): (WebCore::GraphicsLayer::pauseAnimation):
- platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::LayerAnimation::LayerAnimation): (WebCore::GraphicsLayerCA::AnimationProcessingAction::AnimationProcessingAction):
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::addAnimation): (WebCore::GraphicsLayerCA::removeAnimationsForKeyframes): (WebCore::GraphicsLayerCA::pauseAnimation): (WebCore::GraphicsLayerCA::updateLayerAnimations): (WebCore::GraphicsLayerCA::setAnimationOnLayer): (WebCore::GraphicsLayerCA::pauseAnimationOnLayer): (WebCore::GraphicsLayerCA::createAnimationFromKeyframes): (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): (WebCore::RenderLayerBacking::startTransition): (WebCore::RenderLayerBacking::animationPaused):
- rendering/RenderLayerBacking.h:
- 12:50 Changeset [52016] by
-
2009-12-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[check-webkit-style] False positive for tst_QWebFrame
https://bugs.webkit.org/show_bug.cgi?id=32436
Add an exception for function names that start with "tst_". These are
used by the Qt unit testing framework.
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 12:46 Changeset [52015] by
-
Move QuartzCorePresent.h to include/private
This fixes other projects that use wtf/Platform.h
Rubber-stamped by Steve Falkenburg.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Let VS do its thang.
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Write
QuartzCorePresent.h to $(WebKitOutputDir)/include/private.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
Added $(WebKitOutputDir)/include/private to the include path.
- 12:38 Changeset [52014] by
-
2009-12-11 Drew Wilson <atwilson@chromium.org>
Reviewed by Darin Adler.
REGRESSION: fast/workers/dedicated-worker-lifecycle.html failing intermittently on leopard bot
https://bugs.webkit.org/show_bug.cgi?id=29344
dedicated-worker-lifecycle.html relies on a Worker object getting GC'd, which is never guaranteed (due to conservative GC)
but is especially unreliable on Leopard, so disabling on that platform.
- platform/mac-leopard/Skipped: disabled dedicated-worker-lifecycle.html.
- 12:30 Changeset [52013] by
-
Fix clean builds and everything rebuilding on every build
Reviewed by Sam Weinig.
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Don't
write out QuartzCorePresent.h if it exists but is older than
QuartzCore.h. Also, create the directory we write QuartzCorePresent.h
into first.
- 11:59 Changeset [52012] by
-
Fixes <http://webkit.org/b/32399>.
Pan Scrolling Jumps out of frames if the initial location is in a frame that can't be scrolled.
Reviewed by Darin Adler.
WebCore:
When we initially figure out the layer that we should begin scrolling, don't try to jump out
of frames/iFrames to look at the owner document. We don't want to jump out of frames, so we
don't need that logic anymore.
Added a test to make sure that we don't pan scroll if we start to scroll in an empty
iFrame that has a scrollable owner document.
Test: platform/win/fast/events/panScroll-no-iframe-jump.html
- dom/Node.cpp:
(WebCore::Node::defaultEventHandler):
LayoutTests:
Added a test to make sure that we don't pan scroll if we start to scroll in an empty
iFrame that has a scrollable owner document.
- platform/win/fast/events/panScroll-no-iframe-jump-expected.txt: Added.
- platform/win/fast/events/panScroll-no-iframe-jump.html: Added.
- 11:45 Changeset [52011] by
-
Windows build fix for systems with spaces in their paths
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Quote some paths.
- 11:33 Changeset [52010] by
-
Copy QuartzCore header file into Include/JavaScriptCore so Platform.h can find it.
- 11:10 Changeset [52009] by
-
Skip test that is failing because script is not executed after the
view it is on is destroyed.
See https://bugs.webkit.org/show_bug.cgi?id=32441
- platform/gtk/Skipped:
- 10:46 Changeset [52008] by
-
Fixes <http://webkit.org/b/32303>.
Middle-mouse button not firing mousedown DOM event when autoscroll happens.
Reviewed by Adam Roben.
WebCore:
This fix moves the pan scrolling code into Node.cpp, as part of the default event handler.
We get two wins out of this:
1) Mousedown DOM events are now fired before pan scrolling.
2) Calling event.preventDefault() on a middle mouse button will now prevent pan scrolling.
Added tests to show that middle mousedown DOM events are fired when panscrolling happens, and
that when event.preventDefault is called, pan scrolling doesn't happen.
Tests: platform/win/fast/events/panScroll-event-fired.html
platform/win/fast/events/panScroll-preventDefault.html
- dom/Node.cpp:
(WebCore::Node::defaultEventHandler): Moved pan scrolling starting code to here.
- page/EventHandler.cpp:
(WebCore::EventHandler::startPanScrolling): Function to initialize scrolling variables and start timer.
(WebCore::EventHandler::handleMousePressEvent): From here.
- page/EventHandler.h:
LayoutTests:
Added tests to show that middle mousedown DOM events are fired when panscrolling happens, and
that when event.preventDefault is called, pan scrolling doesn't happen.
- platform/win/fast/events/panScroll-event-fired-expected.txt: Added.
- platform/win/fast/events/panScroll-event-fired.html: Added.
- platform/win/fast/events/panScroll-preventDefault-expected.txt: Added.
- platform/win/fast/events/panScroll-preventDefault.html: Added.
- 10:31 Changeset [52007] by
-
forgot to save Changelog
- 10:29 Changeset [52006] by
-
Delay load DLLs for accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=31856
- 10:24 Changeset [52005] by
-
2009-12-11 Steve Block <steveblock@google.com>
Reviewed by Darin Fisher.
Adds an Android-specific implementation of initializeMaximumHTTPConnectionCountPerHost.
https://bugs.webkit.org/show_bug.cgi?id=31810
- platform/network/ResourceRequestBase.cpp: Modified. Disable default implementation
of initializeMaximumHTTPConnectionCountPerHost for Android.
- platform/network/android: Added.
- platform/network/android/ResourceRequestAndroid.cpp: Added. (WebCore::initializeMaximumHTTPConnectionCountPerHost): Android-specific implementation.
- 10:16 Changeset [52004] by
-
2009-12-11 Avi Drissman <avi@chromium.org>
Reviewed by Darin Fisher.
Tickmarks in the scrollbar are not cleared for non-main frames
https://bugs.webkit.org/show_bug.cgi?id=32385
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::stopFinding):
- 10:13 Changeset [52003] by
-
2009-12-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
Add acceptTypes() method to FileChooser.
https://bugs.webkit.org/show_bug.cgi?id=32429
This method returns an 'accept' attribute value of the
corresponding INPUT element. A ChromeClient::runOpenPanel()
implementation can refer it through a FileChooser instance to
support type-restricted file selecting.
This makes no user-visible changes for now.
- platform/FileChooser.h: (WebCore::FileChooser::acceptTypes):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::acceptTypes):
- rendering/RenderFileUploadControl.h:
- 10:06 Changeset [52002] by
-
[Qt][LayoutTestController] Output of document.write() is vanished by waitUntilDone()/notifyDone()
https://bugs.webkit.org/show_bug.cgi?id=32437
- platform/qt/Skipped: http/tests/misc/percent-sign-in-form-field-name.html added until bug fixed.
- 10:03 Changeset [52001] by
-
2009-12-11 Victor Wang <victorw@chromium.org>
Reviewed by Darin Fisher.
Changed PopupMenuChromium to keep the value selected from
keyboard when popup is closed.
The problem is Chromium does not fire the onchange event
when the popup is closed if an item is selected via
keyboard by typing the first char of the item. This makes
chromium popup not having consistent behaviours and also
behaves differently from other major browsers.
Calling popup->hide() instead of popup->hidePopup() in
PopupMenu fixes the issues as it does extra step to check
whethere there is a keyboard selection changed when closing
the popup.
TEST: add a manual test as the current layout test shell
does not support sending keyboard events to popup list.
- manual-tests/chromium/select-close-popup-value-change.html: Added.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupMenu::hide):
- 09:31 Changeset [52000] by
-
Skip two tests that require infrastructure our DRT doesn't have,
or functionality our port does not implement.
- platform/gtk/Skipped:
- 09:30 Changeset [51999] by
-
[Qt] Unreviewed. Skip a timeouter flakey test.
- platform/qt/Skipped: fast/frames/sandboxed-iframe-storage.html added.
- 09:21 Changeset [51998] by
-
2009-12-11 anton muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] refactor WeakReferenceMap.
Move common bits of functionality to reduce duplication.
Should be covered by buildbots.
- bindings/v8/DOMData.h: (WebCore::DOMData::WrapperMapObjectRemover::visitDOMWrapper): (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::removeObjectsFromWrapperMap):
- bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::weakDOMObjectCallback): (WebCore::DOMDataStore::weakActiveDOMObjectCallback): (WebCore::DOMDataStore::weakNodeCallback): (WebCore::DOMDataStore::weakSVGElementInstanceCallback): (WebCore::DOMDataStore::weakSVGObjectWithContextCallback):
- bindings/v8/DOMDataStore.h:
- bindings/v8/V8DOMMap.cpp: (WebCore::visitDOMNodesInCurrentThread): (WebCore::visitDOMObjectsInCurrentThread): (WebCore::visitActiveDOMObjectsInCurrentThread): (WebCore::visitDOMSVGElementInstancesInCurrentThread): (WebCore::visitSVGObjectsInCurrentThread):
- bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::removeIfPresent): (WebCore::WeakReferenceMap::clear): (WebCore::WeakReferenceMap::visit):
- 09:19 Changeset [51997] by
-
Rubber-stamped by Simon Hausmann.
[Qt] TouchEvent related tests have platform dependent results until all platform implement it.
- platform/qt/fast/dom/Window/window-properties-expected.txt: TouchEvent related output added.
- platform/qt/fast/dom/prototype-inheritance-expected.txt: TouchEvent related output added.
- platform/qt/fast/dom/prototype-inheritance.html: Removed. (added by mistake previously)
- platform/qt/fast/js/global-constructors-expected.txt: TouchEvent related output added.
- 09:15 Changeset [51996] by
-
Fixed typo in test result.
- platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt:
- 09:14 Changeset [51995] by
-
2009-12-11 anton muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] in Debug builds create an additional handle scope
when doing debug build checks.
https://bugs.webkit.org/show_bug.cgi?id=32335
Should be covered by buildbots.
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::convertDOMWrapperToNode):
- 09:07 Changeset [51994] by
-
Rubber-stamped by Simon Hausmann.
[Qt] TouchEvent related tests have platform dependent results until all platform implement it.
Original expected files copied.
- platform/qt/fast/dom/Window/window-properties-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-expected.txt.
- platform/qt/fast/dom/prototype-inheritance-expected.txt: Copied from LayoutTests/fast/dom/prototype-inheritance-expected.txt.
- platform/qt/fast/dom/prototype-inheritance.html: Copied from LayoutTests/fast/dom/prototype-inheritance.html.
- platform/qt/fast/js/global-constructors-expected.txt: Copied from LayoutTests/fast/js/global-constructors-expected.txt.
- 08:52 Changeset [51993] by
-
2009-12-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Do not use ContextMenuItem as value type in custom
context menu implementation.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::~InspectorFrontendHost): (WebCore::InspectorFrontendHost::showContextMenu): (WebCore::InspectorFrontendHost::contextMenuCleared):
- inspector/InspectorFrontendHost.h: (WebCore::InspectorFrontendHost::MenuProvider::create): (WebCore::InspectorFrontendHost::MenuProvider::~MenuProvider): (WebCore::InspectorFrontendHost::MenuProvider::disconnect): (WebCore::InspectorFrontendHost::MenuProvider::populateContextMenu): (WebCore::InspectorFrontendHost::MenuProvider::contextMenuCleared): (WebCore::InspectorFrontendHost::MenuProvider::MenuProvider):
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): (WebCore::ContextMenuController::clearContextMenu): (WebCore::ContextMenuController::showContextMenu): (WebCore::ContextMenuController::contextMenuItemSelected):
- page/ContextMenuController.h:
- page/ContextMenuProvider.h: Added. (WebCore::ContextMenuProvider::~ContextMenuProvider):
- page/ContextMenuSelectionHandler.h: Removed.
- 08:22 Changeset [51992] by
-
[Qt] Updated QWebElement documentation
Reviewed by Tor Arne Vestbø.
findAll() returns a QWebElementCollection, not QList<QWebElement>.
- 08:20 Changeset [51991] by
-
WebCore: Basic cross-platform implementation of mapping platform touch events
to JavaScript touch events.
Patch by Simon Hausmann <hausmann@webkit.org>, Kim Grönholm <kim.gronholm@nomovok.com> on 2009-12-11
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=32114
Test: fast/events/basic-touch-events.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):
- page/EventHandler.h:
WebKit/qt: Forward Qt touch events to the event handler as platform touch events.
Patch by Simon Hausmann <hausmann@webkit.org>, Kim Grönholm <kim.gronholm@nomovok.com> on 2009-12-11
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=32114
- Api/qwebpage.cpp:
(QWebPagePrivate::touchEvent):
(QWebPage::event):
- Api/qwebpage_p.h:
- 08:19 Changeset [51990] by
-
2009-12-11 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WebCore's EmptyFrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=32110
Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class EmptyFrameLoaderClient - svg/graphics/SVGImage.cpp:229
- loader/FrameLoaderClient.h:
- 08:17 Changeset [51989] by
-
2009-12-11 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for 3 classes in WebCore's svg and loader directory
https://bugs.webkit.org/show_bug.cgi?id=32106
Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:
class/struct name - instantiated at: WebCore/'location'
class EmptyContextMenuClient - instantiated at: svg/graphics/SVGImage.cpp:232
class EmptyDragClient - instantiated at: svg/graphics/SVGImage.cpp:237
class SVGImageChromeClient - instantiated at: svg/graphics/SVGImage.cpp:243
- svg/graphics/SVGImage.cpp:
- loader/EmptyClients.h:
- 07:51 Changeset [51988] by
-
Skip the touch tests on Windows (somehow that hunk got lost).
- platform/win/Skipped:
- 07:46 Changeset [51987] by
-
Added support for creating synthetic touch events with EventSender
in Qt's DumpRenderTree.
Patch by Simon Hausmann <hausmann@webkit.org>, Kim Grönholm <kim.gronholm@nomovok.com> on 2009-12-11
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=32114
- DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::addTouchPoint):
(EventSender::updateTouchPoint):
(EventSender::touchStart):
(EventSender::touchMove):
(EventSender::touchEnd):
(EventSender::clearTouchPoints):
(EventSender::releaseTouchPoint):
(EventSender::sendTouchEvent):
- DumpRenderTree/qt/EventSenderQt.h:
- 07:39 Changeset [51986] by
-
2009-12-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a problem that JSC::gregorianDateTimeToMS() returns a negative
value for a huge year value.
https://bugs.webkit.org/show_bug.cgi?id=32304
- wtf/DateMath.cpp: (WTF::dateToDaysFrom1970): Renamed from dateToDayInYear, and changed the return type to double. (WTF::calculateDSTOffset): Follow the dateToDaysFrom1970() change. (WTF::timeClip): Use maxECMAScriptTime. (JSC::gregorianDateTimeToMS): Follow the dateToDaysFrom1970() change.
2009-12-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a problem that JSC::gregorianDateTimeToMS() returns a negative
value for a huge year value.
https://bugs.webkit.org/show_bug.cgi?id=32304
- fast/js/date-daysfrom1970-overflow-expected.txt: Added.
- fast/js/date-daysfrom1970-overflow.html: Added.
- fast/js/script-tests/date-daysfrom1970-overflow.js: Added.
- 07:35 QtWebKit/CodeCamp200912 edited by
- (diff)
- 07:21 Changeset [51985] by
-
2009-12-11 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Darin Adler.
The values of RuntimeArray are not enumerable
https://bugs.webkit.org/show_bug.cgi?id=29005
The indices of RuntimeArray should be enumerated like for a regular array.
- platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
- platform/mac/fast/dom/wrapper-classes-objc.html:
2009-12-11 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Darin Adler.
The values of RuntimeArray are not enumerable
https://bugs.webkit.org/show_bug.cgi?id=29005
The indices of RuntimeArray should be enumerated like for a regular array.
- bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertyNames):
- bridge/runtime_array.h:
2009-12-11 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Darin Adler.
The values of RuntimeArray are not enumerable
https://bugs.webkit.org/show_bug.cgi?id=29005
- DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController arrayOfString]):
- 07:07 Changeset [51984] by
-
2009-12-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Remove obsolete message handling methods from WebDevTools* interfaces
- public/WebDevToolsAgent.h:
- public/WebDevToolsAgentClient.h:
- public/WebDevToolsFrontend.h:
- public/WebDevToolsFrontendClient.h:
- 06:38 Changeset [51983] by
-
2009-12-11 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] ImageDecoderQt: Fix retrieval of image file extensions
QImageReader only allows retrieving the format() before actually reading the image.
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::internalDecodeSize):
- 06:15 Changeset [51982] by
-
2009-12-11 Simon Hausmann <hausmann@webkit.org>
Reviewed by Antti Koivisto.
Added basic layout test for DOM touch events.
- fast/events/basic-touch-events-expected.txt: Added.
- fast/events/basic-touch-events.html: Added.
- fast/events/script-tests/basic-touch-events.js: Added. (appendEventLog): (verifyTouchEvent): (verifyTouchPoint): (singleTouchSequence): (multiTouchSequence): (touchTargets):
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
- 06:07 Changeset [51981] by
-
2009-12-11 Simon Hausmann <hausmann@webkit.org>, Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Antti Koivisto.
Added interfaces for touch event support in JavaScript.
The Touch, TouchEvent and TouchList interfaces come straight from
Android's copy of WebKit (eclaire branch).
The PlatformTouchEvent and PlatformTouchPoint code was written by
us.
No new tests added, we are just adding interfaces
with this patch.
- WebCore.pro:
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- dom/Document.cpp: (WebCore::Document::addListenerTypeIfNeeded):
- dom/Document.h: (WebCore::Document::):
- dom/Document.idl:
- dom/Element.h:
- dom/Element.idl:
- dom/Event.cpp: (WebCore::Event::isTouchEvent):
- dom/Event.h:
- dom/EventNames.h:
- dom/Touch.cpp: Added. (WebCore::contentsX): (WebCore::contentsY): (WebCore::Touch::Touch): (WebCore::Touch::updateLocation):
- dom/Touch.h: Added. (WebCore::Touch::create): (WebCore::Touch::frame): (WebCore::Touch::target): (WebCore::Touch::identifier): (WebCore::Touch::clientX): (WebCore::Touch::clientY): (WebCore::Touch::screenX): (WebCore::Touch::screenY): (WebCore::Touch::pageX): (WebCore::Touch::pageY):
- dom/Touch.idl: Added.
- dom/TouchEvent.cpp: Added. (WebCore::TouchEvent::TouchEvent): (WebCore::TouchEvent::initTouchEvent):
- dom/TouchEvent.h: Added. (WebCore::TouchEvent::create): (WebCore::TouchEvent::touches): (WebCore::TouchEvent::targetTouches): (WebCore::TouchEvent::changedTouches): (WebCore::TouchEvent::TouchEvent): (WebCore::TouchEvent::isTouchEvent):
- dom/TouchEvent.idl: Added.
- dom/TouchList.cpp: Added. (WebCore::TouchList::item):
- dom/TouchList.h: Added. (WebCore::TouchList::create): (WebCore::TouchList::length): (WebCore::TouchList::append): (WebCore::TouchList::TouchList):
- dom/TouchList.idl: Added.
- html/HTMLAttributeNames.in:
- html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- platform/PlatformTouchEvent.h: Added. (WebCore::PlatformTouchEvent::PlatformTouchEvent): (WebCore::PlatformTouchEvent::touchPoints):
- platform/PlatformTouchPoint.h: Added. (WebCore::PlatformTouchPoint::): (WebCore::PlatformTouchPoint::id): (WebCore::PlatformTouchPoint::state): (WebCore::PlatformTouchPoint::screenPos): (WebCore::PlatformTouchPoint::pos):
- platform/qt/PlatformTouchEventQt.cpp: Added. (WebCore::PlatformTouchEvent::PlatformTouchEvent):
- platform/qt/PlatformTouchPointQt.cpp: Added. (WebCore::PlatformTouchPoint::PlatformTouchPoint):
- 04:46 WebKit Team edited by
- Add Haiku and myself. (diff)
- 04:20 Changeset [51980] by
-
[Android] Add detachHistoryItem() to AndroidWebHistoryBridge. And the constructor takes
HistoryItem* now. As AndroidWebHistoryBridge holds a dumb pointer of HistoryItem and
HistoryItem holds a RefPtr of AndroidWebHistoryBridge, the dumb pointer needs to be cleared
when HistoryItem is deleted to avoid potential crash.
https://bugs.webkit.org/show_bug.cgi?id=32251
Patch by Grace Kloba <klobag@gmail.com> on 2009-12-11
Reviewed by Darin Adler.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::~HistoryItem):
- history/android/AndroidWebHistoryBridge.h:
(WebCore::AndroidWebHistoryBridge::AndroidWebHistoryBridge):
(WebCore::AndroidWebHistoryBridge::detachHistoryItem):
- 03:04 QtWebKit/CodeCamp200912 edited by
- (diff)
- 02:44 Changeset [51979] by
-
2009-12-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Pavel Feldman.
Log WebSocket error to Web Inspector console.
https://bugs.webkit.org/show_bug.cgi?id=32165
- websocket/tests/handshake-error-expected.txt:
- websocket/tests/handshake-fail-by-cross-origin-expected.txt:
- websocket/tests/handshake-fail-by-sub-protocol-mismatch-expected.txt:
2009-12-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Pavel Feldman.
Log WebSocket error to Web Inspector console.
https://bugs.webkit.org/show_bug.cgi?id=32165
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::appendToBuffer):
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::readHTTPHeaders): (WebCore::WebSocketHandshake::checkResponseHeaders):
- 02:09 QtWebKitFeatures46 edited by
- (diff)
- 00:31 QtWebKit/CodeCamp200912 edited by
- (diff)
- 00:06 QtWebKit/CodeCamp200912 edited by
- add bug links (diff)
12/10/09:
- 23:54 QtWebKit/CodeCamp200912 edited by
- Start documenting day 3 (diff)
- 23:51 QtWebKit/CodeCamp200912 edited by
- (diff)
- 19:42 Changeset [51978] by
-
2009-12-10 Adam Barth <abarth@webkit.org>
No review, rolling out r51975.
http://trac.webkit.org/changeset/51975
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- runtime/JSString.h: (JSC::JSString::JSString): (JSC::JSString::appendStringInConstruct):
- runtime/Operations.cpp: (JSC::jsAddSlowCase):
- runtime/Operations.h: (JSC::jsString): (JSC::jsAdd):
- 19:12 Changeset [51977] by
-
2009-12-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Mixed content shouldn't trigger for plug-ins without URLs
https://bugs.webkit.org/show_bug.cgi?id=32384
- http/tests/security/mixedContent/empty-url-plugin-in-frame-expected.txt: Added.
- http/tests/security/mixedContent/empty-url-plugin-in-frame.html: Added.
- http/tests/security/mixedContent/resources/frame-with-empty-url-plugin.html: Added.
2009-12-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Mixed content shouldn't trigger for plug-ins without URLs
https://bugs.webkit.org/show_bug.cgi?id=32384
These plug-ins cannot be controlled by active network attackers, so
there's no reason to trigger a mixed content warning.
Test: http/tests/security/mixedContent/empty-url-plugin-in-frame.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::isMixedContent):
- 18:22 Changeset [51976] by
-
Incorrect caching of prototype lookup with dictionary base
https://bugs.webkit.org/show_bug.cgi?id=32402
Reviewed by Gavin Barraclough
Make sure we don't add cached prototype lookup to the proto_list
lookup chain if the top level object is a dictionary.
- 18:07 Changeset [51975] by
-
https://bugs.webkit.org/show_bug.cgi?id=32400
Switch remaining cases of string addition to use ropes.
Reviewed by Oliver Hunt.
~1% progression on Sunspidey.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/JSString.h:
(JSC::JSString::JSString):
(JSC::JSString::appendStringInConstruct):
- runtime/Operations.cpp:
(JSC::jsAddSlowCase):
- runtime/Operations.h:
(JSC::jsString):
(JSC::jsAdd):
- 16:58 Changeset [51974] by
-
Unreviewed, build fix for chromium.
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillSendRequest):
- 16:41 Changeset [51973] by
-
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32140
REGRESSION(r50072): Mailman administrative functionality is broken
Test: http/tests/misc/percent-sign-in-form-field-name.html
- platform/network/FormDataBuilder.cpp: (WebCore::appendQuotedString): Don't encode percent sign, we never had a good reason to do that.
- 16:20 Changeset [51972] by
-
2009-12-10 Eric Seidel <eric@webkit.org>
No review, just updating unit tests to match recent checkins.
- Scripts/modules/mock_bugzillatool.py:
- Add missing red_core_builders_names method causing exception.
- Scripts/modules/workqueue_unittest.py:
- processutils is dead, use executive.py instead.
- Scripts/modules/mock_bugzillatool.py:
- 16:06 Changeset [51971] by
-
2009-12-10 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Geoffrey Garen.
Remove JSObject::getPropertyAttributes() and all usage of it.
https://bugs.webkit.org/show_bug.cgi?id=31933
getOwnPropertyDescriptor() should be used instead.
- JavaScriptCore.exp:
- JavaScriptCore.order:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::getOwnPropertyDescriptor):
- debugger/DebuggerActivation.h:
- runtime/JSObject.cpp: (JSC::JSObject::propertyIsEnumerable):
- runtime/JSObject.h:
- runtime/JSVariableObject.cpp:
- runtime/JSVariableObject.h:
2009-12-10 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Geoffrey Garen.
Remove getPropertyAttributes() from JavaScript bindings.
https://bugs.webkit.org/show_bug.cgi?id=31933
The functionality is provided by getOwnPropertyDescriptor().
- WebCore.order:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDOMWindowShell.cpp:
- bindings/js/JSDOMWindowShell.h:
- bindings/scripts/CodeGeneratorJS.pm:
- page/DOMWindow.idl:
- 15:55 Changeset [51970] by
-
2009-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Changed WebGLRenderingContext to synthesize GL errors rather than
raising JavaScript exceptions. Removed internal getError() calls
after each graphics call. The GraphicsContext3D maintains the
synthetic exceptions because only it has complete information
about certain conditions requiring them to be raised.
Based on idea from Ilmari Heikkinen, added create3DDebugContext()
to webgl-test.js and changed the WebGL layout tests expecting
error conditions to use it. Updated expected.txt files, which now
implicitly test the OpenGL error as it is part of the exception's
message.
Added new targeted test covering aspects of synthetic errors as
well as regression tests for bugs uncovered during its development.
Test: fast/canvas/webgl/error-reporting.html
- fast/canvas/webgl/drawArraysOutOfBounds-expected.txt:
- fast/canvas/webgl/drawArraysOutOfBounds.html:
- fast/canvas/webgl/drawElementssOutOfBounds-expected.txt:
- fast/canvas/webgl/drawElementssOutOfBounds.html:
- fast/canvas/webgl/error-reporting-expected.txt: Added.
- fast/canvas/webgl/error-reporting.html: Added.
- fast/canvas/webgl/getActiveTest-expected.txt:
- fast/canvas/webgl/incorrect-context-object-behaviour-expected.txt:
- fast/canvas/webgl/invalidPassedParams-expected.txt:
- fast/canvas/webgl/invalidPassedParams.html:
- fast/canvas/webgl/null-object-behaviour-expected.txt:
- fast/canvas/webgl/resources/webgl-test.js: (create3DDebugContext.wrap.getError): (create3DDebugContext):
- fast/canvas/webgl/script-tests/error-reporting.js: Added.
- fast/canvas/webgl/script-tests/getActiveTest.js:
- fast/canvas/webgl/script-tests/incorrect-context-object-behaviour.js:
- fast/canvas/webgl/script-tests/null-object-behaviour.js:
- fast/canvas/webgl/script-tests/uniform-location.js:
- fast/canvas/webgl/uniform-location-expected.txt:
2009-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Changed WebGLRenderingContext to synthesize GL errors rather than
raising JavaScript exceptions. Removed internal getError() calls
after each graphics call. The GraphicsContext3D maintains the
synthetic exceptions because only it has complete information
about certain conditions requiring them to be raised.
Based on idea from Ilmari Heikkinen, added create3DDebugContext()
to webgl-test.js and changed the WebGL layout tests expecting
error conditions to use it. Updated expected.txt files, which now
implicitly test the OpenGL error as it is part of the exception's
message.
Added new targeted test covering aspects of synthetic errors as
well as regression tests for bugs uncovered during its development.
Test: fast/canvas/webgl/error-reporting.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::sizeInBytes): (WebCore::WebGLRenderingContext::activeTexture): (WebCore::WebGLRenderingContext::attachShader): (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::bindBuffer): (WebCore::WebGLRenderingContext::bindFramebuffer): (WebCore::WebGLRenderingContext::bindRenderbuffer): (WebCore::WebGLRenderingContext::bindTexture): (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData): (WebCore::WebGLRenderingContext::compileShader): (WebCore::WebGLRenderingContext::createShader): (WebCore::WebGLRenderingContext::detachShader): (WebCore::WebGLRenderingContext::disableVertexAttribArray): (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements): (WebCore::WebGLRenderingContext::enableVertexAttribArray): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getBufferParameter): (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): (WebCore::WebGLRenderingContext::getParameter): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getRenderbufferParameter): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource): (WebCore::WebGLRenderingContext::getTexParameter): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::getVertexAttrib): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::shaderSource): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv): (WebCore::WebGLRenderingContext::useProgram): (WebCore::WebGLRenderingContext::validateProgram): (WebCore::WebGLRenderingContext::vertexAttribPointer):
- html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::cleanupAfterGraphicsCall):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::synthesizeGLError):
2009-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Changed WebGLRenderingContext to synthesize GL errors rather than
raising JavaScript exceptions. Removed internal getError() calls
after each graphics call. The GraphicsContext3D maintains the
synthetic exceptions because only it has complete information
about certain conditions requiring them to be raised.
Based on idea from Ilmari Heikkinen, added create3DDebugContext()
to webgl-test.js and changed the WebGL layout tests expecting
error conditions to use it. Updated expected.txt files, which now
implicitly test the OpenGL error as it is part of the exception's
message.
Added new targeted test covering aspects of synthetic errors as
well as regression tests for bugs uncovered during its development.
Test: fast/canvas/webgl/error-reporting.html
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::getError): (WebCore::GraphicsContext3DInternal::synthesizeGLError): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::synthesizeGLError):
- 15:47 Changeset [51969] by
-
2009-12-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move run_command onto Executive to make code which uses run_command testable
https://bugs.webkit.org/show_bug.cgi?id=32396
- Scripts/modules/executive.py:
- Move run_command and error handlers onto Executive.
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py:
- Scripts/modules/executive.py:
- 15:40 Changeset [51968] by
-
2009-12-10 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov.
Fix for assert on Chrome/skia with SVG Filters enabled.
https://bugs.webkit.org/show_bug.cgi?id=32394
Covered by LayoutTests/svg/W3C-SVG-1.1/filters-tile-01-b.svg and others.
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
- 15:33 Changeset [51967] by
-
2009-12-10 Mike Belshe <mike@belshe.com>
Reviewed by Darin Fisher.
Fix FrameLoader to use the new ResourceTypes properly.
- public/WebURLRequest.h: (WebKit::WebURLRequest::):
- src/FrameLoaderClientImpl.cpp: (WebKit::setTargetTypeFromLoader): (WebKit::FrameLoaderClientImpl::dispatchWillSendRequest):
- 15:28 Changeset [51966] by
-
Layout test for video element on HTTP
https://bugs.webkit.org/show_bug.cgi?id=32333
Reviewed by Eric Carlson.
Added a new layout test that tests video element on HTTP protocol.
This test load the same video file twice. The first load will cache
the video file if caching is supported. The second load ensure
the cache works correctly.
- http/tests/media/resources/test.mp4: Copied from LayoutTests/media/content/test.mp4.
- http/tests/media/resources/test.ogv: Copied from LayoutTests/media/content/test.ogv.
The above two files are copied from LayoutTests/media/content because the HTTP
server is rooted at LayoutTests/http/tests. And we don't want to serve these
files with cgi because that will ruin the HTTP headers.
- http/tests/media/video-load-twice-expected.txt: Added.
- http/tests/media/video-load-twice.html: Added.
- 14:59 Changeset [51965] by
-
REGRESSION(4.0.4-42a12): With 2 highlighted lines of text in gmail/hotmail selecting Bold selects other 2 edit buttons automatically.
<rdar://problem/7442065>
https://bugs.webkit.org/show_bug.cgi?id=32285
Reviewed by Darin Adler.
WebCore:
When examining the styles of the nodes after the first in a range selection, we take into
cosideration differences in style of txt nodes only.
Test: editing/execCommand/queryCommandState-02.html
- editing/Editor.cpp:
(WebCore::Editor::selectionHasStyle):
LayoutTests:
- editing/execCommand/queryCommandState-02-expected.txt: Added.
- editing/execCommand/queryCommandState-02.html: Added.
- editing/execCommand/script-tests/toggle-compound-styles.js: Fixed typo in text.
- platform/mac/editing/execCommand/toggle-compound-styles-expected.txt: Fixed typo in text.
- platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Fixed typo in text.
- platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Fixed typo in text.
- 14:13 Changeset [51964] by
-
https://bugs.webkit.org/show_bug.cgi?id=32367
Add support for short Ropes (up to 3 entries) inline within JSString.
(rather than externally allocating an object to hold the rope).
Switch jsAdd of (JSString* + JSString*) to now make use of Ropes.
Reviewed by Oliver Hunt & Mark Rowe.
~1% progression on Sunspidey.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::toBoolean):
(JSC::JSString::getStringPropertyDescriptor):
- runtime/JSString.h:
(JSC::JSString::Rope::Fiber::deref):
(JSC::JSString::Rope::Fiber::ref):
(JSC::JSString::Rope::Fiber::refAndGetLength):
(JSC::JSString::Rope::append):
(JSC::JSString::JSString):
(JSC::JSString::~JSString):
(JSC::JSString::value):
(JSC::JSString::tryGetValue):
(JSC::JSString::length):
(JSC::JSString::canGetIndex):
(JSC::JSString::appendStringInConstruct):
(JSC::JSString::appendValueInConstructAndIncrementLength):
(JSC::JSString::isRope):
(JSC::JSString::string):
(JSC::JSString::ropeLength):
(JSC::JSString::getStringPropertySlot):
- runtime/Operations.h:
(JSC::jsString):
(JSC::jsAdd):
(JSC::resolveBase):
- 14:10 Changeset [51963] by
-
2009-12-10 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, fixing layout test mishap.
Add a newline to the layout test.
- http/tests/security/isolatedWorld/events-expected.txt: Added a newline at the end of the file.
- 14:06 Changeset [51962] by
-
Crash in XMLTokenizer::popCurrentNode if window.close() is called during parsing
https://bugs.webkit.org/show_bug.cgi?id=31576
Reviewed by Alexey Proskuryakov.
Add a RefCounted wrapper object around xmlParserCtxtPtr so we can
maintain it's lifetime more effectively.
Test: fast/parser/xhtml-close-while-parsing.xhtml
- 13:59 BuildingQtOnOSX edited by
- Require qt4-mac-dev (v4.6) instead of qt4-mac (v4.5.3). See … (diff)
- 13:54 Changeset [51961] by
-
2009-12-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: debugger shortcuts don't work when
Search field or Console drawer has focus.
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector.documentKeyUp): (WebInspector.searchKeyDown):
- 13:42 Changeset [51960] by
-
WebCore:
2009-12-10 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adam Barth.
[V8] Events created in isolated worlds may fire in main world.
https://bugs.webkit.org/show_bug.cgi?id=32386
Test: http/tests/security/isolatedWorld/events.html
- WebCore.gypi: Added WorldContextHandle.
- bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Added WorldContextHandle params.
- bindings/v8/SharedPersistent.h: Fixed a few style/include issues.
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): Added WorldContextHandle params. (WebCore::V8AbstractEventListener::handleEvent): Adjusted context retrieval to use WorldContextHandle. (WebCore::V8AbstractEventListener::invokeEventHandler): Ditto.
- bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::worldContext): Added WorldContextHandle params.
- bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper): Ditto.
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): Ditto. (WebCore::V8LazyEventListener::prepareListenerObject): Adjusted context retrieval to use WorldContextHandle.
- bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create): Added WorldContextHandle params.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::context): Refactored to use mainWorldContext(); (WebCore::V8Proxy::mainWorldContext): Added. (WebCore::toV8Context): Changed to use WorldContextHandle.
- bindings/v8/V8Proxy.h: Added mainWorldContext decl.
- bindings/v8/V8Utilities.cpp: (WebCore::reportException): Added an extra check to avoid crashes during frame teardown.
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener): Added WorldContextHandle params.
- bindings/v8/V8WorkerContextEventListener.h: (WebCore::V8WorkerContextEventListener::create): Added WorldContextHandle params.
- bindings/v8/WorldContextHandle.cpp: Added.
- bindings/v8/WorldContextHandle.h: Added.
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener): Added WorldContextHandle params.
- bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create): Added WorldContextHandle params.
LayoutTests:
2009-12-10 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adam Barth.
[V8] Events created in isolated worlds may fire in main world.
https://bugs.webkit.org/show_bug.cgi?id=32386
This test is relevant to both JSC and V8 isolated world implementation,
ensuring that events are fired in the right worlds.
- http/tests/security/isolatedWorld/events.html: Added.
- http/tests/security/isolatedWorld/events-expected.txt: Added.
- 13:17 Changeset [51959] by
-
2009-12-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool needs a command to list patches needing cq+
https://bugs.webkit.org/show_bug.cgi?id=32351
- Scripts/modules/bugzilla.py:
- Parse attacher_email from attachment xml.
- Scripts/modules/bugzilla_unittest.py:
- Test new attacher_email parsing.
- Scripts/modules/commands/queries.py:
- Add PatchesToCommitQueue
- Scripts/modules/commands/queries_unittest.py:
- Tests for PatchesToCommitQueue
- Scripts/modules/mock_bugzillatool.py:
- Add necessary mock methods for running PatchesToCommitQueue
- Scripts/modules/bugzilla.py:
- 13:04 Changeset [51958] by
-
Mac build fix. Unreviewed.
Re-adds code that was mistakenly removed from my last patch.
- WebCoreSupport/WebPluginHalterClient.mm:
Add necessary #import.
- WebView/WebDelegateImplementationCaching.h:
Declare a new overload of CallUIDelegateReturningBoolean.
- WebView/WebDelegateImplementationCaching.mm:
(CallDelegateReturningBoolean):
Add a new overload with different arguments.
(CallUIDelegateReturningBoolean):
Ditto.
- 12:24 Changeset [51957] by
-
Reviewed by Xan Lopez.
Add a missing null-check, that is causing some crash reports.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad):
- 11:57 Changeset [51956] by
-
2009-12-10 Adam Barth <abarth@webkit.org>
Unreviewed. Turns out every StepSequence command needs a --quiet
option.
- Scripts/modules/stepsequence.py:
- 11:51 Changeset [51955] by
-
Fix three more things found by compiling with clang++.
Reviewed by Geoffrey Garen.
- runtime/Structure.h:
(JSC::StructureTransitionTable::reifySingleTransition):
Add the 'std' qualifier to the call to make_pair.
- wtf/DateMath.cpp:
(WTF::initializeDates):
Incrementing a bool is deprecated according to the C++ specification.
- wtf/PtrAndFlags.h:
(WTF::PtrAndFlags::PtrAndFlags):
Name lookup should not be done in dependent bases, so explicitly qualify the call to set.
- 11:33 Changeset [51954] by
-
Touch WebKit.idl to try and fix the Windows build.
- 11:23 Changeset [51953] by
-
Pass more information about a plug-in to the PluginHalterDelegate
Reviewed by Adam Roben.
WebCore:
- loader/EmptyClients.h:
Remove this unused class.
- page/HaltablePlugin.h:
Add new functions to return the plug-in's name and whether it is
windowed.
- page/PluginHalter.cpp:
(WebCore::PluginHalter::timerFired):
Pass new arguments to the client.
- page/PluginHalterClient.h:
Add new parameters.
- plugins/PluginView.cpp:
(WebCore::PluginView::pluginName):
Return the name from the PluginPackage.
- plugins/PluginView.h:
(WebCore::PluginView::isWindowed):
WebKit/mac:
- Plugins/WebBaseNetscapePluginView.mm:
(WebHaltablePlugin::isWindowed):
Return false - the Mac doesn't really have windowed plug-ins.
(WebHaltablePlugin::pluginName):
Return the name from the plug-in package.
- WebCoreSupport/WebPluginHalterClient.h:
Update for new parameters.
- WebCoreSupport/WebPluginHalterClient.mm:
(WebPluginHalterClient::shouldHaltPlugin):
Ditto; pass them when making the delegate call.
- WebView/WebUIDelegatePrivate.h:
Update for new parameters.
WebKit/win:
- Interfaces/IWebPluginHalterDelegate.idl:
Add new parameters.
- WebCoreSupport/WebPluginHalterClient.cpp:
(WebPluginHalterClient::shouldHaltPlugin):
Update for new parameters. Pass them when making the delegate call.
- WebCoreSupport/WebPluginHalterClient.h:
Update for new parameters.
- 10:58 Changeset [51952] by
-
Fixes <http://webkit.org/b/31738>.
Web Inspector: Console Scope Bar should be on top of console when Console is a Panel.
Reviewed by Pavel Feldman.
When the console is set to be shown as a full panel, move the scope bar to the top
where it looks best. When it is only shown as a drawer, move it to the bottom, where
it originally was. This takes up less space as a drawer, and makes it more discoverable
and usable when it is the full panel.
- inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype.show): Move filter bar to top.
(WebInspector.ConsolePanel.prototype.hide): Move filter bar back to bottom.
- inspector/front-end/inspector.css:
- 09:54 Changeset [51951] by
-
2009-12-10 Patrik Persson <patrik.j.persson@ericsson.com>
Reviewed by Adam Barth.
Test case to verify that sandboxing 'about:blank' does not make
the containing frame sandboxed.
- fast/frames/resources/sandboxed-iframe-about-blank.html: Added.
- fast/frames/sandboxed-iframe-about-blank-expected.txt: Added.
- fast/frames/sandboxed-iframe-about-blank.html: Added.
- 09:13 Changeset [51950] by
-
Fix for alpha blending in SVG Filters on Chromium/skia.
https://bugs.webkit.org/show_bug.cgi?id=32378
Reviewed by Dirk Schulze.
Covered by LayoutTests/svg/filters/feGaussianBlur.svg and others.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::platformTransformColorSpace):
- 08:44 Changeset [51949] by
-
2009-12-10 Ilya Tikhonovsky <loislo@google.com>
Reviewed by Pavel Feldman.
Chromium: Expose devtools agent API for inspector layout tests.
- public/WebDevToolsAgent.h: (WebKit::WebDevToolsAgent::setTimelineProfilingEnabled): (WebKit::WebDevToolsAgent::evaluateInWebInspector):
- 06:29 Changeset [51948] by
-
Reviewed by Xan Lopez.
[GTK] Should provide an API to control the IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=32334
First step towards a full IconDatabase API. This provides
notification for pages with favicons, and lets clients handle
them.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::registerForIconNotification): (WebKit::FrameLoaderClient::dispatchDidReceiveIcon):
- tests/resources/blank.ico: Added.
- tests/testwebview.c: Added. (server_callback): (idle_quit_loop_cb): (icon_uri_changed_cb): (icon_loaded_cb): (test_webkit_web_view_icon_uri): (main):
- webkit/webkitprivate.cpp: (closeIconDatabaseOnExit): (webkit_init):
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (webkit_web_view_get_property): (webkit_web_view_finalize): (webkit_web_view_class_init): (webkit_web_view_get_icon_uri):
- webkit/webkitwebview.h:
- 05:55 Changeset [51947] by
-
2009-12-10 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
DumpRenderTree has been patched so that the timeline-paint.html
unit test now runs under GTK+.
- platform/gtk/Skipped:
2009-12-10 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
Implements displayWebView() to force an invalidation and repaint.
This fixes a problem running the timeline-paint.html unit test.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (displayWebView):
- 04:53 Changeset [51946] by
-
2009-12-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add context menu actions for DOM tree.
- English.lproj/localizedStrings.js:
- inspector/front-end/ContextMenu.js: (WebInspector.ContextMenu): (WebInspector.ContextMenu.prototype.show): (WebInspector.ContextMenu.prototype.appendItem): (WebInspector.ContextMenu.prototype.appendSeparator): (WebInspector.ContextMenu.prototype._itemSelected): (WebInspector.contextMenuItemSelected): (WebInspector.contextMenuCleared):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmouseout): (WebInspector.ElementsTreeOutline.prototype.populateContextMenu): (WebInspector.ElementsTreeElement.prototype.ondblclick): (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu): (WebInspector.ElementsTreeElement.prototype._populateTextContextMenu): (WebInspector.ElementsTreeElement.prototype._startEditing): (WebInspector.ElementsTreeElement.prototype._addNewAttribute):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._toggleURLdecoding):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/inspector.js: (WebInspector.contextMenuEventFired):
- inspector/front-end/treeoutline.js: (TreeElement.treeElementDoubleClicked):
- 04:05 Changeset [51945] by
-
2009-12-09 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Oliver Hunt.
Filters contain some leaks in untested code
https://bugs.webkit.org/show_bug.cgi?id=32325
Fix obvious leak in SVGFE*Lighting classes. Implement the create() idiom for
all classes in svg/graphics, that were missing it. The lighting filters aren't
implemented so far, but the associated FilterEffect objects are build, which created
these leaks.
This removes the SVG related failures in the leaks bot.
- 04:04 Changeset [51944] by
-
2009-12-10 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Skip two tests on gtk/qt that generate new results.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 02:13 QtBackLog edited by
- (diff)
- 02:13 QtBackLog edited by
- (diff)
- 01:21 Changeset [51943] by
-
2009-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
[Chromium] SporeViewer demo doesn't work in Chromium
https://bugs.webkit.org/show_bug.cgi?id=32364
Test: fast/canvas/webgl/bug-32364.html
- fast/canvas/webgl/bug-32364-expected.txt: Added.
- fast/canvas/webgl/bug-32364.html: Added.
2009-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
[Chromium] SporeViewer demo doesn't work in Chromium
https://bugs.webkit.org/show_bug.cgi?id=32364
Test: fast/canvas/webgl/bug-32364.html
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi):
- 00:33 Changeset [51942] by
-
2009-12-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Convert more commands to StepSequences
https://bugs.webkit.org/show_bug.cgi?id=32362
We should eventually convert all the commands, but I'm starting with
the easy ones.
- Scripts/modules/commands/download.py:
- 00:21 Changeset [51941] by
-
2009-12-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
[GTK] editing/selection/shrink-selection-after-shift-pagedown.html failing
https://bugs.webkit.org/show_bug.cgi?id=31103
Give focus to the webviews when we create them, since some tests expect this.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (main):
- 00:18 Changeset [51940] by
-
2009-12-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool "builders are red" error should tell you which builders
https://bugs.webkit.org/show_bug.cgi?id=32211
- Scripts/modules/buildsteps.py:
