Timeline
12/20/09:
- 23:29 Changeset [52436] by
-
2009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Eric Seidel.
Created "style" folder for code supporting check-webkit-style.
- Scripts/modules/style: Added.
- 23:24 Changeset [52435] by
-
2009-12-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: error when running commit-queue
https://bugs.webkit.org/show_bug.cgi?id=32806
Fix typo and add test!
- Scripts/modules/bugzilla.py:
- Scripts/modules/bugzilla_unittest.py:
- 22:20 Changeset [52434] by
-
2009-12-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
A test for Date binding.
https://bugs.webkit.org/show_bug.cgi?id=32698
- fast/forms/input-valueasdate-expected.txt: Added.
- fast/forms/input-valueasdate.html: Added.
- fast/forms/script-tests/input-valueasdate.js: Added.
2009-12-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add support for JavaScriptCore Date binding.
https://bugs.webkit.org/show_bug.cgi?id=32698
This is needed for HTMLInputElement::valueAsDate and
HTMLTimeElement::valueAsDate.
A Date instance is mapped to a double value in C++.
- If null or undefined is set to a JavaScript property, C++ setter function receives NaN.
- If a getter C++ function returns NaN or infinity, a JavaScript property returns null.
Test: fast/forms/input-valueasdate.html
- bindings/js/JSDOMBinding.cpp: (WebCore::jsDateOrNull): Implement the above. (WebCore::valueToDate): ditto.
- bindings/js/JSDOMBinding.h: Declare them.
- bindings/scripts/CodeGeneratorJS.pm: Produce jsDateOrNull() or valueToDate() for Date type.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): Temporal implementation. (WebCore::HTMLInputElement::setValueAsDate): ditto.
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl: Declare valueAsDate.
- 22:16 Changeset [52433] by
-
2009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Darin Adler.
Removed outdated contact information from bug life cycle page.
- quality/lifecycle.html:
- 20:57 Changeset [52432] by
-
2009-12-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Introduce the followings:
- ::-webkit-inner-spin-button pseudo CSS selector
- ::-webkit-outer-spin-button pseudo CSS selector
- new appearance type: inner-spin-button
- new appearance type: outer-spin-button
They're going to be used for <input type=number> UI.
https://bugs.webkit.org/show_bug.cgi?id=31821
Inner-spin-button will be used for Windows, and outer-spin-button
will be used for Mac. A spin-button will represent a pair of an
increasing button part and a decreasing button part. SpinUpState,
which is defined in ThemeTypes.h, will be used to distinguish
these two parts.
The outer-spin-button implementation will use NSStepperCell.
NSStepperCell represents the pair of the parts and we can't draw them
independently. So a spin-button also represents the pair of the parts.
This change has no tests. The following changes with tests will cover.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
- css/CSSSelector.h: (WebCore::CSSSelector::):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- css/CSSValueKeywords.in:
- css/html.css:
- platform/ThemeTypes.h: (WebCore::ControlState): Add SpinUpState. (WebCore::ControlPart): Add InnerSpinButtonPart and OuterSpinButtonPart.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::adjustInnerSpinButtonStyle): Add an empty implementation. (WebCore::RenderTheme::adjustOuterSpinButtonStyle): Add an empty implementation.
- rendering/RenderTheme.h: (WebCore::RenderTheme::paintInnerSpinButton): Add an empty implementation. (WebCore::RenderTheme::paintOuterSpinButton): Add an empty implementation.
- rendering/style/RenderStyleConstants.h: (WebCore::PseudoId): Add INNER_SPIN_BUTTON and OUTER_SPIN_BUTTON.
- 19:17 Changeset [52431] by
-
2009-12-20 Nayan Kumar K <nayankk@gmail.com>
Reviewed by Darin Adler.
Fix for compilation errors in WML module, due to the changeset #52314.
https://bugs.webkit.org/show_bug.cgi?id=32786
No new tests, this is compilation error fix.
- wml/WMLDocument.cpp:
- wml/WMLPageState.cpp:
- wml/WMLPageState.h:
- 18:57 Changeset [52430] by
-
2009-12-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Optimize status updates for new dashboard
https://bugs.webkit.org/show_bug.cgi?id=32797
This patch makes the queues slightly more chatty with the web service.
Also, this patch introduces some testing for the queues!
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/early_warning_system_unittest.py: Added.
- Scripts/modules/commands/queues.py:
- Scripts/modules/commands/queues_unittest.py:
- Scripts/modules/commands/queuestest.py: Added.
- Scripts/modules/mock_bugzillatool.py:
- Scripts/modules/patchcollection.py:
- Scripts/modules/queueengine.py:
- Scripts/run-webkit-unittests:
- 18:42 Changeset [52429] by
-
2009-12-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Prepare QueueStatusServer for new status messages
https://bugs.webkit.org/show_bug.cgi?id=32805
- QueueStatusServer/handlers/recentstatus.py:
- QueueStatusServer/index.html: Removed.
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/model/queues.py: Added.
- QueueStatusServer/templates/recentstatus.html: Added.
- 15:51 Changeset [52428] by
-
2009-12-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Unset the adjustments in our FrameView when detaching from
parent. Fixes some crashers when transitioning to a new page from
a scrolled page.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::detachedFromParent2):
- 14:00 QtWebKitAPI edited by
- (diff)
- 12:50 Changeset [52427] by
-
<rdar://problem/7487689> REGRESSION (r52203): Inspector console uses
Monaco on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=32775
Reviewed by Mark Rowe.
- inspector/front-end/inspector.css: Use the default monospace family
and size.
- 12:07 Changeset [52426] by
-
Reviewed by Xan Lopez.
Remove emission of signal that does not exist.
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorClient::webViewDestroyed):
- 11:31 Changeset [52425] by
-
Reviewed by Xan Lopez.
Provides a new API to copy WebKitWebHistoryItem objects.
- webkit/webkitwebhistoryitem.cpp:
(webkit_web_history_item_copy):
- webkit/webkitwebhistoryitem.h:
- 10:46 Changeset [52424] by
-
2009-12-20 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
Disable the page cache by default since:
- It was previously off by default.
- There are still some issues when enabling it.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
- 10:22 Changeset [52423] by
-
2009-12-20 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adam Barth.
[check-webkit-style] static_cast is not misnamed!
https://bugs.webkit.org/show_bug.cgi?id=32796
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 10:07 Changeset [52422] by
-
2009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Make sure we get the URI that is being loaded when updating
WebKitWebFrame's knowledge of it. This was causing problems now
that page cache is enabled.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
- tests/testloading.c: (load_goback_status_changed_cb): (load_wentback_status_changed_cb): (test_loading_goback): (main):
- 09:39 Changeset [52421] by
-
2009-12-20 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez.
[GTK] Remove more GTK+ and GLib headers from WebCore
https://bugs.webkit.org/show_bug.cgi?id=32795
Remove most GTK+ and GLib includes from WebCore headers.
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
- platform/gtk/PasteboardHelper.h:
- platform/gtk/RenderThemeGtk.cpp:
- platform/gtk/RenderThemeGtk.h:
- platform/gtk/ScrollbarGtk.cpp:
- platform/gtk/ScrollbarThemeGtk.h:
- platform/gtk/gtk2drawing.c:
- platform/gtk/gtkdrawing.h:
- 09:06 Changeset [52420] by
-
[wx] build fixes after recent changes.
- 08:26 Changeset [52419] by
-
2009-12-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
https://bugs.webkit.org/show_bug.cgi?id=32788
Avoid using fixed values when moving mouse.
- platform/gtk/editing/pasteboard/middle-button-paste-expected.txt:
- platform/gtk/editing/pasteboard/middle-button-paste.html:
2009-12-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
https://bugs.webkit.org/show_bug.cgi?id=32788
Do not increase the click count if we are using a different button.
- DumpRenderTree/gtk/EventSender.cpp:
- 07:53 Changeset [52418] by
-
2009-12-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Cache control APIs
https://bugs.webkit.org/show_bug.cgi?id=24001
Original patch by Bobby Powers <bobby@laptop.org>
Added new API to specify cache models for GTK port.
- webkit/webkitprivate.cpp: (webkit_init): set a default cache model.
- webkit/webkitwebview.cpp:
- webkit/webkitwebview.h: (webkit_set_cache_model): Added function. (webkit_get_cache_model): Added function.
- 07:45 Changeset [52417] by
-
Reviewed by Xan Lopez.
Hopefully fix the assertion we are hitting by not forcing updating
the state of scrollbars when setting the adjustments. This was
leading to a premature layout.
fast/dom/open-and-close-by-DOM.html
fast/dom/Window/closure-access-after-navigation-window.html
fast/harness/use-page-cache.html
- platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::setGtkAdjustments):
- 04:58 Changeset [52416] by
-
2009-12-20 Xan Lopez <xlopez@igalia.com>
Revert the previous patch, it introduces some failures in the
bots.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
- 04:41 Changeset [52415] by
-
2009-12-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Darin Adler.
Web Inspector: Constrain the number of messages the inspector shows.
- English.lproj/localizedStrings.js:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::updateConsoleMessageExpiredCount):
- inspector/InspectorFrontend.h:
- inspector/front-end/inspector.js: (WebInspector.updateConsoleMessageExpiredCount):
- 04:27 Changeset [52414] by
-
2009-12-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] crash when loading new page
https://bugs.webkit.org/show_bug.cgi?id=32752
Wait until the document is attached to adjust our alignments,
since we need to make sure the FrameView in the document content
render object matches the newly created FrameView for the new
page, otherwise we'll try to relayout the wrong view.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
- 04:18 Changeset [52413] by
-
2009-12-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Gustavo Noronha Silva.
- platform/gtk/editing/pasteboard/middle-button-paste-expected.txt:
- platform/gtk/editing/pasteboard/middle-button-paste.html:
- 04:02 Changeset [52412] by
-
Reviewed by Xan Lopez.
Create a new WebKitDataSource object when attaching to a frame, if
one does not exist. This may happen when we are fetching data from
the page cache.
- WebCoreSupport/DocumentLoaderGtk.cpp:
(WebKit::DocumentLoader::attachToFrame):
(WebKit::DocumentLoader::unrefDataSource):
- 02:46 Changeset [52411] by
-
Rubber-stamped by Xan Lopez.
Make sure the text encoding machinery is initialized from the main
frame, before opening the icon database.
- webkit/webkitprivate.cpp:
(webkit_init):
- 02:27 Changeset [52410] by
-
2009-12-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Adler.
Upstreaming two plugin tests from chromium.org.
https://bugs.webkit.org/show_bug.cgi?id=32750
- plugins/get-file-url-expected.txt: Added.
- plugins/get-file-url.html: Added.
- plugins/get-url-with-iframe-target-expected.txt: Added.
- plugins/get-url-with-iframe-target.html: Added.
- plugins/resources/get-file-url-subframe.html: Added.
- 02:18 Changeset [52409] by
-
2009-12-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Adler.
Upstream a test from chromium.org that verifies that calling
document.clear() from an external script doesn't crash the browser.
https://bugs.webkit.org/show_bug.cgi?id=32743
- fast/dom/document-clear-expected.txt: Added.
- fast/dom/document-clear.html: Added.
- fast/dom/resources/document-clear.js: Added.
- 02:10 Changeset [52408] by
-
2009-12-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Adler.
Upstream a test from chromium.org - ensure that creating a
new Image is actually creating an HTML image element, regardless
of the doctype.
- svg/custom/new-image-is-html-element-expected.txt: Added.
- svg/custom/new-image-is-html-element.svg: Added.
- 02:01 Changeset [52407] by
-
2009-12-20 Dirk Pranke <dpranke@fila-macpro.mtv.corp.google.com>
Reviewed by Darin Adler.
upstream test from chromium.org - this tests simulating italic
on glyphs that don't have an italic version.
- fast/text/fake-italic.html: Added.
- platform/mac/fast/text/fake-italic-expected.checksum: Added.
- platform/mac/fast/text/fake-italic-expected.png: Added.
- platform/mac/fast/text/fake-italic-expected.txt: Added.
- 01:52 Changeset [52406] by
-
2009-12-20 Andrei Popescu <andreip@google.com>
Reviewed by Adam Barth.
[Android] Android needs implementation of setCookies, cookies and cookiesEnabled functions.
https://bugs.webkit.org/show_bug.cgi?id=32559
Add implementation of the cookie functions.
Fix a crash caused by dereferencing a 0 MainResourceLoader pointer
in ResourceHandle::start().
No new tests, this is platform code.
- platform/android/PlatformBridge.h:
- platform/network/android/AuthenticationChallenge.h: Added.
- platform/network/android/CookieJarAndroid.cpp: Added. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
- platform/network/android/ResourceHandleAndroid.cpp: (WebCore::ResourceHandle::start):
- 01:47 Changeset [52405] by
-
2009-12-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[QueueStatusServer] Add a per-patch details page
https://bugs.webkit.org/show_bug.cgi?id=32784
This is a first cut at a per-patch details page. I'm sure we'll have
to iterate.
- QueueStatusServer/filters/webkit_extras.py:
- QueueStatusServer/handlers/patch.py: Added.
- QueueStatusServer/index.yaml:
- QueueStatusServer/main.py:
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/stylesheets/dashboard.css:
- QueueStatusServer/templates/dashboard.html:
- QueueStatusServer/templates/patch.html: Added.
- 00:27 Changeset [52404] by
-
2009-12-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Use memcache to make dashboard to fast
https://bugs.webkit.org/show_bug.cgi?id=32780
- QueueStatusServer/app.yaml:
- QueueStatusServer/handlers/dashboard.py:
- QueueStatusServer/handlers/updatestatus.py:
- QueueStatusServer/model/attachment.py: Added.
12/19/09:
- 23:48 Changeset [52403] by
-
2009-12-19 Eric Seidel <eric@webkit.org>
No review, rolling out r52395.
http://trac.webkit.org/changeset/52395
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- svg/SVGMaskElement.h:
- svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
- svg/graphics/SVGResourceMasker.h:
- 23:36 Changeset [52402] by
-
2009-12-19 Adam Barth <abarth@webkit.org>
No review, rolling out r52399.
http://trac.webkit.org/changeset/52399
- websocket/tests/bad-sub-protocol-expected.txt:
- websocket/tests/script-tests/url-parsing.js:
- websocket/tests/url-parsing-expected.txt:
2009-12-19 Adam Barth <abarth@webkit.org>
No review, rolling out r52399.
http://trac.webkit.org/changeset/52399
- websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
- 23:22 Changeset [52401] by
-
2009-12-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add a test for window.open and JavaScript URLs.
- http/tests/security/xss-DENIED-window-open-javascript-url-expected.txt: Added.
- http/tests/security/xss-DENIED-window-open-javascript-url.html: Added.
2009-12-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Added a missing "not".
Test: http/tests/security/xss-DENIED-window-open-javascript-url.html
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::createWindow):
- 22:55 Changeset [52400] by
-
Provide an example implementation for printing under Windows.
http://bugs.webkit.org/show_bug.cgi?id=32504.`
Reviewed by Adam Roben.
- WinLauncher/PrintWebUIDelegate.cpp: Added.
(PrintWebUIDelegate::QueryInterface):
(PrintWebUIDelegate::AddRef):
(PrintWebUIDelegate::Release):
(PrintWebUIDelegate::webViewPrintingMarginRect):
- WinLauncher/PrintWebUIDelegate.h: Added.
(PrintWebUIDelegate::PrintWebUIDelegate):
(PrintWebUIDelegate::createWebViewWithRequest):
(PrintWebUIDelegate::webViewShow):
(PrintWebUIDelegate::webViewClose):
(PrintWebUIDelegate::webViewFocus):
(PrintWebUIDelegate::webViewUnfocus):
(PrintWebUIDelegate::webViewFirstResponder):
(PrintWebUIDelegate::makeFirstResponder):
(PrintWebUIDelegate::setStatusText):
(PrintWebUIDelegate::webViewStatusText):
(PrintWebUIDelegate::webViewAreToolbarsVisible):
(PrintWebUIDelegate::setToolbarsVisible):
(PrintWebUIDelegate::webViewIsStatusBarVisible):
(PrintWebUIDelegate::setStatusBarVisible):
(PrintWebUIDelegate::webViewIsResizable):
(PrintWebUIDelegate::setResizable):
(PrintWebUIDelegate::setFrame):
(PrintWebUIDelegate::webViewFrame):
(PrintWebUIDelegate::setContentRect):
(PrintWebUIDelegate::webViewContentRect):
(PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage):
(PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage):
(PrintWebUIDelegate::runJavaScriptTextInputPanelWithPrompt):
(PrintWebUIDelegate::runBeforeUnloadConfirmPanelWithMessage):
(PrintWebUIDelegate::runOpenPanelForFileButtonWithResultListener):
(PrintWebUIDelegate::mouseDidMoveOverElement):
(PrintWebUIDelegate::contextMenuItemsForElement):
(PrintWebUIDelegate::validateUserInterfaceItem):
(PrintWebUIDelegate::shouldPerformAction):
(PrintWebUIDelegate::dragDestinationActionMaskForDraggingInfo):
(PrintWebUIDelegate::willPerformDragDestinationAction):
(PrintWebUIDelegate::dragSourceActionMaskForPoint):
(PrintWebUIDelegate::willPerformDragSourceAction):
(PrintWebUIDelegate::contextMenuItemSelected):
(PrintWebUIDelegate::hasCustomMenuImplementation):
(PrintWebUIDelegate::trackCustomPopupMenu):
(PrintWebUIDelegate::measureCustomMenuItem):
(PrintWebUIDelegate::drawCustomMenuItem):
(PrintWebUIDelegate::addCustomMenuDrawingData):
(PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
(PrintWebUIDelegate::canTakeFocus):
(PrintWebUIDelegate::takeFocus):
(PrintWebUIDelegate::registerUndoWithTarget):
(PrintWebUIDelegate::removeAllActionsWithTarget):
(PrintWebUIDelegate::setActionTitle):
(PrintWebUIDelegate::undo):
(PrintWebUIDelegate::redo):
(PrintWebUIDelegate::canUndo):
(PrintWebUIDelegate::canRedo):
(PrintWebUIDelegate::printFrame):
(PrintWebUIDelegate::ftpDirectoryTemplatePath):
(PrintWebUIDelegate::webViewHeaderHeight):
(PrintWebUIDelegate::webViewFooterHeight):
(PrintWebUIDelegate::drawHeaderInRect):
(PrintWebUIDelegate::drawFooterInRect):
(PrintWebUIDelegate::canRunModal):
(PrintWebUIDelegate::createModalDialog):
(PrintWebUIDelegate::runModal):
(PrintWebUIDelegate::isMenuBarVisible):
(PrintWebUIDelegate::setMenuBarVisible):
(PrintWebUIDelegate::runDatabaseSizeLimitPrompt):
(PrintWebUIDelegate::paintCustomScrollbar):
(PrintWebUIDelegate::paintCustomScrollCorner):
- WinLauncher/WinLauncher.cpp: Add new UI delegate for print support.
(WinLauncherWebHost::updateAddressBar): check-webkit-style fixes.
(WinLauncherWebHost::QueryInterface): check-webkit-style fixes.
(WinLauncherWebHost::AddRef): check-webkit-style fixes.
(WinLauncherWebHost::Release): check-webkit-style fixes.
(resizeSubViews): check-webkit-style fixes.
(_tWinMain): check-webkit-style fixes.
(MyRegisterClass): check-webkit-style fixes.
(InitInstance): check-webkit-style fixes.
(AbortProc): New print support function.
(getPrinterDC): New print support function.
(initDocStruct): New print support function.
(PrintView): New printing implementation.
(WndProc): Add support for printing.
(MyEditProc): check-webkit-style fixes.
(About): check-webkit-style fixes.
(loadURL): check-webkit-style fixes.
- WinLauncher/WinLauncher.h:
(WinLauncherWebHost::WinLauncherWebHost):
(WinLauncherWebHost::didStartProvisionalLoadForFrame):
(WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
(WinLauncherWebHost::didFailProvisionalLoadWithError):
(WinLauncherWebHost::didCommitLoadForFrame):
(WinLauncherWebHost::didReceiveTitle):
(WinLauncherWebHost::didReceiveIcon):
(WinLauncherWebHost::didFinishLoadForFrame):
(WinLauncherWebHost::didFailLoadWithError):
(WinLauncherWebHost::didChangeLocationWithinPageForFrame):
(WinLauncherWebHost::willPerformClientRedirectToURL):
(WinLauncherWebHost::didCancelClientRedirectForFrame):
(WinLauncherWebHost::willCloseFrame):
(WinLauncherWebHost::windowScriptObjectAvailable):
- WinLauncher/WinLauncher.rc: Add menu entry for printing.
- WinLauncher/WinLauncher.vcproj: Add new files.
- WinLauncher/resource.h: Add menu entry for printing.
- 19:30 Changeset [52399] by
-
2009-12-19 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Invalid url should raise SYNTAX_ERR exception.
https://bugs.wbekit.org/show_bug.cgi?id=32700
- websocket/tests/bad-sub-protocol-expected.txt: add CONSOLE MESSAGEs
- websocket/tests/script-tests/url-parsing.js: add invalid url tests. Also changed url from ws://127.0.0.1/ to ws://127.0.0.1:8880/websocket/tests/simple to make it sure no errors on console message for these tests by not receiving unexpected response from 127.0.0.1:80.
- websocket/tests/url-parsing-expected.txt:
2009-12-19 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Invalid url should raise SYNTAX_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=32700
Check url is valid in WebSocket::connect.
Also log the detailed reason of websocket failures to console.
- websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
- 18:40 Changeset [52398] by
-
2009-12-19 Adam Barth <abarth@webkit.org>
Unreviewed. Tweak the CSS to make the dashboard prettier.
- QueueStatusServer/stylesheets/dashboard.css:
- QueueStatusServer/templates/dashboard.html:
- 18:32 Changeset [52397] by
-
REGRESSION: Up/down arrow keys do not step numeric CSS property values
https://bugs.webkit.org/show_bug.cgi?id=32776
Reviewed by Darin Adler.
- inspector/front-end/inspector.js:
(WebInspector.documentKeyDown): Call the focused element’s
handleKeyEvent method.
- 17:37 Changeset [52396] by
-
2009-12-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
QueueStatusServer needs a human readable dashboard
https://bugs.webkit.org/show_bug.cgi?id=32769
Here is a first cut at the dashboard. There's a lot left to do.
- QueueStatusServer/filters/webkit_extras.py:
- QueueStatusServer/handlers/dashboard.py: Added.
- QueueStatusServer/handlers/patchstatus.py:
- QueueStatusServer/handlers/recentstatus.py:
- QueueStatusServer/handlers/showresults.py:
- QueueStatusServer/handlers/statusbubble.py:
- QueueStatusServer/handlers/updatestatus.py:
- QueueStatusServer/main.py:
- QueueStatusServer/model/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
- QueueStatusServer/model/queuestatus.py: Renamed from WebKitTools/QueueStatusServer/model.py.
- QueueStatusServer/stylesheets/dashboard.css: Added.
- QueueStatusServer/templates/dashboard.html: Added.
- QueueStatusServer/templates/statusbubble.html: Renamed from WebKitTools/QueueStatusServer/status_bubble.html.
- QueueStatusServer/templates/updatestatus.html: Renamed from WebKitTools/QueueStatusServer/update_status.html.
- 17:30 BuildingOnWindows edited by
- Add notice of change made in changeset 51399 that requires Safari 4.0.4 to … (diff)
- 13:58 Changeset [52395] by
-
2009-12-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Speed-up SVG Masking
https://bugs.webkit.org/show_bug.cgi?id=32738
This patch makes SVG Masking faster. At the moment we create a new ImageBuffer
and copy the complete pixel array. That is rather inefficient. This patch
uses the mask image directly.
It also bounds the direct pixel manipultation to the viewable area to minimize
the calculation of the mask.
No change in functionality. So no new test.
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- svg/SVGMaskElement.h:
- svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
- svg/graphics/SVGResourceMasker.h:
- 13:35 Changeset [52394] by
-
2009-12-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add tests to check filter, mask, clip, opacity and marker ordering
https://bugs.webkit.org/show_bug.cgi?id=14010
Tests the right order of filter and clipper/masker aplied to a SVG
object.
- platform/mac/svg/filters/filter-clip-expected.checksum: Added.
- platform/mac/svg/filters/filter-clip-expected.png: Added.
- platform/mac/svg/filters/filter-clip-expected.txt: Added.
- svg/filters/filter-clip.svg: Added.
2009-12-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add tests to check filter, mask, clip, opacity and marker ordering
https://bugs.webkit.org/show_bug.cgi?id=14010
The right ordering for applying effects on objects in SVG is filters,
clipper/masker and opacity. This patch fixes the order of filter and
clipper/masker. Opacity and marker need another test.
This change is according to the SVG Specification:
http://www.w3.org/TR/SVG11/render.html#Elements
Test: svg/filters/filter-clip.svg
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):
- 12:53 Changeset [52393] by
-
2009-12-19 Daniel Bates <dbates@webkit.org>
Reviewed by Timothy Hatcher.
Added --inspector-frontend flag to build-webkit to copy any changes
to the inspector front-end files to the built WebCore framework. This
will make inspector development more consistent with the rest of
WebKit development.
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
- 10:55 Changeset [52392] by
-
2009-12-19 Evan Martin <evan@chromium.org>
Reviewed by Gustavo Noronha Silva.
Revert my attempt at making --disable-geolocation work; it is
more complicated than I anticipated. (It passed on the build bots
because they build with --enable-geolocation.)
- GNUmakefile.am:
- 10:52 Changeset [52391] by
-
add forgotten file
- 10:45 Changeset [52390] by
-
Rebaselined test after revision 52335.
- 10:37 Changeset [52389] by
-
2009-12-19 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Tests for https://bugs.webkit.org/show_bug.cgi?id=28153
can't middle-button paste within a single window
- LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste-expected.txt: Added
- LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste.html: Adeed
2009-12-19 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Fixed the problem when pasting in the same window with the
middle-button, now we store a reference to the range instead of
requesting it every time, and we do not release it until the
clipboard is requested.
https://bugs.webkit.org/show_bug.cgi?id=28153
- WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:
- WebKit/gtk/WebCoreSupport/EditorClientGtk.h:
- 10:30 Changeset [52388] by
-
2009-12-19 MORITA Hajime <morrita@gmail.com>
Reviewed by Darin Adler.
WebCore::Range::surroundContents NULL pointer crash.
- fast/dom/Range/31684-expected.txt: Added.
- fast/dom/Range/31684.html: Added.
- fast/dom/Range/script-tests/31684.js: Added.
2009-12-19 MORITA Hajime <morrita@gmail.com>
Reviewed by Darin Adler.
WebCore::Range::surroundContents NULL pointer crash.
Test: fast/dom/Range/31684.html
- dom/Range.cpp: (WebCore::Range::surroundContents): throw exception when parentOfNewParent->parentNode() is NULL.
- 10:24 Changeset [52387] by
-
Reviewed by Xan Lopez.
Protect download objects when reporting errors, to make sure the
download stays alive between the status change notification, and
the error signal emission.
- webkit/webkitdownload.cpp:
(webkit_download_error):
- 10:08 Changeset [52386] by
-
2009-12-19 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
Don't use an icon for all spelling guess menu items.
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
- 09:23 Changeset [52385] by
-
2009-12-19 Adam Barth <abarth@webkit.org>
Unreviewed fixes for me being terrible at python.
- Scripts/modules/bugzilla.py:
- Scripts/run-webkit-unittests:
- 08:24 Changeset [52384] by
-
2009-12-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed build fix. Missing \.
- GNUmakefile.am:
- 07:16 Changeset [52383] by
-
2009-12-19 Evan Martin <evan@chromium.org>
Reviewed by Gustavo Noronha Silva.
Add a couple of WebKitGtk files to .gitignore.
- .gitignore:
- 03:52 Changeset [52382] by
-
2009-12-19 Evan Martin <evan@chromium.org>
Reviewed by Gustavo Noronha Silva.
Make --disable-geolocation and --disable-svg work, by conditionally
building the relevant files.
- GNUmakefile.am:
12/18/09:
- 23:14 Changeset [52381] by
-
2009-12-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Split QueueStatus server into modules
https://bugs.webkit.org/show_bug.cgi?id=32768
One monolithic file is no good.
- QueueStatusServer/app.yaml:
- QueueStatusServer/handlers/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
- QueueStatusServer/handlers/patchstatus.py: Added.
- QueueStatusServer/handlers/recentstatus.py: Added.
- QueueStatusServer/handlers/showresults.py: Added.
- QueueStatusServer/handlers/statusbubble.py: Added.
- QueueStatusServer/handlers/updatestatus.py: Added.
- QueueStatusServer/main.py: Added.
- QueueStatusServer/model.py: Added.
- QueueStatusServer/queue_status.py: Removed.
- 23:12 Changeset [52380] by
-
2009-12-18 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
[Chromium] Eliminate redundant data copy in GraphicsContext3D readback
https://bugs.webkit.org/show_bug.cgi?id=32763
Eliminated useless creation of a CGBitmapContext and from there a
CGImage. Now create CGImage directly from data. Also changed
readPixels parameters and CGImage alpha info to try to avoid byte
swapping, and disabled interpolation when drawing the GL content.
Some test cases run twice as fast with these changes, though more
work is needed to achieve desired performance.
No test case; performance optimization only. Ran WebGL demos from
Khronos site to verify changes.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::beginPaint):
- 22:40 Changeset [52379] by
-
2009-12-18 Peter Kasting <pkasting@google.com>
Reviewed by Simon Fraser.
Add a comment about some confusing code that otherwise would look like
it might be a bug.
https://bugs.webkit.org/show_bug.cgi?id=32534
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):
- 22:33 Changeset [52378] by
-
2009-12-18 Adam Barth <abarth@webkit.org>
Rubber stamped by Eric Seidel.
Renamed WorkQueue to QueueEngine. WorkQueue is not a queue.
- Scripts/modules/commands/queues.py:
- Scripts/modules/queueengine.py: Added.
- Scripts/modules/queueengine_unittest.py: Added.
- Scripts/modules/stepsequence.py:
- Scripts/modules/workqueue.py: Removed.
- Scripts/modules/workqueue_unittest.py: Removed.
- 22:05 Changeset [52377] by
-
2009-12-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add watches for EWS
https://bugs.webkit.org/show_bug.cgi?id=32767
dglazkov wanted to be added.
- Scripts/modules/bugzilla.py:
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/queues.py:
- 22:02 Changeset [52376] by
-
Updated localizable strings after r52368
- English.lproj/Localizable.strings:
- 21:14 Changeset [52375] by
-
2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Messed up the XCode file, trying to fix.
- WebCore.xcodeproj/project.pbxproj:
- 20:44 Changeset [52374] by
-
2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed, fix typos in WebCore.xcodeproj.
- WebCore.xcodeproj/project.pbxproj:
- 20:34 Changeset [52373] by
-
2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Eric Seidel.
SVGAngle / SVGPreserveAspectRatio should be POD types
https://bugs.webkit.org/show_bug.cgi?id=32758
Convert SVGAngle / SVGPreserveAspectRatio to be non-refcounted types, just
like it has been done for SVGMatrix / SVGLength before.
This patch prepares removing the special DOMObjectWithSVGContext hack.
No change in functionality, thus no new tests.
- 18:34 Changeset [52372] by
-
Chromium build fix, no review.
- storage/chromium/DatabaseTrackerChromium.cpp:
- 18:04 Changeset [52371] by
-
Build fix, no review.
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::createFontPlatformData): Correct my typo
on the CG build.
- 18:03 Changeset [52370] by
-
Make DatabaseTrackerChromium::removeOpenDatabase() send and IPC on
the main thread when a database is being closed.
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=32627
- storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::removeOpenDatabaseOnMainThread):
(WebCore::DatabaseTracker::removeOpenDatabase):
- 17:59 Changeset [52369] by
-
Build fix, no review.
- page/win/FrameCairoWin.cpp: Add missing include.
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::createFontPlatformData): Conditionalize
Safari-only call.
- 17:56 Changeset [52368] by
-
Add Mac WebKit side of the client based geolocation provider.
Reviewed by Dan Bernstein.
WebKit:
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
- Misc/WebKitErrors.m:
(registerErrors): Add Geolocation errors.
- Misc/WebKitErrorsPrivate.h:
- WebCoreSupport/WebGeolocationControllerClient.h: Added.
(WebGeolocationControllerClient::webView):
- WebCoreSupport/WebGeolocationControllerClient.mm: Added.
(WebGeolocationControllerClient::WebGeolocationControllerClient):
(WebGeolocationControllerClient::startUpdating):
(WebGeolocationControllerClient::stopUpdating):
(WebGeolocationControllerClient::lastPosition):
Add implementation of the WebGeolocationControllerClient.
- WebView/WebGeolocationPosition.h: Added.
- WebView/WebGeolocationPosition.mm: Added.
(-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
(core):
(-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
- WebView/WebGeolocationPositionInternal.h: Added.
Add an Objective-C wrapper for GeolocationPosition.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Set the GeolocationControllerClient.
(-[WebView _setGeolocationProvider:]): Set the GeolocationProvider
(-[WebView _geolocationProvider]): Return the GeolocationProvider.
(-[WebView _geolocationDidChangePosition:]): Notify WebCore that the position changed.
(-[WebView _geolocationDidFailWithError:]): Notify WebCore that an error occured.
- WebView/WebViewData.h:
- WebView/WebViewPrivate.h:
- 17:27 Changeset [52367] by
-
Move some code related to database closing from the destructor to
the close() method. This would allow us to do things such as post
tasks to other threads when a database closes, which cannot be
done now, because we cannot increment the ref count to a database
object when we're in its destructor.
Reviewed by Dmitry Titov.
https://bugs.webkit.org/show_bug.cgi?id=32626
- storage/Database.cpp:
(WebCore::Database::~Database):
(WebCore::Database::close):
- 16:47 Changeset [52366] by
-
2009-12-18 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Chromium build fix
https://bugs.webkit.org/show_bug.cgi?id=32756
- public/WebAccessibilityRole.h: (WebKit::):
- src/AssertMatchingEnums.cpp:
- 16:40 Changeset [52365] by
-
Merge r52344.
- 16:40 Changeset [52364] by
-
Merge r52342.
- 16:40 Changeset [52363] by
-
Merge r52338.
- 16:40 Changeset [52362] by
-
Merge r52336.
- 16:40 Changeset [52361] by
-
Merge r52331.
- 16:40 Changeset [52360] by
-
Merge r52330.
- 16:40 Changeset [52359] by
-
Merge r52325.
- 16:39 Changeset [52358] by
-
Merge r52298.
- 16:39 Changeset [52357] by
-
Versioning.
- 16:33 Changeset [52356] by
-
2009-12-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
REGRESSION(52325) Chromium build broken due to link failure
https://bugs.webkit.org/show_bug.cgi?id=32753
- WebCoreSupport/WebSystemInterface.m:
- Chromium Mac builds use this file, but do not enable Pre-compiled Header (PCH) files so that Chromium build bots can take advantage of the faster distcc 3. Eventually all mac builds will likely use distcc, but for now we'll add Platform.h here and document its usage so it's not removed by accident.
- WebCoreSupport/WebSystemInterface.m:
- 16:29 Changeset [52355] by
-
2009-12-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Move some build decisions from Qt build system into source files
https://bugs.webkit.org/show_bug.cgi?id=31956
- JavaScriptCore.pri: Compile files unconditionally
- jit/ExecutableAllocatorPosix.cpp: Guard with PLATFORM(UNIX) && !PLATFORM(SYMBIAN)
- jit/ExecutableAllocatorWin.cpp: Guard with PLATFORM(WIN_OS)
- runtime/MarkStackPosix.cpp: Guard with PLATFORM(UNIX) && !PLATFORM(SYMBIAN)
- runtime/MarkStackSymbian.cpp: Guard with PLATFORM(SYMBIAN)
- runtime/MarkStackWin.cpp: Guard with PLATFORM(WIN_OS)
- wtf/Platform.h: Guard ENABLE_JSC_MULTIPLE_THREADS with ENABLE_SINGLE_THREADED for the Qt port
- wtf/ThreadingNone.cpp: Guard with ENABLE(SINGLE_THREADED)
- wtf/qt/ThreadingQt.cpp: Guard with !ENABLE(SINGLE_THREADED)
- 16:22 Changeset [52354] by
-
2009-12-18 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Crash when accessing webkitTransition property after setting webkitTransitionProperty with invalid value.
https://bugs.webkit.org/show_bug.cgi?id=31559
Fix an array bounds error when accessing the CSS value for a shorthand property that takes
a comma-separated list, after the list for one of the component properties has been set to a different length.
Test: fast/css/shorthand-mismatched-list-crash.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
- 16:09 Changeset [52353] by
-
New tag.
- 16:05 Changeset [52352] by
-
REGRESSION(r52233): MSAA: Accessibility role of lists is wrong
https://bugs.webkit.org/show_bug.cgi?id=32736
Reviewed by Adam Roben.
WebCore:
Test: platform/win/accessibility/list-role.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::roleValueForMSAA):
Return roleValue(), rather than m_role, as subclasses may override it.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::roleValueForMSAA):
Fallback to roleValue(), rather than m_role, as it may be overriden.
LayoutTests:
- platform/win/accessibility/list-role-expected.txt: Added.
- platform/win/accessibility/list-role.html: Added.
Verify that lists return the "list" role.
- 16:05 Changeset [52351] by
-
MSAA: Accessibility role of list items is wrong
https://bugs.webkit.org/show_bug.cgi?id=32688
Reviewed by Adam Roben.
WebCore:
Test: platform/win/accessibility/list-item-role.html
- accessibility/AccessibilityObject.h:
(WebCore::):
Add a ListItemRole to the enum.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::msaaRoleForRenderer):
Return the role for the RenderObject, or UnknownRole if unknown.
(WebCore::AccessibilityRenderObject::roleValueForMSAA):
Call msaaRoleForRenderer() to get the role. If it is UnknownRole, fall
back to m_role.
WebKit/win:
- AccessibleBase.cpp:
(MSAARole):
Make the WebCore list item role map to the MSAA list item role.
LayoutTests:
- platform/win/accessibility/list-item-role-expected.txt: Added.
- platform/win/accessibility/list-item-role.html: Added.
Verify that the list item role is "list item".
- 16:05 Changeset [52350] by
-
MSAA: Accessibility role of list markers is wrong
https://bugs.webkit.org/show_bug.cgi?id=32687
Reviewed by Adam Roben.
WebKit/win:
- AccessibleBase.cpp:
(MSAARole):
Make the WebCore list marker role map to the MSAA static text role.
LayoutTests:
- platform/win/accessibility/list-marker-role-expected.txt: Added.
- platform/win/accessibility/list-marker-role.html: Added.
Verify that the list marker role is "text".
- 16:00 Changeset [52349] by
-
2009-12-18 Simon Fraser <simon.fraser@apple.com>
Reviewed by Mark Rowe.
Remove WebCore.ClientBasedGeolocation.exp from Sources, and remove two IDL files from Resources.
- WebCore.xcodeproj/project.pbxproj:
- 15:57 Changeset [52348] by
-
Build fix part II, this time it's personal.x
- 15:46 Changeset [52347] by
-
First step at a Windows build fix, get it to link JavaScriptCore. Might fail later.
- 14:59 Changeset [52346] by
-
Add createNonCopying method to UString to make replace constructor passed bool,
to make behaviour more explicit. Add createFromUTF8 to UString (wrapping method
on UString::Rep), since other cases of transliteration (e.g. from ascii) are
performed in UString constructors. Add/use setHash & size() accessors on Rep,
rather than accessing _hash/len directly.
Reviewed by Sam Weinig.
- API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
- API/OpaqueJSString.cpp:
(OpaqueJSString::ustring):
- JavaScriptCore.exp:
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
- runtime/Identifier.cpp:
(JSC::Identifier::equal):
(JSC::CStringTranslator::translate):
(JSC::UCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
- runtime/JSString.h:
(JSC::JSString::Rope::Fiber::refAndGetLength):
(JSC::JSString::Rope::append):
- runtime/StringBuilder.h:
(JSC::StringBuilder::release):
- runtime/StringConstructor.cpp:
(JSC::stringFromCharCodeSlowCase):
- runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
- runtime/UString.cpp:
(JSC::UString::UString):
(JSC::UString::createNonCopying):
(JSC::UString::createFromUTF8):
- runtime/UString.h:
(JSC::UString::Rep::setHash):
(JSC::UString::~UString):
(JSC::makeString):
- 14:51 Changeset [52345] by
-
Fix mac Geolocation build.
- DerivedSources.make:
- WebCore.ClientBasedGeolocation.exp: Added.
- WebCore.xcodeproj/project.pbxproj:
- page/Geolocation.h:
- page/GeolocationError.h:
(WebCore::GeolocationError::GeolocationError):
- page/GeolocationPosition.h:
- 14:44 Changeset [52344] by
-
Fix preference key name.
Reviewed by Anders Carlsson.
- WebView/WebPreferenceKeysPrivate.h:
- 14:18 Changeset [52343] by
-
Changed Register constructors to assignment operators, to streamline
moving values into registers. (In theory, there's no difference between
the two, since the constructor should just inline away, but there seems
to be a big difference in the addled mind of the GCC optimizer.)
Reviewed by Cameron Zwarich and Gavin Barraclough.
In the interpreter, this is a 3.5% SunSpider speedup and a 1K-2K
reduction in stack usage per privateExecute stack frame.
- interpreter/CallFrame.h:
(JSC::ExecState::setCalleeArguments):
(JSC::ExecState::setCallerFrame):
(JSC::ExecState::setScopeChain):
(JSC::ExecState::init):
(JSC::ExecState::setArgumentCount):
(JSC::ExecState::setCallee):
(JSC::ExecState::setCodeBlock): Added a little bit of casting so these
functions could use the new Register assignment operators.
- interpreter/Register.h:
(JSC::Register::withInt):
(JSC::Register::Register):
(JSC::Register::operator=): Swapped in assignment operators for constructors.
- 14:05 Changeset [52342] by
-
Pass preference to plug-in host.
Reviewed by Sam Weinig.
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::spawnPluginHost):
- 13:57 Changeset [52341] by
-
Fixes <http://webkit.org/b/32613>.
REGRESSION (r52008): Middle-clicking on a linked image starts a pan scroll,
but should follow the link instead.
Reviewed by Adam Roben.
WebCore:
The node itself isn't the only possible node that can be a link (that was the
original check), any of its ancestors could be links as well, we need to climb
up the tree to see. Created a new function (enclosingAnchorNode), that finds a
node's enclosing anchor element (if it exists), that we can share between RenderLayer
and Node, and also added tests that test pan scrolling behavior in image maps.
Tests: platform/win/fast/events/panScroll-image-no-scroll.html
platform/win/fast/events/panScroll-imageMap-href-no-scroll.html
platform/win/fast/events/panScroll-imageMap-noHref-scroll.html
- dom/Node.cpp:
(WebCore::Node::enclosingAnchorNode):
(WebCore::Node::defaultEventHandler):
- dom/Node.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):
LayoutTests:
Added tests that test pan scrolling behavior when you middle click on images with
links, and if you click on parts on image maps that are links, and that aren't.
- platform/win/fast/events/panScroll-image-no-scroll-expected.txt: Added.
- platform/win/fast/events/panScroll-image-no-scroll.html: Added.
- platform/win/fast/events/panScroll-imageMap-href-no-scroll-expected.txt: Added.
- platform/win/fast/events/panScroll-imageMap-href-no-scroll.html: Added.
- platform/win/fast/events/panScroll-imageMap-noHref-scroll-expected.txt: Added.
- platform/win/fast/events/panScroll-imageMap-noHref-scroll.html: Added.
- 13:55 Changeset [52340] by
-
2009-12-18 Ariya Hidayat <ariya.hidayat@gmail.com>
Build fix, not reviewed.
- QtLauncher/main.cpp: (MainWindow::setTouchMocking): Leave setTouchMocking as an empty function for Qt < 4.6 so that moc still creates a slot for that. Otherwise, it would have generated a linker error.
- 13:45 Changeset [52339] by
-
2009-12-18 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
move bugzilla.py off of urllib2
https://bugs.webkit.org/show_bug.cgi?id=32729
- Scripts/modules/bugzilla.py: use mechanize for all url fetching.
- 13:43 Changeset [52338] by
-
Add WKPCRunSyncOpenPanel implementation.
Reviewed by Sam Weinig.
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCRunSyncOpenPanel):
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs:
- 13:18 Changeset [52337] by
-
2009-12-18 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=32713
[Qt] make wtf/Assertions.h compile in winscw compiler.
Add string arg before ellipsis to help winscw compiler resolve variadic
macro definitions in wtf/Assertions.h.
- wtf/Assertions.h:
- 13:17 Changeset [52336] by
-
Add a useProxiedOpenPanel WebPreference and tunnel it through to the plug-in host.
Reviewed by Sam Weinig.
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::hostForPackage):
(WebKit::NetscapePluginHostManager::spawnPluginHost):
(WebKit::NetscapePluginHostManager::instantiatePlugin):
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences usesProxiedOpenPanel]):
(-[WebPreferences setUsesProxiedOpenPanel:]):
- WebView/WebPreferencesPrivate.h:
- 12:50 Changeset [52335] by
-
[GTK] RemoveDashboard support. It's useless.
- configure.ac:
- 12:46 Changeset [52334] by
-
Fixed intermittent failure seen on Windows buildbot, and in other JSC
API clients.
Reviewed by Adam Roben.
Added a WeakGCPtr class and changed OpaqueJSClass::cachedPrototype to
use it, to avoid vending a stale object as a prototype.
- API/JSClassRef.cpp:
(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::prototype):
- API/JSClassRef.h: Use WeakGCPtr.
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/WeakGCPtr.h: Added.
(JSC::WeakGCPtr::WeakGCPtr):
(JSC::WeakGCPtr::get):
(JSC::WeakGCPtr::clear):
(JSC::WeakGCPtr::operator*):
(JSC::WeakGCPtr::operator->):
(JSC::WeakGCPtr::operator!):
(JSC::WeakGCPtr::operator bool):
(JSC::WeakGCPtr::operator UnspecifiedBoolType):
(JSC::WeakGCPtr::assign):
(JSC::::operator):
(JSC::operator==):
(JSC::operator!=):
(JSC::static_pointer_cast):
(JSC::const_pointer_cast):
(JSC::getPtr): Added WeakGCPtr to the project.
- 12:45 Changeset [52333] by
-
Add a needed export to fix the Windows build.
- 12:42 Changeset [52332] by
-
2009-12-18 Christian Dywan <christian@twotoasts.de>
Reviewed by Xan Lopez.
[GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546
Omit SearchWeb from the context menu in the GTK+ port.
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
- 12:41 Changeset [52331] by
-
Add export the new symbol in WebCoreSystemInterface.
Reviewed by Anders Carlsson.
- WebCore.base.exp:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- 12:26 Changeset [52330] by
-
Forward declare NSMutableArray when not compiling for Objective-C.
Reviewed by Anders Carlsson.
- platform/mac/WebCoreSystemInterface.h:
- 12:02 Changeset [52329] by
-
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=32720
Reviewed by Sam Weinig.
- JavaScriptCore.exp:
- Remove exports for UString::append
- JavaScriptCore.xcodeproj/project.pbxproj:
- Make StringBuilder a private header (was project).
WebCore: https://bugs.webkit.org/show_bug.cgi?id=32720
Replace UString addition/append with use of JSC::StringBuilder.
Reviewed by Sam Weinig.
- ForwardingHeaders/runtime/StringBuilder.h: Added.
- bindings/js/ScriptString.h:
(WebCore::ScriptString::operator+=):
- bridge/jni/jni_runtime.cpp:
(appendClassName):
(JavaMethod::signature):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::addProfileFinishedMessageToConsole):
(WebCore::InspectorController::addStartProfilingMessageToConsole):
(WebCore::InspectorController::getCurrentUserInitiatedProfileName):
- JavaScriptCore.exp:
- 11:55 Changeset [52328] by
-
2009-12-18 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] GRefPtr does not take a reference when assigned a raw pointer
https://bugs.webkit.org/show_bug.cgi?id=32709
Ensure that when assigning a raw pointer to a GRefPtr, the reference
count is incremented. Also remove the GRefPtr conversion overload as
GRefPtr types have necessarily incompatible reference counting.
- wtf/gtk/GRefPtr.h: (WTF::GRefPtr::operator=):
- 11:43 Changeset [52327] by
-
2009-12-18 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Index validation for drawElements examines too many indices
https://bugs.webkit.org/show_bug.cgi?id=32692
- fast/canvas/webgl/bug-32692-expected.txt: Added.
- fast/canvas/webgl/bug-32692.html: Added.
2009-12-18 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Index validation for drawElements examines too many indices
https://bugs.webkit.org/show_bug.cgi?id=32692
Test: fast/canvas/webgl/bug-32692.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
- 11:36 Changeset [52326] by
-
2009-12-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Disable page cache for tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (copyWebSettingKey): (LayoutTestController::overridePreference):
- 11:22 Changeset [52325] by
-
WebCore: Update WebKitSystemInterface for <rdar://problem/7237059>.
Reviewed by Anders Carlsson.
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
WebKit/mac: Update WebKitSystemInterface for <rdar://problem/7237059>.
Reviewed by Anders Carlsson.
- WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
WebKitLibraries: Update WebKitSystemInterface for <rdar://problem/7237059>.
Reviewed by Anders Carlsson.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 11:16 Changeset [52324] by
-
Rubber-stamped by Adam Roben.
Add expected failing results for fast/dom/Element/id-in-deleteutton.html.
The progress of fixing the failure is being tracked by:
<https://bugs.webkit.org/show_bug.cgi?id=32727>.
- platform/win/fast/dom/Element: Added.
- platform/win/fast/dom/Element/id-in-deletebutton-expected.txt: Added.
- 10:48 Changeset [52323] by
-
2009-12-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Fix gtk-doc of webkit_web_resource_new.
- webkit/webkitwebresource.cpp:
- 10:35 Changeset [52322] by
-
GTK build fix
- plugins/gtk/PluginViewGtk.cpp: Added #include.
- 10:00 Changeset [52321] by
-
Build fixes
WebCore: Chromium build fix
- platform/chromium/PopupMenuChromium.cpp: Added #include.
WebKit/chromium: Chromium build fix
- src/ChromiumBridge.cpp:
- src/WebPluginContainerImpl.cpp:
- src/WebViewImpl.cpp:
Added #includes.
WebKit/qt: Qt build fix
- Api/qwebpage.cpp: Added #include.
- 09:54 Changeset [52320] by
-
Chromium build fix
- html/HTMLLinkElement.cpp: Added #include.
- 09:52 Changeset [52319] by
-
Qt build fix
WebCore:
- platform/qt/RenderThemeQt.cpp:
- plugins/qt/PluginDataQt.cpp:
- plugins/qt/PluginViewQt.cpp:
Added #includes.
WebKit/qt:
- Api/qwebpage.cpp:
Added #includes.
- 09:47 Changeset [52318] by
-
2009-12-18 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Check one space before end of line comments.
https://bugs.webkit.org/show_bug.cgi?id=32597
Fix to check one space before end of line comments in whitespace and build/header_guard.
Also fix build/header_guard to use WebKit header guard defines.
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 09:47 Changeset [52317] by
-
V8 build fix
- bindings/v8/custom/V8DOMWindowCustom.cpp: Added #include.
- 09:45 Changeset [52316] by
-
GTK build fix
- webkit/webkitprivate.cpp: Added #include.
- 09:42 Changeset [52315] by
-
GTK (and others?) build fix
- platform/text/StringImpl.h: Added #include.
- 09:38 Changeset [52314] by
-
Reduce #includes in a few high-use headers
Removed unnecessary #includes in these headers:
- Frame.h
- FrameWin.h
- Node.h
- Page.h
- StringImpl.h
The rest of the patch is all adding #includes to source files that now
require them.
Fixes <http://webkit.org/b/32718>.
Rubber-stamped by Anders Carlsson.
WebCore:
- dom/Node.h:
- page/Frame.h:
- page/Page.h:
- page/win/FrameWin.h:
- platform/text/StringImpl.h:
Removed unnecessary #includes.
- accessibility/win/AXObjectCacheWin.cpp:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowCustom.cpp:
- dom/Document.cpp:
- dom/InputElement.cpp:
- dom/Node.cpp:
- dom/SelectElement.cpp:
- editing/EditorCommand.cpp:
- html/HTMLFormControlElement.cpp:
- html/HTMLFormElement.cpp:
- html/HTMLMediaElement.cpp:
- html/HTMLParser.cpp:
- html/HTMLTextAreaElement.cpp:
- html/HTMLVideoElement.cpp:
- inspector/InspectorController.cpp:
- loader/FrameLoader.cpp:
- loader/HistoryController.cpp:
- loader/appcache/ApplicationCacheGroup.cpp:
- page/Console.cpp:
- page/EventHandler.cpp:
- page/Frame.cpp:
- page/FrameView.cpp:
- page/Navigator.cpp:
- page/PageGroup.cpp:
- page/Settings.cpp:
- page/mac/EventHandlerMac.mm:
- platform/KURL.h:
- platform/ScrollbarThemeComposite.cpp:
- platform/cf/BinaryPropertyList.cpp:
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/win/WKCACFLayerRenderer.cpp:
- platform/mac/PopupMenuMac.mm:
- platform/mac/WidgetMac.mm:
- platform/network/cf/DNSCFNet.cpp:
- platform/text/StringImpl.cpp:
- platform/win/FileSystemWin.cpp:
- platform/win/PlatformScreenWin.cpp:
- platform/win/PopupMenuWin.cpp:
- platform/win/WidgetWin.cpp:
- plugins/PluginView.cpp:
- plugins/win/PluginViewWin.cpp:
- rendering/InlineTextBox.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderFileUploadControl.cpp:
- rendering/RenderInline.cpp:
- rendering/RenderLayerCompositor.cpp:
- rendering/RenderObject.cpp:
- rendering/RootInlineBox.cpp:
- storage/DatabaseTracker.cpp:
- storage/DatabaseTracker.h:
- storage/SQLTransactionClient.cpp:
- svg/graphics/SVGImage.cpp:
Added now-needed #includes.
WebKit/mac:
Add #includes needed after WebCore clean-up
- WebView/WebFrame.mm:
- WebView/WebFrameView.mm:
- WebView/WebView.mm:
WebKit/win:
Add #includes needed after WebCore clean-up
- WebCoreSupport/WebContextMenuClient.cpp:
- WebDataSource.cpp:
- WebHTMLRepresentation.cpp:
- WebView.cpp:
- WebView.h:
- 09:06 Changeset [52313] by
-
[Qt] Clean up the qmake build system to distinguish between trunk builds and package builds
Reviewed by Tor Arne Vestbø.
https://bugs.webkit.org/show_bug.cgi?id=32716
.:
- WebKit.pri: Use standalone_package instead of QTDIR_build
- pcre/pcre.pri: Use standalone_package instead of QTDIR_build
WebCore:
Introduce standalone_package as config that is set when QTDIR_build is set or when
the directory for the generated files is present.
Renamed uses of QTDIR_build that apply to generic package builds to use standalone_package.
Others remain as they are specific to building inside Qt.
- WebCore.pro:
- 08:56 QtWebKitPerformanceWork edited by
- Minor spelling correction (diff)
- 08:40 Changeset [52312] by
-
2009-12-18 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Darin Adler.
New test cases for isId support.
https://bugs.webkit.org/show_bug.cgi?id=5578
- dom/xhtml/level3/core/attrisid04-expected.txt:
- dom/xhtml/level3/core/attrisid04.js: (setUpPage):
- dom/xhtml/level3/core/attrisid05-expected.txt:
- dom/xhtml/level3/core/attrisid05.js: (setUpPage):
- fast/dom/Element/attrisid-extra01-expected.txt: Added.
- fast/dom/Element/attrisid-extra01.html: Added.
- fast/dom/Element/id-in-applet-expected.txt: Added.
- fast/dom/Element/id-in-applet.html: Added.
- fast/dom/Element/id-in-deletebutton-expected.txt: Added.
- fast/dom/Element/id-in-deletebutton.html: Added.
- fast/dom/Element/id-in-formcollection-expected.txt: Added.
- fast/dom/Element/id-in-formcollection.html: Added.
- fast/dom/Element/id-in-frame-expected.txt: Added.
- fast/dom/Element/id-in-frame.html: Added.
- fast/dom/Element/id-in-frameset-expected.txt: Added.
- fast/dom/Element/id-in-frameset.html: Added.
- fast/dom/Element/id-in-getelement01-expected.txt: Added.
- fast/dom/Element/id-in-getelement01.html: Added.
- fast/dom/Element/id-in-insert-hr-expected.txt: Added.
- fast/dom/Element/id-in-insert-hr.html: Added.
- fast/dom/Element/id-in-map-expected.txt: Added.
- fast/dom/Element/id-in-map.html: Added.
- fast/dom/Element/id-in-param-expected.txt: Added.
- fast/dom/Element/id-in-param.html: Added.
2009-12-18 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Darin Adler.
Implemented isId as specified by DOM Level 3. See detailed description below.
https://bugs.webkit.org/show_bug.cgi?id=5578
Added isId property and implementation:
Tests: dom/xhtml/level3/core/attrisid01-07.xhtml
fast/dom/Element/attrisid-extra01.html
- dom/Attr.cpp: (WebCore::Attr::isId):
- dom/Attr.h:
- dom/Attr.idl:
Replaced instances of HTMLNames::idAttr with Element::idAttributeName()
for the reason that id attribute name could be customized to a different
string other than "id". A test case is associated to each code change.
- dom/Document.cpp: (WebCore::Document::getElementById): Test: fast/dom/Element/id-in-getelement01.html
- dom/Element.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml (WebCore::Element::setAttribute): (WebCore::Element::setAttributeMap): (WebCore::Element::insertedIntoDocument): (WebCore::Element::removedFromDocument): (WebCore::Element::formatForDebugger): (WebCore::Element::rareIDAttributeName):
- dom/Element.h: Added function idAttributeName(). (WebCore::Element::idAttributeName):
- dom/ElementRareData.h: Added member variable to store customized id name in ElementRareData. (WebCore::ElementRareData::ElementRareData):
- dom/NamedAttrMap.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml (WebCore::NamedNodeMap::setNamedItem): (WebCore::NamedNodeMap::removeNamedItem): (WebCore::NamedNodeMap::setAttributes):
- dom/Node.cpp: Removed ASSERT as it may not hold any more. (WebCore::Node::querySelector):
- dom/SelectorNodeList.cpp: Removed ASSERT as it may not hold any more. (WebCore::createSelectorNodeList):
- dom/StyledElement.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml (WebCore::StyledElement::parseMappedAttribute):
- editing/DeleteButtonController.cpp: Test: fast/dom/Element/id-in-deletebutton.html (WebCore::DeleteButtonController::createDeletionUI):
- editing/EditorCommand.cpp: Test: fast/dom/Element/id-in-insert-hr.html (WebCore::executeInsertHorizontalRule):
- html/HTMLAppletElement.cpp: Test: fast/dom/Element/id-in-applet.html (WebCore::HTMLAppletElement::parseMappedAttribute): (WebCore::HTMLAppletElement::createRenderer):
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): Test: fast/forms/select-namedItem.html (WebCore::HTMLCollection::updateNameCache): Test: fast/dom/collection-namedItem-via-item.html
- html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::ensureColumn): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom.html (WebCore::HTMLDataGridColElement::parseMappedAttribute): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html
- html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
- html/HTMLFormCollection.cpp: Test: fast/dom/Element/id-in-formcollection.html (WebCore::HTMLFormCollection::getNamedFormItem): (WebCore::HTMLFormCollection::nextNamedItem): (WebCore::HTMLFormCollection::updateNameCache):
- html/HTMLFrameElementBase.cpp: Test: fast/dom/Element/id-in-frame.html (WebCore::HTMLFrameElementBase::parseMappedAttribute): (WebCore::HTMLFrameElementBase::setNameAndOpenURL):
- html/HTMLImageElement.cpp: Test: fast/dom/Element/id-in-deletebutton.html (WebCore::HTMLImageElement::parseMappedAttribute):
- html/HTMLMapElement.cpp: Test: fast/dom/Element/id-in-map.html (WebCore::HTMLMapElement::parseMappedAttribute):
- html/HTMLNameCollection.cpp: Test: fast/dom/Element/id-in-frameset.html (WebCore::HTMLNameCollection::itemAfter):
- html/HTMLObjectElement.cpp: Test: fast/dom/HTMLDocument/object-by-name-or-id.html (WebCore::HTMLObjectElement::parseMappedAttribute):
- html/HTMLParamElement.cpp: Test: fast/dom/Element/id-in-param.html (WebCore::HTMLParamElement::parseMappedAttribute):
- loader/CachedFont.cpp: Test: svg/custom/acid3-test-77.html (WebCore::CachedFont::getSVGFontById):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): Debug-only code
- rendering/SVGRenderTreeAsText.cpp: Test: svg/text/text-gradient-positioning.svg (WebCore::writeRenderResources):
- svg/SVGElement.cpp: Test: svg/custom/acid3-test-77.html (WebCore::SVGElement::insertedIntoDocument):
- svg/SVGStyledElement.cpp: Test: svg/custom/js-update-image-and-display.svg (WebCore::SVGStyledElement::isKnownAttribute):
- wml/WMLElement.cpp: (WebCore::WMLElement::parseMappedAttribute):
- 07:04 Changeset [52311] by
-
2009-12-18 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add new API to QWebFrame to scrollRecursively starting with any css overflow
then checking current frame and then ancestors
https://bugs.webkit.org/show_bug.cgi?id=32668
- Api/qwebframe.cpp: (QWebFramePrivate::scrollOverflow): (QWebFrame::scrollRecursively):
- Api/qwebframe.h:
- Api/qwebframe_p.h:
- tests/qwebframe/qwebframe.qrc:
- tests/qwebframe/testiframe.html: Added.
- tests/qwebframe/testiframe2.html: Added.
- tests/qwebframe/tst_qwebframe.cpp:
- 06:03 Changeset [52310] by
-
[Qt] Fix the build on Symbian.
Reviewed by Tor Arne Vestbø.
Use QFont::lastRestortFamily() instead of QFont::lastRestortFont(),
which is a missing symbol in Qt 4.6.0 on Symbian.
Functionally they should be equivalent, according to the source.
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- 06:01 Changeset [52309] by
-
2009-12-18 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] segfault during controls initialization if not GTK theme is present.
https://bugs.webkit.org/show_bug.cgi?id=32705
Create empty images for the controls if no GTK theme is set.
- platform/graphics/gtk/ImageGtk.cpp: (WebCore::getThemeIconFileName): (WebCore::loadImageFromFile):
- 05:38 Changeset [52308] by
-
Revert r52305, since it breaks many http tests. We will try a better
solution for Soup.
- 05:32 Changeset [52307] by
-
[Qt] Fix infinite recursion in touch mocking.
Reviewed by Tor Arne Vestbø.
Don't send the fake touch events to the view, as that'll trigger the
event filter again.
- QtLauncher/main.cpp:
(MainWindow::sendTouchEvent):
- 04:00 Changeset [52306] by
-
2009-12-18 Kalle Vahlman <kalle.vahlman@movial.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Add enable-page-cache property to WebSettings for disabling the Page Cache
- webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
- webkit/webkitwebview.cpp:
- 02:51 Changeset [52305] by
-
Remove the fragment identifier from url before passing it to libsoup.
In newer releases libsoup emits a warning when it gets handed a
fragment.
- 02:37 Changeset [52304] by
-
2009-12-18 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Compile warning from line 29 of GRefPtr.cpp
https://bugs.webkit.org/show_bug.cgi?id=32703
Fix memory leak and compiler warning in GRefPtr GHashTable template
specialization.
- wtf/gtk/GRefPtr.cpp: (WTF::refGPtr):
- 01:50 Changeset [52303] by
-
2009-12-18 Alejandro G. Castro <alex@igalia.com>
Reviewed by Darin Adler.
REGRESSION (r38898): Using the up arrow in a textarea gets "stuck"
at the beginning.
https://bugs.webkit.org/show_bug.cgi?id=31920
Added test showing the problem described in the bug.
- editing/selection/wrapped-line-caret-3.html:
- editing/selection/wrapped-line-caret-3-expected.txt:
2009-12-18 Alejandro G. Castro <alex@igalia.com>
Reviewed by Darin Adler.
REGRESSION (r38898): Using the up arrow in a textarea gets "stuck"
at the beginning.
https://bugs.webkit.org/show_bug.cgi?id=31920
Moving up from a position after the end of the previous lines
should use UPSTREAM affinity to render the caret in the previous
line.
Test: editing/selection/wrapped-line-caret-3.html
- rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint):
12/17/09:
- 23:17 Changeset [52302] by
-
2009-12-17 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
HTMLInputElement::stepMismatch() uses ambiguous overload of pow()
https://bugs.webkit.org/show_bug.cgi?id=32675
Use the double constant 2.0 instead of static_cast<double>(2).
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepMismatch):
- 22:39 Changeset [52301] by
-
2009-12-17 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Upstreaming an XSS test from chromium.org.
https://bugs.webkit.org/show_bug.cgi?id=32685
- http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt: Added.
- http/tests/security/xss-DENIED-assign-location-href-javascript.html: Added.
- 22:12 Changeset [52300] by
-
2009-12-17 Justin Schuh <jschuh@chromium.org>
Reviewed by Dan Bernstein.
Bug 32357: SVG test case crashes WebKit (invalid font URL)
https://bugs.webkit.org/show_bug.cgi?id=32357
Added check for NULL return value from DocLoader::requestFont()
- svg/text/text-font-uri-invalid-expected.txt: Added.
- svg/text/text-font-uri-invalid.svg: Added.
2009-12-17 Justin Schuh <jschuh@chromium.org>
Reviewed by Dan Bernstein.
Bug 32357: SVG test case crashes WebKit (invalid font URL)
https://bugs.webkit.org/show_bug.cgi?id=32357
Added check for NULL return value from DocLoader::requestFont()
- svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::loadFont):
- 21:42 Changeset [52299] by
-
2009-12-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
marquee with display:inline causes crash
https://bugs.webkit.org/show_bug.cgi?id=32374
- fast/inline/inline-marquee-crash-expected.txt: Added.
- fast/inline/inline-marquee-crash.html: Added.
2009-12-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
marquee with display:inline causes crash
https://bugs.webkit.org/show_bug.cgi?id=32374
Test: fast/inline/inline-marquee-crash.html
- html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::start): (WebCore::HTMLMarqueeElement::stop): (WebCore::HTMLMarqueeElement::suspend): (WebCore::HTMLMarqueeElement::resume): (WebCore::HTMLMarqueeElement::renderMarquee):
- html/HTMLMarqueeElement.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged):
- 20:14 Changeset [52298] by
-
JavaScriptCore: Add BUILDING_ON_SNOW_LEOPARD and TARGETING_SNOW_LEOPARD #defines.
Reviewed by Mark Rowe.
- wtf/Platform.h:
WebKitTools: Add BUILDING_ON_SNOW_LEOPARD #define.
Reviewed by Mark Rowe.
- DumpRenderTree/mac/DumpRenderTreeMac.h:
- 20:12 Changeset [52297] by
-
Unreviewed. Unskip websocket tests
New pywebsocket (0.4.5) landed at WebKit r52296, so
sub-protocol-with-space.html should pass.
- platform/mac/Skipped: delete websocket/tests/sub-protocol-with-space.html
- platform/win/Skipped: delete websocket/tests/sub-protocol-with-space.html
- 18:38 Changeset [52296] by
-
2009-12-17 Yuzo Fujishima <yuzo@google.com>
Reviewed by Alexey Proskuryakov.
Update pywebsocket to 0.4.5 and make handshake checking stricter
https://bugs.webkit.org/show_bug.cgi?id=32249
- Scripts/run-webkit-tests:
- pywebsocket/mod_pywebsocket/handshake.py:
- pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
- pywebsocket/mod_pywebsocket/standalone.py:
- pywebsocket/setup.py:
- pywebsocket/test/test_handshake.py:
- pywebsocket/test/test_memorizingfile.py: Added.
- 17:28 Changeset [52295] by
-
2009-12-17 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Command.show_in_main_help should default to False
https://bugs.webkit.org/show_bug.cgi?id=32686
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/queries.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/commands/upload.py:
- Scripts/modules/multicommandtool.py:
- 16:51 Changeset [52294] by
-
2009-12-17 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for inspector's classes
https://bugs.webkit.org/show_bug.cgi?id=32660
Inherits the following classes from Noncopyable because these are
instantiated by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class JavaScriptDebugServer - inspector/JavaScriptDebugServer.cpp:72
class ConsoleMessage - inspector/InspectorController.cpp:329
class InspectorController - page/Page.cpp:119
- inspector/ConsoleMessage.h:
- inspector/InspectorController.h:
- inspector/JavaScriptDebugServer.h:
- 15:22 Changeset [52293] by
-
2009-12-17 Eric Seidel <eric@webkit.org>
No review, rolling out r52291.
http://trac.webkit.org/changeset/52291
https://bugs.webkit.org/show_bug.cgi?id=32618
Darin Fisher points out that this will likely break
the SSL security indicator in Chromium. Rolling out for now.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
- 14:37 Changeset [52292] by
-
2009-12-17 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Fixes HTMLInputElement::stepMismatch() to avoid ambiguous overload of pow().
https://bugs.webkit.org/show_bug.cgi?id=32675
Build fix only, no new tests.
- html/HTMLInputElement.cpp: Modified. (WebCore::HTMLInputElement::stepMismatch): Cast first argument of pow to double to force 'double pow(double, int)'
- 14:14 Changeset [52291] by
-
2009-12-17 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Eric Seidel.
Disable memory cache client calls so that a new identifier isn't created
for the same resource on reload.
With the calls enabled, duplicate entries for cached resources are created
in the Web Inspector. Safari for Windows disables the calls near the point of the
Frame instance creation, and we just follow this for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=32618
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
- 14:10 Changeset [52290] by
-
Versioning.
- 14:09 Changeset [52289] by
-
New tag.
- 13:52 Changeset [52288] by
-
2009-12-17 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Eric Seidel.
Fix link failure on LTCG builds on Windows for chromium port.
Reenable SVGAllInOne.cpp. This required some fixups.
Namely, there was conflicts in constants between HTMLNames and
SVGNames, and conflicts between static functions names.
No new tests as functionality has not changed.
- WebCore.gyp/WebCore.gyp:
- svg/SVGAllInOne.cpp:
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace):
- svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::invalidateGlyphCache): (WebCore::SVGGlyphElement::buildGlyphIdentifier):
- svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::insertedIntoDocument): (WebCore::SVGHKernElement::removedFromDocument):
- svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::type): (WebCore::SVGStyleElement::setType): (WebCore::SVGStyleElement::media): (WebCore::SVGStyleElement::setMedia): (WebCore::SVGStyleElement::title): (WebCore::SVGStyleElement::setTitle): (WebCore::SVGStyleElement::parseMappedAttribute):
- svg/SVGStyledElement.cpp: (WebCore::mapAttributeToCSSProperty): (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
- svg/SVGStyledElement.h:
- 13:38 Changeset [52287] by
-
Chromium build fix VI
- svg/animation/SMILTimeContainer.h: Added now-needed #include.
- 13:37 Changeset [52286] by
-
Chromium build fix V
- platform/KURLGoogle.cpp: Added now-needed #include.
- 13:29 Changeset [52285] by
-
Chromium build fix IV
- loader/CrossOriginPreflightResultCache.h: Added now-needed
- 13:26 Changeset [52284] by
-
2009-12-17 Alejandro G. Castro <alex@igalia.com>
Reviewed by Eric Seidel.
Added the key WebKitEnableCaretBrowsing to the
layoutTestController.overridePreference in order to activate caret
browsing.
https://bugs.webkit.org/show_bug.cgi?id=32612
- DumpRenderTree/gtk/DumpRenderTree.cpp: Added the reset value of the setting.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Inserted the new key in the keytable.
- 13:19 Changeset [52283] by
-
Chromium build fix III
- platform/graphics/Font.h: Added now-needed #include.
- 13:10 Changeset [52282] by
-
Chromium build fix II
- dom/EventTarget.h: Added now-needed #include.
- 13:09 Changeset [52281] by
-
2009-12-17 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Eric Seidel.
Allow custom memory allocation control for js bindings
https://bugs.webkit.org/show_bug.cgi?id=32655
Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class ScriptCachedFrameData - history/CachedFrame.cpp:117
class WebCoreJSClientData - bindings/js/JSDOMWindowBase.cpp:162
class ScheduledAction - bindings/js/ScheduledAction.cpp:58
- bindings/js/JSDOMBinding.h:
- bindings/js/ScheduledAction.h:
- bindings/js/ScriptCachedFrameData.h:
- 12:56 Changeset [52280] by
-
Chromium build fix
- dom/QualifiedName.h: Added now-needed #include of HashTraits.h
(which itself #includes HashFunctions.h).
- 12:53 Changeset [52279] by
-
2009-12-17 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
Reviewed by Timothy Hatcher.
Web Inspector: Incorrect Doctype.
REGRESSION(4.0.4-TOT):Web Inspector: Incorrect Doctype
https://bugs.webkit.org/show_bug.cgi?id=32671
- inspector/elements-panel-structure-expected.txt:
- inspector/elements-panel-structure.html:
2009-12-17 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
Reviewed by Timothy Hatcher.
Web Inspector: Incorrect Doctype.
REGRESSION(4.0.4-TOT):Web Inspector: Incorrect Doctype
https://bugs.webkit.org/show_bug.cgi?id=32671
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
- 12:38 Changeset [52278] by
-
Don't include all JSC headers everywhere
https://bugs.webkit.org/show_bug.cgi?id=32663
Patch by Benjamin Otte <otte@gnome.org> on 2009-12-17
Reviewed by Adam Roben.
Remove HashMap HashSet and OwnPtr includes from PlatformString.h.
Reduces code size of Gtk build by another 5%.
- platform/text/PlatformString.h:
- 12:32 Changeset [52277] by
-
Mac build fix
- WebView/WebVideoFullscreenController.mm: Added now-needed #import.
- 12:22 Changeset [52276] by
-
Mac/Qt build fixes
- platform/graphics/mac/Canvas3DLayer.mm:
- platform/graphics/mac/GraphicsContext3DMac.cpp:
- platform/qt/Localizations.cpp:
Added missing #includes.
- 12:00 Changeset [52275] by
-
Don't include all JSC headers everywhere
https://bugs.webkit.org/show_bug.cgi?id=32663
Patch by Benjamin Otte <otte@gnome.org> on 2009-12-17
Reviewed by Adam Roben.
WebCore:
PlatformString.h included almost all of JSC via runtime/Identifier.h.
This patch gets rid of this include by forward-declaring the required
classes instead.
This reduces the build size of the object files on a Gtk debug build
by 10%. The resulting libwebkit.so gets 5% smaller.
No new tests as it's just a build improvement.
- platform/gtk/LocalizedStringsGtk.cpp:
include math.h here (it used to be pulled by JSC)
- platform/text/PlatformString.h:
- platform/text/String.cpp:
WebKit/win:
- WebCoreLocalizedStrings.cpp: Added now-needed #include of
MathExtras.h.
- 11:59 Changeset [52274] by
-
2009-12-17 Evan Martin <evan@chromium.org>
Reviewed by Xan Lopez.
Always use all WebCore include paths in GtkWebKit.
With this patch, I can disable all optional features and still build.
- GNUmakefile.am:
- 11:58 Changeset [52273] by
-
Unreviewed layout test fix.
WAI-ARIA: implement treegrid
https://bugs.webkit.org/show_bug.cgi?id=31299
The test for this patch shouldn't be run on Tiger.
- platform/mac-tiger/Skipped:
- 11:48 Changeset [52272] by
-
AX: DRT needs to support URL for accessibility
https://bugs.webkit.org/show_bug.cgi?id=32666
Reviewed by David Kilzer.
- DumpRenderTree/AccessibilityUIElement.cpp:
(getURLCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::url):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::url):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::url):
- 11:36 Changeset [52271] by
-
Unreviewed; added myself to committers
- Scripts/modules/committers.py:
- 11:23 Changeset [52270] by
-
2009-12-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
More make distcheck fixes. Use a more robust solution to making
sure we are in the correct directory for running these tests.
- tests/testmimehandling.c: (main):
- tests/testwebview.c: (main):
- 11:21 Changeset [52269] by
-
Unreviewed; added myself to committers
- 11:18 Changeset [52268] by
-
2009-12-17 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
Added WebPageSerializer to WebKit API and enriched the WebNode hierarchy to support
downstream unit-testing of serialization.
WebPageSerializer was adapted from Chromium's dom_serializer, originally authored by Johnny Ding.
- WebKit.gyp:
- public/WebDocument.h: Added. (WebKit::WebDocument::WebDocument): (WebKit::WebDocument::operator=): (WebKit::WebDocument::assign):
- public/WebElement.h:
- public/WebFormElement.h: (WebKit::WebFormElement::operator=):
- public/WebFrame.h:
- public/WebNode.h: (WebKit::WebNode::): (WebKit::WebNode::toConstElement):
- public/WebNodeCollection.h: Added. (WebKit::WebNodeCollection::~WebNodeCollection): (WebKit::WebNodeCollection::WebNodeCollection): (WebKit::WebNodeCollection::operator=):
- public/WebNodeList.h: Added. (WebKit::WebNodeList::~WebNodeList): (WebKit::WebNodeList::WebNodeList): (WebKit::WebNodeList::operator=):
- public/WebPageSerializer.h: Added.
- public/WebPageSerializerClient.h: Added. (WebKit::WebPageSerializerClient::): (WebKit::WebPageSerializerClient::WebPageSerializerClient): (WebKit::WebPageSerializerClient::~WebPageSerializerClient):
- public/WebString.h:
- public/WebView.h:
- src/AssertMatchingEnums.cpp:
- src/DOMUtilitiesPrivate.cpp: (WebKit::elementHasLegalLinkAttribute):
- src/DOMUtilitiesPrivate.h:
- src/WebDocument.cpp: Added. (WebKit::WebDocument::WebDocument): (WebKit::WebDocument::operator=): (WebKit::WebDocument::operator WTF::PassRefPtr<Document>): (WebKit::WebDocument::frame): (WebKit::WebDocument::isHTMLDocument): (WebKit::WebDocument::baseURL): (WebKit::WebDocument::body): (WebKit::WebDocument::head): (WebKit::WebDocument::all): (WebKit::WebDocument::completeURL):
- src/WebElement.cpp: (WebKit::WebElement::hasTagName): (WebKit::WebElement::hasAttribute): (WebKit::WebElement::getAttribute):
- src/WebEntities.cpp: Added. (WebKit::populateMap): (WebKit::): (WebKit::WebEntities::WebEntities): (WebKit::WebEntities::entityNameByCode): (WebKit::WebEntities::convertEntitiesInString):
- src/WebEntities.h: Added.
- src/WebFrameImpl.cpp: (WebKit::WebFrame::fromFrameOwnerElement): (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::document): (WebKit::WebFrameImpl::fromFrameOwnerElement):
- src/WebFrameImpl.h:
- src/WebNode.cpp: (WebKit::WebNode::nodeType): (WebKit::WebNode::nodeValue): (WebKit::WebNode::document): (WebKit::WebNode::firstChild): (WebKit::WebNode::lastChild): (WebKit::WebNode::previousSibling): (WebKit::WebNode::nextSibling): (WebKit::WebNode::hasChildNodes): (WebKit::WebNode::childNodes): (WebKit::WebNode::createMarkup): (WebKit::WebNode::isTextNode): (WebKit::WebNode::isElementNode):
- src/WebNodeCollection.cpp: Added. (WebKit::WebNodeCollection::reset): (WebKit::WebNodeCollection::assign): (WebKit::WebNodeCollection::WebNodeCollection): (WebKit::WebNodeCollection::length): (WebKit::WebNodeCollection::nextItem): (WebKit::WebNodeCollection::firstItem):
- src/WebNodeList.cpp: Added. (WebKit::WebNodeList::reset): (WebKit::WebNodeList::assign): (WebKit::WebNodeList::WebNodeList): (WebKit::WebNodeList::length): (WebKit::WebNodeList::item):
- src/WebPageSerializer.cpp: Added. (WebKit::WebPageSerializer::serialize): (WebKit::WebPageSerializer::generateMetaCharsetDeclaration): (WebKit::WebPageSerializer::generateMarkOfTheWebDeclaration): (WebKit::WebPageSerializer::generateBaseTagDeclaration):
- src/WebPageSerializerImpl.cpp: Added. (WebKit::WebPageSerializerImpl::SerializeDomParam::SerializeDomParam): (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::postActionAfterSerializeOpenTag): (WebKit::WebPageSerializerImpl::preActionBeforeSerializeEndTag): (WebKit::WebPageSerializerImpl::postActionAfterSerializeEndTag): (WebKit::WebPageSerializerImpl::saveHTMLContentToBuffer): (WebKit::WebPageSerializerImpl::openTagToString): (WebKit::WebPageSerializerImpl::endTagToString): (WebKit::WebPageSerializerImpl::buildContentForNode): (WebKit::WebPageSerializerImpl::WebPageSerializerImpl): (WebKit::WebPageSerializerImpl::collectTargetFrames): (WebKit::WebPageSerializerImpl::serialize):
- src/WebPageSerializerImpl.h: Added.
- src/WebString.cpp: (WebKit::WebString::WebString): (WebKit::WebString::operator=):
- src/WebViewImpl.cpp:
- 11:14 Changeset [52267] by
-
2009-12-17 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
[GTK] Don't assume downloads are always synchronous
http://bugs.webkit.org/show_bug.cgi?id=32359
- tests/testdownload.c: (download_requested_cb): (set_filename): (test_webkit_download_perform): (test_webkit_download_synch): (test_webkit_download_asynch): (main): Test downloads synchronously and asynchronously.
- webkit/webkitwebview.cpp: (webkit_web_view_class_init): (webkit_web_view_request_download): Only try to start a requested download if the destination URI is set and clarify the documentation.
- 11:13 Changeset [52266] by
-
Merge branch 'bug/26304' into staging
- 11:12 Changeset [52265] by
-
Sync JavaScriptCore.vcproj with JavaScriptCore.xcodeproj and the source tree
Fixes <http://webkit.org/b/32665>.
Reviewed by Ada Chan.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Moved
around files and filters so that the structure matches
JavaScriptCore.xcodeproj and the source tree. A few headers that were
previously omitted have been added, as well as JSZombie.{cpp,h}.
- 11:12 Changeset [52264] by
-
Remove HeavyProfile and TreeProfile completely
These were mostly removed in r42808, but the empty files were left in
place.
Fixes <http://webkit.org/b/32664>.
Reviewed by John Sullivan.
- Android.mk:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCoreSources.bkl:
Removed HeavyProfile/TreeProfile source files.
- profiler/HeavyProfile.cpp: Removed.
- profiler/HeavyProfile.h: Removed.
- profiler/TreeProfile.cpp: Removed.
- profiler/TreeProfile.h: Removed.
- 11:12 Changeset [52263] by
-
Remove WebKit.sln's Debug_All and Debug_Internal configurations
These configurations aren't buildable by people outside of Apple, and
Apple doesn't use this solution file.
Fixes <http://webkit.org/b/31000> Windows WebKit Build Configuration
should default to Debug instead of Debug_all.
Rubber-stamped by Dan Bernstein.
- WebKit.vcproj/WebKit.sln:
- 11:09 Changeset [52262] by
-
2009-12-17 Christian Dywan <christian@twotoasts.de>
Reviewed by Xan Lopez.
Deprecate the title-changed signal of WebKitWebFrame.
- webkit/webkitwebframe.cpp: (webkit_web_frame_class_init):
- 10:39 Changeset [52261] by
-
2009-12-17 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] support navigator.onLine and ononline/onoffline events.
https://bugs.webkit.org/show_bug.cgi?id=32555
Hooked up Bearer Management to NetworkStateNotifier. This solution is available
only if QtMobility's Bearer Management is installed.
- WebCore.pro:
- platform/network/NetworkStateNotifier.h:
- platform/network/qt/NetworkStateNotifierPrivate.h: Added.
- platform/network/qt/NetworkStateNotifierQt.cpp: Added. (WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate): (WebCore::NetworkStateNotifierPrivate::onlineStateChanged): (WebCore::NetworkStateNotifierPrivate::~NetworkStateNotifierPrivate): (WebCore::NetworkStateNotifier::updateState): (WebCore::NetworkStateNotifier::NetworkStateNotifier):
- 10:25 Changeset [52260] by
-
2009-12-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Switch to 11px as default for source-code in WebKit.
- inspector/front-end/inspector.css:
- 09:57 Changeset [52259] by
-
[Qt] Symbian build fix: Don't include QtXml/qxmlstream.h but omit the prefix, to
make sure we pick up the header file from QtCore. That is where the implementation
is compiled.
Reviewed by Tor Arne Vestbø.
- dom/XMLTokenizer.h:
- 09:44 Changeset [52258] by
-
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Implement GRefPtr, a smart pointer for reference counted GObject types.
- GNUmakefile.am:
- wtf/gtk/GOwnPtr.cpp: (WTF::GDir):
- wtf/gtk/GRefPtr.h: Added. (WTF::): (WTF::GRefPtr::GRefPtr): (WTF::GRefPtr::~GRefPtr): (WTF::GRefPtr::clear): (WTF::GRefPtr::get): (WTF::GRefPtr::operator*): (WTF::GRefPtr::operator->): (WTF::GRefPtr::operator!): (WTF::GRefPtr::operator UnspecifiedBoolType): (WTF::GRefPtr::hashTableDeletedValue): (WTF::::operator): (WTF::::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr): (WTF::adoptGRef): (WTF::refGPtr): (WTF::derefGPtr):
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Add GRefPtr support for GTK types to WebCore, as JSC does not link against
GTK+. Also convert PopupMenu::m_poup from a raw pointer to a GRefPtr.
No new tests as functionality has not changed.
- GNUmakefile.am:
- platform/PopupMenu.h:
- platform/gtk/GRefPtrGtk.cpp: Added. (WTF::refGPtr): (WTF::derefGPtr):
- platform/gtk/GRefPtrGtk.h: Added.
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::menuRemoveItem):
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Convert a use of GOwnPtr for a reference counted type to GRefPtr.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin):
- 09:21 Changeset [52257] by
-
2009-12-17 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Add support for mocking touch events with Q(GV)Launcher
https://bugs.webkit.org/show_bug.cgi?id=32434
The event delivery should go through QCoreApplication::sendEvent()
- QtLauncher/main.cpp: (MainWindow::sendTouchEvent):
- 09:09 Changeset [52256] by
-
2009-12-17 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
[Qt] Add support for touch events in QWebView and QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=32432
- Api/qgraphicswebview.cpp: (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebView::sceneEvent):
- Api/qwebview.cpp: (QWebView::QWebView): (QWebView::event):
- 09:06 Changeset [52255] by
-
2009-12-17 Yury Semikhatsky <yurys@chromium.org>
Reviewed by David Levin.
Provide explicit implementation of 'non-template' WebVector<T>::operator=
- public/WebVector.h:
- 07:56 Changeset [52254] by
-
2009-12-17 Evan Martin <evan@chromium.org>
Reviewed by Xan Lopez.
Expose the page workarounds ("quirks") setting to the GTK+ WebKit API.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings):
- 07:34 Changeset [52253] by
-
2009-12-17 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Advice links to source code in CPU profiler to open in debugger,
not in resources tab.
Also work around the case when resources are disabled, but scripts are present.
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.updateMainViewWidth): (WebInspector.Panel.prototype.canShowSourceLineForURL): (WebInspector.Panel.prototype.showSourceLineForURL):
- inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.createCell):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLineForURL): (WebInspector.ResourcesPanel.prototype.showSourceLineForURL):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.scriptForURL): (WebInspector.ScriptsPanel.prototype.canShowSourceLineForURL): (WebInspector.ScriptsPanel.prototype.showSourceLineForURL): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
- inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector._choosePanelToShowSourceLineForURL): (WebInspector.canShowSourceLineForURL): (WebInspector.showSourceLineForURL):
- 06:42 Changeset [52252] by
-
Skipping one test that needs overriding of standard preferences,
and a new one.
- platform/gtk/Skipped:
- 06:27 Changeset [52251] by
-
Reviewed by Xan Lopez.
[GTK] display FPS stats for video element
https://bugs.webkit.org/show_bug.cgi?id=32560
Display FPS statistics if WEBKIT_DEBUG environment variable
contains the Media log category. This feature requires a very
recent (>= 0.10.18) version of gst-plugins-bad.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- 06:01 Changeset [52250] by
-
2009-12-17 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
[Qt] Add support for mocking touch events with QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=32434
- QtLauncher/main.cpp: (MainWindow::MainWindow): (MainWindow::sendTouchEvent): (MainWindow::eventFilter): (MainWindow::setTouchMocking): (MainWindow::setupUI):
- 05:05 Changeset [52249] by
-
Reverting 52246 and 52248 because they crash tests.
- 04:46 QtWebKitBackportingFixes edited by
- (diff)
- 04:43 QtWebKitContrib edited by
- (diff)
- 04:43 QtWebKitReleases edited by
- (diff)
- 04:41 QtWebKitReleases created by
- 04:31 QtWebKitBackportingFixes edited by
- (diff)
- 04:30 Changeset [52248] by
-
Build fix. Landing files I forgot to commit.
- 04:13 Changeset [52247] by
-
2009-12-16 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] segfault during volume notification
https://bugs.webkit.org/show_bug.cgi?id=32603
Emit volumeChanged and durationChanged upon notification from
GStreamer. Also don't reset the volume property on playbin, it is
not needed as it is 1.0 by default both on playbin and in the
MediaPlayer.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::notifyVolumeIdleCallback): (WebCore::doGstInit): (WebCore::MediaPlayerPrivate::isAvailable): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::durationChanged): (WebCore::mimeTypeCache): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2009-11-11 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] Should emit {networkState,readyState,volume,time,size,rate,duration}Changed signals
https://bugs.webkit.org/show_bug.cgi?id=30377
Emit volumeChanged and durationChanged upon notification from
GStreamer.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::mediaPlayerPrivateVolumeCallback): (WebCore::notify_volume_idle_cb): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::durationChanged): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- 04:02 Changeset [52246] by
-
WebCore
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Add GRefPtr support for GTK types to WebCore, as JSC does not link against
GTK+. Also convert PopupMenu::m_poup from a raw pointer to a GRefPtr.
No new tests as functionality has not changed.
- GNUmakefile.am:
- platform/PopupMenu.h:
- platform/gtk/GRefPtrGtk.cpp: Added. (WTF::refGPtr): (WTF::derefGPtr):
- platform/gtk/GRefPtrGtk.h: Added.
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::menuRemoveItem):
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Implement GRefPtr, a smart pointer for reference counted GObject types.
- GNUmakefile.am:
- wtf/gtk/GOwnPtr.cpp: (WTF::GDir):
- wtf/gtk/GRefPtr.h: Added. (WTF::): (WTF::GRefPtr::GRefPtr): (WTF::GRefPtr::~GRefPtr): (WTF::GRefPtr::clear): (WTF::GRefPtr::get): (WTF::GRefPtr::operator*): (WTF::GRefPtr::operator->): (WTF::GRefPtr::operator!): (WTF::GRefPtr::operator UnspecifiedBoolType): (WTF::GRefPtr::hashTableDeletedValue): (WTF::::operator): (WTF::::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr): (WTF::adoptGRef): (WTF::refGPtr): (WTF::derefGPtr):
WebKit/gtk
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Convert a use of GOwnPtr for a reference counted type to GRefPtr.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin):
- 03:48 Changeset [52245] by
-
2009-12-17 Evan Martin <evan@chromium.org>
Reviewed by Xan Lopez.
gtk: always use standard include paths, regardless of settings.
WebKit style is to wrap the body of a header in #if ENABLE(FOO),
so they're always safe to include whether the features are enabled or
not.
This fixes building with --disable-database and other flags.
- GNUmakefile.am:
- 03:33 Changeset [52244] by
-
Unreviewed. Build fixes for make distcheck.
- 03:14 Changeset [52243] by
-
Rubber-stamped by Gustavo Noronha Silva.
Trivial WebKit coding style fix.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint):
- 00:27 Changeset [52242] by
-
2009-12-17 Adam Barth <abarth@webkit.org>
Rubber stamp by Seidel.
Clean up exception handling in WorkQueue. Basically, a bunch of the
delegate messages can throw exceptions because of network errors. We
want the queues to keep on ticking instead of erroring out. That means
we want to catch generic exceptions and continue looping.
Also, cleaned up the exception handling in the EWS to properly log
failures.
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/workqueue.py:
12/16/09:
- 23:52 Changeset [52241] by
-
2009-12-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Make UpdateStep quiet
https://bugs.webkit.org/show_bug.cgi?id=32599
- Scripts/modules/buildsteps.py:
- Scripts/modules/buildsteps_unittest.py:
- 23:41 Changeset [52240] by
-
2009-12-16 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Add Gtk to the early warning system WebKit port list.
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/webkitport.py:
- Scripts/modules/webkitport_unittest.py:
- 23:40 Changeset [52239] by
-
2009-12-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
post-diff is failing with exception under guess_reviewer_from_bug
https://bugs.webkit.org/show_bug.cgi?id=32642
Also refactor output capturing code into
OutputCapture.assert_outputs to share more code between tests.
- Scripts/modules/buildsteps.py:
- Add the missing include.
- Give guess_reviewer_from_bug a private underscore.
- Scripts/modules/buildsteps_unittest.py: Added.
- Test to make sure _guess_reviewer_from_bug works as expected.
- Scripts/modules/commands/commandtest.py:
- Custom code is now obsoleted by OutputCapture.assert_outputs
- Scripts/modules/commands/queues_unittest.py:
- ditto
- Scripts/modules/credentials_unittest.py:
- ditto
- Scripts/modules/mock_bugzillatool.py:
- fetch_reviewed_patches_from_bug can never return None
- Scripts/modules/multicommandtool_unittest.py:
- Custom code is now obsoleted by OutputCapture.assert_outputs
- Scripts/modules/outputcapture.py:
- Add assert_outputs to share more code between tests.
- Scripts/run-webkit-unittests:
- Add buildsteps_unittest.py
- Scripts/modules/buildsteps.py:
- 23:37 Changeset [52238] by
-
2009-12-16 Adam Barth <abarth@webkit.org>
Unreviewed. Added a default argument to _update_status so that callers
don't have to explictly pass None when they don't have a patch object.
- Scripts/modules/commands/queues.py:
- 23:17 Changeset [52237] by
-
Unreviewed, build fix.
[Chromium] Add EditableTextRole to catch up with
http://trac.webkit.org/changeset/52233
- public/WebAccessibilityRole.h:
(WebKit::): Added WebAccessibilityRoleEditableText
- src/AssertMatchingEnums.cpp: Added matching compile assert.
- 23:05 Changeset [52236] by
-
[Qt] Put test into skiplist because of missing layoutTestController.setSmartInsertDeleteEnabled().
- platform/qt/Skipped: editing/selection/doubleclick-beside-cr-span.html added.
- 22:30 Changeset [52235] by
-
2009-12-15 MORITA Hajime <morrita@gmail.com>
Reviewed by Eric Seidel.
Bug 28306: double-clicking a word inside <b> beside newline select two words
https://bugs.webkit.org/show_bug.cgi?id=28306
SimplifiedBackwardsTextIterator missed trailing whitespaces just
before folding line-break, which is used to detect word
boundaries. This fix checks strings on RenderText and expand text
range on SimplifiedBackwardsTextIterator to include trailing
whitespaces if availble.
Test: editing/selection/doubleclick-beside-cr-span.html
- editing/TextIterator.cpp: (WebCore::collapsedSpaceLength): (WebCore::maxOffsetIncludingCollapsedSpaces): (WebCore::SimplifiedBackwardsTextIterator::advance):
2009-12-16 MORITA Hajime <morrita@gmail.com>
Reviewed by Eric Seidel.
Bug 28306: double-clicking a word inside <b> beside newline select two words
https://bugs.webkit.org/show_bug.cgi?id=28306
SimplifiedBackwardsTextIterator missed trailing whitespaces just
before folding line-break, which is used to detect word
boundaries. This fix checks strings on RenderText and expand text
range on SimplifiedBackwardsTextIterator to include trailing
whitespaces if availble.
- editing/selection/doubleclick-beside-cr-span-expected.txt: Added.
- editing/selection/doubleclick-beside-cr-span.html: Added.
- 22:19 Changeset [52234] by
-
2009-12-16 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix flakiness in WebSocket handshake console message.
https://bugs.webkit.org/show_bug.cgi?id=32598
In chromium, LayoutTests/websocket/tests/handshake-error.html is
flaky, because it outputs the following console message several times:
CONSOLE MESSAGE: line 0: Unexpected response code:101
Update m_mode in WebSocketHandshake correctly: Once it finds
error in handshake message, set m_mode to Failed and don't try
reading handshake message again. If handshake message is not yet
fully received, set m_mode to Incomplete, so next didReceiveData()
will try to check handshake message again.
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake):
- 21:58 Changeset [52233] by
-
2009-12-16 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: Accessibility role of text nodes is wrong
https://bugs.webkit.org/show_bug.cgi?id=32631
<rdar://problem/7369084>
Reviewed by Alice Liu.
Test: platform/win/accessibility/text-role.html
WebCore/:
- accessibility/AccessibilityObject.h: (WebCore::): Add a new role to the enum. (WebCore::AccessibilityObject::roleValueForMSAA): Declare a function to return the accessibility role for MSAA; the base implementation returns the old role value.
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::AccessibilityRenderObject): Initialize m_roleForMSAA. (WebCore::AccessibilityRenderObject::roleValueForMSAA): If m_roleForMSAA has been set, return it. If the renderer is a RenderText, set the role to EditableTextRole to match IE and Firefox. Otherwise, set the role for MSAA to the old role value.
- accessibility/AccessibilityRenderObject.h: Add a member to hold the role for MSAA, and declare an override of roleValueForMSAA().
WebKit/win/:
- AccessibleBase.cpp: (MSAARole): If the role is WebCore::EditableTextRole, return ROLE_SYSTEM_TEXT. (AccessibleBase::role): Call roleValueForMSAA().
LayoutTests/:
- platform/win/accessibility/text-role-expected.txt: Added.
- platform/win/accessibility/text-role.html: Added. Check that the role of the text node that is the first child of the <a> tag has the "editable text" role.
- 21:30 Changeset [52232] by
-
2009-12-16 Kent Tamura <tkent@chromium.org>
Reviewed by David Levin.
check-webkit-style supports for TAB check against text files.
https://bugs.webkit.org/show_bug.cgi?id=32538
- Scripts/check-webkit-style: Move process_patch() to style.py.
- Scripts/modules/cpp_style.py: Add can_handle().
- Scripts/modules/cpp_style_unittest.py: Add tests for can_handle().
- Scripts/modules/style.py: Added. This is a front-end of cpp_style and text_style. It dispatches files to an appropriate linter.
- Scripts/modules/text_style.py: Added. This is a linter module for generic text files. It supports only for TAB checking at this moment.
- Scripts/modules/text_style_unittest.py: Added. Tests for text_style.py.
- Scripts/run-webkit-unittests: Add text_style_unittest.
- 19:50 Changeset [52231] by
-
Fixed <rdar://problem/7355025> Interpreter::privateExecute macro generates
bloated code
Reviewed by Oliver Hunt.
This patch cuts Interpreter stack use by about a third.
- bytecode/Opcode.h: Changed Opcode to const void* to work with the
const static initiliazation we want to do in Interpreter::privateExecute.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter): Moved hashtable initialization here to
avoid polluting Interpreter::privateExecute's stack, and changed it from a
series of add() calls to one add() call in a loop, to cut down on code size.
(JSC::Interpreter::privateExecute): Changed a series of label computations
to a copy of a compile-time constant array to cut down on code size.
- 16:44 Changeset [52230] by
-
2009-12-16 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Darin Adler.
Fix LayoutTests/websocket/tests/url-with-query-for-no-query.html
https://bugs.webkit.org/show_bug.cgi?id=32606
It should test with /websocket/tests/no-query
- websocket/tests/script-tests/url-with-query-for-no-query.js:
- websocket/tests/url-with-query-for-no-query-expected.txt:
- 16:41 Changeset [52229] by
-
2009-12-16 Eric Seidel <eric@webkit.org>
No review, rolling out r52206.
http://trac.webkit.org/changeset/52206
https://bugs.webkit.org/show_bug.cgi?id=31187
This broke pixel tests on Mac. Presumably the code in
ImageCG is wrong here.
- platform/graphics/BitmapImage.h:
- platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
- platform/graphics/GeneratedImage.h:
- platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
- platform/graphics/Image.h:
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
- platform/graphics/haiku/ImageHaiku.cpp: (WebCore::Image::drawPattern):
- platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::Image::drawPattern):
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::drawBitmapPattern):
- platform/graphics/wince/ImageBufferWince.cpp: (WebCore::): (WebCore::BufferedImage::drawPattern):
- platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::drawPattern): (WebCore::Image::drawPattern):
- 16:40 Changeset [52228] by
-
2009-12-16 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
bugzilla-tool should not require users to install mechanize
https://bugs.webkit.org/show_bug.cgi?id=32635
Centralize our import logic.
- Scripts/modules/bugzilla.py: use webkit_mechanize
- Scripts/modules/statusbot.py: use webkit_mechanize
- Scripts/modules/webkit_mechanize.py: Added.
- 16:31 Changeset [52227] by
-
[Qt] editing/selection/empty-cell-right-click.html introduced in r52220 failed.
https://bugs.webkit.org/show_bug.cgi?id=32639
Test was refactored by r52226, and now it passes.
- platform/qt/Skipped: unskip editing/selection/empty-cell-right-click.html.
- 16:15 Changeset [52226] by
-
Revised version of the test for:
<rdar://problem/5565465
https://bugs.webkit.org/show_bug.cgi?id=32622
Reviewed by Adele Peterson.
- editing/selection/empty-cell-right-click-expected.txt:
- editing/selection/empty-cell-right-click.html:
- 16:07 Changeset [52225] by
-
Rubber-stamped by Simon Hausmann.
[Qt] editing/selection/empty-cell-right-click.html introduced in r52220 failed.
https://bugs.webkit.org/show_bug.cgi?id=32639
- platform/qt/Skipped: editing/selection/empty-cell-right-click.html added until fix.
- 16:03 Changeset [52224] by
-
2009-12-16 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=32637
[V8] Generate most named property getters.
Covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm: Added generation of SetNamedPropertyHandler call.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed now-generated SetNamedPropertyHandler callsites.
- 15:52 Changeset [52223] by
-
2009-12-16 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement combobox delegate for Qt
https://bugs.webkit.org/show_bug.cgi?id=32550
Abstract popup menu factory.
A static method from QtAbstractPopupMenu is used to create its instances. If a factory
has been suplied to class QtAbstractPopupMenu the factory will be used to create the
objects. If not an instance of QtFallbackPopupMenu will be created.
The objective is to make it easy to replace the combobox popup at WebCore layer providing
support to the combobox popup delegation API. Future patches will make it possible to
replace the combobox popup at WebKit layer.
No behavior changes.
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu):
- platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::setFactory): (WebCore::QtAbstractWebPopup::create):
- platform/qt/QtAbstractWebPopup.h:
- platform/qt/QtFallbackWebPopup.cpp:
- 15:39 Changeset [52222] by
-
Build fix. Disable debug variants of WebKit frameworks.
- 14:19 Changeset [52221] by
-
2009-12-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Generalize commit-queue recent status page for all queues
https://bugs.webkit.org/show_bug.cgi?id=32633
- QueueStatusServer/index.html:
- Generalize to support other queues.
- QueueStatusServer/queue_status.py:
- Generalize MainPage to support other queues.
- QueueStatusServer/index.html:
- 14:02 Changeset [52220] by
-
WebCore: Right clicking in a table cell creates a selection that extends into the next cell.
<rdar://problem/5565465>
https://bugs.webkit.org/show_bug.cgi?id=32622
Reviewed by Eric Seidel.
Avoid extending the selection to the next cell if we start from an empty cell.
Test: editing/selection/empty-cell-right-click.html
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Replaced the code that check for empty table cell
with a call to the new function.
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity): Extends the
selection only if we are not starting from an empty table cell.
- editing/htmlediting.cpp:
(WebCore::isEmptyTableCell): Added a function since this check is performed now in two places.
- editing/htmlediting.h: Added isEmptyTableCell declaration.
LayoutTests: Right clicking in a table cell creates a selection that extends into the next cell.
<rdar://problem/5565465>
https://bugs.webkit.org/show_bug.cgi?id=32622
Reviewed by Eric Seidel.
- editing/selection/empty-cell-right-click-expected.txt: Added.
- editing/selection/empty-cell-right-click.html: Added.
- 13:56 Changeset [52219] by
-
2009-12-16 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
feMerge crahses if feMergeNodes attribute in is empty
https://bugs.webkit.org/show_bug.cgi?id=32489
The previous test only checked if feMerge works on empty node
without a last effect. In this case we get a source image and
everything works fine. This test also covers the case if there
is a last effect.
- platform/mac/svg/custom/empty-merge-expected.checksum:
- platform/mac/svg/custom/empty-merge-expected.png:
- platform/mac/svg/custom/empty-merge-expected.txt:
- svg/custom/empty-merge.svg:
2009-12-16 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
feMerge crahses if feMergeNodes attribute in is empty
https://bugs.webkit.org/show_bug.cgi?id=32489
SVGFEMergeElement only stored pointers to all effects of it's nodes
in a list. But it should store the RefPtr otherwise the effects get
dereferenced and WebKit crashes.
I also made a short clean-up in SVGFilterBuilder. No change in
functionality.
Test: I updated svg/custom/empty-merge.svg to cover this problem.
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
- svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::FEMerge): (WebCore::FEMerge::create): (WebCore::FEMerge::mergeInputs): (WebCore::FEMerge::setMergeInputs):
- svg/graphics/filters/SVGFEMerge.h:
- svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::SVGFilterBuilder::add):
- 13:24 Changeset [52218] by
-
2009-12-16 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Early warning system server should display output as UTF-8.
- QueueStatusServer/queue_status.py:
- 13:17 Changeset [52217] by
-
Part of <http://webkit.org/b/32568>.
Web Inspector: Context Menus should be used in more places.
Reviewed by Timothy Hatcher.
Add a context menu entry in the console to clear the console. This
is only shown when there is no user selection of text, because if
there is selection of the text, then we want to give the user the Copy +
Spell Check context menu that they are used to.
- English.lproj/localizedStrings.js: Added "Clear Console".
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._handleContextMenuEvent):
- 13:17 Changeset [52216] by
-
2009-12-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Add error handling to the early warning system
https://bugs.webkit.org/show_bug.cgi?id=32594
This should be the last step in making the EWS operational. When we
have a build error, we post the log to QueueStatusServer and add a link
to the bug.
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/executive.py:
- 13:15 Changeset [52215] by
-
2009-12-16 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
Deprecate the old loading signals load-started, load-committed,
load-finished, load-progress-changed and change unit tests to use
load-status instead.
- tests/testmimehandling.c: (idle_quit_loop_cb): (test_mime_type): use notify::load-status
- tests/testwebdatasource.c: (notify_load_status_unreachable_cb): (notify_load_status_cb): (test_webkit_web_data_source): (test_webkit_web_data_source_unreachable_uri): Remove uses of g_main_loop_is_running. It's an error if the loop is wrongly terminated.
- tests/testwebresource.c: (notify_load_status_cb): (test_web_resource_loading): (notify_load_status_sub_cb): (test_web_resource_sub_resource_loading): use notify::load-status
- tests/testwebview.c: (idle_quit_loop_cb): (test_webkit_web_view_icon_uri):
- tests/testwindow.c: (notify_load_status_cb): (test_webkit_window_scrollbar_policy): use notify::load-status
- webkit/webkitwebframe.cpp: (webkit_web_frame_class_init):
- webkit/webkitwebview.cpp: (webkit_web_view_class_init): Deprecate old load signals.
- 12:59 Changeset [52214] by
-
Fixes <https://bugs.webkit.org/show_bug.cgi?id=32621>.
Web Inspector: [REGRESSION (52095-52100)] Resources filter disappears when switching
from / to resources panel.
Reviewed by Pavel Feldman.
Changed style in sidebar-resizer-vertical, because if the min-height was 100%, we start
to cover the scope bar.
- inspector/front-end/inspector.css:
- 12:14 Changeset [52213] by
-
2009-12-16 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adam Barth.
[V8] Switch all indexers to be generated.
https://bugs.webkit.org/show_bug.cgi?id=32569
Covered by existing tests.
- WebCore.gypi: Remove V8FileListCustom.cpp and V8ClientRecListCustom.cpp,
as they are now generated.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Remove customization of ClientRectList,
FileList, and DataGridColumnList templates.
- bindings/v8/custom/V8ClientRectListCustom.cpp: Removed.
- bindings/v8/custom/V8CustomBinding.h: Remove custom indexer getter decls.
- bindings/v8/custom/V8DataGridColumnListCustom.cpp: Remove indexer getter definition.
- bindings/v8/custom/V8FileListCustom.cpp: Removed.
- 11:34 Changeset [52212] by
-
2009-12-16 anton muhin <antonm@chromium.org>
Reviewed by Darin Adler.
[dom] make dom/Node.cpp compile if DUMP_NODE_STATISTICS is on
https://bugs.webkit.org/show_bug.cgi?id=32617
- dom/Node.cpp: (WebCore::Node::dumpStatistics):
- 11:25 Changeset [52211] by
-
2009-12-16 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Fisher.
[V8] There is no such thing as HTMLSelectElementCollection.
https://bugs.webkit.org/show_bug.cgi?id=32616
Refactoring, covered by existing tests.
- WebCore.gypi: Removed V8HTMLSelectElementCollectionCustom.cpp
- bindings/v8/V8Collection.h: Removed one-off template.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Renamed all references to HTMLSelectElementCollection
to HTMLSelectElement.
- bindings/v8/custom/V8CustomBinding.h: Renamed custom indexer decls.
- bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Removed.
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp: Moved code as-is from
V8HTMLSelectElementCollectionCustom.cpp
- 11:20 Changeset [52210] by
-
Fixing bug number in ChangeLog
- 11:15 Changeset [52209] by
-
Brought this file up to date, sans review.
- StringsNotToBeLocalized.txt:
- 11:14 Changeset [52208] by
-
2009-12-16 Dan Winship <danw@gnome.org>
Reviewed by Gustavo Noronha Silva.
[Gtk] Content-Encoding support
- configure.ac: require libsoup 2.28.2 for SoupContentDecoder
2009-12-16 Dan Winship <danw@gnome.org>
Reviewed by Gustavo Noronha Silva.
[Gtk] Content-Encoding support
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp): Don't force "Accept-Encoding: identity" any more
2009-12-16 Dan Winship <danw@gnome.org>
Reviewed by Gustavo Noronha Silva.
Content-Encoding support
- webkit/webkitprivate.cpp: (webkit_init): add a SoupContentDecoder feature to the session
- 11:03 Changeset [52207] by
-
2009-12-16 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
Take into account favicon.ico in the webresource test.
- tests/testwebresource.c: (test_web_resource_sub_resource_loading):
- 11:00 Changeset [52206] by
-
2009-12-16 Benjamin Otte <otte@gnome.org>
Reviewed by Darin Adler.
Get rid of the phase argument to Image::drawPattern.
https://bugs.webkit.org/show_bug.cgi?id=31187
The argument can be expressed equally well as part of the
patternTransform. All backends but the Qt one did exactly that
manually anyway.
- platform/graphics/BitmapImage.h:
- platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
- platform/graphics/GeneratedImage.h:
- platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
- platform/graphics/Image.h:
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
- platform/graphics/haiku/ImageHaiku.cpp: (WebCore::Image::drawPattern):
- platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::Image::drawPattern):
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::drawBitmapPattern):
- platform/graphics/wince/ImageBufferWince.cpp: (WebCore::): (WebCore::BufferedImage::drawPattern):
- platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::drawPattern): (WebCore::Image::drawPattern):
- 10:50 Changeset [52205] by
-
2009-12-16 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Performance problems with index validation code for drawElements
https://bugs.webkit.org/show_bug.cgi?id=32466
Added a cache of the maximum index for each element type to
WebGLBuffer, querying it before iterating through the indices in
the client-side copy of the buffer's data. Hoisted checks of the
size of the element array itself into validateElementArraySize to
avoid duplicating code.
The performance improvement has been measured with manual tests.
Existing layout tests cover the index validation functionality
and continue to pass as before.
- html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::WebGLBuffer): (WebCore::WebGLBuffer::associateBufferData): (WebCore::WebGLBuffer::associateBufferSubData): (WebCore::WebGLBuffer::getCachedMaxIndex): (WebCore::WebGLBuffer::setCachedMaxIndex): (WebCore::WebGLBuffer::clearCachedMaxIndices):
- html/canvas/WebGLBuffer.h:
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateElementArraySize): (WebCore::WebGLRenderingContext::validateIndexArrayConservative): (WebCore::WebGLRenderingContext::validateIndexArrayPrecise): (WebCore::WebGLRenderingContext::validateRenderingState): (WebCore::WebGLRenderingContext::drawElements):
- html/canvas/WebGLRenderingContext.h:
- 10:43 Changeset [52204] by
-
2009-12-16 Zelidrag Hornung <zelidrag@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32261
Added ability to separate the autocomplete suggestion previewing from
the actual accepting of the suggested value in HTMLInputElement.
This element (it's single line text incarnation) can now
be put in suggestion mode where renderer might display the suggested
value without making it automatically exposed to JavaScript.
No new tests. This new methods are not exposed yet. It's use will be
platform specific. PopupMenu and Chromium specific changes will be
separated based on Darin Adler's comments.
- dom/InputElement.h: (WebCore::InputElementData::suggestedValue): (WebCore::InputElementData::setSuggestedValue):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::suggestedValue): (WebCore::HTMLInputElement::setSuggestedValue): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer):
- html/HTMLInputElement.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::updateFromElement):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::suggestedValue):
- wml/WMLInputElement.h:
- 10:24 Changeset [52203] by
-
2009-12-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Make Elements tree, properties section and resources
view monospace.
- inspector/front-end/ElementsPanel.js:
- inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView):
- inspector/front-end/inspector.css:
- 10:12 Changeset [52202] by
-
2009-12-16 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
sourceGraphic wrong if positive x,y is >0 and objectBB is selected on Filter
https://bugs.webkit.org/show_bug.cgi?id=32575
Check if the GraphicsContex get adjusted, if the source rect is clipped
to the filter rect.
- platform/mac/svg/filters/filter-source-position-expected.checksum: Added.
- platform/mac/svg/filters/filter-source-position-expected.png: Added.
- platform/mac/svg/filters/filter-source-position-expected.txt: Added.
- svg/filters/filter-source-position.svg: Added.
2009-12-16 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
sourceGraphic wrong if positive x,y is >0 and objectBB is selected on Filter
https://bugs.webkit.org/show_bug.cgi?id=32575
On SVG Filters, the rest of the source graphic gets clipped to the filter
rest. This helps us to minimize the size of intermediate ImageBuffers. If
the position moves to the right or to the bottom, we have to adjust the
GraphicContext of this intermediate ImageBuffer.
This patch fixes the adjustment of the context, according to the clipping.
Test: svg/filters/filter-source-position.svg
- svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::prepareFilter):
- 09:59 Changeset [52201] by
-
CrashTracer: [USER] 1 crash in Safari at com.apple.WebCore: WebCore::endsOfNodeAreVisuallyDistinctPositions + 115
<rdar://problem/7467108>
https://bugs.webkit.org/show_bug.cgi?id=32590
Reviewed by Adele Peterson.
WebCore:
If the element is a button there is no need to look at the children to calculate the caret position.
Test: editing/selection/button-right-click.html
- dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset): Avoid calling recursively this method,
when starting from a button element.
LayoutTests:
- editing/selection/button-right-click-expected.txt: Added.
- editing/selection/button-right-click.html: Added.
- 09:37 Changeset [52200] by
-
Rubber-stamped by Xan Lopez.
Add tab_key_cycles_through_elements to copies of
WebKitWebSettings.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_copy):
- 09:27 Changeset [52199] by
-
2009-12-16 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement combobox delegate for Qt
https://bugs.webkit.org/show_bug.cgi?id=32550
Refactoring of class QWebPopup.
Class QWebPopup has been split in QtAbstractWebPopup and QtFallbackWebPopup.
Both new classes are now in corresponding files and files QWebPopup.* have been removed.
Custom combo popup classes will inherit from QtAbstractWebPopup. It is not the public API as it is
in WebCore and will not be visible by users of QtWebKit. It will be used in implementation of
public QtWebKit combobox popup delegation API.
Class QtFallbackWebPopup inherits from QtAbstractWebPopup and implements the currently used combobox popup.
It needs to be improved to provide standard features that are missing like style or indentation.
No behavior changes.
- WebCore.pro:
- platform/PopupMenu.h:
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu):
- platform/qt/QWebPopup.cpp: Removed.
- platform/qt/QWebPopup.h: Removed.
- platform/qt/QtAbstractWebPopup.cpp: Added. (WebCore::QtAbstractWebPopup::QtAbstractWebPopup): (WebCore::QtAbstractWebPopup::~QtAbstractWebPopup): (WebCore::QtAbstractWebPopup::client):
- platform/qt/QtAbstractWebPopup.h: Added.
- platform/qt/QtFallbackWebPopup.cpp: Added. (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate): (WebCore::QtFallbackWebPopup::showPopup): (WebCore::QtFallbackWebPopup::hidePopup): (WebCore::QtFallbackWebPopup::activeChanged):
- platform/qt/QtFallbackWebPopup.h: Added. (WebCore::QtFallbackWebPopup::hide):
- 09:04 Changeset [52198] by
-
2009-12-16 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] webkit_web_navigation_action_get_button() documentation
https://bugs.webkit.org/show_bug.cgi?id=25555
Small documentation improvement for webkit_web_navigation_action_get_button.
- webkit/webkitwebnavigationaction.cpp:
- 06:21 Changeset [52197] by
-
Rubber-stamped by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=31332
[Qt] After http://trac.webkit.org/changeset/52192
there are a failing and a timeouter test.
- platform/qt/Skipped: http/tests/misc/drag-over-iframe-invalid-source-crash.html added until fix.
- platform/qt/fast/text/international/khmer-selection-expected.txt: update outdated expected.
- 06:02 QtWebKit/CodeCamp200912 edited by
- Update day2 and day3 (diff)
- 05:57 QtWebKit/CodeCamp200912 edited by
- link to the presentation to freya and mozAfterPaint (diff)
- 05:54 QtWebKit/CodeCamp200912 edited by
- Update performance day 1 summary (diff)
- 02:42 Changeset [52196] by
-
Rubber-stamped by Simon Hausmann.
[Qt] http://trac.webkit.org/changeset/52194 fixed a side-effect
of DumpRenderTree. The previously wrong expected file updated.
- platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt: updated.
- 02:25 Changeset [52195] by
-
Skipping a new test, and a test that fails only on the release bot,
apparently because of rouding errors.
- platform/gtk/Skipped:
- 02:06 Changeset [52194] by
-
WebKitTools: Fix crash with tests that use custom font faces.
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=32600
In the DRT we call QApplication::removeAllApplicationFonts(), to make sure
that custom font faces between tests don't influence each other. Calling this
function in Qt however also invalidates all existing handles with QFontDatabase.
In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(),
which implies a call to WebCore::FontCache::fontCache()->invalidate().
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
LayoutTests: [Qt] Unskip fast/css/font-face-multiple-families.html.
Reviewed by Holger Freyther.
- platform/qt/Skipped:
- 02:05 Changeset [52193] by
-
2009-12-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: beautify HTTP info section.
- English.lproj/localizedStrings.js:
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._refreshURL): (WebInspector.ResourceView.prototype._refreshHTTPInformation):
- inspector/front-end/inspector.css:
- 01:54 Changeset [52192] by
-
2009-12-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Maintain button state between mouse events.
This allows eventSender to generate drag events.
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::mouseDown): (EventSender::mouseUp): (EventSender::mouseMoveTo):
- DumpRenderTree/qt/EventSenderQt.h:
- 01:52 Changeset [52191] by
-
Revert r52085, because it causes crashes on media tests in the release
bot.
- 01:41 QtWebKit edited by
- (diff)
- 01:09 QtWebKitContrib edited by
- (diff)
- 01:08 QtWebKit edited by
- (diff)
- 00:56 Changeset [52190] by
-
[Qt] fast/css/font-face-unused-source-loaded.html crashes
https://bugs.webkit.org/show_bug.cgi?id=32600
Reviewed by Simon Hausmann.
The crash caused by fast/css/font-face-multiple-families.html, added to skiplist until fix.
- platform/qt/Skipped: fast/css/font-face-multiple-families.html added.
- 00:53 QtWebKitTodo edited by
- (diff)
